00:11:47
|
*** evmw has joined #openmrs
|
00:12:00
|
*** evmw has joined #openmrs
|
00:44:09
|
*** evmw has quit IRC
|
00:51:33
|
*** evmw has joined #openmrs
|
00:59:32
|
*** mseaton has quit IRC
|
02:16:34
|
*** mseaton has joined #openmrs
|
02:16:34
|
*** ChanServ sets mode: +v mseaton
|
02:39:53
|
*** jkeiper has joined #openmrs
|
02:39:53
|
*** ChanServ sets mode: +v jkeiper
|
02:48:23
|
*** edcalip has joined #openmrs
|
02:53:10
|
*** edcalip has quit IRC
|
03:32:44
|
*** evmw has quit IRC
|
03:58:21
|
*** mseaton has quit IRC
|
04:10:11
|
*** jkeiper has quit IRC
|
04:17:31
|
*** djadmin has joined #openmrs
|
04:23:53
|
*** kishoreyekkanti has joined #openmrs
|
04:35:51
|
*** kishoreyekkanti has quit IRC
|
05:46:27
|
*** djadmin has quit IRC
|
06:07:38
|
*** djadmin has joined #openmrs
|
06:08:45
|
*** djadmin has quit IRC
|
06:19:54
|
*** vibhav_ has joined #openmrs
|
06:22:11
|
*** vibhav_ has quit IRC
|
06:39:51
|
*** djadmin has joined #openmrs
|
06:50:50
|
*** kishoreyekkanti has joined #openmrs
|
07:25:18
|
*** djadmin has quit IRC
|
07:54:29
|
*** Anuruddha has joined #openmrs
|
08:01:17
|
*** kishoreyekkanti has quit IRC
|
08:06:36
|
*** djazayeri has quit IRC
|
08:34:50
|
*** dkayiwa has joined #openmrs
|
08:47:03
|
*** dkayiwa has quit IRC
|
08:50:23
|
*** dkayiwa has joined #openmrs
|
09:00:05
|
*** harshadura has quit IRC
|
09:12:15
|
*** harshadura has joined #openmrs
|
09:14:28
|
*** k-joseph has joined #openmrs
|
09:15:03
|
*** djadmin has joined #openmrs
|
09:19:47
|
*** djadmin has quit IRC
|
09:40:32
|
<k-joseph> dkayiwa: hi
|
09:45:29
|
<dkayiwa> k-joseph: hi
|
09:46:13
|
<dkayiwa> k-joseph: your unit test naming does not seem to be in line with our convention
|
09:47:07
|
<dkayiwa> k-joseph: secondly, you need two tests: One where the method should return true and the other where the same method should return false
|
09:47:57
|
<k-joseph> dkayiwa: does it require me to add @should in Daemon class
|
09:48:34
|
<dkayiwa> k-joseph: you need to learn from what you have been doing in the past, before asking
|
09:49:03
|
<dkayiwa> k-joseph: just look at your past commits and you will understand
|
09:58:28
|
*** wyclif has quit IRC
|
10:08:09
|
<k-joseph> dkayiwa: http://pastebin.com/m8i09GGB
|
10:09:29
|
<dkayiwa> k-joseph: that looks better
|
10:09:50
|
<dkayiwa> k-joseph: do these tests pass?
|
10:10:03
|
<k-joseph> dkayiwa: yes they do pass
|
10:10:20
|
<dkayiwa> k-joseph: can you remind of the ticket number
|
10:10:46
|
<k-joseph> dkayiwa: TRUNK-3424
|
10:10:55
|
<dkayiwa> !ticket TRUNK-3424
|
10:10:56
|
<OpenMRSBot> dkayiwa: [#TRUNK-3424] Daemon.DAEMON_USER_UUID should be public - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3424
|
10:13:43
|
<dkayiwa> k-joseph: did you also add the javadoc that Burke suggests?
|
10:14:07
|
<k-joseph> dkayiwa: yes i did,
|
10:20:27
|
<dkayiwa> k-joseph: can you do a commit and i look at it?
|
10:20:42
|
<k-joseph> dkayiwa: ok
|
10:23:53
|
<dkayiwa> k-joseph: after you commit, look for another ticket and start working on it
|
10:24:55
|
<k-joseph> dkayiwa: ok,
|
10:31:34
|
<k-joseph> dkayiwa: commit at https://github.com/k-joseph/openmrs-core/commit/TRUNK-3424
|
10:31:39
|
<OpenMRSBot> <http://ln-s.net/+ZdN> (at github.com)
|
10:33:07
|
*** dkayiwa has quit IRC
|
10:38:49
|
*** dkayiwa has joined #openmrs
|
10:39:13
|
<dkayiwa> hi k-joseph
|
10:39:23
|
<k-joseph> dkayiwa: hi
|
10:39:28
|
<k-joseph> dkayiwa: how is this TRUNK-3289 ??
|
10:39:43
|
<dkayiwa> k-joseph: in the javadoc, i do not see the method description (as in what the method does)
|
10:40:50
|
<dkayiwa> k-joseph: secondly, why do you hard code the uuid?
|
10:41:32
|
<k-joseph> dkayiwa: secondly, why do you hard code the uuid?
|
10:41:46
|
<dkayiwa> k-joseph: why
|
10:41:46
|
<k-joseph> dkayiwa: what are you meaning?
|
10:42:19
|
<dkayiwa> k-joseph: do you remember the docs i sent you about constants?
|
10:42:41
|
<k-joseph> dkayiwa: i do
|
10:43:41
|
<dkayiwa> k-joseph: so do i now make sense?
|
10:44:00
|
<k-joseph> dkayiwa: not yet
|
10:44:13
|
<k-joseph> dkayiwa: on hard coding
|
10:44:44
|
<dkayiwa> k-joseph: its about the constants docs i sent you in reference to the way you are using the uuid in that method
|
10:44:52
|
<dkayiwa> k-joseph: you can just read them again
|
10:49:10
|
<dkayiwa> k-joseph: i also see that you did not claim the ticket
|
10:49:16
|
<dkayiwa> k-joseph: did you?
|
10:49:34
|
<dkayiwa> k-joseph: never work on a ticket before claiming it
|
10:49:36
|
<k-joseph> dkayiwa: i claimed it, refresh the page
|
10:49:44
|
<k-joseph> dkayiwa: ok
|
10:50:13
|
<dkayiwa> k-joseph: you may end up wasting time duplicating and wasting efforts with someone else working on the same thing
|
10:52:20
|
*** dkayiwa has quit IRC
|
10:53:52
|
*** k-joseph has quit IRC
|
11:59:19
|
*** kishoreyekkanti has joined #openmrs
|
12:02:21
|
*** k-joseph has joined #openmrs
|
12:07:35
|
*** kishoreyekkanti has quit IRC
|
12:43:24
|
*** k-joseph has quit IRC
|
12:47:53
|
*** kishoreyekkanti has joined #openmrs
|
13:05:04
|
*** k-joseph has joined #openmrs
|
13:39:57
|
*** edcalip has joined #openmrs
|
13:47:13
|
*** djadmin has joined #openmrs
|
14:50:01
|
*** kishoreyekkanti has quit IRC
|
14:54:48
|
*** lh has joined #openmrs
|
14:54:48
|
*** lh has joined #openmrs
|
15:05:27
|
*** edcalip has quit IRC
|
15:29:51
|
*** djadmin2 has joined #openmrs
|
15:31:09
|
*** djadmin has quit IRC
|
15:33:03
|
*** harshadura has quit IRC
|
15:37:40
|
*** djadmin2 has quit IRC
|
15:48:22
|
*** lh has quit IRC
|
16:11:04
|
*** djadmin has joined #openmrs
|
16:17:35
|
*** k-joseph has quit IRC
|
16:26:16
|
*** wyclif has joined #openmrs
|
16:46:33
|
*** djadmin has quit IRC
|
16:48:48
|
*** djadmin has joined #openmrs
|
16:58:07
|
*** djadmin has quit IRC
|
16:58:49
|
*** djazayeri has joined #openmrs
|
16:58:49
|
*** ChanServ sets mode: +o djazayeri
|
17:08:53
|
*** lh has joined #openmrs
|
17:08:53
|
*** lh has joined #openmrs
|
17:10:47
|
*** harshadura has joined #openmrs
|
17:16:41
|
*** lh has quit IRC
|
17:18:17
|
*** k-joseph has joined #openmrs
|
17:18:48
|
<k-joseph> /msg NickServ identify jesus
|
17:19:15
|
<k-joseph> [20:18] <k-joseph> /msg NickSer
|
17:19:58
|
*** mseaton has joined #openmrs
|
17:19:58
|
*** ChanServ sets mode: +v mseaton
|
17:38:26
|
*** Anuruddha has quit IRC
|
17:43:53
|
*** k-joseph has quit IRC
|
17:45:06
|
*** k-joseph has joined #openmrs
|
17:45:37
|
*** evmw has joined #openmrs
|
17:49:01
|
*** mseaton has quit IRC
|
18:18:35
|
*** djadmin has joined #openmrs
|
18:35:36
|
*** bhashitha has joined #openmrs
|
18:47:10
|
*** harshadura_ has joined #openmrs
|
18:51:22
|
*** harshadura has quit IRC
|
18:55:40
|
<bhashitha> Hi
|
18:57:10
|
<bhashitha> Can anyone tell me how to call a function of jQuery opesnmrsearch widget ?
|
19:23:31
|
*** dkayiwa has joined #openmrs
|
19:23:49
|
<k-joseph> dkayiwa: hi
|
19:23:54
|
<dkayiwa> k-joseph: hi
|
19:25:14
|
<k-joseph> dkayiwa: commited at https://github.com/k-joseph/openmrs-core/commit/TRUNK-3424
|
19:25:15
|
<OpenMRSBot> <http://ln-s.net/+ZdN> (at github.com)
|
19:25:55
|
<dkayiwa> k-joseph: checking it now
|
19:26:08
|
<k-joseph> dkayiwa: ok
|
19:26:54
|
<dkayiwa> k-joseph: the method description should not include implementation details
|
19:27:22
|
<dkayiwa> k-joseph: in otherwards, remove the part which says how the daemon comparison is done
|
19:27:56
|
<dkayiwa> k-joseph: does that make sense?
|
19:30:40
|
<k-joseph> dkayiwa: it does, i have removed that and now the first line of that javadoc is checks whether a user is a daemon user or not
|
19:31:07
|
<dkayiwa> k-joseph: ok good
|
19:31:11
|
*** djadmin has quit IRC
|
19:31:20
|
<dkayiwa> k-joseph: secondly, the call needs to be like this: Daemon.isDaemonUser(
|
19:31:43
|
<dkayiwa> k-joseph: that is in your unit tests
|
19:45:31
|
*** harshadura_ has quit IRC
|
19:46:38
|
<k-joseph> dkayiwa: can you please clarify more what you mean by the last two posts,
|
19:47:13
|
<dkayiwa> k-joseph: check your unit tests, your method call should be: Daemon.isDaemonUser()
|
19:50:02
|
<k-joseph> dkayiwa: then i think i need to make isDaemonUser() static, ? right,
|
19:50:17
|
<dkayiwa> k-joseph: right
|
19:50:26
|
<k-joseph> dkayiwa: ok
|
19:52:38
|
<k-joseph> dkayiwa: i think i can make a fresh commit
|
19:52:47
|
<dkayiwa> k-joseph: ok
|
19:58:47
|
*** bhashitha has quit IRC
|
19:59:33
|
<k-joseph> dkayiwa: dkayiwa: https://github.com/k-joseph/openmrs-core/commit/TRUNK-3424 pullrequest?
|
19:59:34
|
<OpenMRSBot> <http://ln-s.net/+ZdN> (at github.com)
|
20:00:39
|
<dkayiwa> k-joseph: looking
|
20:00:52
|
<k-joseph> dkayiwa: ok, mean while am working on TRUNK-3621
|
20:00:58
|
<dkayiwa> k-joseph: ok
|
20:01:32
|
<k-joseph> dkayiwa: do you mean it fine to make a pull request?
|
20:02:16
|
<dkayiwa> k-joseph: in the isDaemonUser method, can you do the reverse?
|
20:02:33
|
<dkayiwa> k-joseph: DAEMON_USER_UUID.equals(......)
|
20:02:49
|
<dkayiwa> k-joseph: that will prevent the NPE if the uuid is null
|
20:02:53
|
<dkayiwa> k-joseph: does this make sense?
|
20:03:25
|
<k-joseph> dkayiwa: what is NPE
|
20:03:36
|
<dkayiwa> k-joseph: Null Pointer Exception
|
20:05:15
|
<k-joseph> dkayiwa: am not fully getting this can you do the reverse?
|
20:05:45
|
<dkayiwa> k-joseph: if the uuid is null, do you see that the method call will throw a NPE?
|
20:07:53
|
<k-joseph> dkayiwa: so can i just use a catch block to take care of this, or there i sa better way?
|
20:08:30
|
<dkayiwa> k-joseph: and easier way is it reverse the statement
|
20:08:37
|
<dkayiwa> k-joseph: as i mentioned above
|
20:11:47
|
<k-joseph> dkayiwa: how is that to be done?
|
20:12:08
|
<k-joseph> dkayiwa: daemon.getUuid().equals(DAEMON_USER_UUID) || daemon.getUuid().equals(null) ??
|
20:12:48
|
<dkayiwa> k-joseph: do you see my statement above?
|
20:13:45
|
<k-joseph> dkayiwa: i see that
|
20:13:45
|
<k-joseph> k-joseph: in the isDaemonUser method, can you do the reverse?
|
20:13:45
|
<k-joseph> [23:02] <dkayiwa> k-joseph: DAEMON_USER_U UID.equals(......)
|
20:13:59
|
<dkayiwa> k-joseph: yes use that to do the comparison
|
20:18:21
|
<k-joseph> dkayiwa: am failing to figure out how exactly you want me to do that
|
20:19:02
|
<dkayiwa> k-joseph: do you see where you do the equals comparison in that method?
|
20:19:28
|
<k-joseph> dkayiwa: i do see that
|
20:20:03
|
<dkayiwa> k-joseph: can you replace it my statement above and then you finish it?
|
20:22:44
|
<k-joseph> dkayiwa: am sorry to say but am not understanding that,
|
20:23:08
|
<dkayiwa> k-joseph: have you first of all done the replacement?
|
20:26:05
|
<k-joseph> dkayiwa: daemon.getUuid().DAEMON_USER_UUID.equals(DAEMON_USER_UUID)
|
20:26:37
|
<dkayiwa> k-joseph: does that compile?
|
20:28:25
|
*** djazayeri has quit IRC
|
20:36:36
|
<k-joseph> dkayiwa: ok, i have got what you meant,
|
20:37:29
|
<k-joseph> dkayiwa: return DAEMON_USER_UUID.equals(daemon.getUuid());
|
20:37:51
|
<dkayiwa> k-joseph: thats exactly what i wanted. how did you figure it out?
|
20:38:32
|
<k-joseph> dkayiwa: i just had to remeber how the equals() is to be used
|
20:38:42
|
<dkayiwa> k-joseph: ok
|
20:39:10
|
<dkayiwa> k-joseph: what is the advantage of that over the one you have committed?
|
20:40:43
|
<k-joseph> dkayiwa: i dont think i can prove the advantage, bu tfrom what i have had from you, this conciders DAEMON_USER_UUID being null as well
|
20:41:14
|
<dkayiwa> k-joseph: what do you mean by DAEMON_USER_UUID being null?
|
20:42:14
|
<k-joseph> dkayiwa: i mean daemon uuid == null
|
20:42:43
|
<dkayiwa> k-joseph: can't DAEMON_USER_UUID also be null?
|
20:43:27
|
<k-joseph> dkayiwa: DAEMON_USER_UUID is the same as daemon uuid
|
20:44:00
|
<dkayiwa> k-joseph: what do you mean by saying that they are the same?
|
20:44:04
|
<k-joseph> dkayiwa: it can be null when there is no value that is initially assigned to it
|
20:46:16
|
<k-joseph> dkayiwa: it looks like, DAEMON_USER_UUID is the in defined uuid for daemon, does that mean that a daemon user can have a user defined universally unique id ?
|
20:47:13
|
<dkayiwa> k-joseph: not all users are daemon
|
20:47:56
|
<dkayiwa> k-joseph: and in that case can you also change the parameter name?
|
20:48:23
|
<dkayiwa> k-joseph: you gave the parameter the name daemon. but that does not make sense since the user may not be a daemon
|
20:48:29
|
<dkayiwa> k-joseph: do you agree?
|
20:49:37
|
<k-joseph> dkayiwa: yes i do, practically how can i create a daemon user account, besides modifying the availabe daemon account
|
20:50:03
|
<k-joseph> dkayiwa: am naming the parameter daemonUsername
|
20:50:31
|
<dkayiwa> k-joseph: which data type is that parameter?
|
20:50:45
|
<k-joseph> dkayiwa: User
|
20:50:53
|
<dkayiwa> k-joseph: so is that a user name?
|
20:51:18
|
<k-joseph> dkayiwa: so daemonUser, is what am using
|
20:51:44
|
<dkayiwa> k-joseph: will all of them be daemons?
|
20:52:06
|
<k-joseph> dkayiwa: do you mean all users
|
20:52:20
|
<dkayiwa> k-joseph: all parameters to that method
|
20:52:52
|
<k-joseph> dkayiwa: not neccessarily
|
20:53:07
|
<dkayiwa> k-joseph: so then why do you call it daemon???
|
20:57:50
|
<k-joseph> dkayiwa: http://pastebin.com/0zHmmXEj
|
20:58:50
|
<dkayiwa> k-joseph: you did not complete the javadoc for the @param
|
20:59:31
|
<dkayiwa> k-joseph: also for the method description, can you use capitalization whenever it should be?
|
21:00:06
|
<dkayiwa> k-joseph: that is only for the method description
|
21:01:56
|
<k-joseph> dkayiwa: @param user, User
|
21:03:47
|
<k-joseph> dkayiwa: http://pastebin.com/cxD3xGdm
|
21:04:38
|
<dkayiwa> k-joseph: the method javadoc is still missing on capitalizations and full stops
|
21:05:15
|
<dkayiwa> k-joseph: the @param is still incomplete. you can just look at existing openmrs methods that have javadoc, for an example
|
21:05:41
|
<dkayiwa> k-joseph: the capitalization and full stops are for method description
|
21:09:43
|
*** k-joseph has quit IRC
|
21:18:54
|
*** jkeiper has joined #openmrs
|
21:18:54
|
*** ChanServ sets mode: +v jkeiper
|
21:23:50
|
*** k-joseph has joined #openmrs
|
21:40:57
|
<k-joseph> dkayiwa: hi, http://pastebin.com/LT9f44Dm
|
21:44:51
|
<k-joseph> dkayiwa: hi
|
21:45:47
|
*** harshadura has joined #openmrs
|
21:49:50
|
<dkayiwa> k-joseph: hi
|
21:50:14
|
*** k-joseph has quit IRC
|
21:51:11
|
*** k-joseph has joined #openmrs
|
21:51:29
|
<k-joseph> dkayiwa: hi
|
21:51:49
|
<dkayiwa> k-joseph: make User start with small u
|
21:52:15
|
<dkayiwa> k-joseph: also the @param and @return should not have implementation details
|
21:52:48
|
<dkayiwa> k-joseph: that is, they should not tell the method user that we are actually using uuid to check for daemoness
|
21:53:15
|
<dkayiwa> k-joseph: does that make sense?
|
21:53:34
|
<k-joseph> dkayiwa: it does
|
22:01:22
|
<k-joseph> dkayiwa: http://pastebin.com/07WkGN1d
|
22:02:06
|
<dkayiwa> k-joseph: ok now commit
|
22:05:22
|
<dkayiwa> k-joseph: did you also make DAEMON_USER_UUID public?
|
22:05:59
|
<k-joseph> dkayiwa: no
|
22:06:21
|
<dkayiwa> k-joseph: do you see the ticket title?
|
22:06:31
|
<k-joseph> dkayiwa: i had forgotten that, am goin to do that
|
22:06:37
|
<dkayiwa> k-joseph: ok
|
22:07:37
|
<dkayiwa> k-joseph: after committing, you should also create a new ticket for someone to handle Burke's request which goes as below:
|
22:07:39
|
<dkayiwa> k-joseph: Can we filter daemon user from user-related API methods â i.e., getting users or searching users would not include the daemon user in results?
|
22:10:45
|
<k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/commit/TRUNK-3424
|
22:10:46
|
<OpenMRSBot> <http://ln-s.net/+ZdN> (at github.com)
|
22:13:12
|
<dkayiwa> k-joseph: create pull request
|
22:13:41
|
<dkayiwa> k-joseph: also on the ticket, mention that you have created a new ticket for Burke's request
|
22:13:50
|
<dkayiwa> k-joseph: remember to mention the ticket number
|
22:20:13
|
*** harshadura has quit IRC
|
22:20:33
|
*** harshadura has joined #openmrs
|
22:22:08
|
<k-joseph> dkayiwa: is the ticket to be of the same name TRUNK-3414, such that i should just change the description?
|
22:22:46
|
<dkayiwa> k-joseph: the name should be a summary of what the ticket is about
|
22:23:16
|
<dkayiwa> k-joseph: meaning ticket name should a summary of the description
|
22:24:24
|
<k-joseph> dkayiwa: that is creating a sub task?
|
22:24:44
|
<dkayiwa> k-joseph: no
|
22:25:23
|
<k-joseph> dkayiwa: i see no option for creating a new ticket on the page
|
22:25:37
|
<dkayiwa> k-joseph: which page?
|
22:25:44
|
*** harshadura has quit IRC
|
22:26:57
|
<k-joseph> dkayiwa: am on https://tickets.openmrs.org/browse/TRUNK-3424#comment-194822 i think you should give me a link to create the ticket from
|
22:27:31
|
<dkayiwa> k-joseph: dont you see a Create Issue link at the top?
|
22:27:58
|
*** evmw has quit IRC
|
22:29:09
|
<k-joseph> dkayiwa: seen that
|
22:29:42
|
<dkayiwa> k-joseph: am feeling sleepy. talk to you tomorrow
|
22:30:07
|
<k-joseph> dkayiwa: ok, thanks a lot
|
22:30:13
|
*** dkayiwa has quit IRC
|
22:39:24
|
*** k-joseph has quit IRC
|
22:47:26
|
*** evmw has joined #openmrs
|