| 00:22:31 | *** robbyoconnor has quit IRC |
| 00:42:50 | *** robbyoconnor has joined #openmrs |
| 00:42:50 | *** ChanServ sets mode: +v robbyoconnor |
| 01:09:07 | *** travis-ci has joined #openmrs |
| 01:09:07 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [9e2c963] [k-joseph] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/4463123 |
| 01:09:07 | *** travis-ci has left #openmrs |
| 01:09:11 | <OpenMRSBot> <http://ln-s.net/+Y:O> (at travis-ci.org) |
| 01:41:08 | *** djadmin has joined #openmrs |
| 01:47:00 | *** robbyoconnor has quit IRC |
| 02:23:53 | *** djadmin has quit IRC |
| 02:24:12 | *** djadmin has joined #openmrs |
| 02:40:38 | *** djazayeri has joined #openmrs |
| 02:40:38 | *** ChanServ sets mode: +o djazayeri |
| 02:42:14 | *** djadmin has quit IRC |
| 02:48:44 | *** mseaton has joined #openmrs |
| 02:48:44 | *** ChanServ sets mode: +v mseaton |
| 02:58:24 | *** djadmin has joined #openmrs |
| 03:17:36 | *** djadmin has quit IRC |
| 03:21:27 | *** mseaton has quit IRC |
| 03:35:29 | *** jkeiper has joined #openmrs |
| 03:35:29 | *** ChanServ sets mode: +v jkeiper |
| 03:36:55 | *** cpower has joined #openmrs |
| 03:37:40 | <jkeiper> hiya wyclif |
| 03:37:56 | <wyclif> jkeiper, hi |
| 03:38:09 | <wyclif> jkeiper, i think i figure out what i wanted to ask |
| 03:38:18 | <wyclif> jkeiper, one more question |
| 03:38:52 | <jkeiper> wyclif, haha ok |
| 03:39:04 | <wyclif> to the getSchema() methods should only return the section for the properties and no parent |
| 03:39:53 | <wyclif> i.e if i have firstname and lastname as my props, it should return <xs:elementname="firstname"type="xs:string"/> |
| 03:39:53 | <wyclif> <xs:elementname="lastname"type="xs:string"/> |
| 03:40:34 | <wyclif> jkeiper, with no enclosing elements, and assumes they all accept strings |
| 03:40:34 | <jkeiper> wyclif, i think so |
| 03:40:39 | *** mseaton has joined #openmrs |
| 03:40:39 | *** ChanServ sets mode: +v mseaton |
| 03:40:43 | <jkeiper> wyclif, that seems right to me |
| 03:40:59 | <jkeiper> wyclif, we can try to be smarter with datatypes later on |
| 03:41:00 | <wyclif> jkeiper, am starting to think this base class might not really be useful |
| 03:41:08 | <jkeiper> wyclif, no? |
| 03:41:23 | <jkeiper> wyclif, it's a bonus anyway ... not absolutely necessary |
| 03:41:31 | <jkeiper> wyclif, but i thought it might be useful |
| 03:41:53 | <wyclif> jkeiper, since different handlers will typically want to control the structure in more refined way, e.g what is required, no. of occurences, datatypes |
| 03:42:08 | <jkeiper> wyclif, in that case we can skip the base |
| 03:42:13 | <wyclif> jkeiper, complex vs simple |
| 03:42:21 | <jkeiper> wyclif, as long as we have an interface |
| 03:42:37 | <wyclif> jkeiper, i mean there are so many factors that lead to minimum usasge of this base class |
| 03:42:51 | <wyclif> jkeiper, am actually thinking the chances are 0 |
| 03:43:24 | <jkeiper> wyclif, hahaha ok |
| 03:43:33 | <jkeiper> wyclif, then we can axe it ... was just a suggestion / bonus anyway |
| 03:43:39 | <wyclif> jkeiper, ok |
| 03:43:51 | <jkeiper> wyclif, your argument is sound ... since the only people asking will be fine with a custom approach anywqays |
| 03:51:50 | <wyclif> jkeiper, what is a typical use case of serializeFormData? |
| 03:52:15 | <wyclif> jkeiper, am trying to wrap my head around it and it is starting not to make sensed to me |
| 03:52:24 | <jkeiper> wyclif, the idea is to get formData serialized so it can be put into an HL7 |
| 03:52:50 | <jkeiper> so you receive something like "<firstName>Jeremy</firstName>" |
| 03:53:03 | <jkeiper> and send back "{firstName: \"Jeremy\"}" |
| 03:53:13 | <jkeiper> then it goes into the OBX |
| 03:53:14 | <wyclif> jkeiper, if that is the case, then why provide the method on the interface |
| 03:53:25 | <jkeiper> so you can expect it |
| 03:53:27 | <jkeiper> on the handler |
| 03:53:41 | <jkeiper> some complex obs handlers might not provide it |
| 03:54:04 | <wyclif> jkeiper, i still dont get it |
| 03:54:10 | <jkeiper> wyclif, hahaa |
| 03:54:13 | <wyclif> jkeiper, when do we ever call it |
| 03:54:18 | <jkeiper> wyclif, in the XSLT |
| 03:54:27 | <jkeiper> wyclif, you can't just drop XML data into the OBX |
| 03:54:34 | <jkeiper> wyclif, it has to be serialized |
| 03:55:05 | <jkeiper> wyclif, and (in addition) it should be escaped for use in HL7s |
| 03:55:31 | <jkeiper> wyclif, if you'd rather use some utility that always serializes the same way (XML -> JSON for instance), we can consider that |
| 03:55:47 | <wyclif> jkeiper, i guess my point is that since we know we always need hl7, then why not just call it getHl7 |
| 03:55:49 | <jkeiper> wyclif, but sometimes that form data might not be XML ... it could be some other format ... |
| 03:56:07 | <jkeiper> wyclif, because we're just getting a serialized version of the form data |
| 03:56:08 | <jkeiper> :-D |
| 03:56:19 | <jkeiper> wyclif, we're not getting an HL7 |
| 03:56:28 | <jkeiper> wyclif, we're getting a section of an OBX segment |
| 03:56:32 | <jkeiper> wyclif, the data part |
| 03:56:51 | <jkeiper> wyclif, i can show you tomorrow what we need |
| 03:56:57 | <jkeiper> wyclif, if you come up with something different to do it, that's fine |
| 03:56:59 | <jkeiper> :-) |
| 03:57:39 | <wyclif> jkeiper, you mean hl7 doesnt support xml as content |
| 03:57:54 | <jkeiper> wyclif, right ... as far as i know ... |
| 03:57:55 | <wyclif> jkeiper, i get what you mean |
| 03:58:25 | <jkeiper> wyclif, i mean, it's encapsulated data ... i guess it could be anything, but typically ppl are sending base64 encoded text |
| 03:58:37 | <jkeiper> wyclif, so we could do that too if you want! |
| 03:58:41 | <jkeiper> wyclif, it's just easier to read as json |
| 03:58:46 | <jkeiper> wyclif, but i'd leave that up to the handler |
| 03:59:09 | <jkeiper> wyclif, because if it's image data ... there won't be any other way to represent it except with base64 or a reference to some shared file system |
| 04:02:46 | <wyclif> jkeiper, i think there is something not clicking for me |
| 04:02:55 | <jkeiper> wyclif, haha ... we can rehash tomorrow AM |
| 04:03:01 | <jkeiper> wyclif, my brain is not clicking either ;-) |
| 04:03:14 | <wyclif> jkeiper, ok |
| 04:03:26 | <jkeiper> wyclif, just don't get swept away in a flood |
| 04:03:40 | <jkeiper> wyclif, i heard flood warnings until 11am |
| 04:04:08 | <wyclif> jkeiper, in the morning? |
| 04:04:24 | <wyclif> jkeiper, from what time? |
| 04:04:25 | <jkeiper> wyclif, yep |
| 04:05:46 | <wyclif> jkeiper, my assumption is that is xforms receives xml data from the client, it should transform it to another form before applying the xslt |
| 04:07:04 | <wyclif> jkeiper, so that we don't have to explicitly call serializeFormData, what do you think |
| 04:07:18 | <wyclif> jkeiper, you can think about it tomorrow morning |
| 04:07:34 | <jkeiper> wyclif, i still think the handler should decide since it is consuming in saveObs() |
| 04:07:44 | <jkeiper> wyclif, but yes ... let's talk after some caffeine ;-) |
| 04:24:43 | *** djazayeri has quit IRC |
| 04:25:03 | *** mseaton has quit IRC |
| 04:39:09 | *** kishoreyekkanti has joined #openmrs |
| 05:02:25 | *** robbyoconnor has joined #openmrs |
| 05:02:25 | *** ChanServ sets mode: +v robbyoconnor |
| 06:12:47 | *** travis-ci has joined #openmrs |
| 06:12:47 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [be945a8] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/4468604 |
| 06:12:47 | *** travis-ci has left #openmrs |
| 06:12:50 | <OpenMRSBot> <http://ln-s.net/+YDj> (at travis-ci.org) |
| 06:23:39 | *** upul has joined #openmrs |
| 06:23:39 | *** ChanServ sets mode: +v upul |
| 06:42:59 | *** upul has quit IRC |
| 07:37:42 | *** rowanseymour has joined #openmrs |
| 07:50:39 | *** djadmin has joined #openmrs |
| 08:01:05 | *** ibewes has joined #openmrs |
| 08:01:32 | <ibewes> hello all |
| 08:03:37 | <ibewes> does anyone here have experience deploying modules? I'm getting an error when I run 'mvn release:perform' |
| 08:04:36 | <ibewes> something is causing mvn to try and run a javadoc task that is messing things up, but I'm not sure why it's running or how to fix it |
| 08:17:20 | *** k-joseph has joined #openmrs |
| 08:34:20 | *** djadmin has quit IRC |
| 08:55:23 | *** k-joseph has quit IRC |
| 09:29:17 | *** kavuri has joined #openmrs |
| 09:32:39 | <kavuri> wyclif: hi |
| 09:38:32 | <kavuri> hello anyone |
| 09:44:23 | *** rafa has joined #openmrs |
| 09:44:23 | *** ChanServ sets mode: +v rafa |
| 09:51:53 | <kavuri> rafa: hi |
| 09:52:00 | <rafa> kavuri: hi |
| 09:52:32 | <kavuri> rafa: I have created a task to retire a user that are not part of the system any more |
| 09:52:48 | <kavuri> rafa: when I invoke the method retireUser, I get a privilege exception |
| 09:52:51 | <kavuri> VIEW_PERSON |
| 09:53:32 | <kavuri> rafa: I went to the extent of giving admin privileges in the Context.authenticate(username,password) method, but still I get the same exception.. |
| 09:53:55 | <rafa> kavuri: a typical way is to add proxy privelege |
| 09:54:03 | <rafa> kavuri: call Context.addProxyPrivlege |
| 09:54:37 | <kavuri> rafa: what would be the value of the String privilege? |
| 09:54:39 | <rafa> kavuri: remember to remove it in the finally block by calling Context.removeProxyPrivilege |
| 09:54:53 | <rafa> kavuri: PrivilegeConstants.VIEW_PERSON |
| 09:55:18 | <kavuri> rafa: ok, will try this |
| 09:55:48 | <kavuri> rafa: if proxy privileges are used, is there still need to perform Context.authenticate()? |
| 09:55:56 | <rafa> kavuri: no |
| 09:56:18 | <kavuri> rafa: ok |
| 09:57:49 | <kavuri> rafa: I still get the error |
| 09:57:50 | <kavuri> An error occurred while executing this method. Error message: You must have privilege 'View People' in order to assign it. |
| 09:57:51 | <kavuri> org.openmrs.api.APIException: You must have privilege 'View People' in order to assign it. |
| 09:58:51 | <rafa> kavuri: can you pastebin the full stack trace? |
| 10:00:48 | <rafa> kavuri: and a code snippet of your execute method... |
| 10:01:12 | <kavuri> rafa: here is the pastebin for the error |
| 10:01:14 | <kavuri> rafa: http://pastebin.com/d1gcYGs7 |
| 10:03:50 | <rafa> kavuri: are you adding this task via module? |
| 10:03:56 | <kavuri> rafa: yes |
| 10:04:22 | <rafa> kavuri: can you try restarting tomcat/jetty? |
| 10:04:28 | <kavuri> rafa: will do |
| 10:06:40 | <kavuri> rafa: restarted, but its the same problem |
| 10:06:50 | <kavuri> rafa: let me post the code snippet |
| 10:07:05 | <rafa> kavuri: yes, please do |
| 10:10:45 | <kavuri> rafa: http://pastebin.com/5gUKi5AM |
| 10:12:55 | *** dkayiwa has joined #openmrs |
| 10:12:55 | <rafa> kavuri: looks all good. How do you schedule the task? |
| 10:13:23 | <kavuri> rafa: I created a task in the scheduler with the task class and scheduled it for every 10 secs (just for testing) |
| 10:15:48 | <rafa> kavuri: and you are sure you are running the pasted code and not some old version? |
| 10:16:30 | <kavuri> rafa: yes |
| 10:16:56 | <kavuri> rafa: everytime I modify the module and upload it again, do I have to re-create the task? |
| 10:17:09 | <kavuri> rafa: I even tried that once, but no use |
| 10:17:40 | <rafa> kavuri: it shouldn't be necessary |
| 10:17:53 | <rafa> kavuri: it looks like a bug |
| 10:17:55 | <kavuri> rafa: yes..since the task class is loaded dynamically |
| 10:18:06 | <rafa> kavuri: please do enter a ticket, specify OMRS version you are using, attach stacktrace and code snippet |
| 10:18:16 | <kavuri> rafa: ok |
| 10:18:48 | <kavuri> rafa: its coming from the checkPrivileges method and there is a check |
| 10:18:50 | <kavuri> if (requiredPrivs.size() == 1) { |
| 10:18:50 | <kavuri> throw new APIException("You must have privilege '" + requiredPrivs.get(0) + "' in order to assign it."); |
| 10:18:50 | <kavuri> } |
| 10:19:27 | <kavuri> rafa: I have even added EDIT_USERS privilege, in which case the size() should be 2 |
| 10:20:06 | <kavuri> rafa: I wonder why the size is always 1 |
| 10:22:42 | <kavuri> rafa: this is in UserServiceImpl class |
| 10:25:08 | <rafa> kavuri: ahh right |
| 10:25:24 | <kavuri> rafa: ? |
| 10:25:30 | <rafa> kavuri: it passes Context.requirePrivilege(PrivilegeConstants.EDIT_USERS); but fails later in checkPrivileges(user); |
| 10:27:17 | <kavuri> rafa: something that I am doing wrong? |
| 10:29:22 | <rafa> kavuri: no, the checkPrivileges method is to be blamed |
| 10:29:36 | <rafa> kavuri: have you tried authenticating with superuser account? |
| 10:29:47 | <kavuri> rafa: I did, same error |
| 10:30:26 | <rafa> kavuri: try again |
| 10:30:33 | <rafa> kavuri: just restart the server after loading a module |
| 10:30:50 | <kavuri> rafa: o |
| 10:30:51 | <kavuri> rafa: ok |
| 10:32:34 | *** dkayiwa has quit IRC |
| 10:33:57 | *** rowanseymour has quit IRC |
| 10:37:32 | <kavuri> rafa: same error |
| 10:38:12 | <rafa> kavuri: ok, I'm confused what's going on in checkPrivileges then as well |
| 10:38:21 | <rafa> kavuri: just enter a ticket |
| 10:38:27 | <kavuri> rafa: ok |
| 10:39:52 | <rafa> kavuri: probably UserServiceImpl.checkPrivileges must be fixed to use Context.hasPrivilege instead of authUser.hasPrivilege |
| 10:40:22 | <kavuri> rafa: I am using the standalone version of openmrs 1.9.2 |
| 10:40:54 | <rafa> kavuri: I was looking at 1.8.x code |
| 10:41:02 | <rafa> kavuri: let me switch |
| 10:41:05 | <kavuri> rafa: ok |
| 10:41:24 | <rafa> kavuri: yeah, it's the same case |
| 10:42:47 | <rafa> kavuri: let me know when you create a ticket |
| 10:42:52 | <kavuri> rafa: ok |
| 10:43:13 | <rafa> kavuri: I could get you a war with this fix right away |
| 10:43:40 | <kavuri> rafa: great. A patch would also do. I can apply to 1.9.x code base and try |
| 10:44:43 | <rafa> kavuri: ohh then just open UserServiceImpl and change line 433 from if (!authUser.hasPrivilege(p.getPrivilege())) to if (!Context.hasPrivilege(p.getPrivilege())) |
| 10:45:00 | <kavuri> rafa: ok |
| 10:45:54 | <rafa> kavuri: this way the method will respect proxy privileges |
| 10:46:01 | <kavuri> rafa: ok |
| 10:48:07 | *** ibewes has quit IRC |
| 10:56:21 | <kavuri> rafa: after this change, I get a null pointer exception at line 170 |
| 10:56:29 | <kavuri> rafa: User.setRetired(true); |
| 10:56:56 | <kavuri> rafa: and I see that the user is already retired.. |
| 10:57:01 | <kavuri> rafa: thats probably the reason |
| 10:57:03 | <kavuri> will try again |
| 11:02:18 | <kavuri> rafa: the fix works |
| 11:02:31 | <rafa> kavuri: perfect! |
| 11:02:43 | <rafa> kavuri: are you in position to issue a pull request? |
| 11:02:56 | <kavuri> rafa: yes |
| 11:03:04 | <rafa> kavuri: thanks a lot! |
| 11:03:14 | <kavuri> rafa: thank you :) |
| 11:25:47 | *** lh has quit IRC |
| 12:41:11 | *** ibewes has joined #openmrs |
| 12:44:18 | *** k-joseph has joined #openmrs |
| 12:46:07 | *** jblaya has joined #openmrs |
| 12:47:40 | *** djadmin has joined #openmrs |
| 13:05:31 | *** mseaton has joined #openmrs |
| 13:05:31 | *** ChanServ sets mode: +v mseaton |
| 13:11:40 | *** djadmin has quit IRC |
| 13:30:34 | *** kishoreyekkanti has quit IRC |
| 13:32:51 | *** jkeiper has quit IRC |
| 13:34:37 | *** dkayiwa has joined #openmrs |
| 13:35:49 | <ibewes> anyone here running Ubuntu? I've got a question about running tests with PowerMock on linux |
| 13:36:44 | <k-joseph> dkayiwa: hi |
| 13:37:01 | <dkayiwa> k-joseph: hi |
| 13:38:00 | <k-joseph> dkayiwa: working on TRUNK-3289, i think orderDAO is also an order stuff, right? |
| 13:39:23 | <dkayiwa> !ticket TRUNK-3289 |
| 13:39:24 | <OpenMRSBot> dkayiwa: [#TRUNK-3289] Delete other order stuff before deleting current order - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3289 |
| 13:45:05 | <k-joseph> dkayiwa: hi |
| 13:45:15 | <dkayiwa> k-joseph: hi |
| 13:45:56 | <k-joseph> dkayiwa: am thinking am to call the deleteOrder() on all these stuffs after implementing it, ?? |
| 13:46:05 | *** wyclif has quit IRC |
| 13:47:24 | <dkayiwa> k-joseph: looking |
| 13:54:28 | <dkayiwa> k-joseph: can you instead do this? TRUNK-3424 |
| 13:54:32 | <dkayiwa> !tciket TRUNK-3424 |
| 13:54:33 | <OpenMRSBot> dkayiwa: Error: "tciket" is not a valid command. |
| 13:54:43 | <dkayiwa> !ticket TRUNK-3424 |
| 13:54:44 | <OpenMRSBot> dkayiwa: [#TRUNK-3424] Daemon.DAEMON_USER_UUID should be public - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3424 |
| 13:56:46 | *** djazayeri has joined #openmrs |
| 13:56:46 | *** ChanServ sets mode: +o djazayeri |
| 13:58:18 | *** kishoreyekkanti has joined #openmrs |
| 14:12:35 | <k-joseph> dkayiwa: hi |
| 14:12:39 | <dkayiwa> k-joseph: hi |
| 14:13:36 | <k-joseph> dkayiwa: do still remeber my two questions?, please answer me when you free to |
| 14:14:12 | <dkayiwa> k-joseph: are you reading all IRC comments? |
| 14:15:17 | *** jblaya has quit IRC |
| 14:15:40 | <k-joseph> dkayiwa: have seen that, i had not seen that comment of that ticket before, focussing on that now |
| 14:16:15 | *** jkeiper has joined #openmrs |
| 14:16:15 | *** ChanServ sets mode: +v jkeiper |
| 14:21:05 | *** ibewes has quit IRC |
| 14:28:51 | *** kavuri has quit IRC |
| 14:30:29 | *** djadmin has joined #openmrs |
| 14:34:45 | *** wyclif has joined #openmrs |
| 14:37:46 | *** jblaya has joined #openmrs |
| 14:44:09 | *** djazayeri1 has joined #openmrs |
| 14:47:16 | *** djazayeri has quit IRC |
| 14:49:26 | *** djazayeri1 has quit IRC |
| 14:52:45 | *** djazayeri has joined #openmrs |
| 14:52:45 | *** ChanServ sets mode: +o djazayeri |
| 14:53:14 | *** djadmin has quit IRC |
| 14:54:50 | *** kishoreyekkanti has quit IRC |
| 14:55:35 | *** downey has joined #openmrs |
| 14:55:35 | *** ChanServ sets mode: +o downey |
| 14:55:35 | *** OpenMRSBot sets mode: +o downey |
| 15:02:54 | *** andrea_ has joined #openmrs |
| 15:04:21 | <cpower> Hello everyone |
| 15:04:31 | <djazayeri> hi |
| 15:04:39 | <cpower> Are we ready to Scrum? |
| 15:04:44 | <andrea_> cpower, hi! |
| 15:04:46 | <cpower> !scrumon cpower |
| 15:04:46 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:05:22 | <cpower> Order: djazayeri, mseaton, rafa, andrea_, dkayiwa, wyclif |
| 15:05:50 | <djazayeri> Recently: |
| 15:06:04 | <djazayeri> * UIs for dialog popups in Mirebalais |
| 15:06:07 | <djazayeri> Soon: |
| 15:06:31 | <djazayeri> * Refactoring App Framework to support apps only available for certain locations |
| 15:06:57 | <djazayeri> * Work with mseaton on cohort-builder-lite for Mirebalais |
| 15:07:02 | <djazayeri> * lots of calls today |
| 15:07:05 | <djazayeri> No blockers |
| 15:07:16 | <djazayeri> btw, cpower I can only be on the first hour of design call today. |
| 15:07:25 | <mseaton> * Reviewing tickets and answering questions |
| 15:07:25 | <mseaton> * Picking up PS-7 and other "demonstrate" tickets to show what I have in mind there |
| 15:07:25 | <mseaton> * Lots of calls today |
| 15:07:25 | <mseaton> * No blockers |
| 15:07:33 | <cpower> Is ok, at the moment we have 0 topics |
| 15:07:53 | <jkeiper> ;-) |
| 15:08:06 | <rafa> Today: |
| 15:08:06 | <rafa> * IRC support |
| 15:08:06 | <rafa> * RESTWS sprint setup |
| 15:08:06 | <rafa> No blockers. (sorry mseaton for stepping away from the sprint, I'm back on board tomorrow) |
| 15:08:17 | <mseaton> rafa: good to konw |
| 15:08:46 | <mseaton> rafa: discussion about what is currently in place for people to create patient summaries in ui |
| 15:09:09 | <cpower> go ahead andrea_ |
| 15:09:26 | <andrea_> Wednesday |
| 15:09:26 | <andrea_> Design call |
| 15:09:26 | <andrea_> Work on PS-3 Support a print-friendly view of a patient summary |
| 15:09:26 | <andrea_> Review JQuery |
| 15:09:26 | <andrea_> No Blockers but discussion |
| 15:09:40 | <dkayiwa> Public Holiday in Uganda |
| 15:09:40 | <dkayiwa> No Blockers |
| 15:10:06 | <wyclif> Tuesday: |
| 15:10:06 | <wyclif> TRUNK-3886 - Add SerializableComplexObsHandler interface for form processing methods |
| 15:10:06 | <wyclif> Reviewed and applied pull requests |
| 15:10:06 | <wyclif> |
| 15:10:06 | <wyclif> Wednesday: |
| 15:10:07 | <wyclif> FORM-144 - Update schema and template generation for complex observations |
| 15:10:09 | <wyclif> design call |
| 15:10:11 | <wyclif> Review and apply pull requests |
| 15:10:15 | <wyclif> |
| 15:10:17 | <wyclif> Blockers: None |
| 15:10:42 | <cpower> No blockers, |
| 15:11:06 | <cpower> Discussion between mseaton and rafa on patient Summaries |
| 15:11:21 | <andrea_> mseaton, rafa would like to join discussion about what is currently in place for people to create patient summaries in ui |
| 15:11:25 | <rafa> mseaton: one can create reports and add datasets, but no way to add templates yet, dkayiwa have you added a button to create reports to the manageSummaries.jsp? otherwise one needs to go directly to http://localhost:8081/openmrs-standalone/module/patientsummary/patientSummaryReportDefinitionEditor.form |
| 15:11:41 | <mseaton> rafa: ok, that's what i discovered. wanted to confirm |
| 15:11:50 | <dkayiwa> rafa: no |
| 15:12:28 | <mseaton> rafa: i don't think we used the right controller as a model for that page necessarily. it seems we reused the controller from back when we were trying to embed the patient data set editor (so it has things like support for an inprogress session-based report, which we don't need. |
| 15:12:48 | <mseaton> rafa: i think it would be more straightforward to just steal the reportEditor.jsp page as described. |
| 15:12:58 | <mseaton> and tweak it slightly |
| 15:13:17 | <mseaton> but i'll look into it more today while you are on other things and we can revisit where we are tomorrow. |
| 15:13:58 | <andrea_> mseaton, will this become the page to put the print button on? |
| 15:13:59 | <rafa> mseaton: hmmm looks simpler indeed |
| 15:14:14 | <mseaton> andrea_: to give yourself a patient summary report definition and template to play with, you can work around the lack of a working ui by doing most of this in the reporting module pages for now. |
| 15:14:42 | <mseaton> andrea_: no |
| 15:15:22 | <andrea_> mseaton, which UI pages in the reporting module? |
| 15:15:26 | <mseaton> andrea_: the print button will likely go directly on the page that displays the rendered summary (eg. the dashboard tab) |
| 15:15:42 | <mseaton> andrea_: i'll write something up |
| 15:15:51 | <andrea_> mseaton, ok great! |
| 15:18:36 | *** djadmin has joined #openmrs |
| 15:19:56 | <rafa> cpower: I think you can switch us off ;) |
| 15:21:21 | <downey> !scrumoff |
| 15:21:21 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:21:47 | *** djazayeri has quit IRC |
| 15:40:30 | *** jaghatise has joined #openmrs |
| 15:40:41 | <jaghatise> hi |
| 15:41:25 | <jaghatise> i am having problem uploading from backup sql file |
| 15:41:35 | <jaghatise> can anyone help? |
| 15:41:58 | <jblaya> jaghatise, what's the problem |
| 15:45:12 | *** djazayeri has joined #openmrs |
| 15:45:12 | *** ChanServ sets mode: +o djazayeri |
| 15:54:08 | <mseaton> andrea_ dkayiwa rafa : i have added some notes in a section called Technical Notes at the bottom of this page: https://wiki.openmrs.org/display/docs/Patient+Summary+Module , which is intended to instruct how to create a new patient summary and template today, using the UI features that are currently available. this will be useful if you want a way to have a list of patient summaries to display in the manage list, or if you want to a |
| 15:56:54 | <andrea_> mseaton, thanks will check it out |
| 15:57:32 | <rafa> mseaton: thanks |
| 15:57:55 | <mseaton> andrea_: rafa no worries. let me know if it is unclear. |
| 16:21:42 | *** k-joseph has quit IRC |
| 16:25:27 | *** jaghatise has quit IRC |
| 16:38:16 | *** downey has quit IRC |
| 16:39:03 | *** djadmin has quit IRC |
| 16:40:18 | *** djadmin has joined #openmrs |
| 16:53:23 | *** suranga has joined #openmrs |
| 16:53:23 | *** ChanServ sets mode: +v suranga |
| 17:03:22 | *** downey has joined #openmrs |
| 17:03:22 | *** ChanServ sets mode: +o downey |
| 17:03:22 | *** OpenMRSBot sets mode: +o downey |
| 17:05:45 | *** robbyoconnor has quit IRC |
| 17:07:17 | *** lh has joined #openmrs |
| 17:07:17 | *** lh has joined #openmrs |
| 17:21:05 | *** k-joseph has joined #openmrs |
| 17:21:21 | <k-joseph> dkayiwa: hi |
| 17:21:49 | <dkayiwa> k-joseph: hi |
| 17:24:30 | <k-joseph> dkayiwa: please am kindly requesting you to interview this http://pastebin.com/uEXE0j62 |
| 17:24:48 | *** HP_ has joined #openmrs |
| 17:25:47 | *** HP_ has quit IRC |
| 17:27:40 | *** suranga has quit IRC |
| 17:28:37 | <dkayiwa> k-joseph: can you compare the UUID as the way of checking if is daemon user? |
| 17:36:41 | *** suranga has joined #openmrs |
| 17:36:41 | *** ChanServ sets mode: +v suranga |
| 17:43:50 | *** rafa has quit IRC |
| 18:01:10 | *** jblaya has quit IRC |
| 18:13:02 | <jkeiper> hello, irc ... are you working? |
| 18:13:08 | <jkeiper> downey, test |
| 18:13:32 | <downey> jkeiper: no |
| 18:13:36 | <downey> :) |
| 18:44:31 | <suranga> IRC is working, but people are broken :D |
| 18:44:57 | *** djazayeri1 has joined #openmrs |
| 18:48:41 | *** djazayeri has quit IRC |
| 18:58:49 | *** lh has quit IRC |
| 19:05:29 | *** breeze has joined #openmrs |
| 19:07:01 | *** djadmin has quit IRC |
| 19:10:43 | *** cjbriese has joined #openmrs |
| 19:10:44 | *** breeze has quit IRC |
| 19:11:11 | *** cjbriese__ has joined #openmrs |
| 19:11:11 | *** cjbriese has quit IRC |
| 19:11:45 | *** cjbriese__ is now known as breeze |
| 19:14:17 | <breeze> hey, everyone. I have a question about the preferred version of linux for running openmrs |
| 19:15:50 | <breeze> is there a default distro to use? |
| 19:15:54 | <dkayiwa> breeze: am not so sure if we have a preferred version, but most people i have seen are running on late versions of ubuntu |
| 19:16:13 | <breeze> ok |
| 19:17:00 | <breeze> dkayiwa: does that include production servers too? |
| 19:17:10 | <dkayiwa> breeze: yes |
| 19:17:22 | <breeze> dkayiwa: ok. thanks |
| 19:27:01 | <downey> +1 to dkayiwa comments ⦠we don't have any formalized minimum/recommended platform requirements (we should) but most people are running an ubuntu+mysql+tomcat stack |
| 19:47:54 | *** k-joseph has quit IRC |
| 19:51:00 | *** david__ has joined #openmrs |
| 19:51:52 | <david__> Hi all, I was wondering if anyone has tested OpenMRS with the newest Tomcat release 7.0.35? |
| 19:54:20 | <dkayiwa> david__: i have seen people testing with Tomcat 7, but not sure of the very precise version |
| 19:55:35 | <david__> I believe there was a change that could cause issues. I'm seeing this error when attempting to create a patient: http://pastebin.com/3BBrL3Pf |
| 19:56:39 | <david__> I spent some time looking into it, and there was a change in the tomcat code base, http://svn.apache.org/viewvc?view=revision&revision=1427821 such that they no longer guard against null in JspWriterImpl |
| 19:56:43 | <OpenMRSBot> <http://ln-s.net/+YSG> (at svn.apache.org) |
| 19:57:20 | <david__> on the patientForm page, there is an EL expression ${identifier}, and that value is null |
| 19:58:27 | *** djazayeri1 has quit IRC |
| 19:59:44 | <dkayiwa> david__: my testing was on Tomcat 7.0.26 and it seemed to work fine |
| 20:00:04 | <david__> yes, the change was made for tomcat 7.0.35 onwards |
| 20:00:11 | <dkayiwa> david__: ok |
| 20:01:46 | <downey> wyclif: ping ^ |
| 20:01:48 | <cpower> Should we get a bug ticket created so we can look into making sure it will work in previous versions... |
| 20:01:56 | <wyclif> ? |
| 20:02:47 | <downey> or future versions :) |
| 20:03:00 | <dkayiwa> :D |
| 20:03:06 | <cpower> but it sounds like present versions are ok |
| 20:03:24 | <cpower> quick Marty to the car! |
| 20:03:28 | <cpower> ;-) |
| 20:03:29 | <downey> cpower: tomcat versions previous to current |
| 20:03:41 | * downey grabs the plutonium |
| 20:03:43 | <jkeiper> hi breeze |
| 20:03:43 | <jkeiper> i'm jkeiper |
| 20:03:43 | <jkeiper> :-D |
| 20:03:46 | <david__> hehe |
| 20:03:49 | *** wyclif has quit IRC |
| 20:04:08 | <dkayiwa> jkeiper: have you scared Wyclif? :) |
| 20:04:18 | <cpower> yep he quit |
| 20:04:26 | <david__> it seems drastic on tomcat's part to go from guarding against null, to saying, nevermind we'll throw a NPE |
| 20:04:29 | <downey> maybe the bug from david__ scared him :D |
| 20:04:42 | <jkeiper> dkayiwa, he is celebrating his birthday on african time |
| 20:04:54 | <dkayiwa> jkeiper: lollllllllllll :D |
| 20:05:11 | <dkayiwa> downey: you sound more correct :) |
| 20:05:35 | <dkayiwa> david__: that must have scared Wyclif :) |
| 20:05:39 | <jkeiper> david__, spring is at fault typically when it comes to error reporting |
| 20:05:44 | <jkeiper> david__, afaict spring doesn't like NPEs |
| 20:06:32 | <jkeiper> david__, we've tried swallowing every error (i.e. catch Throwable e) and still spring rolls back the transaction |
| 20:07:13 | *** suranga has quit IRC |
| 20:07:17 | <dkayiwa> jkeiper: may be it catches it before you do :) |
| 20:07:29 | *** wyclif has joined #openmrs |
| 20:07:48 | <dkayiwa> Suranga leaves, wyclif comes back. what an exchange :) |
| 20:09:39 | *** lh has joined #openmrs |
| 20:09:39 | *** lh has joined #openmrs |
| 20:11:29 | *** djazayeri has joined #openmrs |
| 20:11:29 | *** ChanServ sets mode: +o djazayeri |
| 20:11:41 | <downey> wyclif: did you see that bug report |
| 20:12:11 | <wyclif> downey, i missed the conversation |
| 20:12:19 | <wyclif> downey, which one? |
| 20:12:52 | <downey> wyclif: https://wiki.openmrs.org/display/IRC/2013-01-30+-+OpenMRS#195152 |
| 20:20:02 | <downey> wyclif is pacing around thinking about it :) |
| 20:20:40 | <dkayiwa> that normally happens on birth days :) |
| 20:21:50 | <downey> jkeiper: https://issues.apache.org/bugzilla/show_bug.cgi?id=35410 |
| 20:21:54 | <OpenMRSBot> <http://ln-s.net/+YSx> (at issues.apache.org) |
| 20:22:00 | <jkeiper> oO |
| 20:22:44 | <jkeiper> wow, strange |
| 20:23:00 | <downey> jkeiper: evil patch in 2005 :) |
| 20:31:00 | *** lh has quit IRC |
| 20:50:27 | *** david__ has quit IRC |
| 20:59:41 | <dkayiwa> hi mseaton |
| 21:00:08 | <dkayiwa> mseaton: is the mockup for PS-11 still valid? |
| 21:01:05 | <mseaton> dkayiwa: yep, that's valid |
| 21:01:34 | <dkayiwa> mseaton: ok |
| 21:01:40 | <mseaton> dkayiwa: might be easiest to just write it from scratch and delete anything that has been done before. |
| 21:01:49 | <dkayiwa> mseaton: ok |
| 21:14:04 | *** djazayeri has quit IRC |
| 21:17:44 | *** lh has joined #openmrs |
| 21:17:44 | *** lh has joined #openmrs |
| 21:20:07 | *** djazayeri has joined #openmrs |
| 21:20:07 | *** ChanServ sets mode: +o djazayeri |
| 21:21:38 | *** mseaton has quit IRC |
| 21:31:35 | *** breeze1 has joined #openmrs |
| 21:39:53 | *** downey has quit IRC |
| 21:42:59 | *** jkeiper has quit IRC |
| 21:48:01 | *** djazayeri1 has joined #openmrs |
| 21:48:02 | *** djazayeri has quit IRC |
| 21:59:59 | *** breeze1 has left #openmrs |
| 22:00:10 | *** dkayiwa has quit IRC |
| 22:31:30 | *** djazayeri1 has quit IRC |
| 22:35:54 | *** apb156 has joined #openmrs |
| 22:37:55 | *** djazayeri has joined #openmrs |
| 22:37:55 | *** ChanServ sets mode: +o djazayeri |
| 22:38:35 | *** breeze has quit IRC |
| 22:40:14 | *** apb156 has quit IRC |
| 22:46:40 | *** lh has quit IRC |
| 23:03:42 | *** wyclif has quit IRC |
| 23:45:57 | *** Martinphs has joined #openmrs |