IRC Chat : 2013-01-21 - OpenMRS

Created by Unknown User (openmrsbot), last modified on 2013-07-09
00:32:26 *** wyclif has joined #openmrs
02:21:24 *** mseaton has joined #openmrs
02:21:24 *** ChanServ sets mode: +v mseaton
02:22:00 *** mseaton has left #openmrs
02:30:07 *** mseaton has joined #openmrs
02:30:07 *** ChanServ sets mode: +v mseaton
02:35:08 *** mseaton has left #openmrs
02:39:03 *** mseaton has joined #openmrs
02:39:03 *** ChanServ sets mode: +v mseaton
02:39:13 *** mseaton has left #openmrs
03:03:28 *** robbyoconnor has quit IRC
03:07:55 *** robbyoconnor has joined #openmrs
03:07:55 *** ChanServ sets mode: +v robbyoconnor
03:48:18 *** LVW has joined #openmrs
04:00:58 *** robbyoconnor has quit IRC
04:01:27 *** robbyoconnor has joined #openmrs
04:01:27 *** ChanServ sets mode: +v robbyoconnor
04:08:59 *** pusakat has joined #openmrs
04:09:02 *** LVW has quit IRC
05:03:23 *** kavuri has joined #openmrs
05:09:18 *** kishoreyekkanti has joined #openmrs
05:34:37 *** pusakat has quit IRC
05:49:00 *** kavuri has quit IRC
05:50:16 *** robbyoconnor has quit IRC
05:56:00 *** robbyoconnor has joined #openmrs
05:56:00 *** ChanServ sets mode: +v robbyoconnor
06:03:56 *** kavuri has joined #openmrs
06:04:51 *** kavuri has joined #openmrs
06:06:07 *** kavuri has joined #openmrs
06:07:10 *** kavuri has joined #openmrs
06:07:49 *** kavuri has quit IRC
06:08:17 *** kavuri has joined #openmrs
06:09:42 *** kavuri has joined #openmrs
06:09:49 *** kavuri has quit IRC
06:10:48 *** kavuri has joined #openmrs
06:12:05 *** kavuri has joined #openmrs
06:13:11 *** kavuri has joined #openmrs
06:13:50 *** kavuri has quit IRC
06:14:13 *** kavuri has joined #openmrs
06:16:14 *** kavuri has joined #openmrs
06:22:13 *** robbyoconnor has quit IRC
06:22:21 *** r0bby has joined #openmrs
06:22:21 *** ChanServ sets mode: +v r0bby
06:28:28 *** r0bby has quit IRC
06:54:05 *** r0bby has joined #openmrs
06:54:05 *** ChanServ sets mode: +v r0bby
07:09:23 *** r0bby has quit IRC
07:13:56 *** r0bby has joined #openmrs
07:13:56 *** ChanServ sets mode: +v r0bby
07:26:41 *** kavuri has joined #openmrs
07:28:05 *** kavuri has joined #openmrs
07:43:29 *** r0bby has quit IRC
07:45:49 *** r0bby has joined #openmrs
07:45:49 *** ChanServ sets mode: +v r0bby
08:08:56 *** r0bby has quit IRC
08:34:44 *** r0bby has joined #openmrs
08:34:44 *** ChanServ sets mode: +v r0bby
08:37:12 *** kavuri has quit IRC
08:40:10 *** r0bby has quit IRC
10:06:02 *** r0bby has joined #openmrs
10:06:02 *** ChanServ sets mode: +v r0bby
10:15:58 *** r0bby has quit IRC
10:43:16 *** k-joseph has joined #openmrs
10:45:15 *** k-joseph_ has joined #openmrs
10:48:50 *** k-joseph has quit IRC
10:49:04 *** k-joseph_ is now known as k-joseph
10:53:23 *** k-joseph has quit IRC
11:06:53 *** k-joseph has joined #openmrs
11:20:09 *** dkayiwa has joined #openmrs
11:24:38 *** djazayeri1 has joined #openmrs
11:26:58 *** kavuri has joined #openmrs
11:27:39 *** djazayeri has quit IRC
11:32:45 <kavuri> dkayiwa: hi
11:32:54 <dkayiwa> kavuri: hi
11:33:05 <kavuri> dkayiwa: did you have a chance to look at my patch?
11:33:19 <dkayiwa> kavuri: it looks good
11:33:53 <kavuri> dkayiwa: will you be able to merge it?
11:34:18 <dkayiwa> kavuri: let me check again
11:34:23 <kavuri> dkayiwa: ok
11:34:25 *** k-joseph_ has joined #openmrs
11:34:35 <k-joseph_> dkayiwa: hi
11:34:45 <dkayiwa> k-joseph_: hi
11:37:32 *** k-joseph has quit IRC
11:38:14 *** k-joseph_ is now known as k-joseph
11:49:44 <k-joseph> dkayiwa: am having problems with establishing the problem for TRUNK-3883, and this is limiting my undrstanding of the ticket, i kindly request for your assistance here
11:51:29 <dkayiwa> k-joseph: what does the ticket say that you should be doing?
11:52:33 <k-joseph> dkayiwa: storing the locationId integer instead of the Location object in the UserContext which is this http://pastebin.com/fSRh5VdF
11:53:38 <k-joseph> dkayiwa: i think that is the method to be addressed, right?
11:54:23 <dkayiwa> k-joseph: UserContext has a class level variable named "location" which is of type Location. This ticket is about changing it to locationId and of type Integer
11:54:27 <dkayiwa> k-joseph: does this make sense?
11:57:30 <k-joseph> dkayiwa: ok, i get that, can you also make this clear ....... and of type Intege?
11:58:24 <dkayiwa> k-joseph: the variable type should be changed to Integer
11:59:08 *** rafa has joined #openmrs
11:59:08 *** ChanServ sets mode: +v rafa
12:04:16 <k-joseph> dkayiwa: i think you mean writing this : private int locationId; instead of this : private Location location = null; , right
12:04:50 <k-joseph> dkayiwa: ?
12:09:07 *** k-joseph has quit IRC
12:37:20 *** k-joseph has joined #openmrs
12:38:01 <k-joseph> dkayiwa: hi
12:38:53 <dkayiwa> k-joseph: give me just like 15 mins
12:39:09 <k-joseph> dkayiwa: ok
12:53:27 <dkayiwa> k-joseph: hi
12:53:47 <k-joseph> dkayiwa: hi
12:54:03 <dkayiwa> k-joseph: use Integer instead of int
12:54:20 <k-joseph> dkayiwa: ok
12:57:46 *** suranga has joined #openmrs
12:57:46 *** ChanServ sets mode: +v suranga
13:04:19 <k-joseph> dkayiwa: how about fixing this http://snag.gy/KnL9c.jpg?
13:05:18 <dkayiwa> does it compile?
13:07:49 <k-joseph> dkayiwa: runing openmrs and gives http://pastebin.com/dYpvHhfV in the browse with those two errors,
13:08:35 <dkayiwa> k-joseph: can you resolve the compiler errors?
13:09:11 <k-joseph> dkayiwa: that is what am looking forwad to
13:10:05 <dkayiwa> k-joseph: ok please do it
13:12:25 <k-joseph> dkayiwa: is it write to change return type for LocationService.getLocation() to Integer?
13:12:50 <dkayiwa> k-joseph: no
13:13:43 *** hybridivy has joined #openmrs
13:13:58 *** kavuri has quit IRC
13:15:18 <k-joseph> if (this.locationId == null || !this.locationId.getName().equalsIgnoreCase(locationId)) {
13:15:18 <k-joseph> try {
13:15:18 <k-joseph> this.locationId = Context.getLocationService().getLocation(Integer.valueOf(locationId));
13:15:18 <k-joseph> }
13:15:54 <k-joseph> dkayiwa: need assistance in fixing that, please
13:16:26 *** r0bby has joined #openmrs
13:16:26 *** ChanServ sets mode: +v r0bby
13:16:39 <dkayiwa> k-joseph: lets use pastebin for multiple lines
13:17:22 <dkayiwa> k-joseph: which line are you referring to
13:18:15 *** dkayiwa has quit IRC
13:20:03 *** k-joseph has quit IRC
13:25:42 *** dkayiwa has joined #openmrs
13:33:53 *** dkayiwa has quit IRC
13:40:59 *** dkayiwa has joined #openmrs
13:41:30 *** k-joseph has joined #openmrs
13:48:42 <k-joseph> looks like you are bussy, mean while am still trying to ressolve the two error messages http://pastebin.com/PGQG73Sk , and it looks as though am still failing, please tell me when you are fine to look into this otherwise am taking along time focusing on it and its turning into a blocker on my side
13:48:55 <k-joseph> dkayiwa: looks like you are bussy,mean while am still trying to ressolve the twoerror messages http://pastebin.com/PGQG73Sk , and it looks as though am still failing, please tellme when you are fine to look into this otherwiseam taking along time focusing on it and its turning into a blocker on my side
13:50:27 <dkayiwa> k-joseph: what error message do you get?
13:51:04 <k-joseph> dkayiwa: http://snag.gy/KnL9c.jpg
13:51:31 <dkayiwa> k-joseph: i see code but not the error message
13:53:20 <k-joseph> dkayiwa: error messages are The method getName() is undefined for the type Integer and type mismatch: cannot convert from Location to Integer respectively
13:54:09 <dkayiwa> k-joseph: do you know how to get a locationId from a Location object?
13:54:44 <k-joseph> dkayiwa: i do not
13:55:01 *** r0bby_ has joined #openmrs
13:55:01 *** ChanServ sets mode: +v r0bby_
13:55:02 <dkayiwa> k-joseph: can you look at the Location class?
13:55:18 <k-joseph> dkayiwa: looking at it now
13:56:13 *** r0bby has quit IRC
14:04:38 *** suranga has quit IRC
14:06:59 *** r0bby_ has quit IRC
14:08:42 *** r0bby_ has joined #openmrs
14:08:42 *** ChanServ sets mode: +v r0bby_
14:17:51 *** kishoreyekkanti has quit IRC
14:30:08 *** kavuri has joined #openmrs
14:31:30 *** Anuruddha has joined #openmrs
14:32:03 *** hybridivy has quit IRC
14:33:03 *** r0bby_ has quit IRC
14:34:10 *** robbyoconnor has joined #openmrs
14:34:10 *** ChanServ sets mode: +v robbyoconnor
14:34:46 *** hybridivy has joined #openmrs
14:47:26 *** k-joseph has quit IRC
15:04:25 <rafa> hmm no cpower around
15:04:46 <rafa> let's scrum anyway
15:04:53 <rafa> !scrumon rafa
15:04:53 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster rafa- you may begin when ready.
15:05:26 <rafa> order: dkayiwa, djazayeri1, wyclif, rafa, and any late comers
15:05:37 <dkayiwa> Investigated: Error when trying to open appointment management page - AM-56
15:05:37 <dkayiwa> Now working on: Allow comment in mysql dataset - REPORT-372
15:05:37 <dkayiwa> No Blockers
15:06:30 <rafa> djazayeri1: there?
15:07:03 <rafa> 3, 2, 1... time's up
15:07:08 <rafa> wyclif: go ahead
15:07:17 <dkayiwa> :D
15:08:12 <rafa> hmm let's try rafa ;)
15:08:19 <dkayiwa> :)
15:08:23 <rafa> Today:
15:08:23 <rafa> * Committed:
15:08:23 <rafa> + REPORT-459: Preview of Indicators don't work on later pages or when searching
15:08:23 <rafa> https://tickets.openmrs.org/browse/REPORT-459
15:08:23 <rafa> + REPORT-225: you can't purge a report design if the serialized object assocated with this report design can't be deserialized
15:08:23 <rafa> https://tickets.openmrs.org/browse/REPORT-225
15:08:23 <rafa> * Merged REPORT-415: Add preview button to composition cohort query
15:08:24 <rafa> https://tickets.openmrs.org/browse/REPORT-415
15:08:24 <rafa> * Will test REPORT-247: Spaces or underscores in any of the "Searches to Combine" CohortDefinition keys breaks Composition String in CompositionQuery
15:08:25 <rafa> https://tickets.openmrs.org/browse/REPORT-247
15:08:25 <rafa> Discussion points: * What to do with can't reproduce tickets?
15:08:26 <rafa> + https://tickets.openmrs.org/browse/REPORT-445
15:08:26 <rafa> + https://tickets.openmrs.org/browse/REPORT-444
15:08:27 <rafa> + https://tickets.openmrs.org/browse/REPORT-453
15:08:27 <rafa> * It would be useful to have more report definitions to test REPORT-464
15:08:28 <rafa> https://tickets.openmrs.org/browse/REPORT-464
15:08:28 <rafa> No blockers.
15:08:55 <rafa> I'll e-mail Mike about the discussion points.
15:09:02 <dkayiwa> ok
15:09:07 <rafa> No blockers.
15:09:20 <rafa> !scrumoff
15:09:20 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:17:30 <kavuri> dkayiwa: hi
15:19:40 <dkayiwa> kavuri: hi
15:19:52 <kavuri> dkayiwa: about the patch...
15:20:12 <dkayiwa> kavuri: oh yeah. can you remind me of the url? :)
15:20:23 <kavuri> dkayiwa: https://github.com/openmrs/openmrs-module-webservices.rest19ext/pull/1
15:20:26 <OpenMRSBot> <http://ln-s.net/+Urq> (at github.com)
15:27:07 <dkayiwa> kavuri: what is the ticket number?
15:27:24 <kavuri> dkayiwa: RESTWS-317
15:28:17 *** hybridivy has quit IRC
15:31:21 *** rafa has quit IRC
15:36:41 *** kavuri has quit IRC
16:00:03 *** yony258 has joined #openmrs
16:00:56 <yony258> dkayiwa: Hi, let me know when you have a second I want to talk about CRs, I can wait so no need to hurry
16:02:55 *** suranga has joined #openmrs
16:02:55 *** ChanServ sets mode: +v suranga
16:07:32 <suranga> hmm.. just realized that today is a holiday in the US....
16:16:01 <dkayiwa> yony258: hey
16:16:12 <yony258> dkayiwa: Hi
16:16:46 <yony258> dkayiwa: So as you know we will be deploying v0.2 on Wednesday Evening
16:16:59 <dkayiwa> yony258: ok
16:17:34 <yony258> dkayiwa: And of course you did a lot of CRs and some of the issues you've mentioned have been fixed and some have some follow-up comments.
16:17:55 <yony258> dkayiwa: plus there are some tickets that haven't been reviewed yet.
16:18:12 <yony258> dkayiwa: So I wanted to ask if you think you will make it by Wednesday eve?
16:18:28 <dkayiwa> yony258: just point me to the remaining ones and i review them now now :)
16:18:29 <yony258> dkayiwa: I know that you are probably on a tight schedule and thus am asking
16:18:54 <yony258> dkayiwa: Do you want to first answer the follow-up questions or to start reviewing others?
16:19:08 <dkayiwa> yony258: i can start with the follow up questions
16:19:27 <yony258> dkayiwa: Ok so let me direct you to the commits that have questions
16:19:46 <dkayiwa> yony258: ok
16:22:22 <yony258> dkayiwa: These are the ones that have follow-up questions:
16:22:26 <yony258> https://github.com/openmrs/openmrs-module-appointment/commit/b8b31e13b81997a51f429c0ccdaf6dcefee01883 https://github.com/openmrs/openmrs-module-appointment/commit/eeaaf0600fdbaf5fef464fd5bd1d4a97b3d5b906
16:22:31 <OpenMRSBot> <http://ln-s.net/+Uu0> (at github.com)
16:22:34 <yony258> (There are two links in it)
16:22:41 <dkayiwa> yony258: ok looking at them now
16:30:02 <yony258> dkayiwa: Other stuff to review: http://pastebin.com/dHMWNg6i
16:30:57 <dkayiwa> yony258: ok
16:31:05 <yony258> dkayiwa: Thank you
17:02:34 *** k-joseph has joined #openmrs
17:04:10 *** k-joseph has quit IRC
17:11:59 <yony258> dkayiwa: Hi, let me know when you are done with a ticket so I could fix if needed and alert Tobin
17:12:08 <dkayiwa> yony258: ok
17:14:01 *** k-joseph has joined #openmrs
17:19:56 <k-joseph> dkayiwa: hi
17:20:02 <dkayiwa> k-joseph: hi
17:25:28 <dkayiwa> yony258: is AppointmentStatus enum committed
17:25:37 <yony258> dkayiwa: Yes
17:26:08 <dkayiwa> yony258: which package
17:26:18 <yony258> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/1e264888f52271bf5ff27d26913dbe49f21fe82c
17:26:23 <OpenMRSBot> <http://ln-s.net/+Uvm> (at github.com)
17:27:27 <dkayiwa> yony258: ok seen it
17:27:33 *** AdamLauz has joined #openmrs
17:47:00 <AdamLauz> dkayiwa: Hi daniel how are you?
17:47:20 <dkayiwa> AdamLauz: am good
17:48:29 <AdamLauz> dkayiwa: will you have the time to review 2 commits?
17:48:41 <dkayiwa> AdamLauz: yes
17:48:59 <AdamLauz> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/8a2ffe28ccdf92718347dfb8b2c2f3882d9e75a5
17:49:04 <OpenMRSBot> <http://ln-s.net/+Uwd> (at github.com)
17:49:10 <dkayiwa> AdamLauz: ok
17:49:11 <AdamLauz> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/9a0103a87bc01b5713a50690e577f8f6169dd7af
17:49:14 <OpenMRSBot> <http://ln-s.net/+Uwf> (at github.com)
17:49:20 <AdamLauz> dkayiwa: Thanks
17:49:36 *** hybridivy has joined #openmrs
17:53:53 *** lh has quit IRC
17:58:28 <AdamLauz> dkayiwa: How the date format is changed when I change the locales of openMRS? is it related to "http://java.sun.com/jsp/jstl/fmt"?
17:59:21 <dkayiwa> AdamLauz: i do not seem to understand the question
18:00:18 <AdamLauz> dkayiwa: my question is if I change the language of openMRS then who changed the date format?
18:00:31 <AdamLauz> dkayiwa: changes*
18:01:31 <dkayiwa> AdamLauz: do you have openmrs-core checked out?
18:02:14 <dkayiwa> AdamLauz: Context.getDateForm() returns according to the selected locale
18:03:49 <AdamLauz> dkayiwa: OK I hard coded the date format in one of the forms so I need to change it. I will check that out.
18:04:07 <k-joseph> dkayiwa: on the previous issue, i would like to have more light am stuck, i now know how to get locationId from a Location object ,
18:05:13 <yony258> k-joseph: Maybe I could help?
18:05:18 <yony258> dkayiwa: Done with AM-20?
18:05:42 <k-joseph> yony258: thanks alot that will be great
18:05:59 <yony258> k-joseph: Where do you need to get the locationId?
18:06:52 <dkayiwa> k-joseph: so can you now clear one of the compiler errors?
18:07:47 <k-joseph> dkayiwa: how
18:09:45 <dkayiwa> yony258: about to
18:11:05 <k-joseph> yony258: am working at TRUNK-3883, i haeve this now http://pastebin.com/FjDrca86 while i now want to eliminate these two errors, http://snag.gy/VmD8z.jpg
18:11:16 <dkayiwa> k-joseph: the line complaining about return type cannot be cast from Location to Integer, you need to call the getLocationId() method on the returned object to clear the error
18:12:07 *** AdamLauz has quit IRC
18:12:32 *** yony258 has quit IRC
18:19:01 <k-joseph> dkayiwa: http://pastebin.com/exf8kAmY
18:19:52 <dkayiwa> k-joseph: what change did you make?
18:21:29 <k-joseph> dkayiwa: i changed getLocationService().getLocation(Integer.valueOf(locationId)); to getLocationService().getLocationId(Integer.valueOf(locationId)); and now the issue is this http://snag.gy/85e8K.jpg
18:22:11 <dkayiwa> k-joseph: does the LocationService have the getLocationId() method?
18:22:41 <k-joseph> dkayiwa: no
18:22:50 <dkayiwa> k-joseph: and so???
18:23:15 *** yony258 has joined #openmrs
18:23:23 <k-joseph> dkayiwa: creating it, ??
18:23:55 <dkayiwa> k-joseph: am trying to understand why you are calling a method which does not exist
18:24:14 <yony258> dkayiwa: Sorry had a DC, are you done with AM-20?
18:24:24 <dkayiwa> yony258: about to
18:24:30 <yony258> dkayiwa: Ok thanks
18:32:57 *** Anuruddha has quit IRC
18:49:03 <k-joseph> dkayiwa: cleared one of the two erros, http://pastebin.com/Enn6SmQk
18:49:52 <dkayiwa> k-joseph: which one did you clear?
18:50:59 <k-joseph> dkayiwa: one previously on Context.getLocationService().getLocationId()
18:51:16 <dkayiwa> k-joseph: what did you change it to?
18:52:09 <k-joseph> dkayiwa: that is the exact one currently, i changed to that
18:52:54 <dkayiwa> k-joseph: does the locationservice have the getLocationId() method?
18:53:24 <k-joseph> dkayiwa: just implemented getLocationId() in LocationService file
18:53:42 <dkayiwa> k-joseph: that is not correct
18:54:28 <dkayiwa> k-joseph: what i meant is the original line returns a location object. so you only need to get location id from the returned location object
18:54:29 <k-joseph> dkayiwa: take a look at it http://pastebin.com/Enn6SmQk am now left with one error more
19:03:36 *** suranga has quit IRC
19:06:10 <k-joseph> dkayiwa: what is to be done by this one also: The method getName() is undefined for the type Integer
19:06:46 <dkayiwa> k-joseph: can you first finish the other one?
19:08:22 *** yony258 has quit IRC
19:08:55 *** yony258 has joined #openmrs
19:11:07 <yony258> dkayiwa: Where do you suggest to put the constants in?
19:11:25 <dkayiwa> yony258: do you use it only in that place?
19:11:39 <yony258> dkayiwa: Yea
19:11:55 <dkayiwa> yony258: then in that case you can leave it for now
19:12:15 <yony258> dkayiwa: Ok, but in general, where would be the correct place for those constatns?
19:12:17 <yony258> constants*
19:13:12 <dkayiwa> yony258: if used only in that class, you can declare it in the class. Else in something like AppointmentConstants
19:13:35 <yony258> dkayiwa: AppointmentConstants in the API package?
19:13:48 <dkayiwa> yony258: perfect!!!
19:14:13 <yony258> dkayiwa: thanks, how many commits left for AM-20 ?
19:14:23 <yony258> dkayiwa: A lot or a bit? :)
19:17:20 <dkayiwa> yony258: a bit :)
19:17:30 <yony258> dkayiwa: Thanks
19:22:53 <k-joseph> dkayiwa: not sure whether what you actually mean is http://pastebin.com/VkwRmmXZ
19:27:35 <dkayiwa> k-joseph: are you trying to add a new method?
19:27:42 <dkayiwa> yony258: done with AM-20
19:28:24 <yony258> dkayiwa: Great! now only AM-25 left
19:28:43 <yony258> dkayiwa: :)
19:29:06 *** k-joseph has quit IRC
19:34:39 *** hybridivy has quit IRC
19:35:45 <dkayiwa> yony258: AM-25 looks to simple a fix
19:35:50 <dkayiwa> too
19:36:46 <yony258> dkayiwa: Oh you are right, let me direct you the the relevant lines in a commit
19:38:26 <yony258> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/a70997503809dc7bcde6bb6e47c59fca96ab0899
19:38:30 <OpenMRSBot> <http://ln-s.net/+Uzz> (at github.com)
19:38:34 <yony258> dkayiwa: It's the getWaitingTime method
19:38:43 <dkayiwa> yony258: ok
19:38:52 <yony258> dkayiwa: if you want me to guide you through that, thats ok
19:38:59 <dkayiwa> yony258: ok
19:44:29 *** k-joseph has joined #openmrs
19:53:02 <dkayiwa> yony258: commit looks fine
19:53:41 <yony258> dkayiwa: Added a follow up question on https://github.com/openmrs/openmrs-module-appointment/commit/1e264888f52271bf5ff27d26913dbe49f21fe82c#commitcomment-2472565
19:53:45 <OpenMRSBot> <http://ln-s.net/+V0b> (at github.com)
19:53:47 <yony258> dkayiwa: And thats it
19:55:13 <dkayiwa> yony258: in the case where you are passing an AppointmentStatus, use a custom method on the subclass of SingleClassDAO
19:55:26 <dkayiwa> yony258: such that we do not lose the type safety
19:55:49 <yony258> dkayiwa: subclass of SingleClassDAO you mean HibernateAppointmentStatusHistoryDAO ?
19:55:55 <dkayiwa> yony258: yes
19:56:09 <yony258> dkayiwa: ok great
19:56:55 <yony258> dkayiwa: So I think thats it for my tickets anyway
19:57:07 <dkayiwa> yony258: yes
19:57:20 <yony258> dkayiwa: Any points or improvements suggestions for me after you've seen my code?
19:57:37 <yony258> dkayiwa: Open to recieve any critique :)
19:57:51 <dkayiwa> yony258: not for now apart from saying thanks guys for the great work
19:58:04 <dkayiwa> yony258: never knew you had plans of going this far with the module :)
19:58:17 <yony258> dkayiwa: Thank you for helping us and reviewing all of that code !
19:58:47 <dkayiwa> yony258: yo welcome!!!
20:02:03 <yony258> dkayiwa: One small thing I just remembered
20:02:21 <yony258> dkayiwa: We will need the string to enum function for the init binder
20:03:07 <dkayiwa> yony258: has it complained?
20:03:25 <yony258> dkayiwa: Never tried it, won't it?
20:04:23 <dkayiwa> yony258: assume no problem until it happens :)
20:04:36 <yony258> dkayiwa: good. Will do than. :)
20:10:37 *** k-joseph has quit IRC
20:27:53 <dkayiwa> yony258: one thing which next versions of module will need to address is making the colors match with the selected theme
20:28:16 <yony258> dkayiwa: they do I think
20:28:17 *** k-joseph has joined #openmrs
20:28:43 <dkayiwa> yony258: are you sure?
20:29:06 <yony258> dkayiwa: When I go legacy everything goes blue, etc..
20:29:31 <yony258> dkayiwa: unless you refer to something specific?
20:29:42 <dkayiwa> yony258: am looking at the manage appointments page
20:30:07 <dkayiwa> and looking at the widget below "Existing Appointments"
20:30:16 <dkayiwa> yony258: i think its a table
20:31:17 *** yony258_ has joined #openmrs
20:31:25 <yony258_> dkayiwa: sorry had a DC
20:31:36 <yony258_> dkayiwa: You mean the jQuery Datatable theme?
20:31:41 <dkayiwa> yony258_: yes
20:32:07 <yony258_> dkayiwa: well its a jquery UI theme, the openmrs one is just really unclear for this use case :/
20:32:30 <yony258_> dkayiwa: Thats why its gray~ to be general for every theme
20:32:39 <dkayiwa> yony258_: ok
20:32:59 <yony258_> dkayiwa: Is there a problem with that? (Openmrs convention-wise)
20:33:01 <dkayiwa> yony258_: on same screen, can i select appointment status Completed as the starting one?
20:33:17 <dkayiwa> yony258_: i will let the end users to answer that :)
20:33:21 <yony258_> dkayiwa: what do you mean? filter by completed?
20:33:47 *** yony258 has quit IRC
20:33:57 <dkayiwa> yony258_: got it :)
20:34:03 *** yony258_ is now known as yony258
20:34:51 <yony258> dkayiwa: Well its a def issue, but I think it would be ok if we will address it at the end
20:35:32 *** k-joseph has quit IRC
20:35:47 <yony258> dkayiwa: And we are planning a user study after we will let the users try this version
20:36:19 <dkayiwa> yony258: ok
20:36:22 <yony258> dkayiwa: Also maybe ask for some tips from a UX expert
20:36:45 <dkayiwa> yony258: ok
21:10:43 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Entry 2.0.4 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=htmlformentry&ampversion=&amp2.0.4>
21:12:07 *** yony258 has quit IRC
22:26:06 *** dkayiwa has quit IRC