00:22:48
|
*** dkayiwa has quit IRC
|
00:48:14
|
*** wyclif has quit IRC
|
01:23:45
|
*** andreapat has quit IRC
|
01:27:46
|
*** mseaton has joined #openmrs
|
01:27:46
|
*** ChanServ sets mode: +v mseaton
|
01:28:19
|
*** mseaton has left #openmrs
|
02:05:33
|
*** wyclif has joined #openmrs
|
02:14:08
|
*** wyclif has quit IRC
|
02:15:44
|
*** wyclif has joined #openmrs
|
03:24:29
|
*** Anuruddha has joined #openmrs
|
04:16:04
|
*** djazayeri1 has joined #openmrs
|
04:18:55
|
*** user12 has joined #openmrs
|
04:18:56
|
*** djazayeri has quit IRC
|
04:19:40
|
<user12> Hi
|
04:19:55
|
<user12> I'm new bee to openmrs
|
04:20:52
|
<user12> can anyone let me know that, how openmrs plug the seperate modules to openmrs-core application without changing the core application ?
|
04:23:02
|
*** kavuri has joined #openmrs
|
04:35:28
|
*** user12 has quit IRC
|
05:19:46
|
*** docpaul has joined #openmrs
|
05:19:46
|
*** ChanServ sets mode: +o docpaul
|
05:20:00
|
*** robbyoconnor has quit IRC
|
05:20:03
|
*** docpaul has quit IRC
|
05:20:32
|
*** robbyoconnor has joined #openmrs
|
05:20:32
|
*** ChanServ sets mode: +v robbyoconnor
|
05:22:50
|
*** sseth has joined #openmrs
|
05:26:36
|
*** kishoreyekkanti has joined #openmrs
|
05:29:26
|
*** GUna has joined #openmrs
|
05:29:50
|
*** GUna is now known as Guest89878
|
05:30:32
|
<Guest89878> after installing openMRS how to start tomcat server pls any one gude me
|
05:30:43
|
<Guest89878> guide me
|
05:31:42
|
*** sseth has quit IRC
|
05:32:58
|
<Guest89878> any one can hel me
|
05:33:22
|
*** Guest89878 has quit IRC
|
05:33:35
|
<robbyoconnor> Guest89878: hi: http://tomcat.apache.org/tomcat-7.0-doc/setup.html
|
05:33:38
|
<OpenMRSBot> <http://ln-s.net/+Tlm> (at tomcat.apache.org)
|
05:33:40
|
<robbyoconnor> if on 7.x
|
05:34:00
|
<robbyoconnor> if on 6.x: http://tomcat.apache.org/tomcat-6.0-doc/setup.html
|
05:34:01
|
<OpenMRSBot> <http://ln-s.net/2Iij> (at tomcat.apache.org)
|
05:35:11
|
<robbyoconnor> ...
|
05:36:28
|
*** GGuna has joined #openmrs
|
05:36:30
|
<GGuna> after installing openMRS how to start tomcat server
|
05:46:56
|
*** ibewes has joined #openmrs
|
05:47:06
|
<ibewes> good morning all
|
05:47:23
|
<ibewes> or whatever time of day it is where you are :)
|
05:53:58
|
<GGuna> via command line how can i do this one<ibewes>
|
05:54:28
|
<ibewes> 'net start tomcat' or maybe 'net start tomcat7'
|
05:54:49
|
<ibewes> GGuna: I forget what the service is named on Windows
|
05:57:25
|
<ibewes> GGuna: but the command is 'net start <service_name>'
|
06:02:01
|
*** djazayeri1 has quit IRC
|
06:15:24
|
*** wyclif has quit IRC
|
06:32:55
|
*** wyclif has joined #openmrs
|
06:51:00
|
*** GGuna has quit IRC
|
07:07:20
|
*** ibewes has quit IRC
|
07:17:42
|
*** ibewes has joined #openmrs
|
07:24:58
|
*** kishoreyekkanti has quit IRC
|
07:25:18
|
*** kishoreyekkanti has joined #openmrs
|
07:35:05
|
*** Anuruddha has quit IRC
|
07:35:45
|
*** k-joseph has joined #openmrs
|
07:36:02
|
*** adam_l has joined #openmrs
|
09:00:02
|
*** adam_l has quit IRC
|
09:00:15
|
*** k-joseph has quit IRC
|
10:20:22
|
<kavuri> wyclif: hi
|
10:34:04
|
*** kavuri has quit IRC
|
10:42:57
|
*** kavuri has joined #openmrs
|
10:48:49
|
*** sahiti has joined #openmrs
|
10:49:27
|
<sahiti> Hi
|
10:52:00
|
*** ibewes has quit IRC
|
10:53:47
|
*** sahiti has quit IRC
|
10:56:11
|
*** ibewes has joined #openmrs
|
10:56:59
|
*** dkayiwa has joined #openmrs
|
11:29:52
|
<kavuri> dkayiwa: hi
|
11:29:58
|
<dkayiwa> kavuri: hi
|
11:30:41
|
<kavuri> dkayiwa: surprisingly and unfortunately, loading of the event module does not work for me. I am using tomcat6 + openjdk 1.6 in Ubuntu 12.04
|
11:31:05
|
<kavuri> dkayiwa: so I am thinking of writing a hibernate interceptor class that would achieve the similar functionality as atomfeed module
|
11:31:23
|
<kavuri> dkayiwa: do you have any feedback on this approach?
|
11:32:11
|
<dkayiwa> kavuri: why doesnt the module load for you?
|
11:33:41
|
<kavuri> dkayiwa: I enabled debug tracing and could see clearly, that the event module is not even loaded. The started() method call is not invoked
|
11:34:37
|
<dkayiwa> kavuri: is it for you only or even others?
|
11:36:09
|
<kavuri> dkayiwa: I am the only one testing this
|
11:36:39
|
<dkayiwa> kavuri: how does the log look like when you try start this module?
|
11:36:55
|
*** k-joseph has joined #openmrs
|
11:37:02
|
<kavuri> dkayiwa: I tested this in amazon server, but ofcourse the server is also ubuntu12.04
|
11:37:12
|
<kavuri> dkayiwa: and its the same problem in the amazon server
|
11:37:13
|
<k-joseph> dkayiwa: hi
|
11:37:18
|
<dkayiwa> k-joseph: and locally?
|
11:37:21
|
<dkayiwa> k-joseph: hi
|
11:37:37
|
<dkayiwa> k-joseph: did you install the openmrs code formetters for eclipse?
|
11:38:00
|
<k-joseph> dkayiwa: not yet
|
11:38:07
|
<dkayiwa> kavuri: and locally?
|
11:38:18
|
<kavuri> dkayiwa: locally also its the same problem
|
11:38:19
|
<dkayiwa> k-joseph: your commit is still messed up
|
11:38:36
|
<dkayiwa> kavuri: can i look at the local stack trace?
|
11:39:10
|
<kavuri> dkayiwa: I will do a pastebin
|
11:40:52
|
<k-joseph> dkayiwa: how is it messed up, am not seeing that now
|
11:41:11
|
<dkayiwa> k-joseph: can you look at the controller?
|
11:41:17
|
<k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/commit/TRUNK-2975
|
11:41:18
|
<OpenMRSBot> <http://ln-s.net/+Tbi> (at github.com)
|
11:41:38
|
<k-joseph> dkayiwa: am looking at it
|
11:41:51
|
<dkayiwa> k-joseph: did you delete all that stuff in red?
|
11:42:15
|
<k-joseph> dkayiwa: yes i did, was that wrong?
|
11:42:36
|
<kavuri> dkayiwa: http://pastebin.com/V7gd0UB9
|
11:42:55
|
<dkayiwa> k-joseph: why did you delete it?
|
11:43:00
|
<kavuri> dkayiwa: after the last message in the log, nothing appears in the log
|
11:43:22
|
<kavuri> dkayiwa: the other symptom is this: if I restart the server, the server hangs at the point of loading the module
|
11:44:18
|
<dkayiwa> kavuri: are you using the released version of the module? or a custom one?
|
11:44:20
|
<k-joseph> dkayiwa: was i just just supposed to indicate the line that creates the instance for AlertValidator class and that is all?
|
11:44:54
|
<kavuri> dkayiwa: I have tried with both the release version as well as the one from github. The problem is same in both the scenarios
|
11:44:55
|
<dkayiwa> k-joseph: am not sure i understand you
|
11:45:09
|
<dkayiwa> k-joseph: can you explain why you deleted all those lines in red?
|
11:45:35
|
<dkayiwa> kavuri: which operating system
|
11:45:54
|
<kavuri> dkayiwa: Ubuntu 12.04, kernel 3.2.0-32
|
11:46:01
|
<kavuri> dkayiwa: 64bit OS
|
11:46:11
|
<k-joseph> dkayiwa: i thought that was responsible for the validating message that was seen previously
|
11:46:19
|
<kavuri> dkayiwa: and one more pointer, I tried this in jboss and it works there
|
11:46:39
|
<dkayiwa> kavuri: the logs has mush stuff. can you git me only a section in the log which is appended when you try start the module from the web interface?
|
11:46:41
|
<kavuri> dkayiwa: but I have other issues with jboss, so can't go with that
|
11:47:27
|
<kavuri> dkayiwa: this is all the messages from the point of starting the module. I enabled 'debug' level in openmrs. I can change it back to 'info' and send a new pastebin
|
11:47:33
|
<k-joseph> dkayiwa: checking that out again,
|
11:47:47
|
<dkayiwa> k-joseph: what validation is being done by your validator and what validation is being done by that section of code which you removed?
|
11:48:15
|
<dkayiwa> k-joseph: i thought you are using tomcat
|
11:48:28
|
<dkayiwa> k-joseph: sorry the last one was for kavuri
|
11:48:45
|
<k-joseph> dkayiwa: mine is for alert text,
|
11:48:53
|
<kavuri> dkayiwa: to debug the problem, I tried jboss too
|
11:48:56
|
<dkayiwa> k-joseph: and the one you deleted?
|
11:48:57
|
<k-joseph> dkayiwa: how exactly ? tomcat!!!
|
11:49:12
|
<k-joseph> dkayiwa: ok
|
11:49:29
|
<dkayiwa> kavuri: can i look at the log for tomcat
|
11:50:00
|
<kavuri> dkayiwa: I am going to paste the 'info' logs...just a min
|
11:51:07
|
<kavuri> dkayiwa: http://pastebin.com/EJ5N5g3T
|
11:51:45
|
<dkayiwa> kavuri: not enough
|
11:52:18
|
<kavuri> dkayiwa: this is the only log available
|
11:52:33
|
<kavuri> dkayiwa: and the other pastebin which I posted earlier is with 'debug' log level
|
11:52:46
|
<dkayiwa> kavuri: click the start module button
|
11:54:27
|
<kavuri> dkayiwa: the module does not get loaded for me to click the start button. The scenario goes like 'Modules-> Add or upgrade module' -> 'Choose file' -> (file chosen) -> 'Upload'
|
11:54:46
|
<kavuri> dkayiwa: after this, there are logs generated which I posted earlier and the server just hangs
|
11:55:05
|
<dkayiwa> kavuri: can you download and test with the standalone version of openmrs?
|
11:55:17
|
<kavuri> dkayiwa: I will give it a try
|
11:55:33
|
*** dkayiwa has quit IRC
|
11:56:34
|
*** dkayiwa has joined #openmrs
|
11:57:00
|
<dkayiwa> member:kavuri: can you download and test with the standalone version of openmrs?
|
11:57:45
|
<kavuri> dkayiwa: yes, will do that. Download will take sometime (the standalone version size is some 250MB)
|
11:57:48
|
<kavuri> dkayiwa: will update you
|
11:57:58
|
<dkayiwa> kavuri: ok
|
11:59:54
|
<k-joseph> dkayiwa: with that code back, how can eliminate Invalid property 'users' of bean class [org.openmrs.notification.Alert]: Bean property 'users' is not readable or has an invalid getter method: Does the return type of the getter match the parameter type of the setter? that alert message, or it is fine having it stay?
|
12:00:40
|
<dkayiwa> k-joseph: what does the code do? (the one you removed)
|
12:02:47
|
<k-joseph> dkayiwa: i think create userlist, roles sdd new users, + remove recipient not included in userlist
|
12:03:36
|
<dkayiwa> k-joseph: and is that what your validator is also doing?
|
12:04:29
|
*** ekow has joined #openmrs
|
12:04:36
|
<k-joseph> dkayiwa: no, so in other wards i should leave the un userfiendly message for validation of Recipients?
|
12:04:41
|
<ekow> Hi Daniel ... Ekow here ....
|
12:06:10
|
<dkayiwa> k-joseph: you delete code only if it was doing what you have created
|
12:06:30
|
<dkayiwa> k-joseph: but since it is not doing what you have done, then there is no need for removing it
|
12:06:37
|
<dkayiwa> ekow: hi
|
12:06:58
|
<k-joseph> dkayiwa: ok, so am leaving that alone, thanks
|
12:07:04
|
<dkayiwa> k-joseph: yes
|
12:07:25
|
<dkayiwa> k-joseph: and test the webapp before commiting (that is after getting it back)
|
12:11:08
|
*** kavuri has quit IRC
|
12:11:44
|
<ekow> Daniel .. some basic background first. Am Swazi now. They are still going through (at govt level) whih EMR they want to apply nationwide. Remember Swazi is quite a small place. Anyway, we have been tasked with indirectly 'selling' OpenMRS. Saw some reall adaptions of OpenMRS at one of the Piliipino clinis, you would even know if is OpenMS. Hoping to do similar with a phrase "Powered by OpenMRS " + the logo.
|
12:12:27
|
<dkayiwa> ekow: oh i see!!! Looks exciting. :)
|
12:13:01
|
<ekow> Yep, hopefully , that will let them bite into OpenMRS. Do you see the pciture ?
|
12:14:20
|
<dkayiwa> ekow: oh yes!!!
|
12:16:47
|
<ekow> In my limited knowledge. We want to use OpenMRS with a new/redesigned dashboard and perhaps some newe forms (which I am capable of designing). Different larger logo With few modules like reporting etc.
|
12:17:34
|
<dkayiwa> ekow: ok
|
12:17:47
|
<ekow> Do you know any group that has implemented something similar. Saw one at a Maternity Clinic near Manila
|
12:18:18
|
<dkayiwa> ekow: i think AMPATH should have done the same
|
12:18:50
|
<dkayiwa> ekow: and i think this too: http://openmrskenya.blogspot.com/2012/12/kenyaemr-release-201221.html
|
12:18:52
|
<OpenMRSBot> <http://ln-s.net/+TrM> (at openmrskenya.blogspot.com)
|
12:19:35
|
<dkayiwa> ekow: demo is here: https://demo.kenyaemr.org/openmrs/login.htm
|
12:19:37
|
<ekow> Is there anyone you know there that I can talk to? Or can you help us. I can bring you over for some few days if you can afford the time ):
|
12:19:53
|
<dkayiwa> ekow: bring me to where?
|
12:21:08
|
<ekow> Swazi ...... LAND. The African Kingdom\
|
12:21:20
|
<dkayiwa> ekow: lollllllllll :)
|
12:21:40
|
<ekow> Saw the link. Login/password to try?
|
12:23:15
|
<ekow> By the way, I think that is exactly what we are looking for. ...https://demo.kenyaemr.org/openmrs/login.htm
|
12:23:42
|
<dkayiwa> ekow: Darius could be one of the contact person for that.
|
12:25:34
|
<ekow> Thanks Daniel. You are a star!. By the way, can I still bring you to the kingdom?
|
12:25:57
|
<ekow> Also, the 2nd link did not work
|
12:26:04
|
<dkayiwa> ekow: username: demo
|
12:26:09
|
<dkayiwa> ekow: password: demo
|
12:26:46
|
<ekow> 2ns link ...<http://ln-s.net/+TrM> ..
|
12:28:17
|
*** k-joseph has quit IRC
|
12:28:24
|
*** k-joseph_ has joined #openmrs
|
12:28:37
|
*** k-joseph_ is now known as k-joseph
|
12:29:16
|
<k-joseph> dkayiwa: so this is better :-) https://github.com/k-joseph/openmrs-core/commit/TRUNK-2975
|
12:29:17
|
<OpenMRSBot> <http://ln-s.net/+Tbi> (at github.com)
|
12:29:24
|
<k-joseph> dkayiwa: ??
|
12:29:33
|
<dkayiwa> k-joseph: looking at it :)
|
12:29:49
|
<k-joseph> dkayiwa: (H)
|
12:31:05
|
<dkayiwa> k-joseph: have you tested it in the browser?
|
12:34:22
|
<k-joseph> dkayiwa: tested just fine
|
12:36:17
|
<dkayiwa> k-joseph: displays your error message instead of the earlier ugly one???
|
12:37:37
|
<k-joseph> dkayiwa: saving without alertText, gives http://snag.gy/lFnEU.jpg
|
12:38:29
|
<dkayiwa> k-joseph: what happens when you enter the text alone?
|
12:41:13
|
<k-joseph> dkayiwa: with text alone http://snag.gy/vj7vl.jpg with recipients alone http://snag.gy/Z2kQ8.jpg
|
12:42:34
|
<k-joseph> dkayiwa: ??
|
12:42:49
|
<dkayiwa> k-joseph: looking at it now
|
12:50:49
|
*** kavuri has joined #openmrs
|
12:50:50
|
<k-joseph> dkayiwa: :-|
|
12:51:04
|
<dkayiwa> k-joseph: thinking about it :)
|
12:51:17
|
*** r0bby has joined #openmrs
|
12:51:17
|
*** ChanServ sets mode: +v r0bby
|
12:51:26
|
<k-joseph> dkayiwa: ok, i have a few questions about TRUNK-2897
|
12:51:32
|
<dkayiwa> k-joseph: ask
|
12:51:51
|
<dkayiwa> k-joseph: before that
|
12:52:06
|
<dkayiwa> k-joseph: do you see this line? errors.rejectValue("users", "Alert.recipientRequired");
|
12:53:12
|
<dkayiwa> k-joseph: can you change it to this? errors.rejectValue("recipients", "Alert.recipientRequired"); Then test again and tell me what happens?
|
12:55:13
|
<k-joseph> dkayiwa: testing...
|
12:55:16
|
*** robbyoconnor has quit IRC
|
12:56:43
|
<k-joseph> dkayiwa: http://snag.gy/vKBlX.jpg
|
12:58:00
|
<dkayiwa> k-joseph: do we have a message for this code? Alert.recipientRequired
|
12:58:45
|
<k-joseph> dkayiwa: yes we do
|
12:58:54
|
<dkayiwa> k-joseph: what message has it?
|
12:59:14
|
<k-joseph> dkayiwa: At least one recipient is required
|
12:59:41
|
<dkayiwa> k-joseph: how come it is not displaying as so?
|
13:00:31
|
<k-joseph> dkayiwa: how is this http://snag.gy/BHrZ8.jpg
|
13:00:36
|
<k-joseph> dkayiwa: ?
|
13:01:01
|
<dkayiwa> k-joseph: what did you change?
|
13:01:51
|
<k-joseph> dkayiwa: ("users", "Alert.recipientRequired" to ("recipients", "Recipients is required");
|
13:02:15
|
<k-joseph> dkayiwa: under errors.rejectValue
|
13:02:22
|
<k-joseph> dkayiwa: ()
|
13:02:31
|
<dkayiwa> k-joseph: why are you hard coding it?
|
13:02:59
|
<k-joseph> dkayiwa: what is hard cording?
|
13:03:19
|
<dkayiwa> k-joseph: is that how you have been doing it for the past tickets?
|
13:03:52
|
<k-joseph> dkayiwa: no, then should create a message for it?
|
13:04:11
|
<dkayiwa> k-joseph: why then do you now do it differently???
|
13:07:33
|
<k-joseph> dkayiwa: i have done that and it works just fine with Alert.reccipients.required=Recipients is required in messages file
|
13:07:36
|
<k-joseph> dkayiwa: ?
|
13:08:05
|
<dkayiwa> k-joseph: whats wrong with the existing? Alert.recipientRequired
|
13:08:17
|
<dkayiwa> k-joseph: as in why do we need to create a new one?
|
13:09:23
|
<k-joseph> dkayiwa: i had not seen that, i should just change is message?
|
13:09:52
|
<dkayiwa> k-joseph: you told me it exists and has a message associated with it
|
13:09:57
|
<dkayiwa> k-joseph: didn't you?
|
13:10:19
|
<k-joseph> dkayiwa: yes Alert.recipientRequired=At least one recipient is required
|
13:11:38
|
<dkayiwa> k-joseph: yes
|
13:12:01
|
<dkayiwa> k-joseph: why don't we go with that?
|
13:12:59
|
<k-joseph> dkayiwa: isnt its message used any where where its meaningfull
|
13:13:04
|
<k-joseph> dkayiwa: ?
|
13:13:47
|
<dkayiwa> k-joseph: thats ok because we are not changing its text. are we?
|
13:14:16
|
<k-joseph> dkayiwa: ok
|
13:17:48
|
*** sara_ has joined #openmrs
|
13:17:55
|
*** rafa has joined #openmrs
|
13:17:57
|
*** ChanServ sets mode: +v rafa
|
13:22:33
|
*** dkayiwa has quit IRC
|
13:23:52
|
*** dkayiwa has joined #openmrs
|
13:24:37
|
*** r0bby_ has joined #openmrs
|
13:24:37
|
*** ChanServ sets mode: +v r0bby_
|
13:25:49
|
*** sara_ has quit IRC
|
13:26:59
|
<k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/commit/TRUNK-2975 :-(
|
13:27:00
|
<OpenMRSBot> <http://ln-s.net/+Tbi> (at github.com)
|
13:27:13
|
*** dkayiwa has quit IRC
|
13:28:01
|
*** dkayiwa has joined #openmrs
|
13:28:15
|
*** r0bby has quit IRC
|
13:31:21
|
<k-joseph> dkayiwa: :-|
|
13:33:41
|
*** r0bby_ is now known as robbyoconnor
|
13:38:31
|
<k-joseph> dkayiwa: hi
|
13:39:58
|
*** ibewes has quit IRC
|
13:42:15
|
*** dkayiwa has quit IRC
|
13:42:47
|
*** k-joseph_ has joined #openmrs
|
13:45:58
|
*** wyclif has quit IRC
|
13:55:32
|
*** k-joseph has quit IRC
|
13:57:55
|
*** k-joseph has joined #openmrs
|
14:04:02
|
*** dkayiwa has joined #openmrs
|
14:04:41
|
*** kishoreyekkanti has quit IRC
|
14:08:37
|
<k-joseph> dkayiwa: hi
|
14:08:44
|
<dkayiwa> k-joseph: hi
|
14:09:09
|
<k-joseph> dkayiwa: have you confirmed the commit yet?
|
14:10:47
|
<dkayiwa> k-joseph: how does the error message look like
|
14:14:49
|
<k-joseph> dkayiwa: just as the previous, At least one recipient is required Alert Text is required
|
14:15:17
|
<dkayiwa> k-joseph: can you show me the screenshot
|
14:19:25
|
<k-joseph> dkayiwa: http://snag.gy/wyXb8.jpg
|
14:20:23
|
<dkayiwa> k-joseph: and how does the line of code look like?
|
14:20:49
|
<k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/commit/TRUNK-2975
|
14:20:50
|
<OpenMRSBot> <http://ln-s.net/+Tbi> (at github.com)
|
14:21:43
|
<dkayiwa> k-joseph: ok now create pull request
|
14:21:54
|
<k-joseph> dkayiwa: ok
|
14:22:36
|
<kavuri> dkayiwa: I tried with the standalone version of openmrs and event module installation works
|
14:22:52
|
<dkayiwa> kavuri: that is great!!!
|
14:23:07
|
<dkayiwa> kavuri: which version of openmrs did the standalone have?
|
14:23:18
|
<kavuri> dkayiwa: 1.9.2
|
14:23:30
|
<dkayiwa> kavuri: and which version were you using before?
|
14:23:35
|
<kavuri> dkayiwa: 1.9.2
|
14:23:42
|
<dkayiwa> kavuri: ok
|
14:24:26
|
<kavuri> dkayiwa: I wonder where the problem could be !
|
14:25:03
|
<dkayiwa> kavuri: what happens when you deploy the module?
|
14:25:40
|
<kavuri> dkayiwa: in the tomcat server, the webconsole goes on forever and after the logs that I posted earlier, nothing else happens
|
14:25:59
|
<dkayiwa> kavuri: which version of tomcat are you using?
|
14:26:09
|
<kavuri> dkayiwa: 6.0
|
14:26:13
|
<kavuri> dkayiwa: I also tried with 7.0
|
14:26:25
|
<dkayiwa> kavuri: same problem for both versions?
|
14:26:29
|
<kavuri> dkayiwa: yes
|
14:26:49
|
<dkayiwa> kavuri: and which version of java?
|
14:27:06
|
<kavuri> dkayiwa: 1.6.0_24
|
14:27:23
|
<dkayiwa> kavuri: can you uninstall all modules except logic?
|
14:27:28
|
<dkayiwa> kavuri: then restart tomcat
|
14:27:37
|
<dkayiwa> kavuri: and finally try upload the module again?
|
14:27:45
|
<kavuri> dkayiwa: I never had any other modules (except logic) whenever I tried this
|
14:27:53
|
<kavuri> dkayiwa: even now
|
14:28:16
|
*** wyclif has joined #openmrs
|
14:28:26
|
<k-joseph> dkayiwa: Request Code Review?? (y)
|
14:28:43
|
<dkayiwa> kavuri: can you note the current line in the log. Then try deploy module and then send me the next lines that are logged as you try deploying?
|
14:28:49
|
<dkayiwa> k-joseph: y
|
14:29:00
|
<k-joseph> dkayiwa: ok
|
14:29:01
|
<kavuri> dkayiwa: ok
|
14:32:25
|
<k-joseph> dkayiwa: need some guidance on TRUNK-2897
|
14:32:32
|
<kavuri> dkayiwa: The last line before the deployment of the module is:
|
14:32:39
|
<kavuri> dkayiwa: 18 Jan, 2013 8:00:59 PM org.apache.coyote.http11.Http11Protocol start
|
14:32:39
|
<kavuri> INFO: Starting Coyote HTTP/1.1 on http-8080
|
14:32:39
|
<kavuri> 18 Jan, 2013 8:00:59 PM org.apache.catalina.startup.Catalina start
|
14:32:39
|
<kavuri> INFO: Server startup in 32142 ms
|
14:32:55
|
<kavuri> dkayiwa: which is basically the tomcat server startup message
|
14:33:00
|
<dkayiwa> k-joseph: what dont you understand about it?
|
14:33:03
|
<dkayiwa> !ticket TRUNK-2897
|
14:33:04
|
<OpenMRSBot> dkayiwa: [#TRUNK-2897] Add a ValidationException class - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2897
|
14:33:18
|
<dkayiwa> kavuri: correct
|
14:33:34
|
<dkayiwa> kavuri: so deploy module and tell me what next
|
14:33:41
|
*** jkeiper has joined #openmrs
|
14:33:41
|
*** ChanServ sets mode: +v jkeiper
|
14:35:12
|
<kavuri> dkayiwa: http://pastebin.com/gNvwWXhv
|
14:35:26
|
<kavuri> dkayiwa: its the same as I have posted earlier
|
14:36:00
|
<dkayiwa> kavuri: whats the name of the log file you are sending me?
|
14:36:09
|
<kavuri> dkayiwa: catalina.log
|
14:36:25
|
<dkayiwa> kavuri: did you in any way change the log level?
|
14:36:30
|
<kavuri> dkayiwa: sorry! its catalina.out
|
14:36:37
|
<kavuri> dkayiwa: no
|
14:36:44
|
<dkayiwa> kavuri: what value has it?
|
14:36:55
|
<kavuri> dkayiwa: the log level? It is at info level
|
14:37:09
|
<dkayiwa> kavuri: and browser still hanging?
|
14:37:14
|
<kavuri> dkayiwa: yes
|
14:37:33
|
<dkayiwa> kavuri: do you have any data in the database that you do not want to lose?
|
14:37:36
|
<kavuri> dkayiwa: at one point of time, I left it for 1hr and the browser is still in the same state
|
14:37:48
|
<kavuri> dkayiwa: no, I can erase the database if needed
|
14:37:56
|
<kavuri> dkayiwa: this is a test system
|
14:38:04
|
<dkayiwa> kavuri: can you drop the database
|
14:38:19
|
<kavuri> dkayiwa: ok. Guess I should stop the tomcat server?
|
14:38:21
|
<dkayiwa> kavuri: then do a fresh setup of openmrs wizard
|
14:38:25
|
<dkayiwa> kavuri: yes
|
14:38:37
|
<dkayiwa> kavuri: after which you try install the module again
|
14:39:13
|
<kavuri> dkayiwa: ok
|
14:40:20
|
<dkayiwa> k-joseph: are you there?
|
14:42:49
|
<k-joseph> dkayiwa: i understand it is about creating a new class that extends APIException, this class handles the APIException error message thrown by ValidateUtil.validate() ??, and am not figuring out the way of doing this yet, i think i would to better when openned my brain the whole idear behind
|
14:44:17
|
<dkayiwa> k-joseph: can you start by simply creating the class?
|
14:44:43
|
<k-joseph> dkayiwa: under which package!
|
14:45:06
|
<dkayiwa> k-joseph: same package as for APIException
|
14:45:13
|
<k-joseph> dkayiwa: ok
|
14:46:09
|
<dkayiwa> k-joseph: do you see where ValidateUtil.validate() throws the APIException?
|
14:46:28
|
<k-joseph> dkayiwa: yes i do
|
14:47:12
|
<dkayiwa> k-joseph: simply replace that with your new exception class
|
14:47:17
|
<dkayiwa> k-joseph: does it make sense?
|
14:47:46
|
<k-joseph> dkayiwa: an instance to my class?
|
14:48:18
|
<dkayiwa> k-joseph: make the class throw an exception of your class instead of the existing APIException
|
14:49:38
|
<k-joseph> dkayiwa: what is the best name to give the class
|
14:50:18
|
<dkayiwa> k-joseph: don't you see that mentioned on the ticket?
|
14:50:58
|
<k-joseph> dkayiwa: ok seen that sorry.
|
14:53:03
|
<kavuri> dkayiwa: its the same problem
|
14:53:18
|
<dkayiwa> kavuri: is browser still hanging?
|
14:53:24
|
<kavuri> dkayiwa: yes
|
14:54:04
|
<kavuri> dkayiwa: during installation of openmrs, there is an option called, update module database on deploying a module, should this be enabled?
|
14:54:16
|
<dkayiwa> kavuri: yes
|
14:54:26
|
<kavuri> dkayiwa: always? This option looks optional
|
14:54:26
|
<dkayiwa> kavuri: did you?
|
14:54:30
|
<kavuri> dkayiwa: no, I did not
|
14:54:36
|
<kavuri> dkayiwa: will try enabling it
|
14:54:43
|
<dkayiwa> kavuri: so trying again?
|
14:54:47
|
<kavuri> dkayiwa: yes
|
14:54:51
|
<dkayiwa> kavuri: ok
|
14:55:07
|
<dkayiwa> kavuri: why dont you use the Simple Install Method?
|
14:55:14
|
<k-joseph> dkayiwa: i have this throw new ValidationException(exceptionMessage, errors.getCause()); i need to implement this in the class?
|
14:55:44
|
<dkayiwa> k-joseph: am not sure i understand your question
|
14:56:21
|
<kavuri> dkayiwa: because the message against the simple install mentions it as suitable for a single machine
|
14:56:38
|
<dkayiwa> kavuri: just for troubleshooting
|
14:56:54
|
<dkayiwa> kavuri: we just want to confirm whether its not a problem with your installation options
|
14:56:54
|
<kavuri> dkayiwa: ok, will try that after giving one more try of 'advanced'
|
14:57:14
|
<k-joseph> dkayiwa: i need to write the code in ValidationException class, to work upon this!!!
|
14:57:22
|
*** wyclif has quit IRC
|
14:57:42
|
<dkayiwa> k-joseph: start by doing what you think
|
14:58:04
|
<k-joseph> dkayiwa: ok trying
|
14:58:55
|
*** wyclif has joined #openmrs
|
15:02:52
|
<cpower> Hello!
|
15:02:58
|
*** andrea_ has joined #openmrs
|
15:03:02
|
<cpower> Let's do the scrum thing shall we?
|
15:03:21
|
<cpower> !scrumon cpower
|
15:03:21
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:03:54
|
<cpower> Order: rafa, andrea_, dkayiwa, wyclif and anyone else who's interested
|
15:04:05
|
<rafa> Today:
|
15:04:05
|
<rafa> * Investigated memory leaks in core TRUNK-3879: Two session factories when running OpenMRS
|
15:04:05
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3879
|
15:04:05
|
<rafa> * Reviewed sprint tickets
|
15:04:05
|
<rafa> No blockers.
|
15:04:22
|
<andrea_> Thursday
|
15:04:22
|
<andrea_> Dev call
|
15:04:22
|
<andrea_> Sprint-201301
|
15:04:22
|
<andrea_> Report-415
|
15:04:22
|
<andrea_> Code for Preview button and Preview page
|
15:04:22
|
<andrea_> Tested changes in UI
|
15:04:24
|
<andrea_> Everything looks good
|
15:04:26
|
<andrea_> New pull request in github
|
15:04:28
|
<andrea_> emails
|
15:04:30
|
<andrea_> Friday
|
15:04:32
|
<andrea_> Report-415
|
15:04:34
|
<andrea_> Squash commits
|
15:04:36
|
<andrea_> Finish putting system on new computer
|
15:04:38
|
<andrea_> No Blockers
|
15:04:47
|
<dkayiwa> Investigated PrivilegeListener notifications causing database flushes bug
|
15:04:48
|
<dkayiwa> Did more reviews for Tobin's team code for appointment module
|
15:04:48
|
<dkayiwa> Did more review for: Attempting to save an alert without text should display a more user friendly error message - TRUNK-2975
|
15:04:48
|
<dkayiwa> Now its time to work on: The Run Report page is unable to load with parameters that default to expression values - REPORT-419
|
15:04:48
|
<dkayiwa> No Blockers
|
15:05:56
|
<cpower> wyclif...
|
15:05:56
|
*** mseaton has joined #openmrs
|
15:06:10
|
<wyclif> Thursday:
|
15:06:10
|
<wyclif> dev list emails
|
15:06:10
|
<wyclif> dev call
|
15:06:10
|
<wyclif> Meeting with Ada, Jer and Lauren around the design of TRUNK-3841 - Create a complex obs handler to store value of the "relationships" complex observation
|
15:06:10
|
<wyclif> Commit code for REPORT-247 - Spaces or underscores in any of the "Searches to Combine" CohortDefinition keys breaks Composition String in CompositionQuery
|
15:06:12
|
<wyclif>
|
15:06:14
|
<wyclif> Friday:
|
15:06:16
|
<wyclif> REPORT-237 - Change ReportDesign to reference ReportDefinition by uuid rather than by foreign key to serialized object
|
15:06:21
|
<wyclif>
|
15:06:23
|
<wyclif> Blockers: None
|
15:06:39
|
<cpower> No blockers, no discussion topics
|
15:06:57
|
<mseaton> cpower: sorry i'm late. no blockers here either
|
15:06:58
|
<cpower> !scrumoff
|
15:06:58
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:07:03
|
<cpower> no worries
|
15:10:23
|
<k-joseph> dkayiwa: please see this http://pastebin.com/E8F2t9qK
|
15:26:09
|
<dkayiwa> k-joseph: looks good. add some class javadoc
|
15:26:21
|
<dkayiwa> k-joseph: will continue tomorrow night :)
|
15:26:26
|
*** k-joseph has quit IRC
|
15:31:06
|
*** dkayiwa has quit IRC
|
15:43:15
|
*** wyclif has quit IRC
|
15:48:39
|
*** cpower has quit IRC
|
15:49:09
|
*** kavuri has quit IRC
|
15:56:40
|
*** robbyoconnor has quit IRC
|
16:11:49
|
*** adam_l has joined #openmrs
|
16:13:47
|
*** mseaton has quit IRC
|
16:14:37
|
*** ekow has quit IRC
|
16:14:59
|
*** wyclif has joined #openmrs
|
16:17:12
|
*** andrea_ has quit IRC
|
16:20:11
|
<adam_l> wyclif: Hi :) can I ask you a question about portlets?
|
16:24:19
|
<adam_l> some one here can please tell me how to connect a portlet to its controller?
|
16:25:12
|
<wyclif> hi adam_l
|
16:27:14
|
<adam_l> wyclif: Hi I have a portlet and a controller but I don't know how to connect between the two.
|
16:29:27
|
<adam_l> wyclif: because I have model attribute in the controller that recognized as null. I thought the connection is made authomatically via class name or something.
|
16:29:38
|
<wyclif> adam_l, you need to set the url mapping on the controller to "yourForm.portlet"
|
16:29:57
|
<wyclif> and you need to have your controller extend PortletController
|
16:30:19
|
<adam_l> wyclif: yes I did that but not mapped the url
|
16:30:36
|
<adam_l> wyclif: I map it in the config.xml?
|
16:30:41
|
<wyclif> adam_l, portlets were authored in the spring 2.x days so the examples i know of use the xml config
|
16:31:13
|
<adam_l> wyclif: ok
|
16:31:20
|
<wyclif> adam_l, you might be the first to do from an annotated controller and am not sure if it will work but it is worth a try
|
16:31:43
|
<wyclif> adam_l, you could go with the tested and proven xml based one by doing as below:
|
16:31:50
|
*** djazayeri has joined #openmrs
|
16:31:50
|
*** ChanServ sets mode: +o djazayeri
|
16:32:45
|
*** kishoreyekkanti has joined #openmrs
|
16:33:16
|
<adam_l> wyclif: so all the portlets use ajax calls? or DWR?
|
16:34:08
|
<wyclif> try:
|
16:34:09
|
<wyclif> <bean id="myPortletUrlMapping"
|
16:34:09
|
<wyclif> class="org.springframework.web.servlet.handler.SimpleUrlHandlerMapping">
|
16:34:09
|
<wyclif> <property name="order">
|
16:34:09
|
<wyclif> <value>1</value>
|
16:34:09
|
<wyclif> </property>
|
16:34:11
|
<wyclif> <property name="mappings">
|
16:34:13
|
<wyclif> <props>
|
16:34:15
|
<wyclif> <prop key="**/myForm.portlet">myPortletController</prop>
|
16:34:17
|
<wyclif> </props>
|
16:34:19
|
<wyclif> </property>
|
16:34:21
|
<wyclif> </bean>
|
16:34:23
|
<wyclif> <bean id="myPortletController" class="org.mymodule.MyPortletController"></bean>
|
16:34:33
|
<wyclif> adam_l, put that in your webModuleAPplicationContext
|
16:34:45
|
<wyclif> adam_l, and edit the what you need to
|
16:35:45
|
<adam_l> wyclif: ok thanks! I will try it out
|
16:35:56
|
<wyclif> adam_l, see https://wiki.openmrs.org/display/docs/Module+Portlets
|
16:37:04
|
<adam_l> wyclif: ok
|
16:44:01
|
*** robbyoconnor has joined #openmrs
|
16:44:01
|
*** ChanServ sets mode: +v robbyoconnor
|
16:48:43
|
*** rafa has quit IRC
|
16:51:52
|
<adam_l> wyclif: Thanks! it's working :))))
|
16:54:47
|
*** rafa has joined #openmrs
|
16:54:47
|
*** ChanServ sets mode: +v rafa
|
16:56:04
|
<wyclif> hi djazayeri
|
16:56:17
|
<djazayeri> hi wyclif
|
16:56:27
|
<wyclif> am working on https://tickets.openmrs.org/browse/REPORT-237
|
16:56:36
|
<wyclif> djazayeri, and i need come clarification
|
16:57:16
|
<wyclif> djazayeri, does it mean, we deprecation getters/setters for ReportDefinition
|
16:58:27
|
<djazayeri> wyclif: I think it means changing the serializers...
|
16:58:40
|
<wyclif> djazayeri, and then add ReportDefinitionService.getReportDefinition(ReportDesign rd)?
|
16:59:43
|
<djazayeri> wyclif: I think the point is that when doing serialization, we want to serialize the references by uuid, not by id.
|
16:59:48
|
<wyclif> djazayeri, yeah i figured that, looks to me like ReportDefinitionType has to change to use uuid and not id
|
17:00:13
|
<djazayeri> wyclif: oh, wait, maybe I'm wrong on thatâ¦is there a report_design table?
|
17:00:20
|
<wyclif> djazayeri, yes
|
17:00:51
|
<wyclif> djazayeri, because we need to change the forein key references to be by uuid
|
17:01:00
|
*** rafa has quit IRC
|
17:01:04
|
<djazayeri> wyclif: okay, so *that* would need to change so that it doesn't refer to report_definition_id (which points to serialized object), but to store a uuid that's the report_definition
|
17:01:20
|
<djazayeri> wyclif: can you email Mike and see if he's around but just forgot to turn on irc?
|
17:01:28
|
<wyclif> djazayeri, okay
|
17:01:43
|
*** nribeka has joined #openmrs
|
17:01:43
|
*** ChanServ sets mode: +v nribeka
|
17:15:21
|
<adam_l> wyclif: Apparently the controller is called and the ModelAttributes are updated (did a debug) but they are not reflected in the protlet jsp. Do you know why?
|
17:16:09
|
<wyclif> adam_l, portlet controllers differ from other regular spring controllers
|
17:17:16
|
<wyclif> adam_l, all data you need to access in the jsp, should be added to the model object passed to the populateModel method
|
17:17:36
|
<wyclif> adam_l, and you access it in the jsp as model.myAttributeName
|
17:17:45
|
<adam_l> wyclif: I noticed that and I used populateModel(HttpServletRequest request, Map<String, Object> model) method to put the model attribute to the map. isn't it the right way to do it?
|
17:18:14
|
<adam_l> wyclif: OK so the access is wrong
|
17:18:21
|
<wyclif> admare you saying you can't access the data in the model
|
17:18:36
|
<wyclif> adam_l, you have to use ${modeul.attributeName}
|
17:18:46
|
<wyclif> adam_l, sorry! you have to use ${model.attributeName}
|
17:19:15
|
<adam_l> wyclif: yes ok I get it now . thanks
|
17:19:28
|
<wyclif> adam_l, cool
|
17:20:00
|
*** ningosi has joined #openmrs
|
17:20:07
|
<adam_l> wyclif: man you're faster than google :)
|
17:20:13
|
<wyclif> adam_l, ha ha ha
|
17:20:22
|
*** ningosi is now known as Ojwanganto
|
17:20:23
|
<wyclif> adam_l, that's not true
|
17:22:53
|
<adam_l> wyclif: ok :) but you did helpled me alot and I appreciate it
|
17:23:07
|
<wyclif> adam_l, np
|
17:26:34
|
*** evmw has joined #openmrs
|
17:29:24
|
*** Ojwanganto has quit IRC
|
17:38:57
|
<nribeka> anyone knows how to solve the unknown entity exception in unit test after we use maven?
|
17:41:38
|
*** nribeka has quit IRC
|
17:42:09
|
*** nribeka has joined #openmrs
|
17:42:09
|
*** ChanServ sets mode: +v nribeka
|
17:49:13
|
<djazayeri> nribeka: have you set up a TestingApplicationContext.xml and test-hibernate.cfg.xml ?
|
18:02:00
|
<nribeka> djazayeri, where can i get a sample of them? i don't think the wizard generate them
|
18:02:57
|
<djazayeri> nribeka: look in almost any mavenized module in github. :-) An arbitrary example, taht I happen to have open now, is github.com/PIH/openmrs-module-emr
|
18:03:39
|
<nribeka> i wonder why the wizard stop generating them. i know the wizard generate them a while back
|
18:06:04
|
*** kishoreyekkanti has quit IRC
|
18:22:45
|
*** kishoreyekkanti has joined #openmrs
|
18:29:46
|
*** mseaton has joined #openmrs
|
18:29:46
|
*** ChanServ sets mode: +v mseaton
|
18:37:07
|
*** adam_l has quit IRC
|
18:39:34
|
<mseaton> wyclif: did you want to talk?
|
18:39:50
|
<mseaton> wyclif: i have about 30 minutes before i have to drop off again
|
18:40:15
|
<wyclif> mseaton, sure
|
18:40:22
|
<wyclif> so you want to skype?
|
18:40:28
|
<wyclif> do you want to skype?
|
18:40:40
|
<mseaton> wyclif: how about just on irc?
|
18:40:47
|
<wyclif> ok fine
|
18:41:03
|
<wyclif> djazayeri, does it mean, we deprecation getters/setters for ReportDefinition
|
18:41:12
|
<wyclif> mseaton, , does it mean, we deprecation getters/setters for ReportDefinition
|
18:41:22
|
<mseaton> wyclif: remind me what ticket?
|
18:41:42
|
<wyclif> mseaton, https://tickets.openmrs.org/browse/REPORT-237
|
18:41:55
|
<wyclif> mseaton, , and then add ReportDefinitionService.getReportDefinition(ReportDesign rd)?
|
18:42:25
|
<wyclif> mseaton, i know that ReportDefinitionType needs to be updated to use uuid instead of id
|
18:43:19
|
<mseaton> wyclif: i don't think the api needs to change at all, from what i remember
|
18:44:27
|
<mseaton> reportdesign currently has a reportdefinition property, and it will continue to have this
|
18:45:25
|
<mseaton> it's just that the reporting_report_design table should look up the report definition it is associated with via uuid, not by id
|
18:47:48
|
<wyclif> mseaton, so you are saying the foreign key should be on uuid and not id?
|
18:48:07
|
<mseaton> wyclif: well, there is no "foreign key" per se.
|
18:48:35
|
<wyclif> mseaton, you are using the ReportDefinitionType
|
18:48:51
|
<mseaton> wyclif: let me look. just a sec
|
18:48:53
|
<wyclif> mseaton, which uses id as if it were a foreign key
|
18:50:17
|
<mseaton> wyclif: ok, great. so this is easier than i remembered.
|
18:51:03
|
<mseaton> wyclif: assuming ReportDesign is the only thing that uses this UserType, then we can just change the implementation in that to get ReportDefinition by UUID and to set the db column based on UUID, instead of id.
|
18:51:32
|
<mseaton> wyclif: the big change will obviously be that we need to change the column at the db level from an integer to a varchar, and do a data migration from ids to uuids
|
18:51:56
|
<mseaton> wyclif: make sense?
|
18:53:55
|
<wyclif> mseaton, sure
|
18:54:23
|
<mseaton> wyclif: so probably a few line change in code in ReportDefinitionType, and a custom liquibase changeset will do the trick?
|
18:54:46
|
<wyclif> mseaton, so what's up with the in memory uuids
|
18:56:07
|
<mseaton> wyclif: the point is that if i want to build a report in memory, run it, and render it to a renderer that requires a report design file, and never save these objects to the database, i currently can't do this successfully... so this change will enable this to work.
|
18:56:25
|
<wyclif> mseaton, ok
|
18:57:20
|
<mseaton> wyclif: there are workarounds we have employed in the past, but they involve overwriting the ReportDesign.getReportDefinition() method in a custom inner class usually. see unit tests that do this for examples. this ticket will allow this to work without that "hack".
|
18:58:21
|
<wyclif> mseaton, ok
|
18:58:37
|
<wyclif> mseaton, one more question
|
19:02:44
|
<wyclif> mseaton, i thought uuid as a property on reportDesign, it is already serialized along, so we don't need to update exisiting serialized data
|
19:08:24
|
<mseaton> wyclif: report design has it's own uuid. i'm talking about the reportdefinition uuid.
|
19:08:47
|
<mseaton> it's not serialized data we need to update.
|
19:09:16
|
<mseaton> wyclif: it's the reporting_report_design.report_definition_id that will no longer work.
|
19:10:03
|
<mseaton> wyclif: so we either need to change that column to be a varchar and contain the report definition _uuid_, or we need to create a new column "report_definition_uuid", put the report definition uuid in there, and then drop the "report_definition_id" column.
|
19:10:19
|
<mseaton> wyclif: gotta run. ping djazayeri if this doesn't make sense in my absence.
|
19:10:22
|
*** mseaton has left #openmrs
|
19:11:42
|
*** rafa has joined #openmrs
|
19:11:42
|
*** ChanServ sets mode: +v rafa
|
19:15:08
|
<djazayeri> I think I get it, if you need clarification, wyclif
|
19:17:22
|
*** djazayeri1 has joined #openmrs
|
19:18:54
|
<wyclif> djazayeri, i get it
|
19:20:36
|
*** djazayeri has quit IRC
|
19:20:47
|
*** rafa has quit IRC
|
19:32:33
|
*** djazayeri1 is now known as djazayeri
|
19:33:13
|
*** mario_ has joined #openmrs
|
19:40:19
|
*** nutsiepully has joined #openmrs
|
19:59:34
|
*** kishoreyekkanti has quit IRC
|
20:00:43
|
*** tobin_g has joined #openmrs
|
20:07:46
|
*** nribeka has quit IRC
|
20:08:08
|
<tobin_g> hey djazayeri time for a quick question?
|
20:08:54
|
<djazayeri> tobin_g: a quick one!
|
20:09:09
|
<tobin_g> I've been writing a groovy script to merge multiple users. Everything seems to be working but just want to make sure I properly understand providers which have changed from 1.8 to 1.9
|
20:10:01
|
<tobin_g> In either case updating all fields in the database related to user_id is not enough, provider needs to also be done which in 1.8 is related to person_id and in 1.9 is related to the provider table
|
20:10:49
|
<tobin_g> djazayeri: sorry didn't tag you in the last two comments. this is what I wrote, you can see the commented out area for 1.8 versus 1.9 http://pastebin.com/2NRVtFKB
|
20:11:21
|
<djazayeri> tobin_g: are you merging the persons that underlie the user rows also?
|
20:11:41
|
<tobin_g> djazayeri: hadn't planned on it but I suppose maybe I should?
|
20:12:06
|
<tobin_g> djazayeri: perhaps that would be the smarter way to go than try to figure out everything else I may have missed?
|
20:13:01
|
<tobin_g> djazayeri: (although it seems that provider is the main sticking point)
|
20:13:22
|
<djazayeri> tobin_g: if you just merge the users together, that will "work" in a self-contained way. but you'll also end up with an orphan person record for the "losing" user.
|
20:13:47
|
<djazayeri> tobin_g: you probably also want to merge the providers that belong to that person
|
20:14:16
|
<tobin_g> djazayeri: right, assuming it's a 1.9
|
20:14:34
|
<tobin_g> djazayeri: so for 1.9 i think i'll merge providers, then maybe delete the person at the end of the script
|
20:14:42
|
<djazayeri> tobin_g: that should work
|
20:14:56
|
<tobin_g> djazayeri: there's no reason the person should be a patient in our implementation anyways
|
20:15:01
|
<djazayeri> tobin_g: and "merge providers" would basically mean that everything in encounter_provider needs to be pointed to the winning provider
|
20:16:27
|
<tobin_g> djazayeri: i suppose that's better than just changing the person_id in the providers table
|
20:17:00
|
<djazayeri> tobin_g: if you do that, you'll end up with two "providers" for that person. The data model allows it, but code has generally not been tested for that cse.
|
20:17:41
|
<tobin_g> djazayeri: yes, that makes sense. i assume the api has stuff for dealing with providers?
|
20:17:53
|
<djazayeri> tobin_g: yes
|
20:18:45
|
<tobin_g> djazayeri: last question - assuming I fix this before I do our upgrade to 1.9 (tomorrow), it might be easier to fix in 1.8 because there are no providers right? the encounter_provider is just a link to person?
|
20:19:11
|
<tobin_g> djazayeri: from what I can tell on upgrading the database it automatically sets all users with a provider role to be "providers" in the new data model
|
20:19:13
|
<djazayeri> tobin_g: oh! yeah, just do it in 1.8 before the upgrade, and you odn't have to worry about that
|
20:19:54
|
<tobin_g> djazayeri: i noticed that providers are not automatically created in 1.9 when a new user is created, even if they have a "role" of provider.
|
20:20:25
|
<tobin_g> djazayeri: Not necessarily a bug but confusing. Anyways I'll let you get on with it thanks for the help.
|
20:20:36
|
<djazayeri> tobin_g: yeah; that's unfortunate; I agree it's confusing
|
20:21:08
|
<djazayeri> tobin_g: in theory in 1.9 you should no longer have a "Provider" role. You should be using the Providers table instead
|
20:21:20
|
<djazayeri> tobin_g: though that required updating your forms.
|
20:21:59
|
<tobin_g> djazayeri: thanks for that hint - I need to look @ that
|
20:22:45
|
<tobin_g> djazayeri: the appointment module was built around 1.9 and uses providers, since we're starting the pilot this week gotta have 1.9 working :D
|
20:50:50
|
*** mario_ has quit IRC
|
20:51:00
|
*** djazayeri1 has joined #openmrs
|
20:53:55
|
*** djazayeri has quit IRC
|
21:17:00
|
*** djazayeri1 is now known as djazayeri
|
21:17:52
|
*** ekow has joined #openmrs
|
21:18:01
|
<ekow> Hi Darius ..
|
21:18:57
|
*** djazayeri1 has joined #openmrs
|
21:19:31
|
<djazayeri1> hi ekow
|
21:20:37
|
<ekow> I have been told you are the brains behind ...https://demo.kenyaemr.org/openmrs/index.htm?
|
21:22:09
|
<djazayeri1> ekow: I was the original architect. Now it's being developed by others.
|
21:22:41
|
<ekow> The story is ... Swazio has not yet decided on which PMIS to implement. However my group has been tasked with developing something for testing and I am hoping we could use somethjing exactly like that without the logo and Kenya stuff
|
21:22:44
|
*** djazayeri has quit IRC
|
21:23:53
|
<djazayeri1> ekow: the code is open source
|
21:24:26
|
<djazayeri1> ekow: we don't have great instructions about how to set up and modify it, but we do have some
|
21:24:39
|
<ekow> Thanks Darius. I know. Where do I get this particular version and how do I twek it?
|
21:25:33
|
<djazayeri1> ekow: the code is at https://github.com/I-TECH/openmrs-module-kenyaemr
|
21:25:37
|
<OpenMRSBot> <http://ln-s.net/+U2G> (at github.com)
|
21:25:57
|
<djazayeri1> ekow: Email kenyaemr-developers@googlegroups.com to ask for advice about how to set it up
|
21:26:25
|
<djazayeri1> ekow: I have to run shortly to the airport, but I'm on that list too.
|
21:26:30
|
<ekow> You are a star. Thank you. !
|
21:26:30
|
*** tobin_g has quit IRC
|
21:26:51
|
*** tobin_g has joined #openmrs
|
21:45:59
|
*** ekow has quit IRC
|
22:01:14
|
*** jkeiper has quit IRC
|
22:04:07
|
*** mseaton has joined #openmrs
|
22:04:07
|
*** ChanServ sets mode: +v mseaton
|
22:17:32
|
*** nutsiepully has quit IRC
|
22:26:15
|
*** wyclif has quit IRC
|
22:30:41
|
*** mseaton has quit IRC
|
22:30:44
|
*** tobin_g has quit IRC
|
22:56:13
|
*** tobin_g has joined #openmrs
|
23:22:00
|
*** djazayeri1 has quit IRC
|
23:30:13
|
*** wyclif has joined #openmrs
|
23:43:46
|
*** tobin_g has quit IRC
|
23:54:41
|
*** mseaton has joined #openmrs
|
23:54:41
|
*** ChanServ sets mode: +v mseaton
|