| 00:22:12 | *** wyclif has quit IRC |
| 00:44:24 | *** basic` is now known as basic |
| 00:56:15 | *** basic is now known as basic` |
| 00:58:45 | *** mseaton has joined #openmrs |
| 00:58:45 | *** ChanServ sets mode: +v mseaton |
| 00:59:00 | *** mseaton has quit IRC |
| 02:02:22 | *** kevin has joined #openmrs |
| 02:36:29 | *** jkeiper has joined #openmrs |
| 02:36:29 | *** ChanServ sets mode: +v jkeiper |
| 03:23:15 | *** wyclif has joined #openmrs |
| 03:48:36 | *** kavuri has joined #openmrs |
| 03:48:47 | <kavuri> djazayeri1: hi |
| 04:03:44 | *** jkeiper has quit IRC |
| 04:34:02 | *** djazayeri1 has quit IRC |
| 04:34:55 | *** djazayeri has joined #openmrs |
| 04:34:55 | *** ChanServ sets mode: +o djazayeri |
| 04:44:43 | *** LVW has joined #openmrs |
| 04:58:52 | *** shangxiao has joined #openmrs |
| 05:25:45 | *** shangxiao has quit IRC |
| 05:37:59 | *** djazayeri has quit IRC |
| 05:48:05 | *** k-joseph has joined #openmrs |
| 05:54:34 | *** kishoreyekkanti has joined #openmrs |
| 06:00:27 | *** r0bby has joined #openmrs |
| 06:00:27 | *** ChanServ sets mode: +v r0bby |
| 06:00:32 | *** robbyoconnor has quit IRC |
| 06:07:59 | *** LVW has quit IRC |
| 06:59:15 | *** k-joseph has quit IRC |
| 06:59:46 | *** r0bby has quit IRC |
| 07:00:14 | *** r0bby has joined #openmrs |
| 07:00:14 | *** ChanServ sets mode: +v r0bby |
| 07:23:41 | *** r0bby is now known as robbyoconnor |
| 08:14:17 | *** ekow has joined #openmrs |
| 08:15:40 | <ekow> Hi Guys, we have an opprtunity to sell OpenMRS here in Swazi. We are being requested to 'redesign' a simple PMIS with some few modules. Anyone done minimal customization lately? |
| 08:16:22 | <ekow> Hi Wyclif .... how are you doing? |
| 08:23:32 | *** kavuri has quit IRC |
| 08:27:32 | *** kavuri has joined #openmrs |
| 08:33:32 | *** kavuri has quit IRC |
| 10:02:51 | *** rafa has joined #openmrs |
| 10:02:51 | *** ChanServ sets mode: +v rafa |
| 10:09:57 | *** dkayiwa has joined #openmrs |
| 10:34:06 | *** k-joseph has joined #openmrs |
| 10:37:06 | <k-joseph> dkayiwa: hi |
| 10:37:12 | <dkayiwa> k-joseph: hi |
| 10:44:09 | *** k-joseph_ has joined #openmrs |
| 10:45:21 | *** Guna has joined #openmrs |
| 10:47:32 | *** k-joseph has quit IRC |
| 10:48:46 | <dkayiwa> k-joseph_: did you choose a ticket? |
| 10:49:02 | <k-joseph_> dkayiwa: looking for one. |
| 10:49:07 | <dkayiwa> k-joseph_: ok |
| 10:49:14 | *** k-joseph_ is now known as k-joseph |
| 11:18:45 | <dkayiwa> hi k-joseph |
| 11:18:59 | <k-joseph> dkayiwa: hi |
| 11:19:00 | <dkayiwa> k-joseph: can you work on this? TRUNK-2897 |
| 11:19:04 | <dkayiwa> !ticket TRUNK-2897 |
| 11:19:05 | <OpenMRSBot> dkayiwa: [#TRUNK-2897] Add a ValidationException class - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2897 |
| 11:20:54 | <dkayiwa> k-joseph: can you also do this one? TRUNK-2975 |
| 11:20:57 | <dkayiwa> !ticket TRUNK-2975 |
| 11:20:58 | <OpenMRSBot> dkayiwa: [#TRUNK-2975] Attempting to save an alert without text should display a more user friendly error message - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2975 |
| 11:21:14 | <dkayiwa> k-joseph: in otherwards, claim both tickets and work on them |
| 11:24:41 | <dkayiwa> k-joseph: are you there? |
| 11:26:05 | *** k-joseph has quit IRC |
| 11:29:26 | *** kavuri has joined #openmrs |
| 11:30:38 | *** k-joseph has joined #openmrs |
| 11:34:25 | <dkayiwa> hi k-joseph |
| 11:35:31 | <dkayiwa> k-joseph: have you seen the two tickets? |
| 11:37:07 | *** k-joseph has quit IRC |
| 11:37:08 | *** dkayiwa has quit IRC |
| 11:37:39 | *** Sateesh has joined #openmrs |
| 11:38:10 | *** kavuri has quit IRC |
| 11:45:10 | *** dkayiwa has joined #openmrs |
| 11:49:34 | *** Sateesh has quit IRC |
| 11:49:44 | *** kavuri has joined #openmrs |
| 11:56:14 | *** dkayiwa_ has joined #openmrs |
| 11:57:29 | *** dkayiwa has quit IRC |
| 11:57:30 | *** dkayiwa_ is now known as dkayiwa |
| 12:17:56 | *** kavuri has quit IRC |
| 12:21:47 | *** kavuri has joined #openmrs |
| 12:22:02 | *** jkeiper has joined #openmrs |
| 12:22:02 | *** ChanServ sets mode: +v jkeiper |
| 12:29:08 | *** jkeiper has quit IRC |
| 12:46:42 | *** ekow has quit IRC |
| 12:49:45 | *** k-joseph has joined #openmrs |
| 12:51:27 | *** GGna has joined #openmrs |
| 12:51:36 | <GGna> how to |
| 12:52:15 | <GGna> How to change i put my companies logo on the pages vs the OpenMRS |
| 12:52:46 | <GGna> any one can guide me |
| 12:52:59 | <GGna> i m eagerly waiting |
| 12:54:26 | <dkayiwa> GGna: have you looked at this? https://wiki.openmrs.org/display/docs/Custom+Branding+Module |
| 12:58:46 | <GGna> after Administration selection which one i want to select ,( dkayiwa) |
| 12:59:03 | <dkayiwa> GGna: you select your local images |
| 12:59:32 | *** k-joseph_ has joined #openmrs |
| 13:00:43 | <GGna> its in Logic Module?? |
| 13:01:07 | <dkayiwa> GGna: you need to download and install the module from the module repository |
| 13:01:17 | *** k-joseph has quit IRC |
| 13:01:32 | *** k-joseph_ is now known as k-joseph |
| 13:03:51 | <GGna> today only i started Open MRS so can u pls guide to change my companies logo on theindex page where can i start |
| 13:05:29 | <dkayiwa> GGna: can you start by downloading the module from: https://modules.openmrs.org/modules/list.jsp |
| 13:05:39 | <dkayiwa> hi k-joseph |
| 13:05:52 | <k-joseph> dkayiwa: hi |
| 13:06:02 | <dkayiwa> k-joseph: did you see the two tickets? |
| 13:06:46 | <k-joseph> dkayiwa: yes, has been having some network failures, looking at TRUNK-2975 now |
| 13:07:21 | <dkayiwa> k-joseph: claim them both |
| 13:07:28 | <k-joseph> dkayiwa: ok |
| 13:08:42 | <dkayiwa> GGna: we use IRC such that others can also help. i do not know everything :) |
| 13:12:56 | <GGna> in that which module i want to download?? |
| 13:13:01 | <dkayiwa> GGna: we prefer using this IRC channel to skype because we need others to also share in helping and solutions |
| 13:13:12 | <dkayiwa> GGna: look for the custom branding module |
| 13:15:18 | *** kavuri has quit IRC |
| 13:18:07 | <GGna> ya daniael i have downloaded custom branding module from where can i install that module for that where i want to go?? |
| 13:18:27 | <dkayiwa> k-joseph: hi |
| 13:18:35 | <k-joseph> dkayiwa: hi |
| 13:18:36 | <k-joseph> dkayiwa: finished claim, while establishing the problem of TRUNK-2975 , am not establishing that error message on the ticket when i save the alert without entering alert text |
| 13:18:48 | <dkayiwa> k-joseph: can you help GGna on how to install the module? |
| 13:18:58 | <k-joseph> dkayiwa: ok |
| 13:19:20 | <k-joseph> GGna: hi |
| 13:20:02 | <k-joseph> GGna: have you downloaded the .omod version of the module? |
| 13:20:07 | <GGna> hi joseph |
| 13:20:22 | <dkayiwa> GGna: use the nick name as it appears here |
| 13:20:47 | <GGna> ok <dkayiwa> |
| 13:22:01 | <GGna> yeah <k-joseph> i have downloaded .omod version only |
| 13:22:13 | <k-joseph> GGna: ok, |
| 13:23:07 | <k-joseph> GGna: now go to the administration page? |
| 13:23:41 | <k-joseph> GGna: go under Modules, select manage modules |
| 13:23:57 | <GGna> ya |
| 13:24:55 | <k-joseph> GGna: on the page that has openned up, do you see a button that has Add or uograde module, click that |
| 13:25:44 | <k-joseph> GGna: on the popup window go under Add Module |
| 13:26:05 | <k-joseph> GGna: are we together? |
| 13:26:40 | <GGna> ya i have browse(custombranding-0.2). |
| 13:27:40 | <k-joseph> GGna: ?? |
| 13:27:48 | <GGna> in that Add Module i have browse(custombranding-0.2). |
| 13:28:30 | <GGna> whwt about Upgrade An Existing Module column?? |
| 13:28:31 | <k-joseph> GGna: if you are there, now go ahead and click the button that has Choose under Add Module |
| 13:28:54 | <k-joseph> GGnna? leave that one for this moment |
| 13:29:16 | <k-joseph> GGna: having clicked the button |
| 13:29:24 | <GGna> ok |
| 13:30:09 | <GGna> now Custom Branding module is comming under module list |
| 13:30:10 | <k-joseph> GGna: in the popup window locate where the file that has the extension .omod of the mdule you have down loaded is |
| 13:30:39 | <k-joseph> GGna: are we together |
| 13:31:11 | <GGna> are we together?? |
| 13:31:29 | <GGna> i m not get u |
| 13:32:15 | <k-joseph> GGna: ok, did you click Choose under Add Module? |
| 13:32:26 | <GGna> yeah |
| 13:32:52 | <GGna> its comming under Manage Modules |
| 13:33:18 | <k-joseph> GGna: yes |
| 13:34:19 | <k-joseph> GGna: look at this, http://snag.gy/LMw57.jpg do you have this |
| 13:35:16 | <k-joseph> GGna: when you go to manage modules and click the Add or Upgrade module button? |
| 13:36:12 | <GGna> ya i hav that one and i have browse custombranding module also |
| 13:38:48 | <GGna> next <k-joseph>?? |
| 13:39:12 | <k-joseph> GGna: now locate and select the .omod module file you downloaded, and click open, see http://snag.gy/uis3P.jpg |
| 13:40:33 | <GGna> yes i hav uploaded. |
| 13:40:53 | <k-joseph> GGna: good, |
| 13:41:26 | <k-joseph> GGna: do you see an alert message on top of the page that show it was successfull? |
| 13:41:34 | <k-joseph> dkayiwa: hi |
| 13:41:38 | <dkayiwa> k-joseph: hi |
| 13:41:42 | <k-joseph> dkayiwa: am not getting the error message recorded on the ticket TRUNK-2975, when i save with out entering the alert text the error i get is http://snag.gy/5lt0M.jpg |
| 13:41:50 | <GGna> <dkayiwa> my Inpatient Care module is suddnly stoped i tried but its not started wat can i do?? |
| 13:42:34 | <k-joseph> GGna: was the process successfull? |
| 13:42:44 | <dkayiwa> k-joseph: can you try again without entering anything and just submit? |
| 13:42:54 | <GGna> yeah |
| 13:43:35 | <k-joseph> GGna: now go again on the administration page |
| 13:43:59 | <GGna> yes |
| 13:44:09 | <k-joseph> GGna: you should be able to see or locate you module, and begin using it |
| 13:44:53 | <GGna> ya |
| 13:45:08 | <GGna> its there under modules |
| 13:45:39 | *** wyclif has quit IRC |
| 13:46:32 | <k-joseph> dkayiwa: the error alert message i get is Please fix all errors and try again. |
| 13:46:32 | <k-joseph> Invalid property 'users' of bean class [org.openmrs.notification.Alert]: Bean property 'users' is not readable or has an invalid getter method: Does the return type of the getter match the parameter type of the setter? |
| 13:47:03 | <dkayiwa> k-joseph: yes thats the error that should be fixed |
| 13:47:27 | <dkayiwa> !ticket TRUNK-2975 |
| 13:47:28 | <OpenMRSBot> dkayiwa: [#TRUNK-2975] Attempting to save an alert without text should display a more user friendly error message - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2975 |
| 13:48:28 | <GGna> then what i want to do??<k-joseph> |
| 13:48:42 | <k-joseph> GGna: the module you have instaled should have a seperate link to it under administration page not under modules |
| 13:49:16 | <k-joseph> GGna: what do yo want to do?? |
| 13:51:34 | <GGna> How to change my companies logo on the pages of OpenMRS |
| 13:52:46 | <k-joseph> GGna: i think you should use the module you have installed to do that, dkayiwa: is this right? |
| 13:53:15 | <GGna> yeah |
| 13:53:46 | <k-joseph> dkayiwa: need some guidance on how to fix this? |
| 13:54:06 | <dkayiwa> k-joseph: what you are asking for is right on the ticket |
| 13:54:15 | <dkayiwa> k-joseph: have you read it? |
| 13:54:23 | <k-joseph> dkayiwa: yes |
| 13:54:43 | <dkayiwa> k-joseph: and did you do what the ticket tells you to? |
| 13:54:44 | <k-joseph> dkayiwa: i understand am to make the mesage user friendly |
| 13:55:31 | <dkayiwa> k-joseph: the ticket has instructions on what exactly you are supposed to do |
| 13:55:35 | <dkayiwa> k-joseph: did you read them? |
| 13:56:09 | <k-joseph> dkayiwa: seen that, |
| 14:00:39 | <k-joseph> dkayiwa: am i to put the validator under the same package org.openmrs.notification.web.controller |
| 14:00:44 | <k-joseph> dkayiwa: ? |
| 14:01:11 | <dkayiwa> k-joseph: where the rest of the openmrs validators are |
| 14:02:24 | <GGna> then what can i do k-joseph?? |
| 14:04:24 | <k-joseph> GGna: i have not used that module before and i think you can look up to someone who has used it, he would be the better choice to guide you, thanks |
| 14:04:31 | *** jkeiper has joined #openmrs |
| 14:04:31 | *** ChanServ sets mode: +v jkeiper |
| 14:05:50 | <dkayiwa> hi rafa |
| 14:05:54 | <rafa> dkayiwa: hi |
| 14:06:06 | <dkayiwa> rafa: do you know where i can get htmlwidgets module version 1.6.1 ? |
| 14:06:33 | <rafa> dkayiwa: why you need this version? |
| 14:06:42 | <GGna> hi <dkayiwa> can u guide me |
| 14:06:50 | <dkayiwa> rafa: it is in the current reporting module |
| 14:06:59 | <dkayiwa> rafa: <require_module version="1.6.1">org.openmrs.module.htmlwidgets</require_module> |
| 14:07:10 | <rafa> dkayiwa: but you can use the latest 1.6.4 |
| 14:07:28 | <dkayiwa> rafa: was using 1.6.2 |
| 14:08:33 | <rafa> dkayiwa: 1.6.4 doesn't work for you? |
| 14:09:18 | *** kishoreyekkanti has quit IRC |
| 14:09:23 | <dkayiwa> rafa: i had assumed that since 1.6.2 was rejected, then should be same story for higher versions. but trying that now :) |
| 14:09:48 | <rafa> dkayiwa: I don't know why 1.6.2 would be rejected |
| 14:09:54 | <dkayiwa> rafa: ok |
| 14:10:22 | <rafa> maybe didn't start properly |
| 14:10:33 | <dkayiwa> rafa: ok |
| 14:11:51 | <dkayiwa> rafa: thanks 1.6.4 works |
| 14:12:00 | <rafa> dkayiwa: np |
| 14:21:35 | <dkayiwa> GGna: have you finished installing the module? |
| 14:27:16 | *** mseaton has joined #openmrs |
| 14:27:16 | *** ChanServ sets mode: +v mseaton |
| 14:30:19 | *** lh has joined #openmrs |
| 14:32:07 | *** wyclif has joined #openmrs |
| 14:34:59 | *** docpaul has joined #openmrs |
| 14:35:06 | *** ChanServ sets mode: +o docpaul |
| 14:51:20 | *** shortend has joined #openmrs |
| 14:52:57 | *** GGna has quit IRC |
| 15:03:10 | *** mseaton has quit IRC |
| 15:04:26 | <k-joseph> dkayiwa: hi |
| 15:05:26 | *** wyclif has quit IRC |
| 15:05:31 | *** mseaton has joined #openmrs |
| 15:05:31 | *** ChanServ sets mode: +v mseaton |
| 15:05:38 | <dkayiwa> k-joseph: hi |
| 15:05:42 | <k-joseph> dkayiwa: please can you give an example of a validator in api which valiadtes data on from .....web project |
| 15:06:13 | <dkayiwa> k-joseph: simply validator on the alert fields like you did for the other validator you did before |
| 15:06:54 | <dkayiwa> k-joseph: like the ticket you did on relationship type validator |
| 15:07:01 | <dkayiwa> k-joseph: does this now make sense? |
| 15:07:19 | *** djazayeri has joined #openmrs |
| 15:07:19 | *** ChanServ sets mode: +o djazayeri |
| 15:08:23 | <k-joseph> dkayiwa: yes, am trying to import org.openmrs.notification.web.controller.AlertFormController; and eclipse is highlighting the import how can i import the to be validated class? |
| 15:08:23 | *** kishoreyekkanti has joined #openmrs |
| 15:09:18 | <dkayiwa> k-joseph: are you trying to use the validator in the controller or the controller in the validator? |
| 15:10:04 | <k-joseph> dkayiwa: the controller in the validator |
| 15:10:30 | <dkayiwa> k-joseph: did you do the same for the other (relationship type ticket) ? |
| 15:11:13 | *** andrea has joined #openmrs |
| 15:11:29 | *** andrea is now known as andreap_ |
| 15:11:37 | <k-joseph> dkayiwa: i mean accessing AlertFormControler.java in the validator that am writing |
| 15:11:59 | <dkayiwa> dkayiwa: k-joseph: did you do the same for the other (relationship type ticket) ? |
| 15:12:46 | <k-joseph> dkayiwa: i remember having impoorted relationshipType.java |
| 15:13:09 | <dkayiwa> k-joseph: can you check and tell me what you did? |
| 15:13:26 | <dkayiwa> k-joseph: as in can you confirm? |
| 15:16:16 | *** wyclif has joined #openmrs |
| 15:17:19 | <k-joseph> dkayiwa: @Handler(supports = { AlertFormController.class }, order = 50) AlertFormController is highlighted red, i want to correct this error |
| 15:17:33 | *** andreap_ has quit IRC |
| 15:17:52 | <dkayiwa> k-joseph: can you please first look at the commit you made for the relationship type ticket? |
| 15:18:15 | <k-joseph> dkayiwa: am looking at that right now |
| 15:28:08 | *** downey has joined #openmrs |
| 15:28:08 | *** ChanServ sets mode: +o downey |
| 15:28:08 | *** OpenMRSBot sets mode: +o downey |
| 15:28:18 | *** k-joseph_ has joined #openmrs |
| 15:29:13 | *** k-joseph_ has quit IRC |
| 15:29:13 | *** k-joseph has quit IRC |
| 15:31:11 | *** rafa has quit IRC |
| 15:37:38 | *** k-joseph has joined #openmrs |
| 15:45:11 | *** docpaul has quit IRC |
| 15:45:39 | *** k-joseph has quit IRC |
| 15:59:08 | *** kishoreyekkanti has quit IRC |
| 16:00:41 | *** k-joseph has joined #openmrs |
| 16:00:52 | <k-joseph> dkayiwa: hi |
| 16:01:04 | <dkayiwa> k-joseph: hi |
| 16:01:21 | <k-joseph> dkayiwa: am focused on these two lines import org.openmrs.RelationshipType; and @Handler(supports = { RelationshipType.class }, order = 50) |
| 16:01:54 | <dkayiwa> k-joseph: ok |
| 16:02:02 | <k-joseph> dkayiwa: i want to fix |
| 16:03:07 | <k-joseph> dkayiwa: { RelationshipType.class } in this case focusing on AlertValidator |
| 16:03:24 | <dkayiwa> k-joseph: ok |
| 16:05:26 | <k-joseph> dkayiwa: dkayiwa: isnt this to be { AlertFormController.class } ? |
| 16:06:02 | <dkayiwa> k-joseph: what to be what? |
| 16:06:35 | <k-joseph> dkayiwa: { RelationshipType.class } to be { AlertFormController.class } |
| 16:07:14 | <dkayiwa> k-joseph: can you list the classes that your commit changes on that other ticket? |
| 16:08:09 | *** downey has quit IRC |
| 16:08:54 | <k-joseph> dkayiwa: i beg your pardon here commit changes on that other ticket? |
| 16:10:34 | <dkayiwa> k-joseph: concerning the commit you made for the ticket about relationship types, can you list the different classes that you touched? |
| 16:16:00 | <k-joseph> dkayiwa: ok that was relationshipTypeValidator, relationshipTypeValidatorTest, messages.properties which is a file |
| 16:16:20 | <dkayiwa> k-joseph: can you show me the pull request url? |
| 16:16:30 | *** jkeiper has quit IRC |
| 16:16:59 | *** suranga has joined #openmrs |
| 16:16:59 | *** ChanServ sets mode: +v suranga |
| 16:17:39 | *** wyclif has quit IRC |
| 16:17:50 | <suranga> hi dkayiwa I wanted to thank you for your advice on forking a tag last wednesday. It worked like a charm :-) :-) |
| 16:18:13 | <dkayiwa> suranga: oh great. i have never done it myself though :) |
| 16:19:02 | <suranga> dkayiwa, it worked beautifully, but I wasnt feeling very well yesterday, so I couldnt tell you until now :-) |
| 16:19:25 | *** guest1 has joined #openmrs |
| 16:19:31 | *** guest1 is now known as k-joseph_ |
| 16:19:45 | <k-joseph_> dkayiwa: the other one is RelationTypeFormController, the pull request is at https://github.com/openmrs/openmrs-core/pull/187 |
| 16:19:51 | <dkayiwa> suranga: oh good that you are now feeling better |
| 16:19:51 | <OpenMRSBot> <http://ln-s.net/+TX2> (at github.com) |
| 16:20:09 | *** k-joseph has quit IRC |
| 16:20:25 | *** k-joseph_ is now known as k-joseph |
| 16:20:53 | <dkayiwa> k-joseph: are you sure those are the only files you touched as per the commits in that pull request? |
| 16:21:54 | *** k-joseph_ has joined #openmrs |
| 16:22:28 | <k-joseph> dkayiwa: that is what i remember four of them |
| 16:23:14 | <dkayiwa> k-joseph: ok. can you now mention the equivalent files as for this new ticket? |
| 16:23:46 | *** k-joseph_ is now known as guest0 |
| 16:26:10 | <dkayiwa> k-joseph: in otherwards, for each of the files in that ticket commit, mention the corresponding file for this new ticket |
| 16:29:48 | *** wyclif has joined #openmrs |
| 16:30:16 | <k-joseph> dkayiwa: AlertFormContoler, AlertValidator, message.properties |
| 16:32:32 | <dkayiwa> k-joseph: four or three? |
| 16:33:57 | *** k-joseph_ has joined #openmrs |
| 16:34:13 | <dkayiwa> k-joseph: four or three? |
| 16:36:36 | *** k-joseph has quit IRC |
| 16:36:51 | *** guest0 has quit IRC |
| 16:38:05 | *** k-joseph has joined #openmrs |
| 16:38:40 | *** k-joseph_ is now known as guest0 |
| 16:39:45 | *** wyclif has quit IRC |
| 16:45:04 | <k-joseph> dkayiwa: AlertFormController.java, AlertValidator.java, AlertValidatorTest.java, and perhaps message.properties |
| 16:50:22 | <k-joseph> dkayiwa: ok i have known what i wanted by compairing |
| 16:52:24 | *** basic` has quit IRC |
| 17:18:36 | *** shortend has quit IRC |
| 17:22:33 | <suranga> hi mseaton :-) |
| 17:23:53 | <suranga> mseaton, we at Jembi have been doing some fixes to reporting 0.7.3.1 based on our requirements... |
| 17:23:59 | <suranga> mseaton, I've added a pull request for them just in case you thinks that these changes are good enought to go into the master :) |
| 17:24:07 | <suranga> mseaton, https://github.com/openmrs/openmrs-module-reporting/pull/16 |
| 17:24:13 | <OpenMRSBot> <http://ln-s.net/+TYF> (at github.com) |
| 17:24:30 | <mseaton> suranga: just seeing it now. looking it over, thanks! there is a ticket for this, have you seen it? will find it for you now... |
| 17:24:44 | <suranga> mseaton, really :-D |
| 17:26:49 | <mseaton> suranga: https://tickets.openmrs.org/browse/REPORT-392 |
| 17:27:34 | <mseaton> suranga: are you using this in your own custom UI? |
| 17:27:54 | <mseaton> suranga: or do your changes alone allow you to use the reporting UI differently? |
| 17:28:10 | <suranga> mseaton, um.. there are no changes to the UI |
| 17:28:26 | <suranga> the new data definitions are also added to the same drop down list |
| 17:29:10 | <suranga> mseaton, but it works end-to-end |
| 17:29:49 | <suranga> mseaton, did you want to add encounter data definitions into the list as well, or is it only patient data definitions that you wanted ? :) |
| 17:30:48 | <mseaton> suranga: looks fine for now. i didn't realize that we hard-coded PersonDataDefinition into this class to begin with. we'll probably need to remove both hard-coded references in place of something more configurable. |
| 17:31:32 | <suranga> mseaton, this is in regard to the tag, isnt it ? |
| 17:32:34 | <suranga> mseaton, if you also want to add encounter data, we will need to add a converter class to convert from encounter to patient (the opposite of this is already done in the reporting module..) |
| 17:33:18 | <mseaton> suranga: yes, currently the only place in the UI where the "chooseDataDefiniton" tag is used is in the patient data set editor, so this is fine. but given it's name implies you should be able to choose a generic data definition, we probably want to pass the supported types into it, rather than hard code 2 specific ones directly into the tag... but i can take care of this when i apply the pull request :) |
| 17:33:55 | <k-joseph> dkayiwa: hi |
| 17:34:02 | <dkayiwa> k-joseph: hi |
| 17:34:21 | <k-joseph> dkayiwa: please take alook at this, http://pastebin.com/f7mkkcnq i have also added: new AlertValidator().validate(obj, errors); in AlertFormController.processFormSubmission() |
| 17:34:27 | <mseaton> suranga: and then it will be the patient data set editor's job to figure out what types of definitions is wants the tag to expose for it. and it has this information available to it in the PatientDataSetDefinition class... |
| 17:34:31 | <dkayiwa> k-joseph: ok |
| 17:34:41 | *** shortend has joined #openmrs |
| 17:35:07 | <suranga> mseaton, uummm... sure.. if anything pops up you know where to find me :) |
| 17:35:43 | <shortend> Hey, I'd like to get set up as the maintainer for the jasperreports module. |
| 17:35:47 | *** djazayeri has quit IRC |
| 17:35:57 | <shortend> What do I have to sign away for that? |
| 17:39:45 | <k-joseph> dkayiwa: hi |
| 17:39:52 | <dkayiwa> k-joseph: hi |
| 17:40:50 | *** djazayeri has joined #openmrs |
| 17:40:50 | *** ChanServ sets mode: +o djazayeri |
| 17:41:14 | <k-joseph> dkayiwa: is that ok? processFormSubmission() looks more complex than there other time |
| 17:41:23 | <mseaton> suranga: thanks for the contribution. |
| 17:41:25 | <dkayiwa> k-joseph: looking |
| 17:41:45 | <suranga> mseaton, sorry I havent done the entire ticket for you :( |
| 17:43:01 | *** kishoreyekkanti has joined #openmrs |
| 17:43:35 | *** k-joseph_ has joined #openmrs |
| 17:44:40 | <dkayiwa> k-joseph: can you look at the validator you did for the relationship type ticket? |
| 17:45:24 | *** k-joseph has quit IRC |
| 17:46:17 | *** k-joseph has joined #openmrs |
| 17:46:25 | *** guest0 has quit IRC |
| 17:46:38 | *** k-joseph_ is now known as guest0 |
| 17:46:50 | <dkayiwa> k-joseph: which IRC client are you using |
| 17:47:34 | <dkayiwa> guest0: are you k-joseph ? |
| 17:48:25 | <k-joseph> dkayiwa: iceChart is my favorite, but it keeps no record of the messages so i have adapted xchart which can do that |
| 17:48:47 | <dkayiwa> k-joseph: are you using more than one client at a time? |
| 17:49:03 | <dkayiwa> k-joseph: you seem to be logged in as k-joseph and guest0 |
| 17:49:06 | <k-joseph> dkayiwa: is this unsafe? |
| 17:49:16 | <dkayiwa> k-joseph: it confuses us |
| 17:49:47 | <dkayiwa> k-joseph: i cannot communicate to you well when you nick name keeps changing like crazy |
| 17:50:16 | <k-joseph> dkayiwa: ok, will drop one of the clients |
| 17:50:46 | <dkayiwa> k-joseph: are you ready for me to continue? |
| 17:50:58 | <k-joseph> dkayiwa: yes i am |
| 17:51:13 | <dkayiwa> member:k-joseph: can you look at the validator you did for the relationship type ticket? |
| 17:51:32 | <k-joseph> dkayiwa: am looking at it now |
| 17:53:30 | <k-joseph> dkayiwa: ? |
| 17:53:54 | <dkayiwa> k-joseph: in that validator, do you reference the form controller? |
| 17:55:06 | <k-joseph> dkayiwa: no, fixing that |
| 17:55:39 | <dkayiwa> k-joseph: can you do everything and send me a complete package? |
| 17:55:53 | <k-joseph> dkayiwa: ok |
| 18:01:34 | *** jkeiper has joined #openmrs |
| 18:01:34 | *** ChanServ sets mode: +v jkeiper |
| 18:04:09 | *** wyclif has joined #openmrs |
| 18:13:54 | *** docpaul has joined #openmrs |
| 18:13:54 | *** ChanServ sets mode: +o docpaul |
| 18:13:56 | *** docpaul has quit IRC |
| 18:21:31 | <k-joseph> dkayiwa: hi |
| 18:21:40 | <dkayiwa> k-joseph: |
| 18:21:45 | <k-joseph> dkayiwa: please go ahead check this http://pastebin.com/HfpQ6P2a i have tested and it is just fine, also added Alert.text.required=Alert Text is required in messages.properties |
| 18:23:56 | <dkayiwa> k-joseph: have you generated the unit tests too? |
| 18:24:30 | <k-joseph> dkayiwa: am going to generate it now, is that ok? |
| 18:24:42 | <dkayiwa> k-joseph: so far good |
| 18:24:50 | <k-joseph> dkayiwa: ok |
| 18:34:02 | *** yony258 has joined #openmrs |
| 18:36:39 | <yony258> dkayiwa: Hi |
| 18:36:44 | <dkayiwa> yony258: hi |
| 18:37:04 | <yony258> dkayiwa: So when I put AppointmentStatuses enum in Appointment POJO the hibernate couldn't translate it |
| 18:37:15 | <yony258> dkayiwa: and I dont think it should |
| 18:37:25 | <yony258> dkayiwa: Maybe the correct place for it is in AppointmentService? |
| 18:37:59 | <dkayiwa> yony258: how did you do the hibernate mapping file |
| 18:38:01 | <dkayiwa> ? |
| 18:38:11 | *** k-joseph_ has joined #openmrs |
| 18:38:40 | <yony258> dkayiwa: The point is that the Appointment's status attribute is a string and I think it should be a string and not an enum |
| 18:38:59 | <dkayiwa> yony258: can be an enum of strings :) |
| 18:39:10 | <yony258> dkayiwa: I do think there should be an enum with values that is being used |
| 18:39:34 | <yony258> dkayiwa: but I dont want to change the status attribute to an enum, does that makes sense? |
| 18:40:01 | <dkayiwa> yony258: does it have a predefined list of possible values? |
| 18:40:10 | <yony258> dkayiwa: Yes for now |
| 18:40:20 | *** k-joseph has quit IRC |
| 18:40:37 | <dkayiwa> yony258: is that the reason why you do not want it to be an enum? |
| 18:40:43 | <yony258> dkayiwa: Yes |
| 18:40:53 | *** k-joseph_ is now known as k-joseph |
| 18:41:02 | <yony258> dkayiwa: But I do want to use an enum, for example instead of "Waiting" use Statuses.Waiting |
| 18:41:04 | <dkayiwa> yony258: i thought predefined list of possible values call for an enum? :) |
| 18:41:20 | *** guest0 has quit IRC |
| 18:41:51 | <yony258> dkayiwa: If you remember we talked about that in the future some one may want to change it to use custom statuses (like add a table appointment_Status) |
| 18:42:26 | <dkayiwa> yony258: that would require changing of the code anyway |
| 18:42:40 | <dkayiwa> yony258: because your code is aware of the exact values that they are |
| 18:43:06 | <yony258> dkayiwa: so you recommend changing the status attribute from "String status" to "EnumSomething status" ? |
| 18:43:24 | <dkayiwa> yony258: so my take is to have better code to address the current use case |
| 18:43:43 | <dkayiwa> yony258: when in future we want to make it generic, we shall think of some way then not now :) |
| 18:43:52 | <yony258> dkayiwa: Agree |
| 18:44:03 | <yony258> dkayiwa: So what would be the type of status attribute in the DB? |
| 18:44:21 | <dkayiwa> yony258: the database type does not change |
| 18:45:09 | *** yony258_ has joined #openmrs |
| 18:45:15 | <yony258_> dkayiwa: only the mapping? |
| 18:45:48 | <dkayiwa> yony258_: an example of enum mapping for you to look at is in openmrs-core for Order.hbm.xml |
| 18:46:05 | <shortend> Who do I need to talk to about getting access to deploy to the openmrs nexus... thing. |
| 18:46:11 | <dkayiwa> yony258_: look at properties: orderAction, urgency |
| 18:46:20 | <shortend> I'd like to update the jasperreports module. |
| 18:46:26 | <yony258_> dkayiwa: Do you see it causing any issues with the views? |
| 18:46:39 | <yony258_> dkayiwa: By it I mean the change |
| 18:46:45 | <dkayiwa> shortend: you can create an ITSM ticket for Michael Downey |
| 18:46:58 | <dkayiwa> yony258_: those can be corrected :) |
| 18:47:08 | <yony258_> dkayiwa: As a function of time |
| 18:47:19 | <dkayiwa> yony258_: immediately :) |
| 18:47:20 | <yony258_> dkayiwa: which costs more than gold nowdays :) |
| 18:47:38 | <dkayiwa> yony258_: it does not take more than a few mins :) |
| 18:47:52 | <yony258_> dkayiwa: So Im going to start and changing it to an enum, :S will update you when it crashes :P |
| 18:48:04 | <dkayiwa> yony258_: sure :) |
| 18:48:22 | *** yony258 has quit IRC |
| 18:48:32 | <yony258_> dkayiwa: You can just go through the commits and see which are AM-20 I tried to write AM-20 when I committed |
| 18:48:36 | *** yony258_ is now known as yony258 |
| 18:48:42 | <dkayiwa> yony258: ok |
| 18:49:32 | <dkayiwa> yony258: will be back in 15 mins |
| 18:49:41 | <yony258> dkayiwa: ok, thank you :) |
| 18:56:43 | *** Adam_l has joined #openmrs |
| 18:57:54 | <Adam_l> dkayiwa: Hi daniel how are you? |
| 19:02:23 | *** docpaul has joined #openmrs |
| 19:02:26 | *** ChanServ sets mode: +o docpaul |
| 19:06:41 | *** cpower has joined #openmrs |
| 19:08:24 | <k-joseph> dkayiwa: hi |
| 19:09:48 | *** andrea has joined #openmrs |
| 19:10:10 | *** andrea is now known as Guest85672 |
| 19:10:25 | *** Guest85672 is now known as andreap_ |
| 19:13:34 | <k-joseph> dkayiwa: the test pastie link is http://pastebin.com/XS34AzVi |
| 19:16:03 | <shortend> dkayiwa: Hi. |
| 19:16:15 | <shortend> dkayiwa: Sorry... for the delay. |
| 19:16:22 | <yony258> dkayiwa: Let me know when you are back |
| 19:23:03 | *** areo has joined #openmrs |
| 19:24:29 | *** wyclif has quit IRC |
| 19:24:42 | <areo> hi everybody, Do you have problem with build "mvn clean install" ? ( from console : [ERROR] Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:2.3.2:jar ) |
| 19:25:23 | <dkayiwa> hi k-joseph |
| 19:25:28 | <dkayiwa> shortend: hi |
| 19:25:31 | <dkayiwa> yony258: hi :) |
| 19:25:47 | <k-joseph> dkayiwa: the test pastie link is http://pastebin.com/XS34AzVi |
| 19:26:06 | <dkayiwa> k-joseph: can you add some javadoc to the test? |
| 19:26:07 | <yony258> dkayiwa: Major problem, jUnit tests are failing, I just dont know what to do with that enum in testDataSet.xml |
| 19:26:37 | <shortend> dkayiwa: What do I need to do to take over maintenance of the jasperreports module? |
| 19:26:45 | <dkayiwa> yony258: did you change the hibernate mapping files? |
| 19:26:51 | <yony258> dkayiwa: Yes |
| 19:26:55 | <yony258> dkayiwa: like in order |
| 19:27:24 | <dkayiwa> yony258: did you look at standardDataset.xml for Order? |
| 19:27:28 | <shortend> dkayiwa: I'd like to push an updated version to the maven repository. |
| 19:27:34 | <yony258> dkayiwa: let me do that |
| 19:29:20 | <dkayiwa> shortend: do you mean permissions to load it to the module repository? |
| 19:29:33 | <shortend> dkayiwa: I think that's what I mean. |
| 19:29:50 | <dkayiwa> shortend: whats your openmrs id? |
| 19:30:24 | <shortend> danielshorten, I believe. |
| 19:30:51 | <shortend> dkayiwa: Yes, danielshorten. |
| 19:31:26 | <dkayiwa> shortend: you can try send Michael an ISTM ticket to add you |
| 19:32:14 | <dkayiwa> k-joseph: remember am also assuming you have the @should on the validator |
| 19:34:03 | <shortend> dkayiwa: Sorry... What's an ISTM ticket? |
| 19:34:08 | *** rafa has joined #openmrs |
| 19:34:08 | *** ChanServ sets mode: +v rafa |
| 19:34:59 | <yony258> dkayiwa: My function gets a string that could be null (filter appointments) and now it should be an enum but can't be null |
| 19:35:02 | <dkayiwa> shortend: JIRA ticket with id starting with ITSM |
| 19:35:12 | <dkayiwa> shortend: an example https://tickets.openmrs.org/browse/ITSM-2630 |
| 19:35:16 | <yony258> dkayiwa: (Sorry for interrupting, answer when you are done) |
| 19:36:00 | <dkayiwa> yony258: how about an enum value for null? :) |
| 19:36:26 | <yony258> dkayiwa: How about getting a String? (since the form already restricts enum values only) ? |
| 19:36:32 | <shortend> dkayiwa: Great. Thanks. |
| 19:36:36 | <dkayiwa> yony258: e.g Status.NULL |
| 19:36:51 | <k-joseph> dkayiwa: http://pastebin.com/B4AZqdjE |
| 19:36:54 | <yony258> dkayiwa: Im afraid its a big change to do 1 week before deployment |
| 19:37:14 | <yony258> dkayiwa: don't you think? im now changing every important feature in the module |
| 19:37:33 | <dkayiwa> yony258: in that case leave it for next version :) |
| 19:37:51 | <yony258> dkayiwa: Its too late since I've already changed more than half of the module |
| 19:38:07 | <dkayiwa> yony258: lollllllllll. you can rever the changes :) |
| 19:38:10 | <dkayiwa> t |
| 19:38:24 | <yony258> dkayiwa: Do you think it will make a lot of problems with the views? |
| 19:38:47 | <dkayiwa> yony258: i do not think so |
| 19:39:00 | <yony258> dkayiwa: Ok so lets try to make it work |
| 19:39:05 | <dkayiwa> k-joseph: have you tested these changes in the browser and confirmed they work well? |
| 19:39:21 | <yony258> dkayiwa: BTW enum can be null, my bad! |
| 19:39:30 | <dkayiwa> yony258: hahaha :) |
| 19:39:38 | *** wyclif has joined #openmrs |
| 19:40:18 | <yony258> dkayiwa: Ok so all tests are now not correct or have errors |
| 19:40:45 | <dkayiwa> k-joseph: can you also create another unit test for validator returning no errors if values are properly set? |
| 19:40:46 | <Adam_l> dkayiwa: Did you try to make the bug to happen? |
| 19:40:46 | <yony258> dkayiwa: No enum const class org.openmrs.module.appointment.Appointment$AppointmentStatus.FINISHED |
| 19:41:25 | <dkayiwa> yony258: i guess you can quickly fix those :) |
| 19:41:45 | <dkayiwa> Adam_l: yes i did but failed. so i need you guide me through reproducing it |
| 19:41:47 | <yony258> dkayiwa: If I could I would not ask you for help since I can tell you are overloaded with questions |
| 19:41:58 | <yony258> :) |
| 19:42:21 | <Adam_l> dkayiwa: can you try to edit n existing appointment type and rename it's name to an empty string? |
| 19:42:23 | <dkayiwa> yony258: some days i can do multi tasking pretty well :) |
| 19:42:33 | <dkayiwa> Adam_l: ok doing that now |
| 19:42:36 | <yony258> dkayiwa: I don't think you have a choice :P |
| 19:43:08 | <dkayiwa> yony258: now when you are around :D |
| 19:43:17 | <dkayiwa> now = not :) |
| 19:43:24 | <Adam_l> dkayiwa: ok then click save and you will see the validtion errors |
| 19:43:35 | <k-joseph> dkayiwa: yes all work fine, the test passes too |
| 19:43:45 | <yony258> dkayiwa: dkayiwa++ |
| 19:43:55 | <dkayiwa> k-joseph: can you also create another unit test for validator returning no errors if values are properly set? |
| 19:44:31 | <dkayiwa> Adam_l: do i need to first do a pull. i last pulled yesterday |
| 19:44:47 | <Adam_l> dkayiwa: then go to the appointment types list and you will see the changes... they reflected on the db although there was an error |
| 19:44:51 | <k-joseph> dkayiwa: pardon |
| 19:45:00 | <Adam_l> dkayiwa: no you don't have to |
| 19:45:07 | <dkayiwa> Adam_l: ok |
| 19:45:21 | *** shortend has left #openmrs |
| 19:45:58 | <dkayiwa> k-joseph: you have a unit test which ensures the validator complains when there are errors. can you create also a unit test where validator is happy if object has no errors? |
| 19:46:14 | <dkayiwa> k-joseph: you did that for the ticket you did for relationship types |
| 19:46:19 | <Adam_l> dkayiwa: you will see that the appointment type you have edited have no name |
| 19:46:32 | <dkayiwa> k-joseph: so if you still do not get me, just look at the commit you did for it |
| 19:46:44 | <k-joseph> dkayiwa: only one value? alert text? |
| 19:47:04 | <dkayiwa> k-joseph: have you tried it? |
| 19:47:35 | <dkayiwa> Adam_l: oh |
| 19:47:51 | <dkayiwa> Adam_l: so the web browser does not show the changes but when they are in the database? |
| 19:48:50 | <Adam_l> dkayiwa: I didn't understand your question. can you repeat it? |
| 19:50:09 | <dkayiwa> Adam_l: i edited an appointment type by changing its name to an empty string. trying to save, i got errors. I then clicked the appointment types link at the top and saw the lists again with the name still as it was |
| 19:50:16 | <Adam_l> dkayiwa: Apparently the changes reflected in the db and hence in appointment type list although there was an error in the appointment edit page(form) |
| 19:51:10 | <Adam_l> djazayeri: That's weird ... in my local standalone it do save the changes. let me check |
| 19:51:21 | <djazayeri> dkayiwa: ^^ |
| 19:51:22 | <dkayiwa> Adam_l: after getting validation errors, on the appointment type management page, i see the list including the name as it was before changing it to an empty string |
| 19:51:31 | <dkayiwa> djazayeri: i was sure it was mine :) |
| 19:51:45 | <dkayiwa> Adam_l: which version of openmrs are you using? |
| 19:52:42 | <Adam_l> dkayiwa: 1.9.1 |
| 19:53:06 | <dkayiwa> Adam_l: that should be fine |
| 19:53:33 | <dkayiwa> Adam_l: and are you sure you are using the latest changes? |
| 19:53:57 | <dkayiwa> Adam_l: for the module |
| 19:56:32 | <Adam_l> dkayiwa: 1.9.1 |
| 19:57:02 | <dkayiwa> Adam_l: was that for the module? |
| 19:57:29 | *** andreapat has joined #openmrs |
| 19:57:31 | <Adam_l> dkayiwa: yes I'm sure... and it's not related to the appointment types form... it happen also in the appointment block from you see? |
| 19:57:38 | <Adam_l> dkayiwa: it's like a general problem |
| 19:57:48 | *** andreap_ has quit IRC |
| 19:58:17 | <dkayiwa> Adam_l: when did you last pull? |
| 19:58:43 | <Adam_l> dkayiwa: I pulled this morning |
| 19:59:22 | <dkayiwa> Adam_l: just as a sanity check, let me pull again now, recompile and test again. can you also pull now? |
| 19:59:30 | <Adam_l> dkayiwa: I found the bug yesterday |
| 19:59:47 | <Adam_l> dkayiwa: yes no problem |
| 20:01:12 | <Adam_l> dkayiwa: up-to-date |
| 20:01:20 | <dkayiwa> Adam_l: pulling now |
| 20:02:00 | <andreapat> cpower, it's scrum time |
| 20:02:17 | *** k-joseph has quit IRC |
| 20:02:19 | <dkayiwa> Adam_l: will it be hard to test with the latest version of 1.9? |
| 20:02:23 | *** k-joseph_ has joined #openmrs |
| 20:02:31 | <dkayiwa> Adam_l: as in can you? :) |
| 20:02:32 | <k-joseph_> dkayiwa: confirm this please http://pastebin.com/xYgtX465 |
| 20:03:23 | <Adam_l> dkayiwa: I can but I need to donwload |
| 20:03:33 | <dkayiwa> k-joseph_: do you have the corresponding @should? |
| 20:04:07 | <dkayiwa> Adam_l: i remember having fixed some hibernate flush stuff which i think were backported to the latest 1.9 release |
| 20:04:23 | *** cpower has quit IRC |
| 20:04:32 | <andreapat> mseaton, are you here? |
| 20:04:32 | *** cpower has joined #openmrs |
| 20:04:36 | <cpower> Hello! |
| 20:04:44 | <cpower> Ready to Scrum? |
| 20:05:08 | <rafa> hi cpower |
| 20:05:27 | <rafa> ready! |
| 20:05:28 | <Adam_l> dkayiwa: ok maybe it will help... I will let you know if it still happens in 1.9.2 |
| 20:05:37 | <dkayiwa> Adam_l: sure thanks |
| 20:05:45 | <cpower> Ok then let's do what good developers do and Scrum |
| 20:05:50 | <cpower> !scrumon cpower |
| 20:05:50 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 20:06:27 | <cpower> Order: djazayeri, mseaton, rafa, andreapat, dkayiwa, wyclif and anyone else who has an update |
| 20:06:32 | <Adam_l> dkayiwa: thank you..I hope it will save my ass from puting some garbage to the module :) |
| 20:06:44 | <djazayeri> Recently: |
| 20:06:45 | <dkayiwa> Adam_l: lollllllll :D |
| 20:06:46 | <djazayeri> * Lots of calls |
| 20:06:58 | <djazayeri> * Form entry in Mirebalais |
| 20:07:04 | <djazayeri> No blockers |
| 20:07:07 | *** k-joseph_ has quit IRC |
| 20:08:00 | <rafa> can someone ping mseaton via skype :) |
| 20:08:05 | <mseaton> i'm here |
| 20:08:21 | <mseaton> reviewing calculation code |
| 20:08:25 | <mseaton> reviewing other tickets |
| 20:08:27 | <mseaton> testing code |
| 20:08:33 | <mseaton> no blockers |
| 20:08:47 | <rafa> Today: |
| 20:08:47 | <rafa> * Committed REPORT-464: Support Metadata Sharing of all Reporting Module metadata |
| 20:08:47 | <rafa> https://tickets.openmrs.org/browse/REPORT-464 (waiting for tests by mseaton) |
| 20:08:47 | <rafa> * Started with REPORT-398: Possible memory leak with reporting scheduled tasks |
| 20:08:47 | <rafa> https://tickets.openmrs.org/browse/REPORT-398 |
| 20:08:47 | <rafa> * Created TRUNK-3879: Two session factories when running OpenMRS |
| 20:08:47 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3879 |
| 20:08:48 | <rafa> No blockers. |
| 20:08:57 | <mseaton> discussion: wyclif are you working on calculation still, or can i apply some changes on top? |
| 20:09:09 | <wyclif> mseaton, nope |
| 20:09:41 | <mseaton> wyclif: your latest is in sprint branch? |
| 20:10:01 | <wyclif> mseaton, i just need to push the code formatting you suggested and moving assigning params to the context, i have been working on other tickets |
| 20:10:01 | <andreapat> Wednesday |
| 20:10:02 | <andreapat> Univ call |
| 20:10:02 | <andreapat> Design call |
| 20:10:02 | <andreapat> Report-415 |
| 20:10:02 | <andreapat> Preview button in place and working (I think) |
| 20:10:11 | <andreapat> Thursday |
| 20:10:11 | <andreapat> Dev call |
| 20:10:11 | <andreapat> Test Report-415 |
| 20:10:11 | <andreapat> |
| 20:10:22 | <mseaton> wyclif: that's why i asked if you ahd more to push before i make changes :) |
| 20:10:42 | <wyclif> mseaton, nope i will push mine after you |
| 20:10:43 | <andreapat> Blocker none but need discussion re code in github |
| 20:10:46 | <cpower> dkayiwa you have an update? |
| 20:10:47 | <mseaton> wyclif: ok |
| 20:10:50 | <dkayiwa> Reviewed Tobin's team code for appointment module |
| 20:10:51 | <dkayiwa> Reviewed: Attempting to save an alert without text should display a more user friendly error message - TRUNK-2975 |
| 20:10:51 | <dkayiwa> Committed responses to: New creator and created values are not appearing for any of the reporting objects from the UI on OpenMRS 1.9 - REPORT-416 |
| 20:10:51 | <dkayiwa> Still failed to reproduce: Possible issue with hibernate caching and running reports - REPORT-453 |
| 20:10:51 | <dkayiwa> Dev Call |
| 20:10:51 | <dkayiwa> Working on: The Run Report page is unable to load with parameters that default to expression values - REPORT-419 |
| 20:10:52 | <dkayiwa> No Blockers |
| 20:11:08 | <wyclif> Thursday: |
| 20:11:09 | <wyclif> emails |
| 20:11:09 | <wyclif> dev call |
| 20:11:09 | <wyclif> Meeting with Ada, Jer and Lauren |
| 20:11:09 | <wyclif> Commit code for REPORT-247 - Spaces or underscores in any of the "Searches to Combine" CohortDefinition keys breaks Composition String in CompositionQuery |
| 20:11:10 | <wyclif> Pick up a sprint ticket |
| 20:11:12 | <wyclif> |
| 20:11:16 | <wyclif> Blockers: None |
| 20:11:25 | <wyclif> sorry! |
| 20:11:26 | <wyclif> Wednesday: |
| 20:11:26 | <wyclif> design call |
| 20:11:26 | <wyclif> REPORT-247 - Spaces or underscores in any of the "Searches to Combine" CohortDefinition keys breaks Composition String in CompositionQuery |
| 20:12:26 | <cpower> ok, I think discussions and blockers are resolved during the scrum |
| 20:12:39 | <cpower> Any still out there that need assistance |
| 20:12:41 | <cpower> ? |
| 20:13:14 | <andreapat> cpower, I need some advise on wrong branch in github |
| 20:13:22 | <wyclif> mseaton, i will probably need a chat with you tomorrow about what remains to be implemented about calculations |
| 20:13:42 | <mseaton> wyclif: i have on my plate to translate discussions from yesterday into new tickets... |
| 20:14:05 | <wyclif> mseaton, cool! because from the design call i recall there were otehr things to do |
| 20:14:29 | *** suranga has quit IRC |
| 20:14:32 | <wyclif> mseaton, then i will look out for the tickets |
| 20:14:46 | <wyclif> mseaton, please add me to the watchers |
| 20:14:51 | <mseaton> wyclif: my main worry is that i don't see a lot of the code review suggestions i made implemented (not just formatting stuff). i'm doing some of them now, but we should re-review. |
| 20:15:03 | <andreapat> rafa, are you still here? |
| 20:15:04 | <djazayeri> andreapat: what wrong branch? |
| 20:15:11 | <rafa> andreapat: yes |
| 20:15:29 | <wyclif> mseaton, i recall the other was to change how to set the parmater values |
| 20:15:35 | <wyclif> unless i pushed stale code |
| 20:15:57 | <cpower> !scrumoff |
| 20:15:57 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:15:59 | <mseaton> wyclif: right. ok, maybe that was all |
| 20:16:30 | <mseaton> wyclif: are there any changes i need to review outside of the calculation package? |
| 20:16:34 | <wyclif> i repushed all the code again in 2 commits, the first was your original code and the 2nd commit included all my changes |
| 20:16:34 | <andreapat> djazayeri, yesterday I did pull request on my branch sprint-201301 when actually the branch I am on is called REPORT-415 - what is the best way to fix this? |
| 20:16:41 | <wyclif> mseaton, nope |
| 20:17:06 | <mseaton> wyclif: great. so if i just ignore all commits and pull requests and just review the 5 files in that package as a whole, i'm good? |
| 20:17:09 | <djazayeri> andreapat: you've committed the code to both places? |
| 20:17:09 | <wyclif> mseaton, i also need to factor out that code that you said was screaming for a utility method |
| 20:17:17 | <mseaton> wyclif: just did that locally |
| 20:17:25 | <andreapat> hi rafa, just stated problem to djazayeri |
| 20:17:44 | <mseaton> wyclif: will push as soon as i test |
| 20:17:50 | <wyclif> mseaton, ok, you can push your changes and i will pull to make any remaining suggestions you made |
| 20:18:07 | <wyclif> mseaton, ok |
| 20:18:49 | <andreapat> djazayeri, I must have commited to sprint-201301 with my first set of changes |
| 20:20:30 | <mseaton> wyclif: and djazayeri right now the PatientDataCalculationProvider is exposing reporting data definitions based on their String name. is this what we want? seems brittle if a reporting module user decides to change the name of a data definition from "Age" to "Current Age" or something. |
| 20:20:38 | <djazayeri> andreapat: if you did an incorrect pull request, you can just close it (from github) and do another pull request. |
| 20:21:22 | <djazayeri> mseaton, wyclif: I agree that isn't great... |
| 20:21:35 | <mseaton> djazayeri: uuid? |
| 20:21:37 | <djazayeri> mseaton, wyclif: the only alternative I can think of is to expose them by UUID |
| 20:21:52 | <mseaton> djazayeri: ugly in the ui, but safer |
| 20:21:56 | <andreapat> djazayeri, ok thanks - will do that |
| 20:22:07 | <djazayeri> mseaton, wyclif: yeah, and in the "calculation suggestion" (I forget what it's called) we should expose them with a nice description that is based on the name... |
| 20:22:33 | <mseaton> djazayeri: will go that route. djazayeri i think that's already the case but will confirm. wyclif, any problems with this, holler. |
| 20:23:54 | *** yony258 has quit IRC |
| 20:24:34 | *** yony258 has joined #openmrs |
| 20:25:06 | <wyclif> mseaton, am fine with it |
| 20:26:22 | <yony258> dkayiwa: (Hi is the scrum still on? I dont want to interrupt in the middle of it) |
| 20:26:33 | <dkayiwa> yony258: no |
| 20:26:54 | <yony258> dkayiwa: Ok so all tests are correct now, module got compiled and installed |
| 20:27:03 | <dkayiwa> yony258: excellent :) |
| 20:27:05 | <yony258> dkayiwa: I can't see forms errors |
| 20:27:23 | <dkayiwa> yony258: forms do not give errors? excellent :) |
| 20:27:26 | <yony258> dkayiwa: One thing I do need help with, is how to change an enum to its string value in jsp |
| 20:27:59 | <yony258> dkayiwa: for example: ${appointment.status} will give me INCONSULTATION instead of its toString value which is "In-Consultation" |
| 20:28:15 | <dkayiwa> yony258: doesn't it automatically call the toString() method? |
| 20:28:29 | <wyclif> yony258, nope |
| 20:28:39 | <andreapat> djazayeri, closed pull request now trying to do 2nd one - don't see branch REPORT-415 |
| 20:29:04 | <yony258> wyclif: Thanks for the answer in the email yesterday, that was really specific and great. |
| 20:29:12 | <djazayeri> andreapat: maybe it's only local? google for how to push a local branch to remote... |
| 20:29:19 | <dkayiwa> yony258: can i look at the enum? |
| 20:29:31 | <yony258> dkayiwa: ill paste bin |
| 20:29:51 | <wyclif> yony258, Enum has toString() and name() and these can return different values depending on one thing |
| 20:29:51 | *** k-joseph_ has joined #openmrs |
| 20:29:56 | <yony258> dkayiwa: http://pastebin.com/Hq658J4R |
| 20:30:18 | <andreapat> djazayeri, ok will google |
| 20:31:30 | <dkayiwa> yony258: is that what the browser displays? |
| 20:31:42 | <Adam_l> dkayiwa: just tested it on 1.9.2 and it still happen for me... |
| 20:31:48 | <yony258> dkayiwa: The browser displays "WAITING" instead of "Waiting" |
| 20:32:01 | *** k-joseph_ is now known as k-joseph |
| 20:32:02 | <dkayiwa> Adam_l: looking at it now |
| 20:32:05 | *** kishoreyekkanti has quit IRC |
| 20:32:43 | <k-joseph> dkayiwa: have you certified the last link i have sent to you? |
| 20:32:46 | <dkayiwa> Adam_l: when you do a git pull, is everything uptodate? |
| 20:32:51 | <dkayiwa> k-joseph: yes |
| 20:33:16 | <Adam_l> dkayiwa: yes |
| 20:33:22 | <dkayiwa> k-joseph: do a commit and show me the commit url. no pull request for now until when i give you a go ahead |
| 20:33:44 | <Adam_l> dkayiwa: maybe yony258 can test it when he will be free |
| 20:34:03 | <dkayiwa> Adam_l: that is a very bright idea |
| 20:34:12 | <yony258> Adam_l: tell me how to reproduce or let me know where to see the steps :) |
| 20:34:20 | <k-joseph> dkayiwa: ok doing that |
| 20:34:40 | <Adam_l> yony258: it's pretty simple to produce it :) edit an existing appointment type |
| 20:34:41 | <dkayiwa> yony258: sure Adam_l go ahead and tell him :) |
| 20:35:02 | <Adam_l> yony258: change it's name to empty string and click save |
| 20:35:23 | <Adam_l> yony258: now go to appointment types list and check if it's changed |
| 20:35:56 | <yony258> Adam_l: dkayiwa Yep, I see an empty appointment type name |
| 20:36:17 | <dkayiwa> yony258: ohhhhhh. which version of openmrs are you using? |
| 20:38:06 | <yony258> dkayiwa: 1.9.1 |
| 20:38:16 | <yony258> dkayiwa: Version: 1.9.1 Build 28992 |
| 20:38:27 | *** andreapat has quit IRC |
| 20:38:35 | <dkayiwa> yony258: let me try that exact version |
| 20:39:12 | *** Guest37918 has joined #openmrs |
| 20:39:16 | <yony258> dkayiwa: And on the way let me know if there is a way to show an enum.toString() value in JSP (Sounds so simple and common but couldn't find a good guide for it) |
| 20:39:21 | *** Guest37918 is now known as andreapat |
| 20:39:43 | <dkayiwa> yony258: ok |
| 20:43:58 | <dkayiwa> Adam_l: interesting, it happens on 1.9.1 but not on 1.9.0 :) |
| 20:44:24 | *** k-joseph has quit IRC |
| 20:44:41 | <dkayiwa> Adam_l: let me test again to confirm |
| 20:45:04 | *** docpaul_ has joined #openmrs |
| 20:45:04 | *** ChanServ sets mode: +o docpaul_ |
| 20:45:32 | <Adam_l> dkayiwa: ok |
| 20:47:20 | *** k-joseph has joined #openmrs |
| 20:48:48 | *** docpaul has quit IRC |
| 20:48:49 | *** docpaul_ is now known as docpaul |
| 20:55:50 | <andreapat> djazayeri, all is well - thanks again!!! |
| 20:55:56 | <djazayeri> np |
| 20:56:02 | <k-joseph> dkayiwa: commit https://github.com/k-joseph/openmrs-core/commit/TRUNK-2975 |
| 20:56:08 | <OpenMRSBot> <http://ln-s.net/+Tbi> (at github.com) |
| 20:57:23 | <dkayiwa> k-joseph: ok |
| 20:58:08 | <dkayiwa> k-joseph: do all the unit tests pass? |
| 20:58:27 | <k-joseph> dkayiwa: yes they do |
| 20:59:54 | <dkayiwa> k-joseph: did you delete all that is in red in the commit for AlertFormController? |
| 21:00:23 | <k-joseph> dkayiwa: also supprised at that |
| 21:01:08 | <dkayiwa> k-joseph: did you setup the openmrs eclipse code formatter? |
| 21:01:39 | <k-joseph> dkayiwa: no, what and how? |
| 21:03:12 | <k-joseph> dkayiwa: how about a hard reset, and add the chages care fully now than before? |
| 21:03:26 | <dkayiwa> k-joseph: ok |
| 21:04:19 | <dkayiwa> k-joseph: about the eclipse code formatter, you can get instructions at the bottom of this page: https://wiki.openmrs.org/display/docs/Developer+How-To+Use+Eclipse+Guide |
| 21:04:48 | <dkayiwa> k-joseph: you should also read this: https://wiki.openmrs.org/display/docs/Coding+Conventions |
| 21:05:24 | <Adam_l> dkayiwa: can please guide me how to do an extension and add a new tab in the patient dashboard? |
| 21:05:50 | <dkayiwa> yony258: can you help Adam_l with that? :) |
| 21:09:17 | <yony258> dkayiwa: Yes |
| 21:09:17 | <Adam_l> dkayiwa: maybe can you tell me how to know what method to override? |
| 21:09:36 | <dkayiwa> yony258: thanks :) |
| 21:10:10 | <yony258> dkayiwa: But just wanted to let you know that I got the enum string by adding "getName" and doing ${appointment.status.name}, is this workaround applicable? |
| 21:10:54 | <yony258> dkayiwa: Adam_l But my help is depended on which extension point you wish to extend, I worked with LinkExt |
| 21:10:57 | <dkayiwa> yony258: you are so creative man!!! :D |
| 21:11:21 | <yony258> dkayiwa: But I would like to know how to do that "correctly" if you know how |
| 21:11:23 | <dkayiwa> yony258: until we get something better :) |
| 21:11:31 | <dkayiwa> yony258: not off my head |
| 21:11:44 | <yony258> dkayiwa: ok so I hope there aren't any other bugs |
| 21:11:52 | <yony258> dkayiwa: related to the enum change |
| 21:11:55 | <dkayiwa> yony258: hopefully |
| 21:12:02 | <yony258> Adam_l: do you know which point you wish to extend? |
| 21:13:01 | <Adam_l> yony258: I want to add a new tab... the position depends on which extension point I extend? |
| 21:13:27 | <yony258> dkayiwa: Adam_l did the bug got fixed? (since its top priority for us) |
| 21:14:16 | <dkayiwa> yony258: am looking at it now since it was introduce in openmrs 1.9.1 core (it does not happen with 1.9.0) you can help me confirm this :) |
| 21:14:51 | <dkayiwa> Adam_l: this can be good for you: https://answers.openmrs.org/questions/373/how-can-i-add-a-tab-in-the-patient-dashboard |
| 21:15:02 | <yony258> dkayiwa: I am here for anything you need, im basically almost done with all of the stuff related to the pilot (except your code reviews) |
| 21:15:05 | <Adam_l> dkayiwa: thanks! |
| 21:15:43 | <dkayiwa> yony258: yes still reviewing more and will be done by tomorrow :) |
| 21:15:56 | <yony258> dkayiwa: Excellent!! much appreciated |
| 21:16:03 | <yony258> Adam_l: Im here for any question you have |
| 21:16:06 | <dkayiwa> yony258: can you help me confirm that Adam_l 's bug does not happen on openmrs 1.9.0? |
| 21:16:29 | <yony258> dkayiwa: Just need to get a 1.9.0 version (preferably the same as you have) |
| 21:16:37 | <dkayiwa> yony258: yes |
| 21:16:46 | <dkayiwa> yony258: you can also test trunk |
| 21:16:53 | <Adam_l> yony258: ok thanks |
| 21:16:54 | <dkayiwa> yony258: that is 1.10 |
| 21:17:09 | <yony258> dkayiwa: what do you mean by "test trunk? " |
| 21:17:22 | <dkayiwa> yony258: openmrs-core |
| 21:19:23 | <yony258> dkayiwa: Downloading 1.9.0 |
| 21:19:28 | <cpower> Darius and Mike are you both here? |
| 21:19:36 | <dkayiwa> yony258: ok excellent |
| 21:19:43 | <yony258> dkayiwa: BTW just a small FYI - Appointments Module is planned to support 1.9.0+ |
| 21:19:47 | <djazayeri> cpower: I'm here, though also on hangout with burke |
| 21:19:54 | <dkayiwa> yony258: ok |
| 21:20:23 | <cpower> the quick question is getting a time for Tuesday to talk to Joaquin about Patient Summary. When is good for you and Mike |
| 21:20:37 | <yony258> dkayiwa: Can I run 2 standalones in parallel or there may be some bugs? |
| 21:21:00 | <dkayiwa> yony258: you can run as many as you want :) |
| 21:24:24 | <yony258> dkayiwa: Im not sure since I just got an error with connecting to the DB |
| 21:24:39 | <djazayeri> cpower: I think I'm free from 12pm onwards your time |
| 21:24:48 | <dkayiwa> yony258: did you use the same port? |
| 21:24:54 | <yony258> dkayiwa: Nope |
| 21:31:48 | <k-joseph> dkayiwa: i think this is ok https://github.com/k-joseph/openmrs-core/commit/TRUNK-2975 |
| 21:31:49 | <OpenMRSBot> <http://ln-s.net/+Tbi> (at github.com) |
| 21:32:05 | <dkayiwa> k-joseph: ok checking |
| 21:35:01 | *** docpaul has quit IRC |
| 21:35:55 | <k-joseph> dkayiwa: ok |
| 21:36:05 | <yony258> dkayiwa: Bug does not happen on Version: 1.9.0 Build 27760 |
| 21:36:11 | <cpower> Rafal, you around? |
| 21:36:22 | <yony258> dkayiwa: If you want me to test other versions please send me links to them :) |
| 21:36:31 | <dkayiwa> yony258: thanks for confirming that too. can you check with the latest openmrs-core? :) |
| 21:36:32 | <rafa> cpower: yes, but just for a few minutes |
| 21:36:49 | <yony258> dkayiwa: Im not really sure how to get the standalone zip for 1.10.0 |
| 21:37:16 | <cpower> Looking to get a call with you Roger, and maybe Mike Seaton Monday or Tuesday, any times better for you? |
| 21:37:33 | <dkayiwa> yony258: just compile openmrs-core, then replace the war in any 1.9 standalone you are using :) |
| 21:38:01 | <yony258> dkayiwa: so just like pull core, do mvn install and use the WAR? |
| 21:38:05 | <mseaton> cpower: you looking for me? |
| 21:38:25 | <rafa> cpower: the earlier the better ;) |
| 21:38:28 | <dkayiwa> yony258: yes |
| 21:38:38 | <rafa> cpower: I guess from scrumtime onwards |
| 21:38:51 | <rafa> cpower: btw what is the topic? |
| 21:39:29 | <djazayeri> cpower: if that's about RESTWS, I'd like to be there too (if feasible) |
| 21:39:48 | *** k-joseph has quit IRC |
| 21:39:56 | <cpower> mseaton, check your email setup a Patient Summary meeting for you on Tuesday with Joaquin. and now I'm looking to setup a meeting (if you want to be involved) on RestWS |
| 21:40:15 | <Adam_l> yony258: do you know how to develop a portlet? |
| 21:40:29 | <cpower> rafa, RestWS getting the ball rolling on it |
| 21:40:40 | <mseaton> cpower: tuesday at 1 works for me. i'll pass on restws |
| 21:40:51 | <yony258> Adam_l: No, but I did read some stuff about it and it did not looked too complex for me but never actually tried it |
| 21:40:53 | <cpower> good deal |
| 21:41:01 | <cpower> mseaton: Good deal |
| 21:41:25 | <cpower> djazayeri do you want to be in on RESTWS with Roger? |
| 21:41:30 | <Adam_l> yony258: ok |
| 21:41:55 | <djazayeri> cpower: yes. I don't need to be on patient summary. Just switch mseaton and I. :-) |
| 21:42:03 | <cpower> awesome |
| 21:42:26 | <yony258> Adam_l: Do you need to start a portlet for that extension point? |
| 21:43:04 | <cpower> djazayeri and rafa: Tuesday 1/22 2pm EST good for you? |
| 21:43:09 | <Adam_l> yony258: yes |
| 21:43:56 | <djazayeri> cpower: works for me. I could do up to 2 hours earlier. |
| 21:44:14 | <rafa> cpower: same for me ;) |
| 21:44:38 | <yony258> Adam_l: Than I suggest that you contact Tobin since he already added a new tab once in the past |
| 21:45:12 | *** jkeiper has quit IRC |
| 21:45:25 | <cpower> The hr before is the Patient Summary call, I'll leave the door open to you guys on the email I'm sending out for the hr before that with a "if I don't hear anything by tomorrow I'm scheduling it for 2pm" |
| 21:48:22 | *** Mkop has quit IRC |
| 21:50:42 | <Adam_l> yony258: ok I will probably will do that... |
| 21:50:57 | <yony258> Adam_l: Sorry I couldn't help more :/ |
| 21:52:08 | <Adam_l> yony258: it's ok :) it's probably not a big deal to make a portlet. |
| 21:52:13 | *** evmw has quit IRC |
| 21:53:47 | *** areo has quit IRC |
| 21:54:13 | <Adam_l> dkayiwa: can I use DWR in a portlet? |
| 21:54:24 | <dkayiwa> Adam_l: yes |
| 21:54:26 | *** Mkop has joined #openmrs |
| 21:54:26 | *** ChanServ sets mode: +v Mkop |
| 21:54:43 | *** evmw has joined #openmrs |
| 21:54:44 | <Adam_l> dkayiwa: and where to put portlets that I make in the module project? |
| 21:57:45 | <dkayiwa> Adam_l: in omod |
| 21:58:22 | <dkayiwa> Adam_l: webapp/portlets |
| 22:00:05 | <Adam_l> dkayiwa: ok thanks |
| 22:00:31 | *** rafa has quit IRC |
| 22:09:54 | <yony258> dkayiwa: still here? |
| 22:10:00 | <dkayiwa> yony258: yes |
| 22:10:09 | <yony258> dkayiwa: Bug do not happen with Version: 1.10.0 SNAPSHOT Build 0 |
| 22:10:31 | <dkayiwa> yony258: thanks for confirming. same here :) |
| 22:10:56 | <yony258> dkayiwa: No problem. Im still here, like on "IDLE" :P if you want me to help with anything |
| 22:11:09 | <dkayiwa> yony258: ok :) |
| 22:11:50 | *** wyclif has quit IRC |
| 22:24:13 | *** wyclif has joined #openmrs |
| 22:33:32 | *** mseaton has left #openmrs |
| 22:36:32 | <dkayiwa> yony258: hey |
| 22:36:40 | <yony258> dkayiwa: Hi |
| 22:37:09 | <dkayiwa> yony258: it was a bug in openmrs-core, which was fixed but not back ported in 1.9.1 and 1.9.2 |
| 22:37:34 | <yony258> dkayiwa: so the usual question - What do we need to do? |
| 22:38:01 | <dkayiwa> yony258: a release of 1.9.3 with the fix |
| 22:39:33 | <yony258> dkayiwa: What do you mean? we want this module to support 1.9.0 |
| 22:39:38 | <yony258> + |
| 22:40:08 | <dkayiwa> yony258: it works well on 1.9.0 but not 1.9.1 and 1.9.2 |
| 22:40:22 | <yony258> dkayiwa: Can we make it work on 1.9.1 and 1.9.2 ? |
| 22:40:23 | <dkayiwa> yony258: because the bug was introduce in 1.9.1 |
| 22:40:41 | <dkayiwa> yony258: that was when we introduced the PrivilegeListener |
| 22:41:07 | <yony258> Adam_l: following on this? |
| 22:41:09 | <dkayiwa> yony258: those are already released. so can only be fixed on 1.9.3 and above |
| 22:41:30 | <yony258> dkayiwa: When will 1.9.3 be released? |
| 22:41:47 | <dkayiwa> yony258: am not sure but you can always push for it :) |
| 22:42:15 | <yony258> dkayiwa: Need to inform Tobin, hoping that Adam_l following on this |
| 22:42:32 | <dkayiwa> yony258: ok |
| 22:42:45 | <yony258> dkayiwa: Thank you ! |
| 22:43:14 | <Adam_l> yony258: dkayiwa ok |
| 22:43:46 | <Adam_l> yony258: Maybe we will use 1.9.0 in the clinic for now? |
| 22:43:59 | <yony258> Adam_l: you will send an email to inform Tobin to upgrade the clinic to 1.9.0 but not 1.9.1 or 1.9.2? (maybe add a reference to this specific conversation) |
| 22:44:30 | <yony258> Adam_l: forgot a question mark somewhere up there, sry :P |
| 22:44:34 | <Adam_l> yony258: yeah np |
| 22:45:00 | <yony258> Adam_l: great :) hope that he will see it asap |
| 22:45:06 | <yony258> dkayiwa: Small question |
| 22:45:12 | <dkayiwa> yony258: ok |
| 22:45:31 | <yony258> dkayiwa: Will it hurt if I added a test class called "AppointmentUtilityTest,java" for utility method unit testing? |
| 22:45:35 | <yony258> *methods |
| 22:46:17 | <dkayiwa> yony258: no |
| 22:46:41 | <yony258> dkayiwa: ok thanks |
| 22:58:58 | <Adam_l> dkayiwa: say daniel, what I wrtie in getPortletUrl()? I finished writing the portlet and the DWR functions. |
| 22:59:30 | <yony258> dkayiwa: By the way we can close AM-4 just waiting for review on this https://github.com/openmrs/openmrs-module-appointment/commit/eeaaf0600fdbaf5fef464fd5bd1d4a97b3d5b906 |
| 22:59:35 | <OpenMRSBot> <http://ln-s.net/+Tet> (at github.com) |
| 23:00:04 | *** basic` has joined #openmrs |
| 23:00:04 | <yony258> dkayiwa: Not suggesting to do that now, its late. But just an FYI to help close tickets |
| 23:00:14 | <dkayiwa> yony258: ok |
| 23:01:15 | <yony258> dkayiwa: Oh sorry u reviewed that already ! |
| 23:05:31 | <yony258> dkayiwa: Thank you, im heading off to bed now. You can contact me via email I always check them. Have a good night |
| 23:05:47 | <yony258> Adam_l: Have a good night too! |
| 23:05:49 | <dkayiwa> yony258: sure thanks too |
| 23:06:34 | <Adam_l> yony258: good night :) |
| 23:06:39 | *** yony258 has quit IRC |
| 23:15:06 | <Adam_l> dkayiwa: good night daniel :) see you tomorrow :) |
| 23:15:14 | <dkayiwa> Adam_l: see ya :) |
| 23:15:26 | *** Adam_l has quit IRC |
| 23:45:31 | *** evmw has quit IRC |
