00:19:24
|
*** Echidna has quit IRC
|
00:25:54
|
*** Echidna has joined #openmrs
|
00:25:54
|
*** ChanServ sets mode: +v Echidna
|
00:41:41
|
*** Echidna has quit IRC
|
00:41:52
|
*** Echidna has joined #openmrs
|
00:41:52
|
*** ChanServ sets mode: +v Echidna
|
00:49:07
|
*** mseaton has joined #openmrs
|
00:49:07
|
*** ChanServ sets mode: +v mseaton
|
01:27:20
|
*** andreapat has quit IRC
|
03:39:48
|
*** mseaton has quit IRC
|
04:42:24
|
*** kavuri has joined #openmrs
|
04:44:08
|
*** kavuri has quit IRC
|
05:17:20
|
*** djazayeri has quit IRC
|
05:22:01
|
*** tobin_g has quit IRC
|
05:33:03
|
*** sara has joined #openmrs
|
05:36:39
|
*** k-joseph has joined #openmrs
|
05:42:49
|
*** k-joseph has quit IRC
|
05:51:19
|
*** kishoreyekkanti has joined #openmrs
|
06:02:14
|
*** kavuri has joined #openmrs
|
06:30:20
|
*** arahulkmit has joined #openmrs
|
06:45:52
|
*** sara has quit IRC
|
06:46:56
|
<kavuri> Hello
|
06:56:42
|
<kavuri> wyclif: hi
|
07:26:24
|
*** kishoreyekkanti has quit IRC
|
07:26:32
|
*** kishoreyekkanti has joined #openmrs
|
07:36:23
|
*** kishoreyekkanti has quit IRC
|
07:38:15
|
*** djazayeri has joined #openmrs
|
07:38:16
|
*** ChanServ sets mode: +o djazayeri
|
07:45:52
|
*** dkayiwa has joined #openmrs
|
08:00:03
|
*** k-joseph has joined #openmrs
|
08:15:59
|
*** k-joseph_ has joined #openmrs
|
08:17:07
|
*** k-joseph has quit IRC
|
08:17:22
|
*** k-joseph_ is now known as k-joseph
|
08:17:46
|
*** k-joseph is now known as k-joseph_
|
08:22:59
|
*** k-joseph_ has quit IRC
|
08:25:08
|
*** k-joseph has joined #openmrs
|
08:29:34
|
*** k-joseph has quit IRC
|
08:35:37
|
*** arahulkmit has quit IRC
|
08:50:17
|
*** djazayeri has quit IRC
|
09:19:28
|
*** kishoreyekkanti has joined #openmrs
|
09:24:19
|
*** sara_ has joined #openmrs
|
09:35:51
|
*** kavuri has quit IRC
|
09:36:24
|
*** kavuri has joined #openmrs
|
09:55:58
|
*** dkayiwa has quit IRC
|
09:59:48
|
*** suranga has joined #openmrs
|
09:59:48
|
*** ChanServ sets mode: +v suranga
|
10:02:29
|
*** dkayiwa has joined #openmrs
|
10:04:26
|
*** k-joseph has joined #openmrs
|
10:04:36
|
<k-joseph> dkayiwa: hi
|
10:04:44
|
<dkayiwa> k-joseph: hi
|
10:10:33
|
*** Guest1 has joined #openmrs
|
10:10:41
|
*** k-joseph has quit IRC
|
10:11:13
|
*** Guest1 is now known as k-joseph
|
10:20:08
|
*** suranga has quit IRC
|
10:25:31
|
*** suranga has joined #openmrs
|
10:26:05
|
<kavuri> dkayiwa: hi
|
10:26:21
|
<dkayiwa> kavuri: hi
|
10:26:49
|
<kavuri> dkayiwa: I am trying to setup tomcat7 to use active MQ (for event module and atomfeed module), but am not able to configure
|
10:26:59
|
<kavuri> dkayiwa: do you know if there is a guide to set these up?
|
10:27:01
|
<kavuri> dkayiwa: in openmrs?
|
10:27:30
|
<dkayiwa> kavuri: unfortunately no
|
10:28:15
|
<kavuri> dkayiwa: I have been stuck trying to configure..and the only way was to deploy openmrs in jboss, but jboss has its own set of problems
|
10:28:47
|
*** sara_ has quit IRC
|
10:29:29
|
<dkayiwa> kavuri: ask on mail
|
10:29:35
|
<kavuri> dkayiwa: ok
|
10:33:34
|
<k-joseph> dkayiwa: is this where youare creating the format bassing on the globalproperty value? String formatValue =Context.getAdministrationService().getGlobalPro pertyValue(propertyName, null); ??
|
10:34:25
|
<dkayiwa> k-joseph: do you know what the method getGlobalPropertyValue is used for?
|
10:34:59
|
<k-joseph> dkayiwa: i hardly know that
|
10:35:43
|
<dkayiwa> k-joseph: what do you mean by that?
|
10:36:06
|
<k-joseph> dkayiwa: no, i dont
|
10:36:22
|
<dkayiwa> k-joseph: have you tried to read its javadoc?
|
10:36:43
|
<k-joseph> dkayiwa: checking for it ...
|
10:36:47
|
<suranga> hi dkayiwa , sorry, but do you know how we can checkout the code for an earlier release of an openmrs module using GIT ?
|
10:37:03
|
<dkayiwa> k-joseph: thats what you should have done in the first place
|
10:37:21
|
<suranga> dkayiwa, is it by using the commmit hash ?
|
10:37:33
|
<dkayiwa> suranga: like which release?
|
10:37:57
|
<suranga> dkayiwa, 0.7.3.1 of the reporting module ? :)
|
10:40:15
|
<dkayiwa> suranga: it is here: https://github.com/openmrs/openmrs-module-reporting/tree/0.7.3.1
|
10:40:19
|
<OpenMRSBot> <http://ln-s.net/+T5x> (at github.com)
|
10:40:45
|
<dkayiwa> suranga: so just get that brancj
|
10:40:47
|
<dkayiwa> h
|
10:42:54
|
*** suranga_ has joined #openmrs
|
10:43:18
|
<suranga_> dkayiwa, sorry, I got cut off, hope I didnt miss anything from you :)
|
10:43:35
|
<dkayiwa> dkayiwa: suranga: it is here: https://github.com/openmrs/openmrs-module-reporting/tree/0.7.3.1
|
10:43:35
|
<dkayiwa> [2:13pm]
|
10:43:35
|
<OpenMRSBot> <http://ln-s.net/+T5x> (at github.com)
|
10:43:42
|
<dkayiwa> suranga_: just get that branch
|
10:44:11
|
*** suranga has quit IRC
|
10:44:30
|
<suranga_> dkayiwa, I use this only when im checking out, isnt it ? for clone and upstream commands I use the usual head command ?
|
10:44:58
|
<dkayiwa> suranga_: use git fetch all
|
10:45:12
|
<dkayiwa> suranga_: then switch to that branch
|
10:45:48
|
<suranga_> dkayiwa, thank you soo much ! ill update the wiki doc too :-)
|
10:46:48
|
<dkayiwa> suranga_: did it work?
|
10:47:22
|
<suranga_> dkayiwa, im not in a position to try it out right now :-( gimme 5 mins :)
|
10:47:37
|
<dkayiwa> suranga_: no need to hurry. i have never done it too :)
|
10:52:16
|
*** suranga_ has quit IRC
|
10:53:41
|
<k-joseph> dkayiwa: ok seen that, it Returns a global property according to the type specified
|
10:54:19
|
<dkayiwa> k-joseph: what do you mean by type?
|
10:56:02
|
*** suranga has joined #openmrs
|
10:57:02
|
<k-joseph> dkayiwa: it is like datatype, of format iin this case??
|
10:57:23
|
<suranga> dkayiwa, the url you gave me links to the very same git url, doesnt it ? how does it identify that I want 0.731, and not the head ? :(
|
10:57:27
|
<dkayiwa> k-joseph: can you show me the javadoc where you read that
|
10:57:55
|
<dkayiwa> suranga: you dont use that url
|
10:58:01
|
<dkayiwa> suranga: that was just to show you
|
10:58:06
|
<k-joseph> dkayiwa: about type?
|
10:58:15
|
<dkayiwa> suranga: for your reporting module checkout, just do a git fetch all
|
10:58:31
|
<dkayiwa> suranga: then you will see that branch come up and you switch to it using git checkout
|
11:00:51
|
<dkayiwa> k-joseph: yes
|
11:02:05
|
*** Rahul has joined #openmrs
|
11:02:29
|
*** Rahul is now known as Guest24506
|
11:02:40
|
<k-joseph> dkayiwa: propertyName??
|
11:02:59
|
<dkayiwa> k-joseph: does that mean type?
|
11:03:42
|
<k-joseph> dkayiwa: getGlobalProperty() Gets the global property that has the given propertyName.
|
11:04:09
|
<dkayiwa> k-joseph: type means things like, String, int, double, date, etc. not so?
|
11:04:35
|
<k-joseph> dkayiwa: yes,
|
11:04:57
|
<k-joseph> dkayiwa: datatype in this case
|
11:05:07
|
<dkayiwa> k-joseph: so now the description you gave means so because you used type
|
11:06:39
|
<k-joseph> dkayiwa: not sure what type specified is, doubt whether it is datatype, cant it represent any other object names?
|
11:07:07
|
<dkayiwa> k-joseph: can you paste here the javadoc as it is?
|
11:08:28
|
<k-joseph> <String> String org.openmrs.api.AdministrationService.getGlobalPropertyValue(String propertyName, String defaultValue) throws APIException
|
11:08:28
|
<k-joseph> Returns a global property according to the type specified
|
11:08:28
|
<k-joseph> Parameters:
|
11:08:28
|
<k-joseph> <T>
|
11:08:28
|
<k-joseph> propertyName
|
11:08:28
|
<k-joseph> defaultValue
|
11:08:28
|
<k-joseph> Returns:
|
11:08:29
|
<k-joseph> property value in the type of the default value
|
11:08:29
|
<k-joseph> Throws:
|
11:08:30
|
<k-joseph> APIException
|
11:08:30
|
<k-joseph> Since:
|
11:08:31
|
<k-joseph> 1.7
|
11:09:17
|
<dkayiwa> k-joseph: oh i see.
|
11:09:39
|
<dkayiwa> so after reading that javadoc, do you now understand my line of code?
|
11:10:21
|
<k-joseph> dkayiwa: yes,
|
11:10:37
|
<dkayiwa> k-joseph: ok so do you think you can now proceed?
|
11:12:35
|
<k-joseph> dkayiwa: is propertyName e.g. GLOBAL_PROPERTY_TIME_DISPLAY_FORMAT, what is it?
|
11:12:58
|
<dkayiwa> k-joseph: yes its the value contained in that constant
|
11:13:01
|
<k-joseph> dkayiwa: e.g. = like
|
11:13:17
|
<k-joseph> dkayiwa: ok
|
11:18:56
|
*** dkayiwa has quit IRC
|
11:20:35
|
*** dkayiwa has joined #openmrs
|
11:21:00
|
<dkayiwa> suranga: doing this will list for you all the module tags: git tag
|
11:21:17
|
<dkayiwa> suranga: then you just do: git checkout tagname
|
11:22:48
|
<k-joseph> dkayiwa: please this out http://pastebin.com/tbVwwpR0
|
11:23:47
|
<dkayiwa> k-joseph: do you know why we use constants instead of the actual value?
|
11:25:06
|
<k-joseph> dkayiwa: psrdon, i thought we are using the value contained in the global constant than the constant?
|
11:25:24
|
<k-joseph> dkayiwa: pardon the question
|
11:26:39
|
<dkayiwa> k-joseph: can you read this: http://www.dotnetspider.com/resources/30452-What-are-advantages-using-constant.aspx
|
11:26:44
|
<OpenMRSBot> <http://ln-s.net/+T6e> (at www.dotnetspider.com)
|
11:27:05
|
<dkayiwa> k-joseph: and this:http://stackoverflow.com/questions/2524585/the-benefits-of-constants
|
11:27:07
|
<OpenMRSBot> <http://ln-s.net/+T6g> (at stackoverflow.com)
|
11:27:18
|
<dkayiwa> k-joseph: http://stackoverflow.com/questions/2524585/the-benefits-of-constants
|
11:27:19
|
<OpenMRSBot> <http://ln-s.net/+T6g> (at stackoverflow.com)
|
11:28:18
|
<dkayiwa> k-joseph: and finally read this: http://www.itjungle.com/fhg/fhg081804-story01.html
|
11:28:20
|
<OpenMRSBot> <http://ln-s.net/+T6i> (at www.itjungle.com)
|
11:28:24
|
<dkayiwa> k-joseph: then tell me when you are done
|
11:28:30
|
<k-joseph> dkayiwa: ok
|
11:29:58
|
*** kavuri has quit IRC
|
11:38:23
|
*** kishoreyekkanti has quit IRC
|
11:55:55
|
*** k-joseph has quit IRC
|
12:00:01
|
*** k-joseph has joined #openmrs
|
12:10:59
|
<k-joseph> dkayiwa: hi
|
12:11:04
|
<dkayiwa> k-joseph: hi
|
12:13:58
|
<k-joseph> dkayiwa: reading, did the two links are for different languages!, did you intend that i get advantages of using constants?
|
12:14:38
|
<dkayiwa> k-joseph: the idea was not language syntax, but instead the principle of using constants
|
12:15:06
|
*** mseaton has joined #openmrs
|
12:15:06
|
*** ChanServ sets mode: +v mseaton
|
12:16:31
|
<dkayiwa> hi mseaton
|
12:18:39
|
*** mseaton has quit IRC
|
12:50:34
|
<k-joseph> dkayiwa: please check this out http://pastebin.com/jWRMViPA
|
12:52:34
|
<dkayiwa> k-joseph: what change have you made?
|
12:54:26
|
<k-joseph> dkayiwa: the value of propertyName from "displayFormat.dateTime" to OpenmrsConstants.GLOBAL_PROPERTY_DATEANDTIME_DISPLAY_FORMAT
|
12:54:37
|
<dkayiwa> k-joseph: thats excellent
|
12:54:49
|
<dkayiwa> k-joseph: so can you continue with the ticket?
|
12:55:32
|
*** Guest24506 has quit IRC
|
13:00:03
|
*** pulasthi7 has joined #openmrs
|
13:00:37
|
*** rkorytkowski has joined #openmrs
|
13:00:37
|
*** ChanServ sets mode: +v rkorytkowski
|
13:00:48
|
*** rkorytkowski is now known as rafa
|
13:23:05
|
<k-joseph> dkayiwa: is this ok, http://pastebin.com/wqPTtMFT can i add the one for date?
|
13:27:40
|
*** wyclif has quit IRC
|
13:32:32
|
<dkayiwa> k-joseph: hi
|
13:32:55
|
<k-joseph> dkayiwa: hi
|
13:33:06
|
<dkayiwa> k-joseph: yes go ahead and do for the date too
|
13:37:35
|
<k-joseph> dkayiwa: http://pastebin.com/CHz7pWNn
|
13:38:26
|
<dkayiwa> k-joseph: you can now do a pull request
|
13:38:34
|
<dkayiwa> k-joseph: good work so far :)
|
13:41:40
|
*** thompcha has joined #openmrs
|
13:42:23
|
*** k-joseph has quit IRC
|
13:43:33
|
*** kavuri has joined #openmrs
|
13:53:17
|
*** travis-ci has joined #openmrs
|
13:53:17
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [f972a2d] [rkorytkowski] The build has errored. - http://travis-ci.org/openmrs/openmrs-core/builds/4186501
|
13:53:17
|
*** travis-ci has left #openmrs
|
13:53:23
|
<OpenMRSBot> <http://ln-s.net/+T9O> (at travis-ci.org)
|
14:02:50
|
*** kavuri has quit IRC
|
14:03:01
|
*** kavuri has joined #openmrs
|
14:18:01
|
*** mseaton has joined #openmrs
|
14:18:01
|
*** ChanServ sets mode: +v mseaton
|
14:25:22
|
*** wyclif has joined #openmrs
|
14:28:00
|
*** k-joseph_ has joined #openmrs
|
14:28:44
|
*** yony258 has joined #openmrs
|
14:29:05
|
<yony258> dkayiwa: Hi :)
|
14:29:12
|
<dkayiwa> yony258: hi
|
14:29:19
|
<yony258> dkayiwa: How are you?
|
14:29:26
|
<dkayiwa> yony258: doing fine and you? :)
|
14:29:45
|
<yony258> dkayiwa: Good good, planning an early pilot at the end of this month
|
14:29:59
|
<dkayiwa> yony258: oh wish you all the best
|
14:31:02
|
<yony258> dkayiwa: thank you :)
|
14:31:14
|
<yony258> dkayiwa: Wanted to ask 2 questions:
|
14:31:24
|
<yony258> dkayiwa: 1. Have you had a chance to do some code - reviews?4
|
14:31:31
|
<yony258> dkayiwa: 2. What do I send for review if I have to work split between a lot of commits?
|
14:31:51
|
<yony258> *If I have the work split between a lot of commits
|
14:32:25
|
<dkayiwa> yony258: urls for the commits :)
|
14:32:47
|
*** k-joseph_ has quit IRC
|
14:32:54
|
*** k-joseph_ has joined #openmrs
|
14:33:02
|
<dkayiwa> yony258: i have a feeling that there could be a way of merging them :0
|
14:33:28
|
<yony258> dkayiwa: Why do we prefer commits instead the files related to the ticket?
|
14:35:12
|
<dkayiwa> yony258: as long as i can look at only the changes, am good :)
|
14:35:14
|
*** mseaton has left #openmrs
|
14:35:41
|
<yony258> dkayiwa: Ok so how about I send the files with the lines that are related to the ticket highlighted ?
|
14:35:51
|
<yony258> *links to the files
|
14:36:33
|
<dkayiwa> yony258: do the files allow me to make inline comments in them?
|
14:37:00
|
<yony258> dkayiwa: Good point. No they don't and thus I guess we use the commits :)
|
14:37:18
|
<dkayiwa> yony258: :0
|
14:38:43
|
<yony258> dkayiwa: Solved - found a web app called "Chop" that is similar to pastebin just that I can allow inline comments!
|
14:39:01
|
<dkayiwa> yony258: you are so fast!!! :)
|
14:39:08
|
<yony258> dkayiwa: http://chopapp.com/
|
14:39:26
|
<yony258> dkayiwa: If I put links to the files transferred to chop will that be ok?
|
14:39:41
|
<yony258> dkayiwa: Im trying to make it easy for you because the commits are kinda messy
|
14:39:57
|
<dkayiwa> yony258: will see how it goes :)
|
14:40:24
|
<yony258> dkayiwa: Ok will try to do that by the evening, will send an email to let you know. just respond to it and tell me if its better this way?
|
14:40:46
|
<dkayiwa> yony258: ok
|
14:40:53
|
<yony258> dkayiwa: Great, thank you!
|
14:40:58
|
<yony258> dkayiwa: Will stay in touch
|
14:41:05
|
<dkayiwa> yony258: sure
|
14:42:29
|
*** k-joseph has joined #openmrs
|
14:43:28
|
*** k-joseph_ has quit IRC
|
14:44:57
|
*** k-joseph_ has joined #openmrs
|
14:45:27
|
*** yony258 has quit IRC
|
14:48:46
|
<k-joseph> dkayiwa: hi, is your sound/audeo on and clear now?
|
14:49:03
|
<dkayiwa> k-joseph: i think rafa is quiet :)
|
14:49:09
|
<dkayiwa> k-joseph: as in he is not speaking
|
14:52:37
|
*** kavuri has quit IRC
|
14:52:53
|
*** mseaton has joined #openmrs
|
14:52:53
|
*** ChanServ sets mode: +v mseaton
|
14:58:32
|
*** suranga has quit IRC
|
14:59:30
|
<mseaton> rafa: i may get called away for scrum. no updates on my end aside from doing code reviews and commenting on tickets as you have seen. no blockers. hope to get to my screencast later this week.
|
14:59:47
|
<rafa> mseaton: cool, thanks
|
15:01:12
|
<mseaton> rafa: if reportingmds is at a point where it would benefit from user testing, let me know. i might be able to try it out with ellen on some of our reports here.
|
15:01:56
|
*** andreap has joined #openmrs
|
15:02:37
|
<rafa> mseaton: would be great. I hope to fix the issue I'm having today and we could start more thorough tests tomorrow.
|
15:04:40
|
<rafa> mseaton: imports without merges seem to work, but fail if merging is needed... I'm investigating why.
|
15:04:48
|
<k-joseph> dkayiwa: hi
|
15:05:34
|
*** cpower has joined #openmrs
|
15:05:39
|
<cpower> Hello!
|
15:05:43
|
<cpower> Did I miss it?
|
15:05:49
|
<rafa> cpower: hi, nope
|
15:05:54
|
<andreap> hello cpower
|
15:05:56
|
<cpower> Cool, then let's begin
|
15:06:00
|
<cpower> !scrumon cpower
|
15:06:00
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:06:24
|
<cpower> Order: wyclif, dkayiwa, andreap, rafa, mseaton
|
15:06:59
|
<wyclif> Tuesday:
|
15:07:00
|
<wyclif> REPORT-444 - When editing Report Processors the changes are saved but don't take effect
|
15:07:00
|
<wyclif> REPORT-247 - Spaces or underscores in any of the "Searches to Combine" CohortDefinition keys breaks Composition String in CompositionQuery
|
15:07:00
|
<wyclif> Wednesday:
|
15:07:01
|
<wyclif> design call
|
15:07:04
|
<wyclif> REPORT-247 - Spaces or underscores in any of the "Searches to Combine" CohortDefinition keys breaks Composition String in CompositionQuery
|
15:07:06
|
<wyclif>
|
15:07:08
|
<wyclif> Blockers: None
|
15:07:53
|
<cpower> dkayiwa if you are there you are up!
|
15:08:45
|
<cpower> NEXT! andreap
|
15:08:46
|
<dkayiwa> Failed to reproduce: Possible issue with hibernate caching and running reports - REPORT-453
|
15:08:47
|
<dkayiwa> Failed to reproduce: When changing Resource Files in a Report Design the new file doesn't work - REPORT-445
|
15:08:47
|
<dkayiwa> Committed: New creator and created values are not appearing for any of the reporting objects from the UI on OpenMRS 1.9 - REPORT-416
|
15:08:47
|
<dkayiwa> Now working on: The Run Report page is unable to load with parameters that default to expression values - REPORT-419
|
15:08:47
|
<dkayiwa> No Blockers
|
15:08:56
|
<cpower> at the bell
|
15:09:02
|
<dkayiwa> :)
|
15:09:10
|
<cpower> andreap
|
15:09:12
|
<andreap> Tuesday
|
15:09:12
|
<andreap> Sprint-201301
|
15:09:13
|
<andreap> Report-415
|
15:09:13
|
<andreap> Pulled latest Reporting Module code from github
|
15:09:13
|
<andreap> Testing changes in compositionCohortDefinition.jsp in UI
|
15:09:13
|
<andreap> New preview button not showing up correctly yet
|
15:09:15
|
<andreap>
|
15:09:17
|
<andreap> Wednesday
|
15:09:19
|
<andreap> Univ call
|
15:09:21
|
<andreap> Design call
|
15:09:25
|
<andreap> Sprint-201301
|
15:09:27
|
<andreap> Report-415
|
15:09:29
|
<andreap> Get preview button Working
|
15:09:31
|
<andreap> Continue Testing changes in compositionCohortDefinition.jsp in UI
|
15:09:33
|
<andreap> Blockers
|
15:09:35
|
<andreap> None
|
15:09:47
|
*** k-joseph_ has joined #openmrs
|
15:09:48
|
<rafa> Today (started later today):
|
15:09:48
|
<rafa> * Committed
|
15:09:48
|
<rafa> + TRUNK-3875: Upgrade xstream to 1.4.3
|
15:09:48
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3875
|
15:09:48
|
<rafa> + REPORT-468: Adding Indicator to Cohort Indicator and Dimension Data Set fails
|
15:09:49
|
<rafa> https://tickets.openmrs.org/browse/REPORT-468
|
15:09:49
|
<rafa> * Univ Call
|
15:09:49
|
*** k-joseph_ is now known as guest1
|
15:09:50
|
<rafa> * Will work on REPORT-464: Support Metadata Sharing of all Reporting Module metadata
|
15:09:50
|
<rafa> https://tickets.openmrs.org/browse/REPORT-464
|
15:09:51
|
<rafa> * Design call
|
15:09:51
|
<rafa> No blockers.
|
15:09:52
|
<rafa> [15:57] mseaton: rafa: i may get called away for scrum. no updates on my end aside from doing code reviews and commenting on tickets as you have seen. no blockers. hope to get to my screencast later this week.
|
15:10:22
|
<cpower> ok!
|
15:10:34
|
<cpower> No questions or blockers
|
15:11:54
|
<cpower> Annoucements: I see a lot of new Nick's in the IRC chat, if you are looking for ways to help feel free to reach out to me. Next sprint starts in a week. Patient Summary, always looking for more Dev's, testers, Document writers and so on.
|
15:12:07
|
<cpower> Have a great day
|
15:12:11
|
<cpower> !scrumoff
|
15:12:11
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:13:36
|
*** mseaton has quit IRC
|
15:13:43
|
*** mseaton has joined #openmrs
|
15:13:43
|
*** ChanServ sets mode: +v mseaton
|
15:14:43
|
<k-joseph> dkayiwa: hi
|
15:15:57
|
<dkayiwa> k-joseph: hi
|
15:16:11
|
<k-joseph> dkayiwa: did you look at the pastie final link? and if yes how is it?
|
15:16:40
|
*** guest1 has quit IRC
|
15:16:58
|
<dkayiwa> k-joseph: it was good. do for date and then create pull request
|
15:17:05
|
*** mseaton has quit IRC
|
15:17:13
|
*** mseaton has joined #openmrs
|
15:17:13
|
*** ChanServ sets mode: +v mseaton
|
15:19:33
|
<k-joseph> dkayiwa: the last link had it inclusive, or http://pastebin.com/EZ4wEu6K
|
15:20:12
|
*** pulasthi7 has quit IRC
|
15:20:44
|
*** dkayiwa_ has joined #openmrs
|
15:22:57
|
*** dkayiwa has quit IRC
|
15:22:57
|
*** dkayiwa_ is now known as dkayiwa
|
15:33:42
|
*** k-joseph has quit IRC
|
15:47:27
|
*** k-joseph has joined #openmrs
|
15:55:17
|
*** basic` has quit IRC
|
15:56:25
|
*** basic` has joined #openmrs
|
16:11:37
|
*** shangxiao has joined #openmrs
|
16:14:38
|
*** apb156 has joined #openmrs
|
16:14:46
|
*** taygun has joined #openmrs
|
16:22:00
|
*** k-joseph has quit IRC
|
16:25:32
|
*** djazayeri has joined #openmrs
|
16:25:32
|
*** ChanServ sets mode: +o djazayeri
|
16:28:20
|
*** jkeiper has quit IRC
|
16:28:43
|
*** kishoreyekkanti has joined #openmrs
|
16:33:24
|
*** dkayiwa has quit IRC
|
16:39:59
|
*** taygun has quit IRC
|
16:44:08
|
*** rafa has quit IRC
|
16:48:03
|
*** mseaton has quit IRC
|
16:48:23
|
*** apb156 has quit IRC
|
16:49:30
|
*** mseaton has joined #openmrs
|
16:49:30
|
*** ChanServ sets mode: +v mseaton
|
16:51:20
|
*** dkayiwa has joined #openmrs
|
16:57:21
|
*** shangxiao has quit IRC
|
16:58:21
|
*** shangxiao has joined #openmrs
|
17:00:00
|
*** dkayiwa has quit IRC
|
17:00:15
|
*** kishoreyekkanti has quit IRC
|
17:01:10
|
*** andreap has quit IRC
|
17:02:23
|
*** dkayiwa has joined #openmrs
|
17:11:55
|
*** jkeiper has joined #openmrs
|
17:11:55
|
*** ChanServ sets mode: +v jkeiper
|
17:20:49
|
*** k-joseph has joined #openmrs
|
17:23:22
|
*** kishoreyekkanti has joined #openmrs
|
17:25:58
|
*** thompcha has quit IRC
|
17:26:38
|
*** thompcha has joined #openmrs
|
17:31:23
|
<k-joseph> dkayiwa: hi
|
17:31:39
|
*** thompcha has quit IRC
|
17:32:43
|
*** shangxiao has joined #openmrs
|
17:41:46
|
<k-joseph> dkayiwa: dkayiwa: hi
|
17:56:56
|
<k-joseph> hello every one, i have made a pull request at https://github.com/openmrs/openmrs-core/pull/191 which has failed travis test, i dont know what is missing for the test to pass and would like to correct the problem, i will be glad if assisted and pointed towards where the problem is and the intended solution, thanks a lot
|
17:57:00
|
<OpenMRSBot> <http://ln-s.net/+TB6> (at github.com)
|
18:04:45
|
*** guest1 has joined #openmrs
|
18:10:41
|
<wyclif> hi mseaton
|
18:16:00
|
*** mseaton has quit IRC
|
18:16:23
|
*** mseaton has joined #openmrs
|
18:16:23
|
*** ChanServ sets mode: +v mseaton
|
18:16:31
|
<mseaton> hi wyclif
|
18:19:20
|
<wyclif> mseaton, do you notice that the code for the patient data definition and calculations i pushed to the upstream branch is now gone
|
18:19:46
|
<wyclif> mseaton, and i recall i thought it is what happened the last time when i had to push it again
|
18:19:54
|
<wyclif> mseaton, i wonder what causes it
|
18:19:56
|
*** guest1 has quit IRC
|
18:27:25
|
*** mseaton1 has joined #openmrs
|
18:30:11
|
*** mseaton2 has joined #openmrs
|
18:31:50
|
*** mseaton has quit IRC
|
18:33:44
|
*** mseaton1 has quit IRC
|
18:34:30
|
*** mseaton has joined #openmrs
|
18:34:30
|
*** ChanServ sets mode: +v mseaton
|
18:36:16
|
*** mseaton2 has quit IRC
|
18:40:04
|
*** yony258 has joined #openmrs
|
18:40:17
|
<yony258> dkayiwa: Hi, let me know if this is better: https://tickets.openmrs.org/browse/AM-20?focusedCommentId=194153&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-194153
|
18:43:55
|
*** mseaton has left #openmrs
|
18:43:59
|
*** mseaton has joined #openmrs
|
18:43:59
|
*** ChanServ sets mode: +v mseaton
|
18:49:29
|
<dkayiwa> k-joseph: hi
|
18:49:54
|
<k-joseph> dkayiwa: hi
|
18:54:28
|
<k-joseph> dkayiwa: i humbly need assistance, how can i correct the test that has failed, travis? https://github.com/openmrs/openmrs-core/pull/191
|
18:54:28
|
<k-joseph>
|
18:54:28
|
<OpenMRSBot> <http://ln-s.net/+TB6> (at github.com)
|
18:55:39
|
<dkayiwa> k-joseph: is that a unit test?
|
18:55:58
|
<k-joseph> dkayiwa: no
|
18:55:59
|
<mseaton> wyclif: sorry, i have been bouncing on or off with bad internet. can you repeat questions?
|
18:56:14
|
<k-joseph> dkayiwa: failed travis tets
|
18:56:26
|
<k-joseph> dkayiwa: travis test
|
18:56:40
|
<dkayiwa> k-joseph: url?
|
18:57:01
|
<k-joseph> dkayiwa: https://github.com/openmrs/openmrs-core/pull/191
|
18:57:02
|
<OpenMRSBot> <http://ln-s.net/+TB6> (at github.com)
|
18:57:14
|
<wyclif> mseaton, do you notice that the code for the patient data definition and calculations i pushed to the upstream branch is now gone
|
18:57:15
|
*** dkayiwa has left #openmrs
|
18:57:16
|
<wyclif> mseaton, i wonder what causes it
|
18:57:19
|
<wyclif> mseaton, and i recall i thought it is what happened the last time when i had to push it again
|
18:57:48
|
*** dkayiwa has joined #openmrs
|
19:00:30
|
*** shangxiao has quit IRC
|
19:00:42
|
*** cpower has quit IRC
|
19:02:34
|
<dkayiwa> k-joseph: ignore that for now
|
19:02:59
|
<k-joseph> dkayiwa: yes, please, i have ignored it
|
19:07:42
|
<dkayiwa> k-joseph: have you tried to test this in the webapp?
|
19:12:02
|
*** docpaul has joined #openmrs
|
19:12:02
|
*** ChanServ sets mode: +o docpaul
|
19:12:25
|
<docpaul> hi all! :)
|
19:12:34
|
<docpaul> is andrea online?
|
19:12:37
|
<docpaul> if so, what is her nick?
|
19:12:53
|
<djazayeri> docpaul: she's andreapat, but I don't see her now.
|
19:13:01
|
<mseaton> wyclif: i see no reference in github's commit history in the sprint branch or master branch as to your commits. are you sure you are pushing to the right place?
|
19:13:24
|
<wyclif> mseaton, i am
|
19:13:24
|
<docpaul> darn, ok⦠let me try something else
|
19:13:33
|
<wyclif> mseaton, i even saw the commits the other day
|
19:13:45
|
<wyclif> am pushing them again
|
19:13:48
|
<dkayiwa> hey docpaul :) Andrea does not seem to be online
|
19:13:58
|
<docpaul> heya daniel!!
|
19:14:55
|
<dkayiwa> docpaul: but she is on the design call :)
|
19:15:30
|
<k-joseph> dkayiwa: am experiencing this error when i test by trying to search for a patient Error while attempting to find patients - The defaultValue argument cannot be nul
|
19:15:44
|
*** djazayeri1 has joined #openmrs
|
19:15:44
|
<docpaul> perfect, emailing her now
|
19:18:38
|
*** djazayeri has quit IRC
|
19:20:19
|
<dkayiwa> k-joseph: can you pastebin the stack trace?
|
19:24:30
|
<k-joseph> dkayiwa: http://pastebin.com/8RZQV8aS
|
19:25:28
|
<dkayiwa> k-joseph: can you replace null with an empty string and tests again?
|
19:25:45
|
<k-joseph> dkayiwa: ok
|
19:32:00
|
*** k-joseph has quit IRC
|
19:40:40
|
<yony258> dkayiwa: Dont want to interrupt. sent some emails let me know if you have any questions :D
|
19:41:38
|
*** wyclif has quit IRC
|
19:41:59
|
<dkayiwa> yony258: sure :)
|
19:43:41
|
*** wyclif has joined #openmrs
|
19:50:34
|
*** kishoreyekkanti has quit IRC
|
19:51:18
|
*** yony258 has quit IRC
|
19:56:06
|
*** yony258 has joined #openmrs
|
20:04:37
|
*** yony258 has quit IRC
|
20:27:42
|
*** wyclif has quit IRC
|
20:29:04
|
*** wyclif has joined #openmrs
|
20:40:26
|
*** docpaul has quit IRC
|
20:41:31
|
*** k-joseph has joined #openmrs
|
20:44:37
|
<k-joseph> dkayiwa: hi
|
20:49:07
|
*** k-joseph has quit IRC
|
20:58:06
|
*** yony258 has joined #openmrs
|
21:00:31
|
*** k-joseph has joined #openmrs
|
21:01:53
|
<k-joseph> dkayiwaa: hi
|
21:01:58
|
<dkayiwa> k-joseph: hi
|
21:13:33
|
<k-joseph> dkayiwa: i have changed null to "" for all the three values as you told me and the error disappeared,
|
21:13:46
|
<dkayiwa> k-joseph: ok good
|
21:13:51
|
<k-joseph> dkayiwa: but still i have seen that this works still with only one value = "" the one for date, the error now is in
|
21:13:51
|
<k-joseph> birthdate field on patient search page, it is coming in the form 00:00:00
|
21:14:01
|
<dkayiwa> k-joseph: oh
|
21:14:17
|
<dkayiwa> k-joseph: did you set the value of the global properties using the settings page?
|
21:17:15
|
<k-joseph> dkayiwa: settings page?
|
21:17:25
|
<dkayiwa> k-joseph: yes
|
21:22:11
|
*** k-joseph has quit IRC
|
21:26:01
|
*** lh has quit IRC
|
21:33:39
|
*** k-joseph has joined #openmrs
|
21:35:48
|
<k-joseph> dkayiwa: sorry my network is on and off, which settings page? that could help me
|
21:37:06
|
<dkayiwa> k-joseph: yes that page
|
21:37:24
|
*** jkeiper has quit IRC
|
21:37:35
|
<dkayiwa> k-joseph: do you know how to set global properties values as an end user?
|
21:42:27
|
*** k-joseph has quit IRC
|
21:49:57
|
<yony258> dkayiwa: Can I ask a question? (can be later if now isn't a good time)
|
21:50:05
|
<dkayiwa> yony258: ok
|
21:50:26
|
<yony258> dkayiwa: How do I know if an extension point should extend "Extension" or "LinkExt" ?
|
21:56:33
|
<dkayiwa> yony258: i think it depends on which exact extension point you want to extend
|
21:56:55
|
<dkayiwa> yony258: each has a base class you are expected to extend
|
21:57:22
|
<yony258> dkayiwa: How can I find out which base class should I extend for a specific extension point?
|
21:57:42
|
<dkayiwa> yony258: you either look at the code or wiki documentation
|
21:57:52
|
<yony258> dkayiwa: Ok, thank you
|
22:05:23
|
*** dkayiwa has quit IRC
|
22:27:36
|
*** mseaton has left #openmrs
|
22:36:55
|
*** LVW has joined #openmrs
|
22:46:28
|
*** wyclif has quit IRC
|
22:48:10
|
*** wyclif has joined #openmrs
|
23:18:50
|
*** LVW has quit IRC
|
23:42:07
|
*** yony258 has quit IRC
|