| 00:00:18 | <andreapat> djazayeri, C:\Users\patandre\workspace\openmrs-module-reporting\omod\src\main\webapp\cohorts\compositionCohortDefinition.jsp |
| 00:00:44 | <andreapat> djazayeri, openmrs-module-reporting came from Rafal |
| 00:01:09 | <andreapat> djazayeri, am I misunderstanding something? |
| 00:01:32 | <djazayeri> andreapat: okay. so, you cloned openmrs-module-reporting from github? |
| 00:01:46 | <andreapat> djazayeri, yes |
| 00:01:50 | <djazayeri> andreapat: then you made a change, and did a maven build; that's where the omod came from... |
| 00:02:05 | <andreapat> djazayeri, yes |
| 00:02:15 | <djazayeri> andreapat: so, I think that you should update to the latest version of the code, since I think that this has been fixed |
| 00:02:38 | <djazayeri> andreapat: using git pull |
| 00:03:05 | <andreapat> djazayeri, ok thanks again - didn't know there was any problem with the code - will do that |
| 00:03:54 | <andreapat> djazayeri, ok will pull down the latest version and try again |
| 00:21:15 | *** wyclif has joined #openmrs |
| 00:44:52 | *** andreapat has quit IRC |
| 00:58:54 | *** mseaton has joined #openmrs |
| 00:58:54 | *** ChanServ sets mode: +v mseaton |
| 01:00:35 | <mseaton> wyclif: sorry i dropped off before. am back online now. i never run against trunk. are you running latest from trunk? |
| 01:43:48 | *** djazayeri has quit IRC |
| 04:24:10 | *** mseaton has quit IRC |
| 05:35:40 | *** robbyoconnor has quit IRC |
| 05:36:09 | *** robbyoconnor has joined #openmrs |
| 05:36:09 | *** ChanServ sets mode: +v robbyoconnor |
| 05:38:45 | *** k-joseph has joined #openmrs |
| 05:43:45 | *** k-joseph has quit IRC |
| 06:26:58 | *** k-joseph has joined #openmrs |
| 06:45:53 | *** robbyoconnor has quit IRC |
| 06:46:26 | *** robbyoconnor has joined #openmrs |
| 06:46:26 | *** ChanServ sets mode: +v robbyoconnor |
| 06:47:03 | *** upul has quit IRC |
| 07:43:11 | *** djazayeri has joined #openmrs |
| 07:43:11 | *** ChanServ sets mode: +o djazayeri |
| 07:43:16 | *** k-joseph has quit IRC |
| 07:50:56 | *** dkayiwa has joined #openmrs |
| 08:43:51 | *** djazayeri has quit IRC |
| 09:43:38 | *** deepaganu has joined #openmrs |
| 09:43:47 | <deepaganu> Hi dkayiwa |
| 09:43:50 | <deepaganu> hi robbyoconnor |
| 09:44:08 | <deepaganu> i have to put some third party libs in the nexus repo |
| 09:44:16 | <deepaganu> how do i go about it |
| 09:44:27 | <dkayiwa> deepaganu: hi |
| 09:44:56 | <deepaganu> I have created a ISTM ticket |
| 09:45:55 | <dkayiwa> deepaganu: if you have created an ISTM, then just wait for Michael to respond :) |
| 09:46:08 | <dkayiwa> deepaganu: he must be in bed now |
| 09:46:12 | <deepaganu> he has responded way back |
| 09:46:21 | <dkayiwa> oh great |
| 09:47:06 | <deepaganu> my account has also been created |
| 09:47:15 | <deepaganu> but i dont know now what should i do |
| 09:48:13 | <deepaganu> currently my pom.xml look slike this http://pastebin.com/SFpJShFQ |
| 09:48:39 | <deepaganu> now i need to put the jars mentioned in the pom.xml in the nexus repo right dkayiwa |
| 09:49:19 | <dkayiwa> deepaganu: log onto nexus |
| 09:49:24 | <dkayiwa> deepaganu: and upload them |
| 09:49:37 | <dkayiwa> deepaganu: aren't they already on maven central? |
| 09:49:46 | <deepaganu> no |
| 09:49:56 | <deepaganu> i dont think so |
| 09:50:16 | <deepaganu> how do i check that whether they are there in maven centel dkayiwa |
| 09:50:33 | <dkayiwa> deepaganu: what jars are they? |
| 09:50:39 | <dkayiwa> deepaganu: can you give an example? |
| 09:50:52 | <deepaganu> mdht runtime jars fro export ccd module |
| 09:51:45 | <dkayiwa> deepaganu: ok log onto nexus and upload |
| 09:52:04 | <deepaganu> i am into nexus |
| 09:52:41 | <deepaganu> where do i upload them |
| 09:52:47 | <deepaganu> in which repository |
| 09:53:14 | <dkayiwa> deepaganu: do you have the source code of the jars you want to upload? |
| 09:53:27 | <deepaganu> no only jar files |
| 09:53:27 | <dkayiwa> deepaganu: and if yes, is it mavenized? |
| 09:53:38 | <deepaganu> no they are not mavenized |
| 09:54:17 | <deepaganu> dkayiwa: |
| 09:54:20 | *** k-joseph has joined #openmrs |
| 09:54:37 | <k-joseph> dkayiwa: hi |
| 09:54:41 | <dkayiwa> deepaganu: click the repositories link |
| 09:54:43 | <dkayiwa> k-joseph: hi |
| 09:54:49 | <deepaganu> done |
| 09:55:14 | <deepaganu> i ckicked on the repo link dkayiwa |
| 09:55:45 | <dkayiwa> deepaganu: then choose the 3rd party repo |
| 09:55:54 | <deepaganu> ok then ? |
| 09:56:15 | <deepaganu> choosen |
| 09:56:18 | <deepaganu> dkayiwa: |
| 09:56:20 | <dkayiwa> deepaganu: which structure do you want to user? |
| 09:56:26 | <dkayiwa> deepaganu: org or com? |
| 09:56:32 | <deepaganu> org |
| 09:56:43 | <dkayiwa> deepaganu: then expand it |
| 09:56:52 | <deepaganu> ok |
| 09:57:17 | <deepaganu> did |
| 09:57:17 | <dkayiwa> deepaganu: from there create any structure you want |
| 09:57:24 | <dkayiwa> by right clicking and etc |
| 09:57:36 | <deepaganu> how to create the structure |
| 09:57:48 | <dkayiwa> deepaganu: right click |
| 09:57:55 | <dkayiwa> deepaganu: on orf |
| 09:57:58 | <dkayiwa> org |
| 09:58:24 | <deepaganu> it does not show anything if i right click on it |
| 09:58:27 | <deepaganu> dkayiwa: |
| 09:59:03 | <dkayiwa> deepaganu: sorry i misled you a bit :) |
| 09:59:12 | <dkayiwa> deepaganu: go to artifact upload tab |
| 09:59:17 | <dkayiwa> deepaganu: on right had side |
| 09:59:17 | <deepaganu> ok |
| 09:59:26 | *** ibewes has joined #openmrs |
| 09:59:41 | <deepaganu> got the artifact upload tab |
| 09:59:59 | <dkayiwa> deepaganu: feel in the values there |
| 10:00:11 | <deepaganu> Ok |
| 10:00:24 | <deepaganu> i would try that and let you know dkayiwa |
| 10:00:26 | <deepaganu> thanks |
| 10:00:29 | <deepaganu> :) |
| 10:00:30 | <dkayiwa> deepaganu: ok |
| 10:26:21 | <k-joseph> dkayiwa: current pastie link http://pastebin.com/yif3J3jc |
| 10:27:22 | <deepaganu> dkayiwa: I have all the required jars in the 3rd party lib in nexus repo |
| 10:27:49 | <deepaganu> so do i have to change my pom.xml , so that it points to the 3rd party lib |
| 10:27:58 | <deepaganu> or would it take automatically dkayiwa |
| 10:28:02 | <dkayiwa> k-joseph: can you used a naming convention like this? GLOBAL_POPERTY_DATE_DISPLAY_FORMAT |
| 10:28:06 | <dkayiwa> etc |
| 10:28:31 | <dkayiwa> k-joseph: change your javadocs also to reflect that |
| 10:29:12 | <dkayiwa> k-joseph: the description in props.add(....) also does not seem to make sense to me |
| 10:29:22 | <dkayiwa> k-joseph: can you make it clearer? |
| 10:29:51 | <dkayiwa> deepaganu: yes your pom needs to match the parameters you put in nexus |
| 10:30:04 | <deepaganu> they do match |
| 10:30:12 | <dkayiwa> deepaganu: they you are done |
| 10:30:17 | <deepaganu> but should i change the repo location |
| 10:30:20 | <dkayiwa> they = then |
| 10:30:29 | <deepaganu> oki will try building my module again |
| 10:30:30 | <dkayiwa> deepaganu: yes |
| 10:30:39 | <deepaganu> how? |
| 10:31:03 | <dkayiwa> deepaganu: try build now and see what happens |
| 10:31:16 | <deepaganu> same error |
| 10:31:44 | <deepaganu> in my pom.xml i have this <repositories> <repository> <id>openmrs-repo</id> <name>OpenMRS Nexus Repository</name> <url>http://mavenrepo.openmrs.org/nexus/content/repositories/public</url> </repository> </repositories> |
| 10:31:47 | <deepaganu> dkayiwa: |
| 10:32:02 | <deepaganu> does it mean it would point to the third party libs also |
| 10:32:20 | <deepaganu> i can see my jars in the tree structure of nexus repo dkayiwa |
| 10:33:03 | <dkayiwa> deepaganu: pastebin the log |
| 10:53:45 | <deepaganu> dkayiwa: |
| 10:53:51 | <dkayiwa> deepaganu: |
| 10:53:54 | <deepaganu> i am getting this error |
| 10:53:55 | <deepaganu> http://pastebin.com/wRupFgDh |
| 10:54:24 | <deepaganu> but it should look in the other repo i.e the third party repo than looking in public |
| 10:54:44 | *** ibewes has quit IRC |
| 10:54:50 | <dkayiwa> deepaganu: can i also look at the pom |
| 10:55:01 | <deepaganu> ya sure 1 sec |
| 10:55:50 | <deepaganu> here is the pom.xml http://pastebin.com/V1w3fsY6 |
| 10:58:22 | <dkayiwa> deepaganu: if exportccd is an openmrs module then it does not belong to third parties |
| 10:58:37 | <deepaganu> yes |
| 10:58:56 | <dkayiwa> deepaganu: did you put it under 3rd party? |
| 10:59:04 | <deepaganu> but the rest of the jars i kept them in the third party |
| 10:59:10 | <deepaganu> didnt get you |
| 10:59:17 | <deepaganu> i didnt change anything |
| 10:59:23 | <deepaganu> dkayiwa: |
| 10:59:30 | <dkayiwa> deepaganu: do you have exportccd in nexus? |
| 10:59:36 | <deepaganu> no |
| 11:00:02 | <dkayiwa> deepaganu: oh its the module you are building? |
| 11:00:09 | <k-joseph> dkayiwa: pastie link, http://pastebin.com/3w4pjLtx |
| 11:00:17 | <deepaganu> sorry its there |
| 11:00:34 | <deepaganu> the exportccd module is there in the nexus repo |
| 11:00:36 | <deepaganu> dkayiwa: |
| 11:02:03 | <dkayiwa> deepaganu: what module are you building |
| 11:02:38 | <deepaganu> i crashed my system , so i am trying to extend the export ccd module |
| 11:02:59 | <deepaganu> so i wanted that ccd module to first work on my system |
| 11:03:05 | <deepaganu> trying to do that dkayiwa |
| 11:03:21 | <deepaganu> i am just rebuilding the export ccd module |
| 11:03:56 | <dkayiwa> deepaganu: so do you mean the export ccd module was not building even before your changes? |
| 11:04:26 | <deepaganu> it was building coz at that time i had locally installed the jars |
| 11:04:59 | <deepaganu> but now since other people want to use it , i had to upload the third party jars it requires for functionality |
| 11:05:13 | <dkayiwa> deepaganu: oh i see |
| 11:05:21 | <deepaganu> so i thought this time let me do it right by uploading it in the repo |
| 11:05:35 | <dkayiwa> deepaganu: did you change its pom in any way? |
| 11:05:41 | <deepaganu> yes |
| 11:05:43 | <deepaganu> i have |
| 11:05:54 | <dkayiwa> deepaganu: what did you change |
| 11:06:00 | <deepaganu> the one which i showed you is the latest pom |
| 11:06:41 | <deepaganu> i added a repository tag which point to the 3rd party lib dkayiwa |
| 11:07:19 | <deepaganu> [WARNING] The POM for org.openhealthtools.mdht.uml:cda:jar:1.0.0.201109121753 is missing, no dependency information available [WARNING] The POM for org.openhealthtools.mdht.uml.hl7:rim:jar:1.0.0.201109121753 is missing, no dependency information available [WARNING] The POM for org.openhealthtools.mdht.uml.hl7:vocab:jar:1.0.0.201109121753 is missing, no dependency information available |
| 11:07:37 | <deepaganu> i even got this warning while building the module |
| 11:09:19 | <deepaganu> dkayiwa: |
| 11:09:25 | *** k-joseph_ has joined #openmrs |
| 11:11:29 | *** k-joseph has quit IRC |
| 11:12:26 | <dkayiwa> deepaganu: which command do you use to build? |
| 11:12:37 | <deepaganu> maven install |
| 11:14:01 | <deepaganu> dkayiwa: |
| 11:15:41 | <dkayiwa> deepaganu: remove the third party repo from the pom |
| 11:15:49 | <deepaganu> Ok |
| 11:16:18 | <dkayiwa> deepaganu: and then mvn clean install |
| 11:17:02 | <deepaganu> dkayiwa: doing that |
| 11:18:04 | <deepaganu> here is the output dkayiwa |
| 11:18:05 | <deepaganu> http://pastebin.com/wSe6i6Fg |
| 11:19:24 | <dkayiwa> deepaganu: the pom you sent me is in which project |
| 11:19:38 | <deepaganu> export ccd |
| 11:19:54 | <deepaganu> i removed the repository tag and built it again |
| 11:20:08 | <deepaganu> do you want to see the lateset pom.xml |
| 11:21:24 | <deepaganu> you asked me to remove the repository tag , so now the latest pom.xml looks like this http://pastebin.com/V5N3zZMw |
| 11:21:26 | <deepaganu> dkayiwa: |
| 11:24:26 | <deepaganu> dkayiwa: |
| 11:24:46 | <deepaganu> it says the repository is offline and these jars are not there in local repo |
| 11:26:26 | <dkayiwa> deepaganu: can i look at your pom in the parent folder |
| 11:26:41 | <k-joseph_> dkayiwa: hi |
| 11:26:54 | <dkayiwa> k-joseph_: hi |
| 11:27:06 | <k-joseph_> dkayiwa: is the previous pastie ok, and still am here PersonalListItem birthdateString = Format.format(), can you help me here, i need to understand how and what you mean by your comment about changinging this |
| 11:27:09 | <deepaganu> yes the above url points to the pom.xmlin the parent folder |
| 11:27:12 | <deepaganu> dkayiwa: |
| 11:28:05 | <dkayiwa> k-joseph_: can you start by respond to to my comments in the pastebin link you just sent me? |
| 11:29:34 | *** k-joseph_ is now known as k-joseph |
| 11:30:46 | <k-joseph> dkayiwa: which comments, i thought i had responded to the previou comments about javadoc and description, any other comments? |
| 11:31:52 | <dkayiwa> k-joseph: read the irc comments when last typed a couple of minutes ago |
| 11:31:52 | <k-joseph> dkayiwa: http://pastebin.com/3w4pjLtx |
| 11:32:49 | <dkayiwa> k-joseph: what does this mean? "display of format of Time " |
| 11:34:34 | <k-joseph> dkayiwa: display of time format |
| 11:35:07 | <dkayiwa> k-joseph: can you reword it better by removing the repitition |
| 11:37:50 | <dkayiwa> deepaganu: where is the org.eclipse.emf:ecore:jar:2.5.0.v200906151043 artifact? |
| 11:38:08 | <deepaganu> just now added it in the third party |
| 11:38:50 | <dkayiwa> deepaganu: go ahead using the same principle and solve all the others |
| 11:39:14 | <deepaganu> yes, but the other jars already exsists |
| 11:39:28 | <dkayiwa> deepaganu: like which one? |
| 11:39:39 | <deepaganu> hl7 rim.jar |
| 11:39:56 | <deepaganu> i deleted my local repo |
| 11:40:04 | <deepaganu> and building my project again |
| 11:40:18 | <dkayiwa> deepaganu: yes you need to do that |
| 11:40:44 | *** mseaton has joined #openmrs |
| 11:40:44 | *** ChanServ sets mode: +v mseaton |
| 11:42:37 | <k-joseph> dkayiwa: http://pastebin.com/QReazp5d |
| 11:44:14 | <dkayiwa> k-joseph: change the to some thing like: date display format |
| 11:50:26 | <k-joseph> dkayiwa: http://pastebin.com/XedzEWFB |
| 11:51:51 | <dkayiwa> k-joseph: can you also remove the redundant null initialization? That is because java automatically initializes those variables to null |
| 11:52:23 | *** mseaton has quit IRC |
| 11:52:57 | <k-joseph> dkayiwa: but that produces an error, when not initialised |
| 11:53:15 | <dkayiwa> k-joseph: which error? |
| 11:54:00 | <k-joseph> dkayiwa: The blank final field GLOBAL_POPERTY_DATE_DISPLAY_FORMAT may not have been initialized |
| 11:54:17 | <k-joseph> dkayiwa: that is the error |
| 11:56:44 | <dkayiwa> k-joseph: oh actually the value is supposed to be a global property name instead of null. just like for the rest of the global properties in that class. ca you change that? |
| 12:03:29 | <k-joseph> dkayiwa: where are the names of the global property found, is it in GlobalProperty.java? |
| 12:04:05 | <dkayiwa> k-joseph: what you are declaring is a constant for a global property name |
| 12:04:30 | <dkayiwa> k-joseph: can you look at any existing constants and you see what am saying? |
| 12:04:53 | <k-joseph> dkayiwa: looking.... |
| 12:05:02 | *** deepaganu has quit IRC |
| 12:27:05 | *** rubailly has joined #openmrs |
| 12:28:29 | <k-joseph> dkayiwa: http://pastebin.com/aMPyXgwD |
| 12:33:47 | <dkayiwa> k-joseph: very much better. how about using something like this? displayFormat.date, displayFormat.time, displayFormat.dateTime |
| 12:34:17 | <k-joseph> dkayiwa: ok |
| 12:34:38 | <dkayiwa> k-joseph: did you claim the ticket? |
| 12:34:51 | <k-joseph> dkayiwa: yes |
| 12:35:08 | <dkayiwa> k-joseph: which ticket number? |
| 12:35:32 | <k-joseph> dkayiwa: TRUNK-3765 |
| 12:35:43 | <dkayiwa> !ticket v |
| 12:35:44 | <OpenMRSBot> dkayiwa: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/v |
| 12:35:47 | <dkayiwa> !ticket TRUNK-3765 |
| 12:35:48 | <OpenMRSBot> dkayiwa: [#TRUNK-3765] Show the fully-specified birthdate date format like it did previously on patient search results - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3765 |
| 12:51:47 | *** mseaton has joined #openmrs |
| 12:51:47 | *** ChanServ sets mode: +v mseaton |
| 13:08:33 | <k-joseph> dkayiwa: hi |
| 13:08:40 | <dkayiwa> k-joseph: hi |
| 13:09:12 | <k-joseph> dkayiwa: done the previous |
| 13:09:52 | <dkayiwa> k-joseph: pastebin |
| 13:12:11 | <k-joseph> dkayiwa: http://pastebin.com/kVqE3ZQD |
| 13:13:10 | <dkayiwa> k-joseph: can i also see the other section that has props.add( |
| 13:15:46 | *** pascal` has joined #openmrs |
| 13:15:46 | *** ChanServ sets mode: +v pascal` |
| 13:16:07 | <pascal`> !seen downeym |
| 13:16:07 | <OpenMRSBot> pascal`: downeym was last seen in #openmrs 47 weeks, 4 days, 17 hours, 3 minutes, and 44 seconds ago: <downeym> Hi downey and welcome to the #openmrs IRC channel. |
| 13:16:25 | <pascal`> D: |
| 13:16:57 | *** pascal` has quit IRC |
| 13:18:23 | <k-joseph> dkayiwa: http://pastebin.com/L5Hi9t3W |
| 13:19:30 | <dkayiwa> k-joseph: ok looks good. can you proceed? |
| 13:22:07 | <k-joseph> dkayiwa: how about formatting birthdate, here birthdateString = Format.format(person.getBirthdate()); ??? |
| 13:24:54 | <dkayiwa> k-joseph: open the Format.java class |
| 13:25:46 | <k-joseph> dkayiwa: openned it |
| 13:26:12 | <dkayiwa> k-joseph: do you see the method? public static String format(Date date, Locale locale, FORMAT_TYPE type) { |
| 13:26:43 | *** jkeiper has joined #openmrs |
| 13:26:43 | *** ChanServ sets mode: +v jkeiper |
| 13:27:24 | <k-joseph> dkayiwa: i have seen that |
| 13:28:18 | <dkayiwa> k-joseph: thats where we are going to change. by the way, were you able to reproduce the reported behavior in the browser as reported on the ticket by james? |
| 13:29:01 | <k-joseph> dkayiwa: yes, |
| 13:29:20 | <dkayiwa> k-joseph: so you see the problem? |
| 13:29:34 | <dkayiwa> k-joseph: as reported by end user? |
| 13:29:38 | <k-joseph> dkayiwa: yes, i so it |
| 13:29:51 | <dkayiwa> k-joseph: and you know how it should look like when fixed? |
| 13:32:37 | <dkayiwa> k-joseph: as in how to test if our code has fixed it? |
| 13:33:30 | <k-joseph> dkayiwa: is it as 15-JAN-2013? |
| 13:34:58 | <dkayiwa> k-joseph: how does it currently display in your browser? |
| 13:35:43 | <k-joseph> dkayiwa: 15/1/13 |
| 13:36:37 | <dkayiwa> k-joseph: can you read Jame's ticket description again? |
| 13:37:10 | <k-joseph> dkayiwa: ok |
| 13:38:30 | <k-joseph> dkayiwa: finished reading it, again |
| 13:38:41 | <dkayiwa> k-joseph: so how should it look like? |
| 13:39:31 | <k-joseph> dkayiwa: 30-Aug-1977 |
| 13:41:07 | <dkayiwa> k-joseph: ok |
| 14:12:24 | *** kavuri has joined #openmrs |
| 14:14:51 | <dkayiwa> hi k-joseph |
| 14:15:10 | <k-joseph> dkayiwa: hi |
| 14:15:20 | <dkayiwa> k-joseph: do you know how to proceed? |
| 14:15:40 | <k-joseph> dkayiwa: tried but failed so far |
| 14:16:22 | <dkayiwa> k-joseph: ok. in that method. check if global property is set, and then use its format. else, you use the default |
| 14:17:30 | <dkayiwa> k-joseph: something like this: String formatValue = Context.getAdministrationService().getGlobalPropertyValue(propertyName, null) |
| 14:23:12 | <dkayiwa> hi k-joseph |
| 14:23:35 | <k-joseph> dkayiwa: hi |
| 14:23:45 | <dkayiwa> k-joseph: am going to pastebin for you a sample |
| 14:24:06 | <k-joseph> dkayiwa: ok thanks |
| 14:24:55 | <dkayiwa> k-joseph: here it is: http://pastebin.com/VL4K41hU |
| 14:25:18 | <dkayiwa> k-joseph: do you see the change i have done for the first: if (type == FORMAT_TYPE.TIMESTAMP) ??? |
| 14:26:15 | <dkayiwa> k-joseph: i have done it for dateTime in that first if statement |
| 14:26:36 | <dkayiwa> k-joseph: so do that for the remaining two else blocks (for time and date) |
| 14:26:42 | <dkayiwa> k-joseph: does this make sense? |
| 14:27:37 | *** k-joseph_ has joined #openmrs |
| 14:30:05 | <dkayiwa> dkayiwa: k-joseph: here it is: http://pastebin.com/VL4K41hU |
| 14:30:06 | <dkayiwa> [5:58pm] dkayiwa: k-joseph: do you see the change i have done for the first: if (type == FORMAT_TYPE.TIMESTAMP) ??? |
| 14:30:06 | <dkayiwa> [5:59pm] dkayiwa: k-joseph: i have done it for dateTime in that first if statement |
| 14:30:07 | <dkayiwa> [5:59pm] dkayiwa: k-joseph: so do that for the remaining two else blocks (for time and date) |
| 14:30:07 | <dkayiwa> [5:59pm] dkayiwa: k-joseph: does this make sense? |
| 14:30:30 | <dkayiwa> k-joseph: you will also create a unit test for that method |
| 14:30:35 | *** k-joseph has quit IRC |
| 14:30:48 | <k-joseph_> dkayiwa: ok |
| 14:32:32 | *** k-joseph_ is now known as k-joseph |
| 14:34:36 | <mseaton> wyclif: are you still having problems from yesterday? |
| 14:35:02 | *** dkayiwa has quit IRC |
| 14:35:08 | <wyclif> mseaton, i managed to work get past it |
| 14:36:11 | <wyclif> mseaton, but i still run into errors, but atleast am able to run the module and test the bug for the ticket am working on |
| 14:36:34 | <mseaton> wyclif: are you on trunk? |
| 14:36:43 | <mseaton> wyclif: openmrs trunk i mean |
| 14:42:10 | *** k-joseph_ has joined #openmrs |
| 14:44:20 | *** k-joseph has quit IRC |
| 14:55:20 | *** rafa has joined #openmrs |
| 14:55:20 | *** ChanServ sets mode: +v rafa |
| 15:00:14 | *** r0bby has joined #openmrs |
| 15:00:14 | *** ChanServ sets mode: +v r0bby |
| 15:00:54 | *** cpower has joined #openmrs |
| 15:01:06 | <cpower> Hola! |
| 15:01:19 | <cpower> Let us begin our daily Scrum... |
| 15:01:25 | <cpower> !scrumon cpower |
| 15:01:25 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:01:40 | <wyclif> mseaton, yes iw as |
| 15:02:05 | <cpower> Order: mseaton, rafa, wyclif, andrea when she shows, and Darius if he shows |
| 15:02:14 | <cpower> and jkeiper if he wants |
| 15:02:29 | *** robbyoconnor has quit IRC |
| 15:02:46 | *** andrea_ has joined #openmrs |
| 15:03:11 | <andrea_> rafa, u there? |
| 15:03:22 | <cpower> mseaton you are up |
| 15:03:31 | <mseaton> doing code review, ticket review. |
| 15:03:33 | <rafa> andrea_: scrum is on |
| 15:03:34 | <mseaton> no blockers |
| 15:03:41 | <rafa> Today: |
| 15:03:41 | <rafa> * Continued with REPORT-464: Support Metadata Sharing of all Reporting Module metadata |
| 15:03:41 | <rafa> https://tickets.openmrs.org/browse/REPORT-464 |
| 15:03:41 | <rafa> * Committed META-306: Call getPriorityDependencies when determining related items |
| 15:03:41 | <rafa> https://tickets.openmrs.org/browse/META-306 |
| 15:03:41 | <rafa> * Created: |
| 15:03:41 | <rafa> + META-307: Group metadata types to export |
| 15:03:42 | <rafa> https://tickets.openmrs.org/browse/META-307 |
| 15:03:42 | <rafa> + REPORT-469: @ConfigurationProperty and UI related metadata |
| 15:03:43 | <rafa> https://tickets.openmrs.org/browse/REPORT-469 |
| 15:03:43 | <rafa> * Reviewed tickets |
| 15:03:44 | <rafa> No blockers. |
| 15:04:05 | <wyclif> Monday: |
| 15:04:05 | <wyclif> Review TODOs for REPORT-461 - Expose reporting module Person and Patient Data Definitions as Calculations |
| 15:04:05 | <wyclif> Skype call wtih Wolf Schlegel about TRUNK-2472 - Obey searchable property from person attributes |
| 15:04:05 | <wyclif> REPORT-444 (was blocked to run reporting so didn't do much) - When editing Report Processors the changes are saved but don't take effect |
| 15:04:05 | <wyclif> |
| 15:04:07 | <wyclif> Tuesday: |
| 15:04:08 | *** k-joseph_ has quit IRC |
| 15:04:09 | <wyclif> Continue with REPORT-444 - When editing Report Processors the changes are saved but don't take effect |
| 15:04:11 | <wyclif> pick up another sprint ticket |
| 15:04:13 | <wyclif> |
| 15:04:15 | <wyclif> Blockers: None |
| 15:04:25 | <cpower> andrea_ your turn |
| 15:04:42 | <andrea_> Monday |
| 15:04:42 | <andrea_> Sprint-201301 |
| 15:04:42 | <andrea_> Report-415 |
| 15:04:42 | <andrea_> Installed Reporting Module to test changes in update to the latest version of the code |
| 15:04:42 | <andrea_> Error Starting it |
| 15:04:43 | <andrea_> Tuesday |
| 15:04:45 | <andrea_> Possible bug in code - get latest version of the code from github |
| 15:04:47 | <andrea_> Test changes in compositionCohortDefinition.jsp in UI |
| 15:04:49 | <andrea_> |
| 15:04:51 | <andrea_> Blocker |
| 15:04:53 | <andrea_> Error statring module - is this a bug? |
| 15:05:40 | <rafa> andrea_: what is the error? |
| 15:05:41 | <mseaton> andrea_: i didn't see any emails or irc chatter about the bug. did you ask for help? |
| 15:06:09 | <cpower> Ok, we have an error starting the report module (is it buggy?) as our blocker. Most likely looking for more details from andrea_ to the group. |
| 15:06:14 | <andrea_> mseaton, yes contacted djazayeri on irc - |
| 15:06:45 | <andrea_> mseaton, he said first version had was buggy |
| 15:07:20 | <mseaton> andrea_: you are working off of the sprint-201301 branch, right? |
| 15:07:38 | <andrea_> cpower, from stacktrace: Caused by: java.lang.ClassNotFoundException: org.openmrs.module.reporting-omod.ModuleActivator |
| 15:08:06 | <mseaton> andrea_: yes, this was a temporary issue fixed by rafa before the sprint started |
| 15:08:22 | <andrea_> mseaton, yes sprint-201301 branch |
| 15:09:20 | <andrea_> mseaton, should I get code again? I got the code at the beginning of the sorint |
| 15:09:33 | <mseaton> andrea_: you should be building your own omods based on the latest from the branch, regularly. certainly if you are making changes to code, running old omods won't contain your changes :) |
| 15:10:02 | <mseaton> andrea_: it is good practice to keep your code up to date as you develop, yes |
| 15:10:15 | <andrea_> mseaton, ok will do |
| 15:10:55 | <rafa> andrea_: remember the command is: git pull --rebase upstream sprint-201301 |
| 15:11:08 | <mseaton> andrea_: irc log from yesterday says you are running an omod taht rafa gave you. |
| 15:11:33 | <rafa> mseaton: I gave? |
| 15:11:34 | <andrea_> rafa, yes I remember - will do |
| 15:11:48 | <andrea_> mseaton, yes |
| 15:11:57 | <mseaton> andrea_: darius' instructions from last night are pretty clear. are you still blocked today after talking to him? |
| 15:12:19 | <cpower> Ok, Annoucements: We are prepping for the design call for tomorrow. Currently we have some Patient Summary things to go on it, but if you have any other topics you would like to discuss we are always open to suggestions. Patient Summary will be our next sprint we are still taking dev's and testers for this sprint. |
| 15:12:23 | <cpower> Thank you and see you in 24hrs! |
| 15:12:27 | <cpower> !scrumoff |
| 15:12:27 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:12:32 | <andrea_> mseaton, need to get into work and test it |
| 15:12:45 | <rafa> cpower: thanks! |
| 15:12:55 | <mseaton> andrea_: ok, good luck. ping on irc if you hit snags and email dev list if you don't get traction on irc. |
| 15:13:14 | <andrea_> mseaton, ok will do |
| 15:13:23 | <mseaton> andrea_: or comment on your ticket. we will see those commetns too and respond. |
| 15:13:55 | <andrea_> mseaton, ok |
| 15:15:01 | <mseaton> thanks all - i'm really seeing great progress on things this sprint. great work! |
| 15:24:39 | *** rafa has quit IRC |
| 15:36:47 | <jkeiper> cpower, i want to talk about using calculations as columns in reporting ... but might be able to just talk w/ mseaton at some point and avoid it on the design call |
| 16:01:20 | *** kavuri has quit IRC |
| 16:12:41 | *** pulasthi7 has joined #openmrs |
| 16:16:43 | *** rafa has joined #openmrs |
| 16:16:43 | *** ChanServ sets mode: +v rafa |
| 16:24:13 | *** r0bby is now known as robbyoconnor |
| 16:26:52 | *** ningosi has joined #openmrs |
| 16:31:23 | *** djazayeri has joined #openmrs |
| 16:31:23 | *** ChanServ sets mode: +o djazayeri |
| 16:35:54 | <mseaton> jkeiper: happy to discuss |
| 16:46:50 | *** dehrg has joined #openmrs |
| 16:47:23 | <dehrg> hello |
| 16:48:03 | *** mseaton has quit IRC |
| 16:52:21 | <dehrg> does anyone know when the google summer of code projects are set to be merged into production? |
| 16:52:29 | <dehrg> specifically the ajax loading of patient dashboard tabs? |
| 16:56:59 | *** rafa has quit IRC |
| 17:03:43 | *** andrea_ has quit IRC |
| 17:05:03 | *** mseaton has joined #openmrs |
| 17:05:03 | *** ChanServ sets mode: +v mseaton |
| 17:06:07 | <rubailly> hi Mike |
| 17:08:54 | *** ningosi has quit IRC |
| 17:10:44 | *** suranga has joined #openmrs |
| 17:10:44 | *** ChanServ sets mode: +v suranga |
| 17:12:12 | <rubailly> does anyone here knows how the workflowState tag of htmlformentry works I'm having a problem where multiple program enrollments are created for the same program when I use this tag more than once on the same form |
| 17:12:30 | <mseaton> hi rubailly |
| 17:12:46 | <rubailly> hi Mike :-) |
| 17:13:01 | <mseaton> rubailly: i'm not sure. would need to look at the code. just a sec. |
| 17:13:08 | <rubailly> ok |
| 17:14:31 | <rubailly> can I skype you a picture of a patient dashboard where you can see this problem? |
| 17:14:37 | <mseaton> rubailly: sure. |
| 17:15:41 | <rubailly> i think it might be a proble in the WorkflowStateSubmissionElement |
| 17:19:19 | <mseaton> rubailly: it would appear that way. i think the issue is that if there is no active program enrollment for the program involved, then htmlformentry will create a program enrollment and transition to the passed state. if there are 2 of these tags in the form, it will do this twice. it is not smart enough to recognize that a program enrollment has been added previously in the form entry session i guess. this would likely be where the bug lies. probabl |
| 17:21:24 | <dehrg> does anyone know when the google summer of code projects are set to be merged into production? |
| 17:21:39 | *** wyclif has quit IRC |
| 17:22:27 | <rubailly> ok |
| 17:23:08 | <mseaton> rubailly: can you create a ticket for this and add the comments from here on the ticket. this way mark and djazayeri can both see the issue and comment there for the record if needed. |
| 17:23:21 | <rubailly> I think a good behavior would be to check if the patient is not already enrolled in the program first |
| 17:23:35 | <rubailly> yes |
| 17:28:22 | *** apb156 has joined #openmrs |
| 17:31:48 | <apb156> hey guys, I'm trying to create an XForms form that includes search boxes to incrementally add multiple diagnoses and treatments. My concept dictionary is from MVP. Is this fairly straightforward? |
| 17:40:26 | *** Anuruddha has joined #openmrs |
| 17:42:40 | <mseaton> rubailly: well, it does do this, but it doesn't look at what has happened earlier in the form entry context i believe. |
| 17:48:45 | *** kaweesi has joined #openmrs |
| 17:49:05 | *** kaweesi is now known as k-joseph |
| 17:51:15 | *** pulasthi7 has quit IRC |
| 17:52:48 | <rubailly> ... ok, thanks |
| 17:52:57 | *** dehrg has quit IRC |
| 18:02:41 | *** k-joseph_ has joined #openmrs |
| 18:05:40 | *** k-joseph_ is now known as Guest1 |
| 18:08:00 | *** Anuruddha has quit IRC |
| 18:22:27 | *** apb156 has left #openmrs |
| 18:26:17 | *** rubailly has quit IRC |
| 18:36:56 | <cpower> who's doing Community Development this week? |
| 18:38:27 | <cpower> As crickets fill the room |
| 18:38:55 | *** k-joseph has quit IRC |
| 18:44:59 | *** Guest1 has quit IRC |
| 18:50:23 | *** k-joseph has joined #openmrs |
| 19:01:27 | *** k-joseph_ has joined #openmrs |
| 19:04:05 | *** k-joseph has quit IRC |
| 19:04:17 | *** andreapat has joined #openmrs |
| 19:04:33 | <andreapat> mseaton, u around? |
| 19:05:49 | *** k-joseph_ is now known as k-joseph |
| 19:15:51 | *** Echidna has quit IRC |
| 19:16:12 | *** Echidna has joined #openmrs |
| 19:16:12 | *** ChanServ sets mode: +v Echidna |
| 19:30:30 | *** evmw has joined #openmrs |
| 19:40:21 | *** dkayiwa has joined #openmrs |
| 19:41:21 | *** suranga has quit IRC |
| 19:41:45 | *** andreapat has quit IRC |
| 19:44:58 | <k-joseph> dkayiwa: hi |
| 19:45:05 | <dkayiwa> k-joseph: hi |
| 19:45:23 | <k-joseph> dkayiwa: sent you a mail, i think much is missing for the problem is still experienced for the ticket |
| 19:45:43 | <dkayiwa> k-joseph: yes i just looked at it |
| 19:46:32 | *** wyclif has joined #openmrs |
| 19:46:42 | <dkayiwa> k-joseph: did you see my exact changes? |
| 19:46:57 | <dkayiwa> k-joseph: and did you understand them? |
| 19:47:19 | <k-joseph> dkayiwa: not totally |
| 19:48:53 | <dkayiwa> in the existing branch (if clause) for datetime format, i check if the global property is set. It it is not, i do was the existing code was doing, else, i create a format basing on the global property value. Does this make things clearer? |
| 20:05:06 | *** andreapat has joined #openmrs |
| 20:05:39 | <andreapat> djazayeri, I'm here |
| 20:06:08 | <djazayeri> andreapat: does doing "git remote -v" give you the right urls for upstream? |
| 20:07:06 | <andreapat> djazayeri, No $ git remote -v |
| 20:07:06 | <andreapat> origin https://github.com/andreapat/openmrs-core-1.git (fetch) |
| 20:07:06 | <andreapat> origin https://github.com/andreapat/openmrs-core-1.git (push) |
| 20:07:06 | <andreapat> upstream https://github.com/openmrs/openmrs-core.git (fetch) |
| 20:07:06 | <andreapat> upstream https://github.com/openmrs/openmrs-core.git (push) |
| 20:07:34 | <djazayeri> andreapat: that's for openmrs core, not for the reporting module... |
| 20:08:21 | <andreapat> djazayeri, yes - just realized that |
| 20:09:03 | <andreapat> djazayeri, $ git remote -v |
| 20:09:04 | <andreapat> origin https://github.com/andreapat/openmrs-module-reporting.git (fetch) |
| 20:09:04 | <andreapat> origin https://github.com/andreapat/openmrs-module-reporting.git (push) |
| 20:09:12 | <OpenMRSBot> <http://ln-s.net/+Srl> (at github.com) |
| 20:09:13 | <OpenMRSBot> <http://ln-s.net/+Srl> (at github.com) |
| 20:09:23 | <djazayeri> andreapat: okay, so you need to add the upstream remote _there_, not to openmrs-core |
| 20:09:59 | <andreapat> djazayeri, I think I was in worng dir - embarassing - sorry |
| 20:10:05 | <djazayeri> np |
| 20:10:29 | *** k-joseph has quit IRC |
| 20:12:38 | *** andreapat has quit IRC |
| 20:19:56 | *** andreapat has joined #openmrs |
| 20:20:21 | <andreapat> djazayei, pull looks good now! |
| 20:20:30 | <djazayeri> cool |
| 20:20:59 | <mseaton> andreapat: were you looking for me before? |
| 20:21:27 | <andreapat> mseaton, yes I was |
| 20:22:07 | <mseaton> andreapat: ok |
| 20:22:09 | <andreapat> mseaton, think I'm ok now - was able to do pull request |
| 20:22:35 | <andreapat> mseaton, going to reinstall reporting module now |
| 20:22:52 | <mseaton> andreapat: cool. |
| 20:23:45 | <andreapat> djazayei, thanks!! Had to logoff Merck network to do pull or connect error and I can't be on irc unless I'm on network |
| 20:24:20 | <andreapat> mseaton, will keep you posted |
| 20:29:23 | *** cpower has quit IRC |
| 20:34:12 | *** cpower has joined #openmrs |
| 20:43:07 | *** apb156 has joined #openmrs |
| 20:54:24 | <apb156> hey is Daniel here? |
| 20:54:44 | <dkayiwa> apb156: i saw you but never knew you were the one :) |
| 20:55:05 | <apb156> dkayiwa: Cool, thanks |
| 20:55:25 | <dkayiwa> apb156: so start by creating a new form |
| 20:55:25 | <apb156> dkayiwa: Did you see my messages on the board? |
| 20:55:32 | <apb156> dkayiwa: k |
| 20:56:01 | <dkayiwa> apb156: make a duplicate of the basic form. ok? |
| 20:56:12 | <dkayiwa> apb156: and do not delete any field on the form schema |
| 20:56:25 | <apb156> dkayiwa: I'm running 1.9.2 and there is no basic form. Right? |
| 20:57:03 | <apb156> dkayiwa: Isn't it just the default set of fields when you "Add form" |
| 20:57:28 | <dkayiwa> apb156: ok just create a new form |
| 20:57:55 | *** tobin_g has joined #openmrs |
| 20:58:23 | <apb156> dkayiwa: done |
| 20:58:40 | <dkayiwa> apb156: what is the type for the Visit Diagnoses concept? (as in the concept dictionary) |
| 21:00:13 | <apb156> dkayiwa: Well there are two when I search for Visit Diagnoses |
| 21:00:33 | <dkayiwa> apb156: what types are they |
| 21:00:41 | <apb156> dkayiwa: one is a Concept and the other is a Set of Concepts |
| 21:01:01 | <dkayiwa> apb156: can you rename one to avoid the confusion? |
| 21:01:51 | <apb156> dkayiwa: These are only from MVP, I haven't created any concepts of my own |
| 21:02:18 | <dkayiwa> apb156: drag the concept set one to the form schema |
| 21:02:51 | <dkayiwa> apb156: and set the value of its Max to -1 |
| 21:03:19 | <apb156> dkayiwa: done |
| 21:03:35 | <dkayiwa> apb156: did you set its max to -1? |
| 21:03:47 | <apb156> dkayiwa: yeah |
| 21:03:57 | <dkayiwa> apb156: now click the design xform link |
| 21:04:16 | <apb156> dkayiwa: k |
| 21:04:19 | <dkayiwa> apb156: and pastebin the xforms xml |
| 21:05:08 | <apb156> dkayiwa: from within designer? |
| 21:05:14 | <dkayiwa> apb156: yes |
| 21:06:46 | <apb156> dkayiwa: http://pastebin.com/U3fviSvL |
| 21:09:27 | <dkayiwa> apb156: can you put for me here the screenshot of your form schema page when this field is visible? http://snag.gy/ |
| 21:16:01 | <apb156> dkayiwa: http://snag.gy/0VLgM.jpg |
| 21:16:54 | <dkayiwa> apb156: move Visit Diagnosis to be under the OBS section |
| 21:17:54 | <apb156> dkayiwa: Done |
| 21:18:47 | <dkayiwa> apb156: delete PROBLEM LIST |
| 21:19:04 | <dkayiwa> apb156: oh no |
| 21:19:09 | <dkayiwa> apb156: just leave it alone |
| 21:19:29 | <dkayiwa> apb156: instead click the "Delete Xform" link |
| 21:19:31 | <apb156> dkayiwa: already gone, should I add it back |
| 21:19:36 | <dkayiwa> apb156: no |
| 21:19:59 | <apb156> dkayiwa: k, its deleted |
| 21:20:09 | <dkayiwa> apb156: the what? |
| 21:20:22 | <apb156> dkayiwa: You said click "Delete XForm" |
| 21:20:39 | <dkayiwa> apb156: now click the "Design Xform" link and send me the xforms xml on pastebin |
| 21:21:23 | <apb156> dkayiwa: got this error http://pastebin.com/xJAb108u |
| 21:22:01 | <dkayiwa> apb156: send me an image of your form schema |
| 21:22:31 | <dkayiwa> apb156: but first send the contents of the xforms xml |
| 21:22:40 | <dkayiwa> apb156: after you close the error popup |
| 21:23:21 | <dkayiwa> apb156: image with OBS and Visit Diagnosis expanded |
| 21:24:00 | <apb156> dkayiwa: when I went to save as, I got this error in the designer: http://pastebin.com/qGi9k8Lf |
| 21:24:14 | <dkayiwa> apb156: no need to save anything |
| 21:24:27 | <dkayiwa> apb156: simply copy and paste contents of the xforms xml tab |
| 21:26:08 | <apb156> dkayiwa: I don't have an xml tab |
| 21:26:14 | <apb156> dkayiwa: I guess that's a setting right? |
| 21:26:23 | <dkayiwa> apb156: yes |
| 21:26:31 | <dkayiwa> apb156: named Show Xforms Xml tab |
| 21:26:36 | <dkayiwa> apb156: under xforms |
| 21:27:28 | <apb156> dkayiwa: http://pastebin.com/8ruqbHPB |
| 21:27:48 | <dkayiwa> apb156: send the image too of form schema |
| 21:32:18 | <apb156> dkayiwa: sorry, i'm having problems with snaggy |
| 21:33:53 | *** rafa has joined #openmrs |
| 21:33:53 | *** ChanServ sets mode: +v rafa |
| 21:35:23 | <apb156> dkayiwa: http://snag.gy/J7TTn.jpg |
| 21:36:19 | <dkayiwa> apb156: can you also send me a screen show of how visit diagnoses appears in the concept dictionary? |
| 21:37:20 | <apb156> dkayiwa: http://snag.gy/urcgh.jpg |
| 21:38:11 | *** cpower has quit IRC |
| 21:38:23 | *** rafa has quit IRC |
| 21:41:07 | <dkayiwa> apb156: go to form schema and click the delete xform link |
| 21:41:44 | <apb156> dkayiwa: the delete xform link is missing |
| 21:42:04 | <dkayiwa> apb156: ok click design xform and tell me what happens |
| 21:42:12 | <dkayiwa> apb156: error again? |
| 21:42:17 | <apb156> dkayiwa: yah |
| 21:42:27 | <dkayiwa> apb156: which version of openmrs |
| 21:42:38 | <apb156> dkayiwa: 1.9.2 |
| 21:44:10 | <dkayiwa> apb156: create a new conv set concept |
| 21:44:59 | <dkayiwa> apb156: just like visit diagnoses but with no PROBLEM LIST member |
| 21:46:22 | <apb156> dkayiwa: k working obi t |
| 21:48:37 | <apb156> dkayiwa: k done, want me to create a new form? |
| 21:49:03 | <dkayiwa> apb156: yes and add it to the OBS section |
| 21:50:15 | <apb156> dkayiwa: What should the field type be for this again? Concept? |
| 21:50:43 | <dkayiwa> apb156: what did you choose for the other form? |
| 21:51:26 | <apb156> dkayiwa: on the first form we made it defaulted to "Set of Concepts" |
| 21:51:58 | <dkayiwa> apb156: did u ask field type for form schema screen? |
| 21:52:11 | <apb156> dkayiwa: yah that's what I'm referring to |
| 21:52:28 | <dkayiwa> dkayiwa: apb156: what did you choose for the other form? |
| 21:52:40 | <apb156> dkayiwa: I left it as "Set of Concepts" |
| 21:53:13 | <apb156> dkayiwa: but the one I just created defaulted to "Concept" |
| 21:53:32 | <dkayiwa> apb156: go to the old form |
| 21:53:45 | <apb156> dkayiwa: ypu |
| 21:53:48 | <dkayiwa> apb156: and change visit diagnoses field on form schema to concept |
| 21:53:50 | *** andreapat has quit IRC |
| 21:54:28 | <dkayiwa> apb156: after having set the field type to concept, then select the visit diagnoses concept |
| 21:55:17 | <apb156> dkayiwa: okay |
| 21:56:01 | <apb156> dkayiwa: what do I do after changing the "Visit Diagnoses" to a Concept Field Type? |
| 21:56:18 | <dkayiwa> apb156: click the delete xform link |
| 21:56:31 | <apb156> dkayiwa: Still not there |
| 21:56:49 | <dkayiwa> apb156: did you close the popup where you changed the field type? |
| 21:56:59 | <apb156> dkayiwa: yup |
| 21:57:09 | <dkayiwa> apb156: now click the design xform link |
| 21:57:13 | <apb156> dkayiwa: no error this time |
| 21:57:35 | <dkayiwa> apb156: yes the error was cause by field type not being concept |
| 21:57:49 | <dkayiwa> apb156: so now that form should have that field as repeating |
| 21:57:53 | <apb156> dkayiwa: there is a visit diagnoses section but it only has the three fields we left in there |
| 21:58:11 | <dkayiwa> apb156: yes thats what it should be |
| 21:58:36 | <apb156> dkayiwa: Should I go back and try re-adding the Visit Diagnoses section because remember we deleted the diagnosis field underneath it |
| 21:59:07 | <dkayiwa> apb156: why do you wanna do that? |
| 22:00:22 | <apb156> dkayiwa: http://snag.gy/rDEyw.jpg |
| 22:00:31 | <apb156> dkayiwa: its missing the actual diagnosis |
| 22:00:38 | <apb156> dkayiwa: cause we deleted it |
| 22:00:43 | <apb156> dkayiwa: from the schema |
| 22:01:29 | <dkayiwa> apb156: ok create a new concept of type text and add it to the set |
| 22:02:10 | <apb156> dkayiwa: what is wrong with leaving "Problem List" in there? |
| 22:02:52 | <dkayiwa> apb156: there is a bug where problem list does not show up. feel free to create a ticket for it |
| 22:03:27 | <apb156> dkayiwa: was this already known about? Is it specific to this version? |
| 22:03:48 | <dkayiwa> apb156: for all versions |
| 22:05:04 | <dkayiwa> apb156: alternatively, you do not need to create a new concept |
| 22:05:15 | <apb156> dkayiwa: okay |
| 22:05:16 | <dkayiwa> apb156: you can simply add PROBLEM ADDED concept to the set |
| 22:06:01 | <apb156> dkayiwa: add it to the Visit Diagnosis concept or just the set in the schema? |
| 22:06:16 | <dkayiwa> apb156: add to the visit diagnosis concept set |
| 22:06:35 | <dkayiwa> apb156: after which you will remove the field from the form schema, and then add it again |
| 22:06:58 | <apb156> dkayiwa: And if I get updates for MVP I'll have to make this change again right? |
| 22:07:10 | <dkayiwa> apb156: no |
| 22:07:21 | <dkayiwa> apb156: oh sorry yes for now |
| 22:07:29 | <dkayiwa> apb156: before bug is fixed |
| 22:07:54 | <apb156> dkayiwa: What are your thoughts on this bug getting fixed in the near future? |
| 22:08:18 | <dkayiwa> apb156: that starts with you creating a ticket for it :) |
| 22:08:30 | <apb156> dkayiwa: haha okay. I'll do that |
| 22:08:46 | <dkayiwa> apb156: actually even adding PROBLEM ADDED does not work |
| 22:09:13 | <dkayiwa> apb156: so for now you will add a concept of Text type for the visit diagnoses concept set |
| 22:09:25 | <apb156> dkayiwa: OKay |
| 22:16:35 | <apb156> dkayiwa: I'm filling out the form to start a new ticket, but I don't know much about the cause of the problem |
| 22:17:08 | <dkayiwa> apb156: just report the problem as you see it. but before that, lets first finish your form |
| 22:17:58 | <apb156> dkayiwa: okay thanks |
| 22:18:40 | <apb156> dkayiwa: I need to have multiple servers to be synced and identical in configuration |
| 22:19:00 | <apb156> dkayiwa: any suggestion as to the best way to make this change to the concept dictionary |
| 22:19:03 | <apb156> ? |
| 22:19:21 | <dkayiwa> apb156: before you think of that, does the form work? |
| 22:19:40 | <apb156> dkayiwa: I didn't edit the concept yet |
| 22:20:02 | <dkayiwa> apb156: oh i see. then in that case just create the ticket to fix the bug |
| 22:20:22 | <dkayiwa> apb156: that way no need to sync as you will just use the default concept set as it is |
| 22:20:41 | <apb156> dkayiwa: cool, thanks. That was what I was asking |
| 22:20:52 | <dkayiwa> apb156: i get you now :) |
| 22:22:43 | <apb156> dkayiwa: this is my first ticket, how is this for the summary: "Adding the MVP "Visit Diagnosis" concept set to an XForm doesn't show the diagnosis field." |
| 22:23:23 | <dkayiwa> apb156: does not show the problem list field |
| 22:23:47 | <apb156> dkayiwa: okay that's better |
| 22:24:01 | <apb156> dkayiwa: is that fairly self explanatory or do you want a description as well? |
| 22:24:27 | <dkayiwa> apb156: if you have anything more to add :) |
| 22:24:45 | <apb156> dkayiwa: okay i'll just add the concept ID |
| 22:26:01 | <apb156> dkayiwa: https://tickets.openmrs.org/browse/TRUNK-3873 |
| 22:26:06 | <dkayiwa> apb156: ok |
| 22:26:13 | <apb156> dkayiwa: Thanks for all your help Daniel |
| 22:26:30 | <dkayiwa> apb156: you are welcome. thanks for your patience too |
| 22:26:51 | <apb156> dkayiwa: no problem. |
| 22:27:44 | <apb156> dkayiwa: On a related note, how much effort do you think it would take for someone new to the code base to fix? |
| 22:28:06 | <dkayiwa> apb156: a full day |
| 22:28:15 | <apb156> dkayiwa: : / |
| 22:29:03 | <apb156> dkayiwa: and just to get the dev environment up and running? |
| 22:29:14 | <apb156> dkayiwa: how long does that usually take |
| 22:29:40 | <dkayiwa> apb156: depends on one's prior experience with the tools involved |
| 22:30:07 | <apb156> dkayiwa: I was a c# developer for a few years, but that's a totally different set of tools |
| 22:30:40 | <dkayiwa> apb156: yes |
| 22:30:58 | <apb156> dkayiwa: How reasonable do you think it is to have one or two people setting up openmrs and maintaining it? |
| 22:31:06 | *** andreapat has joined #openmrs |
| 22:31:53 | <dkayiwa> apb156: not sure |
| 22:32:16 | <dkayiwa> apb156: not sure of what you mean :) |
| 22:32:47 | <apb156> dkayiwa: Well I read the implementers' guide and it suggests a much larger and diverse team |
| 22:33:05 | <apb156> dkayiwa: I have run into what feels like a lot of problems just getting OpenMRS installed and running |
| 22:34:32 | <apb156> dkayiwa: I'm just wondering if it's realistic to have only one person in an organization to run OpenMRS |
| 22:35:17 | <dkayiwa> apb156: if using sync, it is more work |
| 22:36:52 | <apb156> dkayiwa: So basically we will always need technical staff working to keep the servers synched. Is that the case with any other open source products out there? |
| 22:37:57 | <dkayiwa> apb156: looks like the implementers list may be better in answering this from their real experiences (am more of a developer) :) |
| 22:39:35 | <apb156> dkayiwa: yah, sorry to continue to bother you |
| 22:39:42 | <apb156> dkayiwa: Thanks again for all your help |
| 22:39:56 | <dkayiwa> apb156: :D |
| 22:41:22 | *** apb156 has quit IRC |
| 22:52:10 | *** mseaton has quit IRC |
| 22:56:24 | *** dkayiwa has quit IRC |
| 23:20:18 | *** rafa has joined #openmrs |
| 23:20:18 | *** ChanServ sets mode: +v rafa |
| 23:21:20 | *** rafa has quit IRC |
