| 00:15:59 | *** k-joseph has quit IRC |
| 00:18:39 | *** k-joseph has joined #openmrs |
| 00:25:34 | *** k-joseph has quit IRC |
| 04:24:44 | *** djazayeri has quit IRC |
| 04:34:59 | *** kishoreyekkanti has joined #openmrs |
| 05:46:53 | *** kishoreyekkanti has quit IRC |
| 05:49:16 | *** thariyarox has joined #openmrs |
| 05:49:31 | *** kishoreyekkanti has joined #openmrs |
| 05:50:11 | <thariyarox> hi |
| 05:51:54 | *** thariyarox has quit IRC |
| 06:44:08 | *** kishoreyekkanti has quit IRC |
| 06:47:51 | *** cpower has quit IRC |
| 07:54:18 | *** k-joseph has joined #openmrs |
| 08:00:03 | *** dkayiwa has joined #openmrs |
| 08:09:40 | *** dkayiwa_ has joined #openmrs |
| 08:10:12 | *** dkayiwa has quit IRC |
| 08:10:12 | *** dkayiwa_ is now known as dkayiwa |
| 08:16:22 | *** robbyoconnor has quit IRC |
| 08:56:39 | *** kishoreyekkanti has joined #openmrs |
| 08:59:26 | *** k-joseph has quit IRC |
| 10:18:08 | *** rafa has joined #openmrs |
| 10:18:08 | *** ChanServ sets mode: +v rafa |
| 10:23:22 | *** rafa has quit IRC |
| 11:47:33 | *** rafa has joined #openmrs |
| 11:47:33 | *** ChanServ sets mode: +v rafa |
| 12:19:48 | *** mseaton has joined #openmrs |
| 12:19:48 | *** ChanServ sets mode: +v mseaton |
| 12:22:11 | *** k-joseph has joined #openmrs |
| 12:22:32 | <k-joseph> dkayiwa: hi |
| 12:22:37 | <dkayiwa> k-joseph: hi |
| 12:26:48 | <k-joseph> dkayiwa: i am hhumbly requesting for your further guidance on the previous isssue, |
| 12:27:08 | <dkayiwa> k-joseph: you never responded to where we stopped |
| 12:28:15 | <k-joseph> dkayiwa: i was trying to establish the problem, which i did not fully understand |
| 12:32:35 | <dkayiwa> k-joseph: can you follow yesterday's IRC chat and you start from where i left waiting for your response? |
| 12:39:41 | *** yony258 has joined #openmrs |
| 12:39:48 | <k-joseph> dkayiwa: didn't we stop when i set require_version to "1.9.2" - "1.10.0-SNAPSHOT" , i did this, testes and the module was running |
| 12:40:11 | <dkayiwa> k-joseph: can you pastebin the changes? |
| 12:42:56 | <k-joseph> dkayiwa: i have pasted at http://pastebin.com/bU7ARWBB |
| 12:43:37 | <dkayiwa> k-joseph: can you again look at the example link i gave you? |
| 12:56:06 | *** mseaton has quit IRC |
| 12:56:23 | <dkayiwa> k-joseph: are you there? |
| 12:56:58 | <k-joseph> dkayiwa: looked at it again, but am not fully understanding how 1.7.2.17710-1.8.* is to be related to what you are meaning/ Between "1.9.2" and "SNAPSHOT" |
| 12:57:29 | <dkayiwa> k-joseph: dont you see a different between that one and yours? |
| 12:57:57 | <dkayiwa> k-joseph: can you please respond instead of simply keeping quiet??? |
| 12:58:35 | <k-joseph> dkayiwa: i see the difference |
| 12:58:49 | <dkayiwa> k-joseph: so can you now correct it? |
| 13:02:33 | *** yony258 has quit IRC |
| 13:03:54 | <k-joseph> dkayiwa: is it something like, 1.9.2 .1.10.0-SNAPSHOT* i really need some further clarification as far as this is concerned, |
| 13:04:20 | <dkayiwa> k-joseph: what did you change? |
| 13:04:46 | *** kishoreyekkanti_ has joined #openmrs |
| 13:05:09 | <k-joseph> dkayiwa: i changed <require_version>"1.9.2" - "1.10.0-SNAPSHOT"</require_version> |
| 13:05:40 | <dkayiwa> k-joseph: am not asking for the original value you had |
| 13:05:49 | <dkayiwa> k-joseph: am simply asking what did you change about it? |
| 13:06:13 | <k-joseph> dkayiwa: require_version |
| 13:06:43 | <dkayiwa> k-joseph: did you understand my question? |
| 13:07:38 | <k-joseph> dkayiwa: i think i didn't, please cme again in further simplificaction |
| 13:07:58 | <dkayiwa> k-joseph: what did you change to come up with the new value? |
| 13:08:16 | *** kishoreyekkanti has quit IRC |
| 13:08:16 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 13:08:59 | <k-joseph> dkayiwa: which new value, sorry to ask also |
| 13:09:32 | <dkayiwa> k-joseph: the one you are showing me here on IRC |
| 13:09:46 | <dkayiwa> k-joseph: it is different from the one you have pastebined |
| 13:12:02 | <k-joseph> dkayiwa: i changed "1.9.2" - "1.10.0-SNAPSHOT" to 1.9.2 .1.10.0-SNAPSHOT* under <require_version/> |
| 13:12:31 | <dkayiwa> k-joseph: so what change did you make? |
| 13:12:43 | *** Rowan has joined #openmrs |
| 13:12:50 | <dkayiwa> k-joseph: in otherwards whats the difference between those two? |
| 13:13:06 | *** Rowan is now known as Guest84800 |
| 13:15:33 | <k-joseph> dkayiwa: that's where i am not understanding, i think "1.9.2" - "1.10.0-SNAPSHOT" is the openmrs interpretation of 1.9.2 .1.10.0-SNAPSHOT* am just not sure |
| 13:16:49 | <dkayiwa> k-joseph: did you see my other messages? |
| 13:17:22 | <k-joseph> dkayiwa: which ones, |
| 13:18:54 | *** k-joseph_ has joined #openmrs |
| 13:20:20 | *** Guest84800 has quit IRC |
| 13:23:48 | *** k-joseph has quit IRC |
| 13:27:34 | *** wyclif has quit IRC |
| 13:28:08 | *** k-joseph_ is now known as k-joseph |
| 13:55:15 | *** yony258 has joined #openmrs |
| 13:55:50 | <yony258> dkayiwa: Hi :) |
| 13:56:16 | <dkayiwa> yony258: hi :) |
| 13:56:51 | <yony258> dkayiwa: Dont want to interrupt, I just have a question so let me know when is ok to ask. |
| 13:57:07 | <dkayiwa> yony258: you can ask now |
| 13:57:26 | <yony258> dkayiwa: so I sent an email to the devlist if you prefer to read it there |
| 13:57:41 | <yony258> dkayiwa: called "AJAX / JSON and Spring MVC" |
| 13:58:14 | <yony258> dkayiwa: The idea is that I want to use AJAX or JSON in order to update a model attribute (which means I can't use DWR ) |
| 13:58:37 | <dkayiwa> yony258: i saw it |
| 13:58:42 | <yony258> dkayiwa: The goal is to get the appointment list on Manage appointments form to update every x seconds without posting the whole page. |
| 13:59:01 | <yony258> dkayiwa: Any ideas how to do that? Maybe a controller that did something like this? |
| 13:59:41 | <yony258> dkayiwa: Im sorry that im asking all of those questions I just dont have a good understanding of Sprint MVC, just the basic stuff I already did. |
| 13:59:52 | <yony258> *Spring MVC |
| 14:00:45 | <dkayiwa> yony258: why do you want it update every x seconds? |
| 14:01:35 | <yony258> dkayiwa: For example a clinician can have the Manage appointments form open while others may updated this form |
| 14:02:13 | <yony258> dkayiwa: Sorry: *while others may added new appointments |
| 14:02:15 | <dkayiwa> yony258: ok |
| 14:02:32 | <yony258> dkayiwa: So I want it to stay updated |
| 14:03:06 | <yony258> dkayiwa: Also I want to use the "change appointment status" buttons with AJAX. |
| 14:03:33 | <yony258> dkayiwa: The problem with DWR that it can't update the Model attributes in contrast to the controller |
| 14:08:52 | <dkayiwa> yony258: can you use something like a javascript timer? |
| 14:09:26 | <yony258> dkayiwa: I have no problem executing a function every x seconds |
| 14:09:35 | <dkayiwa> yony258: ok |
| 14:09:42 | <yony258> dkayiwa: The problem is doing the AJAX / JSON to update a model attribute |
| 14:09:43 | <dkayiwa> yony258: and then you make a DWR call |
| 14:09:55 | <yony258> dkayiwa: how can I make a DWR call to the Controller? |
| 14:10:47 | <dkayiwa> yony258: not do the controller |
| 14:10:58 | <dkayiwa> not to the controlelr |
| 14:10:59 | <yony258> dkayiwa: So how can I update that model attribute? |
| 14:11:23 | <k-joseph> dkayiwa: http://pastebin.com/cf0sRzkC |
| 14:11:37 | <dkayiwa> yony258: i thought you would manipulate form display data via javascript |
| 14:12:15 | <dkayiwa> k-joseph: remove the empty space at the begining of the version |
| 14:12:29 | <dkayiwa> k-joseph: then compile, install and tell me what happens |
| 14:13:24 | <dkayiwa> yony258: for instance DWR call can return JSON which you use for the JQuery datatable |
| 14:15:02 | *** jkeiper has joined #openmrs |
| 14:15:02 | *** ChanServ sets mode: +v jkeiper |
| 14:15:36 | <yony258> dkayiwa: I have a model attribute "appointmentList" - a list of appointments that fits the filters in the form. I need to recompute that list and re render the table every x seconds. |
| 14:16:19 | <dkayiwa> yony258: can you do it in an iframe? |
| 14:16:30 | <dkayiwa> yony258: where the iframe refreshes |
| 14:17:07 | <dkayiwa> yony258: that way the iframe can be backed up by a controller |
| 14:17:32 | <yony258> dkayiwa: How can I pass the filters values to that iframe? |
| 14:17:33 | <yony258> dkayiwa: How can I pass the filters values to that iframe? |
| 14:17:38 | <yony258> dkayiwa: sorry for double posting |
| 14:18:35 | <dkayiwa> yony258: which jsp is that? |
| 14:20:28 | <yony258> dkayiwa: The filters in the appointment manage form |
| 14:20:43 | <dkayiwa> yony258: what jsp name? |
| 14:20:47 | <yony258> dkayiwa: http://i.snag.gy/gWllb.jpg ("Filtering Options") |
| 14:20:55 | <yony258> dkayiwa: appointmentList.jsp |
| 14:23:32 | *** wyclif has joined #openmrs |
| 14:24:00 | <dkayiwa> yony258: do you see the find patient page? |
| 14:24:13 | <dkayiwa> yony258: and how it refreshes when you type? |
| 14:24:18 | <yony258> dkayiwa: yea |
| 14:24:27 | <dkayiwa> yony258: was thinking of using the same model |
| 14:24:45 | <yony258> dkayiwa: hmm |
| 14:25:39 | <yony258> dkayiwa: Let me go through the code |
| 14:25:46 | <dkayiwa> yony258: ok |
| 14:26:10 | *** jkeiper has quit IRC |
| 14:26:56 | <yony258> dkayiwa: Ok ill get back to you on that, Thank you! |
| 14:27:04 | <dkayiwa> yony258: ok |
| 14:27:22 | <k-joseph> it has installed well and works just fine |
| 14:27:42 | <k-joseph> dkayiwa: it has installed well and works just fine |
| 14:28:40 | <dkayiwa> k-joseph: can you now change the required version to 1.9.2-SNAPSHOT |
| 14:28:48 | <dkayiwa> k-joseph: then compile and test |
| 14:32:11 | <k-joseph> dkayiwa: still fine |
| 14:32:29 | <dkayiwa> k-joseph: and which openmrs version are you running? |
| 14:34:51 | <k-joseph> dkayiwa: not sure, OpenMRS Version is "" |
| 14:35:00 | <dkayiwa> k-joseph: ok |
| 14:35:24 | <dkayiwa> k-joseph: do you know how to start writing a unit test for that ticket? |
| 14:35:44 | <k-joseph> dkayiwa: not sure |
| 14:36:03 | <dkayiwa> k-joseph: ok. do you know in which class to put the unit test? |
| 14:36:56 | <k-joseph> dkayiwa: in ModuleUtilTest.java |
| 14:37:02 | <dkayiwa> k-joseph: perfect |
| 14:37:36 | <dkayiwa> k-joseph: can you look through the unit test methods in that class that have this call? ModuleUtil.checkRequiredVersion( |
| 14:37:57 | <dkayiwa> k-joseph: and tell me if it helps you in any way on how to start writing a unit test for that ticket |
| 14:38:30 | *** jkeiper has joined #openmrs |
| 14:38:30 | *** ChanServ sets mode: +v jkeiper |
| 14:39:07 | *** downey has joined #openmrs |
| 14:39:07 | *** ChanServ sets mode: +o downey |
| 14:39:07 | *** OpenMRSBot sets mode: +o downey |
| 14:40:55 | *** kishoreyekkanti has quit IRC |
| 14:47:57 | *** yony258 has quit IRC |
| 14:54:24 | <k-joseph> dkayiwa: it does help me, but i have not established what am testing in this case for this ticket, is it Saying that a module requires OpenMRS 1.9.2-SNAPSHOT fails, how? |
| 14:54:42 | *** mseaton has joined #openmrs |
| 14:54:42 | *** ChanServ sets mode: +v mseaton |
| 14:55:14 | *** hybridivy has joined #openmrs |
| 14:55:33 | <dkayiwa> k-joseph: can you create a unit test where both the openmrsVersion and requireVersion are equal to 1.9.2-SNAPSHOT ? |
| 14:55:54 | <dkayiwa> k-joseph: then tell me if it passes |
| 14:57:33 | *** mseaton1 has joined #openmrs |
| 15:01:54 | *** mseaton has quit IRC |
| 15:05:17 | *** wyclif has quit IRC |
| 15:06:18 | *** djazayeri has joined #openmrs |
| 15:06:18 | *** ChanServ sets mode: +o djazayeri |
| 15:20:07 | *** wyclif has joined #openmrs |
| 15:21:35 | *** lh has quit IRC |
| 15:24:12 | <k-joseph> dkayiwa: did you mean something like http://pastebin.com/2qBPMwrh (concider from line 363 to 372) |
| 15:24:41 | <dkayiwa> k-joseph: checking |
| 15:25:08 | <k-joseph> dkayiwa: i tested before i made that change, and junit test was failing, even now it does fail |
| 15:26:17 | <dkayiwa> k-joseph: do you know what this means? @Test(expected = ModuleException.class) |
| 15:27:43 | <k-joseph> dkayiwa: i think it shows that we are testing something, |
| 15:28:45 | <dkayiwa> k-joseph: can you google for it and tell me if you get an understanding of it from the search results? |
| 15:36:02 | <dkayiwa> k-joseph: hi |
| 15:36:08 | *** jkeiper_ has joined #openmrs |
| 15:36:09 | <k-joseph> dkayiwa: hi |
| 15:36:20 | <dkayiwa> k-joseph: can you download and read this? http://www.tutorialspoint.com/junit/junit_tutorial.pdf |
| 15:36:23 | <OpenMRSBot> <http://ln-s.net/+R$6> (at www.tutorialspoint.com) |
| 15:36:28 | *** jkeiper has quit IRC |
| 15:39:14 | *** kishoreyekkanti has joined #openmrs |
| 15:39:34 | *** k-joseph_ has joined #openmrs |
| 15:40:50 | *** k-joseph has quit IRC |
| 15:43:24 | *** rafa has quit IRC |
| 15:43:34 | <dkayiwa> k-joseph_: downloaded it? |
| 15:43:52 | <k-joseph_> dkayiwa: yes |
| 15:43:59 | *** lh has joined #openmrs |
| 15:44:04 | <dkayiwa> k-joseph_: tell me after you have read it. ok? |
| 15:44:14 | *** k-joseph_ is now known as k-joseph |
| 15:44:32 | <k-joseph> dkayiwa: all of it |
| 15:44:36 | <k-joseph> dkayiwa? |
| 15:44:37 | <dkayiwa> k-joseph: yes |
| 15:44:42 | <k-joseph> dkayiwa: ok |
| 15:45:43 | *** lhawthor_ has joined #openmrs |
| 15:46:34 | *** lh has quit IRC |
| 15:46:47 | *** lhawthor_ is now known as lh |
| 15:47:08 | *** lh has quit IRC |
| 15:47:08 | *** lh has joined #openmrs |
| 15:51:17 | *** hybridivy has quit IRC |
| 15:52:32 | * downey waves at lh |
| 15:56:00 | *** kishoreyekkanti has quit IRC |
| 16:01:50 | *** lh has quit IRC |
| 16:02:27 | *** lh has joined #openmrs |
| 16:03:21 | *** mseaton1 has quit IRC |
| 16:04:34 | *** wyclif has quit IRC |
| 16:07:21 | <dkayiwa> hi djazayeri |
| 16:08:01 | <dkayiwa> djazayeri: in the html widgets module, do you know how i can make this <wgt:widget translate to a TextArea instead of Input |
| 16:08:02 | <dkayiwa> ? |
| 16:08:20 | <djazayeri> dkayiwa: I know nothing about that module. |
| 16:08:31 | <dkayiwa> djazayeri: :) |
| 16:11:38 | *** applecool has joined #openmrs |
| 16:11:38 | *** ChanServ sets mode: +v applecool |
| 16:13:36 | *** wyclif has joined #openmrs |
| 16:15:44 | *** jkeiper_ has quit IRC |
| 16:19:31 | *** mseaton has joined #openmrs |
| 16:19:31 | *** ChanServ sets mode: +v mseaton |
| 16:27:05 | *** k-joseph has quit IRC |
| 16:27:10 | *** k-joseph_ has joined #openmrs |
| 16:30:00 | *** wyclif has quit IRC |
| 16:30:19 | *** downey has quit IRC |
| 16:31:40 | *** k-joseph_ is now known as k-joseph |
| 16:43:19 | *** wyclif has joined #openmrs |
| 17:01:18 | *** lh has quit IRC |
| 17:02:55 | *** lh has joined #openmrs |
| 17:16:08 | <dkayiwa> hi mseaton |
| 17:18:11 | <mseaton> hi dkayiwa |
| 17:18:27 | <dkayiwa> mseaton: do you know how i can make this <wgt:widget translate to a TextArea instead of Input |
| 17:18:49 | <dkayiwa> mseaton: is there any sort of thing like parameter? |
| 17:18:59 | <dkayiwa> mseaton: to have it do so |
| 17:19:34 | <mseaton> yes, i believe so, let me check... |
| 17:19:45 | <dkayiwa> mseaton: that will be excellent |
| 17:21:04 | <mseaton> dkayiwa: the widget tag has an "attributes" attribute, in which you can specify a pipe-separated list of key=value pairs |
| 17:21:18 | <mseaton> in this case you want something like: |
| 17:21:42 | <mseaton> attributes="rows=5|cols=100". try something like that. |
| 17:21:53 | <dkayiwa> mseaton: ok thanks |
| 17:22:21 | <mseaton> you can also use the attribute: format="textarea" |
| 17:22:38 | <dkayiwa> mseaton: ok |
| 17:22:45 | <mseaton> dkayiwa: ^^, and this will use default rows and cols, which you can override as above |
| 17:22:55 | <dkayiwa> mseaton: ok |
| 17:39:14 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting 0.7.4.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=reporting&version=&0.7.4.1> |
| 17:45:07 | <dkayiwa> mseaton: thanks it has worked perfectly :) |
| 17:52:35 | *** lh has quit IRC |
| 17:57:53 | *** jkeiper_ has joined #openmrs |
| 17:59:18 | *** k-joseph_ has joined #openmrs |
| 18:00:46 | *** k-joseph has quit IRC |
| 18:01:07 | *** k-joseph_ is now known as k-joseph |
| 18:01:59 | *** Mkop has quit IRC |
| 18:01:59 | *** Meths has quit IRC |
| 18:02:18 | *** Mkop has joined #openmrs |
| 18:02:18 | *** ChanServ sets mode: +v Mkop |
| 18:09:10 | *** lh has joined #openmrs |
| 18:09:10 | *** lh has joined #openmrs |
| 18:10:43 | *** kishoreyekkanti has joined #openmrs |
| 18:21:51 | *** suranga has joined #openmrs |
| 18:21:51 | *** ChanServ sets mode: +v suranga |
| 18:25:13 | *** k-joseph has quit IRC |
| 18:44:11 | *** k-joseph has joined #openmrs |
| 18:46:20 | *** kishoreyekkanti has quit IRC |
| 19:02:16 | *** rafa has joined #openmrs |
| 19:02:16 | *** ChanServ sets mode: +v rafa |
| 19:02:17 | *** applecool has left #openmrs |
| 19:10:59 | *** dkayiwa has quit IRC |
| 19:14:14 | *** dkayiwa has joined #openmrs |
| 19:19:01 | *** yony258 has joined #openmrs |
| 19:26:56 | <yony258> dkayiwa: Hi :) |
| 19:27:05 | <dkayiwa> yony258: hey :) |
| 19:27:21 | <yony258> dkayiwa: I did an AJAX call and the controller got it with the correct values :) |
| 19:27:36 | <dkayiwa> yony258: excellent!!! :) |
| 19:28:02 | <yony258> dkayiwa: Now I need to find a way to reload the data into the Datatables.net table |
| 19:28:15 | <yony258> dkayiwa: Anyway to rerender a jsp or any other idea how to do that? |
| 19:29:17 | <yony258> dkayiwa: I have a "List<Appointment>" that I need to iterate through |
| 19:32:28 | <yony258> dkayiwa: I dont have any idea how to update the jquery datatable using the List<Appointment> model attribute |
| 19:34:04 | <dkayiwa> yony258: i thought you send json to jsp |
| 19:34:28 | <yony258> dkayiwa: Hmm no I actually did AJAX but Im sure I can do that with JSOn |
| 19:36:27 | <yony258> dkayiwa: Is there a way to "Re-run" that code in the JSP after the AJAX/JSON call? |
| 19:36:55 | <yony258> dkayiwa: I mean the code here: http://pastebin.com/SR2hFwVH |
| 19:40:41 | *** k-joseph has quit IRC |
| 19:43:14 | <wyclif> hi mseaton , djazayeri |
| 19:43:27 | <mseaton> hi wyclif |
| 19:43:55 | <wyclif> mseaton, djazayeri am running into an issue with exposing PersonDataDefinition as a calculation |
| 19:45:49 | <mseaton> wyclif: what's up? |
| 19:46:00 | *** jkeiper_ has quit IRC |
| 19:46:03 | <wyclif> mseaton, Person is not a Patient, and am trying to differ a little from the code you attached to the ticket, i don't want to treat person as patient, so i don't want to use the same methods for patient when evaluating person, more so i dont want to use a PatientCalculationContext for person calculations |
| 19:46:29 | <wyclif> mseaton, does this sound right to you? |
| 19:47:20 | <wyclif> calculation module currently provides no default ways for evaluating none Patient centric calculations |
| 19:47:21 | <mseaton> wyclif: the point is that we can always assume that the end user wants patients back |
| 19:47:38 | <mseaton> and we know that anything you can do on person, you can also do on patient |
| 19:48:24 | <mseaton> you can assume that the persondatadefinition evaluators know how to handle a Cohort (eg. list of patients) and to return the patients that match the person data definition configuration |
| 19:49:54 | <wyclif> mseaton, so why in the first place did reporting have to separate the two if they are the same, i believe there are definitions that are specific to patients |
| 19:52:01 | <mseaton> wyclif: the point is that you may want to find all persons in your system that match certain criteria, and get data about them. eg. a list of all persons who are males who are not necessarily patients |
| 19:52:02 | <wyclif> mseaton, okat then i will do it the way you did it |
| 19:52:45 | *** Meths has joined #openmrs |
| 19:52:47 | <mseaton> wyclif: so it's helpful to have person data and person queries that do not restrict to only patients. but also to be able, when dealing with patients, to re-use these same definitions, since it is the same calculation |
| 19:54:20 | <yony258> dkayiwa: I think that its better that we will pass this feature and just make the user refresh manually |
| 19:54:44 | <dkayiwa> yony258: thats ok for the early versions of the module |
| 19:55:56 | <yony258> dkayiwa: Yea, well I'll get back to the same 2 bugs Im having for the last week |
| 19:56:16 | *** dkayiwa has quit IRC |
| 19:56:20 | <yony258> dkayiwa: Difficult bugs :P |
| 19:56:29 | <yony258> dkayiwa: Thank you anyway! |
| 19:59:01 | *** dkayiwa has joined #openmrs |
| 20:01:45 | *** andrea has joined #openmrs |
| 20:02:09 | *** andrea is now known as Guest19979 |
| 20:02:20 | <djazayeri> Is it scrum time? |
| 20:02:34 | <djazayeri> I think it is. |
| 20:02:47 | <rafa> djazayeri: yes |
| 20:03:05 | <djazayeri> since I don't see cpower around... |
| 20:03:10 | <djazayeri> !scrumon rafa |
| 20:03:10 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster rafa- you may begin when ready. |
| 20:03:40 | <rafa> ;) order: djazayeri, wyclif, dkayiwa, rafa, mseaton and any others |
| 20:03:54 | <djazayeri> Recently: |
| 20:03:57 | <djazayeri> * lots of calls |
| 20:04:01 | *** Guest19979 is now known as andreap_ |
| 20:04:09 | <djazayeri> * some UI Framework tickets around localization (for Mirebalais) |
| 20:04:18 | <djazayeri> * some Mirebalais work around question-per-screen UIs |
| 20:04:20 | <djazayeri> * even more calls |
| 20:04:22 | <djazayeri> no blockers |
| 20:04:53 | <wyclif> Wednesday: |
| 20:04:53 | <wyclif> RG Work in progress session |
| 20:04:53 | <wyclif> design call |
| 20:04:53 | <wyclif> REPORT-461 - Expose reporting module Person and Patient Data Definitions as Calculations |
| 20:04:53 | <wyclif> Prepare summary about changes in order entry in trunk vs 1.9 |
| 20:04:54 | <wyclif> |
| 20:04:56 | <wyclif> Thursday: |
| 20:04:58 | <wyclif> dev call |
| 20:05:00 | <wyclif> Continue with work on REPORT-461 - Expose reporting module Person and Patient Data Definitions as Calculations |
| 20:05:05 | <wyclif> |
| 20:05:07 | <wyclif> Blockers: None |
| 20:05:13 | <dkayiwa> About to do an initial commit for: Add ScriptedCohortDefinition - REPORT-93 |
| 20:05:13 | <dkayiwa> Dev Call |
| 20:05:14 | <dkayiwa> Then will do the remaining work for: Add ScriptedCohortDefinition - REPORT-93 |
| 20:05:14 | <dkayiwa> No Blockers |
| 20:05:17 | <rafa> sorry I missed andreap_, you are after mseaton |
| 20:05:26 | <rafa> Today: |
| 20:05:26 | <rafa> * Investigated on REPORT-468: Adding Indicator to Cohort Indicator and Dimension Data Set fails |
| 20:05:26 | <rafa> https://tickets.openmrs.org/browse/REPORT-468 |
| 20:05:26 | <rafa> * Started with REPORT-464: Support Metadata Sharing of all Reporting Module metadata |
| 20:05:26 | <rafa> https://tickets.openmrs.org/browse/REPORT-464 |
| 20:05:26 | <rafa> (my current approach is to provide a general support for the serialized_object table as Mike suggested) |
| 20:05:27 | <rafa> No blockers. |
| 20:05:34 | <andreap_> rafa, ok |
| 20:06:08 | <rafa> mseaton: anything to share? |
| 20:06:37 | <rafa> andreap_: you're up then :) |
| 20:06:55 | <andreap_> rafa, ok having big Eclipse problem |
| 20:07:07 | <andreap_> Thursday (morning) |
| 20:07:08 | <andreap_> Dev call |
| 20:07:08 | <andreap_> Trying to fix Eclipse problem |
| 20:07:08 | <andreap_> Blocker |
| 20:07:08 | <andreap_> Eclipse Problem |
| 20:07:09 | <andreap_> Was looking at openmrs-module-reprtoing project directory |
| 20:07:11 | <andreap_> Navigator disapeared - |
| 20:07:12 | <andreap_> Window - show view - navigator does nothing |
| 20:07:14 | <andreap_> Cannot see my projects in Eclipse |
| 20:07:16 | <andreap_> They are in workspace |
| 20:07:18 | <andreap_> Have restarted Eclipse/computer several times - still can't see Navigator |
| 20:07:21 | <andreap_> Has anyone seen this problem? |
| 20:07:25 | <rafa> andreap_: try package explorer instead ;) |
| 20:07:39 | <rafa> andreap_: it's nicer than navigator anyway |
| 20:08:16 | <andreap_> rafa, you mean project explorer? That doesn't come up either |
| 20:08:24 | <rafa> no discussion points and the only blocker is Eclipse and missing Navigator |
| 20:08:31 | <rafa> !scrumoff |
| 20:08:31 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:08:45 | <rafa> andreap_: you should also have the package explorer view |
| 20:09:06 | <rafa> andreap_: when you click other... |
| 20:09:31 | <andreap_> rafa, no package explorer in show view menu |
| 20:09:53 | <rafa> andreap_: there's Other... in show view |
| 20:10:21 | <rafa> andreap_: anyway probably you have it minimized somewhere or some view is maximized |
| 20:10:23 | <djazayeri> andreap_: what "perspective" are you in in eclipse? |
| 20:10:32 | <rafa> andreap_: send me a screenshot |
| 20:10:36 | <andreap_> rafa, Java EE |
| 20:10:45 | <andreap_> rafa, ok |
| 20:12:18 | <mseaton> rafa: and all, sorry i didn't see this start :( |
| 20:12:36 | <rafa> mseaton: no worries |
| 20:12:49 | *** k-joseph has joined #openmrs |
| 20:13:05 | <rafa> mseaton: I'll ping your skype next time |
| 20:13:48 | <mseaton> thanks |
| 20:14:41 | <andreap_> rafa, 1st screen shot on it's way. |
| 20:14:58 | <andreap_> rafa, will expand Other and send a 2nd one |
| 20:15:37 | <rafa> andreap_: did you e-mail me? |
| 20:15:43 | <andreap_> mseaton, whad some questions for you - till I got hung up with this eclipse problem - will email you |
| 20:15:51 | <rafa> andreap_: I don't see it yet |
| 20:16:29 | <andreap_> rafa, yes sent it |
| 20:17:03 | <rafa> andreap_: 8MBs screenshot? wow |
| 20:18:26 | <rafa> andreap_: looks strange. I think your workspace got corrupted |
| 20:18:39 | <rafa> andreap_: do you have a backup? |
| 20:19:19 | <andreap_> rafa, my workspace looks fine in Explorer |
| 20:19:47 | <andreap_> rafa, how would workspace get corrupted? |
| 20:20:15 | *** cpower has joined #openmrs |
| 20:20:23 | <rafa> andreap_: e.g. improperly closed Eclipse, IO failure, etc. |
| 20:20:29 | <cpower> My apologies, did you guys scrum without me? |
| 20:20:36 | <rafa> cpower: yes, we did |
| 20:20:44 | <cpower> good deal |
| 20:20:48 | <rafa> andreap_: you should always backup workspace/.metadata |
| 20:20:53 | <cpower> sorry for missing it |
| 20:21:15 | <rafa> andreap_: if you don't have a backup I think you will have to delete .metadata |
| 20:21:22 | <rafa> andreap_: Eclipse will recreate it |
| 20:21:33 | <rafa> andreap_: but you will have to import projects into Eclipse again |
| 20:22:25 | <rafa> andreap_: just in case backup .metadata before deleting |
| 20:23:31 | <andreap_> rafa, doing that now |
| 20:23:59 | <andreap_> rafa, when will it get recreated? When I restrat Eclipse? |
| 20:24:18 | <rafa> andreap_: yes, stop Eclipse, delete .metadata and start Eclipse again |
| 20:25:34 | <andreap_> rafa, ok - think I should back up workspace too |
| 20:26:15 | <rafa> andreap_: never too many backups ;) |
| 20:27:20 | <andreap_> rafa, I agree - I do have an old backup of workspace on a flash drive - now will backup every night |
| 20:27:52 | <andreap_> rafa, thanks will let you know how it goes |
| 20:29:27 | <rafa> andreap_: np, I'm signing off from here so e-mail me in case of problems |
| 20:29:53 | <andreap_> rafa, will do - appreciate your help!!! |
| 20:33:10 | <dkayiwa> hi rafa |
| 20:34:09 | *** k-joseph has quit IRC |
| 20:34:28 | *** rafa has quit IRC |
| 20:58:27 | *** yony258 has quit IRC |
| 21:08:17 | *** suranga has quit IRC |
| 21:42:53 | *** downey has joined #openmrs |
| 21:42:53 | *** ChanServ sets mode: +o downey |
| 21:42:53 | *** OpenMRSBot sets mode: +o downey |
| 21:53:36 | *** upul has joined #openmrs |
| 21:53:36 | *** ChanServ sets mode: +v upul |
| 22:07:55 | <wyclif> hi mseaton |
| 22:07:58 | <wyclif> hi djazayeri |
| 22:08:05 | <djazayeri> hi wyclif |
| 22:08:26 | <wyclif> djazayeri, how do is configurationproperty used in a data definition |
| 22:08:46 | <wyclif> djazayeri, do i add it as parameter or i call the setter? |
| 22:08:51 | <djazayeri> wyclif: I don't understand the question |
| 22:09:30 | <wyclif> a data definition in reporting can have a ConfigurationProperty annotation on a property |
| 22:09:51 | <wyclif> djazayeri, and am wondering if i have to set this via the setter or by calling addParameter |
| 22:10:03 | <wyclif> djazayeri, on the definition itself |
| 22:10:24 | <djazayeri> wyclif: the idea behind that annotation is that it indicates which properties should be exposed as parameters in the UI. |
| 22:10:50 | <djazayeri> wyclif: so, if you were instantiating and calling the data definition directly in code, you can just call the setter, I think. |
| 22:11:45 | <wyclif> djazayeri, ok, so have a look at PatientDataCalculationProvider on this ticket https://tickets.openmrs.org/browse/REPORT-461 |
| 22:12:04 | <djazayeri> wyclif: you mean the attached java file? |
| 22:12:34 | <wyclif> djazayeri, yes, it means that logic about configuration properties in getCalculation is unnecessary |
| 22:13:21 | <wyclif> djazayeri, or i think we need to pass in the params via that methpd to be set by the provider |
| 22:13:32 | <djazayeri> wyclif: perhaps unnecessary, but if you weren't using it you'd have to use reflection, right? |
| 22:15:40 | <wyclif> djazayeri, probably the idea it to expose them on the calculation |
| 22:17:08 | <djazayeri> wyclif: taking a step back, my point is that if you're writing non-frameworky code, but using the API directly, you might say: |
| 22:17:31 | <djazayeri> dd = new AgeDataDefinition(); dd.setEffectiveDate(some date); ... |
| 22:17:59 | <djazayeri> wyclif: however in frameworky code, you'll probably end up doing what Mike did in that code snippet. |
| 22:19:31 | <wyclif> djazayeri, i was doing that and i noticed that they are null by the time of evaluation |
| 22:19:54 | <wyclif> djazayeri, when i remove that code, then everything works |
| 22:20:47 | <djazayeri> wyclif: I'd suggest waiting for mseaton to be able to answer this |
| 22:21:01 | <djazayeri> wyclif: there's a PIH all-staff meeting going on now (I'm listening by phone) so I assume he's away from his desk. |
| 22:21:18 | <wyclif> djazayeri, ok thanks |
| 22:25:16 | *** downey has quit IRC |
| 22:45:52 | *** andreap_ has quit IRC |
| 22:48:43 | *** wyclif has quit IRC |
| 22:54:42 | *** dkayiwa has quit IRC |
| 23:01:18 | <mseaton> djazayeri: did you and wyclif work out the above point? |
| 23:01:28 | <djazayeri> mseaton: no, I said to wait for you. |
| 23:01:28 | <mseaton> i'm not sure i understand the problem |
| 23:01:42 | <mseaton> djazayeri: did you look at the code in question? |
| 23:01:51 | <djazayeri> mseaton: wyclif seemed to be saying that the code in question wasn't working. though I don't know why. |
| 23:02:12 | <djazayeri> mseaton: I assumed he'd comment on the ticket, or email, or something... |
| 23:03:02 | <mseaton> djazayeri: nothing in the ticket or in my email... |
| 23:03:45 | <djazayeri> mseaton: oh well... |
| 23:25:52 | *** mseaton has left #openmrs |
