00:03:17
|
*** wyclif has joined #openmrs
|
00:07:01
|
*** mseaton has joined #openmrs
|
00:07:01
|
*** ChanServ sets mode: +v mseaton
|
00:42:24
|
*** lh has quit IRC
|
00:50:45
|
*** Anuruddha has joined #openmrs
|
00:53:55
|
*** k-joseph has left #openmrs
|
00:55:07
|
*** nwilkie has quit IRC
|
01:07:40
|
*** Anuruddha_ has joined #openmrs
|
01:09:06
|
*** Anuruddha has quit IRC
|
01:11:33
|
*** Anuruddha has joined #openmrs
|
01:13:39
|
*** Anuruddha_ has quit IRC
|
01:17:53
|
*** andrea__ has quit IRC
|
02:00:16
|
*** Anuruddha_ has joined #openmrs
|
02:03:40
|
*** Anuruddha has quit IRC
|
02:10:44
|
*** Anuruddha_ has quit IRC
|
02:44:38
|
*** wyclif_ has joined #openmrs
|
02:44:39
|
*** wyclif has quit IRC
|
03:17:58
|
*** upul` has joined #openmrs
|
03:17:58
|
*** ChanServ sets mode: +v upul`
|
03:18:57
|
*** upul` has left #openmrs
|
03:22:06
|
*** djazayeri has quit IRC
|
04:44:57
|
*** djazayeri has joined #openmrs
|
04:44:57
|
*** ChanServ sets mode: +o djazayeri
|
05:10:50
|
*** djazayeri has quit IRC
|
06:09:22
|
*** mseaton has quit IRC
|
06:25:54
|
*** kavuri has joined #openmrs
|
06:29:44
|
*** kishoreyekkanti has joined #openmrs
|
08:06:32
|
*** tobin_g has joined #openmrs
|
08:37:54
|
*** dkayiwa has joined #openmrs
|
08:43:32
|
*** hybridivy has joined #openmrs
|
08:46:05
|
<hybridivy> hi , i was trying to build the openmrs on my system following the steps as https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers , but when i try to compile it is failing
|
08:46:06
|
<OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org)
|
08:46:43
|
<dkayiwa> hybridivy: can you pastebin the failure error log?
|
08:47:13
|
<hybridivy> http://pastebin.com/wgeVTn9d
|
08:48:15
|
<dkayiwa> hybridivy: have you just forked and clone openmrs-core from github?
|
08:48:25
|
<hybridivy> yes
|
08:48:35
|
<dkayiwa> hybridivy: do you have any local changes?
|
08:49:52
|
<hybridivy> i forked it then cloned from github then using git commandline did: git remote add upstream https://github.com/openmrs/openmrs-core.git
|
08:50:16
|
<hybridivy> then imported it as maven project
|
08:51:02
|
<hybridivy> in eclipse, then tried to maven build on pom.xml
|
08:51:46
|
<hybridivy> openmrs tables are created in mysql
|
08:54:06
|
<dkayiwa> hybridivy: they are only created when you compile it successfully and run
|
08:57:58
|
<hybridivy> actually i builton pom.xml of webapp yesterday , though the pm.xml of openmrs was failing , and i could see the login page but couldnot login
|
08:59:04
|
<hybridivy> so i deleted everything and started on new clone of openmrs , and ran the maven on pom.xml of openmrs and i get the same error
|
08:59:12
|
<dkayiwa> hybridivy: have you made any local changes to the code?
|
08:59:16
|
<hybridivy> no
|
08:59:58
|
<dkayiwa> hybridivy: is the problem with running or compiling?
|
09:00:39
|
<hybridivy> maven build "clean install"
|
09:01:41
|
<hybridivy> compiling
|
09:04:08
|
<dkayiwa> hybridivy: can you do mvn clean install at commandline
|
09:04:08
|
<dkayiwa> ?
|
09:04:41
|
<hybridivy> ok i will give a try
|
09:06:28
|
<hybridivy> as i donot have commanline maven right now
|
09:07:50
|
<dkayiwa> hybridivy: dont you have maven installed?
|
09:08:06
|
<dkayiwa> hybridivy: in which case you would access it from command promot
|
09:08:09
|
<dkayiwa> prompt
|
09:09:13
|
<hybridivy> i was compiling through eclipse , in which maven plugin were installed
|
09:11:04
|
<dkayiwa> hybridivy: you could try doing a hard reset
|
09:11:22
|
<dkayiwa> hybridivy: to ensure that you have things exactly as at the begining
|
09:20:04
|
<hybridivy> great build was success through commandline
|
09:20:25
|
<dkayiwa> hybridivy: plugins do not always work well :)
|
09:53:36
|
*** hybridivy has quit IRC
|
09:55:22
|
*** k-joseph has joined #openmrs
|
09:55:36
|
<k-joseph> dkayiwa: hi
|
09:56:20
|
<dkayiwa> k-joseph: hi
|
10:00:50
|
<k-joseph> dkayiwa: did you look at that commit link i sent you? if so should i close the previous pull request and make a new one for that commit, otherwise i wanted to begiin on that next ticket!!!
|
10:01:15
|
<dkayiwa> k-joseph: yes i did. can you look at the comments on github?
|
10:01:26
|
<k-joseph> dkayiwa: ok
|
10:13:59
|
<dkayiwa> hi kavuri
|
10:20:21
|
*** robbyoconnor has quit IRC
|
10:20:41
|
*** r0bby has joined #openmrs
|
10:20:41
|
*** ChanServ sets mode: +v r0bby
|
10:21:04
|
*** r0bby is now known as robbyoconnor
|
10:22:10
|
*** hybridivy has joined #openmrs
|
10:29:36
|
*** rafa has joined #openmrs
|
10:29:36
|
*** ChanServ sets mode: +v rafa
|
10:30:14
|
<k-joseph> dkayiwa: hi
|
10:30:22
|
<dkayiwa> k-joseph: hi
|
10:30:27
|
<k-joseph> dkayiwa: can you please give an example of aclass with javadoc added, addressing Can you add the class javadoc (description as for the rest of openmrs test classes?)
|
10:31:14
|
<dkayiwa> k-joseph: look for any existing validator test class
|
10:31:34
|
<dkayiwa> k-joseph: and then see its class description (javadoc)
|
10:41:54
|
<dkayiwa> hi kavuri
|
10:44:29
|
*** tobin_g has quit IRC
|
10:47:03
|
*** tobin_g has joined #openmrs
|
10:49:13
|
<kavuri> dkayiwa: hi
|
10:49:27
|
<dkayiwa> kavuri: can you pull and test again?
|
10:49:44
|
<kavuri> dkayiwa: sure, will let you know the result. Am in the middle of sometime, so it might take sometime
|
10:50:36
|
<dkayiwa> kavuri: ok no problem. actually wait to test until after they have approved and merged my commit.
|
10:50:47
|
<kavuri> dkayiwa: ok
|
10:52:51
|
<dkayiwa> kavuri: but you should feel free to look at the commit here: https://github.com/dkayiwa/openmrs-module-event/commit/cd7f26b8a191a5fd2dfb2a37c59ced3499f0e961
|
10:52:56
|
<OpenMRSBot> <http://ln-s.net/+P5v> (at github.com)
|
10:57:43
|
<kavuri> dkayiwa: ok
|
11:06:39
|
*** magoo_ has joined #openmrs
|
11:15:28
|
<k-joseph> dkayiwa: i have addresed all the comments, if there be any thing further, i have pasted all the three class, http://pastebin.com/6Ducezs0
|
11:15:43
|
<dkayiwa> k-joseph: let me check
|
11:16:31
|
<dkayiwa> k-joseph: you did not add the javadoc for RelationshipTypeValidatorTest
|
11:16:42
|
<dkayiwa> k-joseph: as in class description
|
11:18:23
|
<dkayiwa> k-joseph: what is also the use of setName in shouldFailValidationIfDescriptionIsNullOrEmptyOrWhitespace
|
11:19:50
|
<dkayiwa> k-joseph: and what is setdescription doing in shouldFailValidationIfbIsToAIsNullOrEmptyOrWhitespace?
|
11:21:03
|
<dkayiwa> k-joseph: the same in here: shouldFailValidationIfaIsToBIsNullOrEmptyOrWhitespace
|
11:21:39
|
<k-joseph> dkayiwa: am addressing all those issues cuurrently
|
11:21:44
|
<dkayiwa> k-joseph: ok
|
11:24:13
|
*** magoo_ has quit IRC
|
11:31:35
|
<k-joseph> dkayiwa: am not getting exactly how, where to add the javadoc, can you please help me and specify for me an example of a class where its applied, i have so far only seen one with a description of the class, that is Relationshiptype.java, is this how you want me to do this?
|
11:32:06
|
<dkayiwa> k-joseph: can you look at any existing class of the same kind?
|
11:32:16
|
<dkayiwa> k-joseph: tell me which class you have decided to look at
|
11:33:57
|
<k-joseph> dkayiwa: EncounterTypeValidatorTest.java is what am looking at now
|
11:34:44
|
<dkayiwa> k-joseph: can you paste here its class description?
|
11:34:50
|
<dkayiwa> k-joseph: it is one line
|
11:35:26
|
<k-joseph> dkayiwa: methods on the {@link EncounterTypeValidator} class.
|
11:35:52
|
<dkayiwa> k-joseph: is that all?
|
11:36:20
|
<k-joseph> dkayiwa: Tests methods on the {@link EncounterTypeValidator} class.
|
11:36:37
|
<dkayiwa> k-joseph: do you have that in your test?
|
11:36:42
|
*** hybridivy has quit IRC
|
11:37:20
|
<k-joseph> dkayiwa: no, ok am adding that
|
11:42:08
|
*** hybridivy has joined #openmrs
|
11:43:24
|
<k-joseph> dkayiwa: i have included all that in http://pastebin.com/8nwrENVn, except there be any thing else for me to clear or add again on that?
|
11:43:59
|
<dkayiwa> k-joseph: ok looking
|
11:45:11
|
<dkayiwa> k-joseph: can you make the class description in the same format like that for EncounterTypeValidatorTest?
|
11:47:49
|
<dkayiwa> k-joseph: how about the changes in the message properties file?
|
11:49:18
|
<dkayiwa> k-joseph: you also did not address my class doc comment above
|
11:50:55
|
*** suranga has joined #openmrs
|
11:50:55
|
*** ChanServ sets mode: +v suranga
|
11:52:20
|
*** hybridivy has quit IRC
|
11:54:23
|
*** suranga has quit IRC
|
11:57:52
|
<k-joseph> dkayiwa: what exactly are you refering to here class doc comment above
|
11:58:31
|
<dkayiwa> k-joseph: use the same exact class description in in that encounter validator test
|
11:59:06
|
<k-joseph> dkayiwa: do you mean Tests methods on the {@link EncounterTypeValidator} class.
|
11:59:23
|
<dkayiwa> k-joseph: yes something like that
|
11:59:36
|
<dkayiwa> k-joseph: and change in it only what is necessary
|
11:59:45
|
<dkayiwa> k-joseph: like the rest of the validator test classes do
|
12:22:37
|
*** kavuri has quit IRC
|
12:25:18
|
<dkayiwa> k-joseph: can you first create a clean pull request for this?
|
12:25:57
|
<k-joseph> dkayiwa: ok
|
12:49:15
|
*** mseaton has joined #openmrs
|
12:49:15
|
*** ChanServ sets mode: +v mseaton
|
13:05:38
|
<k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/commit/TRUNK-3814
|
13:05:46
|
<OpenMRSBot> <http://ln-s.net/+P7m> (at github.com)
|
13:07:59
|
<dkayiwa> k-joseph: yes go ahead and make the pull request
|
13:08:12
|
<k-joseph> dkayiwa: ok
|
13:16:58
|
*** mseaton has quit IRC
|
13:31:05
|
*** kishoreyekkanti has quit IRC
|
13:31:45
|
<k-joseph> dkayiwa: hi
|
13:31:52
|
<dkayiwa> k-joseph: hi
|
13:32:04
|
<k-joseph> dkayiwa: i have been going through TRUNK-3825, am not sure where i can begin from, any guidance so far i will be glad
|
13:32:31
|
<dkayiwa> !ticket TRUNK-3825
|
13:32:32
|
<OpenMRSBot> dkayiwa: [#TRUNK-3825] Remove loading of module specific log4j configuration files - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3825
|
13:32:51
|
<dkayiwa> k-joseph: have you already switched to the branch?
|
13:33:04
|
<k-joseph> dkayiwa: no
|
13:33:34
|
<dkayiwa> k-joseph: what do you understand by that ticket?
|
13:33:47
|
<dkayiwa> k-joseph: the little that you do understand
|
13:34:05
|
<k-joseph> dkayiwa: not sure
|
13:34:22
|
<dkayiwa> k-joseph: do you completely have zero understanding of that ticket?
|
13:36:04
|
<k-joseph> dkayiwa: it is to do with module, and i think there somethings that should be removed
|
13:36:27
|
<dkayiwa> k-joseph: and does the ticket mention what should be removed?
|
13:36:39
|
<k-joseph> dkayiwa: it does
|
13:36:52
|
<dkayiwa> k-joseph: so now where do you find the problem?
|
13:39:37
|
*** applecool has joined #openmrs
|
13:39:37
|
*** ChanServ sets mode: +v applecool
|
13:40:38
|
<dkayiwa> k-joseph: are we together?
|
13:41:28
|
<dkayiwa> k-joseph: why don't you begin with what you understand?
|
13:41:34
|
*** Nzeyi has joined #openmrs
|
13:42:19
|
<dkayiwa> k-joseph: are you there?
|
13:42:30
|
<k-joseph> dkayiwa: i am there
|
13:42:34
|
*** Nzeyi has quit IRC
|
13:42:42
|
<dkayiwa> k-joseph: what is the problem?
|
13:43:35
|
*** wyclif_ has quit IRC
|
13:44:35
|
<dkayiwa> k-joseph: are you there?
|
13:45:07
|
<k-joseph> dkayiwa: yes, am trying to again go through the ticket
|
13:45:25
|
<dkayiwa> k-joseph: can you start with just what you have just told me?
|
13:46:15
|
<k-joseph> dkayiwa: will be alerting you when am ready to start moving
|
13:46:35
|
<dkayiwa> k-joseph: ok
|
14:18:40
|
<k-joseph> dkayiwa: hi
|
14:18:49
|
<dkayiwa> k-joseph: hi
|
14:19:11
|
<k-joseph> dkayiwa: i think it is if (mod.getLog4j() != null) { DOMConfigurator.configure(mod.getLog4j().getDocumentElement()); } code that i need to remove? i have located the file and the code, except there be another understanding of this but am thinking that by removing that i eliminate the loading of module specific log4j configuration files !!!
|
14:19:36
|
<dkayiwa> k-joseph: start by doing what you think
|
14:19:43
|
<k-joseph> dkayiwa: ok
|
14:23:55
|
*** dkayiwa has quit IRC
|
14:24:27
|
*** dkayiwa has joined #openmrs
|
14:24:37
|
*** mseaton has joined #openmrs
|
14:24:37
|
*** ChanServ sets mode: +v mseaton
|
14:28:15
|
*** wyclif_ has joined #openmrs
|
14:43:44
|
<k-joseph> dkayiwa: hi
|
14:43:51
|
<dkayiwa> k-joseph: hi
|
14:43:54
|
<k-joseph> dkayiwa: concider http://pastebin.com/7e0Xqnkg which is the initial file WebModuleUtil.java, i have removed from line 110 to 122, to make this http://pastebin.com/10dpX8V6,
|
14:44:09
|
<dkayiwa> k-joseph: checking
|
14:46:32
|
<dkayiwa> k-joseph: you seem to have removed more than what was mentioned on that ticket
|
14:46:49
|
<k-joseph> dkayiwa: yes i have seen that too
|
14:47:13
|
<k-joseph> dkayiwa: i was supposed to stop on line 119
|
14:47:17
|
<k-joseph> dkayiwa: ?
|
14:47:26
|
<dkayiwa> k-joseph: send me what you think
|
14:47:33
|
<k-joseph> dkayiwa: ok
|
14:49:09
|
<k-joseph> dkayiwa: http://pastebin.com/BYAguESE
|
14:49:46
|
<dkayiwa> k-joseph: create a pull request for it
|
14:49:55
|
<k-joseph> dkayiwa: ok
|
14:57:36
|
<dkayiwa> k-joseph: after the pull request, go for this ticket TRUNK-3742
|
14:57:52
|
<k-joseph> dkayiwa: ok
|
15:00:39
|
<cpower> Hello everyone
|
15:00:53
|
<cpower> Let's do that Scrum thing.
|
15:01:03
|
<cpower> !scrumon cpower
|
15:01:03
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:01:36
|
<cpower> Order: Wyclif, dkayiwa, rafa, mseaton, Darius and Andread when they appear
|
15:01:56
|
*** andrea_ has joined #openmrs
|
15:02:11
|
<wyclif_> Thursday:
|
15:02:11
|
<wyclif_> Dev call
|
15:02:11
|
<wyclif_> complete other tests related to REPORT-166 - Ensure that all date-based queries are appropriately handling boundary conditions
|
15:02:11
|
<wyclif_> review pull requests
|
15:02:11
|
<wyclif_>
|
15:02:15
|
<wyclif_> Friday:
|
15:02:16
|
<wyclif_> TRUNK-2877 - Don't set password values in the UI in the installation wizard
|
15:02:19
|
<wyclif_> review and apply pull requests
|
15:02:21
|
<wyclif_> Pair with andrea to complete birthdate estimated ticket
|
15:02:22
|
<wyclif_>
|
15:02:24
|
<wyclif_> Blockers: None
|
15:02:40
|
<dkayiwa> Reviewed: Missing Validators for relationship_type - TRUNK-3814
|
15:02:41
|
<dkayiwa> Committed: Creating numeric concept does not fire a message - EVNT-26
|
15:02:41
|
<dkayiwa> Now working on: Upgrade Spring framework to 3.1.x - TRUNK-3390
|
15:02:41
|
<dkayiwa> No Blockers
|
15:02:47
|
<rafa> Yesterday:
|
15:02:47
|
<rafa> * Picked up RESTWS-310 after the design review: RESTWS needs to keep an explicit registry of resources, which should be conditionally populated based on the OpenMRS version
|
15:02:47
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-310
|
15:02:47
|
<rafa> * Calls
|
15:02:47
|
<rafa> No blockers.
|
15:02:48
|
<rafa> Today:
|
15:02:48
|
<rafa> * Continued with RESTWS-310 (will complete by Monday)
|
15:02:49
|
<rafa> No blockers.
|
15:03:12
|
*** mseaton has quit IRC
|
15:03:25
|
<cpower> Andrea you are up
|
15:03:32
|
<dkayiwa> mseaton what a report!!! :)
|
15:03:34
|
<andrea_> Thursday afternoon
|
15:03:34
|
<andrea_> TRUNK-2768
|
15:03:34
|
<andrea_> Modified ShortPersonForm.jsp to try and fix problem - deathdate_estimated
|
15:03:34
|
<andrea_> not getting set in Person table
|
15:03:34
|
<andrea_> Tested in UI - problem still there
|
15:03:35
|
<andrea_> Friday
|
15:03:39
|
<andrea_> skype with Wyclif re problem with TRUNK-2768
|
15:03:41
|
<andrea_> Hopefully will fix and finish ticket
|
15:03:43
|
<andrea_> Blocker
|
15:03:45
|
<andrea_> deathdateEstimated still not getting set in Person table
|
15:04:00
|
<cpower> dkayiwa, short and sweet the way I like it :-)
|
15:04:17
|
<dkayiwa> :D
|
15:04:24
|
<cpower> So that answers my question if the pair programming resolved the ticket for Andrea..
|
15:04:25
|
<rafa> 1 minute scrum :D
|
15:04:33
|
<dkayiwa> :D
|
15:04:44
|
<cpower> Blocker: deathEstimated and the person table
|
15:05:15
|
<cpower> wyclif_ are you going to help Andrea with this more or do we need to get someone in the group to pitch in?
|
15:05:29
|
<cpower> We need her to wrap this one up.
|
15:05:54
|
<rafa> I believe wyclif_ has all needed super powers :D
|
15:07:34
|
<cpower> Ok, I just want andrea_ to be able to move on from this ticket
|
15:07:48
|
<andrea_> wyclif, committed latest code last night (TRUNK-2768)
|
15:08:00
|
<wyclif_> cpower, i will help, we already set a time
|
15:08:02
|
<cpower> Other quick words before I lose everyone's attention.
|
15:08:28
|
<andrea_> cpower, I so want to finish this ticket - everything else is done
|
15:08:31
|
<dkayiwa> hi k-joseph
|
15:08:48
|
<k-joseph> dkayiwa: ho
|
15:08:50
|
<andrea_> wyclif, will be in touch soon - thanks!
|
15:08:54
|
<k-joseph> dkayiwa: hi
|
15:08:55
|
<wyclif_> andrea_, ok
|
15:09:01
|
<dkayiwa> k-joseph: did you create a new branch for the recent commit?
|
15:09:08
|
<wyclif_> actually, i have a blocker myself
|
15:09:09
|
<k-joseph> dkayiwa: yes
|
15:09:13
|
<cpower> 1. A Reporting Sprint will be starting on 1/9 and will go through 1/23 Mike Seaton is the Product Owner, we are still looking for a Developer Lead for this (taking volunteers to work with Mike)
|
15:09:25
|
<dkayiwa> k-joseph: did you do it after doing? git checkout master?
|
15:09:32
|
<cpower> Anyone interested in working on this sprint should let Mike and I know asap.
|
15:10:02
|
<k-joseph> dkayiwa: yes
|
15:10:09
|
<dkayiwa> k-joseph: no it cannot be so
|
15:10:30
|
<rafa> cpower: I could be the dev lead
|
15:10:48
|
<dkayiwa> k-joseph: that is because your commit has got into the other pull request for another ticket
|
15:10:59
|
<dkayiwa> k-joseph: that means you forgot to do git checkout master
|
15:11:02
|
<cpower> rafa, I'm sure Mike would love that.
|
15:11:11
|
<dkayiwa> k-joseph: before creating the new branch for the second ticket
|
15:11:34
|
<dkayiwa> k-joseph: can you reset hard and do it clean?
|
15:11:40
|
<cpower> wyclif_ what's your blocker?
|
15:12:21
|
<k-joseph> dkayiwa: so am supposed to checkout master every time i want to create a new branch?
|
15:12:23
|
<rafa> cpower: can you say in short how responsibilities are divided between a product owner and a deav lead?
|
15:12:23
|
<dkayiwa> k-joseph: after finishing a ticket, you need to do "git checkout master" before creating a branch for a new ticket
|
15:12:28
|
<dkayiwa> k-joseph: yes
|
15:12:35
|
<k-joseph> dkayiwa: ok
|
15:12:37
|
<rafa> cpower: in particular who prepares tickets and set ups the dashboard?
|
15:12:55
|
<andrea_> cpower, I'd like to work on sprint
|
15:12:55
|
<wyclif_> rafa, dkayiwa i have an hql query that doesnt seem to do date comparisons well
|
15:13:01
|
<dkayiwa> k-joseph: if you do not do it, your commits will go into another branch pull request
|
15:13:19
|
<dkayiwa> k-joseph: so you need to do it again
|
15:13:20
|
<wyclif_> probably it is an h2 issues, have any of you run into this?
|
15:13:33
|
<dkayiwa> wyclif_: not me
|
15:13:50
|
<rafa> wyclif_: what do you mean it doesn't compare dates well?
|
15:14:01
|
<rafa> wyclif_: do you have a snippet?
|
15:14:21
|
<cpower> rafa, sure Product lead: Says what features should go in the sprint, Dev lead: Gets the tickets, dashboard and helps the other dev's who assist get it done. But Mike has said he's willing to help co-dev lead so if you need any help here let him and I know.
|
15:14:25
|
<rafa> wyclif_: I can't recall any problems
|
15:15:26
|
<rafa> cpower: thx, sounds good
|
15:15:28
|
<cpower> andrea_, I want you on it too, get your plate cleared prior to 1/8 so when we can get you engaged on 1/9
|
15:16:18
|
<andrea_> cpower, sounds good! Hopefully we will find problem today
|
15:22:21
|
<cpower> !scrumoff
|
15:22:21
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:22:40
|
<k-joseph> dkayiwa: please can you check this pull request https://github.com/openmrs/openmrs-core/pull/181
|
15:22:45
|
<OpenMRSBot> <http://ln-s.net/+P$:> (at github.com)
|
15:22:49
|
<wyclif_> rafa, see http://pastebin.com/efwh8j4y
|
15:23:33
|
<dkayiwa> k-joseph: cant you first check it yourself before showing me?
|
15:24:05
|
<wyclif_> rafa, that test should fail because the encounter's datetime is after the onOrBefore date
|
15:24:12
|
<wyclif_> rafa, but it passes
|
15:24:39
|
<wyclif_> rafa, when i remove the time components and just set the date behind by one day, it fails as expected
|
15:25:59
|
<wyclif_> i think, when the date is a java.util.Date in hbm file, it sets the time to 00:00:00
|
15:26:55
|
<dkayiwa> k-joseph: don't you also see that that pull request has even another commit for the other ticket?
|
15:27:33
|
<k-joseph> dkayiwa: i have seen that
|
15:27:40
|
<k-joseph> dkayiwa: clearing it
|
15:27:46
|
<dkayiwa> k-joseph: ok
|
15:32:52
|
*** dkayiwa has quit IRC
|
15:34:28
|
*** k-joseph has quit IRC
|
15:47:42
|
<rafa> wyclif_: I'm not familiar with DateUtil.getDateTime()
|
15:48:27
|
<wyclif_> rafa, that just creates a date object given a year month and date
|
15:49:26
|
<rafa> wyclif_: and a time? have you tried simply Date now = new Date() and Date past = new Date(now.getTime() - 1000000)?
|
15:50:30
|
<wyclif_> rafa, the problem is not creating a date object
|
15:51:08
|
<rafa> wyclif_: I don't know. it's the only doubt I could have in this snippet ;)
|
15:51:10
|
<wyclif_> rafa, the problem is with the way h2 is handling dates
|
15:51:46
|
<wyclif_> rafa, there is a DateUtil.getDateTime() that takes in time components
|
15:51:49
|
<rafa> wyclif_: are you sure it's h2? when you clear session and get encounter again, does it have the proper date?
|
15:52:21
|
<wyclif_> rafa, even when i change the time in the test dateset it fails, so it is not a session issue
|
15:52:50
|
<rafa> wyclif_: I don't mean it's a session issue
|
15:53:05
|
<rafa> wyclif_: it's just a way to test if time is truncated when saved to h2
|
15:53:49
|
<wyclif_> rafa, yeah that is what am thinking
|
15:54:24
|
<rafa> wyclif_: easy to test
|
15:54:41
|
<wyclif_> rafa, but when i print, the time component exists
|
15:55:26
|
<rafa> wyclif_: you mean you print after you call saveEncounter?
|
15:55:32
|
*** basic has quit IRC
|
15:55:47
|
<wyclif_> rafa, yeah
|
15:56:11
|
<rafa> wyclif_: it's not necessarily what got stored in the db
|
15:56:39
|
<rafa> wyclif_: you need to clear the cache and then get it out of the db
|
15:57:42
|
<rafa> wyclif_: do you know what I mean?
|
15:58:13
|
*** basic has joined #openmrs
|
15:59:54
|
<wyclif_> rafa, i get what you mean, and you are correct, h2 doesnt store the time component i think if in the hbm file the type is java.util.Date
|
16:00:55
|
*** rafa has quit IRC
|
16:02:00
|
*** applecool has quit IRC
|
16:03:43
|
*** rafa has joined #openmrs
|
16:03:43
|
*** ChanServ sets mode: +v rafa
|
16:07:51
|
*** mseaton has joined #openmrs
|
16:07:51
|
*** ChanServ sets mode: +v mseaton
|
16:11:39
|
<rafa> wyclif_: sorry got disconnected. got you. it's definitely possible. a db schema for tests is created straight from hbms and not using liquibase
|
16:12:43
|
<wyclif_> i have noticed rafa, if am to set the encountertime to what i want for testing puproses i have to flush the session before i evaluate the query
|
16:13:29
|
<rafa> wyclif_: did it resolve your issue?
|
16:32:49
|
*** djazayeri has joined #openmrs
|
16:32:49
|
*** ChanServ sets mode: +o djazayeri
|
16:47:44
|
*** nwilkie has joined #openmrs
|
16:57:22
|
*** rafa has quit IRC
|
17:05:38
|
*** andrea_ has quit IRC
|
17:09:04
|
*** mseaton has quit IRC
|
17:09:20
|
*** mseaton has joined #openmrs
|
17:09:20
|
*** ChanServ sets mode: +v mseaton
|
17:14:49
|
*** basic is now known as basic`
|
17:25:01
|
<wyclif_> hi djazayeri
|
17:25:08
|
<djazayeri> hi wyclif_
|
17:25:44
|
<wyclif_> djazayeri, in reporting does really the time a person was born matter when looking for patients born before a certain date?
|
17:26:30
|
<djazayeri> wyclif_: I think we should treat it just like all other date fields, i.e. do the "if midnight -> start of day or end of day" thing.
|
17:26:36
|
<wyclif_> person birth date is intended to be a date and not really a datetime
|
17:27:22
|
<djazayeri> wyclif_: if the user were to say "find me patients born before 1980-01-02 17:24:00" then I think the query should use the time, and not strip it off.
|
17:28:11
|
<djazayeri> wyclif_: really? birthdate is stored in the database as a date+time, and it's represented in the object model with date+time, right?
|
17:41:25
|
*** lh has joined #openmrs
|
17:41:25
|
*** lh has joined #openmrs
|
17:42:06
|
*** kishoreyekkanti has joined #openmrs
|
17:48:55
|
*** mseaton has quit IRC
|
17:50:25
|
*** nwilkie has quit IRC
|
18:02:02
|
*** mseaton has joined #openmrs
|
18:02:02
|
*** ChanServ sets mode: +v mseaton
|
18:02:53
|
*** robbyoconnor has quit IRC
|
18:10:39
|
*** andreapat has joined #openmrs
|
18:11:09
|
<andreapat> wyclif_, u there?
|
18:11:15
|
<wyclif_> yes
|
18:11:30
|
<andreapat> wyclif_ hi
|
18:11:36
|
<wyclif_> hi andreapat
|
18:11:45
|
<andreapat> wyclif, want to skype
|
18:11:48
|
<wyclif_> sure
|
18:12:07
|
<andreapat> wuclif_, should I connect to you?
|
18:12:53
|
<andreapat> wyclif_, should I connect to you?
|
18:13:00
|
<wyclif_> yes
|
18:13:53
|
<wyclif_> andreapat, skype?
|
18:14:09
|
<wyclif_> andreapat, you need to share your screen on skyp[e
|
18:14:12
|
<wyclif_> andreapat, you need to share your screen on skype
|
18:15:25
|
<andreapat> wyclif, forget how to do that
|
18:16:37
|
<andreapat> wyclif, call keeps failing - says I must be on call to share screen
|
18:16:53
|
<djazayeri> can you two use teamviewer?
|
18:18:36
|
<andreapat> djazayeri, wyclif_, ok will strat teamviewer
|
18:22:29
|
<andreapat> wyclif_, djazayeri, my id is 259541105 password: 6609
|
18:24:46
|
<wyclif_> andreapat, okay
|
18:25:04
|
<andreapat> wyclif, skype is saying [10:14:01 AM] *** Call to wyclif.luyima, no answer. ***
|
18:26:09
|
<wyclif_> looks like my team viewer license/trial has expired
|
18:26:28
|
<wyclif_> andreapat, looks like my team viewer license/trial has expired
|
18:27:02
|
<andreapat> wyclif_, yow - what about the Google thing - hangout I think
|
18:29:36
|
<wyclif_> andreapat, do i see your screen on google hangout
|
18:30:14
|
<andreapat> wyclif, I think so - lets check with djazayeri
|
18:30:27
|
<djazayeri> I'm not planning to join the session...
|
18:30:38
|
<djazayeri> what am I supposed to be answering?
|
18:30:54
|
<wyclif_> djazayeri, does google hangout support screen sharing
|
18:31:00
|
<djazayeri> yes
|
18:31:03
|
<wyclif_> ok
|
18:31:04
|
<djazayeri> it does
|
18:31:11
|
<wyclif_> andreapat, can you send me an invite?
|
18:31:19
|
<wyclif_> andreapat, on goodle hangouts?
|
18:31:46
|
<andreapat> djazayeri, that's ok - does Google hangout allow sharing screens - wyclif's teamviewer's license expired
|
18:31:57
|
<wyclif_> andreapat, he said it does
|
18:32:00
|
<djazayeri> andreapat: yes, it does
|
18:33:03
|
<andreapat> djazayeri, great! never used it
|
18:34:03
|
<wyclif_> andreapat, let me know when you are ready
|
18:37:49
|
<andreapat> wyclif, just downloaded plugin
|
18:39:22
|
<andreapat> wyclif, not sure how to start my gmail is: apattson@gmail.com
|
18:46:16
|
<wyclif_> andreapat, start a google hangout and invite me
|
18:46:48
|
<wyclif_> andreapat, preferrably send me the link
|
18:49:10
|
<OpenMRSBot> Recent updates in the world of openmrs: Burke Mamlin: The growing OpenMRS Development Glossary <http://blog.burkeware.com/2013/01/the-growing-openmrs-development-glossary/>
|
18:50:18
|
<andreapat> wyclif: here's link: https://plus.google.com/hangouts/_/4435d92d1a02df1e27d31993551b64f8ffab83b7?authuser=0&hl=en
|
18:50:22
|
<OpenMRSBot> <http://ln-s.net/+PAX> (at plus.google.com)
|
18:57:58
|
<wyclif_> andreapat, hold on a sec
|
19:06:38
|
*** wyclif_ has quit IRC
|
19:07:45
|
*** wyclif has joined #openmrs
|
19:18:36
|
*** lh has quit IRC
|
19:19:40
|
<cpower> Hey djazayeri and mseaton, I'm going to go ahead put out some information on the Dev and Implentor's list on the Reporting Sprint and you guys can comment to make it better if that's ok with you.
|
19:20:02
|
<cpower> I think mseaton gave me some good info on his wiki page
|
19:20:03
|
<djazayeri> cpower: can you send me/mike a draft?
|
19:20:18
|
<cpower> sure
|
19:20:49
|
*** andreapat has quit IRC
|
19:28:02
|
*** wyclif has quit IRC
|
19:31:39
|
*** andreapat has joined #openmrs
|
19:32:07
|
<andreapat> wyclif_, https://plus.google.com/hangouts/_/5739fd650671e944b72aa603c706da9d8ba1bfdb?authuser=0&hl=en
|
19:32:10
|
<OpenMRSBot> <http://ln-s.net/+PBL> (at plus.google.com)
|
19:32:55
|
*** wyclif has joined #openmrs
|
19:33:59
|
<wyclif> andreapat, https://plus.google.com/hangouts/_/4e5d94d42a6d8c2b1f53fb84e4cf5b889b4aade7#
|
19:34:00
|
<OpenMRSBot> <http://ln-s.net/+PBP> (at plus.google.com)
|
19:34:19
|
*** nwilkie has joined #openmrs
|
19:36:12
|
<cpower> mseaton and djazayeri check this out for the release https://docs.google.com/document/d/1TEwNMV0ZBVQBdcX-wXCYxHG-xXUndyZnNA5bs72MJwI/edit
|
19:36:15
|
<OpenMRSBot> <http://ln-s.net/+PBV> (at docs.google.com)
|
19:36:42
|
<cpower> feel free to change it up how you like
|
19:36:52
|
<andreapat> wyclif_, entered your hangout
|
19:37:57
|
<djazayeri> cpower: you need to grant me edit privileges
|
19:39:54
|
<cpower> I have now given rafal.korytowski@gmail and djazayeri@gmail edit rights
|
19:39:58
|
<djazayeri> thanks
|
19:40:56
|
<wyclif> andreapat, am there
|
19:41:49
|
<djazayeri> cpower: mainly I'm going to shorten it, for the email-skimmers out there. :-)
|
19:42:13
|
<djazayeri> cpower: btw, you say "a community-driven sprint on reporting". Do we have another kind of sprint?
|
19:42:20
|
<djazayeri> i.e. not community-driven?
|
19:42:29
|
<cpower> implementer driven
|
19:43:08
|
<cpower> This wasn't a call out by AMPATH or PIH so figured there should be a differece
|
19:43:11
|
<cpower> difference
|
19:43:40
|
<djazayeri> Okay, I think by default all sprints are community-driven. :-)
|
19:43:44
|
<djazayeri> But that's fine, I'll leave it.
|
19:49:18
|
*** lh has joined #openmrs
|
19:49:19
|
*** lh has joined #openmrs
|
19:51:21
|
<djazayeri> cpower: I'm done revising.
|
19:51:45
|
<cpower> ok, thanks for the revisions
|
19:52:39
|
<djazayeri> cpower: incidentally I changed the wiki page link to a short link (from JIRA) since those are more guaranteed to last longer.
|
19:52:59
|
<djazayeri> cpower: also, "Reporting Sprint" isn't a good wiki page title, since we've had other reporting sprints before, and we'll have more in the future.
|
19:55:27
|
<cpower> Should we send this to the implementer page as well?
|
19:55:37
|
<cpower> or just Dev
|
19:55:49
|
<djazayeri> cpower: send to both, I think.
|
19:56:29
|
<andreapat> wyclif_, want to call me on my cell phone?
|
19:57:02
|
<andreapat> wyclif_, call my cell phone: 415 351-8914
|
20:07:55
|
*** lhawthor_ has joined #openmrs
|
20:08:53
|
*** jkeiper has joined #openmrs
|
20:08:53
|
*** ChanServ sets mode: +v jkeiper
|
20:09:17
|
*** lh has quit IRC
|
20:09:23
|
*** lhawthor_ is now known as lh
|
20:09:55
|
*** lhawthor_ has joined #openmrs
|
20:09:59
|
*** lh has quit IRC
|
20:09:59
|
*** lh has joined #openmrs
|
20:11:09
|
*** lhawthor_ has quit IRC
|
20:29:42
|
*** wyclif has quit IRC
|
20:30:02
|
*** wyclif has joined #openmrs
|
21:02:55
|
*** jkeiper has quit IRC
|
21:14:10
|
*** nwilkie has quit IRC
|
21:15:23
|
*** mseaton has left #openmrs
|
21:18:47
|
*** andreapat has quit IRC
|
21:51:00
|
*** cpower has quit IRC
|
22:28:57
|
*** nwilkie has joined #openmrs
|
22:38:28
|
*** wyclif has quit IRC
|
23:01:26
|
*** arnie_ has joined #openmrs
|
23:13:21
|
*** robbyoconnor has joined #openmrs
|
23:13:21
|
*** ChanServ sets mode: +v robbyoconnor
|
23:40:53
|
*** arnie_ has quit IRC
|
23:50:20
|
*** nwilkie has quit IRC
|
23:52:21
|
*** nwilkie has joined #openmrs
|