| 00:16:22 | *** k-joseph has quit IRC |
| 05:15:51 | *** kishoreyekkanti has joined #openmrs |
| 06:38:14 | *** djazayeri has joined #openmrs |
| 06:38:14 | *** ChanServ sets mode: +o djazayeri |
| 07:21:35 | *** dkayiwa has joined #openmrs |
| 07:28:13 | *** judy has joined #openmrs |
| 07:32:44 | <judy> happy new year dkayiwa |
| 07:32:50 | <judy> seen my email on dev list cced to you ? |
| 07:32:55 | <dkayiwa> judy: happy new year :) |
| 07:33:05 | <dkayiwa> judy: even responded already :) |
| 07:34:18 | <judy> when is that invite to kampala.? dkayiwa |
| 07:34:28 | <judy> i am 2 hours away from the border |
| 07:34:32 | <dkayiwa> judy: when do you want it? :) |
| 07:34:59 | <judy> march... to escape election troubles in kenya :) |
| 07:36:21 | <dkayiwa> judy: lollllllllll |
| 07:36:30 | <dkayiwa> judy: granted :) |
| 07:37:12 | <judy> you even know lol? when are you coming to kenya? |
| 07:39:05 | <dkayiwa> judy: i completely have no idea :) |
| 07:39:43 | *** djazayeri has quit IRC |
| 07:43:27 | <judy> dkayiwa |
| 07:43:31 | <judy> my file is too big |
| 07:43:35 | <judy> needs pro |
| 07:43:47 | <judy> can i attach the xml output instead? |
| 07:43:51 | <judy> needs pro users |
| 07:44:13 | <dkayiwa> judy: ok then send me attachment. but privately such that the dev list does not get troubles with the big attachement |
| 07:49:00 | <dkayiwa> judy: wowwwww. such a huge form :) |
| 07:49:29 | <judy> ha hah .. I know.. The users are better off with forms... |
| 07:49:36 | <judy> tahts teh only way tehy will manage... |
| 07:49:42 | <judy> I know you discourage it though |
| 07:50:07 | <dkayiwa> judy: am not the expert on that :) |
| 07:50:27 | <judy> I did a little more of investigation and tried to just run one of the concept sets |
| 07:50:31 | <dkayiwa> judy: never new some people love the orange theme :) |
| 07:50:37 | <judy> ina new form and it fails |
| 07:50:49 | <judy> that specific clinic has an orange theme... |
| 07:51:07 | <dkayiwa> judy: oh i see |
| 07:51:18 | <dkayiwa> judy: is it an AMPATH clinic? |
| 07:56:03 | <judy> no |
| 07:56:33 | <judy> its the clinic i have helped out with in kibera |
| 08:03:53 | *** dkayiwa has quit IRC |
| 08:05:20 | *** dkayiwa has joined #openmrs |
| 08:07:07 | <judy> hey dkayiwa did you find the error? |
| 08:07:15 | <dkayiwa> judy: yes |
| 08:14:43 | <judy> whats is it? |
| 08:14:54 | <dkayiwa> judy: a bug in the module :) |
| 08:18:11 | <dkayiwa> judy: can you create a ticket for it? will fix it immediately :) |
| 08:34:02 | <judy> sawa |
| 08:34:09 | <judy> sorry .. sawa = ok |
| 08:34:20 | <judy> you should know some kiswahili by now... |
| 08:34:24 | <dkayiwa> judy: ofcourse :) |
| 08:34:25 | <judy> dkayiwa |
| 08:47:35 | <judy> created the ticket @dkayiwa |
| 08:47:52 | <dkayiwa> judy: did you add me as a watcher? |
| 09:00:36 | <judy> yes |
| 09:00:39 | <judy> and here is the link.. |
| 09:00:41 | <judy> https://tickets.openmrs.org/browse/XFRM-115 |
| 09:00:46 | <dkayiwa> judy: ok |
| 09:03:21 | <dkayiwa> judy: see my comment on the ticket |
| 09:32:38 | <judy> works |
| 09:32:43 | <judy> dkayiwa |
| 09:32:45 | <judy> thank you |
| 09:32:47 | <dkayiwa> judy: excellent :) |
| 09:33:47 | *** judy has quit IRC |
| 10:00:52 | *** rkorytkowski has joined #openmrs |
| 10:00:52 | *** ChanServ sets mode: +v rkorytkowski |
| 10:01:05 | *** rkorytkowski is now known as rafa |
| 11:31:52 | *** kishoreyekkanti has quit IRC |
| 12:18:03 | *** jkeiper has quit IRC |
| 12:28:35 | *** dkayiwa has quit IRC |
| 12:29:20 | *** dkayiwa has joined #openmrs |
| 12:53:37 | *** fwdew has joined #openmrs |
| 12:56:05 | *** fwdew has quit IRC |
| 12:57:22 | *** supun has joined #openmrs |
| 13:12:06 | *** supun has quit IRC |
| 13:12:26 | *** supun has joined #openmrs |
| 13:20:05 | *** jkeiper has joined #openmrs |
| 13:20:05 | *** ChanServ sets mode: +v jkeiper |
| 13:24:55 | *** wyclif has quit IRC |
| 14:15:36 | *** wyclif has joined #openmrs |
| 14:22:24 | *** k-joseph has joined #openmrs |
| 14:27:05 | *** mseaton has joined #openmrs |
| 14:27:05 | *** ChanServ sets mode: +v mseaton |
| 14:28:03 | <mseaton> rafa, let me know if you need to talk through reporting at all... |
| 14:40:38 | *** mseaton has quit IRC |
| 14:43:55 | *** mseaton has joined #openmrs |
| 14:43:55 | *** ChanServ sets mode: +v mseaton |
| 14:47:03 | *** kishoreyekkanti has joined #openmrs |
| 14:52:08 | *** kishoreyekkanti has quit IRC |
| 14:53:53 | *** dkayiwa has quit IRC |
| 14:55:12 | *** rafa has quit IRC |
| 14:55:15 | *** dkayiwa has joined #openmrs |
| 14:59:01 | <cpower> . |
| 14:59:21 | <cpower> Good morning everyone |
| 15:00:31 | <cpower> Are we ready for our Scrum this morning? |
| 15:00:34 | *** kishoreyekkanti has joined #openmrs |
| 15:00:35 | *** andrea has joined #openmrs |
| 15:00:56 | <cpower> Ok, let's begin |
| 15:00:58 | *** andrea is now known as Guest57564 |
| 15:01:02 | <cpower> !scrumon cpower |
| 15:01:02 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:01:20 | *** Guest57564 is now known as andrea__ |
| 15:01:39 | <cpower> Order: jkeiper, mseaton, dkayiwa, andrea__, wyclif, and darius when he appears |
| 15:02:40 | <mseaton> nothing to report on my end |
| 15:02:55 | *** rafa has joined #openmrs |
| 15:02:55 | *** ChanServ sets mode: +v rafa |
| 15:02:56 | <cpower> ok double next, dkayiwa you are up |
| 15:03:06 | <jkeiper> plowing through AMPATH documents today, and cleaning up the REGCORE sprint |
| 15:03:26 | <dkayiwa> Committed: Xforms module throws error of "Cannot read property 'd' of null xforms" - XFRM-115 |
| 15:03:26 | <dkayiwa> About to finish: Potential Memory Leak reported by Tomcat 7 - TRUNK-3056 |
| 15:03:27 | <dkayiwa> No Blockers |
| 15:03:50 | <cpower> andrea__ your turn |
| 15:03:54 | <andrea__> Friday 12-21 and last week |
| 15:03:55 | <andrea__> TRUNK-2768 |
| 15:03:55 | <andrea__> Added test for deathdateEstimated (like birthdateEstimated) in PatientServiceTest |
| 15:03:55 | <andrea__> Testing in UI |
| 15:03:55 | <andrea__> Test passed - but still not retaining value in UI |
| 15:03:55 | <andrea__> Wednesday |
| 15:03:57 | <andrea__> Finish 1 remaining JSP |
| 15:03:59 | <andrea__> Find problem in UI |
| 15:04:01 | <andrea__> No blockers |
| 15:04:33 | <cpower> wyclif the floor is yours |
| 15:05:33 | *** kishoreyekkanti has quit IRC |
| 15:05:37 | <wyclif> Monday(worked 4hrs): |
| 15:05:37 | <wyclif> emails |
| 15:05:37 | <wyclif> reviewing and applying pull requests |
| 15:05:37 | <wyclif> |
| 15:05:37 | <wyclif> Wednesday: |
| 15:05:39 | <wyclif> reviewing and applying pull requests |
| 15:05:41 | <wyclif> design call |
| 15:05:43 | <wyclif> pick a ticket |
| 15:05:45 | <wyclif> |
| 15:05:47 | <wyclif> Blockers: None |
| 15:06:18 | <rafa> Today: |
| 15:06:18 | <rafa> * Continued with providing support for Reporting by MDS. |
| 15:06:18 | <rafa> No blockers. |
| 15:06:27 | <rafa> * Univ call ;) |
| 15:06:34 | <dkayiwa> :D |
| 15:06:56 | <cpower> ok, so no blockers or discussion points... for many this is a first day back so get caught up and I let's make 2013 a great year for OpenMRS! |
| 15:07:09 | <cpower> !scrumoff |
| 15:07:09 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:52:06 | *** lh has joined #openmrs |
| 15:52:59 | *** k-joseph_ has joined #openmrs |
| 15:54:36 | *** k-joseph has quit IRC |
| 16:02:05 | *** suranga has joined #openmrs |
| 16:02:05 | *** ChanServ sets mode: +v suranga |
| 16:07:22 | <cpower> rafa, I'm trying to get my memory back on what we decided. Are you currently working on Reporting + MDS Integration or is that what we are scheduling you to do starting 1/7? |
| 16:10:54 | *** hybridivy has joined #openmrs |
| 16:11:20 | *** hybridivy has left #openmrs |
| 16:11:58 | *** supun has quit IRC |
| 16:12:11 | *** supun has joined #openmrs |
| 16:14:17 | *** mseaton has quit IRC |
| 16:20:43 | <rafa> cpower: I'm currently working on that |
| 16:23:35 | *** supun has quit IRC |
| 16:38:07 | <cpower> ok thanks rafa |
| 16:39:51 | *** mseaton has joined #openmrs |
| 16:39:51 | *** ChanServ sets mode: +v mseaton |
| 16:40:35 | *** andrea__ has quit IRC |
| 16:58:04 | <k-joseph_> dkayiwa: hi |
| 16:58:33 | *** k-joseph_ is now known as k-joseph |
| 17:00:01 | *** mseaton1 has joined #openmrs |
| 17:01:48 | *** mseaton has quit IRC |
| 17:08:31 | <suranga> hi jkeiper |
| 17:08:59 | <suranga> jkeiper, about that comment tha you just made to trunk 3769... |
| 17:09:17 | *** rafa has quit IRC |
| 17:09:45 | <suranga> jkeiper, what should be the correct behavior if personId is null ? I initally thought that there will ALways be a patient... |
| 17:11:57 | <dkayiwa> k-joseph: hi |
| 17:15:12 | <k-joseph> dkayiwa: i have looking at the tests available in the code and it looks to me as if they take up the same form, the test cases that are for rejectIfEmptyOrWhitespace(), is this right? i have again gone through the unit test links |
| 17:15:59 | <dkayiwa> k-joseph: like which test have you looked at? |
| 17:17:42 | <k-joseph> dkayiwa: FieldTypeValidatorTest, EncounterTypeValidatorTest, PatientIdentifierTypeValidatorTest, ConceptDatatypeValidatorTest |
| 17:18:34 | <dkayiwa> k-joseph: can you also send me your pastebin link? |
| 17:18:45 | <k-joseph> dkayiwa: ok |
| 17:27:20 | *** dkayiwa has quit IRC |
| 17:28:11 | <k-joseph> dkayiwa: http://pastebin.com/1Eegm01v |
| 17:28:16 | *** dkayiwa has joined #openmrs |
| 17:31:44 | <dkayiwa> k-joseph: are you there? |
| 17:31:53 | <k-joseph> dkayiwa: yes |
| 17:32:06 | <dkayiwa> k-joseph: still waiting for your pastebin |
| 17:32:22 | <k-joseph> dkayiwa: http://pastebin.com/1Eegm0 |
| 17:32:51 | <dkayiwa> k-joseph: that url is not correct |
| 17:32:56 | <k-joseph> et by peer ) |
| 17:32:56 | <k-joseph> [20:28] <k-joseph> dkayiwa: http://pastebin.com/1Eegm0 1v |
| 17:33:00 | <jkeiper> suranga, hey man |
| 17:33:22 | <k-joseph> dkayiwa: sorry, http://pastebin.com/1Eegm01v |
| 17:33:23 | <jkeiper> suranga, that's why i asked the question ... not sure if we are happy with saying patient will always exist on encounter |
| 17:33:41 | <jkeiper> suranga, but afaik that's how we roll |
| 17:33:43 | <jkeiper> :-D |
| 17:34:06 | <suranga> jkeiper, woopsy. but wont validation prevent the encounter from making it this far without a patient assigned ? |
| 17:34:08 | <dkayiwa> k-joseph: can you take a close look at FieldTypeValidatorTest ? |
| 17:34:30 | <jkeiper> suranga, probably? |
| 17:35:04 | <jkeiper> suranga, answer is: i don't know :-D ... but I do know that NPEs are annoying |
| 17:35:22 | <jkeiper> suranga, just found one in Concept.addSetMember() |
| 17:35:22 | <k-joseph> dkayiwa: looking at it now |
| 17:35:25 | <suranga> jkeiper, totally agreee :( |
| 17:35:42 | <dkayiwa> k-joseph: look at only this method: validate_shouldFailValidationIfNameIsNullOrEmptyOrWhitespace |
| 17:35:52 | <suranga> jkeiper, whom should we consult ? or, what would u recommend ? |
| 17:35:56 | <dkayiwa> k-joseph: and tell me if you understand its contents |
| 17:36:53 | <k-joseph> dkayiwa: to some extent, i do understand the content |
| 17:37:13 | <dkayiwa> k-joseph: what don't you understand about it? |
| 17:37:53 | <jkeiper> suranga, we can bring it up briefly on today's design call |
| 17:38:12 | <suranga> jkeiper++ |
| 17:38:35 | <suranga> jkeiper, you know about my connection. but ill try to be there.. |
| 17:38:50 | <suranga> jkeiper, starts in 3o mins, right ? |
| 17:38:52 | <jkeiper> suranga, ok .. i'll bring it up |
| 17:40:55 | <dkayiwa> k-joseph: are you there? |
| 17:41:07 | <k-joseph> dkayiwa: yes |
| 17:51:52 | *** djazayeri has joined #openmrs |
| 17:51:52 | *** ChanServ sets mode: +o djazayeri |
| 18:00:06 | *** djazayeri has quit IRC |
| 18:00:44 | *** djazayeri has joined #openmrs |
| 18:00:44 | *** ChanServ sets mode: +o djazayeri |
| 18:19:01 | <jkeiper> suranga, there's your answer (in github) :-) |
| 18:19:53 | <suranga> jkeiper, ooh, I see it :) |
| 18:20:29 | <suranga> jkeiper, looks like we are good to close that ticket then, it seems that alls well :) :) |
| 18:26:25 | <jkeiper> :-) |
| 18:33:13 | <k-joseph> dkayiwa: paste link== http://pastebin.com/5R2rBV4i |
| 18:33:22 | <dkayiwa> k-joseph: ok |
| 18:37:13 | *** mseaton1 has quit IRC |
| 18:40:46 | <dkayiwa> k-joseph: this is much better than before |
| 18:42:16 | <dkayiwa> k-joseph: can you add another @should and corresponding test? |
| 18:42:41 | <k-joseph> dkayiwa: which one exactly? |
| 18:42:41 | <dkayiwa> k-joseph: something like this: |
| 18:43:00 | <dkayiwa> k-joseph: @should pass validation if all required fields are set |
| 18:43:25 | <k-joseph> dkayiwa: let me try doing that |
| 18:43:29 | <dkayiwa> k-joseph: ok |
| 18:45:44 | <k-joseph> dkayiwa: am now having a problem of my validator for description, it has stopped working, which way should i implement for this? |
| 18:46:14 | <dkayiwa> k-joseph: what did you change |
| 18:46:26 | <dkayiwa> k-joseph: can you pastebin it |
| 18:46:45 | <k-joseph> dkayiwa: nothing, ok let me paste bin the two |
| 18:49:49 | <k-joseph> dkayiwa: http://pastebin.com/xn9FSUvu |
| 18:50:33 | *** mseaton has joined #openmrs |
| 18:50:33 | *** ChanServ sets mode: +v mseaton |
| 18:51:47 | *** rafa has joined #openmrs |
| 18:51:47 | *** ChanServ sets mode: +v rafa |
| 19:01:16 | <k-joseph> dkayiwa: still for all the previous tests to pass, i have noticed that i have to change description to Description in RelationshipTypeValidator for that field, |
| 19:01:48 | *** cpower has quit IRC |
| 19:01:50 | <dkayiwa> k-joseph: for it to pass? |
| 19:02:33 | <k-joseph> dkayiwa: yes, i mean to pass the junit test |
| 19:03:01 | <dkayiwa> k-joseph: ok good that it now passes |
| 19:24:26 | *** k-joseph_ has joined #openmrs |
| 19:25:37 | *** k-joseph has quit IRC |
| 19:33:39 | *** travis-ci has joined #openmrs |
| 19:33:39 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [2cf03b9] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3921001 |
| 19:33:39 | *** travis-ci has left #openmrs |
| 19:33:42 | <OpenMRSBot> <http://ln-s.net/+OW7> (at travis-ci.org) |
| 19:45:12 | *** lh has quit IRC |
| 19:53:34 | *** djazayeri has quit IRC |
| 19:54:26 | *** djazayeri has joined #openmrs |
| 19:54:27 | *** ChanServ sets mode: +o djazayeri |
| 20:01:48 | *** k-joseph_ is now known as k-joseph |
| 20:05:01 | *** mseaton has quit IRC |
| 20:05:39 | *** mseaton has joined #openmrs |
| 20:05:39 | *** ChanServ sets mode: +v mseaton |
| 20:15:36 | *** rafa has quit IRC |
| 21:12:39 | <k-joseph> dkayiwa: i have @should pass validation if all required fields are set, pasted at http://pastebin.com/r5KsheL3 |
| 21:12:49 | <dkayiwa> k-joseph: ok |
| 21:14:26 | <dkayiwa> k-joseph: can you look at shouldFailValidationIfaIsToBIsNullOrEmptyOrWhitespace |
| 21:15:27 | <k-joseph> dkayiwa: looking at it now |
| 21:17:06 | <dkayiwa> k-joseph: if you change from type.setaIsToB(null); to type.setaIsToB("some value"); does it pass? |
| 21:17:37 | <k-joseph> dkayiwa: yes, it does |
| 21:18:37 | <dkayiwa> k-joseph: can you pastebin the validator |
| 21:19:14 | <k-joseph> dkayiwa:when i replace some value with null, the test fails |
| 21:19:42 | *** Echidna has quit IRC |
| 21:21:30 | <k-joseph> dkayiwa: http://pastebin.com/j9yqddhy |
| 21:22:29 | <dkayiwa> k-joseph: can you create a pull request with all your changes |
| 21:22:51 | <k-joseph> dkayiwa: ok |
| 21:37:07 | *** jkeiper has quit IRC |
| 21:41:34 | *** Echidna has joined #openmrs |
| 21:41:34 | *** ChanServ sets mode: +v Echidna |
| 21:44:27 | *** travis-ci has joined #openmrs |
| 21:44:27 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [3efc34f] [wluyima] The build was broken. - http://travis-ci.org/openmrs/openmrs-core/builds/3923135 |
| 21:44:27 | *** travis-ci has left #openmrs |
| 21:44:31 | <OpenMRSBot> <http://ln-s.net/+OYx> (at travis-ci.org) |
| 21:44:57 | <k-joseph> dkayiwa: please take a look at this commit, is it okay https://github.com/k-joseph/openmrs-core/commit/25f5b792f35213a8ffe38f91ecf4bb7ae0027718 |
| 21:44:59 | <OpenMRSBot> <http://ln-s.net/+OZ0> (at github.com) |
| 21:45:05 | <dkayiwa> k-joseph: ok |
| 22:31:22 | *** dkayiwa has quit IRC |
| 22:34:12 | *** mseaton has quit IRC |
| 22:39:04 | *** wyclif has quit IRC |
| 22:45:33 | *** suranga has quit IRC |
| 22:49:12 | *** lh has joined #openmrs |
| 22:49:12 | *** lh has joined #openmrs |
| 23:15:29 | *** lh has quit IRC |
| 23:39:38 | *** k-joseph has quit IRC |
| 23:47:02 | *** lh has joined #openmrs |
| 23:47:02 | *** lh has joined #openmrs |
| 23:51:33 | *** mseaton has joined #openmrs |
| 23:51:33 | *** ChanServ sets mode: +v mseaton |
| 23:53:22 | *** mseaton has quit IRC |