| 00:44:43 | *** djazayeri has joined #openmrs |
| 00:44:43 | *** ChanServ sets mode: +o djazayeri |
| 00:51:22 | *** djazayeri has quit IRC |
| 00:56:59 | *** djazayeri has joined #openmrs |
| 00:56:59 | *** ChanServ sets mode: +o djazayeri |
| 01:09:12 | *** k-joseph has quit IRC |
| 03:29:00 | *** harshadura has quit IRC |
| 03:47:12 | *** Iome has quit IRC |
| 03:47:20 | *** Iome has joined #openmrs |
| 04:15:56 | *** djazayeri has quit IRC |
| 04:17:33 | *** cpower has quit IRC |
| 07:29:30 | *** sujatro has joined #openmrs |
| 07:35:10 | <sujatro> using github... i am doing this but it is giving me an eror |
| 07:35:20 | <sujatro> git checkout master |
| 07:35:21 | <sujatro> needs merge error: you need to resolve your current index first |
| 07:35:32 | <sujatro> solutions?? |
| 07:38:02 | *** sujatro has left #openmrs |
| 08:20:14 | *** dkayiwa has joined #openmrs |
| 08:44:02 | *** yony258 has joined #openmrs |
| 08:44:35 | <yony258> Hi, in need of some help with Spring and URL parameters. Any help will be appreciated :) |
| 08:44:57 | <yony258> Im having: org.springframework.beans.TypeMismatchException |
| 08:46:31 | <dkayiwa> yony258: when? |
| 08:46:50 | <yony258> dkayiwa: Its about the create appointment form |
| 08:47:12 | <dkayiwa> yony258: can you pastebin stack trace |
| 08:47:12 | <yony258> dkayiwa: When I do url parameter for example: ?patient=364 |
| 08:47:19 | <yony258> dkayiwa: sure |
| 08:47:35 | <yony258> dkayiwa: Just let me explain |
| 08:47:54 | <yony258> dkayiwa: When I do ?patient=364 it loads the correct patient but when I POST it crashes |
| 08:48:11 | <yony258> dkayiwa: http://pastebin.com/63YKKVM7 |
| 08:48:50 | <yony258> dkayiwa: same with ?locationId=4 and ?providerSelect=2 |
| 08:49:17 | <yony258> dkayiwa: The paste bin is the error for ....?providerSelect=2 |
| 08:49:43 | <dkayiwa> yony258: can you give me that for patient |
| 08:49:49 | <yony258> dkayiwa: sure |
| 08:50:21 | <yony258> dkayiwa: http://pastebin.com/nBhEpwxN |
| 08:51:16 | <yony258> dkayiwa: Why it became String[] "[364,364]" rather than String "364" ? |
| 08:51:22 | <dkayiwa> yony258: does that happen when you try submit? |
| 08:51:29 | <yony258> dkayiwa: yes |
| 08:51:35 | <dkayiwa> yony258: can i look at the jsp and controller? |
| 08:51:38 | <yony258> dkayiwa: Any POST actually |
| 08:51:58 | <yony258> dkayiwa: Well my JSP is pretty complex but I can send you them both if you want |
| 08:52:20 | <yony258> dkayiwa: Controller: http://pastebin.com/MZ0BidMc |
| 08:52:52 | <yony258> dkayiwa: JSP: http://pastebin.com/WzTDhbWW |
| 08:53:00 | <dkayiwa> yony258: ok looking |
| 08:53:23 | <yony258> dkayiwa: Thank you :D |
| 08:54:19 | <yony258> dkayiwa: Why its doing a String array and not a String? |
| 08:54:31 | <dkayiwa> yony258: looking |
| 08:59:28 | <yony258> dkayiwa: It works without the URL parameter, but when there is a URL parameter it crashes. |
| 09:00:17 | <dkayiwa> yony258: how does the url parameter look like? |
| 09:00:35 | <yony258> dkayiwa: http://localhost:8081/openmrs-standalone/module/appointment/appointmentForm.form?patient=364 |
| 09:01:00 | <dkayiwa> yony258: change it to this: http://localhost:8081/openmrs-standalone/module/appointment/appointmentForm.form?patient=364 |
| 09:01:10 | <dkayiwa> yony258: sorry |
| 09:01:39 | <dkayiwa> yony258: i meant change the parameter from "patient=364" to "patientId=364" |
| 09:01:53 | <dkayiwa> yony258: does that make sense? |
| 09:02:01 | <yony258> dkayiwa: It doesn't work |
| 09:02:21 | <dkayiwa> yony258: which one does not work? |
| 09:02:37 | <yony258> dkayiwa: ?patientId=364 |
| 09:02:50 | <yony258> dkayiwa: It doesn't loads the patient |
| 09:04:05 | <dkayiwa> yony258: loading the patient on which page? |
| 09:04:18 | <yony258> dkayiwa: Create Appointment Form |
| 09:04:24 | <yony258> dkayiwa: using the patientField tag |
| 09:05:35 | <dkayiwa> yony258: how is it supposed to load the patient? |
| 09:06:02 | <yony258> dkayiwa: Let me screenshot it |
| 09:06:17 | <dkayiwa> yony258: ah i see |
| 09:06:24 | <dkayiwa> yony258: you do not have to. just change this |
| 09:06:52 | <dkayiwa> yony258: in the jsp, change from queryParameters['patient'] to queryParameters['patient'Id] |
| 09:07:05 | <dkayiwa> queryParameters['patientId'] |
| 09:07:11 | <yony258> dkayiwa: let me try |
| 09:07:50 | <yony258> dkayiwa: Nope doesn't work |
| 09:07:59 | <yony258> dkayiwa: http://snag.gy/nCnVv.jpg |
| 09:08:03 | <dkayiwa> yony258: same error? |
| 09:08:05 | <yony258> dkayiwa: http://i.snag.gy/7BLw9.jpg |
| 09:08:22 | <yony258> dkayiwa: Nothing happens (see first screenshot) |
| 09:08:34 | <dkayiwa> yony258: send me your jsp after change |
| 09:09:23 | <yony258> dkayiwa: http://pastebin.com/KTwrf1h5 |
| 09:10:00 | <dkayiwa> yony258: any browser catching? |
| 09:10:08 | <yony258> dkayiwa: Oh right!, let me try |
| 09:10:51 | <yony258> dkayiwa: Nope.. |
| 09:11:32 | <dkayiwa> yony258: looks like now i need to deal with the entire module. are your changes pushed? |
| 09:12:13 | <yony258> dkayiwa: No not yet |
| 09:13:39 | <yony258> dkayiwa: pushed |
| 09:13:47 | <dkayiwa> yony258: ok pulling |
| 09:13:56 | <yony258> dkayiwa: I really think the problem is with the String[] instead of String |
| 09:14:11 | <yony258> dkayiwa: the error says that it cant translate that String[] to a patient |
| 09:14:54 | <dkayiwa> yony258: does that mean you are using String[] instead of String? :) |
| 09:15:02 | <yony258> dkayiwa: I never used String[] |
| 09:15:15 | <yony258> dkayiwa: But that URL parameter causing this to be String[] |
| 09:15:27 | <dkayiwa> yony258: yes thats exactly what we dealing with :) |
| 09:16:15 | <yony258> dkayiwa: I used a queryParameter plug in u can see it in resources/Scripts/queryParameters.js |
| 09:16:27 | <dkayiwa> yony258: ok |
| 09:16:28 | <yony258> dkayiwa: But I dont think the problem is that |
| 09:22:12 | <dkayiwa> yony258: so how do i reproduce that from the UI? |
| 09:22:26 | <yony258> dkayiwa: Go to Create Appointment Form |
| 09:22:52 | <yony258> dkayiwa: Add to the url ?patient=364 (or any patient Id u have) |
| 09:23:13 | <dkayiwa> yony258: and then press ENTER? |
| 09:23:26 | <yony258> dkayiwa: yes |
| 09:23:29 | <yony258> dkayiwa: And cause POST (Click "Find available times" or "Save appointment") |
| 09:25:48 | <dkayiwa> yony258: did i do the steps differently. i do not see any problem |
| 09:25:56 | <yony258> dkayiwa: What you did? |
| 09:26:18 | <dkayiwa> yony258: oh never mind. got it :) |
| 09:29:56 | *** rafa has joined #openmrs |
| 09:29:56 | *** ChanServ sets mode: +v rafa |
| 09:31:38 | <dkayiwa> yony258: can you help me understand the logic a bit. when i select a patient, does it like reload the page? |
| 09:32:02 | <yony258> dkayiwa: Yea, it redirects to the same url just with the new patient parameter |
| 09:33:14 | <dkayiwa> yony258: and that happens correctly. not so? |
| 09:33:21 | <yony258> dkayiwa: Yes |
| 09:33:45 | <yony258> dkayiwa: The problem is that it cant translate a patient if there is a "?patient=" URL parameter |
| 09:33:56 | <yony258> dkayiwa: Im trying now to find the POST requests and see if they are corrupted |
| 09:34:49 | <dkayiwa> yony258: ok |
| 09:34:56 | <yony258> dkayiwa: This is the POST request: http://i.snag.gy/ctJO7.jpg |
| 09:35:29 | <yony258> dkayiwa: I think the problem is that we have "364" both in the Query string parameters and in the Form Data, which results in 2 "patient" |
| 09:35:39 | <dkayiwa> yony258: yes |
| 09:35:50 | *** dkayiwa has quit IRC |
| 09:37:32 | *** dkayiwa has joined #openmrs |
| 09:37:49 | <yony258> dkayiwa: |
| 09:37:51 | <yony258> http://forum.springsource.org/showthread.php?24966-How-to-avoid-binding-of-Query-Parameters |
| 09:37:54 | <OpenMRSBot> <http://ln-s.net/+N89> (at forum.springsource.org) |
| 09:38:05 | <yony258> dkayiwa: Comment #4 is exactly what we have here |
| 09:38:16 | <dkayiwa> yony258: when i change to patientId, i do not get the error on submit |
| 09:38:30 | <dkayiwa> yony258: as in when i change the parameter from patient to patientId |
| 09:38:38 | <yony258> dkayiwa: But does it do anything? I mean patientId didnt seem to work for me |
| 09:38:54 | <dkayiwa> yony258: what should it do? |
| 09:39:15 | <yony258> dkayiwa: It should open the page with the patient "patientId" |
| 09:40:02 | <dkayiwa> yony258: which page should it open? the patient search page? |
| 09:40:36 | <yony258> dkayiwa: When navigating to "appointmentForm.form?patientId=364" it should open Create Appointment Form with the patient 364 already loaded |
| 09:41:11 | <dkayiwa> yony258: does the controller handle that parameter? |
| 09:41:34 | <yony258> dkayiwa: <spring:bind does |
| 09:42:19 | <dkayiwa> yony258: <spring:bind gets from the appointment.patient object which comes from the controller |
| 09:42:57 | <yony258> dkayiwa: But I never handled any Patient and yet it worked without the URL parameter |
| 09:43:08 | <yony258> dkayiwa: Sorry Im a bit confused :/ |
| 09:44:20 | <dkayiwa> yony258: looks like i may be confused too :) |
| 09:44:48 | <yony258> dkayiwa: I cant explain the issue better than this: http://forum.springsource.org/showthread.php?24966-How-to-avoid-binding-of-Query-Parameters&p=61478#post61478 |
| 09:44:50 | <OpenMRSBot> <http://ln-s.net/+N8C> (at forum.springsource.org) |
| 09:45:21 | <yony258> dkayiwa: Let me shorten it for you |
| 09:45:26 | <yony258> dkayiwa: , if I submit a form which contains an input element of name="param2" and value="value2" to the URL myForm?param1=value1 then both param1 and param2 will be bound. |
| 09:45:57 | <yony258> dkayiwa: In our case param1=param2="patient" and value1=value2="364" |
| 09:46:00 | <yony258> dkayiwa: :/ |
| 09:47:17 | <dkayiwa> yony258: thats why i say the the parameter name should be different from the input element |
| 09:47:33 | <dkayiwa> yony258: input element should be patient while param patientId |
| 09:47:41 | <yony258> dkayiwa: Let me explain the motivation for this too: I want that when the user selects a patient and click "View Patient" that when he clicks "Back" he will return to this form with the selected patient. (This sentence is a bit confusing let me know if you want me to rephrase it) |
| 09:47:50 | <yony258> dkayiwa: Hmmm |
| 09:48:03 | <yony258> dkayiwa: That sounds right, I just dont know why it doesn't works :/ |
| 09:49:01 | <yony258> dkayiwa: Maybe add to the controller some @RequestParam(value = "patientId") ? |
| 09:49:25 | <dkayiwa> yony258: can you handle the patientId parameter in the controller and then set the appointment.patient property? |
| 09:49:38 | <yony258> dkayiwa: Yes I will do that ! |
| 09:49:59 | <yony258> dkayiwa: Thank you for your help it was great :D |
| 09:50:00 | <dkayiwa> yony258: looks like that should be the correct way to deal with it in the spring MVC world |
| 09:50:56 | <dkayiwa> yony258: you are too generous with your comments. looks like i have done nothing |
| 09:51:22 | <dkayiwa> :) |
| 09:51:31 | <yony258> dkayiwa: You directed me to the source of the problem :D |
| 09:51:43 | <dkayiwa> yony258: hahahahahahaha :) |
| 09:57:07 | <yony258> dkayiwa: Works !, I added a requestParam to the getAppointment |
| 09:57:18 | <dkayiwa> yony258: excellent |
| 09:57:36 | <yony258> dkayiwa: I should also add it to "save" right? |
| 09:58:56 | <dkayiwa> yony258: no |
| 09:59:11 | <dkayiwa> yony258: getAppointment will always be called |
| 09:59:14 | <yony258> dkayiwa: Oh right because it will do getAppointment anyway before |
| 09:59:19 | <yony258> dkayiwa++ |
| 09:59:27 | <yony258> dkayiwa: Thanks man, have a good day |
| 09:59:27 | <dkayiwa> yony258++ :) |
| 09:59:36 | <dkayiwa> yony258: same to you |
| 10:12:57 | *** k-joseph has joined #openmrs |
| 10:14:03 | <k-joseph> dkayiwa: hi, |
| 10:14:10 | <dkayiwa> k-joseph: hi |
| 10:14:14 | <k-joseph> dkayiwa: am ready now in response to your email |
| 10:14:39 | <dkayiwa> k-joseph: so did you do as per my earlier email? |
| 10:14:54 | <k-joseph> dkayiwa: yes |
| 10:15:12 | <dkayiwa> k-joseph: did you replace? |
| 10:15:36 | <k-joseph> dkayiwa: yes, |
| 10:15:45 | <dkayiwa> k-joseph: what did you replace? |
| 10:16:26 | <k-joseph> dkayiwa: the validation in the class you talled me with my validator |
| 10:16:43 | <dkayiwa> k-joseph: can you pastebin for me? |
| 10:16:51 | <k-joseph> dkayiwa: ok |
| 10:18:23 | *** yony258 has quit IRC |
| 10:27:53 | *** djazayeri has joined #openmrs |
| 10:27:53 | *** ChanServ sets mode: +o djazayeri |
| 10:34:51 | <k-joseph> dkayiwa: at: http://pastebin.com/qJ7Q6A80 |
| 10:37:13 | *** dkayiwa has quit IRC |
| 10:37:57 | *** dkayiwa has joined #openmrs |
| 11:16:48 | *** k-joseph has quit IRC |
| 11:33:14 | *** rafa has quit IRC |
| 11:39:03 | *** dkayiwa_ has joined #openmrs |
| 11:39:43 | *** dkayiwa has quit IRC |
| 11:39:48 | *** dkayiwa_ is now known as dkayiwa |
| 11:45:57 | *** rkorytkowski has joined #openmrs |
| 11:45:57 | *** ChanServ sets mode: +v rkorytkowski |
| 11:46:06 | *** rkorytkowski is now known as rafa |
| 11:53:56 | *** djazayeri has quit IRC |
| 13:13:39 | *** k-joseph has joined #openmrs |
| 14:04:28 | *** dkayiwa has quit IRC |
| 14:21:36 | *** dkayiwa has joined #openmrs |
| 14:28:36 | <dkayiwa> hi k-joseph |
| 14:28:44 | *** wyclif_ has quit IRC |
| 14:28:48 | <k-joseph> dkayiwa: hi |
| 14:28:58 | <dkayiwa> k-joseph: did you send the pastebin? |
| 14:29:39 | <k-joseph> dkayiwa: yes, didnt you see it, i sent it through irc: |
| 14:29:50 | <dkayiwa> k-joseph: did not see it |
| 14:30:06 | <k-joseph> dkayiwa: http://pastebin.com/qJ7Q6A80 |
| 14:30:30 | <dkayiwa> k-joseph: did you replace anything? |
| 14:31:40 | <k-joseph> dkayiwa: replaced my original validation with the validation from the validator, |
| 14:31:51 | <dkayiwa> k-joseph: did you understand my email? |
| 14:33:20 | <dkayiwa> k-joseph: are you there? |
| 14:33:31 | <k-joseph> dkayiwa: am now not sure what you could have meant, i have replaced the validation two way and it looks as if it isnt the thing to be done, so please can you pardon |
| 14:34:02 | <dkayiwa> k-joseph: can you read my email line by line and tell me what you understood by each line? |
| 14:36:13 | <dkayiwa> k-joseph: are you there? |
| 14:36:18 | <k-joseph> dkayiwa:am supposed to find the class RelationshipTypeFormController, find in its code where the validation is done before the form is submited, remove the validation |
| 14:36:53 | <k-joseph> dkayiwa: and replace it with the validation fron the validator |
| 14:37:56 | <k-joseph> dkayiwa: ??? like this: new RelationshipTypeValidator().validate(type, errors);, understands its meaning but not sure what you meant |
| 14:39:04 | <dkayiwa> k-joseph: and did you do that? |
| 14:40:02 | <k-joseph> dkayiwa: yes, and that is the paste |
| 14:40:19 | <dkayiwa> k-joseph: is that what you have sent me in the above pastebin link? |
| 14:40:39 | <k-joseph> dkayiwa: yes |
| 14:41:16 | <dkayiwa> k-joseph: in which class did i tell you to make changes? as per that email? |
| 14:42:09 | <dkayiwa> k-joseph: can you respond a bit faster? i need to switch my concentration to something else. |
| 14:42:22 | <k-joseph> dkayiwa: at first i made the changes in the validator class, but was after wards |
| 14:42:41 | <k-joseph> dkayiwa: led to dought my interpretation |
| 14:43:16 | <k-joseph> dkayiwa: of the mail, then i change and made the change s in my validator |
| 14:43:17 | <dkayiwa> k-joseph: is that as per your instructions or my instructions in the email? |
| 14:44:15 | <k-joseph> dkayiwa: still i have the paste for the change in the avlidator |
| 14:44:45 | <dkayiwa> k-joseph: are you really following the simple instructions in my email????? |
| 14:45:38 | <k-joseph> dkayiwa: yes, and if not then i beg your pardon on what you exactly meant |
| 14:45:57 | <dkayiwa> k-joseph: simply do what is in the email. And thats all |
| 14:46:16 | <dkayiwa> k-joseph: my steps are very clear and simple. Do not make yourself do what i did not say |
| 14:46:27 | <dkayiwa> k-joseph: you seem to complicate things for yourself |
| 14:48:05 | <dkayiwa> k-joseph: may be emails are hard for you. let me paste the steps here at IRC |
| 14:48:09 | <dkayiwa> k-joseph: 1) Look for a class named: RelationshipTypeFormController |
| 14:48:17 | <dkayiwa> k-joseph: 2) Locate where the validation is done before the form is submitted. |
| 14:48:33 | <dkayiwa> k-joseph: 3) Remove all that validation and replace it with your validator like this: new RelationshipTypeValidator().validate(type, errors); |
| 14:48:58 | <dkayiwa> k-joseph: whats hard to understand about those steps? |
| 14:50:15 | <dkayiwa> k-joseph: are you there? |
| 14:51:25 | <k-joseph> dkayiwa: pasted at http://pastebin.com/AxFUCmGP |
| 14:52:00 | <dkayiwa> k-joseph: is that a response to my three steps above? |
| 14:53:19 | <dkayiwa> k-joseph: are you multitasking? as in doing something else at the same time? |
| 14:53:31 | <dkayiwa> k-joseph: you are a bit slow at responding and i need to move on???? |
| 14:53:51 | <k-joseph> dkayiwaa: the link is http://pastebin.com/5nw4ubg7 |
| 14:54:13 | <dkayiwa> k-joseph: can you respond to my questions? |
| 14:54:39 | <dkayiwa> k-joseph: you are simply sending links that am not asking for |
| 14:54:48 | <k-joseph> dkayiwa: am not multi tasking now |
| 14:55:04 | <dkayiwa> k-joseph: am engaging you to think thats why i need you answer the above questions, not send me links |
| 14:55:23 | <k-joseph> dkayiwa: ok |
| 14:56:04 | *** cpower has joined #openmrs |
| 14:56:35 | <cpower> ahhh it's good to be back |
| 14:59:09 | <rafa> cpower: welcome back! :D |
| 15:00:26 | <cpower> Thanks Rafa...breaks are good now and then...I'm ready to get pumped and take on 2013! |
| 15:01:15 | <cpower> So let's go ahead and have a scrum just to get back in the routine. I'm not going to be suprised how the response goes |
| 15:01:54 | <cpower> !scrumon cpower |
| 15:01:54 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:02:12 | <cpower> Order: Rafa, dkayiwa, and anyone else |
| 15:02:40 | <rafa> Today: |
| 15:02:40 | <rafa> * Finished experimenting with RESTWS-310: RESTWS needs to keep an explicit registry of resources, which should be conditionally populated based on the OpenMRS version |
| 15:02:40 | <rafa> https://tickets.openmrs.org/browse/RESTWS-310 |
| 15:02:40 | <rafa> (added all my findings to the ticket, waiting for a review before going either way) |
| 15:02:40 | <rafa> * Started with META-142: Implement MetadataHandlers for the Reporting module |
| 15:02:40 | <rafa> https://tickets.openmrs.org/browse/META-142 |
| 15:02:40 | <rafa> No blockers. |
| 15:02:53 | <dkayiwa> IRC |
| 15:02:53 | <dkayiwa> Committed: If OBS section is not a concept field, error is not discovered until HL7 processing - TRUNK-215 |
| 15:02:54 | <dkayiwa> Now working on: Potential Memory Leak reported by Tomcat 7 - TRUNK-3056 |
| 15:02:54 | <dkayiwa> No Blockers |
| 15:03:32 | <cpower> anyone else? |
| 15:03:49 | <cpower> !scrumoff |
| 15:03:49 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:04:01 | <cpower> So anything interesting happen in the past week? |
| 15:04:36 | <rafa> cpower: we did some scrums without you ;) |
| 15:04:53 | <rafa> cpower: nothing that interesting |
| 15:04:54 | <cpower> well that's good |
| 15:05:50 | <cpower> You guys are the team, and things should go on with or without me. |
| 15:06:43 | <rafa> cpower: but still it's great to have you :D |
| 15:08:29 | <cpower> Nice to know I'm wanted :-) |
| 15:09:02 | <cpower> Now to figure out the mess of the sprints going forward |
| 15:13:50 | <dkayiwa> k-joseph: are still there? |
| 15:14:28 | <k-joseph> dkayiwa: yes |
| 15:14:43 | <dkayiwa> k-joseph: have you sent me the pastebin link? |
| 15:15:03 | <k-joseph> dkayiwa: not yet |
| 15:15:29 | <k-joseph> dkayiwa: http://pastebin.com/Rgy7P5UV |
| 15:17:26 | *** wyclif_ has joined #openmrs |
| 15:29:44 | *** dkayiwa has quit IRC |
| 15:32:04 | *** dkayiwa has joined #openmrs |
| 15:55:24 | *** rafa has quit IRC |
| 15:55:26 | *** basic has quit IRC |
| 15:56:57 | *** basic has joined #openmrs |
| 16:21:08 | <k-joseph> dkayiwa: i have sent the observations via email |
| 16:21:26 | <dkayiwa> k-joseph: ok let me check |
| 16:23:07 | <dkayiwa> hi k-joseph |
| 16:23:20 | <k-joseph> dkayiwa: hi |
| 16:23:54 | <dkayiwa> k-joseph: so validation is working for all other fields apart from only the description field. correct? |
| 16:24:21 | *** harshadura has joined #openmrs |
| 16:24:28 | <k-joseph> dkayiwa: yes, the error messages |
| 16:24:52 | <dkayiwa> k-joseph: so can you also make it to work for the description field too? |
| 16:25:27 | <k-joseph> dkayiwa: let me try what am thinking to |
| 16:25:43 | <dkayiwa> k-joseph: ok |
| 16:30:47 | *** akif has joined #openmrs |
| 16:34:12 | *** harshadura_ has joined #openmrs |
| 16:35:52 | *** harshadura has quit IRC |
| 16:37:42 | <k-joseph> dkayiwa: working out, pasted at http://pastebin.com/rFRXv4gn |
| 16:38:46 | <dkayiwa> k-joseph: how different is the validation fro description from that of isToA and isToB? |
| 16:42:15 | <k-joseph> dkayiwa: isToA and isToB show an error message, whereas description field if not filled give a message Description is required |
| 16:43:33 | *** suranga has joined #openmrs |
| 16:43:38 | <dkayiwa> k-joseph: from the end user's perspective, is there any difference in the validation requirements of the three fields? |
| 16:44:49 | <k-joseph> dkayiwa: i think, no difference |
| 16:45:29 | <dkayiwa> k-joseph: do why don't you do the description validation field in the exact same way as you have done for the other two? |
| 16:45:59 | <k-joseph> dkayiwa: let me do that |
| 17:01:49 | <akif> exit |
| 17:02:02 | *** akif has left #openmrs |
| 17:29:58 | *** harshadura_ has quit IRC |
| 17:48:18 | <k-joseph> dkayiwa: the error messages are now corresponding, paste at http://pastebin.com/5StvgN93 |
| 17:48:46 | <dkayiwa> k-joseph: checking |
| 17:49:22 | <dkayiwa> k-joseph: ok thats correct |
| 17:49:54 | <dkayiwa> k-joseph: how do the error messages look like in the browser? |
| 17:50:54 | <k-joseph> dkayiwa: like error.aIsToB.relationshipType.aIsToB error.bIsToA.relationshipType.bIsToA error.Description.relationshipType.description |
| 17:51:46 | <dkayiwa> k-joseph: can you make them as user friendly as the ones which were there before your changes? |
| 17:52:11 | <dkayiwa> k-joseph: that is the error messages |
| 17:52:25 | <k-joseph> dkayiwa: ok trying now |
| 17:52:30 | <dkayiwa> k-joseph: ok |
| 18:18:03 | *** travis-ci has joined #openmrs |
| 18:18:03 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [43c339c] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3896416 |
| 18:18:03 | *** travis-ci has left #openmrs |
| 18:18:06 | <OpenMRSBot> <http://ln-s.net/+NFU> (at travis-ci.org) |
| 18:23:28 | *** wyclif_ has quit IRC |
| 18:59:52 | <k-joseph> dkayiwa: tried to make the messages user friendly, all the three are of order or style, Enter B is to A to continue.relationshipType.bIsToA pasted at http://pastebin.com/U6EDMTBi |
| 19:00:38 | <dkayiwa> k-joseph: can you look at the validation you replaced in the controller? |
| 19:01:42 | <dkayiwa> k-joseph: are you there? |
| 19:01:42 | <k-joseph> dkayiwa: looking at it |
| 19:01:54 | <k-joseph> dkayiwa: yes am there |
| 19:02:04 | <dkayiwa> k-joseph: it resulted into user friendly error messages. |
| 19:02:13 | <dkayiwa> k-joseph: can you follow the same pattern? |
| 19:04:03 | <k-joseph> dkayiwa: same pattern!!!, to do what now? |
| 19:04:40 | <dkayiwa> k-joseph: did you see that the validation you replaced had user friendly error messages in the browser? |
| 19:05:19 | <k-joseph> dkayiwa: yes, forexample description is required |
| 19:05:35 | <dkayiwa> k-joseph: can you paste here just one of the validation lines your replaced? one for isToA |
| 19:06:55 | <k-joseph> dkayiwa: errors.rejectValue("bIsToA", "RelationshipType.bIsToA.required"); |
| 19:07:31 | <dkayiwa> k-joseph: so how do you think that translated into a user friendly error message? |
| 19:08:14 | <k-joseph> dkayiwa: not sure, |
| 19:08:40 | <dkayiwa> k-joseph: thats where you read about the method and you learn what its parameters mean |
| 19:09:15 | <dkayiwa> k-joseph: do you know what those parameters mean? |
| 19:10:12 | <dkayiwa> k-joseph: you can test it here: http://demo.openmrs.org/openmrs/admin/person/relationshipType.form |
| 19:10:12 | <k-joseph> dkayiwa:yes the ones for rejectIfEmptyOrWhitespace() |
| 19:10:20 | <dkayiwa> k-joseph: yes |
| 19:10:21 | *** wyclif_ has joined #openmrs |
| 19:13:07 | <k-joseph> dkayiwa: i wanted to eliminate the .relationshipType.bIsToA, but i did not know how? |
| 19:13:56 | <dkayiwa> k-joseph: can you answer my question first? |
| 19:17:23 | <k-joseph> dkayiwa: in the right order errors == the Errors instance to register errors, field == the field name to check and errorCod == error message |
| 19:18:04 | *** dkayiwa_ has joined #openmrs |
| 19:20:08 | *** dkayiwa has quit IRC |
| 19:20:08 | *** dkayiwa_ is now known as dkayiwa |
| 19:32:17 | *** Mkop has quit IRC |
| 19:43:16 | *** Mkop has joined #openmrs |
| 19:43:16 | *** ChanServ sets mode: +v Mkop |
| 19:53:08 | <k-joseph> dkayiwa: |
| 19:53:17 | <dkayiwa> k-joseph: |
| 19:54:05 | <k-joseph> dkayiwa: am having this order now for all the names and description A is to B name is required.relationshipType.aIsToB |
| 19:55:02 | <dkayiwa> k-joseph: can you pastebin |
| 19:55:45 | <k-joseph> dkayiwa: http://pastebin.com/RwdUgTtD |
| 19:56:33 | <dkayiwa> k-joseph: checking |
| 19:58:08 | <dkayiwa> k-joseph: did you answer my question? |
| 19:58:19 | <dkayiwa> k-joseph: or did you even see it? |
| 19:59:17 | <dkayiwa> k-joseph: are you there? |
| 19:59:21 | <k-joseph> dkayiwa: is it this do you know what those parameters mean?, i answered it |
| 19:59:36 | <dkayiwa> k-joseph: what was your answer? |
| 19:59:48 | <k-joseph> dkayiwa: yes, i do |
| 20:02:13 | <dkayiwa> k-joseph: what answer did you give? |
| 20:03:17 | <k-joseph> dkayiwa: in the right ordererrors == the Errors instance to register errors, field == the field name to check and errorCode == error message |
| 20:03:41 | <k-joseph> dkayiwa: == stands for mean |
| 20:04:11 | <dkayiwa> k-joseph: do you remember this which you replaced? errors.rejectValue("bIsToA", "RelationshipType.bIsToA.required"); |
| 20:04:22 | *** djazayeri has joined #openmrs |
| 20:04:22 | *** ChanServ sets mode: +o djazayeri |
| 20:04:48 | <k-joseph> dkayiwa: i do |
| 20:05:13 | <dkayiwa> k-joseph: which is the error message in the above? |
| 20:05:34 | <k-joseph> dkayiwa: RelationshipType.bIsToA.required |
| 20:05:49 | <dkayiwa> k-joseph: and what was displayed in the browser? |
| 20:06:42 | <k-joseph> dkayiwa: i think it was .bIsToA.required, just cant recall well |
| 20:07:24 | <dkayiwa> k-joseph: can you check it here? http://demo.openmrs.org/openmrs/admin/person/relationshipType.form |
| 20:08:45 | <k-joseph> dkaiwa: B is to A name is required |
| 20:09:02 | <k-joseph> dkayiwa: B is to A name is required |
| 20:09:11 | <dkayiwa> k-joseph: so how do you think they are related? |
| 20:10:27 | <k-joseph> dkayiwa: this one has just the error message while the one i have formed is having an extension of words |
| 20:10:44 | <k-joseph> dkayiwa: that am not establishing from where |
| 20:11:13 | <k-joseph> dkayiwa: and how to eliminate them |
| 20:12:24 | <k-joseph> dkayiwa: coming back soon |
| 20:12:34 | <dkayiwa> k-joseph: ok tell me when back |
| 20:12:42 | <k-joseph> dkayiwa: ok |
| 20:21:47 | *** djazayeri has quit IRC |
| 20:25:41 | *** djazayeri has joined #openmrs |
| 20:25:41 | *** ChanServ sets mode: +o djazayeri |
| 20:25:59 | *** djazayeri has quit IRC |
| 20:29:45 | <suranga> hi wyclif_ :-) |
| 20:37:20 | *** wyclif has joined #openmrs |
| 20:37:20 | *** wyclif_ has quit IRC |
| 20:48:36 | <k-joseph> dkayiwa: am back |
| 20:49:03 | <dkayiwa> k-joseph: can you look for messages.properties file? |
| 20:49:17 | <k-joseph> dkayiwa: ok |
| 20:50:34 | <k-joseph> dkayiwa: got it and opened it |
| 20:51:04 | <dkayiwa> k-joseph: can you look for the message code as in the original validator? |
| 20:52:52 | *** scsibug has quit IRC |
| 20:54:44 | <k-joseph> dkayiwa: can you please pardon for me, what you mean by as in the original validator? |
| 20:55:15 | <dkayiwa> k-joseph: the one which you replaced, which was showing user friendly messages in the browser |
| 21:02:42 | <k-joseph> dkayiwa: finally seen it |
| 21:03:11 | <dkayiwa> k-joseph: so now do you know how to correct your code? |
| 21:04:48 | <k-joseph> dkayiwa: still not sure how to correct it |
| 21:05:10 | <dkayiwa> k-joseph: do you know the use of the messages.properties file? |
| 21:05:27 | <k-joseph> dkayiwa: no |
| 21:07:04 | <dkayiwa> k-joseph: have you looked at this? https://wiki.openmrs.org/display/docs/Module+Messages.properties+files |
| 21:09:53 | <dkayiwa> hi suranga |
| 21:10:03 | <suranga> dkayiwa, howdy !!! |
| 21:10:14 | <suranga> dkayiwa, happy new year ! |
| 21:10:19 | <dkayiwa> suranga: do you know if Mykola is still alive? |
| 21:10:29 | <dkayiwa> suranga: oh thanks!!! The same to you. :) |
| 21:10:57 | <suranga> dkayiwa, i think hes busy with his studies... I havent talked to him in about 2 months, i think :( |
| 21:11:08 | <dkayiwa> suranga: ok |
| 21:11:21 | <suranga> dkayiwa, wasnt he supposed to be giving a talk on openmrs uni call ? |
| 21:11:47 | <dkayiwa> suranga: yes he was |
| 21:25:42 | <dkayiwa> k-joseph: are you there? |
| 21:26:00 | <k-joseph> dkayiwa: yes, |
| 21:26:17 | <dkayiwa> k-joseph: did you respond to my question? |
| 21:27:20 | <k-joseph> dkayiwa: has seen how to use the message.properties file and am trying to see how to use it for this purpose |
| 21:28:12 | <k-joseph> dkayiwa: i had nt looked at the [revious link you sent me and has just seen it |
| 21:29:08 | <k-joseph> dkayiwa: i mean i have now gone through it. complete |
| 21:29:40 | <dkayiwa> k-joseph: can you also read this? https://wiki.openmrs.org/display/docs/Localization+and+Languages |
| 21:32:07 | <dkayiwa> k-joseph: and this: https://wiki.openmrs.org/display/docs/How+To+Translate+OpenMRS+and+Modules |
| 21:36:11 | <k-joseph> dkayiwa: the last link is not available |
| 21:36:28 | <dkayiwa> k-joseph: try again |
| 21:36:38 | <k-joseph> dkayiwa: ok |
| 21:38:36 | *** djazayeri has joined #openmrs |
| 21:38:36 | *** ChanServ sets mode: +o djazayeri |
| 21:44:47 | *** wyclif has quit IRC |
| 21:54:41 | *** suranga has quit IRC |
| 21:58:37 | <k-joseph> dkayiwa: the last link has not openned, it is not found, but for the other ones i have finished going through them |
| 21:58:47 | <dkayiwa> k-joseph: ok |
| 22:06:02 | *** wyclif has joined #openmrs |
| 22:49:48 | *** dkayiwa has quit IRC |
| 23:45:56 | *** robbyoconnor has quit IRC |
| 23:53:18 | *** k-joseph has quit IRC |
