00:29:20
|
*** yony258 has quit IRC
|
00:31:44
|
*** tobin_g has quit IRC
|
02:53:34
|
*** k-joseph has quit IRC
|
04:59:12
|
*** k-joseph has joined #openmrs
|
05:03:26
|
*** k-joseph_ has joined #openmrs
|
05:06:11
|
*** k-joseph has quit IRC
|
05:22:40
|
*** k-joseph_ has quit IRC
|
05:33:06
|
*** k-joseph_ has joined #openmrs
|
05:57:41
|
*** dkayiwa has joined #openmrs
|
08:15:22
|
*** dkayiwa has quit IRC
|
08:43:03
|
*** robbyoconnor has quit IRC
|
08:45:26
|
*** robbyoconnor has joined #openmrs
|
08:45:26
|
*** ChanServ sets mode: +v robbyoconnor
|
08:50:59
|
*** robbyoconnor has quit IRC
|
08:59:31
|
*** robbyoconnor has joined #openmrs
|
08:59:31
|
*** ChanServ sets mode: +v robbyoconnor
|
09:56:11
|
*** robbyoconnor has quit IRC
|
10:52:25
|
*** pulasthi7 has joined #openmrs
|
10:57:30
|
*** harshadura has joined #openmrs
|
11:00:10
|
*** robbyoconnor has joined #openmrs
|
11:00:10
|
*** ChanServ sets mode: +v robbyoconnor
|
11:01:13
|
*** k-joseph has joined #openmrs
|
11:06:41
|
*** robbyoconnor has quit IRC
|
11:23:30
|
*** robbyoconnor has joined #openmrs
|
11:23:30
|
*** ChanServ sets mode: +v robbyoconnor
|
11:28:18
|
*** lh has joined #openmrs
|
11:28:18
|
*** lh has joined #openmrs
|
11:31:27
|
*** robbyoconnor has quit IRC
|
11:46:26
|
*** dkayiwa has joined #openmrs
|
11:49:49
|
<dkayiwa> hi k-joseph
|
11:53:13
|
<k-joseph> dkayiwa: hi
|
11:57:08
|
<dkayiwa> k-joseph: how is it going
|
11:58:46
|
<k-joseph> dkayiwa: still stranded on the previous issue, and has just been going through some practices
|
11:59:01
|
<dkayiwa> k-joseph: ok
|
12:15:28
|
*** lh has quit IRC
|
12:29:40
|
*** wyclif has quit IRC
|
12:30:01
|
*** harshadura has quit IRC
|
12:39:45
|
*** dkayiwa has quit IRC
|
14:08:56
|
*** rafa has joined #openmrs
|
14:08:56
|
*** ChanServ sets mode: +v rafa
|
14:13:15
|
*** rafa has quit IRC
|
14:16:59
|
*** pulasthi7 has quit IRC
|
14:29:19
|
*** pulasthi7 has joined #openmrs
|
14:36:02
|
*** k-joseph has quit IRC
|
14:36:24
|
*** k-joseph has joined #openmrs
|
15:27:48
|
*** yes has joined #openmrs
|
15:28:01
|
*** yes is now known as Guest43529
|
15:37:10
|
*** ndy40 has joined #openmrs
|
15:37:33
|
*** pulasthi7 has quit IRC
|
15:51:59
|
*** harshadura has joined #openmrs
|
16:01:09
|
*** robbyoconnor has joined #openmrs
|
16:01:09
|
*** ChanServ sets mode: +v robbyoconnor
|
16:04:42
|
*** dkayiwa has joined #openmrs
|
16:06:18
|
<dkayiwa> hi k-joseph
|
16:06:30
|
<k-joseph> dkayiwa: hi
|
16:07:14
|
<dkayiwa> k-joseph: how is it going?
|
16:10:17
|
<k-joseph> dkayiwa: ready now to do according to your advise about the previous blocker
|
16:11:11
|
<dkayiwa> k-joseph: ok
|
16:24:34
|
*** pulasthi7 has joined #openmrs
|
16:26:17
|
*** robbyoconnor has quit IRC
|
16:27:05
|
*** robbyoconnor has joined #openmrs
|
16:27:05
|
*** ChanServ sets mode: +v robbyoconnor
|
16:32:02
|
*** robbyoconnor has quit IRC
|
16:33:17
|
*** robbyoconnor has joined #openmrs
|
16:33:17
|
*** ChanServ sets mode: +v robbyoconnor
|
16:38:10
|
*** yony258 has joined #openmrs
|
16:39:29
|
<k-joseph> dkayiwa:
|
16:39:33
|
<dkayiwa> k-joseph:
|
16:40:31
|
<yony258> dkayiwa: (Hi I dont want to interrupt, Let me know when you have 5 minutes to explain something to me :) )
|
16:40:47
|
<dkayiwa> yony258: ok :)
|
16:45:06
|
*** Meths has joined #openmrs
|
16:57:14
|
<dkayiwa> yony258: ready :)
|
16:57:24
|
<yony258> dkayiwa: Ok :)
|
16:57:34
|
<yony258> dkayiwa: I think I figured what I needed
|
16:57:49
|
<dkayiwa> yony258: thats the beauty of delaying to respond :)
|
16:57:49
|
<yony258> dkayiwa: I didn't understood why adding &patientId=something worked
|
16:58:07
|
<yony258> dkayiwa: But it was implemented in the findPatient portal
|
16:58:30
|
<yony258> dkayiwa: Now I just need to add a url parameter using javascript but I think google can answer it
|
16:58:51
|
<yony258> dkayiwa: So I will ask another question
|
16:59:16
|
<yony258> dkayiwa: What is the convention for naming an extension point extension class and where am I supposed to put it?
|
17:00:38
|
<dkayiwa> yony258: you can look at the clinical summary module
|
17:01:08
|
<yony258> dkayiwa: Can you send a link please? (its not important but can save some time :) )
|
17:01:31
|
<dkayiwa> yony258: http://code.google.com/p/clinical-summary/
|
17:01:55
|
<yony258> dkayiwa: Thank you!
|
17:57:25
|
<dkayiwa> hi k-joseph
|
17:57:34
|
<k-joseph> dkayiwa: hi
|
17:57:50
|
<dkayiwa> k-joseph: how is it going?
|
17:58:29
|
<k-joseph> dkayiwa: still stack about TRUNK-3814
|
17:58:42
|
<dkayiwa> k-joseph: did you do as per my email?
|
17:59:38
|
<k-joseph> dkayiwa: had yet seen that, am doing that right now
|
18:21:18
|
*** djazayeri has joined #openmrs
|
18:21:18
|
*** ChanServ sets mode: +o djazayeri
|
18:37:14
|
*** ndy40 has quit IRC
|
18:51:01
|
*** pulasthi7 has quit IRC
|
18:55:40
|
<k-joseph> dkayiwa: the two classes http://pastebin.com/Cj43vuW9
|
18:55:58
|
<dkayiwa> k-joseph: ok
|
18:56:46
|
<dkayiwa> k-joseph: have you changed the validator from yesterday's pastebin?
|
18:57:55
|
<k-joseph> dkayiwa: i have just changed a fiew things in the validator, but all the classes are on that same link
|
18:59:20
|
<dkayiwa> k-joseph: why did you change?
|
19:00:30
|
<k-joseph> dkayiwa: no good reason, i was still checking for the impact of the change
|
19:01:30
|
<dkayiwa> k-joseph: so which should i take?
|
19:02:05
|
<k-joseph> dkayiwa: yesturdays paste
|
19:02:52
|
<dkayiwa> k-joseph: but thats not what your code is currently
|
19:03:04
|
<dkayiwa> k-joseph: send me another pastebin link
|
19:03:59
|
<dkayiwa> k-joseph: but it should be a copy and paste of your code as it should currently be
|
19:04:56
|
<k-joseph> dkayiwa: ok it is, http://pastebin.com/bAKvddwV
|
19:05:38
|
<dkayiwa> k-joseph: is this how your code is currently?
|
19:05:49
|
<k-joseph> dkayiwa: is
|
19:06:22
|
<dkayiwa> k-joseph: meaning???
|
19:07:06
|
<k-joseph> dkayiwa: that is the current code
|
19:07:26
|
<k-joseph> dkayiwa: in eclpise
|
19:07:46
|
<dkayiwa> k-joseph: so now and you respond as per my email?
|
19:12:25
|
<k-joseph> dkayiwa: not yet fully establisheded a change on the Relationship Type Form,
|
19:12:49
|
<dkayiwa> k-joseph: did you read my email well?
|
19:14:59
|
<dkayiwa> k-joseph: or did you understand it?
|
19:15:16
|
<k-joseph> dkayiwa: i have been addressing this part: Then test the effects in the browser,
|
19:16:16
|
<dkayiwa> k-joseph: so you can you pastebin the changes you have done as per my email?
|
19:24:41
|
<k-joseph> dkayiwa: lines 63 to 78 of http://pastebin.com/3xTRrnXv
|
19:25:27
|
<dkayiwa> k-joseph: did you do as per my email?
|
19:27:23
|
<k-joseph> dkayiwa: yes
|
19:27:46
|
<dkayiwa> k-joseph: can you rephrase what you did in a sentence?
|
19:28:29
|
<k-joseph> dkayiwa: i replaced the validation with my validator
|
19:28:49
|
<k-joseph> dkayiwa: that is before form submit
|
19:29:21
|
<dkayiwa> k-joseph: can you paste that replacement here?
|
19:30:21
|
<k-joseph> dkayiwa: do you mean what i replaced with or my replacement
|
19:30:39
|
<dkayiwa> k-joseph: your replacement
|
19:31:08
|
<k-joseph> new RelationshipTypeValidator().validate(type, errors);
|
19:31:08
|
<k-joseph> ValidationUtils.rejectIfEmptyOrWhitespace(errors, "aIsToB", "error.aIsToB");
|
19:31:08
|
<k-joseph> ValidationUtils.rejectIfEmptyOrWhitespace(errors, "bIsToA", "error.bIsToA");
|
19:31:08
|
<k-joseph>
|
19:31:53
|
<dkayiwa> k-joseph: is new RelationshipTypeValidator().validate(type, errors); doing anything different from the two lines below it?
|
19:32:32
|
<k-joseph> dkayiwa: i think so
|
19:32:44
|
<dkayiwa> k-joseph: and what is it?
|
19:33:25
|
<k-joseph> dkayiwa: i think it is validating for type
|
19:33:40
|
<dkayiwa> k-joseph: you are not sure of what its doing?
|
19:33:57
|
<dkayiwa> k-joseph: yet you wrote it?
|
19:34:18
|
<k-joseph> dkayiwa: yes, not sure, you had included it in the mail
|
19:34:45
|
<dkayiwa> k-joseph: are you the one who wrote the class? RelationshipTypeValidator
|
19:34:58
|
<k-joseph> dkayiwa: no
|
19:35:13
|
<k-joseph> dkayiwa: sorry yes
|
19:35:29
|
<k-joseph> dkayiwa: i wrote it,
|
19:35:31
|
<dkayiwa> k-joseph: and you do not know what you put in the class does?
|
19:35:48
|
*** yony258 has quit IRC
|
19:36:50
|
*** djazayeri has quit IRC
|
19:37:08
|
*** wyclif has joined #openmrs
|
19:38:41
|
<k-joseph> dkayiwa: for that line, you advised me to add it in your email or else i mis-understood what you were meaning
|
19:39:14
|
<dkayiwa> k-joseph: it creates a new instance of your class (if you remember the new operator)
|
19:39:28
|
<dkayiwa> k-joseph: and then calls the validate method on this new instance
|
19:39:35
|
<dkayiwa> k-joseph: is it now clear?
|
19:39:46
|
<k-joseph> dkayiwa: yes
|
19:40:17
|
<dkayiwa> k-joseph: so have you thought of any change you can make now?
|
19:40:27
|
<dkayiwa> k-joseph: in the controller?
|
19:42:02
|
<dkayiwa> k-joseph: in otherwards, do you think you now understand my email?
|
19:42:15
|
<dkayiwa> k-joseph: are you there?
|
19:42:20
|
<k-joseph> dkayiwa: am getting it now
|
19:42:41
|
<dkayiwa> k-joseph: can you pastebin for me now?
|
19:50:15
|
<k-joseph> dkayiwa: http://pastebin.com/MenvfUzr
|
20:06:16
|
*** wyclif has quit IRC
|
20:20:02
|
<dkayiwa> hi k-joseph
|
20:24:14
|
*** wyclif has joined #openmrs
|
20:25:19
|
*** dkayiwa_ has joined #openmrs
|
20:25:26
|
<dkayiwa_> hi k-joseph
|
20:26:45
|
*** dkayiwa has quit IRC
|
20:26:45
|
*** dkayiwa_ is now known as dkayiwa
|
20:43:44
|
*** wyclif has quit IRC
|
20:44:08
|
*** r0bby has joined #openmrs
|
20:44:08
|
*** ChanServ sets mode: +v r0bby
|
20:45:27
|
*** robbyoconnor has quit IRC
|
20:47:38
|
*** wyclif has joined #openmrs
|
20:57:44
|
*** dkayiwa has quit IRC
|
20:59:49
|
*** r0bby is now known as robbyoconnor
|
21:08:37
|
*** dkayiwa has joined #openmrs
|
21:08:44
|
<dkayiwa> hi k-joseph
|
21:09:19
|
*** dehrg has joined #openmrs
|
21:22:18
|
*** djazayeri has joined #openmrs
|
21:22:18
|
*** ChanServ sets mode: +o djazayeri
|
21:30:35
|
*** dkayiwa has quit IRC
|
21:37:21
|
*** rafa has joined #openmrs
|
21:37:21
|
*** ChanServ sets mode: +v rafa
|
21:49:05
|
*** yony258 has joined #openmrs
|
21:49:49
|
<yony258> Hi, wanted to ask for some help on how to add links to MinimalHeader and FullHeader, it seems a bit more complicated than a normal extension point
|
21:56:11
|
*** rafa has quit IRC
|
22:09:03
|
*** dehrg has quit IRC
|
22:27:00
|
*** wyclif_ has joined #openmrs
|
22:27:00
|
*** wyclif has quit IRC
|
22:45:04
|
*** djazayeri has quit IRC
|
22:54:38
|
*** yony258 has quit IRC
|