| 00:31:48 | *** wyclif_ has quit IRC |
| 01:05:11 | *** wyclif has joined #openmrs |
| 03:21:17 | *** djazayeri has quit IRC |
| 03:29:56 | *** djazayeri has joined #openmrs |
| 03:29:56 | *** ChanServ sets mode: +o djazayeri |
| 04:32:18 | *** djazayeri has quit IRC |
| 05:26:03 | *** djazayeri has joined #openmrs |
| 05:26:03 | *** ChanServ sets mode: +o djazayeri |
| 06:34:00 | *** djazayeri has quit IRC |
| 09:56:40 | *** rafa has joined #openmrs |
| 09:56:40 | *** ChanServ sets mode: +v rafa |
| 10:06:45 | *** rafa has quit IRC |
| 10:29:18 | *** girish has joined #openmrs |
| 10:47:47 | *** pulasthi7 has joined #openmrs |
| 13:15:50 | *** pulasthi7 has quit IRC |
| 14:36:44 | *** rafa has joined #openmrs |
| 14:36:44 | *** ChanServ sets mode: +v rafa |
| 14:47:11 | *** rafa has quit IRC |
| 16:06:28 | *** suranga has joined #openmrs |
| 16:06:28 | *** ChanServ sets mode: +v suranga |
| 17:05:05 | *** tobin_g has joined #openmrs |
| 17:05:14 | <tobin_g> hi suranga |
| 17:05:43 | <tobin_g> hi wyclif |
| 17:08:15 | <tobin_g> hi robbyoconnor time for a quick question? |
| 17:32:30 | *** dkayiwa has joined #openmrs |
| 17:32:57 | <tobin_g> dkayiwa: as we say here after shabbat shavua tov |
| 17:32:57 | <tobin_g> ] |
| 17:33:08 | <dkayiwa> tobin_g: hahahah :) |
| 17:33:37 | <tobin_g> dkayiwa: means good week - since the week is just startign |
| 17:34:41 | <tobin_g> dkayiwa: time for a quick question? |
| 17:34:47 | <dkayiwa> tobin_g: ok |
| 17:35:05 | <tobin_g> I need to make a very simple module that will insert a link up on the patient dashboard in the header area |
| 17:35:28 | <tobin_g> dkayiwa: do I need to do this with an extension point? |
| 17:35:37 | <tobin_g> dkayiwa: sorry didn't tag u in the previous line |
| 17:35:52 | <dkayiwa> tobin_g: yes |
| 17:37:24 | <tobin_g> dkayiwa: and since I want it on the header, I just need to pick one from here? https://github.com/openmrs/openmrs-core/blob/master/webapp/src/main/webapp/WEB-INF/template/headerFull.jsp |
| 17:37:30 | <OpenMRSBot> <http://ln-s.net/+Mb+> (at github.com) |
| 17:38:01 | <dkayiwa> tobin_g: do you mean like the "Form Entry" tab? |
| 17:38:48 | <tobin_g> dkayiwa: no i mean to put a link up higher on the page |
| 17:39:00 | <tobin_g> dkayiwa: to the right of the patients' name |
| 17:40:02 | <tobin_g> dkayiwa: the situation is that our OpenMRS is running in parallel with another system. we want to provide a link like http://theothersystem/search.asp?patientid=123435 so that OpenMRS users can easily go between |
| 17:40:29 | <dkayiwa> tobin_g: do you have like a mockup for it? |
| 17:41:05 | <tobin_g> dkayiwa: gimme about 90 seconds and I will :) |
| 17:41:13 | <dkayiwa> tobin_g: ok :) |
| 17:43:50 | <tobin_g> dkayiwa: http://snag.gy/SVzBI.jpg |
| 17:44:01 | <tobin_g> dkayiwa: that big red button at the top that says TEREM should be a link to the other system |
| 17:44:37 | <dkayiwa> tobin_g: ok |
| 17:45:27 | *** yony258 has joined #openmrs |
| 17:46:36 | <tobin_g> dkayiwa: yony258 has been kind enough to help me! |
| 17:46:44 | <tobin_g> dkayiwa: so he came on to hear your wisdom :D |
| 17:46:47 | <yony258> dkayiwa: Hi ! |
| 17:46:54 | <dkayiwa> tobin_g: yony258 lolllllll hi |
| 17:46:56 | <dkayiwa> :) |
| 17:47:04 | <tobin_g> yony258: this is the mockup i sent to dkayiwa http://snag.gy/SVzBI.jpg |
| 17:47:07 | <yony258> dkayiwa: Hope to show you what we have done with the module :) |
| 17:47:11 | <yony258> dkayiwa: sure ok |
| 17:47:24 | <tobin_g> yony258: he said we are correct in that we have to use an extension point, i've been looking for the right hook in the code but not exactly found yet |
| 17:47:34 | <dkayiwa> yony258: oh i have been seeing the commits flying around like ligthening :) |
| 17:47:48 | <tobin_g> dkayiwa: what they've done is AWESOME |
| 17:47:51 | <yony258> dkayiwa: Yea :P it looks good too (we started using Datatables.net) |
| 17:47:53 | <tobin_g> dkayiwa: i love the datatables.net |
| 17:47:56 | <tobin_g> dkayiwa: lol |
| 17:48:12 | <dkayiwa> tobin_g: oh those tables are stinking sweet!!! :) |
| 17:48:15 | <tobin_g> dkayiwa: i'm spending my night making LOTS of new tickets to get started on! it's almost a functional module |
| 17:48:20 | <tobin_g> dkayiwa: SO sweet. |
| 17:54:24 | <tobin_g> dkayiwa: it seems that the extensionpoint we may be looking for is on this page, what do you think? https://github.com/openmrs/openmrs-core/blob/master/webapp/src/main/webapp/WEB-INF/view/portlets/patientHeader.jsp |
| 17:54:27 | <OpenMRSBot> <http://ln-s.net/+MbU> (at github.com) |
| 17:55:24 | <dkayiwa> tobin_g: looks very promissing |
| 17:56:54 | <tobin_g> yony258: do you understand how to use this whole extension point thing? |
| 17:58:30 | <yony258> tobin_g: Hmm, I didnt got 100% into it yet since im also working on a big assignment, but its similar to the AdminList.java we did and the wiki describes how to do that. |
| 17:59:19 | <tobin_g> yony258: ok. seems like the place to insert (the extension point to use) is probably about line 83 in https://github.com/openmrs/openmrs-core/blob/master/webapp/src/main/webapp/WEB-INF/view/portlets/patientHeader.jsp |
| 17:59:20 | <OpenMRSBot> <http://ln-s.net/+MbU> (at github.com) |
| 18:00:54 | <yony258> tobin_g: dkayiwa what is the "parameters" in the extension point? What do I do with it? |
| 18:01:32 | *** k-joseph has joined #openmrs |
| 18:02:01 | <k-joseph> hi every one |
| 18:02:03 | <k-joseph> dkayiwa: hi |
| 18:02:03 | <dkayiwa> yony258: looks like that exact location may not have an extension point |
| 18:02:07 | <dkayiwa> k-joseph: hi |
| 18:02:45 | <k-joseph> dkayiwa: welcome back, though it looks late from then |
| 18:03:57 | <tobin_g> dkayiwa: based on the wiki i thought that extension points are defined with <openmrs:extensionPointpointIdâ¦.> no? |
| 18:04:19 | <dkayiwa> k-joseph: thanks |
| 18:04:45 | <dkayiwa> tobin_g: yes |
| 18:05:40 | <tobin_g> dkayiwa: so why isn't that place an extension point? |
| 18:06:08 | <dkayiwa> tobin_g: never thought one would need extend it |
| 18:06:29 | <tobin_g> dkayiwa: sorry don't understand |
| 18:09:38 | <tobin_g> dkayiwa: i'm basically trying to inject a hyperlink into this general area of the code, suggestions of where i can do that? |
| 18:10:14 | <dkayiwa> tobin_g: i do not think we have an extension point for that |
| 18:10:57 | <dkayiwa> tobin_g: am looking at patientDashboardForm.jsp |
| 18:12:53 | <tobin_g> dkayiwa: ok. it's possible that i don't really understand what an extensionpoint is. i thought they were places in the code where you can insert code? |
| 18:14:40 | <dkayiwa> tobin_g: yes |
| 18:14:54 | <tobin_g> dkayiwa: so why wouldn't the original one that i found work again? |
| 18:15:36 | <dkayiwa> tobin_g: extension points are at places where we thought one would need to extend some aspect of openmrs |
| 18:15:55 | <dkayiwa> tobin_g: where we did not think one would love to extend, we never provides extension points |
| 18:16:23 | <tobin_g> dkayiwa: ok, but line 83 in https://github.com/openmrs/openmrs-core/blob/master/webapp/src/main/webapp/WEB-INF/view/portlets/patientHeader.jsp appears to be an extension point, right? |
| 18:16:24 | <OpenMRSBot> <http://ln-s.net/+MbU> (at github.com) |
| 18:16:27 | <dkayiwa> tobin_g: so in that case you would start with a ticket requesting for core openmrs to provide an extension point for that |
| 18:17:36 | <dkayiwa> tobin_g: oh, you could be right. i need to examine it more closely :) |
| 18:18:19 | <tobin_g> dkayiwa: ok if you have a moment i'd really appreciate it so I know if i'm looking at this correctly. |
| 18:20:52 | <dkayiwa> tobin_g: ok |
| 18:22:14 | <k-joseph> dkayiwa: is this close to the expected work: commited at https://github.com/k-joseph/openmrs-core/commit/af29bdf26c037e09cdababe340054e29865e80ff |
| 18:22:17 | <OpenMRSBot> <http://ln-s.net/+Mc5> (at github.com) |
| 18:22:32 | <dkayiwa> k-joseph: checking.... |
| 18:22:41 | <k-joseph> dkayiwa: ok |
| 18:23:40 | <dkayiwa> k-joseph: did you intentionally change anything in RelationshipType.java? |
| 18:23:51 | <k-joseph> dkayiwa: yes |
| 18:23:58 | <dkayiwa> k-joseph: why? |
| 18:24:36 | <k-joseph> dkayiwa: i had to make the String variables accessible to the validator |
| 18:26:05 | <dkayiwa> k-joseph: is the validation for "aIsToB" different from that for "name"? |
| 18:27:13 | <k-joseph> dkayiwa: yes |
| 18:27:23 | <dkayiwa> k-joseph: how? |
| 18:29:03 | <k-joseph> dkayiwa: am testing for aIsToB, that should be valid otherwise, name should be valid then |
| 18:29:47 | <dkayiwa> k-joseph: am not sure i understand |
| 18:30:08 | <dkayiwa> k-joseph: can you explain from an end user's perspective? |
| 18:30:17 | <dkayiwa> k-joseph: like you did yersterday |
| 18:31:58 | <k-joseph> dkayiwa: ok, am thinking that we are to get the input for aIsToB, check whether if it is not null or not correct |
| 18:32:35 | <dkayiwa> k-joseph: what do you mean by not correct? |
| 18:33:44 | <k-joseph> dkayiwa: i mean input data not being correct then that of name, either way the user's input can pass be validated |
| 18:34:02 | <dkayiwa> k-joseph: when is input data not correct |
| 18:34:14 | <dkayiwa> k-joseph: you need to be specific by what you mean by not correct |
| 18:34:21 | <dkayiwa> k-joseph: does not correct mean it is too long? |
| 18:34:32 | <dkayiwa> k-joseph: does it mean its a letter instead of number? |
| 18:34:40 | <dkayiwa> k-joseph: what exactly do you mean by not correct |
| 18:34:50 | <dkayiwa> k-joseph: do not beat about the bush please!!! |
| 18:35:15 | <k-joseph> dkayiwa: if all required fields have proper values |
| 18:35:28 | <dkayiwa> k-joseph: what are proper values? |
| 18:35:51 | <dkayiwa> k-joseph: do proper values mean numbers, letters, etc or what? |
| 18:36:08 | <k-joseph> dkayiwa: yes, corresponding data types |
| 18:36:46 | <dkayiwa> k-joseph: so is the validator for name testing whether the entered value is for correct data type? |
| 18:37:16 | <k-joseph> dkayiwa: in this case, it should be a String |
| 18:37:41 | <dkayiwa> k-joseph: is that what the VisitType validator testing for the "name" field? |
| 18:38:32 | <k-joseph> dkayiwa: i think so |
| 18:39:53 | <dkayiwa> k-joseph: which like number is that in the VisitType validator? |
| 18:40:19 | <dkayiwa> like = ;ine |
| 18:40:22 | <dkayiwa> line |
| 18:40:56 | <k-joseph> dkayiwa: 59 |
| 18:41:11 | <dkayiwa> k-joseph: can you paste that line here? |
| 18:43:16 | <k-joseph> dkayiwa: ValidationUtils.rejectIfEmptyOrWhitespace(errors, "name", "error.name"); |
| 18:43:54 | <dkayiwa> k-joseph: so you mean the purpose of ValidationUtils.rejectIfEmptyOrWhitespace() is to test whether the "name" field is of type string? |
| 18:44:42 | <k-joseph> dkayiwa: whether name is null |
| 18:44:54 | <k-joseph> dkayiwa: or has no input |
| 18:45:16 | <k-joseph> dkayiwa: i have got it, i think i dont need that |
| 18:45:18 | <dkayiwa> k-joseph: now i do not know which to take because you are telling me two different and opposite things |
| 18:46:53 | <k-joseph> dkayiwa: i now think it is unneccessary to say am testing for datatype, besides that could nt be the code to do that? |
| 18:47:27 | <dkayiwa> k-joseph: the ticket is very clear on what you need to ensure? |
| 18:47:59 | <dkayiwa> k-joseph: do you understand the requirement on the ticket? |
| 18:49:09 | <k-joseph> dkayiwa: to write the validator and include tests for whether aIsToB and bIs |
| 18:49:25 | <dkayiwa> k-joseph: for whether what? |
| 18:49:41 | <k-joseph> dkayiwa: bIsToA is null |
| 18:50:15 | <dkayiwa> k-joseph: is that the same as the validation for "name"? or is it different? |
| 18:50:49 | <k-joseph> dkayiwa: the same, |
| 18:50:55 | <dkayiwa> k-joseph: ok |
| 18:52:55 | <k-joseph> dkayiwa: so now looking at that, excluding the else statements, could the rest code be valid with such a knowledge behind |
| 18:53:56 | <dkayiwa> k-joseph: do what you think and use pastebin.com to show me |
| 18:54:10 | <dkayiwa> k-joseph: we shall make the pull request only after approval |
| 18:54:19 | <k-joseph> dkayiwa: ok |
| 18:54:36 | <dkayiwa> k-joseph: am trying to avoid making too many unnecesary pull requests |
| 18:55:02 | <k-joseph> dkayiwa: that is better |
| 19:03:55 | *** suranga_ has joined #openmrs |
| 19:04:10 | <k-joseph> dkayiwa: http://pastebin.com/vq8TuPeA |
| 19:05:27 | <dkayiwa> k-joseph: is "name" validation different from the "bIsToA" validation? |
| 19:06:44 | <k-joseph> dkayiwa: no, the same idea is in my mind while doing that |
| 19:07:01 | <dkayiwa> k-joseph: and how is "name" validation done? |
| 19:07:25 | *** suranga has quit IRC |
| 19:07:32 | *** suranga__ has joined #openmrs |
| 19:08:29 | <k-joseph> dkayiwa: like, ValidationUtils.rejectIfEmptyOrWhitespace(errors, "name", "error.name"); |
| 19:09:00 | <dkayiwa> k-joseph: what is the reason why your validation is different from that? |
| 19:10:44 | <k-joseph> dkayiwa: this requires me to re implement that method in ValidateUtil.java which is against your last comment on the pull request |
| 19:11:37 | <dkayiwa> k-joseph: does the name validation implement a method in ValidateUtil? |
| 19:11:52 | *** suranga_ has quit IRC |
| 19:13:20 | <k-joseph> dkayiwa: no, ok disproved my own idea |
| 19:22:56 | <dkayiwa> hi tobin_g yony258 |
| 19:23:14 | <tobin_g> hi dkayiwa, i think yony258 is out for a bit |
| 19:23:37 | <dkayiwa> tobin_g: i was looking at this moduel: http://code.google.com/p/clinical-summary/source/browse/trunk/clinicalsummary/metadata/config.xml?r=3 |
| 19:23:42 | <OpenMRSBot> <http://ln-s.net/+Md6> (at code.google.com) |
| 19:24:01 | <dkayiwa> tobin_g: in particular the @MODULE_PACKAGE@.extension.html.SummaryDashboardHeaderExt |
| 19:24:41 | <tobin_g> dkayiwa: uh huh |
| 19:24:43 | <dkayiwa> tobin_g: you can look at the image here: http://wiki.jembi.org/index.php?title=BIRT_Patient_Summary |
| 19:24:48 | <OpenMRSBot> <http://ln-s.net/+Md$> (at wiki.jembi.org) |
| 19:25:02 | <dkayiwa> tobin_g: that is for another module but same extension point |
| 19:25:25 | <yony258> dkayiwa: tobin_g http://wiki.jembi.org/images/2/2b/View_Patient_Summary.PNG |
| 19:25:26 | <OpenMRSBot> <http://ln-s.net/+Md+> (at wiki.jembi.org) |
| 19:25:38 | <tobin_g> dkayiwa: see that :) |
| 19:25:47 | <tobin_g> dkayiwa: just need to find that class file and take a look what's in there |
| 19:26:14 | <tobin_g> dkayiwa: i'm guessing it's not on git? |
| 19:26:38 | <dkayiwa> tobin_g: for this class? BirtPatientDashboardHeaderExt |
| 19:27:02 | <tobin_g> SummaryDashboardHeaderExt I think |
| 19:27:07 | <tobin_g> dkayiwa: oh yeah |
| 19:27:15 | <tobin_g> dkayiwa: BirtPatientDashboardHeaderExt |
| 19:29:28 | <k-joseph> dkayiwa: http://pastebin.com/gKsQV525 will be back shortely |
| 19:30:00 | <dkayiwa> tobin_g: should look like this: http://code.google.com/p/clinical-summary/source/browse/trunk/api/src/main/java/org/openmrs/module/clinicalsummary/extension/html/SummaryDashboardHeaderExt.java |
| 19:30:02 | <OpenMRSBot> <http://ln-s.net/+MdF> (at code.google.com) |
| 19:30:31 | <dkayiwa> k-joseph: just tell me when back |
| 19:30:52 | <k-joseph> dkayiwa: ok |
| 19:31:06 | <tobin_g> dkayiwa: BINGO thank you very much! |
| 19:31:21 | <tobin_g> dkayiwa: I'd gotten close but had a little difference which this cleared up for me :) worked like a charm |
| 19:31:44 | <dkayiwa> tobin_g: i trust your experience now :) |
| 19:31:54 | <tobin_g> dkayiwa: I guess necessity is truly the mother innovation. who would have thought little ol' me be makin' modules |
| 19:32:23 | <dkayiwa> tobin_g: are you now coding???? :) |
| 19:32:48 | <tobin_g> dkayiwa: wellâ¦.i did just make a little module that adds the link I want :) |
| 19:33:01 | <dkayiwa> tobin_g: wowwwwwwwwwww :D |
| 19:33:29 | <dkayiwa> tobin_g: you also need to answer yourself the email you sent to the dev list and say you have done it yourself :) |
| 19:33:40 | <tobin_g> dkayiwa: actually let's be fairâ¦it's adding the link without the ID number so far |
| 19:33:43 | <tobin_g> dkayiwa: will do :) |
| 19:33:57 | <dkayiwa> tobin_g: sure |
| 19:35:28 | <tobin_g> dkayiwa: I may come back to you for help getting the ID number to behave how I need but I'll try on my own first! |
| 19:35:28 | *** wyclif has quit IRC |
| 19:35:37 | *** wyclif has joined #openmrs |
| 19:35:56 | <dkayiwa> tobin_g: ok. thats a good way to start :) |
| 19:36:48 | *** suranga__ has quit IRC |
| 19:38:03 | <yony258> tobin_g: So you just need to add the patientId to the URL ? |
| 19:38:28 | <tobin_g> yony258: yup, turns out i'm more clever than i thought |
| 19:38:37 | <dkayiwa> tobin_g: :D |
| 19:38:44 | <yony258> tobin_g: tobin_g ++ |
| 19:39:03 | <dkayiwa> yony258: i doubt if he received that :) |
| 19:39:07 | <dkayiwa> tobin_g++ |
| 19:39:12 | <yony258> tobin_g++ |
| 19:39:30 | <yony258> tobin_g: Do you need help adding the correct identifier? |
| 19:39:38 | <tobin_g> dkayiwa: yony258 thanks |
| 19:39:54 | <tobin_g> yony258: i think so, let me send my email to the dev list then i'll check in with you |
| 19:40:07 | <yony258> tobin_g: ok :) |
| 19:41:17 | <yony258> tobin_g: You will need to teach me how to use an extension point :D |
| 19:41:30 | <tobin_g> yony258: ok that I think I can do |
| 19:41:47 | <yony258> tobin_g: We can add a link to the appointment management form |
| 19:42:14 | <yony258> tobin_g: Anyway let me go back to my recommender system :/ |
| 19:42:30 | <yony258> tobin_g: Let me know if you need anything |
| 19:42:38 | <tobin_g> yony258: ok thank you very much |
| 19:43:38 | <yony258> dkayiwa: |
| 19:43:39 | <yony258> http://i.snag.gy/eLDSv.jpg |
| 19:43:46 | <yony258> dkayiwa: Just a small screenshot :D |
| 19:44:14 | <dkayiwa> yony258: wowwwwwwwwwwww. so sweet :D |
| 19:44:37 | <yony258> dkayiwa: Would've never get this far without your help :) Thank you |
| 19:44:54 | <dkayiwa> yony258: but you did those tables yourself |
| 19:45:03 | <dkayiwa> yony258: infact you do then better than i :) |
| 19:45:26 | <yony258> dkayiwa: Just a function of time :D |
| 19:45:51 | <dkayiwa> yony258: nice mathematics :D |
| 19:46:02 | <yony258> (tobin_g: By the way I said thanks to the devs of Datatables.net (http://datatables.net/forums/discussion/comment/43346) |
| 19:46:07 | <OpenMRSBot> <http://ln-s.net/+MdS> (at datatables.net) |
| 19:46:17 | <yony258> tobin_g: And donated a $ :P |
| 19:46:30 | <tobin_g> yony258: wow good man! |
| 19:46:46 | <tobin_g> yony258: that's awesome :) |
| 19:47:02 | <dkayiwa> yony258: kindest heart i have seen in this IRC :D |
| 19:47:12 | <yony258> tobin_g: They deserve more but im still a student :P |
| 19:47:29 | <dkayiwa> yony258: a dollar counts |
| 19:47:45 | <yony258> dkayiwa: True :) |
| 19:47:58 | <dkayiwa> yony258: remember a million students - a dollar each :) |
| 19:48:25 | <yony258> dkayiwa: A million students that know when to say "Thanks" thats important :D |
| 19:48:31 | <tobin_g> yony258: how do i donate? |
| 19:48:45 | <yony258> tobin_g: There is a link at the top of www.datatables.net |
| 19:48:51 | <dkayiwa> yony258: hahahahha. you win!!!! :) |
| 19:48:57 | <tobin_g> yony258: ok on the list to do. |
| 19:48:57 | <yony258> tobin_g: http://www.datatables.net/donate |
| 19:49:04 | <yony258> tobin_g: :) |
| 19:49:21 | <yony258> tobin_g: They are also the devs of TableTools (the export & printing widget) |
| 19:49:37 | <tobin_g> yony258: yeah that's nifty too |
| 19:51:10 | <k-joseph> dkayiwa: |
| 19:51:42 | <dkayiwa> k-joseph: can you test your validation in the webapp? |
| 19:51:55 | <k-joseph> dkayiwa: ok |
| 19:53:59 | <tobin_g> yony258: ok so now you get to help me! |
| 19:54:17 | <yony258> tobin_g: Awesome! |
| 19:54:21 | <tobin_g> So I'm getting the patientID through the extension point. |
| 19:54:22 | <yony258> tobin_g: Bring it on |
| 19:54:56 | <yony258> tobin_g: but u need the Parpar identifier, right? |
| 19:55:02 | <tobin_g> yony258: I think i need to use that and return a patientidentifier of a particular type |
| 19:55:05 | <tobin_g> yony258: yup |
| 19:55:25 | <yony258> tobin_g: Ok are we talking about client side (JSP) or server side(java) ? |
| 19:55:36 | <tobin_g> yony258: server side |
| 19:55:46 | <yony258> tobin_g: Awesome so that is easy |
| 19:55:56 | <tobin_g> yony258: love it |
| 19:56:13 | <yony258> tobin_g: Do you have a global property that says which patientIdentifier ID is the Parpar one? |
| 19:56:19 | <yony258> tobin_g: Or do you want to hard code it? |
| 19:57:17 | <tobin_g> yony258: just hard code is fine |
| 19:57:30 | <yony258> tobin_g: ok |
| 19:57:44 | <yony258> tobin_g: let me do it at on my machine and guide u |
| 19:57:48 | <yony258> tobin_g: it will take 5 minutes |
| 19:57:51 | <yony258> tobin_g: or less |
| 19:58:06 | <tobin_g> yony258: k no prob. and i'm also making sure i actually know how to get the patientId |
| 19:58:23 | <yony258> tobin_g: We can also do it by the identifier name |
| 19:58:35 | <yony258> tobin_g: Which is better than identifier id :) |
| 19:59:00 | <tobin_g> yony258: why is it better? it's super long and annoying in this case |
| 19:59:43 | <yony258> tobin_g: Correct but if you will need to reinstall the system and the Parpar identifier will get a different identifier id than your module won't work anymore. |
| 20:00:01 | <yony258> tobin_g: But if u will assign the identifier the same name it will work. |
| 20:00:20 | <tobin_g> yony258: let's go on ID, i doubt they'd put the name the same to be honest |
| 20:00:44 | <yony258> tobin_g: Your call :) |
| 20:00:59 | <tobin_g> yony258: eventually i'll put it in a global property |
| 20:01:12 | <tobin_g> yony258: i guess we could just do that know as you suggested |
| 20:02:09 | <yony258> tobin_g: sorry what? |
| 20:02:32 | <tobin_g> yony258: let's go ahead and put the identifier id into a global property then it will be flexible |
| 20:03:45 | <yony258> tobin_g: Ok do you need that i'll tell you how? |
| 20:04:20 | <yony258> tobin_g: https://wiki.openmrs.org/display/docs/Setting+and+Reading+Global+Properties |
| 20:04:36 | <yony258> tobin_g: If you aren't sure how to do that than check in this guide |
| 20:04:46 | <tobin_g> yony258: ok i can do that, i did it once before |
| 20:05:15 | <tobin_g> yony258: give me a couple minutes and I'll get that setup and also verify that I in fact have the patientId working? |
| 20:07:44 | <yony258> tobin_g: ok |
| 20:07:56 | <tobin_g> yony258: got the id working, just gimme a minute to get the globalproperty setup |
| 20:09:46 | <yony258> tobin_g: Ok |
| 20:10:47 | <yony258> tobin_g: http://pastebin.com/dKLkQ0sA |
| 20:11:21 | <yony258> tobin_g: Change the string to the name of the global property |
| 20:12:16 | <tobin_g> yony258: k i'll get there in a sec |
| 20:20:49 | <tobin_g> yony258: did you mean getPatients as opposed to getPatient? |
| 20:21:18 | <yony258> tobin_g: Where? |
| 20:21:39 | <tobin_g> line 5 |
| 20:21:52 | <tobin_g> yony258: line 5 my eclipse doesn't seem to be happy with getPatient |
| 20:22:03 | <yony258> tobin_g: What is it saying? |
| 20:22:22 | <yony258> tobin_g: It have to be getPatient |
| 20:22:49 | <tobin_g> yony258: oh i see the problem, i'm passing it a string should send it an integer |
| 20:22:56 | <yony258> tobin_g: :) |
| 20:34:48 | <yony258> tobin_g: How's it going? |
| 20:35:03 | <tobin_g> yony258: tinkerin |
| 20:35:10 | <yony258> tobin_g: Does it works? |
| 20:35:44 | <tobin_g> yony258: not yet but i'm just going through it real slow to understand everything first |
| 20:35:56 | <yony258> tobin_g: Ok, anyway im on |
| 20:36:01 | <tobin_g> yony258: i have practically no experience with object oriented so i'm learning |
| 20:36:06 | <tobin_g> yony258: thanks |
| 20:36:10 | <yony258> tobin_g: Send any questions im totally free |
| 20:36:16 | <tobin_g> yony258: thanks |
| 20:36:21 | <tobin_g> yony258: shortly! |
| 20:36:27 | <yony258> tobin_g: Cool |
| 20:38:51 | <tobin_g> yony258: syntax problem. PatientIdentifier identifier = patient.getPatientIdentifier(identifierId); and my eclipse is saying that the ; should be a { |
| 20:39:25 | <yony258> tobin_g: Hmm, my eclipse says its ok |
| 20:39:33 | <yony258> tobin_g: Paste bin the whole thing |
| 20:39:52 | <yony258> tobin_g: You are probably missing a ) or a ; or a } or { |
| 20:39:52 | <tobin_g> yony258: grrr. did that. |
| 20:40:02 | <tobin_g> yony258: ok will check |
| 20:41:15 | <tobin_g> yony258: what imports do i need for this? |
| 20:41:28 | <yony258> tobin_g: Click ctrl+shift+o |
| 20:41:36 | <yony258> tobin_g: It will import what needed automatically |
| 20:41:52 | <tobin_g> yony258: nifty |
| 20:41:59 | <tobin_g> yony258: had all the right ones |
| 20:42:17 | <yony258> tobin_g: paste bin the whole thing |
| 20:42:39 | <tobin_g> yony258: i think i got it, it's something down below that was affecting this line lemme figure out where one sed |
| 20:47:07 | <tobin_g> yony258: the problem is something with the if statement. eclipse is throwing a fit about it |
| 20:47:27 | <yony258> tobin_g: I cant do anything without knowing what is the error / seeing the pastebin |
| 20:47:43 | <tobin_g> yony258: Syntax error on token(s), misplaced construct(s) |
| 20:47:46 | <tobin_g> yony258: i'll pastebin |
| 20:48:18 | <tobin_g> yony258: http://pastebin.com/tqbJdr0n |
| 20:49:43 | <tobin_g> yony258: http://stackoverflow.com/questions/6655113/syntax-error-on-token-if-invalid-annotationname |
| 20:49:45 | <OpenMRSBot> <http://ln-s.net/+Mep> (at stackoverflow.com) |
| 20:50:11 | <yony258> tobin_g: Try to remove the comment near the if |
| 20:50:30 | <tobin_g> yony258: nope |
| 20:51:08 | <yony258> tobin_g: Can you screen share? |
| 20:51:21 | <tobin_g> yony258: sure i'll go to skype |
| 21:29:41 | *** scsibug has joined #openmrs |
| 21:38:51 | <dkayiwa> hi wyclif |
| 22:50:44 | *** dkayiwa has quit IRC |
