IRC Chat : 2012-12-28 - OpenMRS

01:02:57 *** yony258 has quit IRC
02:08:28 *** djazayeri has quit IRC
02:27:20 *** upul` has quit IRC
03:57:28 *** djazayeri has joined #openmrs
03:57:28 *** ChanServ sets mode: +o djazayeri
04:40:11 *** kishoreyekkanti has joined #openmrs
05:35:24 <robbyoconnor> Hey all :)
06:18:00 *** djazayeri has quit IRC
06:49:06 *** hudayanga has joined #openmrs
06:59:38 *** dkayiwa has joined #openmrs
07:05:52 *** hudayanga has quit IRC
07:27:25 *** hudayanga has joined #openmrs
07:54:35 <hudayanga> hi all
07:59:32 <hudayanga> dkayiwa: i'm working for this ticket ,https://tickets.openmrs.org/browse/TRUNK-2758 i want some explanation and how the request be linked i'm a new beginner to openMRS
08:09:50 *** hudayanga has left #openmrs
08:34:26 *** hudayanga has joined #openmrs
09:10:51 *** dkayiwa has quit IRC
09:11:23 *** dkayiwa has joined #openmrs
09:11:29 <dkayiwa> hi hudayanga
09:17:29 *** wyclif has quit IRC
09:25:57 <hudayanga> dkayiwa: hi
09:26:53 <dkayiwa> hudayanga: how are you today?
09:27:20 <hudayanga> dkayiwa: fine..thanx..you?
09:27:35 <dkayiwa> hudayanga: good here too
09:27:40 <dkayiwa> hudayanga: how is the coding?
09:28:36 <hudayanga> dkayiwa: i'm new to open mrs i want your guidance...how to start my trunk
09:28:59 <dkayiwa> hudayanga: have you already cloned openmrs-core?
09:29:11 <hudayanga> dkayiwa: yes
09:29:19 <dkayiwa> hudayanga: and have you run it?
09:29:36 <hudayanga> dkayiwa: yes..i run it in fedora...
09:30:07 <hudayanga> dkayiwa: its working correcty
09:30:07 <dkayiwa> hudayanga: so you can do things like create a new patient, etc?
09:30:30 <hudayanga> dkayiwa: yes i already create patients..
09:31:23 <dkayiwa> hudayanga: have you first of all been able to reproduce the problem on the ticket?
09:31:42 <hudayanga> dkayiwa: yes
09:32:01 <dkayiwa> hudayanga: do you have an idea on how to fix it?
09:32:06 <hudayanga> dkayiwa: i want some explanation about problem..
09:32:16 <hudayanga> dkayiwa: no
09:33:39 <dkayiwa> hudayanga: have you seen the line of code where it happens?
09:34:12 <hudayanga> dkayiwa: yup as they mentioned i go trough that line
09:34:56 <hudayanga> dkayiwa: but the thing is i cant understand realy how it happen?
09:35:35 <dkayiwa> hudayanga: how does that line look like? can you paste it here?
09:36:01 <hudayanga> dkayiwa: ok
09:39:16 <hudayanga> dkayiwa: public PatientIdentifierType getPatientIdentifierTypeByUuid(String uuid) {
09:39:16 <hudayanga> return (PatientIdentifierType) sessionFactory.getCurrentSession().createQuery(
09:39:16 <hudayanga> "from PatientIdentifierType pit where pit.uuid = :uuid").setString("uuid", uuid).uniqueResult();
09:39:16 <hudayanga> }
09:39:36 <dkayiwa> hudayanga: i mean just the one line where the exception happens
09:41:37 <hudayanga> dkayiwa: i cant undertand where it happend?
09:41:44 <dkayiwa> hudayanga: ok
09:41:56 <dkayiwa> hudayanga: on which version of openmrs did you reproduce this problem?
09:43:39 <hudayanga> dkayiwa: i cloned latest version..
09:43:55 <dkayiwa> hudayanga: and how did you reproduce the problem?
09:44:51 <hudayanga> dkayiwa: i run the project..i coldnt find that error ?
09:45:16 <dkayiwa> hudayanga: you told me that you were able to reproduce the problem
09:46:02 <hudayanga> dkayiwa: i think its mean go trouth the code...sorry for that
09:46:29 <dkayiwa> hudayanga: first step for a ticket is reproduce the problem as an end user (not code)
09:46:47 <hudayanga> dkayiwa: yes
09:46:59 <dkayiwa> hudayanga: if you have not been able to reproduce the problem, then you have no way of telling whether what you have done fixes it or not
09:47:17 <dkayiwa> hudayanga: so do you think you can reproduce the problem as an end user?
09:47:32 <hudayanga> dkayiwa: yes
09:47:51 <dkayiwa> hudayanga: how have you reproduced it?
09:48:34 <hudayanga> dkayiwa: i cant understand how to reproduce
09:49:44 <dkayiwa> hudayanga: can you mention that on the ticket?
09:50:19 <hudayanga> dkayiwa: as a comment?
09:50:25 <dkayiwa> hudayanga: yes
09:50:41 <hudayanga> dkayiwa: ok
09:52:48 <dkayiwa> hudayanga: after adding the comment, you can un assign yourself from the ticket and choose another
09:54:15 <hudayanga> dkayiwa: but i like to do this..if you can give me guidance how to reproduce?
09:56:17 <dkayiwa> hudayanga: from the stack trace, it started from the blood bank module
09:56:47 <dkayiwa> hudayanga: since that module is not in the public module repository, i have no way of reproducing it
09:58:21 <hudayanga> dkayiwa: ok thank you.
09:59:42 <hudayanga> dkayiwa:can you tel me a ticket..its suitable for begginer?
10:00:35 <dkayiwa> hudayanga: let me check
10:00:51 <dkayiwa> hudayanga: have you looked at all the beginner tickets?
10:01:35 <hudayanga> dkayiwa: no..
10:01:44 <dkayiwa> hudayanga: can you look at them now?
10:02:02 <hudayanga> dkayiwa: ok
10:05:42 *** k-joseph has joined #openmrs
10:05:45 <hudayanga> dkayiwa: you mean Introductory Tickets no?
10:05:51 <k-joseph> dkayiwa: hi
10:05:51 <dkayiwa> hudayanga: yes
10:05:57 <dkayiwa> k-joseph: hi
10:08:08 <hudayanga> dkayiwa: How can i find suitable one?
10:08:35 <dkayiwa> hudayanga: can you give me the url for all the tickets and i look through?
10:09:18 <hudayanga> dkayiwa: https://tickets.openmrs.org/secure/IssueNavigator.jspa?mode=hide&requestId=10068
10:09:19 <OpenMRSBot> <http://ln-s.net/8d9E> (at tickets.openmrs.org)
10:15:40 <dkayiwa> hudayanga: can you look at? TRUNK-3335
10:15:45 <dkayiwa> !ticket TRUNK-3335
10:15:46 <OpenMRSBot> dkayiwa: [#TRUNK-3335] Retired Provider Attribute Types should not be shown when adding/editing providers - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3335
10:16:42 <hudayanga> dkayiwa: ok thank you
10:17:05 <dkayiwa> hudayanga: first step is ensure you can reproduce the problem as an end user
10:17:22 <dkayiwa> k-joseph: how is it going?
10:18:19 <hudayanga> dkayiwa: yes
10:24:58 <hudayanga> dkayiwa: thank you for kind guidance after i reproduce the code i'll contact you when i got trouble...thank you
10:25:18 <dkayiwa> hudayanga: you are welcome. thanks too for your hard work!!!
10:27:28 *** hudayanga has quit IRC
10:34:21 <k-joseph> dkayiwa:hi
10:34:30 <dkayiwa> k-joseph: hi
10:34:47 <k-joseph> from the update email, i would like you to first of help me to push changes, i need a git
10:34:47 <k-joseph> command that i can use to push changes to git hub, i have tried using git push and git push -f for
10:34:47 <k-joseph> several times and it failing,
10:36:01 <dkayiwa> k-joseph: changes for which ticket?
10:36:32 <k-joseph> dkayiwa: TRUNK-3814-3
10:36:52 <k-joseph> dkayiwa: had added details according to you advise
10:37:41 <k-joseph> dkayiwa: on your previous comments, you and wluyima
10:37:56 <dkayiwa> k-joseph: what error do you get when you try git push
10:38:27 <k-joseph> error: src refspec refs/heads/TRUNK-3814:git@github.com does not match any.
10:38:27 <k-joseph> error: src refspec refs/heads/TRUNK-3814 does not match any.
10:38:27 <k-joseph> error: failed to push some refs to 'git@github.com:k-joseph/openmrs-core.git'
10:38:53 <dkayiwa> k-joseph: what is your checked out branch?
10:39:17 <k-joseph> dkayiwa: TRUNK-3814-3
10:39:43 <dkayiwa> k-joseph: what is the exact command you are executing
10:40:00 <k-joseph> dkayiwa: git push
10:40:20 <dkayiwa> k-joseph: when you do git branch
10:40:27 <dkayiwa> k-joseph: which one is marked with a start
10:40:29 <dkayiwa> star
10:41:06 <k-joseph> dkayiwa: * TRUNK-3814-3
10:41:30 <dkayiwa> k-joseph: is TRUNK-3814 listed?
10:41:40 <k-joseph> dkayiwa: no
10:41:47 <dkayiwa> k-joseph: thats strange
10:41:54 <dkayiwa> k-joseph: can you try checkout master
10:42:08 <dkayiwa> k-joseph: then checkout the branch and try again to commit
10:42:22 <k-joseph> dkayiwa: ok
10:43:54 <k-joseph> dkayiwa: still getting the same error
10:44:07 <dkayiwa> k-joseph: strange
10:44:26 <dkayiwa> k-joseph: may be try creating a new branch and put your changes there
10:44:50 <k-joseph> dkayiwa: ok
11:04:46 <k-joseph> dkayiwa: could you please still help me undestand what you meant by your last comment on the pull request, i beg your pardon
11:04:58 <dkayiwa> k-joseph: what was it?
11:05:20 <k-joseph> dkayiwa:We do not normally do this from the validator. We instead let the database throw an exception.
11:06:51 <dkayiwa> k-joseph: what i meant is that do not check for duplicates
11:06:58 <dkayiwa> k-joseph: the database will take care of that
11:08:25 *** dkayiwa has quit IRC
11:09:36 *** dkayiwa has joined #openmrs
11:10:38 <k-joseph> dkayiwa: so then, do you mean it was unneccessary to implement rejectIfDuplicateMetadataName()
11:11:07 <dkayiwa> k-joseph: yes
11:11:31 <dkayiwa> k-joseph: you can look at other validators like VisitTypeValidator and you see that they have no such checks
11:11:52 <k-joseph> dkayiwa: ok,
11:19:48 <k-joseph> dkayiwa: am going to comment out its implentation and commit so that you can have a look at that and see whether it was you want, how about wluyima's comment: use RelationshipType.class.isAssignableTo(c),
11:20:12 <dkayiwa> k-joseph: yes will look at it
11:22:04 <k-joseph> dkayiwa: for me to add this code as a return statement it required me to replace isAssignableTo(c) with isAssignableFrom(c), could you please comment on this so that the commit can include all those requirements
11:22:36 <k-joseph> dkayiwa: i mean wyclif comment
11:22:39 <dkayiwa> k-joseph: am not sure of what he meant
11:23:21 <k-joseph> dkayiwa: ok then, am now commiting these changes ones only
11:23:28 <dkayiwa> k-joseph: ok
11:26:29 *** kishoreyekkanti has quit IRC
11:30:36 <k-joseph> dkayiwa: commit url https://github.com/k-joseph/openmrs-core/commit/576e2f6684014e38b95b30b16f54871acfc4ba54
11:30:41 <OpenMRSBot> <http://ln-s.net/+MBz> (at github.com)
11:30:42 <dkayiwa> k-joseph: ok
11:32:16 <k-joseph> dkayiwa: used block comments
11:32:26 <dkayiwa> k-joseph: ok
12:09:57 *** dkayiwa has quit IRC
12:11:26 *** dkayiwa has joined #openmrs
12:12:27 *** dkayiwa has quit IRC
12:14:22 *** dkayiwa has joined #openmrs
12:17:39 <k-joseph> dkayiwa:
13:00:58 *** k-joseph_ has joined #openmrs
13:01:41 *** k-joseph has quit IRC
13:02:08 *** k-joseph_ is now known as k-joseph
13:26:50 *** rkorytkowski has joined #openmrs
13:26:50 *** ChanServ sets mode: +v rkorytkowski
13:27:03 *** rkorytkowski is now known as rafa
13:34:54 <dkayiwa> k-joseph:
13:35:15 <k-joseph> dkayiwa: hi
13:35:23 <dkayiwa> k-joseph: hi
13:36:05 <k-joseph> dkayiwa: did you see the commit, and if yes, is it what you wanted?
13:36:19 <dkayiwa> k-joseph: not yet
13:37:18 <k-joseph> dkayiwa: please, check so that i can push the overall commit
13:37:33 <dkayiwa> k-joseph: ok
13:37:54 <k-joseph> dkayiwa: thank you
13:49:45 <dkayiwa> k-joseph: i have put a comment on the commit
13:49:54 <k-joseph> dkayiwa: ok
13:53:43 <k-joseph> dkayiwa: no, according to what i have known from you, now am going to eliminate the whole method under the comments and finally do a commit, will send you the commit url soon
13:54:10 <dkayiwa> k-joseph: ok
14:30:56 <dkayiwa> rafa: are you familiar with the xstream serialization module?
14:31:35 <rafa> dkayiwa: to some extend
14:33:57 <dkayiwa> rafa: am running the reporting module, and for report definitions, it serializes only name and description. Do you know how i can make it also serialize the "creator" and "dateCreated" fields?
14:35:21 <rafa> dkayiwa: hmm don't know
14:35:27 <dkayiwa> rafa: ok
14:51:22 <k-joseph> dkayiwa: hi
14:51:28 <dkayiwa> k-joseph: hi
14:51:31 <k-joseph> dkayiwa: commit at https://github.com/k-joseph/openmrs-core/commit/TRUNK-3814-3
14:51:36 <OpenMRSBot> <http://ln-s.net/+MFE> (at github.com)
14:51:41 <dkayiwa> k-joseph: ok
14:52:45 <dkayiwa> k-joseph: in this commit i see code for checking duplicate names
14:52:57 <dkayiwa> k-joseph: i thought you removed it
14:54:03 *** wyclif has joined #openmrs
14:57:50 <k-joseph> dkayiwa: check out https://github.com/k-joseph/openmrs-core/commit/TRUNK-3814-3
14:57:51 <OpenMRSBot> <http://ln-s.net/+MFE> (at github.com)
14:58:54 <dkayiwa> k-joseph: so can you create a new clean commit with only the stuff we need?
14:59:11 <k-joseph> dkayiwa: fine
15:02:46 <dkayiwa> hi k-joseph
15:02:54 <k-joseph> dkayiwa: hi
15:03:05 <dkayiwa> k-joseph: did you look at the VisitTypeValidator?
15:03:25 <k-joseph> dkayiwa: yes
15:03:40 <dkayiwa> k-joseph: what validations does it do?
15:04:18 <dkayiwa> k-joseph: look at the code and tell me what validations it does (assume am simply an end user instead of a coder)
15:04:36 <k-joseph> dkayiwa: ok
15:08:40 *** hudayanga has joined #openmrs
15:09:57 <rafa> dkayiwa: wyclif: hey
15:10:01 <rafa> scrum?
15:10:06 <wyclif> rafa, sure
15:10:13 <rafa> !scrumon rafa
15:10:13 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster rafa- you may begin when ready.
15:10:22 <rafa> wyclif, me and dkayiwa
15:10:34 <rafa> go ahead wyclif :)
15:11:30 <wyclif> Thursday:
15:11:30 <wyclif> emails
15:11:30 <wyclif> reviewing and applying pull requests
15:11:30 <wyclif> REPORT-166 - Ensure that all date-based queries are appropriately handling boundary conditions
15:11:30 <wyclif>
15:11:31 <wyclif> Friday:
15:11:33 <wyclif> reviewing and applying pull requests
15:11:35 <wyclif> pick another sprint ticket
15:11:37 <wyclif>
15:11:39 <wyclif> Blockers: None
15:11:41 <rafa> !ticket REPORT-166
15:11:42 <OpenMRSBot> rafa: [#REPORT-166] Ensure that all date-based queries are appropriately handling boundary conditions - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-166
15:11:55 <rafa> Today:
15:11:55 <rafa> * Continued with RESTWS-310: RESTWS needs to keep an explicit registry of resources, which should be conditionally populated based on the OpenMRS version (need yes or no for a different approach I want to take)
15:11:55 <rafa> https://tickets.openmrs.org/browse/RESTWS-310
15:11:55 <rafa> No blockers.
15:12:02 <dkayiwa> IRC
15:12:02 <dkayiwa> Working on: New creator and created values are not appearing for any of the reporting objects from the UI on OpenMRS 1.9 - REPORT-416
15:12:02 <dkayiwa> No Blockers
15:12:35 <rafa> !ticket REPORT-416
15:12:36 <OpenMRSBot> rafa: [#REPORT-416] New creator and created values are not appearing for any of the reporting objects from the UI on OpenMRS 1.9 - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-416
15:13:09 <rafa> !scrumoff
15:13:09 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:13:18 <k-joseph> dkayiwa: hi
15:13:22 <dkayiwa> k-joseph: hi
15:16:18 <k-joseph> dkayiwa: VisitTypeValidator valiadtes attributes like oject name input on the visitType form
15:16:49 <dkayiwa> k-joseph: can you rephrase that in a more user friendly way?
15:17:39 <dkayiwa> k-joseph: for instead if an end user was trying to create a visit type, and the validator fails them, how would you tell them to correct the data entery error such that the validator is happy?
15:18:55 <dkayiwa> k-joseph: you can try yourself to create a visit type on the openmrs web app
15:19:23 <k-joseph> dkayiwa: like fill in the name attribute, description, otherwise failure, am trying that
15:20:19 <dkayiwa> k-joseph: can you be exact and mention only what the validator does?
15:21:33 <k-joseph> dkayiwa: it confirms whether the input data corresponds with the constraints
15:22:00 <dkayiwa> k-joseph: you would tell that to the end user? and they ask, what do you mean by constraints?
15:23:01 <dkayiwa> k-joseph: you mentioned description, which line in the visitType validator deals with description?
15:24:10 <k-joseph> dkayiwa: was just giving an example, other wise it is not implemented
15:24:47 <dkayiwa> k-joseph: i do not want an example. i would like you to be exact from the end user's perspective
15:25:33 <dkayiwa> k-joseph: the end user is trying to create a visitType, the validator fails him/her, how do you tell them to correct the error to make this exact validator happy?
15:26:21 <k-joseph> dkayiwa: coonstraints, am meaning specifications that must be fullfilled in order for the validation to pass, so i would
15:26:34 <dkayiwa> k-joseph: be exact
15:26:42 <dkayiwa> k-joseph: am an end user.
15:27:07 <dkayiwa> k-joseph: am an end user asking you what specifications are those you are talking about?
15:27:40 <k-joseph> dkayiwa: name must be etered
15:27:55 <dkayiwa> k-joseph: thats all i needed!!!
15:28:19 <k-joseph> dkayiwa: still with no errors
15:28:26 <dkayiwa> k-joseph: so as simpler as that, can you make the same exact validation for isToA and isToB?
15:28:34 <dkayiwa> simpler = simple
15:29:14 <k-joseph> dkayiwa: ok
15:30:59 <dkayiwa> k-joseph: thats all for me today. will get back online tomorrow night
15:31:43 <k-joseph> dkayiwa: ok thanks alot, am working on that now and you will meet the commit tomorrow
15:31:53 <dkayiwa> k-joseph: ok thanks
15:31:55 *** dkayiwa has left #openmrs
15:32:25 *** k-joseph has quit IRC
15:34:21 *** rafa has quit IRC
15:53:36 *** hudayanga has quit IRC
15:55:13 *** basic has quit IRC
15:55:49 *** basic has joined #openmrs
16:04:39 *** mccallumg has joined #openmrs
16:04:39 *** ChanServ sets mode: +v mccallumg
16:09:34 *** mccallumg has quit IRC
16:24:19 *** KiLLeR has joined #openmrs
16:26:11 <KiLLeR> Hi i would like to contribute towards the organization for gsoc 2013 . Can anyone help me on how to proceed ???
16:32:32 *** KiLLeR has quit IRC
16:34:57 *** djazayeri has joined #openmrs
16:34:57 *** ChanServ sets mode: +o djazayeri
16:50:41 *** KiLLeR has joined #openmrs
16:52:08 <KiLLeR> Hi , iwould like to contribute towards openMrs as a developer , so can any one help me on how to proceed
16:52:11 *** mccallumg has joined #openmrs
16:52:11 *** ChanServ sets mode: +v mccallumg
16:52:16 <KiLLeR> ??
16:56:09 *** mccallumg_ has joined #openmrs
16:56:09 *** ChanServ sets mode: +v mccallumg_
16:56:10 *** mccallumg has quit IRC
16:56:11 *** mccallumg_ is now known as mccallumg
17:05:33 *** KiLLeR has quit IRC
17:40:11 *** bhashitha has joined #openmrs
17:40:27 <bhashitha> Hi
17:40:42 <bhashitha> I'm new bee to openmrs
17:42:10 <bhashitha> I just edit JSP file inside openmrs-webapp/src/main/webapp/WEB-INF/view directory
17:43:07 <bhashitha> now when I reload the browser, empty page is diaplaying
17:43:31 <bhashitha> Do I need to mvn clean build after editing JSP files ?
17:45:08 *** djazayeri has quit IRC
17:58:58 *** djazayeri has joined #openmrs
17:58:58 *** ChanServ sets mode: +o djazayeri
18:49:04 *** bhashitha has quit IRC
18:56:37 *** suranga has joined #openmrs
18:56:37 *** ChanServ sets mode: +v suranga
18:59:53 <suranga> hi djazayeri , could you please change the status of https://tickets.openmrs.org/browse/TRUNK-3773 so that I can claim it ? :)
19:53:48 *** djazayeri has quit IRC
19:54:59 *** djazayeri has joined #openmrs
19:54:59 *** ChanServ sets mode: +o djazayeri
19:56:19 <suranga> djazayeri, thanks :)
20:28:08 *** suranga_ has joined #openmrs
20:32:00 *** suranga has quit IRC
21:01:02 *** wyclif_ has joined #openmrs
21:01:03 *** wyclif has quit IRC
21:11:00 *** mccallumg has quit IRC
21:24:59 *** suranga_ has quit IRC
21:30:16 *** mccallumg has joined #openmrs
21:30:16 *** ChanServ sets mode: +v mccallumg
21:58:56 *** mccallumg has quit IRC