| 00:49:57 | *** jkeiper has joined #openmrs |
| 00:49:57 | *** ChanServ sets mode: +v jkeiper |
| 01:34:18 | *** jkeiper has quit IRC |
| 02:06:28 | *** harshadura has joined #openmrs |
| 03:09:07 | *** harshadura has quit IRC |
| 04:38:44 | *** kishoreyekkanti has joined #openmrs |
| 04:54:28 | *** dkayiwa has joined #openmrs |
| 06:12:18 | *** dkayiwa has quit IRC |
| 07:26:11 | *** kavuri has joined #openmrs |
| 07:46:47 | *** kishoreyekkanti has quit IRC |
| 08:00:49 | *** dkayiwa has joined #openmrs |
| 08:02:15 | *** dkayiwa has quit IRC |
| 08:14:41 | *** kishoreyekkanti has joined #openmrs |
| 08:15:19 | *** kishoreyekkanti has joined #openmrs |
| 09:01:15 | *** kavuri has quit IRC |
| 10:43:32 | *** kavuri has joined #openmrs |
| 10:45:52 | *** kavuri has quit IRC |
| 11:11:43 | *** tobing_g has joined #openmrs |
| 11:34:37 | *** tobing_g has quit IRC |
| 12:07:28 | *** k-joseph has joined #openmrs |
| 13:24:14 | *** k-joseph_ has joined #openmrs |
| 13:25:07 | *** k-joseph has quit IRC |
| 13:40:28 | *** wyclif has joined #openmrs |
| 13:47:06 | *** k-joseph_ has quit IRC |
| 14:01:51 | *** kishoreyekkanti has quit IRC |
| 14:10:07 | *** k-joseph has joined #openmrs |
| 14:25:48 | *** harshadura has joined #openmrs |
| 14:31:36 | *** bhashitha has joined #openmrs |
| 14:47:29 | *** harshadura has quit IRC |
| 14:52:57 | *** dkayiwa has joined #openmrs |
| 15:33:08 | <k-joseph> dkayiwa: hi |
| 15:35:16 | *** cpower has joined #openmrs |
| 15:35:38 | <cpower> Just checking in folks, how's everyone doing? |
| 15:37:41 | <cpower> ahh the warming silence of an IRC chat hard at work |
| 15:46:54 | *** jblaya has joined #openmrs |
| 15:58:31 | <dkayiwa> k-joseph: hi |
| 15:58:48 | <dkayiwa> cpower: doing great. and you? :) |
| 16:31:50 | *** kishoreyekkanti has joined #openmrs |
| 16:36:37 | *** jblaya has quit IRC |
| 16:40:31 | *** bhashitha has quit IRC |
| 17:05:03 | *** dkayiwa has quit IRC |
| 17:05:56 | *** dkayiwa has joined #openmrs |
| 17:15:26 | <k-joseph> dkayiwa:dkayiwa: hi |
| 17:15:34 | <dkayiwa> k-joseph: hi |
| 17:17:02 | <k-joseph> dkayiwa: i claimed TRUNK-3255 |
| 17:17:19 | <dkayiwa> k-joseph: did you finish all work on the previous one? |
| 17:17:55 | <k-joseph> dkayiwa: some parts were tricky for me |
| 17:18:02 | <dkayiwa> k-joseph: like which? |
| 17:18:49 | <k-joseph> dkayiwa: like, It should have basic validation added (aIsToB and bIsToA need to be set). |
| 17:19:14 | <dkayiwa> k-joseph: did you attempt to do what you think about it? |
| 17:19:28 | <k-joseph> dkayiwa: yes |
| 17:19:35 | <dkayiwa> k-joseph: did you push? |
| 17:20:17 | <k-joseph> dkayiwa: yes, https://tickets.openmrs.org/browse/TRUNK-3814 the last comment |
| 17:20:30 | <dkayiwa> k-joseph: looking now |
| 17:20:41 | <k-joseph> dkayiwa: ok |
| 17:23:43 | <dkayiwa> k-joseph: is the last pull request url correct? |
| 17:24:06 | <k-joseph> dkayiwa: let me confirm that |
| 17:25:37 | <k-joseph> dkayiwa: the last one: https://github.com/k-joseph/openmrs-core/commit/24e34593dcdf2a30f3c1fe148387bd33f7eb3e42 |
| 17:25:42 | <OpenMRSBot> <http://ln-s.net/+LlA> (at github.com) |
| 17:25:49 | <dkayiwa> k-joseph: i mean the pull request url? |
| 17:27:13 | <k-joseph> dkayiwa: yes, concider the last one on the list, thats the one i last did |
| 17:27:35 | <dkayiwa> k-joseph: is the 160 pull request url correct? |
| 17:29:45 | <k-joseph> dkayiwa: how are you reading the 160 number? |
| 17:30:15 | <dkayiwa> k-joseph: i mean it is of a different format from the other pull request urls |
| 17:30:21 | <dkayiwa> k-joseph: don't you notice it? |
| 17:33:36 | <k-joseph> dkayiwa: i have noticed that, ok, concider the 160, it,s fine |
| 17:34:34 | <dkayiwa> k-joseph: edit and correct it |
| 17:36:43 | <k-joseph> dkayiwa: how exactly, is it by again going through pull request!! |
| 17:37:05 | <dkayiwa> k-joseph: can you look at the other pull request urls on the same ticket? |
| 17:38:09 | <k-joseph> dkayiwa: seen them, they end with a number, like 160 at the end of the url |
| 17:48:06 | <dkayiwa> k-joseph: have you done the editing? |
| 17:48:32 | <k-joseph> dkayiwa: yes |
| 17:49:29 | <dkayiwa> k-joseph: on the ticket? |
| 17:49:55 | <k-joseph> dkayiwa: ok, am now doing that |
| 17:51:19 | <k-joseph> dkayiwa: am throght |
| 17:51:29 | <dkayiwa> k-joseph: checking |
| 17:52:26 | <dkayiwa> k-joseph: has that pull request have the aIsToB and bIsToA validation? |
| 17:53:12 | <k-joseph> dkayiwa: yes, |
| 17:53:19 | <dkayiwa> k-joseph: ok looking |
| 17:55:18 | <dkayiwa> k-joseph: i do not see it. which commit url |
| 17:55:32 | <k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/blob/24e34593dcdf2a30f3c1fe148387bd33f7eb3e42/api/src/main/java/org/openmrs/validator/RelationshipTypeValidator.java |
| 17:55:38 | <OpenMRSBot> <http://ln-s.net/+Lla> (at github.com) |
| 17:55:54 | <dkayiwa> dkayiwa: which commit url? |
| 17:56:25 | <k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/commit/24e34593dcdf2a30f3c1fe148387bd33f7eb3e42 |
| 17:56:26 | <OpenMRSBot> <http://ln-s.net/+LlA> (at github.com) |
| 17:57:22 | <dkayiwa> k-joseph: can you check that commit url yourself |
| 18:00:09 | <dkayiwa> k-joseph: do you see that change in the commit url you gave me? |
| 18:01:21 | <dkayiwa> k-joseph: are you there? |
| 18:01:44 | <k-joseph> dkayiwa: am there, resolving that now |
| 18:02:05 | <dkayiwa> k-joseph: but you did not tell me that you were doing so (you instead just kept quiet) |
| 18:02:43 | <k-joseph> dkayiwa: at first, it looked fine, sorry for that |
| 18:03:07 | <dkayiwa> k-joseph: you need to give an update response such that i know you are with me |
| 18:03:31 | <k-joseph> dkayiwa: ok |
| 18:04:54 | <k-joseph> dkayiwa: again checked, this time in a different browser and it looks, fine!! |
| 18:05:20 | <dkayiwa> k-joseph: same url but contents looking different in different browsers? |
| 18:05:45 | <k-joseph> dkayiwa: still not confirmed, |
| 18:05:57 | <dkayiwa> k-joseph: can you confirm? |
| 18:06:16 | <k-joseph> dkayiwa: yes please |
| 18:08:14 | <k-joseph> dkayiwa: it is working fine, https://github.com/k-joseph/openmrs-core/commit/24e34593dcdf2a30f3c1fe148387bd33f7eb3e42 |
| 18:08:15 | <OpenMRSBot> <http://ln-s.net/+LlA> (at github.com) |
| 18:09:18 | <dkayiwa> k-joseph: what do you mean by its working fine? |
| 18:10:12 | <k-joseph> dkayiwa: i have a gain checked in firefox and crome, the url is working |
| 18:10:50 | <dkayiwa> k-joseph: does that commit url have the aIsToB and bIsToA validation? |
| 18:11:41 | <k-joseph> dkayiwa: it does, but i pleed that you look at it |
| 18:11:55 | <dkayiwa> k-joseph: that is why am asking |
| 18:12:07 | <dkayiwa> k-joseph: but i do not see it |
| 18:12:12 | <dkayiwa> k-joseph: which line should i check? |
| 18:12:29 | <dkayiwa> k-joseph: as in which line number? |
| 18:13:14 | <k-joseph> dkayiwa: line 72 to 78 |
| 18:13:14 | <k-joseph> d |
| 18:13:40 | <dkayiwa> dkayiwa: in which class? |
| 18:13:46 | <dkayiwa> k-joseph: in which class? |
| 18:14:13 | <k-joseph> dkayiwa: RelationshipTypeValidator.java |
| 18:14:59 | <dkayiwa> k-joseph: on that url, that class stops at lines 59 (outside) and 67 (inside) |
| 18:15:30 | <dkayiwa> k-joseph: on which lines does yours stop? |
| 18:15:44 | <dkayiwa> k-joseph: for that class |
| 18:15:54 | <dkayiwa> k-joseph: in that commit url? |
| 18:16:02 | <dkayiwa> k-joseph: https://github.com/k-joseph/openmrs-core/commit/24e34593dcdf2a30f3c1fe148387bd33f7eb3e42 |
| 18:16:03 | <OpenMRSBot> <http://ln-s.net/+LlA> (at github.com) |
| 18:16:30 | <k-joseph> dkayiwa: line 81 |
| 18:16:58 | <dkayiwa> k-joseph: how many classes does that commit url show? |
| 18:17:06 | <dkayiwa> k-joseph: or how many files? |
| 18:17:15 | <k-joseph> dkayiwa: two |
| 18:17:21 | <dkayiwa> k-joseph: which and which? |
| 18:17:37 | <k-joseph> dkayiwa: RelationshipTypeValidator.java and RelationshipTypeValidatorTest.java |
| 18:17:48 | <dkayiwa> k-joseph: and on which line does each stop? |
| 18:19:42 | <k-joseph> dkayiwa: RelationshipTypeValidator.java stops on line 81 and RelationshipTypeValidatorTest.java stops on line 80 |
| 18:20:19 | <dkayiwa> k-joseph: what like of code is at line number 80? |
| 18:20:46 | <dkayiwa> k-joseph: just on the page that comes up when you simply click the above commit url |
| 18:20:54 | <dkayiwa> k-joseph: line of code? |
| 18:21:02 | <k-joseph> 80 |
| 18:21:02 | <k-joseph> +} |
| 18:21:28 | <dkayiwa> k-joseph: that is for which class? |
| 18:21:42 | <k-joseph> dkayiwa: the test class |
| 18:21:52 | <dkayiwa> k-joseph: and for the other class? |
| 18:22:07 | <dkayiwa> k-joseph: which you say has line 81 |
| 18:22:21 | <dkayiwa> k-joseph: so which line of code is at number 81? |
| 18:22:28 | <dkayiwa> k-joseph: just on the same commit url |
| 18:22:34 | <k-joseph> dkayiwa: 81 } |
| 18:23:00 | <dkayiwa> k-joseph: for which class? |
| 18:23:35 | <k-joseph> 80 |
| 18:23:35 | <k-joseph> +} |
| 18:23:54 | <k-joseph> dkayiwa: on the validator class |
| 18:24:16 | <k-joseph> dkayiwa: am first clicking view file @... |
| 18:24:18 | <dkayiwa> k-joseph: are you doing anything else other than simply clicking the above commit url? |
| 18:24:54 | <dkayiwa> k-joseph: not all the file contents are part of the commit |
| 18:25:21 | <dkayiwa> k-joseph: when i say a commit url, i mean what comes up when you just click the url |
| 18:25:46 | <dkayiwa> k-joseph: if you need to do anything else other than simply open up the url, then you are looking at what is not part of the commit |
| 18:26:37 | <dkayiwa> k-joseph: the commit url shows what you have changed in red, and what you have added in green |
| 18:27:04 | <dkayiwa> k-joseph: so can you give me that commit url for the aIsToB and bIsToA validation? |
| 18:27:34 | <k-joseph> dkayiwa:ok, let me look for that |
| 18:30:44 | <k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/commit/bf66086e9edce715e2f8c053201f4ce996a1d158 |
| 18:30:48 | <OpenMRSBot> <http://ln-s.net/+LmE> (at github.com) |
| 18:32:40 | <dkayiwa> k-joseph: does that have the aIsToB and bIsToA validation? |
| 18:34:03 | <k-joseph> dkayiwa: that is down, i deleted some of the remote branch for me to push in most cases, am not sure where i must lost that url from otherwise am still looking around |
| 18:34:27 | <dkayiwa> k-joseph: but you gave me the above url as the one? |
| 18:34:48 | <k-joseph> dkayiwa: i mistaken it for the true one |
| 18:35:08 | <dkayiwa> k-joseph: so have you got the true one? |
| 18:35:19 | <k-joseph> dkayiwa: not yet |
| 18:36:51 | <k-joseph> dkayiwa: https://github.com/k-joseph/openmrs-core/commit/37a7170e76133dceafa84993ce07295284e739bf |
| 18:36:56 | <OpenMRSBot> <http://ln-s.net/+LmP> (at github.com) |
| 18:37:00 | <k-joseph> dkayiwa: concider that one |
| 18:37:14 | <dkayiwa> k-joseph: looking at it now |
| 18:37:36 | <k-joseph> dkayiwa: is it the one you wanted |
| 18:37:59 | <dkayiwa> k-joseph: does it have the aIsToB and bIsToA validation? |
| 18:38:51 | <k-joseph> dkayiwa: i did according to what i thought, line 60 to 68 |
| 18:39:16 | <dkayiwa> k-joseph: ok that is what i was looking for |
| 18:39:38 | <dkayiwa> k-joseph: did you include that commit url on the ticket? |
| 18:39:58 | <k-joseph> dkayiwa: i dont think i did that |
| 18:40:05 | <dkayiwa> k-joseph: can you do so? |
| 18:40:10 | <k-joseph> dkayiwa: ok |
| 18:43:11 | <k-joseph> dkayiwa: have added a new comment for that commit on the ticket page |
| 18:43:20 | <dkayiwa> k-joseph: ok thanks |
| 18:43:24 | <dkayiwa> k-joseph: what data types are aIsToB and bIsToA ? |
| 18:44:27 | <k-joseph> dkayiwa: do you mean String |
| 18:44:46 | <dkayiwa> k-joseph: am asking for the data type they are declared as? |
| 18:45:06 | <dkayiwa> k-joseph: what type/class? |
| 18:45:40 | <k-joseph> dkayiwa: RelationshipType |
| 18:46:55 | <dkayiwa> k-joseph: so aIsToB and bIsToA are declared as of type RelationshipType? |
| 18:48:21 | <k-joseph> dkayiwa: RelationshipType.java is the class where the aIsToB and bIsToA are declared from as private variables, they are taking on String as their type/class |
| 18:48:43 | <dkayiwa> k-joseph: can you give me a simple answer? |
| 18:49:05 | <dkayiwa> k-joseph: what types are aIsToB and bIsToA ? |
| 18:49:24 | <k-joseph> dkayiwa: String |
| 18:49:33 | <dkayiwa> k-joseph: that is all i needed |
| 18:50:02 | <dkayiwa> k-joseph: and what type is name? |
| 18:50:51 | <k-joseph> dkayiwa: String |
| 18:51:18 | <dkayiwa> k-joseph: do you see how nam is validated? |
| 18:51:22 | <dkayiwa> name |
| 18:52:04 | <k-joseph> dkayiwa: still it is not clear |
| 18:52:16 | <dkayiwa> k-joseph: what is not clear? |
| 18:52:32 | <k-joseph> dkayiwa: how name is validated |
| 18:52:43 | <dkayiwa> k-joseph: what is not clear about it? |
| 18:54:17 | <k-joseph> dkayiwa: i mean, linking name with the two Strings, the relationship between |
| 18:54:56 | <dkayiwa> k-joseph: i am not talking about anything else. am only talking about the name validation |
| 18:55:14 | <dkayiwa> k-joseph: you said it is not clear how name is validated. didn't you? |
| 18:55:32 | <k-joseph> dkayiwa: yes |
| 18:55:47 | <dkayiwa> k-joseph: so i ask you now, what is not clear about name validation? |
| 18:57:18 | <k-joseph> dkayiwa: is aIsToB and bIsToA related with name, relating them is my problem |
| 18:57:41 | <dkayiwa> k-joseph: do you see who name validation was done? |
| 18:57:55 | <dkayiwa> k-joseph: do you see how name validation was done? |
| 18:58:05 | <k-joseph> dkayiwa: yes |
| 18:58:12 | <k-joseph> dkayiwa: i see that |
| 18:58:36 | <dkayiwa> k-joseph: and you said you do not understand how name validation was done? |
| 18:59:11 | <dkayiwa> k-joseph: do you read my question carefully? |
| 18:59:42 | <k-joseph> dkayiwa: yes ido, i |
| 19:00:04 | <dkayiwa> k-joseph: so what don't you understand about how name validation was done? |
| 19:00:49 | <dkayiwa> k-joseph: please answer only what am asking, do not confuse it with anything else |
| 19:01:08 | <k-joseph> dkayiwa: ok |
| 19:01:22 | <dkayiwa> k-joseph: so what don't you understand about how name validation was done? |
| 19:01:55 | <k-joseph> dkayiwa: the part rejectIfEmptyOrWhitespace(errors, "name", "error.name"); |
| 19:02:22 | <dkayiwa> k-joseph: can you state exactly what the problem is you find with the above? |
| 19:04:32 | <k-joseph> dkayiwa: sorry, am not even sure how to tell this, |
| 19:04:59 | <dkayiwa> k-joseph: what don't you understand about that line? |
| 19:05:49 | <dkayiwa> k-joseph: simply speak out your mind |
| 19:06:02 | <dkayiwa> k-joseph: when you do not speak it out, i find it hard to help you |
| 19:06:40 | <k-joseph> dkayiwa: the validate function, am not getting to uderstand its practical part |
| 19:07:12 | <k-joseph> dkayiwa: when checked in openmrs |
| 19:07:18 | <dkayiwa> k-joseph: but the line you say you do not understand does not have validate. does it? |
| 19:08:03 | <k-joseph> dkayiwa: the whole bunch of code is in that same function |
| 19:08:19 | <dkayiwa> k-joseph: you seem to have a problem with communication |
| 19:08:41 | <dkayiwa> k-joseph: can you learn to examine my questions carefully? |
| 19:08:53 | <k-joseph> dkayiwa: i mean |
| 19:09:00 | <dkayiwa> k-joseph: you pasted a line above and you said you do not understand it |
| 19:09:16 | <dkayiwa> k-joseph: so i asked you, what don't you understand about that line |
| 19:09:20 | <k-joseph> dkayiwa: yes i did |
| 19:09:28 | <dkayiwa> k-joseph: now you are speaking something else???? |
| 19:10:25 | <dkayiwa> k-joseph: you seem to be worried about so many things |
| 19:10:36 | <dkayiwa> k-joseph: can you train your mind to deal with one thing at a time? |
| 19:11:11 | <dkayiwa> k-joseph: the line you pasted is this: rejectIfEmptyOrWhitespace(errors, "name", "error.name"); |
| 19:11:20 | *** kishoreyekkanti has quit IRC |
| 19:11:44 | <dkayiwa> k-joseph: and my question is simple and clear that, what don't you understand about that line |
| 19:12:09 | <dkayiwa> k-joseph: it is from your answer that i can tell how to help you |
| 19:12:34 | <dkayiwa> k-joseph: are we together? |
| 19:12:42 | <k-joseph> dkayiwa: we are |
| 19:12:49 | <dkayiwa> k-joseph: so can you answer me? |
| 19:13:43 | <k-joseph> dkayiwa: am replying |
| 19:16:15 | <k-joseph> dkayiwa: i understand the passing of the arguments in rejectIfEmptyOrWhitespace(), but my point is simply telling the impact of that part of the code on the application, i mean openmrs when run |
| 19:17:41 | <dkayiwa> k-joseph: do you know what this method does? rejectIfEmptyOrWhitespace |
| 19:18:09 | <k-joseph> dkayiwa: no |
| 19:18:24 | <dkayiwa> k-joseph: did you try to find out what it does? |
| 19:18:36 | <k-joseph> dkayiwa: no |
| 19:18:40 | <dkayiwa> k-joseph: why? |
| 19:19:27 | <k-joseph> dkayiwa: just did not think to do that |
| 19:19:51 | <dkayiwa> k-joseph: ok. can you now try to? |
| 19:20:04 | <k-joseph> dkayiwa: ok |
| 19:20:15 | <dkayiwa> k-joseph: how are you going to do it? |
| 19:20:42 | <k-joseph> dkayiwa: google that |
| 19:20:52 | <dkayiwa> k-joseph: excellent!!! |
| 19:26:12 | <dkayiwa> k-joseph: after you are done with googling about that, feel free to make any changes you may feel like. even if you do not make any changes or understand it from googling, still send me an email and tell me the outcome. That will put me in a better position of how to help you next. ok? |
| 19:26:55 | <k-joseph> dkayiwa: ok, fine |
| 19:47:32 | *** dkayiwa has quit IRC |
| 19:56:51 | *** dkayiwa has joined #openmrs |
| 19:59:25 | *** wyclif has quit IRC |
| 20:16:42 | *** jkeiper has joined #openmrs |
| 20:16:42 | *** ChanServ sets mode: +v jkeiper |
| 21:58:18 | *** jkeiper has quit IRC |
| 23:23:02 | *** dkayiwa has quit IRC |