| 01:06:44 | *** robbyoconnor has quit IRC |
| 01:13:06 | *** robbyoconnor has joined #openmrs |
| 01:13:06 | *** ChanServ sets mode: +v robbyoconnor |
| 01:41:08 | *** robbyoconnor has quit IRC |
| 01:46:00 | *** robbyoconnor has joined #openmrs |
| 01:46:00 | *** ChanServ sets mode: +v robbyoconnor |
| 03:38:30 | *** jkeiper has joined #openmrs |
| 03:38:30 | *** ChanServ sets mode: +v jkeiper |
| 04:34:18 | *** jkeiper has quit IRC |
| 06:05:40 | *** goutham has joined #openmrs |
| 06:06:26 | *** goutham_ has joined #openmrs |
| 06:10:03 | *** goutham has quit IRC |
| 06:16:52 | *** kishoreyekkanti has joined #openmrs |
| 07:08:21 | *** dkayiwa has joined #openmrs |
| 08:07:21 | *** kishoreyekkanti has quit IRC |
| 08:14:27 | *** k-joseph has joined #openmrs |
| 08:14:45 | <k-joseph> dkayiwa: good morning |
| 08:29:29 | <dkayiwa> hi k-joseph |
| 08:32:27 | *** dkayiwa has left #openmrs |
| 08:38:52 | *** kishoreyekkanti has joined #openmrs |
| 08:40:00 | *** k-joseph has quit IRC |
| 10:02:13 | *** kishoreyekkanti has quit IRC |
| 10:03:01 | *** kishoreyekkanti has joined #openmrs |
| 10:35:35 | *** kishoreyekkanti has quit IRC |
| 10:40:06 | *** d__ed has joined #openmrs |
| 10:43:59 | *** d__ed has left #openmrs |
| 10:54:03 | *** rafa has joined #openmrs |
| 10:54:03 | *** ChanServ sets mode: +v rafa |
| 11:43:39 | *** k-joseph has joined #openmrs |
| 12:06:12 | *** dkayiwa has joined #openmrs |
| 12:10:33 | <dkayiwa> hi k-joseph |
| 12:10:44 | <k-joseph> dkayiwa: hi |
| 12:10:57 | <dkayiwa> k-joseph: how is it going? |
| 12:12:19 | <k-joseph> dkayiwa: i have just gotten a break for proceeding now, i had not yet gotten enough time to do as per your email, |
| 12:12:31 | <dkayiwa> k-joseph: ok |
| 12:27:31 | <dkayiwa> k-joseph: i guess you are now looking at other unit tests for validators |
| 12:27:49 | <k-joseph> dkayiwa: yes |
| 12:27:57 | <dkayiwa> k-joseph: ok good |
| 12:31:38 | <k-joseph> dkayiwa: have looked at ValidateUtilTest.java, am only getting that, any others you know by name that i can look at? |
| 12:32:17 | <dkayiwa> k-joseph: let me check |
| 12:32:25 | <k-joseph> dkayiwa: ok |
| 12:36:02 | <dkayiwa> k-joseph: can you look at src/test/java? |
| 12:36:17 | <dkayiwa> k-joseph: then under the "org.openmrs.validator" package |
| 12:36:26 | <k-joseph> dkayiwa: ok |
| 12:36:39 | <dkayiwa> k-joseph: then you should see lots of validator tests |
| 12:39:35 | <dkayiwa> k-joseph: have you seen them? |
| 12:39:43 | <k-joseph> dkayiwa: yes |
| 12:39:50 | <dkayiwa> k-joseph: like which one? |
| 12:40:26 | <k-joseph> dkayiwa: like EncounterTypeValidatorTest.jajva |
| 12:40:46 | <dkayiwa> k-joseph: ok |
| 12:52:36 | <k-joseph> dkayiwa: still going through them, am not yet familiar with spring framework, and am seeing it applied, i wanted to have a quick view of it, will be greatfull to recieve assistance here |
| 12:53:15 | <dkayiwa> k-joseph: can you start by doing what you think for that test, then submit a pull request. i will start from there to guide you |
| 12:53:40 | <k-joseph> dkayiwa: ok |
| 13:19:11 | <k-joseph> dkayiwa: i will be back shortely |
| 13:19:20 | <dkayiwa> k-joseph: ok |
| 13:23:40 | *** k-joseph has quit IRC |
| 13:31:35 | *** roseSale has joined #openmrs |
| 13:33:26 | *** k-joseph has joined #openmrs |
| 13:33:32 | <dkayiwa> hey roseSale :) |
| 13:33:42 | <dkayiwa> roseSale: good to see you after a long time :) |
| 13:34:28 | <roseSale> dkayiwa: hello. :) |
| 13:35:14 | <dkayiwa> roseSale: so which version of the module do you have installed now? |
| 13:36:31 | <roseSale> dkayiwa: the latest. Since when I get back to my old version, things are not working at all. |
| 13:39:06 | <dkayiwa> roseSale: can you tell me the exact version? |
| 13:39:55 | <roseSale> dkayiwa: its 4.0.9.9 |
| 13:40:34 | <dkayiwa> roseSale: can you go to the form designer and tell me exactly what happens when you try look at it on the design surface tab? |
| 13:43:15 | <roseSale> dkayiwa: my internet is bad. It is still loading. sorry for the delay. :) |
| 13:43:44 | <dkayiwa> roseSale: no problem. will wait. Was told to always be patient with ladies!!! :D |
| 13:44:28 | <roseSale> dkayiwa: When I go to the design surface tab, I can see the form that I created. But I cannot scroll down to the bottom part. There's this scroll bar that limits the scrolling |
| 13:45:19 | <dkayiwa> roseSale: which browser are you using? |
| 13:46:07 | <roseSale> dkayiwa: google Chrome. This is what I always use, even before |
| 13:46:48 | <dkayiwa> roseSale: which widget is the last that you are able to see at the bottom of the design surface? |
| 13:48:05 | <roseSale> dkayiwa: the grouped widget of contact person. I can see only the half of name and number field. |
| 13:48:31 | <dkayiwa> roseSale: did you send me a screenshot of what you are able to see? |
| 13:49:09 | <roseSale> dkayiwa: I sent in to you before. and also on the implementers group. |
| 13:49:20 | <dkayiwa> roseSale: ok let me check |
| 13:49:32 | <dkayiwa> roseSale: do you have firefox installed on your computer? |
| 13:50:26 | <roseSale> dkayiwa: I only have chrome and safari. Should I download one and try on it? |
| 13:50:48 | <dkayiwa> roseSale: can you try safari and tell me what happens with it? |
| 13:51:33 | <roseSale> dkayiwa: Ok. Trying. |
| 13:58:16 | <dkayiwa> hi goutham_ |
| 13:58:16 | <roseSale> dkayiwa: Ok that's it. I can see everything in safari. It was chrome after all. |
| 13:58:42 | <dkayiwa> roseSale: what verson of chrome are you using? |
| 13:59:12 | *** goutham_ has quit IRC |
| 13:59:17 | <roseSale> dkayiwa: Version 23.0.1271.101 |
| 13:59:25 | <dkayiwa> roseSale: is that the latest? |
| 14:01:39 | <roseSale> dkayiwa: I think it is the latest. |
| 14:01:46 | <dkayiwa> roseSale: ok |
| 14:01:59 | <dkayiwa> roseSale: when did you last update it? |
| 14:03:04 | <roseSale> dkayiwa: Last month maybe. I don't upgrade my mac, so maybe this is not the latest. :D |
| 14:03:39 | <dkayiwa> roseSale: try the latest chrome and see if problem persists :0 |
| 14:03:41 | <dkayiwa> :) |
| 14:04:23 | <roseSale> dkayiwa: May I should just use safari for now. Thank you Daniel. :D |
| 14:04:48 | <dkayiwa> roseSale: if you are happy with safari, then who am i to stop your from using it??? :D |
| 14:05:54 | <roseSale> dkayiwa: not so happy with it. I just need it for now. :D I need to fix the form as soon as possible, i'll fix my chrome later. :) |
| 14:06:07 | <dkayiwa> roseSale: sure :) |
| 14:06:24 | <roseSale> dkayiwa: Thank you. :0 |
| 14:06:30 | <roseSale> dkayiwa: :) |
| 14:06:35 | <dkayiwa> roseSale: you are welcome Rose :) |
| 14:17:10 | *** wyclif has quit IRC |
| 14:24:28 | *** rafa has quit IRC |
| 14:26:42 | *** dkayiwa has quit IRC |
| 14:56:50 | *** wyclif has joined #openmrs |
| 14:57:58 | *** applecool has joined #openmrs |
| 14:57:58 | *** ChanServ sets mode: +v applecool |
| 15:35:56 | *** k-joseph has quit IRC |
| 15:38:47 | *** roseSale has quit IRC |
| 15:55:25 | *** basic` has quit IRC |
| 15:57:03 | *** basic has joined #openmrs |
| 17:27:28 | *** pulasthi7 has joined #openmrs |
| 17:33:14 | *** applecool has quit IRC |
| 17:44:25 | *** djazayeri has joined #openmrs |
| 17:44:25 | *** ChanServ sets mode: +o djazayeri |
| 17:52:35 | *** djazayeri has quit IRC |
| 17:54:32 | *** dkayiwa has joined #openmrs |
| 18:24:13 | *** wyclif has quit IRC |
| 18:35:19 | *** k-joseph has joined #openmrs |
| 18:35:46 | <k-joseph> dkayiwa: good evening, |
| 18:35:51 | <dkayiwa> k-joseph: hi |
| 18:37:12 | <k-joseph> dkayiwa: did you see my email and followed it up please?:-( |
| 18:37:33 | <dkayiwa> k-joseph: yes i even replied :) |
| 18:37:48 | <dkayiwa> k-joseph: in the meantime, you can claim another ticket :) |
| 18:38:07 | <k-joseph> dkayiwa: ok please |
| 18:40:39 | <dkayiwa> k-joseph: does the test pass? |
| 18:41:26 | <k-joseph> dkayiwa: not yet confirmed |
| 18:41:45 | <dkayiwa> k-joseph: we do not commit tests which do not pass |
| 18:42:15 | <dkayiwa> k-joseph: in otherwards, first check if the test passes before you commit/push |
| 18:42:32 | <k-joseph> dkayiwa: ok, let me test it, |
| 18:42:41 | <dkayiwa> k-joseph: ok |
| 18:44:06 | <dkayiwa> k-joseph: you will tell me after you are done |
| 18:44:17 | <dkayiwa> k-joseph: if am offline, you just send me an email |
| 18:51:17 | <k-joseph> dkayiwa: ok please |
| 18:56:15 | <k-joseph> dkayiwa: passed the junit test |
| 18:57:44 | <dkayiwa> k-joseph: without any changes? |
| 18:57:53 | <k-joseph> dkayiwa: yes |
| 18:58:14 | <dkayiwa> k-joseph: reviewing now |
| 18:59:04 | <dkayiwa> k-joseph: did you do all the validation as specified on the ticket? |
| 19:16:40 | *** djazayeri has joined #openmrs |
| 19:16:40 | *** ChanServ sets mode: +o djazayeri |
| 19:26:14 | *** djazayeri has quit IRC |
| 19:33:45 | *** travis-ci has joined #openmrs |
| 19:33:45 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [a1230a7] [rkorytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3809561 |
| 19:33:45 | *** travis-ci has left #openmrs |
| 19:33:48 | <OpenMRSBot> <http://ln-s.net/+LJx> (at travis-ci.org) |
| 20:01:12 | *** pulasthi7 has quit IRC |
| 20:02:40 | *** dkayiwa has quit IRC |
| 20:07:14 | *** dkayiwa has joined #openmrs |
| 20:34:28 | *** dkayiwa has quit IRC |
| 21:34:18 | *** wyclif has joined #openmrs |
| 21:41:08 | *** k-joseph has quit IRC |
| 22:08:55 | *** tobin_g has joined #openmrs |
| 22:14:17 | *** tobin_g has quit IRC |
| 23:47:19 | *** djazayeri has joined #openmrs |
| 23:47:19 | *** ChanServ sets mode: +o djazayeri |
| 23:48:23 | *** djazayeri has quit IRC |
| 23:55:33 | *** djazayeri has joined #openmrs |
| 23:55:33 | *** ChanServ sets mode: +o djazayeri |