| 00:03:23 | *** lh has joined #openmrs |
| 00:03:23 | *** lh has joined #openmrs |
| 00:30:09 | *** wyclif_ has joined #openmrs |
| 01:20:49 | *** djazayeri has quit IRC |
| 01:22:38 | *** robbyoconnor has joined #openmrs |
| 01:22:38 | *** ChanServ sets mode: +v robbyoconnor |
| 01:41:40 | *** lh has quit IRC |
| 01:45:38 | *** djazayeri has joined #openmrs |
| 01:45:38 | *** ChanServ sets mode: +o djazayeri |
| 01:46:00 | *** harshadura has joined #openmrs |
| 02:24:16 | *** jkeiper has joined #openmrs |
| 02:24:16 | *** ChanServ sets mode: +v jkeiper |
| 02:34:12 | *** Mkop1 has joined #openmrs |
| 02:34:12 | *** ChanServ sets mode: +v Mkop1 |
| 02:48:52 | *** Mkop1 has quit IRC |
| 03:05:12 | *** djazayeri has quit IRC |
| 03:30:23 | *** harshadura has quit IRC |
| 03:49:18 | *** jkeiper has quit IRC |
| 03:59:17 | *** Mkop1 has joined #openmrs |
| 03:59:17 | *** ChanServ sets mode: +v Mkop1 |
| 04:15:40 | *** djazayeri has joined #openmrs |
| 04:15:40 | *** ChanServ sets mode: +o djazayeri |
| 04:31:22 | *** kishoreyekkanti has joined #openmrs |
| 04:37:13 | <kishoreyekkanti> http://developer.android.com/tools/devices/managing-avds-cmdline.html |
| 04:37:16 | <OpenMRSBot> <http://ln-s.net/+Jk_> (at developer.android.com) |
| 04:37:20 | <kishoreyekkanti> http://developer.android.com/tools/projects/projects-cmdline.html |
| 04:37:21 | <OpenMRSBot> <http://ln-s.net/+Jka> (at developer.android.com) |
| 04:37:40 | <kishoreyekkanti> sorry for the spam. was about to ping this in another channel |
| 05:09:04 | *** ishara has joined #openmrs |
| 05:12:13 | <ishara> hi djazayeri, you free for a sec? |
| 05:23:37 | *** djazayeri has quit IRC |
| 05:24:01 | *** Mkop1 has left #openmrs |
| 05:42:26 | *** robbyoconnor has quit IRC |
| 05:47:23 | *** ishara has quit IRC |
| 06:21:55 | *** tobin_g has quit IRC |
| 06:24:36 | *** robbyoconnor has joined #openmrs |
| 06:24:36 | *** ChanServ sets mode: +v robbyoconnor |
| 06:30:49 | *** tobin_g has joined #openmrs |
| 06:34:29 | *** tobin_g has quit IRC |
| 07:44:56 | *** ibewes has joined #openmrs |
| 07:49:42 | <ibewes> howdy all! |
| 08:08:25 | *** dkayiwa has joined #openmrs |
| 08:23:34 | <ibewes> hello dkayiwa |
| 08:23:51 | <dkayiwa> ibewes: hi |
| 08:25:01 | <ibewes> dkayiwa: what would be the best way to get involved in the registration sprint? It seems like the tickets that are open are dependent on the ones being worked on |
| 08:25:42 | <dkayiwa> ibewes: that is very true. i also had trouble choosing a ticket |
| 08:25:58 | <dkayiwa> ibewes: can you send out an email to the dev list and ask this very question? |
| 08:26:12 | <ibewes> dkayiwa: surely |
| 08:27:08 | <ibewes> dkayiwa: also, regarding that huge module issue I mentioned yesterday (the Jasper module), I was thinking of removing the jasper maven dependency and just referencing and including the jars needed |
| 08:27:29 | <ibewes> dkayiwa: but I'm not sure if that is generally frowned upon |
| 08:28:39 | <dkayiwa> ibewes: is the master branch ant based? |
| 08:29:05 | <ibewes> dkayiwa: yeah, but there is a maven branch which is what we're working on at the moment |
| 08:29:22 | <ibewes> dkayiwa: that is, there is a branch called 'maven' |
| 08:29:38 | <dkayiwa> ibewes: am a git newbie, how do i get that branch |
| 08:29:48 | <ibewes> git checkout maven |
| 08:30:03 | <ibewes> dkayiwa: git checkout maven |
| 08:30:17 | <dkayiwa> ibewes: whats the module name? |
| 08:30:32 | <ibewes> dkayiwa: assuming you've already cloned the repository from github |
| 08:31:15 | <ibewes> dkayiwa: it's here on github: https://github.com/OpenHMIS/openmrs-module-jasperreports |
| 08:31:18 | <dkayiwa> ibewes: yes |
| 08:31:19 | <OpenMRSBot> <http://ln-s.net/+Jne> (at github.com) |
| 08:31:57 | <ibewes> dkayiwa: the artifact id is 'jasperreports', is that the name you're looking for? |
| 08:32:04 | <dkayiwa> ibewes: yes |
| 08:36:12 | *** k-joseph has joined #openmrs |
| 08:36:45 | <k-joseph> dkayiwa: Hi; |
| 08:36:51 | <dkayiwa> k-joseph: hi |
| 08:37:04 | <ibewes> k-joseph: hello! |
| 08:37:34 | <k-joseph> ibewes: hi |
| 08:41:28 | <k-joseph> dkayiwa: am getting an error when i push, i did all the commands again after i had deleted the branch TRUNK-3814 locally, but i tried to delete it remotely and i failed, the error is: http://pastebin.com/ZFvQzBuk |
| 08:46:44 | <dkayiwa> k-joseph: how did you delete remotely? what command? |
| 08:48:14 | <k-joseph> dkayiwa: i used: git branch -d TRUNK-3814 |
| 08:48:35 | <dkayiwa> k-joseph: to delete it remotely? |
| 08:49:05 | <k-joseph> dkayiwa: git push origin :TRUNK-3814 |
| 08:52:14 | <dkayiwa> k-joseph: can do a: git pull upstream master |
| 08:54:32 | <k-joseph> dkayiwa: am getting this: http://pastebin.com/bFid5FSV |
| 08:55:31 | <dkayiwa> k-joseph: restart your computer and do it again |
| 08:56:12 | *** k-joseph has quit IRC |
| 08:57:50 | *** djazayeri has joined #openmrs |
| 08:57:50 | *** ChanServ sets mode: +o djazayeri |
| 09:03:06 | *** robbyoconnor has quit IRC |
| 09:04:07 | *** k-joseph has joined #openmrs |
| 09:05:56 | <k-joseph> dkayiwa: am getting this: http://pastebin.com/aiWaW1YE am i supposed to first run git checkout master |
| 09:06:47 | <dkayiwa> k-joseph: can you try google the error? |
| 09:07:02 | <k-joseph> dkayiwa: ok |
| 09:30:53 | <dkayiwa> hi ibewes |
| 09:31:13 | <ibewes> dkayiwa: hello there |
| 09:31:32 | <dkayiwa> ibewes: do you need all the jars in the lib folder? |
| 09:32:36 | <ibewes> dkayiwa: yeah, the ones in /lib on the master branch |
| 09:33:09 | <ibewes> dkayiwa: when we updated it to use the maven jasper dependency we got a ton of other things that I don't think we actually need for our usage of jasper |
| 09:33:12 | <dkayiwa> ibewes: the big size comes from the so many jars |
| 09:33:29 | <dkayiwa> ibewes: can you exclude some of these jars? |
| 09:33:46 | <dkayiwa> ibewes: actually exclude the majority of them |
| 09:33:56 | <ibewes> dkayiwa: I think this set (in the lib folder) are the ones that are actually required |
| 09:34:20 | <dkayiwa> ibewes: that makes it even simpler to do |
| 09:34:21 | <ibewes> dkayiwa: though I'm not 100% sure about the jdt-compiler jar |
| 09:34:40 | <dkayiwa> ibewes: whichever jar you are not sure of, just exclude it :) |
| 09:35:05 | <ibewes> dkayiwa: what I was going to do is remove the jasper maven dependency, directly reference these jars, and include only them in the omod |
| 09:35:24 | <ibewes> dkayiwa: it'll still be large, but way smaller |
| 09:35:38 | <ibewes> dkayiwa: hehe... that's what testing is for ;) |
| 09:36:03 | <dkayiwa> ibewes: you can simply use the maven excludes tag under the jasper dependency |
| 09:36:12 | <dkayiwa> ibewes: eclipse can automatically add that for you |
| 09:36:29 | <ibewes> dkayiwa: ok, nice... I didn't know about that |
| 09:37:11 | <ibewes> dkayiwa: I use IDEA but I assume I can just specify that in the dependency element in the pom.xml? |
| 09:37:25 | <dkayiwa> ibewes: yes |
| 09:37:42 | <ibewes> dkayiwa: great... thanks kindly for the help! |
| 09:45:20 | <dkayiwa> k-joseph: any success? |
| 09:46:55 | <k-joseph> dkayiwa: i have finally deleted the local and remote branch for TRUNK-3814,, so am now doing the commands again |
| 09:47:08 | <dkayiwa> k-joseph: ok great |
| 09:59:46 | *** djazayeri has quit IRC |
| 10:02:56 | *** dkayiwa has quit IRC |
| 10:02:57 | *** Mkop has quit IRC |
| 10:05:53 | *** dkayiwa has joined #openmrs |
| 10:24:22 | *** ibewes has quit IRC |
| 10:25:12 | <k-joseph> dkayiwa: hi |
| 10:25:20 | <dkayiwa> k-joseph: hi |
| 10:25:47 | <k-joseph> dkayiwa: i have finished the procedures: see https://tickets.openmrs.org/browse/TRUNK-3814 |
| 10:26:31 | <dkayiwa> k-joseph: looking... |
| 10:26:59 | <k-joseph> dkayiwa: pardon |
| 10:29:32 | <k-joseph> dkayiwa: in the description, am not understanding this: It should have basic validation added (aIsToB and bIsToA need to be set). |
| 10:29:32 | <dkayiwa> k-joseph: i do not see the unit test in the commeit |
| 10:29:52 | <dkayiwa> k-joseph: ensure that they are not null |
| 10:35:10 | *** ibewes has joined #openmrs |
| 10:35:38 | <dkayiwa> k-joseph: did you have a glance at the links below? |
| 10:35:41 | <dkayiwa> k-joseph: https://wiki.openmrs.org/display/docs/Unit+Testing+Conventions |
| 10:36:03 | <dkayiwa> k-joseph: and this: https://wiki.openmrs.org/display/docs/Unit+Tests |
| 10:36:26 | <dkayiwa> k-joseph: and this: https://wiki.openmrs.org/display/docs/Testing |
| 10:36:41 | <dkayiwa> k-joseph: and this: https://wiki.openmrs.org/display/docs/Unit+Testing+With+at-should+Annotation |
| 10:36:57 | <dkayiwa> k-joseph: and this: https://wiki.openmrs.org/display/docs/Unit+Testing+Servlets |
| 10:37:34 | <dkayiwa> k-joseph: and this: https://wiki.openmrs.org/display/docs/Unit+Testing+with+Database+Data |
| 10:39:04 | <k-joseph> dkayiwa: i will report back to you when am through with going through them, i had not for most of them |
| 10:39:44 | *** suranga has joined #openmrs |
| 10:39:44 | *** ChanServ sets mode: +v suranga |
| 10:57:11 | <dkayiwa> k-joseph: ok |
| 11:06:00 | *** rafa has joined #openmrs |
| 11:06:01 | *** ChanServ sets mode: +v rafa |
| 11:09:23 | *** ibewes has quit IRC |
| 11:12:09 | <dkayiwa> k-joseph: you will also need this plugin: https://wiki.openmrs.org/display/docs/Generate+Test+Case+Plugin |
| 11:12:10 | <OpenMRSBot> <http://ln-s.net/8zPd> (at wiki.openmrs.org) |
| 11:14:22 | <suranga> hi rafa ! |
| 11:14:29 | <rafa> suranga: hi |
| 11:14:38 | <suranga> rafa, ha ha.. ive been staling IRC waiting for you :P |
| 11:15:00 | <suranga> rafa, um.. I have a problem with maven release:prepare, can I ask u a question ? :) |
| 11:15:01 | <rafa> suranga: haha here I am |
| 11:15:08 | <rafa> suranga: sure |
| 11:15:32 | <rafa> I'm sorry my IRC client is playing tricks with me and sometimes it doesn't connect automatically |
| 11:15:46 | <rafa> I keep forgetting to kick it and connect |
| 11:15:56 | <suranga> rafa, its like this. Im trying to release the hl7query module, but it seems to hang at the very last step (the pushing to git part) |
| 11:16:10 | <suranga> rafa, have you seen this before ? |
| 11:16:19 | <rafa> suranga: do you have some logs? |
| 11:17:02 | <rafa> suranga: does it create a tag locally? |
| 11:17:33 | <rafa> suranga: you can check if you type: 'git tag' |
| 11:18:17 | <suranga> im using the instructions given here: https://wiki.openmrs.org/display/docs/Module+Tagging+and+Releasing |
| 11:18:36 | *** k-joseph has quit IRC |
| 11:18:44 | <suranga> rafa, I didnt see any logs as such, but ill re-try again and try to get you something |
| 11:19:03 | <rafa> suranga: by logs I mean what is printed in the console |
| 11:19:09 | <suranga> rafa, quick question : in this command : |
| 11:19:09 | <suranga> mvn -Dusername=yourusername -Dpassword=yourpassword release:prepare |
| 11:19:26 | <suranga> rafa, whats our username password ? is it our github credentials ? |
| 11:19:44 | <rafa> suranga: yes, github |
| 11:20:11 | <suranga> rafa, hm,... but anyway, let me re-try :) |
| 11:20:32 | *** ibewes has joined #openmrs |
| 11:21:26 | <rafa> suranga: I'm looking at https://github.com/openmrs/openmrs-module-hl7query/blob/master/pom.xml |
| 11:21:31 | <OpenMRSBot> <http://ln-s.net/+Jqh> (at github.com) |
| 11:22:05 | <rafa> suranga: Have you tried changing scm details to https? |
| 11:22:15 | <rafa> suranga: see https://github.com/openmrs/openmrs-module-metadatasharing/blob/master/pom.xml for example |
| 11:22:18 | <OpenMRSBot> <http://ln-s.net/+Jqi> (at github.com) |
| 11:22:22 | <suranga> rafa, um... i see a reference to NEXUS repo |
| 11:23:01 | <suranga> rafa in the pom. do I need to provide credentials to the nexus repo in order to release ? |
| 11:23:07 | <rafa> suranga: you will also see <distributionManagement> |
| 11:23:17 | <rafa> suranga: *need |
| 11:23:35 | <rafa> suranga: no credentials need to be put in settings.xml |
| 11:23:55 | <ibewes> suranga: I just went through that myself... ended up putting my credentials in settings.xml also |
| 11:24:39 | <suranga> rafa, hmm.. so you recomend that I 1) Switch to https from scm and 2) add <distributionManagement> tag ? |
| 11:24:59 | <rafa> suranga: and 3) add credentials to settings.xml |
| 11:25:27 | <suranga> rafa, my github credentials ? ir this ? |
| 11:25:28 | <suranga> <settings> |
| 11:25:28 | <suranga> <servers> |
| 11:25:28 | <suranga> <server> |
| 11:25:28 | <suranga> <id>svn.openmrs.org</id> |
| 11:25:28 | <suranga> <username>yourusername</username> |
| 11:25:30 | <suranga> <password>yourpassword</password> |
| 11:25:32 | <suranga> </server> |
| 11:25:34 | <suranga> </servers> |
| 11:25:38 | <suranga> </settings> |
| 11:26:31 | <rafa> suranga: and for the nexus repository |
| 11:27:05 | <suranga> rafa, hmm... me no have nexus credentials. guess I will need to create an ITSM for this ? |
| 11:27:16 | <rafa> suranga: correct |
| 11:27:53 | <suranga> rafa, thanks . I ll do that, and also update the hl7query module pom with the changes you suggested. thanks ! :) |
| 11:38:43 | *** jkeiper has joined #openmrs |
| 11:38:43 | *** ChanServ sets mode: +v jkeiper |
| 11:46:51 | *** ningosi has joined #openmrs |
| 11:47:32 | *** ningosi is now known as Ojwanganto |
| 12:09:17 | *** rafa has quit IRC |
| 12:10:49 | <suranga> greetings all ! |
| 12:11:12 | <suranga> jkeiper, I' the prodigal son, has returned :P |
| 12:16:04 | *** rafa has joined #openmrs |
| 12:16:04 | *** ChanServ sets mode: +v rafa |
| 12:19:54 | <suranga> hi indy people, is michael at office today ? :) |
| 12:30:54 | *** Ojwanganto has quit IRC |
| 12:49:12 | *** kavuri has joined #openmrs |
| 12:51:33 | <kavuri> dkayiwa: hi |
| 12:53:11 | <ibewes> dkayiwa: this those maven dependency exclusions the size is down to a much more reasonable 4.8 MB. Thanks for your advice! |
| 13:15:04 | <jkeiper> suranga, hi :-) |
| 13:15:08 | <jkeiper> suranga, i think he will be |
| 13:15:34 | <suranga> jkeiper, cool, thanks. Ive just realized that I dont have access to nexus :P |
| 13:15:41 | <jkeiper> o? |
| 13:15:42 | <jkeiper> heh |
| 13:15:48 | <jkeiper> maybe file an ITSM ticket? |
| 13:16:00 | <suranga> jkeiper, um.. how goes the sprint ? Im afraid ive been somewhat of a prodigal son lately :P |
| 13:16:11 | <suranga> jkeiper, yep, did that. hopefully hell see it soon :) |
| 13:16:22 | <jkeiper> suranga, no problem ... dkayiwa, wyclif_ and rafa are all working hard :-D |
| 13:16:46 | <suranga> jkeiper, im also having the same problem that wesley brown had (see his email) |
| 13:17:04 | <suranga> jkeiper, we cant seem to find tickets that are not dependent on others :( |
| 13:17:18 | <jkeiper> suranga, ibewes i totally understand |
| 13:17:43 | <jkeiper> suranga, ibewes it's because the initial push does not have much design beyond what is already in progress |
| 13:17:53 | <suranga> jkeiper, I see |
| 13:18:26 | <jkeiper> suranga, ibewes we just have another day or so left ... but still, we could consider taking the AMRS Registration Module and fitting it to use the registration module |
| 13:19:20 | <suranga> jkeiper, im having a crisis where i havent done much openmrs work in some time, but cant seem to find something small and non-depdent which I could work on :( |
| 13:19:53 | <suranga> jkeiper, hmm.. what happens after the sprint finishes on the 21st ? |
| 13:19:56 | <ibewes> jkeiper: I think the functionality I'm most interested in is some type of generalized biometric support. Perhaps that can get rolled into a future sprint? |
| 13:20:08 | *** k-joseph has joined #openmrs |
| 13:21:12 | <jkeiper> ibewes, ah i see ... essentially we saw that as a "hook" (which we do not have in there yet) |
| 13:21:30 | <jkeiper> ibewes, and it would be part of a Map<String, Object> otherData. |
| 13:21:47 | <jkeiper> ibewes, it seems we might need to add pre/post processors too ... |
| 13:21:48 | <jkeiper> hrm |
| 13:22:00 | <ibewes> jkeiper: right, I see your point; but even that part would be interesting to work on |
| 13:22:08 | <jkeiper> suranga, hahah ... well, I think wyclif_ filed a core ticket related to RC |
| 13:22:21 | <jkeiper> ibewes, perhaps you and I can collaborate on designing it? |
| 13:22:34 | <jkeiper> suranga, the core ticket has to do with creating a patient from a person stub |
| 13:22:43 | <ibewes> jkeiper: that Map<String, Object> is such a pain to work with... seems like we could give it a bit more structure than that |
| 13:22:49 | <ibewes> jkeiper: sure, I'd love to! |
| 13:22:54 | <suranga> jkeiper, i think I could try some core tickets maybe... that way, I wont hold up anyone if I get stuck with uni stuff :) |
| 13:23:16 | <jkeiper> ibewes, i agree |
| 13:24:05 | <suranga> jkeiper, umm.. also, when are you going on leave for christmas ? (I ask so that I can do some quick planning :) |
| 13:24:35 | <jkeiper> next wk |
| 13:24:37 | <jkeiper> ;-) |
| 13:24:42 | <jkeiper> suranga, i'll be around though |
| 13:25:06 | <suranga> jkeiper, thanks, thats cool :) :) |
| 13:40:32 | *** Mkop has joined #openmrs |
| 13:40:32 | *** ChanServ sets mode: +v Mkop |
| 13:45:38 | *** kavuri has quit IRC |
| 13:49:18 | *** jkeiper has quit IRC |
| 13:50:30 | *** wyclif_ has quit IRC |
| 13:52:23 | <dkayiwa> hi ibewes |
| 13:52:51 | <ibewes> dkayiwa: howdy |
| 13:53:02 | <dkayiwa> ibewes: sorry i had stepped out |
| 13:53:12 | <dkayiwa> ibewes: good to hear that the size is now sane :) |
| 13:53:30 | <ibewes> dkayiwa: as am I, thanks again for the help |
| 13:53:43 | <dkayiwa> ibewes: you did it on your own :) |
| 13:54:57 | <ibewes> dkayiwa: yeah, but having another pair of eyes is a good as a sanity check |
| 13:55:09 | <dkayiwa> ibewes: hahahaha :) |
| 13:56:00 | *** k-joseph has quit IRC |
| 14:11:23 | *** suranga has quit IRC |
| 14:14:50 | *** kishoreyekkanti has quit IRC |
| 14:15:46 | *** ibewes has quit IRC |
| 14:24:12 | *** wyclif has joined #openmrs |
| 14:32:42 | *** jkeiper has joined #openmrs |
| 14:32:42 | *** ChanServ sets mode: +v jkeiper |
| 14:55:55 | *** andrea has joined #openmrs |
| 14:56:13 | <andrea> rafa, u around? |
| 14:56:16 | *** andrea is now known as Guest23233 |
| 14:56:25 | <rafa> yes |
| 14:56:32 | *** Guest23233 is now known as andreap |
| 14:57:05 | <andreap> hi rafa, did u see I replied to your comments on pull request |
| 14:57:28 | <rafa> andreap: yes, but I haven't looked again closely |
| 14:57:47 | <rafa> andreap: maybe after the dev call |
| 14:58:29 | <andreap> rafa, ok - thanks |
| 15:01:18 | *** jkeiper has quit IRC |
| 15:01:29 | *** djazayeri has joined #openmrs |
| 15:01:29 | *** ChanServ sets mode: +o djazayeri |
| 15:16:30 | *** jkeiper has joined #openmrs |
| 15:16:30 | *** ChanServ sets mode: +v jkeiper |
| 15:55:12 | *** kishoreyekkanti has joined #openmrs |
| 16:00:06 | *** jkeiper has quit IRC |
| 16:01:12 | <andreap> rafa, do you have a minute? |
| 16:01:20 | <rafa> andreap: yes |
| 16:02:13 | <andreap> rafa, only 1 test in error now after following your suggestions - the boolean Boolean thing was a big problem |
| 16:02:33 | <rafa> andreap: what is the error? |
| 16:02:39 | <andreap> rafa, wonder why birthdateEstimated didn't have sam problems |
| 16:03:17 | <andreap> rafa, https://github.com/OpenMRS/openmrs-core/pull/150 - see my last comment |
| 16:03:23 | <OpenMRSBot> <http://ln-s.net/+JvZ> (at github.com) |
| 16:05:40 | <rafa> andreap: did you push all your recent changes to github? |
| 16:06:37 | <andreap> rafa, yes have made all suggested changes except still a comment in jsp - have to do a few more jsps - then will remove it |
| 16:08:11 | *** jkeiper has joined #openmrs |
| 16:08:11 | *** ChanServ sets mode: +v jkeiper |
| 16:09:17 | <rafa> andreap: just left a comment |
| 16:09:35 | <rafa> andreap: please try it out and see if it makes the test pass |
| 16:10:44 | <andreap> rafa, ok thanks but need to go to office - don't have work computer here - will let you know |
| 16:11:20 | <rafa> andreap: ok |
| 16:11:36 | <andreap> rafa, thanks! |
| 16:32:46 | *** robbyoconnor has joined #openmrs |
| 16:32:46 | *** ChanServ sets mode: +v robbyoconnor |
| 16:33:24 | *** r0bby has joined #openmrs |
| 16:33:24 | *** ChanServ sets mode: +v r0bby |
| 16:37:14 | *** robbyoconnor has quit IRC |
| 17:01:16 | *** rafa has quit IRC |
| 17:11:46 | *** kishoreyekkanti has quit IRC |
| 17:20:17 | *** k-joseph has joined #openmrs |
| 17:24:06 | *** kjoseph has joined #openmrs |
| 17:25:05 | *** k-joseph has quit IRC |
| 17:33:03 | *** k-joseph has joined #openmrs |
| 17:35:26 | *** basic is now known as basic` |
| 17:35:29 | *** kjoseph has quit IRC |
| 17:36:08 | *** kjoseph has joined #openmrs |
| 17:37:23 | *** k-joseph has quit IRC |
| 17:39:21 | *** dilangamachchige has joined #openmrs |
| 17:40:56 | *** k-joseph_ has joined #openmrs |
| 17:41:54 | *** kjoseph has quit IRC |
| 17:45:27 | <dilangamachchige> hi |
| 17:46:23 | <dilangamachchige> i am a new guy for openMRS. can anyone help me with working with a module.. |
| 17:46:58 | <dilangamachchige> I have created a module using the developer giude in openMRS site |
| 17:48:18 | <dilangamachchige> can anyone tell how to run the module and how worknig with module.. |
| 17:51:13 | *** k-joseph_ has quit IRC |
| 17:51:28 | <dilangamachchige> y |
| 17:51:32 | *** k-joseph has joined #openmrs |
| 18:00:06 | *** andreap has quit IRC |
| 18:08:50 | *** k-joseph_ has joined #openmrs |
| 18:09:08 | * k-joseph_ slaps k-joseph_ with a big red brick |
| 18:10:26 | <dkayiwa> dilangamachchige: hi |
| 18:10:52 | *** k-joseph has quit IRC |
| 18:11:42 | *** k-joseph_ has quit IRC |
| 18:12:15 | *** k-joseph has joined #openmrs |
| 18:17:06 | *** suranga has joined #openmrs |
| 18:17:06 | *** ChanServ sets mode: +v suranga |
| 18:18:58 | <suranga> dkayiwa, howdy. COuld you please share with me how you add your nexus credentials into your settings.xml ? :) |
| 18:38:08 | *** r0bby has quit IRC |
| 18:43:06 | <dkayiwa> hi suranga |
| 18:43:26 | <suranga> dkayiwa, howdy. sorry, this must be pretty late in your time :-) |
| 18:43:42 | <dkayiwa> suranga: am not am morning worker :) |
| 18:44:13 | <suranga> dkayiwa, it must be like 9 pm your local time right ? |
| 18:44:15 | <dkayiwa> suranga: i put those tips here: https://wiki.openmrs.org/display/docs/Release+Process |
| 18:44:24 | <dkayiwa> suranga: under the troubleshooting section |
| 18:44:37 | <dkayiwa> suranga: about to be 10pm |
| 18:44:57 | <suranga> dkayiwa, aha, so <server> |
| 18:44:57 | <suranga> Â Â Â <id>openmrs-repo-modules</id> |
| 18:44:57 | <suranga> Â Â Â <username>username</username> |
| 18:44:58 | <suranga> Â Â Â <password>password</password> |
| 18:44:58 | <suranga> </server> is the way to go :-) |
| 18:45:58 | <suranga> dkayiwa, i seem to be having trouble logging into nexus. the login keeps ending with no result, but I guess this is a temporary glitch, so I'll try again later :) |
| 18:46:14 | <dkayiwa> suranga: ok |
| 18:57:52 | <jkeiper> djazayeri, know who owns EVNT? |
| 19:01:17 | *** dilangamachchige has quit IRC |
| 19:29:36 | *** k-joseph has quit IRC |
| 19:31:14 | <dkayiwa> jkeiper: maybe bwolfe :) |
| 19:41:10 | <djazayeri> jkeiper: we all own it, as the OpenMRS community |
| 19:53:44 | *** k-joseph has joined #openmrs |
| 19:54:36 | <djazayeri> jkeiper: if you're wondering whether it's okay to make changes along the lines of what we talked to on yesterday's design call, I think we're empowered to. |
| 19:54:50 | <djazayeri> jkeiper: I haven't looked at the pull request directly. |
| 20:03:12 | *** cpower has joined #openmrs |
| 20:03:19 | <cpower> Hello! |
| 20:03:36 | <cpower> Let us Scrum |
| 20:03:42 | <cpower> !scrumon cpower |
| 20:03:42 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 20:04:11 | <cpower> Order: wyclif, dkayiwa, suranga, jkeiper, djazayeri and I'll start with Andrea's which was emailed in |
| 20:04:21 | <cpower> Wednesday |
| 20:04:21 | <cpower> TRUNK-2768 |
| 20:04:21 | <cpower> Made all changes suggested by Rafal |
| 20:04:21 | <cpower> Only 1 test in error now (were 28) |
| 20:04:21 | <cpower> Thursday |
| 20:04:21 | <cpower> Dev call |
| 20:04:21 | <cpower> Made another change suggested by Rafal to fix the test still en error. |
| 20:04:22 | <cpower> Problem with work computer (again). |
| 20:04:22 | <cpower> Have not been able to test change yet. |
| 20:04:23 | <cpower> Finish remaining JSPs for TRUNK-2768 |
| 20:04:23 | <cpower> No blockers |
| 20:04:38 | <wyclif> Wednesday: |
| 20:04:38 | <wyclif> RC-4 - Send notification of registration via Event Module |
| 20:04:38 | <wyclif> Addressed review TODOs for RC-2 - Add service method to process a registration event |
| 20:04:38 | <wyclif> design call |
| 20:04:38 | <wyclif> Revisted EVNT-25 to make changes as per design call - Extend EventEngine.fireEvent to allow more data in message |
| 20:04:40 | <wyclif> |
| 20:04:42 | <wyclif> Thursday: |
| 20:04:44 | <wyclif> Dev call |
| 20:04:46 | <wyclif> TODO items from wednesday 12/19/2012 design call |
| 20:04:48 | <wyclif> RC-6 - Expose registration method via REST |
| 20:04:50 | <wyclif> |
| 20:04:52 | <wyclif> Blockers: None |
| 20:04:55 | <dkayiwa> Looked into: Allow modules to provide a registration validator - RC-7 |
| 20:04:55 | <dkayiwa> Reviewed: Missing Validators for relationship_type - TRUNK-3814 |
| 20:04:56 | <dkayiwa> Committed: NonUniqueObjectException: a different object with the same identifier value was already associated with the session: [org.openmrs.Patient#] - TRUNK-3728 |
| 20:04:56 | <dkayiwa> Committed: Cannot Create a new patient with the same person object registered as user - TRUNK-2528 |
| 20:04:56 | <dkayiwa> Dev Call |
| 20:04:56 | <dkayiwa> Now working on: ModuleException: A servlet mapping with name PatientImageSave is already in use - TRUNK-3685 |
| 20:04:57 | <dkayiwa> No Blockers |
| 20:05:48 | <cpower> suranga |
| 20:06:06 | <cpower> ok, next! |
| 20:06:10 | <cpower> jkeiper |
| 20:07:11 | <jkeiper> sry |
| 20:07:27 | <jkeiper> today: meetings. tomorrow: RC docs ... need to work w/ wyclif on REST |
| 20:07:34 | <jkeiper> blocker: none |
| 20:07:39 | <cpower> dj |
| 20:07:42 | <cpower> djazayeri |
| 20:07:49 | <djazayeri> * Mirebalais, integrating HTML Form Entry with the EMR module |
| 20:07:50 | <djazayeri> * Registration: some design conversations and code review |
| 20:07:51 | <djazayeri> * calls |
| 20:07:52 | <djazayeri> no blockers |
| 20:08:12 | <cpower> ok no blockers, no discussion points |
| 20:08:16 | <cpower> !scrumoff |
| 20:08:16 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:09:33 | <djazayeri> dkayiwa: about the ticket about turning a person stub into a patient... |
| 20:09:55 | <dkayiwa> djazayeri: am commiting another solution |
| 20:10:07 | <djazayeri> dkayiwa: I would propose trying to solve this in the DAO layer in the RC module first, and then we can use that to inform how we solve it in core. |
| 20:10:27 | <djazayeri> dkayiwa: though if you think you can solve it in core without side-effects, I guess that's fine. |
| 20:10:36 | <dkayiwa> djazayeri: ok |
| 21:00:00 | <cpower> hello, who's our community developer this week? |
| 21:01:08 | *** k-joseph has quit IRC |
| 21:01:39 | <dkayiwa> cpower: i completely have no idea :) |
| 21:02:10 | <cpower> that would be a #fail on me I figure... |
| 21:03:58 | <cpower> so I know there is a rotation and wyclif and rafal where it till the 4th... |
| 21:05:30 | <cpower> that leaves you dkayiwa, and who else is usually apart of this rotation? |
| 21:05:43 | <dkayiwa> cpower: all core devs :) |
| 21:05:58 | <wyclif> dkayiwa, you probably want to make the fix as part of https://tickets.openmrs.org/browse/RC-9 |
| 21:06:25 | <wyclif> dkayiwa, as djazayeri suggested, did you see all my comments |
| 21:06:56 | <dkayiwa> wyclif: i have just seen them now :) |
| 21:07:09 | <dkayiwa> wyclif: was not checking email :) |
| 21:08:19 | <wyclif> djazayeri, you patientId wont be null when updating or promoting a person to patient, meaning the eviction will happen in both cases, do we really want to happen for an update |
| 21:08:53 | <dkayiwa> wyclif: was that meant for me? |
| 21:08:57 | <dkayiwa> :0 |
| 21:08:58 | <dkayiwa> :) |
| 21:09:02 | <wyclif> dkayiwa, yes |
| 21:09:17 | <wyclif> dkayiwa, you both start with d |
| 21:09:47 | <dkayiwa> wyclif: the eviction does not happen because of: SELECT * FROM patient WHERE patient_id = ? |
| 21:10:14 | <dkayiwa> wyclif: did you see that section of code which set the value of stubInsertNeeded to true? |
| 21:11:17 | <dkayiwa> wyclif: meaning stubInsertNeeded will be true (and hence that code executed) only when there is not patient record for a person |
| 21:14:25 | *** suranga has quit IRC |
| 21:16:58 | <djazayeri> dkayiwa, wyclif: I'm a bit confused actually, about the whole way that the inheritence works |
| 21:17:36 | <djazayeri> my understanding is that if I were to do "from Order", this is going to return a list of things, some of which are plain Orders, and some of which are DrugOrders. |
| 21:17:40 | <dkayiwa> djazayeri: hibernate does not allow promoting from base to subclass |
| 21:17:45 | <djazayeri> dkayiwa, wyclif: is that your understanding too? |
| 21:17:56 | <djazayeri> oh, hmm, we're talking about promoting... |
| 21:18:09 | <dkayiwa> djazayeri: yes just promoting |
| 21:18:47 | <dkayiwa> djazayeri: from the hibernate forum, they say that just like you cannot cast a base class to subclass in java :) |
| 21:20:13 | <djazayeri> dkayiwa: I see. I may be looking at the same topic. :-) |
| 21:20:23 | <dkayiwa> :) |
| 21:21:12 | *** lh has joined #openmrs |
| 21:21:13 | *** lh has joined #openmrs |
| 21:21:41 | <wyclif> djazayeri, yeah |
| 21:22:00 | <wyclif> djazayeri, hibernate freaks when promoting form superclass to subclass |
| 21:22:09 | <djazayeri> the suggestion there is to manually insert into the subclass table, and evict |
| 21:22:20 | <djazayeri> what are we doing? |
| 21:22:22 | <dkayiwa> djazayeri: exactly :) |
| 21:22:33 | <wyclif> djazayeri, that is why he needs to evict the superclass instance(person) which hibernate is seeing as a duplicate |
| 21:22:43 | <dkayiwa> wyclif: correct |
| 21:23:06 | <wyclif> djazayeri, you evist first and then instead the patient |
| 21:23:15 | <wyclif> djazayeri, you evist first and then instead save the patient |
| 21:23:28 | <dkayiwa> djazayeri: wyclif there was another suggestion of deleting the base class record first and insert child. But that could lead to errors and foreign key constraint errors |
| 21:23:31 | <djazayeri> where's the current code snippet? |
| 21:23:36 | <djazayeri> that would be bad |
| 21:23:59 | <wyclif> dkayiwa, i want to agree with djazayeri that we probably then dont need that call toinsert a dummy patient row, because it is not actually doing its jo |
| 21:24:05 | <wyclif> jo -> job |
| 21:24:11 | <djazayeri> did I say that? |
| 21:24:23 | <dkayiwa> wyclif: you mean it is not actually inserting the record? |
| 21:24:33 | <djazayeri> Deleting the Person first then saving the Patient would be bad, is all I said |
| 21:24:42 | <dkayiwa> djazayeri: :) |
| 21:25:19 | <djazayeri> dkayiwa: where can I see the current solution you're proposing? |
| 21:25:33 | <wyclif> djazayeri, the problem i have with the what we are doing is that it will always evict the person even on an update |
| 21:25:47 | <dkayiwa> djazayeri: i just made another pull request |
| 21:26:00 | <dkayiwa> wyclif: it only happens for a person without a patient record |
| 21:26:07 | <wyclif> dkayiwa, nope |
| 21:26:27 | <wyclif> dkayiwa, that logic you put it in the else close, right? |
| 21:26:44 | <dkayiwa> wyclif: the code is under this: if (stubInsertNeeded) { |
| 21:27:15 | <dkayiwa> wyclif: and stuInserNeeded is only true when this returns a record: SELECT * FROM patient WHERE patient_id = ? |
| 21:27:54 | <dkayiwa> wyclif: can i merge and you see it all? |
| 21:28:07 | <wyclif> dkayiwa, ah i have seen it |
| 21:28:12 | <dkayiwa> wyclif: ok |
| 21:29:47 | <wyclif> the the solution seems fine to me |
| 21:29:54 | <dkayiwa> wyclif: ok |
| 21:30:10 | <dkayiwa> wyclif: am now adding another unit test for the other scenario you talked about |
| 21:30:14 | <djazayeri> I'm just wondering whether we want to make this more of an explicit thing that client code has to do |
| 21:30:26 | <dkayiwa> djazayeri: why? |
| 21:30:31 | <djazayeri> e.g. is it really correct to say: |
| 21:30:51 | <djazayeri> patientService.savePatient(new Patient(personStub)); |
| 21:30:57 | <wyclif> djazayeri, asre you saying to provide a service method to create a patient from a person |
| 21:31:00 | <djazayeri> or is it more appropriate to have an explicit method for this like: |
| 21:31:24 | <wyclif> djazayeri, i would prefer that |
| 21:31:27 | <djazayeri> patientService.createPatientFromPerson(personStub) -> returns Patient |
| 21:31:58 | <wyclif> djazayeri, thay we can get rid of that logic for inserting a stub |
| 21:32:00 | <djazayeri> the problem with this, though, is that it would lead to an invalid patient (e.g. with no PatientIdentifier) |
| 21:32:43 | <wyclif> djazayeri, we just need to add another parameter for the list of identifiers to the method |
| 21:32:57 | <djazayeri> so maybe it would need to be phrased as: Patient PstientService.createPatientFromPersonStub(Person stub, Patient copyPatientSpecificFieldsFromMe) |
| 21:33:17 | <dkayiwa> djazayeri: wyclif can you guys create a ticket for that with the proposal? |
| 21:33:20 | <wyclif> djazayeri, PstientService.createPatientFromPersonStub(Person stub, List identifiers) |
| 21:34:08 | <wyclif> djazayeri, as you said, can we actually implement this first in the registrationcore module |
| 21:34:16 | <djazayeri> wyclif: in case someday there are more required fields on Patient that aren't on Person, I'd rather have it take a Person and a Patient, rather than a Person and a List<PatientIdentifier> |
| 21:37:24 | <djazayeri> dkayiwa: I agree with Wyclif: do this as part of the existing RC ticket, and then email the dev list proposing this change to core. |
| 21:37:54 | <wyclif> dkayiwa, see RC-9 |
| 21:38:30 | <dkayiwa> djazayeri: wyclif i have not understood the proposal. That is why i wanted you guys to curate that ticket more :) |
| 21:39:30 | *** lh has quit IRC |
| 21:39:32 | <djazayeri> dkayiwa: the proposal is that for now we make no changes to PatientService.savePatient. Instead we add a new "createPatientRecordForPerson" method which handles this case explicitly. |
| 21:39:39 | <wyclif> dkayiwa, i will update RC-9 and assign it to you |
| 21:39:42 | *** jkeiper has quit IRC |
| 21:39:44 | <djazayeri> cool, thanks wyclif |
| 21:40:02 | <wyclif> dkayiwa, so dont merge that patch to master |
| 21:40:14 | <dkayiwa> djazayeri: would the back port to older versions of openmrs require the new method? |
| 21:40:41 | <wyclif> dkayiwa, i think it okay to backport a fix even if it introduces a new method |
| 21:40:46 | <djazayeri> dkayiwa: I would write the method in RegistrationCoreDAO |
| 21:41:06 | <djazayeri> dkayiwa: but yeah, when we decide to move it to core, we should backport the new method. |
| 21:41:07 | <dkayiwa> djazayeri: meaning whoever needs the fix must use that module? |
| 21:41:40 | <djazayeri> dkayiwa: while I _think_ that this is the right approach, it feels to me like something that might have ramifications we haven't thought of yet |
| 21:41:51 | <dkayiwa> djazayeri: ok |
| 21:42:09 | <djazayeri> dkayiwa: so I'm suggesting that initially we implement this DAO method in the module, and then email saying "hey, we want to add this to core. thoughts?" |
| 21:42:21 | <dkayiwa> djazayeri: ok |
| 21:42:54 | <dkayiwa> djazayeri: so it simply takes a patient object and does exactly as i had made the savePatient method behave? |
| 21:43:14 | <dkayiwa> wyclif: ^^ |
| 21:43:22 | <djazayeri> dkayiwa: no, it will take a Person and a Patient, but I think Wyclif will write this on the ticket |
| 21:43:35 | <dkayiwa> djazayeri: ok |
| 21:43:50 | <dkayiwa> !ticket RC-9 |
| 21:43:51 | <OpenMRSBot> dkayiwa: [#RC-9] Add wasAPerson key values to event message - OpenMRS JIRA - https://tickets.openmrs.org/browse/RC-9 |
| 21:46:23 | <wyclif> djazayeri, dkayiwa i have rephrases https://tickets.openmrs.org/browse/RC-9 |
| 21:46:34 | <dkayiwa> wyclif: ok |
| 21:46:39 | <wyclif> rephrases -> rephrased |
| 21:46:43 | <djazayeri> wyclif: typo in summary. :-) |
| 21:47:05 | *** djazayeri has left #openmrs |
| 21:47:22 | <wyclif> edited it, thanks! |
| 21:52:10 | *** dkayiwa has quit IRC |
| 21:57:30 | *** lh has joined #openmrs |
| 22:11:20 | *** lh has quit IRC |
| 22:22:16 | *** r0bby has joined #openmrs |
| 22:22:16 | *** ChanServ sets mode: +v r0bby |
| 22:26:20 | *** lh has joined #openmrs |
| 22:45:01 | *** lh has quit IRC |
| 23:03:07 | *** wyclif has quit IRC |
| 23:22:18 | *** lh has joined #openmrs |
| 23:22:18 | *** lh has joined #openmrs |
| 23:57:59 | *** wyclif has joined #openmrs |