| 00:25:51 | <andreapat> djazayeri, changes made - still errors in 28 tests - on same line in PatientServiceImpl: mergedData.setPriorDateOfDeathEstimated(preferred.getDeathdateEstimated()); |
| 00:35:40 | *** andreapat has quit IRC |
| 00:50:23 | *** andreapat has joined #openmrs |
| 01:05:03 | *** andreapat has quit IRC |
| 01:34:29 | *** robbyoconnor is now known as r0bby |
| 01:35:12 | *** r0bby is now known as robbyoconnor |
| 03:06:37 | *** Mkop1 has joined #openmrs |
| 03:06:37 | *** ChanServ sets mode: +v Mkop1 |
| 03:13:23 | *** Mkop1 has quit IRC |
| 03:26:47 | *** Mkop1 has joined #openmrs |
| 03:26:47 | *** ChanServ sets mode: +v Mkop1 |
| 04:56:44 | *** kishoreyekkanti has joined #openmrs |
| 05:20:14 | *** Mkop1 has quit IRC |
| 05:25:27 | *** kishoreyekkanti_ has joined #openmrs |
| 06:26:30 | *** jkeiper has quit IRC |
| 06:29:44 | *** jkeiper has joined #openmrs |
| 06:29:44 | *** ChanServ sets mode: +v jkeiper |
| 07:16:22 | *** djazayeri has quit IRC |
| 07:46:21 | *** djazayeri has joined #openmrs |
| 07:46:21 | *** ChanServ sets mode: +o djazayeri |
| 08:00:47 | *** suranga has joined #openmrs |
| 08:00:47 | *** ChanServ sets mode: +v suranga |
| 08:05:31 | *** dkayiwa has joined #openmrs |
| 08:34:11 | <suranga> good morning dkayiwa |
| 08:34:20 | <dkayiwa> suranga: morning |
| 08:34:25 | <suranga> dkayiwa, is this too early in the morning to bother you ? :P |
| 08:35:31 | <dkayiwa> suranga: here is the formula: dkayiwa online = ready for anything :) |
| 08:35:47 | <suranga> dkayiwa, im really sorry , but ive got this problem :( |
| 08:35:56 | <suranga> dkayiwa, im trying to do a maven release |
| 08:36:02 | <suranga> as specified on the wiki page |
| 08:36:28 | <suranga> but no matter how I try, the pushing of the updated code hangs , and the release fails :( |
| 08:36:57 | <dkayiwa> suranga: which command? |
| 08:37:29 | <suranga> dkayiwa, |
| 08:37:29 | <suranga> mvn -Dusername=yourusername -Dpassword=yourpassword release:prepare |
| 08:37:49 | <suranga> dkayiwa, the username password are our github ones, arnt they ? |
| 08:38:16 | <dkayiwa> suranga: no :) |
| 08:39:02 | <dkayiwa> suranga: can you log on our nexus maven repo |
| 08:43:46 | <suranga> dkayiwa, hmmm.... it seems that my credentials dont match. thats a pity, because I re-use the same credentials to everything :P |
| 08:46:12 | <suranga> dkayiwa, im sorry, but how can I create a new nexus account ? I cant see a sign up link on http://mavenrepo.openmrs.org/nexus/index.html#welcome :-( |
| 08:48:11 | <dkayiwa> suranga: send Michael an ITSM :) |
| 08:48:59 | <suranga> dkayiwa, I see. so in summary. I cant release because im a silly fellow witout a nexus account, is it ? :P |
| 08:49:28 | <suranga> dkayiwa, when did they make this change to use nexus ? I remember making a release 2-3 months back ? :) |
| 08:49:49 | <dkayiwa> suranga: oh then in that case i am wrong :) |
| 08:50:05 | <dkayiwa> suranga: did you upload your artifacts to nexus? |
| 08:50:23 | <suranga> dkayiwa, im trying to release the hl7query module |
| 08:51:04 | <suranga> dkayiwa, its on github, but not on nexus, I think :( |
| 08:51:21 | <dkayiwa> suranga: for nexus you need an account |
| 08:51:48 | <dkayiwa> suranga: but the command you are issuing requires no nexus |
| 08:51:59 | <dkayiwa> suranga: not so? |
| 08:52:08 | <suranga> dkayiwa, if you're releasing something thats not on nexus, which credentials do you use ? |
| 08:52:34 | <suranga> dkayiwa, for the username/password on the mvn release:prepare command ? :) |
| 08:52:51 | <dkayiwa> suranga: does it ask you for user name and password? |
| 08:52:59 | <suranga> dkayiwa, um.. no |
| 08:53:10 | <dkayiwa> suranga: i think that should work |
| 08:53:25 | <suranga> dkayiwa, i tried with and without the credentials, but in both cases it seems to hang :( |
| 08:53:51 | <dkayiwa> suranga: have you ever successfully used the same command? |
| 08:54:08 | <suranga> dkayiwa, I belive so,... |
| 08:54:20 | <dkayiwa> suranga: for another module? |
| 08:55:35 | <suranga> dkayiwa, im afraid not |
| 08:55:48 | <suranga> dkayiwa, maybe we can ask rafa when he signs in ? |
| 08:55:54 | <dkayiwa> suranga: you easily get afraid :) |
| 08:55:58 | <dkayiwa> suranga: ok |
| 08:56:09 | <suranga> dkayiwa, its professional worry :P |
| 08:56:19 | <suranga> dkayiwa, rafa is not on leave, is he ? |
| 08:57:30 | <dkayiwa> suranga: he is not |
| 09:52:45 | *** travis-ci has joined #openmrs |
| 09:52:45 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [08278ec] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3735255 |
| 09:52:45 | *** travis-ci has left #openmrs |
| 09:52:48 | <OpenMRSBot> <http://ln-s.net/+JRz> (at travis-ci.org) |
| 10:31:01 | *** kavuri has joined #openmrs |
| 10:31:53 | <kavuri> dkayiwa: hi |
| 10:32:01 | <dkayiwa> kavuri: hi |
| 10:32:23 | <kavuri> dkayiwa: about the bug of updating address using REST |
| 10:32:32 | <dkayiwa> kavuri: aha |
| 10:34:55 | <kavuri> dkayiwa: you mentioned that you have something you might want to check with me |
| 10:35:47 | <dkayiwa> kavuri: can you give me a couple of minutes? :) |
| 10:35:52 | <kavuri> dkayiwa: sure |
| 10:46:45 | *** rafa has joined #openmrs |
| 10:46:45 | *** ChanServ sets mode: +v rafa |
| 11:13:15 | *** ibewes has joined #openmrs |
| 11:43:17 | *** djazayeri has quit IRC |
| 11:50:17 | <dkayiwa> hi kavuri |
| 12:01:58 | <kavuri> dkayiwa: hi |
| 12:02:16 | <dkayiwa> kavuri: which ticket number was it |
| 12:02:52 | <kavuri> dkayiwa: https://tickets.openmrs.org/browse/RESTWS-314 |
| 12:03:01 | <dkayiwa> kavuri: ok |
| 12:08:03 | *** rafa has quit IRC |
| 12:09:48 | <jkeiper> dkayiwa, hello there |
| 12:09:57 | <dkayiwa> jkeiper: hi |
| 12:10:07 | <jkeiper> :-) |
| 12:10:13 | <dkayiwa> jkeiper: :) |
| 12:10:17 | <jkeiper> hi |
| 12:10:18 | <jkeiper> heheh |
| 12:10:22 | <dkayiwa> jkeiper: hey |
| 12:10:28 | <jkeiper> dkayiwa, yo |
| 12:10:34 | <dkayiwa> jkeiper: yeyeye |
| 12:10:38 | <jkeiper> hahah |
| 12:10:44 | <dkayiwa> jkeiper: hohoohoh |
| 12:10:49 | <jkeiper> oh no |
| 12:10:54 | <jkeiper> dkayiwa == st. nick |
| 12:11:00 | <dkayiwa> jkeiper: oh yes d:) |
| 12:11:12 | <jkeiper> haha |
| 12:11:42 | <jkeiper> so ... i ran into a strange mockito issue |
| 12:11:47 | <jkeiper> perhaps i'm using it wrong |
| 12:11:47 | <dkayiwa> aha |
| 12:12:19 | <jkeiper> but i have a line in my setup() that returns a private List<Obs> if a certain method is called on a service |
| 12:12:43 | <jkeiper> and it only retains the first obs i gave it |
| 12:12:50 | *** robbyoconnor has quit IRC |
| 12:13:00 | <dkayiwa> ok |
| 12:13:02 | <jkeiper> even though the obs list is created fresh in setup() |
| 12:13:20 | <jkeiper> i have an addObs() method in the test that will add to the obs list |
| 12:13:26 | <jkeiper> and this works in other tests ... |
| 12:13:27 | <jkeiper> heh |
| 12:13:30 | <dkayiwa> ok |
| 12:13:31 | <jkeiper> not in the same class though |
| 12:14:06 | <jkeiper> hrm, perhaps i should just show you ... |
| 12:14:11 | <dkayiwa> ok |
| 12:14:32 | * jkeiper likes talking to an "ok robot" |
| 12:16:28 | <jkeiper> dkayiwa, this is the test: https://github.com/jlkeiper/openmrs-module-amrsreports/blob/588f37712de1bb64e02dfc84a3940acfaa187040/api/src/test/java/org/openmrs/module/amrsreport/rule/collection/MohPEPStartStopDateRuleTest.java |
| 12:16:32 | <OpenMRSBot> <http://ln-s.net/+JU9> (at github.com) |
| 12:16:35 | <dkayiwa> ok |
| 12:17:57 | <jkeiper> dkayiwa, this is the output it generates (until the first assertion error): http://pastebin.com/5AcGRpvs |
| 12:18:05 | <dkayiwa> ok |
| 12:19:07 | <jkeiper> so, it clearly builds the list of concepts right ... the "...#:#" lines are coming from the rule itself when it evaluates. it thinks that every time I am sending an obs with concept:0, answer:6. |
| 12:19:38 | <jkeiper> but each test adds a single obs to the list and the list always has just 1 member |
| 12:20:05 | <dkayiwa> jkeiper: and you wanted to add more obs? |
| 12:20:07 | <jkeiper> so i wonder, am i using mockito wrong? should the line for mocking that service call be in each test? |
| 12:20:32 | <jkeiper> dkayiwa, no i just want the currentObs variable to be used as the mocked response every time it is called |
| 12:20:42 | <dkayiwa> ok |
| 12:20:45 | <jkeiper> dkayiwa, but i think it is just taking the first instance of when it was called |
| 12:20:55 | <jkeiper> since that instance was correct with 0:6 |
| 12:22:02 | <jkeiper> dkayiwa, essentially i want to know if line #92 is where it should be ... or if I should have it in each test or what |
| 12:22:18 | <dkayiwa> ok |
| 12:23:33 | <jkeiper> so confusing! |
| 12:23:43 | <jkeiper> although your commentary has been very helpful ;-) |
| 12:24:00 | <dkayiwa> jkeiper: ahahahaha. still looking :) |
| 12:24:05 | <jkeiper> haha |
| 12:27:08 | <jkeiper> perhaps results are being cached ... idk |
| 12:28:28 | <ibewes> greetings all |
| 12:29:39 | <ibewes> I'm getting ready to release an updated version of the Jasper module which has been Mavenized and updated to work with 1.9.x but I've noticed one issue... |
| 12:30:30 | <ibewes> the resulting omod is pretty large at 23MB, mostly because of all the jasper dependencies. Should all those be included in the omod? |
| 12:31:32 | <dkayiwa> jkeiper: so is the problem that the obsList does not contain the obs you added for each test? |
| 12:38:21 | <dkayiwa> ibewes: thats too big |
| 12:38:29 | <dkayiwa> ibewes: i smell something wrong |
| 12:38:39 | <ibewes> dkayiwa: that's what I was thinking |
| 12:38:49 | <dkayiwa> ibewes: is it in github? |
| 12:39:03 | <ibewes> yeah: https://github.com/OpenHMIS/openmrs-module-jasperreports/tree/maven |
| 12:39:06 | <OpenMRSBot> <http://ln-s.net/+JUK> (at github.com) |
| 12:39:08 | <jkeiper> ibewes, karibu |
| 12:39:25 | <ibewes> jkeiper: hey there! |
| 12:40:08 | <jkeiper> dkayiwa, the problem is that the list of obs as i have set it for each test is apparently not pulled each time the rule is run ... instead it just gets the list as it is first requested |
| 12:41:59 | <dkayiwa> jkeiper: why don't you pass the list as a parameter in addObs() instead of making it a class level variable? |
| 12:42:33 | <jkeiper> dkayiwa, i have tried several permutations ... even setting the mock.when().thenReturn() for each test |
| 12:42:58 | <jkeiper> dkayiwa, i am about to try instantiating the rule each time i ask for a result |
| 12:43:00 | <ibewes> jkeiper: almost all the size is the jasper maven dependencies (in the lib folder of the omod) |
| 12:43:15 | <jkeiper> ibewes, >> dkayiwa |
| 12:44:00 | <ibewes> jkeiper: oops... thanks :) |
| 12:44:10 | <jkeiper> :-) |
| 12:44:19 | <ibewes> dkayiwa: almost all the size is the jasper maven dependencies (in the lib folder of the omod) |
| 12:45:23 | <dkayiwa> ibewes: your module is not mavenized |
| 12:45:42 | <ibewes> dkayiwa: look at the maven branch |
| 12:48:12 | <ibewes> Off-topic: does anyone have a suggestion for a good IRC client on Ubuntu? I'm using Smuxi and finding it rather underwhelming... |
| 12:55:20 | <jkeiper> ibewes, xchat |
| 12:57:09 | <ibewes> jkeiper: thanks, i'll give that a try |
| 12:57:19 | <jkeiper> np |
| 12:57:20 | <jkeiper> :-) |
| 12:58:08 | <dkayiwa> hi kavuri |
| 12:58:14 | <kavuri> dkayiwa: hi |
| 12:58:27 | <dkayiwa> kavuri: have you created a unit test for this? |
| 12:58:34 | <kavuri> dkayiwa: there is already a unit testcase |
| 12:58:38 | <kavuri> dkayiwa: and it passes |
| 12:58:48 | <dkayiwa> kavuri: can you create one that fails? |
| 12:58:48 | <kavuri> dkayiwa: but the data does not get saved in the database |
| 12:58:57 | <kavuri> dkayiwa: it is not possible :) |
| 12:59:04 | <kavuri> dkayiwa: because, it always succeeds |
| 12:59:13 | <dkayiwa> kavuri: which test is that |
| 12:59:22 | <kavuri> dkayiwa: some layer in openmrs returns wrong status |
| 12:59:27 | <kavuri> dkayiwa: or does not do its job |
| 12:59:29 | *** ibewes has quit IRC |
| 12:59:32 | <dkayiwa> kavuri: which test |
| 13:00:32 | <kavuri> dkayiwa: public void shouldEditIAnAddress() throws Exception |
| 13:00:42 | <kavuri> dkayiwa: mentioned this in the bug report |
| 13:01:08 | <dkayiwa> kavuri: there are so many methods in many classes :) |
| 13:01:13 | *** ibewes has joined #openmrs |
| 13:02:55 | <kavuri> dkayiwa: :) |
| 13:03:15 | <dkayiwa> kavuri: so i do not know which |
| 13:05:48 | <kavuri> dkayiwa: it is omod/src/test/java/org/openmrs/module/webservices/rest/web/v1_0/controller/PersonAddressControllerTest.java |
| 13:06:02 | <kavuri> dkayiwa: and method is public void shouldEditIAnAddress() |
| 13:06:10 | <kavuri> dkayiwa: in the openmrs-webservices-rest module |
| 13:07:06 | <dkayiwa> kavuri: ok |
| 13:12:57 | <dkayiwa> kavuri: how do you tell that address in not updated |
| 13:14:53 | <kavuri> dkayiwa: I checked the database |
| 13:15:04 | <kavuri> dkayiwa: and also when I did a patient GET, I got old values |
| 13:15:30 | <dkayiwa> kavuri: can i just use your exact data to reproduce |
| 13:16:15 | <kavuri> dkayiwa: sure, but it does not really matter. You can use any data with the curl (that I posted in the bug report) |
| 13:16:21 | <kavuri> dkayiwa: but let me provide it to you |
| 13:16:37 | <dkayiwa> kavuri: pastebin |
| 13:16:41 | <kavuri> dkayiwa: hmm..infact the exact data is in the bug report |
| 13:24:37 | *** k-joseph has joined #openmrs |
| 13:26:53 | * suranga looks for rafa |
| 13:29:45 | <k-joseph> dkayiwa: hi |
| 13:36:06 | *** jkeiper has quit IRC |
| 13:40:33 | <kavuri> dkayiwa: would be out for sometime. Will try to login again after sometime |
| 13:42:12 | <dkayiwa> kavuri: like after how long? |
| 13:43:06 | <dkayiwa> hi k-joseph |
| 13:43:47 | <kavuri> dkayiwa: 2hrs |
| 13:43:53 | <dkayiwa> kavuri: ok |
| 13:43:57 | <kavuri> dkayiwa: c u |
| 13:44:02 | <dkayiwa> kavuri: see ya |
| 13:44:04 | *** kavuri has quit IRC |
| 13:45:24 | *** wyclif_ has quit IRC |
| 13:46:05 | <k-joseph> dkayiwa: i was left hanging yesturday, at TRUNK-2449, i mean i didnt know how to continue from the point where you left me |
| 13:46:26 | <dkayiwa> k-joseph: ok let me look at it and guide you accordingly |
| 13:46:33 | <dkayiwa> !ticket TRUNK-2449 |
| 13:46:34 | <OpenMRSBot> dkayiwa: [#TRUNK-2449] Make Max Number of Encounters on Dashboard Configurable - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2449 |
| 13:46:39 | <k-joseph> dkayiwa: thank you |
| 13:46:54 | <dkayiwa> k-joseph: can you run openmrs in debug mode? |
| 13:47:04 | <k-joseph> dkayiwa: ok |
| 13:51:34 | <dkayiwa> k-joseph: you will tell me after it has run |
| 13:52:17 | <k-joseph> dkayiwa: its takinh long but i think in just a few secs |
| 13:52:23 | <dkayiwa> k-joseph: ok |
| 13:57:01 | <k-joseph> dkayiwa: as am waiting for openmrs to run in the browser, am already in debug mode |
| 13:57:18 | <dkayiwa> k-joseph: can you login? |
| 13:57:48 | <k-joseph> dkayiwa: not yet opening in the browser |
| 13:58:16 | <dkayiwa> k-joseph: it only the standalone which opens the browser for you |
| 13:58:29 | <dkayiwa> k-joseph: otherwise you need to open the browser yourself |
| 13:59:17 | <k-joseph> dkayiwa: yes, i did that already, but openmrs is not ready from eclipse to run there |
| 13:59:40 | <dkayiwa> k-joseph: but does it show in eclipse that it is loading? |
| 14:00:31 | <k-joseph> dkayiwa: yes, it is here now, taking so much time here: 2012-12-19 16:53:45.977::INFO: No Transaction manager found - if your webapp requires one, please configure one. |
| 14:01:05 | <dkayiwa> k-joseph: does it normally take that long? |
| 14:01:31 | <k-joseph> dkayiwa: no, am used to runing it not in debug mode\ |
| 14:02:08 | <dkayiwa> k-joseph: ok stop and run it again in non debug mode |
| 14:02:23 | <k-joseph> dkayiwa: ok please |
| 14:04:11 | <k-joseph> dkayiwa: i have done that and logged in already |
| 14:04:32 | <dkayiwa> k-joseph: what value does your global property for yesterday have? |
| 14:04:46 | <k-joseph> dkayiwa: 2 |
| 14:05:09 | <dkayiwa> k-joseph: now go to the patient dashboard and tell me how many encounters are shown |
| 14:06:24 | *** suranga has quit IRC |
| 14:06:55 | <k-joseph> dkayiwa: 1 visit with encounter, and three with no encounters |
| 14:07:20 | <dkayiwa> k-joseph: how many under the FormEntry tab? |
| 14:07:49 | <k-joseph> dkayiwa: one |
| 14:09:11 | <k-joseph> dkayiwa: i think i should try this in openmrs-standalone with quite some much data, am opening it now |
| 14:09:44 | <dkayiwa> k-joseph: no |
| 14:09:59 | <dkayiwa> k-joseph: i want to use the other one which has one encounter |
| 14:09:59 | <k-joseph> dkayiwa: ok |
| 14:10:10 | <dkayiwa> k-joseph: can you create 5 new encounters for this patient? |
| 14:10:28 | <k-joseph> dkayiwa: ok |
| 14:10:40 | <dkayiwa> k-joseph: tell me when you are done |
| 14:10:53 | <k-joseph> dkayiwa: yes i will |
| 14:11:15 | <dkayiwa> k-joseph: ok good |
| 14:17:27 | *** jkeiper has joined #openmrs |
| 14:17:27 | *** ChanServ sets mode: +v jkeiper |
| 14:21:43 | *** downey has joined #openmrs |
| 14:21:43 | *** ChanServ sets mode: +o downey |
| 14:26:09 | <k-joseph> dkayiwa: i have created anew patient and added three encounters, and all are seen in the dashboard |
| 14:26:15 | *** wyclif_ has joined #openmrs |
| 14:26:33 | <dkayiwa> k-joseph: make them five |
| 14:26:45 | <k-joseph> dkayiwa: ok then |
| 14:29:39 | *** ibewes has quit IRC |
| 14:32:50 | <k-joseph> dkayiwa: have created eight, and i see all the eight under visits in the patient dashboard, and only three under Form Entry |
| 14:33:29 | <dkayiwa> k-joseph: on can you go under settings -> visits, and then set the value for visits enabled to false |
| 14:36:00 | <k-joseph> dkayiwa: do that |
| 14:36:15 | <dkayiwa> k-joseph: meaning? |
| 14:36:44 | <k-joseph> dkayiwa: i i have changed visit enabled to false |
| 14:37:13 | <dkayiwa> k-joseph: ok now go back to the patient dashboard and tell me how many encounters are on the encounters tab |
| 14:38:17 | <k-joseph> dkayiwa: three under Form Entry, notice Visits has disappeared |
| 14:38:39 | <dkayiwa> k-joseph: how many encounters do you see there? |
| 14:38:58 | <k-joseph> dkayiwa: i see three encounters |
| 14:39:35 | <dkayiwa> k-joseph: under which tab are you looking? |
| 14:41:05 | <k-joseph> dkayiwa: sorry i was looking under Form Entry, but under they are two encounters under Encounters |
| 14:41:56 | <dkayiwa> k-joseph: can you adjust the value of your number of encounter global property and tell me if they change according to the value you set? |
| 14:42:13 | <k-joseph> dkayiwa: ok |
| 14:43:18 | <k-joseph> dkayiwa: i have changed it to seven and am now seeing seven there |
| 14:44:25 | <dkayiwa> k-joseph: how many do you see under the FormEntry tab? |
| 14:44:34 | <k-joseph> dkayiwa: three |
| 14:45:15 | <dkayiwa> k-joseph: can you now comment on the ticket that the global property value is respected under the encounters tab but not formentry ? |
| 14:45:33 | <k-joseph> dkayiwa: ok |
| 14:48:19 | <dkayiwa> k-joseph: just tell me when done |
| 14:48:30 | <k-joseph> dkayiwa: ok |
| 14:58:57 | <k-joseph> dkayiwa: i have added the comment |
| 14:59:50 | <dkayiwa> k-joseph: ok. can you now open personFormEntry.jsp? |
| 15:00:41 | *** andrea_ has joined #openmrs |
| 15:01:03 | <k-joseph> dkayiwa: ok |
| 15:01:52 | <k-joseph> dkayiwa: i have opened it |
| 15:02:55 | <dkayiwa> k-joseph: can you look for: <openmrs:portlet url="patientEncounters" |
| 15:03:36 | <k-joseph> dkayiwa: i have got that |
| 15:04:09 | <dkayiwa> k-joseph: ok then can you also open the patientEncounters.jsp |
| 15:04:56 | <k-joseph> dkayiwa: i have openned it also |
| 15:05:24 | <dkayiwa> k-joseph: can you locate: model.num |
| 15:05:40 | *** rkorytkowski has joined #openmrs |
| 15:05:40 | *** ChanServ sets mode: +v rkorytkowski |
| 15:05:40 | <andrea_> where is cpower? |
| 15:05:58 | *** rkorytkowski is now known as rafa |
| 15:06:04 | *** cpower has joined #openmrs |
| 15:06:22 | <cpower> Who's ready to Scrum! |
| 15:06:36 | <andrea_> hi cpower |
| 15:06:43 | <cpower> !scrumon cpower |
| 15:06:43 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:06:52 | <k-joseph> dkayiwa: i have got it |
| 15:07:16 | <dkayiwa> k-joseph: ok. can you in the meantime choose another ticket? |
| 15:07:18 | *** robbyoconnor has joined #openmrs |
| 15:07:18 | *** ChanServ sets mode: +v robbyoconnor |
| 15:07:32 | <k-joseph> dkayiwa: ok |
| 15:07:51 | <cpower> Order:jkeiper, rafa, andrea_, dkayiwa, wyclif_, downey and whomever else would like to contribute |
| 15:08:31 | <jkeiper> yoy, sorry. |
| 15:08:56 | <jkeiper> update is: working w/ wyclif on RC tickets and finishing some AMPATH work, blocker: mockito frustrations |
| 15:09:23 | <rafa> Today: |
| 15:09:23 | <rafa> * Changed the eclipse plugin installation package (would be nice to test on something different than Windows). |
| 15:09:23 | <rafa> * Recorded screencast: installing eclipse (will need to upload it to openmrs youtube) |
| 15:09:23 | <rafa> * Univ call |
| 15:09:23 | <rafa> * Design call |
| 15:09:23 | <rafa> No blockers. |
| 15:09:50 | <rafa> downey: how to upload to openmrs' youtube channel? |
| 15:10:03 | <andrea_> Tuesday |
| 15:10:03 | <andrea_> TRUNK-2768 |
| 15:10:03 | <andrea_> Removed isDeatdateEstimated() method |
| 15:10:03 | <andrea_> Changes Rafal suggested |
| 15:10:03 | <andrea_> Wednesday |
| 15:10:03 | <andrea_> Design call |
| 15:10:05 | <andrea_> Finish changes to TRUNK-2768 |
| 15:10:07 | <andrea_> Controllers and remaining JSPs |
| 15:10:09 | <andrea_> Tickets for Registration Core Module (if anything left to be done) |
| 15:10:11 | <andrea_> No blockers |
| 15:10:18 | <wyclif_> Tuesday: |
| 15:10:18 | <wyclif_> Read about idgen module before working on RC-2 |
| 15:10:18 | <wyclif_> RC-2 - Add service method to process a registration event |
| 15:10:18 | <wyclif_> Wednesday: |
| 15:10:18 | <wyclif_> RC-4 - Send notification of registration via Event Module |
| 15:10:19 | <wyclif_> pick another sprint ticket |
| 15:10:21 | <wyclif_> |
| 15:10:23 | <wyclif_> Blockers: None |
| 15:10:35 | <dkayiwa> Looked into: Allow modules to provide a registration validator - RC-7 |
| 15:10:36 | <dkayiwa> Committed response to review comments for: No override the module´s messages in the module_message.properties - TRUNK-2187 |
| 15:10:36 | <dkayiwa> Committed: Update to PersonAddress does not update the address details - RESTWS-314 |
| 15:10:36 | <dkayiwa> Now working on: NonUniqueObjectException: a different object with the same identifier value was already associated with the session: [org.openmrs.Patient#] - TRUNK-3728 |
| 15:10:36 | <dkayiwa> No Blockers |
| 15:11:39 | <cpower> ok |
| 15:12:11 | <cpower> Discussion topics: downey: how to upload to openmrs' youtube channel? |
| 15:12:22 | <cpower> and we are done |
| 15:12:25 | <cpower> !scrumoff |
| 15:12:25 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:12:54 | <downey> rafa: you can request an upload URL via http://go.openmrs.org/helpdesk or (if you have a working IU account) upload directly to http://slashtmp.iu.edu |
| 15:13:08 | <cpower> quick reminder I will be long gone come friday afternoon won't be back till next year ;-) |
| 15:13:50 | <andrea_> cpower, will there be any scrums? |
| 15:15:00 | <cpower> Not on Christmas eve or Day, but I imagine I'll stop in 26,27,28 to see if people have updates. If you are not going to be around email me your updates |
| 15:15:37 | <andrea_> cpower, ok have a good vacation |
| 15:16:50 | *** k-joseph has quit IRC |
| 15:17:08 | <andrea_> rafa, jkeiper, djazayeri, thanks for your input on TRUNK-2768! |
| 15:17:23 | <jkeiper> andrea_, np |
| 15:19:57 | *** k-joseph has joined #openmrs |
| 15:20:15 | *** magoo has joined #openmrs |
| 15:27:31 | *** kavuri has joined #openmrs |
| 15:28:10 | *** cpower has quit IRC |
| 15:31:41 | <kavuri> dkayiwa: hi |
| 15:31:52 | <dkayiwa> kavuri: hi |
| 15:32:00 | <kavuri> dkayiwa: saw your update of the bug report |
| 15:32:09 | <dkayiwa> kavuri: scrum? |
| 15:32:27 | <kavuri> dkayiwa: do you know where the problem is? |
| 15:32:35 | <kavuri> dkayiwa: in JIRA |
| 15:32:36 | <dkayiwa> kavuri: yes |
| 15:32:51 | <kavuri> dkayiwa: great! something simple to fix? |
| 15:33:15 | <jkeiper> dkayiwa, wyclif_ saw my mockito tests and is equally perplexed |
| 15:33:19 | <dkayiwa> kavuri: i thought i had committed only to find out that module was moved to github |
| 15:33:29 | <dkayiwa> kavuri: trying to create a pull request |
| 15:33:54 | <kavuri> dkayiwa: do you have the pull request in the report? |
| 15:34:40 | <dkayiwa> kavuri: trying to make the pull request now but connection is damn slow |
| 15:35:03 | <kavuri> dkayiwa: ok |
| 15:35:35 | *** magoo has quit IRC |
| 15:36:59 | <dkayiwa> kavuri: can you see my commit on the ticket? |
| 15:42:27 | *** kavuri has quit IRC |
| 15:45:06 | *** kavuri has joined #openmrs |
| 15:45:15 | <kavuri> dkayiwa: sorry! got disconnected |
| 15:45:28 | <dkayiwa> kavuri: just merged the pull request |
| 15:45:29 | <kavuri> dkayiwa: yes, I can see the pull request |
| 15:45:46 | <dkayiwa> kavuri: so just pull and get the fix |
| 15:45:54 | <kavuri> dkayiwa: cool. Thanks |
| 15:46:13 | <kavuri> dkayiwa: who can review and push the fix? |
| 15:48:15 | <dkayiwa> kavuri: i have pushed it |
| 15:48:21 | <kavuri> dkayiwa: ok, thanks |
| 15:48:28 | <dkayiwa> kavuri: so ready for use |
| 15:49:12 | *** k-joseph has joined #openmrs |
| 15:50:00 | <dkayiwa> jkeiper: about the mokito beast. is the the module on github? |
| 15:50:31 | <dkayiwa> hi kavuri |
| 15:50:45 | <kavuri> dkayiwa: hi |
| 15:50:52 | <kavuri> dkayiwa: did a git pull and got your fix |
| 15:50:57 | <dkayiwa> kavuri: thanks for always catching these bugs :) |
| 15:51:04 | <kavuri> dkayiwa: most welcome :) |
| 15:51:15 | <dkayiwa> kavuri: test and confirm if fixed |
| 15:51:18 | <kavuri> dkayiwa: sure |
| 15:51:33 | <dkayiwa> k-joseph: got a ticket? |
| 15:52:23 | <k-joseph> dkayiwa: i have just subsribed anew bundle and am working on that now |
| 15:52:53 | <dkayiwa> k-joseph: for how long does the bundle take you? |
| 15:53:35 | <k-joseph> dkayiwa: 60Mb for 24 hours |
| 15:53:45 | <dkayiwa> k-joseph: at how much? |
| 15:54:00 | <k-joseph> dkayiwa: Ugsh. 500 |
| 15:54:04 | <dkayiwa> k-joseph: ok |
| 15:54:55 | <dkayiwa> k-joseph: which network? |
| 15:55:07 | <k-joseph> dkayiwa: airtel |
| 15:55:12 | <dkayiwa> k-joseph: ok |
| 15:55:24 | *** kavuri has quit IRC |
| 15:55:58 | *** basic` has quit IRC |
| 15:56:27 | *** basic has joined #openmrs |
| 16:06:13 | <k-joseph> dkayiwa: how is this one: OpenMRS Trunk TRUNK-2564 |
| 16:06:30 | <dkayiwa> !ticket TRUNK-2564 |
| 16:06:31 | <OpenMRSBot> dkayiwa: [#TRUNK-2564] Add many classes and ids to the Patient Creation Form - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2564 |
| 16:06:40 | *** kavuri has joined #openmrs |
| 16:07:46 | <dkayiwa> k-joseph: that is not very appropriate for you yet |
| 16:07:56 | <k-joseph> dkayiwa: ok |
| 16:08:13 | <k-joseph> dkayiwa: am looking for another one |
| 16:08:21 | <dkayiwa> k-joseph: ok |
| 16:08:43 | *** kishoreyekkanti_ has quit IRC |
| 16:09:40 | *** sgithens has joined #openmrs |
| 16:11:02 | <kavuri> dkayiwa: tested the fix. I confirm it works. Will update the bug report |
| 16:11:20 | <dkayiwa> kavuri: thanks alot!!! |
| 16:11:57 | *** tobin_g has joined #openmrs |
| 16:13:16 | <dkayiwa> k-joseph: https://tickets.openmrs.org/browse/TRUNK-3814 |
| 16:15:58 | <jkeiper> dkayiwa, yep |
| 16:16:23 | <dkayiwa> jkeiper: i could try look at it in whole :) |
| 16:16:36 | *** lh has joined #openmrs |
| 16:16:36 | *** lh has joined #openmrs |
| 16:16:53 | <dkayiwa> k-joseph: do you know how to start on it? |
| 16:17:09 | <jkeiper> dkayiwa, https://github.com/jlkeiper/openmrs-module-amrsreports/tree/REPORTS-73 |
| 16:17:14 | <OpenMRSBot> <http://ln-s.net/+JYs> (at github.com) |
| 16:17:24 | <dkayiwa> jkeiper: ok |
| 16:17:28 | <k-joseph> dkayiwa: still understanding what am required to do |
| 16:17:40 | <dkayiwa> k-joseph: ok do not fear to ask |
| 16:18:12 | <k-joseph> dkayiwa: ok please |
| 16:18:25 | <dkayiwa> k-joseph: for examples, you can look at other validators in the org.openmrs.validator package |
| 16:19:12 | <dkayiwa> k-joseph: eg, VisitTypeValidator, VisitValidator , etc |
| 16:28:54 | *** djazayeri has joined #openmrs |
| 16:28:54 | *** ChanServ sets mode: +o djazayeri |
| 16:30:17 | <k-joseph> dkayiwa: under the description for this ticket, what does: (aIsToB and bIsToA need to be set). mean |
| 16:30:29 | *** dkayiwa has quit IRC |
| 16:31:41 | *** kavuri has quit IRC |
| 16:32:01 | *** dkayiwa has joined #openmrs |
| 16:42:19 | <k-joseph> dkayiwa: |
| 16:43:51 | <k-joseph> dkayiwa: are you on |
| 16:51:57 | *** downey has quit IRC |
| 16:55:06 | *** kishoreyekkanti has joined #openmrs |
| 16:55:48 | *** rafa has quit IRC |
| 16:56:14 | *** andrea_ has quit IRC |
| 17:02:39 | *** sgithens has quit IRC |
| 17:09:11 | <dkayiwa> k-joseph: hi |
| 17:18:20 | *** k-joseph has quit IRC |
| 17:18:26 | *** kjoseph has joined #openmrs |
| 17:22:39 | <kjoseph> dkayiwa: hi |
| 17:22:51 | <kjoseph> dkayiwa: am going ahead to claim this ticket, and i will be consulting you for any assistance. |
| 17:23:03 | <dkayiwa> kjoseph: ok |
| 17:47:52 | *** dkayiwa has quit IRC |
| 17:49:06 | *** dkayiwa has joined #openmrs |
| 17:59:10 | *** dkayiwa has quit IRC |
| 18:01:40 | *** dkayiwa has joined #openmrs |
| 18:03:53 | *** dkayiwa has quit IRC |
| 18:06:45 | *** dkayiwa has joined #openmrs |
| 18:13:51 | *** sgithens has joined #openmrs |
| 18:18:24 | *** rafa has joined #openmrs |
| 18:18:24 | *** ChanServ sets mode: +v rafa |
| 18:22:46 | *** rafa has quit IRC |
| 18:26:20 | *** kishoreyekkanti has quit IRC |
| 19:05:48 | *** kjoseph has quit IRC |
| 19:06:06 | *** k-joseph has joined #openmrs |
| 19:10:54 | *** k-joseph has quit IRC |
| 20:00:40 | *** rafa has joined #openmrs |
| 20:00:40 | *** ChanServ sets mode: +v rafa |
| 20:06:20 | *** sgithens has quit IRC |
| 20:14:43 | *** k-joseph has joined #openmrs |
| 20:18:36 | *** sgithens has joined #openmrs |
| 20:35:14 | <dkayiwa> hi k-joseph |
| 20:35:23 | <k-joseph> dkayiwa: hi |
| 20:35:44 | <k-joseph> dkayiwa: have you seen my email |
| 20:35:44 | <dkayiwa> k-joseph: did you create a branch as per the instructions here? .setParameter("date_created", patient.getDateCreated()) |
| 20:35:57 | <dkayiwa> k-joseph: sorry i meant here? https://wiki.openmrs.org/display/docs/Using+Git |
| 20:36:42 | <dkayiwa> k-joseph: whats the ticket number? |
| 20:36:49 | <k-joseph> dkayiwa: i wanted to generate code first, and am right now doing that |
| 20:37:36 | <dkayiwa> k-joseph: whats the ticket number? |
| 20:37:59 | <k-joseph> dkayiwa: TRUNK-3814 |
| 20:38:43 | <dkayiwa> k-joseph: from that page, it means you can do the following: |
| 20:38:50 | <dkayiwa> k-joseph: git branch TRUNK-3814 |
| 20:39:04 | <dkayiwa> k-joseph: git checkout TRUNK-3814 |
| 20:40:50 | <dkayiwa> k-joseph: then after your changes, you commit like: git commit -m "Missing Validators for relationship_type - TRUNK-3814" |
| 20:41:18 | <dkayiwa> k-joseph: and then: git push origin TRUNK-3814 |
| 20:41:31 | <dkayiwa> k-joseph: then finally create a pull request on github |
| 20:41:42 | <dkayiwa> k-joseph: that will make your work available for review |
| 20:43:52 | <k-joseph> dkayiwa: should i add the sent to you code? |
| 20:44:26 | <dkayiwa> k-joseph: we review code using github. not as email attachments :) |
| 20:44:40 | <k-joseph> dkayiwa: ok |
| 20:46:28 | *** downey has joined #openmrs |
| 20:46:28 | *** ChanServ sets mode: +o downey |
| 21:21:12 | <jkeiper> djazayeri, omg that workd |
| 21:26:29 | <dkayiwa> jkeiper: wow!!!!! :D |
| 21:32:27 | *** robbyoconnor has quit IRC |
| 21:34:11 | <k-joseph> dkayiwa: i did every thing successful, but i realised the ssh i was using was for username 009614, so i have deleted that account and generated a new ssh key for k-joseph my current user name |
| 21:34:19 | <jkeiper> hahaha |
| 21:34:27 | <dkayiwa> k-joseph: ok |
| 21:34:34 | <jkeiper> dkayiwa, djazayeri ... just removed "static final" and boom, worked. |
| 21:34:37 | * jkeiper goes home happy |
| 21:34:51 | <dkayiwa> jkeiper: yikes!!!! :D |
| 21:42:42 | *** jkeiper has quit IRC |
| 21:46:08 | *** sgithens has quit IRC |
| 21:59:31 | *** k-joseph has quit IRC |
| 22:07:59 | *** k-joseph has joined #openmrs |
| 22:49:48 | *** dkayiwa has quit IRC |
| 22:51:56 | *** wyclif_ has quit IRC |
| 22:53:17 | *** lh has quit IRC |
| 22:58:47 | *** djazayeri1 has joined #openmrs |
| 23:00:47 | *** k-joseph has quit IRC |
| 23:01:37 | *** djazayeri has quit IRC |
| 23:06:30 | *** rafa has quit IRC |
| 23:20:41 | *** downey has quit IRC |
| 23:21:28 | *** djazayeri1 is now known as djazayeri |
| 23:59:08 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Address Hierarchy 2.2.7 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=addresshierarchy&version=&2.2.7> |