| 00:01:56 | *** wyclif_ has joined #openmrs |
| 00:02:50 | *** r0bby has quit IRC |
| 00:03:40 | *** r0bby has joined #openmrs |
| 00:03:40 | *** ChanServ sets mode: +v r0bby |
| 00:07:50 | *** Mkop1 has joined #openmrs |
| 00:07:50 | *** ChanServ sets mode: +v Mkop1 |
| 00:20:16 | *** andreapat has quit IRC |
| 00:27:12 | *** r0bby has quit IRC |
| 00:43:50 | *** gschiltz has joined #openmrs |
| 01:05:27 | *** gschiltz has left #openmrs |
| 02:13:54 | *** Mkop1 has quit IRC |
| 04:16:52 | *** djazayeri has quit IRC |
| 04:30:07 | *** gschiltz has joined #openmrs |
| 04:55:02 | *** kishoreyekkanti has joined #openmrs |
| 05:56:37 | *** robbyoconnor has joined #openmrs |
| 05:56:37 | *** ChanServ sets mode: +v robbyoconnor |
| 06:15:51 | *** ibewes has joined #openmrs |
| 06:28:43 | *** ibewes has quit IRC |
| 10:20:31 | *** rkorytkowski has joined #openmrs |
| 10:20:31 | *** ChanServ sets mode: +v rkorytkowski |
| 10:20:41 | *** rkorytkowski is now known as rafa |
| 10:30:34 | *** dkayiwa has joined #openmrs |
| 10:32:16 | *** hasintha has joined #openmrs |
| 10:33:54 | <hasintha> hi all, i can't find m2e connector for maveen scm plugin in eclipse juno can any one help me. |
| 10:35:53 | *** brunn_ has joined #openmrs |
| 10:38:43 | *** dkayiwa has quit IRC |
| 10:40:02 | *** brunn_ has quit IRC |
| 10:40:14 | *** dkayiwa has joined #openmrs |
| 10:42:53 | <dkayiwa> hi rafa |
| 10:42:59 | <rafa> dkayiwa: hey |
| 10:43:06 | <dkayiwa> rafa: how is it going? |
| 10:43:37 | <rafa> dkayiwa: good, I've picked up the work from yesterday already. |
| 10:43:45 | <dkayiwa> rafa: ok |
| 10:46:24 | *** hasintha has quit IRC |
| 11:02:42 | *** dkayiwa has quit IRC |
| 11:06:31 | *** dkayiwa has joined #openmrs |
| 11:33:22 | *** ningosi has joined #openmrs |
| 11:34:52 | *** ningosi is now known as Ojwanganto |
| 11:36:43 | <dkayiwa> rafa: do you think RC-5 depends on your ticket? |
| 11:36:46 | <dkayiwa> !ticket RC-5 |
| 11:36:47 | <OpenMRSBot> dkayiwa: [#RC-5] Expose search method via REST - OpenMRS JIRA - https://tickets.openmrs.org/browse/RC-5 |
| 11:37:29 | <rafa> dkayiwa: yes |
| 11:37:39 | <dkayiwa> rafa: ok then will leave it alone :) |
| 11:38:28 | <rafa> dkayiwa: want to pair again? |
| 11:38:50 | <dkayiwa> rafa: as long as you will be the driver :) |
| 11:39:14 | <rafa> dkayiwa: I was driving yesterday :P |
| 11:39:18 | <rafa> dkayiwa: your turn |
| 11:39:44 | <dkayiwa> rafa: would cause an accident driving because am not yet sure of the destination :) |
| 11:39:58 | <rafa> dkayiwa: neither was I ;) |
| 11:40:15 | <rafa> dkayiwa: as you see things need to be rewritten |
| 11:40:16 | <dkayiwa> rafa: but you driving skills seems so excellent :D |
| 11:40:53 | <dkayiwa> rafa: you seemed to know exactly how to go where we were supposed to go :) |
| 11:41:29 | *** jkeiper has joined #openmrs |
| 11:41:29 | *** ChanServ sets mode: +v jkeiper |
| 11:41:32 | <rafa> dkayiwa: haha and yet it wasn't what we were expected to do :P |
| 11:41:59 | <dkayiwa> rafa: but atleast you drove us to some destination and we never had an accident :) |
| 11:42:09 | <rafa> dkayiwa: let me clean things up and let you drive |
| 11:42:12 | <jkeiper> :-) |
| 11:42:28 | <dkayiwa> rafa: infact i did learn more hibernate from your driving |
| 11:42:57 | <dkayiwa> rafa: my hibernate as mostly been copying and pasting from existing openmrs-core code :) |
| 11:43:11 | <rafa> dkayiwa: that's good, but you will learn even more when you do it :) |
| 11:43:48 | <dkayiwa> rafa: that can be true only if learning is simply typing what the other is dictating :D |
| 11:44:13 | <dkayiwa> jkeiper: i did not know you are awake :) |
| 11:45:02 | <dkayiwa> rafa: so as you drive, i will be like in a driving school until when i get a driving permit :) |
| 11:45:55 | <rafa> dkayiwa: haha it doesn't work that way from what I remember. You need to drive and not your instructor ;) |
| 11:46:13 | <jkeiper> dkayiwa, me neither ;-) |
| 11:46:29 | <dkayiwa> jkeiper: :) |
| 11:48:14 | <dkayiwa> jkeiper: is there any existing ticket that does not depend on another? |
| 11:49:19 | <jkeiper> dkayiwa, is there ever a ticket that doesn't truly depend on another? ;-) |
| 11:49:24 | <jkeiper> dkayiwa, not exactly |
| 11:49:46 | <jkeiper> dkayiwa, but there were some other nice-to-have features that i can write up and add to the sprint |
| 11:49:54 | <jkeiper> dkayiwa, like a validation mechanism |
| 11:50:14 | <dkayiwa> jkeiper: putting it in another way, which ticket do you recommend for me to claim? :) |
| 11:50:16 | <jkeiper> dkayiwa, for ensuring a minimum collected data set |
| 11:50:29 | <jkeiper> dkayiwa, i think you would like this one, but i need to write it up |
| 11:51:01 | <dkayiwa> jkeiper: so you do not recommend that i choose any of the existing? |
| 11:51:12 | *** k-joseph has joined #openmrs |
| 11:51:35 | <jkeiper> dkayiwa, you can choose to do RC-5 if you have something to work against |
| 11:51:43 | <jkeiper> dkayiwa, are you and rafa stuck on RC-3? |
| 11:52:02 | *** yony258 has joined #openmrs |
| 11:52:13 | <dkayiwa> jkeiper: rafa has done 100% of the work on RC-3 :) |
| 11:52:23 | <dkayiwa> !ticket RC-5 |
| 11:52:24 | <OpenMRSBot> dkayiwa: [#RC-5] Expose search method via REST - OpenMRS JIRA - https://tickets.openmrs.org/browse/RC-5 |
| 11:52:54 | <jkeiper> aha! |
| 11:53:04 | <yony258> dkayiwa, If you have time please review AM-10 :) |
| 11:53:24 | <dkayiwa> jkeiper: looks like yony258 gives me something else to do now :) |
| 11:53:25 | <jkeiper> dkayiwa, in about 10 minutes i will write up another RC ticket about the pluggable validator |
| 11:53:30 | <jkeiper> sawa |
| 11:53:46 | <yony258> dkayiwa, its on low priority |
| 11:54:04 | <dkayiwa> yony258: i have no higher priority alternative :) |
| 11:54:20 | <yony258> dkayiwa, gee |
| 11:54:25 | <yony258> dkayiwa, great |
| 11:54:40 | *** yony258 has quit IRC |
| 11:54:49 | <jkeiper> hahaha |
| 11:54:53 | <dkayiwa> :) |
| 11:55:30 | <dkayiwa> yony258 just comes in, allocates a task to a dev, and then vanishes!!! :D |
| 11:55:54 | <dkayiwa> !ticket AM-10 |
| 11:55:56 | <OpenMRSBot> dkayiwa: [#AM-10] Add "Find Next Appointment Time" functionality to the Create new Appointment form. - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-10 |
| 11:57:06 | <k-joseph> dkayiwa: hi |
| 11:57:13 | <dkayiwa> k-joseph: hi |
| 11:59:49 | <k-joseph> dkayiwa: am ready please to recieve your reply |
| 12:00:00 | *** yony258 has joined #openmrs |
| 12:00:06 | <dkayiwa> k-joseph: what is the ticket number? |
| 12:00:21 | *** yony258 has quit IRC |
| 12:00:22 | <k-joseph> dkayiwa: TRUNK-2449 |
| 12:00:48 | <dkayiwa> k-joseph: by the way on a side note, did you read the link Harsha sent about spring? |
| 12:01:04 | <dkayiwa> !ticket TRUNK-2449 |
| 12:01:05 | <OpenMRSBot> dkayiwa: [#TRUNK-2449] Make Max Number of Encounters on Dashboard Configurable - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2449 |
| 12:01:24 | <k-joseph> dkayiwa: am reading it as well just now |
| 12:01:32 | <dkayiwa> k-joseph: ok |
| 12:02:27 | <dkayiwa> k-joseph: have you already created a branch for this ticket as per? https://wiki.openmrs.org/display/docs/Using+Git |
| 12:02:57 | <k-joseph> dkayiwa: not yet |
| 12:03:20 | <dkayiwa> k-joseph: can tell me after you are done? |
| 12:03:39 | <k-joseph> dkayiwa: let me do it now, and will tell you after |
| 12:03:55 | <dkayiwa> k-joseph: ok |
| 12:35:07 | *** lowell has joined #openmrs |
| 12:39:12 | *** lowell has quit IRC |
| 12:41:18 | <dkayiwa> k-joseph: are you still creating the branch? |
| 12:42:29 | <k-joseph> dkayiwa: finished creating the branch for the ticket |
| 12:42:44 | <dkayiwa> k-joseph: was waiting for you to tell me as you had promised? |
| 12:43:03 | <k-joseph> dkayiwa: sorry for the delay |
| 12:43:43 | <dkayiwa> k-joseph: have you read all the comments on that ticket? |
| 12:44:10 | <k-joseph> dkayiwa: i read all the comments |
| 12:44:36 | <dkayiwa> k-joseph: have you understood Lluis's comment? |
| 12:46:44 | <dkayiwa> k-joseph: are you concentrating on what i type or are you doing something else? |
| 12:47:39 | <k-joseph> dkayiwa: am concetrating, but am just not sure which exactly comment |
| 12:48:07 | <dkayiwa> k-joseph: but you did not tell me that either :( |
| 12:49:16 | <k-joseph> dkayiwa: i first confused that with Harsha comment and link on spring |
| 12:49:36 | <dkayiwa> k-joseph: am not used to multi tasking. so when i concentrate on helping you out, i would need to give me your attention. even when you do not understand what i type, atleast tell me so instead of keeping quiet |
| 12:50:11 | <k-joseph> dkayiwa: ok please, am sorry |
| 12:50:56 | <dkayiwa> k-joseph: what we are discussing now is not Harsha's linke |
| 12:51:03 | <dkayiwa> k-joseph: we are dealing with TRUNK-2449 |
| 12:51:28 | <dkayiwa> k-joseph: so am asking again, did you understand Lluis's comment on TRUNK-2449? |
| 12:52:24 | <k-joseph> dkayiwa: let go through it again for just a few seconds, |
| 12:52:56 | <dkayiwa> k-joseph: that is better. atleast you have updated me that you are going through it instead of keeping quiet :) |
| 12:58:38 | <k-joseph> dkayiwa: am not understanding it well |
| 12:59:28 | <dkayiwa> k-joseph: do you have the "dashboard.encounters.maximumNumberToShow" global property? |
| 12:59:36 | <dkayiwa> k-joseph: in the webapp |
| 13:00:26 | <k-joseph> dkayiwa: am checking |
| 13:00:50 | <dkayiwa> k-joseph: excellent update :) |
| 13:06:24 | <k-joseph> dkayiwa: am seeing patientDashboardForm.jsp, where i can see <openmrs:globalProperty....> tag, is it this? |
| 13:07:10 | <dkayiwa> k-joseph: not in the code |
| 13:07:21 | <dkayiwa> k-joseph: in the running global property |
| 13:07:56 | <dkayiwa> k-joseph: running application user interface |
| 13:08:52 | <k-joseph> dkayiwa: am not understanding those two, |
| 13:09:38 | <dkayiwa> k-joseph: if i told you to set a global property value in OpenMRS as an end user, do you know how to do it? |
| 13:10:06 | <k-joseph> dkayiwa: no\ |
| 13:10:33 | <dkayiwa> k-joseph: can you search using the openmrs-user guide |
| 13:10:43 | <k-joseph> dkayiwa: ok |
| 13:12:54 | <dkayiwa> k-joseph: you will tell me after you have seen or not seen it :) |
| 13:13:12 | <k-joseph> dkayiwa: ok |
| 13:18:58 | <k-joseph> dkayiwa: am not seeing it in openmrs guide |
| 13:20:20 | <dkayiwa> k-joseph: go to the admin screen, and then click the Advanced Settings link |
| 13:20:34 | <k-joseph> dkayiwa: ok |
| 13:22:22 | <k-joseph> dkayiwa: am there |
| 13:22:32 | <dkayiwa> k-joseph: can you look for? dashboard.encounters.maximumNumberToShow |
| 13:23:33 | <k-joseph> dkayiwa: seen |
| 13:23:43 | <dkayiwa> k-joseph: what value has it got? |
| 13:24:29 | <k-joseph> dkayiwa: it has: An integer which, if specified, would determine the maximum number of encounters to display on the encounter tab of the patient dashboard. |
| 13:24:54 | <dkayiwa> k-joseph: thats the description. the value in on the right hand side |
| 13:25:16 | <k-joseph> dkayiwa: it has no number specified |
| 13:25:37 | <dkayiwa> k-joseph: so thats the one Lluis was refering to in the ticket |
| 13:25:47 | <dkayiwa> k-joseph: can you give it a value like 2 |
| 13:25:56 | <k-joseph> dkayiwa: ok |
| 13:25:58 | <dkayiwa> k-joseph: then tell me how many encounters are displayed? |
| 13:30:10 | <k-joseph> dkayiwa: they two: that is under: visit type on the Edit visit Form, before they were three here |
| 13:33:57 | <k-joseph> dkayiwa: am getting back in a few secs |
| 13:34:43 | <dkayiwa> k-joseph: ok |
| 13:43:34 | *** k-joseph has quit IRC |
| 13:46:35 | *** yony258 has joined #openmrs |
| 13:47:18 | <yony258> dkayiwa: Hi, what was the issue with 1.9,0? |
| 13:47:22 | <yony258> *1.9.0 |
| 13:53:02 | <dkayiwa> yony258: clicking the links result into errors |
| 13:53:13 | <dkayiwa> yony258: you can try out a 1.9.0 standalone to see it |
| 13:53:20 | <yony258> dkayiwa: RC4? |
| 13:54:16 | <dkayiwa> yony258: just put the 1.9.0 war file in the standalone and run it again |
| 13:54:50 | <dkayiwa> yony258: you will need to also drop the database |
| 14:01:23 | <yony258> dkayiwa: Where can I get the war file? (I just tried to download 1.9.0 RC4 and the rar is corrupted) |
| 14:02:08 | <dkayiwa> yony258: http://sourceforge.net/projects/openmrs/files/releases/OpenMRS_1.9.0/ |
| 14:02:11 | <OpenMRSBot> <http://ln-s.net/+J$a> (at sourceforge.net) |
| 14:02:22 | <yony258> dkayiwa: Thank you |
| 14:02:25 | <dkayiwa> yony258: you will see openmrs.war on that page |
| 14:06:22 | *** Ojwanganto has quit IRC |
| 14:11:21 | <yony258> dkayiwa: It says that it doesn't support <openmrs:message |
| 14:11:31 | <dkayiwa> yony258: exactly!!! |
| 14:11:44 | <yony258> dkayiwa: So what can I do lol? |
| 14:11:56 | <yony258> dkayiwa: Import a more updated library? |
| 14:12:05 | <dkayiwa> yony258: look at the appointmentTypes.form that i created |
| 14:12:18 | <dkayiwa> yony258: and then use the same as i did for messages |
| 14:20:04 | <yony258> dkayiwa: Where can I get 1.8.0 war? |
| 14:20:14 | <yony258> dkayiwa: That page has 1.8.4 but not 1.8.0 |
| 14:23:17 | <dkayiwa> yony258: in the url i sent you, replace 1.9.0 with the version you want :) |
| 14:25:37 | <yony258> dkayiwa: Is it ok that I'll check if it works only on 1.8.0 , 1.9.0, 1.9.1, 1.9.2, or do I need to check the sub versions too? |
| 14:25:46 | <yony258> 1.8.x |
| 14:25:59 | <dkayiwa> yony258: only the released one :) |
| 14:26:14 | <yony258> dkayiwa: What do you mean? |
| 14:26:22 | <yony258> dkayiwa: 1.8.4 was released too right? |
| 14:26:24 | <dkayiwa> yony258: not 1.8.x |
| 14:26:29 | <dkayiwa> yony258: yes |
| 14:31:08 | <yony258> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/4f9fb40cb420f6870e7c4b84627970c6f5be606c |
| 14:31:13 | <OpenMRSBot> <http://ln-s.net/+J+8> (at github.com) |
| 14:31:24 | <dkayiwa> yony258: ok |
| 14:31:57 | <dkayiwa> yony258: by the way you do not have to test each and every version :) |
| 14:32:01 | <dkayiwa> yony258: just a few |
| 14:32:20 | <yony258> dkayiwa: 1.8.0, 1.9.0, 1.9.1 and 1.9.2 ? |
| 14:33:04 | <dkayiwa> yony258: include 1.8.0 & 1.8.4 and also 1.9.0 & 1.9.3 |
| 14:33:38 | <yony258> dkayiwa: 1.9.3? |
| 14:34:54 | <dkayiwa> yony258: ok |
| 14:36:05 | <yony258> dkayiwa: But I think it will be better if we check compatibility when the module is done |
| 14:37:38 | <dkayiwa> yony258: ok |
| 14:39:13 | *** k-joseph has joined #openmrs |
| 14:41:20 | <k-joseph> dkayiwa: i have redone the above steps, this time using openmrs-standalone: when i set the number to 2, am still able to see all the 3 views under visits on the patient dashboard, for patient 7279MP-4. is this what you meant? or there is a different way to what you meant? |
| 14:43:39 | <dkayiwa> k-joseph: yes thats what i meant. looks like the value is not respected |
| 14:43:46 | <dkayiwa> k-joseph: will be back later |
| 14:43:53 | <k-joseph> dkayiwa: ok |
| 14:44:00 | *** dkayiwa has quit IRC |
| 14:55:25 | *** cpower has joined #openmrs |
| 14:56:21 | *** k-joseph has quit IRC |
| 14:57:00 | <cpower> Good day... Anyone taking Friday off just in case it really is our last day on earth? |
| 14:57:13 | <jkeiper> hmmmm |
| 14:59:24 | <yony258> I dont think it will be our last day on earth because I have an assignment due to Friday and God was never that much kind to me :P |
| 14:59:39 | <cpower> +1 to yony258 |
| 14:59:55 | <yony258> cpower: ;) |
| 15:00:06 | <jkeiper> someone in australia let us know on thursday |
| 15:00:49 | <cpower> from Australia "Hey it's tru....." |
| 15:01:22 | <cpower> On that note...on with the show |
| 15:01:28 | <cpower> !scrumon cpower |
| 15:01:28 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:01:37 | <yony258> im off, thank you |
| 15:01:49 | *** yony258 has quit IRC |
| 15:02:15 | <cpower> Our Order: jkeiper, rafa, wyclif_, darius, andrea, and whomever else would like to contribute |
| 15:02:29 | <jkeiper> yikes! |
| 15:02:53 | <cpower> don't yikes me, it's your sprint...be prepared man! |
| 15:03:02 | <jkeiper> Until now: |
| 15:03:02 | <jkeiper> - worked with wyclif on RC-2 (kinda) |
| 15:03:02 | <jkeiper> - discussed EVNT-25 |
| 15:03:02 | <jkeiper> - meetings |
| 15:03:02 | <jkeiper> Until next scrum: |
| 15:03:03 | <jkeiper> - work with wyclif on RC-2, EVNT-25 |
| 15:03:05 | <jkeiper> - CALC-47 |
| 15:03:07 | <jkeiper> Blockers: |
| 15:03:09 | <jkeiper> - None |
| 15:03:11 | <jkeiper> heh |
| 15:03:16 | <rafa> Today: |
| 15:03:16 | <rafa> * Reworked RC-3: Add service method to search for similar persons and patients |
| 15:03:16 | <rafa> https://tickets.openmrs.org/browse/RC-3 (please review) |
| 15:03:16 | <rafa> * Preparing a recording for the Univ Call |
| 15:03:16 | <rafa> No blockers. |
| 15:03:41 | *** andrea_ has joined #openmrs |
| 15:04:06 | <cpower> wyclif_ you are up! |
| 15:04:26 | <jkeiper> yay! |
| 15:04:47 | <cpower> , ok andrea_ you are up |
| 15:05:06 | <wyclif_> hold on a sec |
| 15:05:06 | <andrea_> Monday |
| 15:05:07 | <andrea_> TRUNK-2768 |
| 15:05:07 | <andrea_> PersonFormController and PatientListItem |
| 15:05:07 | <andrea_> Documented all programs I changed |
| 15:05:07 | <andrea_> Pull request |
| 15:05:07 | <andrea_> Contacted Jeremy re Registration Core Module sprint |
| 15:05:10 | <andrea_> |
| 15:05:11 | <andrea_> Tuesday |
| 15:05:13 | <andrea_> TRUNK-2768 |
| 15:05:15 | <andrea_> Ticket or pair-programming on Registration Core Module sprint |
| 15:05:17 | <andrea_> |
| 15:05:19 | <andrea_> Blocker - discussion point |
| 15:05:21 | <andrea_> Add code to PersonFormController for deathDate and deathdateEstimated? |
| 15:05:25 | <andrea_> Till now have been adding code for deathdateEstimated only if there is code for deathDate |
| 15:06:58 | <wyclif_> can i go? |
| 15:07:00 | <cpower> paging wyclif_...wyclif please pick up the red courtsey phone |
| 15:07:07 | <wyclif_> Monday: |
| 15:07:08 | <wyclif_> Completed and commit code for RC-1 |
| 15:07:08 | <wyclif_> GHI quarterly meeting |
| 15:07:08 | <wyclif_> Design discussion with Jer and Burke for EVNT-25 - Extend EventEngine.fireEvent |
| 15:07:08 | <wyclif_> EVNT-25 - Extend EventEngine.fireEvent to allow more data in message |
| 15:07:08 | <cpower> yes |
| 15:07:08 | <wyclif_> Tuesday: |
| 15:07:10 | <wyclif_> RC-2 - Add service method to process a registration event |
| 15:07:12 | <wyclif_> Pick another sprint ticket |
| 15:07:14 | <wyclif_> |
| 15:07:16 | <wyclif_> Blockers: None |
| 15:07:26 | *** djazayeri has joined #openmrs |
| 15:07:26 | *** ChanServ sets mode: +o djazayeri |
| 15:07:48 | <cpower> just in time djazayeri, you may go when ready |
| 15:07:58 | <djazayeri> Working on Mirebalais |
| 15:08:12 | <djazayeri> Working with Pulkit (TW India) about new reference application |
| 15:08:13 | <djazayeri> no blockers |
| 15:11:25 | <rafa> cpower: ring, ring ;) |
| 15:14:48 | <cpower> I'm not home |
| 15:14:58 | <cpower> Ok, Blockers |
| 15:15:22 | <cpower> andrea_> Blocker - discussion point |
| 15:15:22 | <cpower> [10:05] <andrea_> Add code to PersonFormController for deathDate and deathdateEstimated? |
| 15:15:22 | <cpower> [10:05] <andrea_> Till now have been adding code for deathdateEstimated only if there is code for deathDat |
| 15:16:10 | <andrea_> rafa, https://github.com/openmrs/openmrs-core/pull/150 |
| 15:16:17 | <OpenMRSBot> <http://ln-s.net/+J-K> (at github.com) |
| 15:16:21 | <cpower> Anyone have some suggestions for andrea_ |
| 15:16:57 | <rafa> andrea_: I need to run right now. I'll be back in 3 hours and review it. |
| 15:17:14 | <cpower> !scrumoff |
| 15:17:14 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:17:18 | * jkeiper looks |
| 15:17:20 | <andrea_> rafa, ok - ping me then |
| 15:17:29 | <rafa> andrea_: sure |
| 15:20:11 | *** rafa has quit IRC |
| 15:23:18 | <andrea_> djazayeri, did you see my email to dev list re TRUNK-2768? |
| 15:23:59 | *** gschiltz has joined #openmrs |
| 15:24:45 | <jkeiper> andrea_, i'm checking out your pull request to review it on my IDE |
| 15:25:05 | <djazayeri> andrea_: saw itâdon't have time to look at it now though |
| 15:25:16 | <djazayeri> hopefully jkeiper and/or rafa can take a look |
| 15:25:20 | * jkeiper waits for files to download |
| 15:25:22 | <andrea_> jkeiper, good |
| 15:25:26 | *** magoo has joined #openmrs |
| 15:26:09 | <andrea_> djazayeri, let me know should if I should add add code to PersonFormController |
| 15:26:32 | <andrea_> djazayeri, it currently does not save deathDate on person |
| 15:26:35 | *** magoo has quit IRC |
| 15:26:41 | <gschiltz> Can anyone tell me the MySQL username and password for the standalone in demonstration mode? I'd like to use MySQL Workbench to examine the DB. |
| 15:35:29 | *** kishoreyekkanti has quit IRC |
| 15:38:42 | *** gschiltz_ has joined #openmrs |
| 15:39:07 | <gschiltz_> Can anyone tell me the MySQL username and password for the standalone in demonstration mode? I'd like to use MySQL Workbench to examine the DB. |
| 15:39:58 | <djazayeri> gschiltz_: there's an app-data folder, which has a .properties file in it, that should have the password |
| 15:40:22 | <gschiltz> Okay, thanks. I'll look there. |
| 15:40:31 | *** gschiltz_ has left #openmrs |
| 15:47:35 | <gschiltz> djazayeri: there is an openmrs-standalone-runtime.properties file in the top level directory of the standalone (openmrs-standalone-1.9.1) - is that the file you mean? There are no .properties files anywhere under the appdata directory... |
| 15:47:50 | <djazayeri> gschiltz: yeah, that's the one I mean |
| 15:55:21 | *** gschiltz has quit IRC |
| 15:55:30 | *** basic` has quit IRC |
| 15:56:49 | *** basic has joined #openmrs |
| 16:11:20 | <jkeiper> andrea_, i now see the 28 errors you get |
| 16:11:23 | <jkeiper> andrea_, will take a look ... |
| 16:14:42 | *** suranga has joined #openmrs |
| 16:14:43 | *** ChanServ sets mode: +v suranga |
| 16:20:46 | *** suranga_ has joined #openmrs |
| 16:24:32 | *** suranga has quit IRC |
| 16:41:27 | *** afiles has joined #openmrs |
| 16:48:33 | *** afiles has quit IRC |
| 17:01:44 | *** andrea_ has quit IRC |
| 17:23:08 | *** kishoreyekkanti has joined #openmrs |
| 17:36:04 | <cpower> So djazayeri, what should we have this week's design call on? |
| 17:36:23 | <djazayeri> cpower: I feel like there's probably a bunch to discuss around the registration sprint |
| 17:36:30 | <djazayeri> jkeiper: yea or nay? |
| 17:36:31 | <djazayeri> ^^ |
| 17:36:56 | <cpower> I think he's afk |
| 17:37:20 | <djazayeri> cpower: well, that seems like the primary topic. |
| 17:37:27 | <cpower> I'll check with him on this. Any other ideas? |
| 17:50:00 | *** sagar has joined #openmrs |
| 17:50:42 | *** basic is now known as basic` |
| 17:57:47 | <djazayeri> cpower: wearing our PIH hats, Mike and I have a topic we'd like to discuss a bit: an OpenMRS Starter Edition for a particular project of ours. |
| 17:57:52 | <djazayeri> cpower: if there's time |
| 18:11:42 | *** sagar has quit IRC |
| 18:11:46 | <jkeiper> ? |
| 18:12:59 | <jkeiper> djazayeri, cpower: the essentials are ironed out, i think ... although rafal might not feel the same way |
| 18:13:09 | <jkeiper> so perhaps we get some feedback from rafal, daniel, wyclif_ |
| 18:13:21 | *** andreapat has joined #openmrs |
| 18:13:31 | <cpower> djazayeri: Sounds good I'll add it |
| 18:13:37 | <djazayeri> cpower: do we have other sprint-related topics? |
| 18:13:58 | <cpower> I'm looking into this as we speak. |
| 18:14:25 | <djazayeri> jkeiper: I feel like you all are making significant decisions about design and architecture, which is totally fine, but if those decisions happen during the sprint rather than before, we should spend some design call time looking at them. |
| 18:14:26 | <cpower> It's not so much lack of topics as it is, lack of people with time or prep to discuss items |
| 18:14:35 | <jkeiper> djazayeri, true |
| 18:15:02 | <jkeiper> djazayeri, most decision changes happened from not fully understanding original intentions and/or impact on other modules |
| 18:16:02 | <djazayeri> jkeiper: right, and I think it's totally fine and good for devs to be empowered to be making those decisions while doing development; design call seems the time to review them and bring them to light, though. |
| 18:18:14 | <jkeiper> djazayeri, sounds good then |
| 18:19:07 | <cpower> ok how much time would you like to allocate to this informative piece? |
| 18:20:15 | <cpower> and djazayeri, how much time would you and Mike like for your OpenMRS Starter Edition |
| 18:25:37 | <jkeiper> cpower, idk 30m? |
| 18:25:52 | <cpower> ok |
| 18:46:46 | <cpower> djazayeri, so it seems like we shouldn't expect to have a sprint going next week (holiday's and it seems like no one is ready) do you feel the same? |
| 18:46:57 | <djazayeri> cpower: I agree |
| 18:53:05 | <andreapat> jkeiper, saw you're comment on irc (on my home computer) am in the office now |
| 19:02:09 | <jkeiper> andreapat, yes ... didn't figure much out yet sorry |
| 19:02:13 | <andreapat> djazayeri, did u see my comments on PersonFormController? |
| 19:03:25 | <andreapat> jkeiper, ok - still wondering whether to put deathdate info in PersonFormController |
| 19:04:13 | <djazayeri> andreapat: saw that you commented, don't have time to look now, hopefully jkeiper can help |
| 19:09:23 | <andreapat> djazayeri, ok - just wondering about putting deathdate info in PersonFormController - take a look when you can |
| 19:09:38 | <djazayeri> andreapat: which comment/question specifically |
| 19:09:48 | <djazayeri> andreapat: is deathdate not currently on the edit person form? |
| 19:12:35 | *** kishoreyekkanti has quit IRC |
| 19:17:08 | <andreapat> djazayeri, yes it is |
| 19:17:28 | <jkeiper> andreapat, you mean deathdateEstimated |
| 19:18:20 | <andreapat> jkeiper, I added deathdateEstimated to wherever deathDate was |
| 19:18:31 | <jkeiper> andreapat, right |
| 19:18:34 | <djazayeri> andreapat: I believe that we need to add a checkbox for "is this deathdate estimated" to the jsp page. I don't know if this needs to be added to the controller explicitly or not, or if spring binding will take care of that automatically |
| 19:20:30 | <andreapat> djazayeri, yes - so far have only put checkbox in shortPatientForm - it is there you can check it - but doesn't retain value or persist to the database |
| 19:21:02 | <andreapat> djazayeri, will put in the rest of the JSPs when those thing are working |
| 19:21:58 | <djazayeri> andreapat: so, what's the question exactly? |
| 19:22:11 | <andreapat> djazayeri, how do you get to the editPersonInfo.jsp oin the UI? |
| 19:23:03 | <djazayeri> andreapat: I would suggest searching (in eclipse) for "editPersonInfo" and see where it's referenced from |
| 19:23:24 | <djazayeri> andreapat: I assume from your question that this isn't the view for the EditPersonInfo page contorller... |
| 19:23:25 | <andreapat> djazayeri, question is: PersonFormController doesn't do anything with deathDate now - should I add code to it? |
| 19:24:03 | <djazayeri> andreapat: I don't know. It is possible that spring binding would already set this property on the command object |
| 19:24:44 | <djazayeri> andreapat: sorry, going back a stepâ¦you said that you put a checkbox in shortPatientForm, but this isn't handled in the DB yet. |
| 19:25:23 | <djazayeri> andreapat: have you done something in the controller for *that* form yet? |
| 19:25:51 | <andreapat> djazayeri, yes put a checkbox in shortPatientForm and not setting new colunm in Person table |
| 19:26:30 | <andreapat> djazayeri, JSPs ect are all new to me - only done work in backend of system |
| 19:26:55 | <andreapat> djazayeri, I mean in the OpenMRS system |
| 19:27:59 | <wyclif_> hi jkeiper , got a minute to talk on skype? |
| 19:29:08 | <wyclif_> jkeiper, ? |
| 19:30:17 | <jkeiper> wyclif_, can we chat? it's "quiet time" atm |
| 19:31:32 | <jkeiper> andreapat, i know the problem |
| 19:31:45 | <wyclif_> jkeiper, hmmm... |
| 19:31:47 | <jkeiper> all the errors are in the mergePatients() method |
| 19:31:50 | <jkeiper> wyclif_, one sec |
| 19:31:57 | <wyclif_> i need to clarify something about RC-2 |
| 19:32:05 | <wyclif_> !ticket RC-2 |
| 19:32:06 | <OpenMRSBot> wyclif_: [#RC-2] Add service method to process a registration event - OpenMRS JIRA - https://tickets.openmrs.org/browse/RC-2 |
| 19:32:13 | <andreapat> jkeiper, what is it? |
| 19:32:23 | <djazayeri> andreapat: I don't understand why you're asking about PersonFormController |
| 19:32:31 | <jkeiper> andreapat, PersonMergeLogData.priorDateOfDeathEstimated is a boolean (primitive) |
| 19:32:31 | <djazayeri> andreapat: when you've been talking about jsps for other pages |
| 19:32:38 | <jkeiper> andreapat, it cannot be set to null |
| 19:32:39 | <djazayeri> andreapat: gotta run to a meeting |
| 19:32:41 | <jkeiper> andreapat, only true or false |
| 19:32:58 | <jkeiper> andreapat, so you have to return true or false from preferred.isDeathdateEstimated() |
| 19:33:03 | <wyclif_> andreapat, am also a little confused by your emails about estimated death date |
| 19:33:24 | <wyclif_> andreapat, i dont seem to understand the exact problem to be able to help |
| 19:34:29 | <andreapat> jkeiper, let me take a look - thanks |
| 19:35:12 | <andreapat> wyclif, added new column deathdateEstimated to Person |
| 19:35:32 | <jkeiper> andreapat, i'll show you a patch |
| 19:35:48 | <andreapat> jkeiper, ok |
| 19:38:27 | <jkeiper> andreapat, un-commenting the if statement in Person.java#isDeathdateEstimated() fixes the tests |
| 19:38:45 | <jkeiper> still, it looks like djazayeri thinks we should not have isDeathdateEstimated() |
| 19:39:01 | <jkeiper> perhaps a mixture of the two is good -- return Boolean for get() and boolean for is() |
| 19:39:06 | <jkeiper> seems really complicated then |
| 19:39:11 | <jkeiper> wyclif_, what's up |
| 19:39:32 | <djazayeri> jkeiper: that's the convention. a boolean property should have an "is" getter, and everything else (including Boolean) should have a "get" getter. |
| 19:39:47 | <wyclif_> what is the method signature of the registerNewPatient method suppose to be |
| 19:39:56 | <wyclif_> !ticket RC-2 |
| 19:39:57 | <OpenMRSBot> wyclif_: [#RC-2] Add service method to process a registration event - OpenMRS JIRA - https://tickets.openmrs.org/browse/RC-2 |
| 19:39:59 | <jkeiper> djazayeri, sure ... just wondering if we should provide an is() if it's not primitive boolean |
| 19:40:42 | <jkeiper> wyclif_, ah i'll update the ticket |
| 19:40:42 | <djazayeri> jkeiper: no, we should only have one getter, and it should be the appropriate one. |
| 19:40:45 | <jkeiper> changed since i wrote it |
| 19:41:00 | <jkeiper> djazayeri, as long as hibernate still works ... think it would. |
| 19:41:16 | <jkeiper> djazayeri, so, interpreting it to a boolean is a bad idea then? |
| 19:41:25 | <andreapat> jkeiper, let me take a look at what's going on - thanks! |
| 19:41:41 | <djazayeri> jkeiper: if it's a Boolean field on the class, it should have a getXyz getter that returns a Boolean. |
| 19:41:54 | <jkeiper> andreapat, i think we may want to just change the type of PersonMergeLogData.priorDateOf* to Boolean |
| 19:42:02 | <djazayeri> jkeiper: if the property is a Boolean (and we want it to be because it supports null)... |
| 19:42:04 | <djazayeri> yeah, sounds right |
| 19:42:16 | <jkeiper> djazayeri, the problem is the merge trying to capture prior info |
| 19:42:21 | <andreapat> jkeiper, djazayeri, doesn't autoboxing (or unboxing) take care of the primitive - object thing? |
| 19:42:25 | <jkeiper> djazayeri, it is what casts the Boolean to a boolean |
| 19:42:38 | <jkeiper> andreapat, not when it's null |
| 19:42:39 | <djazayeri> andreapat: doesn't handle nulls when going from Boolean to boolean. |
| 19:43:00 | <andreapat> djazayeri, aah good point |
| 19:43:13 | *** ningosi has joined #openmrs |
| 19:46:23 | <jkeiper> wyclif_, after messing around with it this week it seems the best way is: public Patient registerPatient(Patient, List<Relationship>); |
| 19:46:49 | <jkeiper> returning the persisted patient (unless you think we should set the incoming parameter to the persisted patient so it can be returned) |
| 19:46:51 | <jkeiper> ...? |
| 19:47:55 | <jkeiper> wyclif_, ok? |
| 19:48:21 | <wyclif_> jkeiper, that is what i have |
| 19:48:34 | *** ningosi is now known as Ojwanganto |
| 19:48:34 | <jkeiper> wyclif_, OK |
| 19:48:36 | <jkeiper> :-D |
| 19:48:36 | <wyclif_> jkeiper, i was just confirming |
| 19:48:47 | <jkeiper> wyclif_, np |
| 19:48:54 | <wyclif_> jkeiper, what is the logging have to do with it |
| 19:50:07 | <jkeiper> wyclif_, logging can just be a log.info() |
| 19:50:15 | <jkeiper> wyclif_, just want to have some indication that it has happened |
| 19:51:38 | <wyclif_> jkeiper, i thought patient service will do that when saving the patient object |
| 19:59:15 | <jkeiper> wyclif_, yes i think so ... |
| 19:59:29 | <jkeiper> wyclif_, but we are _registering_ |
| 19:59:39 | <jkeiper> wyclif_, even though we do very little else, it's significant enough to log |
| 19:59:50 | <wyclif_> jkeiper, ok |
| 19:59:52 | <jkeiper> wyclif_, don't you agree? |
| 20:09:07 | <wyclif_> jkeiper, yes |
| 20:10:34 | <wyclif_> jkeiper, did you create a ticket for the RegistrationValidator |
| 20:22:20 | *** wyclif_ has quit IRC |
| 20:23:51 | <jkeiper> i did ... but oh well |
| 20:26:47 | *** wyclif_ has joined #openmrs |
| 20:34:26 | *** cpower has quit IRC |
| 20:34:54 | *** jkeiper has quit IRC |
| 20:35:24 | *** Ojwanganto has quit IRC |
| 20:38:07 | *** jkeiper has joined #openmrs |
| 20:38:07 | *** ChanServ sets mode: +v jkeiper |
| 21:06:42 | *** jkeiper has quit IRC |
| 21:19:59 | *** jkeiper has joined #openmrs |
| 21:19:59 | *** ChanServ sets mode: +v jkeiper |
| 21:29:22 | *** rafa has joined #openmrs |
| 21:29:22 | *** ChanServ sets mode: +v rafa |
| 21:36:22 | *** rafa has quit IRC |
| 21:51:06 | *** jkeiper has quit IRC |
| 21:57:26 | *** dkayiwa has joined #openmrs |
| 22:05:57 | *** andreapat has quit IRC |
| 22:07:06 | *** jkeiper has joined #openmrs |
| 22:07:06 | *** ChanServ sets mode: +v jkeiper |
| 22:10:55 | *** suranga_ has quit IRC |
| 22:46:44 | *** dkayiwa has quit IRC |
| 23:12:30 | *** andreapat has joined #openmrs |
| 23:18:39 | <andreapat> djazayeri, u around? All those comments from Rafal - not sure what the consensus is does isDeathdateEstimated get removed? |
| 23:34:17 | <djazayeri> andreapat: the deathdateEstimated field is a Boolean (capital B, right?) |
| 23:34:41 | <djazayeri> andreapat: we should get rid of the isDeathdateEstimated method, but keep (or add) a "Boolean getDeathdateEstimated()" method |
| 23:35:24 | <djazayeri> andreapat: and that's just a plain getter. |
| 23:48:07 | <andreapat> djazayeri, from Person.java: private Boolean deathdateEstimated = false; |
| 23:50:36 | <andreapat> djazayeri, there is a getDeathdateEstimated() method but it returns isDeathdateEstimated(); |
| 23:51:37 | <djazayeri> andreapat: get rid of isDeathdateEstimated(). It is incorrect. |
| 23:53:10 | <andreapat> djazayeri, ok - then getDeathdateEstimated() should be changed to return deathDateExtimated, right? |
| 23:53:19 | <djazayeri> andreapat: yes |
| 23:54:06 | <andreapat> djazayeri, ok thanks |