| 00:00:52 | *** yony258 has quit IRC |
| 00:01:50 | *** Mkop has quit IRC |
| 00:29:58 | *** andreapat has quit IRC |
| 00:41:05 | *** sgithens has joined #openmrs |
| 01:00:52 | *** wyclif_ has joined #openmrs |
| 01:38:35 | *** sgithens has quit IRC |
| 01:44:34 | *** wyclif_ has quit IRC |
| 01:54:01 | *** wyclif_ has joined #openmrs |
| 02:01:18 | *** wyclif_ has quit IRC |
| 02:05:19 | *** djazayeri has quit IRC |
| 02:22:48 | *** harshadura_ has joined #openmrs |
| 02:24:00 | *** harshadura has quit IRC |
| 02:26:16 | *** jkeiper has joined #openmrs |
| 02:26:16 | *** ChanServ sets mode: +v jkeiper |
| 03:02:31 | *** harshadura_ has quit IRC |
| 03:33:36 | *** wyclif_ has joined #openmrs |
| 03:37:39 | *** wyclif_ has quit IRC |
| 03:49:32 | *** suranga has joined #openmrs |
| 03:49:32 | *** ChanServ sets mode: +v suranga |
| 03:52:46 | <suranga> !history rafa |
| 03:52:46 | <OpenMRSBot> suranga: Error: "history" is not a valid command. |
| 04:16:58 | *** wyclif_ has joined #openmrs |
| 04:37:18 | *** wyclif_ has quit IRC |
| 04:46:31 | *** wyclif_ has joined #openmrs |
| 05:02:12 | *** wyclif_ has quit IRC |
| 05:17:40 | *** wyclif_ has joined #openmrs |
| 05:29:40 | *** kishoreyekkanti has joined #openmrs |
| 06:02:39 | *** djazayeri has joined #openmrs |
| 06:02:39 | *** ChanServ sets mode: +o djazayeri |
| 07:23:23 | *** dkayiwa has joined #openmrs |
| 07:35:16 | *** ningosi has joined #openmrs |
| 07:35:30 | *** ningosi is now known as Ojwanganto |
| 07:36:24 | <Ojwanganto> hi jkeiper |
| 07:36:59 | <dkayiwa> Ojwanganto: he must be sleeping :) |
| 07:37:15 | <Ojwanganto> dkayiwa, ooh |
| 07:37:22 | <Ojwanganto> Hi dkayiwa |
| 07:37:35 | <dkayiwa> Ojwanganto: hi :) |
| 07:37:47 | <Ojwanganto> dkayiwa, I am having some problem |
| 07:38:03 | <Ojwanganto> dkayiwa, using the AdministrativeService |
| 07:39:03 | <Ojwanganto> dkayiwa, when i do something like this |
| 07:39:08 | <Ojwanganto> dkayiwa, public static final PatientIdentifierType cccPatientIdentifierType = MohCacheUtils.getPatientIdentifierType(Context.getAdministrationService().getGlobalProperty("cccgenerator.CCC")); |
| 07:39:23 | <Ojwanganto> dkayiwa, at the class level |
| 07:40:28 | <Ojwanganto> dkayiwa, i get a value different from when i declare the same variable as a local variable within a class |
| 07:40:37 | <Ojwanganto> dkayiwa, what could be the problem? |
| 07:41:07 | <dkayiwa> Ojwanganto: can you pastebin your class including the two places where you get different values? |
| 07:41:26 | <Ojwanganto> dkayiwa, fine |
| 07:44:34 | <Ojwanganto> dkayiwa, The url to the code is http://pastebin.com/W2zRULzR |
| 07:45:24 | <dkayiwa> Ojwanganto: looking.... |
| 07:45:53 | <Ojwanganto> dkayiwa, these two variables cccPatientIdentifierType and pit reference the same GlobalProperty |
| 07:46:13 | <dkayiwa> Ojwanganto: ok |
| 07:46:18 | <Ojwanganto> dkayiwa, but their toString results in different values |
| 07:47:04 | <dkayiwa> Ojwanganto: why do you store value in cccPatientIdentifierType variable? |
| 07:47:27 | <dkayiwa> Ojwanganto: why don't you just call Context.getAdministrationService().getGlobalProperty whenever you need its value? |
| 07:48:02 | <Ojwanganto> dkayiwa, it is a code i took over from someone |
| 07:48:33 | <Ojwanganto> dkayiwa, so may be i need to do away with the variable |
| 07:48:42 | <dkayiwa> Ojwanganto: yes you need to |
| 07:49:01 | <dkayiwa> Ojwanganto: static variables are to be avoided as much as possible |
| 07:49:14 | <Ojwanganto> dkayiwa, i get the point |
| 07:49:16 | <dkayiwa> Ojwanganto: do not store that value in a class variable |
| 07:49:36 | <dkayiwa> Ojwanganto: whenever you need it, retrieve it with the call for Context.getAdministrationService().getGlobalProperty |
| 07:50:06 | <Ojwanganto> dkayiwa, thanks for the good piece |
| 07:50:15 | <Ojwanganto> dkayiwa, i can now continue |
| 07:50:23 | <Ojwanganto> dkayiwa, thanks once more |
| 07:50:49 | <dkayiwa> Ojwanganto: you are welcome |
| 07:55:25 | *** dkayiwa has quit IRC |
| 07:56:48 | *** dkayiwa has joined #openmrs |
| 08:07:21 | *** Ojwanganto has quit IRC |
| 08:18:09 | <dkayiwa> hi suranga |
| 08:18:12 | *** ibewes has joined #openmrs |
| 08:18:26 | <suranga> dkayiwa, good mornnggg :) :) |
| 08:18:35 | <ibewes> howdy folks! |
| 08:18:36 | <dkayiwa> suranga: can you send me the omod |
| 08:18:45 | <dkayiwa> hey ibewes |
| 08:18:53 | <suranga> dkayiwa, im sorry, um.. omod ? |
| 08:18:57 | <suranga> for hl7query ? |
| 08:19:01 | <dkayiwa> suranga: your email |
| 08:20:22 | <suranga> dkayiwa, thank you, I'll do so :-) |
| 08:20:39 | <ibewes> is there a page that details how @MODULE_ID@ gets replaced with the module id? |
| 08:21:26 | <ibewes> it seems like there are different rules depending on the context (in a string, a jsp page, messages, etc) |
| 08:21:47 | <suranga> dkayiwa, I had made some changes to the module, plase hang on, i'll revert :-) |
| 08:22:02 | <dkayiwa> suranga: ok :) |
| 08:22:41 | <dkayiwa> ibewes: there are times when it does not get replaced for me too |
| 08:23:06 | <ibewes> dkayiwa: heh... at least I'm not the only one |
| 08:23:25 | <dkayiwa> ibewes: and when it happens, i simply replace it with the real module id :) |
| 08:23:46 | <ibewes> dkayiwa: ok, that's good to know. I was thinking of doing the same thing |
| 08:25:11 | *** kavuri has joined #openmrs |
| 08:32:23 | <suranga> hi, just emailed you :) |
| 08:32:33 | <dkayiwa> suranga: ok |
| 08:32:47 | <suranga> dkayiwa, I need to vanish for a while, will return soon :) |
| 08:32:53 | <dkayiwa> suranga: ok |
| 08:37:50 | *** suranga has quit IRC |
| 08:46:01 | *** tobin_g has joined #openmrs |
| 08:46:30 | <tobin_g> good morning dkayiwa |
| 08:46:37 | <dkayiwa> tobin_g: morning |
| 08:46:53 | <tobin_g> dkayiwa: the fellows were up committing late last night! |
| 08:47:47 | <tobin_g> dkayiwa: was about to ask you for the latest omod but then i realized that things should be functional enough to use CI for some testing |
| 08:48:30 | <dkayiwa> tobin_g: aha |
| 08:51:40 | <tobin_g> dkayiwa: if I find small changes (like date picker instead of date/time picker) should those be individual tickets or comments on current ticket? |
| 08:51:40 | *** djazayeri has quit IRC |
| 08:53:48 | <dkayiwa> tobin_g: comments on tickets |
| 08:54:52 | <tobin_g> dkayiwa: can you tell if the add appointment block feature that adam created is also making time slots? because i can't find any time slots when i search in yonatan's create appointment page |
| 08:55:04 | <tobin_g> dkayiwa: can't look in the db since i'm just on the CI server |
| 08:55:25 | <ibewes> tobin_g: is this up on github? I'd love to check it out |
| 08:55:37 | <tobin_g> ibewes: it should be! |
| 08:55:46 | <tobin_g> ibewes: you can also sign into your CI server and play with it |
| 08:55:54 | <tobin_g> http://gw65.iu.xsede.org:8080/openmrs/index.htm |
| 08:56:05 | <tobin_g> admin/DevTest01 |
| 08:56:16 | <ibewes> tobin_g: awesome... thanks! |
| 08:56:17 | <dkayiwa> ibewes: https://github.com/openmrs/openmrs-module-appointment/ |
| 08:56:21 | <OpenMRSBot> <http://ln-s.net/+HdB> (at github.com) |
| 08:56:35 | <tobin_g> ibewes: getting there but not quite functional yet |
| 08:57:35 | *** robbyoconnor has joined #openmrs |
| 08:57:35 | *** ChanServ sets mode: +v robbyoconnor |
| 08:57:49 | <ibewes> tobin_g: well once it is more stable we will definitely start using it at our sites |
| 08:57:50 | <tobin_g> ibewes: everything is accessible via the admin page for now |
| 08:58:03 | <tobin_g> ibewes: :D where are you located? |
| 08:58:15 | <ibewes> tobin_g: Nairobi, Kenya |
| 08:58:19 | <tobin_g> ibewes: I don't think it'll be too long before we've got something useful. |
| 08:58:26 | <tobin_g> ibewes: what kind of clinics? |
| 08:58:56 | <ibewes> tobin_g: right now we're working with a small clinic and soon a smaller hospital |
| 08:59:05 | <tobin_g> ibewes: Wes Brown didn't recognize your irc name |
| 08:59:14 | <ibewes> tobin_g: yup, that's me :) |
| 08:59:19 | <tobin_g> ibewes: now I know what we're talking about! |
| 08:59:31 | <tobin_g> ibewes: you've done some work on queueing right? |
| 08:59:38 | <ibewes> tobin_g: yup yup... you've been making great progress! |
| 08:59:54 | <tobin_g> ibewes: thanks, i give the credit to dkayiwa and the students adam & yonatan |
| 09:00:10 | <dkayiwa> tobin_g: more to the students :) |
| 09:00:14 | <dkayiwa> and you :) |
| 09:00:19 | <tobin_g> dkayiwa: you're too kind |
| 09:00:31 | <dkayiwa> tobin_g: because thats the truth :) |
| 09:00:43 | <tobin_g> ibewes: we should skype one of these days and make sure that what we're building meets your requirements as well |
| 09:00:47 | <ibewes> tobin_g: yeah, but we sidelined it for the time being. The current code for our list manager is here: https://github.com/OpenHMIS/openmrs-module-openhmis.plm |
| 09:00:51 | <OpenMRSBot> <http://ln-s.net/+HdF> (at github.com) |
| 09:01:02 | <tobin_g> ibewes: as we move onto queuing will check that out |
| 09:01:03 | <ibewes> tobin_g: but it's pretty rough so it'll need some work to be easily usable |
| 09:01:33 | <tobin_g> ibewes: our next project is to make a really nice queuing module so we'll be in touch |
| 09:01:41 | <ibewes> tobin_g: yeah, definitely. It would be good to catch up |
| 09:01:44 | <tobin_g> ibewes: i'd just be curious to know if our appointment module will meet your workflow |
| 09:01:57 | <ibewes> tobin_g: me too! |
| 09:02:04 | <tobin_g> ibewes: we tried to build it reasonably generic but everyone has their own stuff of course |
| 09:02:25 | <ibewes> tobin_g: yeah... that's always the difficulty isn't it |
| 09:02:31 | <tobin_g> ibewes: we're going to be doing at least 2 more sprints in the coming months be great to have you developing with us :-) |
| 09:03:22 | <ibewes> tobin_g: thanks kindly... we're figuring out our next steps now (just finish a cashier module) so hopefully we can keep some time open to join your team |
| 09:03:56 | <tobin_g> ibewes: sounds great. we're not sure when the next sprint will be but of course keep the community informed! |
| 09:04:23 | <tobin_g> ibewes: do you guys use the standard openmrs interface for your app? |
| 09:04:54 | <ibewes> tobin_g: yes |
| 09:05:02 | <tobin_g> ibewes: i have an idea for a really simple module that i think will make a HUGE difference for clinicians, wondering if you have made anything like it |
| 09:05:11 | <tobin_g> basically it's a vital signs page |
| 09:05:14 | <tobin_g> ibewes: http://snag.gy/KLoq1.jpg |
| 09:05:50 | <tobin_g> ibewes: it would add a tab onto the main patient dashboard that contains a table of the most recent numeric vital signs. the vital signs displayed would be configured via a single global property (comma separated concept IDs) |
| 09:06:24 | <tobin_g> ibewes: if we got really fance we could have a link from the column names to make a graph on the graphs tab |
| 09:06:47 | <tobin_g> dkayiwa: looking for a project? [:) |
| 09:07:22 | <dkayiwa> tobin_g: about? |
| 09:07:23 | <ibewes> tobin_g: cool idea |
| 09:07:38 | <tobin_g> dkayiwa: look @ the link I just sent ibewes |
| 09:07:58 | <ibewes> tobin_g: doesn't even seem like that much work |
| 09:08:18 | <tobin_g> ibewes: yeah, i think I could almost do it! |
| 09:08:25 | <ibewes> tobin_g: hehe |
| 09:08:29 | <tobin_g> ibewes: I think it would take one of you pros an afternoon! :D |
| 09:09:14 | <tobin_g> ibewes: and from my time in clinics using other EMRs I can tell you it'd be worth it's weight in gold. i think it's one of the biggest things missing for being able to effectively use our web app for point of care |
| 09:09:24 | <tobin_g> ibewes: huge bang for the buck |
| 09:10:03 | <ibewes> tobin_g: right... now if I only had a free afternoon and were an openmrs "pro" :) |
| 09:10:26 | <tobin_g> ibewes: seems that you've outwitted my sales tactics |
| 09:10:52 | <tobin_g> ibewes: but don't worry, dkayiwa already has 2/3 of it done |
| 09:10:53 | <ibewes> tobin_g: I really do like the core idea though, especially introducing simple graphing |
| 09:11:17 | <dkayiwa> tobin_g: no way :) |
| 09:11:31 | <tobin_g> dkayiwa: that wasn't fair we'll talk in an hour :D |
| 09:11:35 | <dkayiwa> tobin_g: maybe Yonatan :) |
| 09:11:43 | <tobin_g> dkayiwa: I know I'm going to try to put the hard sell on |
| 09:12:22 | <tobin_g> dkayiwa: just so i can get an idea, how long do you think it would take to make? |
| 09:12:35 | <tobin_g> ibewes: yeah the graphing stuff theoretically exists in the app already |
| 09:12:40 | <dkayiwa> tobin_g: not sure for now |
| 09:15:38 | <tobin_g> ibewes: and it works, just tested |
| 09:15:57 | <ibewes> tobin_g: sweet! |
| 09:16:33 | <tobin_g> ibewes: it actually shows a little table of the values as well which is nice. but for stuff like weight, glucose, A1Cs, it's invaluable to the clinican |
| 09:17:24 | *** suranga has joined #openmrs |
| 09:19:12 | <ibewes> tobin_g: is that online somewhere? |
| 09:19:29 | <tobin_g> ibewes: what's that, the graphing? |
| 09:19:48 | <tobin_g> ibewes: here's an example http://gw65.iu.xsede.org:8080/openmrs/patientDashboard.form?patientId=2&phrase=horatio |
| 09:19:51 | <OpenMRSBot> <http://ln-s.net/+HdS> (at gw65.iu.xsede.org:8080) |
| 09:20:03 | <ibewes> tobin_g: is that a part of that vitals module idea or something separate? |
| 09:20:20 | <tobin_g> part of the default openmrs web app - on the patient dashboard there is a tab called "graphs" we all have it :D |
| 09:20:34 | <tobin_g> ibewes: just not convinced anyone uses it. see line up, didn't tag you |
| 09:21:11 | <ibewes> tobin_g: heheh... you can tell I obviously don't use it! |
| 09:21:23 | <tobin_g> ibewes: devs..... |
| 09:22:38 | <ibewes> tobin_g: :) |
| 09:35:14 | <tobin_g> hi suranga |
| 09:35:50 | <suranga> tobin_g, hello ! :) |
| 09:36:24 | <tobin_g> suranga: how you doing? nice to see you online since you're such a traveling man! |
| 09:36:46 | <suranga> tobin_g, :P Unfortuately i've been grounded until I finished my degree :( |
| 09:37:00 | <tobin_g> suranga: no that's a :) |
| 09:37:06 | <tobin_g> suranga: how much time left? |
| 09:37:20 | <suranga> ending in May 2013 :) :) |
| 09:37:34 | <tobin_g> suranga: woooooo hooo! |
| 09:37:40 | <tobin_g> suranga: are you super swamped with it? |
| 09:37:47 | <suranga> yeah, finally |
| 09:38:15 | <suranga> ssomewhat, im afraid. i still try to take up Omrs stuff, but i wasnt as frequent as I was earlier :( |
| 09:38:43 | <tobin_g> suranga: i know it's very hard to do both |
| 09:38:49 | <tobin_g> suranga: are you working a lot for jembi still? |
| 09:39:00 | <suranga> tobin_g, both + employment at Jembi |
| 09:39:04 | <suranga> :P |
| 09:39:33 | <suranga> but its not bad, at least the degree is the only one out of the three that I dont like :P |
| 09:41:07 | <tobin_g> suranga: true! |
| 09:41:28 | <tobin_g> suranga: i was going to try and convince you to help me with a little project but i think you might be too busy... |
| 09:42:10 | <tobin_g> http://snag.gy/KLoq1.jpg |
| 09:42:16 | <suranga> tobin_g, well, I can always try :) |
| 09:42:23 | * suranga goes to look |
| 09:42:34 | <tobin_g> suranga: it would add a tab onto the main patient dashboard that contains a table of the most recent numeric vital signs. the vital signs displayed would be configured via a single global property (comma separated concept IDs) |
| 09:43:46 | <suranga> tobin_g, that does make sense :) |
| 09:43:55 | <suranga> how far long have you come ? |
| 09:44:02 | <tobin_g> suranga: you saw it! |
| 09:44:40 | <tobin_g> suranga: i'm thinking it would be a module |
| 09:45:04 | <tobin_g> suranga: i think it should be quite easy to make and from my time in clinics using other EMRs I can tell you it'd be worth it's weight in gold. i think it's one of the biggest things missing from the web app for being able to effectively use our web app for point of care |
| 09:45:10 | <suranga> tobin_g, yep, thats feasable. Ive seen modules that add tabs to the dashboard |
| 09:45:31 | <tobin_g> suranga: that's an easy part - made one of those with the file browser module |
| 09:45:47 | <tobin_g> suranga: if we got really fnacy we could have a link from the column names to make a graph on the graphs tab that already exists |
| 09:46:35 | <suranga> tobin_g, have you considered mailing the dev list ? |
| 09:46:44 | <tobin_g> suranga: not yet, it's a new idea |
| 09:47:55 | <tobin_g> suranga: you going to be on for a bit?need to run over to the store |
| 09:48:12 | <suranga> tobin_g, um.. sure, ill be here :) |
| 09:48:20 | <tobin_g> suranga: ok i'll ttyiab |
| 09:50:26 | <suranga> hi dkayiwa :) |
| 09:50:38 | <dkayiwa> suranga: hi |
| 09:50:59 | <suranga> dkayiwa, im terribly sorry, I was wondering if you had any luck with that :) |
| 09:51:14 | <dkayiwa> suranga: not yet :) |
| 09:51:35 | <suranga> dkayiwa, no worries, lets see :) |
| 10:56:08 | *** kernelhunter92 has joined #openmrs |
| 10:58:03 | *** ibewes has quit IRC |
| 10:59:36 | *** rkorytkowski has joined #openmrs |
| 10:59:36 | *** ChanServ sets mode: +v rkorytkowski |
| 10:59:52 | *** rkorytkowski is now known as rafa |
| 11:05:00 | *** suranga has quit IRC |
| 11:40:18 | *** kernelhunter92 has left #openmrs |
| 11:51:32 | *** adam_l has joined #openmrs |
| 11:54:20 | *** yony258 has joined #openmrs |
| 11:55:52 | *** adam_l has quit IRC |
| 11:56:21 | <yony258> dkayiwa: Hi, whats up? |
| 11:56:42 | <dkayiwa> yony258: wazup |
| 11:57:08 | <yony258> dkayiwa: :) Had any chance to do some code-review? |
| 11:58:40 | <dkayiwa> yony258: was one commit. not so? |
| 11:58:49 | <yony258> dkayiwa: Yea |
| 11:58:57 | <dkayiwa> yony258: which url? |
| 11:59:06 | <yony258> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/b29d7bb0d701f2b38d38cfe7e5cf4b38842ead1c |
| 11:59:11 | <OpenMRSBot> <http://ln-s.net/+Hfa> (at github.com) |
| 11:59:15 | <dkayiwa> yony258: checking.... |
| 12:00:42 | *** jkeiper has quit IRC |
| 12:06:41 | <dkayiwa> yony258: the commit looks excellent :) |
| 12:08:05 | <yony258> dkayiwa: Cool, so from your perspective is there anything left to change? (I'll ask tobin_g too) |
| 12:08:18 | <dkayiwa> yony258: will need to test first |
| 12:08:30 | <tobin_g> yony258: change on what? |
| 12:08:44 | <yony258> tobin_g: AM-4 |
| 12:08:53 | <yony258> tobin_g: !ticket AM-4 |
| 12:09:01 | <yony258> !ticket AM-4 |
| 12:09:03 | <OpenMRSBot> yony258: [#AM-4] Create new Appointment - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-4 |
| 12:10:10 | <tobin_g> yony258: I'm reviewing Adam's stuff right now with him on skype then I will get to AM-4 |
| 12:10:23 | <yony258> yony258: Ok no problem ;) |
| 12:10:43 | <tobin_g> I'm going to have adam come here so we can talk about a feature together quickly yony258 dkayiwa |
| 12:10:57 | <dkayiwa> tobin_g: ok |
| 12:11:41 | *** adam_l_ has joined #openmrs |
| 12:11:59 | <tobin_g> hi adam_l_ |
| 12:12:06 | <yony258> dkayiwa: If we will change the liquibase (like add appointment type to appointment). who will be responsible to update the CI server? |
| 12:12:27 | <tobin_g> yony258 and dkayiwa i've been talking with adam_l_ about time slots |
| 12:12:36 | <adam_l_> tobin_g: yony258 dkayiwa Hi everyone |
| 12:12:44 | <yony258> adam_l_: Hi |
| 12:12:51 | <tobin_g> yony258: dkayiwa adam_l_ has been working on AM-6 and we can now create an appointment block, but it doesn't automatically do the time slots yet. |
| 12:13:40 | <tobin_g> yony258: dkayiwa adam_l_ to start we talked about just letting the user define the length of the time slot - do you think we should do it as a dropdown with set times (1 hour, 2 hour, 4 hour etc) or do you think we should make it a text input box where they can put in the number of minutes to the time slot |
| 12:14:26 | <tobin_g> adam_l_: dkayiwa yony258 i think that dropdown is more user friendly but text box is surely more flexible for other implementations - because if they set the slots to be (for example) 15 minutes then they can give their patients more granularity on when to arrive |
| 12:14:46 | <tobin_g> adam_l_: yony258 dkayiwa thoughts? |
| 12:15:15 | <tobin_g> yony258: dkayiwa if we lose adam_l_ it's because his battery died, he told me it was low before |
| 12:15:46 | <yony258> tobin_g: My problem with splitting to time slots is less about that, its more about how to split the time so we will have the minimal "Holes" |
| 12:15:54 | <yony258> tobin_g: Let me define Hole |
| 12:16:14 | <yony258> tobin_g: Lets say we have a block with type's duration 8 min |
| 12:17:08 | <dkayiwa> tobin_g: yony258 adam_l_ When a user books a time slot, do they book something like just 10,20,30, etc minutes or something like from 10:30 AM to 11:15 AM ? |
| 12:17:09 | <yony258> tobin_g: Lets say we split by 1h slots. than in each slot we will have Hole with size of 4 minutes. |
| 12:17:49 | <adam_l_> yony258: We will need a restrication like minimal number of time slots |
| 12:18:03 | <yony258> tobin_g: But we can do that more efficient, we can say - "This suggested split is 56 min" |
| 12:18:25 | <yony258> tobin_g: But it becomes more complex with multiple types |
| 12:19:00 | <tobin_g> yony258: i understand what you're saying and it all makes a lot of sense but we may be a little bit premature here. let me explain |
| 12:19:44 | <tobin_g> yony258: for starters, in the real working of the clinics time is a bit flexible so some "wiggle room" isn't always a bad thing |
| 12:20:04 | <adam_l_> dkayiwa: yony258 tobin_g need to fo sorry. i will catch up soon |
| 12:20:16 | <tobin_g> adam_l_: ok cool will summarize as a comment on the ticket |
| 12:20:28 | <yony258> adam_l_: We can describe it as an equation slot_duration = a*type1_length + b*type2_length.... and we will need to find the values that satisfy thuis |
| 12:20:30 | <yony258> this* |
| 12:20:41 | <adam_l_> tobin_g: thanks |
| 12:20:55 | <yony258> tobin_g: Lets move to Skype maybe? |
| 12:20:57 | <tobin_g> yony258: the other thing is that the time slot may often be set more by the workflow of the clinic than by what's the most efficient in terms of time |
| 12:21:00 | <tobin_g> yony258: ok |
| 12:21:17 | <yony258> dkayiwa: Is it ok to talk on Skype |
| 12:21:19 | <yony258> ? |
| 12:21:48 | *** kavuri has quit IRC |
| 12:21:49 | <tobin_g> dkayiwa: due to the university's internet restrictions yony258 has to use the web-based IRC which is qutie annoying |
| 12:22:03 | <tobin_g> dkayiwa: we can just summarize for you at the end of this convo if you prefer |
| 12:22:06 | <adam_l_> yony258: sounds great and do-able. |
| 12:22:19 | <yony258> adam_l_: But it creates another issue :/ |
| 12:22:22 | <dkayiwa> tobin_g: ok |
| 12:25:01 | *** adam_l__ has joined #openmrs |
| 12:26:17 | *** adam_l_ has quit IRC |
| 12:31:17 | *** adam_l__ has quit IRC |
| 12:33:25 | *** adam_l_ has joined #openmrs |
| 12:37:53 | <adam_l_> yony258: sorry i got dc. can you send again? |
| 12:39:27 | <tobin_g> adam_l_: we moved to skype, let me add you to the convo |
| 12:39:41 | *** adam_l_ has quit IRC |
| 12:48:51 | *** kavuri has joined #openmrs |
| 13:32:11 | *** jkeiper has joined #openmrs |
| 13:32:11 | *** ChanServ sets mode: +v jkeiper |
| 13:33:22 | *** wyclif_ has quit IRC |
| 13:39:24 | <kavuri> dkayiwa: Hi |
| 13:39:39 | <dkayiwa> kavuri: hi |
| 13:39:52 | <kavuri> dkayiwa: can you help me with using event module? |
| 13:40:09 | <kavuri> dkayiwa: I am trying to write a module that uses event module |
| 13:43:43 | <dkayiwa> kavuri: aha |
| 13:44:08 | <kavuri> dkayiwa: :) any help? |
| 13:44:45 | <dkayiwa> kavuri: am a newbie too with that module. but can see if i can try the smaller problems :) |
| 13:45:36 | <kavuri> dkayiwa: :) |
| 13:57:35 | *** kavuri has quit IRC |
| 14:01:51 | <dkayiwa> hi rafa |
| 14:02:00 | <rafa> dkayiwa: hi |
| 14:02:07 | <dkayiwa> rafa: do you know how i can make 1.9.x get this commit? https://github.com/dkayiwa/openmrs-core/commit/9b875510c018a2fdaf60df5f5bbb2ff0e965ad65 |
| 14:02:12 | <OpenMRSBot> <http://ln-s.net/+HhX> (at github.com) |
| 14:02:19 | <dkayiwa> rafa: i committed it after cherry-picking |
| 14:02:51 | <rafa> dkayiwa: and? |
| 14:03:17 | <dkayiwa> rafa: made some changes, and then: git pull --rebase upstream 1.9.x |
| 14:03:22 | <dkayiwa> rafa: then git pull |
| 14:03:31 | <dkayiwa> rafa: and finally git push |
| 14:03:38 | <rafa> dkayiwa: git push upstream 1.9.x ? |
| 14:03:47 | <dkayiwa> rafa: let me try that now |
| 14:04:14 | <rafa> dkayiwa: 'git push' pushes commits to your fork (origin) |
| 14:04:24 | <dkayiwa> rafa: oh i see |
| 14:04:55 | <rafa> dkayiwa: you should not do 'git pull' |
| 14:05:02 | <dkayiwa> rafa: oj |
| 14:05:03 | <dkayiwa> ok |
| 14:05:07 | <rafa> dkayiwa: only 'git pull --rebase upstream 1.9.x' |
| 14:05:16 | <dkayiwa> rafa: ok |
| 14:05:43 | <rafa> dkayiwa: again 'git pull' pulls from your fork, which is most likely behind upstream 1.9.x |
| 14:05:56 | <dkayiwa> rafa: ok |
| 14:10:01 | <jkeiper> hi |
| 14:14:25 | <cpower> hello |
| 14:15:20 | *** harshadura has joined #openmrs |
| 14:19:01 | <yony258> dkayiwa how's that? http://i.snag.gy/VcVPx.jpg |
| 14:20:00 | <yony258> dkayiwa: Nevermind let me send a more updated version |
| 14:20:08 | <dkayiwa> yony258: i do not like that other color :) |
| 14:20:27 | <yony258> dkayiwa: Yea? hmm let me find a different color :D thanks |
| 14:20:28 | <dkayiwa> yony258: by the way, when user changes theme, do the colors correspondingly change? |
| 14:20:46 | <dkayiwa> yony258: like if i change the theme to orange |
| 14:20:50 | <dkayiwa> yony258: of legacy |
| 14:20:50 | <yony258> dkayiwa: Nope, I didn't even knew there are themes until you just said that :O |
| 14:21:06 | <dkayiwa> yony258: on the admin screen |
| 14:21:13 | <dkayiwa> yony258: manage locales and themes |
| 14:21:40 | <yony258> dkayiwa: But I can easily do that using c:If right? |
| 14:22:01 | <dkayiwa> yony258: you could give it a try :) |
| 14:22:37 | <yony258> dkayiwa: Will do!, thank you |
| 14:30:50 | <jkeiper> hi ppl |
| 14:31:02 | <jkeiper> ready for the Registration Core Module Sprint Kickoff Meeting? |
| 14:31:16 | <jkeiper> wyclif is here ... just fighting with his timecard on a windows-- machine |
| 14:31:27 | <jkeiper> i see rafa and dkayiwa here |
| 14:31:32 | <dkayiwa> jkeiper: yes :) |
| 14:31:36 | *** wyclif_ has joined #openmrs |
| 14:31:54 | <jkeiper> ibewes is sadly missing |
| 14:32:08 | <rafa> jkeiper: hi |
| 14:32:24 | <jkeiper> rafa, :-) |
| 14:32:36 | <jkeiper> can you guys do a hangout? |
| 14:32:42 | <jkeiper> maybe PM me your gmail addresses? |
| 14:32:42 | <rafa> I can |
| 14:37:53 | *** kishoreyekkanti has quit IRC |
| 14:37:54 | <yony258> Not very important. but if anyone knows how can I identify the current selected theme so that my module will load css according to it. |
| 14:47:37 | <jkeiper> https://plus.google.com/hangouts/_/3ac1df254ff59b4523bc4763df8e076af05165c8?hcb=2&hii=101576353212395772898&hit=1355495670719&htp=0&hmv=0 |
| 14:47:39 | <OpenMRSBot> <http://ln-s.net/+Hi_> (at plus.google.com) |
| 15:01:04 | <cpower> Hello everyone! |
| 15:01:20 | <dkayiwa> cpower: hi |
| 15:01:34 | *** applecool has joined #openmrs |
| 15:01:34 | *** ChanServ sets mode: +v applecool |
| 15:01:40 | <cpower> Are we ready to scrum? |
| 15:01:49 | <dkayiwa> yes |
| 15:01:50 | <cpower> !scrumon cpower |
| 15:01:50 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:02:40 | <cpower> Order: yony258, wyclif_, tobin_g, dkayiwa, rafa, jkeiper, darius when he shows, and Andrea when she shows |
| 15:02:52 | <yony258> Thursday: |
| 15:02:57 | <yony258> Finished functionality of AM-4 |
| 15:03:01 | <yony258> Finished code review from Daniel |
| 15:03:07 | <yony258> Friday: |
| 15:03:11 | <yony258> Recieved review from Tobin |
| 15:03:21 | <yony258> Working on that, will finish AM-4 today |
| 15:03:25 | <yony258> Saturday: |
| 15:03:47 | <yony258> Probably will do some university assignments, and thus will not make a lot of progress, but will try to start AM-10 |
| 15:03:51 | <yony258> Blockers: none |
| 15:05:32 | <wyclif_> Thursday: |
| 15:05:32 | <wyclif_> Dev call |
| 15:05:32 | <wyclif_> curating tickets |
| 15:05:32 | <wyclif_> Reviewed- TRUNK-2969 - New visit save errors should not clear new encounter rows |
| 15:05:32 | <wyclif_> Reviewed- TRUNK-3008 - DrugOrderValidator should allow a drug order with either a concept or drug |
| 15:05:33 | <wyclif_> TRUNK-3759 - The repeat interval unit gets changed to seconds no matter what it was previously |
| 15:05:35 | <wyclif_> |
| 15:05:37 | <wyclif_> Friday: |
| 15:05:39 | <wyclif_> curating tickets |
| 15:05:41 | <wyclif_> pick upa a sprint ticket |
| 15:05:43 | <wyclif_> |
| 15:05:45 | <wyclif_> Blockers: None |
| 15:06:42 | *** applecool has quit IRC |
| 15:06:46 | *** djazayeri has joined #openmrs |
| 15:06:46 | *** ChanServ sets mode: +o djazayeri |
| 15:07:59 | <cpower> Next! |
| 15:08:05 | <cpower> dkayiwa |
| 15:08:06 | *** andrea_ has joined #openmrs |
| 15:08:11 | <dkayiwa> Investigated Suranga's problem of Unable to parse order-by fragment |
| 15:08:12 | <dkayiwa> Reviewed a commit for Tobin's Team |
| 15:08:12 | <dkayiwa> Committed: Editing an encounter to set its encounterDatetime to a value invalid for the visit it belongs to gives an error, but changes the date anyway - TRUNK-3572 |
| 15:08:12 | <dkayiwa> Back ported to 1.9.x and closed: New visit save errors should not clear new encounter rows - TRUNK-2969 |
| 15:08:12 | <dkayiwa> Attended: Registration Core Module Sprint Kickoff Meeting |
| 15:08:13 | <dkayiwa> No Blockers |
| 15:08:29 | <rafa> Today: |
| 15:08:30 | <rafa> * Had to see a doctor in the morning, so I'll put in some hours over the weekend. |
| 15:08:30 | <rafa> * Started with RC-3: Add service method to search for similar persons and patients |
| 15:08:30 | <rafa> https://tickets.openmrs.org/browse/RC-3 |
| 15:08:30 | <rafa> No blockers. |
| 15:08:41 | <jkeiper> Until now: |
| 15:08:41 | <jkeiper> - added RC tickets for sprint |
| 15:08:41 | <jkeiper> - built RC rapid board |
| 15:08:41 | <jkeiper> - held RC sprint kickoff |
| 15:08:41 | <jkeiper> Until next sprint: |
| 15:08:41 | <jkeiper> - work with wyclif on RC-1, RC-2 |
| 15:08:43 | <jkeiper> - CALC-47 |
| 15:08:45 | <jkeiper> - AMPATH meetings |
| 15:08:47 | <jkeiper> Blockers: |
| 15:08:49 | <jkeiper> - None |
| 15:10:39 | <djazayeri> (sorry I'm late, who's next?) |
| 15:10:48 | <rafa> you :) |
| 15:11:05 | <djazayeri> Recently, and still today |
| 15:11:05 | <djazayeri> * Calls (OpenMRS, Mirebalais) |
| 15:11:05 | <djazayeri> * Exploring different form entry mechanisms (with the UI Framework) for mirebalais |
| 15:11:05 | <djazayeri> * Mailing lists |
| 15:11:05 | <djazayeri> No blockers |
| 15:11:07 | <djazayeri> no blockers |
| 15:11:17 | <cpower> andrea_ go for it |
| 15:12:05 | <andrea_> Thursday |
| 15:12:05 | <andrea_> Dev call |
| 15:12:05 | <andrea_> Find problem causing failing tests on TRUNK-2768 |
| 15:12:05 | <andrea_> |
| 15:12:05 | <andrea_> Friday |
| 15:12:06 | <andrea_> Find problem causing failing tests on TRUNK-2768 |
| 15:12:08 | <andrea_> Test Atlas module |
| 15:12:10 | <andrea_> Blocker failing tests on TRUNK-2768 |
| 15:13:19 | <rafa> !ticket TRUNK-2768 |
| 15:13:21 | <OpenMRSBot> rafa: [#TRUNK-2768] Add column deathdate_estimated to person table - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2768 |
| 15:13:59 | <djazayeri> andrea_: is what you have now committed to a branch, that someone could check out from github and look at? |
| 15:14:19 | <rafa> andrea_: why don't you create a pull request and we see travis-ci failing? :) |
| 15:14:26 | <andrea_> djazayeri, yes |
| 15:14:37 | <andrea_> djazayeri, have a question |
| 15:14:39 | <djazayeri> ooh! travis is even better! |
| 15:15:19 | <andrea_> rafa what is travis-ci? |
| 15:15:55 | <andrea_> djazayeri, rafa, have a question |
| 15:16:02 | <rafa> andrea_: it's our CI for testing pull requests, you don't have to do anything extra. Just create a pull request |
| 15:16:18 | <rafa> andrea_: and the travis-ci will run tests for it |
| 15:16:36 | <andrea_> rafa, ok |
| 15:16:46 | <cpower> !scrumoff |
| 15:16:46 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:16:53 | <andrea_> https://tickets.openmrs.org/browse/TRUNK-2768 |
| 15:16:53 | <andrea_> The PersonFormController and PatientFormControllers might need to be changed as well to accept the user input. |
| 15:16:53 | <andrea_> What are these? |
| 15:16:53 | <andrea_> Feel like I'm missing something. |
| 15:18:19 | <rafa> andrea_: you mean you can't find the files? /openmrs-web/src/main/java/org/openmrs/web/controller/person/PersonFormController.java |
| 15:18:50 | <rafa> andrea_: /openmrs-web/src/main/java/org/openmrs/web/controller/patient/PatientFormController.java |
| 15:19:24 | <rafa> andrea_: ctrl + shift + t is your friend in Eclipse |
| 15:19:45 | <andrea_> rafa, yes - maybe this is problem - didn't show up in my greps |
| 15:20:24 | <andrea_> rafa, ok thanks |
| 15:23:25 | *** scnakandala has joined #openmrs |
| 15:24:19 | <scnakandala> hi ! |
| 15:29:52 | <andrea_> rafa, djazayeri, getting following message when CTRL_shift: |
| 15:30:02 | *** dkayiwa has left #openmrs |
| 15:30:18 | <andrea_> rafa, djazayeri, The jar file C:\Users\patandre\.m2\repository\org\openmrs-web\1.9.1\openmrs-web\1.9.1.jar has no source attachment |
| 15:31:07 | <andrea_> rafa, djazayeri - these aren't in my project |
| 15:31:36 | <djazayeri> control-shift-T will look for classes in all projects in your workspace... |
| 15:31:48 | *** scnakandala has quit IRC |
| 15:32:09 | *** scnakandala has joined #openmrs |
| 15:32:24 | <djazayeri> so if you have many things checked out (e.g. openmrs-core, and also a module that declares OpenMRS 1.9.1 as a dependency) then you need to be careful that you're choosing the right version of the class you searched for. |
| 15:32:27 | <djazayeri> andrea_: ^^ |
| 15:32:36 | <andrea_> djazayeri, did u see above message - they aren't there |
| 15:33:06 | <djazayeri> andrea_: if you press control-shift-T, and type PersonFormController, it shows you no results? |
| 15:33:13 | <djazayeri> andrea_: and gives an alert error? |
| 15:33:39 | <andrea_> djazayeri, this is what it says: The jar file C:\Users\patandre\.m2\repository\org\openmrs-web\1.9.1\openmrs-web\1.9.1.jar has no source attachment |
| 15:34:05 | <djazayeri> andrea_: when does it say this? after you choose PersonFormController? Or just when you try doing the search? |
| 15:34:44 | <jkeiper> do we have sources available in nexus? |
| 15:34:51 | <djazayeri> typically we do, yes. |
| 15:35:04 | <andrea_> djazayeri, when I look for PersonFormController |
| 15:36:08 | <djazayeri> andrea_: I'm not using eclipse these days, so I'm not remembering exactly how all this works, but is it possible that you have a project whose build path is set up wrong? |
| 15:36:15 | <djazayeri> in the workspace? |
| 15:36:34 | <djazayeri> e.g. go to the Problems view (I think?) and look for build path issues? |
| 15:38:28 | <andrea_> djazayeri, have 100 warning - going to start XCHAT on 2nd computer where project is |
| 15:39:01 | <djazayeri> andrea_: it tells you what type of errors/warnings they areâ¦only check to see if some mention build path |
| 15:39:03 | <djazayeri> or project setup |
| 15:41:05 | <andrea_> djazayeri, nothing about build path |
| 15:42:29 | <andrea_> djazayeri, nothing about project setup either |
| 15:43:28 | <djazayeri> andrea_: I don't know why control-shift-T isn't working then⦠but it's a really important shortcut... |
| 15:47:27 | <andrea_> djazayeri, I think control-shift-T is working but it's not ther somehow |
| 15:48:45 | <rafa> andrea_: do you have teamviewer? |
| 15:49:04 | <andrea_> rafa, yes |
| 15:49:23 | <rafa> andrea_: we could connect |
| 15:49:36 | <andrea_> rafa, ok |
| 15:49:56 | <rafa> andrea_: what is your skype? |
| 15:50:44 | <rafa> andrea_: google hangout would also work I guess |
| 15:51:45 | <andrea_> rafa, just says Andrea Patterson - how do I find my skype id? |
| 15:52:09 | <rafa> andrea_: in the profile tab |
| 15:52:15 | <rafa> Skype Name |
| 15:52:38 | <rafa> or else call me |
| 15:52:41 | <rafa> rafal.korytkowski |
| 15:53:04 | *** adam_l_ has joined #openmrs |
| 15:53:11 | <andrea_> rafa, ok will call you |
| 15:53:33 | <adam_l_> tobin_g: are you here? |
| 15:53:46 | <tobin_g> adam_l_: hi |
| 15:53:47 | *** yony258 has quit IRC |
| 15:54:04 | <adam_l_> tobin_g: Hi can you talk? |
| 15:54:12 | <tobin_g> adam_l_: of course |
| 15:54:31 | <tobin_g> adam_l_: i'm just reviewing your and yonatan's work to make some comments |
| 15:54:47 | <adam_l_> tobin_g: ok |
| 15:54:59 | <tobin_g> adam_l_: you're home now? |
| 15:55:02 | <adam_l_> tobin_g: I'm adding now the time slot to the appointment block form |
| 15:55:12 | <tobin_g> ok |
| 15:55:25 | <andrea_> rafa, think I am andrea.patterson - only used once |
| 15:55:29 | <adam_l_> tobin_g: but I'm faced with problems |
| 15:55:35 | <tobin_g> adam_l_: so I think it should be a small text box that can accept minutes up to the length of time block |
| 15:55:41 | <tobin_g> adam_l_: what's the problem? |
| 15:56:01 | <adam_l_> tobin_g: I understood that. |
| 15:56:09 | <tobin_g> ak |
| 15:56:10 | <adam_l_> tobin_g: we want it to be editable? |
| 15:56:12 | <tobin_g> adam_l_: k |
| 15:56:26 | <tobin_g> adam_l_: no it doesn't need to be |
| 15:56:34 | <rafa> andrea_: just call me |
| 15:56:36 | <tobin_g> adam_l_: but that's a very good point - it is confusing. |
| 15:56:52 | <andrea_> rafa, am trying to add contact - wants a phone number |
| 15:56:56 | <tobin_g> adam_l_: but when we delete a block we should delete the associated slots |
| 15:57:11 | <rafa> just search for rafal.korytkowski |
| 15:57:12 | <adam_l_> tobin_g: Yes that is another problem |
| 15:57:15 | <rafa> no phone number |
| 15:57:44 | <adam_l_> tobin_g: because we don't have right now a list of timeslots in AppointmentBlock object |
| 15:57:45 | <andrea_> rafa, wants a phone number |
| 15:58:40 | <rafa> andrea_: there's a search field right above your contact list |
| 15:58:50 | <tobin_g> adam_l_: let me look at the data model quickly |
| 15:58:53 | <rafa> andrea_: just put it there and hit enter |
| 15:59:19 | <tobin_g> adam_l_: but you have appointment_block_id in the time slot? |
| 15:59:36 | <tobin_g> adam_l_: or are you talking about the object that you've created at the java level |
| 16:01:20 | <andrea_> rafa, says you are not in my contacts |
| 16:01:38 | <andrea_> rafa, try andrea.patterson |
| 16:01:38 | <adam_l_> tobin_g: no I know that. just tought it's to do the long way. but ok I will solve it by using the id. |
| 16:02:11 | <andrea_> wyclif_, u here? |
| 16:02:11 | <tobin_g> adam_l_: or change the object? whatever you think will be better in the long runâ¦you're the expert |
| 16:02:49 | <adam_l_> tobin_g: I mean it's not that hard but I thought maybe there is a reason that it is like that. maybe I need to change the object so it will have a list of time slots. |
| 16:03:30 | <tobin_g> adam_l_: perhaps consult yonatan when he's back? daniel won't be on until tomorrow night because he observes the sabbath |
| 16:03:33 | <rafa> andrea_: did you get my contact request? |
| 16:04:38 | <tobin_g> adam_l_: do you have time to talk about some of my other suggestions? |
| 16:04:45 | <adam_l_> tobin_g: I think when it's 1-to-n we don't add the list. we add it only when it is n-to-n |
| 16:05:14 | <tobin_g> tobin_g: no idea if that's correct but i trust you |
| 16:05:19 | <andrea_> rafa, no - I am home not in office - does that matter? |
| 16:05:27 | <rafa> andrea_: I see no reply so I guess andrea.patterson isn't you :( |
| 16:06:00 | <andrea_> rafa, just got one from djazayeri |
| 16:06:10 | <adam_l_> tobin_g: because we don't need it really. anyway feel free to talk |
| 16:06:33 | <andrea_> djazayeri, did u sent me a contact request on skype? |
| 16:06:46 | <djazayeri> andrea_: maybe a long time ago. :-) not recently |
| 16:07:27 | <andrea_> djazayeri, can u see my skpe id? |
| 16:07:34 | <rafa> andrea_: I need to step away for a while |
| 16:07:47 | <andrea_> rafa, ok - sorry |
| 16:07:59 | <tobin_g> adam_l_: so let's start with the appointment blocks page |
| 16:08:10 | <rafa> andrea_: just add me to contacts when you figure it out :) |
| 16:08:10 | <adam_l_> tobin_g: ok |
| 16:08:20 | <tobin_g> adam_l_: to start, can we change the date/time picker to just a date picker? |
| 16:08:37 | <tobin_g> adam_l_: the time doesn't really mean anything in this case, just a bit confusing. |
| 16:08:45 | <djazayeri> andrea_: gotta run for a bit also |
| 16:09:20 | <tobin_g> adam_l_: also, you implemented the 'pick a date' a bit different from how I had imagined it but I like it and think maybe we could improve it one step more to make it fill another need, let me explain. |
| 16:09:20 | <andrea_> rafa, djazayeri see u later |
| 16:10:01 | <adam_l_> tobin_g: I thought about that too. I will check if there is a way to do that. |
| 16:10:03 | <tobin_g> adam_l_: originally i had imagined that when the page opened the date picker would be set to the current date and show only that day. but, the way you did it it shows ALL dates because it's blank. i think this will get overwhelming very quickly |
| 16:10:53 | <tobin_g> adam_l_: my proposal is that we have the date picker have a start date and an end date - by default it will show a week's worth of appointments (or maybe a day we can decide) |
| 16:11:01 | <adam_l_> tobin_g: I see. ok I will set it to be the current date. |
| 16:11:22 | <tobin_g> adam_l_: the advantage here is that it gives the clinic administrator a way to easily print / have a schedule for the clinic for any period of time. |
| 16:11:35 | <tobin_g> adam_l_: this would have been a shortfall of my approach where you can only see one day at a time. |
| 16:11:51 | <tobin_g> adam_l_: in other words, i think with not too much work we could gain an important feature :-) |
| 16:12:17 | *** suranga has joined #openmrs |
| 16:12:17 | *** ChanServ sets mode: +v suranga |
| 16:12:37 | <adam_l_> tobin_g: oh ok that will be easy to do because the methods are accepting fromDate and toDate just now the toDate is fromDate+1Day you see? |
| 16:12:55 | <tobin_g> adam_l_: very cleverly done dr. lauz |
| 16:13:02 | <tobin_g> :-) |
| 16:13:23 | <adam_l_> tobin_g: lol :) we got lucky :) |
| 16:13:39 | <tobin_g> adam_l_: there's a saying in english - better lucky than good |
| 16:14:02 | <adam_l_> tobin_g: :) |
| 16:14:25 | <tobin_g> adam_l_: do you want me to keep notes of these things or write them as comments on the ticket? |
| 16:15:29 | <adam_l_> tobin_g: I will change that immediately. yes it will be great... |
| 16:15:41 | <tobin_g> adam_l_: ok will put them on the ticket |
| 16:16:04 | <adam_l_> tobin_g: If that is to much trouble you can email them like a To-Do list |
| 16:16:17 | <tobin_g> adam_l_: no it's easy and that way everyone can see |
| 16:16:31 | <adam_l_> tobin_g: true |
| 16:17:25 | <tobin_g> adam_l_: how many days should we show by default? 1? 5? 7? |
| 16:19:46 | <adam_l_> tobin_g: you mean the interval? |
| 16:20:02 | <tobin_g> adam_l_: yeah - just trying to think what would be most convenient for the user. |
| 16:21:17 | <adam_l_> tobin_g: you made me think of another question. how should we sort the appointment blocks list? |
| 16:22:13 | <suranga> hi rafa :) |
| 16:22:18 | <suranga> rafa, are you here ? :) |
| 16:22:46 | <tobin_g> adam_l_: good question, i'll get there in a sec b/c i'll first make a few suggestions about the table itself |
| 16:24:11 | <adam_l_> tobin_g: I think I have something ready (JavaScript library) that openMRS uses. it called data tables. It has all the options that we need. you can check it out from the example in here http://datatables.net/ |
| 16:25:01 | <tobin_g> adam_l_: oooohâ¦. i like it! |
| 16:25:18 | <tobin_g> adam_l_: REALLY like it! |
| 16:25:41 | <adam_l_> tobin_g: Daniel said that I can use it. but I didn't ready know how. but it simplifies and does all the work right? |
| 16:25:52 | <adam_l_> tobin_g: really* |
| 16:25:52 | <tobin_g> adam_l_: i would think so |
| 16:26:11 | <tobin_g> adam_l_: do you think that you could also somehow combine the date picker / location selection into this as well? |
| 16:26:55 | <tobin_g> adam_l_: here is what I am putting for a comment on the ticket regarding date picker. tell me if you have questions: |
| 16:26:58 | <adam_l_> tobin_g: yes I think so. |
| 16:27:06 | <tobin_g> adam_l_: that's going to be very nice |
| 16:27:14 | <tobin_g> Change the single "pick a date" widgets into two. One for start and one for end. |
| 16:27:15 | <tobin_g> Have the default start be set to current day, end be set to current day + 7 (thus a week's worth of appointment blocks will be shown by default). |
| 16:27:16 | <tobin_g> Just a note, although I'd like the widget to be only calendar (not calendar & time) the start value will probably have a time associated with it - 00:00:00. The end value will have a time associated with it - 23:59:59. Thus, if a user wants to view a particular day they will set both to the same day. |
| 16:27:52 | <adam_l_> tobin_g: I will try later that data table maybe it's easy to use. |
| 16:28:04 | <tobin_g> adam_l_: cool |
| 16:28:31 | <tobin_g> adam_l_: let's talk about a few of my comments for the data table though |
| 16:29:15 | <tobin_g> adam_l_: let's add a column for "Date" and have it correspond to the start date in the format XX/XX/XXXX. Whether it's MM/DD/YYYY vs DD/MM/YYYY should correspond to the user's locale preferences. |
| 16:29:36 | *** scnakandala has quit IRC |
| 16:29:37 | <tobin_g> adam_l_: then, change the format of Start Time & End Time columns to only include HH:MM instead of "Fri Dec 14 2012 12:00:00 GMT+0200 (IST)" |
| 16:30:51 | <tobin_g> adam_l_: as an aside, the search feature on the datatables.net is cool |
| 16:30:57 | <adam_l_> tobin_g: OK no problem |
| 16:31:52 | <adam_l_> tobin_g: yes it will be super cool if we use that right? |
| 16:32:02 | <adam_l_> tobin_g: the comments are very clear tobin |
| 16:32:10 | <tobin_g> adam_l_: for default sorting, let's go date, location, start time |
| 16:32:39 | <tobin_g> adam_l_: we'd be setting the bar high we can use it! |
| 16:34:29 | <adam_l_> tobin_g: sorting in location name? |
| 16:34:56 | <adam_l_> tobin_g: nv I get it |
| 16:38:23 | *** adz has joined #openmrs |
| 16:40:36 | <tobin_g> adam_l_: gimme a sec and i'll give a few more things, just helping yonatan with something |
| 16:41:16 | *** harshadura_ has joined #openmrs |
| 16:41:18 | <adam_l_> tobin_g: ok |
| 16:41:21 | *** harshadura_ has quit IRC |
| 16:42:52 | <adz> on googling found this community and find interesting as developer .. |
| 16:43:08 | <adz> like to be a part of the development team |
| 16:43:43 | <adz> any constrain for being developer in this community? |
| 16:46:16 | <tobin_g> hi adz anybody is welcome! |
| 16:47:00 | <tobin_g> adz: are you just an independent developer or are you associated with any organization? |
| 16:47:41 | <adz> currently im independent developer .. worked in a company now moved to freelancing .. |
| 16:48:20 | <tobin_g> adz: cool :-) Just asking because a lot of people come to the community from different clinics etc and have projects in mind that they'd like to work on |
| 16:48:30 | <tobin_g> adz: where are you from? |
| 16:49:15 | <adz> tobin_g: from India (Chennai) |
| 16:50:21 | <adz> one of my vital attraction towards this community is previously i worked in a EMR product for 5 years .. |
| 16:50:37 | <tobin_g> adz: wow (to both)! |
| 16:50:44 | <tobin_g> adz: i'm sure that you have a lot to contribute. |
| 16:51:10 | <adz> so i m sure that my ideas and contribution will be helpful |
| 16:51:18 | <tobin_g> adz: this is a really international group - people working from every corner of the earth |
| 16:51:56 | <tobin_g> adz: well we'll be happy to have you. i'm less of a developer, more on the implementation side of things. have you read a bit of the wiki? maybe consider taking an introductory ticket or two? |
| 16:52:24 | <tobin_g> adz: and if that doesn't suit your fancy I can always find some projects that we need help with! |
| 16:52:37 | <adz> tobin_g: sure ... i want first enter the team and understand how it operates, since this is firsttime im in opensource community :( |
| 16:53:12 | <suranga> hi djazayeri , sorry, but is the mvn release:prepare command run on a seperate branch, or the master itself ? |
| 16:54:03 | <adz> tobin_g: can u help me in showing the path towards it .. |
| 16:54:16 | <tobin_g> adz: i'll do my best! |
| 16:55:03 | <tobin_g> adz: how much time do you have for developing? Maybe you want to join onto a sprint? |
| 16:55:20 | <adz> tobin_g: where my first step has to be ? wiki ? |
| 16:55:36 | <tobin_g> adz: i think so. wiki.openmrs.org |
| 16:55:43 | <tobin_g> adz: let's ask - watch |
| 16:56:17 | <adz> can spend 20 -25 hrs per week initially .. |
| 16:56:31 | <tobin_g> adz: wow that's amazing! |
| 16:57:05 | <tobin_g> djazayeri: adz is new to the community and has about 20-25 hours/wk he could spend working with OpenMRS, where do you suggest he starts? |
| 16:59:20 | <tobin_g> jkeiper, adz is new to the community and has about 20-25 hours/wk he could spend working with OpenMRS, where do you suggest he starts? can he help on the registration sprint? |
| 16:59:36 | <jkeiper> adz, welcome! |
| 16:59:44 | <jkeiper> tobin_g, thanks |
| 16:59:46 | <tobin_g> jkeiper: thought that would get your attention :) |
| 16:59:51 | <jkeiper> haa |
| 16:59:51 | <adz> tobin_g: let me roam around wiki for time being |
| 16:59:58 | <jkeiper> adz, check out the wiki |
| 17:00:14 | <jkeiper> adz, we are on a brief sprint but it may not give you the full "developer experience" right now ;-) |
| 17:00:28 | <jkeiper> adz, this sprint is actually partly design too |
| 17:00:43 | <jkeiper> adz, but there are quite a few entry points to openmrs |
| 17:00:43 | <tobin_g> jkeiper: adz that could be a great experience as well/. |
| 17:00:47 | <jkeiper> adz, happy to have you here :-D |
| 17:02:00 | <adz> thanks jkeiper |
| 17:02:20 | <tobin_g> adz: the best thing about working on a sprit is that you can get a lot of help from more experienced developers. i'm sure you know the technology, but OpenMRS has a bit of a learning curve to it |
| 17:02:28 | <adz> ok as u both suggested, browsing around wiki .. |
| 17:03:22 | <adz> im 5years experiance totally, worked in struts, spring, appengine, extjs, android.... |
| 17:03:42 | <tobin_g> adz: lots to keep you busy here :-) |
| 17:04:23 | <adz> <3 , thats wat i want.. i just want to contribute as much as possible .. |
| 17:04:42 | <jkeiper> excellent! |
| 17:04:49 | <jkeiper> android++ |
| 17:04:56 | <adz> ok tobin_g,jkeiper wiki is calling .. |
| 17:05:01 | <adz> :) |
| 17:05:15 | <tobin_g> adz: sounds good enjoy. |
| 17:05:26 | <tobin_g> adz: also strongly suggest you join the mailing lists - dev@ and maybe also implementers |
| 17:05:38 | <jkeiper> yes definitely |
| 17:05:42 | <tobin_g> adz: let me get you a link |
| 17:06:10 | <adz> thanks both for increasing my interest and directing me to the correct path .. |
| 17:06:42 | <tobin_g> adz: setup an openmrs user id at id.openmrs.org then from there you can get on the mailing lists |
| 17:06:48 | <adz> ok sure.. without entering mailing list how a developer can be .. |
| 17:06:52 | <tobin_g> adz: direct link https://id.openmrs.org/login?destination=%2Fmailinglists |
| 17:07:53 | <tobin_g> jkeiper: random user question. |
| 17:08:03 | <jkeiper> tobin_g, ? |
| 17:08:09 | <tobin_g> jkeiper: writing... |
| 17:08:26 | <tobin_g> jkeiper: in our appointment module, we have a page that shows "resources" that can be scheduled. WE have a dropdown to filter them by location. |
| 17:08:45 | <tobin_g> jkeiper: as a user would you expect that all sub-locations of the location you've selected are displayed below it? |
| 17:09:21 | <tobin_g> jkeiper: for example if you selected "refugee clinic" and would you expect to see rooms 1,2,3 at the clinic as well? Or do we need to have a checkbox for "show sub-locations" |
| 17:09:27 | <jkeiper> tobin_g, sure ... you mean as a sub-dropdown or as a tabbed list? |
| 17:09:39 | <jkeiper> tobin_g, ah i see |
| 17:10:05 | <jkeiper> tobin_g, most likely a user would expect to see more rather than less |
| 17:10:19 | <tobin_g> Right. I think we'll make the default to show all sub-locations |
| 17:10:30 | <tobin_g> jkeiper: can always change it |
| 17:10:37 | <tobin_g> jkeiper: thanks :-) |
| 17:11:10 | <jkeiper> tobin_g, no problem! |
| 17:11:36 | <jkeiper> tobin_g, good thinking though ... need more of us to think those things through :-) |
| 17:12:01 | <tobin_g> tobin_g: yeah⦠|
| 17:12:28 | <tobin_g> jkeiper: how should i put this nicelyâ¦.i think we need more implementers involved in each sprint :-) sort of serve a product manager role |
| 17:13:14 | <jkeiper> tobin_g, i totally agree ... and i think we're going in that direction |
| 17:13:26 | <tobin_g> jkeiper: it's excellent. |
| 17:13:29 | <jkeiper> tobin_g, it's hard to take off the implementer hat and think in a way that will benefit more than one place |
| 17:13:45 | <jkeiper> tobin_g, so hopefully we will meet somewhere in the middle :-D |
| 17:13:49 | <tobin_g> jkeiper: yeah i know. |
| 17:14:13 | *** adz has quit IRC |
| 17:14:14 | <tobin_g> jkeiper: i think it's worked well having daniel as lead developer on our sprint and me as the sort of product manager. |
| 17:14:43 | <tobin_g> jkeiper: i think we also really need to recruit some people with a good eyes for design - get OpenMRS lookin' snazzy. it's really a challenge! |
| 17:14:49 | *** Adz has joined #openmrs |
| 17:14:53 | <jkeiper> tobin_g, certainly ... we need a UX guy! |
| 17:14:55 | <tobin_g> jkeiper: the most annoying this is that my eyes are good enough to know what looks bad, just not good enough to fix it |
| 17:15:07 | <jkeiper> tobin_g, haha i understand |
| 17:15:20 | <jkeiper> tobin_g, maybe google is done with the Apple guy and can let us have him now |
| 17:15:33 | <tobin_g> jkeiper: haha |
| 17:15:39 | <tobin_g> jkeiper: an old boss of mine had a great term - engineering disease. ever heard of it? |
| 17:15:48 | <jkeiper> tobin_g, nope? |
| 17:16:25 | <tobin_g> jkeiper: developers/engineers over design interfaces to have every option imaginable |
| 17:16:34 | <tobin_g> jkeiper: think iphone versus microsoft phone |
| 17:16:56 | <tobin_g> jkeiper: being comfortable to make decisions for people and go with the 80% |
| 17:17:01 | <tobin_g> jkeiper: at least in UK |
| 17:17:04 | <tobin_g> jkeiper: UX |
| 17:17:39 | <jkeiper> tobin_g, yes! that's a real thing |
| 17:17:45 | <tobin_g> jkeiper: in my case, the guy with engineering disease would have put the checkbox. |
| 17:18:00 | <jkeiper> ah true |
| 17:18:51 | <tobin_g> jkeiper: been fun, back to real work :-) |
| 17:19:16 | <jkeiper> tobin_g, i don't necessarily want a graphic designer with no structure but rather a veteran with fresh ideas and no allegiance to the data model ;-) |
| 17:19:29 | <jkeiper> tobin_g, right on ... crack that whip! |
| 17:19:43 | <tobin_g> jkeiper: there must be an irc command for that...hm |
| 17:20:23 | <suranga> jkeiper, howdy, sorry if I missed the kick off meeting :) |
| 17:20:38 | <tobin_g> suranga: you should be sorry! |
| 17:20:46 | <tobin_g> suranga: :D |
| 17:20:46 | <suranga> tobin_g, :( |
| 17:20:58 | <tobin_g> suranga: i kid i kid! |
| 17:20:59 | <suranga> tobin_g, today is university day, you see :( |
| 17:21:03 | <tobin_g> suranga: i just couldn't resist... |
| 17:21:35 | <tobin_g> suranga: i forgive you. of course jkeiper is the one you have to answer to :) |
| 17:21:43 | <suranga> :P |
| 17:22:44 | <tobin_g> adam_l_: are you still working on the multiple appointment types for the add appointment block form? |
| 17:25:02 | *** adam_l_ has quit IRC |
| 17:29:33 | <tobin_g> suranga: i'm looking for a good example of a popup used in openmrs. like instead of directing the user to a completely new page to add something, just a floating popup. any ideas? |
| 17:30:19 | <suranga> tobin_g, hmm.. like the one on the edit global properties page, maybe ? |
| 17:30:24 | <suranga> have you seen that one ? |
| 17:31:01 | <tobin_g> suranga: yeah something like that, any others? i know i've seen more complex ones in modules.... |
| 17:34:05 | <suranga> hmm... //thinks |
| 17:34:27 | <tobin_g> suranga: don't worry that one was a good idea. not so curcial |
| 18:00:23 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Facility Data 2.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=facilitydata&version=&2.2> |
| 18:14:00 | *** rafa has quit IRC |
| 18:16:30 | *** suranga has quit IRC |
| 18:29:06 | *** rafa has joined #openmrs |
| 18:29:06 | *** ChanServ sets mode: +v rafa |
| 18:31:15 | <Adz> whn glancing thru demo application http://demo.openmrs.org/openmrs/admin/visits/visit.form found the "Visit type" mandatory field drop down is empty .. any reason behind it ? |
| 18:32:12 | <jkeiper> Adz, perhaps nobody provided visit types ... look in the administration section |
| 18:32:17 | <jkeiper> there should be a way to manage visit types |
| 18:32:24 | <jkeiper> although i have not worked with visits much |
| 18:33:49 | <Adz> jkeiper, ok let me find it .. |
| 18:42:21 | <andrea_> djazayeri, u ther? Found the controllers |
| 18:48:48 | *** harshadura has quit IRC |
| 18:51:29 | *** rafa has quit IRC |
| 19:03:32 | *** ningosi has joined #openmrs |
| 19:04:54 | *** ningosi is now known as Ojwanganto |
| 19:44:14 | *** Adz has quit IRC |
| 19:57:43 | *** Ojwanganto has quit IRC |
| 20:57:51 | *** wyclif_ has quit IRC |
| 21:00:08 | *** wyclif_ has joined #openmrs |
| 21:32:30 | *** jkeiper has quit IRC |
| 21:39:16 | *** rafa has joined #openmrs |
| 21:39:16 | *** ChanServ sets mode: +v rafa |
| 21:51:19 | *** tobin_g has quit IRC |
| 22:16:26 | *** jkeiper has joined #openmrs |
| 22:16:26 | *** ChanServ sets mode: +v jkeiper |
| 22:18:53 | *** wyclif_ has quit IRC |
| 22:25:54 | *** jkeiper has quit IRC |
| 22:48:16 | *** rafa has quit IRC |
| 22:58:46 | *** harshadura has joined #openmrs |
| 23:19:56 | *** harshadura has quit IRC |
| 23:32:55 | *** upul has joined #openmrs |
| 23:32:55 | *** ChanServ sets mode: +v upul |
