| 00:03:15 | <andreapat> djazayeri, yes they are all re mergePatients - wonder if I'm missing a java program that needs changing |
| 00:03:29 | <djazayeri> andreapat: what does the error message say? |
| 00:03:48 | *** wyclif_ has joined #openmrs |
| 00:04:44 | <andreapat> djazayeri, here's first one: |
| 00:04:50 | <andreapat> Tests in error: |
| 00:04:50 | <andreapat> mergePatients_shouldChangeUserRecordsOfNonPreferredPersonToPreferredPerson(org.openmrs.api.PatientServiceTest) |
| 00:05:26 | <djazayeri> andreapat: typically there's a stack trace or something there, if you scroll down within the failure |
| 00:05:41 | <djazayeri> basically, it failed for a reason, and Eclipse will show you the failure reason |
| 00:09:22 | <andreapat> djazayeri ran PatientServiceTest as Junit test in Eclipse - says Errors: 0 |
| 00:10:35 | <andreapat> djazayeri, have taken change out of Person.hbm.xml - will put iit back and run unit test again |
| 00:18:34 | <andreapat> djazayeri, all to do with new field deathdateEstimated |
| 00:21:03 | *** lh has quit IRC |
| 00:22:06 | <andreapat> djazayeri, in PatientServiceImpl |
| 00:54:39 | *** andreapat has quit IRC |
| 01:23:19 | *** wyclif_ has quit IRC |
| 02:25:39 | *** wyclif_ has joined #openmrs |
| 02:34:09 | *** wyclif_ has quit IRC |
| 03:06:19 | *** Mkop1 has joined #openmrs |
| 03:06:19 | *** ChanServ sets mode: +v Mkop1 |
| 03:42:24 | *** wyclif_ has joined #openmrs |
| 03:58:44 | *** wyclif_ has quit IRC |
| 04:09:40 | *** wyclif_ has joined #openmrs |
| 04:13:38 | *** djazayeri has quit IRC |
| 04:15:24 | *** wyclif_ has quit IRC |
| 04:18:20 | *** wyclif_ has joined #openmrs |
| 04:21:00 | *** kavuri has joined #openmrs |
| 04:22:25 | *** kavuri has quit IRC |
| 04:28:14 | *** wyclif_ has quit IRC |
| 04:28:18 | *** jkeiper has quit IRC |
| 04:36:21 | *** wyclif_ has joined #openmrs |
| 04:48:09 | *** kavuri has joined #openmrs |
| 05:03:03 | *** wyclif_ has quit IRC |
| 05:18:12 | *** Mkop1 has quit IRC |
| 05:30:45 | *** Mkop1 has joined #openmrs |
| 05:31:50 | *** Mkop has quit IRC |
| 05:32:25 | *** Mkop has joined #openmrs |
| 05:32:25 | *** ChanServ sets mode: +v Mkop |
| 05:32:35 | *** kishoreyekkanti has joined #openmrs |
| 05:58:03 | *** robbyoconnor has joined #openmrs |
| 05:58:03 | *** ChanServ sets mode: +v robbyoconnor |
| 06:39:30 | *** djazayeri has joined #openmrs |
| 06:39:30 | *** ChanServ sets mode: +o djazayeri |
| 07:01:37 | *** adam_l has joined #openmrs |
| 07:02:18 | <adam_l> tobin_g: are you up? |
| 07:09:35 | *** kishoreyekkanti_ has joined #openmrs |
| 07:09:36 | *** kishoreyekkanti has quit IRC |
| 07:09:38 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 07:20:22 | <kavuri> djazayeri: hi, about the encounter date time...any inputs on what could be done for the timezone issues? |
| 07:23:55 | <djazayeri> kavuri: we need to verify whether it's just a client-being-a-few-seconds-ahead, or if it's a timezone issue |
| 07:25:47 | <kavuri> djazayeri: no, it is not about few secs. The server is located in a different timezone and the client is in India |
| 07:26:27 | <djazayeri> kavuri: did you see rafal's comment that it may just be the client being a bit ahead? |
| 07:27:42 | <kavuri> djazayeri: yes. But in the code, this is the check being made "if (encounterDateTime != null && encounterDateTime.after(new Date()))" |
| 07:27:50 | <kavuri> djazayeri: in EncounterValidator.java |
| 07:28:28 | <djazayeri> kavuri: so, my point in the email was: please write a (failing) unit test that shows what the root cause is. |
| 07:28:58 | <kavuri> djazayeri: any pointers on how I can simulate the server side time setting? |
| 07:29:24 | <kavuri> djazayeri: for a unit test case |
| 07:30:40 | *** applecool has joined #openmrs |
| 07:30:40 | *** ChanServ sets mode: +v applecool |
| 07:31:26 | <djazayeri> kavuri: I don't think you have to do thatâas long as you know the timezone you're running the unit test in, and submit a value one hour ahead in a different timezone, that should work, right? |
| 07:34:23 | *** applecool has quit IRC |
| 07:34:38 | <kavuri> djazayeri: I have a curl client with an encounter json message and that fails |
| 07:34:41 | <kavuri> djazayeri: is that good enough? |
| 07:36:33 | <djazayeri> kavuri: the right approach is really to create a unit test |
| 07:37:47 | <djazayeri> kavuri: this allows others to see what's going on, try with the debugger, and prove that the fix works. |
| 07:37:52 | <kavuri> djazayeri: there seems to be already a unit testcase " public void validate_shouldFailIfEncounterDateTimeIsAfterCurrentDateTime(" |
| 07:37:57 | <kavuri> in EncounterValidatorTest.java |
| 07:39:32 | <djazayeri> kavuri: we need a test in the RESTWS module that tests the timezone issue specifically |
| 07:44:04 | <djazayeri> kavuri: we know that trying to create an encounter in the future doesn't work |
| 07:44:12 | <djazayeri> kavuri: it's intentionally not allowed |
| 07:46:58 | <kavuri> djazayeri: creating the unit testcase.. |
| 07:49:13 | *** applecool has joined #openmrs |
| 07:49:13 | *** ChanServ sets mode: +v applecool |
| 08:01:22 | <kavuri> djazayeri: as expected, if I set the encounter date time to the next day than that of current, the unit testcase fails |
| 08:02:21 | <kavuri> djazayeri: I agree that creating an encounter in a future date should not be allowed. But this is more about synchronization of local time with that of the server |
| 08:02:42 | <djazayeri> kavuri: specifically what happens if you set the time to be now() - 5 minutes + 1 hour, but in the timezone one hour ahead? |
| 08:02:55 | <djazayeri> kavuri: can you pastebin the unit test? |
| 08:03:00 | <kavuri> djazayeri: ok.. |
| 08:03:56 | <kavuri> djazayeri: http://pastebin.com/vfDnksh5 |
| 08:05:18 | <djazayeri> kavuri: this test isn't doing anything with timezones. |
| 08:05:56 | <kavuri> djazayeri: where should I set the timezone of the server? |
| 08:06:05 | <djazayeri> kavuri: the test needs to submit a time which is not _actually_ further ahead, but _seems_ to be because of timezones |
| 08:06:39 | <djazayeri> kavuri: you don't need to _set_ the timezone of the server, you just need to _get_ it. I assume something like "new Date().getTimezone()" |
| 08:07:06 | <djazayeri> kavuri: then construct a date to submit that's an hour ahead, but in the timezone an hour ahead |
| 08:07:27 | <djazayeri> kavuri: i.e. you can simulate the _client_ being a timezone ahead, without needing to mess with the server. |
| 08:11:25 | <kavuri> djazayeri: I am now trying to do something like this: |
| 08:11:26 | <kavuri> SimpleDateFormat isoFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ"); |
| 08:12:28 | <kavuri> isoFormat.setTimezone(Timezone.getTimeZone("IST")); |
| 08:12:28 | <kavuri> Date date = isoFormat.parse(new Date()); |
| 08:12:28 | <kavuri> djazayeri: and use this in encounter creation |
| 08:13:31 | *** dkayiwa has joined #openmrs |
| 08:13:45 | <djazayeri> kavuri: that's the right ideaâit might be easier to use Calendar.getInstance(TimeZone) |
| 08:13:51 | <djazayeri> I haven't done this before. |
| 08:14:02 | *** djazayeri has left #openmrs |
| 08:14:21 | *** djazayeri has joined #openmrs |
| 08:14:21 | *** ChanServ sets mode: +o djazayeri |
| 08:15:44 | <djazayeri> sorry, accidentally closed this window. back now |
| 08:20:15 | <kavuri> djazayeri: I made these changes: TimeZone tz = TimeZone.getTimeZone("Asia/Kolkata"); |
| 08:20:16 | <kavuri> Calendar calendar = Calendar.getInstance(tz); |
| 08:20:16 | <kavuri> Date date = calendar.getTime(); |
| 08:20:24 | <kavuri> djazayeri: and the unit test case fails |
| 08:20:29 | <kavuri> djazayeri: let me pastebin it |
| 08:21:06 | <kavuri> djazayeri: http://pastebin.com/csSSBELV |
| 08:22:23 | *** kishoreyekkanti has quit IRC |
| 08:22:42 | <djazayeri> kavuri: okay, that seems pretty conclusive. Can you also do a System.out.println of both date and new Date() just so I can see the formats? |
| 08:23:35 | <djazayeri> kavuri: but it seems like we're going to need to make a change to the RESTWS module so that when the client sends a time, we convert it to the server's timezone |
| 08:24:01 | *** kishoreyekkanti has joined #openmrs |
| 08:24:02 | <djazayeri> kavuri: wherever we do String->Date conversion |
| 08:24:57 | <kavuri> djazayeri: yes |
| 08:25:10 | <kavuri> djazayeri: let me do a print out |
| 08:25:23 | <djazayeri> kavuri: it's odd, it seems like when we parse dates it's being done with the timezone taken into account |
| 08:25:44 | <djazayeri> kavuri: I wouldn't have expected us to have to explicitly do anything. |
| 08:28:38 | <djazayeri> kavuri: can you go ahead and create a ticket for this, and attach your unit test as a patch (or better, as a pull request?) |
| 08:29:06 | <kavuri> djazayeri: this is output of new Date() and date with timezon |
| 08:29:08 | <kavuri> +++++++++++++++++++ new Date()Thu Dec 13 13:58:20 IST 2012 |
| 08:29:08 | <kavuri> +++++++++++++++++++ date with timezoneThu Dec 13 13:58:20 IST 2012 |
| 08:29:13 | <kavuri> djazayeri: they are one and the same |
| 08:29:29 | <djazayeri> kavuri: that's odd, then why does it fail? |
| 08:29:30 | <kavuri> djazayeri: where do you think this problem should be fixed? I can goahead and fix it |
| 08:29:59 | <djazayeri> kavuri: we may have to do something in ConversionUtil (look for the line about supportedFormats) |
| 08:30:25 | <djazayeri> kavuri: I'm off to bed |
| 08:30:36 | <kavuri> djazayeri: ok, will dig it out |
| 08:32:30 | <kavuri> djazayeri: I am off to grab some lunch |
| 08:49:53 | *** Echidna has quit IRC |
| 09:14:00 | <tobin_g> dkayiwa: are you able to get on the CI server? down for me |
| 09:14:19 | <dkayiwa> tobin_g: trying now.... |
| 09:15:23 | <dkayiwa> tobin_g: can you remind me with the url? :) |
| 09:15:33 | <tobin_g> http://gw65.iu.xsede.org:8080/openmrs/index.htm |
| 09:16:39 | <dkayiwa> tobin_g: am not able to connect too |
| 09:16:48 | <tobin_g> k i'll submit an itsm ticket |
| 09:16:59 | <tobin_g> dkayiwa: how are the latest commits looking? |
| 09:17:07 | <dkayiwa> tobin_g: reviewing them now |
| 09:17:12 | <tobin_g> dkayiwa: :-) |
| 09:19:37 | <tobin_g> adam_l: lots of commits! nice work! |
| 09:26:21 | <adam_l> tobin_g: thanks need review though :) |
| 09:26:50 | <dkayiwa> adam_l: i already have comments for you :) |
| 09:27:58 | <adam_l> dkayiwa: thanks :) |
| 09:28:31 | <dkayiwa> adam_l: generally nice work. so the comments are mostly about adding javadoc :) |
| 09:29:42 | <adam_l> dkayiwa: that's nice to hear :) I will add the javadoc. |
| 09:29:53 | <dkayiwa> adam_l: excellent!!! :) |
| 09:30:59 | <adam_l> tobin_g: Started working on AM-6. add/edit form. |
| 09:33:12 | *** djazayeri has quit IRC |
| 09:33:36 | <tobin_g> adam_l: that's awesome!! |
| 09:33:59 | <tobin_g> adam_l: (both the good work and starting on AM-6) |
| 09:34:10 | <tobin_g> adam_l: will you and me and yonatan go to rolladin today? |
| 09:36:06 | <adam_l> tobin_g: great with me before 5pm. we will ask Yonatan when he will be available. |
| 09:36:25 | <tobin_g> adam_l: ok let me know :-) |
| 09:36:55 | <adam_l> tobin_g: you know it |
| 09:40:41 | <dkayiwa> hi adam_l |
| 09:40:58 | <adam_l> dkayiwa: hi |
| 09:41:14 | <dkayiwa> adam_l: when did you last try to actually run the module? |
| 09:41:32 | <adam_l> dkayiwa: now :) |
| 09:41:42 | <adam_l> dkayiwa: why? |
| 09:41:42 | <dkayiwa> adam_l: how did you run it? |
| 09:41:48 | <adam_l> dkayiwa: clean install |
| 09:41:55 | <dkayiwa> adam_l: and then after? |
| 09:42:20 | <adam_l> dkayiwa: updating the existing module in the standalone |
| 09:42:33 | <dkayiwa> adam_l: can you do it again now |
| 09:42:44 | <adam_l> dkayiwa: sure wait for a sec |
| 09:43:01 | <dkayiwa> adam_l: and then actually try to deploy the module in the webapp. then tell me module gets loaded well |
| 09:43:42 | <adam_l> dkayiwa: I am deleting the module and deploying right now |
| 09:43:53 | <dkayiwa> adam_l: ok |
| 09:45:44 | <adam_l> dkayiwa: I did it. what now? |
| 09:46:00 | <adam_l> dkayiwa: "Module loaded and started successfully" |
| 09:46:18 | <dkayiwa> adam_l: can you click the create appointment link |
| 09:46:44 | <adam_l> dkayiwa: and? |
| 09:46:55 | <dkayiwa> adam_l: does it load |
| 09:47:01 | <adam_l> dkayiwa: yes |
| 09:47:31 | <adam_l> dkayiwa: I don't see any problems. wait maybe it loads from the cache? |
| 09:47:33 | <dkayiwa> adam_l: looks like my problem is local. let me sort myself out. Thanks alot!!! :) |
| 09:48:11 | <adam_l> dkayiwa: ok :) you'r welcome |
| 09:52:11 | <dkayiwa> hi adam_l |
| 09:52:30 | <adam_l> dkayiwa: yes Daniel |
| 09:52:45 | <dkayiwa> adam_l: can you click the Appointment Blocks link and tell me if it loads? |
| 09:52:55 | <adam_l> dkayiwa: ok |
| 09:53:21 | <adam_l> dkayiwa: yes it loads |
| 09:53:33 | <dkayiwa> adam_l: do you have all your changes pushed? |
| 09:53:47 | <adam_l> dkayiwa: I did git add --all |
| 09:53:59 | <dkayiwa> adam_l: and did you push? |
| 09:54:20 | <adam_l> dkayiwa: yes ofcourse. I can push again if you want to |
| 09:54:39 | <dkayiwa> adam_l: can you pastebin for the the contents of your appointmentBlockList.jsp? |
| 09:55:05 | <adam_l> dkayiwa: I changed it a bit but ok |
| 09:55:15 | <dkayiwa> adam_l: changed what? |
| 09:55:37 | <adam_l> dkayiwa: I stated working on AM-6 so I added a few things |
| 09:56:15 | <dkayiwa> adam_l: no problem. i just want to make sure that all changes you currently have are the same as mine |
| 09:57:14 | <adam_l> dkayiwa: http://pastebin.com/ViTtNfc4 |
| 09:57:47 | <dkayiwa> adam_l: which version of openmrs are you using? |
| 09:58:02 | <adam_l> dkayiwa: 1.9.1 |
| 09:58:24 | <dkayiwa> adam_l: can you email me your omod? |
| 09:58:27 | <adam_l> dkayiwa: openmrs-standalone-1.9.1 |
| 09:58:38 | <adam_l> dkayiwa: yes |
| 09:58:44 | <dkayiwa> adam_l: thanks |
| 10:00:28 | *** yony258 has joined #openmrs |
| 10:05:05 | <yony258> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/17cea1b6622c33d342a8f1627f237912ee6991fe |
| 10:05:10 | <OpenMRSBot> <http://ln-s.net/+HDc> (at github.com) |
| 10:05:24 | <yony258> dkayiwa: Ready for another review whenever you have time |
| 10:05:36 | *** rafa has joined #openmrs |
| 10:05:36 | *** ChanServ sets mode: +v rafa |
| 10:06:08 | <tobin_g> yony258: :) |
| 10:06:23 | <yony258> tobin_g: Hi |
| 10:06:38 | <tobin_g> yony258: loving all the commits :D |
| 10:06:48 | <yony258> tobin_g: Had your exam today? |
| 10:07:29 | <tobin_g> yony258: yup :| |
| 10:07:42 | <yony258> tobin_g: How was it? |
| 10:07:51 | <tobin_g> finished (until possibly the moed bet) |
| 10:08:01 | <dkayiwa> yony258: and the javadocs? |
| 10:08:12 | <yony258> dkayiwa: I did the javadocs in the previous commit |
| 10:08:13 | <tobin_g> yony258: not my best performance but OK |
| 10:09:07 | <yony258> dkayiwa: for example: https://github.com/openmrs/openmrs-module-appointment/blob/ab2d48906b397734be69c4f297d5b1bf3a8565b9/api/src/main/java/org/openmrs/module/appointment/api/db/TimeSlotDAO.java |
| 10:09:12 | <OpenMRSBot> <http://ln-s.net/+HDh> (at github.com) |
| 10:09:20 | <yony258> tobin_g: Well at least that one is finished :) |
| 10:10:02 | <tobin_g> yony258: true! |
| 10:10:12 | <tobin_g> yony258: the one in 2 weeks will be the real killer |
| 10:12:01 | <dkayiwa> yony258: reviewed. only one comment :) |
| 10:12:13 | <yony258> tobin_g: http://i.qkme.me/36gwhp.jpg |
| 10:12:15 | <yony258> dkayiwa: Thanks |
| 10:12:45 | <yony258> dkayiwa: How do I let the user know what was the issue? |
| 10:12:52 | <dkayiwa> yony258: yes |
| 10:12:58 | <dkayiwa> yony258: thats the comment |
| 10:13:00 | <tobin_g> haha |
| 10:13:12 | <tobin_g> yony258: i hope i don't look like that |
| 10:13:12 | <yony258> dkayiwa: I mean, I need to add a error to errors |
| 10:13:29 | <yony258> tobin_g: Everybody does, at least for the 5 minutes after the exam |
| 10:13:51 | <dkayiwa> yony258: feel free to do whatever you want. As long as you notify the user |
| 10:14:11 | <dkayiwa> yony258: adam_l you guys seem to be putting in more time than you had promised to after the sprint :) |
| 10:14:24 | <yony258> dkayiwa: I need to know what do I need to send to the function in order to add an error |
| 10:14:38 | <yony258> dkayiwa: Yes trying to finish as many as possible |
| 10:15:26 | <dkayiwa> yony258: one the ways is to add a javascript popup which tell user of error message and does not allow submit when the above is not corrected |
| 10:15:26 | <tobin_g> dkayiwa: shhhhhhhhh i don't think they've realized it! |
| 10:15:35 | <tobin_g> dkayiwa: :D |
| 10:15:56 | <dkayiwa> tobin_g: sure!!! ;) |
| 10:17:05 | <yony258> dkayiwa: BTW I gave up on the underscore template, |
| 10:17:30 | <dkayiwa> yony258: i have never heard of that thing :) |
| 10:17:46 | <yony258> dkayiwa: and jQuery templates? |
| 10:18:01 | <dkayiwa> yony258: you are teaching me about it :) |
| 10:18:13 | <yony258> dkayiwa: Its really good thing to have, better maintainability and easy to understand, but I just couldn't get it to work |
| 10:18:23 | <dkayiwa> yony258: oh i see!!! |
| 10:19:37 | *** adam_l has quit IRC |
| 10:21:11 | <yony258> dkayiwa: So how do I let the user know what the problem is |
| 10:21:44 | *** Echidna has joined #openmrs |
| 10:21:44 | *** ChanServ sets mode: +v Echidna |
| 10:21:48 | <dkayiwa> yony258: one of the ways is simply not submitting with missing or invalid selection |
| 10:22:02 | <dkayiwa> yony258: using javascript check and alert popup |
| 10:22:19 | <dkayiwa> yony258: does that answer you? |
| 10:23:31 | <yony258> dkayiwa: Not exactly, I dont know what will activate that function |
| 10:24:06 | <dkayiwa> yony258: for instance, attaching a javascript function to the submit button click event |
| 10:24:33 | <yony258> dkayiwa: ok |
| 10:25:00 | <dkayiwa> yony258: where that function return true only when validation passes. when it returns true the form will submit |
| 10:27:23 | <dkayiwa> yony258: on a side note, can you compile and install your module, the tell me if the Appointment Blocks link works? |
| 10:28:20 | <yony258> dkayiwa: alert "Error" |
| 10:36:50 | <yony258> dkayiwa: Can't work with those days in JS, its a string that cant be interpreted because of different date formats |
| 10:38:23 | <yony258> dkayiwa: For example: "26/12/2012 00:00" = Wed Feb 12 2014 .... |
| 10:40:07 | <yony258> dkayiwa: It thinks that the 12 is the day, 26 is the month |
| 10:40:57 | <dkayiwa> yony258: ok |
| 10:41:38 | <dkayiwa> yony258: can you then do the validation in controller and add to the errors object? |
| 10:42:32 | <dkayiwa> yony258: such that the page will display the appropriate errors next to each field |
| 10:42:48 | <yony258> dkayiwa: If you tell me what do I need to add to the signature in order to add to the errors objecyt |
| 10:42:51 | <yony258> obect* |
| 10:42:58 | <yony258> wow! *object |
| 10:43:14 | <dkayiwa> yony258: :D |
| 10:45:39 | <yony258> dkayiwa: Can you pastebin how do I get the selected fromDate in javascript? |
| 10:45:59 | <yony258> dkayiwa: Because new Date(... .value) isn't correct because of the different formats |
| 10:46:13 | <dkayiwa> yony258: do the validation in the controller |
| 10:46:21 | <dkayiwa> yony258: and then add error to the error object |
| 10:46:47 | <yony258> dkayiwa: ok |
| 10:47:21 | <yony258> dkayiwa: Though I think there should be a way to do that, if not, thats a big bug of String to Date conversion in js |
| 10:48:06 | <yony258> dkayiwa: BTW I just noticed AM-10 is about what the getTimeSlotsByConstraints function |
| 10:48:10 | <yony258> !ticket AM-10 |
| 10:48:11 | <OpenMRSBot> yony258: [#AM-10] Add "Find Next Appointment Time" functionality to the Create new Appointment form. - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-10 |
| 10:49:27 | *** ibewes has joined #openmrs |
| 10:50:42 | <dkayiwa> yony258: ok |
| 10:59:03 | <yony258> dkayiwa: Thats what I did http://pastebin.com/34U3Tmha |
| 10:59:09 | <yony258> dkayiwa: It doesn't show the error |
| 11:04:23 | <dkayiwa> yony258: did you run it in debug mode |
| 11:04:42 | <dkayiwa> yony258: and confirm code executes as expected |
| 11:10:22 | *** ibewes has quit IRC |
| 11:10:43 | <yony258> dkayiwa: Yes, the code executes as expected |
| 11:11:24 | <yony258> dkayiwa: But I didn't changed anything in the JSP, do I need to change something, like bind the error to something? |
| 11:11:43 | <dkayiwa> yony258: does result.reject get called |
| 11:11:53 | <yony258> dkayiwa: Yes |
| 11:12:14 | <dkayiwa> yony258: result.rejectValue(field, errorCode); |
| 11:13:39 | <yony258> dkayiwa: like result.rejectValue("toDate", "appointment.error...."); ? |
| 11:13:48 | <dkayiwa> yony258: yes |
| 11:14:48 | <yony258> dkayiwa: It won't work because "toDate" isn't a property of Appointment |
| 11:15:09 | <dkayiwa> yony258: and for appointment type? |
| 11:15:30 | <yony258> dkayiwa: AppointmentType has name, description and duration |
| 11:16:06 | <dkayiwa> yony258: the file on the appointment object |
| 11:16:09 | <dkayiwa> field |
| 11:16:30 | <yony258> dkayiwa: Appointment doesn't have an Appointment Type field |
| 11:16:45 | <dkayiwa> yony258: ohhhhh |
| 11:16:58 | <yony258> dkayiwa: I can bind it to timeSlot :) it sounds relevant to me |
| 11:17:08 | <dkayiwa> yony258: me too :) |
| 11:17:51 | <yony258> dkayiwa: works :) |
| 11:18:06 | <dkayiwa> yony258: you are too fast to believe :) |
| 11:18:07 | <yony258> dkayiwa: let me push |
| 11:18:16 | <yony258> dkayiwa: :) |
| 11:20:53 | *** suranga has joined #openmrs |
| 11:20:53 | *** ChanServ sets mode: +v suranga |
| 11:21:15 | <yony258> dkayiwa: pushed |
| 11:22:03 | <yony258> dkayiwa: By the way, I dont think we need the "Cancel" button |
| 11:22:27 | <dkayiwa> yony258: if tobin_g agrees, then yes :) |
| 11:22:44 | <yony258> tobin_g: I dont think we need the Cancel button on Create Appointment Form |
| 11:22:46 | <tobin_g> dkayiwa: yony258 what's that? |
| 11:22:52 | <tobin_g> yony258: um |
| 11:22:54 | <tobin_g> yony258: thinking |
| 11:22:56 | <dkayiwa> :D |
| 11:23:21 | <tobin_g> yony258: the alternative is just to click back, right? |
| 11:23:27 | <dkayiwa> yony258: how does one get out of that form? |
| 11:23:29 | <yony258> tobin_g: It was good if it wasn't a web based app, but here if you dont want to set a meeting you just navigate to other place |
| 11:23:41 | <yony258> *set an appointment |
| 11:23:53 | <tobin_g> yony258: agree with that. i'm trying to think about standard behavior elsewhere in openmrs; don't recall if there are cancel buttons |
| 11:24:10 | <dkayiwa> yony258: cancel means do not save changes :) |
| 11:24:27 | <tobin_g> yony258: i agree with you. no cancel needed. |
| 11:24:41 | <yony258> dkayiwa: Which is the same as to navigate to a different place (since we dont have any session attributes needed to remove, etc.) |
| 11:24:45 | <tobin_g> yony258: dkayiwa if you compare to create new concept for example you'll see no cancel |
| 11:25:37 | <yony258> !ticket AM-4 |
| 11:25:39 | <OpenMRSBot> yony258: [#AM-4] Create new Appointment - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-4 |
| 11:25:45 | <yony258> dkayiwa: tobin_g I feel like AM-4 is almost done ! |
| 11:27:25 | <yony258> dkayiwa: Found a small bug (Null pointer exception) let me repair it quickly |
| 11:27:50 | <dkayiwa> yony258: ok good |
| 11:29:19 | <yony258> tobin_g: By the way, who will be responsible for maintaining the CI server? |
| 11:29:54 | <tobin_g> yony258: michael downey, i know it's not up right now but i sent in a ticket about it |
| 11:30:41 | <tobin_g> yony258: can you mail me an omod of the latest module including all the latest commits? |
| 11:30:56 | <yony258> tobin_g: Ok, I also noticed it doesn't have some of the modules that comes with the standalone |
| 11:31:32 | <yony258> tobin_g: Sure let me just confirm that the bug was fixed |
| 11:31:34 | <tobin_g> yony258: this is correct but i don't think we need them. i'll check |
| 11:32:42 | <yony258> dkayiwa: pushed |
| 11:32:56 | <yony258> tobin_g: I'll send it to you via Skype, ok? |
| 11:33:34 | <tobin_g> ok |
| 11:36:38 | <yony258> dkayiwa: tobin_g Im going to cook me some lunch, I will be checking for messages, dkayiwa you can review whenever you have time :) |
| 11:36:58 | <tobin_g> yony258: sounds good |
| 11:37:02 | <yony258> dkayiwa: tobin_g Hopefully we can finish it until 4:30pm (5:30pm Ugandan Time) |
| 11:37:14 | <tobin_g> yony258: rolladin? |
| 11:37:46 | <tobin_g> yony258: do i need standalone or can i just upgrade the module? |
| 11:40:13 | <tobin_g> yony258: found a bug - when i search for a patient to create appointment i get a popup that says "no class by name: DWRAppointmentService - then it keeps popping up |
| 11:49:23 | <yony258> tobin_g: Try a fresh standalone |
| 11:49:43 | <yony258> tobin_g: Actually wait |
| 11:49:49 | <yony258> tobin_g: try to clear cache first |
| 11:49:52 | <dkayiwa> tobin_g: fresh standalone does not neccesarily mean redownload |
| 11:50:09 | <dkayiwa> tobin_g: it simply means deleting database folder in standalone and run again :) |
| 11:50:31 | <yony258> dkayiwa: I dont want him to delete the DB folder because it has some TimeSlots |
| 11:50:44 | <dkayiwa> yony258: oh ya :) |
| 11:50:46 | <yony258> tobin_g: Lets try clearing cache first :) |
| 11:50:58 | <yony258> tobin_g: Especially if you are using chrome |
| 11:55:37 | <yony258> dkayiwa: Can you confirm tobin_g error? |
| 11:55:40 | *** sagar has joined #openmrs |
| 11:56:37 | <tobin_g> yony258: now i have other problems (and i've switched to another browser) |
| 11:56:47 | <yony258> tobin_g: Which problems? |
| 11:56:54 | <tobin_g> yony258: when i search for the patient names start popping up, but i can't actually click one |
| 11:57:15 | <yony258> tobin_g: Try a fresh standalone :/ |
| 11:57:27 | <tobin_g> yony258: ok give me a few minutes |
| 11:57:32 | <yony258> tobin_g: sure |
| 11:57:42 | <yony258> let me send you the queries pastebin also |
| 11:59:31 | <tobin_g> yony258: same or new? i have the old ones |
| 11:59:43 | <yony258> tobin_g: Same as the old ones |
| 11:59:54 | <tobin_g> yony258: ok |
| 12:00:55 | <tobin_g> yony258: same behavior. i can select a patient by arrowing down and hitting enter but not with mouse |
| 12:01:32 | <tobin_g> yony258: and even then it's wonky, it selects but doesn't make the list of possible searches disappear so it's confusing - the only way i know it selects is because view/edit patient appears |
| 12:01:37 | <yony258> tobin_g: If you select using enter than it shows the details |
| 12:01:44 | <yony258> tobin_g: ? |
| 12:01:53 | <tobin_g> oh and no details |
| 12:02:21 | <tobin_g> yony258: hm, works in firefox but not chrome or safari |
| 12:02:32 | <yony258> tobin_g: Cleared cache? |
| 12:02:43 | <tobin_g> yony258: yeah but i'll try one more time |
| 12:03:29 | <tobin_g> yony258: oh i think i also was not clear about something - the patient id that you have showing is the id number in the database. but patients also have ID numbers for passports, ID cards, etc. |
| 12:03:45 | <yony258> tobin_g: Let's first solve the bugs |
| 12:03:48 | <tobin_g> yony258: those are what show in the upper-right of the dashboard. that's what we'd like to see. what's in the db isn't so important to the users |
| 12:03:50 | <tobin_g> yony258: ok |
| 12:04:06 | <yony258> dkayiwa: What do you think causing the bugs? |
| 12:04:49 | <dkayiwa> yony258: was not reading :) |
| 12:05:20 | <tobin_g> yony258: ok it seems OK in safari now, let me try clearing cache again in chrome |
| 12:06:00 | <tobin_g> anyone know how to just clear cache for certain sites in chrome? |
| 12:06:09 | <yony258> tobin_g: google does |
| 12:06:16 | <yony258> tobin_g: :P |
| 12:08:02 | <tobin_g> yony258: it's some cache thing, if i load it in private mode in chrome it works fine there as well |
| 12:08:02 | *** sagar has quit IRC |
| 12:08:15 | <yony258> tobin_g: ok glad to hear that |
| 12:08:26 | <yony258> tobin_g: Now please explain what you said? |
| 12:08:34 | <tobin_g> yony258: about the IDs? |
| 12:08:42 | <yony258> tobin_g: dkayiwa yea |
| 12:08:46 | *** sagar has joined #openmrs |
| 12:09:22 | <tobin_g> yony258: the ID number we need to see isn't just from the patient_id column in the database - we need to show the Identification numbers that were entered for the patient by the clinic staff. |
| 12:09:50 | <yony258> tobin_g: Do you know which property is that? |
| 12:09:53 | <tobin_g> yony258: for example in the clinic we record VISA number, Passport number, Clinic ID number, etc |
| 12:10:14 | <tobin_g> yony258: if you go into administration you'll see "manage identifier types" under patients |
| 12:10:22 | <yony258> tobin_g: Can you make a mock up for that? |
| 12:10:33 | <yony258> tobin_g: or a small text for example? |
| 12:10:41 | <tobin_g> yony258: there's not much to mock upâ¦it's just showing the values. |
| 12:10:53 | <tobin_g> New Clinic ID: XXXXXXX |
| 12:11:00 | <tobin_g> Visa Number: XXX-XXXXXXX-XXX |
| 12:11:07 | <tobin_g> Passport Number: XXX-XXXXXXX |
| 12:11:29 | <tobin_g> yony258: if we wanted to get really fancy we could have a global property which would define which identifier types would be displayed |
| 12:11:57 | <yony258> tobin_g: Why do you need all of those? |
| 12:12:13 | <tobin_g> yony258: because that's how we identify people - often time people have the same names so that's not always enough |
| 12:12:33 | <tobin_g> i suspect people will usually search for a person id in the little widget you're using |
| 12:12:41 | <tobin_g> yony258: not personid, identifier |
| 12:12:49 | <yony258> tobin_g: hmm ok, let me try that after my lunch |
| 12:12:56 | <tobin_g> yony258: ok sounds good |
| 12:13:14 | <tobin_g> yony258: if you search for horatio hornblower, for example, you'll see that it shows 101-6 before his name. that's his primary identifier |
| 12:13:28 | <tobin_g> yony258: so you can either search for 101-6 in that widget or horatio... |
| 12:13:45 | <tobin_g> yony258: at our clinic, i suspect people will search for ID numbers more often than names since they're easier to type. |
| 12:14:33 | <yony258> tobin_g: So you want to show all identifiers or just a specific one? |
| 12:15:26 | <tobin_g> yony258: all of them that the patient has. if's not difficult we could have a global property where you say I only want to display identifier types 1,2,4,8 but that's probably not that important |
| 12:17:38 | <yony258> dkayiwa: Opinion on this? |
| 12:18:27 | <dkayiwa> yony258: whats the problem in summary? |
| 12:18:45 | <yony258> dkayiwa: Instead of patient_Id, show all identifiers |
| 12:18:47 | <tobin_g> dkayiwa: right now we're showing patient_id from the database, but in reality people use Patient Identifiers |
| 12:19:09 | <dkayiwa> tobin_g: correct |
| 12:19:36 | <dkayiwa> tobin_g: yony258 is there a problem if we show patient identifiers? |
| 12:19:42 | <tobin_g> dkayiwa: yony258 so the question is whether we should just list out all identifiers, or create a global property that specifies which ones will be listed on the create appointment |
| 12:19:58 | <tobin_g> dkayiwa: for example "1,2,4,10" might mean we only show those identifiers |
| 12:20:24 | <tobin_g> dkayiwa: yony258 we can always say that for later |
| 12:20:30 | <dkayiwa> tobin_g: since this is the first version of the module, i would start by displaying them all (the easier route) :) |
| 12:20:41 | <tobin_g> dkayiwa: yony258 i'm good with that |
| 12:20:47 | <yony258> tobin_g: dkayiwa ok |
| 12:21:00 | <yony258> dkayiwa: Please just let me know after you finish review? :) |
| 12:21:04 | <tobin_g> yony258: i think we should put the preferred ID first though |
| 12:21:12 | <dkayiwa> yony258: oh never new that you had pushed :) |
| 12:21:20 | <yony258> dkayiwa: I want to make sure everything else is correct and than work on that |
| 12:21:21 | <dkayiwa> tobin_g: correct |
| 12:21:39 | <dkayiwa> yony258: reviewing now |
| 12:21:52 | <yony258> dkayiwa: ++ |
| 12:22:07 | <tobin_g> dkayiwa++ |
| 12:22:09 | <dkayiwa> yony258: i miss that karma (remove the :) :0 |
| 12:22:20 | <tobin_g> !karma dkayiwa |
| 12:22:20 | <OpenMRSBot> tobin_g: Karma for "dkayiwa" has been increased 56 times and decreased 7 times for a total karma of 49. |
| 12:22:21 | <yony258> dkayiwa++ |
| 12:22:29 | <dkayiwa> tobin_g: yes you got it :) |
| 12:22:30 | <yony258> dkayiwa: decreased? |
| 12:22:35 | <yony258> !karma tobin_g |
| 12:22:35 | <OpenMRSBot> yony258: Karma for "tobin_g" has been increased 2 times and decreased 0 times for a total karma of 2. |
| 12:22:39 | <yony258> !karma yony258 |
| 12:22:39 | <OpenMRSBot> yony258: Karma for "yony258" has been increased 1 time and decreased 0 times for a total karma of 1. |
| 12:22:45 | <tobin_g> yony258++ |
| 12:22:52 | <dkayiwa> yony258++ |
| 12:22:56 | <yony258> :P |
| 12:23:40 | <tobin_g> dkayiwa: yony258 is racking it in |
| 12:24:11 | *** kavuri has quit IRC |
| 12:24:21 | <yony258> tobin_g: you know it! |
| 12:24:25 | <tobin_g> yony258: what is your schedule for the afternoon? also adam's? |
| 12:24:43 | <yony258> tobin_g: today? |
| 12:24:48 | <tobin_g> yony258: ya |
| 12:24:57 | <tobin_g> dkayiwa: have you ever heard of sufganiyot? |
| 12:25:00 | <yony258> tobin_g: Lecture with Kobi at 5 pm |
| 12:25:15 | <dkayiwa> tobin_g: no |
| 12:25:47 | <tobin_g> dkayiwa: https://www.google.co.il/search?q=sufganiyot&hl=en&safe=off&tbo=d&source=lnms&tbm=isch&sa=X&ei=QMnJUPXUGYjM9ATP0YGIDg&ved=0CAcQ_AUoAA&biw=1045&bih=1005 |
| 12:25:49 | <OpenMRSBot> <http://ln-s.net/+HFd> (at www.google.co.il) |
| 12:26:14 | <tobin_g> dkayiwa: they're basically jelly donuts. greasy and delicious. typical food eaten for hannukah :-) |
| 12:26:36 | <dkayiwa> tobin_g: i thought sufganiyot was a software developer :) |
| 12:26:39 | <tobin_g> dkayiwa: promised to take yony258 and adam out to celebrate all their hard work, we wish you could come! |
| 12:26:44 | <tobin_g> dkayiwa: nerd |
| 12:26:59 | <dkayiwa> tobin_g: oh men!!! Those guys deserve a beautfiful party!!! |
| 12:27:11 | <tobin_g> dkayiwa: we could try to fedex you one although i can't promise the deliciousness factor on arrival |
| 12:27:13 | <dkayiwa> tobin_g: they have really worked their bats off :) |
| 12:27:25 | <dkayiwa> tobin_g: lolllllllllllll |
| 12:27:49 | <tobin_g> dkayiwa: so true! and we haven't even started with all of my little critiques 8) |
| 12:27:58 | <dkayiwa> tobin_g: oh yes :) |
| 12:28:01 | <tobin_g> dkayiwa: which i'm sure there will be none since it was so brilliantly designed :D |
| 12:28:17 | <dkayiwa> tobin_g: :D |
| 12:28:43 | <dkayiwa> tobin_g: from all my mentorship experience, they have been the most desiring to learn :) |
| 12:28:54 | <tobin_g> dkayiwa: this weekend i'll have time to start going through page-by-page. there may be some cosmetic stuff but i think functionality is great. |
| 12:28:57 | <dkayiwa> tobin_g: they do not use stuff without asking you why :) |
| 12:29:09 | <dkayiwa> tobin_g: correct |
| 12:29:10 | <yony258> dkayiwa: Yep :O |
| 12:29:14 | <yony258> dkayiwa: :D |
| 12:29:18 | <tobin_g> dkayiwa: theyr'e great and want to learn thats why! |
| 12:29:26 | <tobin_g> yony258: aren't you supposed to be eating lunch? |
| 12:29:37 | <yony258> tobin_g: lol |
| 12:29:43 | <tobin_g> yony258: we're trying to talk about you here. echem |
| 12:29:51 | <yony258> tobin_g: Haha |
| 12:29:53 | <dkayiwa> yony258: yes you have some times asked me questions where i ended up first reading to ensure i know what am replying :D |
| 12:30:46 | <yony258> dkayiwa: I hate doing stuff just because it works, I really want to know what I am doing and what is going on "behind the scenes" but I also realize there is a lot I do not know and thus I cant expect to understand all in 3 weeks |
| 12:31:16 | <dkayiwa> yony258: thats what we call a bright mind!!! :D |
| 12:31:25 | <tobin_g> yony258: so just let me know when you guys want to go, i should be getting the car from my friend in about half an hour so we'll be more mobile |
| 12:31:53 | <dkayiwa> tobin_g: just do not overspeed. we need the module to get finished :) |
| 12:32:15 | <yony258> tobin_g: Well I still have lots to do, probably will need to work on university stuff until 17:00 |
| 12:32:23 | <yony258> tobin_g: But IDK about Adam |
| 12:32:26 | <tobin_g> yony258: ok maybe after or tomorrow is also fine |
| 12:32:33 | <tobin_g> dkayiwa: i won't fatten them up too much but a little sugar might help the matter! |
| 12:32:40 | <yony258> tobin_g: cool :) |
| 12:32:45 | <dkayiwa> tobin_g: d:) |
| 12:35:11 | *** suranga has quit IRC |
| 12:36:45 | <dkayiwa> yony258: what does this mean? Invalid Date Interval |
| 12:39:09 | <yony258> dkayiwa: "Invalid dates range selected." is better? |
| 12:39:26 | <dkayiwa> yony258: what makes the range invalid? |
| 12:39:41 | <yony258> dkayiwa: that the toDate is smaller than fromDate |
| 12:39:45 | <dkayiwa> yony258: is it because it is too big? too small? |
| 12:39:59 | <dkayiwa> yony258: am pretending to be the end user |
| 12:40:13 | <dkayiwa> yony258: so the error message need to tell exactly what is wrong |
| 12:40:19 | <yony258> dkayiwa: I just dont know how to phrase it |
| 12:40:39 | <yony258> dkayiwa: Latter Date cant be smaller than first date? |
| 12:40:40 | <dkayiwa> yony258: i do not care about the english, all i need to know is what makes it invalid |
| 12:42:10 | <dkayiwa> yony258: what is Latter date? |
| 12:42:21 | <dkayiwa> yony258: can you state it in terms of what the user sees on the UI? |
| 12:42:32 | <yony258> dkayiwa: First Date should be earlier than the Second Date |
| 12:43:10 | <dkayiwa> yony258: on the UI, do you use First Date and Second Date as the captions for the date fields? |
| 12:43:33 | <yony258> dkayiwa: So what would you write? |
| 12:44:01 | <dkayiwa> yony258: i would include the exact names i used for the date widgets that the user sees |
| 12:44:13 | <yony258> dkayiwa: There are no names |
| 12:44:22 | <dkayiwa> yony258: oh i see!!!! |
| 12:44:44 | <dkayiwa> yony258: then in that case your: First Date should be earlier than the Second Date |
| 12:44:46 | <dkayiwa> :) |
| 12:44:56 | <yony258> dkayiwa: :) |
| 12:47:46 | *** gugwad has joined #openmrs |
| 12:49:19 | *** sagar has quit IRC |
| 12:53:57 | *** rfriedman has joined #openmrs |
| 12:54:41 | *** gugwad has quit IRC |
| 12:54:44 | <rfriedman> morning, rafa |
| 12:54:51 | <rafa> rfriedman: morning |
| 12:55:00 | <rfriedman> rafa, are you an eclipse user? |
| 12:55:04 | <rafa> yes |
| 12:55:34 | <rfriedman> rafa, my external disk got disconnected before or during an eclipse save yesterday |
| 12:55:46 | <rafa> rfriedman: but recently looking with envy at IDEA ;) |
| 12:55:59 | <rfriedman> rafa, it still sees my project groups but it can't get any of the files |
| 12:56:26 | <rfriedman> is there anything short of reinstalling that I can do? |
| 12:56:44 | <rafa> rfriedman: heh did you backup your workspace? |
| 12:56:55 | <rfriedman> nope |
| 12:57:21 | <rafa> rfriedman: do this in the future |
| 12:57:31 | <rafa> rfriedman: enough to backup .metadata |
| 12:57:40 | <rfriedman> yeah |
| 12:57:57 | <rafa> rfriedman: hmm can you send me a screenshot how it looks right now? |
| 12:57:59 | <rfriedman> so i might just be able to wipe the workspace and rebuild it? |
| 12:58:14 | <rfriedman> sure |
| 12:58:34 | <rafa> rfriedman: if you wipe .metadata out, Eclipse will recreate it, but you will have to import all projects again |
| 12:58:49 | <rafa> rfriedman: and your custom settings |
| 12:59:11 | <rfriedman> rafa, that means my plug-ins? |
| 12:59:14 | <rfriedman> ouch |
| 13:00:17 | <rafa> rfriedman: only plugin's configuration |
| 13:01:21 | <rafa> rfriedman: fortunately plugin are installed to eclipse/plugins |
| 13:01:33 | <rafa> rfriedman: and not stored in .metadata |
| 13:01:40 | <rafa> rfriedman: but maybe we can recover |
| 13:01:49 | <rafa> rfriedman: just let me look at what you see right now |
| 13:02:32 | *** jkeiper has joined #openmrs |
| 13:02:32 | *** ChanServ sets mode: +v jkeiper |
| 13:02:44 | <rafa> jkeiper: morning! |
| 13:02:53 | <rafa> jkeiper: do we have a dashboard yet? :) |
| 13:02:56 | <jkeiper> helllooooooooooo |
| 13:02:58 | <jkeiper> no |
| 13:02:59 | <jkeiper> :| |
| 13:03:06 | <rafa> jkeiper: ok |
| 13:03:15 | <jkeiper> rafa, i was waiting for the right JIRA project |
| 13:03:15 | <jkeiper> :-/ |
| 13:03:27 | <jkeiper> asked code@o.o for a name |
| 13:03:34 | <jkeiper> and sunny said i could have REG |
| 13:03:36 | <jkeiper> but ... |
| 13:03:39 | <rafa> jkeiper: yes, saw that |
| 13:03:41 | <jkeiper> here's the gist though ... |
| 13:03:55 | <jkeiper> and this really belongs in a kickoff ... |
| 13:03:56 | <jkeiper> but ... |
| 13:04:43 | <jkeiper> essentially we'll be creating a new module that provides a few services for registration |
| 13:04:45 | <rfriedman> rafa, what's your e-mail? |
| 13:04:54 | <rafa> rfriedman: rafal@openmrs.org |
| 13:06:32 | <rafa> rfriedman: ouch got it |
| 13:06:44 | <rfriedman> tabula rasa |
| 13:06:45 | <rafa> rfriedman: so it looks as if you lost your configuration |
| 13:06:56 | <rafa> rfriedman: you need to import projects again |
| 13:08:00 | *** robbyoconnor has quit IRC |
| 13:08:26 | <rafa> rfriedman: just do as always file -> Import -> Maven -> Existing Maven Projects |
| 13:09:31 | <rfriedman> ok, rafa, not git? |
| 13:09:50 | <rafa> rfriedman: you already have them checked out on your hdd |
| 13:10:01 | <rfriedman> rafa, yes |
| 13:10:07 | <rafa> rfriedman: so just point to them |
| 13:10:13 | <rfriedman> rafa, ok |
| 13:10:15 | <rafa> rfriedman: you can bind them with git after importing |
| 13:10:42 | <rafa> rfriedman: you just right-click on a project and do Team -> Share project |
| 13:10:56 | <rafa> rfriedman: stay with defaults there and you should be good |
| 13:12:45 | <rafa> rfriedman: when done don't forget to backup .metadata ;) |
| 13:13:23 | <rfriedman> rafa, tks |
| 13:13:32 | <rafa> rfriedman: np |
| 13:15:56 | *** akmad has joined #openmrs |
| 13:16:15 | *** akmad has left #openmrs |
| 13:17:11 | <rafa> jkeiper: when do you plan the kickoff? |
| 13:21:05 | *** suranga has joined #openmrs |
| 13:21:05 | *** ChanServ sets mode: +v suranga |
| 13:24:39 | <rfriedman> rafa, does it make any difference whether I import projects from their git repo or from the old workspace? |
| 13:25:35 | <rafa> rfriedman: hmm I always use git repo |
| 13:25:52 | <rafa> rfriedman: then git repo == workspace |
| 13:26:14 | <rfriedman> ok, but I had a couple of modules that I had gotten from svn |
| 13:26:33 | <rafa> rfriedman: you can just copy the git repo folder to your workspace folder |
| 13:26:42 | *** ibewes has joined #openmrs |
| 13:26:53 | <rafa> rfriedman: and have everything in one place if it's what you want |
| 13:27:26 | <rfriedman> rafa, i think i want to use the local git repos, it's just for those modules i only had them in the workspace |
| 13:27:43 | <rafa> rfriedman: you will still be using local git repos |
| 13:27:57 | <rafa> rfriedman: they will be located directly in your workspace |
| 13:28:23 | <rafa> rfriedman: for example I have d:\workspace\openmrs\ |
| 13:28:33 | <rafa> rfriedman: and inside there's d:\workspace\openmrs\.git\ |
| 13:28:45 | <rafa> rfriedman: which is git local storage |
| 13:29:49 | <rfriedman> ok, i have ~/workspace and ~/gitrepos |
| 13:30:32 | <jkeiper> rafa, i wondered when would be appropriate ... today is packed with meetings ... |
| 13:32:21 | <rfriedman> jkeiper, choose the meeting you least want to attend and hold it then |
| 13:32:30 | <jkeiper> rafa, once i get the JIRA project and the module name confirmed (think we have a quorum now), i'll have the tickets ready ... meanwhile, i'm pointing ppl to look at AMRS Registration Module to see a functional registration process (although lacking) |
| 13:32:40 | *** wyclif_ has joined #openmrs |
| 13:33:10 | <rafa> jkeiper: cool, when I can find the amrs module? |
| 13:33:49 | <rafa> jkeiper: *where |
| 13:36:24 | <jkeiper> rafa, ah yes ... under the AMPATH github account |
| 13:36:36 | <rafa> jkeiper: ok, thanks |
| 13:37:46 | <jkeiper> sorry |
| 13:37:48 | <jkeiper> url in one sec |
| 13:39:26 | *** rafa has quit IRC |
| 13:39:38 | <jkeiper> https://github.com/AMPATH/openmrs-module-amrsregistration |
| 13:39:38 | * jkeiper is mid-meeting w/ AMPATH |
| 13:39:38 | <OpenMRSBot> <http://ln-s.net/+Gv0> (at github.com) |
| 13:40:08 | *** wyclif_ has quit IRC |
| 13:51:46 | *** kishoreyekkanti has quit IRC |
| 13:53:47 | *** yony258 has quit IRC |
| 13:59:21 | <suranga> jkeiper, rafa i'm having my photographs made into an album/s :P |
| 14:11:45 | *** harshadura has joined #openmrs |
| 14:15:40 | <applecool> dkayiwa: hi |
| 14:15:57 | <dkayiwa> applecool: hi long time no see buddy :D |
| 14:16:18 | <applecool> dkayiwa: had semester exams! So could spend much time on IRC |
| 14:16:24 | <applecool> now back into the game :) |
| 14:16:39 | <applecool> dkayiwa: when is the dev call going to start? |
| 14:16:44 | <applecool> dkayiwa: how are you? |
| 14:16:46 | <dkayiwa> applecool: applecool welcome back mangocool :) |
| 14:17:07 | <dkayiwa> applecool: am doing fine. should be starting in like 40mins |
| 14:17:25 | <applecool> haha! :D |
| 14:17:38 | <applecool> great :) |
| 14:18:07 | <applecool> when is the next sprint going to be started? dkayiwa |
| 14:19:24 | <dkayiwa> applecool: today or tomorrow. jkeiper knows better :) |
| 14:19:35 | <applecool> Oh |
| 14:25:27 | *** wyclif_ has joined #openmrs |
| 14:27:06 | *** robbyoconnor has joined #openmrs |
| 14:27:06 | *** ChanServ sets mode: +v robbyoconnor |
| 14:27:10 | *** robbyoconnor has quit IRC |
| 14:37:51 | *** jblaya has joined #openmrs |
| 14:42:31 | *** rafa has joined #openmrs |
| 14:42:31 | *** ChanServ sets mode: +v rafa |
| 14:48:06 | *** jkeiper has quit IRC |
| 14:48:33 | <applecool> hi rfriedman |
| 14:48:40 | <applecool> hi rafa |
| 14:48:48 | <rafa> applecool: hi |
| 14:49:00 | <applecool> i am thinking to kick start with the enhancements again |
| 14:49:08 | <applecool> of the metadata repository |
| 14:50:16 | <rafa> applecool: great, let me know when you make any progress |
| 14:50:21 | <applecool> rafa: is it okay? or you want me anything else to be worked on? |
| 14:50:30 | <applecool> rafa: Okay great :) |
| 14:50:33 | *** tobin_g has quit IRC |
| 15:03:37 | *** harshadura_ has joined #openmrs |
| 15:04:06 | *** djazayeri has joined #openmrs |
| 15:04:06 | *** ChanServ sets mode: +o djazayeri |
| 15:04:41 | *** yanokwa has joined #openmrs |
| 15:04:41 | *** ChanServ sets mode: +v yanokwa |
| 15:05:49 | *** wyclif_ has quit IRC |
| 15:06:25 | *** harshadura has quit IRC |
| 15:12:29 | *** suranga has quit IRC |
| 15:13:31 | <jblaya> djazayeri, hi, I had a question about prescription, do you have any idea how hard it would be to change the regimen display frequency (e.g. 1 day/week, 2 day/week) to duration i.e. 8 days, 4 months... and assume that the frequency is 7 days/week |
| 15:20:39 | *** wyclif_ has joined #openmrs |
| 15:22:47 | <jblaya> rafa, wyclif_, do you have any idea of how long it would take a programmer to do what I asked before about changing the regimen display frequency? |
| 15:23:37 | <wyclif_> jblaya, sorry i didn't get to see your initial question |
| 15:24:00 | <jblaya> wyclif_, I had a question about prescription, do you have any idea how hard it would be to change the regimen display frequency (e.g. 1 day/week, 2 day/week) to duration i.e. 8 days, 4 months... and assume that the frequency is 7 days/week |
| 15:24:27 | <jblaya> wyclif_, or perhaps keep the frequency, but add a box for duration |
| 15:24:34 | <djazayeri> jblaya: offhand I don't see how to do this beyond replacing the regimens tab |
| 15:24:45 | <djazayeri> jblaya: that could be mostly copy-paste in this case |
| 15:25:31 | <wyclif_> jblaya, do you mean when it is 8days, it will always mean 8 days/week |
| 15:25:50 | <jblaya> djazayeri, ok, so fairly simple i.e. a couple of days of programming? |
| 15:26:30 | <jblaya> wyclif_, no, I meant to add an additional box, which says duration, and the user enters a number i.e. 1,2,3, and then selects a pulldown which says days, weeks, months |
| 15:26:46 | <jblaya> wyclif_, this is how long the person should take these medications for i.e. start and end date |
| 15:26:50 | <djazayeri> jblaya: yes. (though the person doing it will be annoyed because the underlying code there is ugly) |
| 15:27:22 | <jblaya> djazayeri, :D, ok, I'll get a patient programmer :D |
| 15:27:32 | <wyclif_> jblaya, as djazayeri says, you might need to replace that entire tab |
| 15:28:11 | <jblaya> wyclif_, djazayeri ok, thanks for that, I'm building a budget and I just needed to know if we were talking a couple of days, weeks or months |
| 15:28:46 | <jblaya> wyclif_, djazayeri once I have this more clear I'll see if this improvement should be sent back into core |
| 15:38:15 | *** ibewes has left #openmrs |
| 16:02:29 | *** yanokwa has quit IRC |
| 16:03:56 | *** rafa has quit IRC |
| 16:08:49 | *** sgithens has joined #openmrs |
| 16:11:58 | *** suranga has joined #openmrs |
| 16:13:48 | *** applecool has left #openmrs |
| 16:16:18 | *** jkeiper has joined #openmrs |
| 16:16:18 | *** ChanServ sets mode: +v jkeiper |
| 16:20:06 | *** wyclif_ has quit IRC |
| 16:29:38 | *** sgithens has quit IRC |
| 16:33:15 | *** wyclif_ has joined #openmrs |
| 16:37:13 | *** shortend has left #openmrs |
| 17:06:45 | *** Mkop has quit IRC |
| 17:07:19 | *** Mkop has joined #openmrs |
| 17:07:19 | *** ChanServ sets mode: +v Mkop |
| 17:31:23 | *** suranga has quit IRC |
| 17:34:18 | *** kishoreyekkanti has joined #openmrs |
| 17:47:05 | <jkeiper> hmmmmyes |
| 17:51:23 | <jkeiper> dkayiwa, are you around for scrum tomorrow? |
| 17:51:26 | <jkeiper> normal time? |
| 17:51:38 | <dkayiwa> jkeiper: yes |
| 17:52:18 | <jkeiper> dkayiwa, so is that a good time to do a kickoff meeting for the registration sprint? |
| 17:52:25 | <jkeiper> ;-) |
| 17:53:22 | <dkayiwa> jkeiper: how long will it last? |
| 17:53:42 | <jkeiper> approx 9h |
| 17:53:46 | <jkeiper> heheh |
| 17:53:53 | <jkeiper> idk, maybe 20 minutes? |
| 17:54:05 | <jkeiper> just need to have everyone on the same page before we get coding |
| 17:54:34 | <dkayiwa> jkeiper: can we do it like 30 mins before scrum? |
| 17:55:46 | <jkeiper> dkayiwa, sure |
| 17:55:47 | <jkeiper> :-) |
| 17:56:26 | <dkayiwa> jkeiper: earlier will work better for me :) |
| 17:56:39 | <jkeiper> haha, that is fine |
| 17:57:03 | <dkayiwa> jkeiper: excellent :D |
| 17:57:56 | *** suranga has joined #openmrs |
| 17:57:56 | *** ChanServ sets mode: +v suranga |
| 18:06:53 | <suranga> hi jkeiper , is the registration sprint now underway ? :) |
| 18:07:28 | <jkeiper> suranga, kinda? |
| 18:07:33 | <jkeiper> soon-ish |
| 18:07:35 | <jkeiper> like tomorrow |
| 18:07:51 | <jkeiper> suranga, want to participate? ;-) |
| 18:08:28 | <suranga> jkeiper, oh, I see. I kinda wanted to release the hl7query module version 1.0 today, but failed (theres some minor glitch) so I wanted to see if there was anything I could work on :-) |
| 18:08:41 | <jkeiper> suranga, ah sorry |
| 18:08:43 | <jkeiper> no tickets yet :( |
| 18:08:48 | <suranga> jkeiper, definitely, I havent done much work these days, so I probably should :) |
| 18:08:50 | <jkeiper> awaiting a project |
| 18:08:51 | <jkeiper> :-D |
| 18:09:12 | <suranga> jkeiper, is the a brand new, from the scratch module ? :) |
| 18:11:05 | <jkeiper> suranga, yes but it should be noted this is not for creating a registration UI |
| 18:11:20 | <jkeiper> suranga, it is for creating a registration API with hooks into various other modules |
| 18:11:26 | <jkeiper> like events, idgen, restws |
| 18:12:12 | <suranga> jkeiper, ooh, sounds neat (but probably complex :P) |
| 18:12:29 | <jkeiper> mm, it's a simple concept |
| 18:12:43 | <jkeiper> provide service and utility methods for registering a patient |
| 18:13:03 | <jkeiper> including search methods for finding a patient that already exists while filling out the registration form |
| 18:13:40 | <jkeiper> then we hook in with event module to notify whoever cares about registration events |
| 18:13:55 | <jkeiper> and hook into restws to provide access to our service methods |
| 18:14:01 | <jkeiper> and use idgen to generate ids |
| 18:14:02 | <jkeiper> :-D |
| 18:14:44 | <suranga> jkeiper, and we're starting tomorrow, right ? :) |
| 18:14:53 | <jkeiper> yep! |
| 18:18:41 | *** yony258 has joined #openmrs |
| 18:36:31 | <jkeiper> suranga, http://db.tt/dFmsFfpe |
| 18:38:10 | <suranga> jkeiper, niceeee |
| 18:38:15 | *** travis-ci has joined #openmrs |
| 18:38:15 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [2144b4c] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3649783 |
| 18:38:15 | *** travis-ci has left #openmrs |
| 18:38:16 | <suranga> where are you sending this ? :) |
| 18:38:19 | <OpenMRSBot> <http://ln-s.net/+HNG> (at travis-ci.org) |
| 18:39:48 | <yony258> dkayiwa: Hi :) |
| 18:40:42 | *** adam_l_ has joined #openmrs |
| 18:41:02 | <yony258> dkayiwa: I wanted to ask if I can assume that the "OpenMRS Identification Number" PatientIdentifier will always have id=2 ? |
| 18:41:18 | *** kishoreyekkanti has quit IRC |
| 18:43:01 | <suranga> yony258, i think thats a safe bet :) |
| 18:43:13 | <yony258> suranga: Thank you :] |
| 18:46:18 | *** kishoreyekkanti has joined #openmrs |
| 18:51:58 | *** andreapat has joined #openmrs |
| 18:58:22 | *** rafa has joined #openmrs |
| 18:58:22 | *** ChanServ sets mode: +v rafa |
| 19:03:33 | *** sgithens has joined #openmrs |
| 19:07:33 | *** harshadura_ has quit IRC |
| 19:08:37 | *** harshadura has joined #openmrs |
| 19:10:05 | <adam_l_> wyclif_: HI :) can I bind a list of objects to a drop down list so that the objects will be represented in the drop down list and if I change the drop down list then the list/db will update? |
| 19:10:51 | *** kishoreyekkanti has quit IRC |
| 19:10:51 | <dkayiwa> yony258: hi |
| 19:10:58 | <yony258> dkayiwa: Hi |
| 19:11:19 | <dkayiwa> yony258: you can never know the id |
| 19:11:35 | <dkayiwa> yony258: user can delete and add again with new id |
| 19:11:52 | <yony258> dkayiwa: So how can I make "OpenMRS Identification Number" show first? |
| 19:12:27 | <dkayiwa> yony258: it does not have to be it |
| 19:12:49 | <dkayiwa> yony258: show first the prefered one |
| 19:12:55 | <wyclif_> adam_l_, i don't seem to get your question well. but set the bing on the select tag only and not the individual items in the dropdown |
| 19:13:04 | <yony258> dkayiwa: Tobin said it does |
| 19:13:29 | <yony258> dkayiwa: Oh ok, maybe the preferred one is a good choice ! |
| 19:13:42 | <dkayiwa> yony258: he meant the prefrered one |
| 19:13:51 | <wyclif_> adam_l_, you can have a look at any form in core that has a dropdown e.f visitForm.jsp, see how the visitType is set up |
| 19:13:57 | <yony258> dkayiwa: Got it, let me finish it then |
| 19:14:15 | <dkayiwa> yony258: ok |
| 19:14:23 | <adam_l_> wyclif_: ok thanks that answers my question :) |
| 19:15:03 | <wyclif_> adam_l_, ok |
| 19:17:04 | <yony258> dkayiwa: Done. And executes correctly :) |
| 19:17:18 | <dkayiwa> yony258: wonderful :) |
| 19:17:46 | <yony258> dkayiwa: I'll push now so you'll be able to review (Whenever you have time of course). |
| 19:17:54 | <dkayiwa> yony258: ok |
| 19:21:13 | <yony258> dkayiwa: ok, pushed. I will wait for your review, because I think this has all the required functionality (according to AM-4) |
| 19:21:28 | <dkayiwa> yony258: ok let me review now |
| 19:21:33 | *** harshadura has quit IRC |
| 19:21:37 | <yony258> !ticket AM-4 |
| 19:21:38 | <OpenMRSBot> yony258: [#AM-4] Create new Appointment - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-4 |
| 19:22:15 | *** harshadura has joined #openmrs |
| 19:22:48 | *** ningosi has joined #openmrs |
| 19:23:02 | *** ningosi is now known as Ojwanganto |
| 19:27:30 | <dkayiwa> yony258: review comments awaiting |
| 19:27:56 | <yony258> dkayiwa: Seen and working on it |
| 19:28:01 | <dkayiwa> yony258: ok |
| 19:28:06 | <yony258> dkayiwa: But ! |
| 19:28:14 | <yony258> dkayiwa: There is no patientId anymore in this class |
| 19:28:46 | <yony258> dkayiwa: I did setIdentifiers(String patientId) in order to prevent code duplication and to create the Identifiers list by a given patientId. |
| 19:30:07 | <dkayiwa> yony258: according to our convention, that method should take the identifiers list and just set them |
| 19:30:18 | <dkayiwa> yony258: so that code belongs somewhere else |
| 19:30:48 | <yony258> dkayiwa: But If I need to do that again? I rewrite all code? |
| 19:31:04 | <dkayiwa> yony258: put that code in the service later |
| 19:31:09 | <dkayiwa> yony258: service layer |
| 19:31:22 | <dkayiwa> yony258: then all users for it should just call the service layer |
| 19:31:37 | <dkayiwa> yony258: our domain objects should not have such bussiness logic |
| 19:31:45 | <yony258> dkayiwa: ok |
| 19:31:53 | <yony258> dkayiwa: So I need to add a unit test too? |
| 19:32:09 | <dkayiwa> yony258: excellent!!! :) |
| 19:32:27 | <yony258> dkayiwa: So I need to create patients and patient identifiers and such in the xml? |
| 19:32:37 | <yony258> dkayiwa: dataSet.xml |
| 19:32:54 | <dkayiwa> yony258: openmrs-core should already be having them |
| 19:33:17 | <dkayiwa> yony258: standardTestDataset.xml |
| 19:33:22 | <yony258> dkayiwa: ok, thank you |
| 19:33:23 | <dkayiwa> yony258: in openmrs-api |
| 19:33:50 | <dkayiwa> yony258: and that dataset is automatically part of all ContextSentitiveTests |
| 19:33:55 | <yony258> dkayiwa: It is much simpler in the previous way :P, but I can see why this change is important. |
| 19:34:19 | <dkayiwa> yony258: simply is not always the most easily maintainable :) |
| 19:34:38 | <yony258> dkayiwa: Yea Im starting to learn this in the hard way |
| 19:34:48 | <dkayiwa> yony258: lollllllll |
| 19:35:06 | <yony258> dkayiwa: The way I did it is good for university assignments, not for this kind of system :P |
| 19:35:28 | <dkayiwa> yony258: hahahaha :D |
| 19:35:58 | <yony258> dkayiwa: On a side note, except of this, how much there is to change until we can mark this as done? |
| 19:36:08 | <yony258> dkayiwa: Im just so anxious to finish this ticket :D |
| 19:36:34 | <dkayiwa> yony258: tobin is the one with an answer to that |
| 19:37:02 | <yony258> dkayiwa: ok, but from your perspective? (assuming what I did fit AM-6 specification) |
| 19:38:28 | *** sgithens has quit IRC |
| 19:39:01 | <yony258> dkayiwa: By the way Im starting to think that we will need to add AppointmentType property for appointment. (for example when we want to compute the average duration of a specific appointment type we can run a query for appointments with the given appointment_type) |
| 19:41:18 | *** cpower has joined #openmrs |
| 19:41:27 | <cpower> Hello, hello..hello! |
| 19:42:02 | <cpower> I need someone to spike on the RestWS module, anyone interested? |
| 19:42:07 | <jblaya> yony258, I put up some screenshots and requirements that we had for the appointment system we built in another software, and I wanted to check that you had seen those |
| 19:42:18 | <cpower> <---figures it never hurts to ask |
| 19:42:42 | <dkayiwa> yony258: correct |
| 19:49:55 | <dkayiwa> yony258: NOT correct :) |
| 19:49:55 | <yony258> jblaya: Did not see them, can you please send me a link? |
| 19:49:59 | <cpower> the crickets are great.. |
| 19:50:00 | <yony258> dkayiwa: ? |
| 19:50:22 | <jblaya> cpower, yeah, defining even down here in Chile :D |
| 19:50:38 | <dkayiwa> yony258: currently, cant we get the type for an appointment? |
| 19:50:53 | <yony258> dkayiwa: What if it's block have more than one type? |
| 19:51:16 | <dkayiwa> yony258: ohhhhh |
| 19:51:24 | <yony258> dkayiwa: Like a boss ! |
| 19:51:34 | <yony258> dkayiwa: :D |
| 19:52:25 | <dkayiwa> yony258: when one selects a time slot, don't we record the appt type |
| 19:52:54 | <cpower> In American baseball I just got word that Josh Hamilton has been traded to LA Angels...that caused me be to be stunned for the last 10 minutes |
| 19:52:59 | <yony258> dkayiwa: We filter slots according to the selection |
| 19:53:20 | *** sgithens has joined #openmrs |
| 19:53:20 | <dkayiwa> yony258: ok |
| 19:53:46 | <cpower> But back to Open MRS, rafa would you like to do a spike on RestWS sometime soon? |
| 19:53:59 | <dkayiwa> yony258: why dont we have a separate block for each appointment type? |
| 19:54:47 | <rafa> cpower: the one to provide support for multiple versions of OpenMRS? |
| 19:54:49 | <jblaya> yony258, is there a wiki page for this project? I can't find it and I think I put the requirements there |
| 19:55:12 | <yony258> jblaya: Let me check |
| 19:55:50 | <cpower> Rafa: possibly, djazayeri can fill in the blanks better than I, I'm just on the hunt for a core dev to spike on it :-) |
| 19:56:24 | <djazayeri> rafa (and wyclif_ and dkayiwa) |
| 19:56:26 | <rafa> cpower: well with my love to rest I can do anything ;) |
| 19:56:31 | <yony258> jblaya: https://wiki.openmrs.org/display/projects/Appointment+Module |
| 19:56:37 | <wyclif_> hi djazayeri |
| 19:56:45 | <djazayeri> the idea is that we have a plan laid out for how to merge RESTWS and RESTWS19ext into one module. |
| 19:56:48 | <yony258> jblaya: This is the wiki page, it doesn't have much yet. |
| 19:57:12 | <cpower> rafa: I am talking about code and not a bed...just to cover the bases. |
| 19:57:14 | <djazayeri> and the idea is that we want a core dev to do the initial work (because that can't really be parallelized) |
| 19:57:23 | <rafa> lol |
| 19:57:35 | <djazayeri> and then we'll look to have a sprint or the equivalent to finish off the other pieces |
| 19:57:57 | <cpower> rafa: but read what djazayeri is writing as it's more useful than my bad jokes. |
| 19:58:14 | <wyclif_> djazayeri, ok |
| 19:58:31 | <djazayeri> I suggested that rafa will be the best one to do the initial piece of work, since he's had the most experience getting modules to run in multiple OpenMRS versions. |
| 19:58:51 | <rafa> and I haven't documented it yet :( |
| 19:59:08 | <cpower> Rafa: when do you think you can do the initial work? |
| 19:59:16 | <rafa> so yes, probably will be the easiest thing for me |
| 19:59:58 | <jblaya> yony258, dkayiwa, it took me a while, but I put the requirements for the appointment module here https://wiki.openmrs.org/display/RES/Visit+Scheduling+or+Queueing |
| 20:00:04 | <rafa> cpower: we have a reporting sprint right now |
| 20:00:08 | <djazayeri> rafa: think of this as a chance to do a refined version, and learn some lessons, before you actually document the best-practice. |
| 20:00:21 | <rafa> cpower: so probably after that |
| 20:00:39 | <cpower> rafa, best guess, two weeks? |
| 20:00:52 | <cpower> when should I check back? |
| 20:00:55 | <andreapat> cpower, I am here - luch is next week |
| 20:00:57 | <jblaya> yony258, dkayiwa, they've also created a test user on their system for you to look at it, Url: http://200.27.179.138:82/user/?returnUrl=|operador |
| 20:00:57 | <jblaya> User: usrtestldap |
| 20:00:57 | <jblaya> Pass: usrtestldap |
| 20:01:00 | <OpenMRSBot> <http://ln-s.net/+HPC> (at 200.27.179.138:82) |
| 20:01:18 | <yony258> jblaya: Wow thats amazing, thank you! |
| 20:01:32 | <jblaya> yony258, dkayiwa, I didn't want to put the user on the wiki because we don't want the entire world to enter the demo |
| 20:01:32 | <rafa> cpower: just put it on the calendar for me in the last week of December |
| 20:01:43 | <cpower> you got it :-) |
| 20:01:54 | <cpower> ok, are we ready to scrum? |
| 20:02:03 | <cpower> if not too bad, we are doing it anyway! |
| 20:02:08 | <cpower> !scrumon cpower |
| 20:02:08 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 20:02:59 | <cpower> Order: jkeiper, wyclif_, dkayiwa, andreapat, suranga, rafa, djazayeri and anyone else who would like to share |
| 20:03:25 | <yony258> cpower: me too |
| 20:03:42 | <jkeiper> until now: organizing sprint details and getting code ready |
| 20:03:54 | <jkeiper> until next: making tickets, holding kickoff meeting, running scrum |
| 20:03:54 | <cpower> Sounds good, we'll add you to the end yony |
| 20:04:01 | <jkeiper> blockers: waiting on JIRA project |
| 20:04:05 | <wyclif_> Wednesday: |
| 20:04:06 | <wyclif_> University call |
| 20:04:06 | <wyclif_> Curated tickets |
| 20:04:06 | <wyclif_> Design call |
| 20:04:06 | <wyclif_> IRC chat with Adam to help him debug a problem in appointment module |
| 20:04:06 | <wyclif_> Reviewed - DrugOrderValidator should allow a drug order with either a concept or drug |
| 20:04:08 | <wyclif_> Addressed TODOs after review of SXS-1 - Fix unit tests in serialization module |
| 20:04:10 | <wyclif_> |
| 20:04:12 | <wyclif_> Thursday: |
| 20:04:14 | <wyclif_> Dev call |
| 20:04:16 | <wyclif_> curating tickets |
| 20:04:18 | <wyclif_> Reviews |
| 20:04:20 | <wyclif_> TRUNK-2969 - New visit save errors should not clear new encounter rows |
| 20:04:22 | <wyclif_> TRUNK-3008 - DrugOrderValidator should allow a drug order with either a concept or drug |
| 20:04:24 | <wyclif_> Pick up a bug ticket to work in the meantime |
| 20:04:26 | <wyclif_> |
| 20:04:28 | <wyclif_> Blockers: None |
| 20:04:32 | <dkayiwa> Reviewed commits for Tobin's Team and tested module |
| 20:04:32 | <dkayiwa> Given guidance to Tobin's team with their current tasks |
| 20:04:33 | <dkayiwa> Committed: New visit save errors should not clear new encounter rows - TRUNK-2969 |
| 20:04:33 | <dkayiwa> Dev Call |
| 20:04:33 | <dkayiwa> Now working on: Editing an encounter to set its encounterDatetime to a value invalid for the visit it belongs to gives an error, but changes the date anyway - TRUNK-3572 |
| 20:04:33 | <dkayiwa> No Blockers |
| 20:05:32 | <cpower> andreapat you are up |
| 20:05:50 | <andreapat> Wednesday |
| 20:05:50 | <andreapat> TRUNK-2768 |
| 20:05:50 | <andreapat> Liquibase changeset for deathdateEstimated |
| 20:05:50 | <andreapat> person.hbm.xml - new property for same |
| 20:05:50 | <andreapat> |
| 20:05:51 | <andreapat> Thursday |
| 20:05:53 | <andreapat> Dev call |
| 20:05:57 | <andreapat> Find problem causing errors in tests (after added change to person.hbm.xml) |
| 20:05:59 | <andreapat> |
| 20:06:01 | <andreapat> Blocker |
| 20:06:03 | <andreapat> Errors in test in PatientServiceTest cause by PatientServiceImp line 948: |
| 20:06:05 | <andreapat> mergedData.setPriorDateOfDeathEstimated(preferred.isDeathdateEstimated()); |
| 20:06:07 | <andreapat> |
| 20:06:43 | <cpower> suranga you are up |
| 20:06:50 | <suranga> howdy ! |
| 20:06:56 | <suranga> DID |
| 20:06:56 | <suranga> Fixed failing unit tests on hl7query module (turns out it was a problem in my local maven repo) |
| 20:06:56 | <suranga> Prepared for release of hl7query 1.0 |
| 20:06:56 | <suranga> (stuck while trying to release, as mvn release command gives me an error.) will re-try again tomorrow, and release module |
| 20:06:56 | <suranga> TO DO |
| 20:06:58 | <suranga> Release hl7query 1.0 tomorrow/tonight |
| 20:07:03 | <suranga> NO BLOCKERS |
| 20:07:14 | <suranga> other than my own ignorance, that is :) |
| 20:07:34 | <rafa> Today: |
| 20:07:35 | <rafa> * Committed META-298: Error when importing package; Failed to parse the expression [${importer.package.dateCreated}] |
| 20:07:35 | <rafa> https://tickets.openmrs.org/browse/META-298 |
| 20:07:35 | <rafa> * Follow up support for James with MDS |
| 20:07:35 | <rafa> * Dev Call |
| 20:07:35 | <rafa> No blockers. |
| 20:07:50 | <djazayeri> Recently |
| 20:07:50 | <djazayeri> * Calls (OpenMRS, Mirebalais, Kenya) |
| 20:07:50 | <djazayeri> * Exploring different form entry mechanisms (with the UI Framework) for mirebalais |
| 20:07:50 | <djazayeri> * Mailing lists |
| 20:07:50 | <djazayeri> No blockers |
| 20:08:21 | <cpower> yony258 you are up! |
| 20:08:23 | <cpower> :-) |
| 20:08:27 | <yony258> Wednesday: (AM-6) |
| 20:08:35 | <yony258> Resolved the biggest issue with Create Appointment Form (Time Slots table) |
| 20:08:39 | <yony258> Added form validation. |
| 20:08:42 | <yony258> Started to fix after review. |
| 20:08:45 | <yony258> Thursday: (AM-6) |
| 20:08:50 | <yony258> Doing some changes in the presented patients details |
| 20:08:54 | <yony258> Continue getting reviews |
| 20:08:57 | <yony258> Friday: |
| 20:09:01 | <yony258> Hopefully will mark AM-6 as completed and start AM-10 |
| 20:09:05 | <yony258> Blockers: none |
| 20:09:07 | <dkayiwa> yony258: Excellent :D |
| 20:09:14 | <dkayiwa> adam_l_: next :) |
| 20:09:22 | <cpower> sure go for it |
| 20:11:17 | *** adam_l_ has quit IRC |
| 20:11:36 | <cpower> great update adam! |
| 20:11:44 | <cpower> ;-) |
| 20:11:45 | <yony258> jblaya: The link you sent me doesn't seems to work, can you please check again? Thank you :) |
| 20:11:54 | <cpower> ok, blockers |
| 20:12:14 | <cpower> 15:06] <andreapat> Blocker |
| 20:12:14 | <cpower> [15:06] <andreapat> Errors in test in PatientServiceTest cause by PatientServiceImp line 948: |
| 20:12:14 | <cpower> [15:06] <andreapat> mergedData.setPriorDateOfDeathEstimated(preferred.isDeathdateEstimated()); |
| 20:12:38 | <cpower> and |
| 20:12:46 | <cpower> [15:04] <+jkeiper> blockers: waiting on JIRA project (Need Downey) |
| 20:13:15 | <djazayeri> andreapat: you need to share a code fragment! |
| 20:13:20 | <djazayeri> :-) |
| 20:13:23 | <jkeiper> gist ftw |
| 20:13:25 | <djazayeri> or the error message |
| 20:13:32 | <cpower> on paste bin I would imagine |
| 20:13:54 | <andreapat> djazayeri, ok |
| 20:14:08 | <cpower> !scrumoff |
| 20:14:08 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:16:16 | <cpower> Rafal do you need design forum time for your restWS work say next week? |
| 20:16:18 | <andreapat> djazayeri, http://pastebin.com/9yT30R2G |
| 20:16:46 | <djazayeri> cpower, rafa: in theory this is already designed |
| 20:16:49 | <djazayeri> though I don't see it on the ticket. |
| 20:16:50 | <rafa> cpower: it's been all said already |
| 20:17:05 | <cpower> fair enough |
| 20:17:14 | <andreapat> djazayeri, that's just one stacktrace - there are 28 |
| 20:17:40 | <djazayeri> andreapat: what is this line of code (mentioned in the top line of the stack trace) |
| 20:17:40 | <djazayeri> at org.openmrs.api.impl.PatientServiceImpl.mergePatients(PatientServiceImpl.java:948) |
| 20:17:48 | <djazayeri> that's line 948 |
| 20:18:38 | <andreapat> djazaeri, clean build till added deathdateEstimated property to person.hbm.xml |
| 20:18:58 | <andreapat> djazayeri, yest the second line of the code I put up |
| 20:19:29 | <jkeiper> andreapat, are you guaranteed that preferred and notPreferred are not null? |
| 20:19:32 | <yony258> dkayiwa: ok changed to API method, added implementation and unit test, verified correctness. |
| 20:19:33 | <rafa> djazayeri: it's this ticket right https://tickets.openmrs.org/browse/RESTWS-310 ? |
| 20:19:36 | <yony258> dkayiwa: pushed |
| 20:20:01 | <djazayeri> rafa: oh yeah, that! there's also a ticket about merging the modules, which is just a one-liner |
| 20:20:03 | <dkayiwa> yony258: ok looking now |
| 20:20:09 | <andreapat> jkeiper, no - would like to debug but can't build |
| 20:20:58 | <jkeiper> debug in the test :-) |
| 20:22:16 | <andreapat> jkeiper, run test with debug - didn't realize u could do that - let me keep working on it a bit more |
| 20:25:08 | *** sgithens has quit IRC |
| 20:25:20 | <jkeiper> np, good luck! |
| 20:25:59 | <andreapat> jkeiper, thanks |
| 20:26:22 | <jblaya> yony258, let me look |
| 20:26:40 | <jblaya> yony258, which URL for the openmrs wiki or for the demo site? |
| 20:26:50 | <yony258> jblaya: demo site |
| 20:27:26 | <jkeiper> jblaya, sorry ... my internet gave out right after you IMed me today! |
| 20:27:54 | <jblaya> jkeiper, no problem, I was able to get it answered here :) |
| 20:28:01 | <jblaya> yony258, that's weird, it works for me |
| 20:28:12 | <jblaya> yony258, give me a sec to check |
| 20:28:34 | <jkeiper> jblaya, ok :-) |
| 20:32:07 | *** yony258_ has joined #openmrs |
| 20:33:22 | *** yony258 has quit IRC |
| 20:34:03 | *** yony258_ is now known as yony258 |
| 20:34:06 | <yony258> Had a DC |
| 20:35:01 | <jblaya> yony258, the url worked for me on 2 different devices on 2 different networks |
| 20:35:16 | <jblaya> yony258, http://200.27.179.138:82/user/?returnUrl=|operador try it again |
| 20:35:17 | <OpenMRSBot> <http://ln-s.net/+HPC> (at 200.27.179.138:82) |
| 20:35:38 | *** Ojwanganto has quit IRC |
| 20:36:05 | <yony258> jblaya: It could be the port, since im using the university dorms networks which have most of the ports blocked. dkayiwa or any1 else can try and confirm that works for them? |
| 20:36:38 | <jblaya> yony258, that sounds that to me |
| 20:36:48 | <djazayeri> andreapat: isDeathdateEstimated is incorrect for an optional property |
| 20:36:57 | <dkayiwa> yony258: i get the login screen |
| 20:37:11 | <djazayeri> andreapat: particularly, isXyz is supposed to be for a boolean xyz property (note the lowercase b) |
| 20:37:13 | <yony258> jblaya: I will try later using the iphone hotspot, but Thank you!. I also looked at the doc you attached at the wiki page but since I dont know that language I could really understand it :) |
| 20:37:19 | <yony258> dkayiwa: Thanks |
| 20:37:24 | <djazayeri> andreapat: and getXyz is for a Boolean property (note the uppercase) |
| 20:37:26 | <jblaya> yony258, will you be able to get around that? becuase taking the port out will be a pain |
| 20:37:28 | <yony258> jblaya: So I will try asap with the iphone hotspot |
| 20:37:45 | <jblaya> yony258, and yeah, that's what i figured, I think you should put it through a google translator perhaps |
| 20:37:49 | <djazayeri> andreapat: since deathdateEstimate should be optional (e.g. it should be null if deathdate is null) then it should be a Boolen property |
| 20:37:59 | <yony258> jblaya: Which language was that? Spanish? |
| 20:38:04 | <djazayeri> andreapat: and it should have a getDeathdateEstimated getter, which is allowed to return null. |
| 20:38:12 | <jblaya> yony258, good luck and any question feel free to email me jblaya@ehs.cl, and yes, it's spanish |
| 20:38:38 | <djazayeri> andreapat: does that make sense? (I'm off to buy lunch, back in 20.) |
| 20:38:46 | <yony258> jblaya: Thank you ! |
| 20:39:15 | *** yony258 has quit IRC |
| 20:39:46 | *** jblaya has quit IRC |
| 20:41:18 | *** yony258 has joined #openmrs |
| 20:42:10 | <yony258> dkayiwa: What jblaya sent is amazing. def worth taking a look at it! |
| 20:42:54 | *** yony258 has quit IRC |
| 20:44:12 | *** yony258 has joined #openmrs |
| 20:49:14 | *** suranga has quit IRC |
| 20:50:31 | *** dkayiwa has quit IRC |
| 21:06:42 | *** jkeiper has quit IRC |
| 21:41:41 | <andreapat> djazayeri, had already gone to grab some lunch |
| 21:42:26 | <andreapat> djazayeri, Here is deathdateEstimated from Person.java: |
| 21:42:32 | <andreapat> private Boolean deathdateEstimated = false; |
| 21:42:53 | <djazayeri> andreapat: but what about the getter method? |
| 21:43:52 | <andreapat> djazayeri, they take and return Boolean too |
| 21:45:43 | <djazayeri> andreapat: so, can you verify exactly what the line of code PatientServiceImpl:948 says? |
| 21:45:57 | <andreapat> djazayeri, returns a Boolean but in person.hbm.xml: <property name="deathdateEstimated" type="boolean" |
| 21:46:54 | <andreapat> djazayeri, line 948: mergedData.setPriorDateOfDeathEstimated(preferred.isDeathdateEstimated()); |
| 21:47:39 | <djazayeri> andreapat: and there is no "caused by" in the exception chain? |
| 21:47:51 | <andreapat> djazayeri, I get what you're saying - maybe property in person.hbm.xml is problem |
| 21:48:12 | <djazayeri> andreapat: could be â try changing it to java.lang.Boolean |
| 21:48:43 | <andreapat> djazayeri, property for birthdateEstimated is the same but will try |
| 21:49:20 | <djazayeri> andreapat: birthdate is required though, right? |
| 21:49:28 | <djazayeri> andreapat: actually it isn't, so never mind |
| 21:49:44 | <djazayeri> andreapat: is there a "caused by" associated with the stack trace you sent along? |
| 21:52:07 | <andreapat> djazayeri, no |
| 21:55:20 | *** Mkop1 has joined #openmrs |
| 21:55:20 | *** ChanServ sets mode: +v Mkop1 |
| 21:57:34 | *** Mkop has quit IRC |
| 22:06:43 | *** Mkop1 is now known as Mkop |
| 22:17:35 | *** rfriedman has quit IRC |
| 22:20:24 | <andreapat> djazayeri, had to build twice cause I forgot java, |
| 22:20:36 | *** wyclif_ has quit IRC |
| 22:20:46 | <andreapat> .lang first time - same thing - a real stumper |
| 22:21:46 | <andreapat> djazayerii, there are 28 tets in error all at that line of code |
| 22:22:41 | <andreapat> djazayerii, does liqibase-update execute at run or clean? |
| 22:32:33 | *** yony258 has quit IRC |
| 22:34:49 | <djazayeri> andreapat: ahâ¦liquibase-update doesn't ever execute during unit tests |
| 22:35:19 | <djazayeri> andreapat: but it's not a no-such-method or no-such-field exception... |
| 22:57:33 | <andreapat> djazayeri, what is -- protected static final String CREATE_PATIENT_XML = "org/openmrs/api/include/PatientServiceTest-createPatient.xml"; |
| 22:59:27 | <djazayeri> andreapat: it's a dataset of test data that is loaded to run the tests on |
| 23:00:38 | <andreapat> djazayeri, ok thanks - think I need to take a break from this |
| 23:31:03 | *** rafa has quit IRC |
| 23:56:31 | *** yony258 has joined #openmrs |
