| 00:08:36 | *** Mkop1 has joined #openmrs |
| 00:08:36 | *** ChanServ sets mode: +v Mkop1 |
| 00:14:47 | *** grahameg has joined #openmrs |
| 00:29:02 | *** grahameg has quit IRC |
| 00:35:54 | *** wyclif_ has quit IRC |
| 01:10:23 | *** sgithens has joined #openmrs |
| 02:59:48 | *** Mkop1 has quit IRC |
| 03:13:20 | *** Mkop1 has joined #openmrs |
| 03:13:21 | *** ChanServ sets mode: +v Mkop1 |
| 03:14:10 | *** Mkop1 has quit IRC |
| 03:30:56 | *** Mkop1 has joined #openmrs |
| 03:30:56 | *** ChanServ sets mode: +v Mkop1 |
| 03:31:46 | *** Mkop1 has quit IRC |
| 03:32:34 | *** Mkop1 has joined #openmrs |
| 03:32:34 | *** ChanServ sets mode: +v Mkop1 |
| 03:32:34 | *** Mkop1 has quit IRC |
| 03:41:30 | *** Mkop1 has joined #openmrs |
| 03:41:30 | *** ChanServ sets mode: +v Mkop1 |
| 03:57:19 | *** Mkop1 has quit IRC |
| 04:14:56 | *** Mkop1 has joined #openmrs |
| 04:14:56 | *** ChanServ sets mode: +v Mkop1 |
| 04:52:23 | *** Mkop1 has quit IRC |
| 06:18:06 | *** jkeiper has quit IRC |
| 08:01:40 | *** tobin_g has joined #openmrs |
| 08:18:40 | *** dkayiwa has joined #openmrs |
| 08:27:19 | *** adam_l has joined #openmrs |
| 08:29:20 | *** djazayeri has quit IRC |
| 08:29:27 | <adam_l> dkayiwa: Hi daniel. can I convert java script Date to java.sql.timestamp? |
| 08:29:54 | <adam_l> dkayiwa: with DWR |
| 08:30:31 | <dkayiwa> adam_l: hi |
| 08:30:43 | <adam_l> dkayiwa: I have a problem to compare the dates in my query because there not the same you see |
| 08:31:01 | <dkayiwa> adam_l: are you comparing dates in javascript? |
| 08:32:02 | <adam_l> dkayiwa: no. if you remeber I wrote restrictions (greater or equal and lower or equal) regarding the strartDate and the endDate |
| 08:32:45 | <dkayiwa> adam_l: and? |
| 08:33:13 | <adam_l> dkayiwa: now the Date I get from the javaScript is converted to java.util.Date and the Dates in hibernate are java.sql.timestamp |
| 08:34:00 | *** yony258 has joined #openmrs |
| 08:34:34 | <adam_l> dkayiwa: java.sql.timestamp is inherits java.util.Date |
| 08:35:08 | <dkayiwa> adam_l: does the comparison fail? or do you get compiler errors? |
| 08:35:33 | <adam_l> dkayiwa: you think it should do the comparsion anyway? |
| 08:35:52 | <adam_l> dkayiwa: no errors. but it's not working |
| 08:36:26 | <dkayiwa> adam_l: does it produce wrong results? |
| 08:36:48 | <adam_l> dkayiwa: yes. |
| 08:37:04 | <dkayiwa> adam_l: you can push and i test it out |
| 08:37:23 | <adam_l> dkayiwa: ok |
| 08:38:23 | <yony258> dkayiwa: Good Morning, I dont want to interrupt, just want to say that Tobin had the same problem as I did yesterday, and If you can look into it that would be great. Have a great day. |
| 08:39:16 | <dkayiwa> yony258: ok. is everything pushed? |
| 08:39:22 | <yony258> dkayiwa: Yea |
| 08:39:31 | <dkayiwa> yony258: ok let me look into it |
| 08:40:17 | <yony258> dkayiwa: ok its not urgent, you can do it when you have time, I dont want to interrupt to what you did before. |
| 08:40:30 | <dkayiwa> yony258: ok |
| 08:51:17 | <yony258> adam_l: You want to go to the class at 12 and than work on the assignment until 14:30? |
| 08:53:05 | <yony258> adam_l: Or we can go a bit earlier, like 11:15 and save a place at the lab and just go back to it when the lecture finish |
| 08:53:42 | <adam_l> yony258: I will go before to eat ok? |
| 08:54:16 | <yony258> adam_l: Ok, so we'll meet at 12:00 at the class? |
| 08:54:40 | <adam_l> yony258: yes |
| 09:00:34 | <yony258> dkayiwa: If you prefer I can just send you my omod file |
| 09:00:45 | <dkayiwa> yony258: ok send that too |
| 09:02:20 | <yony258> dkayiwa: I've sent it to your openmrs email |
| 09:02:26 | <dkayiwa> yony258: ok |
| 09:06:34 | <tobin_g> dkayiwa: yony258 adam_l fyi i'm lurking if anybody has questions for me |
| 09:07:24 | <adam_l> dkayiwa: can you pull? |
| 09:07:28 | <yony258> tobin_g: Let's talk about the details of the selected patient in the Create Appointment Form |
| 09:07:31 | <dkayiwa> adam_l: ok |
| 09:07:47 | <yony258> tobin_g: If you can make a list of details you want to see, and why you need them that can save time |
| 09:08:51 | <tobin_g> yony258: ok give me a minute |
| 09:09:03 | <dkayiwa> yony258: can you remind me of steps to reproduce? |
| 09:09:15 | <yony258> dkayiwa: Yes |
| 09:09:57 | <yony258> dkayiwa: The bad result: Open Create Appointment Form, Press "Find Available Time" -> you should not see any time slots loaded into the table. |
| 09:10:28 | <yony258> dkayiwa: The good result: Open Create Appointment Form, select a start date -> you should see all the time slots in the db loaded into the table. |
| 09:13:46 | <adam_l> yony258: dkayiwa needs the content of the data base to see that right? |
| 09:14:12 | <yony258> adam_l: Yes I think he has it |
| 09:14:45 | <yony258> adam_l: I can paste the queries if anyone wants them |
| 09:15:28 | <dkayiwa> yony258: yony258 why is the first case a bad result? |
| 09:15:37 | <tobin_g> yony258: two things should be displayed for now 1) cell phone number and 2) ID numbers (patients have several ID numbers) |
| 09:15:51 | <dkayiwa> yony258: because you have if (fromDate != null) |
| 09:16:18 | <yony258> dkayiwa: No selected fromDate should result in loading all timeSlots |
| 09:16:36 | <dkayiwa> yony258: but your code does not say so |
| 09:16:50 | <tobin_g> yony258: reason for cell is that it's important we have a reliable way to contact the patient. reason for ID numbers is that we want to make sure we're talking to the right person! |
| 09:16:55 | <yony258> dkayiwa: if the fromDate==null I call that function with fromDate=new Date() |
| 09:17:09 | <yony258> tobin_g: What about "Missed Last Appointment" ? |
| 09:17:27 | <dkayiwa> yony258: spring is the one which calls it not you |
| 09:17:38 | <yony258> dkayiwa: Look at the last function in the controller |
| 09:18:30 | <dkayiwa> yony258: yes spring will call that function first which will results into successive calls for all methods that have @ModelAttribute |
| 09:18:41 | <dkayiwa> yony258: confirm it by running in debug mode |
| 09:18:52 | <yony258> dkayiwa: Can you explain it more? |
| 09:18:54 | <dkayiwa> yony258: and just put a break point in both methods |
| 09:19:22 | <dkayiwa> yony258: you will see that for each POST, spring calls all methods that have @ModelAttribute |
| 09:19:44 | <yony258> dkayiwa: OK thats important and I didn't know that |
| 09:20:21 | <yony258> dkayiwa: So, how can I achieve what I want while not showing any time slots for the first entrance in the form? |
| 09:21:23 | <yony258> dkayiwa: In other words, making those two cases provide the same result, but when a user loads the form it won't show him anything |
| 09:21:23 | <dkayiwa> yony258: what happens when you comment out the @ModelAttribute method for timeslots? |
| 09:21:54 | <yony258> dkayiwa: I dont know, but as far as I remember the timeSlots got lost between calls |
| 09:21:55 | <dkayiwa> yony258: forget the above. would result into more problems |
| 09:21:58 | <tobin_g> yony258: ideally yes, but i want to understand the user story for this a little more before we code it in |
| 09:22:05 | <dkayiwa> yony258: correct |
| 09:22:48 | <dkayiwa> yony258: not very sure of the best way, but can suggest a hacky way |
| 09:22:52 | <yony258> tobin_g: Ok, so let's keep it until you say o.w, ok? |
| 09:23:23 | <tobin_g> yony258: ow? |
| 09:23:26 | <yony258> dkayiwa: Maybe when the findAvailableButton was clicked I should run a js function that assigns current date and time to the fromDate' |
| 09:23:31 | <yony258> tobin_g: otherwise |
| 09:23:53 | <dkayiwa> yony258: i do not want to limit your creativity :) |
| 09:24:04 | <yony258> dkayiwa: Can I do something like that? call the js function before activating the controller? |
| 09:24:08 | <tobin_g> yony258: yeah if you have already coded it we can leave it |
| 09:24:17 | <yony258> tobin_g: cool |
| 09:24:32 | <dkayiwa> yony258: i have not tried it out yet :) |
| 09:26:23 | <yony258> dkayiwa: I can work around it using a js function that than redirects to a url that will activate the controller but it will be ugly |
| 09:26:27 | <yony258> dkayiwa: Other suggestions? |
| 09:26:59 | <adam_l> dkayiwa: anyway if you will be free can you please look into my commit? the problem I think is on the compersion of the dates. |
| 09:27:09 | <adam_l> dkayiwa: In here : https://github.com/openmrs/openmrs-module-appointment/blob/master/api/src/main/java/org/openmrs/module/appointment/api/db/hibernate/HibernateAppointmentBlockDAO.java |
| 09:27:11 | <dkayiwa> adam_l: ok |
| 09:27:13 | <OpenMRSBot> <http://ln-s.net/+GoX> (at github.com) |
| 09:27:53 | <adam_l> dkayiwa: thanks |
| 09:28:02 | <dkayiwa> yony258: you could use request.getSession().getAttribute(name) |
| 09:28:16 | <dkayiwa> yony258: where if its null, then you know its first time |
| 09:28:34 | <dkayiwa> yony258: and the you set it with request.getSession().setAttribute(name) |
| 09:30:49 | <dkayiwa> adam_l: did you run mvn install before committing? |
| 09:32:07 | *** adam_l has quit IRC |
| 09:38:09 | <tobin_g> dkayiwa: adam just texted me to say he did, he got booted off irc and has to go to class |
| 09:38:32 | <tobin_g> dkayiwa: do you see what the problem is? |
| 09:38:39 | <dkayiwa> tobin_g: ok. had some other questions for him. but will wait when he comes back |
| 09:39:22 | <tobin_g> dkayiwa: ok sounds good |
| 09:42:23 | <yony258> dkayiwa: hmm where to do that? |
| 09:42:48 | <dkayiwa> yony258: where you need the logic you are asking for |
| 09:51:17 | <yony258> tobin_g: dkayiwa: Ok thanks heading out to class, talk to you later |
| 09:51:37 | <tobin_g> yony258: k have fun |
| 09:51:50 | <dkayiwa> yony258: see ya |
| 10:14:30 | *** kishoreyekkanti has joined #openmrs |
| 10:42:53 | *** ishara has joined #openmrs |
| 11:03:12 | *** rkorytkowski has joined #openmrs |
| 11:03:12 | *** ChanServ sets mode: +v rkorytkowski |
| 11:03:41 | *** rkorytkowski is now known as rafa |
| 11:17:23 | *** kishoreyekkanti has quit IRC |
| 11:45:12 | *** suranga has joined #openmrs |
| 11:45:12 | *** ChanServ sets mode: +v suranga |
| 11:48:57 | *** shortend has joined #openmrs |
| 11:50:03 | <shortend> Hi there! |
| 11:50:43 | <shortend> Could anyone give me a hand with getting @MODULE_ID@ variables in jsp files filtered into what they're meant to be? |
| 11:50:57 | <shortend> I seem to not understand how this is done. |
| 11:52:02 | <shortend> I thought it was through a <resource> section in the pom file, with <filtering>true</filtering> |
| 11:52:13 | <shortend> But I'm not having much success with that. |
| 12:26:22 | *** travis-ci has joined #openmrs |
| 12:26:22 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [42b055c] [rkorytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3627335 |
| 12:26:22 | *** travis-ci has left #openmrs |
| 12:26:26 | <OpenMRSBot> <http://ln-s.net/+GrJ> (at travis-ci.org) |
| 13:02:34 | *** jkeiper has joined #openmrs |
| 13:02:34 | *** ChanServ sets mode: +v jkeiper |
| 13:03:16 | <suranga> hi rafa :-) |
| 13:03:21 | <rafa> suranga: hi |
| 13:03:24 | <suranga> rafa, it is I. I have returned :P |
| 13:03:32 | <suranga> rafa, can I bug you for a minute please ? |
| 13:03:43 | <rafa> suranga: good to have you back ;) |
| 13:03:44 | <rafa> suranga: sure |
| 13:07:22 | *** kishoreyekkanti has joined #openmrs |
| 13:07:28 | <suranga> its like this. the hl7 query module (as you know) uses groovy. for this, it has a dependency specified in its parent pom. Furthermore, the module works fine under testing. and returned valid results. HOWEVER, when I run the unit tests, a bunch of tests keep failing because "Caused by: java.lang.NoClassDefFoundError: groovy/text/SimpleTemplateEngine" |
| 13:08:12 | <suranga> rafa, ive been messing around with the dependency and the pom, and Im wonderiing if this is an 'only for me' bug, or wether it affects everyone... |
| 13:08:30 | *** jkeiper has quit IRC |
| 13:10:24 | *** nribeka has quit IRC |
| 13:16:22 | <rafa> suranga: how is the groovy dependency declared in your pom? |
| 13:19:09 | <rafa> suranga: actually I can look in github ;) |
| 13:19:20 | <suranga> rafa, it says <dependency> |
| 13:19:21 | <suranga> <groupId>org.codehaus.groovy</groupId> |
| 13:19:21 | <suranga> <artifactId>groovy</artifactId> |
| 13:19:21 | <suranga> <version>1.8.3</version> |
| 13:19:21 | <suranga> <scope>test</scope> |
| 13:19:21 | <suranga> </dependency> in my parent pom |
| 13:20:20 | <rafa> suranga: it's different than what I see on github |
| 13:20:48 | * suranga goes to look... |
| 13:21:55 | <rafa> suranga: you shouldn't be specifying <scope>test</scope> you want the groovy jar included in your omod |
| 13:22:25 | <suranga> rafa, I did try that.. but it didnt change anything, so I left it at default... |
| 13:22:29 | <rafa> suranga: and also it needs to be repeated in api/pom.xml |
| 13:22:50 | <rafa> suranga: I mean without version |
| 13:23:03 | <rafa> suranga: and scope |
| 13:23:23 | <rafa> suranga: how different is your version from the github one? |
| 13:23:39 | <rafa> suranga: can you push changes? |
| 13:24:07 | <suranga> rafa, I will quickly updated my local copy to the latest on github, and re-check... |
| 13:27:35 | <rafa> suranga: ok |
| 13:37:10 | <suranga> hmm... rafa, I did those changes, but the problem seems to persist |
| 13:37:26 | <suranga> rafa, I suspect that its something with my local maven setup (possibly) |
| 13:37:32 | <rafa> suranga: is it just Eclipse or mvn clean install? |
| 13:37:47 | <suranga> rafa, its mvn clean install.. |
| 13:38:00 | <rafa> suranga: then I should be able to reproduce it |
| 13:38:02 | <suranga> rafa, no worries, i'll take a closer look and see what I can find :) |
| 13:38:22 | *** cpower has joined #openmrs |
| 13:38:26 | <rafa> suranga: do you want me to check out the latest hl7 code? |
| 13:38:37 | <suranga> rafa, i suspect that my local maven repo is playing tricks on me. it has been acting strange lately |
| 13:38:55 | <suranga> rafa, oh no, no worries, I'll look at it for some more before I give up :) |
| 13:39:18 | <rafa> suranga: try also mvn dependency:resolve |
| 13:39:28 | <suranga> :) |
| 13:39:30 | <rafa> suranga: see if groovy jar is listed |
| 13:40:03 | <cpower> So here's a question for anyone to answer in the channel. What do you think the Community Developer, Bug Fixer, Core Dev on Duty (whatever name you prefer) should be doing during his two week rotation? |
| 13:40:11 | <rafa> suranga: it should be compile scope |
| 13:40:39 | <rafa> cpower: doing good ;) |
| 13:40:50 | <cpower> hahaha |
| 13:41:06 | <cpower> justice for all, taking out bad guys with a single blow? |
| 13:41:13 | <cpower> ;-) |
| 13:41:14 | <rafa> cpower: right! |
| 13:42:10 | <cpower> Just brainstorming at the moment. They should be working on: Bug tickets, creating new tickets for the Intro tickets, Mentoring new Dev's...what else? |
| 13:42:29 | <rafa> cpower: reviewing and merging pull requests should be a priority |
| 13:42:46 | <cpower> ok, sounds good |
| 13:42:55 | <cpower> keep them coming |
| 13:43:46 | <rafa> spiking on whatever he feels is needed/cool for 20% of time |
| 13:46:00 | <cpower> okay I'll throw it on there and see if it flys, do you (or anyone in the channel) think of anything else? |
| 13:46:52 | <rafa> dkayiwa: any wishes to the Santa? :) |
| 13:52:00 | *** wyclif_ has joined #openmrs |
| 13:55:19 | *** lh has joined #openmrs |
| 13:55:19 | *** lh has joined #openmrs |
| 14:01:39 | *** sgithens has quit IRC |
| 14:12:37 | *** jkeiper has joined #openmrs |
| 14:12:37 | *** ChanServ sets mode: +v jkeiper |
| 14:12:43 | *** kishoreyekkanti has quit IRC |
| 14:13:35 | *** cpower has quit IRC |
| 14:14:11 | *** cpower has joined #openmrs |
| 14:19:03 | *** nribeka has joined #openmrs |
| 14:19:03 | *** ChanServ sets mode: +v nribeka |
| 14:19:50 | *** kishoreyekkanti has joined #openmrs |
| 14:31:09 | *** kishoreyekkanti has quit IRC |
| 14:37:52 | *** suranga has quit IRC |
| 14:39:35 | *** cpower has quit IRC |
| 14:40:51 | *** cpower has joined #openmrs |
| 14:42:13 | *** sgithens has joined #openmrs |
| 14:44:43 | *** thompcha has joined #openmrs |
| 14:46:40 | <thompcha> Hello, can someone help me troubleshoot an issue? |
| 14:59:40 | <jkeiper> thompcha, probably ... just say what the problem is and someone will respond |
| 15:02:10 | *** andrea_ has joined #openmrs |
| 15:03:11 | *** djazayeri has joined #openmrs |
| 15:03:11 | *** ChanServ sets mode: +o djazayeri |
| 15:03:17 | <andrea_> cpower, u there? |
| 15:04:09 | <djazayeri> rafa: is uni call done yet? |
| 15:04:17 | <rafa> djazayeri: yes |
| 15:05:14 | <djazayeri> alright, let's do this then |
| 15:05:18 | <djazayeri> !scrumon djazayeri |
| 15:05:18 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready. |
| 15:05:50 | <djazayeri> today's order: yony258, wyclif_, tobin_g, dkayiwa, andrea_, rafa |
| 15:06:18 | <yony258> * Today: |
| 15:06:21 | <rafa> and djazayeri ;) |
| 15:06:29 | <yony258> * Almost Finished Create Appointment Form |
| 15:06:45 | <jkeiper> i'll chip in at the end |
| 15:06:52 | <yony258> * Tomorrow: Confirmed finish of that form, hopefully will start AM-6 |
| 15:06:57 | <yony258> * Blockers: none |
| 15:07:29 | <djazayeri> tobin_g: anything to say? |
| 15:08:06 | <tobin_g> djazayeri: sorry i wasn't watching come back to me |
| 15:08:17 | <djazayeri> wyclif_: |
| 15:08:43 | <wyclif_> Tuesday: |
| 15:08:43 | <wyclif_> curating tickets |
| 15:08:44 | <wyclif_> Fixed more tests SXS-1 - Fix unit tests in serialization module |
| 15:08:44 | <wyclif_> |
| 15:08:44 | <wyclif_> Wednesday: |
| 15:08:46 | <wyclif_> University call |
| 15:08:48 | <wyclif_> curate tickets |
| 15:08:50 | <wyclif_> design call |
| 15:08:52 | <wyclif_> Pick a sprint ticket |
| 15:08:56 | <wyclif_> |
| 15:08:58 | <wyclif_> Blockers: None |
| 15:09:22 | <djazayeri> dkayiwa: |
| 15:09:48 | <cpower> hello |
| 15:09:59 | <djazayeri> dkayiwa: you there? |
| 15:10:24 | <djazayeri> okay, andrea_ your turn |
| 15:10:42 | <andrea_> Tuesday |
| 15:10:42 | <andrea_> Recover from flu |
| 15:10:43 | <andrea_> Installed everything for OpenMRS on new computer |
| 15:10:43 | <andrea_> Wednesday |
| 15:10:43 | <andrea_> Design call |
| 15:10:43 | <andrea_> Finish work on TRUNK-2768 |
| 15:10:45 | <andrea_> Test Atlas module |
| 15:10:48 | <andrea_> No blockers |
| 15:11:02 | <djazayeri> rafa |
| 15:11:05 | <rafa> Today: |
| 15:11:05 | <rafa> * Corrected the CI config for serialization.xstream |
| 15:11:05 | <rafa> * Reviewed SXS-1: Fix unit tests in serialization module |
| 15:11:05 | <rafa> https://tickets.openmrs.org/browse/SXS-1 |
| 15:11:05 | <rafa> * Sent PR for: TRUNK-3844: Correct BaseOpenmrsObject equals |
| 15:11:06 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3844 |
| 15:11:06 | <rafa> * Committed TRUNK-3845: Short class name in BaseOpenmrsObject toString |
| 15:11:07 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3845 |
| 15:11:07 | <rafa> * Working on META-298: Error when importing package; Failed to parse the expression [${importer.package.dateCreated}] |
| 15:11:08 | <rafa> https://tickets.openmrs.org/browse/META-298 |
| 15:11:08 | <rafa> * Univ call |
| 15:11:09 | <rafa> No blockers. |
| 15:11:59 | <tobin_g> djazayeri: ready |
| 15:12:07 | <djazayeri> go ahead tobin_g |
| 15:12:11 | <tobin_g> yesterday/today: |
| 15:12:12 | <tobin_g> misc testing |
| 15:12:13 | <tobin_g> sorted out CI issue with downey |
| 15:12:15 | <tobin_g> question-answering for appointment sprint |
| 15:12:16 | <tobin_g> tomorrow: |
| 15:12:17 | <tobin_g> sprint wrap-up report |
| 15:12:18 | <tobin_g> dev call |
| 15:12:19 | <tobin_g> blockers: none |
| 15:12:22 | *** dkayiwa has quit IRC |
| 15:12:49 | <djazayeri> Yesterday |
| 15:12:49 | <djazayeri> * Localization work for Mirebalais |
| 15:12:49 | <djazayeri> * Continue working on form entry approaches for Mirebalais |
| 15:12:49 | <djazayeri> * Debugging Kenya EMR issues prior to a release on Friday |
| 15:12:49 | <djazayeri> * Released new UI Framework version for Rowan |
| 15:12:50 | <djazayeri> Today |
| 15:12:51 | <djazayeri> * Calls |
| 15:12:51 | <djazayeri> * Continue working on form entry approaches for Mirebalais |
| 15:12:52 | <djazayeri> * Debugging Kenya EMR issues prior to a release on Friday |
| 15:12:58 | <djazayeri> jkeiper: |
| 15:13:03 | *** afiles has joined #openmrs |
| 15:14:12 | <jkeiper> today: finalizing tickets for REG sprint |
| 15:14:22 | <jkeiper> hope to have a meeting with devs today |
| 15:14:24 | <jkeiper> the end. |
| 15:14:27 | <cpower> *rapid board* cough, cough |
| 15:14:40 | <jkeiper> waiting until the project's mine ;-) |
| 15:15:04 | <cpower> who are you waiting on? |
| 15:15:12 | <djazayeri> no daniel, so that's everyone |
| 15:15:22 | <djazayeri> (anyone out there I missed?) |
| 15:15:40 | <djazayeri> There were no blockers or discussion points |
| 15:15:41 | <djazayeri> !scrumoff |
| 15:15:41 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:15:52 | <djazayeri> cpower: what's the timing of the next sprint? |
| 15:16:34 | <jkeiper> i'm the holdback |
| 15:17:00 | *** sgithens has quit IRC |
| 15:17:01 | <thompcha> Is there a collection of concepts for an AIDS clinic someplace that I cand import? |
| 15:17:24 | <tobin_g> thompcha: it's not specific for aids clinic, but have you considered the mvp dictionary? |
| 15:17:32 | <jkeiper> djazayeri, would love to chat with you today briefly about the sprint |
| 15:17:39 | <djazayeri> thompcha: https://wiki.openmrs.org/x/ww4JAg |
| 15:17:57 | <djazayeri> (that's the MVP/CIEL dictionary â it has HIV content, as well as lots of primary care content) |
| 15:18:03 | <djazayeri> jkeiper: okay |
| 15:18:07 | <djazayeri> when? |
| 15:18:16 | <jkeiper> cpower, MD will give me the power shortly to control REG project, then i can do the tickets and make the board |
| 15:18:19 | <jkeiper> djazayeri, now? |
| 15:18:37 | <djazayeri> okay |
| 15:18:50 | <jkeiper> lemme get skype up |
| 15:19:06 | <thompcha> thanks, djazayeri |
| 15:19:29 | <jkeiper> er g+ |
| 15:20:45 | <thompcha> tobin_g, yes, it doesn't have to be specific |
| 15:20:47 | <cpower> djazayeri, two weeks starting two days ago unless jkeiper wants more time |
| 15:21:15 | *** ibewes has joined #openmrs |
| 15:21:17 | <tobin_g> tobin_g: then check out the link from djazayeri, it's a very good dictionary. |
| 15:21:32 | <tobin_g> thompcha: then check out the link from djazayeri, it's a very good dictionary. |
| 15:22:14 | <tobin_g> thompcha: we didn't end up using it in our implementation because of the organization of it - we wanted things in more specific concept categories so we could use autocompletes based on those categories |
| 15:23:29 | <tobin_g> thompcha: if you decide to build your own, you can consider searching the MVP/CIEL dictionary at www.maternalconceptlab.com |
| 15:23:38 | <tobin_g> thompcha: very useful resource |
| 15:24:23 | <thompcha> thanks |
| 15:24:26 | *** adam_l_ has joined #openmrs |
| 15:24:35 | <tobin_g> thompcha: np |
| 15:26:32 | <adam_l_> tobin_g: sup? :) |
| 15:26:57 | <tobin_g> adam_l_: studying for my family exam :x |
| 15:27:12 | <tobin_g> adam_l_: how you doing? |
| 15:28:18 | <adam_l_> tobin_g: good luck. I'm ok , still got the problem with the dates. |
| 15:28:27 | <tobin_g> :-\ |
| 15:28:32 | <tobin_g> adam_l_: thanks. |
| 15:28:53 | <tobin_g> adam_l_: daniel was here but left a bit ago, let's keep an eye out for him because I know he had some ideas to help |
| 15:29:37 | <adam_l_> tobin_g: ok I hope this will be fixed asap |
| 15:30:08 | <tobin_g> adam_l_: not sure who has time, but you can also ask other developers online. wyclif_ djazayeri rafa are of course very knowledgeable :D |
| 15:31:13 | <wyclif_> hi tobin_g and adam_l_ |
| 15:31:44 | <adam_l_> wyclif_: Hi :) can I ask a question? |
| 15:31:51 | <wyclif_> adam_l_, sure |
| 15:31:54 | <tobin_g> hi wyclif_ thanks~ |
| 15:31:55 | <tobin_g> ! |
| 15:32:49 | <ibewes> howdy folks |
| 15:33:00 | <adam_l_> wyclif_: I have a jsp page with a date time picker. I'm passing the selected date via JavaScript to DWR function |
| 15:33:13 | <ibewes> has there been an update on when the registration sprint will get going? |
| 15:33:33 | <wyclif_> adam_l_, ok and.... |
| 15:33:40 | <adam_l_> wyclif_: I'm passing it as a Date so the bean is converting it to a java.util.Date |
| 15:33:58 | <wyclif_> adam_l_, ok |
| 15:34:06 | <tobin_g> ibewes: ask jkeiper |
| 15:34:21 | <adam_l_> wyclif_: I have a method on Hibernate that compers the Date to a Date in the db |
| 15:34:21 | <ibewes> tobin_g: gotcha... thanks! |
| 15:34:43 | <adam_l_> wyclif_: but those are not the same right? |
| 15:35:30 | <cpower> So I know I should be flogged for this... but I need topics for our design call today. Does anyone have upcoming sprint work that needs to be discussed? |
| 15:35:40 | <adam_l_> wyclif_: hibernates maps to a timestamp and the compersion don't work well. I mean there are no errors but it doesn't work. |
| 15:36:17 | *** yony258 has quit IRC |
| 15:36:40 | <wyclif_> adam_l_, it depends on the what type you are using in your hbm file |
| 15:36:45 | *** yony258 has joined #openmrs |
| 15:37:16 | <djazayeri> adam_l_: look at the OpenmrsUtil.compare method that safely will compare java.util.Date and java.sql.Timestamp |
| 15:37:41 | <wyclif_> adam_l_, what is the type in the hbm file |
| 15:37:55 | <adam_l_> wyclif_: java.util.Date |
| 15:38:03 | <jkeiper> ibewes, hi |
| 15:38:33 | <jkeiper> ibewes, i'm running the registration sprint ... will be kicking off hopefully soon, getting tickets / rapid board ready |
| 15:38:34 | <ibewes> jkeiper: hello there! Hope you're feeling better |
| 15:38:37 | <jkeiper> ibewes, thanks! |
| 15:38:55 | <adam_l_> wyclif_: but as I read it timestamp inherts from java.util.Date then it is a timestamp really |
| 15:38:56 | <jkeiper> ibewes, i'll update the sprint page with a few things to look at while the tickets are rendered |
| 15:38:59 | <djazayeri> adam_l_: see OpenmrsUtil.compare(Date, Date) or OpenmrsUtil.compareWithNullAsEarliest / compareWithNullAsLatest |
| 15:39:07 | <adam_l_> djazayeri: ok |
| 15:39:09 | <jkeiper> ibewes, namely looking at the AMRS Registration Module for insight to teh current process |
| 15:39:09 | <wyclif_> adam_l_, have you seen djazayeri 's comment? use the OpenmrsUtil method that compares dates well |
| 15:39:12 | <jkeiper> :-) |
| 15:39:22 | <ibewes> jkeiper: sounds good... I won't be on too long as it's 6:30PM here |
| 15:39:38 | <jkeiper> ibewes, ahHh! |
| 15:39:51 | <adam_l_> wyclif_: I want to use "criteria.add(Restrictions.ge("startDate", fromDate));" |
| 15:40:00 | <jkeiper> ibewes, in that case ... take a look at https://github.com/AMPATH/openmrs-module-amrsregistration |
| 15:40:06 | <OpenMRSBot> <http://ln-s.net/+Gv0> (at github.com) |
| 15:40:12 | <jkeiper> you can build it and install on a local instance |
| 15:40:30 | <jkeiper> ibewes, take a look at how the registration process happens, how search results appear and what we do with them |
| 15:40:32 | <wyclif_> adam_l_, do you mean that restriction is failing |
| 15:40:39 | <ibewes> jkeiper: ok, will do |
| 15:41:10 | *** rafa has quit IRC |
| 15:41:35 | <adam_l_> wyclif_: not failing. it's not working right |
| 15:42:08 | *** dkayiwa has joined #openmrs |
| 15:42:24 | <jkeiper> ibewes, thanks!!! |
| 15:42:31 | <jkeiper> ibewes, where are you located, kenya? |
| 15:42:43 | <wyclif_> can you do some debugging and make sure that the date value you passed in is actually what is getting used at that line also make sure it is of the type that is in the mapping file |
| 15:42:56 | <ibewes> jkeiper: yup, in Nairobi |
| 15:42:57 | <wyclif_> adam_l_, can you do some debugging and make sure that the date value you passed in is actually what is getting used at that line also make sure it is of the type that is in the mapping file |
| 15:43:10 | <jkeiper> ibewes, ah cool ... asante sana |
| 15:43:17 | <jkeiper> ibewes, look forward to our work together |
| 15:43:18 | <jkeiper> :-D |
| 15:43:34 | <jkeiper> ibewes, surprised you are not out celebrating! |
| 15:44:19 | <ibewes> jkeiper: hehe... karibu! |
| 15:44:46 | <adam_l_> wyclif_: what I found out is if i do dateFromJavaScript.toString() it is not that in the same format is dateFromHIbername.toString(). |
| 15:44:54 | <jkeiper> dkayiwa, wyclif_ ... who is on the sprint this week? rafal? |
| 15:45:18 | <adam_l_> what I found out is if i do dateFromJavaScript.toString() it is not n the same format as dateFromHIbername.toString(). |
| 15:45:44 | <djazayeri> adam_l_: can you take a step back and explain to wyclif_ what you're trying to do in the first place? |
| 15:45:57 | <adam_l_> djazayeri: sure |
| 15:46:01 | <djazayeri> gotta run |
| 15:47:56 | <adam_l_> wyclif_: I have a jsp with a date time picker. I want to display Appointment Blocks that are in the same DAY as the selcted date. |
| 15:48:12 | <wyclif_> adam_l_, ok |
| 15:49:39 | <wyclif_> adam_l_, your code for the jsp, service and dao methods on pastebin |
| 15:49:50 | <wyclif_> adam_l_, can you share your code for the jsp, service and dao methods on pastebin |
| 15:50:20 | <adam_l_> wyclif_: sure |
| 15:51:28 | <adam_l_> wyclif_: DAO : http://pastebin.com/SbLwE81N |
| 15:52:17 | <adam_l_> wyclif_: DWR SERVICE : http://pastebin.com/AnYTSNmV |
| 15:53:21 | <adam_l_> wyclif_: JSP : http://pastebin.com/7usxpPBX |
| 15:54:27 | <wyclif_> adam_l_, service method? |
| 15:54:29 | <yony258> dkayiwa: The all idea of the availableTimes list we did is incorrect. :/ |
| 15:55:00 | <dkayiwa> yony258: why? :) |
| 15:55:05 | <ibewes> jkeiper: is the current version compilable? I'm getting an error that org.openmrs.module.amrsregistration.extension.html.AdminList is missing |
| 15:55:16 | <jkeiper> oy |
| 15:55:23 | <jkeiper> did you mvn clean install? |
| 15:55:29 | <jkeiper> ibewes, i ran it on 1.8.x |
| 15:55:34 | <yony258> dkayiwa: I dont see any way that it will fix the current issue, do you see any fix for it? |
| 15:55:49 | <jkeiper> ibewes, that code is in the omod module |
| 15:56:03 | <yony258> dkayiwa: Changing it into a session attribute is just not correct, its not needed for the whole session |
| 15:56:12 | <ibewes> jkeiper: oh... looks like there is a test in the api project that is referencing that... can you do circular references? |
| 15:56:42 | <jkeiper> there is? haha ... shouldn't be. strange. |
| 15:56:49 | <jkeiper> idk how it compiles on my machine :| |
| 15:56:55 | <jkeiper> ibewes, sure that test isn't being ignored? |
| 15:57:00 | <wyclif_> adam_l_, i think creating a date instance from javascript might not be good thing |
| 15:57:42 | <dkayiwa> yony258: correct |
| 15:57:43 | <ibewes> jkeiper: org.openmrs.module.amrsregistration.test.AdminListExtensionTest is the test that won't compile |
| 15:57:54 | <adam_l_> wyclif_: service : http://pastebin.com/PQDSjexC |
| 15:58:09 | <ibewes> jkeiper: I am skipping the tests (-DskipTests) but the fact that it won't compile is hanging it up |
| 15:58:13 | <yony258> dkayiwa: Im trying to do a small trick to manage around this issue |
| 15:58:14 | <jkeiper> it is fair to get rid of it |
| 15:58:15 | <jkeiper> hmm |
| 15:58:19 | <jkeiper> ibewes, one moment please :-D |
| 15:58:19 | <adam_l_> wyclif_: ok so I should create it after? in the DWR function for example? |
| 15:58:38 | <jkeiper> ibewes, i'll check it out here |
| 15:58:40 | <jkeiper> see what's up |
| 15:59:00 | <adam_l_> wyclif_: you mean pass it as a string and then use that string to create the Date. |
| 15:59:23 | <wyclif_> adam_l_, in core forms that use a date field typically submit dates as a string and let the DateOrDatetimeEditor property editor convert the date for you magically using Context.getDateTimeFormat.parse |
| 16:00:38 | <wyclif_> adam_l_, the problem is that DWR doesnt use spring as search so that property editor won't work for you but you can copy the code in ti and use that in your DWR method to parse the date string the same way |
| 16:01:12 | <wyclif_> adam_l_, does that make sense? |
| 16:02:06 | <adam_l_> wyclif_:Context is unvailable in DWR ? |
| 16:02:20 | <wyclif_> adam_l_, yes it is |
| 16:02:34 | <wyclif_> in DWRServices |
| 16:03:49 | <adam_l_> wyclif_: what do you mean by property editor? the Context.getDateTimeFormat.parse? |
| 16:05:30 | <jkeiper> ibewes, found it, fixing it |
| 16:05:31 | <jkeiper> heh |
| 16:05:45 | <ibewes> jkeiper: thanks! |
| 16:05:57 | <yony258> dkayiwa: Ok so I can say that I have no idea how to fix it. |
| 16:06:17 | <wyclif_> adam_l_, in spring property editors or converts are used to serialize/deserialize values of compound objects |
| 16:06:37 | <jkeiper> ibewes, ok, go ahead and pull |
| 16:06:42 | <jkeiper> should compile now |
| 16:06:43 | <jkeiper> :-D |
| 16:06:46 | <jkeiper> somehow i wasn't cleaning first |
| 16:06:48 | <jkeiper> old code |
| 16:06:54 | <jkeiper> stuck around |
| 16:07:01 | <dkayiwa> yony258: let me think about it |
| 16:07:06 | <adam_l_> wyclif_: ok |
| 16:07:21 | <wyclif_> adam_l_, e.d a form field that allows concept as values, you can need to set the conceptId ad the value, so a property editor will know how to look up a concept by id and display an concept as a id for spring binding to work |
| 16:07:59 | <yony258> dkayiwa: I just dont think this is a ModelAttribute, because we need to change it over and over according to the user input and it doesn't seem to fit the meaning of a model attribute |
| 16:08:01 | <wyclif_> adam_l_, sorry about the typos |
| 16:08:08 | <ibewes> jkeiper: building fine now... thanks! |
| 16:08:15 | <jkeiper> np |
| 16:08:17 | <jkeiper> :-D |
| 16:08:20 | <dkayiwa> yony258: ok |
| 16:08:28 | <yony258> dkayiwa: Am I wrong? |
| 16:09:01 | <wyclif_> adam_l_, what am trying to say is that i think creating date objects is javascript is not good because it is might be compartible with your server side code date format |
| 16:09:15 | <dkayiwa> yony258: i cannot say that you are wrong :) |
| 16:09:49 | <adam_l_> wyclif_: OK and how do you think I should do it? |
| 16:10:09 | <adam_l_> wyclif_: I will create them in my DWR method? |
| 16:10:27 | <yony258> dkayiwa: I mean, the ModelAttribute looks like something we want to load in advance that will be kept between calls and will be shown / assigned properties to, using the form. |
| 16:10:41 | <yony258> dkayiwa: For example: ProvidersList, appointment |
| 16:11:03 | <adam_l_> wyclif_: I depends on my DAO method with uses creteria restrictions. do you see a problem with that? |
| 16:11:17 | <yony258> dkayiwa: But what we need, is an object that will be swapped according to the selections in the form, and will be kept between calls. |
| 16:11:29 | <dkayiwa> yony258: ok |
| 16:12:15 | <yony258> dkayiwa: That is as good as I can describe the main problem. |
| 16:12:39 | <wyclif_> adam_l_, if you look at timepicker.js, you will see that we tell it what a jsTimeFormat to use and that is the date format it uses to when submitting that date and our DateOrTimeEditor will assume the same format to parse it into a date object, but when you parse it from js then we can't guarantee what format it prints it out when posting it via ajax |
| 16:12:39 | <adam_l_> wyclif_: sorry I don't much exprience so I'm just trying things out. |
| 16:12:49 | *** sgithens has joined #openmrs |
| 16:12:58 | <dkayiwa> yony258: yes it is |
| 16:14:05 | <adam_l_> wyclif_: crystal clear now :) thanks |
| 16:15:25 | <wyclif_> adam_l_, that is fine, so you get point, just post that date as string and do the parsing from the DWR method, you borrow the code in DateOrDatetimeEditor.setAsText(String asString) |
| 16:15:47 | <wyclif_> adam_l_, again sorry about the typos |
| 16:16:47 | <adam_l_> wyclif_: it's ok :) thanks you helped me alot! I will try it out. |
| 16:18:03 | <wyclif_> adam_l_, you can omit the logic in the catch clause since you know you are using a time picker and not a date picker |
| 16:19:51 | *** lh has quit IRC |
| 16:20:13 | <adam_l_> wyclif_: ok |
| 16:21:36 | <yony258> dkayiwa: Maybe we can add a property to the controller class? |
| 16:22:53 | *** yony258_ has joined #openmrs |
| 16:22:55 | <dkayiwa> yony258: wouldn't that be shared by multiple users? |
| 16:25:01 | <yony258_> dkayiwa: Yea yea I wrote "nvm forget about it" but apparently I got disconnected, |
| 16:25:14 | *** rfriedman has joined #openmrs |
| 16:25:33 | <rfriedman> dkayiwa, hey daniel |
| 16:25:40 | <dkayiwa> rfriedman: hey |
| 16:25:52 | *** yony258 has quit IRC |
| 16:26:02 | *** yony258_ is now known as yony258 |
| 16:26:09 | <rfriedman> dkayiwa, do you know how UserProperties get set? I couldn't find a spot on the admin page |
| 16:27:34 | <dkayiwa> rfriedman: do you mean? user.setUserProperties() |
| 16:28:36 | <rfriedman> is that an API call? |
| 16:29:28 | <dkayiwa> rfriedman: it is set as a property on the User object |
| 16:29:46 | <dkayiwa> rfriedman: and then it is the user object that is passing in the saving API |
| 16:30:19 | <rfriedman> dkayiwa, probably, but it's a separate table ... doesn't follow any of our usual property patterns, doesn't have auditinfo |
| 16:30:39 | <dkayiwa> rfriedman: correct |
| 16:31:04 | <rfriedman> dkayiwa, you'd expect to find it under Manage Users |
| 16:31:50 | <dkayiwa> rfriedman: do you mean the page where user properties are set? |
| 16:32:47 | <rfriedman> dkayiwa, this page: http://localhost:8080/openmrs/admin/users/users.list |
| 16:33:14 | *** cpower has quit IRC |
| 16:33:34 | <ibewes> jkeiper: I've got to run but I'll check the spring page tomorrow morning (local time) and start working on anything you assign |
| 16:33:46 | <rfriedman> dkayiwa, ok, i see it now, it's under advanced options |
| 16:33:54 | <ibewes> jkeiper: is this the spring page? https://wiki.openmrs.org/display/RES/Registration+Module |
| 16:34:11 | <dkayiwa> rfriedman: how about? http://demo.openmrs.org/openmrs/options.form |
| 16:34:28 | <yony258> dkayiwa: Sorry for interrupting, just wanted to say that SessionAttribute works, but its not a good way to do that I think |
| 16:34:43 | <dkayiwa> yony258: i fully agree with you on that |
| 16:35:07 | <yony258> dkayiwa: If we could remove that attribute when its not relevant anymore that was good? |
| 16:35:29 | <dkayiwa> yony258: yes we need to remove it |
| 16:35:30 | *** applecool has joined #openmrs |
| 16:35:30 | *** ChanServ sets mode: +v applecool |
| 16:36:07 | <yony258> dkayiwa: Its not a problem to remove it when the appointment was saved correctly, the problem is when the user leaves unexpectedly, like navigating to a different page |
| 16:36:43 | <dkayiwa> yony258: correct. so lets remove the session attribute |
| 16:37:01 | <yony258> dkayiwa: But how do you know when to remove? |
| 16:37:14 | <dkayiwa> yony258: as in lets just not use it at all |
| 16:37:35 | <yony258> dkayiwa: Oh ok, so whats the alternative? :) |
| 16:37:44 | <rfriedman> dkayiwa, how do you get there? you can see at least some under Settings>General Settings but there's no way to add a new one |
| 16:38:30 | <dkayiwa> yony258: may be a hidden field in the form, which we pass in the method as a @RequestParam |
| 16:38:55 | <dkayiwa> rfriedman: how do you get where? |
| 16:38:56 | *** ibewes has quit IRC |
| 16:39:04 | <rfriedman> options.form |
| 16:39:18 | <dkayiwa> rfriedman: My Profile |
| 16:39:28 | <dkayiwa> rfriedman: top right hand side |
| 16:39:31 | <yony258> dkayiwa: You lost me there... How do we access it using the <c:forEach then? |
| 16:39:41 | <jkeiper> oops |
| 16:39:47 | <dkayiwa> :) |
| 16:40:21 | <jkeiper> dkayiwa, do you know who is destined for the ever-evasive registration sprint? |
| 16:40:44 | <dkayiwa> jkeiper: as a developer or user? :) |
| 16:40:44 | <rfriedman> jkeiper, nobody registered for it because the module wasn't working |
| 16:40:56 | <jkeiper> dkayiwa, dev |
| 16:41:00 | <jkeiper> rfriedman, it doesn't exist yet |
| 16:41:08 | <dkayiwa> jkeiper: am one of them :) |
| 16:41:23 | <jkeiper> dkayiwa, ok ... not sure if rafal or wyclif_ is meant for it but i think wyclif_ is |
| 16:41:54 | <dkayiwa> jkeiper: possibly |
| 16:41:55 | <rfriedman> dkayiwa, is willing to do anything to get off bug fixing |
| 16:41:56 | <jkeiper> dkayiwa, i'm wrangling control of the REG project from Saptarshi (he is fine with it) ... just need downey to set me up as an admin |
| 16:42:08 | <dkayiwa> jkeiper: ok |
| 16:42:14 | <jkeiper> meanwhile, i'll get you guys something to chew on until the tickets are ready |
| 16:42:23 | <jkeiper> dkayiwa, but it will be simple |
| 16:42:34 | *** kavuri has joined #openmrs |
| 16:42:35 | <dkayiwa> jkeiper: we can try the hard ones too :) |
| 16:43:35 | <jkeiper> ok hehe |
| 16:44:09 | <dkayiwa> jkeiper: but you do not have to be in a hurry |
| 16:44:36 | <dkayiwa> jkeiper: i still have alot to do with Tobin's Team regarding the appointment module :) |
| 16:44:55 | <dkayiwa> yony258: let me try out what i think and then share it with you. ok? |
| 16:44:57 | <jkeiper> dkayiwa, the idea is to create a core API and minimal UI to build on with other modules ... so the concepts will be simple, implementation can be as difficult as you like |
| 16:44:58 | <jkeiper> :-D |
| 16:45:23 | *** sgithens has quit IRC |
| 16:45:33 | *** shortend has quit IRC |
| 16:45:36 | <yony258> dkayiwa: ok |
| 16:45:48 | <rfriedman> djazayeri, you really there? |
| 16:46:05 | <dkayiwa> jkeiper: thats too simple to understand :D |
| 16:46:08 | <djazayeri> rfriedman: on a call |
| 16:46:18 | <dkayiwa> jkeiper: or too general :) |
| 16:46:25 | <rfriedman> djazayeri, ok, when i can check back? |
| 16:46:32 | <jkeiper> dkayiwa, i'll try to complicate it then |
| 16:46:37 | <djazayeri> rfriedman: to be safe, 4pm eastern |
| 16:46:47 | <djazayeri> rfriedman: maybe in 30 |
| 16:46:56 | <dkayiwa> jkeiper: in a ticket :) |
| 16:47:08 | <rfriedman> djazayeri, i'll post on the list |
| 16:47:22 | <dkayiwa> jkeiper: that way i will buy some time while doing something else :) |
| 16:47:40 | *** rafa has joined #openmrs |
| 16:47:40 | *** ChanServ sets mode: +v rafa |
| 16:50:59 | <jkeiper> dkayiwa, no worries ... i just feel bad having it on my list and not being done yet :-) |
| 16:51:59 | <dkayiwa> jkeiper: do not worry, you are just recovering from feeling unwell. so do not make yourself feel bad. :) |
| 16:54:43 | *** yony258 has quit IRC |
| 16:57:40 | *** yony258 has joined #openmrs |
| 16:57:50 | *** lh has joined #openmrs |
| 16:57:50 | *** lh has joined #openmrs |
| 16:58:36 | <yony258> dkayiwa: Sorry had a DC |
| 16:58:45 | <dkayiwa> yony258: no problem |
| 17:00:30 | <dkayiwa> hi yony258 |
| 17:00:40 | <yony258> dkayiwa: hi |
| 17:00:48 | <dkayiwa> yony258: how about using @RequestParam(value = "findAvailableTime", required = false) |
| 17:01:01 | <dkayiwa> yony258: in getAppointmentTypeList |
| 17:01:27 | <yony258> dkayiwa: Can not change the value of the model attribute. |
| 17:01:39 | <dkayiwa> yony258: meaning? |
| 17:02:06 | <yony258> dkayiwa: Does it work for you? |
| 17:02:19 | *** andrea_ has quit IRC |
| 17:02:40 | <dkayiwa> yony258: sorry i meant for getAvailableTimes |
| 17:03:35 | <dkayiwa> yony258: i mean adding to the getAvailableTimes() method this parameter: @RequestParam(value = "findAvailableTime", required = false) String findAvailableTime |
| 17:04:02 | <yony258> dkayiwa: ok, do you think this will solve the problem? have you had the chance to try that? |
| 17:04:18 | <dkayiwa> yony258: i have not tied it out :) |
| 17:04:39 | <yony258> dkayiwa: Why do you think that will work? |
| 17:04:49 | <yony258> dkayiwa: :) |
| 17:05:05 | <dkayiwa> yony258: because frirst time, findAvailableTime will be null :) |
| 17:05:17 | <yony258> dkayiwa: I mean, as far as I understood, @ModelAttribute annotation binds the returned value to the model |
| 17:05:27 | <dkayiwa> yony258: when the Find Times slots button is clicked, it will not be null |
| 17:05:50 | <yony258> dkayiwa: That sounds good |
| 17:05:55 | <yony258> dkayiwa: Let me try that |
| 17:05:59 | <dkayiwa> yony258: you have many model data points |
| 17:06:13 | <yony258> dkayiwa: I have no clue what is a model data point :D |
| 17:06:41 | <dkayiwa> yony258: e.g appointment, providerList, appointmentTypeList, availableTimes |
| 17:09:02 | *** lh has quit IRC |
| 17:10:27 | *** yony258 has quit IRC |
| 17:10:34 | *** yony258_ has joined #openmrs |
| 17:10:45 | <yony258_> dkayiwa: Sorry DC again |
| 17:10:57 | <yony258_> dkayiwa: Did you mean something like this? http://pastebin.com/g1PVzBwx |
| 17:11:38 | <dkayiwa> yony258_: no |
| 17:11:48 | <yony258_> dkayiwa: Good because thats not working :) |
| 17:11:54 | <yony258_> dkayiwa: So you can you say again? |
| 17:12:09 | <yony258_> *without the first you |
| 17:12:16 | <dkayiwa> dkayiwa: yony258: i mean adding to the getAvailableTimes() method this parameter: @RequestParam(value = "findAvailableTime", required = false) String findAvailableTime |
| 17:12:41 | <yony258_> dkayiwa: Oh you mean the button! |
| 17:16:27 | <yony258_> dkayiwa: You meant this? http://pastebin.com/g1PVzBwx |
| 17:17:00 | <dkayiwa> yony258_: perfect |
| 17:17:08 | <yony258_> dkayiwa: Doesn't work :/ |
| 17:17:21 | <yony258_> dkayiwa: Loads the time slot on page load |
| 17:17:45 | *** yony258_ is now known as yony258 |
| 17:17:52 | <yony258> dkayiwa: Want the full JSP? |
| 17:18:00 | <dkayiwa> yony258: can you check for both null and empty string? |
| 17:18:13 | <dkayiwa> yony258: whats the value for findAvailableTime? |
| 17:18:22 | <dkayiwa> yony258: that is if you run it in debug mode? |
| 17:18:35 | <yony258> dkayiwa: Actually it was null for the first time, but apparently it got called again |
| 17:18:54 | <dkayiwa> yony258: let me try it out here |
| 17:19:35 | <dkayiwa> yony258: gets called twice on page load? |
| 17:19:44 | <yony258> dkayiwa: Yes |
| 17:21:23 | <dkayiwa> yony258: and for the second time, what value has findAvailableTime got? |
| 17:21:40 | <dkayiwa> yony258: that is during page load |
| 17:22:09 | <yony258> dkayiwa: Thats what im trying to debug right now |
| 17:24:14 | <dkayiwa> yony258: you do not need the onFindTimesClick method |
| 17:27:49 | <yony258> dkayiwa: Its loading the time slots on page load |
| 17:28:06 | <yony258> dkayiwa: I dont know why, let me pastebin the controller |
| 17:28:10 | <dkayiwa> yony258: it does not do that on mine |
| 17:28:26 | <dkayiwa> yony258: have you cleared the cache |
| 17:28:58 | <yony258> dkayiwa: Yes but I will again just to confirm |
| 17:30:15 | <yony258> dkayiwa: Controller: http://pastebin.com/41BxcDGz |
| 17:34:05 | <dkayiwa> yony258: looks fine. whats the actual value for your findAvailableTime during page load? |
| 17:34:24 | <yony258> dkayiwa: First time null, couldn't find a second call |
| 17:34:38 | <dkayiwa> yony258: and you put a break point in it? |
| 17:34:55 | <dkayiwa> yony258: returns null and yet you find yourself with time slots on page load? |
| 17:35:07 | <yony258> dkayiwa: Yes I can't explain it |
| 17:35:12 | <dkayiwa> yony258: in that case push whatever you have and i look at it here |
| 17:35:21 | *** suranga has joined #openmrs |
| 17:35:21 | *** ChanServ sets mode: +v suranga |
| 17:35:21 | <yony258> dkayiwa: Let me try another browser |
| 17:36:02 | <yony258> dkayiwa: Works on firefox :/ |
| 17:36:22 | <dkayiwa> yony258: i knew it had to be your chrome catching :) |
| 17:36:47 | <yony258> dkayiwa: I cleared my cache like 3 times |
| 17:37:07 | <dkayiwa> yony258: ok |
| 17:37:19 | <yony258> dkayiwa: Now lets check if it can change its value too :P |
| 17:38:13 | <adam_l_> dkayiwa: The date is working now. what I did is create the Date object in DWR method using Context.getDateTimeFormat().parse() instead of creating it in JavaScript. |
| 17:38:30 | <dkayiwa> adam_l_: ok great!!! |
| 17:39:59 | <yony258> dkayiwa: Looks like problem solved ;) |
| 17:40:10 | <dkayiwa> yony258: ok good. |
| 17:40:28 | *** prolificgnosis has joined #openmrs |
| 17:40:48 | <prolificgnosis> is there any built in functionality for making a field required? |
| 17:42:02 | *** yony258_ has joined #openmrs |
| 17:42:09 | <dkayiwa> prolificgnosis: not any that am aware of |
| 17:42:09 | <yony258_> dkayiwa: Too quick, I found an issue ! |
| 17:42:16 | *** lh has joined #openmrs |
| 17:42:16 | *** lh has joined #openmrs |
| 17:42:17 | <dkayiwa> yony258_: aha |
| 17:42:35 | <yony258_> dkayiwa: Try: Open form, load time slots, click save |
| 17:42:42 | <prolificgnosis> seems like HTMLFOrm entry shoudl have something |
| 17:43:09 | <dkayiwa> yony258_: ok |
| 17:44:12 | *** yony258 has quit IRC |
| 17:45:28 | *** yony258_ is now known as yony285 |
| 17:45:32 | *** yony285 is now known as yony258 |
| 17:45:47 | <yony258> dkayiwa: Though I can get around it if I check for "save" in the parameter |
| 17:46:03 | <dkayiwa> yony258: yes that should work |
| 17:51:42 | <dkayiwa> hi suranga |
| 17:52:03 | <dkayiwa> hi OpenMRSBot |
| 17:55:25 | <dkayiwa> hi adam_l_ |
| 18:00:22 | *** thompcha has left #openmrs |
| 18:00:25 | *** thompcha has joined #openmrs |
| 18:02:19 | *** dkayiwa has quit IRC |
| 18:04:15 | *** rafa has quit IRC |
| 18:04:45 | *** shortend has joined #openmrs |
| 18:07:53 | *** nribeka has quit IRC |
| 18:10:18 | *** jkeiper has quit IRC |
| 18:25:36 | *** ishara has quit IRC |
| 18:27:57 | *** dkayiwa has joined #openmrs |
| 18:29:23 | *** yony258_ has joined #openmrs |
| 18:29:35 | <yony258_> dkayiwa: I have a very small question :) |
| 18:29:50 | <yony258_> dkayiwa: I want to do @RequestParam(...) Provider provider |
| 18:29:59 | <yony258_> dkayiwa: Do I need to write a "ProviderEditor" ? |
| 18:31:04 | <dkayiwa> yony258_: no |
| 18:31:18 | <yony258_> dkayiwa: So from where do I get one? |
| 18:31:31 | <yony258_> *From where can I get one |
| 18:31:33 | <dkayiwa> yony258_: its part of core |
| 18:32:27 | <yony258_> dkayiwa: Failed to convert value of type java.lang.String to required type 'org.openmrs.Provider' |
| 18:32:36 | <yony258_> dkayiwa: @RequestParam(value = "providerSelect", required = false) Provider provider, |
| 18:32:41 | <dkayiwa> yony258_: oh |
| 18:34:19 | <dkayiwa> yony258_: binder.registerCustomEditor(Provider.class, new ProviderEditor()); |
| 18:34:23 | <dkayiwa> yony258_: add that |
| 18:35:53 | *** yony258 has quit IRC |
| 18:36:18 | <yony258_> dkayiwa: What import do I need to add? (It doesn't locates one) |
| 18:36:22 | *** yony258_ is now known as yony258 |
| 18:37:13 | <dkayiwa> yony258: do ctrl + shift + O |
| 18:37:41 | <yony258> dkayiwa: It can't find it |
| 18:37:53 | <yony258> dkayiwa: I tried import org.openmrs.propertyeditor.ProviderEditor; |
| 18:37:59 | <yony258> dkayiwa: Still does not work. |
| 18:38:11 | <yony258> dkayiwa: http://resources.openmrs.org/doc/org/openmrs/propertyeditor/ProviderEditor.html |
| 18:38:39 | <yony258> dkayiwa: Since: 1.10.0 ?? |
| 18:38:40 | <dkayiwa> yony258: try do an eclipse project clean |
| 18:38:52 | <dkayiwa> yony258: oh you got it |
| 18:39:10 | <dkayiwa> yony258: so just copy it to the module |
| 18:39:13 | <yony258> dkayiwa: No I didn't, what? :) |
| 18:39:24 | <yony258> dkayiwa: What to copy, and to where |
| 18:39:45 | <dkayiwa> yony258: copy the editor |
| 18:40:25 | <yony258> dkayiwa: I tried adding "import org.openmrs.propertyeditor.ProviderEditor;" it does not work. |
| 18:40:48 | <dkayiwa> yony258: copy the class into the module |
| 18:40:55 | *** kavuri has quit IRC |
| 18:40:59 | <yony258> dkayiwa: to where? |
| 18:41:32 | <dkayiwa> yony258: where you have the timeslot editor |
| 18:41:57 | <yony258> dkayiwa: Oh I see, it wasn't released yet? it will only be available from 1.10.0 ? |
| 18:42:13 | <dkayiwa> yony258: you got it :) |
| 18:42:18 | <yony258> dkayiwa: cool, thank you |
| 18:43:53 | *** jkeiper has joined #openmrs |
| 18:43:53 | *** ChanServ sets mode: +v jkeiper |
| 18:51:17 | *** adam_l_ has quit IRC |
| 18:54:35 | <yony258> dkayiwa: Another small question |
| 18:54:38 | <yony258> dkayiwa: :) |
| 18:55:26 | <yony258> dkayiwa: Can I do in HQL something similar to "WHERE <attribute> = * ", |
| 18:56:09 | *** rafa has joined #openmrs |
| 18:56:09 | *** ChanServ sets mode: +v rafa |
| 19:03:04 | <dkayiwa> yony258: which query is that |
| 19:03:41 | <yony258> dkayiwa: Nevermind the first question, I have a different one |
| 19:04:40 | <yony258> dkayiwa: I want to get all time slots that are in an appointment block that it's types (List<AppointmentType>) contain a given AppointmentType. ok? |
| 19:05:21 | <dkayiwa> yony258: ok |
| 19:05:40 | <yony258> dkayiwa: Can I do that in HQL query? (Restrictions) ? |
| 19:05:58 | <dkayiwa> yony258: can you start by writing a unit test for it? |
| 19:06:20 | <yony258> dkayiwa: Can I ask why? |
| 19:09:36 | <dkayiwa> yony258: TDD |
| 19:09:48 | <dkayiwa> yony258: http://www.agiledata.org/essays/tdd.html |
| 19:10:24 | <yony258> dkayiwa: Thank you for that :D |
| 19:13:31 | *** thompcha has quit IRC |
| 19:31:45 | <yony258> dkayiwa: What do I do if the test has too many cases to test? |
| 19:34:35 | *** dkayiwa_ has joined #openmrs |
| 19:35:11 | <yony258> dkayiwa: I think that I'll leave this function for later after I'll finish all the other stuff for this form |
| 19:35:17 | *** dkayiwa has quit IRC |
| 19:35:17 | <dkayiwa_> yony258: each test should focus on some thing not many things |
| 19:35:18 | *** dkayiwa_ is now known as dkayiwa |
| 19:35:32 | <yony258> dkayiwa: I think that I'll leave this function for later after I'll finish all the other stuff for this form |
| 19:35:39 | <dkayiwa> yony258: ok |
| 19:35:55 | <dkayiwa> yony258: many cases means multiple tests |
| 19:36:21 | <yony258> dkayiwa: Dont have the concentration to do this right now, and I need to take into consideration a lot of stuff |
| 19:36:33 | <dkayiwa> yony258: ok |
| 19:36:41 | <yony258> dkayiwa: voided blocks, voided time slots, remaining time in slot, etc.. |
| 19:37:38 | <dkayiwa> yony258: ok |
| 19:59:30 | *** wyclif_ has quit IRC |
| 19:59:48 | *** wyclif_ has joined #openmrs |
| 20:02:27 | *** applecool has quit IRC |
| 20:26:36 | <yony258> dkayiwa: Is it important that I change the patient details to a template? |
| 20:26:59 | <dkayiwa> yony258: which template |
| 20:27:40 | <yony258> dkayiwa: jquery template |
| 20:27:52 | <dkayiwa> yony258: why |
| 20:28:08 | <yony258> dkayiwa: Im trying to do that but having problems |
| 20:31:51 | *** afiles has quit IRC |
| 20:39:48 | *** jblaya has joined #openmrs |
| 20:43:48 | <yony258> dkayiwa: If you have time to help me with the underscore template let me know :) |
| 20:44:34 | <dkayiwa> yony258: what does underscore template mean? :) |
| 20:45:45 | <yony258> dkayiwa: Darius suggested I should use it, the idea is that instead of doing innerHtml = some string, you build a template that gets values. |
| 20:46:09 | <dkayiwa> yony258: never used it |
| 20:46:16 | <yony258> dkayiwa: ok :) |
| 20:46:17 | <djazayeri> yony258: the point is to avoid having to do string concatenation in javascript to build your html |
| 20:46:29 | <djazayeri> yony258: just saying innerHtml = someString is fine |
| 20:46:47 | <djazayeri> yony258: saying innerHtml = "<div>" + something + somethingElse + ... |
| 20:46:57 | <yony258> djazayeri: Yes thats what im doing :/ |
| 20:47:24 | <yony258> djazayeri: djazayeri: I dont want to waste your time, I did something using underscore templates and would love to get your help on this just let me know if you have time :) |
| 20:48:13 | <yony258> dkayiwa: This is the only aspect I wanted to change before submitting this form for review :] |
| 20:48:30 | <dkayiwa> yony258: ok :) |
| 20:48:33 | <djazayeri> yony258: if you can send me a pointer to the code I can look very quickly |
| 20:48:43 | <yony258> djazayeri: Let me pastebin |
| 20:49:31 | <yony258> djazayeri: http://pastebin.com/xY42p1Ce |
| 20:49:38 | <yony258> djazayeri: Thanks in advance :) |
| 20:49:57 | <djazayeri> yony258: okay, on a call for the next 10 minutes |
| 20:50:06 | <djazayeri> will look afterwards |
| 20:50:14 | *** rfriedman has quit IRC |
| 20:52:20 | <yony258> dkayiwa: Let me push the code without the template, so that you could review it as soon as you have time :) |
| 20:52:41 | <dkayiwa> yony258: ok :) |
| 20:59:16 | <yony258> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/970921f1fed84c0d6da48e20d99d5ac83f1188cd |
| 20:59:19 | <OpenMRSBot> <http://ln-s.net/+H4O> (at github.com) |
| 20:59:29 | <dkayiwa> yony258: ok |
| 20:59:36 | <yony258> dkayiwa: Let me know when you start reviewing so that I'll know when to refresh for comments :P |
| 20:59:51 | <dkayiwa> yony258: ok |
| 21:03:54 | *** suranga has quit IRC |
| 21:05:45 | <dkayiwa> yony258: did you do mvn install before pushing |
| 21:05:52 | <yony258> dkayiwa: Of course! |
| 21:06:03 | <dkayiwa> yony258: :D |
| 21:15:25 | <djazayeri> yony258: glancing at the template example |
| 21:15:55 | <djazayeri> yony258: one thing that you don't need to do is the var values = [{ patientId : details.patientId, ⦠}] |
| 21:16:45 | <djazayeri> yony258: can't you just evaluate the template directly against the details object? |
| 21:17:14 | <yony258> djazayeri: I have no previous experience with underscore templates, I did all based on some tutorials so you'll have to be a bit more specific :) |
| 21:19:39 | <djazayeri> yony258: http://pastebin.com/8DAE7URw |
| 21:19:46 | <djazayeri> see the two lines with // THIS comments |
| 21:20:17 | <yony258> djazayeri: So you display using innerHtml = evaluated ? |
| 21:20:25 | <djazayeri> yony258: exactly |
| 21:20:35 | <yony258> djazayeri: Great!, thank you |
| 21:46:16 | *** jblaya has quit IRC |
| 21:51:43 | *** rafa has quit IRC |
| 21:55:27 | *** andreapat has joined #openmrs |
| 21:55:59 | <andreapat> djazayeri, quick question re tinyint, u around? |
| 21:56:38 | <djazayeri> andreapat: IIRC you shouldn't actually use tinyint |
| 21:56:45 | <djazayeri> because I think that's mysql-specific... |
| 21:56:51 | <djazayeri> andreapat: what's up? |
| 21:57:17 | <andreapat> djazayeri, that was it - so just int? |
| 21:57:34 | <djazayeri> andreapat: see what booleans are in core |
| 21:58:02 | <andreapat> djazayeri, aah good idea - thanks! |
| 22:13:49 | <andreapat> djazayeri, have looked at several booleans - all db values are tinyint |
| 22:14:37 | <andreapat> djazayeri, actually tinyint(1) |
| 22:14:39 | <djazayeri> andreapat: where are you intending to use this? |
| 22:15:02 | <andreapat> djazayeri, deathDateEstimated |
| 22:15:15 | <djazayeri> andreapat: in the liquibase changeset? |
| 22:15:49 | <andreapat> djazayeri, yes I will have to add column thwere, right? |
| 22:17:03 | <djazayeri> andreapat: yeah, but look at an existing example of a boolean in liquibase-schema-only |
| 22:17:09 | <djazayeri> <column defaultValueBoolean="false" name="birthdate_estimated" type="BOOLEAN"> |
| 22:17:09 | <djazayeri> <constraints nullable="false"/> |
| 22:17:09 | <djazayeri> </column> |
| 22:17:12 | <djazayeri> for example |
| 22:17:26 | <djazayeri> don't need to specify tinyint(1) directlyâyou say BOOLEAN and liquibase figures it out |
| 22:17:55 | <andreapat> djazayeri, thank you!l do it like that |
| 22:18:54 | *** andreapat has quit IRC |
| 22:19:19 | *** andreapat has joined #openmrs |
| 22:21:46 | <andreapat> djazayeri, can u send that whole changeset so I know if I need preconditions ect? |
| 22:23:11 | <djazayeri> andreapat: look up one â i got that from liquibase-schema-only |
| 22:24:16 | <djazayeri> it doesn't have the right precondition |
| 22:29:27 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Facility Data 2.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=facilitydata&version=&2.1> |
| 22:32:35 | *** wyclif_ has quit IRC |
| 23:15:14 | <dkayiwa> yony258: reviewed |
| 23:15:28 | <yony258> dkayiwa: Fixed :] pushing soon |
| 23:15:38 | <dkayiwa> yony258: ok :) |
| 23:15:40 | <yony258> dkayiwa: Thank you |
| 23:20:24 | *** dkayiwa has quit IRC |
| 23:30:34 | *** yony258 has quit IRC |
| 23:30:49 | *** wyclif_ has joined #openmrs |
| 23:45:19 | *** wyclif_ has quit IRC |
| 23:57:34 | <andreapat> djazayeri, when I build with neccessary change in person.hbm.xml there are 28 test with errors - to do with Person |
| 23:58:30 | <djazayeri> andreapat: presumably there's one underlying cause of all of them |
| 23:58:41 | <djazayeri> andreapat: have you looked into the error message? |