| 01:07:03 | *** wyclif_ has joined #openmrs |
| 03:01:14 | *** andreap has quit IRC |
| 04:30:58 | *** kishoreyekkanti has joined #openmrs |
| 04:58:12 | *** pulasthi7 has joined #openmrs |
| 05:13:12 | *** djazayeri has quit IRC |
| 05:15:02 | *** djazayeri has joined #openmrs |
| 05:15:02 | *** ChanServ sets mode: +o djazayeri |
| 05:24:04 | *** robbyoconnor has joined #openmrs |
| 05:24:04 | *** ChanServ sets mode: +v robbyoconnor |
| 06:08:24 | *** travis-ci has joined #openmrs |
| 06:08:24 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [41f320b] [Alexandre Barbosa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3605501 |
| 06:08:24 | *** travis-ci has left #openmrs |
| 06:08:28 | <OpenMRSBot> <http://ln-s.net/+GMP> (at travis-ci.org) |
| 07:11:41 | *** dkayiwa has joined #openmrs |
| 07:24:03 | *** djazayeri has quit IRC |
| 07:25:42 | *** djazayeri has joined #openmrs |
| 07:25:42 | *** ChanServ sets mode: +o djazayeri |
| 07:40:32 | <dkayiwa> hi yony258 |
| 08:04:59 | *** Mkop has joined #openmrs |
| 08:04:59 | *** ChanServ sets mode: +v Mkop |
| 08:07:34 | *** Mkop1 has quit IRC |
| 08:17:40 | *** dkayiwa has quit IRC |
| 08:20:08 | *** dkayiwa has joined #openmrs |
| 08:58:15 | *** djazayeri has quit IRC |
| 09:30:26 | <yony258> dkayiwa: hi |
| 09:30:34 | <dkayiwa> yony258: how is your day? |
| 09:31:07 | <yony258> dkayiwa: Good, how are you? |
| 09:31:19 | <dkayiwa> yony258: am doing good too |
| 09:31:59 | <yony258> dkayiwa: Did you see the comments on the dev list? |
| 09:32:08 | <dkayiwa> yony258: yes |
| 09:33:41 | <yony258> dkayiwa: So did you understand how to solve it?, Im not sure. |
| 09:33:50 | <dkayiwa> yony258: yes i did |
| 09:34:04 | <yony258> dkayiwa: <form:radiobuttons ? |
| 09:34:26 | <dkayiwa> yony258: that ones does not seem to layout widgets in the exact way we want them |
| 09:34:48 | <dkayiwa> yony258: wyclif's is the one which fits perfectly in what we want |
| 09:35:57 | <yony258> dkayiwa: name="${status.expression}" ? |
| 09:36:06 | <dkayiwa> yony258: yes |
| 09:36:36 | <dkayiwa> yony258: http://pastebin.com/9g885Z2T |
| 09:36:53 | <dkayiwa> yony258: the above is the first step you need |
| 09:37:41 | <dkayiwa> yony258: put that under your loop of: <c:forEachvar="slot"items="${availableTimes}"> |
| 09:37:59 | <yony258> dkayiwa: I dont have that loop anymore, we changed to DWR |
| 09:38:55 | <dkayiwa> yony258: from Darius's response, looks like going the DWR route is going to take us another lot of time thinking and hacking :) |
| 09:39:23 | <dkayiwa> yony258: in that case, i would go with your original thinking of doing a POST :) |
| 09:39:50 | <yony258> dkayiwa: So what about all the combo box that are reseting? that was one of our motivation to go with DWR |
| 09:40:16 | *** rafa has joined #openmrs |
| 09:40:16 | *** ChanServ sets mode: +v rafa |
| 09:40:22 | <dkayiwa> yony258: i can deal with them after we are done with the time slots :) |
| 09:42:18 | <dkayiwa> yony258: your jsp should look like this: http://pastebin.com/bE74RSni |
| 09:42:30 | <dkayiwa> yony258: feel free to just copy and paste from that pastebin link |
| 09:43:11 | <dkayiwa> yony258: after that, i will tell you the next steps |
| 09:43:36 | *** yony258_ has joined #openmrs |
| 09:44:04 | <yony258_> dkayiwa: Sorry I got DC. |
| 09:44:12 | *** yony258 has quit IRC |
| 09:44:21 | *** yony258_ is now known as yony258 |
| 09:44:29 | <dkayiwa> dkayiwa: yony258: i can deal with them after we are done with the time slots |
| 09:44:29 | <dkayiwa> [1:14pm] dkayiwa: yony258: your jsp should look like this: http://pastebin.com/bE74RSni |
| 09:44:29 | <dkayiwa> [1:15pm] dkayiwa: yony258: feel free to just copy and paste from that pastebin link |
| 09:44:29 | <dkayiwa> [1:15pm] dkayiwa: yony258: after that, i will tell you the next steps |
| 09:45:30 | *** r0bby has joined #openmrs |
| 09:45:30 | *** ChanServ sets mode: +v r0bby |
| 09:48:52 | <yony258> dkayiwa: Can you please paste bin the controller too? (I removed stuff from there when changing to DWR) |
| 09:48:57 | *** robbyoconnor has quit IRC |
| 09:49:06 | <dkayiwa> yony258: ok |
| 09:51:48 | <dkayiwa> yony258: http://pastebin.com/REUAjW5K |
| 09:53:16 | <yony258> dkayiwa: What is TimeSlotEditor? |
| 09:53:57 | <dkayiwa> yony258: http://pastebin.com/imvsYaLm |
| 09:54:17 | <yony258> dkayiwa: What does it do? |
| 09:54:53 | <dkayiwa> yony258: thats the property editor. it helps spring know how to convert between a TimeSlot object and an number (timeSlotId) |
| 09:55:09 | <dkayiwa> yony258: and vise vasa |
| 09:55:19 | <yony258> dkayiwa: Oh so thats why the value of the radio button was timeSlotId? |
| 09:55:40 | <dkayiwa> yony258: perfect!!! You are very clever :D |
| 09:58:52 | <yony258> dkayiwa: Ok, can you please explain to me why it works now? |
| 09:59:12 | <dkayiwa> yony258: does it work for you there? |
| 09:59:24 | <yony258> dkayiwa: Yes |
| 09:59:41 | <yony258> dkayiwa: Im getting the correct timeSlot in the appointment object |
| 10:00:35 | <dkayiwa> yony258: Because we are now telling spring to use the selected (using radio button) time slot for the appointment |
| 10:00:55 | <yony258> dkayiwa: Let me be more specific |
| 10:00:56 | <dkayiwa> yony258: using this: <spring:bindpath="appointment.timeSlot"> |
| 10:00:59 | <dkayiwa> yony258: ok |
| 10:01:35 | <yony258> dkayiwa: What is this: |
| 10:01:35 | <yony258> <c:iftest="${slot.timeSlotId==appointment.timeSlot.timeSlotId}">checked="checked"</c:if> |
| 10:03:24 | <dkayiwa> yony258: slot is the one we have in the looping of the available time slots |
| 10:03:24 | <dkayiwa> yony258: while appointment.timeSlot is that for the current appointment |
| 10:03:24 | <dkayiwa> yony258: so that check makes sure that if the current appointment has a time slot, we selected it while looping through the list of available time slots |
| 10:03:37 | <dkayiwa> yony258: where select means check (tick) the radio button |
| 10:04:11 | <yony258> dkayiwa: ok good, and whats the idea of ${status.expression} I can see the html just replaced to name="timeSlot" |
| 10:06:02 | <dkayiwa> yony258: because we need the radio buttons to act like one group (not to be able to select more than one), they need the same name |
| 10:06:43 | <dkayiwa> yony258: that name is used by spring when bind our values |
| 10:06:47 | <yony258> dkayiwa: Yes I understand, But I dont understand is what is ${status.expression}, where it got its value, and what is its purpose. |
| 10:06:54 | <dkayiwa> yony258: the actal value for that is simply: timeSlot |
| 10:07:44 | <dkayiwa> yony258: status.expression is provided by spring to tell us the current binding that we are using |
| 10:08:18 | <yony258> dkayiwa: Oh like ${status.value} in AppointmentType Edit |
| 10:08:49 | <dkayiwa> yony258: the binding expression |
| 10:08:49 | <dkayiwa> yony258: status.expression: the expression that was used to retrieve the bean or property |
| 10:08:49 | <dkayiwa> yony258: status.value: the actual value of the bean or property (transformed using registered PropertyEditors) |
| 10:08:49 | <dkayiwa> yony258: status.errorMessages: an array of error messages, resulting from validation |
| 10:09:08 | <dkayiwa> yony258: does that make it better? |
| 10:09:21 | <yony258> dkayiwa: Yes but let me check If I got it. |
| 10:09:28 | <dkayiwa> yony258: ok :) |
| 10:09:43 | <yony258> dkayiwa: status has a map of pairs <expression, value> and an errors array? |
| 10:10:02 | <dkayiwa> yony258: yes all those are status properties |
| 10:10:10 | <dkayiwa> yony258: and all provided by spring |
| 10:10:10 | <yony258> dkayiwa: ok cool :) |
| 10:11:05 | <yony258> dkayiwa: So now the major issue is that the combo box are resetting |
| 10:11:18 | <dkayiwa> yony258: which combo box? |
| 10:11:35 | <yony258> dkayiwa: AppointmentType combo box and Clinician combo box |
| 10:11:40 | <yony258> dkayiwa: When clicking on save |
| 10:12:03 | <dkayiwa> yony258: do they still maintain the lists? |
| 10:12:29 | <yony258> dkayiwa: Nope |
| 10:13:13 | <dkayiwa> yony258: ok lets first deal with maintaing the lists. ok? |
| 10:13:44 | <yony258> dkayiwa: ok, Should I just re-add them to the ModelMap on the POST controller? |
| 10:13:58 | <yony258> *in |
| 10:14:06 | <dkayiwa> yony258: that would also work |
| 10:14:18 | <yony258> dkayiwa: What is the correct way to do that? |
| 10:14:41 | <dkayiwa> yony258: i think it should be using the @ModelAttribute |
| 10:14:51 | <dkayiwa> yony258: like we did for AppointmentTypeFormController |
| 10:15:27 | <yony258> dkayiwa: Ok I will try to do that in the lecture I need to be in right now :P |
| 10:15:41 | <dkayiwa> yony258: ok :) |
| 10:15:58 | <yony258> dkayiwa: Thank you, I will to you later. |
| 10:16:02 | <yony258> *talk |
| 10:16:05 | <dkayiwa> yony258: ok |
| 10:16:12 | *** yony258 has quit IRC |
| 10:20:56 | *** k-joseph has joined #openmrs |
| 10:24:52 | <k-joseph> dkayiwa: hi |
| 10:25:05 | <dkayiwa> k-joseph: hi |
| 10:28:06 | *** r0bby has quit IRC |
| 10:42:11 | *** upul has joined #openmrs |
| 10:42:11 | *** ChanServ sets mode: +v upul |
| 11:10:24 | *** kavuri has joined #openmrs |
| 11:12:18 | *** travis-ci has joined #openmrs |
| 11:12:18 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [516aa67] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3608273 |
| 11:12:18 | *** travis-ci has left #openmrs |
| 11:12:21 | <OpenMRSBot> <http://ln-s.net/+GQ6> (at travis-ci.org) |
| 11:14:32 | <kavuri> dkayiwa: hi. I think I found one more bug related to creation of encounters with server in a different timezone than that of the client |
| 11:14:43 | <dkayiwa> kavuri: oh ok |
| 11:14:56 | <dkayiwa> kavuri: did you create a ticket for it? |
| 11:15:02 | <kavuri> dkayiwa: the scenario is like, I have the openmrs server deployed in amazon server |
| 11:15:17 | <dkayiwa> kavuri: aha |
| 11:15:18 | <kavuri> dkayiwa: no, not yet. Wanted to confirm first before raising one |
| 11:15:26 | <dkayiwa> kavuri: ok |
| 11:15:43 | <kavuri> dkayiwa: and I have a client doing a POST of an encounter created locally |
| 11:16:21 | <kavuri> dkayiwa: the encounter date time in the json message is like "encounterDatetime":"2012-12-11T13:59:25.477+0530" |
| 11:16:41 | *** k-joseph has quit IRC |
| 11:17:03 | <dkayiwa> kavuri: ok |
| 11:17:54 | <kavuri> dkayiwa: and the server time is in UTC |
| 11:18:12 | <kavuri> dkayiwa: so, the server is 0530hrs before my client timestamp |
| 11:18:47 | <dkayiwa> kavuri: ok |
| 11:19:00 | <kavuri> dkayiwa: when I try to create an encounter with this timestamp, I get an error "startDatetime is after the current time" |
| 11:19:37 | <kavuri> dkayiwa: when I changed the timestamp of my machine (made is one day before the server timestamp), I am able to create the encounter |
| 11:19:48 | *** k-joseph has joined #openmrs |
| 11:20:04 | <dkayiwa> kavuri: ok |
| 11:20:11 | <kavuri> dkayiwa: is this timestamp ""encounterDatetime":"2012-12-11T13:59:25.477+0530" not a valid one? |
| 11:20:40 | <dkayiwa> kavuri: looks valid to me |
| 11:24:05 | <kavuri> dkayiwa: right, how can I check where this problem is? |
| 11:26:03 | *** k-joseph has quit IRC |
| 11:26:18 | <dkayiwa> kavuri: can you create a unit test for it? |
| 11:28:29 | <kavuri> dkayiwa: how can I simulate a unit test with a server? |
| 11:28:49 | <dkayiwa> kavuri: let me think about it |
| 11:31:35 | <kavuri> dkayiwa: I guess the problem is in openmrs core? |
| 11:31:49 | <dkayiwa> kavuri: will see |
| 11:40:43 | *** k-joseph has joined #openmrs |
| 11:44:12 | *** Sateesh has joined #openmrs |
| 11:45:55 | *** kavuri has quit IRC |
| 11:46:04 | <Sateesh> dkayiwa: the error is coming from api/src/main/java/org/openmrs/validator/ValidateUtil.java |
| 11:47:29 | <Sateesh> dkayiwa: line 85 |
| 11:50:16 | *** Sateesh has quit IRC |
| 11:50:36 | *** kavuri has joined #openmrs |
| 11:51:41 | <dkayiwa> k-joseph: ok |
| 11:52:50 | <dkayiwa> kavuri: ok :) |
| 11:55:11 | <kavuri> dkayiwa: got logged out... |
| 11:55:19 | <kavuri> dkayiwa: did you have any inputs for me? |
| 11:55:21 | <dkayiwa> kavuri: ok |
| 11:55:32 | <dkayiwa> kavuri: not yet |
| 11:56:01 | <kavuri> dkayiwa: I sent a msg sometime back that the problem is getting thrown from ValidateUtil::validate() |
| 11:56:12 | <kavuri> dkayiwa: like 85 to be specific ...in openmrs api |
| 11:57:01 | <dkayiwa> kavuri: can you pastebin the stack trace? |
| 12:03:02 | *** grahameg has joined #openmrs |
| 12:03:19 | *** grahameg has left #openmrs |
| 12:06:19 | <kavuri> dkayiwa: http://pastebin.com/4jn1EXD4 |
| 12:09:36 | *** grahameg has joined #openmrs |
| 12:10:08 | *** grahameg has left #openmrs |
| 12:12:42 | <dkayiwa> kavuri: ok |
| 12:14:55 | *** suranga has joined #openmrs |
| 12:14:55 | *** ChanServ sets mode: +v suranga |
| 12:16:18 | *** k-joseph has quit IRC |
| 12:16:42 | *** pulasthi7 has quit IRC |
| 12:19:28 | *** upul has quit IRC |
| 12:19:37 | *** yony258 has joined #openmrs |
| 12:20:16 | <yony258> dkayiwa: Why do we need to call again showForm(...) after we click "Find Available Time" ? |
| 12:20:21 | *** rfriedman has joined #openmrs |
| 12:21:07 | <dkayiwa> yony258: was temporary. you can just remove it and have something like below |
| 12:21:47 | <yony258> dkayiwa: ok |
| 12:22:00 | <dkayiwa> yony258: http://pastebin.com/ve0YbmGg |
| 12:23:07 | <yony258> dkayiwa: Haha thats almost exactly what I just wrote |
| 12:23:07 | <rfriedman> rafa, hi |
| 12:23:14 | <rafa> rfriedman: hi |
| 12:23:19 | <dkayiwa> yony258: :) |
| 12:23:22 | <rfriedman> rafa, this is very bad |
| 12:23:35 | <rfriedman> rafa, we have never ever done this |
| 12:23:43 | <rafa> rfriedman: it's nothing backwards incompatible |
| 12:24:00 | <rafa> rfriedman: no one should see a difference |
| 12:24:02 | <rfriedman> but it breaks the lab modujle |
| 12:24:09 | <rafa> rfriedman: how? |
| 12:24:21 | <rfriedman> we already have an urgency column in our own lab test object |
| 12:24:47 | <rafa> rfriedman: may I see it? |
| 12:25:13 | <rfriedman> sure, its in git/r.friedman |
| 12:25:15 | <rafa> rfriedman: have you added a column to the order table? |
| 12:25:19 | <rfriedman> jsslab |
| 12:25:27 | <rfriedman> no, we have our own subclass |
| 12:25:58 | <rafa> rfriedman: let me look at that |
| 12:26:25 | <rfriedman> rafa, the point is, once we start down this path, we'll never go back |
| 12:26:48 | <rafa> rfriedman: I understand your concern |
| 12:27:14 | <rfriedman> rafa, i know people want the new order structure, but they're just going to have to use a custom build or we're going to have to release an early 1.10 |
| 12:27:20 | <rafa> rfriedman: I didn't participate in a discussion around that |
| 12:27:38 | <rfriedman> rafa, i didn't see any such discussion |
| 12:28:10 | <rfriedman> rafa, what about rest module, did you update it with new data model? |
| 12:28:14 | <rafa> rfriedman: is it https://github.com/r-friedman/Raxa-JSS? |
| 12:28:19 | <rfriedman> ya |
| 12:28:40 | <rafa> rfriedman: classes have not changed at all |
| 12:28:49 | <rfriedman> order class has |
| 12:29:11 | <rafa> rfriedman: well right |
| 12:29:30 | <rafa> rfriedman: but it doesn't break the rest module |
| 12:29:32 | <rfriedman> rafa, we decided to version rest module with core data version because it would only change on major version changes |
| 12:29:57 | <rfriedman> rafa, does the rest module present the new fields? |
| 12:30:02 | <rfriedman> expose |
| 12:30:09 | <rafa> rfriedman: no |
| 12:30:39 | <rfriedman> rafa, does the rest module expose the test order subclass? |
| 12:30:54 | <rafa> rfriedman: no |
| 12:31:23 | <rfriedman> rafa, we have to keep the rest module in synch with the data model |
| 12:31:37 | <rfriedman> rafa, were there changes to the order api? |
| 12:32:34 | <rafa> rfriedman: from my understanding there were no changes to the api |
| 12:34:46 | <rafa> rfriedman: I'm trying to find my way in the Raxa-JSS project, where should I look for your model classes? |
| 12:35:38 | *** ningosi has joined #openmrs |
| 12:35:44 | <rfriedman> rafa, try jsslab_test.xml for the hibernate |
| 12:35:58 | <rfriedman> excuse me, jsslab_order.xml |
| 12:36:12 | <rfriedman> rafa, pre-first cup of coffee here |
| 12:36:24 | *** ningosi is now known as Ojwanganto |
| 12:41:00 | <rafa> rfriedman: shouldn't I be looking at https://github.com/openmrs/openmrs-module-jsslab/ instead? |
| 12:41:06 | <OpenMRSBot> <http://ln-s.net/+GR7> (at github.com) |
| 12:41:54 | <rfriedman> rafa, double sorry, yes, and in there it's api/main/resources laborder.hbm.xml |
| 12:42:43 | <dkayiwa> yony258: hi |
| 12:42:43 | *** grahameg has joined #openmrs |
| 12:43:08 | <yony258> dkayiwa: hi |
| 12:43:48 | <rafa> rfriedman: so looking at how things are set up in jsslab there should be no problem |
| 12:44:16 | <dkayiwa> yony258: can you reply to the dev list saying that wyclif' suggestion worked? |
| 12:44:26 | <dkayiwa> kavuri: so you were submitting an encounter whose datetime was before the server's current date? |
| 12:44:30 | <yony258> dkayiwa: Sure I will do that, I just need to go to class |
| 12:44:30 | <rafa> rfriedman: LabOrder data is stored in a separate table |
| 12:45:03 | <dkayiwa> yony258: please do not forget. it will help others who read the emails for solutions to the same problems :) |
| 12:45:04 | <rfriedman> rafa, yes, but if there are name conflicgts between the new urgency column and the subclass urgency column? |
| 12:45:14 | <yony258> dkayiwa: Ok, will do. |
| 12:45:53 | <rafa> rfriedman: your column is "urgent" |
| 12:46:15 | <rafa> rfriedman: the one in 1.9.2 is "urgency" |
| 12:46:45 | <rfriedman> rafa, and the subclass identifier? |
| 12:47:53 | <kavuri> dkayiwa: was after |
| 12:47:56 | <rfriedman> is it test_order v. lab_order, rafa? |
| 12:48:16 | <kavuri> dkayiwa: the server is in a timezone which is before my machine timezone |
| 12:48:27 | <dkayiwa> kavuri: why would it refuse if it was after? |
| 12:48:58 | <rfriedman> rafa, my subclass is laborder |
| 12:49:09 | <rafa> rfriedman: that's fine, they can coexist |
| 12:49:30 | <rafa> rfriedman: they are stored in 2 separate tables |
| 12:49:32 | <dkayiwa> kavuri: is your machine the one which generates the encounter datetime? |
| 12:49:33 | <kavuri> dkayiwa: the server time is "Tue Dec 11 12:48:51 UTC 2012", and my machine time is "Tue Dec 11 18:19:16 IST 2012" |
| 12:49:36 | *** grahameg has quit IRC |
| 12:49:37 | *** yony258 has quit IRC |
| 12:49:48 | <kavuri> dkayiwa: so my machine time is ahead of the server time |
| 12:49:56 | *** grahameg has joined #openmrs |
| 12:49:57 | <rafa> rfriedman: they're joined by order_id if requested |
| 12:50:01 | <kavuri> dkayiwa: yes, my machine generates the encounter datetime |
| 12:50:12 | <grahameg> Join #fhir |
| 12:50:17 | <dkayiwa> kavuri: then it should be in line with that of the server |
| 12:50:20 | <rfriedman> rafa, what is the name of the new subclass? |
| 12:50:31 | <kavuri> dkayiwa: in line as in? |
| 12:50:38 | <rafa> rfriedman: the table name is test_order |
| 12:50:38 | <dkayiwa> kavuri: same |
| 12:50:50 | <kavuri> dkayiwa: but the server throws an error |
| 12:50:53 | <kavuri> dkayiwa: validation fails |
| 12:50:53 | <rfriedman> rafa, it's not implemented as a subclass of order? |
| 12:50:59 | <dkayiwa> kavuri: because when server is validating, it uses its today's date |
| 12:51:04 | <rafa> rfriedman: it is a joined-subclass |
| 12:51:06 | <kavuri> dkayiwa: yes |
| 12:51:16 | <rafa> rfriedman: and yes it's a subclass or order |
| 12:51:18 | <dkayiwa> kavuri: the server's today's date is different from you client's today's date |
| 12:51:26 | <kavuri> dkayiwa: yes |
| 12:51:29 | <dkayiwa> kavuri: so the client should be same date with server |
| 12:51:31 | <rafa> rfriedman: but you still can subclass order in your module |
| 12:51:45 | <kavuri> dkayiwa: why should the client be the same date as the server? |
| 12:51:49 | <rafa> rfriedman: you dont' have to know about TestOrder |
| 12:51:54 | <kavuri> dkayiwa: as long as the server deals with UTC, things should be fine |
| 12:52:04 | <rfriedman> rafa, i think we have eliminated potential conflicts |
| 12:52:09 | <kavuri> dkayiwa: but looks like the server does not do the validation against UTC |
| 12:52:26 | <rafa> rfriedman: yes, but I agree with you that we're walking on a thin ice here ;) |
| 12:52:46 | <dkayiwa> kavuri: i could be using wrong assumptions :0 |
| 12:52:48 | <dkayiwa> :) |
| 12:52:56 | <dkayiwa> kavuri: can you start a thread about this on the dev list? |
| 12:52:57 | <rafa> rfriedman: I don't think it should be done ever again |
| 12:53:09 | <kavuri> dkayiwa: ok, will do |
| 12:53:18 | <rfriedman> rafa, hope i haven't been too vehement at you :) |
| 12:53:26 | *** Ojwanganto has quit IRC |
| 12:53:35 | <rfriedman> rafa, just not what i wanted to see first thing in the morning |
| 12:53:53 | <rafa> rfriedman: I don't know the word so probably no ;) |
| 12:54:02 | <rafa> rfriedman: 'vehement' |
| 12:54:06 | <rfriedman> strong, harsh |
| 12:54:13 | <rfriedman> insistgent |
| 12:54:18 | <rfriedman> insistent |
| 12:54:27 | <rafa> rfriedman: ah not at all :) |
| 12:54:38 | <rafa> rfriedman: it's good you're picky and watch our hands |
| 12:55:36 | <rfriedman> rafa, do you think we should have some policy allowing branch releases? |
| 12:55:56 | <rfriedman> rafa, or should we keep having just a main line? |
| 12:56:47 | <rafa> rfriedman: I'm not sure I understand, we do have releases for maintenance branches |
| 12:57:29 | <rfriedman> rafa, this all started with Mark's having to implement test orders while the 1.10 order discussion was in progress |
| 12:57:49 | <rfriedman> rafa, then i think Darius picked up Mark's test orders for mirabelais |
| 12:58:00 | <rfriedman> rafa, basically they see all this happening in 1.10 |
| 12:58:44 | <rfriedman> rafa, but they wanted all the bug fixes etc. in 1.9, maybe 1.10 isn't all running yet? |
| 12:59:39 | <rafa> rfriedman: yes, 1.10 is not stable. I think that orders are not finished there yet. |
| 12:59:54 | <rafa> rfriedman: It |
| 13:00:06 | <rafa> rfriedman: It's bad that partial work on orders was committed to 1.10 |
| 13:00:32 | <rafa> rfriedman: ideally it should have been done in a branch and merged only when 100% ready |
| 13:01:09 | <rfriedman> rafa, is there a way someone can subscribe to changes so that for example when a 1.9 bug is fixed they can apply it to their own custom build? |
| 13:02:07 | <rafa> rfriedman: yes, you need a query in JIRA and then cherry-pick commits |
| 13:02:21 | <kavuri> dkayiwa: sent the mail |
| 13:02:38 | <dkayiwa> kavuri: seen it. thanks :) |
| 13:02:39 | <rfriedman> rafa, could it be scripted? |
| 13:03:40 | <rfriedman> rafa, or turn it around, have a subscribe capability and have jira push out bug fixes? |
| 13:04:12 | <rfriedman> rafa, all commits, not just bug fixes |
| 13:04:50 | <rafa> rfriedman: if you want all commits you just need to pull all changes from the 1.9.2 tag into your custom branch |
| 13:05:23 | <rafa> rfriedman: git will do a merge for you and if all changes were compatible you may not even see conflicts |
| 13:05:41 | <rfriedman> rafa, so if I forked at 1.9.2.123, i just have to pull all commits starting 1.9.2.124? |
| 13:06:06 | <rafa> rfriedman: yes |
| 13:06:37 | <rfriedman> rafa, can that be done in bulk or is it one at a time? |
| 13:07:12 | <rafa> rfriedman: it's in bulk, you specify pull all commits till 1.9.2.200 |
| 13:07:51 | <rafa> rfriedman: you can also use the 1.9.2 tag here, which may point to 1.9.2.450 or something |
| 13:08:45 | <rfriedman> rafa, sounds to me like what should have happened is that they create their own branch of 1.9 which they can mung to their heart's content and just update with other changes ... only cost is resolving conflicts |
| 13:09:19 | *** ningosi has joined #openmrs |
| 13:09:20 | <rafa> rfriedman: yes, I would have advised that. |
| 13:09:39 | *** ningosi is now known as Ojwanganto |
| 13:09:39 | <rafa> rfriedman: with git it's not that expensive to maintain your own branch |
| 13:09:50 | <rafa> rfriedman: it's pretty clever about conflicts |
| 13:10:09 | *** cpower has quit IRC |
| 13:10:26 | <rfriedman> rafa, but maybe they also wanted to distribute it through the downloads page, then we would have to have some sort of parallel naming |
| 13:10:47 | <rfriedman> rafa, or they should have their own page |
| 13:11:30 | <rafa> rfriedman: I don't think OpenMRS should distribute any custom builds, so they would need their own page |
| 13:12:07 | <rfriedman> rafa, probably the wisest course, we have trouble keeping a single line backported :) |
| 13:12:40 | <rafa> rfriedman: yeah, it's already a ton of work |
| 13:14:05 | <rfriedman> rafa, you've been doing it every time now, I think Daniel released1.9.0, but every other time for quite a while? |
| 13:14:31 | <rafa> rfriedman: right, it's my 5th release or something ;) |
| 13:15:07 | <rafa> rfriedman: the last time I've released 4 at once ;) |
| 13:15:35 | <rfriedman> rafa, well you're just a hero i guess, with great skill comes great responsibility :) |
| 13:15:50 | <rafa> rfriedman: releasing 4 actually took almost the same time as releasing just 1 |
| 13:16:06 | <rafa> rfriedman: so I guess next time I'll do again a bunch |
| 13:16:29 | <rfriedman> rafa, or you could do it drunk for the challenge :) |
| 13:16:30 | *** jkeiper has joined #openmrs |
| 13:16:30 | *** ChanServ sets mode: +v jkeiper |
| 13:16:40 | <rafa> rfriedman: lol |
| 13:17:56 | <rfriedman> rafa, tks much, have a good day |
| 13:18:03 | <jkeiper> rafa, dkayiwa, wyclif_ ... hello ... |
| 13:18:18 | <dkayiwa> jkeiper: hi |
| 13:18:27 | <jkeiper> apologies for not having this sprint in order in time |
| 13:18:41 | <jkeiper> still recovering i guess ... hoped to finish it last night and promptly passed out |
| 13:18:49 | <dkayiwa> jkeiper: no problem. we had lots of other things to do in the meantime :) |
| 13:19:05 | <jkeiper> haha i see rafa has released 1.9.2! |
| 13:19:07 | <jkeiper> :-) |
| 13:19:14 | <dkayiwa> jkeiper: wish you a quick recovery |
| 13:19:28 | <jkeiper> thanks ... kids brought it to me, hope i haven't given it back |
| 13:19:44 | <jkeiper> this time of year it might be best for us all to live in bubbles |
| 13:21:26 | <rafa> jkeiper: yeah, no worries, we know how to keep ourselves busy ;) |
| 13:21:34 | *** tobin_g has joined #openmrs |
| 13:21:42 | <jkeiper> haha, well i will have it finished up today |
| 13:22:09 | <jkeiper> you can begin whenever you want but i presume we'll have a kickoff tomorrow around scrum time |
| 13:22:18 | <dkayiwa> jkeiper: your being away was a blessing in disguise |
| 13:22:23 | <rafa> jkeiper: great |
| 13:22:30 | <dkayiwa> jkeiper: for instance 1.9.2 would not have been out by now :) |
| 13:22:51 | *** pascal_jhs has joined #openmrs |
| 13:23:05 | <tobin_g> wyclif_: thanks for helping yonatan with this question on the dev@, solved a big problem for us! |
| 13:23:44 | <rfriedman> dkayiwa, i'd prefer jk well to 1.9.2 released |
| 13:24:03 | <jkeiper> haha, yes that's actually nice to have |
| 13:24:03 | <jkeiper> :-D |
| 13:24:07 | <tobin_g> dkayiwa: thanks for closing up all the tickets, hopefully we'll manage to squeeze a few more in soon |
| 13:24:10 | <dkayiwa> rfriedman: fully agree :D |
| 13:24:38 | <dkayiwa> tobin_g: feel free to close a ticket you feel is done :) |
| 13:24:48 | <pascal_jhs> !seen mseaton |
| 13:24:48 | <OpenMRSBot> pascal_jhs: mseaton was last seen in #openmrs 6 weeks, 3 days, 19 hours, 37 minutes, and 7 seconds ago: <mseaton> jkeiper: a report design has a reference to a report definition. a report definition (which is almost always a serialized object) itself has embedded data set definitions (which themselves are serialized objects), which in turn have embedded indicators (serialized objects), which have embedded (1 more message) |
| 13:24:52 | <pascal_jhs> :( |
| 13:24:55 | <tobin_g> dkayiwa: i think you got them all for now! |
| 13:24:57 | <jkeiper> heh |
| 13:25:02 | <jkeiper> i do remember that convo |
| 13:25:08 | <jkeiper> pascal_jhs++ coffee++ |
| 13:25:15 | <pascal_jhs> jkieper++ |
| 13:25:24 | <pascal_jhs> Hey jer, are you the resident reporting expert here now? |
| 13:25:52 | <pascal_jhs> jkeiper++ |
| 13:26:01 | <jkeiper> hah! not an expert but ... |
| 13:26:02 | <pascal_jhs> !karma jkieper |
| 13:26:02 | <OpenMRSBot> pascal_jhs: Karma for "jkieper" has been increased 1 time and decreased 0 times for a total karma of 1. |
| 13:26:04 | <tobin_g> !karma jkeiper |
| 13:26:04 | <OpenMRSBot> tobin_g: Karma for "jkeiper" has been increased 5 times and decreased 1 time for a total karma of 4. |
| 13:26:11 | <dkayiwa> tobin_g: yup :) |
| 13:26:13 | <tobin_g> ha! |
| 13:26:17 | <pascal_jhs> jkieper-- |
| 13:26:25 | <jkeiper> heheheheh |
| 13:26:28 | *** pascal_jhs is now known as pascal` |
| 13:26:33 | <jkeiper> that's better |
| 13:26:35 | <jkeiper> pascal`++ |
| 13:26:38 | <tobin_g> dkayiwa: do you know much about the issue that adam is having w/ javascript related to AM-7/8? |
| 13:26:39 | *** ChanServ sets mode: +v pascal` |
| 13:26:41 | <jkeiper> !karma pascal` |
| 13:26:41 | <OpenMRSBot> jkeiper: Karma for "pascal`" has been increased 29 times and decreased 3 times for a total karma of 26. |
| 13:27:03 | <jkeiper> so pascal` ... i've just been storming through the data model because we have a module interacting with it |
| 13:27:16 | <pascal`> o.O |
| 13:27:35 | <rfriedman> talk about an elephant in the china shop |
| 13:27:39 | <jkeiper> exactly |
| 13:27:50 | <jkeiper> shouting "why is THIS here?!" |
| 13:28:13 | <jkeiper> we also had a hiccup on a server and some serialized data objects got mixed up |
| 13:28:21 | <dkayiwa> tobin_g: am waiting for him to get online and we go through it together |
| 13:28:22 | <jkeiper> hate when that happens (once so far) |
| 13:28:27 | <pascal`> perhaps we should switch to riak (= |
| 13:28:32 | <jkeiper> heheheh |
| 13:28:40 | <jkeiper> we could store every report in a series of hl7z |
| 13:28:45 | <tobin_g> dkayiwa: great thank you :D |
| 13:28:45 | *** grahameg has quit IRC |
| 13:29:13 | <rfriedman> COBOL is great for reports |
| 13:29:23 | <pascal`> All reports should just be a sql create script to recreate the current state of your db |
| 13:29:30 | <tobin_g> dkayiwa: i think they have lots of class today so it may be later on |
| 13:29:30 | <pascal`> That should make things simpler, no? |
| 13:29:42 | <jkeiper> haha |
| 13:30:04 | <dkayiwa> tobin_g: ok |
| 13:30:04 | <tobin_g> dkayiwa: you think you've got some kind of solution to that Adam's issue? |
| 13:30:16 | <dkayiwa> tobin_g: yes |
| 13:30:27 | <tobin_g> dkayiwa: as always |
| 13:30:29 | <tobin_g> dkayiwa: ++ |
| 13:30:32 | <jkeiper> we should just have a "print" option for openmrs, that prints the entire db out in a huge table |
| 13:30:36 | <pascal`> Srsly though, we have a team in Mozambique trailing omrs, jkeiper, and they've run into a bit of an issue row-per-patients reports (they're using the reporting module) |
| 13:30:41 | <dkayiwa> tobin_g: Yonatan has been here for quite some hours :) |
| 13:30:41 | <dkayiwa> tobin_g: i think he was coding while in lecture :) |
| 13:30:55 | <jkeiper> pascal`, so what's the issue? |
| 13:30:59 | <pascal`> jkeiper: is it possible to have obs/encounter related columns in a RPP report? |
| 13:31:12 | <tobin_g> dkayiwa: seems like we may have succeeded in setting the hook? |
| 13:31:30 | <jkeiper> pascal`, yes ... i do them all the time |
| 13:31:33 | <dkayiwa> tobin_g: oh yes!!! :D |
| 13:31:43 | <pascal`> jkeiper: They've create the data definitions for a specific ID type they use, as well as for encounter date time (although I get why that doesn't work), but they can't add them to a RPP dataset. |
| 13:31:43 | <jkeiper> pascal`, afaict you have to write your own rules for them |
| 13:32:03 | <pascal`> jkeiper: okay, but not through the reporting module UI? |
| 13:32:11 | <pascal`> jkeiper: or do you mean logic rules? |
| 13:32:24 | <pascal`> jkeiper: is there a logic module reference somewhere? |
| 13:32:35 | <jkeiper> pascal`, logic rules ... |
| 13:32:51 | <tobin_g> dkayiwa: i've got to run but i'll check back in later on. |
| 13:32:53 | <jkeiper> pascal`, well ... we used the UI to build the actual reports but created rules to be put in the report |
| 13:32:55 | <pascal`> jkeiper: okay sweet, now... where can they learn the logic rule syntax? |
| 13:33:04 | <jkeiper> pascal`, we wrote the rules in java |
| 13:33:05 | <jkeiper> :-/ |
| 13:33:17 | *** tobin_g has quit IRC |
| 13:33:23 | <pascal`> hmm |
| 13:33:25 | <dkayiwa> tobin_g: ok |
| 13:33:47 | <pascal`> jkeiper: all they want is like: name, their id type, gender, some obs val, encounter_datetime of that obs. |
| 13:33:54 | <pascal`> jkeiper: and it doesn't seem like they can do that via the UI |
| 13:33:55 | <jkeiper> pascal`, you can see our work ... we did those |
| 13:33:56 | <jkeiper> :-D |
| 13:34:19 | <jkeiper> pascal`, right ... might not be rules for that. hrm ... /summon nribeka |
| 13:34:43 | <jkeiper> pascal`, fwiw this is our work: https://github.com/AMPATH/openmrs-module-amrsreports |
| 13:34:44 | <OpenMRSBot> <http://ln-s.net/+8VO> (at github.com) |
| 13:34:51 | <pascal`> jkeiper: it seems like they could do it with a logic dataset, but where can we figure out how to write logic rules? |
| 13:35:30 | <jkeiper> pascal`, that's something i haven't learned yet ... but i assume you mean the Arden syntax, etc? |
| 13:35:42 | <pascal`> jkeiper: well, i think that's what it is... |
| 13:35:59 | <jkeiper> pascal`, here's an oldie: https://wiki.openmrs.org/display/docs/Clinical+Decision+Support |
| 13:36:11 | <jkeiper> i know _someone_ is using it |
| 13:36:54 | <jkeiper> tammy from regenstrief uses it |
| 13:37:10 | <jkeiper> she's the owner of the logic module iirc |
| 13:37:37 | <pascal`> okay nice, thanks |
| 13:37:39 | <jkeiper> and win has lots of experience with manipulating reports behind the scenes ... not sure about from the UI |
| 13:37:52 | <jkeiper> also i'd include mark goodrich and michael seaton in anything regarding reports ;-) |
| 13:38:00 | <pascal`> well, I'm trying to avoid writing custom reporting stuff in java. I did it once. One time was enough. |
| 13:38:09 | <jkeiper> hahahaha agreed! |
| 13:38:10 | <pascal`> Yeah, was hoping to find them here |
| 13:38:27 | <pascal`> the ui is pretty decent now, but this simple use case still seems to be missing |
| 13:38:42 | <jkeiper> yes, strange ... |
| 13:38:52 | <jkeiper> darius might also know something |
| 13:38:53 | *** grahameg has joined #openmrs |
| 13:39:10 | <jkeiper> seems these guys are slacking or in a meeting discussing how to take over the world |
| 13:39:23 | <jkeiper> or asleep |
| 13:39:43 | <rfriedman> too late, they already finished the meeting about taking over the world |
| 13:39:49 | <rfriedman> they're doing it right now |
| 13:39:51 | <pascal`> Okay, well, a lady called Agnalda might pop in at some point to ask a few questions. |
| 13:39:54 | <jkeiper> sgithens, have you messed with creating ad-hoc logic rules for reporting through the UI? |
| 13:40:00 | <pascal`> She's the one taking point on testing omrs for Moz |
| 13:40:13 | <jkeiper> pascal`, ok ... i'll keep an eye out |
| 13:40:21 | <rfriedman> where is the moz installation? |
| 13:40:44 | <pascal`> If they decide to go with omrs, then it'll be a national roll-out, so that's a good thing I guess :). |
| 13:41:14 | <rfriedman> don't think so, moz can't do things at that scale |
| 13:41:24 | <jkeiper> oO! |
| 13:41:26 | <jkeiper> great |
| 13:42:00 | <rfriedman> moz can't do 1 system per region at the same time |
| 13:42:03 | <jkeiper> well, the good news is that reporting _is_ flexible, behind the scenes, and can be made to do whatever they like ... as long as they pick up a decent developer right? |
| 13:42:32 | <rfriedman> maybe could do 4 hospitals in maputo |
| 13:42:37 | <pascal`> er, rfriedman, you're working in moz atm? |
| 13:43:11 | <rfriedman> pascal`, formerly, have several people in our group working with them for years |
| 13:43:41 | <pascal`> jkeiper: yeah, they have a bunch of cool devs, so they could def get some decent reports up and running, but i'm trying to guide through through a UI process only during this pilot phase, just to expedite things a bit. |
| 13:43:44 | <jkeiper> rfriedman, sounds like this is an ambitious project then :-) |
| 13:44:13 | <rfriedman> jkeiper, we have people in our group helping them with their national standards for emrs |
| 13:44:18 | <jkeiper> pascal`, agreed ... probably good to get a dev hooked in with mseaton then, if only to expose more to the UI |
| 13:44:44 | <rfriedman> they want to be like kenya, but they have 1/10th the level of development |
| 13:44:46 | <jkeiper> rfriedman, ah interesting ... i wonder if it is coming from the same people then |
| 13:45:03 | <pascal`> well anyway, thanks jkeiper, hopefully I'll get the moz guys in here at some point |
| 13:45:06 | <pascal`> jkeiper++ |
| 13:45:11 | <jkeiper> pascal`, np :-D coffee++ |
| 13:45:14 | <pascal`> ciao for now :) |
| 13:45:40 | <jkeiper> bye bye |
| 13:45:41 | *** pascal` has quit IRC |
| 13:51:25 | *** grahameg has quit IRC |
| 14:08:34 | *** Ojwanganto has quit IRC |
| 14:23:31 | *** sgithens has quit IRC |
| 14:23:55 | *** kavuri has quit IRC |
| 14:26:00 | *** dkayiwa has quit IRC |
| 14:28:54 | *** rafa has quit IRC |
| 14:34:34 | *** nribeka has joined #openmrs |
| 14:34:34 | *** ChanServ sets mode: +v nribeka |
| 14:46:27 | *** kishoreyekkanti has quit IRC |
| 15:01:35 | *** cpower has joined #openmrs |
| 15:01:43 | <cpower> Good morning! |
| 15:02:33 | <cpower> or afternoon, or evening depending on your timezone |
| 15:02:47 | *** sgithens has joined #openmrs |
| 15:02:57 | <cpower> I have a few scrums by email today so let's get started |
| 15:03:01 | <cpower> !scrumon cpower |
| 15:03:01 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:03:51 | <cpower> Order: Rafal, Dkayiwa, jkeiper, suranga, wyclif_, Andrea when she appears, and whomever else would like to give an update |
| 15:03:56 | <cpower> Rafal's update |
| 15:04:07 | <cpower> * Finished releasing 1.9.2 |
| 15:04:07 | <cpower> * Fixed tests in webservices.rest (another green plan in CI!) |
| 15:04:07 | <cpower> * Investigated implications of the data model change in 1.9.2 for jsslab. |
| 15:04:07 | <cpower> * Investigated on TRUNK-3843: Introduce API performance tests |
| 15:04:07 | <cpower> https://tickets.openmrs.org/browse/TRUNK-3843 |
| 15:04:07 | <cpower> * Reviewed TRUNK-2754: Modules folder should be configured via a runtime property, not a global property, and it should default to a folder that depends on the webapp name |
| 15:04:07 | <cpower> https://tickets.openmrs.org/browse/TRUNK-3754 |
| 15:04:08 | <cpower> No blockers. |
| 15:04:22 | <cpower> dkayiwa's update |
| 15:04:24 | <cpower> Reviewed code and tested module for Tobin's Team |
| 15:04:24 | <cpower> Helped Tobin's team with solving their blockers and next steps |
| 15:04:24 | <cpower> Done some ticket management for the appointments module sprint |
| 15:04:24 | <cpower> Now working on: LazyInitializationException prevents reports from being run that contain patient data with lazy properties - REPORT-429 |
| 15:04:24 | <cpower> No Blockers |
| 15:04:35 | <cpower> jkeiper you are up |
| 15:04:43 | <cpower> let's get your sprint moving! |
| 15:05:34 | <cpower> *crickets* |
| 15:05:55 | *** andrea_ has joined #openmrs |
| 15:06:51 | <cpower> Next! |
| 15:07:06 | <wyclif_> Monday: |
| 15:07:06 | <wyclif_> Curating tickets |
| 15:07:06 | <wyclif_> Fix more tests SXS-1 - Fix unit tests in serialization module |
| 15:07:06 | <wyclif_> Reviewed TRUNK-3837 - ConceptValidatorChangeSet should not throw an Out of Memory exception when writing warnings to file |
| 15:07:06 | <wyclif_> |
| 15:07:07 | <cpower> suranga, do you have something to update? |
| 15:07:08 | <wyclif_> Tuesday: |
| 15:07:12 | *** suranga has quit IRC |
| 15:07:21 | <wyclif_> curating tickets |
| 15:07:21 | <wyclif_> sprint tickets |
| 15:07:21 | <wyclif_> |
| 15:07:21 | <wyclif_> Blockers: None |
| 15:07:26 | <cpower> I'll take that as a no, thanks wyclif_ |
| 15:07:34 | <cpower> and andrea_ you are up |
| 15:08:16 | <andrea_> cpower, am still sick - will be back tommorrow for sure |
| 15:08:24 | <cpower> ok |
| 15:08:31 | <cpower> and that ends our scrum |
| 15:08:35 | <cpower> !scrumoff |
| 15:08:35 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:09:17 | <wyclif_> jkeiper, what is the update on the sprint? |
| 15:09:35 | <cpower> that's my question too, but he's not here to answer |
| 15:10:06 | <cpower> wyclif_ you upstairs? |
| 15:12:02 | *** ayeung has joined #openmrs |
| 15:15:00 | *** travis-ci has joined #openmrs |
| 15:15:00 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [e97647e] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3611541 |
| 15:15:00 | *** travis-ci has left #openmrs |
| 15:15:04 | <OpenMRSBot> <http://ln-s.net/+GTS> (at travis-ci.org) |
| 15:21:48 | *** andrea_ has quit IRC |
| 15:54:23 | <wyclif_> cpower, no, am working fromhome |
| 15:55:15 | *** basic` has quit IRC |
| 15:55:33 | *** basic has joined #openmrs |
| 15:55:33 | *** basic has joined #openmrs |
| 16:04:19 | *** djazayeri has joined #openmrs |
| 16:04:19 | *** ChanServ sets mode: +o djazayeri |
| 16:06:04 | *** yony258 has joined #openmrs |
| 16:15:15 | *** tobin_g has joined #openmrs |
| 16:19:21 | <tobin_g> yony258: i thought you had class today? |
| 16:21:43 | <yony258> tobin_g: Im in class.... |
| 16:22:09 | <tobin_g> yony258: it appears as though we might have "hooked" you |
| 16:22:44 | *** sgithens has quit IRC |
| 16:23:05 | <yony258> tobin_g: just trying to finish this form before the sprint ends... |
| 16:23:19 | <tobin_g> :D |
| 16:23:25 | <tobin_g> yony258: ++ |
| 16:23:41 | *** applecool has joined #openmrs |
| 16:23:41 | *** ChanServ sets mode: +v applecool |
| 16:23:51 | <tobin_g> yony258: how's it looking? |
| 16:24:22 | <yony258> tobin_g: Every time I seem to solve an issue, another one pops up.. |
| 16:24:54 | <tobin_g> yony258: learning curve? :( |
| 16:25:05 | <tobin_g> yony258: or maybe just the nature of the beast |
| 16:26:35 | *** kernelhunter92 has joined #openmrs |
| 16:29:57 | <yony258> tobin_g: The result of not knowing Spring |
| 16:30:15 | <tobin_g> yony258: sounds like it's not so easy to learn |
| 16:30:43 | <tobin_g> yony258: you can try asking one of the other guys if daniel isn't around |
| 16:31:06 | <yony258> tobin_g: Yea its a lot different from other stuff I learned. |
| 16:34:43 | <tobin_g> yony258: do you know if daniel is supposed to be on later? |
| 16:35:38 | <yony258> tobin_g: I dont know, but he was on earlier |
| 16:36:17 | <tobin_g> yony258: yeah we talked a bit, just hoping he can help you & i think he had some answers to adam's questions |
| 16:39:23 | <tobin_g> yony258: wyclif_ just responded to your mail with more info, not sure if it's related to your current issue |
| 16:42:37 | <yony258> tobin_g: I'll check that out, thanks |
| 16:51:16 | *** suranga has joined #openmrs |
| 16:51:16 | *** ChanServ sets mode: +v suranga |
| 17:01:42 | *** yony258 has quit IRC |
| 17:12:11 | *** applecool has left #openmrs |
| 17:17:08 | *** yony258 has joined #openmrs |
| 17:21:43 | *** applecool has joined #openmrs |
| 17:21:43 | *** ChanServ sets mode: +v applecool |
| 17:21:57 | <jkeiper> where _is_ mseaton? ... /me uses email |
| 17:25:20 | <yony258> tobin_g: Do you know if Daniel will be online again today? |
| 17:28:44 | <rfriedman> djazayeri, darius, you really there? |
| 17:29:11 | <jkeiper> yony258, dkayiwa is usually back on at some point ... dinner time now in Uganda |
| 17:29:59 | <yony258> jkeiper: Ok thank you. |
| 17:40:42 | *** Ojwanganto has joined #openmrs |
| 17:40:59 | <Ojwanganto> Hi jkeiper |
| 17:41:08 | <Ojwanganto> am back |
| 17:50:42 | <yony258> tobin_g: Great news |
| 17:54:39 | *** suranga_ has joined #openmrs |
| 17:58:05 | *** suranga has quit IRC |
| 17:59:13 | *** yony258 has quit IRC |
| 17:59:14 | *** kernelhunter92 has quit IRC |
| 18:04:42 | *** Ojwanganto has quit IRC |
| 18:04:58 | *** suranga__ has joined #openmrs |
| 18:05:11 | <djazayeri> rfriedman: here now |
| 18:06:12 | <rfriedman> djazayeri, hey darius |
| 18:06:57 | <rfriedman> djazayeri, do you still have a hand in html form entry_? |
| 18:07:16 | *** cpower has quit IRC |
| 18:07:17 | <djazayeri> rfriedman: I vaguely follow it, and advise from time to time. what's up? |
| 18:07:44 | *** lh has quit IRC |
| 18:07:50 | <rfriedman> djazayeri, parts are translated, parts are not |
| 18:08:14 | <rfriedman> djazayeri, also showAccessionNumber and showComment, though useful, are pretty ugly |
| 18:08:21 | *** suranga_ has quit IRC |
| 18:09:11 | *** suranga_ has joined #openmrs |
| 18:09:14 | <djazayeri> rfriedman: true, and true |
| 18:09:26 | <jkeiper> good thing it's open source! |
| 18:09:28 | <djazayeri> rfriedman: concrete tickets welcome. patches even more welcome. :-) |
| 18:09:30 | <djazayeri> yes |
| 18:09:44 | <rfriedman> djazayeri, ok |
| 18:10:05 | <rfriedman> djazayeri, re translation ... do you think we should have a step in the release process where we solicit translation? |
| 18:10:21 | <djazayeri> rfriedman: AFAIK nobody is actively working on translation-related stuff, but if you create the tickets and they get up-voted, these should be straightforward to do |
| 18:10:45 | <djazayeri> rfriedman: I do not think that there should be a translation step in the release process for all modules, no. |
| 18:11:10 | <rfriedman> djazayeri, how about a "stuff needing translation" list? |
| 18:11:27 | <jkeiper> that said, there's something somewhere written by someone that looks for stuff that needs to be translated still ... think joaquin was using it |
| 18:11:55 | <djazayeri> rfriedman: that makes sense. Though do you mean "we need people to translate bundled modules X, Y, Z into Spanish and French" versus "this module needs to be tweaked to support localization"? |
| 18:11:57 | <djazayeri> you mean the former? |
| 18:12:08 | <rfriedman> former |
| 18:12:26 | *** suranga__ has quit IRC |
| 18:12:47 | <jkeiper> rfriedman, look at https://wiki.openmrs.org/display/docs/Custom+Messages+Module |
| 18:13:17 | <rfriedman> jkeiper, is that the gsoc project for doing translations? it was way cool |
| 18:13:33 | <djazayeri> rfriedman: would be great if we had people wanting to translate modules…do you think there's a general desire of people to do that, outside of particular implementation projects? |
| 18:13:58 | <jkeiper> rfriedman, yep! |
| 18:14:14 | <jkeiper> rfriedman, it lets you override htmlformentry messages too |
| 18:14:47 | <rfriedman> djazayeri, you never know what you can find when you ask ... also, it alerts users in those projects that not all the messages are xlated |
| 18:15:25 | <djazayeri> rfriedman: do you want to email the implementers list with a few bullet points giving the outlines of a proposal? |
| 18:15:48 | <rfriedman> sure, wky not, djazayeri |
| 18:16:42 | *** sgithens has joined #openmrs |
| 18:17:22 | *** cpower has joined #openmrs |
| 18:18:06 | <cpower> djazayeri do we know who should be the main community developer for the next two weeks? Who's next in the rotation? |
| 18:18:22 | <djazayeri> cpower: I don't know... |
| 18:18:41 | <cpower> wyclif_, any idea? |
| 18:18:45 | <djazayeri> cpower: seems like it should be dkayiwa next |
| 18:18:53 | <djazayeri> cpower: since both wyclif_ and rafal are doing it now |
| 18:19:15 | <djazayeri> cpower: since rafal just released 1.9.2 seems like he deserves a break, so it should be wyclif_ before him. :-) |
| 18:19:41 | <cpower> daniel's time should be up, and moving on to the next guy one would think. |
| 18:19:52 | <cpower> wyclif_ you around to input? |
| 18:20:29 | <djazayeri> cpower: daniel is working on the sprint now… wyclif and rafal are in the community dev swim lane now. |
| 18:23:25 | <cpower> ok, when does wyclif and rafal's time end? |
| 18:24:24 | <djazayeri> cpower: I believe they've been on it for 2.5 weeks already (we extended the appt sprint, right?) |
| 18:24:31 | <djazayeri> or will be at the end of the week |
| 18:24:45 | <djazayeri> cpower: maybe we should wait until wyclif_ is here. :-) |
| 18:24:55 | <cpower> yep |
| 18:30:24 | *** suranga__ has joined #openmrs |
| 18:34:06 | *** suranga_ has quit IRC |
| 18:37:43 | *** yony258 has joined #openmrs |
| 18:41:55 | *** afiles has joined #openmrs |
| 18:46:31 | <jkeiper> djazayeri, at mirebalais and rwinkwavu is registration synonymous with check-in, or are they separate processes / interfaces? |
| 18:46:57 | <djazayeri> jkeiper: at mirebalais (and lacolline, also in haiti) registration = patient creation, and check-in = check-in |
| 18:47:21 | <djazayeri> jkeiper: at mirebalais the plan is for them to happen at different windows |
| 18:47:34 | <jkeiper> djazayeri, okay ... how about rwinkwavu? |
| 18:47:40 | <djazayeri> jkeiper: i.e. everyone goes to the check-in window; new patients go to the registration window first. |
| 18:47:51 | <djazayeri> jkeiper: not sure about terminology (or workflow) there, actually. |
| 18:48:00 | <jkeiper> ok |
| 18:48:03 | <jkeiper> thanks djazayeri :-) |
| 18:49:57 | <rfriedman> djazayeri, jkeiper, got my fundraising pitch from PIH here ... think I should donate and earmark for reporting module documentation_ |
| 18:50:45 | *** lh has joined #openmrs |
| 18:51:14 | <jkeiper> oO that would be great :-) ... that and maybe something pascal was looking for, a way to add columns to a row-per-patient report by referencing properties on the patient (like personName or birthdate) |
| 18:51:46 | <djazayeri> rfriedman, jkeiper: I dunno, that's getting pretty specific with donations… :-) |
| 18:52:11 | <rfriedman> last year i asked for hamish to dance in his kilt, and he did it at your wedding |
| 18:52:13 | <jkeiper> haha true |
| 18:53:05 | <djazayeri> rfriedman: I should inform the gifts department that they can check that box off—not sure I made them aware. :-) |
| 19:00:29 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 2.4 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=uiframework&version=&2.4> |
| 19:18:13 | *** cpower has quit IRC |
| 19:37:47 | *** thompcha has joined #openmrs |
| 19:38:54 | *** thompcha has joined #openmrs |
| 19:49:32 | *** applecool has left #openmrs |
| 19:53:21 | *** cpower has joined #openmrs |
| 19:59:30 | *** kernelhunter92 has joined #openmrs |
| 19:59:37 | *** kernelhunter92 has left #openmrs |
| 20:00:42 | <djazayeri> demo server down... |
| 20:16:12 | <tobin_g> yony258: what's the great news?? |
| 20:20:32 | <tobin_g> !seen mdowney |
| 20:20:32 | <OpenMRSBot> tobin_g: I have not seen mdowney. |
| 20:23:25 | *** grahameg has joined #openmrs |
| 20:24:16 | *** dkayiwa has joined #openmrs |
| 20:33:24 | *** grahameg has quit IRC |
| 20:34:27 | *** tobin_g has quit IRC |
| 20:35:09 | *** tobin_g has joined #openmrs |
| 20:36:04 | *** cpower has quit IRC |
| 20:38:30 | <yony258> dkayiwa: Hi |
| 20:38:59 | <dkayiwa> yony258: hi |
| 20:39:19 | <yony258> dkayiwa: Just an update I succeeded to keep the selected values of the combo box and dates, workin now on the validation. |
| 20:39:41 | <dkayiwa> yony258: ok good :) |
| 20:41:30 | *** rafa has joined #openmrs |
| 20:41:30 | *** ChanServ sets mode: +v rafa |
| 20:44:43 | *** thompcha has quit IRC |
| 20:45:22 | *** thompcha has joined #openmrs |
| 20:45:51 | <yony258> dkayiwa: By the way, can you tell me how do I add "Create Appointment" to the main links bar? |
| 20:45:58 | *** thompcha has quit IRC |
| 20:46:27 | <dkayiwa> yony258: aren't you the one who added it? |
| 20:46:41 | <yony258> dkayiwa: Nope |
| 20:46:52 | <dkayiwa> yony258: who was it? |
| 20:47:15 | <yony258> dkayiwa: Im talking about the green bar at the top |
| 20:47:37 | <dkayiwa> yony258: oh i see |
| 20:47:44 | <dkayiwa> yony258: do you want it there instead? |
| 20:48:02 | <yony258> dkayiwa: yes |
| 20:48:13 | <dkayiwa> yony258: why? |
| 20:48:25 | <yony258> tobin_g: Here? |
| 20:48:36 | <yony258> dkayiwa: let me add tobin_g to this conversation |
| 20:49:45 | <tobin_g> yony258: hey |
| 20:50:02 | <tobin_g> yony258: what's up? |
| 20:50:16 | <yony258> tobin_g: "Create Appointment" link should be on the Administration page or on the green main links bar? |
| 20:51:38 | <tobin_g> yony258: eventually there will be a link on the main bar, but probably not to create appointment. It will be to the main appointment management screen which has not yet been built |
| 20:52:00 | <tobin_g> yony258: For now let's just keep it on the Admin page. Sound reasonable to you? |
| 20:52:23 | <tobin_g> yony258: If at a later time we decide to remove it and put it elsewhere is that a large change? |
| 20:53:04 | <yony258> tobin_g: Yes I just thought we could use the help from dkayiwa to do that, since I dont know how to do that and I couldn't find any documentation about it. But im fine with either. |
| 20:53:31 | <yony258> tobin_g: Its just doesn't sounds correct - setting an appointment from the administration page. |
| 20:53:58 | <tobin_g> yony258: I agree with you that it doesn't sound right to do it from there. |
| 20:54:13 | <yony258> tobin_g: If it will become a high frequency of use functionality there should be a way to access it easily with one click from anywhere |
| 20:54:26 | <tobin_g> yony258: one thing I've seen is that "all the functionality" of a module is often available from the admin page. |
| 20:54:57 | <tobin_g> yony258: two questions / ideas |
| 20:55:37 | <tobin_g> yony258: 1) what if we made a main page off the green bar called "appointments" then just had a hard-coded hyperlink on it to the create appointment page for now? eventually this will also have the list of appointments by day and be the main page that receptionist could use. |
| 20:55:53 | <yony258> tobin_g: dkayiwa Ok if its not important right now lets forget about it, I need dkayiwa help on something with an higher priority, if dkayiwa has time? :) |
| 20:55:57 | <tobin_g> yony258: 2) we could have no link at all to it for now, and just navigate using the URL |
| 20:56:09 | <tobin_g> yony258: ok |
| 20:56:18 | <dkayiwa> tobin_g: yony258 and you can always the mailing lists on suggestions concerning where it would be best to be put :) |
| 20:56:18 | *** adam_l_ has joined #openmrs |
| 20:56:53 | <yony258> dkayiwa: Ok, one last important thing before I can mark this as finished. |
| 20:57:00 | <tobin_g> dkayiwa: will do, but i think it'll be a more relevant discussion once we have the next (and in some ways final) screen of the software done |
| 20:57:17 | <adam_l_> dkayiwa: Hi daniel finally it's working with the simple view of fieldGen location |
| 20:57:18 | <yony258> dkayiwa: I want to validate that a time slot was selected, but I dont know how to do it |
| 20:57:30 | <dkayiwa> tobin_g: i agree!!! |
| 20:57:54 | <dkayiwa> adam_l_: excellet!!! :) |
| 20:58:03 | <tobin_g> adam_l_: ++ |
| 20:58:10 | <tobin_g> !karma adam_l_ |
| 20:58:10 | <OpenMRSBot> tobin_g: Karma for "adam_l_" has been increased 1 time and decreased 0 times for a total karma of 1. |
| 20:58:16 | <tobin_g> adam_l_++ |
| 20:58:22 | <dkayiwa> :D |
| 20:58:24 | <tobin_g> !karma adam_l_ |
| 20:58:24 | <OpenMRSBot> tobin_g: Karma for "adam_l_" has been increased 2 times and decreased 0 times for a total karma of 2. |
| 20:58:35 | <adam_l_> lol :) |
| 20:58:38 | <rfriedman> tobin_g, I've found it helpful to have a user landing page (for entering from role-based homepage module) or a main user page link in the admin section of the module (sort of like administer encounters under encounter) |
| 20:58:56 | <dkayiwa> yony258: just check that timeSlot != null :) |
| 20:59:19 | <tobin_g> rfriedman: thanks I agree :-) |
| 20:59:31 | <tobin_g> rfriedman: that's a really good idea that we can just link it with RBH in the meantime |
| 20:59:37 | <yony258> dkayiwa: Where to do that? |
| 21:00:14 | <yony258> dkayiwa: I thought I could use the Appointment validator for that |
| 21:00:35 | <tobin_g> rfriedman: I'm not sure how everything is designed, but I know you can also drop portlets onto RBH…maybe if our stuff is designed as such we can just put a little "appointment" portlet onto that page/ |
| 21:01:10 | <dkayiwa> yony258: yes in the appointment validator |
| 21:01:42 | <yony258> dkayiwa: I have that in the appointment validator... I just dont know how to present it since I can't put it inside the <spring:bind tag. |
| 21:01:53 | <tobin_g> dkayiwa: is there anyway to kick the CI server without michael's help? |
| 21:01:55 | <rfriedman> tobin_g, i just use RBH so people come to a landing page with their options, sort of the old switchboard design or darius' app design |
| 21:02:18 | <dkayiwa> tobin_g: i would be a hacker to get admin access to that machine :) |
| 21:02:34 | <tobin_g> dkayiwa: so what are you waiting for? |
| 21:02:48 | <tobin_g> rfriedman: :-) we're using it the same way |
| 21:02:49 | <dkayiwa> tobin_g: am waiting for skill :D |
| 21:03:13 | <tobin_g> !seen m_downey |
| 21:03:13 | <OpenMRSBot> tobin_g: I have not seen m_downey. |
| 21:03:24 | <dkayiwa> tobin_g: just cry out more while copying as many people as you can (to help just incase they know how to) |
| 21:03:44 | <tobin_g> dkayiwa: here? |
| 21:03:51 | <dkayiwa> tobin_g: email |
| 21:04:07 | <tobin_g> dkayiwa: I tried that once today, I guess I could add a few more people on there. |
| 21:04:07 | <dkayiwa> tobin_g: copy Burke too, he has some hacking skills :) |
| 21:04:20 | <tobin_g> dkayiwa: don't doubt that! |
| 21:04:40 | <dkayiwa> tobin_g: yes when you say it again, you will sound more in need for something to be done about it :) |
| 21:05:20 | <dkayiwa> tobin_g: you never know somebody could give him a phone call or pass by his house :) |
| 21:05:43 | <rfriedman> tobin_g, do an itsm incident report, downey keeps statistics on his service quality |
| 21:06:32 | <tobin_g> rfriedman: how? |
| 21:07:11 | <dkayiwa> rfriedman: :D |
| 21:07:23 | <rfriedman> tobin_g, create a ticket on the IT Service Management project |
| 21:07:38 | <tobin_g> rfriedman: ok i'll give him a few more hours |
| 21:07:57 | *** yony258 has quit IRC |
| 21:07:59 | <rfriedman> tobin_g, he'll just tell you to create a ticket |
| 21:08:06 | <tobin_g> rfriedman: oh ok |
| 21:08:16 | <tobin_g> rfriedman: ticket in progress |
| 21:08:23 | <rfriedman> tobin_g, you could e-mail him, then he'd create the ticket |
| 21:08:56 | <rfriedman> tobin_g, but he doesn't check his e-mail as often as he checks jira (i think he sets off the fire alarm when an itsm ticket is created) |
| 21:09:15 | <tobin_g> rfriedman: maybe his house actually catches fire |
| 21:09:51 | <dkayiwa> tobin_g: https://tickets.openmrs.org/browse/ITSM |
| 21:09:57 | <rfriedman> tobin_g, it's got to be virtual, maybe it turns his TV to the yule log channel |
| 21:10:01 | <tobin_g> dkayiwa: thx |
| 21:10:10 | <tobin_g> rfriedman: LOL |
| 21:11:01 | <tobin_g> dkayiwa: does the DB just need to be wiped clean b/c of something yonatan changed in the data model? |
| 21:11:06 | <tobin_g> dkayiwa: just want to ticket the right thing |
| 21:11:10 | <dkayiwa> tobin_g: yes |
| 21:12:50 | <tobin_g> dkayiwa: would this be considered a problem with bamboo? |
| 21:13:01 | <dkayiwa> tobin_g: no |
| 21:13:33 | <dkayiwa> tobin_g: it is just a db change we make which requires manual changes during development |
| 21:13:48 | *** yony258 has joined #openmrs |
| 21:13:55 | <yony258> dkayiwa: sorry had a DC |
| 21:14:16 | <dkayiwa> yony258: am used to that :) |
| 21:15:09 | <yony258> dkayiwa: My problem now is that the previously loaded List of Time Slots is not saved between posts. |
| 21:15:12 | <yony258> dkayiwa: For example: |
| 21:15:48 | *** lh has quit IRC |
| 21:16:15 | *** suranga__ has quit IRC |
| 21:16:46 | <yony258> dkayiwa: The form loads - no time slots loaded (OK). User enters details and clicks "Find Available Times" which loads the time slots. (OK) The user selects a time slot and click save. when we come back to this screen its like no slots ever loaded (BAD) like we lost the value of availableTimes model attrinbute. |
| 21:16:51 | <yony258> *attribute |
| 21:17:34 | <dkayiwa> yony258: does your controller look like the one i pastebinned? |
| 21:18:12 | <yony258> dkayiwa: No because on the one you pastebinned you load the time slots when the user enters the screen, and its different than what we planned. |
| 21:18:23 | <yony258> *enters the form |
| 21:19:03 | <tobin_g> adam_l_: now that you have locations working what are the next steps? |
| 21:19:45 | <yony258> dkayiwa: If I wasn't clear let me know. :) |
| 21:19:54 | <tobin_g> rfriedman: took about 9 seconds for downey to change the status to In Progress. what a guy! |
| 21:20:27 | <dkayiwa> yony258: the method body was just a place holder |
| 21:20:45 | <dkayiwa> yony258: in the same method, you can just load no time slots when dates are null |
| 21:20:56 | <dkayiwa> yony258: that way it will not load them for the first time |
| 21:21:12 | <yony258> dkayiwa: Dates can be null (Its an optional constraint) |
| 21:21:17 | <adam_l_> tobin_g: I'm trying the date picker widget. |
| 21:21:17 | <rfriedman> tobin_g, tolja |
| 21:21:32 | <yony258> dkayiwa: Dates can be null even after the first time |
| 21:21:34 | <dkayiwa> yony258: both? |
| 21:21:37 | <tobin_g> rfriedman++ |
| 21:21:44 | <yony258> dkayiwa: Yes |
| 21:22:13 | <tobin_g> adam_l_: ok great. if you have questions you can ask dkayiwa |
| 21:22:36 | <yony258> dkayiwa: I think it will be easier if I'll just push. and then you should enter the form, click Find Available Times, do not select any option, and click save |
| 21:23:29 | <adam_l_> tobin_g: sure right now no blockers :) |
| 21:24:14 | *** dkayiwa_ has joined #openmrs |
| 21:24:40 | <tobin_g> adam_l_: ok fantastic. let us know when you commit :-) |
| 21:25:29 | <adam_l_> tobin_g: ok |
| 21:25:43 | *** dkayiwa has quit IRC |
| 21:25:44 | *** dkayiwa_ is now known as dkayiwa |
| 21:27:51 | *** cpower has joined #openmrs |
| 21:28:00 | <cpower> wyclif_ you around? |
| 21:28:41 | <cpower> ok, Darius how about you? |
| 21:28:51 | <djazayeri> yes |
| 21:29:22 | <djazayeri> eating lunch though |
| 21:31:04 | <cpower> ok, I'll bug you later, just looking at what we think the Community Developer's should be doing (bug fixing, new dev help, curating tickets...what else) |
| 21:31:39 | <yony258> dkayiwa: How can I update the value of the ModelAttribute "availableTimes"? |
| 21:31:54 | <tobin_g> hey cpower good timing - wanted to check in with you about sprint wrap-up |
| 21:32:21 | <dkayiwa> yony258: do you still have it as in my contriller? |
| 21:32:36 | <yony258> dkayiwa: no |
| 21:32:49 | <cpower> We should do that as a part of the developer meeting on Thursday if you can? |
| 21:33:09 | <tobin_g> cpower: you're talking to me i assume? |
| 21:33:09 | <dkayiwa> yony258: if you do, it should refresh for every submit |
| 21:33:32 | <yony258> dkayiwa: Im not sure what you mean, but if you can please pastebin again? |
| 21:33:51 | <yony258> dkayiwa: NVM found it |
| 21:34:29 | <cpower> yep |
| 21:34:54 | <tobin_g> cpower: so what should i be ready for? who should come? |
| 21:35:09 | <yony258> dkayiwa: But the problem is On the first time it should be empty and than when the user press "Find Available Times" it should get the list of timeslots according to what was entered and keep the availableTimes ModelAttribute updated. ok? |
| 21:35:41 | <cpower> I'll send you and email Tobin about it. |
| 21:35:48 | <dkayiwa> yony258: yes it will be empty if you return empty list when dates are null |
| 21:35:55 | <cpower> It's nothing big, but I've got to run to another meeting |
| 21:35:59 | <tobin_g> cpower: thx :) |
| 21:36:03 | *** cpower has quit IRC |
| 21:36:15 | <yony258> dkayiwa: But dates can be null on other calls too........ |
| 21:36:23 | <yony258> sorry for the dots (accidentaly) |
| 21:36:43 | <dkayiwa> yony258: do you have cases when dates are null and you need time slots? |
| 21:36:54 | <yony258> dkayiwa: Yes |
| 21:37:07 | <dkayiwa> yony258: so are those time slots loaded without dates? |
| 21:37:32 | <yony258> dkayiwa: I think you or me talking about different Dates |
| 21:37:44 | <dkayiwa> yony258: :) |
| 21:38:00 | <dkayiwa> yony258: am refering to dates that filter time slots |
| 21:38:10 | <dkayiwa> yony258: as per: http://pastebin.com/ve0YbmGg |
| 21:38:40 | <yony258> dkayiwa: Im talking about the fromDate, toDate which represents the interval of dates for the appointment to be scheduled. (For example: The patient want to set an appointment in the next month) |
| 21:39:08 | <dkayiwa> yony258: and its based on those dates that we get the available time slots. not so? |
| 21:39:32 | <yony258> dkayiwa: This is optional, so that if you dont enter those values this means -> I want to set an appointment whenever possible, |
| 21:40:08 | <dkayiwa> yony258: oh i see |
| 21:40:13 | <tobin_g> yony258: dkayiwa presumably for the next possible date |
| 21:40:24 | <dkayiwa> tobin_g: ok |
| 21:40:27 | <tobin_g> yony258: dkayiwa although that may be part of a later algorithm that we work out, to save some of the closer dates |
| 21:41:05 | <dkayiwa> yony258: i still do not see the logic changing in that controller |
| 21:41:16 | <dkayiwa> yony258: because all it considers are those dates |
| 21:41:28 | <dkayiwa> yony258: if they are null, it loads all available time slots |
| 21:41:59 | <yony258> dkayiwa: But on the first time a user enters the form they are null, and I do not want to show any time slots. |
| 21:42:21 | <dkayiwa> yony258: why? |
| 21:42:57 | <tobin_g> yony258: dkayiwa i agree it should be blank originally. because at least appointment type is required. |
| 21:43:37 | <yony258> dkayiwa: No need to present not relevant information if the user didn't even entered the constraints for the appoinment. |
| 21:43:42 | <yony258> appointment |
| 21:43:44 | <tobin_g> yony258: we may want to indicate something like "no appointments found" to differentiate from just a blank screen? |
| 21:44:51 | <yony258> tobin_g: Right now lets say we are just entered this screen. We dont need anything there since the user didn't enter any details. |
| 21:45:03 | <tobin_g> yony258: makes sense to me |
| 21:48:29 | <yony258> dkayiwa: And it all can be solved if I could update the ModelAttribute to a new value and make it persistent. |
| 21:49:13 | <dkayiwa> yony258: what do you mean by make it persistent? |
| 21:50:08 | <yony258> dkayiwa: That it's value will not disappear after the next POST. |
| 21:51:41 | <dkayiwa> yony258: you could make it a session attribute |
| 21:56:05 | *** lh has joined #openmrs |
| 21:56:12 | *** rafa has quit IRC |
| 21:59:38 | <yony258> dkayiwa: Why this won't work? |
| 21:59:44 | <yony258> dkayiwa: http://pastebin.com/mPqL40FY |
| 22:00:00 | <yony258> dkayiwa: Focus on getAvailableTimes and onFindTimesClick |
| 22:00:17 | <yony258> dkayiwa: When I click the button nothing happens |
| 22:01:33 | <dkayiwa> yony258: whats the button name |
| 22:01:37 | *** sgithens has quit IRC |
| 22:02:02 | <yony258> dkayiwa: findAvailableTime |
| 22:02:29 | <dkayiwa> yony258: pastebin the jsp |
| 22:02:55 | <yony258> dkayiwa: http://pastebin.com/dAJeLNys |
| 22:03:17 | <dkayiwa> yony258: assuming no browser catching |
| 22:03:28 | <tobin_g> !ticket AM-6 |
| 22:03:29 | <OpenMRSBot> tobin_g: [#AM-6] Add/Edit Appointment Block - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-6 |
| 22:03:31 | <dkayiwa> yony258: and that you compiled and redeployed |
| 22:06:05 | <yony258> dkayiwa: Cleared Cache, mvn install, redeployed -> Same Error |
| 22:06:50 | <dkayiwa> yony258: which error |
| 22:07:05 | <yony258> dkayiwa: Sorry not an error, just that nothing happens |
| 22:07:44 | <dkayiwa> yony258: are you running in debug mode |
| 22:07:58 | <yony258> dkayiwa: No problem occurs on debug mode |
| 22:08:18 | <dkayiwa> yony258: which problem |
| 22:10:34 | <yony258> dkayiwa: Try this: |
| 22:11:20 | <yony258> dkayiwa: 1. open the form, select a start date and click "Find Available Times", let me know what you see, ok? |
| 22:11:34 | <yony258> dkayiwa: Oh sorry I didn't pushed |
| 22:11:46 | <yony258> dkayiwa: Than let me describe what happens |
| 22:12:23 | <yony258> dkayiwa: 1. Open the form, select start date, click find available times -> gets a list of time slots (GOOD) |
| 22:12:49 | <yony258> dkayiwa: 2. Open the form, click findAvailableTimes -> nothing happens (BAD) |
| 22:13:12 | <yony258> dkayiwa: Why is that? |
| 22:13:33 | <dkayiwa> yony258: whats the difference in steps |
| 22:13:57 | <yony258> dkayiwa: In 1 I chose a start date, In 2 I didn't |
| 22:14:04 | <yony258> dkayiwa: Let me show you what I did in the controller: |
| 22:14:09 | <djazayeri> rfriedman: can you please restate HTML-402 to be clearer then? Thanks! |
| 22:14:11 | <yony258> dkayiwa: http://pastebin.com/DBvKEyaz |
| 22:15:01 | <dkayiwa> yony258: run it in debug mode |
| 22:15:26 | <yony258> dkayiwa: I ran it in debug mode already, its good |
| 22:15:48 | <yony258> dkayiwa: Why on option 1 the availableTimes ModelAttribute doesn't change? |
| 22:16:23 | <dkayiwa> yony258: meaning problem does not happen in debug mode? |
| 22:16:31 | <yony258> dkayiwa: correct |
| 22:17:01 | <dkayiwa> yony258: can you try again now in debug mode |
| 22:17:27 | <yony258> dkayiwa: What do you want that I'll check? |
| 22:18:12 | <dkayiwa> yony258: that your code executes the expected methods/paths. and UI behaves well |
| 22:20:49 | *** basic is now known as basic` |
| 22:24:54 | <yony258> dkayiwa: I already debugged everything, cleared cache, compiled. But I can't understand why Im getting a different result in those 2 cases |
| 22:25:26 | <yony258> dkayiwa: When a user do not define fromDate, I just assign the current Date and Time to that variable in the controller. |
| 22:26:32 | <tobin_g> dkayiwa is it possible that the format of the current time yony258 set is slightly different from what is returned from that widget? Or it's being processed differently for some reason? |
| 22:27:22 | <dkayiwa> tobin_g: you can set the time format |
| 22:27:46 | <tobin_g> dkayiwa: hmmm. any idea why the code isn't working? seems like yony258 has tried to debug |
| 22:28:08 | <dkayiwa> yony258: pushed? |
| 22:28:28 | <yony258> dkayiwa: Let me push :) |
| 22:29:06 | <yony258> dkayiwa: pushed |
| 22:29:34 | <dkayiwa> yony258: ok. how should i reproduce the problem |
| 22:29:52 | <yony258> [00:12] <yony258> dkayiwa: 1. Open the form, select start date, click find available times -> gets a list of time slots (GOOD) [00:12] <yony258> dkayiwa: 2. Open the form, click findAvailableTimes -> nothing happens (BAD) |
| 22:30:04 | <dkayiwa> yony258: ok |
| 22:37:05 | <dkayiwa> yony258: mine loads time slots for the second time too |
| 22:37:57 | <yony258> dkayiwa: Mine don't |
| 22:38:06 | <yony258> dkayiwa: Tried on different browsers, cleared cache |
| 22:38:24 | <dkayiwa> yony258: unless you gave me different steps |
| 22:38:58 | <tobin_g> dkayiwa: yony258 CI is back up :-) |
| 22:39:07 | <yony258> dkayiwa: Try: clear cache, Open "Create Appointment Form", click "Find Available Times" |
| 22:39:27 | <dkayiwa> yony258: without choosing date? |
| 22:39:30 | <tobin_g> yony258: are you guys hard-coding blocks into the DB or how are you accomplishing this? |
| 22:39:33 | <yony258> dkayiwa: Without |
| 22:39:50 | <yony258> tobin_g: I have a SQL query that creates blocks and time slots |
| 22:39:52 | <tobin_g> yony258: just trying to replicate on that server to see behavior |
| 22:40:06 | <dkayiwa> yony258: it loaded the time slots |
| 22:42:18 | <tobin_g> dkayiwa: yony258 on the CI server it has some weird behavior - if you define a date, no problem. if you don't define a date it kind of wigs out |
| 22:42:22 | <tobin_g> http://gw65.iu.xsede.org:8080/openmrs/module/appointment/appointmentForm.form |
| 22:42:26 | <OpenMRSBot> <http://ln-s.net/+GdN> (at gw65.iu.xsede.org:8080) |
| 22:42:51 | <dkayiwa> yony258: compile module and give tobin_g to test also |
| 22:43:33 | <tobin_g> theoretically it should be complied and running on CI right? |
| 22:44:48 | <tobin_g> dkayiwa: how do i get some appointment block/slot info into the database? |
| 22:44:50 | <yony258> dkayiwa: I dont know what is the problem I tried everything |
| 22:45:16 | <dkayiwa> tobin_g: yony258 can direct you |
| 22:45:35 | <yony258> tobin_g: You need to connect to the DB and run this queries: |
| 22:45:37 | <yony258> tobin_g: http://pastebin.com/S115VyFP |
| 22:45:49 | <tobin_g> yony258: thx |
| 22:46:00 | <yony258> dkayiwa: Its probably something you have that I don't |
| 22:46:06 | <tobin_g> yony258: i'll have to run it on the local machine then, not CI since I don't have direct DB access on CI |
| 22:46:21 | <dkayiwa> yony258: compile and give tobin_g to test |
| 22:46:34 | <yony258> tobin_g: Correct |
| 22:46:58 | <yony258> tobin_g: Let me send you the omod via Skype |
| 22:47:05 | <tobin_g> k |
| 22:49:09 | <yony258> tobin_g: Let me know if you need help, you can screen share via Skype |
| 22:50:54 | <tobin_g> yony258: gimme a sec I should have it working |
| 22:51:15 | <tobin_g> yony258: actually i'm going to start with a fresh standalone hold on |
| 22:51:50 | *** upul` has joined #openmrs |
| 22:51:50 | *** ChanServ sets mode: +v upul` |
| 22:52:54 | *** upul` has left #openmrs |
| 22:55:29 | <tobin_g> yony258: dkayiwa i have the same behavior as yonatan |
| 22:55:52 | <tobin_g> yony258: dkayiwa until i click the first date box, nothing appears when I click find available times |
| 22:56:43 | *** dkayiwa has quit IRC |
| 22:57:43 | <tobin_g> yony258: ie i think there is a problem |
| 22:57:49 | <tobin_g> yony258: looks like we lost daniel |
| 22:58:25 | <tobin_g> adam_l_: still hacking away? |
| 22:58:59 | <adam_l_> tobin_g: I have problem with the dates. |
| 22:59:30 | <tobin_g> adam_l_: :-( daniel just got booted but I'm sure he'll be back shortly, need help? |
| 22:59:41 | <tobin_g> adam_l_: or are you still tinkering? |
| 22:59:58 | <adam_l_> tobin_g: yeah maybe he know what to do |
| 23:00:15 | <tobin_g> adam_l_: ok keep an eye out he should be back, i bet he just lost internet or something |
| 23:07:33 | <tobin_g> adam_l_: maybe yony258 can help you? Perhaps daniel lost power or internet |
| 23:08:19 | <yony258> adam_l_: sure ask away, If it is similar to something I did I may be able to help. |
| 23:08:38 | <yony258> adam_l_: But if its too late we can do that tomorrow too |
| 23:09:06 | *** jkeiper has quit IRC |
| 23:09:40 | <tobin_g> adam_l_: yony258 since i'm going to bed I think you guys should too! we're making progress so that's what's good :-) |
| 23:09:58 | <adam_l_> yony258: I have a problem that the format of the Date I get from the widget is not similar to the format of the Date from the java classes on the api |
| 23:11:18 | <yony258> adam_l_: Oh... I didn't encountered that problem, maybe we'll see tomorrow |
| 23:11:55 | *** jkeiper has joined #openmrs |
| 23:11:55 | *** ChanServ sets mode: +v jkeiper |
| 23:12:00 | <tobin_g> adam_l_: yony258 thanks to both for staying up late know it's been a long day |
| 23:12:04 | <adam_l_> yony258: ok |
| 23:12:26 | <yony258> tobin_g: adam_l_ Good night all |
| 23:12:38 | <adam_l_> yony258: tobin_g good night |
| 23:13:34 | *** tobin_g has quit IRC |
| 23:14:40 | *** rfriedman has quit IRC |
| 23:17:07 | *** adam_l_ has quit IRC |
| 23:17:35 | *** yony258 has quit IRC |
| 23:28:56 | *** lh has quit IRC |