IRC Chat : 2012-12-09 - OpenMRS

00:07:36 *** Mkop has joined #openmrs
00:07:36 *** ChanServ sets mode: +v Mkop
01:14:40 *** djazayeri1 has quit IRC
01:16:40 *** djazayeri has joined #openmrs
01:16:40 *** ChanServ sets mode: +o djazayeri
03:21:38 *** jkeiper has quit IRC
03:24:32 *** djazayeri has quit IRC
04:02:35 *** wyclif_ has quit IRC
04:26:17 *** sgithens has quit IRC
06:32:43 *** djazayeri has joined #openmrs
06:32:43 *** ChanServ sets mode: +o djazayeri
07:58:49 *** k-joseph has joined #openmrs
08:12:11 *** k-joseph has quit IRC
08:12:58 *** djazayeri has quit IRC
08:14:15 *** tobin_g has joined #openmrs
08:16:30 *** k-joseph has joined #openmrs
08:37:52 *** wyclif_ has joined #openmrs
08:52:02 *** k-joseph has quit IRC
08:52:57 *** k-joseph has joined #openmrs
09:11:03 *** k-joseph has quit IRC
09:14:25 *** k-joseph has joined #openmrs
09:31:04 *** k-joseph has quit IRC
09:34:14 *** k-joseph has joined #openmrs
09:51:32 *** k-joseph has quit IRC
10:11:40 *** Mkop has quit IRC
10:34:45 *** k-joseph has joined #openmrs
10:35:51 *** k-joseph has quit IRC
11:03:07 *** Mkop has joined #openmrs
11:03:07 *** ChanServ sets mode: +v Mkop
11:09:32 *** dkayiwa has joined #openmrs
11:18:57 *** tobin_g has quit IRC
11:27:46 *** Mkop has quit IRC
11:33:41 *** dkayiwa_ has joined #openmrs
11:35:51 *** dkayiwa has quit IRC
11:35:51 *** dkayiwa_ is now known as dkayiwa
11:59:42 *** dkayiwa has quit IRC
12:05:59 *** dkayiwa has joined #openmrs
12:10:31 *** rafa has joined #openmrs
12:10:31 *** ChanServ sets mode: +v rafa
12:18:01 *** Mkop has joined #openmrs
12:18:01 *** ChanServ sets mode: +v Mkop
12:35:06 *** Mkop has quit IRC
12:35:12 *** Mkop1 has joined #openmrs
12:35:12 *** ChanServ sets mode: +v Mkop1
12:41:36 *** k-joseph has joined #openmrs
12:48:57 *** yony258 has joined #openmrs
12:49:02 <yony258> dkayiwa: Hi :)
12:49:20 <k-joseph> dkayiwa: hi
12:49:39 *** yony258 has quit IRC
12:49:55 *** yony258 has joined #openmrs
12:49:59 <dkayiwa> yony258: k-joseph let me be back in a moment :)
12:50:10 <yony258> dkayiwa: Ok sure, let me know when available.
12:50:26 <k-joseph> dkayiwa: ok
13:00:29 *** rafa has quit IRC
13:22:06 *** tobin_g has joined #openmrs
13:26:39 *** dkayiwa has quit IRC
13:48:13 *** dkayiwa has joined #openmrs
14:01:45 <yony258> dkayiwa: Let me know when available :P
14:29:26 *** k-joseph has quit IRC
14:33:47 *** k-joseph has joined #openmrs
14:36:03 *** batkinson has joined #openmrs
15:02:14 *** tobin_g has quit IRC
15:08:56 <k-joseph> .
15:55:15 <yony258> dkayiwa: ?
16:06:57 *** sgithens has joined #openmrs
16:09:21 *** kjoseph has joined #openmrs
16:09:43 *** k-joseph has quit IRC
16:17:48 *** kjoseph has quit IRC
17:07:16 *** tobin_g has joined #openmrs
17:08:00 *** Vishrut has joined #openmrs
17:12:31 <tobin_g> hey dkayiwa
17:26:57 *** Anuruddha has joined #openmrs
17:30:14 *** dkayiwa has quit IRC
18:29:41 *** rafa has joined #openmrs
18:29:41 *** ChanServ sets mode: +v rafa
18:41:13 *** rafa has quit IRC
19:02:16 *** Anuruddha has quit IRC
19:14:43 *** rafa has joined #openmrs
19:14:43 *** ChanServ sets mode: +v rafa
19:16:04 *** dkayiwa has joined #openmrs
19:17:10 <dkayiwa> hi yony258
19:17:35 <yony258> dkayiwa: hi
19:17:56 <dkayiwa> yony258: sorry i took long to come back
19:18:05 <dkayiwa> yony258: somebody else stayed using my laptop
19:18:14 <yony258> dkayiwa: its ok its a Sunday after all... :)
19:18:46 <dkayiwa> yony258: :D
19:18:57 <yony258> dkayiwa: I'll need help but in like 20min ok?
19:19:05 <dkayiwa> yony258: you are too forgiving :)
19:19:14 <dkayiwa> yony258: thats very ok :0
19:19:15 <dkayiwa> :)
19:24:31 *** adam_l_ has joined #openmrs
19:26:59 *** rkorytkowski has joined #openmrs
19:26:59 *** ChanServ sets mode: +v rkorytkowski
19:28:08 *** rafa has quit IRC
19:40:26 <adam_l_> dkayiwa: Hi daniel... can't I add onChange event to a fieldGen?
19:41:12 <yony258> dkayiwa: tobin_g adam_l_ Im ready to scrum whenever you want.
19:41:57 <tobin_g> yony258: ok i'm ready
19:41:57 <tobin_g> dkayiwa: you there?
19:48:43 <yony258> tobin_g: Its better that we scrum without dkayiwa than not scrum at all
19:49:05 <tobin_g> yony258: agreed. dkayiwa was here a few minutes ago though, right?
19:49:24 <yony258> tobin_g: half an hour ago
19:49:31 <yony258> !scrumon
19:49:31 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready.
19:49:36 <yony258> order: adam_l_ yony258 tobin_g
19:49:51 <adam_l_> yony258: *Today: working on the location and date functionallity on the appointmentBlock UI. added DWR service and methods needed. hope to finish this today.
19:50:06 <adam_l_> yony258: Blockers: I have some question about how to trigger the function I wrote on Java Script.
19:50:33 <yony258> * Yesterday: finished changing to HQL query (the patient details feature),
19:50:56 <yony258> *Today: tried to make some progress with the "Find Available Time" feature
19:51:55 <yony258> * Blockers: How to bind values that are not properties of the object, radio button binding on the same topic, and ! understanding what is going behind the scene for this issues
19:51:59 <yony258> tobin_g:
19:52:10 <tobin_g> past few days: reviewing tickets, reviewing what's been created, planning
19:52:10 <tobin_g> future: review module more in depth (and comment on AM-5 for Daniel), start to ticket "bugs," support where needed
19:52:11 <tobin_g> blockers: none
19:52:33 <yony258> tobin_g: What about those mock-ups?
19:53:02 <tobin_g> yony258: that too! I guess I've been focusing on the more immediate tickets though.
19:53:09 <yony258> tobin_g: cool
19:53:12 <yony258> !scrumoff
19:53:12 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
19:53:44 <tobin_g> yony258: adam_l_ officially I think the sprint ends tonight, not sure what kind of access we'll have to dkayiwa tomorrow and moving forward.
19:54:15 <tobin_g> but ideally i'd like dkayiwa to help with reviewing commits etc and help us establish our own process for this as well
19:54:19 <yony258> tobin_g: I can say that I can not proceed without the help of a Spring Framework expert
19:54:56 <tobin_g> yony258: noted, dkayiwa should be able to help. if not I'll help you find others.
19:55:05 <yony258> tobin_g: great.
19:55:27 <tobin_g> yony258: adam_l_ i'm also going to start working on the sprint wrap-up documentation which i may have some questions for you guys about. want to write down what worked and what didn't etc.
19:55:40 <yony258> tobin_g: sure
19:55:43 <tobin_g> yony258: adam_l_ but we'll talk more about that after the sprint
19:55:45 <adam_l_> tobin_g: ok
19:56:00 <tobin_g> adam_l_: yony258 i'd really like to see both of your tickets done
19:56:20 <yony258> tobin_g: lol
19:56:32 <tobin_g> adam_l_: if you can pickup AM-6 that would also be amazing - it was an oversight not making it more obviously part of AM-3
19:56:44 <yony258> tobin_g: I have no problem marking this as done, but there are more stuff to do
19:56:49 <yony258> tobin_g: AM-11 is done
19:56:54 <tobin_g> yony258: :)
19:57:00 <tobin_g> yony258: that's excellent
19:57:11 <yony258> tobin_g: Its just the DB set up...
19:57:17 <tobin_g> yony258: adam_l_ i think overall we've been very successful but we'll debrief later on.
19:58:14 <tobin_g> yony258: adam_l_ i'm going to run for a bit but i'll check back shortly.
19:58:35 <yony258> tobin_g: Im here waiting for dkayiwa so feel free to ping
19:58:38 <adam_l_> tobin_g: ok see you later
19:58:48 <adam_l_> yony258: *
20:02:40 *** tobin_g has quit IRC
20:07:01 <yony258> dkayiwa: Let me know when youre here
20:12:50 <dkayiwa> yony258: am here now :)
20:13:14 <yony258> dkayiwa: Ok great, let me push my changes
20:13:21 <dkayiwa> yony258: ok
20:15:57 <yony258> dkayiwa: ok pushed, but since your DB is probably empty, let me attach a screen shot
20:15:58 <yony258> dkayiwa: http://i.snag.gy/3sArA.jpg
20:16:34 <dkayiwa> yony258: ok
20:16:53 <adam_l_> dkayiwa: hi :) how can I access a value of a fieldGen in JavaScript?
20:17:13 <dkayiwa> yony258: woow!! looks so nice :)
20:17:22 <dkayiwa> adam_l_: like what value? :)
20:17:28 <adam_l_> dkayiwa: location id
20:17:45 <dkayiwa> adam_l_: the selected location_id?
20:17:56 <adam_l_> dkayiwa: yes
20:18:00 <yony258> dkayiwa: I was considering doing that using DWR but than decided to go with the Controller since It made more sense to me, is that ok?
20:18:13 <dkayiwa> adam_l_: yony258 should show you how he did it :)
20:18:39 <dkayiwa> yony258: does the page post back?
20:18:41 <yony258> dkayiwa: Let me specify that this table is actually a List of TimeSlots
20:18:53 <yony258> dkayiwa: yes
20:19:12 <dkayiwa> yony258: did you show it to Tobin?
20:19:20 <yony258> dkayiwa: nope
20:19:32 <adam_l_> dkayiwa: ok thanks
20:19:40 <dkayiwa> yony258: it is a matter of which gives a better user experience
20:19:51 <dkayiwa> yony258: so if Tobin accepts it, then why not
20:20:30 <yony258> dkayiwa: I now can think of 2 problems: 1. How do I bind the selected timeSlot? (been looking and reading all over the web today). 2. How do I send the selected appointment type, clinician to the controller? (using RequestParam?)
20:21:28 <dkayiwa> yony258: how does one select a time slot? (user interface wise)
20:21:33 <yony258> dkayiwa: Related to question 1: I tried <spring:bind path="appointment.timeSlot" , I tried <form:radiobutton path="slot"
20:21:38 <yony258> dkayiwa: Using the radio buttons
20:22:53 <dkayiwa> yony258: ok
20:22:58 *** tobin_g has joined #openmrs
20:23:44 <dkayiwa> yony258: let me look at the code and advice accordingly
20:24:23 <yony258> dkayiwa: םל
20:24:25 <yony258> dkayiwa: ok
20:26:58 <tobin_g> hey dkayiwa
20:27:12 <tobin_g> dkayiwa: wanted to check in with you regarding wrap-up for the sprint.
20:27:21 <dkayiwa> tobin_g: ok
20:27:28 <tobin_g> dkayiwa: based on the scrum both yony258 and adam_l_ have some things they need help with on their tickets
20:27:44 <tobin_g> dkayiwa: (i think you're workin' on that now)
20:27:58 <dkayiwa> tobin_g: ok
20:28:01 <tobin_g> dkayiwa: i think once those are submitted we will have met our goals?
20:28:36 <tobin_g> dkayiwa: since we'll be continuing with development one thing that would be very helpful is if you can help us establish some sort of code-review process (or continue being involved in that if you have time later).
20:28:50 <dkayiwa> tobin_g: ok
20:30:08 <tobin_g> dkayiwa: also, do you have the ability to fix the CI server?
20:30:26 <dkayiwa> tobin_g: i have no permissions :)
20:30:37 <tobin_g> dkayiwa: what needs to happen?
20:30:57 <dkayiwa> tobin_g: may need root access to restart tomcat
20:31:23 <tobin_g> dkayiwa: hm. seems like CI needs some fine tuning to be useful
20:31:53 <dkayiwa> tobin_g: correct
20:34:03 <tobin_g> dkayiwa: so in terms of code-review when you're no longer officially on board, how do you suggest we do that?
20:34:57 <dkayiwa> tobin_g: i think i should be able to review your code because the guys will be putting in less hours
20:35:00 <adam_l_> yony258:do you know how to trigger a java script function via <openmrs:fieldGen... ? I have tried 'callback' and 'onChange' but those are not suported.
20:35:09 *** djazayeri has joined #openmrs
20:35:09 *** ChanServ sets mode: +o djazayeri
20:35:20 <tobin_g> dkayiwa: ok thank you :)
20:35:35 <yony258> adam_l_: I have no idea what is a <openmrs:fieldGen
20:35:40 <dkayiwa> tobin_g: thank you too for all you and team are doing
20:35:55 <adam_l_> yony258: ok thanks anyway
20:36:01 <adam_l_> dkayiwa: do you know how to trigger a java script function via <openmrs:fieldGen... ? I have tried 'callback' and 'onChange' but those are not suported.
20:36:09 <dkayiwa> adam_l_: as you give up so easily :)
20:36:25 <tobin_g> dkayiwa: at some point we'll decide to "release" the module which I guess it means it'll go up on the module repository, does anything special need to happen for this? or we just have to decide it's good enough.
20:37:02 <dkayiwa> adam_l_: can you pastebin for me your jsp?
20:37:03 <adam_l_> dkayiwa: because I can't find information about it on the internet
20:37:12 <adam_l_> dkayiwa: yes
20:37:23 <dkayiwa> tobin_g: first step would you deciding that its good enough
20:37:37 <dkayiwa> tobin_g: then create documentation wiki pages
20:37:46 <dkayiwa> tobin_g: both developer and user documentation
20:38:02 <dkayiwa> tobin_g: then upload to module respository
20:38:29 <adam_l_> dkhttp://pastebin.com/giwET8mH
20:38:30 <dkayiwa> tobin_g: and finally send out a release announcement email to the dev and implementers lists
20:38:45 <adam_l_> dkayiwa: http://pastebin.com/giwET8mH
20:38:52 <dkayiwa> adam_l_: ok
20:39:59 <adam_l_> dkayiwa: I tried some stuff so there can be mistakes in the code
20:40:40 <tobin_g> dkayiwa: got it, excellent
20:40:57 <tobin_g> dkayiwa: over the next couple days i'll write up the sprint de-brief, will obviously consult you
20:41:00 <dkayiwa> adam_l_: can you send me one where you have put stuff back? :)
20:41:11 <dkayiwa> adam_l_: one with no mistake
20:41:19 <dkayiwa> tobin_g: ok
20:41:38 <adam_l_> dkayiwa: ok
20:42:45 <adam_l_> dkayiwa: http://pastebin.com/4CT2vrA5
20:43:28 <adam_l_> dkayiwa: now the problem is I don't know how to trigger the function updateAppointmentBlockTable().
20:43:38 <dkayiwa> adam_l_: ok
20:44:01 <adam_l_> dkayiwa: I need to trigger it when the date and/or the location changes.
20:45:31 <dkayiwa> adam_l_: ok. looking at it now
20:46:39 <yony258> dkayiwa:
20:51:32 <adam_l_> dkayiwa: I can do like "apply" button that triggers the function or something but still I don't know how to retrive the value of <openmrs:fieldGen:
20:52:38 <dkayiwa> adam_l_: ok
20:57:02 <dkayiwa> adam_l_: did you say onChange did not work for you?
20:57:36 <adam_l_> on fieldGen not but on the calendar yes
20:58:19 <adam_l_> dkayiwa: It's not suported by fieldGen
20:59:32 <adam_l_> dkayiwa: It will be helpful if there is a way to access the locationId selected via javaScript. like document.getElementById('') or something like that
21:02:26 <dkayiwa> adam_l_: did you add onChange as an attribute of the tag?
21:03:01 <dkayiwa> adam_l_: yony258 guys is it ok if we continue from here tomorrow? :)
21:03:26 <adam_l_> dkayiwa: yes I got an error saying that tag <openmrs:FieldGen is not suporting onChange
21:03:43 <adam_l_> dkayiwa: ok no problem...
21:03:43 <dkayiwa> adam_l_: yony258 thanks!!!
21:03:52 <dkayiwa> adam_l_: yony258 see you tomorrow
21:03:57 <adam_l_> dkayiwa: thank you :) you helped us alot
21:04:15 <adam_l_> dkayiwa: take care and good night...
21:04:29 <dkayiwa> adam_l_: you two helped us most
21:04:43 <dkayiwa> adam_l_: thanks and have a good night too
21:05:00 *** dkayiwa has quit IRC
21:05:21 *** adam_l_ has quit IRC
21:13:47 *** yony258 has quit IRC
21:26:12 *** sgithens has quit IRC
21:30:49 *** sgithens has joined #openmrs
22:05:25 *** tobin_g has quit IRC
22:20:30 *** Vishrut has quit IRC
22:34:05 *** djazayeri has quit IRC
22:40:54 *** djazayeri has joined #openmrs
22:40:54 *** ChanServ sets mode: +o djazayeri
22:47:07 *** rkorytkowski has quit IRC
23:44:42 *** djazayeri has quit IRC