| 00:00:24 | *** dkayiwa has quit IRC |
| 00:04:16 | *** rafa has quit IRC |
| 00:06:14 | *** wyclif_ has joined #openmrs |
| 03:00:10 | *** jkeiper has joined #openmrs |
| 03:00:10 | *** ChanServ sets mode: +v jkeiper |
| 03:10:18 | *** jkeiper has quit IRC |
| 03:13:46 | *** jkeiper has joined #openmrs |
| 03:13:46 | *** ChanServ sets mode: +v jkeiper |
| 03:19:53 | *** jkeiper has quit IRC |
| 03:20:00 | *** jkeiper has joined #openmrs |
| 03:20:00 | *** ChanServ sets mode: +v jkeiper |
| 04:03:25 | *** kishoreyekkanti has joined #openmrs |
| 05:51:33 | *** djazayeri has quit IRC |
| 05:52:46 | *** kavuri has joined #openmrs |
| 06:42:56 | *** applecool has joined #openmrs |
| 06:42:59 | *** ChanServ sets mode: +v applecool |
| 06:56:52 | *** adam_l_ has joined #openmrs |
| 07:32:03 | *** robbyoconnor has joined #openmrs |
| 07:32:03 | *** ChanServ sets mode: +v robbyoconnor |
| 07:37:48 | *** djazayeri has joined #openmrs |
| 07:37:48 | *** ChanServ sets mode: +o djazayeri |
| 07:41:57 | <kavuri> djazayeri: quick question. In the encounter creation using webservices.rest, there is no way to specify visit as an attribute. OTOH, there is a getEncountersByVisit to retrieve all encounters by visit |
| 07:42:16 | <kavuri> djazayeri: it seems to be a bug that visit is not part of an encounter creation.. |
| 07:53:05 | <djazayeri> kavuri: I think this is intended to be added via the 19ext module, but either this hasn't been done yet, or maybe it turned out to be hard... |
| 07:53:47 | <kavuri> djazayeri: it should be added to the webservices.rest module, since the EncounterResource is available there |
| 07:54:14 | <djazayeri> kavuri: the problem is that the webservices.rest module compiles against OpenMRS 1.8, which doesn't include visits yet. |
| 07:54:49 | <kavuri> djazayeri: ok. What can be the workaround? |
| 07:54:59 | <kavuri> djazayeri: I really need to have the linkage between encounter and visit |
| 07:57:16 | <djazayeri> kavuri: i'm not sure |
| 07:57:44 | <kavuri> djazayeri: or how can I compile webservices.rest with openmrs 1.9.x? |
| 07:57:55 | <djazayeri> I know this is a lame answer, but can you use the visit resource to add an encounter? |
| 07:58:05 | <djazayeri> after creating the encounter? |
| 07:58:39 | <kavuri> djazayeri: but if I have multiple encounter for a single visit, then I will be able to add only one encounter |
| 08:00:29 | <djazayeri> kavuri: glancing at the code for VisitResource, it seems to me that you should be able to edit the list of encounters in a visit by posting to the visit resource |
| 08:00:48 | <kavuri> djazayeri: ok, so update a visit? |
| 08:01:00 | <djazayeri> kavuri: it's one of the "editable properties". Yes, update a visit. |
| 08:01:30 | <kavuri> djazayeri: its a big workaround for me... |
| 08:01:46 | <kavuri> djazayeri: is there a way to compile webservieces.rest with openmrs1.9.x? |
| 08:02:08 | <djazayeri> kavuri: we're intending to do a sprint soon where we combine the restws and restws19ext modules |
| 08:02:16 | <djazayeri> kavuri: I'm actually not sure why this hasn't been scheduled yet. |
| 08:03:10 | <kavuri> djazayeri: ok. In EncounterResource.java, I added description.addProperty("visit"); in getCreatableProperties |
| 08:03:20 | <kavuri> djazayeri: to allow the creation of a visit with encounter |
| 08:03:37 | <djazayeri> kavuri: actuallyâ¦give that a tryâit's possible that if you're running against 1.9.x that would just work... |
| 08:03:47 | *** adam_l_ has quit IRC |
| 08:04:16 | <kavuri> djazayeri: right, and in openmrs api, it does have a setVisit() method in Encounter.java |
| 08:04:28 | <djazayeri> kavuri: it does in 1.9 |
| 08:04:34 | <kavuri> djazayeri: yes |
| 08:06:34 | <kavuri> djazayeri: is that the only thing that needs to be set or is there something else too? |
| 08:07:21 | <djazayeri> kavuri: I don't know if that will work |
| 08:07:25 | <djazayeri> kavuri: you should try it |
| 08:07:44 | <kavuri> djazayeri: ok |
| 08:08:25 | <djazayeri> kavuri: the alternative is to actually change the version you're compiling against in pom.xml (and I guess in config.xml), add the same "visit" to creatableproperties, and try the same thing |
| 08:10:17 | <kavuri> djazayeri: its in pom.xml. The version is mentioned in these tags: <openMRSVersion>1.8.1</openMRSVersion> |
| 08:10:42 | <djazayeri> kavuri: I would first try just adding the property as you suggested, without changing anything in the pom and config files |
| 08:10:52 | <kavuri> djazayeri: sure. Will try that first |
| 08:11:32 | <kavuri> djazayeri: how will I know the openmrs version in the repository? Is it 1.9.x or 1.9.2? |
| 08:11:54 | <djazayeri> kavuri: the latest released version is 1.9.1 |
| 08:12:03 | <kavuri> djazayeri: ok |
| 08:16:05 | <kavuri> djazayeri: no, just setting the value does not work.. |
| 08:16:13 | <djazayeri> what's the error? |
| 08:16:26 | <kavuri> djazayeri: {"error":{"message":"Unable to convert object into response content","code":"org.openmrs.module.webservices.rest.web.resource.impl.BaseDelegatingResource:551","detail":"org.openmrs.module.webservices.rest.web.response.ConversionException: Some properties are not allowed to be set: visit,provider,encounterType,encounterDatetime\n\tat org.openmrs.module.webservices.rest.web.resource.impl.BaseDelegatingResource.setConvertedProperties(BaseDelegatingR |
| 08:16:27 | <kavuri> esource.java:551)\n\tat org.openmrs.module.webservices.rest.web.resource.impl.DelegatingCrudResource.create |
| 08:16:54 | <kavuri> djazayeri: earlier the error used to be just like |
| 08:16:57 | <kavuri> djazayeri: "detail":"org.openmrs.module.webservices.rest.web.response.ConversionException: Some properties are not allowed to be set: visit\n\tat org.openmrs.module.webservices.rest.web.resource.impl.BaseDelegatingResource.setConvertedProperties(BaseDelegatingResource.java:551 |
| 08:17:14 | <djazayeri> kavuri: are you trying to simultaneously create the encounter and visit? |
| 08:17:29 | <djazayeri> kavuri: or are you passing the uuid of an existing visit? |
| 08:17:35 | <kavuri> djazayeri: visit is already created. I am using the visit uuid in encounter creation |
| 08:19:17 | <djazayeri> kavuri: hmmâ¦I don't know then... |
| 08:19:33 | <kavuri> djazayeri: I will try changing the version |
| 08:19:36 | <djazayeri> kavuri: and I have to head to bed. |
| 08:19:39 | <djazayeri> kavuri: okay, good luck |
| 08:20:03 | <kavuri> djazayeri: ok.. |
| 08:20:06 | <kavuri> good night |
| 08:26:39 | *** upul has joined #openmrs |
| 08:26:39 | *** ChanServ sets mode: +v upul |
| 09:01:30 | *** r0bby has joined #openmrs |
| 09:01:30 | *** ChanServ sets mode: +v r0bby |
| 09:05:17 | *** robbyoconnor has quit IRC |
| 09:07:31 | *** r0bby has quit IRC |
| 09:07:55 | *** r0bby has joined #openmrs |
| 09:07:55 | *** ChanServ sets mode: +v r0bby |
| 09:12:39 | *** rafa has joined #openmrs |
| 09:12:39 | *** ChanServ sets mode: +v rafa |
| 09:19:01 | *** r0bby_ has joined #openmrs |
| 09:19:01 | *** ChanServ sets mode: +v r0bby_ |
| 09:20:13 | *** adam_l has joined #openmrs |
| 09:22:38 | *** r0bby has quit IRC |
| 09:28:10 | *** djazayeri has quit IRC |
| 09:35:15 | *** kavuri has quit IRC |
| 10:08:43 | *** upul has quit IRC |
| 10:25:39 | *** dkayiwa has joined #openmrs |
| 10:42:11 | <adam_l> dkayiwa:Hi how are you? |
| 10:42:45 | <dkayiwa> adam_l: am doing fine |
| 10:42:47 | <dkayiwa> and you? |
| 10:43:16 | <adam_l> dkayiwa: great |
| 10:49:12 | <adam_l> dkayiwa: can you tell me if there is something wrong with : |
| 10:49:14 | <adam_l> dkayiwa: super.sessionFactory.getCurrentSession().createQuery("from " + mappedClass.getSimpleName() + " ab where ab.location = :location and ab.startDate like '%:date%'").setParameter("location", location).setParameter("date", "%"+date+"%").list() |
| 10:49:38 | <dkayiwa> adam_l: is it failing? |
| 10:49:43 | <adam_l> dkayiwa: yes |
| 10:49:51 | <dkayiwa> adam_l: in a unit test? |
| 10:49:55 | <adam_l> dkayiwa: yes |
| 10:50:04 | <dkayiwa> can you pastebin it |
| 10:50:21 | <adam_l> dkayiwa: the code? |
| 10:50:34 | <dkayiwa> adam_l: the above code snippet |
| 10:51:38 | <adam_l> dkayiwa: http://pastebin.com/PkJBVLDZ |
| 10:53:02 | <dkayiwa> adam_l: the method name is not clear |
| 10:53:09 | <dkayiwa> adam_l: getByDateAndLocationId for what? |
| 10:53:37 | <adam_l> dkayiwa: I need to get appointment blocks in a specific date(day) |
| 10:54:00 | <adam_l> dkayiwa: because if you remeber the appointment block UI |
| 10:54:01 | <dkayiwa> adam_l: can you start by making the method name more meaningful? |
| 10:54:21 | <dkayiwa> adam_l: as in by looking at the method name, i should tell what it will be doing |
| 10:54:36 | <dkayiwa> adam_l: getByDateAndLocationId leaves me asking, get date and locationid for what??? |
| 10:55:56 | <adam_l> dkayiwa: it should get appointment blocks with restrications in start_date and location. ok I will change it |
| 10:56:20 | <dkayiwa> adam_l: after changing it, can you pastebin for me again? |
| 10:57:00 | <adam_l> dkayiwa: sure |
| 11:02:40 | <adam_l> dkayiwa: http://pastebin.com/tD3ExX9W |
| 11:03:02 | <adam_l> dkayiwa: I changed the content also |
| 11:03:09 | <dkayiwa> adam_l: ok |
| 11:04:18 | <adam_l> dkayiwa: I can explain to you why I need that method |
| 11:04:22 | <dkayiwa> adam_l: can you also add some javadoc? |
| 11:04:29 | <adam_l> dkayiwa: ok |
| 11:04:46 | <dkayiwa> adam_l: the javadoc will be the working for what the method does |
| 11:05:35 | <dkayiwa> adam_l: Restrictions.ilike is not suitable for dates |
| 11:09:15 | <adam_l> dkayiwa: http://pastebin.com/ZmcM8q6X |
| 11:09:56 | <dkayiwa> adam_l: do you have openmrs-core checked out? |
| 11:10:22 | <adam_l> dkayiwa: ok what I know it's for Strings but what can I do to compare day(dd/mm/yyyy) to startDate(full date) ? |
| 11:10:56 | <adam_l> dkayiwa: I didn't find something related |
| 11:10:59 | <dkayiwa> adam_l: have you tried to google Restrictions.ilike and Restrictions.eq ? |
| 11:11:40 | <adam_l> dkayiwa: yes |
| 11:11:53 | <adam_l> dkayiwa: I understand I'm wrong |
| 11:12:16 | <dkayiwa> adam_l: what is the difference between the two basing on the documents your read after googling? |
| 11:12:59 | <adam_l> dkayiwa: eq is between objects and ilike is for strings as I understand it |
| 11:13:13 | <dkayiwa> adam_l: which link did you read? |
| 11:13:19 | <dkayiwa> adam_l: can i have a look at that link? |
| 11:13:51 | *** yony258 has joined #openmrs |
| 11:14:24 | <adam_l> dkayiwa: It now that I read it... that is how I understand it |
| 11:14:42 | <adam_l> dkayiwa: from examples I saw |
| 11:14:48 | <dkayiwa> adam_l: can i have a look at that link? |
| 11:15:00 | <yony258> dkayiwa: Hi |
| 11:15:04 | <dkayiwa> yony258: hi |
| 11:15:19 | <adam_l> dkayiwa: I don't have links ... never mind thanks for helping |
| 11:17:50 | <yony258> dkayiwa: So im trying to understand why the DWR call I wrote does not execute, let me send you some pastebin links |
| 11:18:01 | <dkayiwa> yony258: ok |
| 11:21:43 | <yony258> dkayiwa: http://pastebin.com/vvawVNDF |
| 11:22:17 | <dkayiwa> yony258: looking..... |
| 11:22:41 | <yony258> dkayiwa: There is some commented out lines so that I'll work with the simple case and then add the rest of the functionality incrementally |
| 11:23:34 | <dkayiwa> yony258: ok |
| 11:25:27 | <adam_l> dkayiwa: anyway I don't really understand what is the difference. I know that "like" is used if the property and value are match but now have to be equal and "eq" is equal. |
| 11:26:00 | <adam_l> anyway I don't really understand what is the difference. I know that "like" is used if the property and value are match but don't have to be equal and "eq" is equal. |
| 11:26:50 | <dkayiwa> adam_l: have you tried to read about them? |
| 11:27:12 | <adam_l> dkayiwa: The problem is I don't know how to restrict according to the startDate. because date and startDate are now the same |
| 11:28:50 | <adam_l> dkayiwa: I didn't find a link with clear defination but only examples with some explainatoin |
| 11:28:52 | <dkayiwa> adam_l: have you read about Restrictions.ilike and Restrictions.eq? |
| 11:29:08 | *** suranga has joined #openmrs |
| 11:29:08 | *** ChanServ sets mode: +v suranga |
| 11:29:15 | <suranga> hi dkayiwa |
| 11:29:25 | <suranga> dkayiwa, long time no see :P |
| 11:30:38 | <dkayiwa> adam_l: can i look at the link you found and read? |
| 11:30:42 | <dkayiwa> suranga: hi :) |
| 11:31:07 | <suranga> dkayiwa, things seem very quiet these days. everyone seems far away :P |
| 11:31:29 | <dkayiwa> suranga: not quite for us here at IRC :) |
| 11:31:30 | <adam_l> dkayiwa: http://docs.jboss.org/hibernate/orm/3.3/reference/en/html/querycriteria.html chaptar 15.2 |
| 11:31:35 | <OpenMRSBot> <http://ln-s.net/+EcA> (at docs.jboss.org) |
| 11:31:44 | <suranga> dkayiwa, I was keeping a low profile over the last few days, I was finishing up an Exam :( |
| 11:32:27 | <dkayiwa> adam_l: by the way, do you have the openmrs-core checked out? |
| 11:32:33 | <dkayiwa> suranga: oh i see |
| 11:33:17 | <adam_l> dkayiwa: If you can guide me what to check because I don't know |
| 11:33:40 | <suranga> dkayiwa, nice, you have students :) |
| 11:33:49 | <dkayiwa> adam_l: do you have the openmrs-core checked out ? |
| 11:34:02 | <dkayiwa> adam_l: or do you know what openmrs-core is? :) |
| 11:34:06 | <yony258> suranga: yes he does :) |
| 11:34:17 | <adam_l> dkayiwa: yes |
| 11:34:30 | <dkayiwa> adam_l: so do you have it checked out? |
| 11:35:28 | <dkayiwa> yony258: can i look at the entire jsp |
| 11:35:29 | <dkayiwa> ? |
| 11:35:36 | <dkayiwa> adam_l: do you have it loaded in eclipse? |
| 11:35:47 | <adam_l> dkayiwa: no because I thought I can do that one with checking the core |
| 11:36:07 | <adam_l> dkayiwa: yes |
| 11:36:07 | <dkayiwa> adam_l: how do you check the core? |
| 11:36:18 | <dkayiwa> adam_l: no and yes ? :) |
| 11:37:02 | <adam_l> dkayiwa: I didn't check it for this ... but ofcourse I looked at it before |
| 11:37:15 | <dkayiwa> adam_l: can you load it in eclipse? |
| 11:37:28 | <dkayiwa> adam_l: all things you will be doing are already in openmrs-core |
| 11:37:29 | <adam_l> dkayiwa: it's loaded |
| 11:37:48 | <dkayiwa> adam_l: can you open this class? HibernateObsDAO |
| 11:38:08 | <adam_l> dkayiwa: that is nice but how can I find where to look? |
| 11:38:16 | <dkayiwa> suranga: they teach me too :) |
| 11:38:22 | <adam_l> dkayiwa: yes |
| 11:38:45 | <dkayiwa> adam_l: you can use this menu: Navigate -> Open Resource |
| 11:38:58 | <dkayiwa> adam_l: then you type the name of the resource you are looking for and it will be opened |
| 11:39:25 | <dkayiwa> adam_l: can you look at the method named createGetObservationsCriteria()? |
| 11:39:49 | <adam_l> dkayiwa: yes |
| 11:40:15 | <dkayiwa> adam_l: do you see how to creates the criteria with the formDate and toDate? |
| 11:40:54 | <adam_l> dkayiwa: yes |
| 11:41:42 | <dkayiwa> adam_l: ok what am trying to show you there is that all those classes in openmrs-core which begin with hibernate are very good to look at and copy ideas from |
| 11:41:50 | <dkayiwa> adam_l: can you use Restrictions.eq for the date? |
| 11:42:39 | <adam_l> dkayiwa: no |
| 11:42:42 | <yony258> dkayiwa: Ok let me know when you can review the pastebin I sent, Its a blocker. |
| 11:43:09 | <dkayiwa> yony258: am waiting for your answer for what i asked above :) |
| 11:44:27 | <yony258> dkayiwa: sure I have no problem sending you the entire JSP but the problem is in calling the DWRAppointmentService, it cant find it. Do you want me to send the entire JSP? |
| 11:44:46 | <dkayiwa> yony258: i want the entire jsp :) |
| 11:44:49 | <adam_l> dkayiwa: ge = greater or equal? le=lower or equal? |
| 11:45:42 | <yony258> dkayiwa: http://pastebin.com/5v4WmGf6 |
| 11:47:11 | <dkayiwa> adam_l: am not sure i have understood the question :) |
| 11:47:18 | <dkayiwa> yony258: looking.... |
| 11:48:29 | <dkayiwa> yony258: is your callback "updatePatient()" called? |
| 11:48:32 | <adam_l> dkayiwa: I asked if Restrictions.ge means greater or equal? |
| 11:48:44 | <yony258> dkayiwa: Yes, with the correct patientId too |
| 11:50:32 | <dkayiwa> adam_l: have you tried to google it? |
| 11:51:16 | <dkayiwa> yony258: does DWRAppointmentService.getPatientDescription get called? |
| 11:51:25 | <yony258> dkayiwa: nope |
| 11:51:56 | <dkayiwa> yony258: what is the value for isPageLoad when updatePatient is called? |
| 11:52:15 | <yony258> dkayiwa: On the first time true, after that fasle |
| 11:52:18 | <yony258> false* |
| 11:52:51 | <dkayiwa> yony258: so that means it branches to the call for? DWRAppointmentService.getPatientDescription |
| 11:53:04 | <yony258> dkayiwa: branches? |
| 11:53:18 | <dkayiwa> yony258: as in it executes the line |
| 11:53:22 | <yony258> dkayiwa: yes |
| 11:53:47 | <dkayiwa> yony258: can i look at DWRAppointmentService.java? |
| 11:53:56 | <yony258> dkayiwa: Its on the first pastebin |
| 11:54:01 | <dkayiwa> yony258: ok |
| 11:54:09 | <adam_l> dkayiwa: yes :) |
| 11:54:17 | <adam_l> dkayiwa: it's correct |
| 11:54:24 | <dkayiwa> adam_l: and did you get the answer? :) |
| 11:54:44 | <adam_l> dkayiwa: can I make the assumption endDate>startDate? |
| 11:54:49 | <adam_l> dkayiwa: yes lol |
| 11:55:03 | <dkayiwa> adam_l: excellent :D |
| 11:55:13 | <dkayiwa> adam_l: it depends on the bussiness loginc |
| 11:55:16 | <dkayiwa> logic |
| 11:55:46 | <dkayiwa> adam_l: do you want to have blocks where endDate <= startDate ? |
| 11:56:14 | <adam_l> dkayiwa: no that's is way I asked |
| 11:56:26 | <adam_l> that* |
| 11:56:50 | <dkayiwa> adam_l: it is Tobin who know the business rules |
| 11:57:03 | <dkayiwa> adam_l: for us we just implement and enforce whatever he says :) |
| 11:57:32 | <adam_l> dkayiwa: even if he says end is before start :) |
| 11:57:35 | <dkayiwa> yony258: do you get anything like javascript error on browser console? |
| 11:57:41 | <yony258> dkayiwa: no |
| 11:57:48 | <dkayiwa> adam_l: yes. customer is always the boss :) |
| 11:58:13 | <dkayiwa> yony258: have tried running it in debug mode? |
| 11:58:28 | <dkayiwa> yony258: as in running the module in debug mode? |
| 11:58:42 | <yony258> dkayiwa: Dont know how to do that |
| 11:58:55 | <dkayiwa> yony258: how do you run openmrs? |
| 11:59:01 | <yony258> dkayiwa: The wiki guide didn't worked for me |
| 11:59:05 | <yony258> dkayiwa: standalone |
| 11:59:12 | <dkayiwa> yony258: ok |
| 11:59:31 | <dkayiwa> yony258: can you run the standalone in debug mode as per here? https://wiki.openmrs.org/display/docs/OpenMRS+Standalone |
| 11:59:32 | <OpenMRSBot> <http://ln-s.net/91x$> (at wiki.openmrs.org) |
| 12:00:20 | <dkayiwa> yony258: look for the section titled: How to run the embedded Tomcat in debug mode |
| 12:00:26 | <yony258> dkayiwa: hmm I'll try that |
| 12:00:33 | <dkayiwa> adam_l: the above is good for you too :) |
| 12:00:56 | <dkayiwa> adam_l: will come in handy at any time T :) |
| 12:01:34 | <dkayiwa> yony258: do so and then put a break point in DWRAppointmentService.getPatientDescription |
| 12:01:41 | <dkayiwa> yony258: then try see if you can break there |
| 12:02:06 | <yony258> dkayiwa: hmm I'll try that? |
| 12:02:07 | <adam_l> dkayiwa: thanks |
| 12:02:13 | <yony258> dkayiwa: One more thing, the DWRAppointmentService.js is being generated automatically by the DWR? |
| 12:02:35 | <dkayiwa> yony258: not auto generated |
| 12:02:49 | <yony258> dkayiwa: then? |
| 12:03:06 | <dkayiwa> yony258: did you mean .js or .java? |
| 12:03:06 | <yony258> dkayiwa: I mean I do not have any DWRAppointmentService.js |
| 12:03:10 | <yony258> dkayiwa: .js |
| 12:03:19 | <dkayiwa> yony258: oh yes :0 |
| 12:03:21 | <dkayiwa> :) |
| 12:03:42 | <yony258> dkayiwa: by the DWR? |
| 12:03:47 | <dkayiwa> yony258: yes |
| 12:18:38 | <yony258> dkayiwa: Debug doesnt work for me as I said, |
| 12:18:57 | <dkayiwa> yony258: did you set the vm arguments? |
| 12:18:57 | <yony258> "Failed to connect to remote VM. Connection refused. |
| 12:19:01 | <yony258> dkayiwa: yes |
| 12:19:12 | <dkayiwa> yony258: can you paste them here? |
| 12:19:39 | <yony258> vm_arguments=-Xmx512m -Xms512m -XX:PermSize=256m -XX:MaxPermSize=256m -XX:NewSize=128m -Xdebug -Xnoagent -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5000 |
| 12:20:00 | <dkayiwa> yony258: did you then restart the standalone? |
| 12:20:08 | <yony258> dkayiwa: of course |
| 12:20:29 | <dkayiwa> yony258: how did you attempt to connect to to it from eclipse? |
| 12:20:52 | <yony258> dkayiwa: Created new Debug Confiuration with port 5000 |
| 12:21:14 | <dkayiwa> yony258: how did you restart the standalone? |
| 12:23:34 | <yony258> dkayiwa: Ok I had to choose appointment-omod project |
| 12:23:39 | <yony258> dkayiwa: Now it works |
| 12:23:49 | <dkayiwa> yony258: ok good |
| 12:24:12 | <yony258> dkayiwa: But it doesnt get to DWRAppointmentService |
| 12:24:39 | <dkayiwa> yony258: can you push and i try it here? |
| 12:25:07 | <yony258> dkayiwa: Hmm ok |
| 12:26:27 | <yony258> dkayiwa: https://github.com/openmrs/openmrs-module-appointment/commit/f160325124dd3c7fbb0d0fa14947f1faa3bff8e0 |
| 12:26:31 | <OpenMRSBot> <http://ln-s.net/+Ecw> (at github.com) |
| 12:27:23 | <adam_l> dkayiwa: Daniel tests are working but I need you to look at the method and tell me if it is fine |
| 12:27:26 | <adam_l> dkayiwa: http://pastebin.com/Zd85ALbZ |
| 12:28:27 | <dkayiwa> adam_l: if the unit test passes, most likely the method is fine :) |
| 12:28:35 | <dkayiwa> yony258: ok |
| 12:29:08 | <adam_l> dkayiwa: ok thanks |
| 12:29:13 | <dkayiwa> adam_l: did you create a unit test for the method? |
| 12:32:34 | <adam_l> dkayiwa: yes |
| 12:32:44 | <dkayiwa> adam_l: can i look at it? |
| 12:32:59 | <adam_l> dkayiwa: sure on pastebin? |
| 12:33:03 | <dkayiwa> adam_l: yes |
| 12:34:04 | <adam_l> dkayiwa: http://pastebin.com/URk9QwZk |
| 12:34:23 | <dkayiwa> yony258: creator should be new instead of yony258 :) |
| 12:34:51 | <yony258> dkayiwa: Oh I thought that was for documentation |
| 12:38:35 | <dkayiwa> yony258: after changing that, try again |
| 12:39:07 | <yony258> dkayiwa: Seems that now it wont load the appointmentForm |
| 12:39:23 | <yony258> dkayiwa: No error just loading inifinity to |
| 12:39:28 | <dkayiwa> adam_l: what does this mean? should get all correct appointment blocks |
| 12:39:36 | <yony258> dkayiwa: Sorry, just loading... |
| 12:39:55 | <dkayiwa> yony258: what changes did you make? |
| 12:39:56 | <adam_l> dkayiwa: sorry I will change it |
| 12:40:09 | <yony258> dkayiwa: yony258->creator |
| 12:40:35 | <dkayiwa> yony258: yony258 -> new |
| 12:40:53 | <yony258> dkayiwa: What? |
| 12:41:05 | <dkayiwa> yony258: change yony258 to new |
| 12:41:40 | <yony258> dkayiwa: <create creator="new" ? |
| 12:41:48 | <dkayiwa> yony258: yes |
| 12:44:02 | <adam_l> dkayiwa: http://pastebin.com/ca5ki14A |
| 12:44:45 | <dkayiwa> adam_l: locaiton -> location |
| 12:44:48 | <dkayiwa> :) |
| 12:44:54 | <adam_l> dkayiwa: :) ok |
| 12:45:54 | <adam_l> dkayiwa: method = "getAppointmentBlocks(Date,Date,Location)"* I forgot that too |
| 12:46:04 | <dkayiwa> adam_l: ok |
| 12:46:12 | <yony258> dkayiwa: Still won't activate DWRAppointmentService |
| 12:46:26 | <dkayiwa> yony258: push again |
| 12:46:45 | <yony258> dkayiwa: The only change was create creator="new" |
| 12:47:18 | <dkayiwa> yony258: yes push |
| 12:47:49 | <yony258> dkayiwa: pushed |
| 12:48:02 | <dkayiwa> yony258: ok |
| 12:50:43 | <adam_l> dkayiwa: I have a question |
| 12:50:47 | <dkayiwa> adam_l: ok |
| 12:51:19 | <adam_l> dkayiwa: Can I update the list of appointment blocks on the jsp page via java Script? |
| 12:51:47 | <dkayiwa> adam_l: yes |
| 12:52:23 | <adam_l> dkayiwa: I have created the DWR service class and the method to get the appointment blocks |
| 12:52:38 | <dkayiwa> adam_l: ok |
| 12:53:36 | <dkayiwa> yony258: did you create the DWR class in the packake i told you? |
| 12:53:40 | <dkayiwa> package |
| 12:54:04 | <yony258> appointment-oimod |
| 12:54:11 | <yony258> src/main/java |
| 12:54:19 | <yony258> right click-> new package called "web" |
| 12:54:23 | <dkayiwa> yony258: i meant package |
| 12:54:57 | <dkayiwa> yony258: can you look at IRC for the package i told you? :) |
| 12:55:07 | <yony258> dkayiwa: Inside of that package I added DWRAppointmentService.java and PatientDescription.java |
| 12:55:26 | <dkayiwa> yony258: what package did i tell you on IRC? |
| 12:56:30 | <yony258> dkayiwa: |
| 12:56:30 | <yony258> 22:26:03 <dkayiwa> yony258: in the omod project 22:26:23 <yony258> dkayiwa:right click new package "web" ? 22:27:19 <dkayiwa> yony258: right click on src/main/java4 |
| 12:57:21 | <dkayiwa> yony258: then sorry i mistyped |
| 12:57:30 | <dkayiwa> yony258: was supposed to be: org.openmrs.module.appointment.web |
| 12:57:56 | <adam_l> dkayiwa:will this algorithm(script) work? 1) get the table from the dhtml tree to js and clear it. 2)get the location and date from the dhtml 3) get the appointment blocks using the DWR service class 4) fill the table 5) refresh |
| 12:58:20 | <dkayiwa> adam_l: can you try it out and see? :) |
| 12:59:01 | <adam_l> dkayiwa: I want to be more confident while doing it :) |
| 12:59:38 | <dkayiwa> adam_l: you develop confidence practically not in theory :) |
| 12:59:56 | <adam_l> dkayiwa: lol ok I will try... I will let you know how it goes |
| 13:00:03 | <dkayiwa> adam_l: sure |
| 13:00:17 | <jkeiper> :-) |
| 13:00:22 | <dkayiwa> adam_l: do not fear trying out stuff. it is always part of the learning process :) |
| 13:01:11 | <adam_l> dkayiwa: ok thanks :) |
| 13:01:59 | <dkayiwa> adam_l: by the way, i like your most recent unit test. it is very clever of you :) |
| 13:02:02 | <yony258> dkayiwa: It still doesn't reach DWRAppointmentService |
| 13:02:11 | <dkayiwa> yony258: push and i test |
| 13:03:00 | <adam_l> dkayiwa: thanks :) glad you liked it :) if you want I will make another one :P |
| 13:03:26 | <dkayiwa> adam_l: infact it is better than what i would write if i were in your shoes |
| 13:03:39 | <dkayiwa> adam_l: so in summary, you have taught me something :D |
| 13:03:58 | <dkayiwa> adam_l: thanks for being generous with more tests :) |
| 13:04:16 | <yony258> dkayiwa: pushed |
| 13:04:23 | <dkayiwa> yony258: ok pulling ..... |
| 13:04:37 | <adam_l> dkayiwa: :) |
| 13:06:37 | *** r0bby_ has quit IRC |
| 13:06:56 | <adam_l> dkayiwa: as I see it I should always generate the table dynamically and delete the hard coded html. what do you think about that? |
| 13:07:12 | <dkayiwa> adam_l: excellent |
| 13:07:41 | <dkayiwa> adam_l: and if you can use jquery tables, it would even be fabulous. but not a must :) |
| 13:08:58 | <adam_l> dkayiwa: ok I will investigate that :) |
| 13:09:05 | <dkayiwa> adam_l: ok |
| 13:09:22 | <dkayiwa> yony258: do you get any javascript error on the browser console? |
| 13:09:29 | <yony258> dkayiwa: no |
| 13:10:02 | <dkayiwa> yony258: which browser are you using? |
| 13:10:15 | <yony258> dkayiwa: chrome |
| 13:12:37 | <dkayiwa> yony258: can you include these two llines before your dwr script declaration? |
| 13:12:38 | <dkayiwa> <script src="<openmrs:contextPath/>/dwr/engine.js"></script> |
| 13:12:38 | <dkayiwa> <script src="<openmrs:contextPath/>/dwr/util.js"></script> |
| 13:13:22 | *** adam_l has quit IRC |
| 13:15:06 | <yony258> dkayiwa: still.... |
| 13:15:24 | <dkayiwa> yony258: still compiling??? :) |
| 13:16:13 | <yony258> dkayiwa: still doesn't work. I suggest checking the path to the .js file since in OpenMRS core all the DWR..Service.java are in package: ... .web.dwr |
| 13:19:06 | <dkayiwa> yony258: feel free to try out anything you think without first getting permission from me :) |
| 13:24:21 | *** applecool has quit IRC |
| 13:25:42 | <yony258> dkayiwa: No idea how to fix this |
| 13:25:48 | <dkayiwa> yony258: looking.... |
| 13:28:01 | <dkayiwa> yony258: in config.xml |
| 13:28:44 | <dkayiwa> yony258: can you replace @MODULE_PACKAGE@ with org.openmrs.module.appointment |
| 13:28:50 | <dkayiwa> yony258: then compile and test again |
| 13:31:12 | <yony258> dkayiwa: Still not working |
| 13:31:38 | <dkayiwa> yony258: have you replaced all occurrences in that file? |
| 13:32:33 | <yony258> dkayiwa: Yes. 2 total, Chrome debugging console says: |
| 13:32:36 | <yony258> dkayiwa: Uncaught ReferenceError: DWRAppointmentService is not defined |
| 13:32:59 | <dkayiwa> yony258: yes thats the error i was looking for |
| 13:34:05 | <yony258> dkayiwa: <script src="<openmrs:contextPath/>/dwr/interface/DWRAppointmentService.js"></script> |
| 13:34:37 | <yony258> dkayiwa: Is this correct? (I have no idea how the js file is created and where it is stored so its just words for me) |
| 13:34:46 | <dkayiwa> yony258: looking... |
| 13:36:16 | <dkayiwa> yony258: do them like this below |
| 13:36:17 | <dkayiwa> <script type="text/javascript" src='${pageContext.request.contextPath}/dwr/engine.js'></script> |
| 13:36:46 | <dkayiwa> yony258: that is for the three lines and then test again |
| 13:38:34 | <yony258> dkayiwa: GET http://localhost:8081/openmrs-standalone/dwr/interface/DWRAppointmentService.js 501 (Not Implemented) appointmentForm.form:215 Uncaught ReferenceError: DWRAppointmentService is not defined |
| 13:39:14 | <dkayiwa> yony258: can you push all your changes for me to look at? |
| 13:40:26 | <yony258> dkayiwa: pushed |
| 13:40:33 | <dkayiwa> yony258: ok |
| 13:41:37 | <dkayiwa> yony258: did you recompile and reinstall the module? |
| 13:41:44 | <yony258> dkayiwa: yes |
| 13:42:01 | <dkayiwa> yony258: can you do it once more? |
| 13:42:08 | <dkayiwa> yony258: as in recompile and reinstall the module |
| 13:42:11 | <yony258> dkayiwa: its working for you? |
| 13:42:15 | <dkayiwa> yony258: yes |
| 13:42:33 | <yony258> dkayiwa: I'll do clean install |
| 13:42:39 | <dkayiwa> yony258: ok |
| 13:43:41 | <yony258> dkayiwa: Uncaught ReferenceError: DWRAppointmentService is not defined |
| 13:43:55 | <dkayiwa> yony258: how do you reinstall? |
| 13:43:58 | <yony258> dkayiwa: After selecting a patient you are getting an alert? |
| 13:44:05 | <dkayiwa> yony258: yes |
| 13:44:17 | <yony258> dkayiwa: I do add/upgrade module |
| 13:44:38 | <dkayiwa> yony258: does the file creation date change to reflect the most recent? |
| 13:44:46 | <yony258> dkayiwa: Yes |
| 13:45:02 | <dkayiwa> yony258: let me revert my changes and try yours |
| 13:48:35 | <dkayiwa> yony258: works on mine |
| 13:48:48 | <dkayiwa> yony258: are you really sure you upgrade the module? |
| 13:48:59 | <yony258> dkayiwa: >.< Yes |
| 13:49:01 | <dkayiwa> yony258: for instance you seem to do it very fast |
| 13:49:11 | <yony258> dkayiwa: Im quick |
| 13:49:14 | <dkayiwa> yony258: can you email me your .omod? |
| 13:49:17 | <yony258> dkayiwa: Let me remove the standalone and try a fresh one |
| 13:49:22 | <dkayiwa> yony258: no |
| 13:49:28 | <yony258> dkayiwa: ok |
| 13:49:31 | <dkayiwa> yony258: do not remove the standlone |
| 13:49:43 | <dkayiwa> yony258: do you have firefox? |
| 13:49:54 | <yony258> dkayiwa: Yes |
| 13:50:04 | <dkayiwa> yony258: try it there and tell me |
| 13:50:51 | *** sgithens has quit IRC |
| 13:51:33 | <yony258> dkayiwa: works in firefox |
| 13:51:42 | <dkayiwa> yony258: can you refresh chrome |
| 13:51:48 | <dkayiwa> yony258: maybe caching |
| 13:52:15 | <yony258> dkayiwa: Ill empty the cache and try again |
| 13:52:21 | <dkayiwa> yony258: ok |
| 13:53:02 | <yony258> dkayiwa: works in chrome |
| 13:53:11 | <dkayiwa> yony258: so it was caching? |
| 13:53:15 | <yony258> dkayiwa: Yes |
| 13:53:20 | <dkayiwa> yony258: ok |
| 13:53:56 | <yony258> dkayiwa: Although its not supposed to be null :/ |
| 13:54:01 | <yony258> dkayiwa: I'll try to fix that |
| 13:54:07 | <dkayiwa> yony258: ok |
| 13:55:54 | *** wyclif_ has quit IRC |
| 14:20:50 | <dkayiwa> hi yony258 |
| 14:24:42 | *** suranga has quit IRC |
| 14:24:57 | *** Mkop has quit IRC |
| 14:26:29 | *** Mkop has joined #openmrs |
| 14:26:29 | *** ChanServ sets mode: +v Mkop |
| 14:36:18 | *** Mkop has quit IRC |
| 14:36:35 | *** Mkop has joined #openmrs |
| 14:36:35 | *** ChanServ sets mode: +v Mkop |
| 14:36:59 | *** sgithens has joined #openmrs |
| 14:38:34 | *** wyclif_ has joined #openmrs |
| 14:46:42 | *** afiles has joined #openmrs |
| 14:47:34 | <rafa> dkayiwa: hi, did you enter a ticket for OOM from yesterday? |
| 14:47:52 | <dkayiwa> rafa: oh no |
| 14:48:08 | <rafa> dkayiwa: would you mind? |
| 14:48:16 | <rafa> dkayiwa: I don't remember the details |
| 14:48:21 | <dkayiwa> rafa: not at all :) |
| 14:48:40 | <rafa> dkayiwa: thanks |
| 14:54:27 | *** kishoreyekkanti has quit IRC |
| 14:56:39 | <dkayiwa> rafa: !ticket TRUNK-3837 |
| 14:56:46 | <dkayiwa> !ticket TRUNK-3837 |
| 14:56:47 | <OpenMRSBot> dkayiwa: [#TRUNK-3837] ConceptValidatorChangeSet should not throw an Out of Memory exception when writing warnings to file - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3837 |
| 14:58:54 | <rafa> dkayiwa: very well |
| 15:02:41 | *** djazayeri has joined #openmrs |
| 15:02:41 | *** ChanServ sets mode: +o djazayeri |
| 15:04:50 | *** wyclif_ has quit IRC |
| 15:08:26 | *** sgithens has quit IRC |
| 15:19:45 | *** wyclif_ has joined #openmrs |
| 15:21:43 | *** sgithens has joined #openmrs |
| 15:43:48 | *** sgithens has quit IRC |
| 15:50:47 | *** sgithens has joined #openmrs |
| 16:31:07 | *** wyclif_ has quit IRC |
| 16:35:13 | *** rafa has quit IRC |
| 16:36:42 | *** sgithens has quit IRC |
| 16:43:40 | *** wyclif_ has joined #openmrs |
| 16:49:17 | *** kishoreyekkanti has joined #openmrs |
| 17:04:28 | *** harshadura has joined #openmrs |
| 17:17:08 | *** travis-ci has joined #openmrs |
| 17:17:08 | <travis-ci> [travis-ci] [kishoreyekkanti/openmrs-core] [872cf61] [Kishore Kumar Yekkanti] The build is still failing. - http://travis-ci.org/kishoreyekkanti/openmrs-core/builds/3534922 |
| 17:17:08 | *** travis-ci has left #openmrs |
| 17:17:11 | <OpenMRSBot> <http://ln-s.net/+Ehy> (at travis-ci.org) |
| 17:17:19 | <dkayiwa> wowwwwwwwwwww |
| 17:18:36 | <kishoreyekkanti> sorry for the travis spam for some time. testing the travis yml from my github fork |
| 17:29:40 | *** travis-ci has joined #openmrs |
| 17:29:40 | <travis-ci> [travis-ci] [kishoreyekkanti/openmrs-core] [0cc2550] [Kishore Kumar Yekkanti] The build is still failing. - http://travis-ci.org/kishoreyekkanti/openmrs-core/builds/3535150 |
| 17:29:40 | *** travis-ci has left #openmrs |
| 17:29:45 | <OpenMRSBot> <http://ln-s.net/+EiG> (at travis-ci.org) |
| 17:43:41 | <kishoreyekkanti> djazayeri / dkayiwa I don't want to genereate the travis CI private key with my githuh id. Can any one of you signup with travis -> go to profile page and openmrs-core from there. Clicking on the spanner icon will configure the service hook to github |
| 17:44:14 | <djazayeri> probably we should have downey do that. |
| 17:45:13 | <kishoreyekkanti> djazayeri: irrespective of who ever do that, as openmrs is an organization, it would be configured with the github id who enables this service hook |
| 17:50:30 | *** travis-ci has joined #openmrs |
| 17:50:30 | <travis-ci> [travis-ci] [kishoreyekkanti/openmrs-core] [9fc2c33] [Kishore Kumar Yekkanti] The build was fixed. - http://travis-ci.org/kishoreyekkanti/openmrs-core/builds/3535478 |
| 17:50:30 | *** travis-ci has left #openmrs |
| 17:50:33 | <OpenMRSBot> <http://ln-s.net/+Eii> (at travis-ci.org) |
| 18:02:10 | *** travis-ci has joined #openmrs |
| 18:02:10 | <travis-ci> [travis-ci] [kishoreyekkanti/openmrs-core] [233045e] [Yekkanti Kishore Kumar] The build was fixed. - http://travis-ci.org/kishoreyekkanti/openmrs-core/builds/3535609 |
| 18:02:10 | *** travis-ci has left #openmrs |
| 18:02:14 | <OpenMRSBot> <http://ln-s.net/+Eir> (at travis-ci.org) |
| 18:04:12 | *** yony258 has quit IRC |
| 18:09:27 | *** travis-ci has joined #openmrs |
| 18:09:27 | <travis-ci> [travis-ci] [kishoreyekkanti/openmrs-core] [b86e565] [Kishore Kumar Yekkanti] The build passed. - http://travis-ci.org/kishoreyekkanti/openmrs-core/builds/3535712 |
| 18:09:27 | *** travis-ci has left #openmrs |
| 18:09:30 | <OpenMRSBot> <http://ln-s.net/+Ej1> (at travis-ci.org) |
| 18:15:42 | *** travis-ci has joined #openmrs |
| 18:15:42 | <travis-ci> [travis-ci] [kishoreyekkanti/openmrs-core] [c447032] [Kishore Kumar Yekkanti] The build passed. - http://travis-ci.org/kishoreyekkanti/openmrs-core/builds/3535733 |
| 18:15:42 | *** travis-ci has left #openmrs |
| 18:15:45 | <OpenMRSBot> <http://ln-s.net/+Ej9> (at travis-ci.org) |
| 18:17:05 | <kishoreyekkanti> djazayeri: I've enabled the travis ci for OpenMRS with my github key for now. Will drop a note to downey so that he can change the same. |
| 18:17:22 | <kishoreyekkanti> Readme is updated with the build status https://github.com/openmrs/openmrs-core |
| 18:19:26 | <djazayeri> kishoreyekkanti: cool |
| 18:21:45 | *** travis-ci has joined #openmrs |
| 18:21:45 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [ab3b9b1] [Kishore Kumar Yekkanti] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/3535846 |
| 18:21:45 | *** travis-ci has left #openmrs |
| 18:21:49 | <OpenMRSBot> <http://ln-s.net/+EjH> (at travis-ci.org) |
| 18:30:36 | *** rafa has joined #openmrs |
| 18:30:36 | *** ChanServ sets mode: +v rafa |
| 18:30:45 | *** yony258 has joined #openmrs |
| 18:30:53 | <yony258> dkayiwa: Hi :) |
| 18:31:04 | <dkayiwa> yony258: hi :) |
| 18:31:49 | <yony258> dkayiwa: It seems that I cant return the PatientDescription object it always becomes null. Do I need to create some sort of a bean for it? |
| 18:32:16 | *** sgithens has joined #openmrs |
| 18:32:34 | <dkayiwa> yony258: looking..... |
| 18:35:52 | <dkayiwa> yony258: can you try add this in your config.xml? |
| 18:35:54 | <dkayiwa> yony258: <convert converter="bean" match="org.openmrs.module.appointment.web.PatientDescription"/> |
| 18:36:00 | <yony258> dkayiwa: Already compiling :] |
| 18:36:06 | <dkayiwa> yony258: that is in the DWR config section |
| 18:36:14 | <dkayiwa> yony258: you are supper fast :) |
| 18:37:22 | <yony258> dkayiwa: still null :/ |
| 18:37:34 | <dkayiwa> yony258: where did you add it? |
| 18:37:48 | <yony258> dkayiwa: ill pastebin |
| 18:38:03 | <yony258> dkayiwa: http://pastebin.com/iuA0Q2T3 |
| 18:38:11 | <dkayiwa> yony258: looking .... |
| 18:38:42 | <yony258> dkayiwa: Maybe outside <allow> tag ? |
| 18:38:50 | <dkayiwa> yony258: can you put a break point DWRAppointmentService? |
| 18:39:00 | <dkayiwa> yony258: and confirm that you do not return null? |
| 18:39:11 | <yony258> dkayiwa: ok let me try that |
| 18:40:38 | <yony258> dkayiwa: confirmed that, and outside allow not working either |
| 18:41:03 | <dkayiwa> yony258: debuging next |
| 18:41:14 | <yony258> dkayiwa: sorry what? |
| 18:41:27 | <dkayiwa> yony258: put a break point and debug |
| 18:42:02 | <yony258> dkayiwa: I debugged DWRAppointmentService it works correctly |
| 18:42:21 | <dkayiwa> yony258: do you mean it returns non null? |
| 18:42:51 | <yony258> dkayiwa: yes it returns a PatientDescription with "test", "test" but in the javascript it becomes null |
| 18:43:08 | <dkayiwa> yony258: ok push and i test here |
| 18:43:31 | <yony258> dkayiwa: Ok just a second let me look at similar functionality in openmrs-core |
| 18:43:55 | <dkayiwa> yony258: very bright idea :) |
| 18:49:11 | *** kishoreyekkanti has quit IRC |
| 18:51:01 | *** harshadura has quit IRC |
| 18:56:27 | <yony258> dkayiwa: Ok according to the information on the web and the examples in openmrs core what we did should work but it doesnt,, anyway I pushed. |
| 18:56:47 | <dkayiwa> yony258: ok pulling |
| 18:56:57 | <yony258> dkayiwa: Oh sec I need to merge |
| 18:57:05 | <dkayiwa> yony258: ok |
| 19:04:31 | <yony258> dkayiwa: pushed |
| 19:04:48 | <dkayiwa> yony258: ok pulling |
| 19:06:25 | <yony258> dkayiwa: Why am I having pom.xml errors? |
| 19:07:02 | <dkayiwa> yony258: did you get conflicts? |
| 19:07:28 | <yony258> dkayiwa: Had one conflict on DWRAppointmentService |
| 19:08:30 | <yony258> dkayiwa: Plugin execution not covered by lifecycle configuration: com.googlecode.maven-java-formatter-plugin:maven-java-formatter-plugin:0.3.1:format (execution: default, phase: process-sources) |
| 19:09:12 | <dkayiwa> yony258: did you pull first? |
| 19:09:25 | <yony258> dkayiwa: yes |
| 19:09:47 | <dkayiwa> yony258: do you have any local modifications in that pom? |
| 19:10:48 | <yony258> dkayiwa: ?? |
| 19:10:58 | <dkayiwa> yony258: ?? |
| 19:11:11 | <yony258> dkayiwa: What do you mean? :) |
| 19:11:27 | <dkayiwa> yony258: did you say you have errors in one of your pom files? |
| 19:11:44 | <djazayeri> yony258, dkayiwa: I think I often see that error (especially when opening the pom in intellij instead of eclipse) but it doesn't seem to break things. |
| 19:11:52 | <yony258> dkayiwa: I have the same errors in both pom.xml, I didn't changed anything |
| 19:11:59 | <yony258> *error |
| 19:12:15 | <dkayiwa> yony258: which IDE do you use? |
| 19:12:21 | <yony258> dkayiwa: Eclipse |
| 19:12:35 | <dkayiwa> yony258: but does mvn install work? |
| 19:13:16 | <yony258> dkayiwa: yes |
| 19:13:26 | <dkayiwa> yony258: ok then ignore it for now :) |
| 19:14:59 | *** afiles has quit IRC |
| 19:15:19 | *** yony258_ has joined #openmrs |
| 19:15:24 | <yony258_> dkayiwa: sorry crashed |
| 19:16:19 | <dkayiwa> yony258_: can you always run mvn install before you push? |
| 19:16:53 | <yony258_> dkayiwa: so that it will format it? |
| 19:17:32 | *** yony258 has quit IRC |
| 19:17:54 | *** yony258_ is now known as yony258 |
| 19:17:58 | <dkayiwa> yony258_: thats one. but also will ensure that you confirm all unit tests pass before you push :) |
| 19:18:07 | <yony258> dkayiwa: ok |
| 19:23:57 | <dkayiwa> yony258: :D |
| 19:24:04 | <yony258> dkayiwa: ? |
| 19:24:04 | *** adam_l_ has joined #openmrs |
| 19:24:09 | <dkayiwa> yony258: you simply have the same web cache problem |
| 19:24:10 | <dkayiwa> :) |
| 19:24:38 | <dkayiwa> yony258: so the fix was: <convert converter="bean" match="org.openmrs.module.appointment.web.PatientDescription"/> |
| 19:25:06 | <adam_l_> dkayiwa: the DWR class need to implement GlobalPropertyListener? |
| 19:25:14 | <dkayiwa> adam_l_: no |
| 19:25:38 | <yony258> adam_l_: pull before creating a new class I think there is only one of those for the module |
| 19:25:47 | <yony258> or dkayiwa can answer that |
| 19:26:09 | <adam_l_> dkayiwa: I know I created it before |
| 19:26:20 | <adam_l_> yony258: I know I created it before |
| 19:26:22 | <yony258> adam_l_: Oh ok so we are going to have a conflict |
| 19:26:39 | <adam_l_> yony258: I'm aware of that... don't worry :) |
| 19:29:10 | <yony258> dkayiwa: So again the caching problem? |
| 19:30:33 | <dkayiwa> yony258: yes |
| 19:31:28 | <yony258> dkayiwa: Weird I cleared the cache but still not working |
| 19:31:45 | <dkayiwa> yony258: can you try firefox |
| 19:31:48 | <yony258> dkayiwa: Do you see an alert that says "test" ? |
| 19:31:54 | <dkayiwa> yony258: yes |
| 19:31:59 | <yony258> dkayiwa: haha lol |
| 19:32:19 | <yony258> ok works now |
| 19:33:00 | <adam_l_> dkayiwa: So how I call the method in the DWR service class? and where to store the data? |
| 19:33:53 | <adam_l_> dkayiwa: I can just right for example var appointmentBlocks = DWRAppointmentService.getAppointmentBlocks(fromDate,toDate,locationId); ? |
| 19:33:54 | <dkayiwa> adam_l_: yony258 should teach you that :) |
| 19:40:02 | <adam_l_> dkayiwa: I need to create a class like Yonatan did? |
| 19:40:25 | <dkayiwa> adam_l_: you need the very same steps like he did |
| 19:40:45 | <adam_l_> dkayiwa: but I need to get a List of appointment blocks |
| 19:41:17 | <dkayiwa> adam_l_: the objects differ but the steps are the same |
| 19:42:01 | <adam_l_> dkayiwa: ok one question... can I transfer a list to the js? |
| 19:42:49 | <yony258> adam_l_: I thought about it too, this may be relevant |
| 19:42:50 | <yony258> adam_l_: http://www.anyang-window.com.cn/dwr-to-transfer-map-return-map-and-other-objects/ |
| 19:44:20 | <adam_l_> yony258: ok thanks |
| 19:44:23 | <dkayiwa> yony258: nice link :) |
| 19:49:05 | <yony258> dkayiwa: lol what happened to SCRUM time? |
| 19:49:23 | <dkayiwa> yony258: Tobin is in bed :) |
| 19:49:35 | <dkayiwa> yony258: which scrum? |
| 19:49:39 | <yony258> dkayiwa: haha |
| 19:49:48 | *** rafa has quit IRC |
| 19:53:09 | *** jblaya has joined #openmrs |
| 19:55:11 | <jblaya> dkayiwa, quick question, does xform allow you to place orders and then have them show up in the patient dashboard under Regimen as if they had been ordered from there? |
| 19:55:27 | <dkayiwa> jblaya: no |
| 19:56:08 | <jblaya> dkayiwa, ok, can I place it as a ticket? or do you know if it exists already? |
| 19:56:20 | <dkayiwa> jblaya: it does not exist |
| 19:56:34 | *** adam_l_ has quit IRC |
| 19:56:41 | *** cpower has joined #openmrs |
| 19:56:51 | <jblaya> dkayiwa, ok, will do that now |
| 19:56:59 | <cpower> Hello Everyone |
| 19:57:58 | <yony258> Hi cpower |
| 20:00:43 | *** andrea has joined #openmrs |
| 20:01:03 | *** andrea is now known as Guest30180 |
| 20:01:17 | *** Guest30180 is now known as andreap_ |
| 20:02:00 | *** adam_l_ has joined #openmrs |
| 20:02:12 | *** travis-ci has joined #openmrs |
| 20:02:12 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [a1adcf6] [rkorytkowski] The build was fixed. - http://travis-ci.org/openmrs/openmrs-core/builds/3537083 |
| 20:02:12 | *** travis-ci has left #openmrs |
| 20:02:16 | <OpenMRSBot> <http://ln-s.net/+El5> (at travis-ci.org) |
| 20:02:52 | <cpower> Let us pass the bread, and begin our daily Scrum |
| 20:02:58 | <cpower> !scrumon cpower |
| 20:02:58 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 20:03:27 | <cpower> Order: yony258, wyclif_, dkayiway andreap_, adam_l_, djazayeri |
| 20:03:49 | <yony258> * Today: solved the blocker, continue working on Create Appointment form |
| 20:03:59 | <yony258> *Tomorrow: continue AM-4 |
| 20:04:06 | <yony258> * Blockers: none |
| 20:04:13 | <cpower> ok |
| 20:04:16 | <cpower> wyclif_ |
| 20:04:38 | <wyclif_> Wednesday: |
| 20:04:38 | <wyclif_> TRUNK-3754 - Modules folder should be configured via a runtime property, not a global property |
| 20:04:38 | <wyclif_> RG Work In Progress |
| 20:04:38 | <wyclif_> Devlist emails and ticket comments |
| 20:04:38 | <wyclif_> Responding to rafa's comments after review of TRUNK-2999 - Investigate replacing concept word with full text search |
| 20:04:39 | <wyclif_> design call |
| 20:04:43 | <wyclif_> |
| 20:04:45 | <wyclif_> Thursday |
| 20:04:47 | <wyclif_> ATLAS-43 - Upgrade atlas module to require 1.7.x version |
| 20:04:49 | <wyclif_> dev call |
| 20:04:51 | <wyclif_> apply atlas pull requests to master and fix config.xml for atlas and prepare the module for 1.1 release |
| 20:04:53 | <wyclif_> upload 1.7.0 artifacts to openmrs nexus repo |
| 20:04:55 | <wyclif_> pick a bug ticket |
| 20:04:57 | <wyclif_> Blockers: None |
| 20:05:12 | <dkayiwa> Reviewed code and tested module for Tobin's Team |
| 20:05:13 | <dkayiwa> Guided Tobin's team with their current tasks |
| 20:05:13 | <dkayiwa> Committed: Add openmrs code formatter to the maven build process for the appointment module - AM-14 |
| 20:05:13 | <dkayiwa> Dev Call |
| 20:05:13 | <dkayiwa> Working on: Retrieving a ProgramWorkflow by name in a the ModuleActivator started method throws an error - TRUNK-3739 |
| 20:05:14 | <dkayiwa> No Blockers |
| 20:05:35 | <cpower> andreap_ |
| 20:05:36 | <andreap_> Wednesday |
| 20:05:37 | <andreap_> Univ call |
| 20:05:37 | <andreap_> Design call |
| 20:05:37 | <andreap_> JSPs for TRUNK-2768 |
| 20:05:37 | <andreap_> Thursday |
| 20:05:37 | <andreap_> Finish working on TRUNK-2768 |
| 20:05:39 | <andreap_> Blockers: None |
| 20:05:51 | <cpower> adam_l_ |
| 20:06:44 | <cpower> ok, djazayeri |
| 20:06:53 | <djazayeri> Calls. Lots of them. |
| 20:06:57 | <djazayeri> (Still on one.) |
| 20:06:58 | <djazayeri> No blockers |
| 20:07:09 | <cpower> Sounds like fun! |
| 20:07:11 | <cpower> ;-) |
| 20:07:21 | <cpower> No discussion, no blockers |
| 20:07:24 | <cpower> !scrumoff |
| 20:07:24 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:09:18 | *** jblaya has quit IRC |
| 20:25:02 | *** adam_l_ has quit IRC |
| 20:28:15 | *** adam_l has joined #openmrs |
| 20:40:23 | *** gschiltz has joined #openmrs |
| 20:46:10 | *** Mkop has quit IRC |
| 20:49:42 | *** Mkop has joined #openmrs |
| 20:49:42 | *** ChanServ sets mode: +v Mkop |
| 20:51:30 | *** rafa has joined #openmrs |
| 20:51:30 | *** ChanServ sets mode: +v rafa |
| 21:05:30 | <adam_l> dkayiwa: I added AppointmentBlockDescription class and changed the DWR method to return List of AppointmentBlockDescriptions. Is that ok? |
| 21:05:47 | <dkayiwa> adam_l: it is ok if it works :) |
| 21:07:07 | <adam_l> dkayiwa: I don't know... I can't find out if I can transfer List without doing some conversation |
| 21:08:23 | <dkayiwa> adam_l: try a method that returns a list of those objects |
| 21:09:46 | <adam_l> dkayiwa: ok... you are saying : "Adam, learn by getting your hands dirty" :) I will try that thanks |
| 21:09:58 | <dkayiwa> adam_l: :D |
| 21:16:17 | *** adam_l has quit IRC |
| 21:29:25 | *** yony258_ has joined #openmrs |
| 21:31:15 | <yony258_> dkayiwa: Hi, small question, im almost done with this featue. If its too late its ok. |
| 21:32:01 | <dkayiwa> yony258_: ask |
| 21:32:42 | <yony258_> dkayiwa: Ok, Im trying to do something like this: |
| 21:32:51 | <yony258_> var phone = "<spring:messagecode='appointment.Appointment.create.label.patientNoPhoneNumber'/>"; |
| 21:33:10 | <yony258_> and then do innerHTML = phone |
| 21:33:28 | <yony258_> dkayiwa: but im getting: appointment.Appointment.create.label.patientNoPhoneNumber as output. |
| 21:34:54 | <dkayiwa> yony258_: am not sure i understand |
| 21:35:12 | <yony258_> dkayiwa: Ok let me say that again |
| 21:36:04 | <yony258_> dkayiwa: I am trying to change the innerHTML of a table cell so that it will contain a message from message.properties. ok? |
| 21:38:17 | <dkayiwa> yony258_: ok |
| 21:39:15 | <dkayiwa> yony258_: are you able to get a display of this: alert( "<spring:messagecode='appointment.Appointment.create.label.patientNoPhoneNumber'/>"); |
| 21:52:06 | <yony258_> dkayiwa: nope |
| 21:52:19 | <dkayiwa> yony258_: what happens |
| 21:52:36 | <yony258_> dkayiwa: shows: appointment.Appointment.create.label.patientNoPhoneNumber |
| 21:52:38 | *** sgithens has quit IRC |
| 21:53:05 | <dkayiwa> yony258_: pastebin your message.properties file |
| 21:54:34 | <yony258_> dkayiwa: Yea I think the problem is there too because I tested with appointment.AppointmentType.title and it worked so ill recheck |
| 21:54:52 | <dkayiwa> yony258_: ok |
| 22:11:17 | <yony258_> dkayiwa: Ok great its working now, I only need to add a function and 1 unit test to finish this feature officially, and then ill push so you'll be able to review it whenever you have time. Thank you for you help |
| 22:11:59 | <dkayiwa> yony258_: you are welcome. Thank you too for the hard work!!! |
| 22:17:34 | *** wyclif_ has quit IRC |
| 22:25:53 | *** dkayiwa has quit IRC |
| 23:19:24 | *** rafa has quit IRC |
| 23:38:58 | *** yony258_ has quit IRC |
| 23:42:57 | *** yony258 has quit IRC |