| 00:43:00 | *** daiki has joined #openmrs |
| 00:43:55 | <daiki> Anyone? |
| 00:53:09 | *** daiki has quit IRC |
| 02:40:16 | *** djazayeri has joined #openmrs |
| 02:40:16 | *** ChanServ sets mode: +o djazayeri |
| 03:49:08 | *** djazayeri has quit IRC |
| 04:21:43 | *** djazayeri has joined #openmrs |
| 04:21:43 | *** ChanServ sets mode: +o djazayeri |
| 04:36:42 | *** kishoreyekkanti has joined #openmrs |
| 05:37:54 | *** jkeiper has quit IRC |
| 06:36:02 | *** adam_l_ has joined #openmrs |
| 06:40:27 | *** adam_l_ has quit IRC |
| 06:47:38 | *** dkayiwa has joined #openmrs |
| 07:20:27 | *** dkayiwa has quit IRC |
| 07:36:40 | *** Health has joined #openmrs |
| 07:38:11 | *** Health has quit IRC |
| 08:45:50 | *** pulasthi7 has joined #openmrs |
| 09:52:29 | *** rafa has joined #openmrs |
| 09:52:29 | *** ChanServ sets mode: +v rafa |
| 10:00:33 | *** dkayiwa has joined #openmrs |
| 10:48:39 | <dkayiwa> hi rafa |
| 10:48:44 | <rafa> dkayiwa: hi |
| 10:49:09 | <dkayiwa> rafa: am backporting TRUNK-3508 is 1.7.x still in svn? |
| 10:49:26 | <rafa> dkayiwa: it's in git actually |
| 10:50:18 | <dkayiwa> rafa: error: pathspec '1.7.x' did not match any file(s) known to git. |
| 10:50:27 | <dkayiwa> rafa: for git checkout 1.7.x |
| 10:50:58 | <rafa> dkayiwa: git fetch --all |
| 10:51:06 | <dkayiwa> rafa: ok thanks |
| 10:51:13 | <rafa> and then git checkout |
| 10:51:19 | <dkayiwa> rafa: ok |
| 10:51:30 | *** kjoseph has joined #openmrs |
| 10:51:38 | <rafa> dkayiwa: actually |
| 10:51:55 | <rafa> dkayiwa: let's not back port that to 1.7.x |
| 10:52:01 | <dkayiwa> rafa: ok |
| 10:57:06 | *** adam_l_ has joined #openmrs |
| 10:58:33 | *** pulasthi7 has quit IRC |
| 11:12:42 | <kjoseph> dkayiwa: have successfully pushed my first commit which is a readme.me file, |
| 11:12:54 | <dkayiwa> kjoseph: excellent :) |
| 11:13:03 | <kjoseph> dkayiwa: sorry, hi first |
| 11:13:40 | <dkayiwa> kjoseph: no problem hi second :) |
| 11:14:53 | <kjoseph> dkayiwa: now when i try pushing others am getting: Branch master set up to track remote branch master from origin. |
| 11:14:54 | <kjoseph> Everything up-to-date, what could not be happening!!! |
| 11:15:27 | <dkayiwa> kjoseph: how do you push? |
| 11:15:57 | <kjoseph> dkayiwa: may be that's the problem, am using the same command: |
| 11:16:09 | <dkayiwa> kjoseph: which command? |
| 11:16:59 | <kjoseph> dkayiwa: git push -u origin master, but now i have run git push, and am waiting again |
| 11:17:18 | <dkayiwa> kjoseph: ok |
| 11:17:47 | <dkayiwa> kjoseph: https://wiki.openmrs.org/display/docs/Using+Git |
| 11:40:39 | *** yony258 has joined #openmrs |
| 11:42:57 | *** adam_l_ has quit IRC |
| 11:43:57 | *** adam_l has joined #openmrs |
| 11:48:33 | *** dkayiwa has quit IRC |
| 12:03:48 | *** kjoseph has quit IRC |
| 12:41:56 | <yony258> adam_l: Hi |
| 12:42:10 | <adam_l> yony258: Hi |
| 12:42:34 | <yony258> adam_l: Working on something? |
| 12:43:14 | <adam_l> yony258: Yes I have one method left in the unit tests for Appointment Status |
| 12:43:35 | <yony258> adam_l: Oh ok, let me know when you are done |
| 12:43:44 | <adam_l> yony258: OK |
| 12:55:33 | *** robbyoconnor has quit IRC |
| 12:57:26 | *** dkayiwa has joined #openmrs |
| 13:02:25 | <dkayiwa> hi rafa |
| 13:02:33 | <rafa> dkayiwa: hi |
| 13:02:44 | <dkayiwa> rafa: have you just added this comment? Can you add assertNotNull(Context.getService(atdServiceClass)) and assertNotNull(Context.getService(dssServiceClass))? |
| 13:03:00 | <rafa> dkayiwa: nevermind ;) |
| 13:03:06 | <dkayiwa> rafa: ok :) |
| 13:27:02 | *** jkeiper has joined #openmrs |
| 13:27:02 | *** ChanServ sets mode: +v jkeiper |
| 13:27:32 | *** adam_l has quit IRC |
| 13:38:44 | *** wyclif_ has quit IRC |
| 13:51:33 | *** tobin_g has joined #openmrs |
| 14:13:09 | *** tobin_g has quit IRC |
| 14:29:15 | *** wyclif_ has joined #openmrs |
| 14:31:12 | *** nribeka has joined #openmrs |
| 14:31:12 | *** ChanServ sets mode: +v nribeka |
| 15:05:07 | *** andrea_ has joined #openmrs |
| 15:07:15 | <rafa> we need power... cpower |
| 15:07:52 | <andrea_> hi rafa |
| 15:08:17 | <rafa> andrea_: hi |
| 15:08:40 | <andrea_> no cpower? |
| 15:08:40 | <djazayeri> we can start without power |
| 15:08:53 | <djazayeri> !scrumon djazayeri |
| 15:08:53 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready. |
| 15:09:29 | <djazayeri> today's order: wyclif_, andrea_, dkayiwa, yony258, rafa |
| 15:09:31 | <djazayeri> then me |
| 15:10:21 | <yony258> djazayeri: Sorry just wanted to say that Im doing SCRUM later with Tobin, Daniel and Adam. cant join now. |
| 15:10:30 | <djazayeri> yony258: okay |
| 15:10:34 | <djazayeri> wyclif_: you there? |
| 15:10:42 | <wyclif_> Friday: |
| 15:10:42 | <wyclif_> Complete TRUNK-3231 - Encounter autocomplete should filter results by patient |
| 15:10:42 | <wyclif_> Merge changes for TRUNK-3593 to master - proposed concept queue - proposed concept text did not get saved to dictionary correctly |
| 15:10:42 | <wyclif_> Reviews: |
| 15:10:42 | <wyclif_> Partial review of TRUNK-2999 - Investigate replacing concept word with full text search |
| 15:10:44 | <wyclif_> |
| 15:10:46 | <wyclif_> Monday: |
| 15:10:48 | <wyclif_> Compete review of TRUNK-2999 - Investigate replacing concept word with full text search |
| 15:10:50 | <wyclif_> Follow up fix for TRUNK-3232 - Concept search should display the name containing all word tokens when multiple words are entered |
| 15:10:53 | <wyclif_> pick another bug ticket |
| 15:10:55 | <wyclif_> |
| 15:10:57 | <wyclif_> Blockers: None |
| 15:11:25 | <andrea_> Friday |
| 15:11:26 | <andrea_> Merck meeting |
| 15:11:26 | <andrea_> Continue Work on TRUNK-2768 |
| 15:11:26 | <andrea_> Failed test: |
| 15:11:26 | <andrea_> mergePatients_shouldAuditPriorDateOfBirthEstimated(org.openmrs.api.PatientServiceTest) |
| 15:11:26 | <andrea_> No blockers but questions will comment on ticket |
| 15:11:30 | <andrea_> Monday |
| 15:11:44 | <andrea_> Continue work on TRUNK-2768 |
| 15:11:45 | <djazayeri> wyclif_: for discussion later, what's up with atlas progress. |
| 15:12:18 | <andrea_> wyclif_, yes - are all tickets closed on it? |
| 15:12:22 | <dkayiwa> Had work-plan meeting with Tobin's team |
| 15:12:22 | <dkayiwa> Reviewed code and tested module for Tobin's Team |
| 15:12:22 | <dkayiwa> Back ported to 1.8.x and 1.9.x: Committed: @StartModule does not work - TRUNK-3508 |
| 15:12:24 | <dkayiwa> Working on: Search for patient by identifier fails when identifier is made of only letters - TRUNK-3822 |
| 15:12:24 | <dkayiwa> No Blockers |
| 15:13:08 | <rafa> yony258: any updates? :) |
| 15:13:27 | <djazayeri> yony258 said he'll scrum later with dkayiwa and adam |
| 15:13:31 | <djazayeri> rafa: you're up |
| 15:13:33 | <rafa> Today: |
| 15:13:34 | <rafa> * Preparing the 1.9.2 release |
| 15:13:34 | <rafa> * Looking around for mdowney |
| 15:13:34 | <rafa> No blockers. |
| 15:13:39 | *** afiles has joined #openmrs |
| 15:14:16 | <djazayeri> Friday |
| 15:14:16 | <djazayeri> * Backported TRUNK-3824 |
| 15:14:16 | <djazayeri> * Researched what we need to do to support i18n in Mirebalais |
| 15:14:16 | <djazayeri> Today |
| 15:14:16 | <djazayeri> * Mirebalais work |
| 15:14:18 | <djazayeri> no blockers |
| 15:14:42 | <djazayeri> okay, discussion points: |
| 15:14:53 | <djazayeri> wyclif_: what's up with atlas module now? |
| 15:15:29 | <wyclif_> djazayeri, as for atlas module tickets, the ones that i adde to the sprint are done, i just need to close them? andrea_ did you work on that ticket for upgrading the required openmrs version? |
| 15:16:01 | <andrea_> wyclif_, I thought when we looked at it we saw it was closed |
| 15:16:07 | <wyclif_> djazayeri, unless burke has anything else he wants to be done, i probably need to tal to him |
| 15:16:18 | <djazayeri> okay |
| 15:16:20 | <andrea_> wyclif_, what is ticket number? |
| 15:16:34 | <wyclif_> andrea_, https://tickets.openmrs.org/browse/ATLAS-43 |
| 15:16:50 | <andrea_> wyclif_, I will work on it if it's open |
| 15:16:50 | <djazayeri> !scrumoff |
| 15:16:51 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:17:27 | <djazayeri> wyclif_: can you mark that ready-for-work (if it's in fact ready?) |
| 15:18:12 | <wyclif_> djazayeri, ok |
| 15:18:13 | <andrea_> wyclif_, I will work on it - sorry for the misunderstanding |
| 15:18:20 | <wyclif_> andrea_, no problem |
| 15:18:52 | *** wyclif_ has quit IRC |
| 15:18:53 | <andrea_> wyclif_, think I remember all that's needed - will ping u later if not |
| 15:22:47 | *** wyclif_ has joined #openmrs |
| 15:28:22 | *** afiles has quit IRC |
| 15:36:16 | <djazayeri> rafa: do you think we can move the refreshApplicationContext method from ModuleUtil to ModuleFactory? |
| 15:36:38 | <djazayeri> I guess I've never really understood the breakdown between the two. |
| 15:37:57 | <djazayeri> rafa: or will that be too much refactoring for a 1.9.2 release? |
| 15:44:41 | *** rafa has quit IRC |
| 15:50:10 | *** wyclif_ has quit IRC |
| 15:51:31 | *** wyclif_ has joined #openmrs |
| 15:55:01 | *** kishoreyekkanti has quit IRC |
| 15:55:48 | *** rafa has joined #openmrs |
| 15:55:48 | *** ChanServ sets mode: +v rafa |
| 15:57:18 | <yony258> dkayiwa: Hi |
| 15:57:30 | <dkayiwa> yony258: hi |
| 15:58:55 | *** lh has joined #openmrs |
| 15:58:55 | *** lh has joined #openmrs |
| 16:00:11 | *** rafa has quit IRC |
| 16:22:27 | <yony258> dkayiwa: Just wanted to ask if you can help me split AM-4 to smaller tasks so it'll be easier for me to work. |
| 16:22:30 | <yony258> !ticket AM-4 |
| 16:22:32 | <OpenMRSBot> yony258: [#AM-4] Create new Appointment - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-4 |
| 16:22:49 | <dkayiwa> yony258: checking..... |
| 16:24:47 | <dkayiwa> yony258: can you start with just laying out the UI alone? |
| 16:25:08 | <yony258> dkayiwa: Like creating the structure of it? |
| 16:25:35 | <yony258> dkayiwa: without connecting it to any logic |
| 16:25:46 | <dkayiwa> yony258: just putting up the UI but when it does not save or load data from the database |
| 16:26:02 | <yony258> dkayiwa: ok, will do now |
| 16:26:47 | <dkayiwa> yony258: yes |
| 16:32:40 | *** andrea_ has quit IRC |
| 16:32:55 | <yony258> dkayiwa: Just asking because It can help but not important right now, is there a way to update the jsp to the code by just refreshing the page? |
| 16:33:06 | *** andrea_ has joined #openmrs |
| 16:34:16 | <dkayiwa> yony258: unfortunately not automatically at the moment. But you can copy over your changes and overwrite the deployed jsp. Then refresh |
| 16:34:43 | <yony258> dkayiwa: How do I overwrite the deployed jsp? |
| 16:34:59 | <dkayiwa> yony258: copy and paste |
| 16:35:08 | <yony258> dkayiwa: to where? |
| 16:35:28 | <dkayiwa> yony258: are you running standalone? |
| 16:35:34 | <yony258> dkayiwa: Yes |
| 16:38:08 | <dkayiwa> yony258: you can overwrite it at: .tomcat/webapps/openmrs-standalone/WEB-INF/view/module/appointment/ |
| 16:38:40 | <yony258> dkayiwa: Ok, I have another question about the AdminList.java file |
| 16:38:52 | <dkayiwa> yony258: ok |
| 16:39:11 | <yony258> dkayiwa: Why do we write ..../something.list |
| 16:39:59 | <yony258> dkayiwa: I mean why is the .list suffix ? |
| 16:40:12 | <dkayiwa> yony258: we just use a it as a convention for pages that will be listing stuff |
| 16:40:58 | <yony258> dkayiwa: Ok so if im adding the createAppointment form to the AdminList temporarily, what suffix should I use? |
| 16:42:36 | <yony258> dkayiwa: .form ? |
| 16:42:41 | *** adam_l_ has joined #openmrs |
| 16:46:47 | *** tobin_g has joined #openmrs |
| 16:50:56 | *** dkayiwa has quit IRC |
| 16:51:18 | *** dkayiwa has joined #openmrs |
| 16:51:51 | <tobin_g> yony258: do you have any design questions for me on !ticket AM-4 |
| 16:52:01 | <tobin_g> !ticket AM-4 |
| 16:52:03 | <OpenMRSBot> tobin_g: [#AM-4] Create new Appointment - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-4 |
| 16:52:14 | <tobin_g> now i feel clever |
| 16:52:27 | <yony258> tobin_g: Not right now but I think may be later. |
| 16:52:39 | <tobin_g> yony258: ok you know where to find me |
| 16:52:42 | <yony258> tobin_g: :) |
| 16:52:52 | <tobin_g> yony258: i'll have a look over it so i can wrap my head around it |
| 16:52:59 | <yony258> tobin_g: Sorry I missed you on skype we can talk now if you want |
| 16:53:24 | <tobin_g> yony258: Nothing urgent I was just checking in before |
| 16:53:30 | <yony258> tobin_g: ok |
| 16:53:53 | <yony258> dkayiwa: Still here? |
| 16:54:03 | <dkayiwa> yony258: ofcourse :) |
| 16:54:19 | <yony258> dkayiwa: I think I found an issue on LocalHeader.jsp |
| 16:54:29 | <tobin_g> dkayiwa lives on IRC :-) |
| 16:54:31 | <dkayiwa> yony258: you do not need to use it |
| 16:54:37 | <dkayiwa> tobin_g: :D |
| 16:55:26 | <yony258> dkayiwa: But Adam does, and I think generally Its good to understand. Anyway I think the c:if tag doesn't wraps the <a href> tag since even if the condition is false it will add the link to the form |
| 16:56:37 | <dkayiwa> yony258: even Adam should not use it |
| 16:56:49 | <dkayiwa> yony258: we are just going to delete it because its confusing :) |
| 16:57:11 | <yony258> dkayiwa: ok... guess I won't need to understand c:if then :) |
| 16:57:23 | <dkayiwa> yony258: atleast for now :) |
| 16:57:29 | <yony258> dkayiwa: correct |
| 16:57:59 | <tobin_g> dkayiwa: I'm looking for an example of a patient search / autofill widget in openmrs, any ideas where? |
| 16:58:06 | <tobin_g> dkayiwa: and by autofill i mean autocomplete |
| 16:58:23 | <dkayiwa> tobin_g: user interface wise? |
| 16:58:44 | <tobin_g> dkayiwa: yup |
| 16:59:01 | <tobin_g> dkayiwa: i know i've seen it just can't remember where |
| 16:59:03 | <yony258> dkayiwa: tobin_g And thats exactly my next question |
| 16:59:30 | <tobin_g> yony258: great minds think alike |
| 16:59:36 | <yony258> dkayiwa: I used AJAX to implement it in ASP.NET but have no clue how to do it here in JSP with OpenMRS conventions. |
| 16:59:51 | <yony258> dkayiwa: Maybe ill look for a form that have that and how it was implemented. |
| 17:00:28 | <dkayiwa> yony258: yes |
| 17:00:58 | <yony258> dkayiwa: findPatient.jsp :] |
| 17:01:16 | <dkayiwa> yony258: :) |
| 17:01:24 | <tobin_g> yony258: where's that in the UI so I can see it |
| 17:01:54 | <yony258> tobin_g: its in openmrs-webapp/view/findPatient.jsp |
| 17:02:19 | <yony258> dkayiwa: I have no idea how to get the values it returns but lets solve that after I'll finish creating the structure. |
| 17:02:33 | <dkayiwa> yony258: ok |
| 17:04:06 | <dkayiwa> tobin_g: do you mean something like i have here? http://localhost:8081/openmrs-standalone/admin/observations/index.htm |
| 17:05:22 | <tobin_g> dkayiwa: yes! |
| 17:05:29 | <tobin_g> dkayiwa: let me play with it but I think it's good for AM-4 |
| 17:05:36 | <dkayiwa> tobin_g: ok |
| 17:05:45 | <tobin_g> yony258: dkayiwa what i was imagining i think |
| 17:07:47 | <yony258> dkayiwa: including the findPatient causes and error |
| 17:07:59 | <yony258> dkayiwa: An error occurred at line: 4 in the jsp file: /WEB-INF/template/header.jsp Duplicate local variable useMinimalHeader |
| 17:08:28 | <dkayiwa> yony258: the findpatient jsp cannot work there |
| 17:09:34 | <tobin_g> dkayiwa: yony258 it's perfect for the top of that form |
| 17:09:54 | <yony258> dkayiwa: What portlet should I add then? |
| 17:10:19 | <yony258> dkayiwa: Where can I view documentation about openmrs:portlets? |
| 17:10:32 | <tobin_g> yony258: can i clarify / change some of the personal details right below the patient search? |
| 17:11:05 | <yony258> tobin_g: Do you want to add the ability to create a patient in that form? |
| 17:11:32 | <tobin_g> yony258: that's a VERY interesting question. Someone brought up a good point which is that sometimes people come to the clinic and want appointments who are not yet patients. |
| 17:12:17 | <yony258> tobin_g: I think that we shouldn't add it and create a patient using the current way. It will cause the create appointment form to be overloaded in the rest of the use cases. |
| 17:12:34 | <yony258> tobin_g: Maybe a button that says "create patient" will be better? |
| 17:12:40 | <tobin_g> yony258: agreed. |
| 17:13:28 | <tobin_g> yony258: we use the short form for creating patients - so a button linking to that would be fine |
| 17:14:17 | <yony258> tobin_g: The easiest way would be to redirect to findPatient.jsp which is the find/Create Patient |
| 17:14:25 | <tobin_g> yony258: that's perfect |
| 17:14:45 | <tobin_g> yony258: are we talking abot not using what daniel found? |
| 17:16:38 | <tobin_g> yony258: what i'm thinking is that you use that we use the patient search like the one on /admin/observations/index.htm then fill in some personal information below once the patient is selected |
| 17:16:57 | <adam_l_> dkayiwa: Hi daniel, tuns our the calandar staff are on another ticket. So I will just try to finish presenting the appointmentBlocks. as for now it's working but need to clear some things |
| 17:17:00 | <tobin_g> yony258: the personal information would be birthdate, ID numbers, and phone numbers to start |
| 17:17:09 | <yony258> tobin_g: Yes thats exactly what im trying to understand how to do now |
| 17:17:14 | <dkayiwa> adam_l_: ok |
| 17:17:16 | <adam_l_> dkayiwa: tuns our -> turns out |
| 17:17:17 | <tobin_g> yony258: great |
| 17:17:46 | <tobin_g> dkayiwa, maybe adam_l_ should also take that ticket? |
| 17:17:51 | <djazayeri> yony258: look for patientField.tag |
| 17:18:03 | <djazayeri> yony258: <openmrs_tag:patient formFieldName="patientId"/> |
| 17:18:09 | <yony258> djazayeri: Thank you |
| 17:18:23 | <adam_l_> tobin_g: dkayiwa Maybe after I finish with AM-3? |
| 17:18:43 | <dkayiwa> adam_l_: ok |
| 17:18:48 | <tobin_g> adam_l_: whatever makes more sense is fine with me |
| 17:19:26 | <adam_l_> tobin_g: ok i will assign to it anyways |
| 17:19:36 | <tobin_g> adam_l_: :-) |
| 17:31:28 | *** andrea_ has quit IRC |
| 17:32:09 | <adam_l_> dkayiwa: There is a way to add a drop down list with (keys,values) from the db? |
| 17:33:07 | <adam_l_> dkayiwa: can I use <select> with a for loop in it? |
| 17:33:21 | <dkayiwa> adam_l_: perfect :) |
| 17:33:37 | <adam_l_> dkayiwa: ok :) |
| 17:39:20 | <adam_l_> dkayiwa: I should show all the locations on openMRS? |
| 17:39:33 | <dkayiwa> adam_l_: yes' |
| 17:39:39 | <adam_l_> dkayiwa: super |
| 17:41:39 | <adam_l_> dkayiwa: what about retired locations? there are any? |
| 17:41:57 | <dkayiwa> adam_l_: do not show them |
| 17:42:05 | <adam_l_> dkayiwa: ok |
| 17:55:45 | <djazayeri> jkeiper: yo |
| 17:55:57 | <jkeiper> djazayeri, hay |
| 17:56:04 | <djazayeri> can we talk by voice regarding the persisted patient calculations? |
| 17:56:17 | <jkeiper> sure |
| 17:56:18 | <djazayeri> jkeiper: (I'm free in 5 minutes) |
| 17:56:21 | * jkeiper gets headphones on |
| 18:01:13 | <djazayeri> jkeiper: actually, give me 5 more minutes |
| 18:01:20 | <jkeiper> ok |
| 18:01:25 | * jkeiper keeps headphones on |
| 18:05:12 | *** tobin_g has quit IRC |
| 18:13:43 | *** harshadura has joined #openmrs |
| 18:16:02 | *** harshadura has quit IRC |
| 18:20:54 | *** apb156 has joined #openmrs |
| 18:21:01 | *** apb156 has left #openmrs |
| 18:35:37 | <jkeiper> djazayeri, shouldn't a cache be a util, not a service? |
| 18:35:50 | <jkeiper> djazayeri, or is it a service since it works with a DAO? |
| 18:35:54 | <djazayeri> jkeiper: it has to write to the database |
| 18:36:08 | <djazayeri> so that's why I called it a service. |
| 18:36:12 | <jkeiper> mmkay, that's what i thought |
| 18:36:31 | <djazayeri> jkeiper: I agree that it doesn't _feel_ like a service. |
| 18:36:49 | <jkeiper> at first i thought it should be static |
| 18:37:00 | <djazayeri> jkeiper: if you want you could even just introduce an "ExperimentalService" |
| 18:37:12 | <jkeiper> djazayeri, perhaps we make a util with static methods that keeps some stuff in memory and calls the service to load from disk! |
| 18:37:14 | <jkeiper> ;-) |
| 18:37:37 | * jkeiper loves making things complicated |
| 18:37:53 | <djazayeri> jkeiper: or give it some better name, basically indicating that things in that service are use-at-your-own-risk, and we won't guarantee those methods and signatures will continue to exist. |
| 18:38:18 | <jkeiper> ah |
| 18:38:29 | <djazayeri> That's really my only concern: don't add the method to PatientCalculationService until we're ready to stand behind "forever". |
| 18:38:29 | <jkeiper> VolatilePatientCalculationCacheService |
| 18:39:09 | <jkeiper> well, my stuff is all in a local branch anyways |
| 18:39:16 | <jkeiper> so we don't have to commit to it |
| 18:39:17 | <jkeiper> literally |
| 18:39:47 | <djazayeri> jkeiper: fair enough. |
| 18:48:37 | *** tobin_g has joined #openmrs |
| 18:49:58 | *** breeze has joined #openmrs |
| 18:52:46 | <jkeiper> djazayeri, think i should add a cache package under org.openmrs.calculation.patient? |
| 18:53:58 | <djazayeri> jkeiper: sure, though if we're going to call it a cache, perhaps we should also change Persistable to Cachable. |
| 18:54:06 | <jkeiper> aha! |
| 18:54:08 | <jkeiper> yes |
| 18:54:34 | <jkeiper> hrm, "cache" is too meaningful |
| 18:54:42 | <jkeiper> because this is permanent, not temporary |
| 18:54:48 | <jkeiper> rather, it's long-term |
| 18:55:58 | * jkeiper goes with PersistedPatientCalculationService |
| 18:56:20 | <djazayeri> jkeiper: to clarify, I think just make a catch-all "ExperimentalService" |
| 18:56:37 | <jkeiper> pl |
| 18:56:42 | <jkeiper> << one key |
| 18:56:43 | <jkeiper> ok |
| 18:57:04 | <djazayeri> and don't put it in a special package yet |
| 19:20:14 | <tobin_g> dkayiwa: yony258 adam_l_ are you guys OK to scrum a few minutes early? |
| 19:20:29 | <dkayiwa> tobin_g: am fine with that |
| 19:22:02 | <yony258> dkayiwa: Its ok if we start as planned? |
| 19:22:18 | <yony258> tobin_g: Sorry that question was for you |
| 19:22:21 | <tobin_g> yony258: fine with me |
| 19:22:44 | <tobin_g> yony258: about 10 minutes right? |
| 19:22:59 | <yony258> dkayiwa: 21:30 IST, 22:30 Ugandan Time |
| 19:23:07 | <dkayiwa> yony258: :) |
| 19:31:05 | <yony258> dkayiwa: tobin_g adam_l_ ready? |
| 19:31:20 | <tobin_g> yony258: ready |
| 19:31:50 | <adam_l_> yony258: ready |
| 19:32:25 | <yony258> dkayiwa: ? |
| 19:32:31 | <dkayiwa> yony258: yes |
| 19:32:35 | <yony258> !scrumon |
| 19:32:35 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready. |
| 19:32:38 | <yony258> Order: yony258, adam_l_, dkayiwa, tobin_g |
| 19:32:45 | <yony258> * Today: Started "Create Appointment" form, started laying out the controls |
| 19:32:49 | <yony258> * added the patientFind tag and added Appointment Type and Clinician comboBox, |
| 19:32:53 | <yony258> * added messages didn't commit yet. |
| 19:32:57 | <yony258> * Tomorrow: Continue Working on this form |
| 19:33:02 | <yony258> * Blockers: Currently none, will need help with the search patient feature, how to use the returned variable. |
| 19:33:23 | <yony258> adam_l_: you are next |
| 19:34:32 | <adam_l_> adam_l_: Added the api level for Appointment Status and did unit tests for it and every thing works fine. Did some work on the Appointment Block UI and will finish it soon |
| 19:35:05 | <dkayiwa> adam_l_: any blockers? |
| 19:35:26 | <adam_l_> dkayiwa: no :) |
| 19:35:39 | <dkayiwa> Reviewed commits and tested module |
| 19:35:40 | <tobin_g> adam_l_: tomorrow will you also start on the calendar ticket? |
| 19:35:40 | <dkayiwa> Continuing to review |
| 19:35:40 | <dkayiwa> No Blockers |
| 19:36:04 | <tobin_g> checked in with everybody, briefly talked with yonatan about design of create apointment page |
| 19:36:20 | <tobin_g> tomorrow: continue with create appointment design as requested |
| 19:36:23 | <tobin_g> blockers: none |
| 19:36:30 | <yony258> !scrumoff |
| 19:36:30 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:36:43 | <adam_l_> tobin_g: I hope I will start today... tomorrow I don't think I will have much time but I will try |
| 19:36:46 | <yony258> tobin_g: adam_l_ dkayiwa now we can continue and discuss if there are any questions |
| 19:37:01 | <dkayiwa> yony258: 8) |
| 19:37:06 | <tobin_g> yony258: ok i broke the rules |
| 19:38:15 | <yony258> tobin_g: dkayiwa Keep in mind we won't have time tomorrow to do a lot of work, maybe 1h. Tomorrow we will be studying from 9am till 9pm with 1 hour window. And on 8am the next day we have to deliver the presentation. |
| 19:38:35 | <tobin_g> yony258: ok |
| 19:38:47 | <dkayiwa> yony258: thanks for informing us in advance :) |
| 19:39:02 | <tobin_g> dkayiwa: ++ |
| 19:39:17 | <dkayiwa> tobin_g: was that meant for yony258 ? :) |
| 19:39:24 | <dkayiwa> yony258++ |
| 19:39:37 | <yony258> dkayiwa: :) |
| 19:39:41 | <tobin_g> yony258: ++ |
| 19:40:30 | <yony258> tobin_g: dkayiwa We will do a lot of work on Wednesday and Thursday thats for sure. And I mean that we will get things done. |
| 19:40:46 | <dkayiwa> yony258: excellent!!! |
| 19:40:51 | <tobin_g> yony258: excellent!! |
| 19:41:09 | <tobin_g> dkayiwa: does chris powers ever come on irc? |
| 19:41:19 | <adam_l_> dkayiwa: totally :) we will commit like crazy |
| 19:41:26 | <yony258> adam_l_: ++ |
| 19:41:30 | <dkayiwa> tobin_g: yes he mostly comes during scrum time :) |
| 19:41:45 | <tobin_g> dkayiwa: ok never heard back from him re: extending our sprint? |
| 19:42:17 | <dkayiwa> adam_l_: wonderfull. You are already comitting good :D |
| 19:42:38 | <tobin_g> adam_l_ ++ |
| 19:42:51 | <tobin_g> adam_l_: yony258 very productive day! |
| 19:43:00 | <dkayiwa> tobin_g: you can ping him |
| 19:43:17 | <adam_l_> tobin_g: dkayiwa thanks :) |
| 19:43:20 | <tobin_g> dkayiwa: via email or with some irc magic? |
| 19:43:29 | <dkayiwa> tobin_g: email :) |
| 19:43:40 | <tobin_g> dkayiwa: ok |
| 19:45:22 | <dkayiwa> yony258: about your question, when you enclose it inside this: <spring:bindpath="appointment.patient"> the return value will be automatically bound to the page model |
| 19:45:38 | <dkayiwa> yony258: in this case, will be automatically bound to the appointment object |
| 19:46:06 | <yony258> dkayiwa: Hmm good, I'll experiment with this a bit |
| 19:46:12 | <dkayiwa> yony258: ok |
| 19:47:58 | <yony258> dkayiwa: Had a question about styling the form, I guess I can use css as soon as Im done with all of the functionality, correct? |
| 19:48:28 | <dkayiwa> yony258: correct |
| 19:48:43 | <dkayiwa> yony258: any time you want :) |
| 19:49:00 | <jkeiper> djazayeri, want me to stick with ExperimentalItem for the service-and-dao interaction objects? |
| 19:49:20 | <jkeiper> or should it be PatientResultItem |
| 19:49:28 | <jkeiper> to go with table name calculation_patient_result |
| 19:50:31 | <yony258> dkayiwa: By the way why does the main bar font goes crazy when I click on "Reporting"? (1.9.1 standalone, chrome 23.0.127) ? |
| 19:51:17 | <dkayiwa> yony258: will need to look at it first :) |
| 19:52:34 | <yony258> dkayiwa: Before clicking: http://i.snag.gy/NyxLL.jpg , After Clicking: http://i.snag.gy/6luHx.jpg |
| 19:53:46 | <dkayiwa> yony258: ok |
| 20:02:21 | *** tobin_g has quit IRC |
| 20:07:34 | <yony258> dkayiwa: How do I present future dates? |
| 20:07:56 | <yony258> dkayiwa: I mean I am using /scripts/calendar/calendar.js, but its for only past dates |
| 20:08:15 | <dkayiwa> yony258: should be like some sort of parameter for the widget |
| 20:08:39 | <yony258> dkayiwa: onfocus="showCalendar(this,60) is the only parameter |
| 20:08:46 | <yony258> dkayiwa: 60 says 60 years back. |
| 20:09:08 | <dkayiwa> yony258: let me have a look at it now.... |
| 20:13:46 | <yony258> dkayiwa: Im looking at the javascript code for calender.js and I dont see a support for future dates. |
| 20:13:59 | <dkayiwa> yony258: looking at it too |
| 20:15:03 | <dkayiwa> yony258: am looking at the datetime widget and it has future years |
| 20:15:18 | <dkayiwa> yony258: http://localhost:8081/openmrs-standalone/admin/visits/visit.form?patientId=7280 |
| 20:16:12 | <yony258> dkayiwa: The timepicker.js has future dates. |
| 20:16:27 | <dkayiwa> yony258: can you use that? |
| 20:17:27 | <yony258> dkayiwa: Hmm yes I can but I think the calender.js should support this, or at least be updated to support this |
| 20:17:37 | <dkayiwa> yony258: i agree |
| 20:17:48 | <dkayiwa> yony258: there has to be a way for it to |
| 20:18:35 | <yony258> dkayiwa: Like adding a Integer futureYears, or just if the int is negative so it counts as future |
| 20:18:51 | <yony258> dkayiwa: Anyway ill use the timepicker.js |
| 20:18:52 | <dkayiwa> yony258: try that and see |
| 20:22:59 | <yony258> dkayiwa: what does the :c10 says? |
| 20:23:06 | <yony258> dkayiwa: in the js file of calender |
| 20:24:46 | <dkayiwa> yony258: i have no idea :) |
| 20:30:19 | *** rafa has joined #openmrs |
| 20:30:19 | *** ChanServ sets mode: +v rafa |
| 20:31:04 | <yony258> dkayiwa: Who wrote that file? |
| 20:31:49 | <yony258> dkayiwa: My implementation goes both ways (future and past), Maybe I shall use it instead?> |
| 20:32:25 | <yony258> dkayiwa: Or just let me know where I should place my calender.js file and i'll use it |
| 20:32:30 | <dkayiwa> yony258: am trying to do an svn blame... :) |
| 20:32:54 | <yony258> dkayiwa: :] sry its ok... |
| 20:32:54 | <dkayiwa> yony258: oh i thought you had changed to timepicker |
| 20:33:18 | <yony258> dkayiwa: I fixed the calender implementation, I think its better than I'll add my own calender |
| 20:33:25 | <yony258> *that |
| 20:33:31 | <dkayiwa> yony258: oh excellent |
| 20:33:56 | <dkayiwa> yony258: you fixe the openmrs core calender? |
| 20:34:12 | <yony258> dkayiwa: I added the option to go to the future :) |
| 20:34:45 | <dkayiwa> yony258: do you mind creating a ticket and then create a pull request with your change? :) |
| 20:35:03 | <dkayiwa> yony258: thats is for openmrs-core |
| 20:35:17 | <yony258> dkayiwa: Im not so sure about that, here is my implementation: http://pastebin.com/ZUYJmkyN |
| 20:35:39 | <dkayiwa> yony258: not sure about how to create a ticket? |
| 20:35:56 | <yony258> dkayiwa: I think its better that I'll just create my own calender for this module, since I dont know what that c was for and I deleted it. I used jQuery calender before and never had a c. |
| 20:37:07 | <dkayiwa> yony258: pushing your change as part of a ticket and pull request will make it a goody for other modules too |
| 20:37:30 | <dkayiwa> yony258: besides, will make the module smaller since you would not need a custom widget |
| 20:38:00 | <yony258> dkayiwa: Ok where should I make a ticket? |
| 20:38:06 | <dkayiwa> yony258: JIRA |
| 20:38:33 | <yony258> dkayiwa: lol I know, but should I mail it to the devlist too or there is someone responsible for checking new tickets. |
| 20:38:56 | <dkayiwa> yony258: you can add as many watchers as you want |
| 20:40:00 | <dkayiwa> yony258: every week we have a developer looking at such tickets and curating them: https://wiki.openmrs.org/display/RES/Ticket+Curation+Swim+Lane |
| 20:40:28 | <dkayiwa> yony258: dev list is when you want to have some discussion about it |
| 20:41:23 | <yony258> dkayiwa: I think my implementation will cause issues since I did erased something that I dont know what is purpose for. plus I have no idea what to choose on the ticket category and ticket type :) |
| 20:42:10 | <dkayiwa> yony258: let that (whether it will break or not) be decided by the reviewer of your pull request |
| 20:42:44 | <dkayiwa> yony258: you do not have to fill all ticket details. the ticket curator can fill in the missing details :) |
| 20:43:08 | <yony258> dkayiwa: How do I push that? cant I just send the pastebin implementation? |
| 20:45:10 | <dkayiwa> yony258: pastebin is still better than nothing, but pull request is the recommended way (has more advantages) :) |
| 20:45:24 | <dkayiwa> yony258: have you already forked openmrs-core? |
| 20:46:55 | <yony258> !ticket TRUNK-3829 |
| 20:46:56 | <OpenMRSBot> yony258: [#TRUNK-3829] Change calendar.js to support future dates. - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3829 |
| 20:47:28 | <dkayiwa> yony258: on a side note, though this may appear as distracting you from the task at hand, it is very very good way of introducing you to core openmrs development and increasing your open source development experience!!! :) |
| 20:48:09 | <dkayiwa> so yony258 +++ |
| 20:48:31 | <yony258> dkayiwa: That is true, but while looking at the time right now I think ill focus on my current tasks, but you are absolutely right. |
| 20:48:44 | <dkayiwa> yony258: :D |
| 20:49:04 | <dkayiwa> yony258: i almost persuaded you :) |
| 20:49:55 | <yony258> dkayiwa: Haha, in the mean time ill show you what Ive completed by now: http://i.snag.gy/3vk4G.jpg |
| 20:50:06 | <dkayiwa> yony258: ok |
| 20:50:49 | <dkayiwa> yony258: how about changing patient name to patient? |
| 20:50:57 | <dkayiwa> yony258: since one can enter name or id |
| 20:51:17 | <yony258> dkayiwa: Correct. |
| 20:51:37 | <dkayiwa> yony258: i think this is a good start :) |
| 20:51:50 | <yony258> dkayiwa: Yes, in 3h I agree |
| 20:52:04 | <dkayiwa> yony258: :D |
| 20:56:09 | *** rafa has quit IRC |
| 21:01:31 | *** lh has quit IRC |
| 21:16:28 | <yony258> dkayiwa: Ok im done for today, commit link will be sent soon. please review this whenever you have time, not urgent. |
| 21:16:28 | <yony258> https://github.com/openmrs/openmrs-module-appointment/commit/4cc484535a0133bf309688074000ae90d544ae1a#commitcomment-2245439 |
| 21:16:33 | <OpenMRSBot> <http://ln-s.net/+Dkj> (at github.com) |
| 21:16:46 | <yony258> adam_l_: dkayiwa Good night |
| 21:17:14 | <dkayiwa> yony258: sure thanks |
| 21:17:48 | <dkayiwa> yony258: have a good night and please do not dream about the calender widget :D |
| 21:18:13 | <yony258> dkayiwa: lol, I'll try not to :D |
| 21:22:32 | *** yony258 has quit IRC |
| 21:27:58 | *** adam_l_ has quit IRC |
| 21:29:13 | *** breeze has quit IRC |
| 21:34:38 | *** lh has joined #openmrs |
| 21:38:30 | *** jkeiper has quit IRC |
| 21:41:44 | *** dkayiwa has quit IRC |
| 22:05:24 | *** lh has quit IRC |
| 22:13:17 | *** wyclif_ has quit IRC |
| 23:19:27 | *** wyclif_ has joined #openmrs |
| 23:28:03 | *** nribeka has quit IRC |
