| 00:40:42 | <djazayeri> andrea__: comment them on the ticket! it helps to have asynchronous discussion. :-) |
| 00:41:06 | <djazayeri> or else ask them... |
| 00:41:10 | <djazayeri> (here) |
| 02:14:39 | *** harshadura has joined #openmrs |
| 02:48:03 | <andrea__> djazayeri, will do - talk to you Monday |
| 02:48:13 | *** andrea__ has quit IRC |
| 05:28:34 | *** djazayeri has quit IRC |
| 08:09:49 | *** AdamLauz has joined #openmrs |
| 09:17:25 | *** yony258 has joined #openmrs |
| 09:20:05 | *** yony258 has quit IRC |
| 09:22:19 | *** yony258 has joined #openmrs |
| 09:22:37 | <yony258> AdamLauz: Hi |
| 09:26:14 | <AdamLauz> yony258: Hi how are you? :) |
| 09:42:57 | *** AdamLauz has quit IRC |
| 09:45:32 | *** Echidna has quit IRC |
| 09:47:52 | *** Echidna has joined #openmrs |
| 09:47:52 | *** zelazny.freenode.net sets mode: +v Echidna |
| 10:11:41 | *** rafa has joined #openmrs |
| 10:11:41 | *** ChanServ sets mode: +v rafa |
| 10:16:34 | *** fishandwalk has quit IRC |
| 10:18:45 | *** adam_l_ has joined #openmrs |
| 11:33:47 | *** adam_l_ has quit IRC |
| 12:49:47 | *** AdamLauz has joined #openmrs |
| 12:53:48 | *** AdamLauz has quit IRC |
| 13:15:26 | *** kishoreyekkanti has joined #openmrs |
| 13:27:27 | *** rafa has quit IRC |
| 15:54:13 | *** rafa has joined #openmrs |
| 15:54:13 | *** ChanServ sets mode: +v rafa |
| 16:12:15 | *** djazayeri has joined #openmrs |
| 16:12:15 | *** ChanServ sets mode: +o djazayeri |
| 16:31:42 | *** kavuri has joined #openmrs |
| 16:35:02 | *** yony258 has quit IRC |
| 16:40:38 | *** djazayeri has quit IRC |
| 16:50:20 | *** kavuri has quit IRC |
| 17:23:36 | *** djazayeri has joined #openmrs |
| 17:23:36 | *** ChanServ sets mode: +o djazayeri |
| 17:24:38 | *** yony258 has joined #openmrs |
| 17:30:59 | <yony258> Working on the appointment module, does anyone have any idea why <spring:bind ="someObject.someProperty" will cause java.lang.reflect.InvocationTargetException saying it has a problem with the getter for this property? |
| 17:55:50 | *** gschiltz has joined #openmrs |
| 17:55:52 | *** gschiltz has left #openmrs |
| 17:56:31 | *** gschiltz has joined #openmrs |
| 18:10:47 | *** rafa has quit IRC |
| 18:15:45 | *** dkayiwa has joined #openmrs |
| 18:16:23 | <dkayiwa> hi yony258 |
| 18:16:31 | <yony258> dkayiwa: Hi ! |
| 18:16:36 | <yony258> dkayiwa: How are you? |
| 18:17:00 | <dkayiwa> yony258: am doing fine. and you? |
| 18:17:10 | <yony258> dkayiwa: Great |
| 18:17:31 | <yony258> dkayiwa: You can look at the commits if you want to catch up, I had some spare time so I did some work. |
| 18:17:44 | <dkayiwa> yony258: oh great!!! |
| 18:18:33 | <yony258> dkayiwa: In short: All tests are working, Validators updated, Module loading successfully to OpenMRS. |
| 18:18:55 | <dkayiwa> yony258: oh thats so so so cool!!!!. great work. :) |
| 18:19:45 | <yony258> dkayiwa: Thanks :), I added some error messages to the messages file, its on the last commit let me know if I did that correctly. |
| 18:20:00 | <dkayiwa> yony258: ok |
| 18:33:16 | <yony258> dkayiwa: And also I tried to change the forms you made for AppointmentType and add the duration property but I have some problems with that. (<spring:bind path="appointmentType.duration" caused an error ) |
| 18:33:35 | <dkayiwa> yony258: which error? |
| 18:33:51 | <yony258> dkayiwa: Invalid property 'duration' of bean class [org.openmrs.module.appointment.AppointmentType]: Getter for property 'duration' threw exception; nested exception is java.lang.reflect.InvocationTargetException |
| 18:35:33 | <dkayiwa> yony258: let me pull and look at it |
| 18:35:48 | <yony258> dkayiwa: Ok I'll push |
| 18:36:00 | <dkayiwa> yony258: ok tell me after you have pushed |
| 18:36:29 | <gschiltz> Howdy, first time chatter here, so be kind :-) |
| 18:36:39 | <yony258> dkayiwa: pushed |
| 18:37:00 | <dkayiwa> yony258: ok let me pull |
| 18:37:34 | <gschiltz> I'm trying to get the Enterprise installation working on OS X, and am getting a bunch of DB errors. |
| 18:39:22 | <dkayiwa> yony258: can you change the type in the method to Integer? |
| 18:39:36 | <yony258> dkayiwa: Which method? |
| 18:40:14 | <dkayiwa> yony258: setDuration |
| 18:40:56 | <dkayiwa> yony258: you also have this: <input type="duration" name="name" |
| 18:41:11 | <yony258> dkayiwa: Yea changed it to type="text" name="duration" |
| 18:41:27 | <dkayiwa> yony258: and the method type to Integer? |
| 18:41:34 | <yony258> dkayiwa: Yes |
| 18:41:43 | <dkayiwa> yony258: and then did you test again? |
| 18:41:48 | <yony258> dkayiwa: I'll try that now |
| 18:41:52 | <dkayiwa> ok |
| 18:43:22 | <yony258> dkayiwa: Works now :), now I need to figure how do I prevent from sending empty duration |
| 18:43:51 | <dkayiwa> yony258: ok |
| 18:43:56 | <yony258> dkayiwa: Should I use the Validator for that? |
| 18:44:06 | <dkayiwa> yony258: yes |
| 18:49:58 | *** djazayeri has quit IRC |
| 18:54:31 | <yony258> dkayiwa: Oh by the way I added TimeSlot with all the necessary files and tests. So I think we have all we need in order to create the forms for this Sprint. |
| 18:54:54 | <yony258> dkayiwa: I'll leave AppointmentStatus for Adam so that he can learn what I took over. |
| 18:55:09 | <dkayiwa> yony258: excellent!!! :) |
| 18:56:19 | <yony258> dkayiwa: Ok finished updating the forms, works. :) |
| 18:56:39 | <dkayiwa> yony258: great work man!!! :) |
| 18:56:41 | *** gschiltz has quit IRC |
| 18:57:27 | <yony258> dkayiwa: Thanks you ! |
| 18:57:47 | <dkayiwa> yony258: thank you more :) |
| 18:58:03 | <dkayiwa> yony258: i just wish Adam put in as much as you do :) |
| 18:59:01 | <yony258> dkayiwa: Well its a Saturday so I wouldn't expect him to work today, and Im sure he will contribute a lot more. Its just that I had some time this weekend so I invested it to promote the sprint. |
| 18:59:33 | <dkayiwa> yony258: not referring to today in particular |
| 18:59:48 | <dkayiwa> yony258: am meaning generally the time since we started the sprint :) |
| 19:00:24 | <yony258> dkayiwa: I can understand what you mean ;) but trust me he will contribute A LOT more :) |
| 19:00:42 | <dkayiwa> yony258: please encourage him :) |
| 19:01:28 | <yony258> dkayiwa: Don't worry as soon as Sunday comes you will see a lot from him, he do have a lot to contribute. |
| 19:01:38 | <yony258> dkayiwa: So what I think we I need now is to get your review on the commits, if you can today it will be great, if not than let me know so that I won't wait :) |
| 19:02:06 | <dkayiwa> yony258: let me start doing the review now :) |
| 19:02:24 | <yony258> dkayiwa: Great, let me know when you finish a commit I'll look at the comments. |
| 19:02:47 | <dkayiwa> yony258: sure |
| 19:12:14 | *** lh has joined #openmrs |
| 19:12:14 | *** lh has joined #openmrs |
| 19:26:47 | *** yony258_ has joined #openmrs |
| 19:27:32 | *** yony258 has quit IRC |
| 19:27:42 | *** yony258_ is now known as yony258 |
| 19:37:52 | <dkayiwa> yony258: what does the forceInt function do? |
| 19:38:09 | <yony258> dkayiwa: Forgot to remove it. Will remove it now. |
| 19:38:16 | <dkayiwa> yony258: ok |
| 19:39:53 | <dkayiwa> yony258: the empty messages have keys that need to be changed to reflect it |
| 19:40:11 | <yony258> dkayiwa: For example? |
| 19:40:13 | <dkayiwa> yony258: for instance: ${project.parent.artifactId}.Appointment.TimeSlot.block=Empty time slot block |
| 19:40:31 | <yony258> dkayiwa: got it |
| 19:40:55 | <dkayiwa> yony258: such that by just looking at the key, you know what text it could be pointing to :0 |
| 19:40:56 | <dkayiwa> :) |
| 19:41:08 | <yony258> dkayiwa: Good point. |
| 20:00:55 | <dkayiwa> yony258: can we remove the primary key parameters from the domain object constructors? |
| 20:01:56 | <yony258> dkayiwa: yea will do right away |
| 20:02:34 | <dkayiwa> yony258: we can have an extra constructor which takes only one parameter, which is the object's primary key |
| 20:02:51 | <yony258> dkayiwa: Why do we want that? |
| 20:02:53 | <dkayiwa> yony258: public Appointment(Integer appointmentId) |
| 20:03:10 | <dkayiwa> yony258: useful in like unit tests. eg new Location(1) |
| 20:34:16 | <yony258> dkayiwa: Should I assign values to other properties in Constructor(Integer Id), or just setId(Integer Id) ? |
| 20:59:50 | <dkayiwa> yony258: sorry i had stepped out a bit :) |
| 21:00:03 | <yony258> dkayiwa: Its ok :) |
| 21:00:10 | <dkayiwa> yony258: only the id |
| 21:00:18 | <yony258> dkayiwa: Watching Juventus in the meantime... |
| 21:00:21 | <yony258> dkayiwa: ok |
| 21:00:27 | <dkayiwa> yony258: hahahaha |
| 21:00:36 | <dkayiwa> yony258: otherwise the commit looks good |
| 21:00:57 | <yony258> dkayiwa: Ok so you finished reviewing? should I commit my fix? |
| 21:01:09 | <dkayiwa> yony258: yes commit |
| 21:02:25 | <yony258> dkayiwa: pushed |
| 21:02:33 | <dkayiwa> yony258: ok let me pull |
| 21:12:21 | <dkayiwa> hi yony258 |
| 21:13:33 | <yony258> dkayiwa: ? |
| 21:14:11 | <dkayiwa> yony258: have you seen my github comments |
| 21:14:31 | <yony258> dkayiwa: just what you wrote on IRC |
| 21:15:21 | <yony258> dkayiwa: I missed stuff? |
| 21:15:38 | <dkayiwa> yony258: github comments |
| 21:16:00 | <yony258> dkayiwa: Ok, you are right |
| 21:16:04 | <yony258> dkayiwa: I'll fix |
| 21:24:34 | *** djazayeri has joined #openmrs |
| 21:24:34 | *** ChanServ sets mode: +o djazayeri |
| 21:26:37 | <dkayiwa> yony258: so what do you want to work on next |
| 21:26:56 | <yony258> dkayiwa: UI? |
| 21:27:04 | <dkayiwa> yony258: ok |
| 21:27:06 | <yony258> dkayiwa: I want to leave AppointmentStatus for Adam |
| 21:27:14 | <dkayiwa> yony258: ok |
| 21:27:39 | *** djazayeri1 has joined #openmrs |
| 21:28:34 | <yony258> dkayiwa: Im talking about Resource Scheduling UI (Define AppointmentBlock) what do you think? |
| 21:29:06 | <dkayiwa> yony258: correct |
| 21:29:30 | *** djazayeri has quit IRC |
| 21:29:38 | <yony258> dkayiwa: So I'll really need your help since the UI I developed were WPF, ASP.NET. Not JSP / Spring |
| 21:29:51 | <dkayiwa> yony258: ok |
| 21:30:40 | <yony258> dkayiwa: You plan to be here tomorrow or is it a vacation day? (Like Saturday here) |
| 21:30:55 | <dkayiwa> yony258: will be on for some time |
| 21:31:29 | <yony258> dkayiwa: Ok well anyway Im done for today, got some university assignment, Im planning to start tomorrow. |
| 21:31:45 | <yony258> dkayiwa: The Resource Scheduling UI. |
| 21:31:49 | <dkayiwa> yony258: ok. well done!!! |
| 21:32:04 | <yony258> dkayiwa: Thank you :) |
| 21:32:13 | <dkayiwa> yony258: :) |
| 21:36:17 | *** yony258 has quit IRC |
| 21:41:31 | *** dkayiwa has quit IRC |
| 22:15:52 | *** kishoreyekkanti has quit IRC |
| 22:49:24 | *** sgithens has joined #openmrs |
| 23:00:15 | *** harshadura has quit IRC |