| 00:10:59 | *** shangxiao has joined #openmrs |
| 00:12:46 | *** wyclif_ has joined #openmrs |
| 00:23:09 | *** shangxiao has quit IRC |
| 01:42:47 | *** gschiltz has quit IRC |
| 01:51:49 | *** gschiltz has joined #openmrs |
| 01:52:11 | *** gschiltz has left #openmrs |
| 02:14:50 | *** jkeiper has joined #openmrs |
| 02:14:50 | *** ChanServ sets mode: +v jkeiper |
| 02:45:27 | *** andrea_ has quit IRC |
| 03:26:46 | *** shangxiao has joined #openmrs |
| 03:35:36 | * shangxiao pings djazayeri |
| 03:35:45 | <shangxiao> Hey djazzy you there? :) |
| 03:37:48 | *** lh has quit IRC |
| 03:47:01 | *** djazayeri has quit IRC |
| 04:14:49 | *** kishoreyekkanti has joined #openmrs |
| 04:14:53 | *** jaga has joined #openmrs |
| 04:15:03 | <jaga> hi |
| 04:15:46 | *** jaga has quit IRC |
| 04:18:13 | *** fishandwalk has joined #openmrs |
| 04:20:06 | *** shangxiao has quit IRC |
| 04:38:06 | *** hif has joined #openmrs |
| 04:54:56 | *** robbyoconnor has joined #openmrs |
| 04:54:56 | *** ChanServ sets mode: +v robbyoconnor |
| 04:58:47 | *** hif has quit IRC |
| 05:01:17 | *** ningosi has joined #openmrs |
| 05:01:31 | *** ningosi is now known as ojwanganto |
| 06:35:24 | *** kishoreyekkanti has quit IRC |
| 07:55:12 | *** ojwanganto has quit IRC |
| 09:11:13 | *** ibewes has joined #openmrs |
| 09:11:29 | <ibewes> greetings all |
| 09:16:48 | *** dkayiwa has joined #openmrs |
| 09:27:24 | *** kishoreyekkanti has joined #openmrs |
| 09:56:36 | *** harshadura has joined #openmrs |
| 10:00:38 | *** robbyoconnor has quit IRC |
| 10:30:59 | *** dkayiwa has quit IRC |
| 10:38:30 | *** rafa has joined #openmrs |
| 10:38:30 | *** ChanServ sets mode: +v rafa |
| 10:38:52 | *** yony258 has joined #openmrs |
| 10:51:17 | *** dkayiwa has joined #openmrs |
| 10:57:18 | <yony258> dkayiwa: Hi |
| 10:57:27 | <dkayiwa> yony258: hi |
| 10:58:05 | <yony258> dkayiwa: Good morning, got time to look at the tests errors? |
| 10:58:46 | <dkayiwa> yony258: yes am ever ready |
| 11:06:30 | <yony258> dkayiwa: Ok I got the unvoid test to work |
| 11:06:40 | <dkayiwa> yony258: ok good |
| 11:07:13 | <yony258> dkayiwa: and the shouldVoid |
| 11:07:21 | <dkayiwa> yony258: ok |
| 11:07:50 | <yony258> dkayiwa: Can you please look at the error for "shouldSave" test? |
| 11:08:06 | <dkayiwa> yony258: have you failed to fix it? |
| 11:08:52 | <yony258> dkayiwa: Let me check if I understood it. It cant save it because one of its properties wasn't save in the DB |
| 11:09:00 | <yony258> *wasn't saved |
| 11:09:56 | <dkayiwa> yony258: ok so you are checking |
| 11:11:02 | <yony258> dkayiwa: Sorry what? |
| 11:12:03 | <dkayiwa> yony258: can you attempt to fix it? |
| 11:12:18 | <yony258> dkayiwa: No because I dont have saveTimeSlot |
| 11:13:04 | <yony258> dkayiwa: Can I fix that without it? |
| 11:13:18 | <dkayiwa> yony258: can you create it |
| 11:13:27 | <yony258> dkayiwa: Yes. |
| 11:13:35 | <dkayiwa> yony258: ok go ahead and fix it |
| 11:13:48 | <yony258> dkayiwa: Ok let me try |
| 11:13:54 | <dkayiwa> yony258: ok |
| 11:19:44 | *** harshadura has quit IRC |
| 11:28:56 | <yony258> dkayiwa: I think I made a mess |
| 11:29:38 | <dkayiwa> yony258: ok |
| 11:30:41 | <yony258> dkayiwa: You sure that was the problem? |
| 11:31:39 | <dkayiwa> yony258: does the test pass after your fix? |
| 11:31:47 | <yony258> dkayiwa: Im still fixing |
| 11:32:13 | <dkayiwa> yony258: so cant tell until after you fix |
| 11:32:29 | <yony258> dkayiwa: I cant fix this |
| 11:32:42 | <yony258> dkayiwa: Its more complicated than I thought |
| 11:33:22 | <dkayiwa> yony258: ok push whatever you have |
| 11:33:26 | <yony258> dkayiwa: If I want to save the timeSlot I need to save the block. If I want to save the block I need to create list of apptmenttypes |
| 11:33:47 | <yony258> dkayiwa: Too much problems with AppointmentBlock |
| 11:33:51 | <dkayiwa> yony258: cant you create them? |
| 11:34:08 | <dkayiwa> yony258: can you first fix the appointment block tests? |
| 11:34:13 | <yony258> dkayiwa: This method will be like 20 lines |
| 11:34:34 | <dkayiwa> yony258: as long as it fixes it |
| 11:34:58 | <yony258> dkayiwa: Ok it'll probably take me a lot of time but sure, can I send you in the meantime what I did maybe you can fix it while I fix appointmentBlock tests? |
| 11:35:32 | <dkayiwa> yony258: i can fix everything. but i just do not want to deny you an opportunity to learn |
| 11:36:19 | <yony258> dkayiwa: Yes thats good but Im not sure how to fix this error. I do want your explanations about the errors in the last 2 tests. (HQL related) |
| 11:36:48 | <dkayiwa> yony258: can you first of all fix the appointmentblock errors? |
| 11:37:01 | <yony258> dkayiwa: I mean I want to get this fixed before Sunday, and we both cant work tomorrow and today's evening. |
| 11:37:16 | <yony258> dkayiwa: Yes I'll work on that, in the meantime I'll push my changes |
| 11:37:31 | <dkayiwa> yony258: i want you to fix each and every test that you can |
| 11:37:48 | <dkayiwa> yony258: then after that, you get me a list of tests which you have failed to fix |
| 11:38:06 | <yony258> dkayiwa: Ok. So maybe explain to me what is the problem in this test? |
| 11:38:25 | <dkayiwa> yony258: for now, ignore tests that you have failed to fix |
| 11:38:31 | <yony258> dkayiwa: Which started as: "object references an unsaved transient instance" error |
| 11:38:39 | <dkayiwa> yony258: and then move on to fix those which you can |
| 11:39:01 | <dkayiwa> yony258: it is after that when you will push and i have a look at them |
| 11:39:04 | <dkayiwa> yony258: not so? |
| 11:39:49 | <yony258> dkayiwa: Ok I trust your judgment |
| 11:40:01 | *** hif has joined #openmrs |
| 11:40:03 | <yony258> dkayiwa: When do you need to go today? |
| 11:40:21 | <dkayiwa> yony258: at 6pm Ugandan time |
| 11:40:44 | <yony258> dkayiwa: Ok same here |
| 11:40:51 | <dkayiwa> yony258: by the way where is Adam? |
| 11:41:05 | *** hif has quit IRC |
| 11:41:19 | <dkayiwa> yony258: you seem to be doing all his work!!! |
| 11:41:34 | *** AdamLauz has joined #openmrs |
| 11:41:40 | <yony258> dkayiwa: Here is Adam !! |
| 11:41:55 | <yony258> dkayiwa: :) |
| 11:42:05 | <yony258> AdamLauz: Hi man, how are you? |
| 11:42:20 | <dkayiwa> yony258: he is the one who is supposed to be fixing the appointment block errors |
| 11:42:27 | <AdamLauz> yony258: OK how are you?? :) |
| 11:42:40 | <dkayiwa> AdamLauz: you seem to be rare :) |
| 11:42:57 | <AdamLauz> dkayiwa: what happend? |
| 11:43:08 | <dkayiwa> AdamLauz: ley yony258 tell you :) |
| 11:45:28 | *** kishoreyekkanti has quit IRC |
| 11:48:56 | *** harshadura has joined #openmrs |
| 11:51:32 | <yony258> dkayiwa: I updated Adam, he will be working on AppointmentBlockServiceTest now |
| 11:51:47 | <dkayiwa> yony258: ok thanks |
| 11:55:18 | <yony258> dkayiwa: Ok in the meantime can you please explain to me what that error says? |
| 11:55:33 | <dkayiwa> yony258: which error? |
| 11:55:37 | <yony258> dkayiwa: "object references an unsaved transient instance" error |
| 11:55:59 | <dkayiwa> yony258: have you tried to google it? |
| 11:56:14 | <yony258> dkayiwa: I think it says that before saving this object we need to save its properties (if they are domain objects too). Is that correct? |
| 11:56:50 | <dkayiwa> yony258: ok |
| 11:57:21 | <yony258> dkayiwa: Ok = correct? or Ok= incorrect ? |
| 12:01:21 | <dkayiwa> yony258: correct :) |
| 12:03:07 | *** harshadura has quit IRC |
| 12:04:27 | <yony258> dkayiwa: Great, maybe can we focus now on the 2 last tests, The problem is with the query |
| 12:04:37 | <yony258> dkayiwa: Let me push all |
| 12:04:41 | <dkayiwa> yony258: ok |
| 12:05:30 | <yony258> dkayiwa: pushed |
| 12:05:38 | <dkayiwa> yony258: ok |
| 12:06:15 | <yony258> dkayiwa: Let me direct you to the source of the problem |
| 12:06:38 | <yony258> dkayiwa: Im talking about test: getAppointmentByVisit_shouldGetCorrectAppointment (in AppointmentServiceTest.java" |
| 12:06:41 | <dkayiwa> yony258: ok |
| 12:07:12 | <yony258> dkayiwa: The problem is with the query in HibernateAppointmentDAO.java, in function: getAppointmentsByPatient |
| 12:09:55 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenHMIS Cashier Module 1.0.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=openhmis.cashier&version=&1.0.0> |
| 12:10:39 | <dkayiwa> yony258: do you think you can fix the errors in AppointmentBlockServiceTest ? |
| 12:11:08 | <yony258> dkayiwa: AdamLauz |
| 12:11:30 | <dkayiwa> yony258: am not sure when he will get time to fix them. i would prefer you who is available now |
| 12:11:49 | <yony258> dkayiwa: AdamLauz he is working on them right now with my help |
| 12:12:07 | <AdamLauz> dkayiwa: I'm working on it my friend :) |
| 12:12:10 | <yony258> dkayiwa: But in that function Im sure its not related to AppointmentBlock |
| 12:12:39 | <yony258> Im talking about the second test from the bottom. |
| 12:17:21 | <dkayiwa> yony258: have you failed to fix the three failing tests in AppointmentServiceTest ? |
| 12:17:47 | <yony258> dkayiwa: Focus about the last 2 tests. |
| 12:17:58 | <dkayiwa> yony258: and the third one? |
| 12:18:02 | <yony258> dkayiwa: I want to understand how to fix it, |
| 12:18:11 | <yony258> dkayiwa: I will fix it |
| 12:18:13 | <dkayiwa> yony258: the formula is to first fix as many as you can |
| 12:18:30 | <yony258> dkayiwa: I need AppointmentBlock fixed to fix it. |
| 12:18:35 | <dkayiwa> yony258: it is after then that we can move on to those you have failed to fix |
| 12:18:46 | <yony258> dkayiwa: So in the meantime lets focus on the last 2 |
| 12:19:16 | <dkayiwa> yony258: why don't you in the meantime fix those you can? |
| 12:19:48 | <yony258> dkayiwa: Because Adam is working on AppointmentBlock now so I cant try and fix that now. |
| 12:20:04 | <yony258> dkayiwa: So while Adam is working we can fix the last two |
| 12:20:47 | <dkayiwa> yony258: am inclined to have you take over fixing them. simply because the tests failing is a blocker for us and you have more experience at fixing them |
| 12:23:02 | <yony258> dkayiwa: Ok what if we will solve those 2 tests and then I will take over the other ones so that we can all finish with that today? |
| 12:23:49 | <dkayiwa> yony258: because i know after you fix the others, you will somehow learn how to fix these two. So it is a learning trick :) |
| 12:24:14 | <yony258> dkayiwa: But the other ones dont have anything related to this type of queries |
| 12:24:26 | <dkayiwa> yony258: that is what you think :) |
| 12:24:42 | <yony258> dkayiwa: Ok I'll try it your way |
| 12:24:51 | <dkayiwa> yony258: AdamLauz can finish with whatever he was doing |
| 12:25:24 | <dkayiwa> yony258: since you have more coding time than him, i want you to be the one working on blocking issues :0 |
| 12:25:25 | <dkayiwa> :) |
| 12:25:50 | <yony258> dkayiwa: So you want me to tell AdamLauz to stop and fix his tests and then fix my tests? |
| 12:26:33 | <dkayiwa> yony258: no. i want him continue with the UI he was working on. Then you continue with fixing all the failing unit tests |
| 12:26:44 | <dkayiwa> yony258: blockers issue need someone who is more available |
| 12:27:06 | <yony258> AdamLauz: are you following on this? |
| 12:27:09 | <dkayiwa> yony258: the UI is not blocking us and so it is safer to have him concentrate on that |
| 12:28:22 | <dkayiwa> yony258: am sure you can fix them (with my help) before 6pm. |
| 12:28:27 | *** ningosi has joined #openmrs |
| 12:28:37 | <dkayiwa> yony258: but as for AdamLauz , he can go off any minute from now :) |
| 12:29:00 | *** ningosi is now known as ojwanganto |
| 12:30:20 | <yony258> dkayiwa: But then how will AdamLauz learn how to do Unit Tests? |
| 12:30:50 | <dkayiwa> yony258: we still have many more unit tests to create. so he can learn with those |
| 12:30:58 | <yony258> dkayiwa: Ok |
| 12:31:03 | <dkayiwa> yony258: right now i just want us have a stable build |
| 12:32:13 | <yony258> dkayiwa: ok, in the meantime can you fix AppointmentTypeServiceTest? |
| 12:32:15 | <dkayiwa> yony258: that is because Darius is setting up a CI server which should find all our tests passing |
| 12:32:53 | <dkayiwa> yony258: i want to help you fix it after you have fixed appointment block errors |
| 12:33:05 | <yony258> dkayiwa: Ok |
| 12:33:46 | <dkayiwa> yony258: in summary, fix all tests that you can, then push and we start together on whichever ones you will have failed to fix |
| 12:36:28 | <AdamLauz> dkayiwa: the thing is I am stuck with the UI because it also related to AppointmentBlock... can I run without the tests? |
| 12:37:28 | <dkayiwa> AdamLauz: yes you can tell maven to skip tests |
| 12:41:33 | <AdamLauz> dkayiwa: ok |
| 12:49:38 | <yony258> dkayiwa: How Can I see the SQL statement hibernate is doing? |
| 12:50:10 | <dkayiwa> yony258: you can turn on sql logging |
| 12:50:19 | <yony258> dkayiwa: How do I do that? |
| 12:51:02 | <dkayiwa> yony258: look at hibernate.default.properties |
| 12:51:27 | <dkayiwa> yony258: hibernate.show_sql=true |
| 12:52:08 | <AdamLauz> dkayiwa: can I use -Dmaven.test.skip=true? |
| 12:52:25 | <dkayiwa> AdamLauz: excellent!!! :) |
| 12:53:04 | <yony258> dkayiwa: Where can I find "hibernate.default.properties" ? |
| 12:53:19 | <dkayiwa> yony258: in openmrs-core |
| 12:53:34 | <dkayiwa> yony258: are you running the standalone version? |
| 12:54:07 | <AdamLauz> dkayiwa: It's succeseds but I don't see the appointment-0.1-SNAPSHOT.omod file created why is that? I wrote clean install -Dmaven.test.skip=true |
| 12:54:32 | <yony258> dkayiwa: I dont think its related. im talking about watching the sql statement when working with junit |
| 12:54:34 | <dkayiwa> AdamLauz: in which folder are you looking |
| 12:55:09 | *** sgithens has joined #openmrs |
| 12:55:49 | <AdamLauz> I was loading the old appointment module so I deleted the file inorder to see if mvn is creating it.... turns out it doesn't |
| 12:56:21 | <AdamLauz> dkayiwa: openmrs-module-appointment\omod\target |
| 12:57:58 | *** ibewes has quit IRC |
| 12:59:07 | <AdamLauz> dkayiwa: never mind now it's working... sorry for that |
| 13:01:07 | <dkayiwa> yony258: do you have the file openmrs-runtime.properties in your app data directory |
| 13:01:51 | <dkayiwa> yony258: e.g on mine: /Users/danielkayiwa/.OpenMRS/openmrs-runtime.properties |
| 13:02:46 | <dkayiwa> yony258: unit tests still use a runtime properties file |
| 13:03:57 | <AdamLauz> dkayiwa: daniel it gives me this error http://pastebin.com/dH3zAdg9 |
| 13:05:42 | <AdamLauz> dkayiwa: It seems like something wrong it the liquibase file |
| 13:06:34 | <dkayiwa> AdamLauz: can you pastebin the entire tomcat log |
| 13:07:56 | <AdamLauz> dkayiwa: http://pastebin.com/MbCtMf9X |
| 13:09:08 | <dkayiwa> AdamLauz: can you 1) drop all appointment module tables |
| 13:09:31 | <dkayiwa> AdamLauz: after that, you tell me to guide you on next step |
| 13:09:38 | <AdamLauz> ok |
| 13:13:33 | <AdamLauz> dkayiwa: what is the next step? |
| 13:14:47 | <AdamLauz> dkayiwa: I see now I need to build it again |
| 13:15:06 | <AdamLauz> dkayiwa: or just to load it? |
| 13:17:36 | <dkayiwa> AdamLauz: now open the liquibasechangelog database table |
| 13:19:46 | <AdamLauz> dkayiwa: where it is? |
| 13:19:56 | <dkayiwa> AdamLauz: in the database |
| 13:20:05 | <AdamLauz> ok |
| 13:20:34 | <AdamLauz> dkayiwa: I'm there |
| 13:21:03 | <dkayiwa> AdamLauz: delete all rows with changeset ids as we have in the liquibase.xml file |
| 13:21:33 | <dkayiwa> AdamLauz: like on my msql GUI, i just do Ctrl + F |
| 13:21:49 | <dkayiwa> AdamLauz: to search for rows with a certain value |
| 13:22:08 | <dkayiwa> AdamLauz: start with the very first id which is: 10000000-1000-appointment-type |
| 13:27:43 | <yony258> dkayiwa: Ok im back from lunch. |
| 13:28:19 | <yony258> dkayiwa: How can I see the Hibernate SQL statements when I run jUnit, I mean im not even starting my standalone |
| 13:28:41 | <dkayiwa> yony258: did you see my earlier instructions? |
| 13:28:49 | <yony258> dkayiwa: AppData ? |
| 13:28:54 | <dkayiwa> yony258: yes |
| 13:30:24 | *** wyclif_ has quit IRC |
| 13:36:13 | <yony258> dkayiwa: ok all AppointmentTypeServiceTest tests works now |
| 13:36:35 | <dkayiwa> yony258: excellent!!! :D |
| 13:37:00 | *** shangxiao has joined #openmrs |
| 13:37:07 | <yony258> dkayiwa: I have an error in all of the AppointmentBlock tests that I dont know how to fix |
| 13:37:27 | <dkayiwa> yony258: ok push and i have a look at it |
| 13:37:56 | <yony258> dkayiwa: ok, here is the error: "org.openmrs.module.appointment.AppointmentBlock, setter method of property: types" |
| 13:37:59 | <yony258> dkayiwa: ok |
| 13:40:30 | <yony258> dkayiwa: pushed |
| 13:41:10 | <dkayiwa> yony258: ok |
| 13:41:48 | *** harshadura has joined #openmrs |
| 13:46:06 | <yony258> dkayiwa: The cause is that it expects a list but gets a PersistentSet |
| 13:46:31 | <dkayiwa> yony258: change from private List<AppointmentType> types; to private Set<AppointmentType> types; |
| 13:47:04 | <yony258> dkayiwa: And if I want to implement it as a List ? |
| 13:47:26 | <dkayiwa> yony258: the hibernate mapping file would need to change to reflect that |
| 13:47:49 | <yony258> dkayiwa: What is the change? (Just so I'll learn) |
| 13:47:52 | <dkayiwa> yony258: you will also need to run the AppointmentBlock through the openmrs formatter |
| 13:48:08 | <dkayiwa> yony258: i think from set to bag in the mapping file |
| 13:48:22 | <yony258> dkayiwa: ok let me change that to set |
| 13:49:18 | <yony258> dkayiwa: Is there a way to change all the related methods to use Set too automatically ? |
| 13:49:34 | <dkayiwa> yony258: not very sure |
| 13:49:54 | *** sgithens has quit IRC |
| 13:51:23 | <yony258> dkayiwa: Its a big change to do. need to update all AppointmentType too, won't it be simpler to change it to bag since we dont really need that as a Set? |
| 13:51:48 | *** suranga has joined #openmrs |
| 13:51:48 | *** ChanServ sets mode: +v suranga |
| 13:51:53 | <dkayiwa> yony258: make the change in only one class. AppointmentBlock |
| 13:52:21 | <dkayiwa> yony258: Set will ensure we do not get duplicates :) |
| 13:52:26 | <yony258> dkayiwa: But I need to change too the methods that use List<AppointmentType> to Set<AppointmentType> |
| 13:53:00 | <yony258> dkayiwa: And the interfaces too |
| 13:53:02 | <dkayiwa> yony258: those are only two methods in the appointmentBlock class |
| 13:53:16 | <yony258> dkayiwa: getAllAppointmentTypes() |
| 13:53:37 | <dkayiwa> yony258: deal with one thing at a time |
| 13:54:06 | <dkayiwa> yony258: so change only in the appointment block class and then run the tests again for AppointmentBlockServiceTest |
| 13:54:36 | <yony258> dkayiwa: Cant change only in appointment block, Compilation Errors.... |
| 13:54:47 | <dkayiwa> yony258: ok. change that too |
| 13:55:43 | <yony258> dkayiwa: Then I need to change SingleClassDAO too to return Set<T> |
| 13:56:02 | <yony258> dkayiwa: It is a lot of changes since there are cases we need to return List<T> |
| 13:56:56 | <dkayiwa> yony258: oh i see |
| 13:57:06 | <yony258> dkayiwa: A lot of changes.... |
| 13:57:34 | <yony258> dkayiwa: It will be a lot easier to just do bag in the mapping file |
| 13:57:54 | <dkayiwa> yony258: ok |
| 13:57:56 | <yony258> dkayiwa: because the model scheme will enforce no duplicates anyway |
| 13:58:17 | <dkayiwa> yony258: you must be right :) |
| 13:58:36 | <yony258> dkayiwa: Ok, what do I need to do in the mapping file |
| 13:59:02 | <dkayiwa> yony258: change set to bag |
| 13:59:58 | <yony258> dkayiwa: Ok. Next Error :) |
| 14:00:07 | <dkayiwa> yony258: :) |
| 14:00:24 | <yony258> dkayiwa: NoPrimaryKeyException APPOINTMENT_BLOCK_TYPE_MAP |
| 14:00:36 | <yony258> dkayiwa: I think I didnt configured correctly the complex key for this map |
| 14:00:41 | <yony258> *for this table |
| 14:01:15 | <dkayiwa> yony258: ok |
| 14:02:08 | <yony258> dkayiwa: what I did is to add primaryKey="true" for both of those properties. I guess this isnt the right way to do that |
| 14:04:30 | <yony258> dkayiwa: Maybe instead I should've used the addPrimaryKey constratint |
| 14:04:58 | <dkayiwa> yony258: to be consistent with the rest of openmrs, lets use a set instead of bag |
| 14:05:20 | <yony258> dkayiwa: Which means we need to change everything to set correct? |
| 14:05:38 | <dkayiwa> yony258: lets start with hibernateblock object |
| 14:05:55 | <dkayiwa> yony258: and then we got on checking what else we may need to change |
| 14:06:13 | <yony258> dkayiwa: The problem is that we need to change SingleClassDAO |
| 14:06:23 | <dkayiwa> yony258: yes lets change it |
| 14:07:09 | <yony258> dkayiwa: Ok it will probably take a few hours |
| 14:07:23 | <dkayiwa> yony258: i can do it for you in 5mins |
| 14:07:40 | <yony258> dkayiwa: ok |
| 14:07:43 | <dkayiwa> yony258: and then i push for you to pull |
| 14:07:47 | <yony258> dkayiwa: ok |
| 14:07:47 | <dkayiwa> yony258: should i? |
| 14:07:52 | <yony258> dkayiwa: yes |
| 14:08:02 | <dkayiwa> yony258: ok let me start right away |
| 14:08:07 | <yony258> dkayiwa: Great, thanks |
| 14:10:51 | *** lh has joined #openmrs |
| 14:10:51 | *** lh has joined #openmrs |
| 14:12:55 | <yony258> dkayiwa: By the way, we need to change AppointmentStatus to HistoryStatus and add a Set<HistoryStatus> in Appointment.java |
| 14:14:04 | *** wyclif_ has joined #openmrs |
| 14:14:44 | <dkayiwa> yony258: lets first make the unit tests pass :0 |
| 14:14:46 | <dkayiwa> :) |
| 14:15:03 | <dkayiwa> yony258: you can pull now |
| 14:15:04 | <yony258> dkayiwa: Yes sure, just pointing this out. |
| 14:15:10 | <yony258> dkayiwa: wow that was fast |
| 14:15:13 | <dkayiwa> yony258: ok thanks :) |
| 14:18:09 | <yony258> dkayiwa: Can't pull |
| 14:18:23 | <yony258> dkayiwa: HTTP request failed |
| 14:18:49 | <dkayiwa> yony258: possibly because you had changes |
| 14:18:59 | <dkayiwa> yony258: you can discard them and then pull |
| 14:19:10 | <yony258> dkayiwa: error: The requested URL returned error: 502 while accessing https://github.com/openmrs/openmrs-module-appointment.git/info/refs |
| 14:19:36 | <dkayiwa> yony258: you can right click from eclipse -> Team -> Reset -> Hard |
| 14:20:01 | <dkayiwa> yony258: that is for projects where you have made changes |
| 14:20:14 | <yony258> dkayiwa: just did git checkout --, git pull |
| 14:20:24 | <dkayiwa> yony258: ok |
| 14:20:25 | <yony258> dkayiwa: works |
| 14:20:29 | <dkayiwa> yony258: ok great |
| 14:24:29 | *** wyclif_ has quit IRC |
| 14:24:48 | *** suranga has quit IRC |
| 14:27:44 | <AdamLauz> dkayiwa: stil don't work :( |
| 14:27:58 | <dkayiwa> AdamLauz: i had not finished the steps |
| 14:28:09 | <dkayiwa> AdamLauz: which step did you stop at? |
| 14:28:28 | <AdamLauz> dkayiwa: Deleted the data from the appointment_block |
| 14:28:45 | <dkayiwa> AdamLauz: i never mentioned that step :) |
| 14:29:04 | <dkayiwa> AdamLauz: let me say them again |
| 14:29:16 | <dkayiwa> AdamLauz: 1) drop all appointment tables |
| 14:29:19 | <AdamLauz> dkayiwa: and all the others you have mentioned ... |
| 14:29:30 | <dkayiwa> AdamLauz: what was the second one? |
| 14:29:38 | <yony258> dkayiwa: Ok, now the problem is in getAll of HibernateSingleClassDAO. Restrictions.eq("retired", includeRetired) should be in some cases "voided" |
| 14:30:03 | *** wyclif_ has joined #openmrs |
| 14:30:09 | <AdamLauz> dkayiwa: to delete all the ids |
| 14:30:15 | <dkayiwa> yony258: retired and voided are different |
| 14:30:20 | <dkayiwa> AdamLauz: from which table? |
| 14:30:22 | <AdamLauz> dkayiwa: in the liquibase |
| 14:30:38 | <dkayiwa> AdamLauz: delete which ids and from which table name? |
| 14:30:44 | <AdamLauz> dkayiwa: all tables in the liquibase |
| 14:30:57 | <dkayiwa> AdamLauz: there is not table named liquibase |
| 14:31:15 | <AdamLauz> dkayiwa: changeset |
| 14:31:30 | <dkayiwa> AdamLauz: there is no table named changeset |
| 14:31:57 | <yony258> dkayiwa: Ok but its trying Retired on AppointmentBlock, which has Voided |
| 14:32:31 | <dkayiwa> yony258: which method call? |
| 14:32:40 | <AdamLauz> dkayiwa: liquibasechangelog* |
| 14:33:02 | <dkayiwa> AdamLauz: how many ids did you delete from that table? |
| 14:33:59 | <yony258> dkayiwa: HibernateSingleClassDAO.java Method: public List<T> getAll(boolean includeRetired) |
| 14:34:07 | <AdamLauz> dkayiwa: I deleted the whole thing... dropped all and reinstalled |
| 14:34:44 | <dkayiwa> AdamLauz: no you were not supposed to delete the whole liquibasechangelog table. did you? |
| 14:36:20 | <AdamLauz> dkayiwa: yes by mistake |
| 14:36:40 | <AdamLauz> dkayiwa: I didn't mean to |
| 14:38:50 | <dkayiwa> AdamLauz: that means you need to drop the openmrs database |
| 14:39:04 | <dkayiwa> AdamLauz: and run openmrs setup afresh |
| 14:39:09 | <AdamLauz> dkayiwa: I did |
| 14:39:19 | <AdamLauz> dkayiwa: that's what I did |
| 14:39:26 | <dkayiwa> AdamLauz: pastebin the error you get when you try install the module |
| 14:39:34 | <dkayiwa> yony258: i have pushed a fix for that |
| 14:39:35 | <AdamLauz> dkayiwa: the same |
| 14:39:44 | <AdamLauz> dkayiwa: do you want the log? |
| 14:39:44 | <dkayiwa> AdamLauz: pastebin the tomcat log |
| 14:39:48 | *** ojwanganto has quit IRC |
| 14:39:49 | <AdamLauz> dkayiwa: ok |
| 14:40:42 | <AdamLauz> dkayiwa: http://pastebin.com/y0Xutqnm |
| 14:41:49 | <dkayiwa> AdamLauz: does your openmrs run? |
| 14:42:00 | <dkayiwa> AdamLauz: as in are you able to login? |
| 14:42:12 | <AdamLauz> dkayiwa: It's down now |
| 14:42:36 | <dkayiwa> AdamLauz: are you using standalone? |
| 14:42:46 | <rafa> guys you keep the channel busy :D |
| 14:43:03 | <dkayiwa> rafa: :D |
| 14:43:22 | <rafa> how is it going? good progress? |
| 14:43:41 | <dkayiwa> rafa: yes for learning :) |
| 14:43:41 | <yony258> rafa: Is it good or bad ? |
| 14:43:49 | <AdamLauz> dkayiwa: yes |
| 14:43:50 | <rafa> yony258: very good! |
| 14:44:09 | <yony258> dkayiwa: Alright now we only got 4 tests to fix. pushing now |
| 14:44:23 | <dkayiwa> AdamLauz: 1) close the standalone |
| 14:44:39 | <dkayiwa> AdamLauz: 2) delete the database folder inside the standalone |
| 14:44:58 | <dkayiwa> AdamLauz: 3) Run the standalone again and choose Demo Data |
| 14:45:14 | <dkayiwa> AdamLauz: thats should be all to have a running instance of openmrs |
| 14:45:25 | <yony258> dkayiwa: pushed. |
| 14:45:26 | <dkayiwa> yony258: ok tell me when its time to pull |
| 14:45:27 | <AdamLauz> dkayiwa: ok |
| 14:45:33 | <dkayiwa> yony258: oh you are too fast :0 |
| 14:45:34 | <dkayiwa> :) |
| 14:45:41 | <yony258> dkayiwa: Haha |
| 14:46:51 | <yony258> dkayiwa: But just remember I need to understand how to fix those myself. :) |
| 14:47:09 | <dkayiwa> yony258: yes you are the one who is going to fix them :) |
| 14:47:25 | <yony258> dkayiwa: Great. :) |
| 14:49:35 | <dkayiwa> yony258: you are adding a provider who does not exist |
| 14:49:43 | <dkayiwa> yony258: saveAppointmentBlock_shouldSaveNewAppointmentBlock |
| 14:49:50 | <yony258> dkayiwa: k |
| 14:49:55 | *** sgithens has joined #openmrs |
| 14:50:10 | <yony258> dkayiwa: Then I think I can fix 2 tests |
| 14:50:19 | <dkayiwa> yony258: please do |
| 14:50:26 | <yony258> dkayiwa: ok |
| 14:52:43 | <yony258> dkayiwa: How do I save provider? |
| 14:53:20 | <AdamLauz> dkayiwa: What to do now? |
| 14:53:36 | <dkayiwa> yony258: you can get one using new Provider(1) |
| 14:53:42 | <dkayiwa> AdamLauz: are you able to login? |
| 14:53:51 | <AdamLauz> dkayiwa: yes |
| 14:54:20 | <dkayiwa> AdamLauz: now install the module |
| 14:55:33 | <AdamLauz> dkayiwa: different error |
| 14:55:48 | <dkayiwa> AdamLauz: pastebin the log |
| 14:56:15 | <AdamLauz> dkayiwa: the tomcat log? |
| 14:56:23 | <dkayiwa> AdamLauz: yes |
| 15:00:50 | *** djazayeri has joined #openmrs |
| 15:00:50 | *** ChanServ sets mode: +o djazayeri |
| 15:01:35 | *** cpower has joined #openmrs |
| 15:01:41 | <cpower> hello |
| 15:01:51 | <cpower> Are we ready to scrum? |
| 15:02:47 | <cpower> That silence is golden |
| 15:02:48 | <djazayeri> I guess |
| 15:03:02 | <cpower> !scrumon cpower |
| 15:03:02 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:03:04 | <rafa> cpower: put me as last |
| 15:03:51 | <cpower> Order: djazayeri, AdamLauz, dkayiwa, wyclif_, yony258, anyone else, and then rafa |
| 15:04:26 | <djazayeri> Yesterday |
| 15:04:26 | <djazayeri> * Calls |
| 15:04:26 | <djazayeri> * Committed TRUNK-3824 - BaseCustomizableMetadata.setAttribute doesn't work when updating existing attributes |
| 15:04:26 | <djazayeri> * Worked on design for question-per-screen form engine |
| 15:04:26 | <djazayeri> Today |
| 15:04:26 | <djazayeri> * Backport TRUNK-3824 |
| 15:04:27 | <djazayeri> * More Mirebalais work |
| 15:04:27 | <djazayeri> no blockers |
| 15:05:36 | *** andrea_ has joined #openmrs |
| 15:06:15 | <cpower> AdamLauz are you there? |
| 15:06:40 | <cpower> dkayiwa you are up |
| 15:07:06 | <dkayiwa> Worked with Tobin's Team all day long :) |
| 15:07:07 | <dkayiwa> Working on: Search for patient by identifier fails when identifier is made of only letters - TRUNK-3822 |
| 15:07:07 | <dkayiwa> No Blockers |
| 15:07:33 | <cpower> why wyclif_...why! You are next |
| 15:07:40 | <cpower> ;-) |
| 15:07:45 | <AdamLauz> cpower: yes sorry |
| 15:08:02 | <wyclif_> Thursday: |
| 15:08:02 | <wyclif_> Created and worked on ATLAS-47 - Fix atlas bubble data form to fit on the map canvas |
| 15:08:02 | <wyclif_> dev call |
| 15:08:02 | <wyclif_> Clean up and apply pull request for TRUNK-3812 - QueryException received while searching for concepts through ConceptService |
| 15:08:02 | <wyclif_> TRUNK-3231 - Encounter autocomplete should filter results by patient |
| 15:08:04 | <wyclif_> |
| 15:08:06 | <wyclif_> Friday: |
| 15:08:08 | <wyclif_> Complete TRUNK-3231 - Encounter autocomplete should filter results by patient |
| 15:08:10 | <wyclif_> review and apply pull requests |
| 15:08:12 | <wyclif_> pick a bug ticket |
| 15:08:14 | <wyclif_> |
| 15:08:16 | <wyclif_> Blockers: None |
| 15:08:20 | <AdamLauz> dkayiwa: http://pastebin.com/E67G37KS |
| 15:08:31 | <cpower> yony258 you are up |
| 15:08:34 | <yony258> Yesterday: Finished writing Unit Tests for AppointmentServiceTest. Today: Fixing Errors with AppointmentServiceTest, AppointmentBlockTest, AppointmentTypeTest. Blockers: none |
| 15:08:52 | <cpower> AdamLauz you can update now if you are ready |
| 15:10:09 | <cpower> ok while he gets ready, andrea_ if you are you can go |
| 15:10:31 | <AdamLauz> AdamLauz: yesterday finished AppointmentBlockTest but have bugs that yony258 is fixing. Working on the UI right now appointmentBlockList |
| 15:11:02 | <cpower> anything you need help with (blockers?) |
| 15:11:28 | <AdamLauz> cpower: yes but dkayiwa is helping me to fix it |
| 15:11:32 | <cpower> k |
| 15:11:36 | <cpower> andrea_ you are u |
| 15:11:38 | <cpower> up |
| 15:11:39 | <andrea_> Thursday |
| 15:11:39 | <andrea_> Dev call |
| 15:11:39 | <andrea_> Work on TRUNK-2768 |
| 15:11:39 | <andrea_> Added code to: |
| 15:11:39 | <andrea_> Person.java |
| 15:11:40 | <andrea_> HibernatePatientSetDAO.java |
| 15:11:42 | <andrea_> PatientServiceImpl.java |
| 15:11:44 | <andrea_> HL7ServiceImpl.java |
| 15:11:48 | <andrea_> Friday |
| 15:11:50 | <andrea_> Merck documentation |
| 15:11:52 | <andrea_> Continue Work on TRUNK-2768 |
| 15:11:55 | <AdamLauz> cpower: some error while loading the module |
| 15:12:01 | <andrea_> No blockers |
| 15:12:15 | <AdamLauz> dkayiwa: http://pastebin.com/E67G37KS |
| 15:12:21 | <dkayiwa> AdamLauz: ok |
| 15:12:22 | <rafa> Today: |
| 15:12:22 | <rafa> * Fixed META-299: ConceptReferenceTerm not merged properly |
| 15:12:22 | <rafa> https://tickets.openmrs.org/browse/META-299 |
| 15:12:22 | <rafa> * Made Metadata Sharing CI GREEN! first time ever! ;-) |
| 15:12:22 | <rafa> Blockers: Not enough permissions to investigate why https://ci.openmrs.org/browse/DEMO-DEVTEST01A fails (downey is too strict about permissions :P) |
| 15:12:24 | <cpower> andrea_ are you done with atlas tickets or is this somehow associated? |
| 15:12:43 | <djazayeri> andrea_: I'm curious why you needed to change HL7 Service, and PatientSetService. |
| 15:12:49 | <andrea_> cpower, wycliff did ticket we were working on |
| 15:12:58 | <djazayeri> andrea_: (discuss after) |
| 15:13:07 | <andrea_> cpower, I think that's it with atlas |
| 15:13:11 | <cpower> but there were multiple Atlas tickets correct? |
| 15:13:33 | <andrea_> wyclif_, is that true? Is that alll for Atlas? |
| 15:14:05 | <andrea_> cpower, a lot were closed when wyclif and I looked at tthem |
| 15:14:09 | <wyclif_> andrea_, did you work on those tickets i asked you to work on? |
| 15:14:18 | <wyclif_> andrea_, i think it was one |
| 15:14:29 | <wyclif_> andrea_, the one to change the required openmrs version |
| 15:14:48 | <andrea_> wyclif_, the one Burke needed to look at? |
| 15:15:19 | <andrea_> wyclif_ , thought we saw it had been closed |
| 15:15:21 | <wyclif_> andrea_, djazayeri i need to talk to burke and ask him if he is comfortable with the status of the module after the few fixes |
| 15:15:40 | <wyclif_> andrea_, burke said that other one need design |
| 15:16:08 | <cpower> rafa, how urgent is your permission needs? |
| 15:16:09 | <andrea_> wyclif_, will be glad to do that one but thought we found out it was done |
| 15:16:43 | <cpower> Downey has a few items before you so I need to know if I should find an alternate way of getting it for you. |
| 15:16:45 | <andrea_> wyclif, let me know if there is anything left to do |
| 15:16:46 | <rafa> cpower: not very urgent |
| 15:16:58 | <cpower> ok |
| 15:17:02 | <rafa> cpower: I'm done for today anyway |
| 15:17:08 | <cpower> ok |
| 15:17:18 | <djazayeri> +1 to rafa's comment that Downey needs to give us more privileges on that devdemo VM |
| 15:18:30 | <cpower> so wyclif_ and andrea_, andrea_ is working on other things until Atlas gets reviewed by Burke? |
| 15:18:45 | <dkayiwa> AdamLauz: you did not give me all contents of the tomcat log file |
| 15:18:50 | <andrea_> wyclif, what is ticket number of the one to change the required openmrs version? |
| 15:18:58 | <AdamLauz> dkayiwa: I will give it to you again |
| 15:19:05 | <wyclif_> cpower, yes |
| 15:19:12 | <cpower> ok |
| 15:19:20 | <andrea_> wyclif_, and one that needed design? |
| 15:19:32 | <AdamLauz> dkayiwa: http://pastebin.com/DmpRTpqN |
| 15:19:48 | <cpower> dkayiwa, AdamLauz, and yony258, is there some items that andrea_ could assist you with? |
| 15:20:09 | <dkayiwa> cpower: will discuss it through |
| 15:20:12 | <yony258> cpower: I think that dkayiwa can answer it better than us |
| 15:20:13 | <andrea_> cpower, wyclif_, thats what I thought - working on other things until Atlas gets reviewed by Burke? |
| 15:20:27 | <cpower> may only be a day, but something is better than nothing. |
| 15:20:32 | <dkayiwa> yony258: appointment object has no visitId property |
| 15:20:37 | <dkayiwa> yony258: so change it to visit |
| 15:20:45 | <yony258> dkayiwa: :) |
| 15:20:53 | <dkayiwa> yony258: that is in HibernateAppointmentDAO.getAppointmentByVisit |
| 15:21:21 | <cpower> andrea_, no problem, I just want to see if I can get you working on current sprint stuff instead of bug tickets if possible, if not then keep working on what you are working on. |
| 15:22:04 | <dkayiwa> yony258: change that and try run all the unit tests again |
| 15:22:20 | <cpower> !scrumoff |
| 15:22:20 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:22:54 | <djazayeri> andrea_: why the need to change PatientSetService to deal with deathDateEstimated? |
| 15:22:58 | <cpower> ok dkayiwa let me and Andrea know if you find something sprint related for her to work on. |
| 15:23:06 | <dkayiwa> cpower: ok |
| 15:23:33 | <AdamLauz> dkayiwa:do you have an idea? |
| 15:23:45 | <cpower> for proper english correction, Andrea and I (trying to get better and not breaking the language too bad) |
| 15:24:01 | <dkayiwa> AdamLauz: still waiting for your tomcat log :) |
| 15:24:03 | <andrea_> djazayeri, beause birhdateEstimated is there - |
| 15:24:43 | <andrea_> djazayeri, will email you some questions |
| 15:24:47 | <djazayeri> andrea_: okay, just make sure you don't change any method signatures of public methods (e.g. ones in the service) |
| 15:24:59 | <djazayeri> andrea_: why not ask the questions as comments on the ticket? |
| 15:25:09 | <AdamLauz> dkayiwa: http://pastebin.com/DmpRTpqN |
| 15:25:19 | <AdamLauz> dkayiwa: I have sent it... |
| 15:25:28 | <andrea_> djazayeri, ok will do that |
| 15:25:36 | <dkayiwa> AdamLauz: ok |
| 15:25:41 | <dkayiwa> yony258: how is it going? |
| 15:25:50 | <yony258> dkayiwa: Still having issues |
| 15:26:10 | <dkayiwa> yony258: how many more tests failling? |
| 15:26:17 | <yony258> dkayiwa: 2 |
| 15:26:32 | <dkayiwa> yony258: which and which? |
| 15:26:46 | <yony258> dkayiwa: Same two.... |
| 15:26:58 | <yony258> dkayiwa: Same too just different errors. |
| 15:26:59 | <dkayiwa> yony258: did you make the change in HibernateAppointmentDAO ? |
| 15:27:03 | <yony258> *two |
| 15:27:06 | <yony258> dkayiwa: Yes of course |
| 15:27:19 | <dkayiwa> yony258: that should have fixed one of the two |
| 15:27:29 | <dkayiwa> yony258: which change did you make there? |
| 15:27:55 | <andrea_> djazayeri, questions are long - maybe I should use pastebin now |
| 15:28:04 | <yony258> instead of "at.visitId" I wrote "at.visit" |
| 15:28:25 | <dkayiwa> yony258: ok push what you have |
| 15:28:27 | <AdamLauz> dkayiwa: http://pastebin.com/rKmLasET |
| 15:28:33 | <dkayiwa> AdamLauz: ok |
| 15:29:20 | <djazayeri> andrea_: all I'm saying is, don't email me directly, because that loses any history of the conversation; pastebin is fine, but do it via irc or the ticket |
| 15:29:39 | <AdamLauz> dkayiwa: Can I do something?? |
| 15:29:47 | <dkayiwa> AdamLauz: ok |
| 15:29:57 | <yony258> dkayiwa: Pushed |
| 15:30:04 | <AdamLauz> dkayiwa: to help |
| 15:30:09 | <dkayiwa> yony258: ok |
| 15:30:13 | <andrea_> djazayeri, ok how about paste bin now for the long one? |
| 15:30:33 | <djazayeri> okay; i need to go offline for an hour or so, so ask fast! |
| 15:30:59 | <dkayiwa> yony258: are you sure you made the change in HibernateAppointmentDAO? |
| 15:31:00 | <andrea_> djazayeri, http://pastebin.com/G0GgsTqZ |
| 15:31:04 | <dkayiwa> yony258: i do not see it |
| 15:31:30 | <dkayiwa> yony258: oh wait |
| 15:31:45 | <dkayiwa> yony258: sorry seen it |
| 15:33:33 | <djazayeri> andrea_: the exportXml stuff in PatientSetService is deprecated, and has never been used. You don't need to modify this, and can you also please add @Deprecated to it? |
| 15:33:56 | <andrea_> djazayeri, sure will do |
| 15:34:22 | <AdamLauz> dkayiwa: http://pastebin.com/WqRyzdbC this is the error |
| 15:34:55 | <djazayeri> andrea_: for merging patients, yes, you should capture the prior deathDateEstimated also. You'll need to modify the MergeDataLog class too (or whatever that's called) |
| 15:35:03 | <dkayiwa> AdamLauz: yony258 gota run. will resume from here :) |
| 15:35:13 | <yony258> dkayiwa: Ok Thank you Daniel |
| 15:35:19 | <dkayiwa> yony258: thank you too |
| 15:35:40 | <AdamLauz> dkayiwa: ok thanks |
| 15:35:43 | <djazayeri> andrea_: yes, we might create a record for a dead patient, so yes, also add this in the ADTA28Handler. |
| 15:35:46 | <dkayiwa> AdamLauz: you too |
| 15:36:01 | <andrea_> djazayeri, what is MergeDataLog class ? |
| 15:36:06 | <djazayeri> andrea_: same for HL7ServiceImpl and the createPersonFromNK1 |
| 15:36:16 | *** dkayiwa has left #openmrs |
| 15:36:40 | <andrea_> djazayeri, ok will do that too |
| 15:37:03 | *** rafa has quit IRC |
| 15:37:11 | <andrea_> djazayeri, but what is MergeDataLog class ? |
| 15:37:31 | <djazayeri> andrea_: it's PersonMergeLogData. Basically that captures details of how you chose to merge two patients, in case you need to try to unmerge them later |
| 15:37:41 | <djazayeri> andrea_: if the javadoc on that class isn't clear on the point, please improve it. |
| 15:38:21 | <andrea_> djazayeri, I looked for javadoc and couldn't find any - where is it? |
| 15:38:49 | <djazayeri> andrea_: at the top of the class in the PersonMergeLogData.java file. |
| 15:39:23 | <djazayeri> andrea_: There is no need for setDeathdateFromAge. |
| 15:40:44 | <djazayeri> andrea_: gotta run for a while, back in an hour |
| 15:40:58 | *** jkeiper has quit IRC |
| 15:41:15 | <andrea_> djazayeri, will do all this stuff - talk to you later |
| 15:58:47 | *** AdamLauz has quit IRC |
| 16:18:48 | *** cpower has quit IRC |
| 16:27:42 | *** lh has quit IRC |
| 16:32:06 | <shangxiao> wyclif_: so I take it you didn't want to join all those if's together ;) |
| 16:34:09 | <wyclif_> shangxiao, i wanted to join just a couple |
| 16:34:23 | <wyclif_> shangxiao, do you nean for that concept search ticket |
| 16:34:51 | <shangxiao> yep |
| 16:35:31 | <wyclif_> shangxiao, there were a couple that were successive and all if(isNameField), so i wanted to group just those to have no redundant checks |
| 16:35:36 | <shangxiao> the problem with joining the if's together is that you'll have 2 places with the same string concatenation |
| 16:35:52 | <shangxiao> but they weren't exactly successive |
| 16:36:04 | <shangxiao> the conditions were mixed |
| 16:36:10 | <wyclif_> shangxiao, it meant just for a few as you saw what i did |
| 16:36:20 | <wyclif_> shangxiao, of course not all |
| 16:36:26 | <shangxiao> what did you do? |
| 16:36:37 | <wyclif_> shangxiao, did you see my commit? |
| 16:36:46 | <shangxiao> checking... |
| 16:37:05 | <wyclif_> shangxiao, i have a certain if(isNameField) containing other if clauses |
| 16:38:53 | <shangxiao> oh you just put it in the join |
| 16:39:00 | <shangxiao> yeah i was thinking of changing that |
| 16:39:10 | <shangxiao> oh wait no |
| 16:39:39 | <shangxiao> my first rewrite was that the condition of 'FULLY_SPECIFIED' was part of the join using the "with" clause |
| 16:40:10 | <shangxiao> but i couldn't get it working - but i found out later after my second attempt why it wasn't working |
| 16:40:59 | <shangxiao> anyhoo wyclif_ I find your way harder to read :P |
| 16:42:13 | <shangxiao> because while you've eliminated some if clauses - you've made it harder to see how the hql is constructed piece by piece |
| 16:45:12 | <shangxiao> although there is one possible if clause you could've gotten rid of and I would have totally agreed with you - just use "select Concept from Concept" all the time |
| 16:45:18 | <shangxiao> it really makes no difference ;) |
| 16:45:32 | <shangxiao> i just put that if clause in to be pedantic :) |
| 16:47:30 | *** shangxiao has quit IRC |
| 16:50:51 | *** andrea__ has joined #openmrs |
| 16:53:51 | *** andrea_ has quit IRC |
| 17:00:06 | *** harshadura_ has joined #openmrs |
| 17:02:07 | *** harshadura has quit IRC |
| 17:14:32 | *** yony258 has quit IRC |
| 17:29:28 | *** harshadura_ has quit IRC |
| 17:39:10 | *** wyclif_ has quit IRC |
| 17:41:22 | *** rafa has joined #openmrs |
| 17:41:22 | *** ChanServ sets mode: +v rafa |
| 17:48:12 | *** wyclif_ has joined #openmrs |
| 17:52:26 | *** djazayeri has quit IRC |
| 18:07:06 | *** rafa has quit IRC |
| 20:14:03 | *** djazayeri has joined #openmrs |
| 20:14:03 | *** ChanServ sets mode: +o djazayeri |
| 21:32:34 | *** sgithens has quit IRC |
| 21:37:03 | *** robbyoconnor has joined #openmrs |
| 21:37:03 | *** ChanServ sets mode: +v robbyoconnor |
| 21:43:14 | *** robbyoconnor has quit IRC |
| 21:45:53 | *** djazayeri1 has joined #openmrs |
| 21:47:13 | *** robbyoconnor has joined #openmrs |
| 21:47:17 | *** ChanServ sets mode: +v robbyoconnor |
| 21:48:22 | *** djazayeri has quit IRC |
| 21:48:33 | *** djazayeri1 is now known as djazayeri |
| 21:49:03 | *** wyclif_ has quit IRC |
| 21:52:34 | *** robbyoconnor has quit IRC |
| 22:37:20 | *** wyclif_ has joined #openmrs |
| 23:35:08 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Provider Management Module 1.1.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=providermanagement&version=&1.1.1> |
| 23:40:31 | <andrea__> djazayeri, u around? |
| 23:40:39 | <djazayeri> andrea__: yes |
| 23:45:15 | <andrea__> djazayeri, hi - putting changes in PersonMergeLogData caused a failed unit test in PatientServiceTest - commented out for now |
| 23:45:27 | <djazayeri> andrea__: what was the failure? |
| 23:46:44 | <andrea__> djazayeri, mergePatients_shouldAuditPriorDateOfBirthEstimated |
| 23:47:30 | <andrea__> djazayeri, also more questions - observations that don't seem appropriate to go on ticket |
| 23:52:27 | *** robbyoconnor has joined #openmrs |
| 23:52:27 | *** ChanServ sets mode: +v robbyoconnor |