IRC Chat : 2012-11-29 - OpenMRS

00:17:32 *** shangxiao has joined #openmrs
00:20:19 *** shangxiao has quit IRC
00:29:44 *** andreapat has quit IRC
00:31:01 *** rafa has quit IRC
00:31:56 *** wyclif_ has joined #openmrs
01:01:59 *** djazayeri1 has joined #openmrs
01:04:55 *** djazayeri has quit IRC
01:14:01 *** shangxiao has joined #openmrs
01:21:44 *** sgithens has joined #openmrs
01:47:50 *** shangxiao has quit IRC
01:59:51 *** shangxiao has joined #openmrs
02:02:38 *** rafa has joined #openmrs
02:02:38 *** ChanServ sets mode: +v rafa
02:19:23 *** rafa has quit IRC
02:37:08 *** andrea_ has quit IRC
02:59:54 *** Mkop has quit IRC
03:22:45 *** Mkop has joined #openmrs
03:22:45 *** ChanServ sets mode: +v Mkop
03:25:43 *** jkeiper has joined #openmrs
03:25:43 *** ChanServ sets mode: +v jkeiper
03:35:30 *** robbyoconnor has joined #openmrs
03:35:30 *** ChanServ sets mode: +v robbyoconnor
04:00:15 *** kishoreyekkanti has joined #openmrs
05:04:12 *** r0bby has joined #openmrs
05:04:12 *** ChanServ sets mode: +v r0bby
05:04:42 *** fishandwalk has joined #openmrs
05:05:34 *** harshadura_ has quit IRC
05:06:20 *** robbyoconnor has quit IRC
05:25:48 *** tobin_g has joined #openmrs
05:26:21 *** shangxiao has quit IRC
05:32:29 *** lh has quit IRC
05:33:12 *** kishoreyekkanti has quit IRC
05:33:52 *** kishoreyekkanti has joined #openmrs
05:55:00 *** jkeiper has quit IRC
06:01:28 *** tobin_g has quit IRC
06:01:37 *** shangxiao has joined #openmrs
06:19:50 *** shangxiao has quit IRC
06:22:22 *** shangxiao has joined #openmrs
06:27:29 *** r0bby_ has joined #openmrs
06:27:29 *** ChanServ sets mode: +v r0bby_
06:28:04 *** r0bby_ is now known as robbyoconnor
06:29:04 *** djazayeri1 has quit IRC
06:31:07 *** r0bby has quit IRC
06:50:08 *** AdamLauz has joined #openmrs
07:31:38 *** dkayiwa has joined #openmrs
07:37:25 *** shangxiao has quit IRC
07:38:26 *** djazayeri has joined #openmrs
07:38:26 *** ChanServ sets mode: +o djazayeri
07:38:57 *** shangxiao has joined #openmrs
07:51:46 *** josue8cc has joined #openmrs
07:52:01 *** josue8cc has left #openmrs
07:54:19 *** magoo has joined #openmrs
07:58:19 *** magoo has quit IRC
08:00:14 *** shangxiao has quit IRC
08:32:55 <AdamLauz> dkayiwa: Hi daniel how are you today?
08:33:05 <dkayiwa> AdamLauz: am doing fine. and you?
08:33:42 <AdamLauz> dkayiwa: great.
08:33:49 <dkayiwa> AdamLauz: ok :)
08:34:01 <AdamLauz> dkayiwa: I have a question regarding the unit tests
08:34:08 <dkayiwa> AdamLauz: ok
08:36:40 <AdamLauz> dkayiwa: each unit test (method) is working on the simulation db as it was at the first time? I mean the changes on the sim db that a unit test is doing do not affert other unit tests right?
08:37:11 <AdamLauz> dkayiwa: affect*
08:37:33 <dkayiwa> AdamLauz: as long as you do not change the data that the earlier unit tests are depending on, there should not be any effects
08:38:24 <AdamLauz> dkayiwa: So if I'm adding a new record in one unit test then it effects the other unit tests as well?
08:38:55 <dkayiwa> AdamLauz: no if it is a record for a different table
08:41:35 <AdamLauz> dkayiwa: ok I think there is something wrong with the saveNewRecord test and theUpdateNewRecord test
08:42:01 <dkayiwa> AdamLauz: ok
08:43:15 <AdamLauz> dkayiwa: because in the saveNewRecord you are trying to add a new record and see if the list's size increased. but in the updateRecord you check if the size remains the same(3) but it may be (4)
08:44:14 <dkayiwa> AdamLauz: each after each test method, database is cleared
08:44:46 <AdamLauz> dkayiwa: That what I thought :) thanks
08:45:00 <dkayiwa> AdamLauz: :D
08:45:33 <dkayiwa> AdamLauz: good and bright thinking :)
08:50:39 *** djazayeri has quit IRC
08:59:20 <AdamLauz> dkayiwa: I commited the code but didn't implemented the unit test for getting the AppointmentBlock by a string(name) because AppointmentBlock don't have the name attribute
08:59:46 <dkayiwa> AdamLauz: correct
09:02:08 *** dkayiwa has quit IRC
09:03:04 *** dkayiwa has joined #openmrs
09:03:12 *** tobin_g has joined #openmrs
09:07:48 *** dkayiwa_ has joined #openmrs
09:08:57 *** dkayiwa has quit IRC
09:08:58 *** dkayiwa_ is now known as dkayiwa
09:12:07 *** AdamLauz has quit IRC
09:16:59 <tobin_g> good morning dkayiwa
09:17:07 <dkayiwa> tobin_g: good morning
09:17:36 <tobin_g> dkayiwa: did you see that adam submitted the unit tests on AM-3?
09:17:52 <dkayiwa> tobin_g: yes. reviewing them:)
09:18:02 <tobin_g> dkayiwa: wonderful
09:37:17 *** tobin_g has quit IRC
09:53:54 *** yony258 has joined #openmrs
09:55:16 *** rafa has joined #openmrs
09:55:16 *** ChanServ sets mode: +v rafa
10:15:45 *** AdamLauz has joined #openmrs
10:18:03 *** tobin_g has joined #openmrs
10:27:07 *** yony258 has quit IRC
10:28:08 <AdamLauz> dkayiwa: Should I proceed to the UI?
10:28:16 <dkayiwa> AdamLauz: oh yes
10:28:41 <AdamLauz> dkayiwa: ok :)
10:34:03 <AdamLauz> dkayiwa: because the page will present a table of appointmentblocks, should I name it *.list?
10:34:24 <dkayiwa> AdamLauz: yes
11:12:33 <tobin_g> AdamLauz: are you in beersheva this weekend?
11:16:21 <AdamLauz> tobin_g: I'm planning to go home tomorrow morning... when are you planning to come over?
11:24:29 <AdamLauz> dkayiwa: There is an openMRS datepicker?
11:25:16 <dkayiwa> AdamLauz: yes
11:25:30 <AdamLauz> dkayiwa: super
11:27:21 *** Antony_ has joined #openmrs
11:27:47 <Antony_> dkayiwa: Hi
11:27:54 <dkayiwa> Antony_: hi
11:28:07 <Antony_> I need help
11:28:26 <Antony_> I am writing some test cases
11:28:53 <Antony_> so i created a patient using personId:501
11:29:34 <Antony_> when i query for the patient's name it returns blank
11:29:41 <dkayiwa> Antony_: can you type including my name
11:30:21 <Antony_> yet in the StandardTestDataset.xml the person has given_name="Bruno" middle_name="" family_name="Otterbourg"
11:30:35 <dkayiwa> member:Antony_: can you type including my name
11:30:54 <Antony_> dkayiwa: I am writing some test cases
11:31:08 <Antony_> dkayiwa: so i created a patient using personId:501
11:31:25 <Antony_> dkayiwa: when i query for the patient's name it returns blank
11:31:41 <Antony_> dkayiwa: yet in the StandardTestDataset.xml the person has given_name="Bruno" middle_name="" family_name="Otterbourg"
11:32:13 <Antony_> dkayiwa:
11:32:26 <Antony_> dkayiwa: My code looks like this:
11:32:32 <Antony_> dkayiwa: Patient patient = new Patient(); patient.setPersonId(501);
11:33:18 <dkayiwa> Antony_: can you pastebin your test class
11:35:23 *** shangxiao has joined #openmrs
11:41:45 <Antony_> dkayiwa: here is my code:
11:41:51 <Antony_> dkayiwa: Patient patient = new Patient(); patient.setPersonId(501); Assert.assertNotNull("The patient is null",patient); PatientIdentifierType pit = new PatientIdentifierType(2); Location location = new Location(1); PatientIdentifier pi = new PatientIdentifier("234", pit, location); patient.addIdentifier(pi); PatientService ps = Context.getPatientService(); Patient sav
11:42:04 <dkayiwa> Antony_: pastebin.com
11:46:10 <Antony_> dkayiwa: How is pastebin used? am there but i don't know whether i need to sign up
11:46:20 <Antony_> dkayiwa: first
11:46:23 <dkayiwa> Antony_: no sign up
11:46:31 <dkayiwa> Antony_: just paste and submit
11:46:58 <AdamLauz> dkayiwa: I need <openmrs:htmlIncludefile="/scripts/timepicker/timepicker.js"/> for the date picker?
11:47:55 <dkayiwa> AdamLauz: calender.js
11:49:15 <Antony_> dkayiwa: I have done so
11:49:29 <dkayiwa> Antony_: what is the url?
11:53:41 <Antony_> dkayiwa: http://pastebin.com/04BTU4q1
11:55:30 <Antony_> dkayiwa: Have you seen the url?
11:55:36 <dkayiwa> Antony_: yes
11:56:24 <dkayiwa> Antony_: if you want to refer to the person in the standard dataset. the you need to load using Context.getPersonService.getPerson(501)
11:57:20 *** tobin_g has quit IRC
11:58:08 <Antony_> Okay
11:58:19 <Antony_> dkayiwa: Okay, let me try that
11:58:26 <dkayiwa> Antony_: ok
12:15:49 *** robbyoconnor has quit IRC
12:17:03 *** yony258 has joined #openmrs
12:22:19 *** Antony__ has joined #openmrs
12:35:23 *** rafa has quit IRC
12:37:33 *** rafa has joined #openmrs
12:37:33 *** ChanServ sets mode: +v rafa
12:42:59 *** tobin_g has joined #openmrs
12:57:41 *** tobin_g has quit IRC
13:03:13 *** kjoseph has joined #openmrs
13:03:27 *** kaweesi_joseph has joined #openmrs
13:03:33 *** kjoseph has quit IRC
13:06:35 *** kjoseph has joined #openmrs
13:07:02 *** kjoseph has left #openmrs
13:20:58 *** jkeiper has joined #openmrs
13:20:58 *** ChanServ sets mode: +v jkeiper
13:24:25 *** wyclif_ has quit IRC
13:28:16 *** wyclif_ has joined #openmrs
13:32:52 *** wyclif_ has quit IRC
13:41:23 *** kjoseph has joined #openmrs
13:41:42 *** dkayiwa_ has joined #openmrs
13:42:11 *** dkayiwa has quit IRC
13:42:12 *** dkayiwa_ is now known as dkayiwa
13:52:52 *** nribeka has joined #openmrs
13:52:52 *** ChanServ sets mode: +v nribeka
13:53:29 <dkayiwa> kjoseph: what are you working on now?
14:05:36 *** kjoseph has quit IRC
14:06:00 *** kjoseph has joined #openmrs
14:11:42 *** yony258 has quit IRC
14:13:55 *** sgithens has quit IRC
14:17:04 *** fishandwalk has quit IRC
14:18:56 *** kjoseph has quit IRC
14:19:59 *** nribeka has quit IRC
14:23:22 *** Antony_ has quit IRC
14:24:25 *** lh has joined #openmrs
14:25:57 *** jkeiper has quit IRC
14:26:48 *** lh has quit IRC
14:27:09 *** wyclif_ has joined #openmrs
14:27:47 *** lh has joined #openmrs
14:28:55 *** nribeka has joined #openmrs
14:28:55 *** ChanServ sets mode: +v nribeka
14:35:45 *** nribeka has quit IRC
14:37:51 *** jkeiper has joined #openmrs
14:37:51 *** ChanServ sets mode: +v jkeiper
14:41:01 *** kishoreyekkanti has quit IRC
14:41:31 *** afiles has joined #openmrs
14:43:49 *** kishoreyekkanti has joined #openmrs
14:44:25 *** sgithens has joined #openmrs
14:48:01 *** kjoseph has joined #openmrs
14:50:45 *** sgithens has quit IRC
14:59:46 *** kaweesi_joseph has joined #openmrs
15:00:52 *** AdamLauz has quit IRC
15:03:48 *** kjoseph has quit IRC
15:05:25 *** wyclif_ has quit IRC
15:07:27 *** djazayeri has joined #openmrs
15:07:27 *** ChanServ sets mode: +o djazayeri
15:18:18 *** wyclif_ has joined #openmrs
15:18:32 *** suranga_ has joined #openmrs
15:19:31 *** nribeka has joined #openmrs
15:19:31 *** ChanServ sets mode: +v nribeka
15:23:53 *** jblaya has joined #openmrs
15:25:05 *** nribeka has quit IRC
15:30:28 *** kishoreyekkanti has quit IRC
15:32:58 *** shangxiao has quit IRC
15:37:37 <kaweesi_joseph> .
15:42:25 *** jblaya has quit IRC
15:47:36 *** kaweesi_joseph has quit IRC
16:00:23 *** sgithens has joined #openmrs
16:03:16 *** shangxiao has joined #openmrs
16:19:49 *** sgithens has quit IRC
16:19:55 *** wyclif_ has quit IRC
16:33:54 *** wyclif_ has joined #openmrs
16:39:16 *** jkeiper has quit IRC
17:10:37 *** shangxiao has quit IRC
17:11:03 *** shangxiao has joined #openmrs
17:14:12 *** Antony__ has quit IRC
17:52:35 *** kishoreyekkanti has joined #openmrs
17:56:28 *** jkeiper has joined #openmrs
17:56:28 *** ChanServ sets mode: +v jkeiper
17:57:17 *** shangxiao has quit IRC
18:03:55 *** downey has joined #openmrs
18:03:55 *** ChanServ sets mode: +o downey
18:16:24 *** lh has quit IRC
18:23:57 *** ningosi has joined #openmrs
18:26:20 *** ningosi has quit IRC
18:29:53 *** ningosi has joined #openmrs
18:31:59 *** ningosi is now known as ojwanganto
18:32:25 *** lh has joined #openmrs
18:42:14 <rafa> downey: Hey, when will we have a new Bamboo? :D
18:42:52 <rafa> downey: 4.0 sucks a bit ;)
18:43:53 <downey> rafa: we have a clean one at http://ci-stg.openmrs.org running 4.3.1 … breeze from thoughtworks is kicking off the analysis of what kind of rework we need to do and we'll build up our first pass at CD over there
18:45:16 <rafa> downey: awsome!
18:45:33 <rafa> downey: I don't see any builds yet
18:45:44 <downey> rafa: yeah, clean slate to start
18:46:25 <rafa> downey: really looking forward to that!
18:46:59 <downey> rafa: breeze is working full time on the stuff - will try to encourage him to hang out in irc with us
18:47:33 <rafa> downey: would be great
18:47:47 <rafa> downey: I'm really interested in this happening asap
18:47:55 <rafa> downey: so will be providing instant feedback :)
18:48:39 <downey> rafa: he's been reading up and learning last few days, and in the last few minutes just sent some clarifying questions to the guys who were here several weeks back, so i think we'll be hearing more from him quite soon
18:49:21 <rafa> downey: very well :]
18:54:20 *** suranga_ has quit IRC
18:57:36 *** kishoreyekkanti has quit IRC
19:11:23 *** ojwanganto has quit IRC
19:19:07 *** andrea has joined #openmrs
19:19:25 *** andrea is now known as Guest3987
19:20:43 *** Guest3987 is now known as andrea_
19:28:16 <djazayeri> downey: yeah, please loop devs (at least the full-time ones) into CD conversations from the beginning. :-)
19:29:39 <djazayeri> downey: btw, JIRA seems quite slow at the moment
19:31:35 *** sgithens has joined #openmrs
19:54:45 *** afiles has quit IRC
20:00:51 *** downey has quit IRC
20:01:19 *** downey has joined #openmrs
20:01:19 *** ChanServ sets mode: +o downey
20:01:25 *** downey has quit IRC
20:02:11 *** sgithens has quit IRC
20:02:35 <andrea_> hi
20:03:51 <andrea_> anyone here?
20:05:22 <wyclif_> andrea_, am here
20:05:59 <djazayeri> scrum time?
20:06:05 <djazayeri> !scrumon djazayeri
20:06:05 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready.
20:06:12 <andrea_> wyclif_ , hi
20:06:26 <djazayeri> today's order: andrea_, dkayiwa, wyclif_, rafa, djazayeri
20:06:30 <andrea_> hi djazayeri
20:06:31 <djazayeri> and anyone I missed
20:06:44 *** jkeiper has quit IRC
20:06:46 *** adam_l has joined #openmrs
20:07:13 <andrea_> Wednesday
20:07:14 <andrea_> Univ call
20:07:14 <andrea_> Design call
20:07:14 <andrea_> Atlas Module
20:07:14 <andrea_> More pair programming with Wyclif on Atlas Module?
20:07:14 <andrea_> Start work on TRUNK-2768
20:07:16 <andrea_> Thursday
20:07:18 <andrea_> Dev call
20:07:20 <andrea_> Work on TRUNK-2768
20:07:22 <andrea_> Blocker
20:07:24 <andrea_> Questions re TRUNK-2768
20:07:40 <djazayeri> !ticket TRUnk-2768
20:07:41 <OpenMRSBot> djazayeri: [#TRUNK-2768] Add column deathdate_estimated to person table - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUnk-2768
20:07:52 <dkayiwa> Had design discussions with Tobin's team
20:07:52 <dkayiwa> Reviewed code for Tobin's team
20:07:52 <dkayiwa> Committed: @StartModule does not work - TRUNK-3508
20:07:52 <dkayiwa> Dev Call
20:07:53 <dkayiwa> Now working on: Search for patient by identifier fails when identifier is made of only letters - TRUNK-3822
20:07:53 <dkayiwa> No Blockers
20:08:57 <djazayeri> dkayiwa: I'm curious what your approach is for TRUNK-3822
20:09:02 <djazayeri> (save for discussion time)
20:09:19 <djazayeri> rafa: you there?
20:09:25 <wyclif_> Wednesday:
20:09:25 <wyclif_> design call
20:09:26 <wyclif_> call/paired with darius and andrea about issue in atlas module
20:09:26 <wyclif_> Reviewed tickets:
20:09:26 <wyclif_> Reviewed, addressed comments and applied - TRUNK-3734 - Add User Property convenience methods
20:09:26 <wyclif_> Applied TRUNK-3474 - Remove not null constraints
20:09:28 <wyclif_>
20:09:29 <rafa> djazayeri: yes
20:09:30 <wyclif_> Thursday:
20:09:32 <wyclif_> Created and worked on ATLAS-47 - Fix atlas bubble data form to fit on the map canvas
20:09:34 <wyclif_> dev call
20:09:36 <wyclif_> Clean up and apply pull request for TRUNK-3812 - QueryException received while searching for concepts through ConceptService
20:09:41 <wyclif_> Beat up TRUNK-3231 - Encounter autocomplete should filter results by patient
20:09:43 <wyclif_>
20:09:45 <wyclif_> Blockers: None
20:09:53 <rafa> Today:
20:09:53 <rafa> * Worked on deploying hibernate-search
20:09:53 <rafa> * Reviewed some pull requests
20:09:53 <rafa> No blockers.
20:10:14 <djazayeri> Yesterday and Today:
20:10:17 <djazayeri> * Lots of calls
20:10:30 <djazayeri> * spike on a jquery-based question-per-screen form engine
20:10:51 <djazayeri> * look at TRUNK-3824 for Mark
20:10:54 <djazayeri> no blockers
20:11:12 <djazayeri> anybody else have updates?
20:13:34 <andrea_> djazayeri,As mentioned in dev call this ticket is not well written - seems incomplete
20:14:13 <andrea_> djazayeri, I'm referring to TRUNK-2768
20:14:23 *** yony258 has joined #openmrs
20:14:29 <djazayeri> !scrumoff
20:14:29 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
20:14:29 <yony258> dkayiwa: Hi :)
20:14:35 <dkayiwa> yony258: hi
20:14:36 <djazayeri> so, discussion points:
20:14:42 <djazayeri> 1. andrea_'s blocker
20:14:56 *** tobin_g has joined #openmrs
20:15:01 <djazayeri> 2. how will dkayiwa approach TRUNK-3822
20:15:23 <djazayeri> !ticket TRUNK-2768
20:15:25 <OpenMRSBot> djazayeri: [#TRUNK-2768] Add column deathdate_estimated to person table - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2768
20:15:26 <djazayeri> (for andrea)
20:15:29 <andrea_> Questions re TRUNK-2768
20:15:29 <andrea_> As mentioned in dev call this ticket is not well written - seems incomplet
20:15:29 <andrea_> column in person table - death_date _estimated int
20:15:29 <andrea_> what are values - are we using like a boolean (0=false, 1=true)?
20:15:29 <andrea_> In Person.java boolean deathDateEstimated -
20:15:30 <andrea_> set by checking person table death_date _estimated ?
20:15:32 <andrea_> also needs getters/setters
20:15:39 <yony258> dkayiwa: Why there isn't a method that checks if an Appointment was voided?
20:16:31 <dkayiwa> yony258: because voided is a property on the appointment object
20:16:34 <djazayeri> andrea_: it should behave exactly like person.birthdate_estimated
20:16:53 <dkayiwa> yony258: so when you have the appointment object, you can tell whether it is voided or not
20:16:54 <djazayeri> andrea_: same column type in the db, same datatype on the object, same treatment in the hibernate mapping.
20:17:13 <yony258> dkayiwa: I mean there isnt a function like appointment.isVoided()
20:17:30 <djazayeri> yony258: you sure this isn't in BaseOpenmrsData that it extends?
20:17:30 <dkayiwa> yony258: it is in the base class
20:17:47 <yony258> dkayiwa: Compiler cant find that function
20:17:57 <dkayiwa> yony258: what base class did you give it?
20:18:09 <yony258> dkayiwa: extends BaseOpenmrsObject implements Serializable
20:18:25 <dkayiwa> yony258: change it to BaseOpenmrsData
20:18:36 <andrea_> djazayeri, mysql has no boolean datatype - so 0=false, 1=true?
20:18:49 <djazayeri> andrea_: I'm saying: do exactly what is done for birthdate_estimated
20:19:11 <djazayeri> andrea_: I think that's smallint where 0=false 1=true, but I don't remember offhand.
20:19:17 <andrea_> djazayeri, aah got it - thanks
20:19:26 *** jkeiper has joined #openmrs
20:19:26 *** ChanServ sets mode: +v jkeiper
20:19:36 <djazayeri> !ticket TRUNK-3822
20:19:37 <OpenMRSBot> djazayeri: [#TRUNK-3822] Search for patient by identifier fails when identifier is made of only letters - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3822
20:19:42 <yony258> dkayiwa: Ok. Can you explain what is the difference? or it will be even better if you could direct me where to read about it.
20:20:10 <dkayiwa> yony258: can you look at the class BaseOpenmrsData in openmrs-core?
20:20:15 <dkayiwa> yony258: it has some javadoc
20:20:19 <yony258> dkayiwa: Ok
20:20:49 <djazayeri> dkayiwa: about that identifier searching ticket, what approach do you have in mind?
20:21:03 <djazayeri> dkayiwa: I was thinking that this is going to require us to change some DAO methods
20:21:17 <dkayiwa> djazayeri: was just starting on it. so no concrete plan yet
20:21:33 <djazayeri> dkayiwa: because currently in the DAO you need to indicate whether you are searching by name _or_ by identifier
20:21:42 <dkayiwa> djazayeri: ok
20:21:58 <djazayeri> dkayiwa: and I think we need a DAO method that will search across both
20:22:06 <dkayiwa> djazayeri: ok
20:22:22 <djazayeri> dkayiwa: so, I *think* we need to add another DAO method for this. (I haven't thought any further though.)
20:22:32 <dkayiwa> djazayeri: ok
20:22:34 <djazayeri> dkayiwa: do cc me on the pull request when you get to it!
20:22:44 <dkayiwa> djazayeri: ok
20:26:40 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 2.3.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=uiframework&ampversion=&amp2.3.1>
20:38:21 <yony258> dkayiwa: I have no idea why but its failing all tests. I mean like AppointmentBlockServiceTest, AppointmentTypeServiceTest, AppointmentServiceTest.
20:38:56 <yony258> dkayiwa: Tests run: 28, Failures: 0, Errors: 28, Skipped: 0
20:39:20 <dkayiwa> yony258: let me pull and look at them
20:39:35 <yony258> dkayiwa: Ok i'll push
20:39:45 <yony258> dkayiwa: Let me just pust all my changes
20:39:51 <dkayiwa> yony258: ok tell me after you have pushed
20:43:01 <yony258> dkayiwa: http://tinyurl.com/bnxlqrh
20:44:01 <dkayiwa> yony258: have you pushed?
20:44:16 <yony258> dkayiwa: Yes
20:44:27 <dkayiwa> yony258: ok let me pull
21:04:03 <dkayiwa> yony258: can you start by renaming the tables in all the hibernate mapping files to match with the new names as per the current data model diagram?
21:04:31 <dkayiwa> yony258: after that, push and tell me to test again
21:05:12 *** lufu has joined #openmrs
21:05:46 <yony258> dkayiwa: You mean in the mapping files?
21:06:41 <dkayiwa> yony258: can you start by renaming the tables in all the hibernate mapping files to match with the new names as per the current data model diagram?
21:06:58 <yony258> dkayiwa: Done. pull
21:07:06 <dkayiwa> yony258: ok
21:08:56 <dkayiwa> yony258: can you do the same in standardAppointmentTestDataset.xml
21:09:11 <dkayiwa> yony258: then push
21:10:49 <yony258> dkayiwa: Done. Pull
21:11:03 <dkayiwa> yony258: ok
21:13:47 <dkayiwa> yony258: can you also rename provider column on appointment_block in standardAppointmentTestDataset.xml
21:19:14 <yony258> dkayiwa: Done. Pull
21:19:25 <dkayiwa> yony258: ok
21:22:35 *** tobin_g has quit IRC
21:26:44 *** jkeiper has quit IRC
21:34:57 *** sgithens has joined #openmrs
21:36:26 <dkayiwa> yony258: can you run the unit tests in AppointmentServiceTest
21:39:41 *** jkeiper has joined #openmrs
21:39:41 *** ChanServ sets mode: +v jkeiper
21:41:44 *** lufu has quit IRC
21:43:55 <yony258> dkayiwa: 28 Errors
21:44:19 <dkayiwa> yony258: can you run that class from eclipse
21:44:36 <dkayiwa> yony258: right click - run as junit
21:45:14 <yony258> dkayiwa: Yes.
21:45:37 <dkayiwa> yony258: now can you look at the error message and fix
21:45:49 <yony258> dkayiwa: Non-uppercase input column: voided_reason
21:46:23 <dkayiwa> yony258: confirm that the column matches data model
21:47:07 <yony258> dkayiwa: Why appointmentTypeServiceTest produces errors too?
21:47:26 <dkayiwa> yony258: deal with one class at a time
21:47:49 <yony258> dkayiwa: Was the voided_reason supposed to by in uppercase?
21:48:25 <dkayiwa> yony258: just match name with that in data model
21:49:00 <yony258> dkayiwa: Im not sure what is the problem
21:49:23 <dkayiwa> yony258: what names does data model have
21:49:49 <yony258> dkayiwa: void_reason
21:50:04 <dkayiwa> yony258: which table is that
21:50:11 <yony258> dkayiwa: appointment_block
21:50:58 <dkayiwa> yony258: is that the same name as in dataset.xml
21:52:59 *** rafa has quit IRC
21:53:32 <yony258> dkayiwa: Ok fixed it, apparently the appointment_block tags contained voided_reason. Now im having NullPointerException.
21:53:50 <dkayiwa> yony258: push
21:54:55 <yony258> pull
21:55:00 *** sgithens has quit IRC
21:55:11 <dkayiwa> yony258: ok
21:59:48 *** jkeiper has quit IRC
22:02:16 <dkayiwa> yony258: can you try to fix that exception
22:02:35 <yony258> dkayiwa: Yes working on that
22:02:45 <dkayiwa> yony258: ok
22:05:33 <yony258> dkayiwa: I think its related to executeDataSet.
22:15:30 <dkayiwa> yony258: so did you fix it?
22:16:02 <yony258> dkayiwa: Still dont know whats the problem but working on that
22:17:37 <yony258> dkayiwa: Do you know what is the problem?
22:17:58 <dkayiwa> yony258: wanted to first give you a chance to fix it
22:18:19 <yony258> dkayiwa: Can you maybe guide me or give me a clue, I want to fix it myself
22:18:46 <yony258> dkayiwa: Is the problem in the Dataset.xml ?
22:18:52 <dkayiwa> yony258: yes
22:22:58 <dkayiwa> yony258: is Adam around?
22:23:11 <dkayiwa> yony258: he should be the one to fix these since they all come from his commit :)
22:23:14 <yony258> dkayiwa: No he's off to sleep, been a long day
22:23:36 <yony258> dkayiwa: Im fixing one problem: appointment_block_type_map_id
22:23:55 *** dkayiwa has quit IRC
22:27:26 *** yony258 has quit IRC
22:27:42 *** yony258 has joined #openmrs
22:29:18 *** dkayiwa has joined #openmrs
22:29:43 <dkayiwa> yony258: at org.dbunit.dataset.datatype.IntegerDataType.setSqlValue(IntegerDataType.java:106) shows there is a numeric field with a problem
22:29:52 <yony258> dkayiwa: So should I add appointment_block_type_map_id
22:30:03 <yony258> dkayiwa: Sorry its not related but anyway should I?
22:30:13 <dkayiwa> yony258: so look for where changed_by=""
22:30:18 <dkayiwa> yony258: changed_by=" "
22:30:30 <yony258> dkayiwa: Yes I removed it
22:30:43 <dkayiwa> yony258: now run the test again
22:31:23 <yony258> dkayiwa: Another problem but different.
22:31:29 <yony258> dkayiwa: I got a question
22:31:31 <dkayiwa> yony258: can you fix it?
22:32:29 <yony258> dkayiwa: Sorry I got a question first. Do I need to add appointment_block_type_map_id? (to Dataset.xml)
22:32:56 <dkayiwa> yony258: if the data model does not have it, then we do not need it
22:33:36 <yony258> dkayiwa: The data model has it.
22:33:55 <yony258> dkayiwa: Its the first field on appointment_block_type_map table
22:34:13 *** wyclif_ has quit IRC
22:34:44 <dkayiwa> yony258: so can you fix the error?
22:35:09 <yony258> dkayiwa: I fixed 2 more problems now working on the third one.
22:35:23 <yony258> dkayiwa: But I still didnt got an answer to my question :)
22:35:24 <dkayiwa> yony258: ok good :)
22:35:39 <dkayiwa> yony258: which one
22:36:49 <yony258> dkayiwa: Let me explain what im asking.
22:38:12 <yony258> dkayiwa: In the block-type-map there is an Auto Increment field called <table name>_id. This field is not given a value in the Dataset.xml file for the <appointment_block_type_map .../> tags. Ok so far?
22:38:42 <dkayiwa> yony258: is it a primary key?
22:38:47 <yony258> dkayiwa: Yes
22:39:04 <dkayiwa> yony258: then there is now way you can have a valid row without a value for it
22:39:28 <yony258> dkayiwa: Ok great I need to fix that too :)
22:41:12 <yony258> dkayiwa: Ok I added it and it caused an error.
22:41:32 <yony258> dkayiwa: This field is not mentioned in the hibernate mapping files of AppointmentBlock
22:41:44 <dkayiwa> yony258: so remove it
22:41:58 <yony258> dkayiwa: I am really confused.
22:42:15 <dkayiwa> yony258: do you have it in the data model?
22:42:25 <yony258> dkayiwa: Yes of course....
22:42:39 <dkayiwa> yony258: which field and in which table?
22:42:58 <yony258> dkayiwa: Table: appointment_block_type_map Field: appointment_block_type_map_id
22:43:59 <dkayiwa> yony258: we do not need it. you can get rid of it
22:44:17 <dkayiwa> yony258: both from the data model diagram and dataset.xml file
22:44:22 <yony258> dkayiwa: Remove it from the data model?
22:44:28 <dkayiwa> yony258: yes
22:44:33 <yony258> dkayiwa: And what will be the primary key for that table?
22:45:02 <dkayiwa> yony258: the two remaining fields
22:45:15 <yony258> dkayiwa: You mean both of them will be a primary key
22:45:33 <dkayiwa> yony258: combination of both will form the primary key
22:46:54 <yony258> dkayiwa: -_-
22:47:58 <yony258> dkayiwa: Ok. let me push all changes. I now have a problem which I need help with.
22:48:11 <dkayiwa> yony258: ok push
22:50:46 <yony258> dkayiwa: pushed, please pull :)
22:50:59 <dkayiwa> yony258: ok
22:54:21 <dkayiwa> yony258: open the moduleApplicationContext.xml file
22:55:08 <yony258> dkayiwa: Ok
22:55:09 <yony258> dkayiwa: I think the appointmentDAO wasnt initialized ?
22:55:16 <dkayiwa> yony258: then add a property for others DAOs
22:55:18 <dkayiwa> yony258: yes
22:55:37 <dkayiwa> yony258: add for the DAOs in the service class
22:55:53 <dkayiwa> yony258: just copy all as for <property name="appointmentTypeDAO">
22:56:34 <dkayiwa> yony258: after that, run the test again
23:01:54 <dkayiwa> yony258: any luck? :)
23:07:31 <yony258> dkayiwa: ;) You know the answer :). Thank you Daniel that was awesome. Just going through and fixing the simple bugs. Will comeback with the more complex ones, If thats ok with you?
23:07:51 <dkayiwa> yony258: sure!!!
23:08:09 <dkayiwa> yony258: thanks for the hard work!!! :D
23:12:07 *** adam_l has quit IRC
23:13:13 <dkayiwa> yony258: is that Adam?
23:14:04 <yony258> dkayiwa: Hmm maybe but he was afk, Me and him are in the same apartment and he went to sleep earlier.
23:14:19 <dkayiwa> yony258: ok
23:17:36 *** dkayiwa_ has joined #openmrs
23:18:40 <yony258> dkayiwa_: Ok pushing changes now
23:18:50 <dkayiwa_> yony258: ok
23:19:01 <yony258> dkayiwa_: I need some guidance with the remaining issues :/
23:19:50 <yony258> dkayiwa_: Ok pushed
23:20:00 *** dkayiwa has quit IRC
23:20:00 *** dkayiwa_ is now known as dkayiwa
23:22:48 <dkayiwa> yony258: ok
23:26:04 <dkayiwa> yony258: looks like its time for bed here :)
23:26:14 <yony258> dkayiwa: Sure same here
23:26:36 <dkayiwa> yony258: ok see ya tomorrow as we resume from here
23:26:44 <yony258> dkayiwa: Well I'll be here tomorrow till the afternoon
23:26:54 <dkayiwa> yony258: ok great!!!!
23:26:59 <yony258> dkayiwa: Great, have a good night, Thank you
23:27:07 <dkayiwa> yony258: you too
23:27:23 *** yony258 has quit IRC
23:27:30 *** dkayiwa has quit IRC
23:37:52 *** gschiltz has joined #openmrs
23:40:01 *** gschiltz has left #openmrs
23:40:43 *** gschiltz has joined #openmrs