IRC Chat : 2012-11-28 - OpenMRS

00:09:26 *** robbyoconnor has joined #openmrs
00:09:26 *** ChanServ sets mode: +v robbyoconnor
00:15:55 *** robbyoconnor has quit IRC
01:47:41 *** harshadura has joined #openmrs
02:52:35 *** shangxiao has joined #openmrs
03:50:32 *** sgithens has joined #openmrs
03:59:50 *** sgithens has quit IRC
04:26:57 *** shangxiao has quit IRC
04:43:01 *** shangxiao has joined #openmrs
04:58:46 *** shangxiao has quit IRC
05:03:22 *** fishandwalk has joined #openmrs
05:04:12 *** kishoreyekkanti has joined #openmrs
05:41:40 *** harshadura_ has joined #openmrs
05:44:35 *** harshadura has quit IRC
05:58:39 *** harshadura__ has joined #openmrs
06:01:35 *** harshadura_ has quit IRC
06:05:24 *** shangxiao has joined #openmrs
06:22:12 *** robbyoconnor has joined #openmrs
06:22:12 *** ChanServ sets mode: +v robbyoconnor
06:46:24 *** AdamLauz has joined #openmrs
06:51:32 *** yony258 has joined #openmrs
07:30:08 *** dkayiwa has joined #openmrs
07:30:15 <dkayiwa> hi yony258
07:30:32 <yony258> dkayiwa: Hi, good morning
07:30:43 <dkayiwa> yony258: morning
07:31:04 <yony258> dkayiwa: We can just continue and finish the questions today on Skype, not many left
07:31:21 <dkayiwa> yony258: ok you can call me
07:31:28 <yony258> dkayiwa: sure
07:46:25 *** kishoreyekkanti_ has joined #openmrs
07:47:52 <dkayiwa> yony258: do you hear me
07:50:27 *** kishoreyekkanti has quit IRC
07:50:27 *** kishoreyekkanti_ is now known as kishoreyekkanti
07:58:14 *** djazayeri has quit IRC
08:11:12 *** Antony has joined #openmrs
08:12:45 *** Antony has quit IRC
08:15:04 *** Antony has joined #openmrs
08:15:37 <Antony> dkayiwa:
08:15:53 <Antony> Hi
08:17:10 <dkayiwa> Antony: in a meeting. let me get back to you shortly :)
08:17:17 <Antony> Thanks
08:21:47 <Antony> OpenMRSBot:
08:21:54 <Antony> Hi
08:30:44 *** kavuri has joined #openmrs
08:31:01 <kavuri> wyclif_: you there?
08:35:27 *** Antony has quit IRC
08:38:10 *** harshadura__ has quit IRC
08:41:07 *** kishoreyekkanti has quit IRC
08:41:28 *** kishoreyekkanti has joined #openmrs
08:42:59 *** Antony has joined #openmrs
08:44:07 <kavuri> dkayiwa: any help in creating visits with attribute types?
08:45:06 <dkayiwa> kavuri: just a moment. in a brief meeting
08:45:13 <kavuri> dkayiwa: ok
08:50:42 <Antony> kavuri:
08:50:44 <Antony> Hi
08:50:53 <kavuri> Antony: hi
08:51:27 <Antony> I have difficulty saving a patient
08:51:50 <Antony> after assigning PatientIdentifierType and PatientIdentifier
08:51:58 <Antony> could you please help?
08:52:23 <kavuri> Antony: what is the problem you are facing? error?
08:53:31 <Antony> I get an error like i need to assign at least one nonvoided patientIdentifiers
08:53:38 <Antony> am using this code
08:53:40 <Antony> :
08:53:58 <Antony> Patient patient = new Patient(); patient.setPersonId(501); PatientIdentifierType pit = new PatientIdentifierType(2); PatientIdentifier pi = new PatientIdentifier("2345456", pit, null); pi.setPatient(patient); PatientService ps = Context.getPatientService(); Patient savedPatient =ps.savePatient(patient);
08:54:18 <Antony> sorry i could not format the code before posting
08:56:09 <kavuri> Antony: looks like the patient identifier with id 2 is voided
08:56:16 <kavuri> Antony: you can check this in the openmrs admin console
08:58:45 <Antony> I first tried with id 1
08:59:06 <Antony> but it returned the same error
08:59:23 <kavuri> Antony: do you see that the patient identifier is not void in admin console?
08:59:47 <Antony> how do you check that?
09:00:06 <kavuri> https://<url of your openmrs server>:<port>/openmrs
09:00:25 <kavuri> Antony: I would suggest you to read a bit more about openmrs
09:00:32 <kavuri> wiki.openmrs.org
09:00:38 <kavuri> Antony: openmrs.org
09:01:18 <Antony> okay
09:04:49 *** kishoreyekkanti_ has joined #openmrs
09:07:19 *** kishoreyekkanti has quit IRC
09:07:20 *** kishoreyekkanti_ is now known as kishoreyekkanti
09:11:42 *** Antony has quit IRC
09:20:57 <kavuri> dkayiwa: free?
09:21:03 <dkayiwa> kavuri: yes :)
09:21:27 <kavuri> dkayiwa: :) creating of visits with visit attributes fails
09:21:35 <kavuri> dkayiwa: using webservices rest api
09:21:45 <kavuri> dkayiwa: and I have a unit testcase for it :)
09:22:47 <dkayiwa> kavuri: ok send me the unit test that fails and i see how to make it pass :)
09:22:57 <kavuri> dkayiwa: shall I send the svn diff?
09:23:35 <kavuri> dkayiwa: as in shall I send a patch? Or the complete file?
09:24:00 <dkayiwa> kavuri: send complete file at pastebin
09:24:04 <kavuri> dkayiwa: ok
09:25:28 <kavuri> dkayiwa: http://pastebin.com/b4uw57GZ
09:25:45 <kavuri> dkayiwa: the failing testcase is shouldCreateAVisitWithAttributes()
09:26:13 <dkayiwa> kavuri: ok let me look at it now
09:26:20 <kavuri> dkayiwa: thank you
09:33:16 *** rafa has joined #openmrs
09:33:16 *** ChanServ sets mode: +v rafa
09:49:37 *** AdamLauz has quit IRC
09:50:01 <dkayiwa> kavuri: which version of openmrs are you referencing in your web services module?
09:50:09 <kavuri> dkayiwa: 1.9.2
09:50:15 <dkayiwa> o
09:50:16 <dkayiwa> ok
09:51:47 <dkayiwa> kavuri: are the 1.9.2 artifacts in nexus?
09:52:05 <kavuri> dkayiwa: not sure what artifacts and nexus are
09:52:08 *** Antony has joined #openmrs
09:52:16 <kavuri> dkayiwa: what are you refering to?
09:52:17 <dkayiwa> kavuri: the openmrs 1.9.2 jars
09:52:44 <kavuri> dkayiwa: I have openmrs server running and using a curl client I tried to create a visit with attributes
09:52:56 <kavuri> dkayiwa: that failed. And so I created a testcase to replicate the problem
09:53:13 <kavuri> dkayiwa: the problem seems to be at like 82 in ConversionUtils.java
09:53:16 <dkayiwa> kavuri: i see some new classes like Rest19ExtTestConstants. are these your classes?
09:53:40 <kavuri> dkayiwa: no, it is part of webservices.rest19ext package
09:53:42 *** Antony has quit IRC
09:53:56 <dkayiwa> kavuri: and the VisitController controller?
09:54:02 <kavuri> dkayiwa: Visit is part of the ext19 module and not the webservices.rest module
09:54:19 <dkayiwa> kavuri: ok let me update my version of the web services module
09:54:25 <kavuri> dkayiwa: you will have to have the webservices.rest19ext source code
09:54:48 <dkayiwa> kavuri: ok let me check it out
09:54:54 <kavuri> dkayiwa: you can get the source code from http://svn.openmrs.org/openmrs-modules/webservices.rest19ext
09:55:04 <dkayiwa> kavuri: ok thanks
10:04:30 <dkayiwa> kavuri: ok i have it checked out. so should i put this unit test in the checkout of this module?
10:05:19 <kavuri> dkayiwa: yes, replace the file webservices.rest19ext/omod/src/test/java/org/openmrs/module/webservices/rest19ext/web/v1_0/controller/VisitControllerTest.java with the file from pastebin
10:05:28 <dkayiwa> kavuri: ok
10:07:27 <dkayiwa> kavuri: so the failing test is? shouldCreateAVisitWithAttributes
10:07:35 <kavuri> dkayiwa: yes
10:07:47 <dkayiwa> kavuri: are you the one who has created that test?
10:08:01 <kavuri> dkayiwa: yes
10:08:37 <dkayiwa> kavuri: do you send the post data as expected?
10:09:01 <kavuri> dkayiwa: I think so, but I am not sure
10:09:33 <dkayiwa> kavuri: can you pastebin with the post data only?
10:09:45 *** shangxiao has joined #openmrs
10:10:07 <kavuri> dkayiwa: http://pastebin.com/EP2u0udQ
10:10:13 <dkayiwa> kavuri: ok
10:11:02 <dkayiwa> kavuri: can you try an attribute type that is not a date?
10:11:14 <dkayiwa> kavuri: a text for instance
10:11:16 <kavuri> dkayiwa: tried with an attribute type of TEXT
10:11:21 <kavuri> dkayiwa: same problem
10:11:38 <kavuri> dkayiwa: the problem seems to be at ConversionUtil.java:82
10:12:31 <dkayiwa> kavuri: ok
10:12:37 *** Echidna has quit IRC
10:12:52 *** Echidna has joined #openmrs
10:12:52 *** ChanServ sets mode: +v Echidna
10:19:44 *** meghna has joined #openmrs
10:23:47 *** meghna has quit IRC
10:38:38 <kavuri> dkayiwa: any luck?
10:38:46 <dkayiwa> kavuri: debugging
10:38:52 <kavuri> dkayiwa: ok
10:44:17 <dkayiwa> kavuri: which visit attribute type is VISIT_ATTRIBUTE_TYPE_UUID?
10:44:31 <dkayiwa> kavuri: as in which data type
10:44:40 <kavuri> dkayiwa: I guess it is a sample one..not sure what the type is
10:45:22 <dkayiwa> kavuri: you gave it text. what if its a date?
10:45:32 <kavuri> dkayiwa: same problem with date too
10:46:17 <dkayiwa> kavuri: which date value did you give it?
10:46:29 <kavuri> dkayiwa: its as it looks in the testcase
11:14:49 <dkayiwa> kavuri: can you create a ticket for this?
11:14:59 <kavuri> dkayiwa: yes, I can..
11:15:08 <kavuri> dkayiwa: any luck in figuring the problem out?
11:15:09 <dkayiwa> kavuri: and add your unit test to the ticket?
11:15:19 <dkayiwa> kavuri: yes partly :)
11:15:44 <kavuri> dkayiwa: cool, got the solution?
11:16:13 <dkayiwa> kavuri: still testing it out. i want to commit it on the ticket you create
11:16:31 <kavuri> dkayiwa: sure..
11:28:53 <kavuri> dkayiwa: created: https://tickets.openmrs.org/browse/RESTWS-312
11:29:06 <dkayiwa> kavuri: did you add me as a watcher?
11:38:23 <kavuri> dkayiwa: added you as a watcher
11:38:29 <dkayiwa> kavuri: ok thanks
11:58:41 <dkayiwa> kavuri: committed
11:58:49 <kavuri> dkayiwa: great! thanks
12:07:42 *** AdamLauz has joined #openmrs
12:09:59 *** shangxiao has quit IRC
12:16:46 *** dkayiwa has quit IRC
12:20:36 *** jkeiper has quit IRC
12:24:18 *** Antony has joined #openmrs
12:26:10 <Antony> wyclif_:
12:26:17 <Antony> Hi
12:26:53 <Antony> Are you there?
12:38:12 <Antony> Which service method is used to save PatientIdentifierType?
12:38:30 <Antony> kavuri:
12:38:37 <Antony> Hi
12:38:39 <Antony> are you there?
12:44:13 *** yony258 has quit IRC
12:45:32 <kavuri> Antony: hi
12:45:45 <kavuri> Antony: I have myself not worked on using the service api..
12:46:39 <kavuri> Antony: the easy way is to check the testcases from openmrs source code
12:46:52 <kavuri> Antony: specically for your stuff, check here: api/src/test/java/org/openmrs/patient/impl
12:48:47 *** Antony has quit IRC
13:06:22 *** wyclif_ has quit IRC
13:07:10 *** k7joseph has joined #openmrs
13:07:21 *** suranga has joined #openmrs
13:07:21 *** ChanServ sets mode: +v suranga
13:07:53 *** Antony has joined #openmrs
13:14:13 *** Antony has quit IRC
13:21:32 *** jkeiper has joined #openmrs
13:21:32 *** ChanServ sets mode: +v jkeiper
13:29:19 *** shangxiao has joined #openmrs
13:29:22 *** suranga has quit IRC
13:31:17 *** k7joseph has quit IRC
13:38:28 *** Antony has joined #openmrs
13:42:37 *** suranga has joined #openmrs
13:42:58 *** Antony has quit IRC
13:48:24 *** yony258 has joined #openmrs
13:49:23 *** sgithens has joined #openmrs
13:51:48 *** Antony has joined #openmrs
13:55:50 *** wyclif_ has joined #openmrs
13:57:18 <Antony> jkeiper:
13:57:36 <Antony> Please join ampath
13:58:44 <jkeiper> i have been there
13:58:54 <jkeiper> :-)
14:04:37 *** Antony has quit IRC
14:08:32 *** Antony has joined #openmrs
14:11:43 *** shangxiao has quit IRC
14:14:13 *** fishandwalk has quit IRC
14:15:57 *** sgithens has quit IRC
14:17:32 *** Antony has quit IRC
14:19:25 *** nribeka has joined #openmrs
14:19:25 *** ChanServ sets mode: +v nribeka
14:20:50 *** dkayiwa has joined #openmrs
14:23:00 <yony258> dkayiwa: Hi
14:23:20 <dkayiwa> yony258: hi
14:24:16 *** downey has joined #openmrs
14:24:16 *** ChanServ sets mode: +o downey
14:24:26 <yony258> dkayiwa: Was working on the AppointmentService .java file and thought about some additional functions we will need except from the standard ones.
14:24:46 <yony258> List<Appointment> getAppointmentsOfPatient(Patient patient);
14:24:48 <dkayiwa> yony258: ok
14:24:52 <yony258> Appointment getAppointmentByVisit(Visit visit);
14:24:57 <dkayiwa> yony258: ok
14:25:31 <yony258> dkayiwa: Wasnt sure about what to do in AppointmentDAO.java
14:25:43 <yony258> dkayiwa: So I added :
14:25:43 <yony258> List<Appointment> getAppointmentsByPatient(int patientId); Appointment getAppointmentByVisit(int visitId);
14:25:49 <dkayiwa> yony258: ok
14:26:01 <yony258> dkayiwa: Is that ok?
14:26:09 <dkayiwa> yony258: thats correct. that is the place where to add such
14:26:29 <yony258> dkayiwa: int patientId instead of Patient patient is ok?
14:26:59 <dkayiwa> yony258: yes patientId is ok
14:27:17 <yony258> dkayiwa: Should I do that too in the AppointmentService.java file?
14:27:40 <dkayiwa> yony258: perfect!!!
14:28:12 <yony258> dkayiwa: Im not sure... Should I change Patient patient to Patient patientId in AppointmentService.java too ?
14:28:18 *** kavuri has quit IRC
14:28:54 <dkayiwa> yony258: let me cross check
14:29:00 *** suranga_ has joined #openmrs
14:29:36 *** suranga has quit IRC
14:34:48 <dkayiwa> yony258: you can leave it the way it is for now
14:35:12 <dkayiwa> yony258: sorry. just change it to an integer
14:35:20 <yony258> dkayiwa: Ok can you share with me the reasons to do that?
14:36:26 <dkayiwa> yony258: for conveniency. such that when a caller has an integer request parameter, they do not have to first load a patient in order to call the API
14:36:52 <yony258> dkayiwa: Ok. Do you want me to change anyplace I used int to integer too?
14:37:01 <yony258> I mean "Integer"
14:37:11 <dkayiwa> yony258: yes Integer
14:38:45 <yony258> dkayiwa: Ok great, let me know when you finish reviewing the Hibernate Mapping files
14:39:42 <dkayiwa> yony258: can you give me the link and i review now?
14:40:10 <yony258> https://github.com/openmrs/openmrs-module-appointment/commit/c43b7f3074e88621804104925d596555035015b7
14:40:13 <yony258> https://github.com/openmrs/openmrs-module-appointment/commit/748d288ab6a3232b51507ff08582d2f57b1c14bb
14:40:15 <OpenMRSBot> <http://ln-s.net/+CJe> (at github.com)
14:40:17 <OpenMRSBot> <http://ln-s.net/+CJf> (at github.com)
14:40:36 *** kishoreyekkanti has quit IRC
14:40:56 <dkayiwa> ok reviewing it now
14:50:28 <yony258> dkayiwa: Why does the HibernateAppointmentServiceDAO implements AppointmentDAO ? AppointmentDAO is the interface for DB manipulation related to openmrs.org.module.Appointment.
14:56:14 <dkayiwa> yony258: you are correct. please feel free to remove that class for now (HibernateAppointmentServiceDAO)
14:58:30 <yony258> dkayiwa: It has a lot of code about DB manipulation related to AppointmentType and AppointmentBlock
14:58:59 <dkayiwa> yony258: just delete it
14:59:29 <yony258> dkayiwa: Why? it has all of Adam's work from yesterday...
15:00:26 <dkayiwa> yony258: Adam was supposed to remove those methods from that class. Did he just forget to commit?
15:00:55 <yony258> dkayiwa: Not sure, hes not availble right now, Anyway I'll proceed with anything not related
15:01:40 <dkayiwa> yony258: just delete the class. we can always get what we want from the git commit history
15:02:19 <yony258> dkayiwa: Ok I'll delete (HibernateAppointmentServiceDAO)..
15:02:59 <dkayiwa> yony258: ok
15:03:37 *** andrea_ has joined #openmrs
15:04:45 <andrea_> good morning
15:05:24 *** cpower has joined #openmrs
15:05:28 <cpower> Hello!
15:05:34 <andrea_> hi cpower
15:05:39 <cpower> Sorry I'm late, are we ready to scrum?
15:05:39 *** djazayeri has joined #openmrs
15:05:39 *** ChanServ sets mode: +o djazayeri
15:05:58 <rafa> cpower: yep
15:06:03 <cpower> !scrumon cpower
15:06:03 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
15:06:53 <djazayeri> order?
15:06:54 <cpower> Order: djazayeri, rafa, AdamLauz, andrea_, dkayiwa, suranga_, wyclif_, yony258
15:07:10 <djazayeri> Yesterday & Today-
15:07:34 <djazayeri> * Mirabalais work, spike on jquery-based data-driven question-per-screen UI
15:07:39 <djazayeri> no blockers
15:07:50 <rafa> Today:
15:07:50 <rafa> * Continued with fixing tests for MDS
15:07:50 <rafa> * Univ call
15:07:50 <rafa> * Design call
15:07:50 <rafa> No blockers.
15:07:50 <rafa> Questions: downey, is https://ci.openmrs.org/browse/DEMO-DEVTEST01 supposed to be used for showcasing lucene?
15:08:01 *** shangxiao has joined #openmrs
15:08:48 <downey> rafa: It's for whatever everyone agrees it to be. :)
15:09:22 <djazayeri> save the discussion for the end. :-)
15:09:36 <cpower> next!
15:09:45 <cpower> AdamLauz are you there?
15:10:08 <yony258> cpower: He will be here in 2 minutes
15:10:09 <cpower> andrea_, you are up!
15:10:25 <cpower> ok, We can put him at the end
15:10:30 <andrea_> Tuesday
15:10:30 <andrea_> Atlas Module
15:10:30 <andrea_> pair programming with Wyclif on Atlas Module.
15:10:31 <andrea_> Looked at tickets Atlas-43, Atlas-45
15:10:31 <andrea_> looked at TRUNK-2768 while waiting for Wyclif
15:10:31 <andrea_> Wednesday
15:10:33 <andrea_> Atlas Module
15:10:35 <andrea_> More pair programming with Wyclif on Atlas Module?
15:10:37 <andrea_> Get status of tickets for Atlas module - some are fixed
15:10:39 <andrea_> Blockers
15:10:41 <andrea_> problem with Atlas form - See Wyclif's email to dev list
15:10:43 <AdamLauz> cpower: now yes
15:10:53 <cpower> dkayiwa, go for it
15:11:06 <dkayiwa> Had a training session with Tobin's Team
15:11:06 <dkayiwa> Reviewed their code
15:11:07 <dkayiwa> Committed: Error in creating visit with attributes - RESTWS-312
15:11:07 <dkayiwa> Now working: @StartModule does not work - TRUNK-3508
15:11:07 <dkayiwa> No Blockers
15:11:17 <cpower> suranga_ you are up
15:12:02 <cpower> Next! wyclif_
15:12:29 <wyclif_> Tuesday:
15:12:30 <wyclif_> Complete work on TRUNK-3593 proposed concept queue
15:12:30 <wyclif_> investigate atlas issues and paired with Andrea to work on them
15:12:30 <wyclif_> Code reviews:
15:12:30 <wyclif_> TRUNK-3474 - Remove not null constraint on the description column/property for all OpenmrsMetadata objects
15:12:31 <wyclif_> TRUNK-2751 - Automated Error Report: NumberFormatException on AddPersonController
15:12:33 <wyclif_>
15:12:35 <wyclif_> Wednesday:
15:12:37 <wyclif_> Code review and apply pull requests
15:12:41 <wyclif_> design call
15:12:43 <wyclif_> talk to burke if he has time about the way forward with atlas module
15:12:45 <wyclif_> pick a bug fix ticket
15:12:47 <wyclif_>
15:12:49 <wyclif_> Blockers: None
15:12:57 <cpower> yony258 you are next
15:13:29 <yony258> Tuesday: Almost Finished AM-11. Wednesday: Working on Appointment Service and DAO
15:13:30 <cpower> and welcome to the channel if it hasn't been said before
15:13:46 <yony258> Thank you
15:14:11 <cpower> Any issues or blockers that Daniel doesn't have the answer for?
15:14:25 <yony258> No Daniel is very helpful solved any issue we had.
15:14:30 <cpower> :-)
15:14:37 <cpower> ok AdamLauz you are up
15:15:13 <cpower> and welcome to the channel as well, but I think I did see you on yesterday so sorry for the late welcome
15:15:21 <AdamLauz> cpower: I am working on AM-3 and finished the API java files and now I'm doing the Unit testing for them
15:15:46 <cpower> Will that take all your time today?
15:16:06 <cpower> And any issues that Daniel hasn't been able to resolve?
15:16:29 <AdamLauz> cpower: No I didn't stated working today yet because I had to finish staff
15:16:38 <AdamLauz> cpower: I finished that yesterday
15:17:04 <cpower> ok, any other comments or questions from the team?
15:17:31 <rafa> cpower: I have a few follow up questions to downey answer ;)
15:17:41 <cpower> Blockers: Atlas issues that Wyclif is reaching out for help on
15:17:47 <AdamLauz> cpower: No daniel is answring everything :) thanks
15:18:01 <cpower> and Downey to save the day for Rafa.
15:18:06 <cpower> !scrumoff
15:18:06 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:18:16 <andrea_> cpower: yes Wyclif will talk to Burke
15:18:19 <djazayeri> downey: do we only have the one dev/demo server, and need to share that between this sprint, and Rafal's demo?
15:18:35 <downey> only one was requested, yes
15:18:46 <djazayeri> downey: can we get a second one?
15:18:54 <downey> it'll take at least another week
15:19:26 <downey> or.. . we can use the same server for both.
15:19:30 <djazayeri> downey: can we start that process now, for the future?
15:19:48 <djazayeri> downey: the appointment module should be running OpenMRS 1.9, and Rafal's code is 1.10-SNAPSHOT, I think
15:19:57 <rafa> djazayeri: correct
15:20:20 <downey> why not install them both on the same server?
15:20:29 <djazayeri> downey: you mean have two tomcats running?
15:20:43 <downey> no, same tomcat instance
15:20:45 <rafa> djazayeri: or two wars on one tomcat ;)
15:20:50 <djazayeri> oh, sure.
15:21:24 <djazayeri> fine, I guess. we'll see how that sized VM handles it.
15:22:11 <rafa> downey: so how to do this?
15:22:43 <rafa> downey: also can we access a db with the mysql client to load data?
15:23:26 <djazayeri> andrea_, wyclif_: I haven't used the google maps API, but perhaps if you share an example of what the html is like, and what element you're trying to move, I can help
15:24:23 <downey> rafa: best thing is fill out a request with what you need at http://go.openmrs.org/helpdesk including what your data load looks like (recurring, one-time), where the data is, etc. Bamboo can be pretty easily configured to deploy multiple apps against the same server, just an additional plan to do so
15:24:23 <andrea_> djazayeri, ok will do that - maybe wyclif can do it now
15:24:46 <downey> rafa: i'm in 2 other parallel meetings right now so i don't have the cycles to do the planning at this moment
15:25:00 <andrea_> wyclif_: u still here?
15:25:07 <wyclif_> djazayeri, the html is wacky, you know that html generated by libraries, i will see what i can do
15:25:50 <rafa> downey: so you need a sql script? no direct access to the db possible?
15:26:53 <downey> rafa: either is possible, the former is preferred. :)
15:28:37 <dkayiwa> yony258: put comments in your commit
15:28:44 <rafa> downey: hmmm direct access would work easier from my side
15:28:56 <yony258> dkayiwa: Can you be more specific?
15:29:12 <dkayiwa> yony258: as github comments
15:29:23 *** suranga_ has quit IRC
15:29:48 <yony258> dkayiwa: You mean that I need to explain more when committing?
15:29:58 <dkayiwa> yony258: no
15:30:01 *** sgithens has joined #openmrs
15:30:11 <dkayiwa> yony258: sorry i mean that i have put comments. :)
15:30:18 <yony258> dkayiwa: Oh ok :)
15:30:33 *** cpower has quit IRC
15:30:36 <andrea_> djazayeri, wyclif_, could the 3 of us skype after the design call?
15:30:59 <wyclif_> sure
15:31:24 <andrea_> djazayeri, how about you?
15:31:35 <djazayeri> sure
15:32:04 <andrea_> djazayeri, wyclif_, great! Talk to you soon.
15:35:39 <yony258> dkayiwa: Ok fixed it thank you, Soon will need another review :)
15:36:06 <dkayiwa> yony258: just tell me and i review immediately
15:47:02 *** rafa has quit IRC
15:48:55 *** tobin_g has joined #openmrs
15:54:17 *** harshadura has joined #openmrs
15:54:18 *** harshadura_ has joined #openmrs
15:56:55 <tobin_g> dkayiwa: AdamLauz yony258 hi guys, how's it going?
15:57:14 <yony258> tobin_g: Hi Tobin, good.
15:57:56 <tobin_g> yony258: how was the session this am?
15:58:29 <yony258> tobin_g: Great, we finished all the questions we had.
15:58:36 <dkayiwa> tobin_g: so far good :)
15:58:54 <shangxiao> djazzy you there?
15:59:07 * shangxiao pokes djazayeri
15:59:23 <shangxiao> dj jazzy jeff xD
15:59:54 <yony258> dkayiwa: Where do you update the appointment retire reason?
15:59:54 <shangxiao> oh you're in a skype design call
16:01:00 <tobin_g> shangxiao: the main design call is in 3 hours
16:01:02 <dkayiwa> yony258: appointment will be voided instead of being retired
16:01:14 <yony258> dkayiwa: Sorry Appointment Type
16:01:16 <tobin_g> yony258: that's great, are you working on unit tests tonight?
16:01:30 <AdamLauz> tobin_g: Hi Tobin everything is great
16:01:48 <yony258> tobin_g: I hope ill get there but cant confirm yet.
16:01:48 <dkayiwa> yony258: passed in the retire method
16:02:32 <yony258> dkayiwa: The JSP is activating the retire method in the AppoinmentService but then it just activates saveAppointmentType
16:02:43 <tobin_g> AdamLauz: great! what are you working on tonight?
16:03:57 <AdamLauz> tobin_g: Unit tests right now
16:04:30 <tobin_g> AdamLauz: nice. anything i can do to help out / questions for me? obviously dkayiwa is the expert
16:05:32 <yony258> tobin_g: Do you think we can finish with the Data Model designing after this evening's Design call ?
16:05:42 <AdamLauz> tobin_g: I'm teaching couple of high school students today so I will have time to work only after 20:00pm
16:05:48 <dkayiwa> yony258: very nice catch :)
16:06:13 <yony258> dkayiwa: But you showed us it works, I just dont know where it does "the magic" ?
16:06:35 <dkayiwa> yony258: yes going to show you shortly :)
16:06:48 <yony258> dkayiwa: Ok great, thanks :)
16:07:18 <tobin_g> yony258: yes that's the hope!
16:07:37 <tobin_g> yony258: everyone will understand that it's important we get it resolved on the call.
16:07:52 <tobin_g> AdamLauz: that sounds great, have fun teaching. reminder we'll be on the design call at 9
16:08:18 <AdamLauz> tobin_g: Yeah :)
16:08:45 <tobin_g> AdamLauz: I guess you'll move onto UI after unit tests?
16:09:12 <AdamLauz> tobin_g: I think so
16:09:30 <tobin_g> AdamLauz: cool, obviously we can follow dkayiwa's lead
16:09:48 <tobin_g> yony258: after we finish data model what's your next step?
16:10:06 <yony258> tobin_g: Unit tests
16:10:26 <dkayiwa> yony258: look in openmrs-core RequiredDataAdvice
16:10:36 <tobin_g> yony258: cool, AdamLauz is working on those so he should be able to help out
16:15:10 <yony258> dkayiwa: Ok im there can you tell me where to focus?
16:15:29 <yony258> dkayiwa: nvm got it thanks.
16:15:53 <dkayiwa> yony258: good you got it :)
16:18:43 <yony258> dkayiwa: Ok good news ready to code-review !
16:18:52 <dkayiwa> yony258: yes
16:19:24 <yony258> dkayiwa: Ok ill push the changes that dont need a review and then the those that need ill send you the link in a few minutes
16:19:24 *** kjoseph has joined #openmrs
16:19:55 <kjoseph> dkayiwa: good evening
16:20:06 <dkayiwa> kjoseph: good evening
16:20:20 <dkayiwa> yony258: ok
16:21:54 <yony258> dkayiwa: Can I remove something from commit and then add it to a different commit?
16:22:19 <dkayiwa> yony258: just change and commit
16:28:56 <yony258> dkayiwa: Please review this: https://github.com/openmrs/openmrs-module-appointment/commit/06d460db4ecdaac3873bc6b842436b25e4c522f7
16:29:00 <OpenMRSBot> <http://ln-s.net/+CLo> (at github.com)
16:29:05 <dkayiwa> yony258: ok
16:34:36 *** rafa has joined #openmrs
16:34:36 *** ChanServ sets mode: +v rafa
16:35:23 *** shangxiao has quit IRC
16:36:57 <dkayiwa> yony258: where do you think we are gonna use getAppointmentsOfPatient(patientId) ?
16:38:13 <yony258> dkayiwa: For example if we will want to check if a patient missed a lot of appointments
16:39:46 <dkayiwa> yony258: oh i see :)
16:40:20 <dkayiwa> yony258: and when do we use getAppointmentByVisit(visitId)?
16:41:25 <yony258> dkayiwa: For example if we want to know the different statuses that a visit had.
16:41:39 <yony258> dkayiwa: Calculating the average waiting time for a patient.
16:41:46 *** suranga has joined #openmrs
16:41:46 *** ChanServ sets mode: +v suranga
16:45:14 <dkayiwa> yony258: ok
16:46:19 <yony258> dkayiwa: Ok let me know when you are done reviewing.
16:48:27 <dkayiwa> yony258: ok
16:50:38 <dkayiwa> yony258: i have done reviewing and have put comments (github)
16:50:38 <suranga> hi rafa :)
16:51:10 <suranga> rafa, I just wanted to say that I was able to update the code based on your comments, and commit it into the module ...
16:51:34 <yony258> dkayiwa: Ok fixed all except one that I didnt understood, I put a comment
16:54:39 <dkayiwa> yony258: just responded to it
16:55:31 <dkayiwa> kjoseph: are you working on anything now?
16:56:55 <yony258> dkayiwa: Great, fixed everything. I guess I need to start unit tests now, correct?
16:59:20 <dkayiwa> yony258: correct
17:02:00 *** sgithens has quit IRC
17:07:44 <yony258> dkayiwa: We made a mistake.
17:08:07 <djazayeri> shangxiao: hi
17:09:32 <dkayiwa> yony258: aha
17:09:51 <yony258> dkayiwa: There is no visitId attribute for org.openmrs.module.Appointment
17:10:04 <yony258> dkayiwa: The attribute is Visit visit
17:12:09 <dkayiwa> yony258: am not sure i understand you
17:12:30 <yony258> "from " + mappedClass.getSimpleName() + " where at.visitId =
17:13:05 <yony258> dkayiwa: visitId in at.visitId supposed to be an attribute of Appointment by the code above, correct?
17:13:55 <dkayiwa> yony258 yes
17:14:16 <yony258> dkayiwa: There isnt an attribute called visitId of Appointment.
17:16:14 <dkayiwa> yony258: do we have it in the data model
17:16:35 <yony258> dkayiwa: Appointment have visit_id
17:16:41 <yony258> dkayiwa: on the data model
17:16:59 <yony258> dkayiwa: But the Appointment Domain Model has Visit visit.
17:17:04 <dkayiwa> yony258: thats correct
17:17:05 <yony258> *domain object
17:17:39 <yony258> dkayiwa: The Appointment domain object dont have any property called visitId.
17:17:42 <dkayiwa> yony258: just like provider_id in model while object = Provider
17:17:58 <dkayiwa> yony258: it should have Visit
17:18:13 <dkayiwa> yony258: see the hibernate file mapping
17:18:38 <yony258> dkayiwa: it has Visit visit, not integer visitId. How will the hibernate know to execute that query?
17:18:43 <yony258> *will hibernate
17:19:49 <yony258> dkayiwa: If you are still not sure what I mean let me know
17:21:03 <dkayiwa> yony258: can you paste here the hibernate mapping line for the visit
17:21:32 <yony258> <many-to-one name="visit" column="visit_id" class="org.openmrs.Visit" not-null="false" />
17:22:34 <dkayiwa> yony258: hibernate will load a visit object from the visit_id
17:23:00 <yony258> dkayiwa: I think it will be easier if you can explain to me here or on skype how will that query will be executed.
17:25:17 <dkayiwa> yony258: for now, i would recommend you do not worry about hibernate behind the scenes magic, let us start with what we need to complete the task. then later on i will give you links for hibernate internals :)
17:25:50 <yony258> dkayiwa: Ok but there is still a problem here, I just cant explain it because I dont know how will that query will be executed
17:25:57 <yony258> dkayiwa: I think it may cause runtime error.
17:26:12 <dkayiwa> yony258: do you have the unit test which produces the error?
17:26:44 <yony258> dkayiwa: no. I just think that this query isnt correct.
17:28:07 <dkayiwa> yony258: can you write a unit test where it fails
17:28:34 <yony258> dkayiwa: I'll try in a few
17:39:12 *** kishoreyekkanti has joined #openmrs
17:39:37 *** kjoseph has quit IRC
17:54:03 <tobin_g> hi suranga :] 8)
17:57:50 *** rafa has quit IRC
18:01:48 <suranga> tobin_g, aloha !
18:02:02 <suranga> tobin_g, sorry, i was a bit fistracted back there :-(
18:02:06 <tobin_g> wow suranga i didn't realize you are hawaiian!
18:02:11 <suranga> *distracted
18:02:51 <suranga> tobin_g im a little bit of everything :-)
18:03:12 <tobin_g> suranga: one of the many things i like about you.
18:03:33 <tobin_g> suranga: np i was just saying hi, having withdrawls after implementers mtg
18:03:57 <suranga> tobin_g, oh, I see !
18:04:02 <tobin_g> suranga: hard to find you since you're such a traveling man these days!
18:04:14 <suranga> tobin_g, hows life these days ? its safer, I hope :)
18:04:37 <suranga> tobin_g, I wish. looks like im grounded until I finish my degree (at long last)
18:04:49 <tobin_g> suranga: much, thank you. i'm up in the north of the country where it's green and beautiful doing a rotation in family medicine. very interesting
18:04:57 <tobin_g> suranga: get-er-done
18:05:15 <tobin_g> suranga: perhaps the best thing about this rotation is getting to see the israeli EMR in action. it's UNREAL
18:06:44 <tobin_g> suranga: they've been doing it for at least 15-20 years and they have every lab value, clinical consultation, specialty consultation, diagnosis, hospital visit, you name it.
18:07:33 <tobin_g> suranga: it's all used point-of-care so the doctor has all this data at their finger tips. they also do all of the ordering and referrals for the whole country through the system; very impressive to say the least.
18:07:38 <tobin_g> suranga: i'm getting lots of ideas for OpenMRS!
18:08:13 <suranga> tobin_g, they're better than us ? :-(
18:08:43 <tobin_g> suranga: they just have a little more practice than we do; and a whole ministry of health behind it!
18:08:58 <tobin_g> suranga: but i do want to try to find a way to learn from them
18:09:44 *** ningosi has joined #openmrs
18:09:48 <suranga> tobin_g, out of curiosity, how much longer till you graduate ? :)
18:10:00 <tobin_g> suranga: about 18 months
18:10:14 <tobin_g> suranga: of course then i have residency before I actually know anything...
18:11:22 <suranga> tobin_g, you know, Ive really started to like doctors ever since I joined up with OpenMRS :-)
18:12:10 <suranga> tobin_g, I see your students are being very active thease days. they're always on IRC !
18:12:26 *** robbyoconnor has quit IRC
18:12:32 <dkayiwa> suranga: :D
18:12:48 <tobin_g> suranga: i was just about to say that's because dkayiwa is the MAN
18:13:02 <tobin_g> suranga: I think we need to find a better name than "my students"
18:13:18 <tobin_g> suranga: as flattering as it is….
18:13:19 <dkayiwa> tobin_g: not at all. the students are the men :D
18:14:38 *** sgithens has joined #openmrs
18:14:50 <tobin_g> dkayiwa: agreed :D
18:14:58 *** ningosi has quit IRC
18:15:16 <tobin_g> suranga: dkayiwa has been really helpful. yony258 and AdamLauz have also been kicking ass.
18:15:16 <dkayiwa> tobin_g: sure :D
18:15:29 *** ningosi has joined #openmrs
18:15:47 *** ningosi is now known as Antony
18:16:11 *** Antony is now known as Anto
18:16:27 <Anto> jkeiper,
18:16:35 <Anto> Hi Jer
18:16:37 <jkeiper> yes sir
18:16:39 <jkeiper> hiya
18:16:44 <jkeiper> come on over to #ampath :-D
18:33:09 <AdamLauz> dkayiwa: Hi daniel
18:33:17 <dkayiwa> AdamLauz: hi
18:35:15 *** AdamLauz_ has joined #openmrs
18:35:21 <AdamLauz_> dkayiwa: I have been doing the unit tests and I'm not sure about how to assert that I'm getting the AppointmentBlock
18:35:26 <downey> Hi AdamLauz_ and welcome to the #openmrs IRC channel.
18:36:18 <dkayiwa> AdamLauz_: did you look at how i assert that am getting an apppointment type?
18:36:33 <AdamLauz_> dkayiwa: Yes sure you are doing it by "name"
18:36:56 <AdamLauz_> dkayiwa: I can do it by id?
18:37:16 <AdamLauz_> dkayiwa: because i need something unique right?
18:37:25 <dkayiwa> AdamLauz_: looking at it now....
18:37:29 <AdamLauz_> dkayiwa: ok
18:37:32 *** AdamLauz has quit IRC
18:42:49 *** tobin_g has quit IRC
18:44:10 <dkayiwa> AdamLauz_: how many appointment rows do you have in your dataset.xml?
18:44:36 <AdamLauz_> dkayiwa: I have 3 appointment blocks
18:45:03 <dkayiwa> AdamLauz_: instead of name, just assert on any other property that you put in the xml file row
18:45:55 <AdamLauz_> dkayiwa: I did it with provider so I suppose it's ok
18:46:16 *** jblaya has joined #openmrs
18:46:20 <dkayiwa> AdamLauz_: yes
18:46:34 <AdamLauz_> I did Context.getProviderService().getProvider(1) and compared with appointmentBlock.getProvider() for example
18:46:36 *** sgithens has quit IRC
18:48:36 <AdamLauz_> dkayiwa: Is that makes sense?
18:50:08 <jblaya> dkayiwa, one question, if I'm trying to submit an xform from another system and it fails, is there a location where it stores the xml that was sent?
18:50:34 <jblaya> dkayiwa, I tried xforms/archive and xforms/queue but they are not in there
18:58:01 *** AdamLauz has joined #openmrs
18:58:47 *** yony258 has quit IRC
18:59:12 *** AdamLauz_ has quit IRC
18:59:53 *** rafa has joined #openmrs
18:59:53 *** ChanServ sets mode: +v rafa
19:02:45 *** tobin_g has joined #openmrs
19:05:51 *** kishoreyekkanti has quit IRC
19:06:13 <dkayiwa> jblaya: are u sending from browser
19:06:31 <jblaya> dkayiwa, no we're sending them from another system, verboice in this case
19:08:32 <dkayiwa> jblaya: can you pastebin the tomcat logs
19:09:19 <jblaya> dkayiwa, it's here http://pastebin.com/AwVTdHVL
19:09:31 <jblaya> dkayiwa, that's the error when it tries to upload the xml
19:10:15 <dkayiwa> jblaya: ok
19:18:27 <dkayiwa> jblaya: do you know the providerid you are passing in?
19:39:33 *** joaquinblaya has joined #openmrs
19:39:40 <downey> Hi joaquinblaya and welcome to the #openmrs IRC channel.
19:39:58 <joaquinblaya> dkayiwa, sorry, got kicked off
19:40:13 <joaquinblaya> dkayiwa, unfortunately, no, that's why I'm trying to see if there's a copy of the xml stored in xforms
19:40:29 <joaquinblaya> dkayiwa, I'm also seeing if there's a copy in the system that sends it, but they haven't responded to me yet
19:44:54 <dkayiwa> joaquinblaya: ok
19:49:02 *** Anto has quit IRC
19:49:37 <joaquinblaya> dkayiwa, so my guess is that a copy of the xml that didn't get entered, don't get stored in the xforms module?
19:50:14 <dkayiwa> joaquinblaya: which version of the module?
19:50:41 <joaquinblaya> dkayiwa, I've tried 4.0.5.9 and 4.0.9.9, they both give different errors
19:51:29 <dkayiwa> joaquinblaya: can you confortably reproduce the error by sending another form?
19:51:38 <joaquinblaya> dkayiwa, yes, no problem
19:52:00 <dkayiwa> joaquinblaya: are you choosing a particular provider?
19:52:55 <joaquinblaya> dkayiwa, no, there isn't an option to chose a particular provider, that's why I'd like to see the xml that's being sent, to see what provider the system is sending
20:01:48 <dkayiwa> joaquinblaya: just send you a module
20:02:07 <dkayiwa> joaquinblaya: install, submit the form, and tell me if you see the form stored in the error folder
20:04:24 <dkayiwa> jblaya: ^^^
20:05:54 *** djazayeri1 has joined #openmrs
20:06:09 <joaquinblaya> dkayiwa, doing it right now
20:08:34 *** djazayeri has quit IRC
20:14:50 *** Echidna has quit IRC
20:15:36 *** Echidna has joined #openmrs
20:15:36 *** ChanServ sets mode: +v Echidna
20:21:36 *** wyclif_ has quit IRC
20:22:46 *** wyclif_ has joined #openmrs
20:29:57 *** wyclif_ has quit IRC
20:30:03 *** AdamLauz has quit IRC
20:30:51 <joaquinblaya> dkayiwa, that worked perfectly, is that going to be a feature of xforms from now on?
20:32:46 <dkayiwa> joaquinblaya: if you say so
20:33:06 <jkeiper> hahaha
20:33:10 <joaquinblaya> dkayiwa, I think that's a great feature, to see which xforms were submitted in error
20:33:19 <dkayiwa> joaquinblaya: ok
20:34:29 <joaquinblaya> dkayiwa, awesome, thanks
20:35:04 <joaquinblaya> jkeiper, thanks for the laughter :D
20:35:14 <jkeiper> :-)
20:35:33 <jkeiper> i like dkayiwa's openness
20:38:36 <dkayiwa> jkeiper: the end user is always my boss :)
20:39:10 <dkayiwa> actually not my boss, but the module's boss :D
20:39:29 <jkeiper> haha very true
20:44:44 *** wyclif_ has joined #openmrs
20:51:32 *** suranga has quit IRC
20:54:40 *** nribeka has quit IRC
21:03:39 *** harshadura_ has joined #openmrs
21:06:42 *** harshadura has quit IRC
21:09:02 *** jkeiper has quit IRC
21:09:08 *** jkeiper has joined #openmrs
21:09:09 *** ChanServ sets mode: +v jkeiper
21:12:01 <tobin_g> hi andrea_ are you planning to use the connect room in the next hour?
21:12:23 <djazayeri1> tobin_g: we can always use another one, go ahead and take it if you need
21:12:49 <tobin_g> djazayeri1: thanks, we just want to have a wrap up on what we talked about before, feel free to pop in :-)
21:12:57 *** djazayeri1 is now known as djazayeri
21:13:04 <djazayeri> gotta run to lunch first. :-)
21:15:00 *** jkeiper has quit IRC
21:16:31 *** tobin_g_ has joined #openmrs
21:18:12 *** tobin_g has quit IRC
21:18:13 *** tobin_g_ is now known as tobin_g
21:29:52 *** joaquinblaya has quit IRC
21:38:20 *** Andrea___ has joined #openmrs
21:38:32 <downey> Hi Andrea___ and welcome to the #openmrs IRC channel.
21:42:32 *** Andrea___ has quit IRC
21:53:21 *** andreapat has joined #openmrs
21:53:47 <andreapat> wyclif_, I was
21:54:21 <andreapat> wyclif_, are u there?
21:54:31 <wyclif_> andrea_, hei
21:54:46 <andreapat> wyclif_, hi
21:56:13 <andreapat> wyclif_, are u on skype?
21:56:23 <wyclif_> andrea_, let me get on
21:56:42 <wyclif_> andrea_, my day has basically ended
21:57:05 <andreapat> wyclif_, so you want to wait till tomorrow?
21:57:23 <wyclif_> andrea_, am only around for around 15min
21:57:35 <wyclif_> andrea_, what time do you start work
21:57:53 <andreapat> wyclif_, have u heard from Darius?
21:59:17 <djazayeri> I'm here
21:59:35 <djazayeri> nobody had said my name. :-)
21:59:42 <djazayeri> let's catch up real quick for 10 minutes
21:59:49 <djazayeri> at least so I can tell you if I can help or not.
22:00:23 <andreapat> djazayeri, here or on skype?
22:01:06 <andreapat> wyclif_, u still here?
22:01:08 <djazayeri> somewhere where you or wyclif_ can screenshare
22:01:26 <wyclif_> hold on
22:01:29 <djazayeri> I think connecrt or google hangout
22:01:42 <andreapat> djazayeri, we've been using TeamViewer
22:01:44 <djazayeri> tobin_g: are you using connect now?
22:01:51 <djazayeri> andrea_: okay, cool, I'll start it up
22:02:03 <tobin_g> djazayeri: yes
22:02:08 <djazayeri> okay
22:02:13 <djazayeri> andrea_: so skype + TV
22:03:14 <andreapat> djazayeri: I have to get off Merck network will loose IRC but will do skype + TV
22:03:49 <andreapat> djazayeri; is wyclif still there?
22:03:57 <djazayeri> andrea_: he just skyped me
22:04:03 <djazayeri> his TV details
22:04:33 <andreapat> djazayeri, ok I'll skype him
22:07:02 *** andreapat has quit IRC
22:07:48 <djazayeri> andrea_: we can't hear you
22:24:43 *** downey has quit IRC
22:39:50 <tobin_g> djazayeri: we are done in adobe connect
22:45:43 *** jblaya has quit IRC
22:47:26 *** wyclif_ has quit IRC
22:48:09 *** tobin_g has quit IRC
22:48:48 <djazayeri> thx
23:00:20 *** dkayiwa has quit IRC
23:04:23 *** lh has quit IRC
23:14:16 *** andreapat has joined #openmrs
23:15:24 <andreapat> djazayeri, good suggestion on getting rid of edit popup and moving to side - wyclif is doing that
23:17:14 <andreapat> djazayeri, meanwhile I'm going to go back to work TRUNK-2678 estimated death date
23:22:25 <djazayeri> cool
23:26:29 *** lh has joined #openmrs
23:27:25 <andreapat> djazayeri, ok glad you approve