| 00:06:36 | *** wyclig_ has quit IRC |
| 00:13:16 | *** wyclig_ has joined #openmrs |
| 02:05:41 | *** sgithens has joined #openmrs |
| 02:24:48 | *** lh has quit IRC |
| 02:45:37 | *** djazayeri has quit IRC |
| 02:58:14 | *** robbyoconnor has joined #openmrs |
| 02:58:14 | *** ChanServ sets mode: +v robbyoconnor |
| 03:04:31 | *** jkeiper has joined #openmrs |
| 03:04:31 | *** ChanServ sets mode: +v jkeiper |
| 03:06:10 | *** djazayeri has joined #openmrs |
| 03:06:10 | *** ChanServ sets mode: +o djazayeri |
| 03:09:59 | *** sgithens has quit IRC |
| 03:14:38 | *** sgithens has joined #openmrs |
| 03:42:04 | *** djazayeri1 has joined #openmrs |
| 03:42:32 | *** djazayeri has quit IRC |
| 05:17:39 | *** fishandwalk has joined #openmrs |
| 05:20:34 | *** kishoreyekkanti has joined #openmrs |
| 05:31:22 | *** mathiaslin has joined #openmrs |
| 05:37:49 | *** lhawthor_ has joined #openmrs |
| 06:16:42 | *** mathiaslin has quit IRC |
| 06:17:09 | *** mathiaslin has joined #openmrs |
| 06:18:21 | *** mathiasl_ has joined #openmrs |
| 06:21:29 | *** mathiaslin has quit IRC |
| 06:40:46 | *** mathiasl_ has quit IRC |
| 06:41:18 | *** mathiaslin has joined #openmrs |
| 06:42:24 | *** mathiasl_ has joined #openmrs |
| 06:45:40 | *** mathiaslin has quit IRC |
| 07:17:30 | *** yony258 has joined #openmrs |
| 07:18:55 | *** mathiasl_ has quit IRC |
| 07:22:46 | *** dkayiwa has joined #openmrs |
| 07:23:05 | *** AdamLauz has joined #openmrs |
| 07:26:31 | <dkayiwa> hi yony258 |
| 07:26:45 | <yony258> dkayiwa: hi dkayiwa , good morning |
| 07:26:59 | <dkayiwa> yony258: what time is it your side? |
| 07:27:09 | <yony258> dkayiwa: 1 hour before your time |
| 07:27:35 | <yony258> dkayiwa: 9:27 AM |
| 07:27:47 | <dkayiwa> yony258: ok great. |
| 07:28:18 | <yony258> dkayiwa: Do you want to talk here? or Skype? or Design Room? |
| 07:28:30 | <dkayiwa> yony258: wherever you prefer |
| 07:28:58 | <yony258> I think Skype is great, and if we'll need screen sharing we can use teamviewer or the design room |
| 07:29:12 | <dkayiwa> yony258: ok |
| 07:29:31 | <yony258> dkayiwa: Let me check if Adam is ready |
| 07:29:37 | <dkayiwa> yony258: ok |
| 07:41:35 | *** shangxiao has joined #openmrs |
| 07:42:09 | <yony258> dkayiwa: So as I said, what I want to achieve at the end of this meeting is to have a list that specifies what files/parts we need to make in order to create a form, and we prepared a *.doc with questions that I hope you can answer at least some of them today. How does that sounds? :] |
| 07:43:09 | <dkayiwa> yony258: did you finish the hibernate mapping files? |
| 07:43:30 | <yony258> dkayiwa: No, it will be finished today. |
| 07:43:53 | <dkayiwa> yony258: you will need to finish it before starting on another ticket |
| 07:44:04 | <shangxiao> hey guys do you agree that @Test methods are a single test case - and not the class itself? |
| 07:44:48 | <yony258> dkayiwa: Ok |
| 07:45:00 | <yony258> AdamLauz: Ready? |
| 07:45:10 | <AdamLauz> yony258: Yeah |
| 07:45:25 | <AdamLauz> dkayiwa: Hi daniel |
| 07:45:32 | <dkayiwa> yony258: as for what files to create a form, did you look at my commit for appointment types form? |
| 07:45:37 | <dkayiwa> hi AdamLauz |
| 07:46:30 | <yony258> dkayiwa: ofcourse I looked at it :], But I would like to get a more organized list, like: jsp forms, controllers, test cases and such |
| 07:47:00 | * shangxiao pokes djazayeri1 |
| 07:47:09 | <dkayiwa> yony258: the list is the exact list of files in the commit |
| 07:47:51 | <dkayiwa> shangxiao: am not sure i understand your question :) |
| 07:48:11 | <yony258> dkayiwa: Ok so lets go on and I'll send you the questions document, do you prefer that I send PDF or a docx file? |
| 07:48:38 | <dkayiwa> yony258: PDF |
| 07:49:37 | <AdamLauz> dkayiwa: We have looked at it. we want to understand more better what is each file is resoponsble and what it's uses. just to know better why we implementing that way |
| 07:50:31 | <dkayiwa> AdamLauz: ok |
| 07:51:26 | <shangxiao> dkayiwa: I consider each @Test method in a Junit fixture to be a "test case" - someone reviewing a PR seems to disagree ;) |
| 07:51:55 | <dkayiwa> shangxiao: oh i see :) |
| 07:52:11 | * shangxiao pokes wyclig_ |
| 07:52:15 | <shangxiao> wyclif you there? |
| 07:52:47 | <dkayiwa> so yony258 AdamLauz , should we use skype for voice? |
| 07:53:17 | <AdamLauz> dkayiwa: I think so yes |
| 07:53:28 | <dkayiwa> AdamLauz: , yony258 can you call me? |
| 07:53:43 | <AdamLauz> dkayiwa: yes in a second |
| 08:03:46 | *** shortend has joined #openmrs |
| 08:06:52 | <shortend> Hi! I'm having trouble updating OpenMRS dependencies. |
| 08:07:09 | <shortend> Maven is trying to download http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/api/openmrs-api/1.9.2-SNAPSHOT/openmrs-api-1.9.2-20121127.061610-32.jar |
| 08:07:26 | <shortend> And the server is not responding. |
| 08:24:57 | <shortend> OK, I've got it now. |
| 08:25:00 | <shortend> :D |
| 08:34:12 | *** yony258 has quit IRC |
| 08:54:47 | *** djazayeri1 has quit IRC |
| 09:17:07 | *** AdamLauz has quit IRC |
| 09:31:29 | *** rafa has joined #openmrs |
| 09:31:29 | *** ChanServ sets mode: +v rafa |
| 10:10:44 | *** robbyoconnor has quit IRC |
| 10:17:02 | *** shortend has left #openmrs |
| 11:57:57 | *** shangxiao has quit IRC |
| 12:30:47 | *** suranga has joined #openmrs |
| 12:30:47 | *** ChanServ sets mode: +v suranga |
| 12:33:53 | *** Antony has joined #openmrs |
| 12:42:23 | *** shangxiao has joined #openmrs |
| 13:02:51 | <jkeiper> Antony, welcome! |
| 13:02:52 | <jkeiper> :-D |
| 13:03:02 | <jkeiper> dkayiwa, Antony is here :-) |
| 13:03:07 | <jkeiper> (from AMPATH) |
| 13:03:14 | * jkeiper runs off ... |
| 13:03:17 | <shangxiao> amtrak? |
| 13:03:23 | <dkayiwa> jkeiper: oh yeaaaaaahh. welcome Antony :) |
| 13:03:42 | <dkayiwa> jkeiper: is he the one who has made you run off? :) |
| 13:04:40 | *** jkeiper has quit IRC |
| 13:04:54 | *** jkeiper has joined #openmrs |
| 13:04:54 | *** ChanServ sets mode: +v jkeiper |
| 13:09:40 | *** jkeiper has quit IRC |
| 13:18:08 | *** Antony has left #openmrs |
| 13:18:12 | *** Antony has joined #openmrs |
| 13:19:05 | <Antony> Hi |
| 13:25:03 | <Antony> Hi |
| 13:29:55 | *** tobin_g has joined #openmrs |
| 13:30:19 | <tobin_g> hi dkayiwa, how are you? |
| 13:30:35 | <dkayiwa> tobin_g: hi. am doing fine. and you? |
| 13:31:18 | <tobin_g> dkayiwa: good thank you :-) I just sent an email about the data model to the dev list. We'll see what we get back if not discuss tomorrow on the call |
| 13:31:26 | <tobin_g> dkayiwa: how was your call this morning with the guys? |
| 13:31:49 | <dkayiwa> tobin_g: yes just seen it. can you also copy the implementers list? :) |
| 13:32:04 | <tobin_g> dkayiwa: great idea, sending. |
| 13:33:19 | <tobin_g> dkayiwa: how long were you able to meet the guys this morning? |
| 13:34:30 | <dkayiwa> tobin_g: from 9:45am their time |
| 13:34:40 | <dkayiwa> tobin_g: up to when they left for class |
| 13:34:57 | <tobin_g> dkayiwa: great! what did you cover? |
| 13:35:34 | <tobin_g> dkayiwa: were you able to cover enough so that they can continue work? |
| 13:36:06 | <dkayiwa> tobin_g: they sent me a document that has a list of questions they have |
| 13:36:22 | <dkayiwa> tobin_g: and we went through more than half of the document |
| 13:36:46 | <dkayiwa> tobin_g: which is enough for them to get started as we move along |
| 13:36:47 | <tobin_g> dkayiwa: that's great. i think they're more organized than me! |
| 13:37:09 | <dkayiwa> tobin_g: more than me too :) |
| 13:37:17 | <tobin_g> dkayiwa: great, i think that yonatan was stuck on something to do with hibernate and how to complete AM-11, got that squared away? |
| 13:37:45 | <tobin_g> dkayiwa: Also, I haven't spoken to Adam today, does he have enough to start coding on AM-3? |
| 13:38:30 | <dkayiwa> tobin_g: i do not remember Yonatan having told me about any blocker for AM-11 |
| 13:38:46 | <dkayiwa> tobin_g: may be it was one of the ones in the document that we tackled :) |
| 13:38:47 | <tobin_g> dkayiwa: maybe it was worked out in the morning meeting, I will check with him |
| 13:38:54 | <tobin_g> :) |
| 13:39:19 | <dkayiwa> tobin_g: Adam should be able to start too. |
| 13:39:39 | <dkayiwa> tobin_g: i assured them that they should be free to come on IRC and ask me more |
| 13:39:47 | <tobin_g> dkayiwa: that's all fantastic. |
| 13:40:30 | <tobin_g> dkayiwa: yonatan was concerned that a lot of design had been changed after the start of the sprint. seems that it was just this issue of appointment_status, what's your thought? are we making an abnormal amount of change? |
| 13:40:49 | <tobin_g> dkayiwa: good to know for future sprint planning. |
| 13:41:40 | <dkayiwa> tobin_g: as far as i know, only one table changed. and that happens to all of us when developing. we all never know some details until along the way |
| 13:41:57 | <tobin_g> dkayiwa: k. |
| 13:42:02 | <dkayiwa> tobin_g: ofcourse we try eliminate that as much as we can, but in reality, its never a perfect world |
| 13:42:11 | <tobin_g> dkayiwa: so true |
| 13:42:15 | <dkayiwa> tobin_g: so solution is being ready for changes as you move along |
| 13:42:30 | <tobin_g> dkayiwa: i think it's a good lesson |
| 13:43:01 | <dkayiwa> tobin_g: so the lesson to him is to be ready to adjust to changes |
| 13:43:07 | <dkayiwa> tobin_g: and always plan for them :) |
| 13:43:57 | <tobin_g> dkayiwa: i'm just looking over tickets. should we wait for the guys to finish what they've got before assigning further? |
| 13:44:38 | <dkayiwa> tobin_g: yes they should each have one ticket at a time |
| 13:44:46 | <tobin_g> dkayiwa: sounds good |
| 13:45:02 | <dkayiwa> tobin_g: until when they move the ticket to review state, where they wait for the ticket to be reviewed. |
| 13:45:19 | *** kishoreyekkanti has quit IRC |
| 13:45:21 | <tobin_g> dkayiwa: gotcha. assume you'll do code review? |
| 13:45:25 | *** Antony has quit IRC |
| 13:45:31 | <dkayiwa> tobin_g: yes :) |
| 13:45:43 | <tobin_g> dkayiwa: excellent |
| 13:46:18 | <tobin_g> dkayiwa: have you managed to find some things to keep you busy since we're demanding less of your time than expected? |
| 13:46:46 | <dkayiwa> tobin_g: there is always plenty of openmrs tickets to work on :) |
| 13:46:55 | <tobin_g> dkayiwa: so true |
| 13:47:22 | <tobin_g> dkayiwa: unless anything else comes to mind I think i'll let you get to it! |
| 13:47:43 | <dkayiwa> tobin_g: sure thanks! :) |
| 13:47:54 | <tobin_g> dkayiwa: thanks talk to you late ron |
| 13:48:34 | <dkayiwa> tobin_g: see ya! |
| 13:50:03 | *** tobin_g has quit IRC |
| 14:02:15 | *** mogoodrich_ has joined #openmrs |
| 14:05:07 | *** rubailly has joined #openmrs |
| 14:08:47 | *** fishandwalk has quit IRC |
| 14:58:18 | *** sgithens has quit IRC |
| 15:00:14 | *** cpower has joined #openmrs |
| 15:00:34 | <cpower> Hello! |
| 15:01:38 | <rafa> cpower: hi |
| 15:01:52 | *** djazayeri has joined #openmrs |
| 15:01:52 | *** ChanServ sets mode: +o djazayeri |
| 15:01:56 | *** andrea__ has joined #openmrs |
| 15:02:54 | <andrea__> cpower, good morning |
| 15:03:45 | <djazayeri> good morning all |
| 15:04:23 | <andrea__> djazayeri, hi |
| 15:04:59 | *** jkeiper has joined #openmrs |
| 15:04:59 | *** ChanServ sets mode: +v jkeiper |
| 15:05:03 | <cpower> sorry for the delay, let's scrum! |
| 15:05:10 | <cpower> !scrumon cjpower |
| 15:05:10 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cjpower- you may begin when ready. |
| 15:06:46 | <cpower> Order: djazayeri, rafa, suranga, andrea__, dkayiwa, anyone working on the visiting or Queueing team, wyclif |
| 15:07:01 | <djazayeri> Yesterday and Today: |
| 15:07:04 | <djazayeri> * Mirebalais work |
| 15:07:06 | <djazayeri> * Catch up on emails |
| 15:07:24 | <djazayeri> (Working with Alex on question-per-screen form approach) |
| 15:07:25 | <djazayeri> no blockers |
| 15:07:38 | <rafa> Today: |
| 15:07:38 | <rafa> * Reviewed a few pull requests. |
| 15:07:38 | <rafa> * More work on the hibernate-search branch (tested with the MVP dict). |
| 15:07:38 | <rafa> * Now trying to make the CI green for the MDS module. |
| 15:07:38 | <rafa> No blockers.\ |
| 15:08:31 | <suranga> hi |
| 15:08:32 | *** wyclig_ has quit IRC |
| 15:08:40 | <suranga> DID : |
| 15:08:40 | <suranga> https://tickets.openmrs.org/browse/HLQRY-58 |
| 15:08:51 | <suranga> sent pull request for rafa to review :-) |
| 15:08:56 | *** wyclif_ has joined #openmrs |
| 15:09:03 | <suranga> To DO : more tickets |
| 15:09:07 | <suranga> NO blockers |
| 15:09:08 | *** lh has joined #openmrs |
| 15:09:34 | <andrea__> Monday |
| 15:09:35 | <andrea__> TRUNK-3474 |
| 15:09:35 | <andrea__> Completely removed attribute not-null="false" from Hibernate mapping files |
| 15:09:35 | <andrea__> because the default is false. |
| 15:09:35 | <andrea__> committed/pushed |
| 15:09:35 | <andrea__> Atlas Module |
| 15:09:37 | <andrea__> skyped/used team viewer to discuss Atlas Module with Wyclif. |
| 15:09:41 | <andrea__> Looked at tickets Atlas-43, Atlas-45 |
| 15:09:43 | <andrea__> Read Atlas module documentation |
| 15:09:45 | <andrea__> Tuesday |
| 15:09:47 | <andrea__> Atlas Module |
| 15:09:49 | <andrea__> skype/use team viewer to discuss Atlas Module with Wyclif. |
| 15:09:51 | <andrea__> Work on tickets Atlas-43, Atlas-45 |
| 15:09:53 | <andrea__> No blockers |
| 15:10:05 | <dkayiwa> Had training session with Tobins Dev Team |
| 15:10:05 | <dkayiwa> Reviewed and applied patch for: Remove Null Pointer Exception when try to see create new patient page without any input parameters - XFRM-93 |
| 15:10:05 | <dkayiwa> Committed: Unit tests failing with JDK 1.7 - TRUNK-3142 |
| 15:10:05 | <dkayiwa> Now working on: @StartModule does not work - TRUNK-3508 |
| 15:10:06 | <dkayiwa> No Blockers |
| 15:11:13 | <wyclif_> Monday: |
| 15:11:13 | <wyclif_> Discussion with Lauren and Jer in relation to TRUNK-3593 proposed concept queue |
| 15:11:13 | <wyclif_> Worked on avoiding multiple synonyms for TRUNK-3593 proposed concept queue |
| 15:11:13 | <wyclif_> Getting andrea started with pair programming tools |
| 15:11:13 | <wyclif_> Paired with andrea to investigate/reproduce ATLAS-43 and ATLAS-45 but ran into another bug |
| 15:11:14 | <wyclif_> Reviewed tickets: |
| 15:11:16 | <wyclif_> TRUNK-3293 - Add error checking to relationship start/end dates on patient dashboard |
| 15:11:18 | <wyclif_> TRUNK-2651 - Ugly stacktrace when trying to upload a non-image file as a complex obs with the ImageHandler |
| 15:11:21 | <wyclif_> |
| 15:11:23 | <wyclif_> Tuesday: |
| 15:11:25 | <wyclif_> Complete work on TRUNK-3593 proposed concept queue |
| 15:11:27 | <wyclif_> investigate atlas issues and pair with Andrea to work on them |
| 15:11:29 | <wyclif_> Code reviews and applying pull requests |
| 15:11:31 | <wyclif_> |
| 15:11:33 | <wyclif_> Blockers: None |
| 15:13:08 | <cpower> dkayiwa how is the Isreal group doing? |
| 15:13:08 | *** mogoodrich_ has quit IRC |
| 15:13:26 | <andrea__> cpower, I have a question |
| 15:13:34 | <dkayiwa> cpower: so far one guy (Yonatan) is the one doing the actual coding :) |
| 15:13:44 | <dkayiwa> cpower: but he is doing fairly well |
| 15:14:26 | <cpower> That's good news, could you use andrea__ if her time opens up or do you want to stay focused with the team you have? |
| 15:14:29 | *** mogoodrich_ has joined #openmrs |
| 15:14:36 | <cpower> andrea__ go for it ask away |
| 15:15:03 | <andrea__> TRUNK-3474 |
| 15:15:03 | <andrea__> Completely removed attribute not-null="false" from Hibernate mapping files |
| 15:15:03 | <andrea__> because the default is false. |
| 15:15:03 | <andrea__> committed/pushed |
| 15:15:21 | <andrea__> cpower, do I need another request code review? |
| 15:16:03 | <dkayiwa> cpower: was that for me? :) |
| 15:16:26 | <cpower> dkayiwa, my question if you could use andrea__ was to you |
| 15:16:44 | <dkayiwa> cpower: oh yes that would be welcome!!! |
| 15:16:58 | *** lh has quit IRC |
| 15:17:03 | <cpower> andrea__ I'm going to pass your question over to djazayeri, Darius can you answer andrea__ question |
| 15:17:04 | <cpower> ? |
| 15:17:14 | <dkayiwa> cpower: although you would need to first ask the Tobin Team first |
| 15:17:15 | <djazayeri> andrea__: typically if you're making changes in response to a code review, (assuming you're working in a branch) you should push the changes (to your branch), and then comment on the ticket or pull request saying that you've made a followup commit. |
| 15:17:29 | <djazayeri> dkayiwa: aren't you/they currently blocked on design issues? |
| 15:17:36 | <cpower> dkayiwa, of course just asking your opinion since you were here |
| 15:17:50 | <djazayeri> andrea__: and typically the original reviewer will do the followup review. |
| 15:17:56 | <dkayiwa> djazayeri: not at all. there is plenty to do that is not waiting for any design issues :) |
| 15:18:15 | <djazayeri> dkayiwa: okay |
| 15:18:34 | <dkayiwa> cpower: from what i perceive, they want to be the ones doing each and every ticket |
| 15:18:34 | <andrea__> djazayeri, ok thanks |
| 15:19:04 | *** mogoodrich_ has quit IRC |
| 15:19:10 | <dkayiwa> cpower: that is why i had to release the tickets i had claimed :) |
| 15:19:26 | <cpower> dkayiwa, just thinking out of the box. The students should do the work if they are able, I just hate leaving stuff hanging. |
| 15:19:58 | <dkayiwa> cpower: correct |
| 15:20:19 | *** mogoodrich_ has joined #openmrs |
| 15:20:35 | <cpower> andrea__, what's your estimate on the Atlas ticket tickets (aka when do you think you will be done with them?) |
| 15:20:49 | <djazayeri> cpower, dkayiwa: remember that this is only the first sprint on the appointment module |
| 15:20:50 | *** lh has joined #openmrs |
| 15:20:50 | *** lh has joined #openmrs |
| 15:20:57 | <djazayeri> and the goal is in fact capacity development |
| 15:21:05 | <dkayiwa> djazayeri: ok |
| 15:21:05 | <djazayeri> and we intend to have another sprint soon-ish with more people |
| 15:21:13 | <dkayiwa> djazayeri: ok |
| 15:22:26 | <cpower> djazayeri, understood from your persepective I wanted to get andrea__ toes wet in a current sprint as an extra set of hands if they are not needed she wouldn't be utilized. |
| 15:23:05 | <djazayeri> cpower: definitely worth considering |
| 15:23:34 | <cpower> djazayeri: and they seem to be consistently short a dev which was also the thought. |
| 15:24:11 | <cpower> andrea__, what's your estimate on the Atlas ticket tickets (aka when do you think you will be done with them?) |
| 15:24:37 | <suranga> rafa, thanks, that was very quick ! :-) |
| 15:24:58 | <rafa> suranga: you're welcome |
| 15:25:30 | <rafa> suranga: actually I'm sorry I forgot about it and you've just reminded me :D |
| 15:26:12 | <andrea__> cpower, sorry stepped away |
| 15:26:15 | <rafa> cpower: scrum off? |
| 15:26:32 | <cpower> yep sorry |
| 15:26:35 | <cpower> !scrumoff |
| 15:26:35 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:26:40 | <suranga> rafa, hmm.. but looking here, you seem to have reviewed an older pull ? https://github.com/openmrs/openmrs-module-hl7query/pulls |
| 15:26:42 | <andrea__> cpower, Wyclif and I need to skype again today |
| 15:26:44 | <OpenMRSBot> <http://ln-s.net/+By1> (at github.com) |
| 15:27:11 | <suranga> rafa, the most recent pull is "Authentication update" |
| 15:27:24 | <rafa> suranga: right... :D |
| 15:27:34 | <andrea__> cpower, haven't seen code yet , will let you know tomorrow |
| 15:27:38 | <rafa> suranga: it's the same branch, isn't it? |
| 15:27:59 | <suranga> rafa, yes, it seems all my latest changes are also included in what you reviewed... |
| 15:28:07 | <suranga> rafa, did git do that ? |
| 15:28:12 | <rafa> suranga: good |
| 15:28:17 | <cpower> wyclif_, do you have a rough estimate of time for the Atlas work you are handing over to andrea__? |
| 15:28:21 | <rafa> suranga: yes, github |
| 15:28:51 | <rafa> suranga: continue with any pull request you want |
| 15:28:55 | <rafa> suranga: close the other |
| 15:29:05 | <rafa> suranga: sorry for that |
| 15:29:30 | <suranga> rafa, so if i make the changes on top of this branch, then commit and pull it, I should be able to merge the latest (correct version) using that (latest ) pull ? :) |
| 15:29:58 | <wyclif_> cpower, i still need to investigate one small bug which i plan later to day and then see if we can do the tickets later today |
| 15:30:19 | <rafa> suranga: yes |
| 15:31:40 | <suranga> hhmmm... maybe git is cooler than I thought :P |
| 15:32:14 | <rafa> suranga: haha |
| 15:32:33 | <suranga> rafa, i've already stopped calling it gitbug :D |
| 15:33:15 | <rafa> suranga: that's a big progress |
| 15:34:02 | *** robbyoconnor has joined #openmrs |
| 15:34:02 | *** ChanServ sets mode: +v robbyoconnor |
| 15:34:36 | *** apb156 has joined #openmrs |
| 15:35:53 | *** dkayiwa has quit IRC |
| 15:37:37 | <apb156> Hey guys, I'm getting this error: http://listarchives.openmrs.org/Error-while-starting-OpenMRS-td7304298.html, BUT, the file path in my error is different |
| 15:38:00 | <apb156> It's: /home/tomcat6/.OpenMRS/openmrs-runtime.propertie |
| 15:38:44 | <apb156> Would this be an issue with an environment variable, or something else? |
| 15:42:35 | <rafa> apb156: the exact path may depend on how you install/start tomcat |
| 15:43:11 | <rafa> apb156: you just need to make sure the file is accessible or can be created there |
| 15:43:36 | *** sgithens has joined #openmrs |
| 15:44:10 | *** sunbiz has joined #openmrs |
| 15:44:10 | *** ChanServ sets mode: +v sunbiz |
| 15:45:07 | *** rafa has quit IRC |
| 15:45:41 | <apb156> rafa: Thanks, that makes sense. But the tomcat6 directory doesn't exist there |
| 15:46:15 | <apb156> rafa: I installed it through apt-get |
| 15:48:15 | *** sunbiz1 has joined #openmrs |
| 15:51:11 | *** sunbiz has quit IRC |
| 15:52:57 | *** kishoreyekkanti has joined #openmrs |
| 15:52:58 | *** mogoodrich_ has quit IRC |
| 15:53:46 | *** mogoodrich_ has joined #openmrs |
| 15:54:55 | *** apb156 has quit IRC |
| 15:55:16 | *** mogoodrich_ has quit IRC |
| 15:55:56 | *** mogoodrich_ has joined #openmrs |
| 15:57:41 | *** jkeiper has quit IRC |
| 16:02:46 | *** basic is now known as basic` |
| 16:02:46 | *** mogoodrich_ has quit IRC |
| 16:03:01 | *** apb156 has joined #openmrs |
| 16:03:32 | *** apb156 has left #openmrs |
| 16:03:39 | *** harshadura has quit IRC |
| 16:04:26 | *** mogoodrich_ has joined #openmrs |
| 16:05:26 | *** mogoodrich_ has quit IRC |
| 16:06:08 | <shangxiao> djazayeri: thanks for pointing out how the test works - I was wondering where that data came from ... |
| 16:06:21 | *** mogoodrich_ has joined #openmrs |
| 16:07:33 | * shangxiao rewards djazzy with an ice cream |
| 16:08:21 | *** mogoodrich_ has quit IRC |
| 16:10:06 | *** mogoodrich_ has joined #openmrs |
| 16:10:07 | *** shangxiao has quit IRC |
| 16:10:13 | *** mogoodrich_ has quit IRC |
| 16:10:46 | *** mogoodrich_ has joined #openmrs |
| 16:11:21 | *** dkayiwa has joined #openmrs |
| 16:11:34 | *** mogoodrich_ has quit IRC |
| 16:13:36 | *** mogoodrich_ has joined #openmrs |
| 16:15:06 | *** mogoodrich_ has quit IRC |
| 16:16:04 | *** suranga has quit IRC |
| 16:26:49 | <cpower> dkayiwa, so do you have work to keep you busy while the Israel group figures out what they are doing? |
| 16:27:03 | <dkayiwa> cpower: yes :) |
| 16:27:08 | <cpower> ok |
| 16:27:52 | <cpower> So anyone: Help me understand how a newbie would start working on !trunk-1801 ? |
| 16:28:53 | <cpower> I see a description that doesn't tell me much, and I'm not sure it would help a newbie get their feet wet. |
| 16:29:56 | <dkayiwa> !ticket trunk-1801 |
| 16:29:57 | <OpenMRSBot> dkayiwa: [#TRUNK-1801] Move the form schema viewer from htmlformentry into core - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-1801 |
| 16:31:27 | <cpower> My goal here is that I have the impression that our intro tickets are not getting designed well enough for newbies to actually do them. This is the first one I've looked at, and I'm getting the feeling I'm right. |
| 16:32:36 | *** sgithens has quit IRC |
| 16:34:32 | <dkayiwa> cpower: you are right on this ;) |
| 16:57:39 | *** AdamLauz has joined #openmrs |
| 17:11:06 | *** andrea__ has quit IRC |
| 17:15:10 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 2.3 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=uiframework&version=&2.3> || OpenMRS Modules: HTML Form Entry 2.0.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=htmlformentry&version=&2.0.2> |
| 17:26:48 | <AdamLauz> dkayiwa: Hi Daniel how are you? |
| 17:26:58 | <dkayiwa> hi AdamLauz |
| 17:27:07 | <dkayiwa> AdamLauz: am doing fine. and you? |
| 17:28:40 | <AdamLauz> dkayiwa: great |
| 17:29:00 | *** shangxiao has joined #openmrs |
| 17:29:16 | <AdamLauz> dkayiwa: I will start working on the AM-3 ticket and I wanted to ask from where I should begin? I mean from the api or the ui? |
| 17:29:31 | <shangxiao> From both :D |
| 17:30:11 | <dkayiwa> AdamLauz: you can begin from the UI :) |
| 17:30:24 | <shangxiao> If you aren't using any mocks for testing then you'd need to do the api first? |
| 17:31:11 | <AdamLauz> dkayiwa: I have mocks prepared for this... I thought that way I will now what I need from the api |
| 17:31:33 | <AdamLauz> know* |
| 17:32:00 | <dkayiwa> AdamLauz: although you are free to chose where to start from |
| 17:32:12 | <dkayiwa> AdamLauz: if you wanna start from the API, that will be fine too |
| 17:32:36 | <dkayiwa> AdamLauz: either way works. all i want is you to choose what will excite you :) |
| 17:33:02 | <shangxiao> lol |
| 17:33:08 | <shangxiao> exciting... |
| 17:33:22 | <AdamLauz> dkayiwa: OK, thanks :) lol very exciting |
| 17:33:47 | <dkayiwa> shangxiao: without work being exciting, one may stop programming and go fishing :) |
| 17:35:27 | *** sgithens has joined #openmrs |
| 17:38:32 | <shangxiao> dkayiwa: ;) |
| 17:38:40 | <shangxiao> fishing... now there's a good idea |
| 17:39:06 | <dkayiwa> shangxiao: more so when you are a vegetarian :0 |
| 17:39:08 | <dkayiwa> :) |
| 17:39:49 | <shangxiao> that's ok just throw some vegetables in the river and try to get it out with the fishing hook |
| 17:40:17 | *** robbyoconnor has quit IRC |
| 17:40:32 | <dkayiwa> shangxiao: loooooooolllll :D |
| 17:40:43 | *** robbyoconnor has joined #openmrs |
| 17:40:43 | *** ChanServ sets mode: +v robbyoconnor |
| 17:41:41 | *** tobin_g has joined #openmrs |
| 17:45:08 | *** sunbiz1 has left #openmrs |
| 17:45:44 | *** jkeiper has joined #openmrs |
| 17:45:44 | *** ChanServ sets mode: +v jkeiper |
| 17:46:07 | *** tobin_g has quit IRC |
| 17:49:34 | *** robbyoconnor has quit IRC |
| 17:51:35 | *** tobin_g has joined #openmrs |
| 17:58:31 | <djazayeri> dkayiwa: AdamLauz, not speaking to AM-3 specifically, but on almost every ticket, you should start by developing the API, following test-driven-development practices |
| 17:58:41 | <djazayeri> or rather behavior-driven development practices |
| 17:59:12 | <djazayeri> dkayiwa, AdamLauz: after the API is behaving the way you want and it supports the method calls you need, *then* you implement the UI. |
| 18:00:05 | <dkayiwa> djazayeri: ok |
| 18:00:10 | <AdamLauz> djazayeri: ok |
| 18:03:01 | *** robbyoconnor has joined #openmrs |
| 18:03:01 | *** ChanServ sets mode: +v robbyoconnor |
| 18:03:55 | <AdamLauz> dkayiwa: There will be only one service class right? I mean only AppointmentService.java |
| 18:04:18 | <dkayiwa> AdamLauz: yes for now |
| 18:05:39 | *** tobin_g has quit IRC |
| 18:22:56 | *** suranga has joined #openmrs |
| 18:22:56 | *** ChanServ sets mode: +v suranga |
| 18:32:36 | <AdamLauz> dkayiwa: HibernateAppointmentTypeDAO.java is not used right? I should update only the HibernateAppointmentServiceDAO.java? |
| 18:33:07 | <dkayiwa> AdamLauz: HibernateAppointmentTypeDAO is used |
| 18:33:22 | <dkayiwa> AdamLauz: did you do a git pull? |
| 18:33:55 | <AdamLauz> dkayiwa: ok so i should create one for AppointmentBlock right? HibernateAppointmentBlockDAO? |
| 18:34:06 | <AdamLauz> dkayiwa: Yes I did |
| 18:34:18 | <dkayiwa> AdamLauz: yes |
| 18:35:27 | <AdamLauz> dkayiwa: I'm asking because it doesn't contains much code except of "super(AppointmentType.class);" |
| 18:35:41 | <AdamLauz> in the builder method |
| 18:36:02 | <dkayiwa> AdamLauz: correct. more code will possibly be added as we move on |
| 18:36:07 | *** Antony has joined #openmrs |
| 18:37:20 | <AdamLauz> dkayiwa: OK can I ask why do we need that one? after all we can use HibernateAppointmentServiceDAO.java alone right? |
| 18:37:21 | <djazayeri> AdamLauz: doesn't it extend a superclass though? and that's where its functionality comes from? |
| 18:37:49 | <AdamLauz> djazayeri: yes that's correct but I just don't understand the uses of it |
| 18:38:01 | <AdamLauz> djazayeri: I mean right now |
| 18:38:34 | <dkayiwa> AdamLauz: after a refactoring suggestion, we are going to have a data access interface to each resource (domain object) |
| 18:38:36 | <djazayeri> AdamLauz: I haven't looked at the code, so I'll let dkayiwa answer that. |
| 18:38:39 | <AdamLauz> djazayeri: OK my mistake I see that HibernateSingleClassDAO is generic type |
| 18:39:22 | <AdamLauz> djazayeri: It extends the HibernateSingleClassDAO class and it functionality is generic type T |
| 18:39:32 | <AdamLauz> djazayeri: sorry :) |
| 18:40:26 | *** yony258 has joined #openmrs |
| 18:40:33 | <yony258> dkayiwa: Hi |
| 18:40:39 | <dkayiwa> yony258: hi |
| 18:40:59 | <yony258> dkayiwa: I think we maybe missed a field of Appointment_Type :/ |
| 18:41:07 | <AdamLauz> dkayiwa: OK |
| 18:41:11 | <dkayiwa> yony258: which field? |
| 18:41:46 | <yony258> dkayiwa: INT duration |
| 18:41:57 | <dkayiwa> yony258: oh yes :) |
| 18:42:08 | <yony258> dkayiwa: ;) |
| 18:42:26 | <dkayiwa> yony258: good catch :) |
| 18:42:52 | *** robbyoconnor has quit IRC |
| 18:43:16 | *** kishoreyekkanti has quit IRC |
| 18:43:18 | *** robbyoconnor has joined #openmrs |
| 18:43:19 | *** ChanServ sets mode: +v robbyoconnor |
| 18:50:30 | *** rubailly has quit IRC |
| 18:53:10 | <yony258> dkayiwa: Updated the full model at ticket AM-11 |
| 18:53:20 | <yony258> https://tickets.openmrs.org/browse/AM-11#comment-192959 |
| 18:53:29 | <dkayiwa> yony258: yes just seen it. thanks :) |
| 18:53:57 | <yony258> dkayiwa: Ok now I'll start doing the mapping files. |
| 18:54:05 | <dkayiwa> yony258: ok |
| 19:06:17 | <yony258> dkayiwa: I got some questions :] |
| 19:06:22 | <yony258> dkayiwa: Really basic ones |
| 19:06:38 | <dkayiwa> yony258: ok |
| 19:07:34 | <yony258> dkayiwa: I want to map the appointment block class to its table. I need to add the attributes to the AppointmentBlock.java file, is there anything else I need to add except of get and set methods for each attribute? |
| 19:08:18 | <dkayiwa> yony258: thats should be all for now |
| 19:08:51 | <yony258> dkayiwa: Ok one more, for the DateTime table fields, I use java.util.Date right? |
| 19:09:26 | <dkayiwa> yony258: yes |
| 19:09:32 | <yony258> dkayiwa: Great, Thanks |
| 19:09:56 | <AdamLauz> dkayiwa: I think I'm done with the java files in the api but I didn't do any tests. Do you want me to push the changes so you can check if i did it right? |
| 19:10:57 | <dkayiwa> AdamLauz: ok i can have a look at them |
| 19:11:14 | <AdamLauz> dkayiwa: Ok just a second |
| 19:11:20 | <yony258> dkayiwa: Why doesn't the AppointmentType.java file have any of the convention attributes? (uuid, creator...) ? |
| 19:11:49 | <dkayiwa> yony258: they are in the base classes |
| 19:12:05 | <yony258> dkayiwa: And what about the AppointmentType name? |
| 19:12:25 | <dkayiwa> yony258: it is also in a base class |
| 19:12:51 | <yony258> dkayiwa: How can I know then what to add and what already is in the base class? |
| 19:13:39 | <dkayiwa> yony258: you can just look at the base classes. and only add what is not there |
| 19:15:15 | <yony258> dkayiwa: Where is the BaseOpenmrsData located? |
| 19:15:31 | <dkayiwa> yony258: in openmrs-core |
| 19:15:38 | <dkayiwa> yony258: do you have it checked out? |
| 19:16:13 | <yony258> dkayiwa: Yes. But I cant find the name property |
| 19:17:25 | <yony258> dkayiwa: Oh its in MetaData. |
| 19:17:50 | <yony258> dkayiwa: Ok one more thing. In appointment block class, instead of INT provider_id I add private Provider provider ? |
| 19:18:46 | <dkayiwa> yony258: yes add Provider provider |
| 19:19:18 | <yony258> dkayiwa: Great ;) |
| 19:27:00 | <yony258> dkayiwa: Why do we write on hibernate mapping the length of a Date type? |
| 19:30:57 | <dkayiwa> yony258: as far as i can tell, it is optional :) |
| 19:31:24 | <yony258> dkayiwa: Ok and im now trying to map the Provider provider, let me write down what im planning to write let me know if its right |
| 19:31:58 | <dkayiwa> yony258: ok |
| 19:34:16 | <yony258> dkayiwa: <many-to-one name="provider" column="provider_id" class="org.openmrs.Provider" not-null="true" /> |
| 19:34:44 | *** robbyoconnor has quit IRC |
| 19:35:07 | <dkayiwa> yony258: The length attribute is used by the DDL generation tool to generate a script with the corresponding columns size. That's all. |
| 19:36:08 | <dkayiwa> yony258: perfect! :) |
| 19:36:14 | *** shangxiao has quit IRC |
| 19:37:06 | <yony258> dkayiwa: Great, can I just write class="Provider"? or do I have to add "org.openmrs.Provider" ? |
| 19:38:18 | <dkayiwa> yony258: because your package="org.openmrs.module.appointment", then you need to fully qualify provider since it does not belong to the same package |
| 19:38:30 | <yony258> dkayiwa: Got it, thanks. |
| 19:38:51 | *** Antony has quit IRC |
| 19:39:04 | <yony258> dkayiwa: Ok so I want to send you the java file and the hbm.xml file for a sort review, is that ok? |
| 19:39:42 | *** tobin_g has joined #openmrs |
| 19:40:11 | <dkayiwa> yony258: yes push them |
| 19:42:18 | <yony258> dkayiwa: Ok done |
| 19:42:41 | <dkayiwa> yony258: ok looking |
| 19:43:45 | *** andreap_ has joined #openmrs |
| 19:45:12 | <yony258> dkayiwa: Ok I have some updates to do, change retire to void and retired to voided on the column name |
| 19:45:21 | <yony258> But except of that? |
| 19:45:31 | <dkayiwa> yony258: was just about to say that :) |
| 19:45:49 | <dkayiwa> yony258: and datevoided to dateVoided |
| 19:46:27 | *** andrea has joined #openmrs |
| 19:46:51 | *** andrea is now known as Guest38405 |
| 19:47:07 | <dkayiwa> yony258: looks fine. are you using the openmrs code formatter? |
| 19:47:08 | *** Guest38405 is now known as andrea_p |
| 19:47:16 | <yony258> dkayiwa: Nope, what is that? |
| 19:48:20 | <dkayiwa> yony258: https://wiki.openmrs.org/display/docs/Coding+Conventions |
| 19:48:31 | <dkayiwa> yony258: under Code Style |
| 19:49:47 | <yony258> dkayiwa: Great. |
| 19:51:36 | *** tobin_g has quit IRC |
| 19:56:03 | <yony258> dkayiwa: Ok another question :) |
| 19:56:36 | <yony258> dkayiwa: We have one to many on appointment slot to appointment |
| 19:57:00 | <yony258> dkayiwa: Do we want to have List or something like that of appointments on TimeSlot.java ? |
| 19:57:39 | <dkayiwa> yony258: i do not think so |
| 19:57:41 | <yony258> dkayiwa: I mean we will defiantly need to know what appointments are on a specific slot. |
| 19:57:50 | <yony258> dkayiwa: So we will just run a query? |
| 19:58:03 | <dkayiwa> yony258: each appointment has one time slot. correct? |
| 19:58:09 | <yony258> dkayiwa: correct |
| 19:58:34 | <dkayiwa> yony258: so then it will have just a time slot instead of a list of them |
| 19:59:00 | <yony258> dkayiwa: Ok so we will run a query in order to find all the appointments in a specific slot right? |
| 19:59:24 | <dkayiwa> yony258: can you have more than one appointment in the same time slot? |
| 19:59:29 | <yony258> dkayiwa: Yes |
| 19:59:40 | <dkayiwa> yony258: ok |
| 20:00:25 | <yony258> dkayiwa: So what is the answer? |
| 20:00:48 | <dkayiwa> yony258: yes will run a query |
| 20:00:48 | <AdamLauz> dkayiwa: Did you see my commit? apperently someting got wrong with my push |
| 20:00:57 | <yony258> dkayiwa: I didn't |
| 20:00:58 | <dkayiwa> AdamLauz: not seen it yet |
| 20:01:50 | <yony258> AdamLauz: you did a Merge |
| 20:01:57 | <AdamLauz> dkayiwa: ok If you will be free check it out |
| 20:02:11 | <yony258> https://github.com/openmrs/openmrs-module-appointment/commit/41ef2c6be2852b0c1775729972ee5e1df5c858ef |
| 20:02:14 | <OpenMRSBot> <http://ln-s.net/+C4_> (at github.com) |
| 20:02:25 | <AdamLauz> yony258: Yes I did that by a mistake because it told me to do pull before the push |
| 20:02:43 | <AdamLauz> https://github.com/openmrs/openmrs-module-appointment/commit/35b8188c2fb517e8b2949ceb6c6752f2627b4b52 |
| 20:02:46 | <OpenMRSBot> <http://ln-s.net/+C4a> (at github.com) |
| 20:02:53 | <AdamLauz> that one is my commit |
| 20:03:26 | <dkayiwa> AdamLauz: looking at it now |
| 20:04:44 | <dkayiwa> AdamLauz: are you also using the openmrs code formatter? |
| 20:05:25 | <AdamLauz> dkayiwa: what is that? |
| 20:05:38 | <dkayiwa> AdamLauz: yony258 can explain it to you |
| 20:06:06 | <AdamLauz> yony258: What is openmrs code formatter? |
| 20:07:58 | <AdamLauz> dkayiwa: anyway I don't know if that is what I supposed to do.. I hope it's fine |
| 20:08:31 | <dkayiwa> AdamLauz: https://wiki.openmrs.org/display/docs/Coding+Conventions |
| 20:08:40 | <dkayiwa> AdamLauz: under Code Style |
| 20:13:19 | <AdamLauz> dkayiwa: I see |
| 20:13:49 | <AdamLauz> dkayiwa: I will use it from now :) |
| 20:13:58 | <andrea_p> wyclif_: u around? |
| 20:14:04 | <dkayiwa> AdamLauz: ok great :) |
| 20:14:14 | <wyclif_> andrea_p, yeah |
| 20:14:30 | <wyclif_> but i wont be available for the next 1hr, is that fine with you |
| 20:14:43 | <wyclif_> andrea_p, but i wont be available for the next 1hr, is that fine with you |
| 20:14:51 | <yony258> dkayiwa: Do I need to create constructors for each class too? |
| 20:14:59 | <wyclif_> andrea_p, i will be onlie but still finishing up somethin else |
| 20:15:14 | <dkayiwa> AdamLauz: did you add methods to the HibernateAppointmentServiceDAO? |
| 20:16:20 | <AdamLauz> dkayiwa: Yes |
| 20:16:23 | <andrea_p> wyclif_: ok, let me know when you want to discuss Atlas module further |
| 20:16:34 | <wyclif_> andrea_p, sure i will |
| 20:16:43 | <dkayiwa> yony258: we shall be adding some constructors later on for conveniently creating these objects |
| 20:16:43 | <AdamLauz> dkayiwa: I wasn't supposed to do that? |
| 20:16:57 | <dkayiwa> yony258: so for now you can leave as is |
| 20:17:30 | <dkayiwa> AdamLauz: you were not supposed to :) |
| 20:18:07 | <AdamLauz> dkayiwa: why? |
| 20:18:08 | <yony258> dkayiwa: Ok so for example for the name property on AppointmentStatus I dont even need to create get and set method and no need to write that as a property since it exists at the parent classes correct? |
| 20:18:31 | <dkayiwa> AdamLauz: because you already have the HibernateAppointmentBlockDAO which has all you needed |
| 20:19:00 | <dkayiwa> yony258: perfect :) |
| 20:19:17 | <yony258> dkayiwa: Great just why doesn't the name mapping have any column? |
| 20:19:18 | <AdamLauz> dkayiwa: I see... I wasn't sure about that... so there is no need for the ServiceDAO? |
| 20:19:44 | <dkayiwa> yony258: for which object? |
| 20:19:55 | <yony258> dkayiwa: AppointmentType |
| 20:20:05 | <dkayiwa> AdamLauz: not need for what you are doing |
| 20:20:33 | <dkayiwa> yony258: in the hibernate mapping file? |
| 20:20:41 | <yony258> dkayiwa: Yes |
| 20:20:51 | <AdamLauz> dkayiwa: So why there are AppointmentType methods impelemented in there? |
| 20:21:25 | <dkayiwa> yony258: when the database column name is the same as the java object property name, then it is optional |
| 20:21:43 | <yony258> dkayiwa: Oh ok :] |
| 20:22:16 | <dkayiwa> AdamLauz: i just forgot to delete them after the refactoring suggestion. sorry for the confusion. just go ahead and remove all of them |
| 20:22:40 | <AdamLauz> dkayiwa: ok now it makes since for me |
| 20:22:56 | <AdamLauz> sense* |
| 20:23:01 | <dkayiwa> AdamLauz: yony258 i can see you guys are not easy to cheat!!! :D |
| 20:23:26 | <yony258> dkayiwa: Hmm hope its a good thing :) |
| 20:23:44 | <dkayiwa> yony258: oh yess!!! :) |
| 20:24:07 | <dkayiwa> yony258: AdamLauz you are asking very intelligent questions :) |
| 20:24:43 | <yony258> dkayiwa: lol, Great, now I finished everything except of the Link Tables mapping which I dont really sure how to do. But I have an idea how to do that let me check it with you |
| 20:25:05 | <yony258> dkayiwa: Actually nevermind, can you guide me how to do that ? I mean the block_type_map and the appointment_status_map |
| 20:25:52 | <dkayiwa> yony258: feel free to try out what you think. do not fear to make mistakes. you learn better that way :) |
| 20:26:20 | <yony258> dkayiwa: Well I have only part of the solution, I dont really understand how hibernate map this kind of stuff |
| 20:26:55 | <yony258> dkayiwa: I was thinking, for example block_type_map, creating a list of types in AppointmentBlock and map it using a tutorial I found to map Lists |
| 20:27:00 | <dkayiwa> yony258: do you have the openmrs-core checked out? there many such examples i can point you to |
| 20:27:06 | <yony258> dkayiwa: Sure |
| 20:27:43 | <AdamLauz> dkayiwa: Do you think I need to add something to the ApooitnmentBlockValidator? I mean I understood that there is no "name" attribute for AppointmentBlock |
| 20:28:50 | <dkayiwa> AdamLauz: we shall add some validations for appointment blocks, latter |
| 20:29:38 | <AdamLauz> dkayiwa: ok so what you think I should do for now? Do I need to fix something else on what I did? |
| 20:30:10 | <dkayiwa> AdamLauz: delete the mothods in the serviceDao |
| 20:30:28 | <dkayiwa> AdamLauz: the start writing some unit tests |
| 20:33:59 | *** cpower has quit IRC |
| 20:36:25 | <wyclif_> andrea_p, in the meantime can you try to fix you mic when using it with skype |
| 20:38:15 | <dkayiwa> yony258: you will not create a hibernate mapping file for block_type_map |
| 20:38:36 | <dkayiwa> yony258: you will not even create a domain object for the relationship(mapping) |
| 20:38:51 | <yony258> dkayiwa: So what am I going to create? |
| 20:39:23 | <dkayiwa> yony258: you are going to add a types property to the appointment block object |
| 20:40:09 | <dkayiwa> yony258: e.g: private Collection<AppointmentType> types |
| 20:40:25 | <yony258> dkayiwa: Ok 2 Questions |
| 20:40:46 | <dkayiwa> yony258: and then you add it to the hibernate mapping file for appointment block |
| 20:41:06 | <yony258> dkayiwa: 1. How will hibernate will know how to do that? what do I specify in the hbm.xml file? |
| 20:41:32 | <yony258> dkayiwa: 2. How do I do it with appointment_status_map since this Link Table has other attributes too |
| 20:43:02 | <dkayiwa> yony258: something like this in the appointment block hibernate mapping file: |
| 20:43:03 | <dkayiwa> <set name="types" table="appointment_block_type_map" cascade="save-update"> |
| 20:43:04 | <dkayiwa> <key column="appointment_block_id"/> |
| 20:43:04 | <dkayiwa> <many-to-many class="AppointmentType" column="appintment_type_id"/> |
| 20:43:04 | <dkayiwa> </set> |
| 20:44:26 | <dkayiwa> yony258: by the way, did you look at the shorter version table names Burke sent on the dev list? |
| 20:45:00 | <yony258> dkayiwa: No let me check that. But I still didn't understood the solution. |
| 20:45:12 | <yony258> dkayiwa: Can you please explain the meaning of the different parts? |
| 20:45:36 | <dkayiwa> for the java property? |
| 20:45:57 | <yony258> dkayiwa: all of that xml block |
| 20:46:41 | <dkayiwa> yony258: it tells hibernate to populate the types java property from the appointment_block_type_map table |
| 20:47:22 | <dkayiwa> yony258: it also tells it that this is a many to many relationship between appointment block and appointment types |
| 20:48:14 | <yony258> Ok, and what about the appointment_status_map |
| 20:48:24 | <yony258> That have association fields |
| 20:48:57 | <dkayiwa> yony258: we shall do that a bit different |
| 20:49:47 | <dkayiwa> yony258: first finish the one for types in appointment block, and then we shall get to that :) |
| 20:49:49 | *** tobin_g has joined #openmrs |
| 20:51:39 | <dkayiwa> yony258: so are you going to rename the tables as per Burke's email? |
| 20:53:37 | <yony258> dkayiwa: what does the <key column="appointment_block_id"/> says? |
| 20:53:57 | <dkayiwa> yony258: also for the appointment_block_type table, you will remove all columns apart from only two (appointment_block_Id, appointment_type_id) |
| 20:54:15 | <yony258> dkayiwa: Yea ill change it, and ok |
| 20:54:37 | *** AdamLauz has quit IRC |
| 20:55:08 | <dkayiwa> yony258: it means that in the mapping table (appointment_block_type_map), each appointment block is going to be referenced by the appointment_block_id column |
| 20:55:40 | <yony258> dkayiwa: Got it!, changing to what Burke said. |
| 20:55:50 | <dkayiwa> yony258: excellent |
| 20:58:41 | <yony258> dkayiwa: Are we planning to remove the columns from appointment_status_map? |
| 20:59:16 | <yony258> dkayiwa: I mean the uuid, creator, etc.. |
| 20:59:24 | <dkayiwa> yony258: no |
| 21:00:25 | <yony258> dkayiwa: Why do we need the retired and such on that association table? |
| 21:01:12 | <dkayiwa> yony258: for that one, we shall concretize after tomorrow's design call :) |
| 21:01:13 | *** sgithens has quit IRC |
| 21:01:21 | <yony258> dkayiwa: ok |
| 21:01:23 | <dkayiwa> yony258: so just ignore it for now |
| 21:02:07 | <yony258> dkayiwa: By the way, if someone removes this module, do liquibase knows to remove the relevant tables as well? |
| 21:02:25 | <yony258> dkayiwa: Like a rollback or something like that? |
| 21:02:47 | <dkayiwa> yony258: no |
| 21:03:02 | <dkayiwa> yony258: you will need to manually remove them |
| 21:03:07 | <yony258> dkayiwa: We need to do that too then right? |
| 21:03:23 | <dkayiwa> yony258: yes manually |
| 21:03:31 | <yony258> dkayiwa: Cant we create something that will remove them on uninstall/ |
| 21:03:34 | <dkayiwa> yony258: we do not automate that |
| 21:03:50 | <dkayiwa> yony258: that would be dangerous to automate |
| 21:04:12 | <dkayiwa> yony258: a user accidentally uninstalling the module can lose data :( |
| 21:04:15 | <yony258> dkayiwa: Oh because if someone is planning to reinstall he can lose data? |
| 21:04:21 | <dkayiwa> yony258: yes |
| 21:04:23 | <yony258> dkayiwa: I see, right. |
| 21:06:14 | *** andreapat has joined #openmrs |
| 21:06:24 | <yony258> dkayiwa: Ok so except of the appointment_status_map Im done, let me push so you'll be able to review |
| 21:06:34 | <dkayiwa> yony258: ok |
| 21:07:07 | *** andrea_p has quit IRC |
| 21:07:20 | <yony258> dkayiwa: But we also need to update AppointmentType to include duration |
| 21:07:33 | <dkayiwa> yony258: yes add it |
| 21:12:12 | <dkayiwa> yony258: after you are done with all that, next step is add unit tests, service, and data access methods for the appointment resource (domain object) |
| 21:13:05 | <yony258> dkayiwa: Sounds good. Do you want me to update AppointmentType? |
| 21:13:13 | <dkayiwa> yony258: yes |
| 21:13:38 | <yony258> dkayiwa: I mean there will be need to change the form you did to support that too |
| 21:14:03 | <dkayiwa> yony258: am not sure i undertstand |
| 21:15:05 | <yony258> dkayiwa: You did all of the stuff related to appointmentType Form, and the different files we talked today's morning |
| 21:15:21 | <dkayiwa> yony258: yes |
| 21:15:28 | <yony258> dkayiwa: Those will need to be changed as well to include setting a duration for an appointment type, right? |
| 21:15:37 | <dkayiwa> yony258: and Adam has done some of it for the AppointmentBlock resource |
| 21:15:44 | <dkayiwa> yony258: yes |
| 21:15:57 | <yony258> dkayiwa: Am I supposed to do that now too? |
| 21:16:04 | <yony258> dkayiwa: or just update the hibernate mapping? |
| 21:16:08 | <dkayiwa> yony258: UI later |
| 21:16:58 | *** AdamLauz has joined #openmrs |
| 21:17:14 | <dkayiwa> AdamLauz: did you see my new comment in your commit? |
| 21:17:44 | <AdamLauz> dkayiwa: daniel I deleted the lines related to AppointmentBlock from the file AppointmentDAO |
| 21:18:25 | <dkayiwa> AdamLauz: i wrote another coment |
| 21:18:26 | <AdamLauz> dkayiwa: since AppointmentBlockDAO extends SingleClassDAO I don't have to write anything in that file right? |
| 21:19:09 | <yony258> dkayiwa: Alright pushed 2 updates: 1 is most of the mapping, the second is the duration property for AppointmentType |
| 21:19:18 | <dkayiwa> AdamLauz: correct |
| 21:19:31 | <dkayiwa> yony258: ok thanks |
| 21:20:14 | <yony258> dkayiwa: AdamLauz: Are we still planning to meet tomorrow morning at 10 AM (Ugandan Time) ? |
| 21:20:28 | <dkayiwa> yony258: AdamLauz yes |
| 21:20:41 | <yony258> dkayiwa: Great just wanted to make sure :). |
| 21:20:50 | <dkayiwa> yony258: :D |
| 21:22:32 | <tobin_g> yony258: AdamLauz dkayiwa I have to sign off, but thanks for all the great work! |
| 21:22:47 | <dkayiwa> tobin_g: sure thanks too |
| 21:23:02 | <AdamLauz> tobin_g: have a good night |
| 21:23:05 | <yony258> tobin_g: Have a good night |
| 21:23:12 | <AdamLauz> tobin_g: :) |
| 21:24:13 | <AdamLauz> dkayiwa: What was your other comment? about AppointmentBlock now having the "name" property? |
| 21:24:29 | <AdamLauz> dkayiwa: now ->*not |
| 21:25:00 | <dkayiwa> AdamLauz: remove the name validation since blocks have no names |
| 21:25:55 | *** tobin_g has quit IRC |
| 21:26:12 | <suranga> goodnight everyone, im off too :-) |
| 21:26:19 | *** suranga has quit IRC |
| 21:26:47 | <AdamLauz> dkayiwa: I can't remove the method validate(Object obj, Errors errors) though right? |
| 21:27:10 | <dkayiwa> AdamLauz: leave the method |
| 21:27:36 | <yony258> AdamLauz: Tomorrow we are going to speak for 30 minutes on the Design Call about the appointment_status idea, hopefully we will get approval to finish with that part. (Meeting starts at 9pm Israel Time, 10pm Ugandan Time) |
| 21:29:17 | <AdamLauz> yony258: OK hopefully we will get the approval and programm with a silence heart lol :) |
| 21:29:33 | <yony258> AdamLauz: Yea I know what you mean. |
| 21:30:12 | <yony258> dkayiwa: Should I wait while you reviewing it or do you plan to review it by tomorrow meeting? |
| 21:30:37 | <yony258> dkayiwa: I mean any option is good for me, dont want to keep you up its already late. |
| 21:30:44 | <dkayiwa> yony258: just proceed with the next work :) |
| 21:31:28 | <AdamLauz> dkayiwa: done with what you said... should I commit? |
| 21:31:41 | <dkayiwa> AdamLauz: yes |
| 21:34:44 | *** yony258 has quit IRC |
| 21:35:22 | *** yony258 has joined #openmrs |
| 21:36:25 | <yony258> dkayiwa: Ok so Im not going to start my next target since its already late and Im not really sure what is my next target. |
| 21:36:42 | <dkayiwa> yony258: ok no problem |
| 21:37:17 | <yony258> dkayiwa: I think Tobin said you got an idea about what I should do next? |
| 21:37:27 | <dkayiwa> yony258: yes |
| 21:37:36 | <yony258> dkayiwa: ? |
| 21:37:56 | <dkayiwa> yony258: you will be doing exactly what AdamLauz has done |
| 21:38:08 | <yony258> dkayiwa: Oh ok |
| 21:38:12 | <dkayiwa> yony258: but for the Appointment resource (domain object) |
| 21:38:23 | <yony258> dkayiwa: Great |
| 21:39:05 | <dkayiwa> yony258: including unit test for its service methids |
| 21:39:18 | <AdamLauz> dkayiwa: I commited... why it commits a Merge branch also? :/ |
| 21:39:19 | <dkayiwa> yony258: AdamLauz is just doing the unit tests next |
| 21:39:35 | <dkayiwa> AdamLauz: will look into that |
| 21:40:39 | <yony258> dkayiwa: AdamLauz: Cant compile module : "There are test failures." |
| 21:41:22 | <yony258> dkayiwa: AdamLauz: Failed Tests list: http://pastebin.com/wwwLsNTk |
| 21:41:36 | <dkayiwa> yony258: he will compile after he has finished his unit test |
| 21:42:18 | <yony258> dkayiwa: What do I need to do in order to compile and check if my part works? What do I need to comment out? |
| 21:43:02 | <dkayiwa> yony258: you just compile and try fix the failing tests |
| 21:45:56 | <AdamLauz> dkayiwa: I need to right unit test for all the methods in AppointmentService related to AppointmentBlock right? |
| 21:46:09 | <AdamLauz> dkayiwa: right - > write |
| 21:46:19 | <dkayiwa> AdamLauz: perfect |
| 21:47:47 | <yony258> dkayiwa: Alright, see you tomorrow at 10 am your time, im off to bed |
| 21:47:58 | <dkayiwa> yony258: see ya |
| 21:48:00 | <yony258> dkayiwa: Thank you |
| 21:48:07 | <dkayiwa> yony258: you too |
| 21:48:28 | <AdamLauz> dkayiwa: I will continue tomorrow :) see you at the meeting have a good night and thanks :) |
| 21:48:44 | <dkayiwa> AdamLauz: you too :) |
| 21:52:07 | *** yony258 has quit IRC |
| 21:52:42 | *** andrea has joined #openmrs |
| 21:53:06 | *** andrea is now known as Guest76127 |
| 21:53:29 | *** Guest76127 is now known as andreap |
| 21:53:40 | *** andreapat has quit IRC |
| 21:54:12 | <andreap> wyclif_, u there? |
| 21:54:50 | *** andreapat has joined #openmrs |
| 21:56:25 | <andreap> wyclif_, u around? |
| 21:59:02 | <wyclif_> andreap, yes |
| 22:01:21 | <andreap> wyclif_ hi - are tickets ATLAS-43 and Atlas-45 still a problem? |
| 22:10:07 | <andreap> wyclif_, u still there? |
| 22:10:33 | <wyclif_> andreap, there is still something not working in the module |
| 22:11:05 | <andreap> wyclif_, what is it? would like to start working on it |
| 22:11:09 | <wyclif_> andreap, some faulty method i found in the scripts |
| 22:11:21 | <wyclif_> andreap, method -> function |
| 22:11:39 | <wyclif_> andreap, the last time i tested this module, this were different |
| 22:11:48 | <wyclif_> andreap, i wonder why |
| 22:12:15 | <wyclif_> andreap, the module couldnt start but could run if i tweaked it |
| 22:12:24 | <wyclif_> andreap, now it starts but fails to run |
| 22:12:40 | <andreap> wyclif_, what isn't working? |
| 22:13:11 | <wyclif_> andreap, what i think is to move th activator code to the appropriate method to be 100% sure |
| 22:13:24 | <wyclif_> andreap, and also to fix the script function and get that done |
| 22:13:48 | <wyclif_> andreap, there is a little function that is unreliable |
| 22:15:02 | <andreap> wyclif_, what isn't working? |
| 22:18:50 | <wyclif_> andreap, basically the broken function results in the link for submiting data to the remote server to never appearing |
| 22:19:12 | <wyclif_> andreap, but i realized we can tweak the funtion a little to get it working |
| 22:19:12 | *** andreap has quit IRC |
| 22:20:06 | *** andreapat has joined #openmrs |
| 22:24:41 | *** andrea has joined #openmrs |
| 22:25:00 | *** andrea is now known as Guest54919 |
| 22:25:26 | *** Guest54919 is now known as andrea_p |
| 22:26:35 | <andrea_p> wyclif_, started another irc - which function is unreliable? How do I get the latest code? |
| 22:30:27 | *** AdamLauz has quit IRC |
| 22:30:59 | <wyclif_> andrea_p, am ready |
| 22:31:17 | <wyclif_> andrea_p, let send you my team viewer credentials |
| 22:31:24 | <wyclif_> andrea_p, start skype |
| 22:32:42 | <wyclif_> andrea_p, are you on skype? |
| 22:35:15 | *** andreapat has quit IRC |
| 22:37:28 | *** andrea_p has quit IRC |
| 22:41:01 | *** sgithens has joined #openmrs |
| 22:52:03 | *** dkayiwa has quit IRC |
| 23:50:54 | *** sgithens has quit IRC |