| 00:06:02 | *** wluyima has joined #openmrs |
| 01:06:07 | *** dkayiwa has quit IRC |
| 01:56:22 | *** djazayeri has quit IRC |
| 02:10:34 | *** djazayeri has joined #openmrs |
| 02:10:34 | *** ChanServ sets mode: +o djazayeri |
| 02:21:27 | *** djazayeri1 has joined #openmrs |
| 02:23:58 | *** sgithens has joined #openmrs |
| 02:24:00 | *** djazayeri has quit IRC |
| 03:25:27 | *** kavuri has joined #openmrs |
| 03:54:12 | *** sgithens has quit IRC |
| 04:31:42 | *** sgithens has joined #openmrs |
| 04:42:24 | *** didymo has joined #openmrs |
| 04:43:26 | *** shangxiao has joined #openmrs |
| 04:52:44 | <djazayeri1> shangxiao: you there? |
| 04:52:54 | *** djazayeri1 is now known as djazayeri |
| 04:55:46 | *** shangxiao has quit IRC |
| 05:06:13 | *** sgithens has quit IRC |
| 05:20:19 | *** kishoreyekkanti has joined #openmrs |
| 05:21:40 | *** jkeiper has quit IRC |
| 06:59:27 | *** dkayiwa has joined #openmrs |
| 07:37:00 | *** shangxiao has joined #openmrs |
| 07:41:08 | *** kavuri has quit IRC |
| 08:13:22 | *** larapihrwanda has joined #openmrs |
| 08:18:03 | *** kavuri has joined #openmrs |
| 09:17:19 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: UI Library Module 2.0.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=uilibrary&version=&2.0.2> |
| 09:31:28 | <djazayeri> dkayiwa: hi, you there? |
| 09:31:33 | <dkayiwa> djazayeri: yes |
| 09:31:38 | <djazayeri> I see you tweaked the git pages |
| 09:31:45 | <dkayiwa> djazayeri: yes |
| 09:31:55 | <djazayeri> have you also created the appointment module then? |
| 09:32:02 | <dkayiwa> djazayeri: yes |
| 09:32:23 | <djazayeri> okay, I'm going to create a bamboo plan for it... |
| 09:32:30 | <dkayiwa> djazayeri: ok thanks |
| 09:32:58 | <dkayiwa> djazayeri: can you claim AM-12? :) |
| 09:33:00 | <dkayiwa> !ticket AM-12 |
| 09:33:01 | <OpenMRSBot> dkayiwa: [#AM-12] Load module into CI - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-12 |
| 09:38:38 | <djazayeri> dkayiwa: okay, I've created the plan, but I realize I don't know how to copy the omod file into the tomcat folder and restart tomcat |
| 09:38:44 | <djazayeri> I'll email downey. |
| 09:38:51 | <dkayiwa> djazayeri: ok thanks |
| 09:38:54 | <djazayeri> And I'm off to bed, then not working much more until monday |
| 09:39:04 | <dkayiwa> djazayeri: 8) |
| 09:42:06 | *** robbyoconnor has joined #openmrs |
| 09:42:06 | *** ChanServ sets mode: +v robbyoconnor |
| 09:42:40 | *** djazayeri has quit IRC |
| 09:47:25 | *** larapihrwanda has left #openmrs |
| 09:50:21 | *** didymo has quit IRC |
| 10:01:19 | *** rafa has joined #openmrs |
| 10:01:19 | *** ChanServ sets mode: +v rafa |
| 10:12:49 | *** kavuri has quit IRC |
| 10:56:03 | *** Adam_ has joined #openmrs |
| 11:06:59 | <dkayiwa> hi Adam_ |
| 11:08:02 | <dkayiwa> Adam_: let me come back after an hour |
| 11:08:07 | *** dkayiwa has quit IRC |
| 12:07:03 | *** lh has joined #openmrs |
| 12:07:03 | *** lh has joined #openmrs |
| 12:07:48 | *** shangxiao has quit IRC |
| 12:17:54 | *** dkayiwa has joined #openmrs |
| 12:37:16 | <dkayiwa> hi Adam_ |
| 12:47:35 | <Adam_> dkayiwa: Hi daniel how are you? |
| 12:47:51 | <dkayiwa> Adam_: am good. and you |
| 12:48:04 | <Adam_> dkayiwa: great |
| 12:51:29 | <Adam_> dkayiwa: Are you free now to meet? |
| 12:52:09 | <dkayiwa> Adam_: yes |
| 12:55:13 | <Adam_> dkayiwa: How do you prefer to meet? skype? |
| 12:55:41 | *** yony258 has joined #openmrs |
| 12:55:55 | *** suranga has joined #openmrs |
| 12:55:55 | *** ChanServ sets mode: +v suranga |
| 12:58:39 | <Adam_> dkayiwa: me and Yonatan are available on skype. My skype is : lauz.adam |
| 12:59:34 | *** shangxiao has joined #openmrs |
| 13:01:39 | <dkayiwa> Adam_: can you give me 30mins |
| 13:02:09 | <Adam_> dkayiwa: sure just let me know when you are free |
| 13:02:15 | <dkayiwa> Adam_: sure |
| 13:24:32 | <suranga> howdy rafa ! |
| 13:24:38 | <rafa> suranga: hi |
| 13:24:41 | <suranga> rafa, did you see the happy news :-) |
| 13:24:51 | <rafa> suranga: yes! |
| 13:24:55 | <rafa> suranga: well done! |
| 13:25:06 | <suranga> rafa, it seems that I had forgotten the spring beans :P |
| 13:25:36 | <rafa> suranga: so some extra configuration was needed? |
| 13:26:32 | <suranga> rafa, apparently I had to add a couple of beans. not having them was not resulting in any visible errors, so it took a while to discover them :( |
| 13:26:47 | <suranga> rafa, now im going to work on cleaning it up, etc. :-) |
| 13:26:57 | <rafa> suranga: I see |
| 13:27:17 | <rafa> suranga: that's great |
| 13:28:35 | <suranga> rafa, i have to vanish for awhile now, but will return in an hour or two to wrap things up :-) |
| 13:28:55 | <rafa> suranga: cool, see you later |
| 13:42:28 | *** sgithens has joined #openmrs |
| 13:54:18 | *** shangxiao has quit IRC |
| 13:54:47 | <yony258> dkayiwa: Hi |
| 13:56:18 | <dkayiwa> yony258: hey |
| 13:59:34 | *** robbyoconnor has quit IRC |
| 14:00:30 | <dkayiwa> yony258: am ready now |
| 14:01:01 | <yony258> dkayiwa: Oh great, where do you want to talk? |
| 14:01:12 | <dkayiwa> yony258: where do you? |
| 14:01:20 | <yony258> dkayiwa: I prefer skype |
| 14:01:28 | <dkayiwa> yony258: ok |
| 14:02:05 | <yony258> dkayiwa: I'll add you to mine and Adam's conversation |
| 14:02:14 | <dkayiwa> yony258: ok |
| 14:04:41 | *** robbyoconnor has joined #openmrs |
| 14:04:41 | *** ChanServ sets mode: +v robbyoconnor |
| 14:08:47 | *** Adam_ has quit IRC |
| 14:11:44 | *** sgithens has quit IRC |
| 14:12:01 | *** sgithens has joined #openmrs |
| 14:39:50 | *** shangxiao has joined #openmrs |
| 15:02:30 | *** sgithens has quit IRC |
| 15:08:03 | *** suranga has quit IRC |
| 15:17:07 | *** yony258 has quit IRC |
| 15:18:06 | *** kishoreyekkanti has quit IRC |
| 15:21:39 | *** rafa has quit IRC |
| 15:29:14 | *** robbyoconnor has quit IRC |
| 15:35:08 | *** jblaya has joined #openmrs |
| 15:38:05 | <jblaya> dkayiwa, wluyima, do either of you know if there's a page with instructions for upgrading from 1.6 to 1.9? I've searched in gmail and google and haven't found it |
| 15:39:07 | <jblaya> the only thing I find is the openmrs 1.9 release notes and the validation module |
| 15:40:43 | <dkayiwa> jblaya: the readme.txt here http://sourceforge.net/projects/openmrs/files/releases/OpenMRS_1.9.1/ |
| 15:40:44 | <OpenMRSBot> <http://ln-s.net/$jR2> (at sourceforge.net) |
| 15:42:03 | <jblaya> thanks dkayiwa |
| 15:44:22 | *** lh has quit IRC |
| 16:41:32 | *** suranga has joined #openmrs |
| 16:41:32 | *** ChanServ sets mode: +v suranga |
| 17:05:14 | *** rafa has joined #openmrs |
| 17:05:14 | *** ChanServ sets mode: +v rafa |
| 17:18:46 | *** Adam_ has joined #openmrs |
| 17:20:39 | *** yony258 has joined #openmrs |
| 17:20:57 | <yony258> dkayiwa: So can I just name my changesets like yours just with a different table name? |
| 17:21:10 | <dkayiwa> yony258: thats ok too :) |
| 17:21:51 | <yony258> dkayiwa: Great, one question I had is why you named the table appointment_appointment_type rather than just appointment_type, is there any convention to add the module name to the table name? |
| 17:23:08 | <dkayiwa> yony258: you got it right. very intelligent of you :D |
| 17:23:22 | <yony258> dkayiwa: haha lol |
| 17:29:34 | <yony258> dkayiwa: Is there any convention for the link tables? (For Example for the many-many relationship of block and appointment type) |
| 17:30:15 | <suranga> hi rafa .. wonder if you are around ? :-) |
| 17:30:23 | <dkayiwa> yony258: as a liquibase changeset or hibernate mapping file? |
| 17:31:28 | <yony258> dkayiwa: liquibase changeset |
| 17:32:06 | <dkayiwa> yony258: do you mean the same way i referenced the creator-user foreign keys? |
| 17:32:12 | <yony258> dkayiwa: I have absolutely no experience with hibernate so I dont even know what that is (But am learning from a book and some video tutorials) |
| 17:32:21 | <dkayiwa> yony258: ok |
| 17:32:42 | <yony258> dkayiwa: I mean that for example an appointment block can have multiple appointment types and so does the other way around |
| 17:33:01 | <yony258> dkayiwa: that means I'll need a "relationship table" for that link |
| 17:33:09 | <dkayiwa> yony258: let me look for an example and show you |
| 17:47:57 | *** jblaya has quit IRC |
| 17:50:34 | *** kishoreyekkanti has joined #openmrs |
| 17:51:47 | <dkayiwa> yony258: is that the block_types table? |
| 17:52:45 | <yony258> dkayiwa: Yes exactly |
| 17:59:17 | *** djazayeri has joined #openmrs |
| 17:59:17 | *** ChanServ sets mode: +o djazayeri |
| 18:00:51 | *** rafa has quit IRC |
| 18:02:32 | *** Adam_ has quit IRC |
| 18:08:02 | *** hif has joined #openmrs |
| 18:08:15 | <dkayiwa> yony258: you simply create a changeset and the appropriate foreign keys |
| 18:08:59 | <yony258> dkayiwa: Ok, is there any convention for the name of this kind of tables? or can I just call it appointment_block_types |
| 18:10:10 | <dkayiwa> yony258: appointment_block_type |
| 18:10:23 | <dkayiwa> yony258: without s |
| 18:10:37 | <yony258> dkayiwa: Oh right sry |
| 18:13:37 | <shangxiao> djazzy you pinged me earlier? |
| 18:13:49 | * shangxiao pokes djazayeri |
| 18:16:40 | <dkayiwa> shangxiao: djazayeri is giving thanks :) |
| 18:17:53 | <shangxiao> :o |
| 18:18:21 | <shangxiao> I'll come back later |
| 18:18:26 | *** shangxiao has quit IRC |
| 18:19:50 | <dkayiwa> so yony258 |
| 18:20:02 | <yony258> dkayiwa: ? |
| 18:20:10 | <dkayiwa> yony258: how do you tell which type is for a particular patient appointment? |
| 18:21:01 | <yony258> dkayiwa: We didn't need that information, do you think we need that? |
| 18:21:24 | <dkayiwa> yony258: so what do you use the appointment_type for? |
| 18:21:50 | <yony258> dkayiwa: In order to know which appointment blocks we should consider when looking for an appointment to schedule |
| 18:22:03 | <dkayiwa> yony258: ok |
| 18:22:09 | <yony258> dkayiwa: Sounds ok? |
| 18:22:26 | <dkayiwa> yony258: can you give an example? |
| 18:23:21 | <yony258> dkayiwa: Lets say we got 2 blocks currently one for physio and the other is a family doctor, ok? |
| 18:23:55 | <yony258> dkayiwa: A patient calls and says I want an appointment for Physiotherapy. |
| 18:24:27 | <yony258> dkayiwa: We need to know that one block cant support physiotherapy appointments and the other can. |
| 18:24:46 | <dkayiwa> yony258: ok. so each block is for one appointment type? |
| 18:25:58 | <yony258> dkayiwa: Not necessarily, for example a doctor which provides both family care and physiotherapy. |
| 18:26:46 | <dkayiwa> yony258: what would you loose by making those two appointment blocks? |
| 18:27:26 | <dkayiwa> yony258: where each block is for the appointment type he gives during a particular time |
| 18:27:50 | <yony258> dkayiwa: We may cause parallel appointments. |
| 18:28:00 | <dkayiwa> yony258: how? |
| 18:28:40 | <dkayiwa> yony258: if the doctor provides say a morning block for family plannning and evening block for physiotherapy |
| 18:28:55 | <yony258> dkayiwa: For Example lets say doctor d is giving both family and eyes care between 12:00-17:00, how would you suggest to model that? |
| 18:29:42 | <dkayiwa> yony258: oh i see |
| 18:29:53 | <dkayiwa> yony258: now i understand |
| 18:30:24 | <yony258> dkayiwa: I cant seem to commit my liquibase changes |
| 18:30:27 | <dkayiwa> yony258: was trying to look for a way of avoiding multiple types for a block because that means more complexity :) |
| 18:30:38 | <dkayiwa> yony258: what happens when you try ? |
| 18:30:39 | <yony258> dkayiwa: Yea I did too :] |
| 18:30:53 | <yony258> dkayiwa: I did "git add liquibase.xml" that was ok |
| 18:31:05 | <yony258> dkayiwa: Now I did "git commit -m "message" |
| 18:31:22 | <yony258> dkayiwa: But I cant see my commit at the git web |
| 18:31:27 | <yony258> *webpage |
| 18:31:34 | <dkayiwa> yony258: you cannot add it because i committed it |
| 18:31:46 | <dkayiwa> yony258: so you need to pull and update it |
| 18:31:58 | <dkayiwa> yony258: you would only add it if i had not committed it |
| 18:32:02 | <yony258> dkayiwa: Can you guide me how to do that? |
| 18:32:43 | <dkayiwa> yony258: after i committed the second time for liquibase changesets, did you do a git pull? |
| 18:33:07 | <yony258> dkayiwa: I just did "git pull -a" and it says already up to date |
| 18:33:22 | *** rafa has joined #openmrs |
| 18:33:22 | *** ChanServ sets mode: +v rafa |
| 18:33:41 | <yony258> dkayiwa: but when I do git status it says my branch is ahead by 2 commits |
| 18:33:47 | <dkayiwa> yony258: what happens when you do it without -a |
| 18:34:12 | <yony258> dkayiwa: "Already up to date" |
| 18:35:34 | <dkayiwa> yony258: how about? git pull --rebase upstream master |
| 18:36:21 | <yony258> dkayiwa: upstream does not appear to be a git repository |
| 18:37:34 | <dkayiwa> yony258: what does this do for you? git push |
| 18:40:29 | <yony258> dkayiwa: Http Request Failed (403) I have no idea why |
| 18:40:47 | <yony258> dkayiwa: something "While accessing .../info/refs" |
| 18:41:16 | <dkayiwa> yony258: that could be my problem :) |
| 18:42:15 | <yony258> dkayiwa: You think its related to this: (First Comment) http://stackoverflow.com/questions/7438313/pushing-to-git-returning-error-code-403-fatal-http-request-failed |
| 18:42:18 | <OpenMRSBot> <http://ln-s.net/$3vA> (at stackoverflow.com) |
| 18:42:50 | <dkayiwa> yony258: i may need to add some sort of permission to your account |
| 18:45:21 | *** jblaya has joined #openmrs |
| 18:53:14 | <dkayiwa> hi rafa |
| 18:53:27 | <rafa> dkayiwa: hi |
| 18:53:58 | <dkayiwa> rafa: do you know how i give someone push access to a github repo |
| 18:54:25 | <rafa> dkayiwa: go to admin and add collaborators |
| 18:55:21 | <dkayiwa> rafa: https://github.com/openmrs/openmrs-module-appointment/admin |
| 18:56:06 | <dkayiwa> i do not see collaborators button there |
| 18:57:14 | <rafa> dkayiwa: I gues it's different for an organization |
| 18:57:28 | <rafa> dkayiwa: you need to ask downey |
| 18:57:40 | <rafa> dkayiwa: only owners can do that |
| 18:57:46 | <dkayiwa> rafa: ok |
| 19:01:37 | <jblaya> dkayiwa, have you seen this error before "identifier of an instance of org.openmrs.Privilege was altered from Update HL7 Inbound Archive to Update HL7 Inbound Archive" |
| 19:02:10 | <jblaya> dkayiwa, I just upgraded an instance from 1.6 to 1.9 and when I try to modify the role for a user it gives me that error |
| 19:02:37 | <jblaya> dkayiwa, I'm asking you because that is a privilege for xform |
| 19:03:50 | <dkayiwa> jblaya: not before |
| 19:05:49 | <jblaya> dkayiwa, ok, I ended up deleting that privilege and adding it back and that seemed to solve the problem |
| 19:06:09 | <dkayiwa> jblaya: ok good |
| 19:07:12 | <jblaya> dkayiwa, one other thing, I'm seeing that the provider ids are not being automatically updated in xforms |
| 19:07:38 | <jblaya> dkayiwa, ie when I add a provider I have to go to the form and refresh to update the list, but I saw a ticket that supposedly solved this |
| 19:07:43 | <jblaya> dkayiwa, should this be working? |
| 19:07:51 | *** harshadura has joined #openmrs |
| 19:12:16 | <jblaya> dkayiwa, I'm getting a Internal Server Error for users with a Provider role, but not for users with System Developer role, so there's a problem with the permissions required |
| 19:12:33 | <jblaya> dkayiwa, is there a page which describes the permissions required for xforms? I searched but couldn't find one |
| 19:14:30 | *** harshadura has quit IRC |
| 19:20:42 | *** kishoreyekkanti has quit IRC |
| 19:30:33 | <dkayiwa> jblaya: sorry had stepped out |
| 19:30:53 | <jblaya> dkayiwa, no problem at all |
| 19:31:28 | <dkayiwa> jblaya: do you mean 1.9 providers? |
| 19:31:34 | <jblaya> yes |
| 19:31:51 | <dkayiwa> jblaya: the ticket was for old providers |
| 19:32:48 | <jblaya> dkayiwa, ah! is there a ticket for new providers? |
| 19:32:58 | <dkayiwa> jblaya: no |
| 19:33:17 | <jblaya> dkayiwa, I'll create one now then |
| 19:33:23 | <dkayiwa> jblaya: ok |
| 19:34:33 | <jblaya> dkayiwa, also is there a list of privielges required? I was able to solve the problem, but it'd be good to know which ones are required |
| 19:36:53 | <dkayiwa> jblaya: required to? |
| 19:38:18 | <jblaya> dkayiwa, oh, sorry, before I had mentioned that the default provider user was getting an Internal Server Error when they tried to open a form |
| 19:38:34 | <jblaya> dkayiwa, I then gave this user a bunch more priviliges and the error went away |
| 19:38:57 | <dkayiwa> jblaya: i do not know the list |
| 19:39:55 | <jblaya> Ok, I'll make the list from the privileges that I gave this user and place it on the wiki |
| 19:40:15 | <dkayiwa> jblaya: must be core requirements. ok |
| 19:42:25 | <dkayiwa> hi yony258 |
| 19:42:34 | <yony258> dkayiwa: hi |
| 19:42:57 | <dkayiwa> yony258: why do we need to store appointment status in database |
| 19:43:11 | <djazayeri> dkayiwa: I am confused by that question |
| 19:43:22 | <djazayeri> dkayiwa: are you asking about there being a table that lists all appointment statuses? |
| 19:43:36 | <yony258> Its ok, let me explain |
| 19:43:53 | <yony258> dkayiwa: Because we want to allow creation of new appointment statuses |
| 19:43:56 | <dkayiwa> djazayeri: yes. like WAITING, SCHEDULED, etc |
| 19:44:09 | <djazayeri> yony258: oh, really? fine⦠:-) |
| 19:44:17 | <yony258> djazayeri: Does that sounds ok? |
| 19:44:32 | <djazayeri> yony258: if that's a requirement, I guess. |
| 19:44:42 | <djazayeri> but do you really need to define them in a table? |
| 19:44:58 | <djazayeri> can't you just refer to them by names like WAITING in a varchar, and their meaning is defined in code? |
| 19:45:17 | <djazayeri> (i.e. the fact that we have a concept_datatype table in OpenMRS core was a big mistake.) |
| 19:45:34 | <yony258> djazayeri: But how would that allow new statuses? |
| 19:45:50 | <djazayeri> you just add code to support more statuses in the module |
| 19:46:43 | <djazayeri> yony258: if no special code is needed to handle a new status, then it's fine to have a database table for those. But I doubt that's the case. |
| 19:46:45 | <yony258> djazayeri: Well if you think thats better its fine by me, anyway that statuses we defined are enough for our use case, that was suggested just in order to generalize t |
| 19:47:25 | <jblaya> djazayeri, dkayiwa yony258 wanted to let you know that I uploaded a requirements doc for a schedulign system that was built by a company I work with and also I just sent an email with a demo user for their scheduling system if you wanted to see it |
| 19:47:27 | <dkayiwa> yony258: because i suspect you plan to have some business logic attached to status |
| 19:47:31 | <yony258> djazayeri: My most important aspect about the statuses is to know how much time an appointment was in the status. (f.e: how much time was a patient waiting) |
| 19:47:35 | <djazayeri> yony258: I would vote for just have the column in the appointment_status table be a varchar, not an FK to another table. |
| 19:47:55 | <djazayeri> yony258: did you see my email of a couple of hours ago? I was asking if having reconfigurable statuses is a real requirement. |
| 19:48:01 | <djazayeri> jblaya: perhaps you can weigh in on that |
| 19:48:20 | <djazayeri> yony258: also, I need to know your and adam's github ids so I can give you privileges |
| 19:48:32 | <yony258> djazayeri: Im not sure about the email let me check |
| 19:48:52 | <yony258> djazayeri: My git id is yony258 , Adam will send you his since he's offline right now |
| 19:49:24 | <dkayiwa> jblaya: thanks. seen it :) |
| 19:49:57 | <yony258> djazayeri: I dont have an email from you so If you can repeat what was it about |
| 19:50:15 | <dkayiwa> yony258: are you on the dev list? |
| 19:50:22 | <yony258> dkayiwa: yea |
| 19:50:40 | <dkayiwa> yony258: then check his email there |
| 19:50:41 | <yony258> dkayiwa: If it was on the dev list than its a different account, ill check again |
| 19:52:49 | <jblaya> djazayeri, let me read and I'll comment |
| 19:53:10 | <djazayeri> jblaya: do you think that having a hardcoded set of appointment statuses (created, arrived, in-consultation, cancelled) is sufficient for an appointment module, or it's necessary to support reconfigurable statuses? |
| 19:53:41 | <jblaya> djazayeri, let me ask the guys who built the scheduling system here |
| 19:54:08 | <djazayeri> yony258: what is the name of your group, actually? I've just been calling you Tobin's group, or the group in Tel Aviv, but surely there's an actual name. :-) |
| 19:54:12 | <dkayiwa> jblaya: how about you as an end user? :) |
| 19:54:24 | <djazayeri> actually, maybe I don't need to know that. |
| 19:54:28 | <yony258> djazayeri: I have no idea :] |
| 19:54:38 | <dkayiwa> yony258: :D |
| 19:54:54 | <yony258> djazayeri: Ok read it, now Im not sure that we need a table for this but I want to point a couple of use cases we planned let me know if its supported without a table |
| 19:56:00 | <jblaya> in talking with the guys here, they've implemented a scheduling system and have had the functionality of adding status types |
| 19:56:10 | <dkayiwa> jblaya: why |
| 19:56:12 | <yony258> djazayeri: 1. A patient is being transferred to another location and we planned to name the status "Waiting for <location_name>", f.e: patient was at family doctor and the doctor told him to go and do a X-ray |
| 19:56:16 | <jblaya> and they have used it in the different implementations |
| 19:56:48 | <jblaya> or what they mentioned was that some places use different names or have more statuses than others |
| 19:56:59 | *** suranga has quit IRC |
| 19:57:12 | <jblaya> for example they told me about a hospital that had a status "patient getting dressed" so that the technician would start getting ready |
| 19:57:20 | <dkayiwa> jblaya: oh i see |
| 19:57:32 | <jblaya> but only an administrator can add status types, not an end user |
| 19:57:55 | <dkayiwa> jblaya: very useful info. can you respond on the dev list too? :) |
| 19:57:59 | <yony258> djazayeri: Thats exactly why we planned to do a table, |
| 19:58:10 | <dkayiwa> yony258: i now agree :) |
| 19:58:16 | <djazayeri> yony258: I think I gave you privileges to the repository |
| 19:58:31 | <yony258> Ok I'll try to push ;] |
| 19:58:51 | <djazayeri> yony258: For that scenario I'm a bit worried about using the same statuses table |
| 19:59:01 | <yony258> djazayeri: Thanks, works now ! |
| 19:59:09 | <yony258> djazayeri: Can you explain? |
| 19:59:27 | <djazayeri> i.e. I feel like after they arrive and check in, the data should be recorded as part of the visit, not as part of the appointment |
| 19:59:54 | <jblaya> dkayiwa, on what email should I respond on the dev list? |
| 20:00:12 | <yony258> jblaya: Re:Appointment Status |
| 20:00:15 | <djazayeri> meaning to me it seems like the "appointment" should cover the spectrum from when they schedule it to when they show up, but as soon as they check in, you'd be storing the data elsewhere |
| 20:00:18 | <jblaya> dkayiwa, yeah, just saw it |
| 20:00:19 | <dkayiwa> jblaya: Re: Appointment Status |
| 20:00:46 | <djazayeri> that said, yony258, I guess I'm convinced that allowing these to be eventually reconfigured makes sense |
| 20:01:08 | <djazayeri> yony258: however I don't see a need to have a table to represent the statuses. Because creating a new status is meaningless unless you write new code to handle it. |
| 20:01:40 | <djazayeri> yony258: if you were also going to have set of tables that define the flowchart of how a patient can go from status to status, and write all that generic code, then you'd definitely need a table to define the statuses. |
| 20:01:41 | <yony258> djazayeri: That is a very good point, let me think about it for a sec |
| 20:02:16 | <jblaya> djazayeri, in my opinion, that is a second phase requirement |
| 20:02:33 | <djazayeri> yony258: but since status behaviors will be hardcoded (at least for now) I recommend just putting the status enum's value in a varchar column |
| 20:02:34 | <djazayeri> gotta run |
| 20:02:50 | <jblaya> djazayeri, happy thanksgiving! |
| 20:02:50 | <yony258> djazayeri: Right now I think you are right, except of some report like avg time in status I see no reason |
| 20:03:01 | <yony258> djazayeri: But I think its better to keep that option open? |
| 20:03:05 | <yony258> djazayeri: Ok thanks. |
| 20:03:18 | <djazayeri> yony258: you could always add a table later |
| 20:03:46 | <yony258> dkayiwa: There are 2 commits in the webpage they are both the same the first shows the changes. (The second one was an accident) |
| 20:04:07 | <dkayiwa> yony258: ok let me look at it |
| 20:04:28 | <yony258> djazayeri: Im sure you got more experience than me about that and thats why I think we should do it as you proposed. |
| 20:04:31 | <djazayeri> yony258: sorry, to be clear, I'm saying that I agree about having an appointment_status table, but I think it should be (appoint_id = fk-to-appointment, status = varchar, from_date, to_date) |
| 20:04:33 | <dkayiwa> yony258: can you put the commit url on the ticket? |
| 20:05:13 | <yony258> dkayiwa: sure but Its not finished its just 2 tables so you could review what I wrote (Since its my first time using liquibase) |
| 20:05:16 | <djazayeri> instead of having another additional table to list the statuses, and having appointment_status have an fk to that. That's just going to be annoying to code against, and gains you nothing now. |
| 20:05:20 | <yony258> djazayeri: Yea I understood |
| 20:05:22 | <djazayeri> 'k, really gotta run now. :-) |
| 20:05:26 | <djazayeri> great |
| 20:05:28 | <yony258> djazayeri: Ok, Thank you. ! |
| 20:05:30 | <dkayiwa> :) |
| 20:05:55 | <djazayeri> dkayiwa: do you have the power to modify this in github? |
| 20:05:56 | <djazayeri> https://github.com/organizations/openmrs/teams/288507 |
| 20:06:00 | <OpenMRSBot> <http://ln-s.net/+:wa> (at github.com) |
| 20:06:22 | <dkayiwa> djazayeri: page not found |
| 20:07:18 | <djazayeri> okay, well, when we know adam's github id, let me/downey/burke know and one of us will add it. |
| 20:07:33 | <dkayiwa> djazayeri: ok |
| 20:07:40 | <yony258> dkayiwa: Let me know when you're done reviewing liquibase.xml if I did that right, if so than I'll continue, if not let me know what are my mistakes. Thank you. :] |
| 20:08:01 | <dkayiwa> yony258: am doing that now :) |
| 20:12:10 | <dkayiwa> yony258: can we have an appointment without a visit_id value? |
| 20:12:56 | <yony258> dkayiwa: Yes, for example a future appointment, there isn't a visit yet for this type, there will be as soon as the patient will check-in into the clinic. |
| 20:13:35 | <dkayiwa> yony258: ok. can we also have an appointment without a patient_id value? |
| 20:13:53 | <yony258> dkayiwa: Nope |
| 20:14:14 | <dkayiwa> yony258: can you change nullable to false for patient_id? |
| 20:14:28 | <yony258> dkayiwa: ofcourse |
| 20:18:56 | <dkayiwa> yony258: looking at this: https://wiki.openmrs.org/display/archive/Deleting+Data+in+OpenMRS___Void+vs.+Retire+vs.+Purge |
| 20:19:17 | <dkayiwa> yony258: what do you think of having voided instead of retired for appointment? |
| 20:19:33 | * yony258 Reading now |
| 20:22:13 | <yony258> dkayiwa: Am Im not sure I understood retire, since appointment isn't really metadata |
| 20:22:37 | <dkayiwa> yony258: that is why i would go with void |
| 20:22:41 | <yony258> dkayiwa: with that being said voided looks more right. |
| 20:22:53 | <dkayiwa> yony258: yes to me too |
| 20:23:00 | <dkayiwa> yony258: can you change to void? |
| 20:23:07 | <yony258> dkayiwa: is that void or void_ ? |
| 20:23:19 | <dkayiwa> yony258: yes :) |
| 20:23:28 | <yony258> dkayiwa: which one ? :] |
| 20:23:45 | <dkayiwa> yony258: retired to voided |
| 20:23:51 | <dkayiwa> etc |
| 20:24:18 | <yony258> dkayiwa: tinyint right? |
| 20:25:40 | <dkayiwa> yony258: same data type as retired |
| 20:29:05 | <dkayiwa> yony258: voided, voided_by, date_voided, void_reason |
| 20:29:17 | <yony258> dkayiwa: Done. |
| 20:31:59 | <yony258> dkayiwa: Ok I need to go off now, Thank you dkayiwa |
| 20:32:12 | <dkayiwa> yony258: after that change, your commit looks good :) |
| 20:35:02 | *** yony258 has quit IRC |
| 20:36:15 | *** lh has joined #openmrs |
| 20:36:15 | *** lh has joined #openmrs |
| 21:07:22 | *** jblaya has quit IRC |
| 21:15:27 | *** jblaya has joined #openmrs |
| 21:16:01 | <jblaya> djazayeri, dkayiwa, have you by any chance worked with xml-rpc messages? |
| 21:16:21 | <dkayiwa> jblaya: not me |
| 21:27:18 | <djazayeri> jblaya: no |
| 21:27:39 | <djazayeri> jblaya: and if you can avoid them, and go with something RESTful instead, you're better off. :-) |
| 21:28:09 | <jblaya> djazayeri, it's an SMS provider that I'm trying to test out |
| 21:28:24 | <jblaya> djazayeri, and they use xml-rpc, but I can't even get a curl statement to work with it... |
| 21:28:31 | <djazayeri> I figured you wouldn't have the choice... |
| 21:29:21 | <jblaya> djazayeri, yeah, and so far it's a pain in the ass, I can't even find a debugger that works with it... |
| 21:38:55 | *** jblaya has quit IRC |
| 22:32:32 | *** hif has quit IRC |
| 22:40:08 | *** dkayiwa has quit IRC |
| 22:52:57 | *** dkayiwa has joined #openmrs |
| 23:08:18 | *** lh has quit IRC |
| 23:10:36 | *** lh has joined #openmrs |
| 23:12:24 | *** dkayiwa has quit IRC |
| 23:17:22 | *** rafa has quit IRC |
| 23:34:02 | *** robbyoconnor has joined #openmrs |
| 23:34:02 | *** ChanServ sets mode: +v robbyoconnor |