| 01:02:28 | *** andreapat has quit IRC |
| 02:08:28 | *** robbyoconnor has joined #openmrs |
| 02:08:28 | *** ChanServ sets mode: +v robbyoconnor |
| 02:52:04 | *** robbyoconnor has quit IRC |
| 02:56:02 | *** didymo has joined #openmrs |
| 04:19:11 | *** pulasthi7 has joined #openmrs |
| 04:42:43 | *** kishoreyekkanti has joined #openmrs |
| 04:49:14 | *** djazayeri has quit IRC |
| 04:58:03 | *** fishandwalk has joined #openmrs |
| 05:43:43 | *** nribeka has quit IRC |
| 06:30:56 | *** djazayeri has joined #openmrs |
| 06:30:56 | *** ChanServ sets mode: +o djazayeri |
| 06:34:36 | *** robbyoconnor has joined #openmrs |
| 06:34:36 | *** ChanServ sets mode: +v robbyoconnor |
| 06:37:04 | *** r0bby has joined #openmrs |
| 06:37:04 | *** ChanServ sets mode: +v r0bby |
| 06:38:56 | *** robbyoconnor has quit IRC |
| 06:39:04 | *** r0bby is now known as robbyoconnor |
| 06:39:23 | *** dkayiwa has joined #openmrs |
| 06:53:22 | *** pulasthi7 has quit IRC |
| 07:39:08 | *** lh has quit IRC |
| 08:11:04 | *** djazayeri has quit IRC |
| 09:12:38 | *** kavuri has joined #openmrs |
| 09:51:26 | *** didymo has quit IRC |
| 10:28:47 | *** kavuri has quit IRC |
| 10:30:54 | *** yony258 has joined #openmrs |
| 10:31:08 | <yony258> dkayiwa: Hi |
| 10:31:40 | <dkayiwa> yony258: hi |
| 10:33:06 | <yony258> dkayiwa: How are you dkayiwa ? |
| 10:33:22 | <yony258> dkayiwa: I wanted to ask for your help on something, if you have time oc. |
| 10:33:37 | <dkayiwa> yony258: ok |
| 10:38:51 | <yony258> dkayiwa: Im trying to do a very small example module |
| 10:39:23 | <dkayiwa> yony258: ok |
| 10:39:42 | <yony258> dkayiwa: In which I have the test.jsp (available from the adminisitration page) that get a concept id from the user and shows the details of that concept in a second page "result.jsp" |
| 10:40:07 | <dkayiwa> yony258: ok |
| 10:41:03 | <yony258> dkayiwa: so my problem is how to transfer the id from test.jsp to the controller (something with the commandName in the form:form maybe?) and how to redirect? (since redirect:result.jsp doesn't seems to work) |
| 10:41:47 | <dkayiwa> yony258: can you commit the module in github and i have a look at it? |
| 10:41:59 | <yony258> hmm yea sure |
| 10:42:21 | <yony258> dkayiwa: the problem is its messed up right now since I tried a lot of different stuff |
| 10:42:28 | <yony258> but ok |
| 10:42:39 | <dkayiwa> yony258: ok |
| 10:42:49 | *** kavuri has joined #openmrs |
| 10:56:22 | <yony258> dkayiwa: https://github.com/yony258/TrainingModule2 |
| 10:56:39 | <dkayiwa> yony258: ok |
| 10:57:02 | <yony258> dkayiwa: Although, as I said its really messed up right now I removed some stuff in order to test with hard-codded values |
| 10:57:16 | <dkayiwa> yony258: ok |
| 10:57:32 | <yony258> But those 2 problems I mentioned are my main problems since im new to using Spring with JSP |
| 10:57:41 | <dkayiwa> yony258: ok |
| 11:07:22 | *** suranga has joined #openmrs |
| 11:14:29 | <dkayiwa> yony258: so which jsp should i look at? |
| 11:14:43 | <yony258> dkayiwa: test.jsp |
| 11:15:01 | <dkayiwa> yony258: and what is the problem is it? |
| 11:15:32 | <yony258> The problem is how do I take the Concept ID from the test.jsp to the controller |
| 11:36:49 | *** suranga has quit IRC |
| 11:37:04 | *** suranga has joined #openmrs |
| 11:42:57 | <dkayiwa> hi yony258 |
| 11:44:50 | <yony258> dkayiwa: ? |
| 11:47:29 | <dkayiwa> yony258: how did you create this module? |
| 11:47:52 | <yony258> dkayiwa: We created it back than when we talked on teamviewer |
| 11:48:08 | <dkayiwa> yony258: ok |
| 11:48:27 | <dkayiwa> yony258: you can add this to the controller: @RequestParam("conceptId") String conceptId |
| 11:48:41 | <dkayiwa> yony258: getConceptName(ModelMap model, @RequestParam("conceptId") String conceptId) |
| 11:48:57 | <dkayiwa> yony258: and then: Enter Concept ID: <input type="text" name="conceptId"/> |
| 11:49:02 | <dkayiwa> in test.jsp |
| 11:49:12 | <yony258> dkayiwa: ok ill try that, can you explain it to me later? |
| 11:49:21 | <yony258> dkayiwa: I mean after ill try that |
| 11:49:22 | <dkayiwa> yony258: anytime you want :) |
| 11:52:22 | <dkayiwa> yony258: can you also look at this? http://levelup.lishman.com/spring/form-processing/controller.php |
| 11:52:26 | <OpenMRSBot> <http://ln-s.net/+:6p> (at levelup.lishman.com) |
| 11:52:27 | *** suranga has quit IRC |
| 11:52:50 | <yony258> dkayiwa: sure, will the redirect I wrote work? |
| 11:53:02 | <dkayiwa> yony258: did it fail? |
| 11:53:14 | <yony258> dkayiwa: Trying now |
| 11:53:29 | <dkayiwa> yony258: do not fear to try out |
| 11:55:03 | <yony258> dkayiwa: ;) |
| 11:55:37 | <yony258> dkayiwa: it says Build Failure because of the @RequestParam |
| 11:56:06 | <yony258> dkayiwa: "Cannot Find Symbol" |
| 11:57:07 | <dkayiwa> yony258: can ctrl + shift + O in the source file? |
| 11:57:40 | <yony258> What is ctrl+shift+0 ? |
| 11:57:49 | <yony258> oh o not 0 :/ |
| 11:58:06 | <yony258> dkayiwa: nope can't |
| 11:58:57 | <dkayiwa> yony258: add import org.springframework.web.bind.annotation.RequestParam; |
| 12:02:46 | <yony258> dkayiwa: Ok, built successfully but when I enter a conceptId and press submit it says: |
| 12:02:58 | <yony258> dkayiwa: The page "/openmrs-standalone/module/trainingexample2/test.jsp" cannot be found. Check the link and try again. |
| 12:03:36 | <dkayiwa> yony258: you can just return null in the controller |
| 12:04:38 | <yony258> dkayiwa: Ok 2 questions: 1. How would it know to go to result.jsp?, 2. What is the command name does in the form:form |
| 12:07:52 | <yony258> As far as I've understood the commandName is a bean |
| 12:08:51 | <dkayiwa> yony258: can you have a look at this first? http://levelup.lishman.com/spring/form-processing/controller.php |
| 12:08:51 | <OpenMRSBot> <http://ln-s.net/+:6p> (at levelup.lishman.com) |
| 12:09:22 | <yony258> dkayiwa: Yea sure I'll read it now and comeback here when I finish. |
| 12:09:30 | <dkayiwa> yony258: ok |
| 12:15:06 | *** kavuri has quit IRC |
| 12:18:33 | *** kavuri has joined #openmrs |
| 12:18:53 | *** kjoseph has joined #openmrs |
| 12:19:20 | <kjoseph> hi every one |
| 12:19:22 | <kjoseph> dkayiwa: hi |
| 12:19:28 | <dkayiwa> kjoseph: hi |
| 12:20:31 | <kjoseph> dkayiwa: what could be the main cause and way of dealing with the following error: $ git push origin master fatal: unable to connect to github.com: github.com[0: 207.97.227.239]: errno=No error |
| 12:20:55 | <dkayiwa> kjoseph: network problem |
| 12:21:12 | <dkayiwa> kjoseph: so just try again |
| 12:21:22 | <kjoseph> dkayiwa: okay |
| 12:22:23 | *** larapihrwanda has joined #openmrs |
| 12:24:26 | <yony258> dkayiwa: Ok I read it |
| 12:24:58 | <yony258> dkayiwa: Should I return "redirect:result.jsp" and create a controller with RequestMapping "../result" ? |
| 12:25:33 | <dkayiwa> yony258: can you also read the corresponding view? http://levelup.lishman.com/spring/form-processing/view.php |
| 12:25:36 | <OpenMRSBot> <http://ln-s.net/+:7s> (at levelup.lishman.com) |
| 12:25:44 | <yony258> dkayiwa: ok |
| 12:29:14 | <yony258> dkayiwa: Ok, read it, can you teach me how to apply this to my example? |
| 12:29:43 | <dkayiwa> yony258: yes thats exactly where we are heading :) |
| 12:29:54 | <yony258> dkayiwa: Thank you! |
| 12:30:43 | <dkayiwa> yony258: can you start by changing the view to match the one in the link? |
| 12:31:34 | *** jkeiper has joined #openmrs |
| 12:31:34 | *** ChanServ sets mode: +v jkeiper |
| 12:31:38 | <yony258> dkayiwa: The result view? |
| 12:31:51 | <dkayiwa> yony258: test.jsp |
| 12:32:35 | <yony258> dkayiwa: Im not sure what do you mean |
| 12:33:34 | <yony258> dkayiwa: Currently it has an input type text with name conceptId, and an input type submit with the value search |
| 12:34:00 | <dkayiwa> yony258: do you see the path attribute in the link i sent? |
| 12:34:07 | <yony258> yea |
| 12:34:15 | <dkayiwa> yony258: can you use the same? |
| 12:34:31 | *** sunbiz has joined #openmrs |
| 12:34:31 | *** ChanServ sets mode: +v sunbiz |
| 12:35:24 | <yony258> dkayiwa: But as far as I've understood the path depends on the modelAttribute, for example Country.area is modelAttribute = Country, Path=area |
| 12:35:47 | <dkayiwa> yony258: yes and your model attribute is the conceptname |
| 12:37:40 | <yony258> dkayiwa: So modelAttribute= conceptname, path=conceptId? |
| 12:38:15 | <dkayiwa> yony258: path is whichever property of that object you want to be displayed |
| 12:38:51 | <yony258> dkayiwa: Ok but in this form I want the user to input the id, and than display the concept name in a different place |
| 12:40:04 | <dkayiwa> yony258: ok then in that case you can just leave the jsp as it was |
| 12:40:12 | <yony258> dkayiwa: ok |
| 12:45:10 | <yony258> dkayiwa: So we took the id from the input and retrieved the concept name into the model as "conceptname", now what I cant seem to do is to open the "result.jsp" and just load the value of "conceptname" into the "result.jsp" page. |
| 12:45:33 | *** suranga has joined #openmrs |
| 12:47:35 | <yony258> dkayiwa: I am able to load the concept details from to "test.jsp" after clicking submit, |
| 12:48:25 | <dkayiwa> yony258: do you have a controller for the result.jsp? |
| 12:48:49 | <yony258> dkayiwa: I created a controller but dont know what to do there |
| 12:49:09 | <yony258> dkayiwa: I mean what methods do I need? |
| 12:49:26 | <dkayiwa> yony258: to populate the model that is to be displayed in the page |
| 12:49:33 | <dkayiwa> yony258: just like we did for test.jsp |
| 12:50:25 | <kjoseph> dkayiwa: please cheque at: http://pastebin.com/J7mbJjHw and help to advise me on how to overcome that |
| 12:53:03 | <dkayiwa> kjoseph: did you create a kjoseph github account? |
| 12:53:30 | <kjoseph> dkayiwa: yes |
| 12:53:42 | <dkayiwa> kjoseph: can you give me the url to it? |
| 12:55:17 | <kjoseph> dkayiwa: https://github.com/009614 |
| 12:55:18 | *** kavuri has quit IRC |
| 12:55:51 | <dkayiwa> kjoseph: why 009614 |
| 12:55:59 | <dkayiwa> instead of kjoseph |
| 12:56:37 | <kjoseph> dkayiwa: okay, i thought that was to be the user name |
| 12:58:06 | <dkayiwa> kjoseph: for instance mine is here https://github.com/dkayiwa |
| 13:02:22 | <suranga> howdy gents :-) |
| 13:02:54 | <suranga> anyone familiar with Spring exception handling for a quick question ? :-) |
| 13:03:23 | <dkayiwa> suranga: just ask everyone :) |
| 13:03:45 | <dkayiwa> kjoseph: what are you doing now?' |
| 13:03:48 | <suranga> dkayiwa, here goes :-) |
| 13:04:46 | <kjoseph> dkayiwa: creating one but it looks like kjoseph is taken already, am trying something different |
| 13:05:16 | <dkayiwa> kjoseph: ok |
| 13:07:25 | <suranga> hi all |
| 13:07:26 | <suranga> im trying to implement basic authentication provided in the webservies.rest module in the hl7query module as well. |
| 13:07:27 | <yony258> dkayiwa: Sorry had to go do something. So do I just return "redirect:result.jsp" and than in the result controller RequestMapping "../result" and than what do I need to write in the function in order to display in result.jsp the conceptname defined in the "test.jsp" controller. |
| 13:07:43 | <suranga> im trying to implement basic authentication provided in the webservies.rest module in the hl7query module as well. |
| 13:07:44 | <suranga> Im making my controoler extend BaseRestController etc, and have the spring beans in place. |
| 13:07:44 | <suranga> now when i try to access a url without signing in, I get a popup asking me to sign in. |
| 13:07:44 | <suranga> but the problem is, my sign in doesnt work. for example, I can keep entering my credentials, but the system wont authenticate me. |
| 13:07:44 | <suranga> Is there som other configuration (other than the spring org.springframework.web.servlet.mvc.annotation.AnnotationMethodHandlerExceptionResolver bean) that I should set / configure ? |
| 13:18:48 | <yony258> dkayiwa: Alright so I've created the controller but still back to the first problem, im getting 404 after redirect, it says it cannot find "result.jsp" |
| 13:29:55 | <kjoseph> dkayiwa: it is: https://github.com/k-joseph |
| 13:34:04 | *** dkayiwa_ has joined #openmrs |
| 13:34:15 | *** wluyima has quit IRC |
| 13:34:30 | *** dkayiwa has quit IRC |
| 13:35:52 | *** dkayiwa_ is now known as dkayiwa |
| 13:40:09 | <dkayiwa> hi yony258 |
| 13:40:40 | <yony258> dkayiwa: hi |
| 13:41:09 | <yony258> dkayiwa: Apparently the ModelMap values cant be transferred between pages, correct me if im wrong? |
| 13:41:36 | <yony258> (for example between "test.jsp" controller and "result.jsp" controller) |
| 13:42:06 | <dkayiwa> yony258: why? |
| 13:42:29 | <dkayiwa> yony258: they can be transfered |
| 13:42:54 | <yony258> dkayiwa: I dont know but when I did finally was able to redirect to "result.form" (Not "result.jsp") the conceptname in the model was null (Even though I did assigned a value to it) |
| 13:43:09 | <yony258> (BTW do you know why *.form worked and *.jsp didn't?) |
| 13:43:25 | <sunbiz> suranga: are u using header to authenticate?? |
| 13:43:37 | <dkayiwa> yony258: one ways is as a url parameter |
| 13:43:59 | <sunbiz> suranga: I mean Authorization: Basic <userpassBase64encoded> ?? |
| 13:44:14 | <dkayiwa> yony258: eg: redirect:result.form?param=value |
| 13:44:19 | <yony258> dkayiwa: yea thats what im trying now |
| 13:45:50 | <yony258> dkayiwa: ok so what I did is redirect to: "result.form?conid=32" |
| 13:45:55 | <yony258> where conid is conceptid |
| 13:46:13 | <dkayiwa> yony258: why conid instead of conceptid? |
| 13:46:17 | <yony258> and than trying to get the value using: @PathVariable("conid") int id |
| 13:46:27 | *** suranga has quit IRC |
| 13:46:30 | <yony258> dkayiwa: just for training purpose |
| 13:46:41 | <yony258> dkayiwa: Is that ok until now? |
| 13:46:41 | <dkayiwa> yony258: why not the full name? |
| 13:46:52 | <yony258> dkayiwa: I'll change it now to conceptId |
| 13:47:07 | <yony258> dkayiwa: But except of the name, does that sounds ok? |
| 13:47:07 | <dkayiwa> yony258: did you mean @RequestParam ? |
| 13:47:24 | <yony258> dkayiwa: @RequestParam works for url parameters? |
| 13:47:32 | <dkayiwa> yony258: yes |
| 13:47:47 | * yony258 Trying @RequestParam |
| 13:48:46 | *** fishandwalk has quit IRC |
| 13:49:17 | <yony258> dkayiwa: Works ! |
| 13:49:38 | <dkayiwa> yony258: ok |
| 13:50:12 | <yony258> dkayiwa: Now only thing I didnt understood in what I did is why redirecting to ".../result.jsp" didnt worked, but redirecting to "../result.form" worked ?? |
| 13:50:45 | <dkayiwa> yony258: i think that is openmrs specific instead of sprint |
| 13:50:47 | <dkayiwa> t=g |
| 13:51:07 | <dkayiwa> yony258: where openmrs expects and does .form = .jsp |
| 13:52:11 | <yony258> dkayiwa: got it. So just want to say thank you, probably would've taken me a couple of days without your help, I appreciate it. |
| 13:52:16 | *** kavuri has joined #openmrs |
| 13:52:40 | <dkayiwa> yony258: thanks for your patience too :) |
| 13:56:09 | *** rafa has joined #openmrs |
| 13:56:09 | *** ChanServ sets mode: +v rafa |
| 13:57:28 | *** rubailly has joined #openmrs |
| 14:19:49 | *** kavuri has quit IRC |
| 14:21:15 | *** yony258 has quit IRC |
| 14:25:41 | <kjoseph> dkayiwa: please, i kindly request you to check on developers list to view and contribute to my post, thank you |
| 14:26:18 | *** wluyima has joined #openmrs |
| 14:26:28 | <dkayiwa> kjoseph: already seen it :) |
| 14:48:47 | *** kjoseph has quit IRC |
| 14:57:28 | *** larapihrwanda has quit IRC |
| 14:59:36 | *** djazayeri has joined #openmrs |
| 14:59:36 | *** ChanServ sets mode: +o djazayeri |
| 15:00:51 | <djazayeri> good morning people |
| 15:02:22 | <djazayeri> Chris is going to be late, so are we ready to scrum? |
| 15:03:03 | <djazayeri> rafa: is the university call over yet? |
| 15:03:07 | <rafa> djazayeri: yes |
| 15:03:17 | <djazayeri> okay, in that case: |
| 15:03:20 | <djazayeri> !scrumon djazayeri |
| 15:03:20 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready. |
| 15:03:40 | <djazayeri> today's order: wluyima, dkayiwa, rafa, jkeiper |
| 15:04:11 | <djazayeri> then djazayeri |
| 15:04:16 | *** andreap_ has joined #openmrs |
| 15:04:53 | <djazayeri> wluyima: you there? |
| 15:05:02 | <wluyima> Tuesday: |
| 15:05:02 | <wluyima> Complete TRUNK-3609 - Updated obs did not get displayed correctly on dashboard |
| 15:05:02 | <wluyima> Review TODOs for TRUNK-3774 - failsafe plugin for integration tests and TRUNK-3586 - Update unit testing environment to use mocks |
| 15:05:02 | <wluyima> dev list emails |
| 15:05:02 | <wluyima> |
| 15:05:04 | <wluyima> Wednesday: |
| 15:05:08 | <wluyima> Pair with a dev to work on atlas module tickets |
| 15:05:10 | <wluyima> Review and apply pull requests |
| 15:05:12 | <wluyima> design call |
| 15:05:14 | <wluyima> |
| 15:05:16 | <wluyima> Blockers: None |
| 15:05:56 | <andreap_> djazayeri, I'm here |
| 15:06:00 | <dkayiwa> Explored the existing appointments/scheduling modules |
| 15:06:03 | <dkayiwa> Googled and analyzed OpenMRS appointments functionality requests |
| 15:06:03 | <dkayiwa> Some IRC with Tobin's dev |
| 15:06:03 | <dkayiwa> Created appointment module sprint dashboard |
| 15:06:04 | <dkayiwa> Curated some appointment module tickets |
| 15:06:04 | <dkayiwa> Curating more as i prepare for the design call |
| 15:06:04 | <dkayiwa> No Blockers |
| 15:06:18 | <rafa> Today: |
| 15:06:18 | <rafa> * TRUNK-3586: Update unit testing environment to use mocks (tweaked up a bit wyclif's work) |
| 15:06:18 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3586 |
| 15:06:18 | <rafa> * University Call |
| 15:06:18 | <rafa> * Will look into the pull request queue. |
| 15:06:18 | <rafa> No blockers. |
| 15:06:45 | <djazayeri> jkeiper: anything to add? |
| 15:07:47 | <djazayeri> guess not |
| 15:07:49 | <djazayeri> me |
| 15:07:51 | <djazayeri> Yesterday |
| 15:07:51 | <djazayeri> * Mirebalais work |
| 15:07:51 | <djazayeri> * a bit of Kenya work |
| 15:07:51 | <djazayeri> Today |
| 15:07:51 | <djazayeri> * Lots of calls |
| 15:07:51 | <djazayeri> * Mirebalais work, if I have time |
| 15:07:52 | <djazayeri> No blockers |
| 15:07:57 | <djazayeri> andreap_: your turn |
| 15:08:16 | <andreap_> Tuesday |
| 15:08:16 | <andreap_> Split ticket TRUNK-3814 into two tickets |
| 15:08:16 | <andreap_> TRUNK-3814 Missing Validators for realationship_type |
| 15:08:16 | <andreap_> TRUNK-3816 Erroneous/Incomplete Validators for program. |
| 15:08:16 | <andreap_> TRUNK-3474 |
| 15:08:16 | <andreap_> Put link to pull request, requested review |
| 15:08:18 | <andreap_> Claim/start work on TRUNK-2768 |
| 15:08:20 | <andreap_> emails |
| 15:08:22 | <andreap_> Wednesday |
| 15:08:24 | <andreap_> Work on TRUNK-2768 |
| 15:08:26 | <andreap_> Merck meeting |
| 15:08:28 | <andreap_> Blockers None |
| 15:08:54 | <djazayeri> Okay, no blockers, no discussion points |
| 15:08:58 | <djazayeri> !scrumoff |
| 15:08:58 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:09:11 | <wluyima> andreap_, do you want to w ork on atlas tickets/ |
| 15:09:19 | <wluyima> andreap_, do you want to work on atlas tickets? |
| 15:09:30 | <andreap_> djazayeri, stilll wondering about no button for request review |
| 15:10:01 | <andreap_> wluyima, ok I could do that |
| 15:11:03 | <djazayeri> andreap_: next time you find a ticket like that, file an IT Support ticket in JIRA, including a link to the ticket that's appearing wrong |
| 15:11:08 | <djazayeri> and attach a screenshot, I guess. |
| 15:14:29 | *** andreap_ has quit IRC |
| 15:14:40 | <wluyima> andreap_, why i asked is that kiran told me you wanted to work onit since Merck has a keen interest in that module |
| 15:16:45 | *** downey has joined #openmrs |
| 15:16:45 | *** OpenMRSBot sets mode: +o downey |
| 15:16:45 | *** ChanServ sets mode: +o downey |
| 15:23:02 | *** kavuri has joined #openmrs |
| 15:24:39 | *** afiles has joined #openmrs |
| 15:29:33 | *** larapihrwanda has joined #openmrs |
| 15:29:53 | <downey> Hi larapihrwanda and welcome to the #openmrs IRC channel. |
| 15:31:42 | *** tobin_g has joined #openmrs |
| 15:32:04 | <tobin_g> Hi dkayiwa, how's it going? |
| 15:32:14 | <dkayiwa> tobin_g: so far so good :) |
| 15:32:17 | <tobin_g> dkayiwa: bussy reviewing tickets i see :-) |
| 15:32:28 | <dkayiwa> tobin_g: hahaha. sort of :) |
| 15:32:43 | <larapihrwanda> Hi Micheal |
| 15:32:58 | <tobin_g> dkayiwa: if you have any questions etc let me know |
| 15:33:07 | <dkayiwa> tobin_g: will surely do so |
| 15:33:10 | <tobin_g> dkayiwa: anything I can do to help prepare for tonight's call? |
| 15:33:42 | <dkayiwa> tobin_g: looks like you have done all i can think of for now :) |
| 15:34:49 | *** larapihrwanda has left #openmrs |
| 15:35:06 | *** larapihrwanda has joined #openmrs |
| 15:35:15 | <tobin_g> dkayiwa: excellent! should we plan a short call with you, me, yonatan, and adam to figure out logistics of the sprint? i want to make sure scrum time is good for everyone etc |
| 15:35:41 | <dkayiwa> tobin_g: no problem |
| 15:35:58 | <tobin_g> dkayiwa: want to make sure I understand how I can best support you guys as "sprint leader" - new to me |
| 15:36:06 | <dkayiwa> tobin_g: ok |
| 15:36:08 | <larapihrwanda> actually had a question, was trying to go rogue and wanted to override the openmrs validators, is it possible to do that in a module |
| 15:37:24 | <dkayiwa> larapihrwanda: is that for making the validation less strict? :) |
| 15:37:29 | <larapihrwanda> yep |
| 15:37:42 | <dkayiwa> larapihrwanda: like for which validator? |
| 15:38:26 | <tobin_g> dkayiwa: when is good for you? |
| 15:39:10 | *** rafa has quit IRC |
| 15:39:58 | <larapihrwanda> at the moment I want to override the patient identifier validator, so that I can ignore the uniqueness check (that way the code can sit in a module until the functionality is available in core, rather than having to support a unique branch of 1.9) |
| 15:40:13 | <dkayiwa> tobin_g: whenever it is good for you |
| 15:40:22 | <tobin_g> dkayiwa: i'm free tonight, not completely sure of my clinic schedule for tomorrow. i'm guessing adam & yonatan are flexible but will have to check. |
| 15:40:45 | <larapihrwanda> but I am sure I will find other places I want to override standard validation as well |
| 15:41:08 | <dkayiwa> tobin_g: ok |
| 15:41:40 | <tobin_g> dkayiwa: want to talk ~20 minutes before the call tonight? |
| 15:42:01 | <dkayiwa> tobin_g: good for me |
| 15:42:14 | <tobin_g> dkayiwa: checking with the other guys |
| 15:42:28 | <dkayiwa> tobin_g: ok |
| 15:42:41 | <djazayeri> larapihrwanda: the underlying core code does |
| 15:42:41 | <djazayeri> for (Validator validator : getValidators(object)) { |
| 15:42:41 | <djazayeri> validator.validate(object, errors); |
| 15:42:41 | <djazayeri> } |
| 15:43:15 | <djazayeri> and that seems to be based on "all matching handlers" |
| 15:44:29 | <djazayeri> larapihrwanda: so, offhand I don't think this can be overridden in a module. |
| 15:45:03 | <djazayeri> larapihrwanda: I think I would support adding some sort of "ValidationScheme" interface, so that the implementation of "getValidators(Object)" can be overridden by a client. |
| 15:45:21 | *** dkayiwa_ has joined #openmrs |
| 15:46:35 | *** dkayiwa has quit IRC |
| 15:46:35 | *** dkayiwa_ is now known as dkayiwa |
| 15:46:58 | <larapihrwanda> djazayer: think that sounds like a good idea, but ideally don't want to have to upgrade my war |
| 15:47:49 | <djazayeri> yeahâ¦offhand I can't think of anything that will help you if you can't upgrade the war. |
| 15:48:21 | <djazayeri> larapihrwanda: well, there's on uber-hacky thing... |
| 15:48:42 | <djazayeri> that might possibly work |
| 15:48:48 | *** suranga has joined #openmrs |
| 15:48:48 | <larapihrwanda> djazayeri: okay I am thinking (and I know this is the hackiest idea ever, and will only work for this one case), is create a validator with a lower order, have it identify the duplicate id, change it (append something unique), add another validator of a higher order and change it back |
| 15:49:00 | <larapihrwanda> djazayeri: is that likely to work |
| 15:49:19 | <djazayeri> you could have a module provide a completely new implementation of HibernateAdministrationDAO, basically just extending the existing DAO and overriding that one method... |
| 15:50:02 | <djazayeri> then you could define in your moduleApplicationContext.xml a BeanFactoryPostProcessor (or some similar class) which would modify the bean definition for AdministrationService to point to your new DAO instead of the core one. |
| 15:51:09 | <djazayeri> larapihrwanda: I can't think of any reason the low/hi thing wouldn't work. Though I agree that it is the hackiest idea ever. |
| 15:52:20 | <larapihrwanda> djazayeri: now you know why I wanted the hacks name in the module id, your idea might be slightly lower on the hack scale and might give me the ability to deal with other issues as they arise |
| 15:53:33 | *** kishoreyekkanti has quit IRC |
| 15:56:59 | <djazayeri> larapihrwanda: hmm, searching my email for BeanFactoryPostProcessor to send you an example, I came across this email from Rafal... |
| 15:57:13 | <djazayeri> We learned that the problem was caused by BeanFactoryPostProcessor which should never be used in OpenMRS since it breaks our interceptors. The alternative is BeanPostProcessor. Please have that in mind developing your modules. See https://tickets.openmrs.org/browse/META-218 for details. |
| 15:58:37 | *** mallan_ has joined #openmrs |
| 15:58:48 | <downey> Hi mallan_ and welcome to the #openmrs IRC channel. |
| 16:01:14 | <mallan_> @downey:how are you |
| 16:01:27 | <downey> mallan_: fine, thanks :) |
| 16:01:59 | <mallan_> @downey :need help with openmrs tables |
| 16:02:09 | <dkayiwa> larapihrwanda: there is another alternative to add to your arsenal or possibilities |
| 16:02:16 | <downey> mallan_: lots of people here to help if you explain your questions |
| 16:02:23 | <dkayiwa> larapihrwanda: just incase you did not talk about it while i got disconnected |
| 16:03:08 | <larapihrwanda> dkayiwa: interested in any ideas |
| 16:03:19 | <dkayiwa> larapihrwanda: you can create a new validator and register it in your moduleApplicationContext.xml |
| 16:03:21 | <djazayeri> larapihrwanda: so I'd definitely ask Rafal about this if you do take the post-processor approach. (e.g. does he remember if it's really *never never* on BFPP), in case BPP doesn't work for some reason. |
| 16:03:41 | <dkayiwa> larapihrwanda: then OpenMRS will list it in the list of validators for each identifier type |
| 16:04:14 | <mallan_> downey:my tables in navicat are corrupted and i can not access OpenMRS |
| 16:05:32 | <larapihrwanda> dkayiwa: the problem is that I would like to remove validation, so would need a way to stop the openmrs one from running |
| 16:06:29 | <larapihrwanda> djazayeri: so in your opinion is my really dodgy approach likely to be safer, I really don't want to break sync, still recovering from the last outtage |
| 16:08:21 | <djazayeri> Your really dodgy approach scares me a bit, though I can't think of anything I _know_ will be bad |
| 16:08:56 | <djazayeri> My only concern is that as soon as you run into the next problem, you're going to have to take my approach anyway. :-) |
| 16:08:58 | <djazayeri> larapihrwanda: ^^ |
| 16:10:17 | <djazayeri> larapihrwanda: I'd spend a few minutes seeing if doing a BeanPostProcessor will let you slot in your own ImbHibernateAdministrationDAO bean |
| 16:10:27 | <djazayeri> if so, that may open up a world of possibilities. |
| 16:10:37 | <djazayeri> (But partly I may just want you to do this because I'm curious.) |
| 16:10:49 | <jkeiper> heh |
| 16:17:08 | <larapihrwanda> djazayeri: okay, I will play around with it. Though not ruling out it leading to another whinge about 1.9 validation for existing implementations |
| 16:19:45 | <tobin_g> dkayiwa: ok we're set for 840 (i think you're same time zone), 20 mins. before meeting. skype or adobe connect? |
| 16:21:38 | <dkayiwa> tobin_g: they both work for me :) |
| 16:22:23 | <tobin_g> dkayiwa: do you know if we can turn on the connect room audio? |
| 16:22:46 | <djazayeri> tobin_g: ping me then and I'll turn it on if it isn't already |
| 16:23:13 | <tobin_g> djazayeri: thanks :-) |
| 16:23:30 | <tobin_g> dkayiwa: ok I'll see you on adobe connect on a bit. |
| 16:23:39 | <dkayiwa> tobin_g: sure! |
| 16:25:02 | *** mallan_ has quit IRC |
| 16:27:21 | *** afiles has left #openmrs |
| 16:29:14 | <wluyima> anybody wants to pair with me? |
| 16:44:02 | *** sgithens has joined #openmrs |
| 16:49:47 | *** shangxiao has joined #openmrs |
| 16:49:59 | <downey> Hi shangxiao and welcome to the #openmrs IRC channel. |
| 16:50:23 | <shangxiao> hi - i've been here a few times already ;) |
| 16:50:33 | <shangxiao> or is this a bot that I'm talking to |
| 16:50:36 | <shangxiao> lol |
| 16:50:40 | <dkayiwa> :D |
| 16:50:44 | <shangxiao> michael downey right? |
| 16:51:02 | <shangxiao> lol daniel it's a bot? |
| 16:51:03 | <downey> shangxiao: as far as i know :) |
| 16:51:14 | <shangxiao> lol |
| 16:51:25 | <dkayiwa> shangxiao: do not worry :D |
| 16:51:34 | <downey> my memory isn't always great. ;-) |
| 16:51:58 | <shangxiao> well I've never chat to you - mainly rafa, daniel and darius |
| 16:52:28 | <shangxiao> so anyway I need a topic for a module |
| 16:52:51 | <shangxiao> I want to show how to use jpa annotations but thought if there was a real module that needed to be created |
| 16:53:08 | <shangxiao> would be good to also show how to use angularjs |
| 16:54:49 | <dkayiwa> shangxiao: how about https://tickets.openmrs.org/browse/AM-1 |
| 16:57:32 | <shangxiao> waiting for page to load... |
| 17:01:00 | <dkayiwa> hi tobin_g |
| 17:01:16 | *** tobin_g has quit IRC |
| 17:01:19 | <shangxiao> dkayiwa: I thought an appointment module was already implemented? |
| 17:01:36 | <dkayiwa> shangxiao: we are creating a new one :) |
| 17:01:45 | <shangxiao> i see |
| 17:01:49 | <shangxiao> who's working on it |
| 17:01:52 | <dkayiwa> shangxiao: https://wiki.openmrs.org/display/RES/Visit+Scheduling+or+Queueing |
| 17:08:05 | <shangxiao> who are yonatan grinberg and adam lauz |
| 17:08:14 | <shangxiao> are they core devs like you? |
| 17:08:21 | <dkayiwa> shangxiao: no |
| 17:09:25 | <shangxiao> well if you want me to show you how to setup the orm with jpa i can certainly help with that |
| 17:09:40 | <shangxiao> I have a fork of our module that runs with jpa |
| 17:09:51 | <dkayiwa> shangxiao: ok |
| 17:11:46 | <shangxiao> besides this module, are there any other ideas? I was thinking of also demonstrating angularjs + require.js and unit testing with jasmine |
| 17:12:25 | <dkayiwa> shangxiao: do you wanna do an OpenMRS University Call for it? |
| 17:13:19 | <shangxiao> what's that? |
| 17:13:57 | <dkayiwa> shangxiao: https://wiki.openmrs.org/display/RES/OpenMRS+University |
| 17:13:58 | <OpenMRSBot> <http://ln-s.net/98-d> (at wiki.openmrs.org) |
| 17:17:26 | <shangxiao> I suppose I could - although it would be better to actually have some code written ;) |
| 17:17:54 | <shangxiao> dkayiwa: for your appointment module what gui technology are you using? |
| 17:17:58 | <dkayiwa> shangxiao: its all up to you. you choose what you wanna take us through :) |
| 17:18:50 | <dkayiwa> shangxiao: not limited to but including jsp,jquery |
| 17:24:11 | <shangxiao> well let me know if you want help! |
| 17:24:47 | <dkayiwa> shangxiao: oh thanks. will surely do so. thanks again for helping :D |
| 17:28:34 | *** shangxiao has quit IRC |
| 17:29:47 | *** robbyoconnor has quit IRC |
| 17:30:39 | *** robbyoconnor has joined #openmrs |
| 17:30:39 | *** ChanServ sets mode: +v robbyoconnor |
| 17:36:22 | *** larapihrwanda has quit IRC |
| 17:53:12 | *** kishoreyekkanti has joined #openmrs |
| 18:07:00 | *** rafa has joined #openmrs |
| 18:07:00 | *** ChanServ sets mode: +v rafa |
| 18:11:00 | *** robbyoconnor has quit IRC |
| 18:16:03 | *** Adam_ has joined #openmrs |
| 18:16:18 | <downey> Hi Adam_ and welcome to the #openmrs IRC channel. |
| 18:21:29 | *** kavuri has quit IRC |
| 18:32:37 | *** suranga has quit IRC |
| 18:35:34 | *** tobin_g has joined #openmrs |
| 18:36:06 | *** tobin_g_ has joined #openmrs |
| 18:36:16 | <downey> Hi tobin_g_ and welcome to the #openmrs IRC channel. |
| 18:37:06 | *** sgithens has quit IRC |
| 18:38:44 | <tobin_g_> djazayeri: no audio! |
| 18:40:15 | *** tobin_g has quit IRC |
| 18:40:16 | *** tobin_g_ is now known as tobin_g |
| 18:40:46 | <tobin_g> dkayiwa: What is your skype? |
| 18:40:49 | *** suranga has joined #openmrs |
| 18:40:49 | *** ChanServ sets mode: +v suranga |
| 18:40:57 | <dkayiwa> tobin_g: kayiwadaniel |
| 18:41:22 | <tobin_g> dkayiwa: I think djazayeri just fixed adobe connect |
| 18:41:24 | <tobin_g> thanks djazayeri |
| 18:41:30 | <dkayiwa> tobin_g: yes :) |
| 18:41:37 | <djazayeri> tobin_g: yeah, to stop the hold music someone needs to call in via freeconferencing |
| 18:42:16 | <djazayeri> tobin_g: or should I just kill the audio bridge? |
| 18:42:34 | <tobin_g> djazayeri: thanks, my skype crashed :-\ |
| 18:42:36 | <djazayeri> tobin_g, dkayiwa: I've stopped that |
| 18:42:43 | <dkayiwa> ok |
| 18:42:48 | <djazayeri> do you need skype? |
| 18:42:56 | <djazayeri> or is the built-in connect audio enough for now? |
| 18:43:43 | *** sunbiz has left #openmrs |
| 18:49:57 | *** rafa has quit IRC |
| 18:56:21 | *** tobin_g has quit IRC |
| 19:09:36 | *** rubailly has quit IRC |
| 19:10:07 | *** rubailly has joined #openmrs |
| 19:16:38 | <rubailly> hey Darius |
| 19:16:45 | <rubailly> do you have a second? |
| 19:16:47 | <djazayeri> hi Bailly |
| 19:16:58 | <djazayeri> I'm on a call now, but I can answer in the background |
| 19:17:13 | <rubailly> great |
| 19:17:33 | <rubailly> I have a problem with the lookup tag of htmlformentry |
| 19:18:03 | <rubailly> I'm trying to get patient's encouters in my form and I copied this from the wiki: |
| 19:18:13 | <rubailly> <lookup complexExpression="#foreach($encounter in $fn.allEncounters()) $encounter.encounterDatetime #end"/> |
| 19:18:31 | <rubailly> but nothing is being displayed in my form |
| 19:19:06 | <rubailly> I can't find what I'm missing here |
| 19:19:16 | <rubailly> I'm using HTML Form Entry 1.9.4 |
| 19:21:06 | *** Echidna has quit IRC |
| 19:21:16 | *** Echidna has joined #openmrs |
| 19:21:16 | *** ChanServ sets mode: +v Echidna |
| 19:34:03 | <djazayeri> rubailly: hmmâ¦let me look on the wiki for an example... |
| 19:37:32 | *** Adam_ has quit IRC |
| 19:53:13 | *** kishoreyekkanti has quit IRC |
| 20:19:11 | *** rubailly has quit IRC |
| 20:19:40 | *** rubailly has joined #openmrs |
| 20:23:41 | *** wluyima has quit IRC |
| 20:26:11 | *** wluyima has joined #openmrs |
| 20:37:21 | *** lh has joined #openmrs |
| 20:37:21 | *** lh has joined #openmrs |
| 20:43:58 | *** suranga has quit IRC |
| 20:55:28 | *** dkayiwa has quit IRC |
| 20:55:41 | *** dkayiwa has joined #openmrs |
| 20:59:12 | *** rubailly has quit IRC |
| 20:59:31 | *** downey has quit IRC |
| 21:09:46 | *** lh has quit IRC |
| 21:23:02 | *** dkayiwa has quit IRC |
| 21:23:36 | *** dkayiwa has joined #openmrs |
| 21:54:30 | *** wluyima has quit IRC |