IRC Chat : 2012-11-20 - OpenMRS

00:30:57 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: reportingrest 1.0.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=reportingrest&ampversion=&amp1.0.1>
00:42:23 <sunbiz> djazayeri: do you know if in trunk we cannot see globalproperties that are blank??
00:42:42 <sunbiz> wluyima: do you know if in trunk we cannot see globalproperties that are blank??
00:43:19 <djazayeri> sunbiz: I haven't run trunk in months
00:43:44 <sunbiz> I've a module globalproperty that has a blank default value and that global property doesn't appear
00:43:54 <sunbiz> I mean its not shown, nor registered
00:45:20 <sunbiz> I dread not updating trunk...
00:45:37 <sunbiz> *updating*
00:50:47 <sunbiz> oh... it seems none of the globalproperties are saved...
00:52:13 <sunbiz> :-(
00:52:26 <sunbiz> djazayeri: is there a place to check if all tests are working on CI
00:52:28 <sunbiz> for trunk??
00:52:34 <djazayeri> ci.openmrs.org
00:53:42 <sunbiz> trunk tests are not there
00:53:56 <sunbiz> I cant see any unit test plan there...
00:53:59 <sunbiz> very very odd
00:54:11 <sunbiz> unless some1 is working on making new ci plans now!
00:56:44 <sunbiz> djazayeri: can you see it??
00:57:13 <djazayeri> sunbiz: it's actually this one
00:57:14 <djazayeri> https://ci.openmrs.org/browse/JU-CORE
00:57:25 <djazayeri> sunbiz: complain to downey about how unintuitive it is to find that one plan. :-)
00:59:01 <sunbiz> djazayeri: thanks! that small 1 node trees
01:47:19 *** sunbiz has quit IRC
02:32:34 *** djadmin has joined #openmrs
02:44:44 *** nribeka has joined #openmrs
02:44:44 *** ChanServ sets mode: +v nribeka
02:48:53 *** djadmin has quit IRC
02:49:46 *** djadmin has joined #openmrs
03:04:26 *** Dheeraj__ has joined #openmrs
03:07:50 *** djadmin has quit IRC
03:10:22 *** djazayeri1 has joined #openmrs
03:13:46 *** djazayeri has quit IRC
03:16:23 *** robbyoconnor has joined #openmrs
03:16:23 *** ChanServ sets mode: +v robbyoconnor
03:34:30 *** Dheeraj__ has quit IRC
03:56:33 *** sgithens has joined #openmrs
04:13:59 *** sgithens has quit IRC
04:41:48 *** nribeka has quit IRC
04:45:23 *** kishoreyekkanti has joined #openmrs
04:47:35 *** fishandwalk has joined #openmrs
05:21:19 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: reportingrest 1.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=reportingrest&ampversion=&amp1.1>
05:53:10 *** kishoreyekkanti_ has joined #openmrs
05:55:43 *** kishoreyekkanti has quit IRC
05:55:43 *** kishoreyekkanti_ is now known as kishoreyekkanti
06:00:46 *** sgithens has joined #openmrs
06:01:47 *** djadmin has joined #openmrs
06:07:59 *** kishoreyekkanti has quit IRC
06:08:19 *** kishoreyekkanti has joined #openmrs
06:16:52 *** djadmin has quit IRC
06:20:14 *** djadmin has joined #openmrs
06:25:28 *** djadmin has quit IRC
06:28:31 *** djadmin has joined #openmrs
06:35:16 *** Dheeraj__ has joined #openmrs
06:35:25 *** djadmin has quit IRC
06:51:18 *** djadmin has joined #openmrs
06:53:34 *** Dheeraj__ has quit IRC
06:53:48 *** Dheeraj__ has joined #openmrs
06:55:51 *** djadmin has quit IRC
07:08:39 *** djadmin has joined #openmrs
07:10:34 *** Dheeraj__ has quit IRC
07:13:11 *** shangxiao has joined #openmrs
07:15:59 *** Dheeraj__ has joined #openmrs
07:17:07 <shangxiao> djazayeri1: are there any modules on the todo list?
07:17:20 *** djazayeri1 is now known as djazayeri
07:17:27 <djazayeri> shangxiao: you mean full modules that need writing?
07:17:31 <shangxiao> yep
07:18:01 <djazayeri> shangxiao: not exactly. there are tickets for existing modules
07:18:18 <shangxiao> djazayeri: I was thinking of doing a proper annotation example with tests for rafa but thought maybe doing it for a complete module
07:18:21 <shangxiao> ah ok
07:18:36 <djazayeri> but full modules generally aren't sitting around, spec'd out and ready to go, but not developed yet. :-)
07:18:46 <shangxiao> lol
07:18:53 <shangxiao> probably not ;)
07:19:18 *** djadmin has quit IRC
07:19:32 <shangxiao> so I'm working on the concept proposal thing in Australia - the orm has been a little over-engineered for a nice easy example for newcomers
07:20:36 <djazayeri> shangxiao: the orm for the concept proposal project? or the orm in general?
07:20:52 <shangxiao> just our module
07:21:54 <djazayeri> shangxiao: I've been very curious how that module is going
07:22:21 <djazayeri> shangxiao: and incidentally, the work that Rafal led on a metadatamapping module provides something that I think was key to concept proposals
07:22:50 <djazayeri> that is, it provides a conception of having subscribed to a dictionary source
07:23:10 <djazayeri> and being able to see which of your metadata are new, versus in the dictionary
07:23:55 <shangxiao> so we actually have traction now - the main hurdle was just understanding the technical approach
07:24:34 <shangxiao> and yes I do believe there were a lot of similarities between proposals and the "MDSM"
07:25:19 <shangxiao> however we thought that having a separate module would allow you to do some nice things
07:25:50 <djazayeri> shangxiao: but in particular we just pulled some stuff out of MDS specifically to be able to support things like concept proposals...
07:26:38 <djazayeri> I agree that in general you don't want to reuse MDS.
07:27:49 <shangxiao> If you have a separate module you can start to supply some of the supporting context around the concept proposal - eg If a new form is needed - perhaps supplying the form along with the concepts to help explain the rationale?
07:28:35 <shangxiao> anyhoo we've gotten so far as building screens for the "client side" based on the mockups that you supplied ;)
07:29:47 <djazayeri> shangxiao: definitely curious to see how it goes—for now…bedtime
07:30:11 <shangxiao> it's actually up on a server - next time I see you on here I can show you ;)
07:30:42 <djazayeri> oh, should have known you all would have followed good CI/CD practice...
07:31:19 <shangxiao> lol
07:37:38 *** djadmin has joined #openmrs
07:38:59 *** Dheeraj__ has quit IRC
07:52:13 *** djadmin has quit IRC
07:55:32 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: reportingrest 1.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=reportingrest&ampversion=&amp1.2>
08:08:52 *** dkayiwa has joined #openmrs
08:52:09 *** djadmin has joined #openmrs
09:06:23 *** djadmin has quit IRC
10:09:03 *** shangxiao has quit IRC
10:12:49 *** shangxiao has joined #openmrs
10:49:02 *** rafa has joined #openmrs
10:49:02 *** ChanServ sets mode: +v rafa
11:24:54 *** r0bby has joined #openmrs
11:24:54 *** ChanServ sets mode: +v r0bby
11:27:21 *** robbyoconnor has quit IRC
11:48:16 *** r0bby has quit IRC
11:55:45 *** kishoreyekkanti has quit IRC
11:56:25 *** kishoreyekkanti has joined #openmrs
11:57:08 *** kishoreyekkanti has joined #openmrs
12:20:45 *** nribeka has joined #openmrs
12:20:45 *** ChanServ sets mode: +v nribeka
12:38:25 *** sunbiz has joined #openmrs
12:38:25 *** ChanServ sets mode: +v sunbiz
12:38:38 <sunbiz> hey guys...
12:38:50 <sunbiz> dkayiwa: were u able to reproduce the issue??
12:39:15 <sunbiz> sorry for wasting your time... should have written creation... instead of saving of global properties
12:40:49 <rafa> sunbiz: hey, I've just installed omodreloader and gps have not been created indeed
12:42:28 <sunbiz> rafa: yes, I think it was a changeset from a few days back
12:42:33 <sunbiz> that is causing the issue
12:42:41 <rafa> sunbiz: do you know which one?
12:42:53 <sunbiz> in the AdministrationService...
12:43:23 <sunbiz> last nite was digging into it... but then couldn't
12:43:32 <sunbiz> I've been scared to update the code :D
12:44:08 <sunbiz> the toString issue was one of them
12:44:15 <sunbiz> but that u reverted yest
12:45:45 <rafa> sunbiz: ok, thanks, let me quickly debug
12:46:35 <rafa> sunbiz: ahh I forgot I removed gp from omod reloader ;)
12:46:42 <rafa> sunbiz: need to test with a different module
13:10:59 *** jkeiper has joined #openmrs
13:10:59 *** ChanServ sets mode: +v jkeiper
13:32:09 <rafa> sunbiz: it should work now
13:32:24 <rafa> sunbiz: missing @Transactional on the AdministrationService method
13:32:39 <rafa> sunbiz: *class
13:32:59 <rafa> sunbiz: committed 20 days ago ;)
13:37:12 *** dkayiwa has quit IRC
13:41:57 *** fishandwalk has quit IRC
13:45:47 <jkeiper> anyone working on mirebalais here?
13:47:13 <sunbiz> rafa: thanks!
13:47:33 <rafa> jkeiper: I was working for the last week
13:48:00 <rafa> sunbiz: thanks for reporting this
13:49:25 *** dkayiwa has joined #openmrs
13:53:44 <jkeiper> rafa, you don't happen to know a link for demoing the registration system, do you?
13:55:44 <rafa> jkeiper: you can go here http://bamboo.pih-emr.org:8080/mirebalais/login.htm
13:55:47 <OpenMRSBot> <http://ln-s.net/+-PZ> (at bamboo.pih-emr.org:8080)
13:56:00 <rafa> jkeiper: admin:Admin123
13:56:32 *** suranga has joined #openmrs
13:56:32 *** ChanServ sets mode: +v suranga
13:56:42 <suranga> howdy rafa :-)
13:56:54 <rafa> suranga: hi
13:57:03 <suranga> rafa, sorry to bug you again :(
13:57:08 <jkeiper> rafa, thanks!
13:57:31 <suranga> rafa, thank you for your comments, I tried them out, but um... they dont seem to change the current behavior...
13:57:44 <rafa> suranga: I see
13:57:49 <suranga> rafa, I havdent made any changes to the HL7QueryPrivilegeConstants.java class
13:58:06 <suranga> you mentioned that you couldnt get it to compile ?
13:58:10 <rafa> suranga: maybe, but I don't have it
13:58:27 <rafa> suranga: you need to commit it
13:58:50 <suranga> rafa, sure thing, let me do try that...
14:06:43 *** kishoreyekkanti has quit IRC
14:12:19 <suranga> rafa, hi,
14:12:24 <suranga> rafa, just pushed :)
14:12:46 <suranga> rafa, I also added in all the changes you had recommended into my commit
14:12:50 <suranga> plus the missing class
14:13:30 <shangxiao> rafa what's the expected release date of 1.9.2?
14:13:57 <rafa> suranga: ok, have a look later
14:14:15 <rafa> shangxiao: I was hoping to get it out by the end of the current sprint
14:14:23 <shangxiao> when does that end?
14:14:27 <suranga> rafa, one more experiment. I tried commenting out all the code in the controller im triggering, and added a throw new authenticationException() right to the top. for some reason, calling that url now doesnt give me any exception, but rather redirects me to the login page...
14:14:31 <rafa> shangxiao: next week
14:14:39 <suranga> rafa, no worries, ill take a second look too :-)
14:14:47 <shangxiao> oh ok that's good :)
14:36:23 *** cpower has joined #openmrs
14:36:32 <cpower> Hey djazayeri
14:41:09 *** cpower has quit IRC
14:43:41 *** dkayiwa has quit IRC
14:49:10 <shangxiao> didn't djazzy just go to sleep?
14:49:32 <shangxiao> i was just talking to him a few hours ago and he said "time for bed" ;)
14:51:52 *** shangxiao has quit IRC
14:53:45 *** afiles has joined #openmrs
14:58:38 *** cpower has joined #openmrs
15:00:41 *** andrea_ has joined #openmrs
15:02:10 <cpower> Good morning!
15:02:27 <andrea_> cpower, good morning to you
15:02:32 <cpower> Let's us place our fingers on the keyboard and have our morning scrum :-)
15:02:39 <cpower> !scrumon cpower
15:02:39 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
15:03:17 <cpower> Order: Rafa, suranga, andrea, djazayeri, wluyima and go!
15:03:23 <rafa> Today:
15:03:23 <rafa> * Fixed issue with updating GPs, TRUNK-208
15:03:23 <rafa> https://tickets.openmrs.org/browse/TRUNK-208
15:03:23 <rafa> * Reviewed some code for suranga
15:03:23 <rafa> * Reviewed mocks for wyclif, TRUNK-3586
15:03:24 <rafa> * Back ported TRUNK-3632: Update build so it doesn't look at svn revision
15:03:24 <rafa> https://tickets.openmrs.org/browse/TRUNK-3632
15:03:25 <rafa> No blockers.
15:06:23 <cpower> suranaga...
15:06:29 <cpower> Next andrea_
15:06:47 <andrea_> Monday
15:06:47 <andrea_> Created ticket TRUNK-3814 for issues found when working on TRUNK-3474
15:06:47 <andrea_> Investigated TRUNK-2768 Add column deathdate_estimated to person table
15:06:47 <andrea_>
15:06:47 <andrea_> Tuesday
15:06:49 <andrea_> Claim, work on TRUNK-2768
15:06:50 <andrea_> and/or
15:06:52 <andrea_> Claim, work on TRUNK-3814
15:06:54 <andrea_> Blocker
15:06:58 <andrea_> TRUNK-2768
15:07:00 <andrea_> Need further explanation of the following:
15:07:02 <andrea_> Change the editPersonInfo.jsp and viewPersonInfo.jsp files so that users can
15:07:04 <andrea_> edit it via the webapp.
15:07:06 <andrea_> The PersonFormController and PatientFormControllers might need to be changed
15:07:08 <andrea_> as well to accept the user input.
15:07:10 <andrea_> (the accept user input part)
15:07:12 <andrea_> (Have not worked on any jsps yet)
15:07:44 <cpower> djazayeri
15:08:08 <djazayeri> Monday
15:08:08 <djazayeri> * Released Reporting REST for Kenya EMR versions 1.0.1, 1.1, 1.2, :-)
15:08:08 <djazayeri> * Mirebalais work
15:08:08 <djazayeri> Today
15:08:09 <djazayeri> * Mirebalais work (finish annoying merge patients story!)
15:08:10 <djazayeri> no blockers
15:08:41 <cpower> wluyima
15:08:43 <wluyima> Monday:
15:08:43 <wluyima> Created atlas module tickets
15:08:43 <wluyima> Discussed TRUNK-3609 with Jeremy and Lauren
15:08:43 <wluyima> TRUNK-3609 - Updated obs did not get displayed correctly on dashboard
15:08:43 <wluyima> Tuesday:
15:08:44 <wluyima> Community dev swimlane tickets
15:08:46 <wluyima> Review TODOs for RUNK-3586 - Update unit testing environment to use mocks
15:08:48 <wluyima>
15:08:50 <wluyima> Blockers: Obs edit form seems to be broken
15:09:04 <cpower> Blockers
15:09:05 <cpower> TRUNK-2768
15:09:05 <cpower> [10:07] <andrea_> Need further explanation of the following:
15:09:05 <cpower> [10:07] <andrea_> Change the editPersonInfo.jsp and viewPersonInfo.jsp files so that users can
15:09:05 <cpower> [10:07] <andrea_> edit it via the webapp.
15:09:05 <cpower> [10:07] <andrea_> The PersonFormController and PatientFormControllers might need to be changed
15:09:06 <cpower> [10:07] <andrea_> as well to accept the user input.
15:09:06 <cpower> [10:07] <andrea_> (the accept user input part)
15:09:07 <cpower> [10:07] <andrea_> (Have not worked on any jsps yet
15:09:08 <cpower> and
15:09:18 <cpower> <wluyima> Blockers: Obs edit form seems to be broken
15:09:55 <andrea_> cpower, it's the change to accept user input part I don't understand
15:10:24 <rafa> !ticket TRUNK-2768
15:10:28 <OpenMRSBot> rafa: [#TRUNK-2768] Add column deathdate_estimated to person table - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2768
15:10:36 <djazayeri> andrea_: the idea is that in addition to adding a column to the data model, we need to allow users to _edit_ that field.
15:11:09 <djazayeri> andrea_: so basically wherever there is a death_datetime field in the UI, you would put a checkbox next to it for death_datetime_estimated.
15:11:47 <andrea_> djazayeri, ok think I got it
15:12:32 <andrea_> djazayeri, does anyone want to check out the ticket I created (my first ticket)?
15:12:37 <rafa> wluyima: you know what to do when something is broken :)
15:12:49 <cpower> fix it?
15:13:03 <rafa> cpower: knows :)
15:13:23 <wluyima> rafa, i know but i couldnt reproduce it on nightly, so i wanted to see if anyone else was running into before i create a ticket
15:13:28 <andrea_> djazayeri, https://tickets.openmrs.org/browse/TRUNK-3814
15:13:36 <wluyima> rafa, could be my dev environment
15:13:47 <rafa> wluyima: ok, let me test
15:13:55 <cpower> !scrumoff
15:13:55 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:14:06 <rafa> wluyima: master right?
15:15:43 <andrea_> djazayeri, rafa, wluyima, should I also work on the ticket I created?
15:16:20 <djazayeri> andrea_: about TRUNK-3814, I was asking if you can actually turn that into two ticket. One of them saying "fix ProgramValidatorTest to check for blank description" , and the second "Add RelationshipTypeValidator"
15:17:01 <djazayeri> andrea_: the idea is that more-or-less you should always pick the "next most important" ticket, and work on that.
15:17:06 <andrea_> djazayeri, yes if that's what I should do
15:17:39 <djazayeri> andrea_: I particularly picked the death_datetime_estimated ticket because it has several votes, IIRC.
15:18:24 <djazayeri> so do that, then come back to do TRUNK-3814
15:18:36 <andrea_> djazayeri, Ok
15:18:38 <djazayeri> (or else, if you get blocked, switch over to TRUNK-3814 until you're unblocked)
15:19:26 <djazayeri> andrea_: though still please reword TRUNK-3814 (to split it into two different tickets)
15:20:56 <andrea_> djazayeri, ok will do that first (split into 2)
15:22:23 <andrea_> djazayeri, alos is anyone reviewing https://tickets.openmrs.org/browse/TRUNK-3474
15:23:27 <rafa> andrea_: you forgot to link a pull request in comments and click request review
15:25:11 <andrea_> rafa, where do I link a pull request in comments?
15:25:30 <rafa> andrea_: just write a comment and put link in there
15:25:49 <andrea_> rafa, ok will do
15:51:04 *** kishoreyekkanti has joined #openmrs
16:04:04 *** r0bby has joined #openmrs
16:04:04 *** ChanServ sets mode: +v r0bby
16:06:24 *** kishoreyekkanti has quit IRC
16:08:50 *** shangxiao has joined #openmrs
16:15:27 *** afiles has quit IRC
16:32:04 *** afiles has joined #openmrs
16:32:20 *** afiles has quit IRC
16:55:46 *** rafa has quit IRC
17:07:14 *** r0bby is now known as robbyoconnor
17:25:02 *** kishoreyekkanti has joined #openmrs
17:32:28 *** andrea_ has quit IRC
17:37:56 *** shangxiao has joined #openmrs
17:49:48 *** sgithens has quit IRC
18:06:25 <cpower> .
18:06:52 <cpower> Who do we have that is closer to Isreal time that would like to help do some design work for an upcomming sprint?
18:11:36 <cpower> the silence shows great strength...
18:12:01 <cpower> Let's go with another question. Is there people currently paying attention in the channel?
18:12:35 <djazayeri> Yes.
18:12:48 <cpower> :-)
18:13:24 <djazayeri> cpower: I don't quite understand your question though… we have a design call on this tomorrow, and it'd be best to have Daniel be the one designing with them, since he's going to be on the sprint.
18:14:21 <cpower> It does, and I lost track of the fact that Daniel was identified. Does Daniel know he's doing this?
18:15:11 <djazayeri> cpower: I sent a very long email to him on this topic yesterday. I thought I cc'd you
18:15:47 <djazayeri> cpower: I've been sending you emails at regenstrief.org. Are you getting them?
18:15:49 <cpower> I'll check
18:16:34 *** jkeiper has quit IRC
18:20:06 <cpower> ok, yes I did. It got lost in my inbox with subject line of "upcoming sprint" is too generic for me to filter
18:20:37 <cpower> I'll read it and come back to this, thanks for the push in the right direction
18:23:34 *** wluyima has quit IRC
18:25:10 <djazayeri> cpower: you should filter if sender=darius then label=OMG!IMPORTANT!!!
18:27:37 *** rafa has joined #openmrs
18:27:37 *** ChanServ sets mode: +v rafa
18:50:22 *** shangxiao has quit IRC
18:50:38 *** wluyima has joined #openmrs
19:03:40 <sunbiz> aur kya??
19:04:09 <sunbiz> :P
19:04:13 <sunbiz> oops
19:11:37 *** dkayiwa has joined #openmrs
19:27:21 <suranga> based on my knowlege of hindi movies, think sunbiz was asking 'what' or 'say what' in hindi :-)
19:29:15 <sunbiz> suranga: yup!! thats right
19:29:43 * suranga thanks Sharuk khan and Amtab bacchan for increaisng my language skills :-) :-)
19:30:04 <sunbiz> suranga: awesome!! so it helps!! not learnt Tamil yet??
19:30:06 <sunbiz> :P
19:31:57 <suranga> sunbiz, tamil movies not as popular as hindi movies :D
19:32:39 *** kishoreyekkanti has quit IRC
19:56:06 *** afiles has joined #openmrs
20:02:05 *** rafa has quit IRC
20:03:49 *** afiles has quit IRC
20:05:31 *** cpower has quit IRC
20:39:30 *** suranga has quit IRC
21:10:59 *** cpower has joined #openmrs
21:11:21 <cpower> let's try that again... djazayeri you around?
21:11:46 <djazayeri> yes
21:12:11 <cpower> cool, I will not be around most likely for the scrum tomorrow. Can you cover?
21:12:34 <djazayeri> cpower: sure
21:13:08 <cpower> Thank you very much, if I get out of my appointment early enough I'll be there but don't want to leave everyone hanging if not ;-)
21:17:19 *** sunbiz has quit IRC
21:17:28 *** dkayiwa has quit IRC
21:31:08 *** cpower has quit IRC
22:02:27 *** lh has joined #openmrs
22:13:34 *** robbyoconnor has quit IRC
22:14:15 *** lh has quit IRC
22:15:44 *** lh has joined #openmrs
23:32:35 *** andreapat has joined #openmrs
23:34:55 <andreapat> djazayeri, you around?
23:35:02 <djazayeri> andreapat: yes
23:36:21 <andreapat> djazayeri, hi - re TRUNK_3474 code review don't see any button to click request review
23:37:06 <djazayeri> andreapat: I do when I look at that ticket.
23:37:15 <djazayeri> Did you have this problem before on one computer but not another?
23:37:53 <andreapat> djazayeri, have only looked at it on work computer
23:38:26 <djazayeri> andreapat: do you see any buttons? (you're logged in, right?)
23:39:29 <andreapat> djazayeri, yes am logged in
23:41:20 <andreapat> djazayeri, see edit comment link to standup, more actions unassign but no request review
23:42:17 <djazayeri> andreapat: nothing to the right of unassign?
23:43:06 <andreapat> djazayeri, a grayed out workflow to right of unassign
23:43:14 <djazayeri> andreapat: odd
23:43:31 <djazayeri> andreapat: I clicked Request Code Review for you.
23:44:20 <andreapat> djazayeri, ok thanks
23:44:42 <andreapat> djayeri, so button should be up on top?
23:46:04 <djazayeri> andreapat: should have been right to the right of Unassign
23:47:19 <andreapat> djazayeri, nope not there but I see it's status has changed to Code Review now - good