00:08:33
|
*** lhawthor_ has joined #openmrs
|
00:12:01
|
*** lh has quit IRC
|
00:20:16
|
*** sgithens has quit IRC
|
00:49:00
|
*** djazayeri has quit IRC
|
02:37:20
|
*** jkeiper_ has quit IRC
|
02:37:29
|
*** jkeiper_ has joined #openmrs
|
02:41:09
|
*** jkeiper_ has quit IRC
|
02:56:26
|
*** djazayeri has joined #openmrs
|
02:56:26
|
*** ChanServ sets mode: +o djazayeri
|
03:36:21
|
*** sgithens has joined #openmrs
|
03:47:06
|
*** djadmin has joined #openmrs
|
03:59:38
|
*** sgithens has quit IRC
|
04:20:43
|
*** Dheeraj__ has joined #openmrs
|
04:23:50
|
*** djadmin has quit IRC
|
04:31:09
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 2.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=uiframework&version=&2.2>
|
04:37:39
|
*** Dheeraj__ has quit IRC
|
04:38:06
|
*** kishoreyekkanti has joined #openmrs
|
04:38:26
|
*** kishoreyekkanti has joined #openmrs
|
05:09:09
|
*** fishandwalk has joined #openmrs
|
05:31:39
|
*** kishoreyekkanti_ has joined #openmrs
|
05:32:46
|
*** Dheeraj__ has joined #openmrs
|
05:34:54
|
*** kishoreyekkanti has quit IRC
|
05:34:54
|
*** kishoreyekkanti_ is now known as kishoreyekkanti
|
05:54:15
|
*** kishoreyekkanti has quit IRC
|
05:54:34
|
*** kishoreyekkanti has joined #openmrs
|
06:06:00
|
*** lhawthor_ is now known as lh
|
06:38:44
|
*** lh has quit IRC
|
07:48:02
|
*** sgithens has joined #openmrs
|
07:50:57
|
*** shangxiao has joined #openmrs
|
07:52:05
|
*** Dheeraj__ has quit IRC
|
07:53:25
|
<robbyoconnor> didymo: Hi
|
07:53:37
|
<robbyoconnor> consider doing some simple patches
|
07:53:42
|
<robbyoconnor> ;)
|
07:54:02
|
<robbyoconnor> did you get any help?
|
07:55:32
|
*** shangxiao has quit IRC
|
08:03:52
|
<didymo> robbyocconnor evening
|
08:04:34
|
*** Dheeraj__ has joined #openmrs
|
08:16:54
|
<robbyoconnor> night for me!
|
08:16:56
|
<robbyoconnor> adios!
|
08:22:52
|
*** dkayiwa has joined #openmrs
|
08:28:53
|
*** djadmin has joined #openmrs
|
08:31:42
|
*** Dheeraj__ has quit IRC
|
09:41:10
|
*** djazayeri has quit IRC
|
09:43:21
|
*** shangxiao has joined #openmrs
|
09:48:29
|
*** didymo has quit IRC
|
09:59:30
|
*** djadmin has quit IRC
|
10:19:05
|
*** djadmin has joined #openmrs
|
10:37:03
|
*** rafa has joined #openmrs
|
10:37:03
|
*** ChanServ sets mode: +v rafa
|
10:38:07
|
<shangxiao> hey rafa
|
10:38:14
|
<rafa> shangxiao: hey
|
10:38:24
|
<shangxiao> I've been playing around with annotations ;)
|
10:38:32
|
*** suranga has joined #openmrs
|
10:38:32
|
*** ChanServ sets mode: +v suranga
|
10:38:45
|
<shangxiao> but there may be a problem with setting up relationships with hbm mapped entities
|
10:39:11
|
<rafa> shangxiao: there should be no problem
|
10:39:28
|
<rafa> shangxiao: unless we setup something wrong
|
10:39:35
|
<rafa> shangxiao: what's the problem?
|
10:39:40
|
<shangxiao> rafa: I tried to link to a User and it complains about an unmapped entity
|
10:39:46
|
<shangxiao> using @ManyToOne
|
10:40:17
|
<rafa> shangxiao: make sure you import the right user :)
|
10:40:47
|
<rafa> shangxiao: I mean org.openmrs.User
|
10:41:13
|
<shangxiao> yes Eclipse automatically picks it up from maven
|
10:41:38
|
<rafa> shangxiao: yes, but make sure you picked the right import ;)
|
10:41:49
|
<rafa> shangxiao: there are org.h2.engine.User, org.hsqldb.User, ...
|
10:42:16
|
<shangxiao> pretty sure it was openmrs... just checking
|
10:44:08
|
<shangxiao> eclipse is taking it's sweet time...
|
10:44:48
|
<rafa> shangxiao: :)
|
10:47:54
|
<shangxiao> I was trying to extend User - that got the module compiling but then it complained when the AuditableInterceptor was trying to write an object of type User
|
10:48:03
|
<shangxiao> I'll just revert and try it again
|
10:48:08
|
<shangxiao> with regular user
|
10:48:51
|
<rafa> shangxiao: yeah, we didn't write our code to allow for extending model classes
|
10:49:39
|
<rafa> shangxiao: you need to wrap model classes instead
|
10:53:52
|
<shangxiao> rafa: hm that's interesting... the module starts now with the map to hbm User ;)
|
10:54:00
|
<shangxiao> I must've made an update that fixed it
|
10:54:09
|
<shangxiao> it might've been the presence of @JoinColumn
|
10:54:14
|
<rafa> shangxiao: cool
|
10:54:17
|
<shangxiao> :D
|
10:54:51
|
<shangxiao> it's funny because I saw some people talk about this problem in hibernate forums and people were saying "nah it can't be done"
|
10:55:00
|
<shangxiao> moral of the story: don't always believe what you read
|
10:56:07
|
<rafa> shangxiao: yeah many wrong people out there, always check more sources ;)
|
10:56:49
|
<rafa> shangxiao: and Hibernate is a beast :P
|
10:56:57
|
<rafa> shangxiao: easy to get it wrong
|
10:57:34
|
<shangxiao> now I just need to figure out how the core code sets uuid
|
10:57:56
|
<shangxiao> when I attempt to save() getting an sqlexception stating that uuid doesn't have a default value
|
10:58:12
|
<rafa> shangxiao: see BaseOpenmrsObject
|
10:58:34
|
<shangxiao> yeah I'm just having a look at that now but no default code - I'll have a look at the api module
|
10:58:44
|
<rafa> shangxiao: your model class should extend it
|
10:59:14
|
<rafa> shangxiao: or BaseOpenmrsData or BaseOpenmrsMetadata ;)
|
11:00:34
|
<shangxiao> it's just extending BaseOpenmrsObject
|
11:00:42
|
<shangxiao> the code works with hbm setup
|
11:00:52
|
<shangxiao> I found the code that sets the uuid
|
11:00:55
|
<shangxiao> it's in OpenmrsObjectSaveHandler
|
11:01:37
|
<rafa> shangxiao: SaveHandler does it too, but since 1.9 we set UUID when object is created that is in BaseOpenmrsObject
|
11:02:28
|
<shangxiao> oh lol yeah it's at the top
|
11:02:46
|
<shangxiao> hm so that's odd
|
11:03:34
|
<rafa> shangxiao: I believe you need to override getUuid in your class
|
11:03:40
|
<rafa> shangxiao: and annotate it with @Basic
|
11:03:58
|
<rafa> shangxiao: so that Hibernate knows it needs to be put in a db
|
11:04:50
|
<rafa> shangxiao: we don't have BaseOpenmrsObject mapped in a hbm or annotated with @MappedSuperclass to say that
|
11:05:39
|
<rafa> shangxiao: precisely you need to annotate getUuid with @Column(name = "uuid", unique = true, nullable = false, length = 38)
|
11:06:37
|
<rafa> shangxiao: are you experimenting with the same jpa example module or working on something real?
|
11:09:02
|
<shangxiao> ah of course!
|
11:09:35
|
<shangxiao> rafa: of course, hibernate won't examine superclasses and if it's not mapped with a hbm then it won't know to bind uuid
|
11:09:43
|
<shangxiao> I'll try that! ;)
|
11:09:52
|
<shangxiao> I'm working on something real
|
11:10:04
|
<rafa> shangxiao: great, do you have it published on github?
|
11:10:22
|
<rafa> shangxiao: I need to write some docs around JPA annotations
|
11:10:28
|
<rafa> shangxiao: and a working example would be great
|
11:10:32
|
<shangxiao> so I've forked the "real" module to play with this annotation stuff for now
|
11:10:42
|
<shangxiao> https://github.com/rapilabs/openmrs-cpm
|
11:10:47
|
<rafa> shangxiao: perfect
|
11:10:56
|
<shangxiao> branch is "jpa-annotations"
|
11:11:15
|
<shangxiao> I'm going to put in the uuid stuff now though
|
11:11:39
|
<rafa> shangxiao: okay, let me know how it goes
|
11:22:45
|
<suranga> hi rafa
|
11:22:52
|
<rafa> suranga: hi
|
11:22:54
|
<suranga> rafa, terribly sorry, me again :(
|
11:23:15
|
<rafa> suranga: haha cheer up :)
|
11:23:31
|
<rafa> suranga: no worries
|
11:23:35
|
<suranga> rafa, small problem, im afraid. I did that fix to the hl7query controller
|
11:24:36
|
<suranga> now, the problem is that my query is triggered by a call to Hl7Querycontroller. but the moment that I make my controller extend the BAseRestController (which Ive renamed)
|
11:24:57
|
<suranga> the request stops working, and responds that it cant find the page Im calling :(
|
11:25:19
|
<suranga> rafa, when I type in my request into the url, I get "The page "/openmrs/module/hl7query/ORUR01.htm" cannot be found. Check the link and try again. "
|
11:25:21
|
<rafa> suranga: I take you're working on this change in a branch that you pushed to github, right? :)
|
11:25:35
|
<rafa> suranga: so that I can look at it
|
11:25:44
|
<suranga> rafa, nothing commited into github yet, im afraid :(
|
11:25:59
|
<rafa> suranga: so go ahead and push it
|
11:26:03
|
<rafa> suranga: do you need a hand?
|
11:26:54
|
<suranga> rafa, im rather rusty with branching and pushing, plus im working on something else at the moment. but let me try this out and get back to you ? :-)
|
11:27:06
|
<rafa> suranga: okay
|
11:56:17
|
<rafa> dkayiwa: hi
|
11:56:25
|
<rafa> dkayiwa: how is merging pull requests going?
|
11:56:25
|
<dkayiwa> rafa: hi
|
11:56:43
|
<dkayiwa> rafa: hahahah. for today am curating tickets :)
|
11:56:56
|
<rafa> dkayiwa: booo
|
11:57:22
|
<dkayiwa> rafa: but as far as last week was, was just pressing the githum merge magic button :)
|
11:57:34
|
<dkayiwa> githum = github :)
|
11:58:25
|
<dkayiwa> rafa: any potential problems with that magic button? :)
|
11:59:01
|
<rafa> dkayiwa: a failing build ;)
|
11:59:14
|
<dkayiwa> rafa: hahahahaha. :)
|
11:59:33
|
<dkayiwa> rafa: looks like i should not use it? :)
|
11:59:46
|
<rafa> dkayiwa: it's ok for simple changes
|
11:59:53
|
<dkayiwa> rafa: ok
|
12:00:03
|
<rafa> dkayiwa: but from my experience it's not ok for 98% of cases
|
12:00:07
|
<rafa> ;)
|
12:00:25
|
<rafa> dkayiwa: you really want to run tests before merging
|
12:01:55
|
<dkayiwa> rafa: how? may be i should just read the merge wiki page again :)
|
12:02:08
|
<rafa> dkayiwa: yes, that's how :)
|
12:02:18
|
<dkayiwa> rafa: :D
|
12:29:51
|
*** kjoseph has joined #openmrs
|
12:35:19
|
*** kjoseph has quit IRC
|
12:43:39
|
<shangxiao> rafa: do you prefer annotations on fields or getters?
|
12:44:06
|
<rafa> shangxiao: in core almost all are on getters, but I prefer on fields
|
12:44:27
|
<shangxiao> looks like I'll need to use @access on the getUuid()
|
12:44:42
|
<rafa> shangxiao: what is @access?
|
12:45:25
|
<shangxiao> rafa: to force hibernate to look at getUuid() if you annotate @Id on a field http://stackoverflow.com/a/4202413/739106
|
12:45:42
|
<shangxiao> by default it only looks at fields if the @Id is a field
|
12:45:50
|
<shangxiao> and vice versa for getters
|
12:46:18
|
<rafa> shangxiao: I see
|
12:46:33
|
<shangxiao> i never knew this ;)
|
12:46:33
|
<rafa> shangxiao: yeah, I remember now
|
12:56:18
|
*** kjoseph has joined #openmrs
|
12:59:19
|
<dkayiwa> hi kjoseph
|
13:00:03
|
<kjoseph> dkayiwa: hi
|
13:00:27
|
<dkayiwa> kjoseph: how is it going?
|
13:02:26
|
<kjoseph> dkayiwa: in response too your message, i tried running: git push original master
|
13:09:28
|
<kjoseph> dkayiwa: info == kaweesi joseph@KJOSEPHN0TEBUK /d/PROGRAMMER/openmrs project/openmrs/module/testm odule $ git push original master fatal: Not a git repository (or any of the parent directories): .git
|
13:09:43
|
*** robbyoconnor has quit IRC
|
13:10:59
|
<dkayiwa> kjoseph: where did you read that command?
|
13:11:44
|
<kjoseph> dkayiwa: in the directory where i had created the module from
|
13:12:14
|
<dkayiwa> kjoseph: where did you READ that command?
|
13:15:28
|
<kjoseph> dkayiwa: from one of the git pages after reading using git : https://wiki.openmrs.org/display/docs/Using+Git
|
13:16:02
|
<dkayiwa> kjoseph: can you just copy and paste here the command that you did read from that page?
|
13:19:21
|
*** kishoreyekkanti_ has joined #openmrs
|
13:19:40
|
<kjoseph> dkayiwa: git push, git push original master, i tried the first one and it gave mme the usame error message, i think am not yet sure of the exact like syntax of the git push command,
|
13:21:01
|
<dkayiwa> kjoseph: did you just type that command yourself or copied and pasted from the wiki page?
|
13:21:05
|
*** jkeiper has joined #openmrs
|
13:21:05
|
*** ChanServ sets mode: +v jkeiper
|
13:22:54
|
*** kishoreyekkanti has quit IRC
|
13:22:54
|
*** kishoreyekkanti_ is now known as kishoreyekkanti
|
13:25:40
|
<kjoseph> dkayiwa: Push changes to your fork on github: git push
|
13:25:51
|
<kjoseph> dkayiwa: git push original master To https://github.com/<username>/<projectName>.git ! [rejected] master -> master (non-fast-forward) error: failed to push some refs to 'https://github.com/<username>/<projectName>.git' To prevent you from losing history, non-fast-forward updates were rejected Merge the remote changes (e.g. 'git pull') before pushing again. See the 'Note about fast-forwards' section of 'git push --help' fo
|
13:26:19
|
<dkayiwa> kjoseph: please use pastebin.com for text spanning more than a few lines
|
13:26:31
|
*** wluyima has quit IRC
|
13:26:36
|
<dkayiwa> kjoseph: did you understand my question?
|
13:30:11
|
<kjoseph> dkayiwa: i typed it my self but i got the command from wiki page
|
13:30:54
|
<dkayiwa> kjoseph: are you concentrating on this or doing something else at the same time?
|
13:32:11
|
<kjoseph> dkayiwa: am now ready and concentrating
|
13:32:44
|
<dkayiwa> kjoseph: can you do run the command again? but this time copying and pasting from the wiki page
|
13:35:39
|
<kjoseph> dkayiwa: am having the exact problem again,
|
13:35:58
|
<dkayiwa> kjoseph: paste here the command you used
|
13:36:52
|
<kjoseph> dkayiwa: git push
|
13:37:24
|
<dkayiwa> kjoseph: and what was the response?
|
13:37:58
|
<kjoseph> dkayiwa: $ git push fatal: Not a git repository (or any of the parent directories): .git
|
13:38:21
|
<dkayiwa> kjoseph: what does this return? git branch
|
13:39:02
|
<kjoseph> dkayiwa: $ git branch fatal: Not a git repository (or any of the parent directories): .git
|
13:39:20
|
<dkayiwa> kjoseph: ok can you give me the url to you git module?
|
13:43:48
|
<kjoseph> dkayiwa: https://github.com/009614/openmrs-module-testmodule
|
13:43:54
|
<OpenMRSBot> <http://ln-s.net/++kH> (at github.com)
|
13:45:26
|
<dkayiwa> kjoseph: how did you push this commit? https://github.com/009614/openmrs-module-testmodule/commit/739fa68eb0be803b6e8bf6a2a1e5f936cb2a081f
|
13:45:28
|
<OpenMRSBot> <http://ln-s.net/++kN> (at github.com)
|
13:47:54
|
<kjoseph> dkayiwa: i really can't remember, i thought it was an automatic commit after creating the repository
|
13:48:41
|
<dkayiwa> kjoseph: ok. can you give me the wiki page you used to create the repository?
|
13:49:39
|
<shangxiao> rafa: I've got my module working - it's a bit of a complex example though
|
13:49:54
|
<rafa> shangxiao: tests too?
|
13:49:57
|
<shangxiao> the guy we put in charge of the orm code kind of made it a bit complex
|
13:50:02
|
<shangxiao> yeah he made some tests
|
13:50:19
|
<rafa> shangxiao: have you checked they work?
|
13:50:32
|
<shangxiao> just checking now
|
13:50:33
|
<rafa> shangxiao: I think you need a bit of configuration
|
13:51:03
|
<shangxiao> it's worth noting however that it's still under development and there are bits which haven't been completed yet
|
13:51:30
|
<shangxiao> maybe for the wiki I should put together something simpler
|
13:52:01
|
<rafa> shangxiao: if you have time, it would be great
|
13:52:22
|
<rafa> shangxiao: an example like I made for core https://github.com/rkorytkowski/openmrs-core/commit/416ca5addf1c50ba65c6982fc55aaceb142d2e44
|
13:52:27
|
<OpenMRSBot> <http://ln-s.net/++kc> (at github.com)
|
13:52:35
|
<rafa> shangxiao: one commit showing how to change from hbms to annotations
|
13:53:01
|
<shangxiao> so I was thinking something that implements Auditable and extends BaseOpenmrsObject
|
13:53:14
|
<shangxiao> show how to link to User, expose uuid, etc
|
13:55:05
|
<shangxiao> and iirc the default naming scheme for hibernate was to convert camel case to underscores
|
13:56:23
|
<jkeiper> dkayiwa, i want to apply the changes you suggested to AMPATH re: form extension memory leaks
|
13:56:32
|
<jkeiper> dkayiwa, i'm going to fork and branch xforms module in my repo
|
13:56:38
|
<jkeiper> (already forked it)
|
13:56:58
|
<jkeiper> dkayiwa, question -- can you tell me what needs to be done?
|
13:57:13
|
<jkeiper> dkayiwa, perhaps describe it in a response to our email thread?
|
13:57:15
|
<jkeiper> ;-)
|
13:58:04
|
<dkayiwa> jkeiper: the patch need to got to OpenMRS 1.8.2 :)
|
13:58:22
|
<dkayiwa> jkeiper: and that should be all
|
13:58:30
|
<dkayiwa> jkeiper: no change to the xforms module :)
|
13:58:41
|
<jkeiper> dkayiwa, hahaha ... we have been debating. was the patch ever backported?
|
13:59:01
|
<dkayiwa> jkeiper: no it was not. as you can see on the ticket. fixVersion is 1.9.0
|
13:59:02
|
<jkeiper> dkayiwa, maintaining custom patches for openmrs is annoying
|
13:59:15
|
<jkeiper> dkayiwa, but it does not introduce new data model or features does it?
|
13:59:32
|
<jkeiper> dkayiwa, so it could be backported if we want?
|
13:59:42
|
<dkayiwa> jkeiper: yes
|
13:59:52
|
<jkeiper> dkayiwa, so if i backport it, it would be in 1.8.5
|
13:59:59
|
<dkayiwa> jkeiper: yes
|
14:00:01
|
<jkeiper> dkayiwa, do we know when the next release will be?
|
14:00:03
|
<jkeiper> :-D
|
14:00:10
|
<dkayiwa> jkeiper: you can ask rafa :)
|
14:00:14
|
<jkeiper> haha
|
14:00:23
|
<jkeiper> rafa, when will 1.8.5 be released?
|
14:00:32
|
<jkeiper> rafa, i want to get a patch in there and use it at AMPATH quite soon
|
14:00:38
|
<dkayiwa> jkeiper: the changes in that patch are not the ones i would get scared to apply on a production server :)
|
14:00:54
|
<rafa> jkeiper: it can be anytime if you do it :D
|
14:00:59
|
<jkeiper> hahaha
|
14:01:02
|
<jkeiper> rafa, ok
|
14:01:04
|
<rafa> jkeiper: I mean if you test and release it
|
14:01:06
|
<dkayiwa> rafa: :D
|
14:01:06
|
<rafa> ;)
|
14:01:52
|
<jkeiper> dkayiwa, i agree ... just did not want to run a custom build of 1.8.2 because i'd have to remember the patches i made and reapply them each time we do an upgrade.
|
14:02:05
|
<dkayiwa> jkeiper: oh i see
|
14:02:07
|
<jkeiper> dkayiwa, i had to do that for 1.6.x and it was a huge pain
|
14:02:10
|
<jkeiper> ;-)
|
14:02:29
|
<dkayiwa> jkeiper: this one is a fix for a serious bug and hence a must to backport :)
|
14:02:39
|
<jkeiper> dkayiwa, that's what i thought too
|
14:03:05
|
<jkeiper> i will backport it to 1.8.x today
|
14:03:13
|
<dkayiwa> jkeiper: because of that bug, no one can use 1.8.2 with xforms or htmlformentry
|
14:03:22
|
<jkeiper> dkayiwa, agreed :(
|
14:03:26
|
<dkayiwa> jkeiper: infact i wonder why it was not reported before
|
14:03:35
|
<shangxiao> anyone know the expected release date of 1.9.2?
|
14:03:47
|
<dkayiwa> jkeiper: my only conclusion is that no one is using 1.8 for entering forms yet :)
|
14:04:08
|
<jkeiper> hahahaha
|
14:04:16
|
<dkayiwa> jkeiper: for that bug makes it impossible :)
|
14:04:19
|
<jkeiper> we truly only used formentry for a long time
|
14:04:33
|
<dkayiwa> jkeiper: thats explains it
|
14:04:34
|
<jkeiper> dkayiwa, we used xforms for a while on that server but it comes and goes
|
14:04:42
|
<jkeiper> dkayiwa, the error is intermittent
|
14:04:43
|
<dkayiwa> jkeiper: hahahah :)
|
14:04:55
|
<dkayiwa> jkeiper: yes it happens when you restart the module :)
|
14:05:07
|
<jkeiper> dkayiwa, so, it's possible to not even notice the problem for quite some time heheheh
|
14:05:27
|
<dkayiwa> jkeiper: very very very true :)
|
14:06:03
|
<suranga> hi rafa :-)
|
14:06:11
|
<rafa> suranga: hi
|
14:06:12
|
<jkeiper> dkayiwa, ok ... i'll backport to 1.8.x today and run tests, see if anything remains for 1.8.5...
|
14:06:26
|
<dkayiwa> jkeiper: that will be excellent!!!
|
14:06:26
|
<suranga> rafa, I was able to solve one problem, but now facing another...
|
14:06:44
|
<suranga> rafa, I wrote it up for conveniance :-)
|
14:06:47
|
<suranga> rafa, this is the latest update on my problem.
|
14:06:48
|
<suranga> Assume Im signed out, but enter a valid url to return an hl7 message into the web browser.
|
14:06:48
|
<suranga> Now since im signed out, the authentication mechanism I developed should kick in and output an appopriate error message, right ?
|
14:06:48
|
<suranga> unfortunately, it doesnt seem to work that way.
|
14:06:48
|
<suranga> Instead, the authentication is not tackled until the service layer, where the @authorized annotation gets triggered, and I get the following error message
|
14:06:50
|
<suranga> Privileges required: [Get HL7 Templates]
|
14:06:52
|
<suranga> (which is as a result of the Annotation ) :
|
14:08:05
|
<rafa> suranga: is this caught by BaseRestController?
|
14:08:21
|
<rafa> suranga: and wrapped in a response?
|
14:08:23
|
<suranga> rafa, no, for some reason its not triggered at all
|
14:08:40
|
<suranga> I get the usual red message tape at the top of the screen :(
|
14:08:41
|
<rafa> suranga: what is the exact exception being thrown?
|
14:09:11
|
<rafa> suranga: have you pushed your code somewhere?
|
14:09:28
|
<suranga> rafa, I will be, very soon :(
|
14:09:34
|
<rafa> suranga: okay
|
14:09:41
|
<dkayiwa> kjoseph: are you still with me?
|
14:09:45
|
<rafa> BaseRestController should actually catch any exception
|
14:09:57
|
<rafa> unless it's misused somehow
|
14:10:09
|
<rafa> I don't like to speculate
|
14:10:18
|
<rafa> would be easier to see code :)
|
14:10:51
|
<kjoseph> dkayiwa: yes,
|
14:11:12
|
<dkayiwa> kjoseph: are you working on this or doing something else?
|
14:11:42
|
<kjoseph> dkayiwa: am working on it right now
|
14:12:09
|
<dkayiwa> kjoseph: ok
|
14:19:43
|
*** Dheeraj__ has joined #openmrs
|
14:23:19
|
*** djadmin has quit IRC
|
14:23:38
|
*** wluyima has joined #openmrs
|
14:28:33
|
<suranga> rafa, https://github.com/openmrs/openmrs-module-hl7query/pull/55
|
14:28:38
|
<OpenMRSBot> <http://ln-s.net/++lk> (at github.com)
|
14:28:48
|
<suranga> rafa, Ive left a detailed comment on the pull request :)
|
14:33:22
|
*** djadmin has joined #openmrs
|
14:34:11
|
<rafa> suranga: thanks, I'll be sure to get back to you later today
|
14:34:32
|
<rafa> suranga: probabaly will e-mail you
|
14:34:33
|
<kjoseph> dkayiwa: am proceeding and am now at: Enter passphrase (empty for no passphrase): from command prompt but am seeing no change when i enter the password, what can i do please, should i skip the stage!
|
14:34:45
|
<suranga> rafa, no worries. I look forward to being prodded into the right direction :P
|
14:35:08
|
<dkayiwa> kjoseph: which wiki page is it that you are following?
|
14:35:40
|
*** Dheeraj__ has quit IRC
|
14:35:55
|
<shangxiao> rafa: one of the awesome benefits of annotations is the ability to add lifecycle callbacks
|
14:36:04
|
*** sunbiz has joined #openmrs
|
14:36:04
|
*** ChanServ sets mode: +v sunbiz
|
14:36:22
|
*** fishandwalk has quit IRC
|
14:36:39
|
<sunbiz> hi guys... I was going to close this issue - !ticket TRUNK-3694
|
14:36:45
|
<sunbiz> !TRUNK-3694
|
14:36:46
|
<OpenMRSBot> sunbiz: Error: "TRUNK-3694" is not a valid command.
|
14:36:50
|
<sunbiz> !ticket TRUNK-3694
|
14:36:52
|
<OpenMRSBot> sunbiz: [#TRUNK-3694] SCM needs to be changed from SVN to GIT - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3694
|
14:37:09
|
<sunbiz> when I realized that although the code has been moved for 1.9x and other branches
|
14:37:32
|
<sunbiz> it still remains in the svn and does not have the MIGRATED convention
|
14:37:42
|
*** suranga has quit IRC
|
14:37:47
|
<kjoseph> dkayiwa: am following a tutorial for getting started with Github am generating a SSH key currently
|
14:38:07
|
<dkayiwa> kjoseph: url for the tutorial?
|
14:38:09
|
<sunbiz> can someone with full access do that - kishoreyekkanti rafa dkayiwa etc??
|
14:38:58
|
<kjoseph> dkayiwa: http://vimeo.com/6457780#t=0
|
14:39:08
|
<rafa> sunbiz: hi
|
14:40:09
|
<rafa> sunbiz: I can look into that
|
14:40:36
|
<rafa> sunbiz: thanks for reminding us
|
14:40:52
|
<dkayiwa> kjoseph: is this your github account? https://github.com/kjoseph/
|
14:42:01
|
<rafa> sunbiz: actually I don't remember what we decided
|
14:42:10
|
<dkayiwa> kjoseph: are you there?
|
14:42:20
|
<rafa> sunbiz: we have https://svn.openmrs.org/openmrs/MIGRATED
|
14:42:28
|
<rafa> sunbiz: which is at the top level
|
14:42:37
|
<kjoseph> dkayiwa: it is but that is not my username
|
14:43:05
|
<dkayiwa> kjoseph: i thought you wanted to be kjoseph
|
14:43:09
|
*** afiles has joined #openmrs
|
14:44:19
|
<kjoseph> dkayiwa: from the same page clicking 009614 at the top right of the page gets you to my account
|
14:45:12
|
<dkayiwa> kjoseph: why don't you set your account name as kjoseph?
|
14:45:20
|
<dkayiwa> kjoseph: just like we all are doing it?
|
14:46:54
|
<kjoseph> dkayiwa: i prefered kaweesi.joseph since its unique, should i change then!!!
|
14:47:28
|
<sunbiz> rafa: at the branches level
|
14:47:36
|
<dkayiwa> kjoseph: i would prefer the openmrsid convention
|
14:48:04
|
<sunbiz> coz the branches in github still refer to those branches in the scm
|
14:48:07
|
<kjoseph> dkayiwa: let me try again, connecting now using wireless,
|
14:48:14
|
<dkayiwa> kjoseph: ok
|
14:48:58
|
<sunbiz> rafa: I meant in the pom.xml for 1.9.x or older branches... it still refers to the svn location
|
14:49:32
|
<rafa> sunbiz: ohh got it
|
14:49:39
|
<rafa> sunbiz: yeah, you're right
|
14:51:11
|
<rafa> sunbiz: I'll do this, thanks.
|
14:51:16
|
<sunbiz> gr8 rafa
|
14:52:32
|
*** kjoseph has quit IRC
|
14:52:35
|
*** kishoreyekkanti has quit IRC
|
15:00:56
|
*** kjoseph has joined #openmrs
|
15:01:07
|
*** kaweesi_joseph has joined #openmrs
|
15:02:08
|
*** kaweesi_joseph has left #openmrs
|
15:02:20
|
<cpower> .
|
15:02:25
|
<cpower> Good morning!
|
15:02:48
|
<cpower> And welcome to the week where we squeeze 5 days of stuff into 3 and hope for the best
|
15:02:56
|
<cpower> Are we ready to scrum?
|
15:03:48
|
<cpower> ok so let's begin
|
15:03:51
|
<cpower> !scrumon cpower
|
15:03:51
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:04:46
|
<cpower> Order: wluyima, dkayiwa, rafa, djadmin (assuming that might be darius, if not ignore), and Andrea who I'm sure will be here soon
|
15:04:52
|
*** jkeiper has quit IRC
|
15:06:17
|
*** cpower has quit IRC
|
15:06:40
|
*** cpower has joined #openmrs
|
15:06:40
|
*** cpower has left #openmrs
|
15:06:43
|
*** andrea__ has joined #openmrs
|
15:06:44
|
*** cpower has joined #openmrs
|
15:06:44
|
<wluyima> Friday:
|
15:06:44
|
<wluyima> TRUNK-3586 - Update unit testing environment to use mocks
|
15:06:44
|
<wluyima>
|
15:06:44
|
<wluyima> Monday:
|
15:06:44
|
<wluyima> Created atlas module tickets
|
15:06:45
|
<wluyima> TRUNK-3586 - Convert more tests to use mocks
|
15:06:47
|
<wluyima>
|
15:06:49
|
<wluyima> Blockers: What is the way forward with using mocks in tests?
|
15:06:57
|
<dkayiwa> Curating tickets
|
15:06:58
|
<dkayiwa> No Blockers
|
15:07:15
|
*** djazayeri has joined #openmrs
|
15:07:15
|
*** ChanServ sets mode: +o djazayeri
|
15:07:15
|
<rafa> Today:
|
15:07:15
|
<rafa> * Mirebalais work
|
15:07:15
|
<rafa> * Some dev list discussions
|
15:07:15
|
<rafa> * Some IRC discussions
|
15:07:15
|
<rafa> No blockers.
|
15:07:38
|
*** kjoseph has quit IRC
|
15:08:11
|
<andrea__> my turn?
|
15:09:01
|
<rafa> andrea__: yes, go ahead :)
|
15:09:05
|
<andrea__> Friday
|
15:09:05
|
<andrea__> Merck meeting
|
15:09:05
|
<andrea__> Merck documentation
|
15:09:05
|
<andrea__> Pull request for TRUNK-3474
|
15:09:05
|
<andrea__> Create new ticket for issues I found when making changes for TRUNK-3474
|
15:09:06
|
<andrea__>
|
15:09:08
|
<andrea__> Monday
|
15:09:10
|
<andrea__> Create ticket (if need be)for issues I found when making changes for TRUNK-3474
|
15:09:12
|
<andrea__> Find new ticket
|
15:09:14
|
<andrea__> No blockers
|
15:09:40
|
<cpower> dkayiwa can go if he has anything
|
15:09:50
|
<cpower> otherwise it's djazayeri turn
|
15:10:12
|
<dkayiwa> cpower: i already went :)
|
15:10:26
|
<djazayeri> Friday + Weekend
|
15:10:26
|
<djazayeri> * Released UI Framework 2.2 (better support for cookies, support for @InjectBeans)
|
15:10:26
|
<djazayeri> * UI Framework documentation at https://wiki.openmrs.org/display/docs/UI+Framework+Reference+Guide
|
15:10:26
|
<djazayeri> * Mirebalais work on "merge patients" story
|
15:10:26
|
<djazayeri> Today
|
15:10:26
|
<djazayeri> * Mirebalais work
|
15:10:27
|
<djazayeri> No blockers
|
15:10:29
|
<cpower> sorry I rebooted IRC so I must have missed it
|
15:10:57
|
<cpower> Blocker: Mocks in tests how?
|
15:11:36
|
<cpower> I'll leave that for you all to discuss
|
15:11:40
|
<djazayeri> sorry, more context please on the blocker, since I missed wluyima's update?
|
15:12:01
|
<cpower> hat is the way forward with using mocks in tests?
|
15:12:32
|
<djazayeri> The way forwards is to use mocks in tests. :-) And the rest of us need to give wluyima feedback on what he's done so far.
|
15:12:33
|
<cpower> wluyima help us out with some more detail.
|
15:12:43
|
<rafa> review/rework and merge ;)
|
15:12:59
|
<djazayeri> once we're satisfied with the output of his spike, we can email out more broadly about it. :-)
|
15:13:09
|
<wluyima> djazayeri, so should i continue with more tests in the meatime
|
15:13:39
|
<djazayeri> wluyima: I think you should probably hold off until we've reviewed the current work
|
15:14:36
|
<djazayeri> I promise to get to this sometime today, but not right nowâ¦
|
15:15:14
|
<wluyima> djazayeri, does this mean i should do something else in the meantime, i can join the community dev swinlane in the meantime
|
15:15:33
|
<djazayeri> wluyima: yes, do that
|
15:15:37
|
<wluyima> dkayiwa, got a ticket for me?
|
15:15:57
|
<cpower> !scrumoff
|
15:15:57
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:16:01
|
<rafa> cpower: fogot about scrum off?
|
15:16:10
|
<djazayeri> wluyima: and work on getting the atlas module read-for-work
|
15:16:11
|
<dkayiwa> wluyima: can you look at dashboard?
|
15:16:17
|
<rafa> cpower: not ;)
|
15:16:30
|
<cpower> I was waiting to see if there was anyting else wluyima's way and then moved on
|
15:16:34
|
<wluyima> djazayeri, , i created the tickets
|
15:16:45
|
<djazayeri> wluyima: cool
|
15:16:57
|
<andrea__> djazayeri, rafa, anyone have suggestions for a new ticket for me?
|
15:17:58
|
<rafa> andrea__: how about asking dkayiwa who is the sprint leader? :)
|
15:18:17
|
<andrea__> rafa, ok
|
15:18:44
|
<andrea__> dkayiwa, any tickets you'd like me to do?
|
15:19:19
|
<dkayiwa> andrea__: can you look at the dashboard and choose any you prefer?
|
15:19:41
|
<andrea__> dkayiwa, ok
|
15:19:45
|
<djazayeri> andrea__: if not, steal ticket https://tickets.openmrs.org/browse/TRUNK-2768, since the current assignee is lost-to-followup
|
15:20:21
|
<andrea__> djazayeri, will look at that one
|
15:20:24
|
*** Dheeraj__ has joined #openmrs
|
15:20:36
|
<djazayeri> andrea__: that's just an arbitrary ticket from searching JIRA for:
|
15:20:50
|
<djazayeri> resolution = Unresolved and labels=intro order by votes desc
|
15:22:48
|
<andrea__> djazayeri, got ya
|
15:23:48
|
*** djadmin has quit IRC
|
15:29:46
|
*** shangxiao has quit IRC
|
15:34:32
|
*** Dheeraj__ has quit IRC
|
15:47:49
|
*** jkeiper has joined #openmrs
|
15:47:49
|
*** ChanServ sets mode: +v jkeiper
|
16:03:36
|
*** shangxiao has joined #openmrs
|
16:10:41
|
*** shangxiao has quit IRC
|
16:11:27
|
*** shangxiao has joined #openmrs
|
16:31:06
|
*** jordank has joined #openmrs
|
16:32:42
|
*** sgithens has quit IRC
|
16:36:14
|
*** sgithens has joined #openmrs
|
17:00:22
|
*** nribeka has joined #openmrs
|
17:00:22
|
*** ChanServ sets mode: +v nribeka
|
17:03:15
|
*** djadmin has joined #openmrs
|
17:08:23
|
*** kishoreyekkanti has joined #openmrs
|
17:08:23
|
*** Dheeraj__ has joined #openmrs
|
17:11:19
|
*** djadmin has quit IRC
|
17:14:20
|
*** andrea__ has quit IRC
|
17:30:49
|
*** jordank has quit IRC
|
17:43:39
|
*** basic` has quit IRC
|
17:45:12
|
*** basic has joined #openmrs
|
18:09:39
|
*** suranga has joined #openmrs
|
18:09:39
|
*** ChanServ sets mode: +v suranga
|
18:17:54
|
*** sgithens has quit IRC
|
18:17:59
|
*** cpower has quit IRC
|
18:19:32
|
*** shangxiao has quit IRC
|
18:24:45
|
<suranga> howdy rafa :-)
|
18:33:45
|
*** robbyoconnor has joined #openmrs
|
18:33:46
|
*** ChanServ sets mode: +v robbyoconnor
|
18:37:44
|
*** robbyoconnor has quit IRC
|
19:10:22
|
*** kishoreyekkanti has quit IRC
|
19:11:53
|
*** Dheeraj__ has quit IRC
|
20:05:14
|
*** suranga_ has joined #openmrs
|
20:06:44
|
*** suranga has quit IRC
|
20:27:08
|
<suranga_> good night guys, im afraid I havent been very productive these day :(
|
20:27:12
|
<suranga_> *s
|
20:27:17
|
*** suranga_ has quit IRC
|
20:34:32
|
*** rafa has quit IRC
|
20:40:32
|
*** afiles has quit IRC
|
20:46:42
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 2.2.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=uiframework&version=&2.2.1>
|
20:54:16
|
*** sunbiz has quit IRC
|
21:03:37
|
*** jkeiper has quit IRC
|
21:23:13
|
*** basic is now known as basic`
|
21:37:12
|
*** sunbiz has joined #openmrs
|
21:37:12
|
*** ChanServ sets mode: +v sunbiz
|
21:42:33
|
*** sgithens has joined #openmrs
|
21:43:08
|
*** lh has joined #openmrs
|
21:45:27
|
<wluyima> dkayiwa, djazayeri is any of you able to save an Obs when you change the location or value coded?
|
21:45:38
|
<djazayeri> wluyima: haven't tried
|
21:45:41
|
<djazayeri> will demo let you?
|
21:45:44
|
<djazayeri> or nightly?
|
21:45:48
|
<wluyima> djazayeri, yes
|
21:46:40
|
<djazayeri> wluyima: haven't tried, and not in a good position to nowâ¦but if it works on nightly it should be working in trunk...
|
21:46:53
|
<wluyima> djazayeri, nightly works
|
21:47:08
|
<wluyima> i see only one commit today
|
22:20:30
|
*** wluyima has quit IRC
|
22:43:44
|
<sunbiz> does anyone here get a NPE on PersonName.toString ??
|
22:45:48
|
*** sgithens has quit IRC
|
22:48:50
|
<sunbiz> ah... ok I see now, rafa reverted the problem yesterday. So there were people having issues with toString due to some earlier commit.
|
22:57:09
|
<sunbiz> I wonder how this didn't get noticed since end of Sep though :(
|
22:59:27
|
*** lh has quit IRC
|
23:10:15
|
*** wluyima has joined #openmrs
|
23:33:59
|
*** dkayiwa has quit IRC
|
23:38:49
|
*** nribeka has quit IRC
|