| 00:03:12 | *** robbyoconnor has quit IRC |
| 00:34:22 | *** wluyima has joined #openmrs |
| 00:52:30 | *** VG has joined #openmrs |
| 02:19:47 | *** nribeka has joined #openmrs |
| 02:19:47 | *** ChanServ sets mode: +v nribeka |
| 02:52:55 | *** andrea_p has quit IRC |
| 03:15:10 | *** shangxiao has joined #openmrs |
| 03:23:05 | <djazayeri> wluyima: hey, I'm running into PermGen errors when trying to do a clean install of trunk |
| 03:23:11 | <djazayeri> have you seen that? |
| 03:24:11 | <djazayeri> (oh wait, I just remembered that daniel broke the build, so I should actually be expecting failure?) |
| 03:24:14 | *** sgithens has joined #openmrs |
| 03:46:35 | *** shangxiao has quit IRC |
| 04:42:09 | *** robbyoconnor has joined #openmrs |
| 04:42:09 | *** ChanServ sets mode: +v robbyoconnor |
| 04:43:49 | *** r0bby has joined #openmrs |
| 04:43:49 | *** ChanServ sets mode: +v r0bby |
| 04:47:00 | *** kishoreyekkanti has joined #openmrs |
| 04:47:23 | *** kishoreyekkanti has joined #openmrs |
| 04:47:28 | *** robbyoconnor has quit IRC |
| 05:00:50 | *** kishoreyekkanti_ has joined #openmrs |
| 05:01:40 | *** kishoreyekkanti_ has quit IRC |
| 05:01:57 | *** kishoreyekkanti_ has joined #openmrs |
| 05:03:31 | *** kishoreyekkanti has quit IRC |
| 05:03:31 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 05:07:32 | *** shangxiao has joined #openmrs |
| 05:24:18 | *** shangxiao has quit IRC |
| 05:43:24 | *** r0bby is now known as robbyoconnor |
| 06:27:57 | *** kishoreyekkanti has quit IRC |
| 06:28:17 | *** kishoreyekkanti has joined #openmrs |
| 07:12:17 | *** dkayiwa has joined #openmrs |
| 07:43:35 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: UI Library Module 2.0.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=uilibrary&version=&2.0.1> |
| 07:59:54 | *** shangxiao has joined #openmrs |
| 08:02:46 | *** dkayiwa has quit IRC |
| 08:15:22 | *** robbyoconnor has quit IRC |
| 09:17:42 | *** djazayeri has quit IRC |
| 09:33:47 | *** rkorytkowski has joined #openmrs |
| 09:33:47 | *** ChanServ sets mode: +v rkorytkowski |
| 09:34:10 | *** rkorytkowski is now known as rafa |
| 09:50:02 | <shangxiao> ok.... when calling concept services's getAllConcepts("name", true, false) i get a dereferencing exception... "illegal attempt to dereference collection [concept0_.concept_id.names] with element property reference [name] [from org.openmrs.Concept concept where retired = false order by concept.names.name asc] |
| 09:50:54 | *** robbyoconnor has joined #openmrs |
| 09:50:54 | *** ChanServ sets mode: +v robbyoconnor |
| 10:03:11 | *** kishoreyekkanti_ has joined #openmrs |
| 10:05:35 | *** robbyoconnor has quit IRC |
| 10:06:44 | *** kishoreyekkanti has quit IRC |
| 10:06:45 | *** kishoreyekkanti_ is now known as kishoreyekkanti |
| 10:10:41 | <shangxiao> rafa how do you feel about criteria query builder? |
| 10:10:49 | <shangxiao> as opposed to manually constructing hql |
| 10:11:11 | <rafa> shangxiao: I like criteria more |
| 10:11:20 | <rafa> shangxiao: but it's a personal thing I guess ;) |
| 10:11:20 | <shangxiao> i found a bug :D |
| 10:11:32 | <shangxiao> so there's this bug with dereferencing a collection |
| 10:11:43 | <shangxiao> and i thought I might submit a patch but change the hql to criteria |
| 10:11:47 | <shangxiao> for safety |
| 10:12:17 | <shangxiao> I like the object oriented approach to building a query with criteria but it's kind of hard to read |
| 10:12:52 | <rafa> shangxiao: what I like about criteria is that it's harder to get them wrong |
| 10:12:57 | <shangxiao> yep |
| 10:12:59 | <rafa> shangxiao: and you have code completion :) |
| 10:13:04 | <shangxiao> type checking |
| 10:13:10 | <rafa> shangxiao: right |
| 10:13:15 | <shangxiao> whereas it's easier to get hql wrong |
| 10:13:44 | <rafa> shangxiao: but at the end you have to test both |
| 10:15:17 | <rafa> shangxiao: I wanted to commit your changes yesterday |
| 10:15:30 | <rafa> shangxiao: but we have a failing CI |
| 10:15:48 | <rafa> shangxiao: and I'm waiting for it to be green again |
| 10:16:04 | <rafa> shangxiao: sorry for the delay |
| 10:17:28 | <shangxiao> rafa: yes I noticed daniel's commit and i rebased again ;) |
| 10:18:13 | <rafa> shangxiao: you don't have to do that :) let me handle it from here |
| 10:18:23 | <shangxiao> ah ok just looking at the ci dashboard core is still red |
| 10:18:33 | <rafa> shangxiao: yeah |
| 10:47:03 | *** kishoreyekkanti has quit IRC |
| 10:57:23 | *** kishoreyekkanti has joined #openmrs |
| 10:57:46 | *** kishoreyekkanti has quit IRC |
| 10:58:04 | *** kishoreyekkanti has joined #openmrs |
| 11:17:33 | *** dkayiwa has joined #openmrs |
| 11:19:42 | <dkayiwa> hi rafa |
| 11:19:46 | <rafa> dkayiwa: hi |
| 11:20:02 | <dkayiwa> rafa: do you also get outofmemory when trying to run unit tests? |
| 11:20:14 | <rafa> dkayiwa: yes |
| 11:20:18 | <rafa> dkayiwa: check your mailbox |
| 11:20:24 | <dkayiwa> rafa: ok |
| 11:20:25 | <rafa> dkayiwa: I'm reverting your recent commits |
| 11:20:34 | <dkayiwa> rafa: yes i just read that :) |
| 11:20:48 | <rafa> dkayiwa: okay :) |
| 11:20:54 | <rafa> dkayiwa: I'll let you know when I'm done |
| 11:21:18 | <dkayiwa> rafa: and i think that will fix CI. not so? :) |
| 11:21:27 | <rafa> dkayiwa: yes :) |
| 11:21:34 | <dkayiwa> rafa: excellent :) |
| 11:22:56 | <dkayiwa> rafa: after that, what would be your recommendation for me to continue responding to the review comments before merging |
| 11:23:07 | <dkayiwa> rafa: do i just need to do a git pull? |
| 11:23:25 | <rafa> dkayiwa: yes |
| 11:24:29 | <rafa> dkayiwa: this guy is also failing https://github.com/openmrs/openmrs-core/commit/921e43f1342f581a8aba026e3408ba194df9c5c6 |
| 11:24:33 | <OpenMRSBot> <http://ln-s.net/+9ie> (at github.com) |
| 11:24:57 | <rafa> dkayiwa: but in web tests |
| 11:25:03 | <dkayiwa> rafa: oh |
| 11:25:32 | <dkayiwa> rafa: strange that it did not fail locally here :) |
| 11:25:54 | <rafa> dkayiwa: didn't you say that api tests were failing for you and you just ignored it? |
| 11:26:11 | <rafa> dkayiwa: if api tests fail, web tests don't even run |
| 11:27:08 | <dkayiwa> rafa: after doing a git update, some tests were failing. so i could have wrongly assumed that i got new code that made mine fail :) |
| 11:28:02 | <rafa> dkayiwa: hehe you were the only guy who committed in the last two days ;) |
| 11:28:26 | <dkayiwa> rafa: that catches me red handedly :) |
| 11:28:40 | <rafa> dkayiwa: hehe no worries |
| 11:28:53 | <dkayiwa> rafa: and worse off, i was not getting email notifications about build failures like it used to happen before :) |
| 11:29:10 | <rafa> dkayiwa: yeah I don't know why you don't get them |
| 11:29:40 | <rafa> dkayiwa: do you mind if I revert https://github.com/openmrs/openmrs-core/commit/921e43f1342f581a8aba026e3408ba194df9c5c6 as well? |
| 11:29:41 | <OpenMRSBot> <http://ln-s.net/+9ie> (at github.com) |
| 11:29:57 | <rafa> dkayiwa: and let you commit it again with fixed tests? |
| 11:30:06 | <dkayiwa> rafa: i have just gone through the steps that Darius pointed me to on the dev list. let me hope i will be notified after your revert when CI sends a happinnes message :) |
| 11:30:18 | <dkayiwa> rafa: yes go ahead and revert |
| 11:30:31 | <rafa> dkayiwa: ok |
| 11:32:21 | <dkayiwa> rafa: after the revert will the outofmemory problems get resolved too? |
| 11:32:50 | <rafa> dkayiwa: it looks like so |
| 11:32:56 | <rafa> dkayiwa: still running tests |
| 11:32:57 | <dkayiwa> rafa: ok |
| 11:41:35 | <rafa> dkayiwa: we're green :) |
| 11:41:54 | <dkayiwa> rafa: ok thanks. let me do a git pull --rebase :) |
| 11:42:31 | <rafa> dkayiwa: did CI mail you? |
| 11:42:32 | <shangxiao> green? woo |
| 11:42:43 | <dkayiwa> rafa: not yet |
| 11:43:02 | <rafa> dkayiwa: it has mailed me already ;) |
| 11:43:22 | <dkayiwa> rafa: then let me check my configs again |
| 11:43:38 | <rafa> dkayiwa: did you mark the build as favourite? |
| 11:43:49 | <dkayiwa> rafa: let me check |
| 11:44:13 | <rafa> dkayiwa: a star to the right needs to be yellow :) |
| 11:44:30 | <dkayiwa> rafa: let me check that :) |
| 11:44:40 | <rafa> dkayiwa: I've also done it for the 1.9.x and 1.8.x branches |
| 11:44:49 | <dkayiwa> rafa: ok |
| 11:44:56 | <rafa> dkayiwa: but you nee to open the branch and go to actions in the top right |
| 11:45:12 | <dkayiwa> rafa: ok |
| 12:05:52 | <shangxiao> I'm trying to run ConceptServiceTest in Eclipse and it's throwing an exception: "Failed to load ApplicationContext" |
| 12:06:14 | <shangxiao> I thought extending the base context sensitive thing was supposed to load the context |
| 12:06:18 | <dkayiwa> shangxiao: try doing a project clean |
| 12:06:27 | <rafa> shangxiao: you probably need to do mvn clean install |
| 12:06:39 | <shangxiao> oh ok I'll try both :) |
| 12:07:07 | <rafa> shangxiao: eclipse tends to build things on its own and it's not exactly the same as what mvn clean install does |
| 12:07:35 | <shangxiao> is it better to run tests from the command line? |
| 12:07:42 | <rafa> shangxiao: that's why ocassionally we have such problems with eclipse |
| 12:07:55 | <rafa> shangxiao: if you want to run all tests then command line is better |
| 12:08:07 | <rafa> shangxiao: if it's a single test then definitely eclipse |
| 12:08:19 | <shangxiao> yeah I just want to run this single test - so I can add to it |
| 12:09:39 | <shangxiao> oh goody it ran |
| 12:10:58 | <dkayiwa> rafa: by clicking the favourite star on the right to make it yellow, is that enough for me to get the build email notifications? |
| 12:11:09 | <rafa> dkayiwa: I don't know :) |
| 12:11:27 | <dkayiwa> rafa: aha :) |
| 12:11:34 | <rafa> dkayiwa: Downey should know |
| 12:11:51 | <dkayiwa> rafa: let me ask him via the dev list :) |
| 12:12:17 | <rafa> dkayiwa: ha! that's the way! |
| 12:12:26 | <dkayiwa> :) |
| 12:13:16 | <rafa> dkayiwa: you know that you should be reviewing and merging pull requests from others right? :) |
| 12:13:37 | <rafa> dkayiwa: as part of the sprint you're leading right now |
| 12:13:57 | <rafa> dkayiwa: I see the number of pull requests going higher and not lower :) |
| 12:14:17 | <dkayiwa> rafa: am the only one working on the sprint :) |
| 12:14:28 | <dkayiwa> rafa: so i would be reviewing my requests :) |
| 12:14:41 | <rafa> dkayiwa: but there are 20 pending pull requests from others |
| 12:15:02 | <dkayiwa> rafa: done for this sprint? |
| 12:15:22 | <rafa> dkayiwa: any pull requests belong to this sprint |
| 12:15:30 | <rafa> dkayiwa: it's work done by community |
| 12:15:58 | <dkayiwa> rafa: oh i thought it was only for the tickets i put on the sprint dashboard :) |
| 12:16:14 | <rafa> dkayiwa: so you it should be your priority to review and merge them first |
| 12:16:52 | <rafa> dkayiwa: no, it's any work done by community developers |
| 12:17:09 | <dkayiwa> rafa: oh i see!!! was restricting myself on only those on the sprint dashboard :) |
| 12:17:20 | <rafa> dkayiwa: the dashboard is just giving ideas on what to work next |
| 12:17:29 | <dkayiwa> rafa: ok |
| 12:17:32 | <rafa> dkayiwa: but if you have pending pull requests, we want them merged asap |
| 12:17:39 | <dkayiwa> rafa: ok |
| 12:17:53 | <dkayiwa> rafa: do you know how i can get a list of them? |
| 12:18:02 | <rafa> https://github.com/openmrs/openmrs-core/pulls |
| 12:18:11 | <dkayiwa> rafa: ok thanks |
| 12:18:38 | <shangxiao> hm i see some naughty testing practices :D |
| 12:19:21 | <rafa> dkayiwa: if you want to pair for merging and back porting pull request let me know |
| 12:19:32 | <dkayiwa> rafa: ok |
| 12:19:48 | <rafa> dkayiwa: but first find one that is ready ;) |
| 12:20:11 | <dkayiwa> rafa: let me first fix the build notification emails problem :) |
| 12:20:36 | *** nribeka has quit IRC |
| 12:20:39 | <rafa> shangxiao: if you see some then the right thing to do is ticket and fix it :D |
| 12:22:03 | <shangxiao> lol there's too much to fix |
| 12:22:04 | <dkayiwa> rafa: you must be right about build notification email requiring only to make it favourite. because after that, my https://ci.openmrs.org/profile/userNotifications.action looks different |
| 12:22:13 | <rafa> shangxiao: small steps :D |
| 12:22:30 | <dkayiwa> rafa: i may need to test it though. should i try send a failing test? :) |
| 12:23:05 | <rafa> dkayiwa: hehe I'm fine with that, but do not leave it this way for 2 days :D |
| 12:23:47 | <dkayiwa> rafa: let me do it right now :D |
| 12:30:05 | *** jkeiper has joined #openmrs |
| 12:30:05 | *** ChanServ sets mode: +v jkeiper |
| 12:39:56 | *** kavuri has joined #openmrs |
| 12:44:42 | *** kjoseph has joined #openmrs |
| 12:55:25 | <shangxiao> what's a "fully specified" concept name? |
| 12:57:40 | <shangxiao> oh wait there's a thing in the wiki |
| 12:58:20 | <rafa> shangxiao: in short it's a full and main name of a concept |
| 12:59:01 | <shangxiao> rafa: oh the primary name? |
| 12:59:26 | <rafa> shangxiao: yes, you can call it the primary name |
| 12:59:56 | <shangxiao> great that's what I'm after |
| 13:01:15 | *** kjoseph has quit IRC |
| 13:02:53 | *** kavuri has quit IRC |
| 13:06:02 | <dkayiwa> rafa: can i safely assume that pull requests without comments are the ones i need to review? |
| 13:07:47 | <rafa> dkayiwa: yes, when you review a pull request either ask for changes, merge it right away or leave a comment that it is ready to be merged |
| 13:08:04 | <rafa> dkayiwa: sometimes there are comments on a pull request, but they've been already addressed |
| 13:08:12 | <dkayiwa> rafa: ok |
| 13:08:19 | <rafa> dkayiwa: you need to see if there are commits after comments have been made |
| 13:08:29 | <dkayiwa> rafa: ok |
| 13:08:43 | <rafa> dkayiwa: an example is here https://github.com/openmrs/openmrs-core/pull/111 |
| 13:08:49 | <dkayiwa> rafa: ok |
| 13:08:51 | <OpenMRSBot> <http://ln-s.net/+9kP> (at github.com) |
| 13:08:58 | <rafa> dkayiwa: you can scroll down and see that the last action is rkorytkowski added a commit |
| 13:09:12 | <dkayiwa> rafa: ok |
| 13:09:13 | <rafa> dkayiwa: other way is to go back to a ticket and see if it's in review state again |
| 13:09:22 | <dkayiwa> rafa: ok |
| 13:09:40 | <rafa> dkayiwa: when you ask for changes don't forget to move the ticket to rework needed |
| 13:09:52 | <dkayiwa> rafa: ok |
| 13:20:34 | *** wluyima has quit IRC |
| 13:24:02 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: XForms 4.0.9.9 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=xforms&version=&4.0.9.9> |
| 13:54:56 | <dkayiwa> hi rafa |
| 13:55:01 | <rafa> dkayiwa: hi |
| 13:55:21 | <dkayiwa> rafa: when a pull request cannot me automatically merged, any recommendations on how to merge it? |
| 13:55:27 | <dkayiwa> me = be |
| 13:55:53 | <rafa> dkayiwa: follow instructions from https://wiki.openmrs.org/display/docs/Git+Merging |
| 13:56:01 | <dkayiwa> rafa: ok thanks |
| 14:05:23 | *** dkayiwa has quit IRC |
| 14:07:34 | *** fishandwalk has joined #openmrs |
| 14:09:24 | *** sgithens has quit IRC |
| 14:14:53 | *** wluyima has joined #openmrs |
| 14:15:00 | <shangxiao> rafa your omod reloader is a lifesaver ! ;) |
| 14:15:13 | <shangxiao> not a lightsabre ;) |
| 14:15:17 | <rafa> shangxiao: happy to hear |
| 14:15:25 | <rafa> shangxiao: wait for OSGi :D |
| 14:15:46 | <shangxiao> i dunno what that is but if you're excited then so am i :D |
| 14:15:48 | *** nribeka has joined #openmrs |
| 14:15:48 | *** ChanServ sets mode: +v nribeka |
| 14:16:41 | <rafa> shangxiao: it means loading modules in seconds ;) |
| 14:17:28 | <shangxiao> cool |
| 14:22:51 | *** dkayiwa has joined #openmrs |
| 14:29:47 | * jkeiper dedicates this cup of coffee to applying concept proposal fixes to the AMRS Customization Module |
| 14:45:56 | <shangxiao> *sigh* Anyone know how to order by concepts "fully specified" name? |
| 14:45:59 | <shangxiao> with hql? |
| 14:46:40 | <shangxiao> if I join Concept to ConceptName to access the name field in the order by clause then I get duplicates |
| 14:46:54 | *** dkayiwa has quit IRC |
| 14:46:57 | <shangxiao> so i add a where condition to name = 'fully specified' then the synonyms don't get included |
| 14:48:12 | <rafa> shangxiao: so where is the problem? |
| 14:48:59 | <shangxiao> the concept object doesn't return synonyms when i call getNames() |
| 14:50:16 | <shangxiao> oh wait i got it |
| 14:50:21 | <shangxiao> i removed the "fetch" from the join |
| 14:50:35 | *** nribeka has quit IRC |
| 14:50:52 | <shangxiao> it's weird because the absence of "fetch" in the join was giving me class cast exceptions earlier >:| |
| 14:51:07 | *** fishandwalk has quit IRC |
| 14:51:39 | <shangxiao> so with fetch gone, hibernate had to select the fetches i suppose |
| 14:51:51 | *** nribeka has joined #openmrs |
| 14:51:51 | *** ChanServ sets mode: +v nribeka |
| 14:52:30 | <rafa> shangxiao: fetch instructs Hibernate to construct objects exactly as in your query |
| 14:52:43 | <cpower> hello eveyone |
| 14:54:55 | <shangxiao> rafa: Ah i see why i'm not getting class cast exceptions now - i included "Select concept" at the start |
| 14:55:21 | <shangxiao> so with the fetchless-join it returns concept object exactly |
| 14:55:41 | <shangxiao> rafa: anyhoo I now have another PR to submit xD |
| 14:55:46 | <shangxiao> this time on a feature branch |
| 14:55:51 | <shangxiao> topic branch |
| 14:55:54 | <rafa> shangxiao: perfect! |
| 14:58:16 | *** sgithens has joined #openmrs |
| 14:58:43 | <rafa> cpower: good morning to you :) |
| 14:59:14 | <cpower> Let's scrum... |
| 14:59:25 | <cpower> !scrumon cpower |
| 14:59:25 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:00:09 | <cpower> Order: wluyima, rafa, andrea (when she shows, djzayeri same) |
| 15:00:29 | <rafa> I think Darius had a long night ;) |
| 15:00:44 | <cpower> for good reasons or bad ones? |
| 15:01:13 | <rafa> always for good |
| 15:01:16 | *** andrea__ has joined #openmrs |
| 15:03:05 | <andrea__> cpower, anyone here? |
| 15:03:26 | <rafa> andrea__: we're waiting for wluyima :) |
| 15:03:36 | <rafa> andrea__: you're after me |
| 15:03:36 | <wluyima> Thursday: |
| 15:03:36 | <wluyima> dev call |
| 15:03:36 | <wluyima> Emails and responding to a couple of questions at answers.openmrs.org |
| 15:03:37 | <wluyima> Testing Atlas module |
| 15:03:37 | <wluyima> |
| 15:03:39 | <wluyima> Friday: |
| 15:03:40 | *** djazayeri has joined #openmrs |
| 15:03:40 | *** ChanServ sets mode: +o djazayeri |
| 15:03:40 | <andrea__> ok, hi rafa |
| 15:03:41 | <wluyima> Continue with TRUNK-3586 - Update unit testing environment to use mocks |
| 15:03:43 | <wluyima> |
| 15:03:45 | <wluyima> Blockers: none |
| 15:03:53 | <rafa> Today: |
| 15:03:53 | <rafa> * Revived openmrs-core on CI |
| 15:03:53 | <rafa> * Reviewed, improved, tested, merged, back ported TRUNK-3778: Add support for JPA annotations |
| 15:03:53 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3778 |
| 15:03:53 | <rafa> * Reviewed (good to merge) TRUNK-3804: Merge Patients ignores visits |
| 15:03:53 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3804 |
| 15:03:53 | <rafa> * Reviewed (to rework) TRUNK-3708: Provide configuration setting that can allow turning off validation in Save Handlers |
| 15:03:54 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3708 |
| 15:03:54 | <rafa> No blockers. |
| 15:04:03 | <cpower> andrea__ your turn |
| 15:04:24 | <andrea__> Thursday |
| 15:04:24 | <andrea__> dev call |
| 15:04:24 | <andrea__> TRUNK-3474 |
| 15:04:24 | <andrea__> Finished testing changes for TRUNK-3474 in UI |
| 15:04:24 | <andrea__> Pull request |
| 15:04:25 | <andrea__> Setup OpenMRS on new computer |
| 15:04:27 | <andrea__> Friday |
| 15:04:29 | <andrea__> Create new ticket for issues I found when making changes for TRUNK-3474 |
| 15:04:31 | <andrea__> Finish setup of OpenMRS on new computer |
| 15:04:33 | <andrea__> Find new ticket |
| 15:04:35 | <andrea__> No blockers |
| 15:04:39 | <andrea__> |
| 15:05:46 | <rafa> djazayeri: morning |
| 15:05:57 | <djazayeri> my turn? |
| 15:06:02 | <rafa> djazayeri: yes |
| 15:06:08 | <djazayeri> Yesterday |
| 15:06:08 | <djazayeri> * Calls |
| 15:06:08 | <djazayeri> * Paired with Alex and Nano (TWers) on writing new CSS rules for the Mirebalais homepage |
| 15:06:08 | <djazayeri> * Pull request for TRUNK-3804 (Merge Patients ignores visits) |
| 15:06:08 | <djazayeri> * Created RESTWS-309 and RESTWS-310 |
| 15:06:09 | <djazayeri> Today |
| 15:06:10 | <djazayeri> * Mirebalais work |
| 15:06:10 | <djazayeri> no blockers |
| 15:08:44 | <rafa> cpower: are you there? |
| 15:08:50 | <rafa> cpower: time to wrap up ;) |
| 15:09:51 | *** suranga has joined #openmrs |
| 15:09:51 | *** ChanServ sets mode: +v suranga |
| 15:09:57 | <rafa> no blockers, no discussion points, no Daniel |
| 15:10:02 | *** kishoreyekkanti has quit IRC |
| 15:10:10 | <rafa> !scrumoff |
| 15:10:10 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:10:49 | <suranga> howdy rafa !! |
| 15:10:54 | <rafa> suranga: hey |
| 15:11:08 | <jkeiper> one cup of coffee was not enough |
| 15:11:18 | <suranga> rafa, sorry I missed you yesterday. I was hoping to pick up on the authentication issue which we discussed during the last university call... :-) |
| 15:11:44 | <jkeiper> anyone here ever write up pseudocode or some easy-to-read-by-users samples for (functional) unit tests? |
| 15:11:51 | <rafa> suranga: I need to eat something now |
| 15:11:55 | <djazayeri> wluyima: hey, will you be able to share a pointer to the code for the mockito work today? |
| 15:12:02 | <rafa> suranga: will be back in an hour |
| 15:12:03 | <djazayeri> I'd like to be able to provide feedback |
| 15:12:10 | <jkeiper> i'm trying to get users to sign off on what is acceptable for a response in a reporting column |
| 15:12:14 | <suranga> rafa, no worries |
| 15:12:14 | <suranga> rafa, when can I catch you again ? :-) |
| 15:12:25 | <suranga> rafa, sure, sounds good ! |
| 15:12:28 | <rafa> suranga: great |
| 15:12:32 | <jkeiper> oh djazayeri, the links on your blog post are off now that the code's been updated (re: mockito) |
| 15:12:45 | <jkeiper> but i wondered why you aren't using @Autowired |
| 15:13:21 | <djazayeri> jkeiper: the way we've been doing tests in mirebalais is maybe 10% of the way to what you want. :-) |
| 15:13:44 | <djazayeri> jkeiper: e.g. do your assertions like: assertThat(something, is(equalTo(value))); |
| 15:13:51 | <jkeiper> djazayeri, re: functional test syntax for running it by users? ahhh |
| 15:14:20 | <djazayeri> jkeiper: which blog post? |
| 15:14:26 | <jkeiper> yeah i like the syntax for mockito and jquery for that matter |
| 15:14:43 | <jkeiper> the one about EmrProperties, getting rid of long Context.getBlahService references |
| 15:15:01 | <jkeiper> http://mirebalaisemr.blogspot.com.br/2012/10/openmrs-style-tip-how-you-should-expose.html |
| 15:15:03 | <OpenMRSBot> <http://ln-s.net/+9nr> (at mirebalaisemr.blogspot.com.br) |
| 15:15:50 | <shangxiao> rafa: woo! thanks for committing my jpa pr ;) |
| 15:16:20 | <rafa> shangxiao: thank you for working on that! |
| 15:16:28 | <shangxiao> my pleasure |
| 15:16:30 | <djazayeri> jkeiper: oh, the issue there is https://tickets.openmrs.org/browse/TRUNK-3806 |
| 15:16:41 | <shangxiao> it will be easier to maintain than xml I reckon ;) |
| 15:16:59 | <rafa> shangxiao: if you could test your module again it would be great |
| 15:17:01 | <djazayeri> Basically if you have @Autowired properties on an OpenMRS service, startup is 10x slower |
| 15:17:05 | <djazayeri> jkeiper: ^^ |
| 15:17:19 | <jkeiper> ohhhhh? |
| 15:17:20 | <jkeiper> hrm |
| 15:17:27 | <jkeiper> that's a bummer! |
| 15:17:42 | <jkeiper> so you set them via xml |
| 15:18:19 | * jkeiper files that away for reference later |
| 15:18:48 | <cpower> !scrumoff |
| 15:18:48 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:19:02 | <jkeiper> you done did that already cpower |
| 15:19:13 | <cpower> rafa did, I just noticed |
| 15:19:16 | <cpower> :-) |
| 15:19:23 | <jkeiper> L-) |
| 15:19:40 | <rafa> cpower: we lost you :P |
| 15:19:56 | <djazayeri> rafa: incidentally you should post to the dev list about https://tickets.openmrs.org/browse/TRUNK-3806 |
| 15:20:12 | <cpower> Yeah we have servers down on another project so I got distracted by the blinky lights |
| 15:20:31 | <rafa> djazayeri: will do\ |
| 15:44:39 | *** jkeiper has quit IRC |
| 15:45:41 | <shangxiao> rafa: just tested the hello world module and it worked |
| 15:45:56 | *** jkeiper has joined #openmrs |
| 15:45:56 | *** ChanServ sets mode: +v jkeiper |
| 15:51:33 | <rafa> shangxiao: great, thanks |
| 15:51:50 | <shangxiao> ok well i'm off |
| 15:51:55 | <shangxiao> must get some sleep |
| 15:51:58 | <shangxiao> ciao all |
| 15:52:07 | *** shangxiao has quit IRC |
| 15:59:29 | *** nribeka has quit IRC |
| 16:02:29 | <rafa> suranga: hey |
| 16:08:48 | *** lh has joined #openmrs |
| 16:08:48 | *** lh has joined #openmrs |
| 16:11:13 | <cpower> So playing around in Jira I found 39 intro tickets that are over a year old. Anyone have a thought on how we would get them some attention? See if they are still relevant and then if they are move them along? |
| 16:12:23 | <suranga> cpower, we can check if anyone who claimed them has ignored them for a long time. if so, we should unassign them so that new people can pick them up ? |
| 16:12:31 | <suranga> rafa, hi, sorry for the delay :-) |
| 16:12:43 | <rafa> suranga: hi |
| 16:12:50 | <cpower> suranga, these are all unassigned and unresolved tickets |
| 16:13:20 | <suranga> rafa, howdy, I was hoping to dicuss authentication, and Dr. Burkes solution to it :-) |
| 16:13:43 | <suranga> rafa, Dr. Burke recomends we copy basic auth from RESTWS |
| 16:13:55 | <suranga> cpower, in that case, um... "scratches head" |
| 16:14:00 | <rafa> suranga: it should be easy |
| 16:14:03 | <rafa> suranga: I agree |
| 16:14:22 | * suranga entire body is coverd in ears :-) |
| 16:14:41 | <cpower> hmmm |
| 16:15:02 | <rafa> suranga: https://tickets.openmrs.org/browse/RESTWS-192 |
| 16:15:08 | <suranga> rafa, does this involve copy pasting restws code into mine, or using the restws module as part of authentication ? |
| 16:15:09 | <cpower> ok I'll think about this some more and see if there "should" be a resolution |
| 16:15:09 | <rafa> here's how it's done in RESTWS |
| 16:15:17 | <rafa> suranga: look at the code snippets |
| 16:15:26 | <rafa> suranga: it's better just to copy it |
| 16:16:07 | <rafa> suranga: if you looked at the RESTWS code, you'll need SessionController and some code from BaseRestController |
| 16:16:24 | <rafa> suranga: that should do the thing |
| 16:16:26 | <suranga> cpower, a lot of intro tickets really get fixed during the feb - april season (GSOC aspirants fix them ) :-) |
| 16:16:42 | <cpower> lol |
| 16:17:05 | <cpower> I have a ticket from 2007 that would argue with you, but I like the thought |
| 16:17:24 | <rafa> you will rename BaseRestController |
| 16:18:18 | <rafa> suranga: if you make all your controllers extend BaseHL7QueryController |
| 16:18:29 | <rafa> suranga: you will get a nice error message if not authenticated |
| 16:18:37 | <suranga> rafa, so I copy session and base restcontroller form RESTWS |
| 16:18:48 | <suranga> rename BaseRestController as BaseHL7QueryController ? |
| 16:18:58 | <rafa> suranga: right |
| 16:19:14 | <suranga> rafa, mm.. and then ? |
| 16:19:52 | <rafa> suranga: and then it should just work ;) |
| 16:20:20 | <suranga> rafa, im really sorry, but im not understanding the background scenario here :-( |
| 16:20:43 | <suranga> rafa, could you please explain a sample scenario where this will come handy ? |
| 16:22:03 | <rafa> suranga: currently you can't easily authenticate programatically if you want to query HL7 module |
| 16:22:37 | <suranga> rafa, yes, mm... but would these two controllers allow us to do so ? |
| 16:22:43 | <rafa> suranga: yes |
| 16:23:02 | <rafa> suranga: they give you a way to get a session |
| 16:23:42 | <suranga> rafa, I see. I think I better look at these classes before I waste your time with silly questions :-) |
| 16:23:59 | <rafa> suranga: yeah and look at the link I gave you |
| 16:24:25 | <rafa> suranga: there are code snippets from Saptarshi which show how it works |
| 16:24:37 | <suranga> rafa, ill start on this later tonight / tomorrow morning. but thanks a lot for the tips :-) |
| 16:24:50 | <suranga> rafa, you were verryyyyy helpful :-) |
| 16:25:19 | <rafa> suranga: ok, ping me in case of any problems |
| 16:25:30 | <suranga> rafa, cool, thanks :-) |
| 16:25:36 | <rafa> suranga: np |
| 16:30:08 | <rafa> djazayeri: is there a way to assess multiple tickets at once in jira? |
| 16:39:48 | *** lh has quit IRC |
| 16:47:42 | *** lh has joined #openmrs |
| 17:03:23 | *** jkeiper has quit IRC |
| 17:03:48 | <djazayeri> rafa: maybe. if you find them all via a query, you can do batch update. not sure if that lets you assess. |
| 17:12:19 | *** rafa has quit IRC |
| 17:15:46 | *** andrea__ has quit IRC |
| 17:18:24 | *** jkeiper has joined #openmrs |
| 17:18:24 | *** ChanServ sets mode: +v jkeiper |
| 17:31:41 | <djazayeri> wluyima: hey, if I have done a pull request, and it has been approved, I can (with a bunch of git steps) merge it into upstream from my own clone of my own fork, right? |
| 18:04:59 | *** sgithens has quit IRC |
| 18:33:50 | *** sgithens has joined #openmrs |
| 18:56:27 | *** sgithens has quit IRC |
| 19:15:17 | *** Echidna has quit IRC |
| 19:15:28 | *** Echidna has joined #openmrs |
| 19:15:28 | *** ChanServ sets mode: +v Echidna |
| 19:48:40 | <cpower> So here's my dumb question of the day. Why is Trunk-3440 not assigned to someone yet? |
| 19:49:20 | <cpower> It's a blocker ticket that's been sitting for almost a month. |
| 19:49:43 | <djazayeri> cpower: it has had a lot of investigation done on it, by Mike Seaton and Daniel. |
| 19:49:54 | <djazayeri> cpower: it's actually waiting on Downey doing something now, so I just assigned it to him. |
| 19:50:58 | <cpower> ok, it's good that there is work moving on it beyond the ticket. |
| 19:51:49 | <cpower> djazayeri have you had a chance to talk to Burke about Community Swimlane? Or are you (I recall a conversation that went something like that) |
| 19:51:52 | <djazayeri> cpower: well, there isn't actually. at least AFAIK Downey isn't actively working on this (perhaps understandable since he doesn't have the ticket assigned) |
| 19:51:59 | <djazayeri> cpower: on a call now actually |
| 19:52:13 | <djazayeri> cpower: we've had an email thread going. more than that? |
| 19:52:50 | <cpower> Is the email thread somewhere I can see it or just between you and him? |
| 19:53:03 | <djazayeri> cpower: I thought you were on it, let me forward |
| 19:53:52 | <cpower> *cpower looks at his million messages and thinks it could be there, just needs to know where to look* but forwarding it is good |
| 19:54:49 | <djazayeri> cpower: is your email at openmrs or at ri? |
| 19:55:06 | <cpower> I look at both, pick whichever is easier |
| 19:58:31 | <cpower> Ok I've read this one. Questions that come from it. It's sad to say I don't know Glen. Is he on IRC? His email the best way to reach out to him? Who is he with? |
| 19:59:01 | <djazayeri> cpower: glen is a freelancer. he's only on irc during GSoC time |
| 19:59:47 | <cpower> So how does he help dev's who want to join up? Via email? How effective do we think he's being? |
| 20:00:47 | <djazayeri> cpower: I assume he was copied because he's looking at our incoming contact requests? |
| 20:01:19 | <cpower> but you don't know for sure who/how many he's really reaching out to right? |
| 20:01:30 | <djazayeri> cpower: I don'tk now |
| 20:01:34 | <cpower> k |
| 20:18:27 | <cpower> wluyima: How's FORM:129 going? |
| 20:41:20 | *** jkeiper_ has joined #openmrs |
| 20:43:08 | *** jkeiper has quit IRC |
| 21:21:43 | <suranga> got to sign off guys, its almost morning over here ' |
| 21:22:08 | * suranga anticipates cocks crowing soon |
| 21:30:48 | *** suranga has quit IRC |
| 21:57:56 | *** lh has quit IRC |
| 22:11:34 | *** lh has joined #openmrs |
| 22:24:01 | <wluyima> cpower, am not working on that |
| 23:41:17 | *** wluyima has quit IRC |