| 00:10:19 | *** yony258 has joined #openmrs |
| 00:10:22 | *** yony258 is now known as YonatanGrinberg |
| 00:10:29 | <YonatanGrinberg> Hi |
| 00:11:28 | <YonatanGrinberg> Is there anyone online? |
| 00:14:54 | <YonatanGrinberg> Well im here let me know if you can help. |
| 00:31:39 | *** djazayeri has quit IRC |
| 00:33:33 | *** sgithens has joined #openmrs |
| 00:35:03 | *** djazayeri has joined #openmrs |
| 00:35:03 | *** ChanServ sets mode: +o djazayeri |
| 00:49:00 | <YonatanGrinberg> hi |
| 01:04:24 | *** lh has quit IRC |
| 01:06:17 | *** mseaton has joined #openmrs |
| 01:06:17 | *** ChanServ sets mode: +v mseaton |
| 01:29:39 | *** downey has quit IRC |
| 01:46:51 | *** gschiltz has joined #openmrs |
| 02:00:16 | *** mseaton has quit IRC |
| 02:07:54 | *** gschiltz has left #openmrs |
| 02:17:14 | *** mseaton has joined #openmrs |
| 02:17:14 | *** ChanServ sets mode: +v mseaton |
| 02:41:14 | *** mseaton has quit IRC |
| 03:10:28 | *** jkeiper has joined #openmrs |
| 03:10:28 | *** ChanServ sets mode: +v jkeiper |
| 03:10:32 | *** nribeka has joined #openmrs |
| 03:10:32 | *** ChanServ sets mode: +v nribeka |
| 03:10:36 | <djazayeri> hi YonatanGrinberg |
| 03:10:48 | <djazayeri> 3 hours later |
| 03:48:11 | *** sgithens has quit IRC |
| 04:04:07 | *** sgithens has joined #openmrs |
| 04:17:28 | *** kishoreyekkanti has joined #openmrs |
| 04:22:26 | *** djazayeri has quit IRC |
| 04:30:11 | *** mseaton has joined #openmrs |
| 04:30:11 | *** ChanServ sets mode: +v mseaton |
| 05:06:27 | *** mseaton has quit IRC |
| 05:47:07 | *** YonatanGrinberg has quit IRC |
| 06:19:48 | *** robbyoconnor has joined #openmrs |
| 06:19:48 | *** ChanServ sets mode: +v robbyoconnor |
| 06:44:12 | *** dkayiwa has joined #openmrs |
| 07:14:30 | *** vsmith has joined #openmrs |
| 07:16:05 | *** dkayiwa has quit IRC |
| 07:18:16 | *** vsmith has quit IRC |
| 07:18:18 | *** dkayiwa has joined #openmrs |
| 07:20:46 | *** vsmith has joined #openmrs |
| 07:28:51 | <vsmith> dkayiwa: You available to help? |
| 07:29:00 | <dkayiwa> vsmith: yes |
| 07:29:24 | <vsmith> dkayiwa: So happy to hear from you again |
| 07:29:35 | <dkayiwa> vsmith: me too :) |
| 07:30:17 | <vsmith> dkayiwa: How do I get connect my client to the irc.freenone.net? I tried registering my Nick but it says I am already using it |
| 07:30:50 | <vsmith> dkayiwa: Is there a password? What is it? Can I set it? |
| 07:30:59 | <dkayiwa> vsmith: which client are you using? |
| 07:31:12 | <vsmith> Adium |
| 07:31:21 | <vsmith> dkayiwa: Adium |
| 07:31:35 | <dkayiwa> vsmith: i have never registered a nick myself :) |
| 07:31:50 | <vsmith> dkayiwa: Ok. How are you using it? |
| 07:32:16 | <vsmith> dkayiwa: It doesn't let me connect. It just says connection refused |
| 07:32:59 | *** dkayiwa_ has joined #openmrs |
| 07:33:24 | <dkayiwa_> vsmith: sorry i got disconnected |
| 07:33:24 | <dkayiwa_> vsmith: was saying that i have never registered a nick myself |
| 07:33:43 | <dkayiwa_> vsmith: the process was not obvious to me so i abandoned it :) |
| 07:33:53 | <vsmith> dkayiwa: OK. How do you connect? :) |
| 07:34:08 | <dkayiwa_> vsmith: i just connect as dkayiwa |
| 07:34:36 | <dkayiwa_> vsmith: my client (Colloquy) just asks for a name i wanna use |
| 07:34:45 | <vsmith> Trying that |
| 07:34:51 | <vsmith> dkayiwa: Trying that |
| 07:35:37 | <vsmith> dkayiwa: Oh, I bet there is a block in place at the firewall. Let me try that |
| 07:35:48 | <dkayiwa_> ok |
| 07:35:53 | *** dkayiwa has quit IRC |
| 07:35:53 | *** dkayiwa_ is now known as dkayiwa |
| 07:36:18 | <vsmith> dkayiwa: Yep, that was it. Boy is that going to be painful |
| 07:36:46 | <dkayiwa> vsmith: so my client saved the connection url and name |
| 07:37:04 | <dkayiwa> vsmith: then all i do is launch it and it automatically connectes |
| 07:37:38 | <vsmith> dkayiwa: Yes. This is a firewall problem for me. Got it figured out. On to bigger challenges |
| 07:37:53 | <dkayiwa> vsmith: oh great!!! |
| 07:38:36 | <vsmith> dkayiwa: After I compiled last time and got the web-app running, then I gave it all the information it asked for to connect it to the database |
| 07:38:49 | <dkayiwa> vsmith: ok |
| 07:38:49 | <vsmith> dkayiwa: Then it proceeded to upgrade that database. |
| 07:39:13 | <vsmith> dkayiwa: Then didn't go any further. No login screen. |
| 07:39:37 | <dkayiwa> vsmith: what did it stop at? |
| 07:39:41 | <vsmith> dkayiwa: So I shut it down and tried to relaunch it again. But this time, it started all over again |
| 07:40:10 | <vsmith> dkayiwa: It said it completed the upgrade but then didn't give me the login screen |
| 07:40:47 | <vsmith> dkayiwa: It didn't appear to setup the configuration file |
| 07:41:17 | <vsmith> dkayiwa: So I answered all the questions again, and then the errors started flying. |
| 07:41:27 | <dkayiwa> vsmith: can you pastebin the tomcat log? |
| 07:41:52 | <vsmith> dkayiwa: Where is it? Remember that I don't have that installed on my computer that I know of. |
| 07:42:08 | <dkayiwa> vsmith: are you using enterprise or standalone? |
| 07:42:25 | <vsmith> dkayiwa: Enterprise or standalone what? |
| 07:42:48 | <dkayiwa> vsmith: where you downloaded openmrs. it lists enterprise or standalone version |
| 07:43:20 | <vsmith> dkayiwa: It was whatever you had me download to compile last time |
| 07:43:56 | <vsmith> dkayiwa: I don't remember any question or indication of enterprise or stand alone |
| 07:44:54 | <dkayiwa> vsmith: i do not even remember when we did that :) |
| 07:45:30 | <vsmith> https://wiki.openmrs.org/display/IRC/2012-10-25+-+OpenMRS |
| 07:45:38 | <dkayiwa> vsmith: http://sourceforge.net/projects/openmrs/files/releases/OpenMRS_1.9.1/ |
| 07:45:39 | <OpenMRSBot> <http://ln-s.net/$jR2> (at sourceforge.net) |
| 07:46:07 | <dkayiwa> vsmith: are you able to download the standalone version there? |
| 07:46:48 | <vsmith> dkayiwa: Sure. What will I run it on? I don't have MySQL or Apache installed |
| 07:47:03 | <dkayiwa> vsmith: just download and run |
| 07:47:19 | <dkayiwa> vsmith: instructions are here: https://wiki.openmrs.org/display/docs/OpenMRS+Standalone |
| 07:47:20 | <OpenMRSBot> <http://ln-s.net/91x$> (at wiki.openmrs.org) |
| 07:47:26 | <vsmith> dkayiwa: OK. Be right back. |
| 07:48:59 | <vsmith> dkayiwa: 13 minutes. In the mean time, the system that was using the database that got upgraded stopped working |
| 07:49:10 | <dkayiwa> vsmith: ok |
| 07:50:19 | <vsmith> dkayiwa: Here is what it says: There was an error starting the module: Logic Module |
| 07:51:30 | <dkayiwa> vsmith: can you try the standalone |
| 07:51:49 | <vsmith> dkayiwa: OK. 8 minutes. Just run it? |
| 07:52:09 | <dkayiwa> vsmith: https://wiki.openmrs.org/display/docs/OpenMRS+Standalone |
| 07:52:10 | <OpenMRSBot> <http://ln-s.net/91x$> (at wiki.openmrs.org) |
| 07:57:32 | <vsmith> dkayiwa: 3 minutes |
| 08:10:51 | <vsmith> dkayiwa: Demonstration mode, Starter Implementation, or Expert Mode? |
| 08:11:22 | <dkayiwa> vsmith: demo mode |
| 08:12:21 | <vsmith> dkayiwa: It's busy |
| 08:12:59 | <dkayiwa> vsmith: ok |
| 08:13:04 | <vsmith> dkayiwa: I have a login screen |
| 08:14:12 | <vsmith> dkayiwa: Login? |
| 08:15:13 | *** robbyoconnor has quit IRC |
| 08:15:21 | <dkayiwa> vsmith: admin/Admin123 |
| 08:16:32 | <vsmith> dkayiwa: admin/test |
| 08:16:46 | <dkayiwa> ok |
| 08:16:53 | <vsmith> dkayiwa: Now what |
| 08:17:21 | <dkayiwa> vsmith: now this: http://en.flossmanuals.net/openmrs-guide/ |
| 08:18:47 | <vsmith> dkayiwa: How can I insert the code that you and I compiled into this? |
| 08:19:29 | <dkayiwa> vsmith: did you create a war file? |
| 08:19:39 | <vsmith> dkayiwa: ?? |
| 08:19:50 | <dkayiwa> vsmith: ?? |
| 08:21:08 | <vsmith> dkayiwa: What is a war file and how would I know if I created it? |
| 08:21:27 | <dkayiwa> vsmith: how did you compile? |
| 08:21:32 | <vsmith> dkayiwa: There is one in the openmrs-webapp directory |
| 08:24:49 | *** robbyoconnor has joined #openmrs |
| 08:24:49 | *** ChanServ sets mode: +v robbyoconnor |
| 08:25:09 | <vsmith> dkayiwa: mvn clean install |
| 08:25:38 | <dkayiwa> vsmith: so that will create a war file in the openmrs-webapp target dirrectory |
| 08:25:54 | <dkayiwa> vsmith: just copy and paste that into the standalone |
| 08:26:10 | <dkayiwa> vsmith: to replace the one in the standalone's tomcat folder |
| 08:26:38 | <vsmith> dkayiwa: Oh, ok. Will it handle that database upgrade thing again or will that not be necessary? |
| 08:26:59 | <dkayiwa> vsmith: i do not know |
| 08:29:56 | <vsmith> dkayiwa: Do I need to exit everything first? Are we talking about the one in openmrs-core/webapp/target/openmrs.war |
| 08:30:14 | <dkayiwa> vsmith: yes you need to first exit |
| 08:30:33 | <dkayiwa> vsmith: and yes thats the file |
| 08:31:52 | <vsmith> dkayiwa: How do I get tomcat stopped? It is holding the command line |
| 08:32:11 | <dkayiwa> vsmith: it stops when you close the standalone |
| 08:32:48 | <vsmith> dkayiwa: Sorry, lost the window in the pile of windows :) |
| 08:33:27 | <vsmith> dkayiwa: Yes, that worked |
| 08:33:36 | <vsmith> dkayiwa: copying file |
| 08:34:20 | <dkayiwa> vsmith: ok |
| 08:37:13 | <vsmith> dkayiwa: The file is openmrs.war. But the file in the webapps directory is openmrs-standalone.war |
| 08:37:31 | <vsmith> dkayiwa: Do I need to rename something or am I attempting to replace the wrong file? |
| 08:37:34 | <dkayiwa> vsmith: rename the pasted file |
| 08:39:41 | <vsmith> dkayiwa: Just relaunch as before? The file is considerably smaller (40.8 compared to the replaced file at 45 |
| 08:40:05 | <dkayiwa> vsmith: yes launch as before |
| 08:40:55 | <vsmith> Attempting to load properties file in current directory: openmrs-standalone-runtime.properties Using runtime properties file: openmrs-standalone-runtime.properties Attempting to load properties file in current directory: openmrs-standalone-runtime.properties Using runtime properties file: openmrs-standalone-runtime.properties Attempting to load properties file in current directory: openmrs-standalone-runtime.properties Using runtime |
| 08:41:45 | <vsmith> dkayiwa: That didn't copy and paste very well. |
| 08:42:21 | <dkayiwa> vsmith: meaning? |
| 08:42:46 | <vsmith> dkayiwa: It errored out because it couldn't find the .properties file |
| 08:43:10 | <dkayiwa> vsmith: has it stopped running |
| 08:44:40 | <vsmith> dkayiwa: Yes. Check email. |
| 08:45:48 | <dkayiwa> vsmith: whats the name of your war file |
| 08:47:35 | <vsmith> dkayiwa:openmrs-standalone.war |
| 08:48:08 | <dkayiwa> vsmith: is it the only file you have in that folder |
| 08:48:55 | <vsmith> dkayiwa: From where I copied from or where I copied to? |
| 08:49:39 | <dkayiwa> vsmith: where you copied to |
| 08:50:02 | <vsmith> dkayiwa: There is the old file that I renamed .bak |
| 08:50:11 | <dkayiwa> vsmith: delete it |
| 08:50:17 | <dkayiwa> any folders there |
| 08:52:31 | <vsmith> dkayiwa: You were right, it retained the .war extension. |
| 08:53:00 | <vsmith> dkayiwa: There is a directory called openmrs-standalone |
| 08:53:48 | <dkayiwa> vsmith: delete it too |
| 08:54:56 | <vsmith> dkayiwa: I left it in place. Once I renamed the old file, it launched. I have a login screen again. You are Brilliant! |
| 08:56:40 | <vsmith> dkayiwa: Logged in! You are awesome! Time for bed for me. Catch you again in a day or two? |
| 08:56:49 | <dkayiwa> vsmith: ok |
| 08:56:56 | <dkayiwa> vsmith: did you see yo change |
| 08:57:18 | <vsmith> dkayiwa: We didn't make any changes last time. I will try that tomorrow. |
| 08:57:25 | <dkayiwa> vsmith: ok |
| 08:57:56 | <vsmith> dkayiwa: Good night. Thank you so much. You sure you don't want to work in the US? |
| 08:58:20 | <dkayiwa> vsmith: why work in the US? |
| 08:58:43 | <vsmith> dkayiwa: Here at Mayo. |
| 08:59:08 | <dkayiwa> vsmith: working on OpenMRS from there? |
| 08:59:26 | <vsmith> dkayiwa: Just keep it in mind. I might come calling. :) |
| 08:59:41 | <vsmith> dkayiwa: Mamlin would probably kill me. |
| 09:00:07 | <dkayiwa> vsmith: hahahaha. you will have to use a bull dozer for that :) |
| 09:00:34 | <vsmith> dkayiwa: Any way, thanks for all your help. I really appreciate it. |
| 09:00:49 | <dkayiwa> vsmith: you are welcome. thanks for your patience too |
| 09:01:09 | <vsmith> dkayiwa: What patience. You are the one putting up with me. |
| 09:01:35 | <dkayiwa> vsmith: i have ever been where you are now. so i know it when i say your patience :) |
| 09:05:33 | <vsmith> dkayiwa: I am not alone. I am surprised many people are contacting you: OpenMRS Developer Trainings - What's Currently Available? on dev@openmrs.org |
| 09:07:05 | <dkayiwa> vsmith: only beacuse am awake because of my time zone while my coligues are sleeping :) |
| 09:07:42 | <vsmith> dkayiwa: Good night Daniel. Thanks again. If I can help you in any way, just let me know. |
| 09:08:13 | <dkayiwa> vsmith: have a good night too. and thanks!!! :D |
| 09:08:28 | *** vsmith has quit IRC |
| 09:36:24 | *** lh has joined #openmrs |
| 10:11:32 | *** rkorytkowski has joined #openmrs |
| 10:11:32 | *** ChanServ sets mode: +v rkorytkowski |
| 10:11:47 | *** rkorytkowski is now known as rafa |
| 10:30:59 | *** lh has quit IRC |
| 10:41:55 | *** lh has joined #openmrs |
| 10:41:55 | *** lh has joined #openmrs |
| 10:44:25 | *** lh has quit IRC |
| 11:06:54 | *** shangxiao has joined #openmrs |
| 11:07:38 | <shangxiao> ping rafa |
| 11:08:17 | <rafa> shangxiao: hi |
| 11:08:23 | <shangxiao> rafa: hi :) |
| 11:08:43 | <shangxiao> rafa: what do you mean by topic branch |
| 11:08:51 | <shangxiao> does that mean 10.x or 1.9.x |
| 11:09:08 | <rafa> shangxiao: you should create a new branch for each pull request you send |
| 11:09:15 | <shangxiao> oh i see |
| 11:09:38 | <rafa> shangxiao: pull requests are automatically updated when you commit to a branch |
| 11:09:49 | <rafa> shangxiao: so if you create it from master |
| 11:10:04 | <rafa> shangxiao: you can't commit to master anymore before the pull request is done |
| 11:10:48 | <shangxiao> rafa: right i was wondering about how to get around that issue ;) |
| 11:11:04 | <shangxiao> this is only my 2nd PR |
| 11:11:07 | <shangxiao> lol |
| 11:11:20 | <rafa> shangxiao: branches are easy with git |
| 11:11:35 | <rafa> shangxiao: you should have no problem using them |
| 11:11:40 | <shangxiao> yes that's what i love about git |
| 11:12:02 | <shangxiao> so naming convention: just name it after the ticket: "TRUNK-XXXX |
| 11:12:04 | <shangxiao> ? |
| 11:12:09 | <rafa> right |
| 11:12:17 | <shangxiao> cool |
| 11:12:53 | <rafa> shangxiao: but continue with master for TRUNK-3778 |
| 11:13:07 | <shangxiao> ok - i was about to ask that question ;) |
| 11:13:18 | <shangxiao> next time i'll do a feature branch |
| 11:13:24 | <rafa> shangxiao: great, thanks |
| 11:13:35 | <rafa> shangxiao: if you need any help with that let me know |
| 11:14:31 | <shangxiao> should be ok i'm pretty good with git - been using since 2010 and loving it ! ;) |
| 11:14:39 | <shangxiao> hate subversion now |
| 11:14:56 | <rafa> shangxiao: same here :) |
| 11:14:59 | <shangxiao> i just didn't use github til recently |
| 11:16:11 | <rafa> shangxiao: github makes contributing to open-source projects so easy |
| 11:16:23 | <shangxiao> yeah it's pretty sweet |
| 11:18:00 | <rafa> shangxiao: where are you based? |
| 11:18:24 | *** kavuri has joined #openmrs |
| 11:19:11 | <shangxiao> rafa: Melbourne, Australia |
| 11:19:28 | <shangxiao> I'm working on OpenMRS through Thoughworks sponsored project |
| 11:19:54 | <shangxiao> I don't work for Thoughtworks, but they have a good presence here in the developer community :) |
| 11:20:17 | <rafa> shangxiao: that's great |
| 11:21:14 | <rafa> shangxiao: so OpenMRS is just part time for you? |
| 11:21:53 | <shangxiao> rafa: Just in your comments about collection types, you mentioned that I should use List, which I agree is always better to use higher level types (rather than ArrayList), but just looking at getModuleMappingResources() they use Set - should I use Set for consistency or stick with List - or doesn't it really matter? |
| 11:22:13 | <shangxiao> rafa: OpenMRS is kind of part time - I'm freelance in between projects so I can work on it whenever ;) |
| 11:22:54 | <rafa> shangxiao: Set will be better here. |
| 11:23:04 | <shangxiao> ok I'll use Set |
| 11:23:28 | <shangxiao> I'm used to using ArrayList and I just put it in when I'm on auto-pilot ;) |
| 11:23:53 | <kavuri> dkayiwa: about RESTWS-302, I was expecting that obsGroup.isObsGrouping() should be a good test for ensuring that the observation is a group |
| 11:24:03 | <kavuri> dkayiwa: but looks like the method itself is at fault |
| 11:24:28 | <dkayiwa> kavuri: a non failing test is not a test at all |
| 11:24:49 | <kavuri> dkayiwa: I agree to that..but my point is that why isObsGrouping() passes? |
| 11:25:24 | <dkayiwa> kavuri: because the obs is a group |
| 11:26:10 | <kavuri> dkayiwa: right, so it is a correct test case. Because the original bug is that when I create observations, they are not treated as groups once they are created in database |
| 11:26:20 | <kavuri> dkayiwa: and after the fix, they should be |
| 11:26:53 | <dkayiwa> kavuri: am not sure i get you |
| 11:27:12 | <shangxiao> ahh I remember now - Set is a collection of distinct objects |
| 11:27:18 | <shangxiao> unordered |
| 11:27:22 | <dkayiwa> kavuri: as far as am thinking, a unit test must fail for a defect it is testing |
| 11:27:57 | <kavuri> dkayiwa: I am denying that fact. As per the original bug, when I create an observation group, the children are not created as group members |
| 11:28:07 | <kavuri> dkayiwa: that means, isObsGrouping() should return false |
| 11:28:11 | <kavuri> dkayiwa: right? |
| 11:28:32 | <dkayiwa> kavuri: no |
| 11:29:34 | <kavuri> dkayiwa: ?? |
| 11:30:26 | <dkayiwa> kavuri: it return true because its indeed a group |
| 11:30:35 | <dkayiwa> kavuri: which is correct |
| 11:30:59 | <kavuri> dkayiwa: which is correct after the bug fix, but which should fail before the bug fix |
| 11:31:07 | <dkayiwa> kavuri: you need to create a unit test which proves the defect by failing |
| 11:31:49 | <dkayiwa> kavuri: that way, whoever fixes your defect, should be tested by having your unit test pass |
| 11:32:07 | <shangxiao> rafa: It looks as though the types in Module & ModuleFileParser should also be Set... |
| 11:32:28 | <rafa> shangxiao: right |
| 11:33:10 | <kavuri> dkayiwa: the method isObsGrouping() should fail before the bug fix |
| 11:33:21 | <dkayiwa> kavuri: no |
| 11:33:27 | <kavuri> dkayiwa: why? |
| 11:33:35 | <dkayiwa> kavuri: it is your unit test (which you need to create) which should fail |
| 11:33:49 | <dkayiwa> kavuri: are you generally farmiliar with unit tests? |
| 11:34:04 | <kavuri> dkayiwa: yes, I am |
| 11:34:13 | <kavuri> dkayiwa: I have written the unit testcase, that I provided to you |
| 11:34:47 | <dkayiwa> kavuri: do you have a unit test which is failing now? |
| 11:35:11 | <kavuri> dkayiwa: and in that unit testcase, I have used the method isObsGrouping() to test that the group I created is an obs group or not. And the bug is exactly that when I created an obs group which is not created as a group, but which are created as individual obs. |
| 11:35:28 | <rafa> dkayiwa: I've updated https://wiki.openmrs.org/display/docs/Using+Git |
| 11:35:28 | <kavuri> dkayiwa: I am not sure if you are able to understand the point... |
| 11:35:35 | <rafa> dkayiwa: see Create topic branch for your task |
| 11:35:44 | <dkayiwa> rafa: thanks rafa :) |
| 11:35:58 | <dkayiwa> kavuri: can you create a unit test which does not pass? |
| 11:36:08 | <rafa> dkayiwa: this way you will never forget you need to base your branch on master |
| 11:36:10 | <dkayiwa> because of the defect you are reporting? |
| 11:36:15 | <kavuri> dkayiwa: ok, I will |
| 11:36:16 | <dkayiwa> rafa: hahah :D |
| 11:36:31 | <kavuri> dkayiwa: but on a side note, I would like to understand the usage of isObsGrouping() method |
| 11:36:32 | <dkayiwa> kavuri: thats all i need :D |
| 11:36:40 | <kavuri> dkayiwa: can you please help me understand that? |
| 11:36:57 | <dkayiwa> kavuri: it simply tell you if an obs is a group or not |
| 11:37:30 | <kavuri> dkayiwa: ok, so before the bug fix, I used that method to check if the observation I created is a group or not. But this method tells me that it is a group, which is wrong |
| 11:37:39 | <kavuri> dkayiwa: why do you think it is? |
| 11:39:29 | <dkayiwa> kavuri: the you need a unit test which fails because the method does not return what a unit test expects |
| 11:40:02 | <kavuri> dkayiwa: you mean a unit test for isObsGrouping() ? |
| 11:40:22 | <dkayiwa> kavuri: a unit test for the defect you want to get fixed :) |
| 11:40:37 | <kavuri> dkayiwa: yeah, maybe I will first provide a failing unit test for isObsGrouping() because, there really seems to be a problem there |
| 11:40:51 | <kavuri> :) |
| 11:42:28 | <dkayiwa> kavuri: you are free to create more than one unit test :) |
| 11:42:40 | <kavuri> dkayiwa: :) |
| 11:42:53 | <dkayiwa> kavuri: and as soon as you have one, it will make it easy to get fixed :) |
| 11:43:12 | <kavuri> dkayiwa: btw. your patch fixed the problem :) |
| 11:43:26 | <dkayiwa> kavuri: it was your patch :) |
| 11:44:54 | <kavuri> dkayiwa: I was trying to use "limit=5" tag with REST request and wondering if it is possible to fetch the next 5 items after the current 5 |
| 11:45:30 | <dkayiwa> kavuri: what happened when you tried it out? |
| 11:45:48 | <kavuri> dkayiwa: I get the first 5..now I want to get the next 5 |
| 11:45:55 | <kavuri> dkayiwa: I do not know the format |
| 11:46:20 | <dkayiwa> kavuri: have not tried it out too :) |
| 11:55:07 | <rafa> shangxiao: do you mind if I squash your 3 commits into 1? It'll be easier to back port to 1.9.x, but you will have to force push on your fork |
| 11:58:46 | <rafa> shangxiao: or maybe you want to do it yourself :) |
| 11:59:48 | <shangxiao> i can squash it - it's probably easier |
| 12:00:03 | <rafa> shangxiao: perfect |
| 12:00:13 | <rafa> shangxiao: do pull --rebase first |
| 12:00:19 | <rafa> shangxiao: to updated to tha latest master |
| 12:00:42 | <shangxiao> cool |
| 12:01:05 | <shangxiao> rafa: I have to step out for a bit but I'll be back online in 1 hour - I can do it then |
| 12:01:18 | <rafa> shangxiao: sure, thanks |
| 12:01:46 | *** shangxiao has quit IRC |
| 12:20:46 | *** jkeiper has quit IRC |
| 12:22:38 | *** dkayiwa has quit IRC |
| 12:48:24 | *** nribeka has quit IRC |
| 13:12:46 | *** nribeka has joined #openmrs |
| 13:12:46 | *** ChanServ sets mode: +v nribeka |
| 13:16:43 | *** jkeiper has joined #openmrs |
| 13:16:43 | *** ChanServ sets mode: +v jkeiper |
| 13:23:49 | *** robbyoconnor has quit IRC |
| 13:25:25 | *** mseaton has joined #openmrs |
| 13:25:25 | *** ChanServ sets mode: +v mseaton |
| 13:25:58 | *** wluyima has quit IRC |
| 13:28:57 | *** kjoseph has joined #openmrs |
| 13:29:52 | <jkeiper> hi ppl |
| 13:33:05 | <kavuri> hei jkeiper |
| 13:35:52 | *** kaweesi_joseph has joined #openmrs |
| 13:37:36 | *** dkayiwa has joined #openmrs |
| 13:38:31 | *** kjoseph has quit IRC |
| 13:40:27 | *** kaweesi_joseph has quit IRC |
| 13:58:31 | *** sgithens has quit IRC |
| 13:59:20 | *** suranga has joined #openmrs |
| 13:59:20 | *** ChanServ sets mode: +v suranga |
| 13:59:21 | *** shangxiao has joined #openmrs |
| 13:59:34 | * shangxiao pings rafa |
| 13:59:44 | <rafa> shangxiao: hi |
| 13:59:52 | <shangxiao> hi |
| 14:00:16 | <shangxiao> after a bit of messing around with git i managed to squash and rebase my PR on top of the current core head |
| 14:00:18 | <shangxiao> :) |
| 14:00:27 | <rafa> shangxiao: awesome |
| 14:00:33 | <shangxiao> so it should be a fast forward now |
| 14:00:50 | <shangxiao> i think |
| 14:00:50 | <rafa> shangxiao: very nice |
| 14:00:58 | <shangxiao> *fingers crossed* ;) |
| 14:03:18 | *** rfriedman has joined #openmrs |
| 14:03:50 | <rfriedman> jkeiper, hey jeremy, got a minute? |
| 14:05:44 | <rfriedman> suranga, hey suranga, have you worked with drug concepts? |
| 14:10:06 | *** nribeka has quit IRC |
| 14:10:10 | *** Gurpreet has joined #openmrs |
| 14:10:34 | <Gurpreet> The developers meetup will happen after an hour? |
| 14:11:00 | <Gurpreet> The page https://wiki.openmrs.org/display/RES/Connect+Meeting+Rooms says 14:00 UTC. |
| 14:11:01 | <OpenMRSBot> <http://ln-s.net/9$Vu> (at wiki.openmrs.org) |
| 14:11:26 | *** kjoseph has joined #openmrs |
| 14:12:02 | <kjoseph> dkayiwa: good evening |
| 14:13:04 | <dkayiwa> kjoseph: good evening |
| 14:14:50 | <rafa> Gurpreet: yes, it starts in an hour |
| 14:15:32 | <Gurpreet> Thanks. Then maybe the wiki page should be updated.. it says 14:00 UTC.. its already 14:00 UTC. Shall i update it? |
| 14:16:06 | <kjoseph> dkayiwa: i have failed to connect using wireless thats why i have dalayed but finally using a modem, so am now ready to heed and continue by your help |
| 14:16:31 | <Gurpreet> http://www.worldtimeserver.com/current_time_in_UTC.aspx |
| 14:16:32 | <OpenMRSBot> <http://ln-s.net/xkB> (at www.worldtimeserver.com) |
| 14:16:37 | <rfriedman> Gupreet, do I remember it wrong, or does the page have 2 columns, one for US Daylight time and one for US Standard time? |
| 14:16:40 | <rafa> Gurpreet: we actually schedule the calls according to EST |
| 14:16:43 | <dkayiwa> kjoseph: did you read the git docs i sent you? |
| 14:16:56 | <kjoseph> dkayiwa: yes i did |
| 14:17:06 | <rfriedman> no rafa, we actually schedule the calls according to ET |
| 14:17:11 | <dkayiwa> kjoseph: were you then able to push your code to github? |
| 14:17:25 | <kjoseph> dkayiwa: not yet |
| 14:17:26 | <rfriedman> that's why the hour changes when we go from EST to EDT and back |
| 14:17:33 | *** djazayeri has joined #openmrs |
| 14:17:33 | *** ChanServ sets mode: +o djazayeri |
| 14:17:43 | <dkayiwa> kjoseph: can you do that now? |
| 14:17:48 | <rfriedman> hey djazayeri |
| 14:18:02 | <Gurpreet> Yes.. actually i think its best to mention EST , PST times.. so that people can ensure they get it right .. even during DST shifts. |
| 14:18:20 | <djazayeri> hi rfriedman |
| 14:18:27 | <Gurpreet> I will update wiki page? https://wiki.openmrs.org/display/RES/Connect+Meeting+Rooms |
| 14:18:28 | <OpenMRSBot> <http://ln-s.net/9$Vu> (at wiki.openmrs.org) |
| 14:18:31 | <djazayeri> (busy now putting together presentation for an hour from now) |
| 14:18:39 | <rfriedman> djazayeri, can I ask you a question about concept_drug? |
| 14:19:13 | <rfriedman> djazayeri, ok later |
| 14:19:22 | <rfriedman> or elsewho |
| 14:20:15 | <Gurpreet> I can update the dev meetup time to be "10:00AM EST" there instead of 14:00 UTC. |
| 14:20:27 | <rafa> dkayiwa: you noticed CI failed after your commit right? |
| 14:20:41 | <rafa> dkayiwa: openmrs-core |
| 14:20:49 | <rfriedman> Gurpreet, "ET" not "EST" |
| 14:20:59 | <dkayiwa> rafa: i have not yet got any email about it :) |
| 14:21:10 | <Gurpreet> Eastern Time (ET).. ok .. |
| 14:21:10 | <rafa> dkayiwa: it happened yesterday |
| 14:21:17 | <rafa> dkayiwa: I don't think we get e-mails now |
| 14:21:21 | <rafa> dkayiwa: you need to watch it |
| 14:21:22 | <dkayiwa> rafa: since yesterday |
| 14:21:28 | <dkayiwa> rafa: from where |
| 14:21:38 | <rafa> https://ci.openmrs.org |
| 14:22:15 | *** wluyima has joined #openmrs |
| 14:22:49 | <dkayiwa> rafa: ok thanks |
| 14:23:44 | <rafa> dkayiwa: actually we do get e-mails |
| 14:23:47 | <rafa> dkayiwa: just found it |
| 14:24:14 | <dkayiwa> rafa: not yet seen mine |
| 14:24:53 | <rafa> dkayiwa: maybe you need to mark the build as favourite, I don't know |
| 14:25:02 | <dkayiwa> rafa: ok |
| 14:25:03 | <Gurpreet> Updated the wiki page. Thanks! |
| 14:29:48 | *** dkayiwa has quit IRC |
| 14:33:15 | *** dkayiwa has joined #openmrs |
| 14:37:40 | *** suranga has quit IRC |
| 14:39:32 | *** dkayiwa has quit IRC |
| 14:40:17 | *** sgithens has joined #openmrs |
| 14:42:58 | *** dkayiwa has joined #openmrs |
| 14:47:14 | <rafa> dkayiwa: are you working on fixing the build? |
| 14:47:30 | <rafa> dkayiwa: I want to push something, but probabaly should wait until you fix it |
| 14:48:38 | <dkayiwa> rafa: am trying to look for the exact test that failed |
| 14:48:51 | <rafa> validate_shouldFailValidationIfEmailAsUsernameEnabledAndEmailInvalid(org.openmrs.validator.UserValidatorTest) |
| 14:49:11 | <rafa> fails on my pc too |
| 14:49:23 | <dkayiwa> rafa: i found that failing even before i committed :) |
| 14:49:34 | <dkayiwa> rafa: so i just ignored it |
| 14:50:16 | <dkayiwa> rafa: can we check of an earlier build failure? |
| 14:50:19 | <rafa> dkayiwa: hmmm it didn't fail on CI and my PC |
| 14:50:40 | <rafa> dkayiwa: yes https://ci.openmrs.org/browse/JU-CORE/latest |
| 14:50:53 | <rafa> dkayiwa: see green dots in the top right corner |
| 14:50:58 | <dkayiwa> rafa: ok |
| 14:53:08 | *** kavuri has quit IRC |
| 14:54:52 | *** lh has joined #openmrs |
| 14:54:52 | *** lh has joined #openmrs |
| 14:56:23 | *** mseaton has quit IRC |
| 15:01:21 | *** nribeka has joined #openmrs |
| 15:01:21 | *** ChanServ sets mode: +v nribeka |
| 15:04:47 | *** wluyima has quit IRC |
| 15:09:10 | *** sgithens has quit IRC |
| 15:12:35 | *** Gurpreet has quit IRC |
| 15:14:30 | *** kishoreyekkanti has quit IRC |
| 15:20:28 | *** wluyima has joined #openmrs |
| 15:28:52 | *** sgithens has joined #openmrs |
| 15:44:32 | *** kjoseph has quit IRC |
| 15:44:59 | *** kjoseph has joined #openmrs |
| 15:52:09 | <kjoseph> dkayiwa: |
| 15:52:46 | <dkayiwa> kjoseph: |
| 15:54:17 | *** kaweesi_joseph has joined #openmrs |
| 16:01:38 | *** kaweesi_joseph has quit IRC |
| 16:01:49 | *** kjoseph has quit IRC |
| 16:10:59 | *** lh has quit IRC |
| 16:13:11 | <rfriedman> jkeiper, you really there? |
| 16:25:32 | *** dkayiwa has quit IRC |
| 16:35:10 | *** jkeiper has quit IRC |
| 16:35:33 | *** sgithens has quit IRC |
| 16:51:45 | *** suranga has joined #openmrs |
| 16:51:45 | *** ChanServ sets mode: +v suranga |
| 16:54:04 | *** afiles has joined #openmrs |
| 16:54:38 | *** afiles has left #openmrs |
| 16:57:56 | *** rfriedman has quit IRC |
| 17:22:48 | *** suranga_ has joined #openmrs |
| 17:25:54 | *** suranga has quit IRC |
| 17:44:59 | *** shangxiao has quit IRC |
| 17:52:02 | *** kishoreyekkanti has joined #openmrs |
| 18:06:50 | *** rafa has quit IRC |
| 18:12:43 | *** jkeiper has joined #openmrs |
| 18:12:43 | *** ChanServ sets mode: +v jkeiper |
| 18:29:12 | *** sgithens has joined #openmrs |
| 18:33:03 | *** dkayiwa has joined #openmrs |
| 18:33:37 | *** sgithens has quit IRC |
| 19:01:14 | <suranga_> howdy guys. hmm... looks like I missed rafa :-( |
| 19:10:01 | *** robbyoconnor has joined #openmrs |
| 19:10:01 | *** ChanServ sets mode: +v robbyoconnor |
| 19:10:43 | *** wluyima has quit IRC |
| 19:10:54 | *** rafa has joined #openmrs |
| 19:10:54 | *** ChanServ sets mode: +v rafa |
| 19:24:05 | *** wluyima has joined #openmrs |
| 19:33:49 | *** robbyoconnor has quit IRC |
| 19:38:16 | *** kishoreyekkanti has quit IRC |
| 19:42:55 | *** rafa has quit IRC |
| 19:47:41 | *** rafa has joined #openmrs |
| 19:47:41 | *** ChanServ sets mode: +v rafa |
| 20:02:15 | *** cpower has joined #openmrs |
| 20:02:21 | *** Mkop1 has joined #openmrs |
| 20:02:21 | *** ChanServ sets mode: +v Mkop1 |
| 20:02:25 | <cpower> Hello fellow Scrummers! |
| 20:02:58 | <cpower> This really is the highlight of my day |
| 20:03:09 | <cpower> Are we ready to scrum? |
| 20:03:39 | <cpower> !scrumon cpower |
| 20:03:39 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 20:04:14 | <djazayeri> bring it! |
| 20:04:16 | <cpower> Order dkayiwa, wluyima, rafa, djazayeri, and Andrea when she shows |
| 20:05:03 | *** andrea_p has joined #openmrs |
| 20:05:13 | <cpower> dkayiwa goo |
| 20:05:32 | <andrea_p> anybody here? |
| 20:05:35 | <dkayiwa> Was trying, all day, to fix: Patient dashboard tabs do not load after restarting xforms module - TRUNK-220 only to find that its a bug in OpenMRS |
| 20:05:36 | <dkayiwa> No Blockers |
| 20:05:36 | *** Mkop has quit IRC |
| 20:05:51 | <wluyima> Wednesday: |
| 20:05:51 | <wluyima> Design call |
| 20:05:51 | <wluyima> TRUNK-3586 - Update unit testing environment to use mocks |
| 20:05:51 | <wluyima> |
| 20:05:51 | <wluyima> Thursday: |
| 20:05:52 | <wluyima> dev call |
| 20:05:54 | <wluyima> Emails and responding to a couple of questions at answers.openmrs.org |
| 20:05:56 | <wluyima> Testing Atlas module |
| 20:05:58 | <wluyima> |
| 20:06:02 | <wluyima> Blockers: none |
| 20:06:09 | <cpower> that's papa wyclif to rest of you |
| 20:06:09 | <djazayeri> wluyima: let's discuss answers.openmrs.org |
| 20:06:29 | <rafa> Today: |
| 20:06:29 | <rafa> * Reworked TRUNK-3781: Support a mechanism for modules to execute code in Daemon thread |
| 20:06:29 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3781 |
| 20:06:29 | <rafa> * Reviewed TRUNK-3778: Add support for JPA annotations (waiting with merging for Daniel to make the CI green :) |
| 20:06:29 | <rafa> https://tickets.openmrs.org/browse/TRUNK-3778 |
| 20:06:29 | <rafa> * Dev Call |
| 20:06:30 | <rafa> * Had a look at SASS and Compass with TW guys |
| 20:06:30 | <rafa> No blockers. |
| 20:06:49 | <djazayeri> wluyima: and also I replied to your email about TRUNK-3586: you should link to a code sample! |
| 20:06:59 | <andrea_p> cpower, my turn? |
| 20:07:11 | <djazayeri> Yesterday |
| 20:07:11 | <djazayeri> * Mirebalais "merge patients" story |
| 20:07:11 | <djazayeri> * Lots of calls |
| 20:07:11 | <djazayeri> Today |
| 20:07:12 | <cpower> not yet |
| 20:07:12 | <djazayeri> * Calls |
| 20:07:12 | <djazayeri> * Paired with Alex and Nano (TWers) on writing new CSS rules for the Mirebalais homepage |
| 20:07:13 | <djazayeri> * Continue TRUNK-3804 - Merge Patients ignores visits |
| 20:07:14 | <djazayeri> no blockers |
| 20:07:22 | <cpower> now your turn |
| 20:07:39 | <andrea_p> Wednesday |
| 20:07:40 | <andrea_p> Univ call |
| 20:07:40 | <andrea_p> Design call |
| 20:07:40 | <andrea_p> TRUNK-3474 |
| 20:07:40 | <andrea_p> Finished changes/checking remaining subclasses of OpenmrsMetadata |
| 20:07:40 | <andrea_p> for NOT NULL Constraint on description |
| 20:07:42 | <andrea_p> Verified that Validators no longer reject null/empty descriptions |
| 20:07:44 | <andrea_p> Test changes for TRUNK-3474 in UI |
| 20:07:46 | <andrea_p> |
| 20:07:48 | <andrea_p> Thursday |
| 20:07:50 | <andrea_p> Continued to test changes for TRUNK-3474 in UI |
| 20:07:52 | <andrea_p> Ready to do pull request |
| 20:07:54 | <andrea_p> Setup OpenMRS on new computer |
| 20:07:56 | <andrea_p> |
| 20:07:58 | <andrea_p> No blockers - but `wanted to mention some odd things I noticed |
| 20:08:57 | <djazayeri> Okay, so, discussion points: |
| 20:09:02 | <cpower> Ok discussion points questions from Andrea, but other than that. Have a nice day |
| 20:09:04 | <djazayeri> (1) about answers.openmrs.org |
| 20:09:10 | <cpower> !scrumoff |
| 20:09:10 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:09:46 | <andrea_p> order_type - |
| 20:09:46 | <andrea_p> no table when using sql after jetty:run but there when using standalone. |
| 20:09:46 | <andrea_p> no Validators |
| 20:09:46 | <andrea_p> relationship_type |
| 20:09:46 | <andrea_p> Had NOT NULL constraint - I removed it |
| 20:09:47 | <andrea_p> No validator |
| 20:09:47 | <djazayeri> wluyima, dkayiwa, rafa, and everyone else: when you're answering questions posted there (which you should be!), do try to point people to not misuse the tool |
| 20:09:49 | <andrea_p> No validator test |
| 20:09:51 | <andrea_p> |
| 20:09:53 | <andrea_p> program |
| 20:09:55 | <andrea_p> there is a description in program table -- NO NOT NULL constraint |
| 20:09:57 | <andrea_p> No mention of description inProgramValidator |
| 20:09:59 | <andrea_p> No @should in ProgramValidator for validate_shouldFailValidationIfDescriptionIsNullOrEmptyOrWhitespace() |
| 20:10:02 | <andrea_p> ProgramValidatorTest |
| 20:10:04 | <andrea_p> validate_shouldFailValidationIfDescriptionIsNullOrEmptyOrWhitespace() looks wrong |
| 20:10:07 | <dkayiwa> djazayeri: ok :) |
| 20:10:09 | <andrea_p> can you read that? |
| 20:10:16 | <djazayeri> andrea_p: please use pastebin |
| 20:10:26 | <rafa> djazayeri: meaning? |
| 20:10:27 | <andrea_p> ok - what's url again? |
| 20:10:40 | <wluyima> djazayeri, i responded to your email, i have a few small things to finish up with the data exports and sechudler service tests that i need to finish, was green about data exports so i had to look at the code closely in order to be able to mock it up |
| 20:10:48 | <rafa> djazayeri: misuse the tool? |
| 20:11:10 | <djazayeri> dkayiwa, wluyima, rafa: see for example https://answers.openmrs.org/questions/891/back-button-does-not-retain-search-results |
| 20:11:18 | <dkayiwa> djazayeri: ok |
| 20:11:22 | <rafa> djazayeri: shame on me I haven't answered a single question there |
| 20:11:43 | <djazayeri> e.g. answers.openmrs.org should be like stackoverflow, in that we should be trying to address questions with concrete answers, that can be marked as "accepted" |
| 20:12:19 | <djazayeri> a question like "I see what I think is a bug, should we do x, y, or z?" should happen on a mailing list. |
| 20:12:29 | <djazayeri> andrea_p: pastebin.com |
| 20:12:55 | <andrea_p> here's pastebin url: http://pastebin.com/CrQpQqMx |
| 20:13:03 | <rafa> djazayeri: ok |
| 20:14:32 | <djazayeri> dkayiwa: can you walk through those points with andrea_p? |
| 20:15:02 | <andrea_p> ok 1. is order_type table gone? |
| 20:15:32 | <dkayiwa> andrea_p: can i do walk you through after an email am sending? :) |
| 20:15:35 | <djazayeri> andrea_p: in master (1.10-SNAPSHOT) I think so |
| 20:15:50 | <rafa> is there any way to have new questions from answers.openmrs.org mailed to me? |
| 20:16:05 | <andrea_p> dkayiwa, sure |
| 20:16:14 | <rafa> and answer via e-mail |
| 20:16:14 | <dkayiwa> andrea_p: ok thanks :) |
| 20:16:24 | <djazayeri> rafa: I don't know. I added it to my rss feed |
| 20:16:40 | <wluyima> djazayeri, i agree with your, someone has been posting alot of questions on the dev list which should be dev list discussions and not really questions that need answers |
| 20:18:02 | <andrea_p> djazayeri, ready to do pull request on TRUN-3474 - thought i should mention a couple things that didn't seem right |
| 20:18:18 | <rafa> djazayeri: ok, thx. I can live with rss |
| 20:20:16 | <djazayeri> wluyima: yeah, so let's just try to correct them, rather than just answering their questions in the wrong place. :-) |
| 20:20:33 | <wluyima> djazayeri, ok |
| 20:41:04 | *** robbyoconnor has joined #openmrs |
| 20:41:04 | *** ChanServ sets mode: +v robbyoconnor |
| 20:43:32 | <andrea_p> djazayeri, u still around? |
| 20:43:44 | <djazayeri> andrea_p: yes, but on a call, what's up? |
| 20:45:00 | <andrea_p> djazayeri, just did pull request for TRUNK-3474 |
| 20:45:48 | <djazayeri> andrea_p: I see it |
| 20:45:59 | <djazayeri> andrea_p: ready to move onto another ticket then, while that one gets reviewed? |
| 20:46:13 | <andrea_p> djazayeri, sure |
| 20:47:42 | <andrea_p> djazayeri, first I'm going to finish setting up OpenMRS on new computer |
| 20:47:47 | <djazayeri> okay |
| 20:49:10 | <andrea_p> djazayeri, work computer got "blue screen of death" or whatever it'd called - came back when I took out battery but still acting very strange |
| 20:54:11 | *** rafa has quit IRC |
| 20:56:00 | *** rafa has joined #openmrs |
| 20:56:00 | *** ChanServ sets mode: +v rafa |
| 21:01:31 | *** rafa has quit IRC |
| 21:01:59 | *** rafa has joined #openmrs |
| 21:01:59 | *** ChanServ sets mode: +v rafa |
| 21:04:27 | *** rafa has quit IRC |
| 21:04:53 | *** rafa has joined #openmrs |
| 21:04:53 | *** ChanServ sets mode: +v rafa |
| 21:06:34 | *** rafa has quit IRC |
| 21:07:02 | *** rafa has joined #openmrs |
| 21:07:02 | *** ChanServ sets mode: +v rafa |
| 21:09:15 | <dkayiwa> andrea_p: am back just incase you still need me :) |
| 21:11:57 | <andrea_p> dkayiwa, here's pastebin url: http://pastebin.com/CrQpQqMx |
| 21:12:37 | <dkayiwa> andrea_p: ok |
| 21:12:38 | <andrea_p> dkayiwa, thet aren't questions - just some thinks I noticed that didn't seem right |
| 21:13:01 | <andrea_p> dkayiwa, just thought you all should know about them |
| 21:13:37 | <dkayiwa> andrea_p: ok |
| 21:14:17 | <andrea_p> dkayiwa, did pull request just now |
| 21:14:31 | <dkayiwa> andrea_p: about them? |
| 21:15:15 | <andrea_p> dkayiwa, pull request for all changes I made for TRUNK-3474 |
| 21:15:34 | <dkayiwa> andrea_p: oh i see, not for the pastebin issues you have raised? |
| 21:16:05 | <andrea_p> dkayiwa, no these were just things I noticed when making changes |
| 21:16:40 | <andrea_p> dkayiwa, I guess we don't have to worry about them |
| 21:16:45 | <dkayiwa> andrea_p: do you think you can create tickets about them? |
| 21:17:26 | <andrea_p> dkayiwa, have never created a ticket but I'm sure I can figure it out |
| 21:18:06 | <dkayiwa> andrea_p: yes it will be a great exercise for you to learn that too :D |
| 21:18:34 | <andrea_p> dkayiwa, yes I agree - are there instructions in wiki for creating a ticket? |
| 21:20:33 | <dkayiwa> andrea_p: looking ..... |
| 21:21:33 | <dkayiwa> andrea_p: https://wiki.openmrs.org/display/docs/Tickets |
| 21:23:10 | <andrea_p> dkayiwa, thanks! Will do ticket. |
| 21:29:29 | *** suranga_ has quit IRC |
| 21:29:51 | <dkayiwa> hi rafa |
| 21:30:09 | *** rafa has quit IRC |
| 21:30:36 | *** rafa has joined #openmrs |
| 21:30:36 | *** ChanServ sets mode: +v rafa |
| 21:31:47 | *** rafa has quit IRC |
| 21:33:37 | *** rafa has joined #openmrs |
| 21:33:37 | *** ChanServ sets mode: +v rafa |
| 21:40:37 | *** andrea_p has quit IRC |
| 21:53:17 | *** jkeiper has quit IRC |
| 22:02:09 | *** dkayiwa has quit IRC |
| 22:23:30 | *** wluyima has quit IRC |
| 22:35:34 | *** Mkop1 has quit IRC |
| 22:43:22 | *** andrea has joined #openmrs |
| 22:43:41 | *** andrea is now known as Guest77474 |
| 22:44:12 | *** Guest77474 is now known as andrea_p |
| 22:50:31 | *** nribeka has quit IRC |
| 22:50:38 | *** Mkop has joined #openmrs |
| 22:50:38 | *** ChanServ sets mode: +v Mkop |
| 22:51:07 | *** Mkop has left #openmrs |
| 23:06:51 | *** rafa has quit IRC |