01:07:25
|
*** djazayeri has quit IRC
|
03:39:08
|
*** djazayeri has joined #openmrs
|
03:39:09
|
*** ChanServ sets mode: +o djazayeri
|
05:03:29
|
*** fishandwalk has joined #openmrs
|
05:08:40
|
*** wluyima has joined #openmrs
|
05:53:46
|
*** fishandwalk has quit IRC
|
05:59:05
|
*** fishandwalk has joined #openmrs
|
06:12:35
|
*** djazayeri has quit IRC
|
06:32:55
|
*** dkayiwa has joined #openmrs
|
07:26:33
|
*** suranga_ has joined #openmrs
|
07:57:06
|
*** dkayiwa has quit IRC
|
08:04:26
|
*** suranga__ has joined #openmrs
|
08:07:11
|
*** suranga_ has quit IRC
|
08:42:11
|
*** suranga__ has quit IRC
|
09:01:28
|
*** suranga has joined #openmrs
|
09:24:05
|
*** suranga has quit IRC
|
09:25:32
|
*** suranga has joined #openmrs
|
10:20:44
|
*** suranga has quit IRC
|
10:36:38
|
*** suranga_ has joined #openmrs
|
10:58:28
|
*** Adam_ has joined #openmrs
|
10:59:38
|
*** yony258 has joined #openmrs
|
11:00:11
|
*** suranga__ has joined #openmrs
|
11:00:48
|
*** suranga_ has quit IRC
|
11:05:52
|
*** yony258 has quit IRC
|
11:07:20
|
*** yony258 has joined #openmrs
|
11:07:29
|
*** dkayiwa has joined #openmrs
|
11:08:29
|
<yony258> dkayiwa: Hi dkayiwa
|
11:08:36
|
<dkayiwa> hi yony258
|
11:13:44
|
*** Adam_ has quit IRC
|
11:13:58
|
*** yony258_ has joined #openmrs
|
11:14:16
|
*** AdamLauz has joined #openmrs
|
11:14:19
|
<yony258_> sry had a DC.
|
11:15:02
|
*** yony258 has quit IRC
|
11:15:38
|
<AdamLauz> dkayiwa: Hi daniel how are you?
|
11:15:51
|
<dkayiwa> AdamLauz: am doing fine. and you?
|
11:16:06
|
<AdamLauz> dkayiwa: great...
|
11:16:26
|
<AdamLauz> dkayiwa: Can meet with us right now?
|
11:16:41
|
<AdamLauz> dkayiwa: can you*
|
11:16:57
|
<dkayiwa> AdamLauz: no problem
|
11:17:42
|
<yony258_> AdamLauz: dkayiwa we can use teamviewer if you prefer
|
11:18:23
|
<dkayiwa> yony258_: no problem
|
11:19:59
|
<yony258_> dkayiwa: So do you want to share your screen and show us, or do you prefer to guide one of us how to start?
|
11:20:45
|
<dkayiwa> yony258_: i would prefer you share your screen and i just connect to it
|
11:21:00
|
<dkayiwa> yony258_: that way you drive while am in the co-driver seat :)
|
11:21:07
|
<dkayiwa> yony258_: reading the map :)
|
11:21:29
|
<yony258_> dkayiwa: ok great, let me start a meeting :)
|
11:23:12
|
<yony258_> dkayiwa: Meeting ID: m51-133-678
|
11:23:19
|
<yony258_> AdamLauz: Meeting ID: m51-133-678
|
11:23:23
|
<dkayiwa> yony258_: ok
|
11:24:26
|
<dkayiwa> yony258_: password
|
11:24:49
|
<yony258_> dkayiwa: can you hear me?
|
11:24:51
|
<dkayiwa> yony258_: oh sorry
|
11:24:56
|
<dkayiwa> yony258_: connected
|
11:25:25
|
<dkayiwa> yony258_: cannot hear you
|
11:25:33
|
<yony258_> let me check what is the problem
|
11:25:41
|
<dkayiwa> yony258_: but can see your screeen
|
11:27:04
|
<yony258_> dkayiwa: I have no idea why the audio isn't working..
|
11:27:20
|
<dkayiwa> yony258_: i too have no idea
|
11:27:46
|
<yony258_> dkayiwa: Maybe we can use skype for audio and teamviewer for screen sharing
|
11:28:12
|
<dkayiwa> yony258_: no problem
|
11:28:34
|
<yony258_> dkayiwa: yonatan.gr
|
12:06:13
|
*** rafa has joined #openmrs
|
12:06:13
|
*** ChanServ sets mode: +v rafa
|
12:13:19
|
*** rafa has quit IRC
|
12:14:59
|
<suranga__> hi, dkayiwa or rafa (whoever is the most free ) :-)
|
12:16:01
|
<dkayiwa> suranga__: :)
|
12:16:23
|
<suranga__> hi dkayiwa sorry to bug you, but I seem to have hit a small problem
|
12:16:48
|
<suranga__> dkayiwa, im using restful web services ( a module that extends our webservices.rest module)
|
12:17:17
|
<suranga__> I want the admin page to have a link, and when someone clicks on that link, they should be navigated to a simple htmll page.
|
12:17:48
|
<suranga__> dkayiwa, this is very very basic, ive done it a million times. but for some reason, this time It keeps failing no matter what :-(
|
12:19:21
|
<dkayiwa> suranga__: how does it fail?
|
12:19:43
|
*** rafa has joined #openmrs
|
12:19:43
|
*** ChanServ sets mode: +v rafa
|
12:19:43
|
<suranga__> dkayiwa, it keeps saying page not found :-(
|
12:20:56
|
<suranga__> dkayiwa, as with the webservices.rest module, the jsp page is in the src.main.webapp of the omod folder...
|
12:21:38
|
<suranga__> dkayiwa, and the url that points to it says map.put("module/RHEASHRadapter/test.form", "test");
|
12:22:30
|
<dkayiwa> suranga__: do you have a controller for it?
|
12:23:36
|
<suranga__> dkayiwa, yes, before that, I also tried without the controller and with the .htm extension :(
|
12:24:00
|
<suranga__> dkayiwa, would u like to look at the code, by any chance ? :)
|
12:24:46
|
<dkayiwa> suranga__: ok
|
12:25:00
|
<suranga__> dkayiwa, yay ! gimmie a sec
|
12:25:02
|
* suranga__ runs
|
12:25:14
|
*** jkeiper has joined #openmrs
|
12:25:14
|
*** ChanServ sets mode: +v jkeiper
|
12:31:19
|
<suranga__> dkayiwa, hi
|
12:31:23
|
<suranga__> dkayiwa, http://pastebin.com/d8aNEUrv
|
12:31:27
|
<suranga__> dkayiwa, :-) :-)
|
12:34:33
|
<dkayiwa> suranga__: give me a few mins :)
|
12:35:04
|
<suranga__> dkayiwa, nooo worries :-)
|
12:35:22
|
<suranga__> rafa, greetings !
|
12:35:33
|
<rafa> suranga__: hey
|
12:35:38
|
<suranga__> rafa, part one of my call was recorded yesterday :-)
|
12:35:51
|
<rafa> suranga__: happy to hear
|
12:35:52
|
<suranga__> today / tomorrow I do part 2 :-)
|
12:36:08
|
<rafa> suranga__: great
|
12:36:12
|
<rafa> suranga__: mail me a link when ready
|
12:46:19
|
*** robbyoconnor has quit IRC
|
12:54:13
|
*** dkayiwa has quit IRC
|
12:56:11
|
*** dkayiwa has joined #openmrs
|
13:03:53
|
<dkayiwa> hi suranga__
|
13:04:05
|
<dkayiwa> suranga__: did rafa help you fix the problem? :)
|
13:04:06
|
<suranga__> dkayiwa, helooooo :-)
|
13:04:29
|
<suranga__> dkayiwa, mmm.... I was hoping you had found something...
|
13:04:47
|
<dkayiwa> suranga__: was in another another meeting
|
13:05:13
|
<suranga__> dkayiwa, no worries. by any chance are you free now ? :P
|
13:05:42
|
<dkayiwa> suranga__: yes let me look at it now :)
|
13:06:02
|
* suranga__ says yay !!! :-)
|
13:10:38
|
<dkayiwa> suranga__: is the code somewhere in a repo or the compiled module available for me to look at?
|
13:11:12
|
<suranga__> dkayiwa, I could commit in these changes, and give you my credentials :-)
|
13:11:18
|
<suranga__> dkayiwa, give me 2 minutes :-)
|
13:11:27
|
<dkayiwa> suranga__: ok
|
13:30:34
|
*** wluyima has quit IRC
|
13:47:43
|
*** nribeka has joined #openmrs
|
13:47:45
|
*** ChanServ sets mode: +v nribeka
|
13:58:16
|
*** fishandwalk has quit IRC
|
13:58:42
|
<dkayiwa> suranga__: there are some unit tests failing
|
13:59:23
|
<suranga__> dkayiwa, im afraid so, those tests are really outdated :-)
|
13:59:42
|
<dkayiwa> can you commit without failing unit tests? :)
|
14:00:13
|
<suranga__> dkayiwa, um.. I could comment them out for now. those tests are like really old... :-)
|
14:00:34
|
<dkayiwa> suranga__: please do and commit :)
|
14:00:42
|
*** lh has joined #openmrs
|
14:00:46
|
<suranga__> dkayiwa, sure thing. 1 minute please :-)
|
14:03:07
|
<dkayiwa> suranga__: commit and let me get back in 5mins
|
14:05:24
|
*** dkayiwa has quit IRC
|
14:14:27
|
*** dkayiwa has joined #openmrs
|
14:14:36
|
<dkayiwa> suranga__: committed?
|
14:14:46
|
<suranga__> dkayiwa, yes. I did
|
14:14:51
|
<dkayiwa> suranga__: ok
|
14:15:08
|
<suranga__> dkayiwa, but im suspicious. Are you trying to tell me that theres something wrong in that code ? :-)
|
14:17:39
|
<dkayiwa> suranga__: can you change from: @RequestMapping(value="/module/rheashradapter/test")
|
14:18:00
|
<dkayiwa> suranga__: to: @RequestMapping(value="/module/RHEASHRadapter/test")
|
14:18:16
|
<dkayiwa> suranga__: in Hl7TestController and then try again?
|
14:18:22
|
<suranga__> dkayiwa, um.. Im sure I did try that... but let me do so ....
|
14:18:32
|
<dkayiwa> suranga__: please do
|
14:18:57
|
*** wluyima has joined #openmrs
|
14:19:36
|
<dkayiwa> suranga__: also remember to change in AdminList too
|
14:19:44
|
<dkayiwa> suranga__: from: map.put("module/rheashradapter/test.form", "test");
|
14:19:58
|
<dkayiwa> suranga__: to map.put("module/RHEASHRadapter/test.form", "test");
|
14:22:40
|
<suranga__> dkayiwa, :-(
|
14:22:50
|
<suranga__> dkayiwa, im afraid that Im still facing the same :(
|
14:23:22
|
<dkayiwa> suranga__: let me compile and test myself :)
|
14:23:34
|
<suranga__> dkayiwa, im really sorry about this :-(
|
14:24:10
|
<dkayiwa> suranga__: sorry for writing a buggy module? :)
|
14:24:31
|
<suranga__> dkayiwa, plus having to ask you to test it :-) :-) :-)
|
14:25:10
|
<dkayiwa> suranga__: hahahaha. we help one another here. so no need to be sorry. next time it may be my turn :)
|
14:25:59
|
<dkayiwa> suranga__: you are also forgetting i enjoy debugging stubborn things like these :D
|
14:26:30
|
<suranga__> dkayiwa, :-)
|
14:27:22
|
<suranga__> dkayiwa, in that case, I will definitely be able to help you. Please feel free to ping me and ask me for bugs :P
|
14:27:33
|
<dkayiwa> suranga__: :)
|
14:39:36
|
*** kjoseph has joined #openmrs
|
14:40:25
|
<kjoseph> dkayiwa: good evening
|
14:41:05
|
<dkayiwa> kjoseph: good evening to you too :)
|
14:41:27
|
<kjoseph> dkayiwa: i have finished the page and the child pages
|
14:42:08
|
*** jkeiper has quit IRC
|
14:42:21
|
<dkayiwa> kjoseph: oh good
|
14:42:39
|
<dkayiwa> kjoseph: can you start by adding another link on the admin page?
|
14:43:03
|
*** sgithens has joined #openmrs
|
14:43:47
|
*** yony258_ has quit IRC
|
14:45:18
|
<dkayiwa> kjoseph: that is in your module
|
14:46:42
|
*** AdamLauz has quit IRC
|
14:47:56
|
*** cpower has joined #openmrs
|
14:53:17
|
*** kjoseph has quit IRC
|
14:53:30
|
<dkayiwa> suranga__: sorry i need to log off and get back later
|
14:53:32
|
<dkayiwa> suranga__: ok?
|
14:54:02
|
<suranga__> dkayiwa, no worries :)
|
14:54:05
|
<dkayiwa> suranga__: but will continue with it if by the time i come back, you will have no solution yet :)
|
14:54:20
|
*** dkayiwa has quit IRC
|
14:54:37
|
<suranga__> dkayiwa, thank you so much for looking into this :)
|
14:59:26
|
<cpower> It's quiet in here for a Monday
|
15:00:22
|
*** lh has quit IRC
|
15:00:46
|
<cpower> and developers are disappearing right before my eyes
|
15:02:25
|
<cpower> Well ok, scrums go on regardless of who's here so let's get this thing going
|
15:02:33
|
<cpower> !scrumon cpower
|
15:02:33
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:02:53
|
<cpower> Order:
|
15:03:17
|
<cpower> wluyima, suranga__, rafa, and Andrea if she shows
|
15:04:00
|
*** andrea__ has joined #openmrs
|
15:04:33
|
<cpower> So Wyclif go
|
15:04:55
|
<wluyima> Friday:
|
15:04:55
|
<wluyima> Dev call
|
15:04:55
|
<wluyima> Spike on TRUNK-3586 - Update unit testing environment to use mocks
|
15:04:55
|
<wluyima> Curating tickets
|
15:04:55
|
<wluyima>
|
15:04:55
|
<wluyima> Monday:
|
15:04:57
|
<wluyima> Continue with Spike on TRUNK-3586 - Update unit testing environment to use mocks
|
15:04:59
|
<wluyima> Spike on TRUNK-3774 - Use Maven Surefire Plugin to run unit tests and Maven Failsafe
|
15:05:01
|
<wluyima>
|
15:05:03
|
<wluyima> Blockers: none
|
15:05:10
|
<suranga__> hi !
|
15:05:13
|
<suranga__> DID
|
15:05:13
|
<suranga__> Part one of my presentation for this weeks university call
|
15:05:13
|
<suranga__> To DO
|
15:05:13
|
<suranga__> Part two of the presentation
|
15:05:13
|
<suranga__> Pick up a ticket from the current sprint :-)
|
15:05:25
|
<suranga__> NO BLOCKERS
|
15:05:34
|
<rafa> Yesterday:
|
15:05:34
|
<rafa> * Hacked on the Omod Reloader module. Check it out: https://modules.openmrs.org/modules/view.jsp?module=omodreloader
|
15:05:34
|
<rafa> Today:
|
15:05:34
|
<rafa> * Started #149 Handle the case when a admin clerk attempts to check-in a patient who is already checked in (Mirebalais)
|
15:05:34
|
<rafa> No blockers.
|
15:06:35
|
<andrea__> my turn?
|
15:06:39
|
<cpower> yep
|
15:06:56
|
<andrea__> Friday
|
15:06:56
|
<andrea__> Morning - work computer crashed
|
15:06:56
|
<andrea__> TRUNK-3474
|
15:06:56
|
<andrea__> Liquibase changeset
|
15:06:56
|
<andrea__> Modify 8 Hiberenate congig xml file - change not null constraint
|
15:06:57
|
<andrea__> Identified the respective Form Validators that may reject null/empty descriptions.
|
15:06:59
|
<andrea__> Modify code in above Java classes
|
15:07:01
|
<andrea__> Monday
|
15:07:03
|
<andrea__> TRUNK-3474
|
15:07:05
|
<andrea__> Modify Validators/Form Validators that may reject null/empty descriptions.
|
15:07:07
|
<andrea__> Modify remaining Hiberenate cfg.xml file - change not null constraint
|
15:07:10
|
<andrea__> Add changesets for remainingf tables to Liquibase changeset
|
15:07:11
|
<andrea__> Put OpenMRS ect on new computer
|
15:07:15
|
<andrea__> No blockers
|
15:07:38
|
<cpower> ok, no blockers, no discussion points seen
|
15:07:45
|
<cpower> !scrum off
|
15:07:46
|
<OpenMRSBot> cpower: Error: "scrum" is not a valid command.
|
15:07:51
|
<cpower> !scrumof
|
15:07:51
|
<OpenMRSBot> cpower: Error: "scrumof" is not a valid command.
|
15:07:56
|
<cpower> !scrumoff
|
15:07:56
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:08:07
|
<cpower> eventually I'll get it right
|
15:08:19
|
<rafa> cpower: yeah, keep practice ;)
|
15:10:04
|
*** suranga__ has quit IRC
|
15:13:09
|
*** kjoseph has joined #openmrs
|
15:17:13
|
*** cpower has quit IRC
|
15:19:06
|
*** nribeka has quit IRC
|
15:19:44
|
*** nribeka has joined #openmrs
|
15:19:45
|
*** ChanServ sets mode: +v nribeka
|
15:45:30
|
*** kjoseph has quit IRC
|
15:49:15
|
*** nribeka has quit IRC
|
16:01:43
|
*** epon has joined #openmrs
|
16:02:32
|
*** epon has quit IRC
|
16:08:12
|
*** applecool has joined #openmrs
|
16:08:12
|
*** ChanServ sets mode: +v applecool
|
16:21:25
|
*** rafa has quit IRC
|
16:28:01
|
*** afiles has joined #openmrs
|
16:32:46
|
*** djazayeri has joined #openmrs
|
16:32:46
|
*** ChanServ sets mode: +o djazayeri
|
16:35:28
|
*** nribeka has joined #openmrs
|
16:35:28
|
*** ChanServ sets mode: +v nribeka
|
16:59:36
|
*** andrea__ has quit IRC
|
17:07:27
|
*** jkeiper has joined #openmrs
|
17:07:27
|
*** ChanServ sets mode: +v jkeiper
|
17:17:59
|
<jkeiper> hi
|
17:27:15
|
*** kavuri has joined #openmrs
|
17:42:30
|
*** suranga has joined #openmrs
|
17:42:30
|
*** ChanServ sets mode: +v suranga
|
17:50:20
|
*** rfriedman has joined #openmrs
|
17:51:57
|
* rfriedman hopes his connection is working
|
17:52:22
|
<rfriedman> djazayeri: hi darius, you really there?
|
17:52:31
|
<djazayeri> rfriedman: yes, but on a call
|
17:53:42
|
<rfriedman> djazayeri: tks, will get back to you, god willing and the connection stays up
|
17:56:40
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Address Hierarchy 2.2.6 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=addresshierarchy&version=&2.2.6>
|
18:12:18
|
*** wluyima has left #openmrs
|
18:12:42
|
*** wluyima has joined #openmrs
|
18:22:14
|
*** robbyoconnor has joined #openmrs
|
18:22:14
|
*** ChanServ sets mode: +v robbyoconnor
|
18:34:33
|
*** kjoseph has joined #openmrs
|
18:36:25
|
<rfriedman> djazayeri: howÅ it coming?
|
18:38:56
|
<rfriedman> djazayeri: me voy
|
18:39:09
|
*** rfriedman has quit IRC
|
18:54:51
|
*** dkayiwa has joined #openmrs
|
19:07:28
|
<kavuri> dkayiwa: about the patch for obs groups creation in webservices rest, guess it is fine to commit the change?
|
19:08:16
|
<dkayiwa> kavuri: to me yes. :) Need just one more reviewer
|
19:08:31
|
<dkayiwa> kavuri: possibly djazayeri :)
|
19:08:46
|
<kavuri> dkayiwa: ok, djazayeri ^^
|
19:10:18
|
*** djazayeri has quit IRC
|
19:10:49
|
*** djazayeri has joined #openmrs
|
19:10:49
|
*** ChanServ sets mode: +o djazayeri
|
19:13:07
|
<dkayiwa> hi suranga
|
19:13:24
|
<suranga> howdy dkayiwa :-) :-)
|
19:13:34
|
<dkayiwa> kavuri: do you badly need the commit? :)
|
19:13:41
|
<kavuri> dkayiwa: yes :)
|
19:13:45
|
<dkayiwa> suranga: did you get the fix?
|
19:13:53
|
<dkayiwa> kavuri: ok i can apply and commit it :)
|
19:14:11
|
<suranga> dkayiwa, im afraid not, I keep runing around in circles :(
|
19:14:18
|
<kavuri> dkayiwa: thanks. But if the process requires one more reviewers approval, better go that way?
|
19:14:30
|
<dkayiwa> kavuri: ok will wait for djazayeri :)
|
19:14:49
|
<suranga> dkayiwa, I was hoping wether you could point me in the right direction, becoz I have no idea where to proceed from here :-(
|
19:14:57
|
*** djazayeri1 has joined #openmrs
|
19:14:59
|
*** robbyoconnor has quit IRC
|
19:15:06
|
<dkayiwa> suranga: ok let me look at it again now :)
|
19:16:06
|
*** djazayeri has quit IRC
|
19:16:45
|
<suranga> dkayiwa, i would really appreciate any pointers you may provide :-)
|
19:28:08
|
*** sgithens has quit IRC
|
19:36:33
|
<dkayiwa> suranga: did you create this module just recently?
|
19:36:55
|
<suranga> dkayiwa, its been about 7 -8 months... mm.. is anything wrong ?
|
19:37:04
|
<dkayiwa> suranga: ok
|
19:37:55
|
<suranga> dkayiwa, i keep suspecting that my spring context file is wrong, especilly as this is geared to look at REStful calls. But so far, no results :-(
|
19:41:06
|
<dkayiwa> suranga: your .omod is not built correctly
|
19:41:14
|
<suranga> dkayiwa, :-(
|
19:41:39
|
<suranga> dkayiwa, I built it using the maven module creator thingy. what seems to be wrong ?
|
19:42:33
|
<dkayiwa> suranga: the generated config.xml has a wrong replacement for @MODULE_ID@
|
19:43:11
|
<suranga> mm....
|
19:43:18
|
*** sgithens has joined #openmrs
|
19:43:24
|
* suranga looks worried...
|
19:43:40
|
*** mccallumg has joined #openmrs
|
19:43:40
|
*** ChanServ sets mode: +v mccallumg
|
19:44:22
|
<dkayiwa> suranga: you do not have to worry. i know a workaround.
|
19:44:32
|
<dkayiwa> suranga: but just anxious to know what the real cause is
|
19:44:44
|
* suranga thinks dkayiwa knows eveything :)
|
19:45:03
|
<dkayiwa> suranga: easy workaround is create the module again using the maven archetype module and then just copy over your files
|
19:45:13
|
<dkayiwa> suranga: but looking into the exact cause of this :)
|
19:45:13
|
<suranga> dkayiwa, a while back, I changed the entire package strucutre, and renamed the module. I suspect that something went wrong at that time..
|
19:45:26
|
<dkayiwa> suranga: maybe
|
19:46:00
|
<suranga> dkayiwa, what is the ModuleID being set as ? and how did you discover this ?
|
19:46:24
|
<dkayiwa> suranga: i just expanded the .omod
|
19:47:48
|
*** robbyoconnor has joined #openmrs
|
19:47:49
|
*** ChanServ sets mode: +v robbyoconnor
|
19:47:51
|
<suranga> dkayiwa, is it the part that says 'persisted container[***] under the omod file ?
|
19:48:20
|
<dkayiwa> suranga: cant tell the cause so far :)
|
19:49:11
|
<suranga> dkayiwa, when you expand the .omod, what fault do yousee ? I'm asking because I want to make sure I dont do this a second time... :-)
|
19:49:36
|
<dkayiwa> suranga: <package>org.openmrs.module.RHEASHRadapter-omod</package>
|
19:50:56
|
*** mccallumg has quit IRC
|
19:51:31
|
<suranga> dkayiwa, I see. ... what should be the correct value for this field ? :-)
|
19:52:21
|
<kavuri> dkayiwa: I started to look into !ticket RESTWS-306
|
19:52:26
|
<kavuri> !ticket RESTWS-306
|
19:52:28
|
<OpenMRSBot> kavuri: [#RESTWS-306] POST to /obs with "value" in the beginning throws error - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-306
|
19:52:42
|
<suranga> dkayiwa, it should be just <package>org.openmrs.module.RHEASHRadapter<package> isnt it ?
|
19:53:00
|
<kavuri> dkayiwa: during debugging, found that the problem could be because of the concept object not being created
|
19:53:54
|
<dkayiwa> suranga: <package>org.openmrs.module.rheashradapter</package>
|
19:54:04
|
<kavuri> dkayiwa: the exception is thrown in method ObsResource::setValue
|
19:54:12
|
<dkayiwa> kavuri: ok
|
19:54:14
|
<kavuri> dkayiwa: and at line RESTWS-306
|
19:54:16
|
<suranga> dkayiwa, thank you so much, this was a major help :-)
|
19:54:27
|
<kavuri> dkayiwa: and at line "obs.getConcept().getDatatype().isCoded()"
|
19:54:28
|
<suranga> dkayiwa, but umm...are you sure that this is the cause of the problem ?
|
19:54:32
|
<dkayiwa> suranga: but fixing that alone does not make it work :)
|
19:54:38
|
<kavuri> dkayiwa: 322 to be precise
|
19:54:49
|
<dkayiwa> suranga: so am just diagnosing and curing various things
|
19:54:57
|
<dkayiwa> kavuri: ok
|
19:55:13
|
<dkayiwa> kavuri: do you wanna claim the ticket?
|
19:55:25
|
<kavuri> dkayiwa: already did
|
19:55:38
|
<dkayiwa> kavuri: there is a claim button if you are logged on
|
19:55:46
|
<suranga> dkayiwa, ooh, I see
|
19:55:53
|
<kavuri> dkayiwa: claimed it
|
19:56:06
|
<suranga> dkayiwa, no worries, let me see what I can do. maybe this will unclog the problem :-)
|
19:56:18
|
<dkayiwa> suranga: no way :)
|
19:56:29
|
<suranga> dkayiwa, :-(
|
19:56:33
|
<dkayiwa> kavuri: are you refering to this? https://tickets.openmrs.org/browse/RESTWS-306
|
19:56:44
|
<kavuri> dkayiwa: yes
|
19:56:55
|
<suranga> dkayiwa, but um... other than creating the module afresh, isnt there an easier way to re-set the package tag ?
|
19:57:11
|
<dkayiwa> suranga: if that was the fix, would be so
|
20:00:08
|
<suranga> dkayiwa, I understand.I will work on this. thank you so much for helping me with it :-)
|
20:00:22
|
<dkayiwa> suranga: so what are you gonna do?
|
20:00:51
|
<suranga> dkayiwa, first, I guess I will try re-creating the module , and check that the <package> tag is correct
|
20:00:59
|
<suranga> dkayiwa, after that... um.....
|
20:01:05
|
* suranga scratches head...
|
20:01:19
|
<dkayiwa> suranga: recreating using the maven archetype module instead of the basic module
|
20:01:44
|
<dkayiwa> kavuri: so do you wanna submit a patch for that ticket?
|
20:01:55
|
<kavuri> dkayiwa: Ben seems to have done some fix to this bug, but it does not fix the problem
|
20:02:17
|
<dkayiwa> kavuri: ok
|
20:03:53
|
<dkayiwa> kavuri: also the capitalizing of you module looks suspicious :)
|
20:04:10
|
<kavuri> dkayiwa: ?
|
20:04:15
|
<dkayiwa> kavuri: sorry that was for suranga :)
|
20:04:30
|
<dkayiwa> suranga: why dont you simply call the module name: rheashradapter
|
20:04:41
|
<suranga> dkayiwa, the capitalization is a ghost which has returned to haunt me :-(
|
20:04:46
|
<dkayiwa> suranga: your capitalizing looks suspicious since i have never seen it in any module
|
20:05:05
|
<dkayiwa> suranga: would you lose any thing if you simply used something like: rheashradapter ?
|
20:05:21
|
<suranga> dkayiwa, you are right. that needs to get removed... no, you are right :)
|
20:05:31
|
<dkayiwa> ok
|
20:10:34
|
<suranga> dkayiwa, thank you again, Ill be going offline now to work on this for some more :-)
|
20:10:43
|
<dkayiwa> suranga: ok
|
20:10:46
|
<dkayiwa> :)
|
20:13:50
|
*** kjoseph has quit IRC
|
20:28:30
|
*** djazayeri1 is now known as djazayeri
|
20:35:47
|
*** rfriedman has joined #openmrs
|
20:36:06
|
*** kavuri has quit IRC
|
20:36:16
|
<rfriedman> djazayeri, hey darius
|
20:43:47
|
*** applecool has left #openmrs
|
20:45:36
|
<djazayeri> hi rfriedman
|
20:48:31
|
<rfriedman> hi darius
|
20:48:50
|
<djazayeri> rfriedman: I've been taking a semi-holiday, but I'm online now. what's up?
|
20:48:59
|
<rfriedman> darius, did you ever try to use REST and Pentaho together
|
20:49:17
|
<djazayeri> rfriedman: Ben, Mike, and I put together the reportingrest module.
|
20:49:29
|
<rfriedman> aha
|
20:49:41
|
<djazayeri> rfriedman: and I did some work to expose the reporting rest API in pentaho via a PDI plugin.
|
20:50:07
|
<rfriedman> people I am working with here want to use Pentaho for ETL
|
20:50:33
|
<rfriedman> but I am thinking REST would be good to overcome issues with concept names
|
20:50:49
|
<djazayeri> rfriedman: where are you, btw?
|
20:51:09
|
<rfriedman> Dominican Republic, probably we can visit over the weekends in Jan :)
|
20:51:42
|
<djazayeri> rfriedman: I believe that the correct way forwards with Pentaho + ETL, is using reportingrest + that PDI plugin, but they're both alpha quality at best.
|
20:52:07
|
<djazayeri> rfriedman: I'm definitely interested to see them move forwards, and can contribute opinions, but don't have any time to move them forwards...
|
20:52:19
|
<rfriedman> i understand
|
20:52:38
|
<rfriedman> there are several reports on the Pentaho list of people trying to use REST unsuccessfully
|
20:52:55
|
<rfriedman> we can duplicate these unsuccesses :(
|
20:52:57
|
<djazayeri> rfriedman: trying to use pentaho + rest in general? (not openmrs specifically?)
|
20:53:26
|
<rfriedman> most people are looking at CouchDB or some other product
|
20:53:41
|
<rfriedman> some big data product, begins with M
|
20:54:04
|
<djazayeri> rfriedman:
|
20:54:05
|
<djazayeri> https://groups.google.com/a/openmrs.org/forum/?fromgroups=#!searchin/dev/pentaho$20pdi/dev/-d_FfX7sDi4/aElZyMElfEwJ
|
20:54:09
|
<OpenMRSBot> <http://ln-s.net/+8DA> (at groups.google.com)
|
20:54:25
|
<rfriedman> ok will take a look
|
20:54:34
|
<rfriedman> do we have ongoing relations with anyone at pentaho?
|
20:54:50
|
<djazayeri> rfriedman: presumably the dev on Feb 22/23 has more about this.
|
20:54:56
|
<djazayeri> rfriedman: e.g. a demo
|
20:55:11
|
<rfriedman> yes, we've looked at it
|
20:55:27
|
<rfriedman> will look again
|
20:56:14
|
<djazayeri> rfriedman: we were working with Gretchen Moran. Last I know she was working with Andy to put together concrete ETL for Columbia/MVP.
|
20:56:24
|
<djazayeri> rfriedman: I don't know if that's ongoing or not, but you could ask him.
|
20:56:54
|
<rfriedman> ok, will do
|
20:57:17
|
<rfriedman> tks much ... glad to hear you can take a semi-holiday
|
20:57:54
|
*** suranga has quit IRC
|
21:14:07
|
*** jkeiper has quit IRC
|
21:16:17
|
*** sgithens has quit IRC
|
22:05:48
|
*** wluyima has quit IRC
|
22:14:06
|
*** nribeka has quit IRC
|
22:32:27
|
*** nribeka has joined #openmrs
|
22:32:27
|
*** ChanServ sets mode: +v nribeka
|
22:33:11
|
*** dkayiwa has quit IRC
|
22:40:58
|
*** robbyoconnor has quit IRC
|
23:20:17
|
*** sgithens has joined #openmrs
|
23:28:29
|
*** andrea has joined #openmrs
|
23:28:53
|
*** andrea is now known as Guest17026
|
23:29:49
|
*** Guest17026 is now known as andreap
|
23:46:22
|
<andreap> djazayeri, looks like all went well with liquibase changeset
|