00:30:39
|
*** wluyima has quit IRC
|
00:32:30
|
*** wluyima has joined #openmrs
|
00:33:10
|
*** wluyima has joined #openmrs
|
00:44:41
|
*** wyclif_ has joined #openmrs
|
00:44:41
|
*** wluyima has quit IRC
|
01:04:32
|
*** wyclif_ has quit IRC
|
02:36:19
|
*** jkeiper has joined #openmrs
|
02:36:19
|
*** ChanServ sets mode: +v jkeiper
|
03:41:29
|
*** djazayeri has quit IRC
|
03:57:54
|
*** jkeiper has quit IRC
|
04:33:11
|
*** kishoreyekkanti has joined #openmrs
|
04:33:39
|
*** kishoreyekkanti has joined #openmrs
|
05:34:22
|
*** kishoreyekkanti_ has joined #openmrs
|
05:37:34
|
*** kishoreyekkanti has quit IRC
|
05:37:34
|
*** kishoreyekkanti_ is now known as kishoreyekkanti
|
05:47:54
|
*** kishoreyekkanti has quit IRC
|
05:48:15
|
*** kishoreyekkanti has joined #openmrs
|
05:53:36
|
*** robbyoconnor has joined #openmrs
|
05:53:36
|
*** ChanServ sets mode: +v robbyoconnor
|
05:59:15
|
*** kavuri has joined #openmrs
|
06:40:50
|
*** shortend has left #openmrs
|
09:08:26
|
<kavuri> Hi, I need some inputs to figure out a problem related to saving observations and observation groups. Anyone out there to help?
|
09:09:15
|
<kavuri> Basically whenever an observation group is created, the child observations do not have the id of the obs_group set in them
|
09:09:32
|
<kavuri> I am trying to figure out the file that handles this part
|
10:04:19
|
*** fishandwalk has joined #openmrs
|
10:39:27
|
*** yony258 has joined #openmrs
|
10:39:50
|
*** yony258 is now known as yonatan
|
10:40:24
|
*** yonatan is now known as yonatanGr
|
10:49:44
|
*** AdamLauz has joined #openmrs
|
10:53:59
|
*** yonatanGr has quit IRC
|
10:56:47
|
*** yony258 has joined #openmrs
|
10:59:38
|
*** yonatanGr has joined #openmrs
|
11:02:05
|
*** rafa has joined #openmrs
|
11:02:05
|
*** ChanServ sets mode: +v rafa
|
11:02:57
|
*** yony258 has quit IRC
|
11:14:29
|
*** AdamLauz has quit IRC
|
11:14:56
|
*** AdamLauz has joined #openmrs
|
11:24:59
|
*** dkayiwa has joined #openmrs
|
11:27:32
|
*** AdamLauz has quit IRC
|
11:29:12
|
*** yonatanGr has quit IRC
|
11:30:41
|
*** yony258 has joined #openmrs
|
11:34:37
|
*** sthaiya has joined #openmrs
|
11:35:31
|
<yony258> dkayiwa: Hi
|
11:37:57
|
*** harshadura has joined #openmrs
|
11:38:04
|
<rafa> dkayiwa: hi
|
11:39:40
|
<dkayiwa> rafa: hi
|
11:39:51
|
<rafa> dkayiwa: wanted to ask you about https://tickets.openmrs.org/browse/TRUNK-2917
|
11:39:54
|
<dkayiwa> yony258: hi
|
11:40:12
|
<rafa> dkayiwa: looking at the Deamon class in master
|
11:40:32
|
<rafa> dkayiwa: it has public static Thread runInDaemonThread(final Runnable runnable) {
|
11:40:48
|
<dkayiwa> rafa: ok
|
11:40:54
|
<rafa> dkayiwa: which apparently was added as part of this ticket (at least commit message says so)
|
11:41:06
|
<rafa> dkayiwa: it also says @since 1.9
|
11:41:07
|
<dkayiwa> rafa: ok
|
11:41:17
|
<dkayiwa> rafa: ok
|
11:41:20
|
<rafa> dkayiwa: but when I look at 1.9 I don't see it
|
11:41:51
|
<rafa> dkayiwa: is this method some left over from your work and really should be deleted in master
|
11:42:00
|
<rafa> dkayiwa: or you forgot to back port it?
|
11:42:17
|
<dkayiwa> rafa: checking now....
|
11:42:36
|
<rafa> dkayiwa: it allows to execute any code with elevated privileges in a deamon thread
|
11:43:24
|
<yony258> dkayiwa: hi, how are you?. We talked yesterday about getting some help with creating forms
|
11:43:35
|
<dkayiwa> yony258: a moment.
|
11:45:14
|
*** AdamLauz has joined #openmrs
|
11:49:30
|
<rafa> dkayiwa: we may actually need this method for https://tickets.openmrs.org/browse/TRUNK-3781 :)
|
11:49:39
|
<rafa> dkayiwa: just wondering what's the story behind it
|
11:49:59
|
<dkayiwa> rafa: i do not seem to remember. but still looking at it :)
|
11:50:06
|
<rafa> dkayiwa: cool
|
11:54:36
|
<dkayiwa> rafa: looks like this was not backported to 1.9 https://source.openmrs.org/changelog/OpenMRS/?cs=24745
|
11:55:23
|
<rafa> dkayiwa: yeah, the question is if it should have been back ported? :)
|
11:55:37
|
<dkayiwa> rafa: i think i just forgot to back port it :)
|
11:55:57
|
<rafa> dkayiwa: ok no worries
|
11:56:03
|
<dkayiwa> rafa: ok
|
11:56:18
|
<rafa> dkayiwa: so TRUNK-2917 actually needs that code?
|
11:56:51
|
<dkayiwa> !ticket TRUNK-2917
|
11:56:53
|
<OpenMRSBot> dkayiwa: [#TRUNK-2917] AuditableInterceptor throws an NPE at startup, preventing OpenMRS from running - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2917
|
11:57:24
|
<dkayiwa> rafa: yes
|
11:57:31
|
<rafa> dkayiwa: ok
|
11:57:34
|
<rafa> dkayiwa: thanks
|
11:57:53
|
<dkayiwa> rafa: you are welcome
|
11:58:09
|
<dkayiwa> yony258: AdamLauz have you guys started creating a new module?
|
11:58:14
|
<dkayiwa> yony258: using this? https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype
|
11:58:15
|
<OpenMRSBot> <http://ln-s.net/9$wo> (at wiki.openmrs.org)
|
11:58:56
|
<yony258> dkayiwa: No we didn't, though I dont think we got enough time since we need to meet Tobin in 1 hour, so maybe we'll reschedule?
|
11:58:59
|
<dkayiwa> yony258: AdamLauz after creating a new module, i can start from there to guide you on creating a form that saves and loads data from the database
|
11:59:14
|
<dkayiwa> yony258: no problem. am always here :)
|
11:59:32
|
<yony258> dkayiwa: So lets do that and than meet, when can you meet again?
|
11:59:46
|
<dkayiwa> yony258: anytime :)
|
12:00:18
|
<yony258> AdamLauz: What time and date is good for you?
|
12:00:34
|
<dkayiwa> yony258: all of them :)
|
12:01:14
|
<yony258> AdamLauz: I prefer Sunday but maybe be able to meet at Monday evening
|
12:01:38
|
<dkayiwa> i forgot to say that should be Monday - Friday :)
|
12:02:57
|
*** kavuri has quit IRC
|
12:04:44
|
<AdamLauz> Monday between 13:00am-17:00am is fine with me
|
12:05:16
|
<dkayiwa> AdamLauz: me too
|
12:06:15
|
<yony258> dkayiwa: So lets schedule this to Monday at 2pm your time (which is 1pm our time) ?
|
12:07:14
|
<yony258> AdamLauz: and lets decide to complete this (https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype) prior to the meeting.
|
12:07:15
|
<OpenMRSBot> <http://ln-s.net/9$wo> (at wiki.openmrs.org)
|
12:07:31
|
<dkayiwa> yony258: sure
|
12:09:38
|
<yony258> dkayiwa: ok great, so cya at 2pm (your time). Thank you.
|
12:10:17
|
<dkayiwa> yony258: see ya!!!
|
12:10:22
|
*** yony258 has quit IRC
|
12:10:25
|
<AdamLauz> dkayiwa: thank you ... see you next week
|
12:10:32
|
<dkayiwa> AdamLauz: sure!!!
|
12:10:48
|
*** AdamLauz has quit IRC
|
12:11:11
|
*** sthaiya has quit IRC
|
12:15:16
|
*** kavuri has joined #openmrs
|
12:15:46
|
<kavuri> dkayiwa: hi
|
12:15:55
|
<dkayiwa> kavuri: hi
|
12:16:49
|
<kavuri> dkayiwa: there are two bugs I am trying to fix. 1) whenever I try to create an observation with groups, the parent observation is created and so are the children. But in the database table, I see that the obs_group_id is null for all the children
|
12:17:04
|
<kavuri> dkayiwa: I looked at ObsDAO, ObsServiceImpl
|
12:17:13
|
<kavuri> dkayiwa: but don't see any hints of this issue
|
12:17:33
|
<kavuri> dkayiwa: where is the place you think might be the most probable place where these observations are created?
|
12:19:37
|
<dkayiwa> kavuri: which ticket is that?
|
12:20:16
|
<kavuri> dkayiwa: !ticket RESTWS-302
|
12:20:24
|
<kavuri> !ticket RESTWS-302
|
12:20:26
|
<OpenMRSBot> kavuri: [#RESTWS-302] Creating observation groups feature does not work - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-302
|
12:20:44
|
<kavuri> dkayiwa: I would be off for sometime, but will be back in couple of hrs...
|
12:20:58
|
<kavuri> dkayiwa: should I send an email about this?
|
12:21:00
|
<dkayiwa> kavuri: no problem. just tell me when you are back :)
|
12:21:06
|
<kavuri> dkayiwa: greath..thanks
|
12:25:50
|
*** kavuri has quit IRC
|
12:47:06
|
*** dkayiwa has quit IRC
|
13:04:49
|
*** dkayiwa has joined #openmrs
|
13:08:47
|
*** robbyoconnor has quit IRC
|
13:28:14
|
*** dkayiwa has quit IRC
|
13:33:06
|
*** jkeiper has joined #openmrs
|
13:33:06
|
*** ChanServ sets mode: +v jkeiper
|
13:36:38
|
*** suranga has joined #openmrs
|
13:36:38
|
*** ChanServ sets mode: +v suranga
|
13:46:52
|
*** akshay has joined #openmrs
|
13:47:40
|
<akshay> hey i wanna join this org as student volunteer,,,can some1 help me!!!
|
13:53:58
|
<rafa> akshay: welcome
|
13:54:19
|
<rafa> akshay: do you code?
|
13:54:30
|
<akshay> yup
|
13:55:06
|
<rafa> akshay: https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer
|
13:55:07
|
<OpenMRSBot> <http://ln-s.net/8bkO> (at wiki.openmrs.org)
|
13:55:32
|
<akshay> im intrested in designing web crawlers!!
|
13:55:54
|
<rafa> akshay: we don't do web crawlers :)
|
13:56:23
|
<rafa> akshay: but I bet you can find some interesting tickets in OpenMRS to work on
|
13:56:48
|
<rafa> akshay: follow instructions from the link I've just pasted
|
13:57:15
|
<akshay> thanks @raga :)
|
13:57:22
|
<akshay> * rafa
|
13:58:03
|
<rafa> akshay: np
|
13:59:54
|
*** fishandwalk has quit IRC
|
14:01:26
|
*** wluyima has joined #openmrs
|
14:04:34
|
*** akshay has quit IRC
|
14:05:14
|
*** jkeiper has quit IRC
|
14:08:23
|
*** nribeka has quit IRC
|
14:17:52
|
*** downey has joined #openmrs
|
14:17:52
|
*** ChanServ sets mode: +o downey
|
14:17:52
|
*** OpenMRSBot sets mode: +o downey
|
14:21:55
|
*** dkayiwa has joined #openmrs
|
14:35:37
|
*** kjoseph has joined #openmrs
|
14:36:09
|
<kjoseph> dkayiwa: hi
|
14:36:17
|
<dkayiwa>
|
14:36:17
|
<dkayiwa> kjoseph hi
|
14:38:30
|
<dkayiwa> kjoseph: how is it going
|
14:39:07
|
<kjoseph> dkayiwa: please am requesting for your assistance, i idont really know know what is wrong, am now getting a build failure when i run openmrs from eclipse, What could be the problem please
|
14:39:50
|
<dkayiwa> kjoseph: which command are u running
|
14:40:16
|
<kjoseph> dkayiwa: getty: run
|
14:40:53
|
<dkayiwa> kjoseph: can u pastebin the error
|
14:40:53
|
<kjoseph> dkayiwa: i mean jetty:run
|
14:48:13
|
*** jkeiper has joined #openmrs
|
14:48:13
|
*** ChanServ sets mode: +v jkeiper
|
14:51:32
|
*** Mkop has quit IRC
|
14:51:36
|
<kjoseph> dkayiwa: the link is: http://pastebin.com/L0PnvsGx
|
14:51:51
|
<dkayiwa> kjoseph: ok
|
14:52:41
|
<dkayiwa> kjoseph: can you look at this https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype
|
14:52:42
|
<OpenMRSBot> <http://ln-s.net/9$wo> (at wiki.openmrs.org)
|
14:54:34
|
<kjoseph> dkayiwa: am looking at the link now
|
14:54:50
|
<dkayiwa> kjoseph: ok tell me when yo done
|
14:55:05
|
*** mey has joined #openmrs
|
14:55:11
|
<downey> Hi mey and welcome to the #openmrs IRC channel.
|
14:55:40
|
<kjoseph> dkayiwa: dkayiwa: am done
|
14:55:59
|
<dkayiwa> kjoseph: can you download that module and use it to create a new module?
|
14:56:31
|
*** mey has left #openmrs
|
15:00:07
|
<kjoseph> dkayiwa: am i to run: mvn module-wizard:generate in the openmrs-core folder or in the newly created folder
|
15:01:12
|
<dkayiwa> kjoseph: no
|
15:01:41
|
<dkayiwa> kjoseph: run it from a new folder where you want your module to be
|
15:02:09
|
<kjoseph> dkayiwa: okay
|
15:02:58
|
*** djazayeri has joined #openmrs
|
15:02:58
|
*** ChanServ sets mode: +o djazayeri
|
15:03:57
|
*** wluyima has quit IRC
|
15:07:02
|
*** nribeka has joined #openmrs
|
15:07:02
|
*** ChanServ sets mode: +v nribeka
|
15:09:08
|
*** sidd has joined #openmrs
|
15:09:21
|
<downey> Hi sidd and welcome to the #openmrs IRC channel.
|
15:10:52
|
<kjoseph> dkayiwa: downloading plugins, Is that the problem why am getting the build failure?
|
15:11:27
|
<dkayiwa> kjoseph: build failure was due to network connection failure
|
15:16:44
|
<kjoseph> dkayiwa: completed downloading,
|
15:17:00
|
<dkayiwa> kjoseph: so run it to create you new module
|
15:19:07
|
<kjoseph> dkayiwa: i run in the same folder, check i have a build failure in cmd where i have just run it recently
|
15:19:24
|
<dkayiwa> kjoseph: from which folder are you running it?
|
15:19:25
|
*** wluyima has joined #openmrs
|
15:20:15
|
<kjoseph> dkayiwa: a newly created folder
|
15:20:50
|
<dkayiwa> kjoseph: and what command did you run?
|
15:21:02
|
<dkayiwa> kjoseph: paste it all here including the parameters
|
15:21:16
|
<kjoseph> dkayiwa: mvn module-wizard:generate
|
15:21:40
|
<dkayiwa> kjoseph: is that all?
|
15:22:07
|
<kjoseph> dkayiwa: so far that is all i had run
|
15:22:40
|
<dkayiwa> kjoseph: pastebin what you get
|
15:22:57
|
*** sidd has quit IRC
|
15:25:55
|
<kjoseph> dkayiwa: pasted at http://pastebin.com/Ee7wCw2i
|
15:29:28
|
*** afiles has joined #openmrs
|
15:29:43
|
<downey> Hi afiles and welcome to the #openmrs IRC channel.
|
15:34:58
|
<afiles> hi downey!
|
15:36:39
|
<kjoseph> dkayiwa: okay i have now successfully run openmrs from eclipse,
|
15:37:35
|
<dkayiwa> kjoseph: ok good
|
15:38:24
|
<dkayiwa> kjoseph: can you also run again the wizard generate module
|
15:38:43
|
<kjoseph> dkayiwa: okay
|
15:43:57
|
*** kishoreyekkanti has quit IRC
|
15:48:05
|
<kjoseph> dkayiwa: the failure is persistent, still getting a BUILD FAILURE
|
15:48:34
|
<dkayiwa> kjoseph: after running which command
|
15:49:07
|
<kjoseph> dkayiwa: mvn module-wizard:generate
|
15:49:44
|
<dkayiwa> kjoseph: can you pastebin the current error?
|
15:52:29
|
<kjoseph> dkayiwa: at: http://pastebin.com/MQ5PnD80
|
16:00:03
|
*** kavuri has joined #openmrs
|
16:00:54
|
<dkayiwa> kjoseph: can you try again
|
16:03:18
|
<kjoseph> dkayiwa: again, a BUILD FAILURE
|
16:03:38
|
<dkayiwa> kjoseph: is it the same exact error
|
16:04:08
|
<dkayiwa> kjoseph: did you do all on this page? https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype
|
16:04:09
|
<OpenMRSBot> <http://ln-s.net/9$wo> (at wiki.openmrs.org)
|
16:04:20
|
*** djazayeri has quit IRC
|
16:05:03
|
<dkayiwa> kjoseph: did you do the steps you are supposed to do before running that command as per that wiki page?
|
16:06:26
|
*** djazayeri has joined #openmrs
|
16:06:26
|
*** ChanServ sets mode: +o djazayeri
|
16:06:46
|
<kjoseph> dkayiwa: no please,
|
16:07:18
|
<dkayiwa> kjoseph: can you do the as per the insructions
|
16:11:40
|
<kavuri> dkayiwa: back to my earlier question, about looking for the place that creates observations and groups
|
16:12:19
|
<dkayiwa> kavuri: how did you save them to the database?
|
16:12:20
|
*** kjoseph has quit IRC
|
16:12:34
|
<kavuri> dkayiwa: I used webservices-REST api
|
16:12:57
|
<dkayiwa> kavuri: which client did you use?
|
16:13:09
|
<kavuri> dkayiwa: ObsResource calls saveObs form ObsService which inturn invokes ObsDAO
|
16:13:12
|
<kavuri> dkayiwa: curl
|
16:13:49
|
<dkayiwa> kavuri: is the obs group saving method the one you have just written?
|
16:14:03
|
<kavuri> dkayiwa: the one that already exists
|
16:14:10
|
<kavuri> dkayiwa: btw. this is openmrs 1.9.2
|
16:14:20
|
<kavuri> dkayiwa: and webservice-REST from trunk (latest)
|
16:16:21
|
<dkayiwa> kavuri: does the obs_group_id get set if you used the openmrs ui to save an obs without using the REST WS?
|
16:17:08
|
<kavuri> dkayiwa: there is no UI (AFAIK) to create obs groups from UI
|
16:17:23
|
<kavuri> dkayiwa: I might be missing something, but can you pls. point me to that
|
16:18:11
|
<dkayiwa> kavuri: if the obs_group_id of the child is not set, am smelling something like a bug
|
16:19:22
|
<kavuri> dkayiwa: yes, its a bug. Am trying to fix it..
|
16:19:43
|
<kavuri> dkayiwa: but not sure if I am looking at the right place
|
16:19:53
|
<dkayiwa> kavuri: oh i see
|
16:20:37
|
<kavuri> dkayiwa: can check with djazayeri
|
16:20:44
|
<dkayiwa> kavuri: ok
|
16:21:07
|
<kavuri> djazayeri: about creation of obs groups using webservice REST API, the basic webservices seems to be able to create the obs group
|
16:21:35
|
<kavuri> djazayeri: but there are 2 bugs, 1) the obs_group_id for the child obs is not set to the parent
|
16:22:33
|
<kavuri> 2) when I retrieve the obs parent and if there is only one child, no children are returned in the groupMembers, but if there are more than 1 children, then they are returned
|
16:22:59
|
<kavuri> djazayeri: I was able to check the 2'nd case by manually setting the obs_group_id in the database
|
16:23:44
|
<kavuri> djazayeri: I am trying to fix these problems but am not sure if HibernateDAO is the correct place for these
|
16:39:34
|
*** jkeiper has quit IRC
|
16:40:52
|
*** wluyima has quit IRC
|
16:44:12
|
*** harshadura has quit IRC
|
16:52:06
|
*** rafa has quit IRC
|
16:52:38
|
*** jkeiper has joined #openmrs
|
16:52:38
|
*** ChanServ sets mode: +v jkeiper
|
16:54:28
|
*** wluyima has joined #openmrs
|
16:57:59
|
<kavuri> jkeiper: maybe you can help..
|
16:59:11
|
<kavuri> jkeiper: trying the fix the creation of obs groups, but I see that with webservices REST call, the obs_group_id is not set
|
16:59:16
|
<kavuri> for the observations
|
16:59:34
|
<jkeiper> kavuri, sorry i am about to walk out the door
|
16:59:47
|
<jkeiper> kavuri, let me read back a sec
|
16:59:59
|
<kavuri> jkeiper: sure
|
17:00:27
|
<jkeiper> kavuri, the behind-the-scenes API work is just creating the parent obs and adding children to it, then relying on the API to create it. right?
|
17:00:46
|
<jkeiper> kavuri, gotta run
|
17:00:47
|
<jkeiper> cya
|
17:00:47
|
<kavuri> jkeiper: yes, thats right
|
17:00:49
|
<jkeiper> bbiab
|
17:05:13
|
<wluyima> hi djazayeri
|
17:14:33
|
<djazayeri> hey wluyima, in a meeting, but what's up?
|
17:21:47
|
*** dkayiwa has quit IRC
|
17:28:05
|
*** dkayiwa has joined #openmrs
|
17:40:11
|
*** dkayiwa has quit IRC
|
17:40:44
|
*** dkayiwa has joined #openmrs
|
18:05:52
|
*** kjoseph has joined #openmrs
|
18:17:27
|
<kjoseph> dkayiwa: sorry for the delay, please am now ready to continue, am not sure yet on what to do with the step of copying openmrs profile into the maven setting.xml, am having that xml file open now in notepad, should i jusut copy and paste Vista/Window7:C:\$USERS$\.m2 in the xml file
|
18:18:49
|
<dkayiwa> kjoseph: replace $USER$ with your account
|
18:19:04
|
<dkayiwa> eg c/users/kawesi/.m2
|
18:19:12
|
<dkayiwa> kjoseph: as in your windows login account
|
18:19:25
|
<kjoseph> dkayiwa:okay
|
18:21:12
|
*** robbyoconnor has joined #openmrs
|
18:21:12
|
*** ChanServ sets mode: +v robbyoconnor
|
18:22:50
|
*** kavuri has quit IRC
|
18:23:16
|
*** kavuri has joined #openmrs
|
18:23:26
|
<kavuri> jkeiper: about my previous query...
|
18:23:52
|
<jkeiper> kavuri, yes
|
18:24:35
|
<kavuri> jkeiper: where should I be looking into to fix the problem of creating obs's
|
18:26:36
|
<jkeiper> kavuri, not sure ... don't know the webservices.rest code ... but essentially there should be a controller for handling POST of obs
|
18:26:43
|
<jkeiper> i think that's where you will find it
|
18:26:48
|
<jkeiper> give me a minute and i will get a clone on my machine
|
18:27:04
|
<kavuri> jkeiper: I do not think the problem is in webservice.rest, rather it is in the openmrs-core
|
18:27:26
|
<jkeiper> kavuri, oh?
|
18:27:32
|
<jkeiper> kavuri, can you write a unit test to prove it?
|
18:27:45
|
<kavuri> jkeiper: are all the classes in the core Obs.java, ObsServiceImpl.java, ObsDAO.java?
|
18:27:55
|
<jkeiper> kavuri, what is the code (perhaps a link to it from git) where the obs group is created and attempted to save?
|
18:27:58
|
<kavuri> jkeiper: I infact have a script that can prove this
|
18:28:00
|
<jkeiper> in webservices.rest ...
|
18:28:44
|
<dkayiwa> kavuri: can you create a core unit test that fails because of this bug?
|
18:29:24
|
<kavuri> dkayiwa: the script is here: http://pastebin.com/fpGpGazH
|
18:29:28
|
<kavuri> jkeiper: ^^^
|
18:30:00
|
<kavuri> jkeiper, dkayiwa: the uuids have to be updated to reflect your installation, but this curl command to create obs groups works
|
18:30:28
|
<jkeiper> kavuri, so you are saying this does not create a valid obs group?
|
18:31:17
|
<kavuri> jkeiper: it does create a valid obs group, but the obs_group_id for the child obs is not set
|
18:31:22
|
<kavuri> jkeiper: this is how it looks in the database
|
18:31:24
|
<kavuri> mysql> select obs_id,concept_id,obs_group_id,value_text from obs;
|
18:31:24
|
<kavuri> +--------+------------+--------------+------------+
|
18:31:24
|
<kavuri>
|
18:31:24
|
<kavuri> +--------+------------+--------------+------------+
|
18:31:24
|
<kavuri>
|
18:31:25
|
<kavuri>
|
18:31:27
|
<kavuri>
|
18:31:29
|
<kavuri>
|
18:31:31
|
<kavuri>
|
18:31:33
|
<kavuri>
|
18:31:35
|
<kavuri>
|
18:31:37
|
<kavuri>
|
18:31:41
|
<kavuri>
|
18:31:43
|
<kavuri> +--------+------------+--------------+------------+
|
18:31:58
|
<kavuri> jkeiper: the obs_id is 6 for the group and 7,8,9 are its children
|
18:32:08
|
<kavuri> jkeiper: but as you can see their obs_group_id is NULL
|
18:32:59
|
<kavuri> jkeiper: because of this, if I do a curl GET of the obs_id, I get "groupMembers":null
|
18:33:07
|
<jkeiper> kavuri, yes ... need to see in webservices.rest exactly how it is constructed
|
18:33:22
|
<jkeiper> kavuri, and we can compare it with another mechanism that creates obs groups, like the ORUR01Handler
|
18:34:03
|
*** dkayiwa has quit IRC
|
18:35:05
|
*** dkayiwa has joined #openmrs
|
18:35:17
|
<kavuri> jkeiper: nothing looks fishy in the webservices.rest, but I could be wrong
|
18:37:02
|
*** kjoseph has quit IRC
|
18:37:50
|
*** kjoseph has joined #openmrs
|
18:38:11
|
<jkeiper> kavuri, i am cloning now, will know something soon ...
|
18:38:51
|
<kavuri> jkeiper: thank you, I will have to hit the bed now, would you be kind to post your results to mailing list?
|
18:40:04
|
<kavuri> jkeiper: I already started a mail thread for this
|
18:40:46
|
<kavuri> jkeiper: the subject reads "RESTWS-302: Creating observation groups feature does not work"
|
18:41:06
|
<jkeiper> kavuri, i'll figure it out
|
18:41:07
|
<jkeiper> :-D
|
18:41:19
|
<kavuri> jkeiper: thanks again
|
18:44:34
|
*** kjoseph has quit IRC
|
18:45:02
|
*** kavuri has quit IRC
|
18:57:14
|
*** applecool has joined #openmrs
|
18:57:14
|
*** ChanServ sets mode: +v applecool
|
19:13:21
|
*** kjoseph has joined #openmrs
|
19:17:09
|
*** robbyoconnor has quit IRC
|
19:19:55
|
*** kjoseph has quit IRC
|
20:03:00
|
*** cpower has joined #openmrs
|
20:03:36
|
<cpower> Hello all, who would like to donate to my Thanksgiving charity run?
|
20:03:40
|
<cpower> ;-)
|
20:03:49
|
*** andrea has joined #openmrs
|
20:04:07
|
*** andrea is now known as Guest36972
|
20:04:15
|
<cpower> And that silence is golden
|
20:04:18
|
*** Guest36972 is now known as andreap_
|
20:04:21
|
<cpower> Let's Scrum instead
|
20:04:30
|
<andreap_> hi cpower
|
20:04:31
|
<cpower> !scrumon cpower
|
20:04:31
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
20:05:05
|
<cpower> Order: dkayiwa, andreap_, suranga, djazayeri and wluyima (if he's here)
|
20:06:21
|
<dkayiwa> IRC
|
20:06:22
|
<dkayiwa> Dev Call
|
20:06:22
|
<dkayiwa> About to commit: Table Widget - XFRM-42
|
20:06:22
|
<dkayiwa> No Blockers
|
20:06:47
|
<andreap_> Wednesday
|
20:06:48
|
<andreap_> Univ call
|
20:06:48
|
<andreap_> Design call
|
20:06:48
|
<andreap_> TRUNK-3474
|
20:06:48
|
<andreap_> Found all Subclasses of OpenmrsMetadata
|
20:06:48
|
<andreap_> Thursday
|
20:06:50
|
<andreap_> Dev call
|
20:06:52
|
<andreap_> TRUNK-3474
|
20:06:54
|
<andreap_> Found all their associated database tables with a not null constraint
|
20:06:57
|
<andreap_> Still To Do
|
20:07:00
|
<andreap_> Drop not null constraint on these tables
|
20:07:02
|
<andreap_> Go through their respective Validators, the naming convention for validators is
|
20:07:04
|
<andreap_> Blocker - How to update database tables (for code release)
|
20:08:10
|
<cpower> suranga anything to contribute?
|
20:08:34
|
<suranga> not today guys :-(
|
20:09:06
|
<djazayeri> Yesterday
|
20:09:06
|
<djazayeri> * Phone calls all day
|
20:09:06
|
<djazayeri> Today
|
20:09:06
|
<djazayeri> * Phone calls all day so far
|
20:09:06
|
<djazayeri> * Mirebalais work
|
20:09:08
|
<djazayeri> No blockers
|
20:09:23
|
<cpower> wyclif you around?
|
20:09:43
|
<cpower> I'll go with no...
|
20:10:13
|
<cpower> Blocker: updating database tables (andrea)
|
20:10:24
|
<cpower> No discussion points
|
20:10:31
|
<cpower> Who can help andreap_?
|
20:10:50
|
<djazayeri> andreap_: can you rephrase the question?
|
20:10:53
|
<andreap_> cpower, I know how to drop the constraint but how to get it to the real db is the question
|
20:11:14
|
<djazayeri> andreap_: presumably you need to write a liquibase changeset
|
20:11:42
|
<andreap_> djazayeri, ahh now I know what to look for anyway
|
20:12:56
|
<andreap_> djazayeri, will look that up and go on with checking the validators
|
20:13:50
|
<andreap_> djazayeri, if questions still, will bring to tommorrow's scrum
|
20:14:13
|
<dkayiwa> andreap_: you do not have to wait for scrum :)
|
20:14:20
|
<djazayeri> yeah
|
20:14:27
|
<djazayeri> andreap_: if you have questions, just ask them!
|
20:14:50
|
<andreap_> dkayiwa, djazayeri, will do. Thanks!
|
20:15:49
|
*** afiles has left #openmrs
|
20:17:49
|
<cpower> on that note !scrumoff
|
20:18:06
|
<cpower> !scrumoff
|
20:18:06
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
20:20:17
|
<cpower> So besides djazayeri, dkayiwa, jkeiper, and wluyima who has the most OpenMRS experience
|
20:20:18
|
<cpower> ?
|
20:20:35
|
<djazayeri> cpower: on irc?
|
20:20:38
|
<djazayeri> cpower: in the world?
|
20:20:39
|
<cpower> yes
|
20:20:55
|
<dkayiwa> cpower: yes to which of the above :)
|
20:21:21
|
<cpower> actively on line developers. Mostly who's in the room now, but anyone we know spends a fair amount of time on IRC
|
20:22:08
|
<cpower> If you 4 went down in a plane crash who would be the lead dev's?
|
20:22:38
|
<cpower> and not bringing up trader (kidding) like bwolfe
|
20:23:14
|
<djazayeri> cpower: you left out rafa.
|
20:23:23
|
<cpower> good one
|
20:23:40
|
<djazayeri> cpower: not on irc all the time, but most openmrs experience, perhaps mike seaton, and maybe saptarshi
|
20:23:42
|
<cpower> who else
|
20:24:35
|
<cpower> second time saptarshi's name has came up. Who is he?
|
20:24:50
|
<djazayeri> cpower: perhaps you know him as sunbiz?
|
20:25:17
|
<cpower> nope don't know that name either
|
20:26:03
|
<cpower> I know Mike, does saptarshi regularly particpate in sprints and I just don't realize it?
|
20:26:39
|
<cpower> Is he with Ampath/PIH or someone like that?
|
20:29:48
|
*** lh has joined #openmrs
|
20:34:19
|
<dkayiwa> cpower: no
|
20:35:40
|
*** robbyoconnor has joined #openmrs
|
20:35:40
|
*** ChanServ sets mode: +v robbyoconnor
|
20:35:43
|
*** applecool has quit IRC
|
20:36:14
|
*** robbyoconnor has quit IRC
|
20:38:23
|
<dkayiwa> cpower: here he is: http://sunnytalkstech.blogspot.com/
|
20:42:21
|
<djazayeri> cpower: he's worked with different people over time. now he's doingâ¦PhD or postdoc (I forget) in Norway
|
20:47:34
|
<djazayeri> wluyima: hi
|
20:47:52
|
<wluyima> hi djazayeri
|
20:48:08
|
<djazayeri> wluyima: per your blocker mentioned in email, about how using a profile is a bad thing?
|
20:48:54
|
<djazayeri> wluyima: can you clarify?
|
20:49:05
|
<wluyima> djazayeri, i can't seem to figure out how to use the profile, i have tried looking at the documentation for maven profiles
|
20:50:12
|
<wluyima> djazayeri, mvn test only runs junit tests while mvn failsafe:integration-test runs only integration tests, so why not just run these separately on CI
|
20:50:55
|
<djazayeri> wluyima: see the mirebalais module's api/pom.xml
|
20:50:57
|
<djazayeri> look for the ci profile
|
20:52:59
|
<wluyima> djazayeri, ok
|
20:55:34
|
<wluyima> djazayeri, the other question, is spike a proof of concept or i should ahead to commit, write wiki page and send out an email?
|
20:55:58
|
<wluyima> djazayeri, the other question, is the spike a proof of concept or i should go ahead to commit, write wiki page and send out an email?
|
20:56:10
|
<djazayeri> wluyima: I would suggest that you do this in a branch, which you commit to, and push up
|
20:56:50
|
<djazayeri> wluyima: so you can easily ask for feedback as you go along, by pointing to it on github. And we can merge it when it's ready.
|
20:56:55
|
<wluyima> djazayeri, that is what i meant, how about the wiki pages and email or that is for later once we push the code to master
|
20:57:24
|
*** dkayiwa_ has joined #openmrs
|
20:57:24
|
<djazayeri> wluyima: Over the course of the week, I hope that you both do the branch, show it to people, get agreement, and create the wiki pages.
|
20:57:35
|
*** dkayiwa has quit IRC
|
20:57:35
|
*** dkayiwa_ is now known as dkayiwa
|
20:57:48
|
<djazayeri> wluyima: I'd suggest doing a bit of work first to make sure things will work the way we propose, and _then_ spending time on the wiki pages
|
20:58:08
|
<djazayeri> wluyima: but it's up to you really
|
20:58:46
|
<wluyima> djazayeri, i actually have my pom like that in mirebalais ci profile
|
20:59:19
|
<wluyima> djazayeri, so so you run mvn test -P ci?
|
20:59:41
|
<wluyima> djazayeri, because it seems to always skip the integration tests for me
|
20:59:52
|
<djazayeri> wluyima: no space between -P and ci
|
20:59:55
|
<djazayeri> wluyima: -Pci
|
21:01:24
|
<wluyima> djazayeri, yeah
|
21:02:46
|
<cpower> sorry stepped away for a sec...so does he still contribute here often?
|
21:03:00
|
<cpower> *talking about sunbiz*
|
21:03:12
|
<wluyima> djazayeri, problem solved, i have figured what the problem was
|
21:03:56
|
<wluyima> i have to do run mvn verify -Pci, -Pci and -P ci are the same
|
21:04:10
|
<djazayeri> wluyima: ah, cool
|
21:25:16
|
*** suranga has quit IRC
|
21:26:41
|
<nribeka> djazayeri, if we get this exception: javax.el.ELException: Error reading 'links' on type org.openmrs.module.reporting.web.extension.ManageAdminListExt
|
21:26:45
|
<nribeka> what could causing this?
|
21:27:07
|
<nribeka> 1.8.2 / reporting 0.7.0
|
21:27:36
|
<nribeka> running module: logic-0.5, serialization 0.2.5, htmlwidgets 1.6.0
|
21:27:44
|
<nribeka> or anyone else?
|
21:29:34
|
*** jkeiper has quit IRC
|
21:39:15
|
<djazayeri> nribeka: sounds vaguely familiar, but I don't recall from where
|
21:39:26
|
<djazayeri> sorry
|
21:41:29
|
<nribeka> yeah, i'm reading some email thread on this
|
22:26:22
|
<nribeka> removed the module and then add the module seems to fix that problem
|
22:30:26
|
*** Mkop has joined #openmrs
|
22:30:26
|
*** ChanServ sets mode: +v Mkop
|
22:49:00
|
*** wluyima has quit IRC
|
22:51:37
|
*** wluyima has joined #openmrs
|
23:11:03
|
*** nribeka has quit IRC
|
23:16:27
|
<djazayeri> downey: hey, do you know if our balsamiq plugin for jira is down?
|
23:16:44
|
<downey> djazayeri: Something tells me you know more than I do
|
23:16:51
|
<djazayeri> downey: I don't see an ability to Add/Edit Mockup on TRUNK-2698
|
23:16:59
|
<downey> djazayeri: OK, will take a look
|
23:17:03
|
<djazayeri> thanks
|
23:18:13
|
*** wluyima has quit IRC
|
23:21:06
|
*** dkayiwa has quit IRC
|
23:24:51
|
*** robbyoconnor has joined #openmrs
|
23:24:51
|
*** ChanServ sets mode: +v robbyoconnor
|
23:26:29
|
<downey> djazayeri: looks like a problem recognizing the license, will get it sorted out
|
23:26:38
|
<djazayeri> downey: thanks!
|
23:30:45
|
<downey> djazayeri: got a trial installed until they get it sorted out, so it should work now
|
23:30:55
|
<djazayeri> downey: cool, I'll do that mockup now. :-)
|
23:55:59
|
*** nribeka has joined #openmrs
|
23:55:59
|
*** ChanServ sets mode: +v nribeka
|