00:26:04
|
*** dkayiwa has quit IRC
|
00:33:50
|
*** jordank has joined #openmrs
|
01:11:20
|
*** harshadura has quit IRC
|
01:41:00
|
*** djazayeri has joined #openmrs
|
01:41:00
|
*** ChanServ sets mode: +o djazayeri
|
01:41:28
|
*** jordank has quit IRC
|
02:16:09
|
*** andreap__ has quit IRC
|
03:58:55
|
*** djazayeri has quit IRC
|
05:24:56
|
*** kishoreyekkanti has joined #openmrs
|
05:33:15
|
*** kishoreyekkanti has quit IRC
|
05:39:51
|
*** nribeka has quit IRC
|
05:50:01
|
*** kishoreyekkanti has joined #openmrs
|
06:06:16
|
*** kishoreyekkanti has quit IRC
|
06:38:44
|
*** upul` has joined #openmrs
|
06:38:44
|
*** ChanServ sets mode: +v upul`
|
07:12:03
|
*** dkayiwa has joined #openmrs
|
07:59:33
|
*** shangxiao has joined #openmrs
|
08:00:40
|
*** seunggao has joined #openmrs
|
08:01:27
|
<seunggao> test
|
08:04:17
|
*** shangxiao has quit IRC
|
08:05:22
|
*** shangxiao has joined #openmrs
|
08:05:52
|
* seunggao slaps shangxiao with a large rainbow trout
|
08:06:09
|
*** seunggao has quit IRC
|
08:06:25
|
<shangxiao> Anybody here?
|
08:06:38
|
<dkayiwa> shangxiao: oh yes :)
|
08:06:42
|
<shangxiao> cool :)
|
08:07:05
|
<shangxiao> im working on a module :)
|
08:07:34
|
<shangxiao> do you know about module setup?
|
08:08:20
|
<dkayiwa> shangxiao: can you use my name such that my IRC client alerts me? :)
|
08:08:27
|
<shangxiao> oh yep
|
08:08:49
|
<dkayiwa> shangxiao: the same way am using yours. yes i know about module setup
|
08:09:09
|
<shangxiao> dkayiwa: do you know if it's possible to use hibernate annotations rather than mapping files?
|
08:09:48
|
<dkayiwa> shangxiao: yes i think you should be able to. though never tried it out with an openmrs module :)
|
08:11:32
|
<shangxiao> dkayiwa: it seems as though the core code has control over the hibernate setup file though
|
08:11:45
|
<dkayiwa> shangxiao: right
|
08:12:29
|
<shangxiao> might just have a look around there for a bit
|
08:12:37
|
<dkayiwa> shangxiao: ok
|
09:36:07
|
*** dkayiwa has quit IRC
|
09:47:17
|
*** dkayiwa has joined #openmrs
|
09:52:12
|
<dkayiwa> #hum-team
|
10:45:26
|
<shangxiao> dkayiwa: perhaps modules can't use annotations afterall. According to the Spring documentation, LocalSessionFactoryBean only takes mapping files... OpenMRS core would have to make use of AnnotationSessionFactoryBean :(
|
10:46:14
|
<dkayiwa> shangxiao: oh i see!!!. Very good investigation. Can you create a ticket for it?
|
10:46:33
|
<shangxiao> dkayiwa: I'm going to ask on the newsgroup first :)
|
10:46:48
|
<dkayiwa> shangxiao: very very wise of you. just incase :)
|
10:47:08
|
<dkayiwa> shangxiao: am assuming you meant dev list :)
|
10:47:13
|
<shangxiao> yep
|
10:48:08
|
<shangxiao> dkayiwa: this guy i'm working with on this has got me saying newsgroup instead of mailing list ;)
|
10:48:49
|
<dkayiwa> shangxiao: :D
|
11:01:57
|
*** shangxiao has quit IRC
|
11:22:50
|
*** upul` has quit IRC
|
11:34:49
|
*** nwilkie has joined #openmrs
|
11:37:07
|
*** kjoseph has joined #openmrs
|
11:38:41
|
<kjoseph> dkayiwa: hi, i can open the guide even with no internet connection
|
11:39:06
|
<dkayiwa> kjoseph: yes thats all i wanted. a simple yes or no :)
|
11:39:25
|
<dkayiwa> kjoseph: can you do an mvn clean install ?
|
11:39:44
|
<kjoseph> dkayiwa:okay
|
11:39:59
|
<dkayiwa> kjoseph: then tell me how it goes
|
11:42:05
|
<kjoseph> dkayiwa: feom which directory do i need to do mvn clean install, is it from the openmrs source code where i had done it before
|
11:42:38
|
<dkayiwa> kjoseph: where you did it before successfully
|
11:45:03
|
*** nribeka has joined #openmrs
|
11:45:03
|
*** ChanServ sets mode: +v nribeka
|
11:59:14
|
<kjoseph> dkayiwa: this time am getting a build failure, i have still tried re un zipping the pack of openmrs- core and run the command in that directory and the same problem, do i need to run the command in a newly created directory, error pasted at: http://pastebin.com/n7yYHBqD
|
11:59:45
|
<dkayiwa> kjoseph: why didn't you do a git clone?
|
12:01:47
|
<dkayiwa> kjoseph: are you there?
|
12:15:27
|
*** kjoseph has quit IRC
|
12:42:00
|
*** alangfiles_ has joined #openmrs
|
12:42:34
|
*** wyclif has quit IRC
|
12:46:54
|
*** nribeka has quit IRC
|
13:05:29
|
*** nwilkie has quit IRC
|
13:05:43
|
*** alangfiles_ has left #openmrs
|
13:07:45
|
*** nwilkie has joined #openmrs
|
13:14:08
|
*** jordank has joined #openmrs
|
13:23:35
|
*** jordank has quit IRC
|
13:28:55
|
*** downey has joined #openmrs
|
13:28:55
|
*** OpenMRSBot sets mode: +o downey
|
13:28:55
|
*** ChanServ sets mode: +o downey
|
13:31:21
|
*** wyclif has joined #openmrs
|
13:33:37
|
*** kishoreyekkanti has joined #openmrs
|
13:39:25
|
*** nribeka has joined #openmrs
|
13:39:25
|
*** ChanServ sets mode: +v nribeka
|
13:39:42
|
<downey> Hi nribeka and welcome to the #openmrs IRC channel.
|
13:40:21
|
<nribeka> hi downey
|
13:41:09
|
<dkayiwa> nribeka: that is the automated downey :)
|
13:41:38
|
<downey> Hi dkayiwa and welcome to the #openmrs IRC channel.
|
13:41:51
|
<dkayiwa> downey: hahahahahah :D
|
13:43:13
|
<dkayiwa> Hi downey and welcome to the #openmrs IRC channel.
|
13:47:52
|
*** fishandwalk has quit IRC
|
13:56:56
|
*** rafa has joined #openmrs
|
13:56:56
|
*** ChanServ sets mode: +v rafa
|
14:02:33
|
*** cpower has joined #openmrs
|
14:02:46
|
<cpower> Greetings Highlander!
|
14:03:11
|
<cpower> *in a random cult movie quote kind of mood*
|
14:03:19
|
*** djazayeri has joined #openmrs
|
14:03:19
|
*** ChanServ sets mode: +o djazayeri
|
14:03:36
|
<cpower> Let us do what we do when we gather...
|
14:04:01
|
<cpower> !scrumon cpower
|
14:04:01
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:04:55
|
<cpower> Order: wyclif, dkayiwa, rafa, djazayeri, and if downey wants to get some attention around the Google work I'm fine with that too.
|
14:06:02
|
<wyclif> Thursday:
|
14:06:02
|
<wyclif> Paired with daniel on user management for mirebalais - #153
|
14:06:02
|
<wyclif> dev call
|
14:06:02
|
<wyclif> merge TRUNK-2705 to master
|
14:06:02
|
<wyclif>
|
14:06:03
|
<wyclif> Friday:
|
14:06:05
|
<wyclif> Pair with daniel to complete user management
|
14:06:07
|
<wyclif> probably start on another ticket
|
14:06:09
|
<wyclif>
|
14:06:13
|
<wyclif> Blockers: none
|
14:06:21
|
<dkayiwa> Did more work on Mirebalais Account Management
|
14:06:21
|
<dkayiwa> Investigating JRebel for Hot Code Replace
|
14:06:22
|
<dkayiwa> No Blockers
|
14:06:45
|
*** andrea__ has joined #openmrs
|
14:06:47
|
<rafa> Yesterday:
|
14:06:47
|
<rafa> * Holiday in Poland
|
14:06:47
|
<rafa> Today:
|
14:06:47
|
<rafa> * Reviewed more pull requests
|
14:06:47
|
<rafa> * Merged / Back ported:
|
14:06:48
|
<rafa> + TRUNK-3261: Make Global Property parsed and cached (not fetching and parsing every time)
|
14:06:48
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3261
|
14:06:49
|
<rafa> + TRUNK-3287: Incorrect date_created value on edited concept names
|
14:06:49
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3287
|
14:06:50
|
<rafa> + TRUNK-3616: ConceptValidator should require at least one description for a concept
|
14:06:50
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3616
|
14:06:51
|
<rafa> + TRUNK-1632: Strange allergies allowed in the Allergies list on the patient dashboard
|
14:06:51
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-1632
|
14:06:52
|
<rafa> No blockers.
|
14:07:30
|
<djazayeri> Yesterday
|
14:07:30
|
<djazayeri> * Lots and lots of calls
|
14:07:30
|
<djazayeri> * Briefly talked with Wyclif and Daniel about User Management story for Mirebalais
|
14:07:30
|
<djazayeri> * Released UI Framework 1.10 (fixes a bug where @BindParams wasn't working in page controllers)
|
14:07:30
|
<djazayeri> * Accepted some UI Library pull requests
|
14:07:30
|
<djazayeri> * Transferred UI Library module into OpenMRS's github
|
14:07:31
|
<djazayeri> Today
|
14:07:31
|
<djazayeri> * No phone calls!?!? (fingers crossed)
|
14:07:32
|
<djazayeri> * Work on Mirebalasi
|
14:07:50
|
<cpower> andrea__ you are up
|
14:07:57
|
<andrea__> ok
|
14:08:13
|
<andrea__> Thursday
|
14:08:14
|
<andrea__> Dev call
|
14:08:14
|
<andrea__> emails
|
14:08:14
|
<andrea__> TRUNK-3616
|
14:08:14
|
<andrea__> Try to get clean build so I can debug
|
14:08:14
|
<andrea__> Fix failing unit test
|
14:08:16
|
<andrea__> Commit / pull request TRUNK-3616
|
14:08:18
|
<andrea__> Unit test Using errors.getGlobalErrors()
|
14:08:20
|
<andrea__> and look for the one with missing description message.
|
14:08:22
|
<andrea__> put in Unit test - Need to debug globalErrors
|
14:08:25
|
<andrea__> Friday
|
14:08:29
|
<andrea__> Go through mail from Rafa
|
14:08:31
|
<andrea__> Look at TRUNK-3474 - Wycliff wanted me to befor TRUNK-3616
|
14:08:32
|
<andrea__> They are related - good idea think
|
14:08:35
|
<andrea__> blocker
|
14:08:42
|
<andrea__> need clean build to debug errors
|
14:09:34
|
<cpower> Do you need any help getting a clean build or just the fact that you need to work on it, is a blocker
|
14:10:44
|
<andrea__> need to work on it - may need help later
|
14:10:56
|
<djazayeri> !ticket trunk-3474
|
14:10:57
|
<OpenMRSBot> djazayeri: [#TRUNK-3474] Remove not null constraint on the description column/property for all OpenmrsMetadata objects - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3474
|
14:11:01
|
<djazayeri> !ticket trunk-3616
|
14:11:02
|
<OpenMRSBot> djazayeri: [#TRUNK-3616] ConceptValidator should require at least one description for a concept - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3616
|
14:11:14
|
<cpower> ok then...no discussiont points, no blockers for today
|
14:11:19
|
<cpower> !scrumoff
|
14:11:19
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:11:57
|
<andrea__> rafa, very early here just going thru your emails
|
14:12:14
|
<rafa> andrea__: ok, we're almost there :)
|
14:12:20
|
<downey> FYI, we have been "short listed" for the Google Doc Sprint. I need to provide some follow up information by Monday so they can make final determinations.
|
14:12:23
|
<andrea__> rafa, commented out test ect are there because I'm not done
|
14:12:39
|
<rafa> andrea__: all right
|
14:12:57
|
<dkayiwa> downey: that is very good news!!! :D
|
14:13:04
|
<rafa> downey: hurray!
|
14:13:51
|
<andrea__> rafa, wycliff suggest I do TRUNK-3477 firs - they are related - will put null constraint on description
|
14:14:13
|
<andrea__> rafa, do you think this is a good idea?
|
14:14:29
|
<rafa> andrea__: yes, got for it
|
14:14:56
|
<andrea__> rafa, good that's what I think
|
14:15:28
|
<andrea__> rafa, do I stash the code for TRUNK-3616?
|
14:15:59
|
<rafa> andrea__: I think you should finish off TRUNK-3616 first
|
14:16:23
|
<rafa> andrea__: and do TRUNK-3477 next
|
14:16:34
|
<djazayeri> andrea__: I agree with rafa. If you're already most of the way through TRUNK-3616, finish it first.
|
14:17:18
|
<andrea__> rafa, ok - need to go thru your mail - may have questions
|
14:17:20
|
*** sgithens has quit IRC
|
14:17:37
|
<andrea__> djaayeri, rafa OK
|
14:17:38
|
<rafa> andrea__: sure I'm going for a run now
|
14:17:43
|
<rafa> andrea__: but will be back in half an hour
|
14:17:53
|
<rafa> andrea__: and plan to stay for another 3 hours at least
|
14:18:18
|
<andrea__> rafa, I have to walk my dog - talk to you later
|
14:34:44
|
*** rafa has quit IRC
|
15:02:24
|
<dkayiwa> downey: do we have a JRebel OpenMRS license?
|
15:04:33
|
<downey> dkayiwa: yes -- just open a request at http://go.openmrs.org/helpdesk
|
15:04:43
|
<dkayiwa> downey: ok
|
15:09:16
|
*** nwilkie has quit IRC
|
15:17:06
|
*** rkorytkowski has joined #openmrs
|
15:17:06
|
*** ChanServ sets mode: +v rkorytkowski
|
15:17:21
|
<downey> Hi rkorytkowski and welcome to the #openmrs IRC channel.
|
15:17:22
|
*** rkorytkowski is now known as rafa
|
15:22:51
|
*** sgithens has joined #openmrs
|
15:28:11
|
*** kishoreyekkanti has quit IRC
|
15:29:23
|
*** dkayiwa has quit IRC
|
15:40:05
|
*** sgithens has quit IRC
|
15:47:38
|
*** kishoreyekkanti has joined #openmrs
|
15:57:11
|
*** djazayeri has quit IRC
|
15:57:28
|
*** djazayeri has joined #openmrs
|
15:57:28
|
*** ChanServ sets mode: +o djazayeri
|
16:06:44
|
<andrea__> rafa, you around?
|
16:06:51
|
<rafa> andrea__: yes
|
16:07:01
|
<andrea__> rafa, good
|
16:07:30
|
*** nwilkie has joined #openmrs
|
16:07:51
|
<andrea__> rafa, glad to fix all these issues but build is failing due to tests failing
|
16:08:11
|
<rafa> andrea__: the ones you wrote or other?
|
16:08:29
|
<andrea__> rafa, others
|
16:08:59
|
<rafa> andrea__: maybe they're failing due to changes you made
|
16:09:06
|
<rafa> andrea__: and you need to fix these tests as well
|
16:09:21
|
<andrea__> rafa, yes! That's what I'm worried about.
|
16:09:31
|
<rafa> andrea__: nothing to worry :)
|
16:09:40
|
<andrea__> rafa, why?
|
16:09:51
|
<rafa> andrea__: just go through these tests, see why they're failing and correct them
|
16:10:50
|
<rafa> andrea__: my guess is that in most cases concepts simply fail validation
|
16:11:04
|
<rafa> andrea__: and you need to make sure that they have at least one non blank description
|
16:11:36
|
<andrea__> rafa, think you're right but can't build code with errors
|
16:11:47
|
<rafa> andrea__: so you add a desciption before saving a concept and you're good
|
16:11:58
|
<rafa> andrea__: you mean it doesn't compile or tests fail?
|
16:12:10
|
<andrea__> rafa, tests fail
|
16:12:15
|
<rafa> andrea__: that's good
|
16:12:24
|
<rafa> andrea__: you need to fix tests :)
|
16:12:29
|
<andrea__> rafa, ok if you say so
|
16:12:40
|
<rafa> andrea__: give me an example of a failing test
|
16:15:51
|
<andrea__> rafa, redirected clean install output to a file - will email it to you
|
16:16:18
|
<rafa> andrea__: ok
|
16:21:30
|
*** sgithens has joined #openmrs
|
16:22:04
|
*** kishoreyekkanti_ has joined #openmrs
|
16:22:12
|
<andrea__> rafa, sorry so slow - on 2 differnt computers - irc not good on the work computer
|
16:24:15
|
*** kishoreyekkanti has quit IRC
|
16:24:15
|
*** kishoreyekkanti_ is now known as kishoreyekkanti
|
16:26:05
|
<rafa> andrea__: ok, got it
|
16:26:18
|
<rafa> andrea__: so let's start with the first one
|
16:26:26
|
<rafa> andrea__: validate_shouldPassForANewConceptWithAMapCreatedWithDeprecatedConceptMapMethods in ConceptValidatorTest
|
16:26:56
|
<rafa> andrea__: there's a new concept created there
|
16:27:06
|
<rafa> but it's missing a description
|
16:27:46
|
<rafa> andrea__: to fix just add concept.addDescription(new ConceptDescription("test description", Context.getLocale())); before calling ValidateUtil.validate(concept) and you're good
|
16:27:58
|
<andrea__> ok, so I need to add a description?
|
16:28:11
|
<andrea__> rafa, got it
|
16:28:45
|
<rafa> andrea__: you should be able to fix all these tests in the same way
|
16:29:03
|
<andrea__> rafa, Thanks!! Will do
|
16:29:05
|
<rafa> andrea__: if in doubt ask
|
16:29:16
|
<andrea__> rafa, have to go to office now
|
16:29:21
|
<rafa> andrea__: ok
|
16:29:31
|
<rafa> andrea__: cya
|
16:31:33
|
<andrea__> rafa, when done will commit and push - that's all I have to do, right?l
|
16:35:50
|
<rafa> andrea__: remember about correcting the addDescription method
|
16:36:15
|
<rafa> andrea__: as in the ticket description
|
16:36:59
|
<rafa> andrea__: and yes, commit -> push -> move ticket to Code Review state
|
16:38:12
|
<rafa> andrea__: whenever you request Code-Review I am notified
|
16:50:31
|
*** wyclif has quit IRC
|
16:55:32
|
*** wyclif has joined #openmrs
|
16:55:44
|
*** andrea__ has quit IRC
|
17:09:10
|
*** sgithens has quit IRC
|
17:46:58
|
*** downey has quit IRC
|
17:47:06
|
*** sgithens has joined #openmrs
|
17:57:53
|
*** nwilkie has quit IRC
|
17:59:14
|
*** nwilkie has joined #openmrs
|
18:07:36
|
*** downey has joined #openmrs
|
18:07:36
|
*** ChanServ sets mode: +o downey
|
18:07:36
|
*** OpenMRSBot sets mode: +o downey
|
18:10:54
|
*** kishoreyekkanti has quit IRC
|
18:16:20
|
*** suranga has joined #openmrs
|
18:16:20
|
*** ChanServ sets mode: +v suranga
|
18:51:21
|
*** downey has quit IRC
|
19:02:27
|
*** downey has joined #openmrs
|
19:02:27
|
*** ChanServ sets mode: +o downey
|
19:02:27
|
*** OpenMRSBot sets mode: +o downey
|
19:07:35
|
*** cpower has quit IRC
|
19:21:51
|
*** downey has quit IRC
|
19:26:51
|
*** downey has joined #openmrs
|
19:26:51
|
*** ChanServ sets mode: +o downey
|
19:26:51
|
*** OpenMRSBot sets mode: +o downey
|
20:50:38
|
*** sgithens has quit IRC
|
21:25:37
|
*** downey has quit IRC
|
21:42:12
|
*** nwilkie has quit IRC
|
21:42:47
|
*** nribeka has quit IRC
|
21:45:25
|
*** wyclif has quit IRC
|
21:58:30
|
<suranga> howdy rafa , are you really here ?
|
21:58:31
|
<suranga> :)
|
22:00:17
|
*** nwilkie has joined #openmrs
|
22:11:22
|
*** rafa has quit IRC
|
22:25:36
|
*** curtisbro has joined #openmrs
|
22:27:27
|
<curtisbro> Hi, first time connecting to the irc. Just installed the stand-alone last weekend. Halftway through the user guide. Can I ask newbie questions here?
|
22:27:54
|
<djazayeri> curtisbro: this is the place, though friday afternoon/evening isn't necessarily the time. :-)
|
22:28:33
|
<curtisbro> LOL, OK, I can imagine. Will read my try some things. Check in next week.
|
22:29:23
|
*** curtisbro has left #openmrs
|
22:52:00
|
*** suranga has quit IRC
|
22:52:05
|
*** wyclif has joined #openmrs
|
22:53:27
|
*** CurtisBRO1 has joined #openmrs
|
22:55:13
|
*** nwilkie has quit IRC
|
23:01:42
|
*** nwilkie has joined #openmrs
|
23:10:07
|
*** lh has joined #openmrs
|
23:10:07
|
*** lh has joined #openmrs
|
23:12:28
|
*** nwilkie has quit IRC
|
23:29:45
|
*** sgithens has joined #openmrs
|
23:45:04
|
*** nribeka has joined #openmrs
|
23:45:04
|
*** ChanServ sets mode: +v nribeka
|
23:47:34
|
*** CurtisBRO1 has left #openmrs
|
23:58:06
|
*** nwilkie has joined #openmrs
|