00:01:09
|
*** Mkop1 has quit IRC
|
00:02:32
|
*** wyclif has joined #openmrs
|
00:36:24
|
*** Mkop1 has joined #openmrs
|
00:36:25
|
*** ChanServ sets mode: +v Mkop1
|
01:09:59
|
*** Mkop1 has quit IRC
|
02:49:22
|
*** mseaton has joined #openmrs
|
02:49:22
|
*** ChanServ sets mode: +v mseaton
|
03:04:28
|
*** djazayeri1 has joined #openmrs
|
03:08:15
|
*** djazayeri has quit IRC
|
04:22:35
|
*** kavuri has joined #openmrs
|
04:27:52
|
*** mseaton has quit IRC
|
04:44:40
|
*** kishoreyekkanti has joined #openmrs
|
04:48:31
|
*** upul` has joined #openmrs
|
04:48:31
|
*** ChanServ sets mode: +v upul`
|
05:09:36
|
*** fishandwalk has joined #openmrs
|
05:54:54
|
*** kishoreyekkanti has quit IRC
|
06:09:35
|
*** kavuri has quit IRC
|
06:20:33
|
*** kishoreyekkanti has joined #openmrs
|
07:04:13
|
*** kishoreyekkanti has quit IRC
|
07:21:34
|
*** kishoreyekkanti has joined #openmrs
|
07:23:17
|
*** suranga has joined #openmrs
|
07:23:17
|
*** ChanServ sets mode: +v suranga
|
07:24:53
|
*** djazayeri1 has quit IRC
|
10:18:24
|
*** dkayiwa has joined #openmrs
|
10:22:18
|
*** dkayiwa_ has joined #openmrs
|
10:24:12
|
*** dkayiwa has quit IRC
|
10:26:54
|
*** dkayiwa has joined #openmrs
|
10:26:59
|
*** dkayiwa_ has quit IRC
|
10:34:21
|
*** suranga has quit IRC
|
10:40:19
|
*** suranga has joined #openmrs
|
10:46:18
|
*** suranga has quit IRC
|
10:49:30
|
*** suranga has joined #openmrs
|
10:58:06
|
*** suranga has quit IRC
|
10:59:05
|
*** suranga has joined #openmrs
|
11:10:04
|
*** suranga has quit IRC
|
11:14:24
|
*** suranga has joined #openmrs
|
11:19:01
|
*** upul` has quit IRC
|
11:52:25
|
*** suranga has quit IRC
|
12:26:47
|
*** jkeiper has joined #openmrs
|
12:26:47
|
*** ChanServ sets mode: +v jkeiper
|
12:44:56
|
*** cpower has joined #openmrs
|
12:47:52
|
<dkayiwa> hi wyclif
|
13:03:02
|
*** kjoseph has joined #openmrs
|
13:04:24
|
*** dkayiwa_ has joined #openmrs
|
13:04:30
|
<kjoseph> dkayiwa:hi,
|
13:04:51
|
<dkayiwa_> kjoseph: hi
|
13:05:11
|
*** dkayiwa has quit IRC
|
13:05:21
|
*** dkayiwa_ is now known as dkayiwa
|
13:05:47
|
*** mseaton has joined #openmrs
|
13:05:47
|
*** ChanServ sets mode: +v mseaton
|
13:06:30
|
<jkeiper> mseaton, is there / has anyone written a queuing feature for report generation?
|
13:07:21
|
<kjoseph> dkayiwa: am requesting for further assistance, am now running standalone and i have just openned the jar file,
|
13:07:57
|
*** mseaton1 has joined #openmrs
|
13:08:29
|
<dkayiwa> kjoseph: can you first respond to my email?
|
13:08:38
|
*** mseaton2 has joined #openmrs
|
13:09:28
|
*** nwilkie has quit IRC
|
13:11:31
|
*** thn has joined #openmrs
|
13:11:35
|
*** mseaton has quit IRC
|
13:11:53
|
<jkeiper> has anyone here ever been able to make a bulleted list in a table cell in a wiki page, and break out of that list to a new line within the same cell? it's driving me crazy.
|
13:12:33
|
<thn> hello
|
13:12:44
|
*** mseaton1 has quit IRC
|
13:13:32
|
<thn> does openmrs use a custom OSIVFilter?
|
13:15:21
|
<dkayiwa> thn: hi
|
13:16:39
|
<thn> hello??
|
13:16:54
|
*** suranga has joined #openmrs
|
13:22:39
|
*** dkayiwa has quit IRC
|
13:25:02
|
*** kjoseph has quit IRC
|
13:25:24
|
*** dkayiwa has joined #openmrs
|
13:33:15
|
*** applecool has joined #openmrs
|
13:33:15
|
*** ChanServ sets mode: +v applecool
|
13:35:22
|
*** mseaton2 has left #openmrs
|
13:51:23
|
<dkayiwa> hi wyclif
|
13:51:50
|
<wyclif> hi dkayiwa
|
13:52:13
|
<dkayiwa> wyclif: canyou remind me of the name of the merabalais irc room?
|
13:52:17
|
<dkayiwa> :)
|
13:57:42
|
*** rafa has joined #openmrs
|
13:57:42
|
*** ChanServ sets mode: +v rafa
|
14:00:00
|
*** andrea__ has joined #openmrs
|
14:01:40
|
<cpower> heeeelllloooo!
|
14:01:50
|
<andrea__> hey cpower
|
14:02:23
|
<cpower> hey you managed to make it to work among the sea of parades and Giants party's...congrats!
|
14:02:49
|
<cpower> Are we ready to do that thing we do?
|
14:02:51
|
<andrea__> cpower, parade is wednesdat - starts right by our building
|
14:03:20
|
<cpower> take some photos and send them to me :-) I'd like to know what should have been happening in Cincy
|
14:03:37
|
<cpower> ok let's scrum
|
14:03:39
|
*** dkayiwa has quit IRC
|
14:03:46
|
<cpower> !scrumon cpower
|
14:03:46
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:04:00
|
*** dkayiwa_ has joined #openmrs
|
14:04:17
|
<cpower> Order: rafa, andrea__, dkayiwa_, suranga, wyclif
|
14:04:38
|
*** djazayeri has joined #openmrs
|
14:04:38
|
*** ChanServ sets mode: +o djazayeri
|
14:04:48
|
<rafa> Yesterday/Today:
|
14:04:48
|
<rafa> * Committed and back ported TRUNK-3651: TRUNK-3295 / allow the email format as a valid username
|
14:04:49
|
<rafa> * Investigated why https://ci.openmrs.org/browse/FUNC-LBR-LATEST-11 fails on CI
|
14:04:49
|
<rafa> * Commented on some tickets
|
14:04:49
|
<rafa> * Will continue closing pull requests (still 21 to go)
|
14:04:49
|
<cpower> and wrap up with djazayeri
|
14:04:49
|
<rafa> No blockers.
|
14:05:08
|
<andrea__> Monday
|
14:05:08
|
<andrea__> Merck meetings
|
14:05:08
|
<andrea__> Added @Ignore to 4 tests not yet implemented in ConceptValidatorTest
|
14:05:08
|
<andrea__> to get clean maven build - still failing due to test in ConceptServiceTest
|
14:05:08
|
<andrea__> Looked for new tickets
|
14:05:09
|
<andrea__> emails
|
14:05:10
|
<andrea__> Junit testing documentation
|
14:05:12
|
<andrea__> Tuesday
|
14:05:14
|
<andrea__> Get mvn clean install working
|
14:05:18
|
<andrea__> Pull Request for TRUNK-3616
|
14:05:21
|
<andrea__> Find new tickets
|
14:05:22
|
<andrea__> Blocker
|
14:05:25
|
<andrea__> mvn clean install failing due to:
|
14:05:26
|
<andrea__> saveConcept_shouldSaveAConceptNumericAsAConcept(org.openmrs.api.ConceptServiceTest)
|
14:05:28
|
<andrea__> I'm not calling ConceptServiceTest.
|
14:05:36
|
*** fishandwalk has quit IRC
|
14:05:47
|
<cpower> ok, dkayiwa_
|
14:06:24
|
<dkayiwa_> Working on: Change ID Gen module so that remote identifier source returns new identfiers is JSON format
|
14:06:24
|
<dkayiwa_> Blocker: Unit test running gives me this error: org.hibernate.MappingException: Unknown entity: org.openmrs.module.idgen.SequentialIdentifierGenerator
|
14:06:43
|
<cpower> alrighty... suranga
|
14:07:01
|
*** andrea__ has quit IRC
|
14:07:28
|
*** andrea__ has joined #openmrs
|
14:07:43
|
<cpower> next! wyclif
|
14:07:47
|
<wyclif> Monday:
|
14:07:47
|
<wyclif> Talk with CD team
|
14:07:47
|
<wyclif> Added check digit and verification code/tests for the check digit
|
14:07:47
|
<wyclif> Clean up/Update branches in my git fork and unmerged pull requests
|
14:07:47
|
<wyclif>
|
14:07:48
|
<wyclif> Tuesday:
|
14:07:50
|
<wyclif> Mirebalais project tickets
|
14:07:52
|
<wyclif>
|
14:07:54
|
<wyclif> Blockers: none
|
14:08:00
|
<cpower> and finally djazayeri
|
14:08:04
|
<djazayeri> Today
|
14:08:04
|
<djazayeri> * Mirebalais tickets
|
14:08:04
|
<djazayeri> Yesterday
|
14:08:04
|
<djazayeri> * Worked on adding visits/ADT to the EMR, Patient Registration and Mirebalais
|
14:08:05
|
<djazayeri> Today
|
14:08:05
|
<djazayeri> * More Mirebalais visits, etc
|
14:08:06
|
<djazayeri> no blockers
|
14:08:15
|
<cpower> A few blockers today
|
14:08:29
|
<cpower> <andrea__> Blocker
|
14:08:29
|
<cpower> [10:05] <andrea__> mvn clean install failing due to:
|
14:08:29
|
<cpower> [10:05] <andrea__> saveConcept_shouldSaveAConceptNumericAsAConcept(org.openmrs.api.ConceptServiceTest)
|
14:08:29
|
<cpower> [10:05] <andrea__> I'm not calling ConceptServiceTest.
|
14:08:30
|
<wyclif> djazayeri, need another task to work on
|
14:08:33
|
<rafa> andrea__: Just create a pull request and I will test if it fails for me
|
14:08:39
|
<cpower> and
|
14:08:50
|
<andrea__> rafa, ok will do
|
14:08:56
|
<cpower> <dkayiwa_> Blocker: Unit test running gives me this error: org.hibernate.MappingException: Unknown entity: org.openmrs.module.idgen.SequentialIdentifierGenerator
|
14:09:08
|
<djazayeri> wyclif: let's talk blockers here, and ask in the other window
|
14:09:10
|
<cpower> who can help?
|
14:09:28
|
<djazayeri> I can
|
14:09:45
|
<cpower> both or which one?
|
14:09:46
|
<dkayiwa_> the unit test in api project run well for the same code, but not in the omod project
|
14:09:52
|
<djazayeri> dkayiwa_: is that after you've made any code changes?
|
14:10:04
|
<dkayiwa_> dkayiwa_: yes
|
14:10:08
|
<djazayeri> dkayiwa_: or on a clean checkout?
|
14:10:20
|
<dkayiwa_> djazayeri: clean checkout runs well
|
14:10:29
|
<dkayiwa_> djazayeri: it is my code producing that error
|
14:10:54
|
<dkayiwa_> djazayeri: and the same unit test runs well in the "api" project but not in "omod"
|
14:11:10
|
*** suranga has quit IRC
|
14:11:25
|
<djazayeri> dkayiwa_: it's in the omod folder? did you accidentally do a ContextSensitiveTest instead of a WebContextSensitiveTest?
|
14:11:43
|
<dkayiwa_> djazayeri: let me cross check
|
14:13:03
|
<djazayeri> dkayiwa_: #hum-team
|
14:13:36
|
<dkayiwa_> djazayeri: ok let me continue from #hum-team
|
14:18:55
|
<cpower> ok anyone helped Andrea with hers?
|
14:19:19
|
<djazayeri> cpower: I think andrea__ is going to send a patch to rafa and he'll help. (Right?)
|
14:19:29
|
<rafa> djazayeri: right
|
14:19:37
|
<cpower> yeah just saw it...sounds good
|
14:19:41
|
<cpower> !scrumoff
|
14:19:41
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:20:00
|
*** cpower has quit IRC
|
14:23:05
|
<thn> try again -- does openmrs use a custom OSIVFilter?
|
14:23:56
|
<djazayeri> thn: per our web.xml, we use the standard Spring OpenSessionInViewFilter
|
14:29:03
|
*** kjoseph has joined #openmrs
|
14:30:35
|
<kjoseph> dkayiwa: have you recieved my mail please?
|
14:33:06
|
<thn> djazayeri: thanks -- and I'm presuming you're not doing any customization of the Spring @Transaction processing or the HibernateTransactionManager?
|
14:34:18
|
<djazayeri> thn: why do you ask?
|
14:34:55
|
<thn> just curious -- want to confirm that
|
14:35:58
|
<djazayeri> thn: we added a bit of custom transaction stuff in OpenMRS 1.9, and rafa can point you which class
|
14:36:13
|
*** applecool has quit IRC
|
14:38:01
|
<thn> that'd be great -- you mean you modified the Spring TransactionAdvice? (which IIRC is what advises @Transaction methods))
|
14:38:38
|
<djazayeri> thn: I don't recall exactly where, and I'm not actually "at work" yet, so I'm hoping rafa can answer with 2 seconds of thought
|
14:39:57
|
<rafa> thn: hi
|
14:40:08
|
<thn> hello
|
14:40:12
|
<rafa> thn: we use standard Spring transaction interceptor
|
14:40:19
|
<rafa> thn: see applicationContext-service.xml
|
14:40:50
|
<kjoseph> dkayiwa_: am re- lauching openmrs-standalone, can i choose: demonstration mode, starter implementation or expert mode, the other time i had used the first one
|
14:41:56
|
<thn> and your extended LocalSessionFactoryBean doesn't intercede in transactional processing; right?
|
14:43:06
|
<rafa> thn: right
|
14:43:26
|
<dkayiwa_> kjoseph: use demonstration mode
|
14:43:27
|
<thn> thanks
|
14:43:54
|
<rafa> thn: the only purpose of that is to chain interceptors at runtime
|
14:44:21
|
<rafa> thn: if they come from modules
|
14:44:40
|
<thn> yeah, i looked at that code -- I couldn't tell what the interceptors (if any) actually did
|
14:45:02
|
*** kjoseph has quit IRC
|
14:45:06
|
<rafa> thn: an example is the event module
|
14:45:46
|
<rafa> thn: it registers an intereceptor which notifies about any created/updated objects
|
14:46:10
|
<rafa> thn: also there's AuditableInterceptor in core
|
14:46:49
|
<rafa> thn: to fill some audit information like changedBy, dateChanged, etc.
|
14:47:11
|
<thn> hmmm -- that sounds like business logic to me
|
14:48:49
|
*** dkayiwa_ has quit IRC
|
14:49:15
|
<rafa> thn: it's almost like AOP
|
14:49:41
|
<rafa> thn: just resistant to the Hibernate magic, becauase it uses the Hibernate magic ;)
|
14:50:02
|
<thn> ahah -- tha's "black" magic
|
14:50:07
|
<thn> that's
|
14:50:36
|
<thn> "All calls within a session are considered to be on one transaction" API docs
|
14:50:52
|
<thn> that, unfortunately is not true
|
14:51:23
|
<rafa> thn: where did you find that?
|
14:51:43
|
<thn> thee quote? https://wiki.openmrs.org/display/docs/API
|
14:51:50
|
<rafa> thn: we have a session which spans the whole request
|
14:51:59
|
<thn> of course
|
14:52:07
|
<thn> that's OSIV
|
14:52:25
|
<thn> session !== transaction
|
14:52:36
|
<rafa> thn: correct
|
14:53:12
|
<rafa> thn: our sessions are supposed to be read only outside of transactions
|
14:54:08
|
<rafa> thn: so nothing should be persisted when you modify it outside of a transaction, but you still need to remember that any modifications done in read only session will be persisted if you commit any transaction :)
|
14:54:14
|
<thn> different issue -- I just wanted to confirm that ""All calls within a session are considered to be on one transaction" is not correct
|
14:55:54
|
<rafa> thn: it's hard to put it simple, see my previous sentence
|
14:56:10
|
<rafa> thn: I think the author had that in mind
|
14:57:28
|
<rafa> thn: the story is that objects are attached to a session outside of a transaction
|
14:57:43
|
<rafa> thn: and Hibernate remembers any modifications to such objects
|
14:58:09
|
<rafa> thn: these modifications will be committed with the next transaction
|
14:59:08
|
<rafa> thn: still following?
|
14:59:23
|
<thn> the last part is generally true
|
15:00:27
|
<rafa> thn: feel free to phrase it better on that page
|
15:01:24
|
<thn> 'attachment' is a function of Session methods (get, list, etc) only irrespective of 'transactions' as within session.beginTransaction 'block''
|
15:03:36
|
<rafa> thn: in other words we don't do anything fancy and everything what applies to JPA applies to our API.
|
15:03:38
|
<thn> anyways, thanks for confirming my understanding about openmrs using 'standard' spring transactional processing
|
15:04:30
|
<rafa> thn: you're welcome
|
15:06:47
|
*** kishoreyekkanti has quit IRC
|
15:08:31
|
<andrea__> rafa, u still there?
|
15:10:38
|
<rafa> andrea__: yes
|
15:12:10
|
<andrea__> hi rafa
|
15:12:25
|
<rafa> andrea__: hi :)
|
15:13:06
|
<andrea__> rafa, I think my Junit test is wrong. I do need to call ConceptService.
|
15:13:32
|
<rafa> andrea__: to test ConceptValidator?
|
15:13:42
|
<andrea__> rafa, will fix and do pull request as soon as I get to office.
|
15:14:31
|
<andrea__> rafa, yes to test ConceptValidator
|
15:15:52
|
<rafa> andrea__: please do pull request even if you think it's not 100% right
|
15:16:18
|
<rafa> andrea__: I can't tell you much without seeing your code :)
|
15:16:19
|
<andrea__> rafa ok got to get to office first
|
15:16:32
|
<rafa> andrea__: sure
|
15:16:42
|
<andrea__> rafa, I got y
|
15:17:03
|
<rafa> andrea__: the thing is that while you're learning it's better to get feedback as soon as possible
|
15:17:44
|
<rafa> andrea__: it makes things easier and faster :)
|
15:17:48
|
<andrea__> rafa, Ok
|
15:33:51
|
*** thn has quit IRC
|
15:37:06
|
*** k4joseph has joined #openmrs
|
15:41:54
|
<k4joseph> assistance: i have run openmrs-standalone jar file and so far am stuck on which user name and password to enter in the openned browser to continue, i have tried the ones i nommaly use on wiki and i have failed, please am requesting for some one's help
|
15:45:05
|
*** rafa has quit IRC
|
15:49:08
|
*** andrea__ has quit IRC
|
15:51:42
|
*** k4joseph has quit IRC
|
15:53:37
|
*** suranga has joined #openmrs
|
15:53:37
|
*** ChanServ sets mode: +v suranga
|
15:55:43
|
*** zard has joined #openmrs
|
16:01:14
|
*** wyclif has quit IRC
|
16:07:06
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 1.1.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=metadatasharing&version=&1.1.1> || OpenMRS Modules: HTML Form Entry Extensions for OpenMRS 1.9 Module 1.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=htmlformentry19ext&version=&1.0> || OpenMRS Modules: Event Module 2.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=event&version=&2.0> || OpenMRS Modules: Event Module 2.0.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=event&version=&2.0.1>
|
16:08:31
|
*** lh has joined #openmrs
|
16:37:09
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Name Phonetics 1.3.6 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=namephonetics&version=&1.3.6>
|
16:42:31
|
*** jordank has joined #openmrs
|
16:49:14
|
*** jkeiper has quit IRC
|
17:17:11
|
*** kishoreyekkanti has joined #openmrs
|
17:33:10
|
*** suranga has quit IRC
|
17:33:51
|
*** wyclif has joined #openmrs
|
17:59:31
|
*** suranga has joined #openmrs
|
17:59:31
|
*** ChanServ sets mode: +v suranga
|
18:01:01
|
*** kavuri has joined #openmrs
|
18:01:21
|
<kavuri> djazayeri: hi
|
18:01:38
|
<djazayeri> hi kavuri
|
18:01:44
|
<kavuri> djazayeri: about starting atomfeed module in tomcat6, apparently the problem seems to be only in tomcat6
|
18:01:48
|
<kavuri> djazayeri: in jetty, it works fine
|
18:02:50
|
<kavuri> djazayeri: any clues on what the problem could be? Memory is not a problem (or so it seems, as I have allocated 1GB to tomcat)
|
18:03:22
|
<djazayeri> kavuri: I have no idea, unfortunately
|
18:03:44
|
<djazayeri> kavuri: I would suggest tweaking your tomcat startup script to allow attaching the remote debugger.
|
18:04:12
|
<kavuri> djazayeri: ok, will do that. Do you know if anyone has tried atomfeed module in tomcat?
|
18:04:16
|
<djazayeri> kavuri: then try what I suggested yesterday: start running it, and after it's at the point where it has hung, attach the debugger, and pause the VM, and see where we're at.
|
18:04:25
|
<kavuri> djazayeri: ok
|
18:04:34
|
<djazayeri> kavuri: I have no idea. I assume that MoTeCH has been using the atom feed module. I'd assume in tomcat.
|
18:04:59
|
<kavuri> djazayeri: is Mike from MoTeCH?
|
18:08:07
|
<djazayeri> kavuri: Mike Seaton is from PIH. (So is Mark Goodrich)
|
18:08:30
|
<djazayeri> kavuri: I don't think anyone from motech is watching the dev lists, else they'd have commented already. Let me ping them directly.
|
18:08:42
|
<kavuri> djazayeri: great! thanks a ton
|
18:13:50
|
*** wyclif has quit IRC
|
18:20:25
|
*** dkayiwa has joined #openmrs
|
18:38:16
|
*** kavuri has quit IRC
|
18:47:10
|
*** applecool has joined #openmrs
|
18:47:10
|
*** ChanServ sets mode: +v applecool
|
18:49:18
|
*** applecool has quit IRC
|
18:53:57
|
*** wyclif has joined #openmrs
|
19:14:11
|
*** suranga has quit IRC
|
19:14:28
|
*** suranga has joined #openmrs
|
19:22:47
|
*** kishoreyekkanti has quit IRC
|
19:25:36
|
*** suranga has quit IRC
|
19:53:52
|
*** zard has quit IRC
|
21:20:02
|
*** mseaton has joined #openmrs
|
21:20:02
|
*** ChanServ sets mode: +v mseaton
|
21:20:04
|
*** mseaton has left #openmrs
|
21:24:11
|
*** dkayiwa has quit IRC
|
21:24:36
|
*** dkayiwa has joined #openmrs
|
21:28:16
|
*** lh has quit IRC
|
22:24:28
|
*** jordank has quit IRC
|
22:25:44
|
*** dkayiwa has quit IRC
|
22:56:47
|
*** nwilkie has joined #openmrs
|