00:17:56
|
*** robbyoconnor has joined #openmrs
|
00:17:56
|
*** ChanServ sets mode: +v robbyoconnor
|
00:33:44
|
*** robbyoconnor has quit IRC
|
00:46:03
|
*** robbyoconnor has joined #openmrs
|
00:46:03
|
*** ChanServ sets mode: +v robbyoconnor
|
00:46:56
|
*** wyclif has joined #openmrs
|
01:06:37
|
*** robbyoconnor has quit IRC
|
01:07:19
|
*** robbyoconnor has joined #openmrs
|
01:07:19
|
*** ChanServ sets mode: +v robbyoconnor
|
01:35:44
|
*** chopin has joined #openmrs
|
02:29:45
|
*** robbyoconnor has quit IRC
|
03:08:45
|
*** eshan has joined #openmrs
|
03:38:28
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Check out the #OMRS12 event schedule on your browser & mobile devices, & list yourself as an attendee: http://t.co/hcShSz8g #OpenMRS <http://twitter.com/OpenMRS/statuses/253697736594034688>
|
04:10:13
|
*** downey has joined #openmrs
|
04:10:13
|
*** ChanServ sets mode: +o downey
|
04:10:13
|
*** OpenMRSBot sets mode: +o downey
|
04:10:25
|
*** downey has quit IRC
|
04:18:59
|
*** djazayeri has joined #openmrs
|
04:18:59
|
*** ChanServ sets mode: +o djazayeri
|
04:28:30
|
<eshan> wyclif : Can I raise a question regarding this ? (only if you are free ) https://tickets.openmrs.org/browse/TRUNK-3611
|
04:33:34
|
*** kishoreyekkanti has joined #openmrs
|
04:40:31
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @Chris_Hackett Thank you for the kind words - we're flattered! <http://twitter.com/OpenMRS/statuses/253713022122618882>
|
04:43:04
|
*** djazayeri has quit IRC
|
05:07:49
|
*** chopin has quit IRC
|
05:09:34
|
*** chopin has joined #openmrs
|
05:42:07
|
*** lh has quit IRC
|
05:42:51
|
*** lh has joined #openmrs
|
07:18:59
|
*** upul` has joined #openmrs
|
07:18:59
|
*** ChanServ sets mode: +v upul`
|
07:22:38
|
*** rafa has joined #openmrs
|
07:22:38
|
*** ChanServ sets mode: +v rafa
|
08:01:16
|
*** fishandwalk has joined #openmrs
|
08:07:32
|
*** kishoreyekkanti has quit IRC
|
08:22:48
|
*** dkayiwa has joined #openmrs
|
08:37:42
|
*** kishoreyekkanti has joined #openmrs
|
08:38:02
|
*** kishoreyekkanti_ has joined #openmrs
|
08:38:37
|
*** kishoreyekkanti has quit IRC
|
08:38:40
|
*** kishoreyekkanti_ has joined #openmrs
|
08:44:35
|
*** dkayiwa has quit IRC
|
09:10:51
|
*** aguid has joined #openmrs
|
09:11:44
|
<aguid> hello, i am adding patients using sql and a php script. The patients show up in the database, but they are not showing up in the user interface. What am I don't wrong?
|
09:11:55
|
*** fishandwalk has quit IRC
|
09:12:43
|
*** dkayiwa has joined #openmrs
|
09:14:14
|
<aguid> hello
|
09:17:25
|
*** aguid has left #openmrs
|
10:23:29
|
*** dkayiwa has quit IRC
|
10:28:43
|
*** rafa has quit IRC
|
10:29:55
|
*** kjoseph has joined #openmrs
|
10:58:41
|
*** james_regen has joined #openmrs
|
10:58:41
|
*** ChanServ sets mode: +v james_regen
|
11:00:54
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: #OpenMRS - Tweet your way to #OMRS12! Let's see photos and stories of your journeys. Use hashtag #OMRS12 <http://twitter.com/OpenMRS/statuses/253799325929455616> || On Twitter: OpenMRS: RT @suranga_kas: Leaving SL tomorrow 4 #omrs12 ! Yayy !!! <http://twitter.com/OpenMRS/statuses/253798718028005376>
|
11:05:57
|
*** kjoseph has quit IRC
|
11:16:07
|
*** suranga has joined #openmrs
|
11:16:07
|
*** ChanServ sets mode: +v suranga
|
11:16:43
|
*** chopin has quit IRC
|
11:30:41
|
*** upul` has quit IRC
|
11:39:00
|
*** kishoreyekkanti_ has quit IRC
|
11:42:26
|
*** piyushmadan has joined #openmrs
|
11:51:29
|
*** kishoreyekkanti has joined #openmrs
|
11:53:18
|
*** eshan has quit IRC
|
12:00:23
|
*** rafa has joined #openmrs
|
12:00:23
|
*** ChanServ sets mode: +v rafa
|
12:03:00
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @reshrams: @OpenMRS Good day fellas..anybody who hv usd registration module pliz urgent help needed.. <http://twitter.com/OpenMRS/statuses/253823725680590848>
|
12:12:38
|
*** dkayiwa has joined #openmrs
|
12:15:28
|
*** djazayeri has joined #openmrs
|
12:15:28
|
*** ChanServ sets mode: +o djazayeri
|
12:25:15
|
*** chopin has joined #openmrs
|
12:26:34
|
*** wyclif has quit IRC
|
13:02:09
|
*** djazayeri has quit IRC
|
13:04:52
|
*** chopin has quit IRC
|
13:14:30
|
*** wyclif has joined #openmrs
|
13:18:50
|
*** djazayeri has joined #openmrs
|
13:18:50
|
*** ChanServ sets mode: +o djazayeri
|
13:19:23
|
*** chopin has joined #openmrs
|
13:23:40
|
*** fishandwalk has joined #openmrs
|
13:58:09
|
*** rafa has quit IRC
|
13:58:46
|
*** chopin has quit IRC
|
14:01:33
|
*** djazayeri has quit IRC
|
14:04:16
|
*** djazayeri has joined #openmrs
|
14:04:16
|
*** ChanServ sets mode: +o djazayeri
|
14:08:10
|
*** kishoreyekkanti has quit IRC
|
14:12:04
|
*** fishandwalk has quit IRC
|
14:12:27
|
*** lh has quit IRC
|
14:13:03
|
*** djazayeri has quit IRC
|
14:17:26
|
*** lh has joined #openmrs
|
14:20:07
|
*** piyushmadan has quit IRC
|
14:23:10
|
*** lh has quit IRC
|
14:36:39
|
*** kishoreyekkanti has joined #openmrs
|
14:38:14
|
*** lh has joined #openmrs
|
14:38:14
|
*** lh has joined #openmrs
|
14:40:31
|
*** suranga has quit IRC
|
14:44:45
|
*** bwolfe has joined #openmrs
|
14:44:45
|
*** ChanServ sets mode: +o bwolfe
|
14:44:59
|
*** fishandwalk has joined #openmrs
|
14:45:48
|
*** djazayeri has joined #openmrs
|
14:45:48
|
*** ChanServ sets mode: +o djazayeri
|
14:50:37
|
*** fishandwalk has quit IRC
|
15:03:38
|
*** harshadura has joined #openmrs
|
15:07:25
|
*** kishoreyekkanti has quit IRC
|
15:17:14
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @jblaya See you soon at #OMRS12 - safe travels! <http://twitter.com/OpenMRS/statuses/253869230737485824>
|
15:41:45
|
*** aguid has joined #openmrs
|
15:43:27
|
<aguid> hello
|
15:44:10
|
<bwolfe> hi aguid
|
15:44:52
|
<aguid> I am adding patients to the database using a php script. The data shows up in the database, but it doesn't show up in the user interface. I checked and the tables and none of them are voided. Any idea what I have been doing wrong?
|
15:47:17
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @jmwogi: @jmwogi #Openmrs 1.9.1 setup works like charm :-) Ready for elegant Household Module transformation in 48hrs <http://twitter.com/OpenMRS/statuses/253876146687586304> || OpenMRS Modules: XForms 4.0.9.7 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=xforms&version=&4.0.9.7>
|
15:47:33
|
<bwolfe> aguid, you added valid names for hte patients too?
|
15:47:59
|
<aguid> bwolfe yes I have
|
15:52:27
|
*** lh has quit IRC
|
16:02:47
|
*** dkayiwa_ has joined #openmrs
|
16:04:46
|
*** dkayiwa has quit IRC
|
16:04:47
|
*** dkayiwa_ is now known as dkayiwa
|
16:23:20
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @downey: #OMRS12 advance team! IND-MSP-NRT-MNL (@ Indianapolis International Airport (IND) w/ 22 others) http://t.co/9Et8qBis <http://twitter.com/OpenMRS/statuses/253886349508239360>
|
16:36:57
|
<aguid> bwolfe, any idea what the problem could be?
|
17:21:25
|
*** harshadura has quit IRC
|
17:27:32
|
*** k9joseph has joined #openmrs
|
17:38:35
|
<bwolfe> aguid, I need more info. can you pastebin your php? or a dump of your patient/person_name table?
|
17:41:16
|
*** jkeiper has joined #openmrs
|
17:41:59
|
<dkayiwa> hi k9joseph
|
17:43:33
|
*** k9joseph has quit IRC
|
17:44:11
|
<aguid> bwolfe, sure give me a minute
|
17:49:58
|
<aguid> bwolfe,here is my php code http://pastebin.com/p3Zysvhi
|
17:51:38
|
<bwolfe> aguid, is your patient insert correct?
|
17:51:51
|
<bwolfe> oh wait, nm
|
17:52:28
|
<bwolfe> aguid, looks right, but I'm guessing at which column names you're inserting to :-p
|
17:52:47
|
<bwolfe> aguid, make sure your openmrs is connecting to that database. you can see in the admin screen --> System Info page
|
17:53:01
|
<bwolfe> aguid, "openmrs_simulated" is what you're inserting to
|
17:54:36
|
<aguid> bwolfe, i am using a separate test database, sorry
|
17:57:56
|
<aguid> bwolfe, thanks for your help
|
18:10:31
|
<prolificgnosis> is there a way to test front end/mvc changes without having to reload module?
|
18:15:50
|
<jkeiper> prolificgnosis, I was just doing this yesterday ... but you won't like the answer
|
18:16:18
|
<jkeiper> prolificgnosis, I ended up finding the JSP as it was expanded into the webapp folder hierarchy and edited it in a text editor
|
18:16:31
|
<jkeiper> prolificgnosis, once it was working right, I copied it back into my IDE
|
18:16:33
|
<jkeiper> :-/
|
18:16:35
|
<prolificgnosis> oh that really sucks
|
18:17:12
|
<prolificgnosis> i'm using jrebel, but i think with the context/classes being reloaded on deployment, it can't dynamically reload anything
|
18:17:15
|
<prolificgnosis> kind of a mess
|
18:18:29
|
<jkeiper> prolificgnosis, that's what i was worried about ... then never got around to trying
|
18:18:54
|
<jkeiper> prolificgnosis, i use a standalone for development ... better than jetty mio
|
18:18:57
|
<jkeiper> s/mio/imho
|
18:19:12
|
<jkeiper> djazayeri has been doing some module dev, might have more insight
|
18:19:47
|
<prolificgnosis> hmmm i'll ask him when he gets back i guess
|
18:20:05
|
<prolificgnosis> is there a way to just deploy omod
|
18:21:05
|
<jkeiper> prolificgnosis, there are so many hooks during the module startup process that it's best to let openmrs do it ... and i know it takes some time to load, but on my machine (with 4GB RAM) it doesn't take very long (with a standalone)
|
18:21:06
|
<prolificgnosis> by itelf
|
18:21:17
|
<prolificgnosis> yeah
|
18:21:20
|
<jkeiper> prolificgnosis, you mean run it in an environment?
|
18:21:22
|
<prolificgnosis> i mean it only takes a few seconds
|
18:21:24
|
<prolificgnosis> yeah
|
18:21:43
|
<prolificgnosis> like just deploy omod as a standalone war or something
|
18:22:11
|
<jkeiper> prolificgnosis, you could write a standalone module in addition to the omod and use it (like a GUI) to test the code in your api
|
18:23:34
|
*** sgithens has joined #openmrs
|
18:23:46
|
<prolificgnosis> meh i can test that code with spring unit
|
18:23:54
|
<prolificgnosis> ok well thanks
|
18:24:03
|
<prolificgnosis> just wanted to make sure there wasn't something I overlooked
|
18:24:05
|
<jkeiper> yeah, sorry ... if you find an answer it will benefit many of us
|
18:24:06
|
<jkeiper> :-)
|
18:24:16
|
<jkeiper> i honestly thought jrebel might be a good choice
|
18:24:19
|
<jkeiper> but haven't tried it
|
18:24:34
|
<prolificgnosis> yeah i have it, but it locks files and causes all sorts of craziness
|
18:24:39
|
<prolificgnosis> its wors fine for openmrs code
|
18:24:44
|
<prolificgnosis> works*
|
18:25:04
|
<jkeiper> hrm, perhaps there's a mode that would be better ... dunno enough about it
|
18:25:24
|
<jkeiper> prolificgnosis, sgithens is also lamenting the same issues
|
18:25:36
|
<prolificgnosis> nah, i think class loader and context loader pretty much screws up jrebel
|
18:25:45
|
<jkeiper> ah
|
18:29:02
|
<dkayiwa> hi jkeiper
|
18:29:17
|
<dkayiwa> are u the one who reported this? FORM-140
|
18:29:24
|
<dkayiwa> !ticket FORM-140
|
18:29:25
|
<OpenMRSBot> dkayiwa: [#FORM-140] Allergy (concept) search widget improperly formats selected concept names - OpenMRS JIRA - https://tickets.openmrs.org/browse/FORM-140
|
18:29:37
|
<jkeiper> dkayiwa, heyya ... yes
|
18:29:45
|
<jkeiper> as given to me by ada
|
18:29:55
|
<dkayiwa> jkeiper: did u try the newest module version?
|
18:30:39
|
<jkeiper> dkayiwa, 1.8.2-compatible?
|
18:30:51
|
<dkayiwa> jkeiper: yes
|
18:31:13
|
<jkeiper> dkayiwa, what version of formentry?
|
18:31:41
|
<jkeiper> 4.5.9.4?
|
18:31:43
|
<dkayiwa> jkeiper: i see the pom having 5.0.7-SNAPSHOT
|
18:32:07
|
<jkeiper> that is not 1.8.2-compatible
|
18:32:09
|
<dkayiwa> jkeiper: so i thought a newer version like 5.0.??
|
18:32:20
|
<dkayiwa> jkeiper: oh i see
|
18:33:14
|
<jkeiper> the issue is with dojo vs jquery widgets i think
|
18:33:16
|
<dkayiwa> jkeiper: so does that mean iam not to use trunk to fix that?
|
18:33:41
|
<jkeiper> you can, but that ticket will hopefully require backporting to 1.7-compatible branch
|
18:33:55
|
<dkayiwa> jkeiper: ok
|
18:35:33
|
*** aguid has quit IRC
|
18:37:01
|
*** andreapat has joined #openmrs
|
18:38:01
|
*** lh has joined #openmrs
|
18:38:55
|
<jkeiper> dkayiwa, if you wanted to make the code in 5.0.x work in 1.8.2, we would gladly upgrade ;-)
|
18:39:27
|
<dkayiwa> jkeiper: :)
|
18:42:35
|
*** andreapat has quit IRC
|
18:42:46
|
*** lh has quit IRC
|
18:43:18
|
*** andreapat has joined #openmrs
|
18:44:01
|
*** andreapat has quit IRC
|
18:44:52
|
*** andrea_ has joined #openmrs
|
18:49:46
|
<andrea_> bwolfe, u there?
|
18:50:01
|
<bwolfe> yep
|
18:50:21
|
<andrea_> bwolfe, hi
|
18:50:55
|
<andrea_> bwolfe, want to verify changes for TRUNK 3321 1.8.x
|
18:52:26
|
<andrea_> bwolfe, in 1.8.x changed ValidateUtil.validate to check for null object
|
18:53:21
|
<bwolfe> right, same as the AdministrationService.validate method in master
|
18:53:41
|
<andrea_> bwolfe, and added Junit test in ValidateUtilTest - no @should in 1.8.x, right?
|
18:54:34
|
*** lh has joined #openmrs
|
18:54:39
|
<bwolfe> yes, you put the @should on ValidateUtil.validate in 1.8.x
|
18:55:45
|
<andrea_> bwolfe, actually had already done that - so only 2 classes changed in 1.8.x, right?
|
18:57:45
|
<bwolfe> andrea_, if all tests still pass, then yes
|
18:59:07
|
*** rafa has joined #openmrs
|
18:59:07
|
*** ChanServ sets mode: +v rafa
|
18:59:33
|
<prolificgnosis> is there a config file (or something) that maps your jsps to URI? I can't seem to access them directly
|
19:02:31
|
*** james_regen has left #openmrs
|
19:04:08
|
<bwolfe> prolificgnosis, openmrs-servlet.xml maps some
|
19:04:20
|
<bwolfe> prolificgnosis, others are done with annotations in the java/controller class
|
19:04:45
|
<bwolfe> !seen cpower
|
19:04:45
|
<OpenMRSBot> bwolfe: cpower was last seen in #openmrs 1 day, 4 hours, 55 minutes, and 34 seconds ago: <cpower> !scrumoff
|
19:05:46
|
<bwolfe> andrea_, look into https://tickets.openmrs.org/browse/TRUNK-3744 as your next ticket
|
19:06:08
|
<bwolfe> andrea_, and when you are ready and have pushed your tickets, be sure to comment somewhere or create a pull request so that we can go review it for you
|
19:07:03
|
<andrea_> bwolfe, ok
|
19:07:25
|
*** cpower has joined #openmrs
|
19:07:34
|
*** lhawthor_ has joined #openmrs
|
19:07:52
|
<prolificgnosis> bwolfe, returning "redirect:test.jsp" when a test.jsp is sitting in my module's web app directory doesn't seem to work
|
19:07:52
|
<cpower> I'm told I'm a horrible PM and a slacker...and so I should get in here quickly and hold a scrum
|
19:08:03
|
<prolificgnosis> I've also tried @RequestMapping
|
19:08:28
|
<cpower> So on that note, let's begin!
|
19:08:29
|
<jkeiper> prolificgnosis, you need "redirect:test.htm"
|
19:08:33
|
<jkeiper> or test.form
|
19:08:35
|
<jkeiper> or test.list
|
19:08:46
|
<cpower> !scrumon cpower
|
19:08:46
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
19:08:56
|
<prolificgnosis> and do i ned an actual test.html in my webapp folder?
|
19:09:05
|
<prolificgnosis> test.htm*
|
19:09:21
|
<cpower> Order: bwolfe, djazayeri, rafa, andrea_, dkayiwa, wyclif
|
19:09:53
|
<bwolfe> prolificgnosis, no, test.jsp is the filename, test.htm is the url path
|
19:10:01
|
<bwolfe> name the file test.jsp
|
19:10:06
|
<bwolfe> cpower, welcome
|
19:10:09
|
*** lhawthor_ has quit IRC
|
19:10:42
|
<bwolfe> Wednesday
|
19:10:42
|
<bwolfe> University call
|
19:10:42
|
<bwolfe> rg conference
|
19:10:42
|
<bwolfe> clean up META-281/META-282 after its merges
|
19:10:42
|
<bwolfe> Thursday
|
19:10:43
|
<bwolfe> emails
|
19:10:45
|
<bwolfe> dev call
|
19:10:49
|
<bwolfe> clean up META-281/META-282 after its merges
|
19:10:51
|
<bwolfe> created truck ticket
|
19:10:53
|
<bwolfe> curated 2 tickets
|
19:10:55
|
<bwolfe> another MDS ticket?
|
19:11:17
|
<rafa> truck ticket? :D
|
19:11:54
|
<bwolfe> haha, yes, the truck tickets haul around the trunks
|
19:12:11
|
<cpower> djazayeri you are next!
|
19:13:06
|
<cpower> and you are skipped!
|
19:13:14
|
<cpower> rafa hi
|
19:13:20
|
<rafa> cpower: hi
|
19:13:22
|
<rafa> Today (just half day, I needed to see an optician and my eyes were not usable after that :P):
|
19:13:22
|
<rafa> * Reviewed and merged sprint tickets
|
19:13:22
|
<rafa> No blockers.
|
19:13:22
|
<rafa> Notification for sprinters: You're very welcome to merge pull requests yourself. I'll be reviewing them post merge too.
|
19:13:47
|
<cpower> andrea go!
|
19:13:50
|
<dkayiwa> rafa: thats sweet!!! :D
|
19:14:26
|
<wyclif> rafa, ok i will do that for my tickets since they some depend on each other
|
19:15:02
|
<cpower> Andrea...
|
19:15:12
|
<andrea_> ok
|
19:15:34
|
<andrea_> Today
|
19:15:34
|
<andrea_> Dev call
|
19:15:34
|
<andrea_> Added TRUNK-3321 changes to 1.8.x
|
19:15:34
|
<andrea_> testing
|
19:15:34
|
<andrea_> New ticket TRUNK-3744
|
19:15:34
|
<andrea_> Friday
|
19:15:36
|
<andrea_> Work on ticket TRUNK-3744
|
19:15:38
|
<andrea_> No blockers
|
19:15:59
|
<dkayiwa> Committed: Java 7 Compatibility Issue - XFRM-57
|
19:15:59
|
<dkayiwa> Committed: Allergy (concept) search widget improperly formats selected concept names - FORM-140
|
19:15:59
|
<dkayiwa> Dev Call
|
19:15:59
|
<dkayiwa> Working on: Changed by information not updated when concept names/synonyms are edited, added or removed - TRUNK-3337
|
19:16:00
|
<dkayiwa> No Blockers
|
19:16:21
|
<wyclif> Wednesday:
|
19:16:21
|
<wyclif> University call
|
19:16:21
|
<wyclif> META-256 - Subscribe concept dictionary
|
19:16:21
|
<wyclif> Was out of office to go replace my malfunctioning RG access card
|
19:16:21
|
<wyclif> META-259 - Friendly subscription URL
|
19:16:22
|
<wyclif> design call
|
19:16:24
|
<wyclif> Thursday:
|
19:16:26
|
<wyclif> META-257 - Check for concept dictionary updates
|
19:16:28
|
<wyclif> dev call
|
19:16:30
|
<wyclif> META-287 - Unsubscribe dictionary
|
19:16:32
|
<wyclif> META-288 - Unpublish dictionary
|
19:16:34
|
<wyclif> Start on META-249 - Publish any version of package header
|
19:16:36
|
<wyclif> Friday:
|
19:16:38
|
<wyclif> Travelling to manilla
|
19:16:40
|
<wyclif> Blockers: None
|
19:17:30
|
<cpower> and that's how we play our game
|
19:17:34
|
<cpower> !scrumoff
|
19:17:34
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
19:20:30
|
<jkeiper> anyone familiar with reporting module care to take a look at an error stacktrace? http://pastebin.com/GUGFyk8Y
|
19:21:01
|
<jkeiper> happens when clicking admin -> manage report definitions -> report designs
|
19:21:02
|
<bwolfe> dkayiwa, rafa, when do you leave? tomorrow? saturday? monday?
|
19:21:20
|
<rafa> bwolfe: tomorrow in the evening
|
19:24:54
|
<andrea_> bwolfe, forgot to ask - are scrums happening next week?
|
19:25:56
|
<dkayiwa> bwolfe: sunday
|
19:26:31
|
<dkayiwa> andrea_: no
|
19:26:52
|
<bwolfe> andrea_, they will be just you and cpower
|
19:27:11
|
<dkayiwa> :)
|
19:29:37
|
<andrea_> bwolfe, don't think cpower and I will have a lot to scrum about
|
19:29:59
|
<bwolfe> andrea_, you will
|
19:30:04
|
<bwolfe> and we read logs. :-)
|
19:30:20
|
<jkeiper> i can scrum with y'all
|
19:30:25
|
<jkeiper> even though it'll all be AMPATH-based
|
19:30:30
|
<jkeiper> with a few concept sharing tickets
|
19:30:33
|
<jkeiper> interspersed
|
19:30:45
|
<andrea_> bwolfe, and all of you - wish I were going - someone has to talk to Merck - you all have a safe trip and tell me all about it when you get back
|
19:30:54
|
<cpower> Andrea you drew the short straw this year, don't worry it will be someone else next year. BUT this year you must do 5 times the work next week to make up for these slackers.
|
19:31:02
|
<jkeiper> heh
|
19:31:06
|
<jkeiper> andrea_, i'm not going either!
|
19:31:53
|
<cpower> Hey Andrea do you know C++ :-)
|
19:32:15
|
<cpower> if you do...boy do I have a sprint for you!
|
19:32:42
|
<andrea_> cpower, afraid I'm rusty on C++ - never did that much of it
|
19:33:01
|
<cpower> It's called do cpower's homework for the semester :-)
|
19:33:31
|
<andrea_> cpower, if you have a question I could give it a shot
|
19:33:51
|
<cpower> I have a feeling anyone with any real coding knowledge can do this stuff. It's literally the Intro class.
|
19:34:12
|
<andrea_> cpower, ah a C++ class - what's the question
|
19:35:24
|
<cpower> don't worry about it now, focus on what you should be doing. I'll ask you when I get really confused.
|
19:35:56
|
*** sgithens has quit IRC
|
19:36:04
|
<jkeiper> heh
|
19:39:24
|
<andrea_> cpower, ok
|
19:55:57
|
*** lh has quit IRC
|
19:57:39
|
<andrea_> bwolfe, did you see my pull request for TRUNK-3321 (trunk)
|
19:58:52
|
<andrea_> bwolfe, about to do same for 1.8.x
|
19:59:11
|
<prolificgnosis> must the context be authenticated in my module to execute a POST?
|
19:59:22
|
<prolificgnosis> i'm gettng a HttpRequestMethodNotSupportedException
|
19:59:30
|
<prolificgnosis> when posting a form within my module
|
19:59:43
|
<prolificgnosis> looks like ForcePasswordChangeFilter.doFilter
|
19:59:50
|
<prolificgnosis> fails on isAuthenticated
|
20:07:12
|
<bwolfe> andrea_, no
|
20:07:24
|
<bwolfe> andrea_, please comment on the tickets with your pull request link whenever you do a new pull request
|
20:11:51
|
<wyclif> bwolfe, when i do: git push upstream master
|
20:11:59
|
<andrea_> bwolfe, I did comment on commit - is that what you mean?
|
20:12:04
|
<wyclif> bwolfe, i get everything is up to date
|
20:12:22
|
<bwolfe> andrea_, no, comment on the ticket. notifications are sent out to all people on the ticket
|
20:12:33
|
<bwolfe> wyclif, are you on your branch?
|
20:12:47
|
<wyclif> bwolfe, yeah
|
20:12:49
|
<bwolfe> wyclif, maybe its saying that because you've already pushed to origin?
|
20:13:19
|
<wyclif> bwolfe, the thing is that i a had already pushed my code to github into my fork
|
20:13:40
|
<wyclif> bwolfe, now i want to push it to upstream since rafa said i can push directly
|
20:14:10
|
<bwolfe> wyclif, yeah, not sure. when I push to upstream I always push to it first, then push to my fork (origin)
|
20:14:32
|
<rafa> the order doesn't matter
|
20:14:37
|
<rafa> wyclif: what is the problem?
|
20:15:25
|
<wyclif> rafa, i want to merge my code to master that i had already pushed to origin in my forl
|
20:15:25
|
<rafa> wyclif: do you get some error?
|
20:15:28
|
<wyclif> rafa, i want to merge my code to master that i had already pushed to origin in my fork
|
20:15:47
|
<wyclif> rafa, i get a message that everything is already up to date
|
20:15:55
|
*** sgithens has joined #openmrs
|
20:16:02
|
<rafa> wyclif: so I assume you haven't merged to master yet
|
20:16:07
|
<rafa> wyclif: checkout master
|
20:16:11
|
<rafa> wyclif: do merge
|
20:16:23
|
<rafa> wyclif: then push to upstream and origin
|
20:17:20
|
<rafa> wyclif: follow instructions from https://wiki.openmrs.org/display/docs/Merging start with point 9
|
20:19:52
|
<andrea_> bwolfe, didn't know that
|
20:20:38
|
<wyclif> rafa, done, thanks!
|
20:20:48
|
<rafa> wyclif: np
|
20:25:31
|
<dkayiwa> hi prolificgnosis
|
20:29:49
|
<andrea_> bwolfe, at https://tickets.openmrs.org/browse/TRUNK-3321 - not sure how to add comment
|
20:30:04
|
<prolificgnosis> hey
|
20:30:05
|
<bwolfe> andrea_, are you logged in?
|
20:30:10
|
<prolificgnosis> dkayiwa
|
20:30:30
|
<dkayiwa> prolificgnosis: did you fix yo problem?
|
20:31:00
|
<prolificgnosis> no, just a sec, will post to pastebin
|
20:31:24
|
<andrea_> bwolfe, logged in where- the Merck network?
|
20:31:34
|
<bwolfe> andrea_, the tickets/jira site!
|
20:31:49
|
<prolificgnosis> http://pastebin.com/CrbgJRT2
|
20:32:02
|
<andrea_> bwolfe, ok I see login
|
20:32:46
|
<andrea_> bwolfe, now I am
|
20:35:42
|
<andrea_> bwolfe, can you see my comment?
|
20:36:39
|
<bwolfe> andrea_, yes, but I don't see a link to your pull request in that comment
|
20:36:45
|
<andrea_> bwolfe, didn't do comment on TRUNK-3701 either but did pull request - thought it was pull that alerted you that I was ready
|
20:37:23
|
<bwolfe> both a pull request and a ticket comment alert me. but both are required.
|
20:39:12
|
<andrea_> bwolfe, are there instructions on this part in the wiki - sorry, didn't know about this
|
20:40:49
|
<bwolfe> andrea_, its probably in random places on the wiki
|
20:40:59
|
<bwolfe> andrea_, I just added it ot the "Submit the code" section on https://wiki.openmrs.org/display/docs/Using+Git
|
20:41:06
|
<prolificgnosis> dkayiwa: any idea?
|
20:44:22
|
<dkayiwa> prolificgnosis: looking.....
|
20:46:32
|
<dkayiwa> prolificgnosis: were you trying to do a POST to your controller?
|
20:47:38
|
<prolificgnosis> yeah
|
20:47:52
|
<dkayiwa> prolificgnosis: can you pastebin that controller?
|
20:48:31
|
* bwolfe waits for andrea_ to edit her ticket comments with links to her pull requests
|
20:48:55
|
<prolificgnosis> http://pastebin.com/uLDkBH8H
|
20:50:19
|
<dkayiwa> prolificgnosis: so how are you posting to it to get this error?
|
20:50:53
|
<prolificgnosis> <form action="manage.form?myValue=5" method="post">
|
20:51:31
|
<dkayiwa> prolificgnosis: manageStuff?
|
20:51:33
|
<andrea_> bwolfe, still trying to figure this out - is this Team->create patch?
|
20:51:44
|
<prolificgnosis> just a uri
|
20:51:46
|
<bwolfe> andrea_, what are you trying to figure out?
|
20:51:48
|
<prolificgnosis> shouldn't matter
|
20:52:04
|
<prolificgnosis> you see the requestMapper in the class, right
|
20:52:13
|
<andrea_> bwolfe, where/what is link to code?
|
20:52:26
|
<dkayiwa> prolificgnosis: so the controller you have pastebined is not exactly what you have?
|
20:53:03
|
<prolificgnosis> yeah it is
|
20:53:12
|
<prolificgnosis> scroll down to line 33
|
20:53:19
|
<dkayiwa> prolificgnosis: pastebin the jsp too
|
20:54:11
|
<prolificgnosis> http://pastebin.com/6Y32f0EH
|
20:54:27
|
<prolificgnosis> its the same as what i pasted you, the only relevant line is the form tag, no?
|
20:54:35
|
*** jkeiper has quit IRC
|
20:55:34
|
<dkayiwa> prolificgnosis: is "manageStuff" the same as "manage"?
|
20:56:23
|
<prolificgnosis> ohhhhh
|
20:56:32
|
*** cpower has quit IRC
|
20:56:34
|
<bwolfe> andrea_, what do you mean link to code? I said link to your pull request. after you click "pull request" in github.com, look in the url bar, copy that
|
20:57:34
|
<prolificgnosis> no that didn't work
|
20:57:47
|
<prolificgnosis> manangeStuff is the uri
|
20:57:50
|
<prolificgnosis> manage.jsp is the page
|
20:58:32
|
<dkayiwa> prolificgnosis: how does it know that manangeStuff points to manage?
|
20:58:58
|
<prolificgnosis> the requestMapper annotation in the class
|
20:59:13
|
<dkayiwa> prolificgnosis: in which class?
|
21:00:21
|
<prolificgnosis> i assumed the parameter to the requestMapper is unique
|
21:01:14
|
<dkayiwa> prolificgnosis: so should i take it that when its unique, it means manangeStuff points to manage?
|
21:01:28
|
<prolificgnosis> manage is an htm
|
21:01:31
|
<prolificgnosis> .htm file
|
21:01:42
|
<prolificgnosis> that's the current page that the form lives in
|
21:02:01
|
<prolificgnosis> i'd like to post to 'manageStuff.form?param=5'
|
21:02:15
|
<prolificgnosis> manageStuff.form is mapped via requestMapped in my controller
|
21:02:26
|
<prolificgnosis> so when form is posted, spring should resolve to that method
|
21:02:51
|
<dkayiwa> prolificgnosis: so do you mean that manageStuff.form resolves to manage.jsp?
|
21:03:10
|
<prolificgnosis> i don't believe manageStuff.form resolves to anything
|
21:03:23
|
<dkayiwa> prolificgnosis: so what is it for?
|
21:03:57
|
<prolificgnosis> i assumed that its just a uri and I could make it "goEatPinkMarshMellows.form" and so long as i have a requestMapping of 'goEatPinkMarshMellows.form" spring should direct request to that method
|
21:04:21
|
<prolificgnosis> if i remove the annotation, how will the servlet direct the request ?
|
21:04:56
|
<prolificgnosis> i could change it of course, but change it to what?
|
21:05:24
|
<prolificgnosis> if i make it manage.form (the name of the file) the method will be called on page load
|
21:05:55
|
<dkayiwa> prolificgnosis: i am trying to refresh my memory a bit :)
|
21:06:09
|
<prolificgnosis> that's fine, so am I, its been 2.5 years since I used spring
|
21:06:15
|
<prolificgnosis> was in the JBOSS seam world for quite some time
|
21:08:45
|
<dkayiwa> prolificgnosis: my understanding was that your action should be manageStuff.form :)
|
21:08:55
|
<prolificgnosis> right
|
21:09:19
|
<prolificgnosis> are you saying that the param stuff won't work?
|
21:09:20
|
<dkayiwa> prolificgnosis: instead of manage.form
|
21:09:21
|
<prolificgnosis> cause it should
|
21:09:46
|
<dkayiwa> prolificgnosis: because you have @RequestMapping(value="/module/rls/manageStuff.form"
|
21:09:47
|
<prolificgnosis> yeah i changed that
|
21:09:53
|
<prolificgnosis> testing
|
21:09:55
|
<dkayiwa> prolificgnosis: instead of @RequestMapping(value="/module/rls/manage.form"
|
21:10:31
|
*** sgithens has quit IRC
|
21:10:40
|
<bwolfe> andrea_, https://github.com/openmrs/openmrs-core/pulls/andreapat
|
21:10:44
|
<OpenMRSBot> <http://ln-s.net/$vEw> (at github.com)
|
21:11:15
|
<prolificgnosis> oh
|
21:11:18
|
<prolificgnosis> hmm let me change too
|
21:19:14
|
*** wyclif has quit IRC
|
21:19:35
|
<prolificgnosis> so i think the action should have manageStuff.form and the controller should have openmrs/module/rls/manageStuff.form'
|
21:19:49
|
<dkayiwa> prolificgnosis: thats what i knew :)
|
21:20:08
|
<dkayiwa> prolificgnosis: without openmrs prefix :)
|
21:21:27
|
*** wyclif has joined #openmrs
|
21:21:59
|
<prolificgnosis> ok thanks
|
21:24:55
|
*** bwolfe has quit IRC
|
21:27:46
|
*** wyclif has quit IRC
|
21:28:23
|
*** dkayiwa_ has joined #openmrs
|
21:30:50
|
*** dkayiwa has quit IRC
|
21:30:50
|
*** dkayiwa_ is now known as dkayiwa
|
22:33:42
|
<andrea_> bwolfe, o
|
22:39:18
|
*** dkayiwa has quit IRC
|
22:39:25
|
*** rafa has quit IRC
|
22:59:24
|
*** lh has joined #openmrs
|