| 00:14:22 | *** wyclif has joined #openmrs |
| 01:04:25 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Just 1 week until the start of #OMRS12 - #OpenMRS community, pack your bags! http://t.co/yTUGJOdb <http://twitter.com/OpenMRS/statuses/252935942237741056> |
| 01:14:13 | *** djazayeri has quit IRC |
| 01:16:51 | *** chopin has joined #openmrs |
| 01:41:26 | *** djazayeri has joined #openmrs |
| 01:41:26 | *** ChanServ sets mode: +o djazayeri |
| 02:04:46 | *** bwolfe has joined #openmrs |
| 02:04:46 | *** ChanServ sets mode: +o bwolfe |
| 02:46:26 | *** Minakshi has joined #openmrs |
| 03:09:00 | *** eshan has joined #openmrs |
| 04:13:03 | *** djazayeri has quit IRC |
| 04:24:50 | <eshan> bwolfe: I am esudharaka. I have a small problem regarding this. If you are free I can ask it here |
| 04:26:04 | <eshan> https://tickets.openmrs.org/browse/TRUNK-3734 |
| 04:27:25 | *** bwolfe has quit IRC |
| 04:34:45 | *** upul` has joined #openmrs |
| 04:34:45 | *** ChanServ sets mode: +v upul` |
| 06:58:41 | *** suranga has joined #openmrs |
| 06:58:41 | *** ChanServ sets mode: +v suranga |
| 07:29:57 | *** suranga has quit IRC |
| 07:30:15 | *** suranga has joined #openmrs |
| 07:36:49 | *** Dodo_ has joined #openmrs |
| 07:37:14 | <Dodo_> hello |
| 07:37:22 | <Dodo_> friends |
| 07:37:31 | <Dodo_> how are you all |
| 07:37:32 | <Dodo_> ? |
| 07:40:56 | *** rafa has joined #openmrs |
| 07:40:56 | *** ChanServ sets mode: +v rafa |
| 07:43:20 | *** dkayiwa has joined #openmrs |
| 08:22:21 | *** Dodo_ has quit IRC |
| 08:22:21 | *** upul` has quit IRC |
| 08:55:00 | <eshan> dkayiwa: Can I raise a small question about openmrs api ? |
| 08:55:10 | <dkayiwa> eshan: ok |
| 08:56:25 | <eshan> dkayiwa: Currently I am working on this issue... https://tickets.openmrs.org/browse/TRUNK-3734 |
| 08:56:44 | <eshan> I have completed the source and not its time for junit |
| 08:57:50 | <dkayiwa> ok |
| 08:58:33 | <eshan> as far as I know when we execute >>>> User user = Context.getAuthenticatedUser(); through test cases it gives a admin user. I wanna return a specific user from this. How can I configure it ? |
| 08:59:15 | <dkayiwa> eshan: you can use Context.setAuthenticatedUser |
| 09:00:27 | <eshan> dkayiwa: There is no such method definition :( |
| 09:01:37 | <dkayiwa> eshan: use Context.authenticate(username, password) |
| 09:05:12 | <eshan> dkayiwa: You mean if we authenticate a particular user in Junit test case >> and in the service method once it execute the Context.getAuthenticatedUser() it returns the same user we authenticated in the junit. Is it ? |
| 09:05:24 | <dkayiwa> eshan: yes |
| 09:05:45 | <eshan> dkayiwa: thanks |
| 09:20:41 | <eshan> dkayiwa: we should give an unencrypted password ? but in test data xml files we can get only encrypted ones? |
| 09:28:47 | <dkayiwa> eshan: yes you should give pass in the method an unencrypted password |
| 09:29:14 | <dkayiwa> eshan: in that dataset, you put the equivalent salt and encrypted password |
| 09:30:02 | <dkayiwa> eshan: you can just use your installed openmrs instance, create a user, and the just copy the generated salt and password from the database to your unit test dataset file |
| 09:30:08 | <dkayiwa> eshan: does that make sense? |
| 09:32:42 | <eshan> dkayiwa: I dont understand generated salt ? Is it the unencrypted password ? |
| 09:33:06 | <dkayiwa> eshan: salt is used when encrypting the password |
| 09:33:28 | <dkayiwa> eshan: so it is not the unencrypted password :) |
| 09:34:30 | <eshan> ah..kind of a key...Then the easiest way to create ac account with a know credentials as you mentioned :) |
| 09:34:45 | <dkayiwa> eshan: :) |
| 09:41:08 | *** shortend has joined #openmrs |
| 09:51:38 | <shortend> I'm trying to make use of the fieldGen tag to render form fields for arbitrary attribute types. |
| 09:52:13 | <shortend> Is there a way to get a question concept field to render as a <select> instead of a jQuery autocomplete field? |
| 09:52:33 | <shortend> ... like it would typically render on the Edit Person form. |
| 09:56:05 | <dkayiwa> shortend: are you talking of when type="org.openmrs.Concept"? |
| 09:56:48 | <shortend> Yes. |
| 09:57:47 | <shortend> dkayiwa: Sorry... Yes. |
| 09:57:49 | <dkayiwa> shortend: so you want the entire concept list (huge list) in a drop down? |
| 09:59:39 | <shortend> dkayiwa: I'm implementing something similar to the PersonAttributeType, so I was hoping to get all of the answers for a particular question concept in a drop-down list... |
| 10:03:16 | <shortend> I tried to follow what was being done in the editPersonInfo.jsp, but I'm automatically getting the autocomplete field instead of a select box. |
| 10:03:42 | <dkayiwa> shortend: do you mean the editPersonInfo.jsp already has what you want? |
| 10:05:42 | <shortend> Well, the form generated by editPersonInfo.jsp basically has what I want. If I create a PersonAttributeType with format "org.openmrs.Concept" and give it the proper foreignKey, it will show up in the form as a drop-down box. |
| 10:07:32 | <dkayiwa> shortend: looking at it now ... |
| 10:20:57 | <dkayiwa> shortend: can i see how your jsp fieldgen looks like? |
| 10:30:53 | <dkayiwa> hi rafa |
| 10:31:00 | <rafa> dkayiwa: hi |
| 10:31:04 | <dkayiwa> !ticket META-274 |
| 10:31:06 | <OpenMRSBot> dkayiwa: [#META-274] HTML form entry forms not working on MDS 1.0.9 and openmrs 1.9.1 - OpenMRS JIRA - https://tickets.openmrs.org/browse/META-274 |
| 10:31:29 | <dkayiwa> rafa: as per the quick win, do you mean i should just skip (not import) tags? |
| 10:32:09 | <rafa> dkayiwa: have you reproduced it in a test? |
| 10:32:15 | <shortend> dkayiwa: <openmrs:fieldGentype="${attrType.format}"formFieldName="${attrType.name}"val=""parameters="optionHeader=[blank]|showAnswers=${attrType.foreignKey}|isNullable=false"/> |
| 10:32:24 | <dkayiwa> rafa: let me do that :) |
| 10:33:53 | <dkayiwa> shortend: what is the data type for the concept you are passing in ? |
| 10:34:38 | <shortend> Datatype is Coded |
| 10:35:02 | <dkayiwa> shortend: does it have the coded answers? |
| 10:35:24 | <shortend> Yes, I've assigned it two coded answers. |
| 10:38:47 | <dkayiwa> shortend: when you click in the autocomplete textbox, doesn't it drop down with your answers? |
| 10:41:45 | <shortend> dkayiwa: It might. I was just hoping to get a select element because I want to use the output as an AJAX partial. |
| 10:42:18 | <dkayiwa> shortend: it will only show the drop down on gaining focus |
| 10:43:12 | <dkayiwa> shortend: and the drop down will have the coded answers |
| 10:43:55 | <shortend> dkayiwa: OK... using the jQuery UI autocomplete, right? |
| 10:44:04 | <dkayiwa> shortend: YES |
| 10:45:11 | <shortend> dkayiwa: Alright. Thanks for the help! |
| 10:45:25 | <dkayiwa> shortend: hahahaha. i wonder what help i have done :) |
| 10:46:47 | <shortend> dkayiwa: Well, it's nice to get an answer, even if it's not the one I wanted to hear. I'll figure something out. |
| 10:47:11 | <dkayiwa> shortend: :D |
| 10:57:26 | *** suranga has quit IRC |
| 10:57:46 | *** suranga has joined #openmrs |
| 11:04:57 | *** k6joseph has joined #openmrs |
| 11:06:51 | <dkayiwa> hi k6joseph |
| 11:07:55 | <k6joseph> hi dkayiwa |
| 11:08:12 | <dkayiwa> k6joseph: which irc client are you using? |
| 11:08:45 | <suranga> hi rafa , I'd like to discuss META -243, if possible... |
| 11:08:52 | <rafa> suranga: hi |
| 11:09:06 | <rafa> suranga: sure |
| 11:09:09 | <suranga> rafa, sorry for the delay in getting this done... |
| 11:09:30 | <rafa> suranga: np |
| 11:09:41 | <suranga> rafa, i was looking at your comment, where you say ... |
| 11:09:42 | <suranga> "Can you please quickly investigate if xstream can be configured to skip this field if it is null? I don't want it to appear in xml so that packages exported with 1.1 can still be imported to 1.0.10. It may require writing some Converter. Don't spend too much time on this. It's not a must." |
| 11:10:23 | <suranga> rafa, im an xstream noob, so i was trying this out... |
| 11:10:52 | <suranga> rafa, and I found this on stackoverlow - "According to XStream's documentation and mailing list, null values are not included in the marshaling output---perhaps as a convention." |
| 11:11:23 | <k6joseph> am using: #OpenMRS on irc.freenode.net |
| 11:11:27 | <rafa> suranga: have you verified that? |
| 11:11:41 | <rafa> suranga: can you see incrementalVersion in xml if it's null? |
| 11:12:10 | <suranga> rafa, um.. I wanted to check if this is right, since I guessed that you are the expert :) |
| 11:12:23 | <suranga> rafa, I'll check the unit test, and see what I can find :) |
| 11:12:36 | <rafa> suranga: I don't know that :) |
| 11:12:43 | *** james_regen has joined #openmrs |
| 11:12:43 | *** ChanServ sets mode: +v james_regen |
| 11:12:58 | <rafa> suranga: it's why I asked you to check |
| 11:13:23 | <rafa> suranga: just export a package and see if it's there |
| 11:13:28 | <dkayiwa> k6joseph: did you see the windows IRC clients that you need to install as listed on the openmrs IRC page? |
| 11:13:31 | <rafa> suranga: very simple |
| 11:13:49 | <k6joseph> it is: #OpenMRS on irc.freenode.net please dkayiwa |
| 11:14:10 | <dkayiwa> k6joseph: that is not an IRC client |
| 11:14:37 | <dkayiwa> k6joseph: can you look at that page again now to see the clients listed? |
| 11:14:38 | <k6joseph> dkayiwa not yet, and how can i see that |
| 11:14:59 | <dkayiwa> k6joseph: are you looking at that page now? |
| 11:15:39 | <k6joseph> dkayiwa yes i am |
| 11:16:28 | <dkayiwa> k6joseph: can you read the whole of the page? https://wiki.openmrs.org/display/IRC/Home |
| 11:16:58 | <k6joseph> dkayiwa am not seing that |
| 11:17:26 | <dkayiwa> k6joseph: can you read now the whole of this page? https://wiki.openmrs.org/display/IRC/Home |
| 11:20:05 | <k6joseph> dkayiwa: yes now i can see itk |
| 11:21:00 | <k6joseph> dkayiwa: what can i do next now |
| 11:24:20 | <suranga> hi rafa since incrementalversion is a boolean, and not Boolean, I cant set its value to 'NULL' programatically. therefore, I cant use unit tests to validate if it works. Is it enough to test via a manual export ? :) |
| 11:24:59 | <rafa> suranga: ekhem? I asked it to be Boolean and null by default |
| 11:25:42 | <suranga> rafa, um... u asked me to switch to boolean, right ? |
| 11:25:50 | <suranga> its on a comment here https://github.com/openmrs/openmrs-module-metadatasharing/pull/8 |
| 11:25:51 | <OpenMRSBot> <http://ln-s.net/$u39> (at github.com) |
| 11:26:01 | <rafa> suranga: yes, but just the isIncrementalVersion method |
| 11:26:14 | <rafa> suranga: to comply with java bean standards |
| 11:26:35 | <rafa> suranga: the field should be Boolean so that it can have null value |
| 11:27:14 | <suranga> rafa, oops, I get it, so the variable is Boolean, but the getter / setters use boolean |
| 11:27:28 | <rafa> suranga: getter/setters must use Boolean |
| 11:27:39 | <rafa> suranga: just isIncrementalVersion use boolean |
| 11:28:37 | <suranga> and if the Boolean is NUll, 'isIncremental.... returns null ? |
| 11:28:46 | <suranga> rafa, sorry sorry, returns false |
| 11:29:12 | <rafa> suranga: yes, return false |
| 11:29:34 | <rafa> suranga: if you update to the latest, I've already fixed that |
| 11:29:53 | <rafa> suranga: wyclif needed that for his ticket |
| 11:30:35 | <suranga> rafa, I saw that email. sorry for the delay. im rather ties up here too :( |
| 11:30:37 | <dkayiwa> k6joseph: install the windows client |
| 11:30:42 | <suranga> rafa, update == git pull --rebase upstream master ? |
| 11:30:50 | <rafa> suranga: yes |
| 11:31:36 | <suranga> rafa, isnt there a way to do that via the UI ? I need to replace only some of the changes, not all... |
| 11:31:54 | <k6joseph> dkayiwa: okey then, that is what am doing now |
| 11:32:03 | <suranga> rafa, as in with svn, I can synchonize, and override selectively ? |
| 11:32:08 | <dkayiwa> k6joseph: ok tell me when done |
| 11:32:13 | <rafa> suranga: I bet there's, but i don't use ui |
| 11:32:33 | <suranga> rafa, no worries . thanks :) |
| 11:40:27 | <suranga> hi rafa sorry, but when I do a rebase it seems to take my last patch META _243, and replay those changes on top of the rebase. isnt this wrong ? :) |
| 11:41:09 | <rafa> suranga: you mean you see it twice in log? |
| 11:42:00 | <suranga> rafa, it says "HEAD is now at fec3587 Changes for META-243 " and "First, rewinding head to replay your work on top of it..." |
| 11:42:17 | <suranga> rafa, doesnt that mean it is replacing my patch, as opposed to the changes you made ? |
| 11:42:28 | <k6joseph> dkayiwa; am through with the download |
| 11:42:48 | <dkayiwa> k6joseph: can you now run it at log on? |
| 11:43:09 | <rafa> suranga: I merged your changes (patch) to master and now only your changes after the first patch are replied on top of that |
| 11:43:16 | <k6joseph> dkayiwa; i have run it already |
| 11:43:22 | <rafa> suranga: it should be correct |
| 11:43:39 | <suranga> rafa, I see. thank you :) |
| 11:43:41 | <rafa> suranga: give me your git log |
| 11:44:00 | <suranga> rafa-- |
| 11:44:02 | <suranga> C:\Users\HP\git\openmrs-module-metadatasharing>git stash |
| 11:44:02 | <suranga> Saved working directory and index state WIP on master: fec3587 Changes for META-243 |
| 11:44:02 | <suranga> HEAD is now at fec3587 Changes for META-243 |
| 11:44:02 | <suranga> C:\Users\HP\git\openmrs-module-metadatasharing>git pull --rebase upstream master |
| 11:44:02 | <suranga> remote: Counting objects: 89, done. |
| 11:44:03 | <suranga> remote: Compressing objects: 100% (32/32), done. |
| 11:44:05 | <suranga> remote: Total 59 (delta 20), reused 48 (delta 9) |
| 11:44:09 | <suranga> Unpacking objects: 100% (59/59), done. |
| 11:44:11 | <suranga> From https://github.com/openmrs/openmrs-module-metadatasharing |
| 11:44:12 | <OpenMRSBot> <http://ln-s.net/$u4c> (at github.com) |
| 11:44:13 | <suranga> * branch master -> FETCH_HEAD |
| 11:44:15 | <suranga> First, rewinding head to replay your work on top of it... |
| 11:44:25 | <suranga> rafa, sorry, I did not mean to use (minus) (minus) back there :( |
| 11:44:44 | <rafa> suranga: hehe np |
| 11:44:51 | <suranga> rafa+ |
| 11:44:53 | <rafa> suranga: can you run "git log" |
| 11:46:06 | <suranga> rafa, its huge, last change by you "META-243: Add incrementalVersion field to package, fixes tests" |
| 11:46:35 | <rafa> suranga: yest, I meant just a few first lines ;) |
| 11:46:50 | <suranga> rafa, |
| 11:46:51 | <suranga> C:\Users\HP\git\openmrs-module-metadatasharing>git log |
| 11:46:52 | <suranga> commit e3661ecb2aaef68354755bc533cd39305b4935b8 |
| 11:46:52 | <suranga> Author: rkorytkowski <rafal.korytkowski@gmail.com> |
| 11:46:52 | <suranga> Date: Mon Oct 1 20:01:42 2012 +0200 |
| 11:46:52 | <suranga> META-243: Add incrementalVersion field to package, fixes tests |
| 11:46:53 | <suranga> commit 84663ace778ab18f6fc08e4e7819182b0e4e203b |
| 11:46:55 | <suranga> Merge: ac59438 7d00f6a |
| 11:46:57 | <suranga> Author: Rafal Korytkowski <rafal@openmrs.org> |
| 11:47:00 | <suranga> Date: Mon Oct 1 06:25:30 2012 -0700 |
| 11:47:01 | <suranga> Merge pull request #8 from surangak/master |
| 11:47:03 | <suranga> Changes for META-243 |
| 11:47:05 | <suranga> commit ac594386c1df8ae82189fc3ae3899be794e89e81 |
| 11:47:10 | <suranga> Author: rkorytkowski <rafal.korytkowski@gmail.com> |
| 11:47:11 | <suranga> Date: Mon Oct 1 13:54:19 2012 +0200 |
| 11:47:13 | <suranga> META-212: Java heap space with large export |
| 11:47:16 | <rafa> suranga: ok enough |
| 11:47:26 | <rafa> so you haven't commited more of your changes yet |
| 11:48:02 | <rafa> suranga: it looks good |
| 11:48:13 | <suranga> rafa, thanks :) so im good to go ? :) |
| 11:48:20 | <rafa> suranga: yes |
| 11:53:04 | <k6joseph> dkayiwa; can i use; #OpenMRS on irc.freenode.net or its url as my new network |
| 11:55:00 | <dkayiwa> k6joseph: ok |
| 11:55:21 | <dkayiwa> k6joseph: can you now start asking where you are stuck |
| 11:57:35 | <k6joseph> dkayiwa; which new network can i enter, that's where i am |
| 11:59:57 | *** suranga_ has joined #openmrs |
| 12:00:32 | *** suranga has quit IRC |
| 12:01:36 | <dkayiwa> k6joseph: which irc client did you install? |
| 12:02:46 | *** shortend has quit IRC |
| 12:03:26 | <k6joseph> dkayiwa; the xchat |
| 12:06:44 | <dkayiwa> k6joseph: ok |
| 12:14:24 | <eshan> help: did dome body get getting this issue http://pastebin.com/1nEpvdxD |
| 12:14:31 | <eshan> *some |
| 12:17:09 | *** k6joseph has quit IRC |
| 12:19:57 | *** fishandwalk has joined #openmrs |
| 12:27:48 | *** fishandwalk has quit IRC |
| 12:48:21 | <dkayiwa> eshan: when do you get that? |
| 12:48:51 | <dkayiwa> eshan: which version of openmrs and the logic modules are you running? |
| 12:55:37 | *** djazayeri has joined #openmrs |
| 12:55:37 | *** ChanServ sets mode: +o djazayeri |
| 13:05:07 | <suranga_> hi rafa , sorry, me again :) |
| 13:05:14 | <rafa> suranga_: hi |
| 13:05:17 | <suranga_> rafa, i've commited to my github account |
| 13:05:31 | <suranga_> rafa, for some reason, i dont see the pull request button. |
| 13:05:55 | <rafa> suranga_: use the one at the top |
| 13:06:25 | *** kishoreyekkanti has joined #openmrs |
| 13:06:43 | <rafa> suranga_: next to star, fork, etc. |
| 13:07:36 | <suranga_> rafa, aaaand done :) |
| 13:08:14 | <suranga_> rafa, my pull contains some unit tests mainly. They are to prove that the serialization issue works, etc. etc. |
| 13:08:19 | <suranga_> rafa, hope that you like it :) |
| 13:08:30 | <rafa> suranga_: thanks |
| 13:08:57 | <suranga_> rafa, dont say 'thank you' until you see the contents of the ticket :P |
| 13:09:06 | <suranga_> the patch, i mean :D |
| 13:09:35 | *** kishoreyekkanti has quit IRC |
| 13:10:56 | *** kishoreyekkanti has joined #openmrs |
| 13:12:21 | *** lhawthor_ has joined #openmrs |
| 13:15:24 | *** bwolfe has joined #openmrs |
| 13:15:24 | *** ChanServ sets mode: +o bwolfe |
| 13:15:55 | <bwolfe> eshan, did you ever get your question answered from last night? |
| 13:21:18 | <rafa> suranga_: well done, just two tweaks needed |
| 13:21:56 | <suranga_> rafa, I was looking at the comments hit my gmail, and I was really happy that there were only two (but very stupid) mistakes |
| 13:22:24 | <suranga_> rafa, I dont understand how you do without the ynchronize function on the IDE :P |
| 13:22:46 | <rafa> suranga_: synchronize function? |
| 13:22:51 | <suranga_> rafa, the two tests cover the issues we need to test, right ? I was a bit unsure :-) |
| 13:23:02 | <rafa> suranga_: yes, they're good |
| 13:23:06 | <suranga_> rafa, I mean, in svn, before commiting we can compare against head... |
| 13:23:51 | <rafa> suranga_: if you work on a topic branch you just do git diff master.. |
| 13:24:11 | <suranga_> rafa, on the console, is it ? :) |
| 13:24:15 | <rafa> suranga_: yes |
| 13:24:27 | <rafa> suranga_: first you need to make sure your master is up to date of course |
| 13:24:38 | <suranga_> rafa, im really looking forward to the GIT session during the hackathon :) |
| 13:28:34 | <djazayeri> rafa: by the way, I've learned a bit more about what rebase does, and I'm thinking we should do a more thorough job of asking _contributors_ to rebase. |
| 13:29:53 | <rafa> djazayeri: I prefer rebase too |
| 13:30:23 | <suranga_> rafa, does this look good ? @should reject imported package if its version id |
| 13:30:24 | <suranga_> does not match the subsequent incremental version |
| 13:30:37 | <rafa> suranga_: a bit too long ;) |
| 13:31:08 | <suranga_> rafa, in that case, ill use what you suggested, no worries :) |
| 13:31:16 | <djazayeri> suranga_: @should reject the wrong incremental version of a package |
| 13:31:29 | <djazayeri> suranga_: or …the wrong version of an incremental package |
| 13:31:33 | <suranga_> djazayeri++ :-) |
| 13:31:42 | <suranga_> djazayeri, thanks :) |
| 13:33:44 | *** djazayeri has quit IRC |
| 13:35:02 | <suranga_> rafa, just made a second commit with those changes. Its incredible how Git caught and merged it :) :) |
| 13:36:36 | <rafa> suranga_: that was quick, thanks! |
| 13:55:05 | <bwolfe> magandang umaga |
| 13:55:16 | <bwolfe> == good morning in Filipino |
| 13:58:57 | *** cpower has joined #openmrs |
| 14:00:39 | *** cpower has joined #openmrs |
| 14:01:25 | <cpower> No time to waste, let's Scrum |
| 14:01:29 | <cpower> !scrumon cpower |
| 14:01:29 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:01:50 | <cpower> Order: Bwolfe, rafa, dkayiwa, suranga_, wyclif |
| 14:02:02 | <rafa> hi |
| 14:02:49 | <bwolfe> Monday |
| 14:02:49 | <bwolfe> emails |
| 14:02:49 | <bwolfe> reviewed a trunk ticket |
| 14:02:49 | <bwolfe> MDS-281 |
| 14:02:49 | <bwolfe> Tuesday |
| 14:02:49 | <bwolfe> emails |
| 14:02:53 | <bwolfe> updated sprint ticket: MDS-281 |
| 14:02:55 | <bwolfe> no blockers |
| 14:03:20 | <rafa> Today: |
| 14:03:20 | <rafa> * Committed META-280: Create MIRROR import mode |
| 14:03:20 | <rafa> https://tickets.openmrs.org/browse/META-280 |
| 14:03:20 | <rafa> * Reviewed: |
| 14:03:20 | <rafa> + META-281: MDS should depend on ConceptPubSub (to redo) |
| 14:03:20 | <rafa> https://tickets.openmrs.org/browse/META-281 |
| 14:03:20 | <rafa> + META-243: Add incrementalVersion field to package (closed) |
| 14:03:20 | <rafa> https://tickets.openmrs.org/browse/META-243 |
| 14:03:22 | <rafa> No blockers. |
| 14:03:31 | *** andrea_ has joined #openmrs |
| 14:04:05 | <cpower> dkayiwa...anything? |
| 14:05:27 | <cpower> ok next |
| 14:05:35 | <cpower> suranga_ |
| 14:05:37 | <bwolfe> dkayiwa is missing |
| 14:05:43 | <bwolfe> and suranga_ has a tail |
| 14:05:44 | <suranga_> hi :) |
| 14:05:47 | <suranga_> :D |
| 14:05:52 | *** bwolfe is now known as bwolfe____ |
| 14:05:56 | <bwolfe____> but my tail is longer |
| 14:06:00 | <rafa> lol |
| 14:06:05 | <suranga_> bwolfe____, thats not my tail, its my long face :( |
| 14:06:10 | <suranga_> DID |
| 14:06:10 | <suranga_> Fixed, META-243, also completed review comments |
| 14:06:11 | <cpower> so it's going to be like this is it? |
| 14:06:19 | <suranga_> TO DO |
| 14:06:28 | <suranga_> More meta tickets, and hl7qry tickets :) |
| 14:06:32 | <suranga_> NO BLOCKERS |
| 14:06:35 | <cpower> I need to be promoted in here so I can kick bwolfe out. |
| 14:06:57 | <cpower> ok wyclif show them how it's done |
| 14:06:58 | <bwolfe____> /kickban cpower for tail hating |
| 14:07:17 | <wyclif> Monday: |
| 14:07:17 | <wyclif> META-251 - Publish concept dictionary |
| 14:07:17 | <wyclif> Tuesday: |
| 14:07:17 | <wyclif> complete META-251 - Publish concept dictionary |
| 14:07:17 | <wyclif> META-257 - Check for concept dictionary updates |
| 14:07:17 | <wyclif> pick another ticket |
| 14:07:19 | <wyclif> Blockers: None |
| 14:07:25 | <cpower> Andrea you are up |
| 14:07:41 | <andrea_> ok |
| 14:07:55 | <andrea_> Monday |
| 14:07:55 | <andrea_> Finished TRUNK-3701 |
| 14:07:55 | <andrea_> commit, push, pull |
| 14:07:55 | <andrea_> TRUNK-3321 |
| 14:07:55 | <andrea_> put changes in AdministrativeServiceImpl - validte method |
| 14:07:55 | <andrea_> put @should in AdministrativeService |
| 14:07:57 | <andrea_> Discussion point - no JUNIT test |
| 14:07:59 | <andrea_> Today |
| 14:08:02 | <andrea_> Finish Junit tests for TRUNK-3321 |
| 14:08:04 | <andrea_> Find new ticket |
| 14:08:05 | <andrea_> Blocker or Discussion point - no magic from @should - JUNIT test |
| 14:08:26 | <cpower> Ok there you have it |
| 14:08:30 | <cpower> <andrea_> Blocker or Discussion point - no magic from @should - JUNIT test |
| 14:08:35 | <bwolfe____> except for the missing dkayiwa... |
| 14:08:43 | <andrea_> yes |
| 14:08:43 | <cpower> Someone help the lady |
| 14:08:50 | <bwolfe____> we should discuss dkayiwa until he senses he is missed and shows up here for the scrum |
| 14:09:04 | <cpower> he's getting his tail removed |
| 14:09:08 | <cpower> !scrumoff |
| 14:09:08 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:09:23 | *** bwolfe____ is now known as bwolfe__ |
| 14:09:29 | <cpower> if anyone's looking for me I'll be hiding under my desk. |
| 14:09:29 | *** bwolfe__ is now known as bwolfe_ |
| 14:09:40 | <andrea_> bwolfe, put @should in AdministrativeService, didn't create Junit test |
| 14:10:02 | *** bwolfe_ is now known as bwolfe |
| 14:10:19 | <bwolfe> andrea_, which project are you in? the "openmrs-api" or the "openmrs" one ? |
| 14:10:30 | <dkayiwa> bwolfe: am back :) |
| 14:10:40 | <andrea_> bwolfe, openmrs-api |
| 14:10:41 | <bwolfe> andrea_, I think we only set up the "behaviour test plugin" on the "openmrs-api" and "openmrs-web" projects |
| 14:10:45 | <cpower> I forgot the line for my jack and coke but I could use one now. |
| 14:11:34 | <andrea_> bwolfe, oh - may I ping you when I get to office? |
| 14:11:43 | *** cpower is now known as cpower[A] |
| 14:11:43 | * cpower[A] is now away - Reason : meeting time |
| 14:13:06 | <dkayiwa> Committed: Unit tests fail when running 'mvn test' when not connected to the internet - HTML-307 |
| 14:13:07 | <dkayiwa> Committed: Cannot create a patient and enroll that patient in a program on the same form - Html 378 |
| 14:13:07 | <dkayiwa> Working on: HTML form entry forms not working on MDS 1.0.9 and openmrs 1.9.1 - META-274 |
| 14:13:07 | <dkayiwa> No Blockers |
| 14:13:15 | <bwolfe> !powerup cpower[A] |
| 14:13:15 | <OpenMRSBot> bwolfe: Error: "A" is not a valid command. |
| 14:13:18 | <bwolfe> !powerup cpower |
| 14:13:18 | * OpenMRSBot slides cpower a Jack and Coke |
| 14:14:53 | <bwolfe> dkayiwa, good work on that internet issue with unit tests thing! |
| 14:14:57 | <bwolfe> dkayiwa, how'd you find that ?! |
| 14:15:28 | <dkayiwa> bwolfe: there was a pointer in the error message about being TestingApplicationContext |
| 14:17:36 | *** sgithens has joined #openmrs |
| 14:22:36 | *** djazayeri has joined #openmrs |
| 14:22:36 | *** ChanServ sets mode: +o djazayeri |
| 14:31:41 | *** suranga_ has quit IRC |
| 14:44:25 | *** rafa has quit IRC |
| 14:47:49 | *** harshadura has joined #openmrs |
| 15:08:44 | *** andrea_ has quit IRC |
| 15:18:49 | *** sgithens has quit IRC |
| 15:45:27 | *** harshadura has quit IRC |
| 15:59:20 | *** kishoreyekkanti has quit IRC |
| 16:13:19 | *** dkayiwa has quit IRC |
| 16:14:33 | *** dkayiwa has joined #openmrs |
| 16:15:08 | *** lh has quit IRC |
| 16:22:16 | *** rafa has joined #openmrs |
| 16:22:16 | *** ChanServ sets mode: +v rafa |
| 16:37:19 | *** andreapat has joined #openmrs |
| 16:48:11 | *** cpower[A] has quit IRC |
| 16:48:47 | *** chopin has quit IRC |
| 16:48:47 | *** chopin has joined #openmrs |
| 17:11:00 | <prolificgnosis> hey, I'm getting an exception when loading my module from front end. The exception doesn't get written to the logs though, any thoughts ( org.openmrs.module.ModuleFactory.runLiquibase(ModuleFactory.java:774)) |
| 17:12:32 | <dkayiwa> prolificgnosis: what is the name of the log file you are looking at? |
| 17:13:56 | <wyclif> rafa, are you able to run unit tests for dictionary publishing? |
| 17:15:26 | <prolificgnosis> server.log,i'm using jboss |
| 17:15:48 | <dkayiwa> prolificgnosis: which version of openmrs |
| 17:15:52 | <prolificgnosis> 1.9.1 |
| 17:16:01 | <prolificgnosis> i just changed log4j in project though, to debug |
| 17:16:31 | <prolificgnosis> although I'm pretty sure the error should have been in the logs |
| 17:16:38 | <dkayiwa> prolificgnosis: can you send me the module to try it out here? |
| 17:17:50 | <prolificgnosis> i suppose i could, where would I send it to? |
| 17:17:51 | <dkayiwa> prolificgnosis: or if you can pastebin your liquibase.xml contents |
| 17:18:05 | <prolificgnosis> yeah i can pastebin liquibase |
| 17:18:08 | <prolificgnosis> hold on |
| 17:18:10 | <dkayiwa> ok |
| 17:19:11 | <wyclif> dkayiwa, , are you able to run unit tests for dictionary publishing? |
| 17:19:31 | <dkayiwa> wyclif: what is that |
| 17:20:24 | <wyclif> dkayiwa, , are you able to run unit tests for dictionary publishing module? |
| 17:20:26 | <prolificgnosis> http://pastebin.com/9V6xFXJj |
| 17:20:41 | <dkayiwa> wyclif: never tried it out |
| 17:20:58 | <prolificgnosis> i should note, i've run the liquibase changes externally via command line |
| 17:21:07 | <prolificgnosis> before I got around to deploying my module |
| 17:21:36 | <prolificgnosis> so i think its trying to run those changes now, but i can't see exception so i'm not sure what its complaining about |
| 17:22:24 | <dkayiwa> prolificgnosis: can you send me the compiled module: dkayiwa at openmrs.org |
| 17:24:30 | <prolificgnosis> sure |
| 17:26:43 | <dkayiwa> hi rafa |
| 17:27:12 | <dkayiwa> rafa: are you able to successfully run the Concept19SmokeTest unit test from eclipse via Run as JUnit test? |
| 17:27:38 | <prolificgnosis> sent |
| 17:27:46 | <dkayiwa> prolificgnosis: ok |
| 17:35:21 | <dkayiwa> prolificgnosis: your log is here: http://pastebin.com/aWSqsY0K |
| 17:35:56 | *** downey has joined #openmrs |
| 17:35:56 | *** ChanServ sets mode: +o downey |
| 17:35:56 | *** OpenMRSBot sets mode: +o downey |
| 17:36:16 | *** rafa has quit IRC |
| 17:43:22 | *** james_regen has left #openmrs |
| 17:57:53 | <prolificgnosis> where did you get the log |
| 17:57:59 | <prolificgnosis> or how did you generate it |
| 17:58:33 | <dkayiwa> prolificgnosis: am running the standalone version of openmrs and i found it in the log file |
| 17:58:46 | <prolificgnosis> hmm weird |
| 17:58:54 | <prolificgnosis> def isn't being output to mine |
| 17:58:58 | <prolificgnosis> okay thanks |
| 17:59:24 | <dkayiwa> prolificgnosis: though i have also never changes my log level from the default :) |
| 17:59:34 | <dkayiwa> s = d |
| 18:00:16 | <prolificgnosis> yeah, is there way to skip or ignore this set of changes? |
| 18:00:39 | <dkayiwa> prolificgnosis: which changes |
| 18:00:53 | <prolificgnosis> the ones listed in my liquibase file |
| 18:01:05 | <prolificgnosis> that SQL has already been executed |
| 18:01:14 | <prolificgnosis> but outside of openmrs |
| 18:01:41 | <dkayiwa> prolificgnosis: you can use preconditions |
| 18:02:16 | *** downey has quit IRC |
| 18:02:49 | <prolificgnosis> ahh okay |
| 18:02:51 | <prolificgnosis> thanks |
| 18:02:55 | <andreapat> bwolfe, you around? |
| 18:03:17 | <bwolfe> yep |
| 18:03:27 | <bwolfe> andreapat, but remember, you can ask anyone in here. ;-) |
| 18:03:55 | *** rafa has joined #openmrs |
| 18:03:55 | *** ChanServ sets mode: +v rafa |
| 18:05:26 | <andreapat> bwolfe, good! Got Junit skelaton - seems a lot of tests are not implemented for AdministrationService - looking for an example of test for null |
| 18:06:16 | <andreapat> bwolfe, yeah I better get used to asking others |
| 18:24:38 | <andreapat> bwolfe, was that a stupid question? |
| 18:24:56 | <bwolfe> andreapat, was there a question in there? |
| 18:27:44 | <andreapat> bwolfe, not exactly - just looking for example unit test for passing a null object - test for validate_shouldFailForAnInvalidObject() above it is not implemented |
| 18:28:00 | <bwolfe> andreapat, which class? |
| 18:28:06 | <bwolfe> which test class? |
| 18:28:35 | <andreapat> bwolfe, AdministrationServiceTest.java |
| 18:29:47 | *** rafa has quit IRC |
| 18:35:08 | <andreapat> bwolfe, AdministrativeServiceTest - validate method |
| 18:35:31 | <djazayeri> bwolfe, wyclif: web.xml in 1.9.x is broken |
| 18:35:35 | <bwolfe> andreapat, sorry, got distracted! let me look now |
| 18:35:48 | <djazayeri> FYI |
| 18:35:50 | <bwolfe> djazayeri, didn't I fix it? |
| 18:35:57 | <djazayeri> bwolfe: you didn't fix it right. :-) |
| 18:36:00 | <andreapat> bwolfe, ok |
| 18:36:09 | <bwolfe> djazayeri, are you in a place to do that? |
| 18:36:16 | <djazayeri> yeah, we can fix it. |
| 18:36:25 | <wyclif> djazayeri, what error do you get? |
| 18:36:52 | <djazayeri> wyclif: see this: https://github.com/openmrs/openmrs-core/commit/edf5f9414989c9dd1001015d24c5fce0b6ed2b70#webapp/src/main/webapp/WEB-INF/web.xml |
| 18:36:56 | <OpenMRSBot> <http://ln-s.net/$uVn> (at github.com) |
| 18:37:09 | <djazayeri> wyclif: you can't do a jetty:run because the web.xml file can't be parsed |
| 18:38:46 | *** rafa has joined #openmrs |
| 18:38:46 | *** ChanServ sets mode: +v rafa |
| 18:38:57 | <wyclif> djazayeri, i think it was a result of bad back port that has these diff characters '<<<<' |
| 18:39:08 | <djazayeri> wyclif: yup, thanks, I'll fix it |
| 18:39:40 | *** rafa has quit IRC |
| 18:40:24 | <bwolfe> djazayeri, https://github.com/openmrs/openmrs-core/commit/3940f04989ae7bb7a5d9dec40017b575c2066988 |
| 18:40:28 | <OpenMRSBot> <http://ln-s.net/$uVv> (at github.com) |
| 18:40:29 | *** rafa has joined #openmrs |
| 18:40:29 | *** ChanServ sets mode: +v rafa |
| 18:40:33 | <bwolfe> I did a followup commit...might have missed something |
| 18:40:57 | <djazayeri> bwolfe: yeah, the entire file is duplicated (both sides of the conflict) and there's a =========== |
| 18:41:18 | <djazayeri> anyway, I'll fix it, it was just an FYI. Also, it seems we don't have a test to catch this? |
| 18:41:20 | <bwolfe> djazayeri, ah yes, I see that now: https://github.com/openmrs/openmrs-core/blob/1.9.x/webapp/src/main/webapp/WEB-INF/web.xml |
| 18:41:21 | <djazayeri> that's odd |
| 18:41:23 | <OpenMRSBot> <http://ln-s.net/$uVx> (at github.com) |
| 18:41:35 | <bwolfe> djazayeri, how would we? I suppose an integration test could deploy the app... |
| 18:41:48 | <bwolfe> djazayeri, wyclif: and it seems I need to work on my merging/cherrypicking skills. :-/ |
| 18:42:22 | <djazayeri> bwolfe: I guess we'd need to deploy the app. Alternately we could have a "unit" test that verifies certain files have correctly-formed xml |
| 18:42:50 | <bwolfe> thoughtworks++ |
| 18:43:01 | <wyclif> bwolfe, djazayeri but the version in master here https://github.com/openmrs/openmrs-core/blob/1.9.x/webapp/src/main/webapp/WEB-INF/web.xml seems fine |
| 18:43:02 | <OpenMRSBot> <http://ln-s.net/$uVx> (at github.com) |
| 18:43:16 | <bwolfe> wyclif, yes, it was a bad backport |
| 18:43:19 | <wyclif> sorry 1.9.x not master |
| 18:43:22 | <djazayeri> wyclif: yeah, sorry, I didn't need to involve you, you did everything right. bwolfe messed up. :-) |
| 18:43:31 | * bwolfe hangs head in shame |
| 18:43:33 | <djazayeri> wyclif: look in 1.9.x for the string ===== in that file |
| 18:43:39 | <djazayeri> it's there. that's not good. |
| 18:43:45 | * bwolfe slinks off to finally answer andreapat's question |
| 18:43:55 | <wyclif> djazayeri, bwolfe seen it |
| 18:44:39 | <wyclif> djazayeri, good catch! |
| 18:44:48 | <andreapat> bwolfe, seems like a lot going on |
| 18:44:51 | <djazayeri> wyclif: it was Mario who found it, not me. |
| 18:45:22 | <djazayeri> bwolfe: hey, it beats my sending pull requests for backports :-) |
| 18:49:17 | <bwolfe> andreapat, so you're saying the @shoulds haven't been implemented? |
| 18:49:33 | <bwolfe> andreapat, I had a hard time trying to find what method you were talking about! |
| 18:50:23 | <bwolfe> andreapat, just call Context.getAdministrationService().validate(null, new Errors()); (although I don't know what impl of Errors to actually use |
| 19:00:04 | <andreapat> bwolfe, validate_shouldPassForAValidObject() validate_shouldFailForAnInvalidObject() have not been implemented |
| 19:00:33 | <bwolfe> andreapat, correct. |
| 19:01:02 | <bwolfe> andreapat, are there unit tests for ValidateUtil? (the place where they were in 1.8.x before being moved to AdminService in 1.9+) |
| 19:01:48 | <andreapat> bwolfe, not sure - working on trunc version right now |
| 19:02:10 | <bwolfe> andreapat, I'm not saying to switch |
| 19:02:21 | <bwolfe> I'm saying to look for ValidateUtilTest and see if there are some examples |
| 19:02:55 | <bwolfe> although its not really that complicated of a test. its basically what I put above and then setting hte @Test annotation to be @Test(expected=APIException.class) |
| 19:03:17 | <andreapat> bwolfe, how do I see 1.8.x without switching? |
| 19:03:37 | <bwolfe> andreapat, you can see it on github.com |
| 19:13:48 | *** rafa has quit IRC |
| 19:17:48 | <andreapat> bwolfe, found it will use the same test - thanks! |
| 19:27:33 | *** maurya has joined #openmrs |
| 19:27:38 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @nimanthab Congratulations, and thanks for your continued hard work! <http://twitter.com/OpenMRS/statuses/253202532648763392> || On Twitter: OpenMRS: Thanks to our newest #OMRS12 sponsor @ThoughtWorks joining @Google in supporting our 6th annual implementers meeting! http://t.co/yTUGJOdb <http://twitter.com/OpenMRS/statuses/253202065227132928> |
| 19:28:01 | *** ChanServ sets mode: +v maurya |
| 19:46:46 | *** midkid has joined #openmrs |
| 19:47:48 | <midkid> Hello, I am trying to load the sample dataset provided, but I am affraid that I changed the username and passowrd before I could download the file |
| 19:47:56 | <midkid> is there a way to reverse this? |
| 19:50:32 | <bwolfe> midkid, changed it where? |
| 19:52:15 | <midkid> I changed it in the browser. I entered the command line to download the demo file, but it keeps asking me to ensure I configured my username/password in golbal properties |
| 19:52:49 | <midkid> not sure if I am doing any of this right |
| 19:57:04 | <bwolfe> midkid, what screen are you seeing? are you sure its not asking about your "runtime" properties and hte database username/password? |
| 19:57:48 | <midkid> WARN - AbstractReportsTask.authenticate(60) |2012-10-02 15:57:01,453| Not authenticating to avoid locking account. Please ensure you scheduler username and password are configured correctly in your global properties |
| 19:58:21 | <bwolfe> midkid, thats for the reporting module |
| 20:01:02 | <andreapat> bwolfe, just emailed test from 1.8.x ValidateUtil - thought we decided that was all that was neccessary - maybe it has to cange to |
| 20:03:11 | *** midkid has quit IRC |
| 20:03:57 | <bwolfe> andreapat, I replied to your email already. but I'm confused what you're asking me here |
| 20:20:50 | *** rafa has joined #openmrs |
| 20:20:50 | *** ChanServ sets mode: +v rafa |
| 20:39:47 | <andreapat> bwolfe, you pointed me to ValidateUtil.validate test - that's what I found. It doesn't look good to me. |
| 20:41:04 | <bwolfe> andreapat, I don't see the test you sent to me anywhere in my code |
| 20:41:07 | <bwolfe> so it must be one you added |
| 20:41:29 | <andreapat> I guess so - |
| 20:41:40 | <bwolfe> compare what you have against what is in github.com or use rightclick-->comparewith-->branch/tag-->upstreamHEAD |
| 20:52:08 | <andreapat> Got that test from branch 1.8.x on github - it will have to change to |
| 20:53:35 | <andreapat> bwolfe, Got that test from branch 1.8.x on github - it will have to change too |
| 20:53:58 | <bwolfe> andreapat, can you link me to the url of it? |
| 21:05:22 | <andreapat> trying to find it again - copied it and put in editor |
| 21:06:20 | <andreapat> https://github.com/andreapat/openmrs-core-1/commit/19657ec713809acc11ce8421684e55d24b1f3bf9 |
| 21:06:25 | <OpenMRSBot> <http://ln-s.net/$uZb> (at github.com) |
| 21:06:43 | <andreapat> bwolfe, here it is: https://github.com/andreapat/openmrs-core-1/commit/19657ec713809acc11ce8421684e55d24b1f3bf9 |
| 21:06:43 | <OpenMRSBot> <http://ln-s.net/$uZb> (at github.com) |
| 21:08:18 | <bwolfe> andreapat, thats in your repo in your commit, not in core. so it is something you copied/modifed from somewhere. :-) |
| 21:08:29 | <bwolfe> if you run that test I am 110% sure it will fail |
| 21:08:43 | <bwolfe> you need to add the expected= in the @test annotation |
| 21:08:54 | <bwolfe> and the assert is not necessary |
| 21:09:25 | <andreapat> how about 150% |
| 21:11:38 | <andreapat> I don't remember where I copied it from |
| 21:11:41 | <bwolfe> no, just 110 |
| 21:21:28 | *** dkayiwa_ has joined #openmrs |
| 21:23:01 | *** dkayiwa has quit IRC |
| 21:23:01 | *** dkayiwa_ is now known as dkayiwa |
| 21:29:05 | *** maurya has quit IRC |
| 21:30:13 | <djazayeri> Has anybody here seen this recently? |
| 21:30:22 | <djazayeri> Unable to start OpenMRS. Error thrown was: org.openmrs.module.ModuleException: Error parsing dwr-modules.xml file |
| 21:30:34 | <bwolfe> not recently |
| 21:30:34 | <djazayeri> Caused by: java.lang.ClassCastException: org.apache.xerces.jaxp.DocumentBuilderFactoryImpl cannot be cast to javax.xml.parsers.DocumentBuilderFactory |
| 21:30:43 | <bwolfe> oh, thats new |
| 21:31:37 | <djazayeri> okay |
| 21:36:15 | *** sunbiz has joined #openmrs |
| 21:36:15 | *** ChanServ sets mode: +v sunbiz |
| 21:40:34 | *** wyclif has quit IRC |
| 21:46:39 | *** dkayiwa has quit IRC |
| 21:46:59 | *** dkayiwa has joined #openmrs |
| 22:13:01 | *** dkayiwa has quit IRC |
| 22:30:21 | *** rafa has quit IRC |
| 23:04:50 | *** wyclif has joined #openmrs |
| 23:31:21 | *** sunbiz has quit IRC |
| 23:36:23 | <djazayeri> wyclif or chopin: do you know if our H2-based unit tests have different case-sensitivity behavior than in production against mysql? |
| 23:36:45 | <djazayeri> e.g. if I use PatientSearchCriteria against h2 I have to get the case of names exactly right? |
| 23:45:04 | <wyclif> djazayeri, i think so |
| 23:45:43 | <djazayeri> cool, thanks |
| 23:45:59 | <wyclif> mysql does searches in a case insensitive way but H2 from what i recall |
| 23:46:10 | <wyclif> doesnot |