01:10:06
|
<wyclif> djazayeri, i think there is a misleading line on the using got page
|
01:10:50
|
<djazayeri> wyclif: which one?
|
01:10:51
|
<wyclif> djazayeri, you cannot switch branches without first committing the changes in the working
|
01:11:03
|
<wyclif> djazayeri, i have just lost everything i was working on
|
01:11:17
|
<wyclif> djazayeri, when i did git clean -df
|
01:11:40
|
<djazayeri> wyclif: I have switched, without losing things, but I've never done git clean -df
|
01:11:45
|
<wyclif> djazayeri, i assumed it was like git stash and git stash pop where it reverts things but not completely lost
|
01:11:59
|
<djazayeri> wyclif: you have to manually do git stash...
|
01:12:14
|
<wyclif> djazayeri, switched with uncommitted files?
|
01:12:40
|
<djazayeri> wyclif: yeah, I've done it before, partly by accident, and I think the uncommitted files have just stayed around.
|
01:12:46
|
<wyclif> djazayeri, and actually edited files that are already under version control are not cleaned
|
01:12:48
|
<djazayeri> wyclif: or maybe I've branched with uncommitted files
|
01:13:22
|
<wyclif> djazayeri, i have brached and that workd if you mark none and not merge option in egit
|
01:13:49
|
<djazayeri> wyclif: in any case it's not good practice to switch when you have uncommitted files, right?
|
01:13:57
|
<djazayeri> wyclif: it's fair to add a note saying not to do that...
|
01:14:37
|
<wyclif> djazayeri, yes
|
01:15:17
|
<wyclif> djazayeri, you can switch if you have no new files you need to add version control because those get lost
|
01:16:01
|
<wyclif> djazayeri, am abit lucky that most of my new files were jsps and i had just run mvn clean install so i can copy them from the omod file
|
01:16:19
|
<djazayeri> whew
|
01:16:30
|
<wyclif> djazayeri, i only have to rewrite a controller that actually had little code, i will edit the wiki page
|
01:19:38
|
*** madroach has quit IRC
|
01:21:15
|
*** madroach has joined #openmrs
|
01:54:28
|
*** mseaton has joined #openmrs
|
01:54:28
|
*** ChanServ sets mode: +v mseaton
|
02:07:41
|
*** mseaton has left #openmrs
|
02:12:57
|
*** lh has quit IRC
|
02:24:28
|
*** lh has joined #openmrs
|
02:24:34
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Event Module 1.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=event&version=&1.1>
|
02:34:45
|
*** lh has quit IRC
|
02:45:02
|
*** lh has joined #openmrs
|
02:45:03
|
*** lh has joined #openmrs
|
02:53:06
|
*** bwolfe has joined #openmrs
|
02:53:07
|
*** ChanServ sets mode: +o bwolfe
|
03:00:55
|
*** suranga has joined #openmrs
|
03:00:55
|
*** ChanServ sets mode: +v suranga
|
03:01:44
|
<suranga> howdy bwolfe :)
|
03:01:53
|
<bwolfe> hi suranga
|
03:02:25
|
<suranga> bwolfe, just wanted to say that i just managed to solve something I ment to ask you last night :P
|
03:02:57
|
<suranga> on average, if i dont ask you something, it takes me 3-5 hours to fix :)
|
03:22:46
|
<bwolfe> suranga, ha
|
03:23:05
|
<suranga> bwolfe, thats not a bad average, is it ? :P
|
03:23:29
|
<bwolfe> suranga, if you pretend to ask me, sometimes that helps :-)
|
03:23:36
|
<bwolfe> its the power of me around...
|
03:23:53
|
<bwolfe> like earlier with rafal/daniel/joaquin.
|
03:23:53
|
<suranga> bwolfe, he hee
|
03:23:55
|
<bwolfe> :-D
|
03:24:09
|
<suranga> bwolfe, um... sorry, did not understand that one..
|
03:24:23
|
<suranga> do u mean that they used to bug you a lot a long time back ? :)
|
03:24:40
|
<bwolfe> no, meaning they had a problem they couldn't solve and so asked me
|
03:24:52
|
<bwolfe> I asked a few questions, and it magically solved itself
|
03:25:45
|
<suranga> bwolfe, :-D
|
03:26:20
|
<suranga> that sounds like rubber duck debugging ....
|
03:55:44
|
*** kishoreyekkanti has joined #openmrs
|
03:57:32
|
*** bwolfe has quit IRC
|
03:58:21
|
*** lh has quit IRC
|
04:23:11
|
*** Echidna has quit IRC
|
04:23:12
|
*** djazayeri has quit IRC
|
04:23:52
|
*** djazayeri has joined #openmrs
|
04:23:53
|
*** ChanServ sets mode: +o djazayeri
|
04:28:26
|
*** Echidna has joined #openmrs
|
04:28:26
|
*** zelazny.freenode.net sets mode: +v Echidna
|
05:13:28
|
*** walkandfish has joined #openmrs
|
06:34:10
|
*** dmexs has joined #openmrs
|
06:50:51
|
*** dmexs has quit IRC
|
07:13:22
|
*** dkayiwa has joined #openmrs
|
07:54:18
|
*** rafa has joined #openmrs
|
07:54:18
|
*** ChanServ sets mode: +v rafa
|
08:05:36
|
*** walkandfish has quit IRC
|
11:14:49
|
*** james_regen has joined #openmrs
|
11:14:49
|
*** ChanServ sets mode: +v james_regen
|
12:21:31
|
*** wyclif has quit IRC
|
12:51:53
|
*** bwolfe has joined #openmrs
|
12:51:53
|
*** ChanServ sets mode: +o bwolfe
|
13:05:30
|
<dkayiwa> hi bwolfe
|
13:08:49
|
<bwolfe> hi dkayiwa
|
13:09:21
|
<dkayiwa> bwolfe: am trying to write a hibernate criteria for REPORT-440
|
13:09:24
|
<dkayiwa> !ticket REPORT-440
|
13:09:25
|
<OpenMRSBot> dkayiwa: [#REPORT-440] Add PersonDataDefinition to calculate an Obs-based Problem List - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-440
|
13:09:34
|
*** wyclif has joined #openmrs
|
13:10:33
|
<dkayiwa> bwolfe: i think i may be forced to write sql (createSqlQuery) because of its complexity, for. Would you recommend it?
|
13:10:55
|
<bwolfe> dkayiwa, you might need multiple queries too
|
13:11:14
|
<bwolfe> or to limit the data asmuch as possible with sql and then remove the rest with java
|
13:11:25
|
<dkayiwa> bwolfe: ok
|
13:11:58
|
<bwolfe> dkayiwa, this has been done before. the clinical summary module has to do this logic. look in one of its util or velocity backing objects for the java method (if it comes to that)
|
13:12:14
|
<dkayiwa> bwolfe: ok
|
13:14:11
|
*** mseaton has joined #openmrs
|
13:14:11
|
*** ChanServ sets mode: +v mseaton
|
13:14:35
|
<dkayiwa> bwolfe: do you mean this? http://svn.openmrs.org/openmrs-modules/clinicalsummary/
|
13:15:54
|
*** mseaton has left #openmrs
|
13:16:47
|
<bwolfe> dkayiwa, looks right
|
13:18:02
|
<bwolfe> dkayiwa, although looks like that module has changed a lot since I last looked at it. win did a lot of work on it
|
13:18:28
|
<dkayiwa> bwolfe: where is the most recent code?
|
13:19:31
|
<bwolfe> dkayiwa, in win's github I think
|
13:19:37
|
<dkayiwa> bwolfe: ok
|
13:29:27
|
*** mseaton has joined #openmrs
|
13:29:27
|
*** ChanServ sets mode: +v mseaton
|
13:31:09
|
*** mseaton has left #openmrs
|
13:41:34
|
*** mseaton has joined #openmrs
|
13:41:34
|
*** ChanServ sets mode: +v mseaton
|
13:42:55
|
*** mseaton has left #openmrs
|
13:44:35
|
*** mseaton has joined #openmrs
|
13:44:36
|
*** ChanServ sets mode: +v mseaton
|
13:58:08
|
*** cpower has joined #openmrs
|
13:58:18
|
*** sgithens has joined #openmrs
|
13:58:35
|
<cpower> Happy "Go to the Apple store and get your new Iphone day"!
|
13:59:09
|
<bwolfe> also known as "selling your soul to the devil for 2 more years day"
|
13:59:30
|
<bwolfe> or "clinging to yesterday's technology because someone told me to day"
|
13:59:31
|
<bwolfe> :-D
|
14:00:43
|
<cpower> the second one hurts a little...the first is true.
|
14:01:03
|
<cpower> You know what would make me feel better?
|
14:01:05
|
<bwolfe> it hurts because its true...
|
14:01:29
|
<bwolfe> !seen downey
|
14:01:30
|
<OpenMRSBot> bwolfe: downey was last seen in #openmrs 19 hours, 10 minutes, and 32 seconds ago: <downey> Hi RaymondS and welcome to the #openmrs IRC channel.
|
14:01:36
|
<cpower> A Scrum!
|
14:01:55
|
<cpower> !scrumon cpower
|
14:01:55
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:02:25
|
<bwolfe> a scrum? what is a scrum? I am unfamiliar with this brand new term to me
|
14:03:07
|
<cpower> Order: dkayiwa, rafa, mseaton, wyclif, bwolfe, djazayeri and Andrea when she teleports in during
|
14:03:22
|
<suranga> me last :)
|
14:03:47
|
<dkayiwa> About to commit: Add PersonDataDefinition to calculate an Obs-based Problem List - REPORT-440
|
14:03:48
|
<dkayiwa> No Blockers
|
14:04:13
|
<bwolfe> dkayiwa, just the one? not stuck on that one?
|
14:04:17
|
*** andrea_ has joined #openmrs
|
14:04:22
|
<dkayiwa> bwolfe: was stuck
|
14:04:48
|
<cpower> we will leave that as a discussion point
|
14:04:51
|
<cpower> rafa!
|
14:04:53
|
<dkayiwa> ok
|
14:05:08
|
<rafa> Today:
|
14:05:08
|
<rafa> * Worked on META-264: Trying to import a MDS package with nested roles fails
|
14:05:08
|
<rafa> https://tickets.openmrs.org/browse/META-264 (reproduced, stuck for a while, but I think I found a cause)
|
14:05:08
|
<rafa> No blockers.
|
14:05:18
|
<cpower> mseaton
|
14:05:28
|
<mseaton> ticket review of patient summary sprint. no blockers.
|
14:05:35
|
<andrea_> sorry to be late - connection problems due to an outside line
|
14:05:41
|
<wyclif> Thursday:
|
14:05:41
|
<wyclif> dev call
|
14:05:41
|
<wyclif> PS-10 - Patient Summary UI: Create/edit a PatientSummaryReportDefinition
|
14:05:41
|
<wyclif> PS-11 - Patient Summary UI: List all available PatientSummaryReportDefinitions
|
14:05:41
|
<wyclif> Friday:
|
14:05:42
|
<wyclif> Still working on PS-10 and PS-11 - Listing/creating/editing patient summary definitions
|
14:05:44
|
<wyclif> Review TODOs for PS-1 to use PatientSummaryService- Add Patient Dashboard Tab Extension for displaying one or more patient summaries
|
14:05:47
|
<wyclif> pick anothe sprint ticket
|
14:05:49
|
<wyclif> Blockers: None
|
14:05:53
|
<bwolfe> andrea_, you're after djazayeri
|
14:05:59
|
<andrea_> ok
|
14:06:05
|
<bwolfe> Thursday
|
14:06:05
|
<bwolfe> emails
|
14:06:05
|
<bwolfe> triaged 3 tickets
|
14:06:05
|
<bwolfe> dev call
|
14:06:05
|
<bwolfe> pm call
|
14:06:06
|
<bwolfe> bp meeting
|
14:06:08
|
<bwolfe> Friday
|
14:06:10
|
<bwolfe> emails
|
14:06:12
|
<bwolfe> finish UIFR-44
|
14:06:14
|
<bwolfe> call with interviewee
|
14:06:16
|
<bwolfe> call with tw
|
14:06:18
|
<bwolfe> no blockers
|
14:06:30
|
<cpower> aww and I had a whole transporter thing I was going to do for Andrea...
|
14:06:48
|
<wyclif> cpower, transporter?
|
14:06:53
|
<cpower> djazayeri you are up
|
14:06:53
|
<andrea_> what transporter thing?
|
14:07:13
|
<bwolfe> you mean teleport?
|
14:07:25
|
<cpower> I really meant transporter
|
14:08:06
|
<bwolfe> cpower, like Jason Statham style? http://www.imdb.com/title/tt0293662/
|
14:08:12
|
<cpower> oooh good one
|
14:08:14
|
<djazayeri> hey, sorry
|
14:08:20
|
<djazayeri> Today: Mirebalais
|
14:08:24
|
<cpower> nice of you to show go for it.
|
14:08:26
|
<djazayeri> * integrating idgen
|
14:08:40
|
<djazayeri> * dealing with difficulty of unit testing around event module
|
14:08:53
|
<djazayeri> blockers: difficulty unit testing around event module
|
14:09:24
|
<cpower> Andrea it is your turn
|
14:09:41
|
<cpower> I'll save my puns and funny's for another time
|
14:09:50
|
<bwolfe> thank goodness
|
14:09:56
|
<bwolfe> I pity the future me though
|
14:10:17
|
<bwolfe> andrea_, ?
|
14:10:20
|
<andrea_> did do a wrong step in getting code form git
|
14:10:45
|
<bwolfe> andrea_, I was meaning its your turn for the daily update
|
14:10:58
|
<bwolfe> or is that question the entirety of it? :-)
|
14:11:07
|
<andrea_> communicated with djazayeri best I could - kept getting bumperd off irc
|
14:11:42
|
<andrea_> blocker - know how to fix that problem but not authentication error
|
14:12:15
|
<andrea_> today - get into office - fix problem
|
14:12:42
|
<andrea_> I do have a question later
|
14:12:43
|
<bwolfe> which problem? the bumping? or the auth?
|
14:12:51
|
<andrea_> auth
|
14:12:51
|
<bwolfe> ok, nm, we'll discuss after scrum
|
14:13:02
|
<cpower> and with that...
|
14:13:05
|
<bwolfe> sorry, I keep forgetting
|
14:13:07
|
<bwolfe> suranga is last
|
14:13:21
|
<cpower> ok fine Suranga if you are here go for it
|
14:13:35
|
<suranga> hi
|
14:13:35
|
<suranga> DONE
|
14:13:36
|
<suranga> hl7qry-55 review comments, all done. ticket can be closed
|
14:13:36
|
<suranga> Article on openmrs hl7qry sprint for ACM submitted for second editorial review (yay !!)
|
14:13:36
|
<suranga> To Do
|
14:13:36
|
<suranga> Brainstorm new hl7qry ideas (maybe add a queue !)
|
14:13:54
|
<suranga> no blockers :)
|
14:14:21
|
<cpower> Discussion points:
|
14:14:38
|
<cpower> Andrea: Problems with Authentication
|
14:14:57
|
<andrea_> may I discuss aut problem?
|
14:15:19
|
<djazayeri> yes
|
14:15:33
|
<andrea_> I can sign in to github but get auth error when I try to clone or push
|
14:15:36
|
<bwolfe> !scrumoff
|
14:15:36
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:15:44
|
<cpower> dkayiwa: being stuck on a ticket Repor440t-
|
14:16:05
|
<cpower> umexcuse me that's my line
|
14:16:47
|
<cpower> Blockers: djazayeri: unit tests
|
14:18:05
|
<wyclif> hi mseaton
|
14:18:15
|
<djazayeri> let's take these in order
|
14:18:26
|
<djazayeri> andrea_: you installed the github app for windows?
|
14:18:35
|
<bwolfe> andrea_, how are you pushing? command line? did you reclone it from your fork's url?
|
14:18:54
|
*** sgithens has quit IRC
|
14:20:21
|
<andrea_> yes from cmd line need to reclone
|
14:20:36
|
<andrea_> get auth error there
|
14:20:39
|
<djazayeri> andrea_: did you install the github app for windows?
|
14:21:35
|
<andrea_> the installation stopped - that's when I called at&t and found there was a problem with phone line
|
14:21:47
|
<bwolfe> att--
|
14:21:53
|
<andrea_> will go to office and do that
|
14:22:05
|
<andrea_> yes att
|
14:22:06
|
*** cpower has quit IRC
|
14:26:57
|
<andrea_> djazayeri, bwolfe may I ping you later from office?
|
14:27:03
|
<djazayeri> andrea_: yes
|
14:27:10
|
<djazayeri> okay, so my blocker: unit tests in the event module
|
14:27:11
|
<andrea_> good!
|
14:27:18
|
<bwolfe> no. I block all pings.
|
14:27:26
|
<djazayeri> rather, unit tests in a module depending on the event module
|
14:27:29
|
<bwolfe> at least on the standard port. ping me on port 80. ;-)
|
14:27:48
|
<andrea_> very funny - later guys
|
14:27:49
|
<bwolfe> djazayeri, did you see mike's reply?
|
14:28:00
|
<djazayeri> bwolfe: yes, and we'll try that
|
14:28:45
|
<djazayeri> bwolfe: but I'm pretty sure that's not ideal, and it will have other side-effects.
|
14:29:18
|
<djazayeri> bwolfe: I'm wondering if during the work on the atomfeed module, people ran into this sort of issue?
|
14:29:37
|
<djazayeri> bwolfe: i.e. was this already looked into a bit, and you all decided it was too hard to unit test against the event module?
|
14:29:39
|
<bwolfe> djazayeri, I dont' remember trying to write a full round trip test in atomfeed
|
14:30:18
|
<bwolfe> its possible, you just have to manually register the aop
|
14:30:55
|
<djazayeri> bwolfe: that's what we had to do
|
14:30:56
|
*** suranga has quit IRC
|
14:31:17
|
<djazayeri> bwolfe: in general, the @StartModule annotation seems to me like it doesn't work...
|
14:31:51
|
<bwolfe> I haven't tried it from a module, only in core
|
14:32:36
|
<djazayeri> bwolfe: I see. We ran into class cast exceptions between the started version (from the omod) and the classes we're including via maven dependency
|
14:32:47
|
<djazayeri> bwolfe: so it makes sense that it would work from core.
|
14:33:40
|
<djazayeri> bwolfe: so, if I put a @NotTransactional annotatino on our test, won't that pollute the test database for all other tests during that run?
|
14:34:07
|
<djazayeri> I'll try that out and see, but that's my worry.
|
14:34:28
|
<djazayeri> otherwise, do we have any examples of tests that write data in one thread and read it from another?
|
14:34:57
|
<bwolfe> are you working against latest core or earlier version?
|
14:35:02
|
<djazayeri> bwolfe: 1.9.1
|
14:35:24
|
<bwolfe> ok, so rafa's change to tests rollback/cleanup would not come into play
|
14:49:11
|
<wyclif> hi ms
|
14:49:14
|
<wyclif> hi ms
|
14:49:16
|
<wyclif> hi mseaton
|
14:57:50
|
<mseaton> hey wyclif
|
14:58:24
|
<bwolfe> hi wy
|
14:58:26
|
<bwolfe> hi wy
|
14:59:21
|
<wyclif> mseaton, for PS-10
|
15:00:05
|
<wyclif> mseaton, a patient summary report definition should have exactly one dataset definition, right?
|
15:00:19
|
<mseaton> wyclif, correct
|
15:05:18
|
<wyclif> mseaton, can you look at the constructor for addDatasetDefinition method you added for PatientSummaryReportDefinition
|
15:05:37
|
<wyclif> mseaton, i always throws an error for me
|
15:06:34
|
<wyclif> that there multiple datasets even when there is one or none, i think one of the other conditions fails but throws the same error msg which can be misleading
|
15:09:03
|
*** kishoreyekkanti has quit IRC
|
15:16:40
|
*** lh has joined #openmrs
|
15:16:40
|
*** lh has joined #openmrs
|
15:28:22
|
<mseaton> wyclif, ok, can look. you can disable what i did for now, and we can re-visit later if needed.
|
15:29:34
|
*** dkayiwa has left #openmrs
|
15:36:05
|
<wyclif> mseaton, ok
|
15:36:25
|
<wyclif> mseaton, i just commented out throwing the exception for now
|
15:47:49
|
*** andrea_ has quit IRC
|
16:06:31
|
*** kishoreyekkanti has joined #openmrs
|
16:49:57
|
*** rafa has quit IRC
|
16:52:47
|
*** suranga has joined #openmrs
|
16:52:47
|
*** ChanServ sets mode: +v suranga
|
16:56:46
|
*** james_regen has left #openmrs
|
17:42:22
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @aldrengonzales: Me reporting #OpenMRS in class.. Bagong classroom ;) Thanks @edricevan for the pic @ UP College of Medicine http:// ... <http://twitter.com/OpenMRS/statuses/249195238353149954>
|
18:08:25
|
*** applecool has joined #openmrs
|
18:08:26
|
*** ChanServ sets mode: +v applecool
|
18:10:25
|
*** applecool has quit IRC
|
18:14:25
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: 18 days and counting until #OMRS12. Are you ready? Are you registered? http://t.co/LHz3e7sW #OpenMRS #ICT4D #HealthIT <http://twitter.com/OpenMRS/statuses/249205563815256064> || On Twitter: OpenMRS: @suranga_kas Sounds good to us! <http://twitter.com/OpenMRS/statuses/249204882509295616> || On Twitter: OpenMRS: RT @RegenstriefGHI: Picture of #Rwanda nurse entering patient data in RHEA Point of Care module in real time! #RHEA_HIE @jembi_hs @OpenM ... <http://twitter.com/OpenMRS/statuses/249203899817418752> || On Twitter: OpenMRS: RT @harshadura: OpenMRS Feedback Module - User guide Presentation targeting implementers usage Done by me @OpenMRS University Forum :) ... <http://twitter.com/OpenMRS/statuses/249201940968390656>
|
18:31:07
|
*** lh has quit IRC
|
18:31:50
|
*** suranga has quit IRC
|
19:14:18
|
*** srinath_ has joined #openmrs
|
19:20:01
|
<srinath_> hi
|
19:34:35
|
*** srinath_ has quit IRC
|
19:57:17
|
*** lh has joined #openmrs
|
19:57:17
|
*** lh has joined #openmrs
|
21:14:53
|
*** bwolfe has quit IRC
|
21:26:31
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Congrats to @Jembi_HS for switching on this week the first of many sites of the new open source Rwanda HIE: http://t.co/B7Z7RtAk #HealthIT <http://twitter.com/OpenMRS/statuses/249247791531040770> || OpenMRS Modules: Synchronization 1.0.5 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=sync&version=&1.0.5>
|
21:40:28
|
*** mseaton has quit IRC
|
22:37:18
|
*** wyclif has quit IRC
|
22:55:19
|
*** andreapat has joined #openmrs
|
22:55:44
|
<andreapat> djazayeri, hi u around?
|
22:58:34
|
<andreapat> djazayeri
|
23:02:51
|
<djazayeri> andreapat: hi
|
23:04:34
|
<andreapat> djazayeri, hi
|
23:04:40
|
<djazayeri> you had a question?
|
23:05:37
|
<andreapat> yes - created new git account and got github client for windows
|
23:06:30
|
<andreapat> djazayeri, created new git account and got github client for windows - is there doc on how to use it?
|
23:07:03
|
<djazayeri> andreapat: OpenMRS doesn't have any specific docs on the github clients. I'm sure github does. Though I imagine they're pretty intuitive.
|
23:07:31
|
<djazayeri> Presumably you need to just fork openmrs-core on the github website, and then click "Cone to Windows" on your fork.
|
23:09:07
|
<andreapat> djazayeri, thanks
|
23:38:58
|
*** wyclif has joined #openmrs
|
23:52:53
|
*** mseaton has joined #openmrs
|
23:52:53
|
*** ChanServ sets mode: +v mseaton
|