IRC Chat : 2012-09-14 - OpenMRS

01:00:58 *** r0bby has joined #openmrs
01:00:58 *** ChanServ sets mode: +v r0bby
01:01:23 *** robbyoconnor has quit IRC
01:39:22 *** andreapat has quit IRC
02:08:33 *** r0bby has quit IRC
04:01:01 *** kishoreyekkanti has joined #openmrs
05:32:52 *** robbyoconnor has joined #openmrs
05:32:52 *** ChanServ sets mode: +v robbyoconnor
05:33:10 *** robbyoconnor has quit IRC
05:33:32 *** robbyoconnor has joined #openmrs
05:33:32 *** ChanServ sets mode: +v robbyoconnor
05:36:21 *** robbyoconnor has quit IRC
05:36:28 *** r0bby has joined #openmrs
05:36:28 *** ChanServ sets mode: +v r0bby
05:39:00 *** r0bby has quit IRC
05:39:24 *** r0bby has joined #openmrs
05:39:24 *** ChanServ sets mode: +v r0bby
05:42:33 *** r0bby is now known as robbyoconnor
07:58:02 *** dkayiwa has joined #openmrs
08:02:07 *** dkayiwa has quit IRC
08:03:41 *** dkayiwa has joined #openmrs
08:09:07 *** dkayiwa_ has joined #openmrs
08:09:09 *** dkayiwa has quit IRC
08:09:10 *** dkayiwa_ is now known as dkayiwa
08:29:14 *** kishoreyekkanti has quit IRC
08:30:15 *** kishoreyekkanti has joined #openmrs
09:07:58 *** kishoreyekkanti has quit IRC
09:09:51 *** kishoreyekkanti has joined #openmrs
09:11:03 *** robbyoconnor has quit IRC
09:42:54 *** upul` has joined #openmrs
09:42:54 *** ChanServ sets mode: +v upul`
10:07:01 *** nathanleiby has joined #openmrs
10:46:59 *** kishoreyekkanti_ has joined #openmrs
10:47:00 *** kishoreyekkanti has quit IRC
10:47:00 *** kishoreyekkanti_ is now known as kishoreyekkanti
10:50:59 *** kishoreyekkanti has quit IRC
11:05:38 *** kishoreyekkanti has joined #openmrs
11:12:11 *** upul` has quit IRC
11:13:18 *** james_regen has joined #openmrs
11:13:18 *** ChanServ sets mode: +v james_regen
11:31:36 *** kishoreyekkanti has quit IRC
11:41:37 *** nathanleiby has quit IRC
12:05:13 *** rfriedman has joined #openmrs
12:05:46 *** rfriedman is now known as rfriedman_away
12:16:54 *** wyclif has quit IRC
12:19:58 *** jkeiper has joined #openmrs
12:20:22 *** jkeiper_ has joined #openmrs
12:28:32 *** kavuri has joined #openmrs
12:31:30 *** nathanleiby has joined #openmrs
12:32:44 *** downey has joined #openmrs
12:32:44 *** ChanServ sets mode: +o downey
12:32:44 *** OpenMRSBot sets mode: +o downey
12:47:24 *** bwolfe has joined #openmrs
12:47:24 *** ChanServ sets mode: +o bwolfe
12:49:20 *** suranga has joined #openmrs
12:49:20 *** ChanServ sets mode: +v suranga
12:57:13 *** rfriedman_away is now known as rfriedman
12:57:28 <rfriedman> bwolfe, hi ben
12:57:41 <bwolfe> hi roger
12:58:19 <rfriedman> bwolfe, while working on RESTWS-267, I discovered that maptype had not been exposed in ConceptReferenceTermMap.java
12:58:44 *** wyclif has joined #openmrs
12:58:59 <rfriedman> i'm surprised that that did not generate a "missing setter/getter" message because it's in hbm.xml
13:00:11 *** downey has quit IRC
13:01:25 <bwolfe> rfriedman, its up one level in the "BaseMapType" class
13:02:08 <rfriedman> bwolfe, oh that's great, no problem then ... just shows the worthlessness of that class
13:02:21 *** piyushmadan has joined #openmrs
13:02:43 <rfriedman> bwolfe, super, i am much happier
13:03:17 <bwolfe> haha, if its used by multiple classes, its not totally worthless. (which it looks like it is extended by 2 class)
13:04:57 *** rfriedman is now known as rfriedman_away
13:05:24 *** kishoreyekkanti has joined #openmrs
13:05:54 *** kishoreyekkanti has joined #openmrs
13:11:47 *** mseaton has joined #openmrs
13:11:47 *** ChanServ sets mode: +v mseaton
13:12:33 <rfriedman_away> bwolfe, has there been another change to the startup directory? in 1.9.x HEAD it is not looking in ~/.OpenMRS
13:16:35 *** robbyoconnor has joined #openmrs
13:16:35 *** ChanServ sets mode: +v robbyoconnor
13:37:34 <suranga> hellloooo bwolfe :-) :-)
13:37:46 <bwolfe> hi suranga
13:37:57 <bwolfe> rfriedman_away, no change that I know of
13:38:21 <suranga> bwolfe, sorry about yesterday... I was wonderinf if you had some time to look at my proposed design for error logging for the hl7query module now..
13:38:33 <bwolfe> suranga, sure
13:38:42 <suranga> bwolfe, i want to make sure i get it right, because we will have to use it a lot :)
13:38:45 <suranga> bwolfe, its on http://pastebin.com/67q15yka
13:39:48 <bwolfe> wyclif, can you add your face/icon to jira? https://tickets.openmrs.org/secure/ViewProfile.jspa (its via linking to gravatar)
13:40:12 <wyclif> bwolfe, ok
13:40:12 <bwolfe> rfriedman_away, can you also add your profile pic? :-) https://tickets.openmrs.org/secure/ViewProfile.jspa
13:40:42 <bwolfe> dkayiwa, you also need a profile pic. :-)
13:40:44 <bwolfe> https://tickets.openmrs.org/secure/ViewProfile.jspa
13:40:49 <wyclif> bwolfe, i wonder wonder what happened to the old one
13:41:01 <dkayiwa> bwolfe: don't i already have one?
13:41:05 <bwolfe> wyclif, jira upgrade. now it connects to gravatar instead of using a built-in thing
13:42:06 <rfriedman_away> bwolfe, any suggestions on how I can get it pointed there?
13:42:22 * suranga goes to look at my own pic
13:44:16 <suranga> um... im still the usual 'ol me on jira.. hmmm.,..........
13:44:18 <rfriedman_away> bwolfe, gravatar doesn't work
13:44:30 <bwolfe> rfriedman_away, you just add your email that you use for jira to gravatar
13:44:36 <bwolfe> and it magically links up (iirc)
13:44:45 <rfriedman_away> bwolfe, i can't even get to the site
13:45:20 <bwolfe> rfriedman_away, works for me...
13:45:28 *** rfriedman_away is now known as rfriedman
13:46:18 <rfriedman> bwolfe, i don't give a snake's leg for my avatar, I'd really like to be able to run OpenMRS
13:46:58 <dkayiwa> hi jkeiper
13:47:06 <bwolfe> rfriedman, 1.9.x loaded up for me a few days ago finding the .OpenMRS folder...
13:47:32 <bwolfe> dkayiwa, you have RESTWS tickets to finish, why are you doing core ones? :-/
13:47:40 <bwolfe> dkayiwa, oh, bug fixing swim lane. bah!
13:47:42 *** cpower has joined #openmrs
13:47:50 <dkayiwa> bwolfe: 40% bug fixing :0
13:48:04 <bwolfe> yeah, shoot
13:48:17 <bwolfe> dkayiwa, there are two tickets still assigned to you on the sprint. should we move those to wyclif?
13:48:28 <dkayiwa> bwolfe: yes please :)
13:50:43 *** sgithens has joined #openmrs
13:52:16 *** mseaton has left #openmrs
13:52:26 <rfriedman> bwolfe, you run maven from command line?
13:52:37 <rfriedman> mvn jetty:run?
13:54:44 <bwolfe> rfriedman, always
13:56:28 <bwolfe> rfriedman, can you get martin to add an explicit step by step to repeat: https://tickets.openmrs.org/browse/RESTWS-286
13:56:31 <bwolfe> cc wyclif ^^
13:56:37 <rfriedman> bwolfe, what directory do you start in?
13:57:02 <rfriedman> bwolfe, martin is on vacation, I have the data, I need to load it
13:57:12 <bwolfe> rfriedman, I mvn jetty:run from my ~/workspace/openmrs-core/webapp and the ~/.OpenMRS/openmrs-runtime.properties is used
13:57:43 <wyclif> bwolfe, what's up?
13:58:11 <bwolfe> wyclif, I reassigned a ticket of daniels to you (286) that is waiting on info from rfriedman. I didn't want you to work and get confused on it too early
13:58:13 <rfriedman> bwolfe, wyclif, try installing jsslab module (depends on logic, restws) and selecting demo data
13:58:50 <bwolfe> wyclif, I also just assigned daniel's 256 to you
13:59:24 <cpower> They went as far as stealing my laptop for the next 6 hours to brainwash it to Windows Enterprise, but did that stop me from being here for the Scrum Noooo...
14:00:05 <cpower> Are we ready to Scrum?
14:00:39 <wyclif> bwolfe, ok
14:00:42 <rfriedman> bwolfe, here is where it starts via mvn run config for jettty:run -- /home/rfriedman/gitrepos/openmrs-core/webapp/openmrs-runtime.properties
14:00:45 <nathanleiby> cpower: sure
14:00:53 <cpower> that's the spirit..
14:01:01 <cpower> !scrumon cpower
14:01:01 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
14:01:04 <bwolfe> rfriedman, it looks there first, yes. then it looks in other places
14:01:13 <bwolfe> rfriedman, I think that was at your request, wasn't it? :-)
14:01:16 <cpower> I never get tired of saying scrum on...
14:01:32 <rfriedman> bwolfe, no, I opposed that, I wanted it to look for an environment variable first
14:01:49 <rfriedman> stupid automatic stuff never works
14:02:04 <nathanleiby> cpower: who goes first?
14:02:11 <cpower> Order: bwolfe , wyclif, suranga , rfriedman, dkayiwa, nathanleiby
14:03:40 <bwolfe> shoot, haven't even started my scrum file for today
14:03:50 <bwolfe> * reviewed RESTWS tickets
14:03:59 <bwolfe> * reassigned tickets to wyclif (from daniel)
14:04:25 <bwolfe> * plan dev call with darius/burke
14:04:28 <bwolfe> no blockers
14:04:55 <cpower> wyclif go!
14:04:59 *** downey has joined #openmrs
14:04:59 *** ChanServ sets mode: +o downey
14:04:59 *** OpenMRSBot sets mode: +o downey
14:05:28 *** andrea_ has joined #openmrs
14:05:49 <nathanleiby> wyclif: you there?
14:05:51 <cpower> ok, next...
14:06:01 <cpower> suranga do you have anything to report?
14:06:03 <wyclif> hold on..
14:06:11 <wyclif> Thursday:
14:06:11 <wyclif> cleaning up past tickets and my github fork, also made follow up on tickets with pull requests
14:06:11 <wyclif> dev call
14:06:11 <wyclif> HGI quarterly meeting
14:06:11 <wyclif> Added Base resource classes for Attributes and attributes and refactored Location and Provider attributes/attribute type resources
14:06:13 <wyclif> Add resources and controllers for VisitAttribute and VisitAttributeType
14:06:14 <wyclif> Friday:
14:06:16 <wyclif> Finish up resources and controllers for VisitAttribute and VisitAttributeType
14:06:18 <wyclif> RESTWS-286 - "answers" and "setMembers" don't work correctly
14:06:20 <wyclif> Remaining TODOs for RESTWS-256 - Add support for ActiveList: Allergy and Problems
14:06:22 <wyclif>
14:06:24 <wyclif> Blockers: None
14:07:03 <cpower> ok, Suranga are you there?
14:07:48 *** robbyoconnor has quit IRC
14:08:02 <rfriedman> case sensitive?
14:08:22 <bwolfe> shouldn't be
14:08:32 <bwolfe> pass suranga
14:08:37 <rfriedman> BWOLFE, we'll soon find out!
14:08:49 <bwolfe> not case sensitive for xchat...
14:08:53 <bwolfe> (apparently)
14:08:53 <rfriedman> RESTWS-267 -- testing
14:08:53 <rfriedman> Blockers: running OpenMRS
14:08:54 <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @s_purkayastha: @kishoreyekkanti super work on the jbehave demo on today's @OpenMRS dev call. Loved it!! <http://twitter.com/OpenMRS/statuses/246608162105470977>
14:09:04 <andrea_> anyone here?
14:09:20 <rfriedman> andrea_, scrum time
14:09:25 <nathanleiby> andrea_: yup!
14:09:27 <bwolfe> andrea_, you can go after nathanleiby
14:09:28 <andrea_> I'm here
14:09:32 <dkayiwa> Reviewed: Remove Null Pointer Exception when try to see create new patient page without any input parameters - XFRM-93
14:09:33 <dkayiwa> Committed: Encounter autocomplete should filter results by patient - TRUNK-3231
14:09:33 <dkayiwa> Working on: Changed by information not updated when concept names/synonyms are edited, added or removed - TRUNK-3337
14:09:33 <dkayiwa> No Blockers
14:09:58 <nathanleiby> Yesterday:
14:09:58 <nathanleiby> -Got environment set up in eclipse. downloaded openMRS standalone but not using it at all yet.
14:09:58 <nathanleiby> -Checked out restws from svn. Did maven clean build, and ran tests. seemed successful
14:09:58 <nathanleiby> -Working on RESTWS-230. Found file DrugResource.java which I need to update. wrote a simple patch where I added createable and updateable methods
14:10:05 <nathanleiby> Today:
14:10:05 <nathanleiby> -update patch with correct fields. once I submit patch, will request Code Review
14:10:10 <nathanleiby> Blockers:
14:10:11 <nathanleiby> -how do determine which properties should be required/optional for creatable and updateable?
14:10:11 <nathanleiby> -should the creatable and updateable properties be identical? or any differences?
14:10:29 <cpower> and Andrea your turn
14:10:48 <andrea_> Thursday - fixing problem of no data - had to reinstal mysql due to
14:10:48 <andrea_> password problem. ok npw.,
14:10:48 <andrea_> Merck training. Blockers: question on git upstream remote, forking a repo
14:10:48 <andrea_> Today finish fixing problem merck training so I can get paid.
14:11:02 <dkayiwa> :D
14:11:28 <rfriedman> andrea_, can you fix it up so they pay me too?
14:11:33 <bwolfe> :-)
14:11:36 <dkayiwa> :D
14:11:41 <bwolfe> rfriedman, fly to SFO, attend training, get paid
14:11:47 <nathanleiby> andrea_: I'm happy to help with git questions
14:11:51 <andrea_> will try
14:11:54 <andrea_> ok
14:11:59 <dkayiwa> d:)
14:12:20 <andrea_> ok nathanleiby
14:12:29 <cpower> Ok lots of stuff today
14:13:17 <cpower> Blockers: <rfriedman> Blockers: running OpenMRS
14:13:38 <rfriedman> bwolfe, i can't get to their site
14:13:47 <cpower> <nathanleiby> Blockers:
14:13:47 <cpower> <nathanleiby> -how do determine which properties should be required/optional for creatable and updateable?
14:13:47 <cpower> <nathanleiby> -should the creatable and updateable properties be identical? or any differences?
14:13:57 <rfriedman> bwolfe, sorry, was scrolled up
14:14:00 <cpower> andrea_> Merck training. Blockers: question on git upstream remote, forking a repo
14:14:38 <rfriedman> nathanleiby, re creatable/updatable
14:14:44 <cpower> !scrumoff
14:14:44 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:14:56 <bwolfe> nathanleiby, you look at the pojo to see what is required. and/or the pojo validator. and/or the pojo's associated database table.
14:15:00 <andrea_> Yes just a minutre
14:15:07 <bwolfe> (but usually it is obvious)
14:15:09 <andrea_> minute that is
14:15:35 <rfriedman> nathanleiby, creatable = updatable unless there is a collection property, those are not updatable
14:16:03 <nathanleiby> bwolfe: does the pojo live in openmrs-core, rest-ws, or elsewhere?
14:16:29 <rfriedman> nathanleiby, openmrs-api project
14:16:52 *** kavuri has quit IRC
14:16:52 <nathanleiby> rfriedman: cool, thanks for help on creatable and updateable. ill check in the drug pojo to see if there's a colletion
14:17:06 <andrea_> git tag -1
14:17:08 <djazayeri> nathanleiby: taking a quick peek at Drug.java, I think creatable = updatable in that case.
14:19:55 <bwolfe> nathanleiby, which means you only have to implement the creatable method. The default impl of getUpdatable just returns the creatable
14:20:11 <nathanleiby> bwolfe: ok
14:20:24 <nathanleiby> djazayeri: checking here https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/Drug.java one moment
14:20:25 <bwolfe> rfriedman, is it just not finding your runtime props? or do you have a bad database defined in the runtime props? or do you have an extra runtime props file defined?
14:20:28 <OpenMRSBot> <http://ln-s.net/$oaG> (at github.com)
14:22:45 <andrea_> question: git tag -l shows latest opemnrs-1.8.3. shouldn't it be 1.9?l
14:23:15 <djazayeri> andrea_: git tag -l means to list the tags
14:23:45 <djazayeri> IIRC if you do a plain clone, tags aren't copied over to you by default
14:23:51 <djazayeri> (but maybe I'm wrong about that)
14:24:03 <nathanleiby> rfriedman, bwolfe, djazayeri: Drug.java has one collection "ingredients". Does that mean I need to handle updateable differently?
14:24:03 <andrea_> I know - why is latest 1.8.3?
14:25:13 <andrea_> djazayeri, was that plain clone for me?
14:25:45 <djazayeri> nathanleiby: oh, hmm, that's added in 1.10, huh. I was looking at the 1.9 codebase. :-) I would ignore that collection for now, and create a ticket in JIRA with low priority to update RESTWS to handle changes to Drug in 1.10
14:25:55 <bwolfe> rfriedman, is it still looking for "openmrs"-runtime.properties? or is it looking for "openmrs-webapp"-runtime.properties?
14:26:05 <bwolfe> (I see the latter in my folder for some reason)
14:32:27 <rfriedman> bwolfe, you get the latter from running unit tests
14:32:40 <rfriedman> bwolfe, i was able to start mine like you start yours
14:33:00 *** kdeeq has joined #openmrs
14:33:40 <rfriedman> bwolfe, there was a weirdness in that a maven run config of jetty:run worked but choosing run as Jetty didn't ... maybe shoe is on other foot now
14:34:22 <bwolfe> rfriedman, I dislike how eclipse runs maven things
14:35:04 <rfriedman> nathanleiby, that means it is creatable but not updatable
14:35:18 <dkayiwa> hi jkeiper
14:35:19 <rfriedman> bwolfe, i can see, that's why you're at the command line
14:35:45 <bwolfe> rfriedman, yes. and I feel the same about how eclipse handles git commands. :-)
14:35:50 <bwolfe> commandline++
14:36:07 <rfriedman> nathanleiby, sry, didn't see darius' comment ... means that you have wrong openmrs branch, however
14:36:16 *** nathanleiby has quit IRC
14:37:26 <andrea_> that's my question - what is correct openmrs branch?
14:37:36 <rfriedman> andrea_, 1.9.x
14:38:52 <andrea_> that's what I thought
14:39:35 <suranga> hi bwolfe, I kinda need to go offline for awhile... could you please email me the comments on that sample I showed you once You take a look at it :-)
14:39:52 <bwolfe> suranga, giv eme the link again?
14:39:56 <bwolfe> I missed when you sent it before
14:40:08 <andrea_> rfriedman, will you be around a little later? I need to get into the office -
14:40:37 <suranga> bwolfe, http://pastebin.com/67q15yka :-)
14:40:49 <rfriedman> another couple of hours ... but i don't get audible notifications on this machine, so don't be surprised if I'm late
14:41:04 <andrea_> ok
14:44:08 *** nathanleiby has joined #openmrs
14:44:20 <downey> Hi nathanleiby and welcome to the #openmrs IRC channel.
14:44:33 <nathanleiby> downey: hi
14:47:30 <bwolfe> wyclif, why is OrderType deprecated in 1.9 but it exists undeprecated in 1.10 (core/master)?.
14:47:57 *** kishoreyekkanti has quit IRC
14:49:58 <wyclif> bwolfe, it should be deprecated in 1.10
14:50:02 <bwolfe> wyclif, and you can't get an OrderType from the OrderService anymore?
14:50:30 <bwolfe> Context.getOrderService().getOrderType(OpenmrsConstants.ORDERTYPE_DRUG) fails in restws on 1.10 with "org.openmrs.api.OrderService.getOrderType(Ljava/lang/Integer;)Lorg/openmrs/OrderType" because there is no getOrderType(Integer) method anymore!
14:51:17 <wyclif> bwolfe, there is another form order types that is supposed to be introduced in 1.10
14:51:43 <wyclif> bwolfe, there is still something that is unclear
14:52:13 <bwolfe> wyclif, but I still see Order.orderType there...
14:52:27 <wyclif> bwolfe, the idea was to deprecate things in 1.9 and make the javadocs clear that things are changing in 1.10 which was against convetion
14:52:56 *** piyushmadan has quit IRC
14:54:07 *** suranga has quit IRC
14:56:08 <dkayiwa> hi jkeiper jkeiper_
14:56:25 <jkeiper_> hi dkayiwa
14:56:26 <jkeiper_> :-)
14:56:34 <dkayiwa> :)
14:57:31 <dkayiwa> jkeiper_: if i want to submit xml to hl7 processor to use the id as providerId instead of personId, what do i set the value to?
14:58:22 <jkeiper_> dkayiwa, i think you might have to alter the XSLT
14:58:44 <dkayiwa> jkeiper_: to make it out put what value for the provider
14:58:45 <dkayiwa> ?
14:59:22 <jkeiper_> hrm, you want to direct the ORU^R01 processor to recognize the provider id correct?
14:59:33 <dkayiwa> jkeiper_: perfect
14:59:49 <dkayiwa> jkeiper_: such that i stopes treating it as person_id
14:59:57 <dkayiwa> it stops :)
15:01:04 <jkeiper_> dkayiwa, have you modified the ORU^R01 processor to recognize a different type of identifier?
15:01:22 <dkayiwa> jkeiper_: that is already in trunk
15:01:39 <dkayiwa> jkeiper_: the code i sent to that email you responded to on the dev list
15:01:46 <jkeiper_> ok
15:01:50 <dkayiwa> jkeiper_: it shows the section which deals with that
15:01:59 <jkeiper_> so ... let me look at the XSLT again one sce
15:02:30 <jkeiper_> the providerid should go in the PV1 segment, right?
15:02:49 <dkayiwa> jkeiper_: i am not sure :)
15:02:53 <jkeiper_> currently that is given as this: <xsl:value-ofselect="encounter/encounter.provider_id"/>
15:03:18 <dkayiwa> jkeiper_: ok. if you can tell me the expected value, i can deal with the rest. so all am asking for is, should the value be something like 1L (where 1 is the provider id)?
15:03:27 <jkeiper_> oh
15:03:33 <jkeiper_> well, that depends on the processor heheheh
15:03:45 <dkayiwa> jkeiper_: basing on our processor in trunk :)
15:03:50 <jkeiper_> so, what do you put in <encounter.provider_id> now?
15:03:54 <jkeiper_> before this change?
15:04:04 <dkayiwa> jkeiper_: the person_id
15:04:04 <jkeiper_> like 1^Super User^99DCT
15:04:04 <jkeiper_> ?
15:04:08 <rfriedman> nathanleiby, I think you missed my last msg
15:04:09 <jkeiper_> or just: 1
15:04:15 <rfriedman> nathanleiby, sry, didn't see darius' comment ... means that you have wrong openmrs branch, however
15:04:17 <dkayiwa> jkeiper_: just 1
15:04:21 <jkeiper_> sawa
15:04:23 <jkeiper_> brb ...
15:04:29 <dkayiwa> jkeiper_: now i wanner put the provider_id
15:04:34 <dkayiwa> ok
15:05:20 <nathanleiby> rfriedman: yes i think i missed your last message. should i follow his advice to make a separate bug for the collection that will be added in a future version?
15:05:42 <nathanleiby> rfriedman: but for now stick with createable only (and updateable affecting same props by defaut)
15:06:26 <jkeiper_> dkayiwa: http://hl7api.sourceforge.net/v25/apidocs/ca/uhn/hl7v2/model/v25/datatype/XCN.html
15:06:29 <OpenMRSBot> <http://ln-s.net/$ob9> (at hl7api.sourceforge.net)
15:06:47 <jkeiper_> essentially, you have provided field #0
15:06:55 <jkeiper_> with "1"
15:07:03 <dkayiwa> jkeiper_: ok
15:07:38 <jkeiper_> but you will need 1^Hornblower^Horatio^L^Jr^Dr^MD^^L
15:07:47 <jkeiper_> the last L is the "local"
15:07:55 <jkeiper_> the first one in the list is his middle initial
15:08:01 <jkeiper_> just a coincidence
15:08:03 <dkayiwa> jkeiper_: ok
15:08:15 <jkeiper_> you should be able to test this in a unit test too
15:08:22 <jkeiper_> several examples in the orur01handlertest
15:08:23 <dkayiwa> jkeiper_: ok
15:09:47 <dkayiwa> jkeiper_: the code am talking about is here: http://pastebin.com/Hxf7HkZb
15:10:04 <jkeiper_> yes
15:10:13 <jkeiper_> the AssigningAuthority comes later in that list
15:10:17 <jkeiper_> right where i put it
15:10:17 <jkeiper_> i think
15:10:38 <jkeiper_> in theory you could do: 1^^^^^^^^L
15:10:57 <dkayiwa> jkeiper_: so what i want is submit a value which will make that code branch on this line: provider = Context.getProviderService().getProvider(Integer.valueOf(id));
15:11:04 <dkayiwa> jkeiper_: ok
15:11:10 <jkeiper_> ahhh
15:11:10 <jkeiper_> wait
15:11:13 <jkeiper_> sorry
15:11:20 <jkeiper_> hrm
15:11:24 <jkeiper_> now i'm confused
15:11:29 <dkayiwa> jkeiper_: lolllllll :)
15:11:32 <rfriedman> nathanleiby, yes, it's always helpful to get tickets written ... there are a number of changes in orders going on in 1.10 and some of them affect the way drug info is kept
15:12:09 <jkeiper_> dkayiwa, Assigning Authority is a HD
15:12:19 <jkeiper_> HD is split into IS, ST and ID
15:12:21 <jkeiper_> :-D
15:12:24 <jkeiper_> idk how they are split
15:12:27 <jkeiper_> with ~ perhaps?
15:12:38 <dkayiwa> jkeiper_: i want a value which will make this if condition true. if (HL7Constants.PROVIDER_ASSIGNING_AUTH_PROV_ID.equalsIgnoreCase(assignAuth)) :)
15:13:08 <jkeiper_> ok one sec, need to play with a HL7 for a sec in this thing
15:13:16 *** kdeeq has quit IRC
15:13:17 <dkayiwa> jkeiper_: ok :)
15:14:28 <jkeiper_> dkayiwa, for future: http://hl7api.sourceforge.net/hapi-testpanel/install.html
15:14:32 <OpenMRSBot> <http://ln-s.net/$obE> (at hl7api.sourceforge.net)
15:14:46 <dkayiwa> jkeiper_: ok
15:16:07 *** nathanleiby has quit IRC
15:26:49 *** andrea_ has quit IRC
15:27:30 *** sgithens has quit IRC
15:29:12 *** dkayiwa has left #openmrs
15:34:55 <jkeiper_> nooooooooo
15:35:00 <jkeiper_> lost dkayiwa
15:35:13 <jkeiper_> 1^^^^^^^^&1&L
15:36:58 <rfriedman> bwolfe, I need to get my changes somewhere so I can update my restws19ext to current. how do i do that?
15:39:34 <bwolfe> rfriedman, git stash
15:39:44 <bwolfe> rfriedman, then git apply when you are done
15:39:48 <rfriedman> but this module is not in git
15:40:21 <jkeiper_> worlds colliding
15:41:22 <rfriedman> bwolfe, ^^
15:42:55 <bwolfe> rfriedman, ha, sorry
15:43:09 <bwolfe> rfriedman, create a patch, save it on your filesystem
15:43:16 <bwolfe> rfriedman, revert all changes
15:45:57 <rfriedman> bwolfe, waiting with baited breath
15:46:32 <bwolfe> waiting for way?
15:46:46 <rfriedman> bwolfe, how do my changes get back in?
15:47:57 <bwolfe> rfriedman, apply that patch that you saved again
15:48:37 <rfriedman> and the patches will arrive in the right spot regardless of changes by others?
15:48:40 <bwolfe> git stash / git apply is essentially just doing that for you. its a manually process with svn though
15:48:51 <bwolfe> rfriedman, as long as you have not changed the same files
15:49:04 <bwolfe> although, if the same fiels change but in diff places, it usually applies fine
15:49:28 <bwolfe> if more than 5-10 lines were added, you might need to use the "guess" button in eclipse so it can find where your changes were.
15:49:59 <rfriedman> bwolfe, will it tell me if it finds conflicts? or should i save everything to do a diff ?
15:50:20 <bwolfe> rfriedman, everything is already a diff
15:50:29 <bwolfe> it will show you conflicts as you apply in eclipse
15:50:33 <bwolfe> and you can change/fix there
15:50:46 <rfriedman> ok, thought i might need more context
15:50:50 <bwolfe> or leave a as a conflict and use "team --> edit conflicts" viewer in eclipse
15:51:04 <bwolfe> rfriedman, although you really could have just done an "svn update" without saving your patch
15:51:18 <bwolfe> any conflicts you could have edited with the team-->editconflicts thing after the update
15:51:53 <rfriedman> ok, i will make a patch to be on the safe side, then do an svn update and resolve conflicts
15:52:34 <rfriedman> bwolfe, ok plan?
15:54:10 <bwolfe> yes, thats fine
15:54:12 <bwolfe> backups++
15:59:18 <rfriedman> bwolfe, ok, 13 files added, 1 file merged, no conflicts
15:59:35 <bwolfe> you're gtg then
15:59:36 <bwolfe> :-)
16:00:04 <jkeiper_> booyah
16:00:25 <rfriedman> jkeiper, you're overcoffeed :-)
16:00:43 <jkeiper_> maybe
16:00:49 <jkeiper_> drinking "bali gold"
16:01:07 <jkeiper_> brought by I Nyoman Winardi Ribeka Pratihana
16:01:40 * rfriedman sings "since he's been gone, all that's left is some bali gold"
16:03:02 <rfriedman> bwolfe, how do I stop jetty at the command line?
16:04:51 *** lh has joined #openmrs
16:14:07 <rfriedman> bwolfe, never mind, ctl-C did the trick
16:18:29 *** jkeiper_ has quit IRC
16:18:29 *** jkeiper has quit IRC
16:19:02 *** jkeiper has joined #openmrs
16:19:12 *** ChanServ sets mode: +v jkeiper
16:41:48 <wyclif> djazayeri, bwolfe do we have a convention for getAll methods in rest resources
16:42:15 <wyclif> djazayeri, bwolfe i.e should they return returned/voided objects
16:42:32 <wyclif> djazayeri, bwolfe i.e sorry retired/voided
16:42:41 <bwolfe> wyclif, use the Context.includeAll param I think
16:42:47 <bwolfe> wyclif, (I think thats the name of it)
16:42:55 <bwolfe> RequestContext.includeAll
16:44:59 <wyclif> bwolfe, seen it in rest ws but the version the 1 .9 ext requires doesnt have it
16:45:02 *** cpower has quit IRC
16:45:24 <djazayeri> wyclif: in that case, update restws19ext to require a newer version of restws
16:45:27 <bwolfe> wyclif, so update 19ext
16:47:56 <wyclif> bwolfe, then am going to make it depend on 1.1 snaphsot until a new version is out
16:48:14 <bwolfe> yes
17:01:43 *** suranga has joined #openmrs
17:01:43 *** ChanServ sets mode: +v suranga
17:02:46 *** bwolfe has quit IRC
17:21:20 *** robbyoconnor has joined #openmrs
17:21:20 *** ChanServ sets mode: +v robbyoconnor
17:30:25 *** kishoreyekkanti has joined #openmrs
17:36:05 <rfriedman> djazayeri, i've got 1.9 tests failing because they don't supply required fields of objects they are creating. what should I do about that?
17:40:06 <djazayeri> rfriedman: core? restws19ext?
17:40:22 <rfriedman> djazayeri, core
17:42:03 <djazayeri> rfriedman: per https://ci.openmrs.org/browse/JU-CORE1/latest (branch=1.9.x) it seems like these should be passing
17:42:13 <djazayeri> have you done a git pull?
17:42:28 <rfriedman> yesterday
17:43:16 <djazayeri> rfriedman: can you pastebin an error message?
17:43:58 <rfriedman> djazayeri, it's failing when running junit tests, i found the problem by single-stepping through the test
17:44:12 <rfriedman> i'm need to leave in about 2 minutes
17:44:42 <djazayeri> rfriedman: I'm on a call now. Tests should be passing. If they aren't, share an error message.
17:45:10 <rfriedman> ok, i'll do something later when I get home
17:45:26 *** rfriedman has quit IRC
18:00:53 *** downey has quit IRC
18:03:37 *** downey has joined #openmrs
18:03:37 *** OpenMRSBot sets mode: +o downey
18:03:37 *** ChanServ sets mode: +o downey
18:04:14 *** downey has quit IRC
18:04:20 *** downey_ has joined #openmrs
18:04:20 *** ChanServ sets mode: +o downey_
18:06:44 *** kavuri has joined #openmrs
18:17:32 *** james_regen has left #openmrs
18:33:15 *** robbyoconnor has quit IRC
18:39:17 *** suranga_ has joined #openmrs
18:42:29 *** suranga__ has joined #openmrs
18:43:05 *** suranga has quit IRC
18:43:19 *** jkeiper has quit IRC
18:44:23 *** suranga has joined #openmrs
18:45:55 *** suranga_ has quit IRC
18:46:58 *** suranga__ has quit IRC
18:48:31 *** suranga has quit IRC
18:58:57 *** kishoreyekkanti has quit IRC
18:58:57 *** downey_ has quit IRC
18:59:20 *** suranga has joined #openmrs
18:59:20 *** ChanServ sets mode: +v suranga
18:59:29 *** downey has joined #openmrs
18:59:29 *** OpenMRSBot sets mode: +o downey
18:59:29 *** ChanServ sets mode: +o downey
19:06:31 *** downey has quit IRC
19:10:47 *** kishoreyekkanti has joined #openmrs
19:17:09 *** kishoreyekkanti has quit IRC
19:29:24 *** lh has quit IRC
19:30:59 *** sgithens has joined #openmrs
19:34:32 *** suranga has quit IRC
19:38:16 *** kavuri has quit IRC
20:06:34 *** lh has joined #openmrs
20:06:34 *** lh has joined #openmrs
20:18:21 *** sgithens has quit IRC
20:20:46 *** downey has joined #openmrs
20:20:46 *** ChanServ sets mode: +o downey
20:20:46 *** OpenMRSBot sets mode: +o downey
20:21:15 *** downey has quit IRC
20:27:36 *** downey has joined #openmrs
20:27:36 *** downey has joined #openmrs
20:27:36 *** OpenMRSBot sets mode: +o downey
20:27:36 *** ChanServ sets mode: +o downey
21:01:41 *** downey has quit IRC
21:01:46 *** downey_ has joined #openmrs
21:01:46 *** ChanServ sets mode: +o downey_
21:02:12 *** downey_ has quit IRC
21:02:16 *** downey has joined #openmrs
21:02:16 *** OpenMRSBot sets mode: +o downey
21:02:16 *** ChanServ sets mode: +o downey
22:12:54 *** andreapat has joined #openmrs
22:17:59 *** wyclif has quit IRC
22:18:07 *** andreapat has quit IRC
22:18:23 *** andreapat has joined #openmrs
22:36:54 *** downey has quit IRC
23:10:24 *** andreapat has quit IRC
23:11:56 *** wyclif has joined #openmrs
23:36:47 *** andreapat has joined #openmrs
23:38:13 <andreapat> any developers out there?
23:38:37 <andreapat> djazayeri, u there?
23:39:04 <djazayeri> andreapat: on the phone
23:39:25 <andreapat> ok - would love to chat when u get off