00:37:34
|
*** lh has joined #openmrs
|
00:40:06
|
*** robbyoconnor has quit IRC
|
00:53:07
|
*** mccallumg has quit IRC
|
01:08:56
|
*** downey has quit IRC
|
01:13:03
|
*** lh has quit IRC
|
01:21:22
|
*** jordank has joined #openmrs
|
01:21:56
|
*** jkeiper has joined #openmrs
|
01:29:32
|
*** robbyoconnor has joined #openmrs
|
01:29:35
|
*** robbyoconnor has joined #openmrs
|
01:29:35
|
*** ChanServ sets mode: +v robbyoconnor
|
01:29:48
|
*** lh has joined #openmrs
|
01:32:03
|
*** robbyoconnor has quit IRC
|
01:46:10
|
*** robbyoconnor has joined #openmrs
|
01:46:10
|
*** ChanServ sets mode: +v robbyoconnor
|
01:52:45
|
*** bwolfe has joined #openmrs
|
01:52:46
|
*** ChanServ sets mode: +o bwolfe
|
01:53:37
|
*** lh has quit IRC
|
01:54:08
|
*** lh has joined #openmrs
|
01:54:08
|
*** lh has joined #openmrs
|
02:04:33
|
*** lh has quit IRC
|
02:13:53
|
*** jkeiper has quit IRC
|
02:17:16
|
*** lh has joined #openmrs
|
02:17:48
|
*** downey has joined #openmrs
|
02:17:48
|
*** OpenMRSBot sets mode: +o downey
|
02:17:49
|
*** ChanServ sets mode: +o downey
|
02:25:41
|
*** downey has quit IRC
|
02:29:56
|
*** upul` has joined #openmrs
|
02:29:57
|
*** ChanServ sets mode: +v upul`
|
02:35:13
|
*** lh has quit IRC
|
02:44:02
|
*** lh has joined #openmrs
|
02:44:02
|
*** lh has joined #openmrs
|
03:11:56
|
*** harshadura has joined #openmrs
|
03:28:55
|
*** harshadura has quit IRC
|
03:30:57
|
*** bwolfe has quit IRC
|
03:49:34
|
*** upul` has quit IRC
|
03:50:56
|
*** harshadura has joined #openmrs
|
03:51:44
|
*** upul` has joined #openmrs
|
03:51:44
|
*** ChanServ sets mode: +v upul`
|
03:58:34
|
*** harshadura has quit IRC
|
04:30:35
|
*** lh has quit IRC
|
04:44:06
|
*** jordank has quit IRC
|
04:50:56
|
*** r0bby has joined #openmrs
|
04:50:56
|
*** ChanServ sets mode: +v r0bby
|
04:52:03
|
*** robbyoconnor has quit IRC
|
04:53:00
|
*** r0bby has quit IRC
|
05:02:07
|
*** basic` has quit IRC
|
05:31:46
|
*** p_m has joined #openmrs
|
05:31:59
|
*** piyush_ has joined #openmrs
|
05:34:18
|
*** piyush_ has left #openmrs
|
05:39:47
|
*** kavuri has joined #openmrs
|
06:08:02
|
*** mvorobey has joined #openmrs
|
06:08:07
|
*** p_m has quit IRC
|
06:09:55
|
*** mvorobey has quit IRC
|
06:29:53
|
*** p_m has joined #openmrs
|
06:46:54
|
*** dkayiwa has joined #openmrs
|
07:14:14
|
*** basic` has joined #openmrs
|
07:27:25
|
*** p_m has quit IRC
|
07:28:12
|
*** rafa has joined #openmrs
|
07:28:12
|
*** ChanServ sets mode: +v rafa
|
10:42:21
|
*** robbyoconnor has joined #openmrs
|
10:42:21
|
*** ChanServ sets mode: +v robbyoconnor
|
10:48:38
|
*** james_regen has joined #openmrs
|
10:48:38
|
*** ChanServ sets mode: +v james_regen
|
11:01:09
|
*** upul` has quit IRC
|
11:16:02
|
*** mvorobey has joined #openmrs
|
11:24:18
|
*** mvorobey has quit IRC
|
12:11:53
|
*** jkeiper has joined #openmrs
|
12:16:00
|
*** sthaiya has joined #openmrs
|
12:21:54
|
<sthaiya> djazayeri
|
12:22:49
|
<sthaiya> was looking at reporting on Jira and saw work in progress for building a cohort builder
|
12:23:01
|
<sthaiya> as was in reporting compatibilty
|
12:31:12
|
*** wyclif has quit IRC
|
12:46:01
|
*** downey has joined #openmrs
|
12:46:01
|
*** OpenMRSBot sets mode: +o downey
|
12:46:01
|
*** ChanServ sets mode: +o downey
|
12:52:53
|
*** basic` has quit IRC
|
12:52:53
|
*** jkeiper has quit IRC
|
12:52:53
|
*** dkayiwa has quit IRC
|
12:52:53
|
*** robbyoconnor has quit IRC
|
12:52:54
|
*** james_regen has quit IRC
|
12:52:54
|
*** djazayeri has quit IRC
|
12:52:54
|
*** sthaiya has quit IRC
|
12:52:54
|
*** Echidna_ has quit IRC
|
12:52:55
|
*** downey has quit IRC
|
12:52:55
|
*** rafa has quit IRC
|
12:52:56
|
*** deadpool has quit IRC
|
12:53:02
|
*** downey has joined #openmrs
|
12:53:02
|
*** sthaiya has joined #openmrs
|
12:53:02
|
*** jkeiper has joined #openmrs
|
12:53:02
|
*** james_regen has joined #openmrs
|
12:53:02
|
*** robbyoconnor has joined #openmrs
|
12:53:02
|
*** rafa has joined #openmrs
|
12:53:02
|
*** zelazny.freenode.net sets mode: +ovvv downey james_regen robbyoconnor rafa
|
12:53:02
|
*** basic` has joined #openmrs
|
12:53:02
|
*** dkayiwa has joined #openmrs
|
12:53:02
|
*** djazayeri has joined #openmrs
|
12:53:02
|
*** Echidna_ has joined #openmrs
|
12:53:02
|
*** deadpool has joined #openmrs
|
12:53:02
|
*** zelazny.freenode.net sets mode: +o djazayeri
|
12:53:05
|
*** OpenMRSBot sets mode: +o downey
|
13:12:50
|
*** wyclif has joined #openmrs
|
13:13:57
|
<dkayiwa> hi wyclif
|
13:15:13
|
<wyclif> what is the status of XFRM-31
|
13:15:19
|
<wyclif> dkayiwa, i think it still needs work
|
13:15:39
|
<dkayiwa> !ticket xfrm-31
|
13:15:41
|
<OpenMRSBot> dkayiwa: [#XFRM-31] Editing relationships when editing form observations - OpenMRS JIRA - https://tickets.openmrs.org/browse/xfrm-31
|
13:15:47
|
<dkayiwa> wyclif: ok
|
13:16:02
|
<dkayiwa> wyclif: by the way, i cannot access the form designer or even enter any form
|
13:16:24
|
<dkayiwa> wyclif: looks like problems come from openmrs:message tag
|
13:17:06
|
<dkayiwa> wyclif: do you have some time to fix that? or i try to fix it myself before i make a new commit?
|
13:17:49
|
<wyclif> dkayiwa, what version are you testing against?
|
13:17:59
|
<dkayiwa> wyclif: openmrs 1.9
|
13:18:13
|
<wyclif> it wroks for me
|
13:18:18
|
<wyclif> it works for me
|
13:18:24
|
<dkayiwa> wyclif: are you sure?
|
13:18:42
|
<dkayiwa> wyclif: does it also work for you in 1.8, 1.7 and 1.6?
|
13:18:45
|
<wyclif> dkayiwa, yes, but i need to add a check to only include it if it is 1.8 and above
|
13:18:59
|
<wyclif> dkayiwa, i dont think it will work for older versions
|
13:19:14
|
<dkayiwa> wyclif: so do you have a fix for that?
|
13:19:40
|
<wyclif> let me commit a fix to check if 1.8 and aboce
|
13:19:48
|
<wyclif> dkayiwa, but it should be working for 1.9
|
13:20:07
|
<dkayiwa> wyclif: ok commit and tell me to update and test again
|
13:20:10
|
<wyclif> dkayiwa, i think it should spring:message tag
|
13:20:23
|
<dkayiwa> wyclif: yes thats what i was using
|
13:22:31
|
<wyclif> dkayiwa, actually i dont like the fact that t was changed to openmrs:message because that file is being used in older versions
|
13:22:58
|
<dkayiwa> wyclif: i think we can change it to spring:message
|
13:23:26
|
<wyclif> dkayiwa, but that file am just adding it as an include soi cant change the tags
|
13:23:47
|
<dkayiwa> wyclif: oh i see
|
13:24:04
|
<wyclif> dkayiwa, or i can include our own version which is edited back to openmrs:message
|
13:24:28
|
<dkayiwa> wyclif: did you mean back to spring:message?
|
13:24:41
|
<wyclif> dkayiwa, that change was made in trunk so yes it doesnt work with 1.9 and below
|
13:24:46
|
<dkayiwa> wyclif: which file is that?
|
13:25:06
|
<wyclif> openmrsmessages.js.withjstl
|
13:25:26
|
<dkayiwa> wyclif: i think just do whatever you think is best
|
13:25:40
|
<dkayiwa> wyclif: as long as the module still works all the way from 1.6
|
13:27:04
|
<wyclif> dkayiwa, i think the actual form entry page works but the designer doesnt
|
13:27:19
|
<dkayiwa> wyclif: even the formentry page fails
|
13:28:30
|
<wyclif> dkayiwa, in 1.9
|
13:28:43
|
<dkayiwa> wyclif: yes
|
13:29:06
|
<dkayiwa> wyclif: Version: 1.9.0 Build 27760
|
13:32:10
|
<dkayiwa> wyclif: how long do you think it is going to take you to finish that? i want to make a commit touching the same files
|
13:32:56
|
*** downey has quit IRC
|
13:33:02
|
*** downey_ has joined #openmrs
|
13:33:02
|
*** ChanServ sets mode: +o downey_
|
13:36:00
|
*** lh has joined #openmrs
|
13:39:07
|
<wyclif> dkayiwa, i actually dont thin kit was correct to change the message tags, it is going to break alot of modules that are backward commpartible that use search widgets and autocompletes
|
13:39:31
|
<dkayiwa> wyclif: i fully agree
|
13:39:58
|
*** sthaiya has quit IRC
|
13:46:41
|
*** harshadura has joined #openmrs
|
13:47:14
|
<wyclif> hi dkayiwa
|
13:47:20
|
<dkayiwa> hi wyclif
|
13:49:24
|
<wyclif> hi sorry i tested with 1.9.1 and it works because that tag changes were back ported, let try 1.9.0
|
13:49:45
|
<dkayiwa> wyclif: 1.9.0 fails
|
13:50:03
|
<wyclif> dkayiwa, the only solution i can think of of right now is to add the tag handler for openmrs:message in xforms
|
13:50:14
|
<wyclif> dkayiwa, if running older versions
|
13:50:19
|
<dkayiwa> wyclif: ok
|
13:50:29
|
<wyclif> dkayiwa, but dont know hot to do it exaclty
|
13:50:35
|
<dkayiwa> wyclif: ok
|
13:51:57
|
<wyclif> dkayiwa, let me try to seeif i can actually create a different copy of openmrsmessages with jstl to xfroms
|
13:52:06
|
<dkayiwa> wyclif: ok
|
13:56:01
|
*** downey_ has quit IRC
|
13:56:10
|
*** sgithens has joined #openmrs
|
13:57:31
|
*** bwolfemobile has joined #openmrs
|
13:57:31
|
*** ChanServ sets mode: +o bwolfemobile
|
13:58:26
|
*** andrea_ has joined #openmrs
|
13:59:19
|
<sgithens> Does the 1.9.1 openmrs tag not show up on github because it's 'latest'?
|
13:59:25
|
<andrea_> Hi is anybody here?
|
14:00:31
|
*** downey has joined #openmrs
|
14:00:32
|
*** OpenMRSBot sets mode: +o downey
|
14:00:32
|
*** ChanServ sets mode: +o downey
|
14:01:03
|
*** downey has quit IRC
|
14:01:37
|
*** cpower has joined #openmrs
|
14:01:50
|
<cpower> Hello everybody!
|
14:02:01
|
<cpower> Are we ready to Scrum?
|
14:02:31
|
<cpower> aaaand with the batch of silence we will say YES!
|
14:02:31
|
<andrea_> Hi Im here
|
14:02:47
|
<cpower> ahhh welcome our new developer Andrea!
|
14:02:55
|
<andrea_> Thanks!
|
14:03:17
|
<cpower> We are hoping to use your awesome Java skills to it's best
|
14:03:36
|
<andrea_> Ok I'm ready
|
14:03:52
|
*** downey has joined #openmrs
|
14:03:52
|
*** ChanServ sets mode: +o downey
|
14:03:52
|
*** OpenMRSBot sets mode: +o downey
|
14:03:59
|
<cpower> Today just sit back a watch what is the magic of our daily scrum, and thanks for getting up so early
|
14:04:06
|
<cpower> Let's do it
|
14:04:11
|
<cpower> !scrumon cpower
|
14:04:11
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:04:15
|
<andrea_> No problem
|
14:04:54
|
<cpower> Order: Wyclif, dkayiwa, rafa, djazayeri and if bwolfe makes it in time him.
|
14:05:04
|
<andrea_> Who else is here?
|
14:05:43
|
<cpower> In all hopes at the least the people I just listed
|
14:05:49
|
<cpower> Wyclif...your up!
|
14:05:59
|
<wyclif> hold on sorry!
|
14:06:10
|
<cpower> ;-)
|
14:06:15
|
<bwolfemobile> I'm here...kind of :-)
|
14:06:37
|
<cpower> it's magic of data phones
|
14:06:45
|
<cpower> but can he scrum on them?
|
14:06:46
|
<bwolfemobile> Silly a/c guy, stuck at the house for a fix.
|
14:07:05
|
<wyclif> Thursday:
|
14:07:05
|
<wyclif> Add person search widget look up in xforms
|
14:07:05
|
<wyclif> Update XFRM-16 to use the person search widget - Include Relationship Widget in XForms Designer
|
14:07:05
|
<wyclif> dev call
|
14:07:05
|
<wyclif> Friday
|
14:07:06
|
<wyclif> Fix xforms widgets to work in 1.9.0 and below
|
14:07:08
|
<wyclif> TRUNK-2069 - Obs should have a pointer for the form_field it was created through
|
14:07:10
|
<wyclif> Blockers: None
|
14:07:43
|
<dkayiwa> Reviewed and tested: Concept, Location, and Provider widget lookup - XFRM-78
|
14:07:43
|
<dkayiwa> Reviewed and tested: Include Relationship Widget in XForms Designer - XFRM-16
|
14:07:44
|
<dkayiwa> About to Committ: Need proposed concept feature - XFRM-50
|
14:07:44
|
<dkayiwa> No Blockers
|
14:07:58
|
<rafa> Yesterday:
|
14:07:58
|
<rafa> * Investigated for the concept dictionary sharing sprint
|
14:07:58
|
<rafa> * Refactored version conversion of metadata in MDS to be easier to handle in the future
|
14:07:58
|
<rafa> * Dev Call
|
14:07:58
|
<rafa> Today:
|
14:07:59
|
<rafa> * More thinking about the concept dictionary sharing sprint
|
14:07:59
|
<rafa> * Reworked, tested and committed TRUNK-3491: Write to independent log file
|
14:08:00
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3491
|
14:08:00
|
<rafa> No blockers.
|
14:08:22
|
<bwolfemobile> Daniel, can you also review the xforms tickets from the sprint?
|
14:08:53
|
<dkayiwa> bwolfemobile: ok
|
14:09:13
|
<bwolfemobile> Wyclif, not sure we want to commit that over just yet, so put it in your fork, don't push to core
|
14:09:46
|
<wyclif> bwolfemobile, the xforms?
|
14:09:57
|
<bwolfemobile> We want to combine that with another obs table change to ease the pain of upgrading
|
14:10:28
|
<wyclif> bwolfemobile, ok, i think darius had added a comment about that
|
14:10:58
|
<djazayeri> hi all, sorry I'm late. Nothing new: today is ITECH stuff. Next week is planning for Mirebalais. Hopefully you'll see a blog post about it
|
14:11:47
|
<bwolfemobile> Wyclif, ok, yes, that obs ticket. Darius did comment, wanted yo maker sure you saw it
|
14:12:08
|
<cpower> ok bwolfe do you have an update?
|
14:13:03
|
<bwolfemobile> Not really, mostly calls yesterday. A few calls today, and some ticket review
|
14:13:16
|
<cpower> okay then.
|
14:13:32
|
<bwolfemobile> We're extending the sprint, can you announce that cpower?
|
14:13:35
|
<djazayeri> bwolfemobile: who will email out about the sprint switcharoo?
|
14:13:44
|
<djazayeri> ah, yes, cpower then. :-)
|
14:13:48
|
<bwolfemobile> :-)
|
14:14:26
|
<bwolfemobile> Any blockers?
|
14:14:47
|
<cpower> Oooooh yeah, hey due to popular demand we are extending this sprint to September 2nd
|
14:15:10
|
<bwolfemobile> Cpower, we will have more spikes after a call this afternoon
|
14:15:29
|
<bwolfemobile> But let's call it a sprint less two weeks
|
14:16:18
|
<cpower> And then we will be preparing several spikes and swimlanes for the next sprint Sept 3rd thru 16th, and a switch to Patient Summary September 17th thru 30th, to finally get to the sprint that we thought was going to be next Sharing Concept Dictionary Oct 1st thru 14th
|
14:16:28
|
<bwolfemobile> We don't always need a sprint...
|
14:16:51
|
<cpower> Yeah I don't really see the next set of work really as a sprint
|
14:17:00
|
<bwolfemobile> Ok, good
|
14:17:03
|
<cpower> it's more collective work
|
14:17:27
|
<bwolfemobile> Can you announce to the dev list?
|
14:17:29
|
<cpower> check https://wiki.openmrs.org/display/RES/Sprint+Schedule for times and details
|
14:17:45
|
<cpower> Yes I can
|
14:18:09
|
<cpower> !scrumoff
|
14:18:09
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:18:38
|
<andrea_> This is a daily thing, right?
|
14:18:56
|
<cpower> Yep we do something similar to this every morning
|
14:19:14
|
<djazayeri> hi andrea_, yes, every day at 10am Eastern (except for Thursdays are a different time due to the developers call)
|
14:19:14
|
<cpower> I'll admit it's usually more organized
|
14:19:25
|
<djazayeri> cpower: today is casual friday?
|
14:19:30
|
<andrea_> What time Thurs?
|
14:19:37
|
<cpower> Sure, we can call it that.
|
14:19:51
|
<cpower> 3pm EST so Noon your time
|
14:19:59
|
<andrea_> Ok
|
14:20:39
|
<cpower> So the next important question is does Andrea drink beer?
|
14:20:53
|
<djazayeri> cpower: hopefully not at 7am for the scrum...
|
14:20:54
|
<andrea_> Andrea loves beer!
|
14:21:02
|
<cpower> hehehe
|
14:21:34
|
<cpower> I just know our mIRC bartender only serves beer, I'm waiting for someone to code in Jack and Cokes for me, but I've yet to see it.
|
14:21:53
|
<andrea_> Oh well
|
14:22:24
|
<cpower> well then you'll fit right in. Because expecially in this channel it's 5 oclock somewhere
|
14:22:42
|
<andrea_> That it is
|
14:23:15
|
<wyclif> dkayiwa, i think i have found a temporary fix give me about 20min
|
14:23:46
|
<cpower> So what is on your agenda today Andrea? A lot of wiki reading, welcome to Merck meetings?
|
14:24:06
|
*** sgithens has quit IRC
|
14:24:39
|
<cpower> I guess the first question is have you made it into the office this morning or should I stop bothering you so you can get ready and get out the door?
|
14:24:40
|
<andrea_> Thanks - yes lots of meetings and have had so much paperwork to do -yuk
|
14:25:20
|
<andrea_> I do need to get to the office. May I be exused now?
|
14:26:04
|
<cpower> lol...can we get everyone to ask permission to leave? I would love that I would be able to get ahold of everyone
|
14:26:07
|
<andrea_> Good chatting with you all
|
14:26:11
|
<djazayeri> ciao
|
14:26:33
|
<cpower> Go, have a good day call or email me if you need anything
|
14:27:11
|
<andrea_> Thanks! Will do.
|
14:28:06
|
*** andrea_ has quit IRC
|
14:28:08
|
<cpower> I'm trying a change of pace this AM, I will say and do everything with a smile (a very no PM/PC thing to do)
|
14:28:23
|
<cpower> no = non
|
14:32:46
|
<cpower> bwolfe, let me know when you make it to the office or a place where we can chat.
|
14:33:53
|
*** bwolfemobile has quit IRC
|
14:36:09
|
<dkayiwa> wyclif: spring:message seems to be working even for 1.9.1 and trunk
|
14:37:14
|
<wyclif> dkayiwa, but am adding a fix to switch the files and tags, i have a added a openmrsmessagesWithSpringTags.js.withjstl to sforms which is typically the one from core but with spring tags
|
14:37:48
|
<dkayiwa> wyclif: wouldn't spring:message work for all versions?
|
14:37:56
|
<dkayiwa> wyclif: i have just tested it and it works well
|
14:38:12
|
<dkayiwa> wyclif: i also tests with trunk
|
14:38:20
|
<dkayiwa> tested
|
14:40:08
|
*** r0bby has joined #openmrs
|
14:40:08
|
*** ChanServ sets mode: +v r0bby
|
14:43:25
|
<wyclif> dkayiwa, adding a check just to switch between openmrsmessages.js.withjstl and openmrsmessagesWithSpringTags.js.withjstl
|
14:43:27
|
*** robbyoconnor has quit IRC
|
14:43:41
|
<dkayiwa> wyclif: was wondering why all that work
|
14:43:59
|
<dkayiwa> wyclif: since spring:message works for all versions (including 1.9.1 and trunk)
|
14:45:00
|
<wyclif> dkayiwa, the problem is that the widgets use openmrsmessages.js.withjstl which is in core so i cant change those tags from xfroms
|
14:45:48
|
<djazayeri> wyclif: what ticket are you working on?
|
14:45:50
|
<wyclif> dkayiwa, that file is referenced from the OpenmrAutoComplete.js file
|
14:46:18
|
<wyclif> djazayeri, am suppsoed to be working on TRUNK-2069
|
14:46:33
|
<wyclif> djazayeri, but there a bug i have noticed
|
14:46:47
|
<dkayiwa> wyclif: the text being replaced in within the xforms jsp
|
14:46:59
|
<dkayiwa> wyclif: for instance: placeHolderText = '<openmrs:messagecode="Person.search.placeholder"javaScriptEscape="true"/>';
|
14:47:17
|
<wyclif> djazayeri, but that is not the only problem
|
14:47:29
|
<dkayiwa> wyclif: that is why i changed it to: placeHolderText = '<spring:messagecode="Person.search.placeholder"javaScriptEscape="true"/>'; and it worked in 1.9.1 and trunk
|
14:47:46
|
<djazayeri> oh, okay, I was wondering what xforms + spring:message had to do with obs.form_field_path. :-)
|
14:47:52
|
<wyclif> look at xformsDesigner, i added an include fot the openmrsmessages file which uses the new tags
|
14:48:01
|
<dkayiwa> wyclif: ok
|
14:48:03
|
<wyclif> dkayiwa, look at xformsDesigner, i added an include fot the openmrsmessages file which uses the new tags
|
14:48:27
|
<dkayiwa> wyclif: ok. i had thought problem was with only openmrs:message
|
14:48:29
|
<wyclif> dkayiwa, without that include the widgets dont work on the designer page
|
14:48:36
|
<dkayiwa> wyclif: ok
|
14:49:02
|
<dkayiwa> wyclif: testing on 1.7, i get this: /WEB-INF/view/module/xforms/xformDesigner.jsp(13,4) Attribute appendLocale invalid for tag htmlInclude according to TLD
|
14:49:35
|
<wyclif> dkayiwa, i think even that is a new attribute in 1.8
|
14:49:42
|
<wyclif> dkayiwa, it might not work
|
14:49:58
|
<dkayiwa> wyclif: it fails in 1.7 and 1.6
|
14:50:04
|
<wyclif> dkayiwa, i think you need to break xforms into different builds
|
14:50:22
|
<wyclif> dkayiwa, it is going to start being hard to add certain features to work across all versions
|
14:50:29
|
<dkayiwa> wyclif: i would only do that if i had no alternative
|
14:50:30
|
<dkayiwa> :)
|
14:50:40
|
<dkayiwa> i have avoided it up to all this time
|
14:50:58
|
<wyclif> dkayiwa, like typically any module using search/autocomplete widgets should support 1.5 and 1.6 versions
|
14:51:18
|
<dkayiwa> wyclif: xforms no longer supports 1.5
|
14:51:21
|
<wyclif> dkayiwa, even i think 1.7 is hard
|
14:51:23
|
<dkayiwa> wyclif: startes with 1.6
|
14:52:20
|
<dkayiwa> wyclif: i would rather disable the new autocomplete widgets for older versions than having to maintain more than one build
|
14:52:43
|
<dkayiwa> wyclif: that is how the single module build supports both dojo and jquery widgets
|
14:52:50
|
<dkayiwa> wyclif: it uses if else clauses :)
|
14:52:59
|
*** downey has quit IRC
|
14:55:00
|
<wyclif> dkayiwa, dkayiwa am already doing that
|
14:55:10
|
<dkayiwa> wyclif: perfect!!! :)
|
14:55:34
|
<wyclif> dkayiwa, the problem is that 1.9.0 and older versions use spring message tag
|
14:55:57
|
<wyclif> so i have to include a different messages with jstl file\
|
14:56:19
|
<dkayiwa> wyclif: yes that is still better than having to maintain more than one build :)
|
14:57:10
|
*** bwolfe has joined #openmrs
|
14:57:10
|
*** ChanServ sets mode: +o bwolfe
|
14:57:15
|
<dkayiwa> wyclif: will what you are doing also cater for the error message above concerning appendLocale attribute?
|
14:57:37
|
*** lh has quit IRC
|
14:58:23
|
<wyclif> dkayiwa, i have taken care of that
|
14:58:35
|
<dkayiwa> wyclif: perfect!!! :)
|
15:05:21
|
*** downey has joined #openmrs
|
15:05:21
|
*** ChanServ sets mode: +o downey
|
15:05:21
|
*** OpenMRSBot sets mode: +o downey
|
15:27:14
|
<wyclif> dkayiwa, committed the fix to 1.9.0 and below, can you test that?
|
15:28:04
|
<dkayiwa> wyclif: just updated and test on 1.7 where i get this: /WEB-INF/view/module/xforms/xformDesigner.jsp(15,6) Attribute appendLocale invalid for tag htmlInclude according to TLD
|
15:29:30
|
<wyclif> dkayiwa, sorry i made slight mistake
|
15:29:44
|
<wyclif> dkayiwa, but no
|
15:30:13
|
<wyclif> dkayiwa, i have removed that attribute, see xformDesigner.jsp
|
15:30:21
|
<wyclif> dkayiwa, i wonder why you still get it
|
15:30:38
|
<dkayiwa> wyclif: <c:whentest="${useOpenmrsMessageTag==true}">
|
15:30:39
|
<dkayiwa> <openmrs:htmlIncludefile="/scripts/openmrsmessages.js"appendLocale="true"/>
|
15:30:39
|
<dkayiwa> </c:when>
|
15:30:52
|
<wyclif> dkayiwa, may be they back ported this to 1.7
|
15:31:04
|
<wyclif> dkayiwa, i think they backported it
|
15:32:20
|
<dkayiwa> wyclif: is there any reason why you added another isOnePointNineAndAbove() method?
|
15:32:58
|
<dkayiwa> wyclif: oh different name isOnePointNineOneAndAbove :)
|
15:33:08
|
<dkayiwa> wyclif: NineOne
|
15:33:25
|
<wyclif> dkayiwa, i have just seen they back ported openmrs messages to 1.7, let me remove the atrribute
|
15:33:33
|
<dkayiwa> wyclif: ok
|
15:35:22
|
*** jordank has joined #openmrs
|
15:35:34
|
<wyclif> dkayiwa, i wonder when that locale thing was added
|
15:35:49
|
<dkayiwa> wyclif: not sure
|
15:37:32
|
*** dkayiwa has quit IRC
|
15:39:48
|
*** jordank_ has joined #openmrs
|
15:40:18
|
*** jordank has quit IRC
|
15:40:20
|
*** jordank_ is now known as jordank
|
15:56:29
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: We're on the @SourceForge blog! Check out our podcast with @bawolfe & learn more about us: http://t.co/PgGXUpXt #opensource #HFOSS <http://twitter.com/OpenMRS/statuses/239017429743841281>
|
15:56:33
|
<bwolfe> !powerup cpower
|
15:56:33
|
* OpenMRSBot slides cpower a Jack and Coke
|
15:58:49
|
*** downey has quit IRC
|
15:58:53
|
*** downey_ has joined #openmrs
|
15:58:53
|
*** ChanServ sets mode: +o downey_
|
16:23:27
|
*** rafa has quit IRC
|
16:23:33
|
*** downey_ has quit IRC
|
16:28:41
|
*** jordank_ has joined #openmrs
|
16:28:43
|
*** jordank has quit IRC
|
16:28:43
|
*** jordank_ is now known as jordank
|
16:30:57
|
*** downey has joined #openmrs
|
16:30:57
|
*** ChanServ sets mode: +o downey
|
16:30:57
|
*** OpenMRSBot sets mode: +o downey
|
16:32:16
|
*** jordank has quit IRC
|
16:48:36
|
*** magoo_ has joined #openmrs
|
16:54:10
|
*** applecool has joined #openmrs
|
16:54:10
|
*** ChanServ sets mode: +v applecool
|
16:59:40
|
*** downey has quit IRC
|
17:01:55
|
*** cpower has quit IRC
|
17:04:42
|
*** harshadura has quit IRC
|
17:13:00
|
*** jordank has joined #openmrs
|
17:17:14
|
*** downey has joined #openmrs
|
17:17:14
|
*** ChanServ sets mode: +o downey
|
17:17:14
|
*** OpenMRSBot sets mode: +o downey
|
17:17:28
|
<bwolfe> !seen andrea
|
17:17:28
|
<OpenMRSBot> bwolfe: I have not seen andrea.
|
17:17:30
|
<bwolfe> !seen andrea_
|
17:17:30
|
<OpenMRSBot> bwolfe: andrea_ was last seen in #openmrs 2 hours, 50 minutes, and 19 seconds ago: <andrea_> Thanks! Will do.
|
17:25:58
|
*** jordank has quit IRC
|
17:36:10
|
*** magoo_ has quit IRC
|
17:39:57
|
<applecool> !seen rafa
|
17:39:57
|
<OpenMRSBot> applecool: rafa was last seen in #openmrs 3 hours, 31 minutes, and 57 seconds ago: <rafa> No blockers.
|
18:13:59
|
*** mvorobey has joined #openmrs
|
18:14:09
|
<mvorobey> hi all
|
18:14:18
|
*** downey has quit IRC
|
18:16:46
|
*** kdeeq has joined #openmrs
|
18:26:48
|
*** jordank has joined #openmrs
|
18:27:25
|
*** downey has joined #openmrs
|
18:27:25
|
*** ChanServ sets mode: +o downey
|
18:27:25
|
*** OpenMRSBot sets mode: +o downey
|
18:29:46
|
<mvorobey> downey, hi
|
18:29:50
|
<downey> hey mvorobey
|
18:31:35
|
<mvorobey> downey, I was working with google melange and noticed that OpenMRS icons on that site are missing (for instance - http://openmrs.org/media/omrs-gsoc11sm-350x87.png), could you fix it so our community will look perfect through melange ?
|
18:31:47
|
<downey> mvorobey: ooh, of course. thanks for letting me know
|
18:32:13
|
<downey> mvorobey: what was the page that had the broken image, if you remember?
|
18:32:16
|
<mvorobey> downey, no problem
|
18:32:34
|
<mvorobey> downey, http://www.google-melange.com/gsoc/org/google/gsoc2012/openmrs
|
18:32:40
|
<OpenMRSBot> <http://ln-s.net/$gtF> (at www.google-melange.com)
|
18:32:51
|
<downey> mvorobey: thanks
|
18:33:09
|
<mvorobey> downey, do not mention it
|
18:34:07
|
*** kdeeq has quit IRC
|
18:38:35
|
<downey> mvorobey: all fixed, thanks again!
|
18:40:46
|
<mvorobey> downey, thank you for fixing!
|
18:47:55
|
<wyclif> hi djazayeri
|
18:49:08
|
<wyclif> for TRUNK-2069, namespace and path are stored in the form field column, right?
|
18:49:16
|
<wyclif> djazayeri, for TRUNK-2069, namespace and path are stored in the form field column, right?
|
18:49:41
|
<djazayeri> wyclif: we should probably change that column name so it's not form_field, but yes, I think just one column
|
18:50:52
|
<wyclif> djazayeri, change to what name
|
18:51:03
|
<djazayeri> wyclif: form_path I think
|
18:51:37
|
<wyclif> i plan to use a separator character to be able to parse the stored value to get the namespace and path
|
18:52:15
|
<wyclif> djazayeri, i plan to use a separator character to be able to parse the stored value to get the namespace and path
|
18:52:30
|
<djazayeri> bwolfe: do you agree with that? (Seems fine to me)
|
18:52:54
|
<wyclif> djazayeri, but am not sure of what will not conflict with the actual stored path
|
18:53:15
|
<djazayeri> wyclif: but *everything* has to have at least one, right?
|
18:54:19
|
*** kdeeq has joined #openmrs
|
18:54:21
|
*** james_regen has quit IRC
|
18:54:41
|
<wyclif> djazayeri, i plan to use a charet as the separator meaning the path should not contain charet
|
18:54:47
|
<bwolfe> wyclif, use "||"
|
18:54:50
|
<bwolfe> (two pipes)
|
18:55:06
|
<bwolfe> carat is probably fine too...
|
18:55:22
|
<bwolfe> form_field_path probably?
|
18:55:28
|
<bwolfe> form_path doesn't seem descriptive enough
|
18:55:41
|
<djazayeri> how about a single character for the separator?
|
18:55:47
|
<bwolfe> I feel fine about "form_field". ...but that will get confused with the form_field table
|
18:56:28
|
<wyclif> ok
|
18:56:35
|
<djazayeri> the idea is that it's not specifically about form fields, i.e. html form entry doesn't have thos
|
18:56:47
|
<bwolfe> its about fields on a form, right?
|
18:57:00
|
<bwolfe> where "field" is a generic term not having to do with the field table
|
18:57:12
|
<djazayeri> bwolfe: well, what if it's some data-driven question-per-screen thing?
|
18:57:29
|
<wyclif> how about field_reference
|
18:57:48
|
<wyclif> or form_field_reference
|
18:57:51
|
*** downey has quit IRC
|
19:01:18
|
<wyclif> djazayeri, bwolfe i named it form_field_reference
|
19:01:34
|
<wyclif> djazayeri, bwolfe but it seems too long
|
19:01:54
|
<wyclif> djazayeri, bwolfe may be just field_reference
|
19:06:50
|
<djazayeri> wyclif: form_namespace_and_path ? :-)
|
19:09:26
|
<wyclif> djazayeri, that's fine to me too
|
19:16:06
|
*** downey has joined #openmrs
|
19:16:06
|
*** ChanServ sets mode: +o downey
|
19:16:06
|
*** OpenMRSBot sets mode: +o downey
|
19:32:03
|
*** downey has quit IRC
|
19:32:06
|
<OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Congratulations to all our #OpenMRS #GSoC students for passing their final evaluations! http://t.co/iMPWhm13 <http://twitter.com/OpenMRS/statuses/239076795817795585>
|
19:33:27
|
*** downey has joined #openmrs
|
19:33:27
|
*** ChanServ sets mode: +o downey
|
19:33:27
|
*** OpenMRSBot sets mode: +o downey
|
19:34:57
|
*** downey has quit IRC
|
19:35:11
|
*** downey has joined #openmrs
|
19:35:11
|
*** ChanServ sets mode: +o downey
|
19:35:11
|
*** OpenMRSBot sets mode: +o downey
|
19:36:25
|
*** downey has quit IRC
|
19:36:36
|
*** downey has joined #openmrs
|
19:36:36
|
*** ChanServ sets mode: +o downey
|
19:36:36
|
*** OpenMRSBot sets mode: +o downey
|
19:36:48
|
*** downey has quit IRC
|
19:37:06
|
*** downey has joined #openmrs
|
19:37:06
|
*** OpenMRSBot sets mode: +o downey
|
19:37:06
|
*** ChanServ sets mode: +o downey
|
19:56:35
|
*** r0bby is now known as robbyoconnor
|
20:11:29
|
*** r0bby has joined #openmrs
|
20:11:29
|
*** ChanServ sets mode: +v r0bby
|
20:13:17
|
*** downey has quit IRC
|
20:13:22
|
*** downey_ has joined #openmrs
|
20:13:22
|
*** ChanServ sets mode: +o downey_
|
20:13:28
|
*** downey_ has quit IRC
|
20:14:18
|
*** robbyoconnor has quit IRC
|
20:19:31
|
*** mvorobey has quit IRC
|
20:23:57
|
*** r0bby has quit IRC
|
20:32:04
|
*** jkeiper has quit IRC
|
20:35:09
|
*** robbyoconnor has joined #openmrs
|
20:35:09
|
*** ChanServ sets mode: +v robbyoconnor
|
20:41:20
|
*** downey has joined #openmrs
|
20:41:20
|
*** ChanServ sets mode: +o downey
|
20:41:20
|
*** OpenMRSBot sets mode: +o downey
|
20:41:45
|
*** Andrea has joined #openmrs
|
20:42:04
|
*** Andrea is now known as Guest19825
|
20:42:18
|
<Guest19825> Ben are you on?
|
20:42:31
|
<bwolfe> Guest19825, yes.
|
20:42:36
|
<Guest19825> It's Andrea
|
20:42:53
|
<bwolfe> Guest19825, type /nick andreapatt
|
20:43:05
|
<Guest19825> Got it working
|
20:43:40
|
<Guest19825> so I've only downloaded Java 1.6 so far
|
20:44:01
|
<bwolfe> ok
|
20:44:06
|
<bwolfe> no eclipse, etc yet?
|
20:44:28
|
<Guest19825> Anything else you suggest I do to get started
|
20:44:48
|
<Guest19825> Not yet - will do
|
20:45:49
|
<Guest19825> Still have a lttle more paperwork to fax - it's never ending but wanted to touch bases before you left
|
20:47:12
|
*** jordank has joined #openmrs
|
20:49:39
|
<bwolfe> Guest19825, you were just in time. :-)
|
20:50:00
|
<bwolfe> Guest19825, after you get eclipse going, you can try to create an openmrs module
|
20:50:05
|
<bwolfe> https://wiki.openmrs.org/display/docs/Creating+Modules
|
20:50:06
|
<bwolfe> and
|
20:50:11
|
<bwolfe> https://wiki.openmrs.org/display/docs/Creating+Your+First+Module
|
20:50:12
|
<OpenMRSBot> <http://ln-s.net/8c6T> (at wiki.openmrs.org)
|
20:50:27
|
<bwolfe> Guest19825, but thats after you get eclipse + git + openmrs. :-)
|
20:50:37
|
<bwolfe> Guest19825, I will assign a small ticket for you to work on for monday
|
20:50:48
|
<bwolfe> Guest19825, send me an email to remind me to do that over the weekend. :-)
|
20:51:32
|
<bwolfe> ok, gotta run
|
20:55:13
|
*** bwolfe has quit IRC
|
21:32:04
|
*** kdeeq has quit IRC
|
21:41:17
|
*** applecool has quit IRC
|
21:42:13
|
*** wyclif has quit IRC
|
22:00:47
|
*** Guest19825 has quit IRC
|
22:01:30
|
*** Andrea has joined #openmrs
|
22:01:54
|
*** Andrea is now known as Guest99680
|
22:11:32
|
*** downey has quit IRC
|
22:25:24
|
*** jordank has quit IRC
|
22:27:19
|
*** Guest99680 has quit IRC
|
22:49:54
|
*** jordank has joined #openmrs
|
22:59:59
|
*** wyclif has joined #openmrs
|
23:30:19
|
*** jordank has quit IRC
|
23:31:45
|
*** jordank has joined #openmrs
|