| 01:25:44 | *** bwolfe has joined #openmrs |
| 01:25:44 | *** ChanServ sets mode: +o bwolfe |
| 04:00:27 | *** bwolfe has quit IRC |
| 05:26:06 | *** deadpool has quit IRC |
| 05:50:07 | *** jibesh has joined #openmrs |
| 05:51:50 | *** jibesh has joined #openmrs |
| 06:02:09 | *** jibesh has quit IRC |
| 07:21:21 | *** dkayiwa has joined #openmrs |
| 07:21:21 | *** Lenovo has joined #openmrs |
| 07:31:55 | *** Lenovo_ has joined #openmrs |
| 07:32:54 | *** Lenovo has quit IRC |
| 07:32:54 | *** Lenovo_ has quit IRC |
| 08:11:25 | *** rafa has joined #openmrs |
| 08:11:26 | *** dkayiwa has quit IRC |
| 08:12:07 | *** dkayiwa has joined #openmrs |
| 08:22:03 | *** rafa is now known as Guest64978 |
| 10:18:27 | *** rfriedman_away has quit IRC |
| 11:00:02 | *** kdeeq has joined #openmrs |
| 11:02:04 | *** rram__ has joined #openmrs |
| 11:05:33 | *** kdeeq has quit IRC |
| 11:14:48 | *** james_regen has joined #openmrs |
| 11:14:48 | *** ChanServ sets mode: +v james_regen |
| 11:21:59 | *** kdeeq has joined #openmrs |
| 11:24:13 | *** snoppy has joined #openmrs |
| 11:34:20 | *** rram__ has quit IRC |
| 11:37:25 | *** harshadura has joined #openmrs |
| 11:38:26 | *** harshadura has quit IRC |
| 11:38:48 | *** kdeeq has quit IRC |
| 11:39:07 | *** kdeeq has joined #openmrs |
| 12:10:01 | *** mgielow has joined #openmrs |
| 12:10:45 | *** kdeeq has quit IRC |
| 12:13:24 | *** pulasthi7 has joined #openmrs |
| 12:13:45 | <pulasthi7> hi james_regen |
| 12:14:00 | <james_regen> pulasthi7: hi |
| 12:14:52 | <pulasthi7> james_regen, I wanted to discuss about the release with you |
| 12:15:01 | <james_regen> pulasthi7: ok |
| 12:15:16 | <pulasthi7> james_regen, should we first give some beta version before the release? |
| 12:17:12 | *** bwolfe has joined #openmrs |
| 12:17:12 | *** ChanServ sets mode: +o bwolfe |
| 12:17:15 | <james_regen> pulasthi7: we've never been so formal before. i think we can if we know a few different people will test the beta and give us feedback fairly quickly |
| 12:18:34 | <pulasthi7> james_regen, so was the release happen, straight away? |
| 12:19:42 | *** downey has joined #openmrs |
| 12:19:42 | *** OpenMRSBot sets mode: +o downey |
| 12:19:42 | *** ChanServ sets mode: +o downey |
| 12:19:44 | <james_regen> pulasthi7: you mean can we release a beta really soon? |
| 12:22:53 | <pulasthi7> james_regen, yes, with what has done upto now |
| 12:23:55 | <james_regen> pulasthi7: you and suranga probably know better than i do if it's ready, but i would be inclinced to get it out there and get people using it. we can try to find problems ourselves, but it would probably be quicker to have other people tell us what's wrong so we can fix it |
| 12:29:57 | *** snoppy has left #openmrs |
| 12:32:36 | <pulasthi7> james_regen, sorry, i had to go out for a bit |
| 12:32:52 | *** kdeeq has joined #openmrs |
| 12:33:41 | <pulasthi7> james_regen, i discussed with suranga with the release. we have done some tests and fixed the problems we found |
| 12:34:24 | <pulasthi7> james_regen, but there may be issues when it is used in different context |
| 12:34:45 | <james_regen> pulasthi7: there probably will be, but we'll never know until someone else tries it |
| 12:36:11 | *** harshadura has joined #openmrs |
| 12:37:49 | <pulasthi7> james_regen, so shall we prepare a beta one and made available first? |
| 12:45:04 | <james_regen> pulasthi7: that will be fine. others might know better, but i would guess an email to the implementor's list would let enough people know to test it |
| 12:46:17 | <pulasthi7> ok james_regen , i'll do so. :) |
| 12:50:47 | *** pulasthi7 has quit IRC |
| 12:57:01 | *** rfriedman has joined #openmrs |
| 12:58:34 | <rfriedman> bwolfe, morning, ben |
| 12:58:39 | <bwolfe> hi roger |
| 12:59:02 | <rfriedman> bwolfe, is the process for moving modules from svn to git pretty well understood now? |
| 12:59:44 | <bwolfe> yes, its been vetted a number of times |
| 13:00:04 | <rfriedman> is there a set of instructions somewhere? |
| 13:01:56 | <bwolfe> aside from the standard one? https://wiki.openmrs.org/display/docs/Migrating+to+Git |
| 13:02:12 | <rfriedman> bwolfe, and do I have to make sure that all code contributors are registered in git like you had to do? |
| 13:02:50 | <bwolfe> if you want their code attributed, yes |
| 13:03:37 | <rfriedman> bwolfe, tks, I will look this over |
| 13:10:33 | *** kdeeq has quit IRC |
| 13:25:40 | *** applecool has joined #openmrs |
| 13:25:40 | *** ChanServ sets mode: +v applecool |
| 13:31:35 | <rfriedman> bwolfe, where does .gitignore go? |
| 13:31:59 | <bwolfe> base folder. see other gitified projects as examples and exmaple content |
| 13:32:25 | <rfriedman> bwolfe, at which level is what i meant |
| 13:33:58 | *** mvorobey has joined #openmrs |
| 13:34:23 | <bwolfe> rfriedman, it can go at any level |
| 13:34:33 | <bwolfe> but we only do it at the top one. I think it gets inheritied |
| 13:34:50 | <rfriedman> ok tks bwolfe |
| 13:35:04 | <mvorobey> hi all |
| 13:35:18 | <mvorobey> hi bwolfe |
| 13:35:48 | <rfriedman> and bwolfe , once you've put it on the github, do you need to refork it to get a working copy? |
| 13:39:33 | <bwolfe> hi mvorobey |
| 13:39:46 | <bwolfe> rfriedman, thats probably best option |
| 13:40:00 | <bwolfe> rfriedman, or you can do the ones I outlined in the email about trunk going to github |
| 13:42:24 | <mvorobey> bwolfe, is there a way to programatically get module ID from module code at runtime ? |
| 13:42:35 | <mvorobey> code = java code |
| 13:42:46 | <mvorobey> meaning any module class |
| 13:42:53 | <bwolfe> no. why do you need it? don't you know your own module id? :-) |
| 13:43:28 | <bwolfe> mvorobey, this nasty looking thing would do it: ((ModuleClassLoader)this.getClass().getClassLoader()).getModule().getModuleId() |
| 13:45:54 | <mvorobey> bwolfe, actually, I need to write log entry that says that "Module MODULE_ID has started with limited functionality" and wanted if there is a way to avoid hard-coding module ID in here |
| 13:45:55 | *** dkayiwa has quit IRC |
| 13:57:26 | *** cpower has joined #openmrs |
| 14:00:27 | <cpower> Hello! |
| 14:01:17 | <cpower> Make sure you say goodbye to your favorite GSoC student today as this is the end of the road, we will miss you and hope you come back to volunteer soon! |
| 14:01:40 | *** sunbiz has joined #openmrs |
| 14:01:40 | *** ChanServ sets mode: +v sunbiz |
| 14:02:15 | <cpower> Let us begin our Scrum |
| 14:02:16 | <bwolfe> goodbye cpower! |
| 14:02:19 | <Guest64978> mvorobey: put module id in properties file |
| 14:02:22 | <bwolfe> oh wait, you're not an intern |
| 14:02:26 | *** Guest64978 is now known as rafa |
| 14:02:55 | *** rafa is now known as Guest82300 |
| 14:03:02 | <cpower> oooh ouch... you never know when I might go. |
| 14:03:14 | <sunbiz> !seen rafa |
| 14:03:14 | <OpenMRSBot> sunbiz: rafa was last seen in #openmrs 23 hours, 12 minutes, and 12 seconds ago: <rafa> applecool: maybe a few screenshots for those not wanting to watch a video |
| 14:03:17 | <cpower> !scrumon cpower |
| 14:03:17 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:03:36 | *** Guest82300 has quit IRC |
| 14:03:53 | <cpower> Order: bwolfe, djazayeri, mvorobey...and anyone else who would like to share. |
| 14:05:03 | <bwolfe> Friday |
| 14:05:03 | <bwolfe> vacation day |
| 14:05:03 | <bwolfe> Monday |
| 14:05:03 | <bwolfe> emails |
| 14:05:03 | <bwolfe> git migration cleanup |
| 14:05:04 | <bwolfe> review git workflow |
| 14:05:06 | <bwolfe> try out git workflow |
| 14:05:08 | <bwolfe> change git workflow (assuming) |
| 14:05:10 | <bwolfe> call with sunny |
| 14:05:14 | <bwolfe> review sprint tickets |
| 14:05:16 | <bwolfe> no blockers. except my email inbox. stop replying to my emails people! |
| 14:05:39 | *** rafal has joined #openmrs |
| 14:06:06 | <cpower> djazayeri you are up |
| 14:06:07 | * rafal irc doesn't like me today |
| 14:06:37 | <cpower> I like your rafa, but late to class means your at the end of the line |
| 14:06:41 | <mvorobey> rafal, :) |
| 14:07:05 | <cpower> and skip, mvorobey you are up |
| 14:07:25 | <mvorobey> * Committed follow up fix for - CSTM-27 |
| 14:07:25 | <mvorobey> * Work in progress - CSTM-10 |
| 14:07:25 | <mvorobey> * Prepared video presentation for for 2012-08-23 Devs Call |
| 14:07:25 | <mvorobey> No blockers |
| 14:07:30 | <bwolfe> !seen dkayiwa |
| 14:07:30 | <OpenMRSBot> bwolfe: dkayiwa was last seen in #openmrs 1 day, 16 hours, 13 minutes, and 56 seconds ago: <dkayiwa> goutham: have a good night too :) |
| 14:08:06 | <cpower> rafa, you are up |
| 14:08:46 | <rafal> Today: * Removed and ignored eclipse files from openmrs-core (not sure yet how to best back port so simply redid changes in branches) * Working on META-239: Convert concepts between their 1.8 and 1.9 representations https://tickets.openmrs.org/browse/META-239 No blockers. |
| 14:09:00 | <rafal> sorry for the formatting, I'm on web client |
| 14:09:11 | <cpower> no worries. |
| 14:09:30 | <cpower> No blockers besides people need to leave Ben alone so he can focus. |
| 14:09:43 | <cpower> No discussion points |
| 14:09:47 | <cpower> !scrumoff |
| 14:09:47 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:11:18 | <bwolfe> rafal, backporting will probably be cherry picking |
| 14:11:53 | <bwolfe> rafal, kishore will work on getting the changes to branches backported today. he forgot to include those! :-( |
| 14:12:10 | <rafal> bwolfe: yes, reading about it right now :) |
| 14:12:13 | <bwolfe> downey, can you lock down the branches to commits? I see one on saturday by nimantha to his branch |
| 14:12:19 | <bwolfe> rafal++ |
| 14:12:27 | <bwolfe> rafal, no rafa today? |
| 14:12:29 | <downey> bwolfe: url? |
| 14:12:39 | <sunbiz> bwolfe: was gonna ask the same |
| 14:12:47 | <rafal> bwolfe: freenode doesn't want to let me in for some reason :P |
| 14:12:55 | <sunbiz> bwolfe: will u b backporting the stuff using cherry picking the commit :D |
| 14:13:19 | <bwolfe> downey, url for what? anything in svn.openmrs.org/openmrs should only be edited by me (or admins) |
| 14:13:35 | <bwolfe> sunbiz, which stuff? |
| 14:13:45 | <rafal> sunbiz: hi sorry, can we reschedule the call for tomorrow? |
| 14:14:42 | <downey> bwolfe: url of where that commit happened |
| 14:15:28 | <sunbiz> bwolfe: the ones from my pull requests that have been merged |
| 14:15:39 | <bwolfe> downey, saw it here: https://source.openmrs.org/changelog/OpenMRS |
| 14:16:37 | <sunbiz> rafal: ok... same time tomorrow?? |
| 14:16:45 | <bwolfe> sunbiz, yes, I planned on testing out cherry picking on those. (unless you want to just submit pull requests before I get to it... ;-)) |
| 14:17:26 | <rafal> sunbiz: sure |
| 14:17:31 | <sunbiz> nah... shouldn't be doing it?? Or whoever is merging the pull request?? |
| 14:18:59 | <sunbiz> rafal: u are so fast!! are u continously just pressing the refresh button on ur email!! :P |
| 14:20:01 | <rafal> sunbiz: haha I've got my mails on a different monitor so they get my attention very quickly |
| 14:21:06 | <sunbiz> rafal: good idea... lemme do that as well now! |
| 14:26:03 | <bwolfe> rafal, thats actually an anti-pattern. do you find yourself getting pulled into too many emails too often? unable to get a stream of work done? |
| 14:26:15 | *** rafal has quit IRC |
| 14:26:26 | <bwolfe> guess he got pulled away :-p |
| 14:27:18 | <sunbiz> bwolfe: ohhh... should have warned me earlier |
| 14:27:27 | <sunbiz> I just got it running now :P |
| 14:30:56 | <bwolfe> sunbiz, easy to close that window ;-) |
| 14:32:51 | *** cpower has quit IRC |
| 14:33:59 | <sunbiz> bwolfe: not just the window... I connected a spare monitor just after rafal's suggestion... but yea I'll have something else on it |
| 14:40:59 | <bwolfe> sunbiz, irc is even worse to put on it. ;-) |
| 14:41:09 | <sunbiz> bwolfe: haha!! true |
| 14:41:14 | *** mvorobey has quit IRC |
| 14:41:26 | <sunbiz> bwolfe: I can see myself looking for u to reply |
| 14:41:29 | <sunbiz> more often :D |
| 14:43:21 | *** applecool has quit IRC |
| 14:45:30 | * bwolfe knows how sunbiz thinks |
| 14:49:10 | <bwolfe> downey, remember those jira issues where I said "I could have sworn I replied to this" ? |
| 14:49:31 | <downey> bwolfe: :) |
| 14:49:33 | <bwolfe> downey, those comments are now showing up on tickets...I think they were all email-ticket-comments. Was there a mail queue backup somewhere? |
| 14:49:56 | <bwolfe> I also see comments from uma posting minutes ago even though she is gone... |
| 14:50:42 | <downey> bwolfe: yes, it seems IU had changed the outbound firewall rules without letting us know, so we couldn't connect over (traditional) POP for a couple weeks. |
| 14:51:15 | <bwolfe> ugh |
| 14:52:04 | *** kavuri has joined #openmrs |
| 14:52:06 | <bwolfe> sunbiz, lets put the full ticket url in the commit comment or pull request comment. |
| 14:53:17 | <bwolfe> sunbiz, its annoying to have to find/copy the id to a url. :-) |
| 14:59:32 | <sunbiz> bwolfe: okies... sounds good. Pull request comment sounds good |
| 14:59:43 | <sunbiz> commit comment just becomes very big |
| 15:00:01 | <bwolfe> yeah, thats only for direct master commits really |
| 15:05:33 | *** harshadura has quit IRC |
| 15:05:56 | *** harshadura has joined #openmrs |
| 15:31:34 | *** tobin_g has joined #openmrs |
| 15:31:50 | <downey> Hi tobin_g and welcome to the #openmrs IRC channel. |
| 15:37:35 | <rfriedman> bwolfe, just looking at your post re unit testing ... |
| 15:37:45 | *** mvorobey has joined #openmrs |
| 15:37:58 | *** deadpool has joined #openmrs |
| 15:38:00 | <rfriedman> ... where is the boundary for multi-tasking? between methods of a test class or between test classes? |
| 15:47:07 | *** cpower has joined #openmrs |
| 15:47:14 | <cpower> bwolfe you around? |
| 15:51:31 | *** rafa has joined #openmrs |
| 15:51:31 | *** ChanServ sets mode: +v rafa |
| 15:56:26 | *** tobin_g has quit IRC |
| 15:57:17 | *** tobin_g has joined #openmrs |
| 15:58:08 | *** djazayeri1 has joined #openmrs |
| 15:59:04 | *** djazayeri has quit IRC |
| 16:00:05 | *** djazayeri1 is now known as djazayeri |
| 16:00:05 | *** ChanServ sets mode: +o djazayeri |
| 16:02:52 | *** jkeiper has joined #openmrs |
| 16:03:15 | <rfriedman> downey, hey mike, how do we get attachments removed from wiki pages? |
| 16:06:51 | <downey> rfriedman: unfortunately confluence doesn't have as granular permissions as jira, so either an admin or a core developer can remove them |
| 16:07:24 | <rfriedman> ok, so do you want an ITSM request to do so or can I do it here? |
| 16:07:36 | <downey> either way :) |
| 16:07:47 | <downey> since i'm here…. you might just do that |
| 16:08:01 | <jkeiper> djazayeri, are there permissions to let a user only view (but not update) a report? |
| 16:08:07 | <rfriedman> https://wiki.openmrs.org/pages/viewpageattachments.action?pageId=15139153 |
| 16:08:23 | <djazayeri> jkeiper: I don't know offhand |
| 16:08:31 | <downey> rfriedman: any specific file? |
| 16:08:37 | <jkeiper> djazayeri, k ... i'll look at wiki docs |
| 16:08:55 | <rfriedman> there are 2 copies of user_guide.wmv from yester day and today (plus one uploading now) -- both should be deleted |
| 16:09:10 | <rfriedman> actually both yesterday |
| 16:09:43 | <jkeiper> djazayeri, also ... serialization.xstream 0.2.6 doesn't have a nexus repo does it? /me could only find 0.2.5 |
| 16:09:48 | <downey> rfriedman: both from yesterday are gone |
| 16:10:00 | <rfriedman> thanks |
| 16:10:22 | <djazayeri> jkeiper: see http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/module/serialization.xstream/ |
| 16:10:23 | <downey> rfriedman: no prob |
| 16:12:03 | <jkeiper> zoinks! |
| 16:12:03 | <jkeiper> not sure where i was looking! |
| 16:12:03 | <jkeiper> heh |
| 16:12:03 | <jkeiper> perhaps my pom isn't referencing the repo right |
| 16:12:35 | <djazayeri> jkeiper: it's possible. I think we have a few modules in an incorrect place |
| 16:12:49 | <djazayeri> jkeiper: so you can easilby be fooled to look there |
| 16:13:41 | <jkeiper> djazayeri, does it require type=pom? |
| 16:13:52 | <jkeiper> ah, that might be it |
| 16:16:12 | <jkeiper> bingo |
| 16:18:53 | *** kavuri has quit IRC |
| 16:24:44 | *** downey has quit IRC |
| 16:28:39 | *** downey has joined #openmrs |
| 16:31:46 | *** downey has joined #openmrs |
| 16:31:46 | *** ChanServ sets mode: +o downey |
| 16:31:46 | *** OpenMRSBot sets mode: +o downey |
| 16:36:21 | *** downey has quit IRC |
| 16:37:25 | *** downey has joined #openmrs |
| 16:37:25 | *** OpenMRSBot sets mode: +o downey |
| 16:37:25 | *** ChanServ sets mode: +o downey |
| 16:39:26 | *** downey_ has joined #openmrs |
| 16:39:26 | *** ChanServ sets mode: +o downey_ |
| 16:39:54 | *** downey has quit IRC |
| 16:39:54 | *** downey_ is now known as downey |
| 16:43:54 | <rafa> downey: hi, is there a way yet to sync google and confluence calendar? |
| 16:50:18 | <rafa> downey: I guess there is https://confluence.atlassian.com/display/TEAMCAL/Subscribing+to+Team+Calendars+from+Google+Calendar but it is not working due to authentication required... |
| 16:50:24 | <OpenMRSBot> <http://ln-s.net/$fCm> (at confluence.atlassian.com) |
| 16:52:26 | <bwolfe> rafa, better to just use a google calendar and link it into the wiki... |
| 16:53:33 | <rafa> bwolfe: yeah I'd vote for that |
| 17:19:27 | *** downey has quit IRC |
| 17:19:36 | *** downey has joined #openmrs |
| 17:19:36 | *** ChanServ sets mode: +o downey |
| 17:19:36 | *** OpenMRSBot sets mode: +o downey |
| 17:32:50 | *** tobin_g has quit IRC |
| 17:40:52 | *** piyush has joined #openmrs |
| 17:41:00 | <downey> Hi piyush and welcome to the #openmrs IRC channel. |
| 17:46:48 | *** piyush has quit IRC |
| 17:47:38 | *** piyush has joined #openmrs |
| 17:55:31 | *** goutham has joined #openmrs |
| 17:57:33 | *** goutham has quit IRC |
| 17:59:12 | *** piyush has quit IRC |
| 18:11:11 | *** piyush has joined #openmrs |
| 18:16:32 | *** sunbiz has quit IRC |
| 18:25:19 | *** jkeiper has quit IRC |
| 18:53:11 | *** mgielow has quit IRC |
| 18:55:07 | *** goutham has joined #openmrs |
| 18:55:48 | *** mvorobey has quit IRC |
| 18:55:55 | *** jkeiper has joined #openmrs |
| 18:58:29 | <rfriedman> downey, mike, we have a 104MB video for the HR Module, Confluence won't accept it for the wiki page. Any suggestions? Like put it in svn? |
| 18:59:20 | <downey> rfriedman: YouTube, blip.tv, etc. |
| 18:59:30 | <downey> (i assume this isn't the 3-minute version) |
| 18:59:37 | <rfriedman> no |
| 18:59:53 | <rfriedman> downey, do we have an organizational account at YouTube or what? |
| 18:59:55 | *** piyush has quit IRC |
| 18:59:57 | <downey> rfriedman: either one of those mentioned can be embedded within a wiki page using the relevant macro |
| 19:00:26 | *** piyush has joined #openmrs |
| 19:00:28 | <downey> rfriedman: there is, but generally the students are uploading videos on their own personal accounts |
| 19:00:57 | <rfriedman> ok, I will see what I can do |
| 19:01:45 | <bwolfe> downey, any of the videos under 3 mins yet? :-p |
| 19:03:29 | *** james_regen has left #openmrs |
| 19:08:37 | *** sunbiz has joined #openmrs |
| 19:08:37 | *** ChanServ sets mode: +v sunbiz |
| 19:14:49 | <rfriedman> downey, youtube won't allow 104MB |
| 19:16:01 | <downey> bwolfe: yes, most so far :) |
| 19:16:03 | <rfriedman> downey, never mind, I'll have sandeep split it in two |
| 19:16:06 | <downey> rfriedman: how long is it in minutes? |
| 19:16:16 | <rfriedman> 18 mins? |
| 19:16:50 | <rfriedman> I'll just have him split it, he put it together from parts |
| 19:17:00 | <downey> rfriedman: ah, i think 15 minutes is the initial time limit. that should work. |
| 19:20:46 | *** tobin_g has joined #openmrs |
| 19:53:32 | *** jkeiper has quit IRC |
| 19:53:33 | *** downey has quit IRC |
| 19:56:50 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Congratulations to our #OpenMRS Google Summer of Code students for a fantastic year! Pencils down! #GSoC <http://twitter.com/OpenMRS/statuses/237626965417406464> |
| 20:07:48 | *** dkayiwa has joined #openmrs |
| 20:10:12 | *** piyush has quit IRC |
| 20:18:24 | *** goutham has quit IRC |
| 20:22:43 | *** piyush has joined #openmrs |
| 20:23:42 | <bwolfe> dkayiwa, missed you on the scrum today... |
| 20:24:06 | <dkayiwa> bwolfe: oh sorry was away :) |
| 20:31:32 | *** piyush has quit IRC |
| 20:36:56 | *** piyush has joined #openmrs |
| 20:47:29 | *** piyush has quit IRC |
| 20:51:10 | <bwolfe> dkayiwa, can you give your update now? |
| 20:59:21 | <dkayiwa> Doing a final review of my gsoc students' code |
| 20:59:22 | <dkayiwa> Used YourKit profiler and found two instances of OpenmrsClassLoader which do not get garbage collected for: Potential Memory Leak reported by Tomcat 7 - TRUNK-3056 |
| 20:59:22 | <dkayiwa> Now Curating tickets |
| 20:59:22 | <dkayiwa> No Blockers |
| 21:01:29 | <bwolfe> dkayiwa, ooo, are those fixable dkayiwa? |
| 21:01:34 | <bwolfe> !ticket TRUNK-3056 |
| 21:01:36 | <OpenMRSBot> bwolfe: [#TRUNK-3056] Potential Memory Leak reported by Tomcat 7 - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3056 |
| 21:03:41 | <dkayiwa> bwolfe: i tried to uncomment the code for setting the contextClassLoader for threads, on destroy context, and it reduced to one. But still had another memory leak where a timer thread had its contextClassLoader preventing the WebappClassLoader from being garbage collected |
| 21:04:19 | <dkayiwa> for destroy context i meant destroyInstance |
| 21:04:30 | <dkayiwa> method for OpenmrsClassLoader |
| 21:06:40 | <bwolfe> dkayiwa, but wasn't that commented out for a reason? didn't it cause issues? whats the comment around that? |
| 21:07:40 | <dkayiwa> bwolfe: that is exactly why i did not commit it. uncommented it out only to see the effect :) |
| 21:12:24 | <dkayiwa> bwolfe: the commented out code has no comment around it |
| 21:29:01 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 1.8 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=uiframework&version=&1.8> |
| 21:32:46 | *** goutham has joined #openmrs |
| 21:33:28 | <goutham> dkayiwa: hi |
| 21:33:35 | <dkayiwa> goutham: hi |
| 21:34:20 | <goutham> dkayiwa: iam just uploading the video to you tube |
| 21:35:01 | <dkayiwa> goutham: oh that is great!!! |
| 21:49:06 | <goutham> dkayiwa: James mentioned roles should be considered unique |
| 21:50:11 | <dkayiwa> goutham: after the cosmetic? |
| 21:50:32 | <goutham> dkayiwa: but user object has menthod hasRoles() which considers interfaces and its implementation |
| 21:51:42 | *** goutham_ has joined #openmrs |
| 21:51:46 | *** goutham has quit IRC |
| 21:51:56 | <dkayiwa> goutham_: ok |
| 21:53:32 | <goutham_> dkayiwa: can you explain me the clerk one which james talking about |
| 21:54:55 | <goutham_> dkayiwa: its that i should not consider inheritance. |
| 21:55:26 | <dkayiwa> goutham_: yes that is what he says. although i feel the default should consider inheritance |
| 21:55:37 | <dkayiwa> goutham_: exactly as you did it |
| 21:55:58 | <dkayiwa> goutham_: so to accomodate him, we could add a global property that turns inheritance off |
| 21:56:44 | <dkayiwa> goutham_: if you looks at the code for User.getAllRoles(), you will see how it adds the base and inherited roles |
| 21:56:46 | *** rafa has quit IRC |
| 21:57:45 | * goutham_ going in deep corners of openmrs core |
| 21:57:48 | <dkayiwa> goutham_: so for case where inheritance is turned off, you could call User.getRoles(), and then do the comparison yourself instead of User.hasRole |
| 21:57:53 | <dkayiwa> goutham_: yes |
| 21:57:55 | *** goutham_ is now known as goutham |
| 21:58:39 | <goutham> dkayiwa: what should be the property name ? |
| 21:59:06 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting 0.7.2.1 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reporting&version=&0.7.2.1> |
| 22:00:02 | <goutham> dkayiwa: some of the users may not understand the name inherit roles (Yes/No) |
| 22:00:35 | <dkayiwa> goutham: that is why the default should be to use role inheritance |
| 22:00:51 | <dkayiwa> goutham: then those who do not understand it, they do not have to do anything |
| 22:01:21 | <dkayiwa> goutham: something like: formFilter.useRoleInheritanceComparison |
| 22:01:26 | <goutham> dkayiwa: :) |
| 22:01:55 | <dkayiwa> goutham: if that global property does not exit (say deleted by user) you assume YES |
| 22:03:02 | <goutham> dkayiwa: i thought keeping radio buttons yes and no by default yes will be checked |
| 22:03:35 | <dkayiwa> goutham: do not worry about that |
| 22:03:39 | <goutham> dkayiwa: will implement it tomorrow |
| 22:03:52 | <dkayiwa> goutham: just add the global property and use it when doing the comparisons |
| 22:04:08 | <dkayiwa> goutham: it should be a small change to add and then send him a module to test |
| 22:04:23 | <dkayiwa> goutham: hopefully this time he will not have any more issues :) |
| 22:05:02 | <dkayiwa> goutham: tomorrow is fine |
| 22:05:46 | <goutham> dkayiwa, :D my doubt is how can user specify yes and no to that global property... from where the value will be assigned |
| 22:07:05 | <dkayiwa> goutham: they will just type yes or no |
| 22:07:36 | <dkayiwa> goutham: or may be true or false |
| 22:07:57 | <dkayiwa> goutham: but just copy how openmrs does it for core global properties |
| 22:07:58 | <goutham> dkayiwa: ok:) |
| 22:09:13 | <goutham> dkayiwa: ok will have a look at it and implement it |
| 22:09:38 | <goutham> dkayiwa: Ulrich did u see Ulrich mail? |
| 22:11:18 | <dkayiwa> goutham: no |
| 22:12:42 | <goutham> dkayiwa: sorry he sent mail only to me:) . |
| 22:12:55 | <dkayiwa> goutham: ok |
| 22:13:07 | <goutham> dkayiwa: his question is " It is possible to limit access to a form to only a specific user/physician? " |
| 22:13:42 | <goutham> dkayiwa: are there any user types? or is he mentioning about Roles? |
| 22:14:21 | <dkayiwa> goutham: he can create a filter with a role for only that user |
| 22:15:55 | <goutham> dkayiwa: ok |
| 22:17:01 | <goutham> Thanks for the great support dkayiwa : ) |
| 22:18:02 | <dkayiwa> goutham: thanks too for your hard work :D |
| 22:18:27 | <goutham> dkayiwa: :) |
| 22:18:40 | <goutham> dkayiwa: i am feeling sleepy. |
| 22:19:00 | <goutham> Good night :) |
| 22:19:08 | <dkayiwa> goutham: ok get some rest :) |
| 22:19:37 | *** goutham has quit IRC |
| 22:20:40 | *** robbyoconnor has joined #openmrs |
| 22:20:40 | *** ChanServ sets mode: +v robbyoconnor |
| 22:23:32 | *** Lenovo has joined #openmrs |
| 22:31:09 | <rfriedman> djazayeri, did you get my e-mail about use of services in REST resources? |
| 22:32:34 | <djazayeri> rfriedman: google didn't put it in my priority inbox. looking at it now |
| 22:33:44 | <djazayeri> rfriedman: we don't have privileges for every property on every pojo |
| 22:34:07 | <rfriedman> no, I don't mean property level privileges |
| 22:34:12 | <djazayeri> rfriedman: e.g. there's no special privilege for adding a mapping to a concept, just the standard Manage Concepts. |
| 22:34:51 | <djazayeri> rfriedman: and generally you're allowed and expected to use pojo methods on the parent in the code for a subresource. |
| 22:36:01 | <rfriedman> djazayeri, right, but if I take the resource object and add a subresource to its collection of subresources, then there will be no privilege check for my right to write the resource |
| 22:37:22 | <djazayeri> rfriedman: the pattern in ConceptNameResource is that all those modifying methods call ConceptService.saveConcept |
| 22:38:06 | <djazayeri> rfriedman: and that's where the priv check would come from |
| 22:38:27 | <rfriedman> right, but that wasn't the case with person_name |
| 22:39:03 | <djazayeri> rfriedman: in the save, purge, etc, methods in ConceptNameResource, there's a call to ConceptService.saveConcept |
| 22:39:34 | <djazayeri> rfriedman: sorry, are you talking about using the Concept resource or the ConceptMapping resource? |
| 22:40:05 | <rfriedman> djazayeri, i'm just writing concept mapping |
| 22:40:52 | <rfriedman> djazayeri, if that's the pattern, i can do it, it's as good as anything, it just wasn't done in person_name |
| 22:40:55 | *** sunbiz has quit IRC |
| 22:41:20 | <djazayeri> rfriedman: is this something different from line 166 on ConceptNameResource? |
| 22:43:30 | <rfriedman> djazayeri, my mistake, personname does follow that pattern |
| 22:43:44 | <rfriedman> but shouldn't the save come before the add? |
| 22:44:05 | <rfriedman> we want the error thrown before the data chagnes, right? |
| 22:44:54 | <djazayeri> rfriedman: if the save line throws an exception (either privilege or validation) the whole transaction will be rolled back. Right? |
| 22:45:24 | <rfriedman> right |
| 22:45:27 | <djazayeri> rfriedman: though I don't know if there's actually a transaction wrapping this. If you can think of a way to test this out |
| 22:45:34 | <djazayeri> rfriedman: I'd be curious. |
| 22:46:02 | <rfriedman> djazayeri, well, I'll probably forget this before I finish, that'll be the test :) |
| 22:47:04 | <rfriedman> djazayeri, after all, Sandeep was apparently the first person to run a test as other than admin |
| 22:48:32 | <rfriedman> djazayeri, tks, c u later |
| 22:48:36 | <djazayeri> ciao |
| 22:49:08 | *** rfriedman has quit IRC |
| 23:09:44 | *** dkayiwa has quit IRC |
| 23:27:19 | *** dkayiwa has joined #openmrs |