| 00:36:44 | *** dmexs has joined #openmrs |
| 00:49:59 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Metadata Sharing 1.0.9 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=metadatasharing&version=&1.0.9> || OpenMRS Modules: Feedback 2.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=feedback&version=&2.0> |
| 01:02:09 | *** rafa has joined #openmrs |
| 01:02:09 | *** ChanServ sets mode: +v rafa |
| 01:07:46 | *** dmexs has quit IRC |
| 01:19:19 | *** dmexs has joined #openmrs |
| 01:22:24 | *** rafa has quit IRC |
| 01:25:53 | *** dmexs has quit IRC |
| 02:17:44 | *** jkeiper_ has joined #openmrs |
| 02:45:39 | *** jkeiper_ has quit IRC |
| 02:58:27 | *** basic` has quit IRC |
| 03:02:20 | *** basic` has joined #openmrs |
| 03:23:17 | *** maurya has joined #openmrs |
| 03:25:58 | *** maurya has quit IRC |
| 03:28:20 | *** sgithens has quit IRC |
| 03:28:23 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: Attention #OpenMRS developers: We're switching to @GitHub on Thursday. Read more: http://t.co/82KME2GQ <http://twitter.com/OpenMRS/statuses/235929862110601217> |
| 03:42:35 | *** harshadura has quit IRC |
| 03:45:21 | *** harshadura has joined #openmrs |
| 03:47:08 | *** bwolfe has quit IRC |
| 03:56:25 | *** suranga_ has joined #openmrs |
| 04:50:18 | *** kavuri has joined #openmrs |
| 04:53:26 | <kavuri> djazayeri: currently, when creating a patient, we will have to choose the hospital location from a drop down list. Typically a doctor is always associated with a pre-defined clinics/hospitals. Is it possible to have a mapping between a provider and a location |
| 05:11:18 | *** harshadura has quit IRC |
| 05:23:00 | *** kavuri has quit IRC |
| 05:28:50 | *** kishoreyekkanti has joined #openmrs |
| 06:07:12 | *** rram_ has joined #openmrs |
| 06:19:12 | *** kavuri has joined #openmrs |
| 06:22:07 | *** suranga_ has quit IRC |
| 06:57:15 | *** harshadura has joined #openmrs |
| 06:59:39 | *** dkayiwa has joined #openmrs |
| 07:02:24 | *** shortend has joined #openmrs |
| 07:05:30 | *** kishoreyekkanti has quit IRC |
| 07:15:51 | *** robbyoconnor has quit IRC |
| 07:22:51 | *** applecool has joined #openmrs |
| 07:22:51 | *** ChanServ sets mode: +v applecool |
| 07:35:10 | *** snoppy has joined #openmrs |
| 07:56:19 | *** piyush has joined #openmrs |
| 07:56:44 | *** piyush is now known as p_m |
| 07:59:59 | *** rafa has joined #openmrs |
| 07:59:59 | *** ChanServ sets mode: +v rafa |
| 08:04:56 | *** dkayiwa has quit IRC |
| 08:07:37 | *** kishoreyekkanti has joined #openmrs |
| 08:20:09 | *** shortend has quit IRC |
| 08:22:44 | *** shortend has joined #openmrs |
| 08:33:55 | *** dkayiwa has joined #openmrs |
| 08:34:56 | *** kishoreyekkanti_ has joined #openmrs |
| 08:36:40 | *** magoo_ has joined #openmrs |
| 08:37:30 | *** kishoreyekkanti has quit IRC |
| 08:41:30 | *** goutham has joined #openmrs |
| 08:51:48 | *** kishoreyekkanti_ has quit IRC |
| 08:55:09 | *** kishoreyekkanti has joined #openmrs |
| 08:55:31 | *** sunbiz has joined #openmrs |
| 08:55:31 | *** ChanServ sets mode: +v sunbiz |
| 08:59:02 | *** kishoreyekkanti_ has joined #openmrs |
| 09:00:46 | *** goutham has quit IRC |
| 09:01:14 | *** kishoreyekkanti has quit IRC |
| 09:05:01 | *** kishoreyekkanti_ has quit IRC |
| 09:13:42 | *** sunbiz has quit IRC |
| 09:16:11 | *** kishoreyekkanti has joined #openmrs |
| 09:20:53 | *** shortend has quit IRC |
| 09:20:59 | *** shortend has joined #openmrs |
| 09:21:00 | *** harshadura has quit IRC |
| 09:22:43 | *** harshadura has joined #openmrs |
| 09:31:58 | *** shortend has left #openmrs |
| 09:39:18 | *** rafa has quit IRC |
| 09:39:34 | *** kishoreyekkanti has quit IRC |
| 09:47:38 | *** rafa has joined #openmrs |
| 09:47:38 | *** ChanServ sets mode: +v rafa |
| 09:47:53 | <rafa> applecool: hi commit code |
| 09:47:56 | <rafa> applecool: I'll have a look |
| 09:48:13 | <applecool> okay rafa. just a second |
| 09:51:01 | <applecool> done rafa |
| 09:51:26 | <rafa> applecool: hmm you're committing to the branch... |
| 09:51:35 | <applecool> yes |
| 09:51:47 | <rafa> applecool: but it's a bug in 1.0 :) |
| 09:51:53 | <applecool> you told that we will merge it later right? |
| 09:52:04 | <applecool> yes sorry |
| 09:52:19 | <rafa> applecool: no problem |
| 09:52:30 | <rafa> applecool: you should commit 1.1 features to the branch |
| 09:52:36 | <rafa> applecool: bugs go to 1.0 |
| 09:52:42 | <applecool> yes sure |
| 09:52:56 | <rafa> applecool: have you committed any new features to 1.1 or just bug fixes? |
| 09:53:07 | <applecool> just big fixes |
| 09:53:12 | <applecool> no new features rafa |
| 09:53:15 | <rafa> applecool: ok, then let me merge it now |
| 09:53:20 | <applecool> okay |
| 09:55:47 | <rafa> applecool: where are you calling packageManager.save(metadataPackage)? |
| 09:56:11 | <applecool> oh no missed again |
| 09:56:59 | <applecool> just a sec rafa |
| 09:57:52 | <rafa> applecool: don't forget about ModelMap |
| 09:58:07 | <applecool> okay |
| 09:58:40 | <applecool> the changes in the packageform.jsp are okay right? |
| 09:58:46 | <applecool> or anything to be changed therE? |
| 09:59:29 | <rafa> applecool: <form:errors> for not editable fields are unnecessary |
| 09:59:51 | <applecool> yes |
| 09:59:57 | <applecool> will remove them right away |
| 10:00:09 | <rafa> applecool: and I still see that in PackageFormController you're trying to display a package after deleting it |
| 10:00:20 | <rafa> applecool: haven't you said you fixed that? |
| 10:01:33 | <applecool> i fixed it! when i remove the package it redirects to the mainMenu and displays the message |
| 10:01:38 | <applecool> and the package is removed too |
| 10:01:42 | <rafa> applecool: ohh I see you're always displaying mainMenu page |
| 10:01:49 | <applecool> yes |
| 10:03:10 | *** harshadura has quit IRC |
| 10:07:50 | *** kishoreyekkanti has joined #openmrs |
| 10:08:27 | *** kishoreyekkanti has joined #openmrs |
| 10:11:27 | *** Echidna has quit IRC |
| 10:12:20 | <applecool> rafa: i guess the test will fail now |
| 10:12:36 | <applecool> rafa: and here we go! test failed! :P |
| 10:16:54 | *** Echidna has joined #openmrs |
| 10:16:54 | *** ChanServ sets mode: +v Echidna |
| 10:22:04 | <applecool> rafa: fixed the test too rafa |
| 10:22:13 | <applecool> and it is working perfectly fine rafa |
| 10:22:22 | <rafa> applecool: good |
| 10:22:38 | <applecool> rafa: did you merge the 1.1 and 1.0 ? |
| 10:22:54 | <rafa> applecool: yes |
| 10:23:13 | <rafa> applecool: but before your fixes |
| 10:23:15 | <applecool> now before committing any steps do i need to follow ? |
| 10:23:47 | <rafa> applecool: you just need to: git checkout master |
| 10:23:52 | <rafa> applecool: and then commmit and push |
| 10:24:25 | <applecool> okay :) |
| 10:24:33 | <applecool> you were saying something before rafa / |
| 10:24:34 | <applecool> ? |
| 10:24:39 | <rafa> applecool: ? |
| 10:24:45 | <applecool> was that the same thing? |
| 10:24:50 | *** harshadura has joined #openmrs |
| 10:24:55 | <applecool> 15:53 rafa: applecool: but before your fixes |
| 10:24:57 | *** harshadura has quit IRC |
| 10:25:04 | *** harshadura_ has joined #openmrs |
| 10:25:20 | <rafa> applecool: nevermind |
| 10:25:25 | <applecool> okay |
| 10:39:27 | *** p_m has quit IRC |
| 10:40:01 | *** suranga has joined #openmrs |
| 10:40:01 | *** ChanServ sets mode: +v suranga |
| 10:40:27 | *** snoppy has left #openmrs |
| 10:42:38 | *** kavuri has quit IRC |
| 10:46:40 | *** magoo_ has quit IRC |
| 10:50:40 | <dkayiwa> hi rafa |
| 10:50:47 | <rafa> dkayiwa: hi |
| 10:50:56 | <dkayiwa> rafa: do umean fix what Mark reported? |
| 10:51:04 | <rafa> dkayiwa: yes |
| 10:51:12 | <dkayiwa> rafa: ok |
| 10:51:22 | <rafa> dkayiwa: add @Transational(readOnly=true) to the notifyPrivilegeListeners |
| 10:51:29 | <dkayiwa> rafa: do we have a ticket for it? |
| 10:51:32 | <rafa> dkayiwa: no |
| 10:51:37 | <dkayiwa> rafa: ok |
| 10:51:46 | *** p_m has joined #openmrs |
| 10:55:30 | *** kishoreyekkanti_ has joined #openmrs |
| 10:59:04 | *** kishoreyekkanti has quit IRC |
| 10:59:41 | <applecool> rafa: i have trouble while committing and push here is the stack trace: http://pastebin.com/6yXcvFpS |
| 10:59:49 | <applecool> can you please tell me whats wrong? |
| 11:00:14 | *** kavuri has joined #openmrs |
| 11:00:28 | <rafa> applecool: ahh right you can't change branches with uncommitted changes |
| 11:00:42 | <rafa> applecool: just commit to the 1.1 branch |
| 11:00:46 | <rafa> applecool: I'll merge again |
| 11:02:10 | <applecool> but now i am branch master rafa |
| 11:02:33 | <applecool> i am on * |
| 11:02:35 | <applecool> sorry |
| 11:03:24 | <rafa> applecool: ok let me look what you did |
| 11:04:12 | <applecool> rafa: oh no! i guess the problem is now i need to pull the existing code and then make the changes and then commit i guess |
| 11:04:51 | <rafa> applecool: wait a sec I'm trying to understand what you've already done |
| 11:05:57 | <applecool> please ignore the starting lines till 17 . that was to 1.1 itself! the mess up is after line 17 i guess |
| 11:08:27 | <rafa> applecool: so you seem to have committed your changes to 1.1 and then doing a bunch of strange things |
| 11:08:49 | <applecool> yes |
| 11:09:16 | <applecool> :P mess |
| 11:09:26 | <rafa> applecool: a lot of mess |
| 11:09:39 | <applecool> yea true! :P |
| 11:09:39 | <rafa> applecool: I hope nothing went through to github |
| 11:09:58 | <applecool> no nothing |
| 11:11:25 | <applecool> i guess everything is fine on 1.1 branch |
| 11:11:32 | *** rram_ has quit IRC |
| 11:11:53 | <applecool> this commit was good https://github.com/rkorytkowski/openmrs-contrib-metadatarepository/commit/307bf6f1b3f1ed69029b0a0014678367dadc4de1 |
| 11:12:01 | <OpenMRSBot> <http://ln-s.net/$dm1> (at github.com) |
| 11:12:36 | <rafa> applecool: run git branch |
| 11:12:46 | <rafa> applecool: tell what you see |
| 11:12:59 | <applecool> * 1.1 |
| 11:12:59 | <applecool> master |
| 11:13:08 | <applecool> i am on 1.1 now |
| 11:13:14 | <rafa> yes |
| 11:13:33 | <rafa> applecool: run git reset --hard |
| 11:13:52 | <applecool> HEAD is now at 307bf6f Fixed Tests |
| 11:13:59 | <rafa> applecool: run git checkout master |
| 11:14:19 | <applecool> Switched to branch 'master' |
| 11:14:19 | <applecool> Your branch and 'origin/master' have diverged, |
| 11:14:19 | <applecool> and have 1 and 6 different commit(s) each, respectively. |
| 11:14:42 | <rafa> applecool: run git reset --hard |
| 11:14:56 | <dkayiwa> rafa: is 1.9.1 already tagged? |
| 11:15:03 | <rafa> dkayiwa: yes |
| 11:15:07 | <dkayiwa> rafa: in that case will make its fix version be 1.9.2 |
| 11:15:07 | <applecool> rafa: HEAD is now at f493ce8 All fixes |
| 11:15:31 | <rafa> dkayiwa: 1.9.1 is marked as released in jira |
| 11:15:37 | <dkayiwa> rafa: ok |
| 11:16:02 | <rafa> dkayiwa: so yes, you should set fix version only to not released versions :) |
| 11:16:11 | <dkayiwa> rafa: ok :) |
| 11:16:29 | <rafa> applecool: run git status |
| 11:16:49 | <applecool> # On branch master |
| 11:16:49 | <applecool> # Your branch and 'origin/master' have diverged, |
| 11:16:49 | <applecool> # and have 1 and 6 different commit(s) each, respectively. |
| 11:16:51 | <applecool> # |
| 11:16:53 | <applecool> nothing to commit (working directory clean) |
| 11:17:35 | <rafa> applecool: run git pull |
| 11:17:58 | <applecool> From https://github.com/rkorytkowski/openmrs-contrib-metadatarepository |
| 11:17:58 | <applecool> c28793f..307bf6f master -> origin/master |
| 11:17:58 | <OpenMRSBot> <http://ln-s.net/$FfD> (at github.com) |
| 11:17:58 | <applecool> Auto-merging web/src/main/java/org/openmrs/contrib/metadatarepository/webapp/controller/PackageFormController.java |
| 11:18:00 | <applecool> CONFLICT (content): Merge conflict in web/src/main/java/org/openmrs/contrib/metadatarepository/webapp/controller/PackageFormController.java |
| 11:18:01 | <applecool> Auto-merging web/src/main/webapp/WEB-INF/pages/packageform.jsp |
| 11:18:03 | <applecool> CONFLICT (content): Merge conflict in web/src/main/webapp/WEB-INF/pages/packageform.jsp |
| 11:18:05 | <applecool> Auto-merging web/src/test/java/org/openmrs/contrib/metadatarepository/webapp/controller/FileUploadControllerTest.java |
| 11:18:08 | <applecool> CONFLICT (content): Merge conflict in web/src/test/java/org/openmrs/contrib/metadatarepository/webapp/controller/FileUploadControllerTest.java |
| 11:18:10 | <applecool> Auto-merging web/src/test/java/org/openmrs/contrib/metadatarepository/webapp/controller/PackageFormControllerTest.java |
| 11:18:12 | <applecool> CONFLICT (content): Merge conflict in web/src/test/java/org/openmrs/contrib/metadatarepository/webapp/controller/PackageFormControllerTest.java |
| 11:18:13 | <applecool> Automatic merge failed; fix conflicts and then commit the result. |
| 11:21:42 | <suranga> applecool, pastebin is probably a better idea... :) |
| 11:21:53 | <applecool> suranga: yes |
| 11:23:28 | <dkayiwa> rafa: did you also get your YourKit licence key from Michael? |
| 11:23:45 | <rafa> dkayiwa: you mean now? |
| 11:24:01 | <dkayiwa> rafa: whenever :) |
| 11:24:17 | <rafa> dkayiwa: yes, I think I got it some time ago from Michael |
| 11:24:38 | <applecool> rafa: shall i compare the code with the HEAD REVISION? |
| 11:24:55 | <applecool> and solve the conflicts by undo ing them |
| 11:24:55 | <dkayiwa> rafa: is there a problem with reusing another person's key? i just copied one from existing ITSM tickets :) |
| 11:26:19 | <rafa> dkayiwa: lol :) Don't know if it's personal or not. Check with Michael and warn him if the licence key is public. |
| 11:26:31 | <dkayiwa> rafa: ok :) |
| 11:27:58 | <rafa> applecool: no you need to rebase |
| 11:28:08 | <applecool> oh |
| 11:28:12 | <rafa> applecool: you have some dirty commits in your repo |
| 11:28:18 | <applecool> hmm |
| 11:28:25 | <rafa> applecool: either you rebase or delete the repo and clone again |
| 11:28:27 | *** james_regen has joined #openmrs |
| 11:28:27 | *** ChanServ sets mode: +v james_regen |
| 11:28:58 | <rafa> applecool: I've merged your changes to master already |
| 11:29:43 | <applecool> okay |
| 11:29:57 | <applecool> so should i delete the repo from my system? |
| 11:31:26 | <applecool> rafa: congo on all the releases :) |
| 11:31:51 | <rafa> applecool: up to you :) |
| 11:32:01 | <rafa> applecool: if you want you can learn rebase |
| 11:32:11 | <rafa> applecool: or if not just delete and clone again |
| 11:33:04 | <applecool> rafa: i need to do git rebase master |
| 11:33:07 | <applecool> right? |
| 11:33:14 | <rafa> applecool: but be careful with rebasing and don't do more mess :) |
| 11:33:22 | <rafa> applecool: you need to read about rebase first :P |
| 11:33:29 | <applecool> okay |
| 11:33:36 | <applecool> i will |
| 11:33:54 | <applecool> then its better first i will just delete the entire repo and clone it back again |
| 11:37:00 | *** kishoreyekkanti_ has quit IRC |
| 11:47:08 | *** bwolfe has joined #openmrs |
| 11:47:08 | *** ChanServ sets mode: +o bwolfe |
| 11:48:02 | *** kishoreyekkanti has joined #openmrs |
| 11:52:03 | *** rram_ has joined #openmrs |
| 11:53:10 | <bwolfe> kishoreyekkanti, welcome back. how was the holiday? |
| 11:53:18 | <kishoreyekkanti> bwolfe: It was awesome |
| 11:53:32 | <kishoreyekkanti> bwolfe: how are you! |
| 11:54:16 | *** kishoreyekkanti has quit IRC |
| 11:54:35 | *** kishoreyekkanti has joined #openmrs |
| 11:55:51 | *** rram_ has quit IRC |
| 11:56:01 | *** rram_ has joined #openmrs |
| 11:56:37 | <applecool> rafa: Thanks :) |
| 11:56:46 | <applecool> rafa: everything is perfect and neat now |
| 11:57:05 | <bwolfe> kishoreyekkanti, doing fine. ready to migrate? or have you started without me? |
| 11:57:15 | <kishoreyekkanti> bwolfe: :) haven't started it |
| 11:57:20 | <kishoreyekkanti> bwolfe: we can pair and start on it |
| 11:59:47 | *** sunbiz has joined #openmrs |
| 11:59:47 | *** ChanServ sets mode: +v sunbiz |
| 12:00:23 | <bwolfe> kishoreyekkanti, ok, what would you have me do? |
| 12:01:17 | <kishoreyekkanti> bwolfe: can i take the latest update from svn now and check in to the repo openmrs-clone-withoutjars |
| 12:01:34 | <kishoreyekkanti> bwolfe: I mean basically you need to guide me :) |
| 12:01:42 | <bwolfe> kishoreyekkanti, yes. do you want me to make svn read-only? |
| 12:01:49 | <bwolfe> (not sure if I can still do that...) |
| 12:02:00 | <kishoreyekkanti> kishoreyekkanti: oh ok. we need not do that now |
| 12:02:07 | <kishoreyekkanti> bwolfe: oh ok. we need not do that now |
| 12:02:31 | <kishoreyekkanti> bwolfe: so, i'll just tell the process i'm panning to do, let me know if that works. |
| 12:03:01 | <kishoreyekkanti> bwolfe: I'll take the latest update from svn and check in the code to openmrs-clone without jars in github and then change the owner ship to openmrs-core |
| 12:03:22 | *** jkeiper_ has joined #openmrs |
| 12:03:35 | <kishoreyekkanti> bwolfe: Thats one way of doing it. Other way would be get the latest svn code base and check in directly to openmrs-core github repo |
| 12:04:21 | <bwolfe> kishoreyekkanti, isn't the first easier? just updated the "clone-withoutjars" and moving it? |
| 12:04:36 | <bwolfe> kishoreyekkanti, wouldn't getting a fresh copy take many hours again? |
| 12:06:06 | <kishoreyekkanti> kishoreyekkanti: First thing is easier, fresh copy would not take much time, as my local machine already have the entire history. I'll get the delta from svn and check in that 110 mb to github openmrs-core (should not take more than 15 mins) |
| 12:06:30 | <kishoreyekkanti> bwolfe: First thing is easier, Even, fresh copy would not take much time, as my local machine already have the entire history. I'll get the delta from svn and check in that 110 mb to github openmrs-core (should not take more than 15 mins) |
| 12:07:41 | <bwolfe> kishoreyekkanti, ok, I have given you owners rights on the OpenMRS repo. handle with care. :-) |
| 12:07:54 | <kishoreyekkanti> bwolfe: :) sure |
| 12:08:33 | <kishoreyekkanti> bwolfe: did any one tried building from the openmrs-clone-withoutjars and checked every thing working? |
| 12:12:46 | <bwolfe> kishoreyekkanti, I remember checking from the one with jars, not the one without. I can do that now. |
| 12:16:46 | *** jkeiper_ has quit IRC |
| 12:17:25 | <kishoreyekkanti> bwolfe: sure |
| 12:27:54 | <bwolfe> kishoreyekkanti, "-withoutjars" compiles and runs fine |
| 12:28:17 | <rafa> bwolfe: do we have a wiki explaining the idea of minor and maintenance versions? |
| 12:28:28 | <kishoreyekkanti> bwolfe: cool let me pull the changes from svn and checkin the code |
| 12:30:14 | <bwolfe> rafa, I made this page a long time ago: https://wiki.openmrs.org/display/archive/Versioning |
| 12:30:23 | <bwolfe> rafa, apparently it was never transitioned to the new wiki... ?? |
| 12:32:46 | *** downey has joined #openmrs |
| 12:32:46 | *** ChanServ sets mode: +o downey |
| 12:32:46 | *** OpenMRSBot sets mode: +o downey |
| 12:40:08 | <suranga> hi bwolfe :) |
| 12:40:09 | *** rfriedman has joined #openmrs |
| 12:40:13 | <suranga> bwolfe, ... so HL7QRY-26 is done and committed |
| 12:40:37 | <bwolfe> hi suranga |
| 12:40:43 | <bwolfe> saw, that, good work! |
| 12:42:34 | *** rram_ has quit IRC |
| 12:43:00 | <suranga> bwolfe, I was under enormous strain after you said that it was a five minute ticket :P |
| 12:43:16 | <bwolfe> suranga, and how long did it take you? :-) |
| 12:44:03 | <suranga> bwolfe, it took me < an hour, because I hard to re-do it... |
| 12:44:21 | <suranga> bwolfe, after I finished it all, I realized that you had suggested a name for the classes |
| 12:44:26 | <bwolfe> you redid instead of using uma's branch? why? |
| 12:44:34 | <suranga> bwolfe, so I had to rename everything |
| 12:44:35 | <bwolfe> suranga, class names don't matter, its the link names I care about |
| 12:45:02 | <suranga> ah, bwolfe I wrote it anew myself, i'd never used that before, and wanted to see how it worked ... :) |
| 12:45:30 | *** downey has quit IRC |
| 12:45:45 | *** downey has joined #openmrs |
| 12:45:45 | *** ChanServ sets mode: +o downey |
| 12:45:45 | *** OpenMRSBot sets mode: +o downey |
| 12:47:01 | *** kavuri has quit IRC |
| 12:47:11 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @ShellZero: I have been working with the World's awesome mentor : ) @OpenMRS @gsoc <http://twitter.com/OpenMRS/statuses/236073775974723584> |
| 12:49:49 | <kishoreyekkanti> bwolfe: Hey Ben, how did you update the github repo openmrs-clone-withoutjars recently |
| 12:49:56 | <kishoreyekkanti> bwolfe: seems like my repo got corrupted |
| 12:50:30 | <kishoreyekkanti> bwolfe: I mean seems like my local desktop svn2git repo got corrupted and i'm unable to fetch the latest changes from svn |
| 12:51:03 | <bwolfe> kishoreyekkanti, oh, hmm, yes, I was testing some things out. I updated via github and pushing. :-/ how did that corrupt it? |
| 12:51:16 | <bwolfe> because of merge conflicts? there shouldn't be any... |
| 12:51:26 | <kishoreyekkanti> bwolfe: nope its not because of your merge :) |
| 12:51:59 | <kishoreyekkanti> bwolfe: Any ways just understood from commit that, what ever you've changed is not the merge from svn to git. Its a direct update on github. |
| 12:53:11 | <kishoreyekkanti> bwolfe: my local svn2git repo(in my desktop) is not able to fetch any changes from svn. But that should not be a problem. there are couple of ways to overcome this. Let me try those. Ignore my previous question. |
| 12:54:07 | <bwolfe> kishoreyekkanti, correct, I've updated your github repo. I was under the impression that committing/pushing to it was ok and the svn2git would take care of it. is that not hte case? |
| 12:56:02 | <kishoreyekkanti> bwolfe: svn2git should automatically should take care of fetch from svn and push to git locally , by default. Currently there seem to be some revision problem with my local machine. I'm unable to fetch the latest code from svn using svn2git. |
| 12:56:32 | <kishoreyekkanti> bwolfe: when ever i say svn2git --rebase or git svn fetch it fails with "fatal: Invalid revision range f493218a0fe6c948e2ad19b139eb0dcc25384ce9..refs/remotes/cohort_builder" |
| 12:57:03 | <bwolfe> is cohort_builder a branch? |
| 12:58:03 | <bwolfe> kishoreyekkanti, looks like it WAS a branch...that was deleted 5 years ago. :-) https://source.openmrs.org/changelog/OpenMRS/branches/cohort_builder |
| 13:04:05 | <bwolfe> suranga, I commented on your settings page commit. The commit comment is missing the ticket link, but sure to include that |
| 13:04:45 | <suranga> bwolfe, cool, I'll take a look :) |
| 13:05:16 | *** sunbiz has quit IRC |
| 13:05:46 | *** kavuri has joined #openmrs |
| 13:27:06 | <bwolfe> kishoreyekkanti, are you still struggling with the svn2git? can mark commit something here quickly? |
| 13:27:32 | <kishoreyekkanti> bwolfe: yes sure |
| 13:27:49 | <kishoreyekkanti> bwolfe: I'm taking the path of patching the commits to the git. |
| 13:27:57 | <kishoreyekkanti> bwolfe: let me know once mark is done with the commits |
| 13:28:22 | *** mvorobey has joined #openmrs |
| 13:28:32 | <mvorobey> hi all |
| 13:28:46 | <mvorobey> hi bwolfe |
| 13:28:57 | <bwolfe> kishoreyekkanti, manually going through them and applying? :-( |
| 13:28:59 | <bwolfe> svn2git-- |
| 13:29:01 | <bwolfe> boo svn2git |
| 13:30:07 | <kishoreyekkanti> kishoreyekkanti: not really, just getting all the revisions/updates done after jul 25th(thats when i did the svn2git thing) as a single patch and apply the patch on svn2git repo |
| 13:30:36 | <mvorobey> bwolfe, could you please point me to example of using velocity templates within any of OpenMRS module ? |
| 13:32:11 | <bwolfe> mvorobey, formentry module uses them in the FormDownloadServlet |
| 13:32:19 | <bwolfe> (might have the wrong class) |
| 13:32:39 | <mvorobey> bwolfe, that's so cool! thanks! |
| 13:32:44 | <mvorobey> will look at it |
| 13:33:44 | * bwolfe enjoys sharing his fount of historical knowledge. |
| 13:38:07 | <mvorobey> :D |
| 13:38:32 | <mvorobey> bwolfe++ |
| 13:39:19 | *** applecool has quit IRC |
| 13:44:19 | *** jriley has joined #openmrs |
| 13:49:28 | *** applecool has joined #openmrs |
| 13:49:28 | *** ChanServ sets mode: +v applecool |
| 13:59:50 | *** shortend has joined #openmrs |
| 14:01:37 | <shortend> Hey, I'm having trouble getting the XForms registration form to create an encounter. |
| 14:02:12 | <shortend> I think the trouble lies in the fact that it expects me to pass a patient id. |
| 14:02:56 | <bwolfe> kishoreyekkanti, commits done |
| 14:03:33 | <kishoreyekkanti> bwolfe: cool, will take me some more time to do commits to github. |
| 14:04:07 | <shortend> I'm getting the exception ca.uhn.hl7v2.HL7Exception: Could not resolve patient |
| 14:04:09 | <dkayiwa> shortend: did you delete the patientid node from the form designer? |
| 14:05:46 | <bwolfe> kishoreyekkanti, :-/ |
| 14:06:06 | <bwolfe> foolish svn2git |
| 14:06:36 | <shortend> dkayiwa: It's there on the left. I don't have it on the "Design Surface" |
| 14:07:27 | <dkayiwa> shortend: are you entering patients from the patient dashboard? |
| 14:08:09 | *** jriley has left #openmrs |
| 14:08:40 | <shortend> dkayiwa: Starting from the Find/Create Patient screen. |
| 14:09:16 | <dkayiwa> shortend: can you pastebin the contents of your xforms xml tab while in the form designer with the form? |
| 14:09:16 | <djazayeri> downey: note comments from various people (Bill, Mark G, Andrea) saying that adobe connect audio isn't working for them anymore |
| 14:09:32 | <djazayeri> downey: probably worth investigating after the call |
| 14:11:06 | <shortend> dkayiwa: http://pastebin.com/6SUVPKqE |
| 14:12:00 | <shortend> dkayiwa: By the way, I found a forum post that recommended placing the patient ID inside the encounter form... |
| 14:12:15 | <dkayiwa> shortend: your encounter form does not have the patientid node |
| 14:12:29 | <dkayiwa> shortend: did you delete it? for it is there by default |
| 14:13:32 | *** bwolfe has quit IRC |
| 14:14:07 | <shortend> dkayiwa: I get another exception when I add it... |
| 14:14:12 | <shortend> Just a minute... |
| 14:15:32 | *** bwolfe has joined #openmrs |
| 14:15:32 | *** ChanServ sets mode: +o bwolfe |
| 14:17:19 | <shortend> dkayiwa: When I have the patient ID in the encounter form, I get this exception: ca.uhn.hl7v2.HL7Exception: Invalid concept ID 'null' in hl7 message with uid: q1XZJ93uykMBQNAy3h3T |
| 14:17:53 | *** suranga has quit IRC |
| 14:18:45 | <downey> djazayeri: my understanding was they hadn't yet downloaded the plugin. |
| 14:18:49 | <dkayiwa> shortend: go to the form schema page |
| 14:19:02 | *** kavuri has quit IRC |
| 14:19:18 | <shortend> dkayiwa: OK |
| 14:19:24 | <dkayiwa> shortend: then edit the OBS section and make sure it is attached to the MEDICAL RECORDS OBSERVATION concept |
| 14:19:34 | <djazayeri> downey: I'm assuming it's not simultaneous user error of 3 different people who are saying they're told it's a bad download link. |
| 14:19:49 | <dkayiwa> shortend: after that, you will open the form in the form designer, refresh, and then save the form |
| 14:19:54 | <dkayiwa> shortend: that should be all |
| 14:19:56 | <djazayeri> downey: in addition rafal says it doesn't work on chrome but works on firefox |
| 14:20:24 | <rafa> downey: in Chrome it opens in a tab now whereas it used to open in a separate window |
| 14:20:41 | <downey> rafa: if it opens in your browser, you don't have the plugin. :) |
| 14:20:44 | <rafa> downey: it still opens in a separate window in Firefox and the audio works there fine |
| 14:21:00 | <downey> rafa: interesting, there might have been a chrome update that broke it |
| 14:21:05 | <downey> rafa: what version? |
| 14:21:22 | <rafa> downey:21.0.1180.79 m |
| 14:21:37 | <downey> rafa: hm, same as what i'm using here |
| 14:21:47 | <rafa> downey: I'm on windows |
| 14:21:52 | <rafa> downey: mark is on windows too |
| 14:22:02 | <rafa> downey: so it may be the windows thing :) |
| 14:22:12 | <downey> rafa: http://helpx.adobe.com/adobe-connect/kb/google-chrome-21-browser-incompatibility.html |
| 14:22:16 | <OpenMRSBot> <http://ln-s.net/$dqK> (at helpx.adobe.com) |
| 14:22:39 | <rafa> downey: okay :D |
| 14:25:14 | <shortend> dkayiwa: Thanks, that takes care of the exceptions. I guess I'm deleting things that I need. |
| 14:25:21 | <shortend> dkayiwa: Really appreciate your help. |
| 14:25:35 | <dkayiwa> shortend: thanks for asking :) |
| 14:26:02 | <dkayiwa> shortend: extra bonus putting that stuff on the wiki :D |
| 14:27:20 | <shortend> dkayiwa: I wouldn't mind earning some bonus points. Is there a specific place where that belongs, or should I just poke around and pick a place to put it? |
| 14:27:53 | <dkayiwa> shortend: just put wherever you would find it easier if you were looking for it |
| 14:28:10 | <shortend> dkayiwa: Haha, OK |
| 14:38:59 | *** shortend has left #openmrs |
| 14:59:38 | <kishoreyekkanti> bwolfe: hey ben can you try out pulling the latest code and check if every thing is working fine |
| 15:00:42 | <bwolfe> kishoreyekkanti, are you done with merging already? :-) |
| 15:00:51 | <kishoreyekkanti> bwolfe: Yep :) |
| 15:00:56 | <bwolfe> kishoreyekkanti++ |
| 15:03:09 | *** goutham has joined #openmrs |
| 15:03:49 | *** goutham has quit IRC |
| 15:05:28 | <bwolfe> kishoreyekkanti, lots of merge conflicts |
| 15:05:31 | <kishoreyekkanti> bwolfe: I guess it got messed up. Just found some conflicts while pulling out |
| 15:05:40 | <bwolfe> I haven't edited those files. why are they not merging cleanly? |
| 15:06:09 | <kishoreyekkanti> bwolfe: thats the svn file format problem. |
| 15:06:22 | <kishoreyekkanti> Lemme remove the merge conflicts |
| 15:14:05 | <bwolfe> kishoreyekkanti, git stores the merge conflicts? seems strange... |
| 15:15:00 | <kishoreyekkanti> bwolfe: should not! but i guess this is the svn file format issue |
| 15:16:08 | *** james_regen has quit IRC |
| 15:19:07 | *** mvorobey has quit IRC |
| 15:19:26 | <djazayeri> rafa: I'll try my best to do new mockups for META-247 today. If I don't get to it today, you should stop counting on me. :-) |
| 15:19:40 | <djazayeri> and do it yourself |
| 15:33:09 | <rafa> djazayeri: cool, thx |
| 15:43:34 | *** jkeiper has joined #openmrs |
| 15:43:56 | *** ChanServ sets mode: +v jkeiper |
| 15:54:59 | *** harshadura_ has quit IRC |
| 15:56:28 | <kishoreyekkanti> bwolfe: Hey ben i've committed the code to openmrs-core, https://github.com/OpenMRS/openmrs-core can you have a look at it once. I'll upload the branches and tags in other 5 mins. I've tested this locally and every thing seems to work fine. Can you please checkout the new copy and let me know how it looks. |
| 15:57:40 | *** harshadura has joined #openmrs |
| 15:59:10 | *** rafa has quit IRC |
| 16:04:16 | <dkayiwa> bwolfe: am i forbidden form committing to svn for core? |
| 16:07:17 | *** maurya has joined #openmrs |
| 16:09:07 | *** p_m has quit IRC |
| 16:09:41 | *** suranga has joined #openmrs |
| 16:09:41 | *** ChanServ sets mode: +v suranga |
| 16:09:48 | <kishoreyekkanti> dkayiwa: I guess not, but i'll wait for bwolfe to comment on it |
| 16:10:24 | <kishoreyekkanti> dkayiwa: though some commit goes to svn now we can get that commit and push it to github. But not sure when bwolfe want to completely lock down svn |
| 16:11:37 | <dkayiwa> kishoreyekkanti: am getting: svn: CHECKOUT of '/!svn/ver/27770/openmrs/trunk/api/src/main/java/org/openmrs/api/UserService.java': 403 Forbidden (http://svn.openmrs.org) |
| 16:12:05 | <kishoreyekkanti> dkayiwa: does that mean svn is locked down? (403) |
| 16:12:20 | <kishoreyekkanti> dkayiwa: or possibly no one have access to svn now? |
| 16:12:31 | <djazayeri> hmm, I'd have thought we were going to make it read-only first... |
| 16:12:48 | <dkayiwa> djazayeri: kishoreyekkanti was committing |
| 16:13:21 | <djazayeri> oh |
| 16:13:34 | <djazayeri> dkayiwa: then probably bwolfe (or downey) locked svn down |
| 16:13:43 | <dkayiwa> djazayeri: ok |
| 16:14:22 | <kishoreyekkanti> dkayiwa: djazayeri currently the code is uploaded/committed to openmrs-core in github . Not sure if we wanted to use that now. I'm waiting for bwolfe to give a go ahed |
| 16:15:12 | <dkayiwa> kishoreyekkanti: so do you suggest i clone the git repo and manually put in my changes? |
| 16:15:31 | <djazayeri> dkayiwa: I think you should wait for bwolfe to give the official notice |
| 16:15:36 | <kishoreyekkanti> dkayiwa: ahh i wanted bwolfe to check it once before we go ahead on this |
| 16:15:39 | <dkayiwa> djazayeri: ok |
| 16:17:38 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Export CCD Module 1.0-SNAPSHOT uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=exportccd&version=&1.0-SNAPSHOT> |
| 16:22:18 | *** p_m has joined #openmrs |
| 16:25:02 | *** goutham has joined #openmrs |
| 16:27:55 | *** lh has quit IRC |
| 16:28:35 | *** lh has joined #openmrs |
| 16:33:48 | <goutham> dkayiwa: Hi |
| 16:33:54 | <dkayiwa> goutham: hi |
| 16:34:15 | <goutham> dkayiwa: Did you see james mail ? |
| 16:34:23 | <dkayiwa> goutham: yes |
| 16:34:58 | *** rafa has joined #openmrs |
| 16:35:00 | *** ChanServ sets mode: +v rafa |
| 16:35:00 | <goutham> dkayiwa: i would reply him saying that will be implemented in next stable release |
| 16:35:13 | <dkayiwa> goutham: ok |
| 16:35:27 | *** kishoreyekkanti has quit IRC |
| 16:36:22 | <goutham> dkayiwa: did you find the solution for the error ? |
| 16:36:38 | <goutham> dkayiwa: any hints? clues ? :) |
| 16:37:18 | <dkayiwa> goutham: i slept off my computer :) |
| 16:37:34 | <goutham> dkayiwa: :D |
| 16:37:50 | <dkayiwa> but now that 1.7.4 was released, can you try change to that version and test again? |
| 16:38:45 | <goutham> dkayiwa: Hope is solves it :| |
| 16:39:03 | <dkayiwa> goutham: just get back to me if it does not :) |
| 16:40:08 | <goutham> dkayiwa: iam deploying the module in openmrs 1.7.2 version |
| 16:41:09 | <dkayiwa> goutham: try change to 1.7.4 in the pom. but you can deploy on any higher version like 1.8 or 9 |
| 16:42:10 | <goutham> dkayiwa: Ok |
| 16:42:57 | <dkayiwa> goutham: but Jame's issue sounds like higher priority than trying to make the module work on 1.7 |
| 16:43:17 | <dkayiwa> goutham: if time does not allow, we can forget making it run on 1.7 |
| 16:43:31 | <dkayiwa> goutham: as long as it satisfactorily works on 1.8 and 1.9 |
| 16:43:38 | <dkayiwa> goutham: how do you see that? :) |
| 16:45:10 | <goutham> dkayiwa: ok :) |
| 16:46:06 | <dkayiwa> goutham: so lets start on James's issue right away :) |
| 16:46:20 | *** p_m has quit IRC |
| 16:46:47 | <goutham> dkayiwa: so my idea of doing it is , similar to wat we do in assigning roles to a user. "Multiple check boxes" |
| 16:47:41 | <dkayiwa> goutham: do you have a mock for that? |
| 16:49:04 | <goutham> dkayiwa: i would like to show mock on demo.openmrs.org |
| 16:49:15 | <dkayiwa> goutham: ok |
| 16:49:41 | <goutham> dkayiwa: http://demo.openmrs.org/openmrs/admin/users/users.list |
| 16:50:19 | <goutham> dkayiwa: select any user |
| 16:50:33 | <dkayiwa> goutham: ok |
| 16:51:19 | <goutham> dkayiwa: now there is Roles: field where we can check multiple roles |
| 16:51:32 | <dkayiwa> goutham: ok |
| 16:52:17 | <goutham> dkayiwa: similarly on choosing role filter type, we will show all role with respective check boxes |
| 16:52:52 | <dkayiwa> goutham: ok |
| 16:54:24 | <goutham> dkayiwa: is it fine or you have any other idea |
| 16:54:48 | <dkayiwa> goutham: it is fine :) |
| 16:55:38 | <goutham> dkayiwa: so do i need to do same thing for privileges ? |
| 16:56:41 | <dkayiwa> goutham: do we have a privilegeFilter? |
| 16:57:22 | <goutham> dkayiwa: : | |
| 16:57:33 | <goutham> dkayiwa: yes |
| 16:57:41 | <dkayiwa> goutham: ok so yes :) |
| 16:59:44 | <goutham> dkayiwa: Cool ! On it |
| 16:59:58 | <dkayiwa> goutham: ok thanks :D |
| 17:03:18 | *** djazayeri1 has joined #openmrs |
| 17:05:37 | *** djazayeri has quit IRC |
| 17:07:13 | *** lh is now known as lh_afk |
| 17:08:32 | *** applecool has quit IRC |
| 17:09:10 | *** goutham has quit IRC |
| 17:10:03 | *** kishoreyekkanti has joined #openmrs |
| 17:20:53 | *** goutham has joined #openmrs |
| 17:21:53 | <goutham> dkayiwa: i have a question. |
| 17:22:00 | <dkayiwa> goutham: ok |
| 17:23:01 | <goutham> dkayiwa: what if a user creates two separate role filters checking two different role check boxes. |
| 17:23:35 | <goutham> dkayiwa: they still need to be considered as OR'ing |
| 17:24:24 | <dkayiwa> goutham: can we give them an option to choose AND / OR |
| 17:24:26 | <dkayiwa> ? |
| 17:24:44 | *** Maurya_ has joined #openmrs |
| 17:27:16 | *** maurya has quit IRC |
| 17:28:43 | <goutham> dkayiwa: where should i have this option ? |
| 17:29:23 | *** applecool has joined #openmrs |
| 17:29:23 | *** ChanServ sets mode: +v applecool |
| 17:30:22 | <djazayeri1> dkayiwa, goutham: to me it seems like an unimportant use case to be able to filter based on roles using AND. |
| 17:30:49 | <dkayiwa> djazayeri1: ok |
| 17:32:05 | <dkayiwa> djazayeri1: so do you suggest we deal with only OR ? |
| 17:32:20 | <djazayeri1> dkayiwa: that would be my suggestion |
| 17:32:26 | <djazayeri1> don't waste the time trying to deal with both |
| 17:32:57 | <djazayeri1> add AND in only if someone asks for it as a feature in the future. |
| 17:32:57 | <kishoreyekkanti> bwolfe: You there now |
| 17:33:10 | *** downey has quit IRC |
| 17:33:31 | *** downey has joined #openmrs |
| 17:33:31 | *** ChanServ sets mode: +o downey |
| 17:33:31 | *** OpenMRSBot sets mode: +o downey |
| 17:33:38 | <dkayiwa> goutham: so lets use OR for roles and djazayeri1 suggests |
| 17:33:38 | <goutham> djazayeri1: ok |
| 17:34:16 | <goutham> dkayiwa: Ok |
| 17:34:45 | <bwolfe> kishoreyekkanti, I'm back now |
| 17:34:57 | <kishoreyekkanti> bwolfe: I've pushed the code to openmrs-core |
| 17:35:21 | <kishoreyekkanti> bwolfe: later recognized that the updates between 25th jul to 14th aug are updated under my name. |
| 17:35:32 | <bwolfe> kishoreyekkanti, ok, so how do you fix the authors now then? |
| 17:36:05 | <dkayiwa> bwolfe: i have my changes, do you allow me commit them to svn? :) |
| 17:36:07 | <kishoreyekkanti> bwolfe: Not sure about this yet. Thought of deleting those commits and recommit with original author names |
| 17:36:57 | <bwolfe> is there a way to edit commits? we could change authors with svn that way |
| 17:37:04 | <bwolfe> (same way you change a commit message) |
| 17:37:41 | <kishoreyekkanti> bwolfe There should be some thing. Don't have any thing on top of my head. |
| 17:37:50 | <kishoreyekkanti> bwolfe: thought of continuing on this tomorrow. |
| 17:38:23 | <bwolfe> kishoreyekkanti, its only 11pm there, right? so you'll pick it up in an hour? :-D |
| 17:38:51 | <kishoreyekkanti> bwolfe: :) ha haa |
| 17:39:46 | <bwolfe> kishoreyekkanti, can I commit to the openmrs-core? |
| 17:40:11 | <kishoreyekkanti> bwolfe: sure but, do you want to allow the access to all others now? |
| 17:40:36 | <kishoreyekkanti> bwolfe: I thought we will fix this before we open this up. |
| 17:41:56 | <bwolfe> kishoreyekkanti, I will not announce it until you or I clean it up |
| 17:42:19 | <kishoreyekkanti> bwolfe: Sure, i want to take it up tomorrow morning. |
| 17:43:01 | <bwolfe> kishoreyekkanti, np. I will update you over email with anything that I do |
| 17:43:19 | <kishoreyekkanti> bwolfe: sure thank you! I'll take it up from where ever you leave |
| 17:47:00 | <bwolfe> kishoreyekkanti, looks like branches didn't make it over |
| 17:47:12 | <bwolfe> kishoreyekkanti, did you do a "transfer ownership" or did you just recommit to the new upstream? |
| 17:47:45 | <kishoreyekkanti> bwolfe: I haven't pushed them yet. i have recommitted the new upstream. I have just tried this way. But seems that its good amount of work. |
| 17:47:53 | <OpenMRSBot> Recent updates in the world of openmrs: Shazin Sadakath: Amazon.com Interview!!!! Yeah you heard it, Amazon.com! <http://shazsterblog.blogspot.com/2012/08/amazoncom-interview-yeah-you-heard-it.html> || OpenMRS Modules: Export CCD Module 1.0 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=exportccd&version=&1.0> |
| 17:48:29 | <bwolfe> kishoreyekkanti, the "transfer ownership" has worked well in the past. you just go into admin in github and choose OpenMRS as the new owner! thats what I thought you were going to do... |
| 17:48:57 | <kishoreyekkanti> bwolfe: I thought of doing it. But i've messed up my openmrs-withoutjars repo |
| 17:49:45 | <kishoreyekkanti> bwolfe: i had to delete some commits which are unnecessary, so i've did this in other way. |
| 17:50:04 | <bwolfe> kishoreyekkanti, ah ok, so it was a bit of a cleanup, gotcha |
| 17:50:45 | <kishoreyekkanti> bwolfe: I had couple of ways to do this tomorrow. If you can hold up on the commits for openmrs-core, i can cleanup my without jars repo and then just change the ownership |
| 17:51:11 | <bwolfe> kishoreyekkanti, which do you prefer? |
| 17:51:32 | <bwolfe> kishoreyekkanti, I can remove rights to openmrs-core or we just remove the repo again now if you want |
| 17:51:38 | <kishoreyekkanti> bwolfe: I prefer changing ownership. But, not sure about how much work it is to clean up the messed commit |
| 17:51:56 | <kishoreyekkanti> bwolfe: we can remove the repo for now |
| 17:52:10 | <kishoreyekkanti> bwolfe: i was about to say that :) |
| 17:52:31 | <bwolfe> kishoreyekkanti, ok, so if I see any issues I can commit to the without-jars one? |
| 17:52:47 | <bwolfe> kishoreyekkanti, is it possible to rename the without-jars one during the move? or does that happen now? |
| 17:52:57 | <kishoreyekkanti> bwolfe: If you can give me couple of hours in the morning. I'll clean this mess and change the ownership to openmrs-core |
| 17:53:00 | <kishoreyekkanti> yep |
| 17:53:05 | <kishoreyekkanti> bwolfe: yep we can rename |
| 17:53:30 | <kishoreyekkanti> bwolfe: we can rename the repo name now or during the transfer. |
| 17:54:09 | <bwolfe> ok, here's the plan: 1) delete openmrs-core in OpenMRS project. 2) you go to bed 3) me try some things to fix those commits in your repo 3) I email you to report on what I did or didn't finish |
| 17:55:15 | <kishoreyekkanti> bwolfe: Awesome sounds fine. |
| 17:55:21 | <bwolfe> we can rename during the move. sounds like best option so we don't have to reset now |
| 17:56:02 | <kishoreyekkanti> bwolfe: yep. |
| 17:56:19 | <kishoreyekkanti> bwolfe: cool. have a good day. I'll look at it tomorrow. |
| 17:56:24 | <applecool> rafa: |
| 17:56:28 | <applecool> there? |
| 17:56:29 | <bwolfe> kishoreyekkanti, gnight |
| 17:56:50 | <rafa> applecool: yes |
| 17:57:22 | <applecool> i am unable to point out where the fields are made required! |
| 17:57:30 | <applecool> its in the javascript |
| 17:57:43 | <applecool> but i could only find it in the developer console of the chrome |
| 17:57:49 | <applecool> but not in the code! |
| 17:57:59 | <applecool> can you please help rafa |
| 17:58:27 | <rafa> applecool: ok, let me look |
| 17:58:35 | <applecool> okay |
| 17:59:03 | <rafa> applecool: see validation.xml |
| 17:59:11 | <applecool> .xml! |
| 17:59:12 | <applecool> oh |
| 18:02:38 | <kishoreyekkanti> bwolfe: Hey ben, one last update before i leave. I've just checked out the without jars code base and haven't found any problems(merge conflicts) with the codebase. |
| 18:02:56 | <bwolfe> ok, good |
| 18:03:08 | <applecool> rafa: Thanks :) i will try :) |
| 18:03:40 | <kishoreyekkanti> bwolfe: so, i guess only thing we should have to do is to get all the updates from jul25th to today/tomorrow and update the codebase and then change the ownership. |
| 18:04:08 | <bwolfe> FYI: kishoreyekkanti, a lot of the commits in openmrs-core were attributed correctly |
| 18:04:30 | <kishoreyekkanti> bwolfe: even the commits between jul25th to aug 15th? |
| 18:05:04 | <bwolfe> looks like before july 19th |
| 18:05:33 | <bwolfe> back to june 22nd or so |
| 18:06:06 | <kishoreyekkanti> bwolfe: those were committed correctly. Only commits between jul25th to aug 15th are not attributed correctly. |
| 18:06:40 | <kishoreyekkanti> bwolfe: nevertheless we can work on the without jars repo now. |
| 18:06:50 | <kishoreyekkanti> bwolfe: Ok. now i'm really leaving ! catch you tomorrow |
| 18:06:58 | <bwolfe> ok, cya |
| 18:08:56 | <dkayiwa> bwolfe: now that kishoreyekkanti is gone, can i commit my changes to svn? :) |
| 18:09:30 | <bwolfe> dkayiwa, no, svn is locked |
| 18:09:47 | <dkayiwa> bwolfe: ok |
| 18:09:51 | <bwolfe> dkayiwa, you will have to wait 8 hours to commit (when kishoreyekkanti wakes up) |
| 18:10:02 | <dkayiwa> bwolfe: ok |
| 18:10:41 | <dkayiwa> he must be very healthy. 8 hours of sleep is very very good!!! :) |
| 18:12:39 | *** dkayiwa_ has joined #openmrs |
| 18:13:56 | <bwolfe> dkayiwa_, I'm putting in a few hours for him to get ready and get to work. :-P |
| 18:14:31 | <dkayiwa_> bwolfe: oh so he sleeps less? thats not good for his health. Doctors tell us 8hrs :) |
| 18:15:31 | <bwolfe> haha |
| 18:16:10 | *** dkayiwa has quit IRC |
| 18:16:10 | *** dkayiwa_ is now known as dkayiwa |
| 18:17:37 | *** jblaya has joined #openmrs |
| 18:18:23 | <jblaya> hi guys, quick question, has anyone run openmrs on RedHat 64 bits? |
| 18:18:36 | <applecool> rafa: it worked perfectly fine! Thanks i searched all the other files like validator.jsp,validator.tld,signup.jsp and all! didnt realize that its in validation.xml |
| 18:18:37 | <applecool> :) |
| 18:18:38 | <jblaya> I'm guessing there shouldn't be a problem, but just wanted to check before I headed down that path |
| 18:20:01 | <rafa> applecool: sometimes it's faster to ask :) |
| 18:20:55 | <applecool> rafa: its easy right! i thought it wont be good to ask for small stuff! So i tried first but hit the road block! So asked you at the end! :) |
| 18:22:35 | <rafa> applecool: great that's the way :) |
| 18:23:02 | <rafa> applecool: be sure to record a new video and prepare a wiki by tomorrow |
| 18:23:22 | <applecool> i will record the video again today itself |
| 18:23:35 | <applecool> and what all do i need to put in wiki |
| 18:23:43 | <applecool> and where? |
| 18:24:18 | <applecool> should i add a link to the Metadata Sharing Server Project wiki page itself? |
| 18:25:24 | <rafa> applecool: https://wiki.openmrs.org/display/RES/Metadata+Repository |
| 18:26:27 | <rafa> applecool: link your video there, add a few more words what it is |
| 18:27:00 | <applecool> hmm okay :) |
| 18:28:44 | <rafa> applecool: link github repository where to find code |
| 18:29:00 | <applecool> yes sure :) |
| 18:29:48 | <rfriedman> djazayeri1, lurking with the plebes? |
| 18:29:56 | *** djazayeri1 is now known as djazayeri |
| 18:29:57 | <djazayeri> who? |
| 18:30:01 | *** ChanServ sets mode: +o djazayeri |
| 18:30:10 | <rafa> rfriedman: haha |
| 18:30:10 | <rfriedman> ok now you're back in the elite |
| 18:30:23 | <rfriedman> got a couple of minutes? |
| 18:30:39 | <rfriedman> djazayeri, ?^ |
| 18:36:30 | <djazayeri> rfriedman: on a call, at the hour. |
| 18:36:45 | <rfriedman> djazayeri, ok tks |
| 18:50:47 | *** mvorobey has joined #openmrs |
| 18:50:50 | *** goutham has quit IRC |
| 18:55:43 | *** cpower has joined #openmrs |
| 18:58:12 | <cpower> Hello! |
| 18:59:13 | <cpower> Anyone home? |
| 18:59:25 | *** lh_afk is now known as lh |
| 18:59:57 | <cpower> All busy coding with a fury unknown to man today? |
| 19:00:20 | <rfriedman> no, i'm just cracking jokes |
| 19:00:31 | <cpower> :-) |
| 19:01:03 | *** goutham has joined #openmrs |
| 19:01:26 | <cpower> well speaking of jokes, let's scrum with hopes of someone working on tickets in this sprint. |
| 19:01:42 | <cpower> !scrumon cpower |
| 19:01:42 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 19:02:36 | <cpower> Order: mvorobey, kishoreyekkanti, dkayiwa, suranga, rafa, jkeiper, djazayeri, and bwolfe |
| 19:03:40 | <cpower> mvorobey...you are up! |
| 19:03:46 | <mvorobey> ok |
| 19:03:49 | <mvorobey> sorry |
| 19:04:02 | <mvorobey> * Finished CSTM-26, CSTM-27 |
| 19:04:16 | <mvorobey> * Committed code for CSTM-22, CSTM-25 |
| 19:04:32 | <mvorobey> * Reviewed TRUNK-3646 |
| 19:04:35 | <mvorobey> No blockers |
| 19:04:58 | <cpower> Kishore you have anything to share? |
| 19:05:16 | <bwolfe> cpower, kishoreyekkanti is asleep by now. he got the svn commits into his github in prep for moving it to the OpenMRS github |
| 19:05:30 | <cpower> with that note...NEXT! |
| 19:05:40 | <bwolfe> dkayiwa |
| 19:05:43 | <dkayiwa> Waiting for Kishore to Commit: Context.getUserService().notifyPrivilegeListeners should not lead to database flushes - TRUNK-3691 |
| 19:05:44 | <dkayiwa> Waiting for Kishore to Commit: @StartModule does not work - TRUNK-3508 |
| 19:05:44 | <dkayiwa> Continuing to work on: Potential Memory Leak reported by Tomcat 7 - TRUNK-3056 |
| 19:05:44 | <dkayiwa> Dev Call |
| 19:05:44 | <dkayiwa> No Blockers |
| 19:05:57 | <cpower> Suranga.. |
| 19:06:07 | <suranga> hi guys |
| 19:06:09 | <suranga> hi |
| 19:06:09 | <suranga> fixed and commited HL7QRY-26 |
| 19:06:09 | <suranga> TO DO -> Update code based on Ben;s comments |
| 19:06:09 | <suranga> Next : |
| 19:06:09 | <suranga> talk to Judy about HL7QRY -37, andf try to get it resolved |
| 19:06:21 | <bwolfe> dkayiwa, attach those as patches on the ticket. and tomorrow you can commit |
| 19:06:22 | <suranga> Also : talk to Ben about releasing hl7QRY module |
| 19:06:28 | <dkayiwa> bwolfe: ok |
| 19:06:35 | <suranga> NO blockers gentlemen |
| 19:07:01 | <rfriedman> that was no gentleman, that was a gospodar |
| 19:07:01 | <cpower> Rafa...hi |
| 19:07:08 | <rafa> dkayiwa: can you test the privilege helper module still works after TRUNK-3691? (it should, but it's better to test) |
| 19:07:10 | <rafa> cpower: hi |
| 19:07:13 | <rafa> Yesterday: |
| 19:07:13 | <rafa> * Helped Daniel with the standalone issue |
| 19:07:13 | <rafa> * Reviewed GsoC work |
| 19:07:13 | <rafa> * Created JIRA dashboard for the coming sprint |
| 19:07:13 | <rafa> Today: |
| 19:07:13 | <rafa> * Built and uploaded the standalone for 1.8.4 |
| 19:07:13 | <rafa> * Added more tickets to the coming sprint |
| 19:07:14 | <mvorobey> rfriedman, :D |
| 19:07:14 | <rafa> * Dev call |
| 19:07:14 | <rafa> * Returned to current sprint tickets: META-239: Convert concepts between their 1.8 and 1.9 representations |
| 19:07:15 | <rafa> https://tickets.openmrs.org/browse/META-239 |
| 19:07:15 | <rafa> No blockers. |
| 19:07:20 | <dkayiwa> rafa: ok |
| 19:07:35 | <dkayiwa> !ticket TRUNK-3691 |
| 19:07:37 | <OpenMRSBot> dkayiwa: [#TRUNK-3691] Context.getUserService().notifyPrivilegeListeners should not lead to database flushes - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3691 |
| 19:07:43 | <cpower> jkeiper |
| 19:07:58 | <dkayiwa> rafa: will test before comitting |
| 19:08:06 | <rafa> dkayiwa: thx |
| 19:08:14 | <jkeiper> before: AMPATH PM, after: AMPATH PM, blocker: AMPATH PM |
| 19:08:18 | *** dkayiwa has quit IRC |
| 19:08:38 | <cpower> hehehe |
| 19:08:43 | <djazayeri> All week |
| 19:08:43 | <djazayeri> * OpenMRS Calls |
| 19:08:43 | <djazayeri> * Mirebalais work |
| 19:08:43 | <djazayeri> * I-TECH work |
| 19:08:43 | <djazayeri> Yesterday |
| 19:08:44 | <jkeiper> ;-) |
| 19:08:44 | <djazayeri> * Released Metadata Sharing 1.0.9 |
| 19:08:45 | <djazayeri> Today |
| 19:08:46 | <djazayeri> * Mockups for META-247 |
| 19:08:46 | <djazayeri> * still Working on UIFR-11 - You should be able to indicate exactly which provider you want a fragment or page to come from |
| 19:08:47 | <djazayeri> No blockers |
| 19:09:37 | <djazayeri> bwolfe? |
| 19:09:41 | <cpower> now it's time for the wolfe.. |
| 19:09:55 | <cpower> b "the" wolfe |
| 19:10:27 | *** jblaya has quit IRC |
| 19:10:58 | <jkeiper> bwolfe is yapping |
| 19:11:06 | <jkeiper> in a conference room |
| 19:11:11 | <jkeiper> within eyeshot |
| 19:11:26 | <cpower> slap him |
| 19:11:33 | * jkeiper stares accusingly |
| 19:11:37 | <djazayeri> or just ask him nicely... |
| 19:11:41 | <bwolfe> sorry, got caught trying to leave my previous call |
| 19:11:46 | <cpower> no, that never works |
| 19:11:57 | <bwolfe> Wednesday |
| 19:11:57 | <bwolfe> emails |
| 19:11:57 | <bwolfe> triaged a few TRUNK tickets |
| 19:11:57 | <bwolfe> admin stuff for github |
| 19:11:57 | <bwolfe> univ call |
| 19:11:58 | <bwolfe> design call |
| 19:11:59 | <bwolfe> pm call |
| 19:12:01 | <bwolfe> github migration wiki page edits |
| 19:12:03 | <bwolfe> git blogging and emailing |
| 19:12:07 | <bwolfe> Thursday |
| 19:12:09 | <bwolfe> git migration setup with kishore |
| 19:12:11 | <bwolfe> emails |
| 19:12:13 | <bwolfe> dev call |
| 19:12:15 | <bwolfe> ldrship call |
| 19:12:17 | <bwolfe> no blockers |
| 19:12:30 | *** kishoreyekkanti has quit IRC |
| 19:12:33 | <cpower> Ok |
| 19:13:12 | <bwolfe> cpower, I don't have any indicators on "wolfe"...gotta be "ben", or "bwolfe". :-) |
| 19:13:21 | <cpower> Discussion: Nothing |
| 19:14:05 | <cpower> Blockers: Ampathed by jkeiper |
| 19:14:13 | <jkeiper> jej |
| 19:14:15 | <cpower> !scrumoff |
| 19:14:15 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:14:27 | <rfriedman> djazayeri, a good time? |
| 19:14:42 | <bwolfe> !ticket TRUNK-3691 |
| 19:14:44 | <OpenMRSBot> bwolfe: [#TRUNK-3691] Context.getUserService().notifyPrivilegeListeners should not lead to database flushes - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3691 |
| 19:15:04 | <jkeiper> djazayeri, did you include the latest (newest) xstream.serialization in the recent release of MDS? |
| 19:15:13 | <djazayeri> jkeiper: I didn't update that |
| 19:15:20 | <jkeiper> oh |
| 19:15:33 | <jkeiper> i had problems serializing a non-persisted object with it |
| 19:15:37 | <djazayeri> rfriedman: actually, I need to get lunch real quick, I should be available in 30 minutes. |
| 19:15:49 | <rfriedman> would you be available a lot later then? |
| 19:16:07 | <jkeiper> xstream.serialization kept saving the persisted object, but then got into an infinite reference loop when i gave it a non-persisted copy |
| 19:16:18 | <rfriedman> djazayeri, ^ |
| 19:16:18 | <jkeiper> this is when trying to render a MDS export |
| 19:16:39 | <rafa> jkeiper: I think it is xstream jar that needs to be updated in OpenMRS core |
| 19:17:09 | <jkeiper> rafa, ah |
| 19:17:19 | <djazayeri> rfriedman: yes, i'll be available from 3:45pm onwards eastern time |
| 19:17:20 | <rafa> jkeiper: Do we have a ticket for that? I totally forgot abou it |
| 19:17:40 | <rfriedman> djazayeri, ok, gym time for me, catch you 5-6 ish |
| 19:18:57 | *** rfriedman has quit IRC |
| 19:24:15 | <jkeiper> rafa, unsure ... i'll check |
| 19:25:12 | <rafa> jkeiper: thx, add me to watchers, I'll test the new jar against MDS |
| 19:31:32 | <applecool> rafa: bye cya :) goodnight :) |
| 19:31:43 | <rafa> applecool: bye! |
| 19:32:00 | *** applecool has quit IRC |
| 19:38:54 | *** dkayiwa has joined #openmrs |
| 19:48:41 | *** Maurya_ has quit IRC |
| 19:50:16 | *** cpower has quit IRC |
| 20:16:51 | *** mvorobey has quit IRC |
| 20:29:31 | *** harshadura has quit IRC |
| 20:29:39 | <bwolfe> jkeiper++ |
| 20:30:51 | *** harshadura has joined #openmrs |
| 20:33:10 | <rafa> dkayiwa++ |
| 20:33:25 | <rafa> dkayiwa: love your discovery at TRUNK-3056 :D |
| 20:34:35 | *** rafa has quit IRC |
| 20:39:49 | <djazayeri> !ticket trunk-3056 |
| 20:39:51 | <OpenMRSBot> djazayeri: [#TRUNK-3056] Potential Memory Leak reported by Tomcat 7 - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3056 |
| 20:41:05 | *** jkeiper has quit IRC |
| 20:48:24 | *** bwolfe has quit IRC |
| 20:51:25 | *** goutham has quit IRC |
| 21:24:21 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: @Nimamon @robmiles0 @diptanu et. al - Thanks for your participation & welcome to the community! <http://twitter.com/OpenMRS/statuses/236200417829208064> |
| 21:27:20 | *** lh is now known as lh_afk |
| 21:44:36 | *** rfriedman has joined #openmrs |
| 21:45:17 | <rfriedman> djazayeri, hi, is now convenient for you? |
| 21:45:22 | <djazayeri> sure |
| 21:45:28 | <rfriedman> ok, 2 issues |
| 21:45:46 | <rfriedman> #1, consider ConceptSet |
| 21:46:01 | <rfriedman> it carries a data element, sortOrder |
| 21:46:17 | <rfriedman> at the moment, there is no ConceptSet subresource |
| 21:47:03 | <rfriedman> so we can add and remove concepts to/from a second concept's set Members, right? |
| 21:47:26 | <rfriedman> but there's no way to edit sortOrder |
| 21:47:33 | <rfriedman> do I have that correct? |
| 21:47:56 | <djazayeri> rfriedman: it's okay not to have an explicit subresource or domain object representing a many-to-many, as long as the only fields in that table are the pointers, and a sort order |
| 21:48:15 | <rfriedman> then how does sort order get set? |
| 21:48:45 | <djazayeri> rfriedman: the idea is that the client or api user shouldn't care about the specific numeric value of sortOrder, but you can edit the children collection on the parent, and the sort order is set |
| 21:49:31 | <rfriedman> so you are saying that when the collection contents change, sortOrder will be adjusted to keep them in order? |
| 21:49:32 | <djazayeri> rfriedman: ConceptService.saveConcept should take care of updating the sort order. |
| 21:49:49 | <djazayeri> rfriedman: that's what should be happening in principle. |
| 21:50:04 | <djazayeri> rfriedman: well, actually, let me rephrase that... |
| 21:51:09 | <djazayeri> rfriedman: from a REST perspective, the way it should be written is that setMembers is a property of a Concept, and you don't know the explicit sortOrder value, just the order in the list. And if you POST to update a concept and changing the order of the setMembers list, the server-side code should handle it. |
| 21:51:28 | <djazayeri> rfriedman: and we intentionally don't expose a conceptset resource. |
| 21:51:35 | <rfriedman> so if it doesn't i should write a ticket |
| 21:51:39 | <djazayeri> rfriedman: is that what you're asking, or are you asking more about the API? |
| 21:51:57 | <djazayeri> rfriedman: correct, we intentionally don't have a conceptset resource. But concept has members, right? |
| 21:52:18 | <rfriedman> right, but i don't know that the ordering was implemented |
| 21:52:44 | <rfriedman> that would be done with a custom setter, right? |
| 21:52:55 | <djazayeri> rfriedman: definitely if the ordering and reordering doesn't work as I've described it, then ticket that. |
| 21:53:34 | <djazayeri> rfriedman: should be straightforward to verify in a unit test, right? |
| 21:53:57 | <rfriedman> and it also means we have to be sure that the underlying pojo uses an ordered collection of some sort |
| 21:54:40 | <djazayeri> rfriedman: the underlying API _does_ have a ConceptSet object, which does implement Comparable |
| 21:54:48 | <rfriedman> right |
| 21:55:05 | <rfriedman> the same situation should obtain for concept_answer |
| 21:55:45 | <djazayeri> rfriedman: I would trust the output of a unit test proving or disproving the behavior, over reasoning based on java + hbm.xml config. :-) |
| 21:55:51 | <djazayeri> rfriedman: yes, concept_answer is the same |
| 21:56:39 | <rfriedman> well, writing unit tests is hard for me because i don't know all the methods relating to requests and responses and extracting elements |
| 21:57:26 | <rfriedman> so on to issue #2 |
| 21:57:33 | *** dkayiwa has quit IRC |
| 21:57:37 | <rfriedman> since that is a good lead-in |
| 21:57:58 | <rfriedman> it relates to the issue around personnameresource |
| 21:58:04 | <rfriedman> and the save method |
| 21:59:18 | <rfriedman> djazayeri, i have looked at the personname.equals method and the only one i could find is inherited from baseopenmrsobject and uses the uuid |
| 21:59:53 | <rfriedman> so if i take a person name and change a field in it and try to write it back, it won't be written |
| 22:00:24 | <djazayeri> rfriedman: about unit tests around concept saving, look at the tests in ConceptControllerTest, like shouldEditFullySpecifiedNameOfAConcept() |
| 22:00:29 | <rfriedman> i think the logic is backwards, it always needs to be added, if there is an existing record it needs to be deleted |
| 22:01:30 | <djazayeri> rfriedman: let's look at PersonNameControllerTest.shouldEditName() |
| 22:02:30 | <djazayeri> rfriedman: actually, fine, let's look at the code of the save method. |
| 22:02:35 | <djazayeri> rfriedman: on PersonNameResource |
| 22:03:35 | <djazayeri> rfriedman: the idea is that by the time this method is called, you either have an existing person name, that you had already specified by UUID in the post, and hence it was fetched that way, or else we're creating a new one with a post to person/uuid/name |
| 22:04:33 | <rfriedman> what about _shouldNotOverwriteName |
| 22:04:52 | <djazayeri> rfriedman: in the first scenario, the name must already belong to the parent patient, that's where the shouldAdd = false comes from. |
| 22:05:22 | <rfriedman> so I can't change Roger Friedman to Darius Jazayeri? |
| 22:05:29 | <djazayeri> rfriedman: if you look at DelegatingSubResource and the create and update methods, that explains the logic |
| 22:06:06 | <djazayeri> rfriedman: is there a shouldNotOverwriteName test method somewhere? |
| 22:06:31 | <rfriedman> yes, in PersonControllerTest |
| 22:06:47 | <djazayeri> rfriedman: I need to update. do you know if restws got moved to git? or is still in svn? |
| 22:07:01 | <rfriedman> last i checked it was in svn |
| 22:08:36 | <djazayeri> rfriedman: you're not allowed to edit names via the Person resource directly. You have to do it from the sub-resource |
| 22:08:43 | <djazayeri> rfriedman: gotta take a phone call, back in a sec |
| 22:14:39 | <rfriedman> 1. PersonNameControllerTest.shouldEditName expects an exception |
| 22:15:45 | <rfriedman> 2. PersonControllerTest.updatePerson_shouldNotOverwriteNamesOnAPerson is exactly the update method that you suggested for ConceptSet in issue #1 |
| 22:36:06 | * rfriedman is getting a snack |
| 23:00:22 | <djazayeri> rfriedman: hi |
| 23:03:29 | <rfriedman> hi |
| 23:04:51 | <rfriedman> djazayeri, see my 2 pts above? |
| 23:05:37 | <djazayeri> rfriedman: PersonNameControllerTest.shouldEditName does *not* expect an exception |
| 23:06:18 | <rfriedman> iyou're right, it just throws one, sorry |
| 23:07:07 | <rfriedman> so something must be happening in the update method in a higher level controller |
| 23:07:27 | <djazayeri> rfriedman: the test passes for me (the one in PersonNameControllerTest) |
| 23:07:50 | <rfriedman> well, i've be been building that sucker over and over again, so i know it passes the tests |
| 23:08:14 | <djazayeri> rfriedman: okay, then I don't know where it throws an exception... |
| 23:08:38 | <rfriedman> i guess that's there for good luck |
| 23:08:48 | <rfriedman> or against bad luck |
| 23:09:02 | <djazayeri> rfriedman: if you're suggesting that the re-ordering of concept set members via updating the concept property is not working, I expect you're right. |
| 23:09:28 | <rfriedman> right, we agree on that, it just has to be proved/disproved |
| 23:09:41 | <rfriedman> i'm just trying to understand the rules |
| 23:10:20 | <rfriedman> 1. there doesn't have to be a subresource for a helper table as long as it carries no data. in this case, collections can be replaced |
| 23:10:29 | <djazayeri> rfriedman: offhand I think the correct thing should be POST concept { setMembers: [ uuid3, uuid2, uui1 ] } |
| 23:10:47 | <rfriedman> yes, that's what I meant |
| 23:10:53 | <djazayeri> rfriedman: yes, exactly |
| 23:11:12 | <rfriedman> 2. if there is a subresource, then you can't replace a collection, you have to edit individual members |
| 23:11:13 | <djazayeri> rfriedman: it's specifically about many-to-manies |
| 23:11:35 | <rfriedman> or self joins |
| 23:11:47 | <djazayeri> sure |
| 23:12:06 | <djazayeri> but there's no helper object for a self-join |
| 23:12:33 | <rfriedman> ConceptSet is a helper table |
| 23:12:53 | <djazayeri> right, I was calling that a many-to-many, but I suppose you could call it a self-join too. :-) |
| 23:13:04 | <djazayeri> anyway, we agree. |
| 23:13:24 | <rfriedman> ok |
| 23:13:34 | <rfriedman> i think I'm clear, thanks for your time |
| 23:14:07 | <djazayeri> np |
| 23:16:35 | *** rfriedman is now known as rfriedman_away |
| 23:17:07 | *** suranga has quit IRC |
| 23:34:08 | *** lh_afk is now known as lh |
| 23:49:50 | *** downey has quit IRC |