| 00:22:44 | *** jordank has quit IRC |
| 02:19:29 | *** deadpool has quit IRC |
| 02:46:27 | *** dmexs has joined #openmrs |
| 02:47:17 | *** dmexs has joined #openmrs |
| 03:03:11 | *** kishoreyekkanti has joined #openmrs |
| 03:15:01 | *** kishoreyekkanti has quit IRC |
| 03:19:12 | *** dmexs has quit IRC |
| 03:36:35 | *** harshadura has quit IRC |
| 03:38:31 | *** maurya has joined #openmrs |
| 03:38:50 | *** ChanServ sets mode: +v maurya |
| 03:57:09 | *** mccallumg has joined #openmrs |
| 03:57:10 | *** ChanServ sets mode: +v mccallumg |
| 04:27:05 | *** mccallumg has quit IRC |
| 04:33:16 | *** reddykir has quit IRC |
| 04:51:28 | *** kishoreyekkanti has joined #openmrs |
| 05:07:02 | *** bwolfe has quit IRC |
| 05:17:12 | *** pulasthi7 has joined #openmrs |
| 05:25:53 | *** kishoreyekkanti has quit IRC |
| 05:36:00 | *** deadpool has joined #openmrs |
| 06:08:58 | *** diptanuc has joined #openmrs |
| 06:11:35 | *** maurya has quit IRC |
| 06:13:39 | *** harshadura has joined #openmrs |
| 06:13:47 | *** diptanuc has quit IRC |
| 06:15:34 | *** shortend has joined #openmrs |
| 06:22:02 | *** pulasthi7 has quit IRC |
| 06:35:50 | *** robbyoconnor has joined #openmrs |
| 06:35:50 | *** ChanServ sets mode: +v robbyoconnor |
| 07:13:32 | *** mgielow has joined #openmrs |
| 07:44:17 | *** dkayiwa has joined #openmrs |
| 07:55:28 | *** goutham has joined #openmrs |
| 08:03:02 | *** applecool has joined #openmrs |
| 08:03:02 | *** ChanServ sets mode: +v applecool |
| 08:11:16 | *** snoppy has joined #openmrs |
| 08:12:07 | *** applecool has quit IRC |
| 08:23:20 | *** harshadura has quit IRC |
| 08:26:54 | *** shortend has quit IRC |
| 08:53:44 | *** rafa has joined #openmrs |
| 08:53:44 | *** ChanServ sets mode: +v rafa |
| 08:59:21 | <dkayiwa> rafa: hi rafa. any tips on what i could do for STAND-60? looks like am running out of ideas. :) |
| 08:59:41 | <rafa> dkayiwa: do you know the cause? |
| 08:59:57 | <rafa> dkayiwa: is it a faulty liquibase plugin? |
| 09:00:06 | <dkayiwa> rafa: maybe |
| 09:00:25 | <dkayiwa> rafa: so the changesets are in DATABASECHANGELOG |
| 09:00:36 | <dkayiwa> rafa: yet it looks for liquibasechangelog |
| 09:00:39 | <rafa> dkayiwa: right |
| 09:01:02 | <dkayiwa> rafa: when i manually rename DATABASECHANGELOG to liquibasechangelog, then no update wizard |
| 09:01:11 | <dkayiwa> rafa: then stuff work correct |
| 09:02:54 | <rafa> dkayiwa: hmmm before you run mvn clean package can you set a system environment property "liquibase.databaseChangeLogTableName" to liquibasechangelog? |
| 09:03:23 | <rafa> dkayiwa: maybe the plugin is not setting it properly, but if you set it manually it'll be picked up by liqubiase |
| 09:03:28 | <dkayiwa> rafa: looks like that is already set in the pom |
| 09:03:47 | <dkayiwa> rafa: oh i see |
| 09:04:30 | <rafa> dkayiwa: set it the same way as maven_opts |
| 09:04:44 | <dkayiwa> rafa: ok |
| 09:04:48 | <dkayiwa> rafa: did you look at liquibase-demo-data-18x.xml |
| 09:04:49 | <dkayiwa> ? |
| 09:04:59 | <dkayiwa> rafa: and see the renameTable? |
| 09:05:11 | <rafa> dkayiwa: ohh |
| 09:06:02 | <rafa> dkayiwa: but you tired that and it failed for you? |
| 09:06:12 | <rafa> dkayiwa: in mvp-data? |
| 09:06:23 | <dkayiwa> rafa: yes it failed |
| 09:06:40 | <rafa> dkayiwa: ohh I know why |
| 09:06:46 | <dkayiwa> rafa: aha |
| 09:07:01 | <rafa> dkayiwa: because you can't put it in mvp-data-18x.xml |
| 09:07:15 | <rafa> dkayiwa: after that liquibase-update-to-latest.xml is run |
| 09:07:15 | <dkayiwa> rafa: ok |
| 09:07:21 | <dkayiwa> rafa: ok |
| 09:07:26 | <rafa> dkayiwa: so it still needs to be databasechangelog |
| 09:07:50 | <rafa> dkayiwa: only after liquibase-update-to-latest you can run a changeset which will rename the table |
| 09:08:17 | <dkayiwa> rafa: ok |
| 09:08:37 | <rafa> dkayiwa: but demo-data-18.x does a strange thing |
| 09:08:47 | <rafa> dkayiwa: it does it the other way |
| 09:08:50 | <dkayiwa> rafa: very strange |
| 09:09:03 | <rafa> dkayiwa: or am I still not awake? |
| 09:09:23 | <dkayiwa> rafa: you are very awake :) |
| 09:09:43 | <rafa> dkayiwa: hmmm |
| 09:10:25 | <rafa> dkayiwa: ohh and liquibae-rename-helper-tables does it again :D |
| 09:10:42 | <rafa> dkayiwa: now in the right way |
| 09:11:19 | <rafa> dkayiwa: so yes, executing liquibase-rename-helper-tables-18x.xml after liquibase-update-to-latest.xml will do the trick |
| 09:12:25 | <rafa> dkayiwa: is that clear? |
| 09:12:39 | <rafa> dkayiwa: add a new execution after <execution><id>empty-db-update-to-latest</id> |
| 09:13:04 | <dkayiwa> rafa: a new execution for the rename? |
| 09:13:26 | <rafa> dkayiwa: yes, for liquibase-rename-helper-tables-18x.xml |
| 09:13:55 | <dkayiwa> rafa: which will have <renameTable newTableName="liquibasechangelog" oldTableName="DATABASECHANGELOG"/> ? |
| 09:14:09 | <rafa> dkayiwa: it already has it |
| 09:14:24 | <rafa> dkayiwa: there's a file liquibase-rename-helper-tables-18x.xml |
| 09:14:30 | <dkayiwa> rafa: ok |
| 09:14:58 | <rafa> dkayiwa: see demo-db-followup how to do that |
| 09:15:15 | <dkayiwa> rafa: i saw that there is alreadty an execution for that |
| 09:15:20 | <dkayiwa> rafa: named demo-db-followup |
| 09:15:29 | <dkayiwa> rafa: which points to liquibaseDemoDataFollowupFileName |
| 09:15:32 | <rafa> dkayiwa: just copy that execution and rename it empty-db-followup |
| 09:16:11 | <dkayiwa> rafa: did you see this? <liquibaseDemoDataFollowupFileName>liquibase-rename-helper-tables-18x.xml</liquibaseDemoDataFollowupFileName> |
| 09:16:20 | <rafa> dkayiwa: yes |
| 09:16:37 | <dkayiwa> rafa: it is already run in the demo-db-followup execution |
| 09:16:44 | <rafa> dkayiwa: yes, but for the demo db |
| 09:16:50 | <rafa> dkayiwa: you need to run it for the empty db |
| 09:16:55 | <dkayiwa> rafa: oh i see!!!! |
| 09:17:08 | <rafa> dkayiwa: right after empty-db-update-to-latest |
| 09:17:21 | <dkayiwa> rafa: ok |
| 09:18:00 | *** mgielow has quit IRC |
| 09:36:23 | *** sunbiz has joined #openmrs |
| 09:36:23 | *** ChanServ sets mode: +v sunbiz |
| 09:58:39 | <dkayiwa> rafa: i have added an execution for <id>empty-db-followup</id> immediately after <id>empty-db-update-to-latest</id> But still same problem |
| 09:59:08 | <rafa> dkayiwa: does it fail or you see upgrade wizard? |
| 09:59:23 | <dkayiwa> rafa: i still see upgrade wizard |
| 09:59:30 | <dkayiwa> rafa: meaning building is successful |
| 09:59:48 | <rafa> dkayiwa: was the table renamed? |
| 10:00:00 | <dkayiwa> rafa: i still see two tables |
| 10:00:24 | <dkayiwa> DATABASECHANGELOG and liquibasechangelog |
| 10:00:28 | <rafa> dkayiwa: can you look inside them? |
| 10:00:40 | <dkayiwa> rafa: liquibasechangelog is empty while the other is full |
| 10:00:40 | <rafa> dkayiwa: are they both filled with data? |
| 10:01:05 | <rafa> dkayiwa: so the rename table changeset was probably not executed |
| 10:01:15 | <dkayiwa> rafa: i suspect so too |
| 10:01:16 | <rafa> dkayiwa: can you pastebin the pom? |
| 10:01:22 | <dkayiwa> rafa: ok |
| 10:02:21 | <dkayiwa> rafa: http://pastebin.com/R95Dvztb |
| 10:03:26 | *** rram_ has joined #openmrs |
| 10:04:05 | <rafa> dkayiwa: you haven't corrected the url in empty-db-followup |
| 10:04:11 | <rafa> dkayiwa: it says target/demodatabase |
| 10:04:27 | <rafa> dkayiwa: it should be target/emptydatabase |
| 10:04:28 | <dkayiwa> rafa: hahaha. thanks. nice catch!!! |
| 10:04:44 | <dkayiwa> rafa: let me build again |
| 10:05:19 | <rafa> dkayiwa: watch out there are basedir and datadir which need to be corrected |
| 10:05:26 | <dkayiwa> rafa: ok |
| 10:13:05 | <goutham> rafa: Hi |
| 10:13:14 | <rafa> goutham: hi |
| 10:14:18 | <goutham> rafa: Do you know dependency for BaseModuleWebContextSensitiveTest for openmrs 1.7 version |
| 10:16:34 | <rafa> goutham: something like: <groupId>org.openmrs.web</groupId><artifactId>openmrs-web</artifactId><version>1.7.4</version><classifier>tests</classifier> |
| 10:17:26 | <dkayiwa> goutham: by the way, did you respond to Jame's email? |
| 10:18:03 | <goutham> dkayiwa: i understood the bug. Solved it ! Will send the reply in the evening |
| 10:18:12 | <rafa> goutham: either 1.7.4 or 1.7.3 should have it |
| 10:18:42 | <goutham> rafa: checking it :) |
| 10:19:04 | <dkayiwa> goutham: the earlier you respond the better because the deadline is soon and yet we need to address user feedback |
| 10:19:46 | <dkayiwa> goutham: so i would prefer you send it now such that we give ourselves time to look into all feedback issues before pencils down!!! |
| 10:20:07 | <goutham> dkayiwa: Ok sending the mail right away |
| 10:20:26 | <dkayiwa> goutham: James is a very enthusiastic tester and we need to keep him busy!!! :) |
| 10:21:17 | <goutham> dkayiwa: :) |
| 10:24:11 | *** maurya has joined #openmrs |
| 10:27:08 | *** rram_ has quit IRC |
| 10:40:32 | <goutham> dkayiwa: sent the mail |
| 10:40:45 | <dkayiwa> goutham: ok thanks :D |
| 10:44:16 | <dkayiwa> rafa: thanks alottttttttt. You have saved me alot of time!!! :D |
| 10:44:31 | <rafa> dkayiwa: I guess it works :) |
| 10:44:38 | <dkayiwa> rafa: yes :) |
| 10:44:42 | <rafa> dkayiwa: great! |
| 10:44:56 | <rafa> dkayiwa: I'll try it out |
| 10:45:02 | <dkayiwa> rafa: ok |
| 11:02:39 | *** goutham_ has joined #openmrs |
| 11:03:45 | *** goutham has quit IRC |
| 11:08:44 | <dkayiwa> hi rafa |
| 11:08:50 | <rafa> dkayiwa: yes? |
| 11:08:56 | <dkayiwa> !ticket TRUNK-3508 |
| 11:08:57 | <OpenMRSBot> dkayiwa: [#TRUNK-3508] @StartModule does not work - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3508 |
| 11:09:12 | <dkayiwa> rafa: how do i tell that context is not properly refreshed? |
| 11:09:20 | <dkayiwa> rafa: for the above ticket |
| 11:09:20 | *** shortend has joined #openmrs |
| 11:10:01 | <rafa> dkayiwa: Just try to make @StartModule work |
| 11:10:20 | <rafa> dkayiwa: write any test that uses @StartModule |
| 11:10:33 | <dkayiwa> rafa: ok |
| 11:10:44 | <rafa> dkayiwa: in some other module |
| 11:10:52 | <dkayiwa> rafa: ok |
| 11:11:09 | <rafa> dkayiwa: you could write a test in hfe using hfe ext19 |
| 11:11:16 | <dkayiwa> rafa: ok |
| 11:13:53 | *** james_regen has joined #openmrs |
| 11:13:53 | *** ChanServ sets mode: +v james_regen |
| 11:19:21 | *** goutham_ has quit IRC |
| 11:28:35 | <dkayiwa> rafa: did we add support for the standalone's running the update concept index task? |
| 11:31:42 | <rafa> dkayiwa: meaning? |
| 11:32:07 | <rafa> dkayiwa: updating index while building a standalone? |
| 11:32:17 | <dkayiwa> rafa: yes |
| 11:32:21 | <rafa> dkayiwa: no |
| 11:32:33 | <dkayiwa> rafa: ok |
| 11:32:40 | <rafa> dkayiwa: it's done only when first started |
| 11:32:53 | <dkayiwa> rafa: yes |
| 11:33:24 | <dkayiwa> rafa: but can take real long especially for mvp database and hence consume some cpu |
| 11:33:51 | <dkayiwa> rafa: would be nice to have it done by standalone build process (if it were simple to do) :) |
| 11:51:27 | *** downey has joined #openmrs |
| 11:51:27 | *** ChanServ sets mode: +o downey |
| 11:51:27 | *** OpenMRSBot sets mode: +o downey |
| 11:58:18 | *** bwolfe has joined #openmrs |
| 11:58:18 | *** ChanServ sets mode: +o bwolfe |
| 11:58:24 | *** Jibesh has joined #openmrs |
| 12:01:51 | *** harshadura has joined #openmrs |
| 12:04:13 | *** downey has quit IRC |
| 12:04:25 | *** downey has joined #openmrs |
| 12:04:28 | *** downey has joined #openmrs |
| 12:04:28 | *** ChanServ sets mode: +o downey |
| 12:04:28 | *** OpenMRSBot sets mode: +o downey |
| 12:04:57 | <dkayiwa> hi rafa |
| 12:05:04 | <dkayiwa> rafa: this test passes http://pastebin.com/4LcyqiSV |
| 12:05:51 | <dkayiwa> rafa: do you have an example test which fails? |
| 12:10:25 | *** rafa has quit IRC |
| 12:21:25 | *** rfriedman has joined #openmrs |
| 12:22:33 | *** goutham has joined #openmrs |
| 12:22:34 | <rfriedman> bwolfe, morning ben, got a minute? |
| 12:24:56 | *** bwolfe has quit IRC |
| 12:25:14 | <dkayiwa> bwolfe is a coward :) |
| 12:25:56 | <rfriedman> dkayiwa, if darius is awake at this hour and downey is on line, it means they're all in a big meeting |
| 12:26:09 | <dkayiwa> rfriedman: ok |
| 12:26:11 | <downey> rfriedman: yep, meeting just finished :) |
| 12:26:37 | <rfriedman> hey downey, good morning |
| 12:27:00 | <rfriedman> downey, any news on pre/post-implementers meeting events? |
| 12:27:10 | *** bwolfe has joined #openmrs |
| 12:27:10 | *** ChanServ sets mode: +o bwolfe |
| 12:27:15 | <bwolfe> someone say my name? |
| 12:27:25 | <rfriedman> hi bwolfe, yep that's me |
| 12:27:33 | <rfriedman> i was thinking ... |
| 12:27:45 | <rfriedman> if A and B are parent and child tables |
| 12:28:14 | <rfriedman> and A has a collection of Bs and B has its A |
| 12:28:41 | <rfriedman> and in their full reps in REST they both use the full reps of each other |
| 12:29:05 | <rfriedman> what stops REST from an infinite loop looking up Bs in A and A in B? |
| 12:30:23 | *** suranga has joined #openmrs |
| 12:30:23 | *** ChanServ sets mode: +v suranga |
| 12:30:40 | <rfriedman> ? bwolfe ^ |
| 12:33:12 | <bwolfe> rfriedman, most frameworks will use some sort of "reference" if it encounters a previously serialized object |
| 12:33:41 | <bwolfe> rfriedman, I don't remember us putting something like that in because we are able to control the properties and objects that are exposed |
| 12:34:36 | <rfriedman> bwolfe, i am stepping through such a case and it looks like there's nothing to stop it but memory |
| 12:35:06 | <rfriedman> bwolfe, so we need to exercise some self-control over what we put in the reps and we need to document that |
| 12:35:06 | <bwolfe> rfriedman, better lower your memory then. :-D |
| 12:35:14 | <bwolfe> yes, and yes |
| 12:35:57 | <rfriedman> bwolfe, ok, i'll verify then post |
| 12:36:11 | <bwolfe> !seen rafa |
| 12:36:11 | <OpenMRSBot> bwolfe: rafa was last seen in #openmrs 1 hour, 3 minutes, and 30 seconds ago: <rafa> dkayiwa: it's done only when first started |
| 12:36:35 | <bwolfe> haha, did that sentence make sense at the time? |
| 12:36:57 | <rfriedman> at 7:33 am nothing makes sense |
| 12:37:04 | <dkayiwa> bwolfe: oh yes it did :) |
| 12:37:41 | <bwolfe> oh good. I thought rafal was losing his mind for a second. |
| 12:37:52 | <dkayiwa> bwolfe: no not at all :) |
| 12:37:59 | <rfriedman> bwolfe, steel trap in steel trap, no danger |
| 12:39:57 | *** rfriedman is now known as rfriedman_away |
| 12:49:52 | <goutham> dkayiwa: http://pastebin.com/8Ag5at66 i am getting this error |
| 12:50:47 | <dkayiwa> goutham: can you commit and i also try it here? |
| 12:51:03 | <goutham> dkayiwa: Ok |
| 12:55:50 | <goutham> dkayiwa: made the commit |
| 12:55:57 | <dkayiwa> goutham: ok |
| 13:00:28 | <OpenMRSBot> Recent updates in the world of openmrs: On Twitter: OpenMRS: RT @djazayeri: @OpenMRS is moving to @github on Thursday. Awesome! Start getting ready: http://t.co/lF5gnvQ6 <http://twitter.com/OpenMRS/statuses/235710395321577472> |
| 13:17:39 | <suranga> howdy bwolfe ! |
| 13:18:14 | <suranga> bwolfe, so add / edit / retire / restore for hl7 template works fine now.. i've commited it... its on HLQRY-11 :-) |
| 13:19:06 | <bwolfe> suranga++ |
| 13:26:06 | <dkayiwa> hi goutham |
| 13:26:16 | <goutham> dkayiwa: Hi |
| 13:26:25 | <dkayiwa> goutham: after updating, mvn install works very well on mine without any errors |
| 13:26:56 | <goutham> dkayiwa: Yes but on uploading the module its giving the error |
| 13:27:59 | <goutham> dkayiwa: i think its with the omod dependencies |
| 13:33:53 | <dkayiwa> goutham: what did you change to start getting that error? |
| 13:35:07 | <goutham> dkayiwa: i added this dependency <dependency> <groupId>org.openmrs.web</groupId><artifactId>openmrs-web</artifactId><version>1.7.4</version><classifier>tests</classifier></dependency> |
| 13:35:08 | <suranga> !karma suranga |
| 13:35:08 | <OpenMRSBot> suranga: Karma for "suranga" has been increased 11 times and decreased 2 times for a total karma of 9. |
| 13:35:38 | <dkayiwa> goutham: only? |
| 13:37:45 | <goutham> dkayiwa: i made many changes but i strongly belive this is making the error |
| 13:38:22 | <dkayiwa> goutham: i thought we change the version using this??? <properties> |
| 13:38:23 | <dkayiwa> <openMRSVersion>???</openMRSVersion> |
| 13:38:33 | <goutham> dkayiwa: because i created a new module(basic) one and added this and this started to give error |
| 13:38:48 | <goutham> dkayiwa: its 1.7.2 |
| 13:39:34 | <dkayiwa> goutham: but the place you changed seems different as per your above statement?? |
| 13:39:50 | *** harshadura has quit IRC |
| 13:41:35 | <goutham> dkayiwa: ya but 1.7.2 is giving error |
| 13:42:21 | <dkayiwa> goutham: can you start by removing the change you made for: |
| 13:42:22 | <dkayiwa> i added this dependency <dependency> <groupId>org.openmrs.web</groupId><artifactId>openmrs-web</artifactId><version>1.7.4</version><classifier>tests</classifier></dependency> |
| 13:44:36 | *** goutham_ has joined #openmrs |
| 13:44:41 | *** Jibesh has left #openmrs |
| 13:45:50 | *** goutham has quit IRC |
| 13:46:19 | <goutham_> dkayiwa: if i remove that mvn install wont work |
| 13:46:31 | *** goutham_ is now known as goutham |
| 13:46:51 | <dkayiwa> goutham: can you commit after removing that? |
| 13:47:42 | <goutham> dkayiwa: i lost the connection in between so missed a bit of conversation. |
| 13:48:12 | <goutham> dkayiwa: so i am removing that dependency we were talking about and commit ! |
| 13:48:25 | <dkayiwa> goutham: ok |
| 13:49:22 | *** diptanuc has joined #openmrs |
| 13:49:36 | <diptanuc> @bwolfe Around? |
| 13:49:46 | <diptanuc> bwolfe: Around? |
| 13:49:57 | <bwolfe> yes |
| 13:49:58 | <bwolfe> and yes |
| 13:51:10 | <diptanuc> bwolfe: We are running codejam this evening |
| 13:51:16 | <diptanuc> bwolfe: Will you be around? |
| 13:51:26 | <goutham> dkayiwa: done |
| 13:51:27 | <diptanuc> bwolfe: I am thinking to do the following tickets |
| 13:51:35 | <bwolfe> define "evening". :-) 5 hours from now? |
| 13:51:56 | <diptanuc> bwolfe: TRUNK - 3615, 3608, 3501, 3632 |
| 13:52:05 | <diptanuc> bwolfe: At 6PM London time |
| 13:52:15 | <diptanuc> two hours from now! |
| 13:52:16 | <diptanuc> :) |
| 13:52:33 | <bwolfe> you're 6 hours ahead? |
| 13:52:44 | <bwolfe> !ticket TRUNK-3615 |
| 13:52:45 | <OpenMRSBot> bwolfe: [#TRUNK-3615] Add WebUtil.getContextPath() - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3615 |
| 13:52:48 | <bwolfe> !ticket TRUNK-3608 |
| 13:52:49 | <OpenMRSBot> bwolfe: [#TRUNK-3608] Cannot edit user if name is null - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3608 |
| 13:52:55 | <bwolfe> !ticket TRUNK-3501 |
| 13:52:56 | <OpenMRSBot> bwolfe: [#TRUNK-3501] Show helpful message when purging in-use Field Types - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3501 |
| 13:52:59 | <bwolfe> !ticket TRUNK-3632 |
| 13:53:00 | <OpenMRSBot> bwolfe: [#TRUNK-3632] Update build so it doesnt look at svn revision - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3632 |
| 13:54:34 | <goutham> dkayiwa: committed |
| 13:54:51 | <dkayiwa> goutham: ok |
| 13:56:17 | <diptanuc> bwolfe: Lots of new people today! |
| 13:56:56 | <bwolfe> diptanuc, first three are fine. that last one I have been working on. I could have sworn I claimed that... :-/ |
| 13:57:37 | <bwolfe> diptanuc, unfortunately (or fortunately) I have hit a blocker on that one and am stumped. so perhaps turning it over to your good minds will do it good! :-) |
| 13:58:02 | <diptanuc> bwolfe: Lol. Ok We can pick up 3638/3628 |
| 13:58:13 | <diptanuc> bwolfe: Whatever you wish good sir! |
| 13:58:48 | <cpower> hello |
| 13:59:05 | *** lh has quit IRC |
| 13:59:12 | <bwolfe> hi power |
| 13:59:13 | <cpower> and for the geeks online, welcome to Gencon weekend |
| 13:59:23 | *** lh has joined #openmrs |
| 13:59:57 | <cpower> It's time to do this thing we call Scrum |
| 14:00:39 | <cpower> !scrumon cpower |
| 14:00:39 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:01:22 | <cpower> Order: Bwolfe, djazayeri, suranga, dkayiwa and anyone whom I might have missed. |
| 14:01:55 | <bwolfe> diptanuc, lets finish the discussion after the sprint |
| 14:01:57 | <bwolfe> err, scrum |
| 14:02:42 | <bwolfe> Tuesday |
| 14:02:42 | <bwolfe> emails |
| 14:02:42 | <bwolfe> triaged ERR tickets |
| 14:02:42 | <bwolfe> triaged new trunk tickets |
| 14:02:42 | <bwolfe> reviewed commits by Rafal |
| 14:02:44 | <bwolfe> update documentation to point to github |
| 14:02:46 | <bwolfe> prepare for move to github |
| 14:02:48 | <bwolfe> revamped code review pages - TRUNK-3603 |
| 14:02:50 | <bwolfe> removed extra crap in the git repo |
| 14:02:52 | <bwolfe> created readme in git repo TRUNK-3602 |
| 14:02:54 | <bwolfe> fixed build.xml to look at git hash code - TRUNK-3632 |
| 14:02:56 | <bwolfe> Wednesday |
| 14:02:58 | <bwolfe> emails |
| 14:03:00 | <bwolfe> triaged a few TRUNK tickets |
| 14:03:02 | <bwolfe> admin stuff for github |
| 14:03:04 | <bwolfe> univ call |
| 14:03:06 | <bwolfe> design call |
| 14:03:08 | <bwolfe> pm call |
| 14:03:10 | <bwolfe> github migration wiki page edits |
| 14:03:14 | <bwolfe> blocked on TRUNK-3632, attached a patch there for diptanuc's smart hackers to figure out. ;-) |
| 14:03:39 | <djazayeri> All week |
| 14:03:40 | <djazayeri> * OpenMRS Calls |
| 14:03:40 | <djazayeri> * I-TECH work |
| 14:03:40 | <djazayeri> * sporadic code reviews and ticket comments |
| 14:03:40 | <djazayeri> Today |
| 14:03:40 | <djazayeri> * Working on UIFR-11 - You should be able to indicate exactly which provider you want a fragment or page to come from |
| 14:03:41 | <djazayeri> No blockers |
| 14:03:51 | <djazayeri> Question: would like to know if anyone here is using the UI Framework module now? |
| 14:04:08 | <djazayeri> (because I'm considering a non-backwards-compatible change) |
| 14:05:03 | <djazayeri> suranga: ? |
| 14:05:09 | <suranga> hi guys |
| 14:05:16 | <suranga> Today : |
| 14:05:16 | <suranga> finished work on HL7QRY-11 |
| 14:05:16 | <suranga> Next : |
| 14:05:16 | <suranga> working on Hl7QRY-26 |
| 14:05:16 | <suranga> Worries : |
| 14:05:16 | <suranga> Dont seem to have permissions to unassign people from jira tickets |
| 14:05:18 | <suranga> No blockers |
| 14:05:22 | <dkayiwa> Committed: Building standalone does not work for 1.8.4 - STAND-60 |
| 14:05:22 | <dkayiwa> Looked into: @StartModule does not work - TRUNK-3508 |
| 14:05:22 | <dkayiwa> Now working on: Potential Memory Leak reported by Tomcat 7 - TRUNK-3056 |
| 14:05:23 | <dkayiwa> No Blockers |
| 14:05:53 | <cpower> anyone else? |
| 14:05:57 | <djazayeri> dkayiwa: you're the bug fixer? |
| 14:06:04 | <dkayiwa> djazayeri: yes |
| 14:06:12 | <cpower> Blockers |
| 14:06:12 | <cpower> @bwolfe> blocked on TRUNK-3632, attached a patch there for diptanuc's smart hackers to figure out |
| 14:06:12 | <cpower> +suranga> Dont seem to have permissions to unassign people from jira ticket |
| 14:06:12 | <cpower> Discussion |
| 14:06:12 | <cpower> <@djazayeri> Question: would like to know if anyone here is using the UI Framework module now? |
| 14:07:30 | <djazayeri> I take it silence means no... |
| 14:07:59 | <cpower> *cricket* *cricket* |
| 14:08:04 | <cpower> !scrumoff |
| 14:08:04 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:08:05 | <suranga> :-) |
| 14:08:26 | <cpower> Good luck to diptanuc's hackers |
| 14:08:33 | <bwolfe> djazayeri, better ask on the dev list |
| 14:08:41 | <djazayeri> yup |
| 14:08:59 | <cpower> downey, can you figure out why suranga permissions (if needed) |
| 14:09:24 | *** jordank has joined #openmrs |
| 14:09:27 | <suranga> hi downey .. in regard to the hl7query module.. do I get permissions to unassign people from tickets :-) |
| 14:09:34 | <cpower> and anyone using the UI framework?...anyone...anyone... |
| 14:10:08 | *** rfriedman_away is now known as rfriedman |
| 14:10:46 | <rfriedman> bwolfe, do you have time to renew our previous conversation re RESTWS? |
| 14:11:04 | <dkayiwa> goutham: can you put @Ignore on tests that subclass BaseModuleWebContextSensitiveTest and then try compile and deploy in the web app |
| 14:11:06 | <cpower> downey's working on it. |
| 14:12:07 | <downey> suranga: example issue number please? |
| 14:12:10 | <goutham> dkayiwa: ok |
| 14:12:28 | <suranga> downey, I tried https://tickets.openmrs.org/browse/HLQRY-26 |
| 14:12:38 | <suranga> downey, maybe im doing something stupid... :( |
| 14:13:04 | <rfriedman> suranga, admitting doubt to downey is stupid, its like blood to a shark |
| 14:13:17 | <downey> suranga: i assume there is further work needed based on the code review? if so, click "rework needed" and then you could unassign it. |
| 14:13:48 | <suranga> downey, aha, thanks :-) |
| 14:14:04 | <suranga> rfriedman, it seems that my above statement was correct after all :P |
| 14:14:13 | <rfriedman> downey, sorry if that didn't feel as funny as it did here |
| 14:14:25 | *** diptanuc has quit IRC |
| 14:14:45 | <bwolfe> rfriedman, which convo? |
| 14:14:59 | <rfriedman> 8:33 |
| 14:15:05 | <bwolfe> !ticket TRUNK-3638 |
| 14:15:07 | <OpenMRSBot> bwolfe: [#TRUNK-3638] Separate liquibase file into separate files per version - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3638 |
| 14:15:08 | <bwolfe> !ticket TRUNK-3628 |
| 14:15:09 | <OpenMRSBot> bwolfe: [#TRUNK-3628] Hide the Preferred radio button on concept form - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3628 |
| 14:15:42 | *** goutham_ has joined #openmrs |
| 14:16:40 | *** goutham has quit IRC |
| 14:20:49 | <goutham_> dkayiwa: @Ignore is not working. Tests are giving Compilation failure as they couldnt find BaseModuleWebContextSensitiveTest |
| 14:21:05 | <dkayiwa> goutham_: oh sorry :) |
| 14:21:21 | <goutham_> dkayiwa: shall i delete them and try deploying |
| 14:21:32 | <dkayiwa> goutham_: can you tell maven to exclude those tests? |
| 14:22:16 | <rfriedman> bwolfe, if you don't have time to talk, pls let me know |
| 14:23:20 | <goutham_> dkayiwa: i will try |
| 14:23:29 | <dkayiwa> goutham_: ok |
| 14:24:30 | <bwolfe> rfriedman, we can chat... |
| 14:24:36 | <rfriedman> bwolfe, tks |
| 14:24:51 | <rfriedman> bwolfe, it appears to crash before out of memory |
| 14:25:01 | <bwolfe> rfriedman, which stack overflow? |
| 14:25:04 | <bwolfe> err *with |
| 14:25:17 | <rfriedman> i am thinking it may have something to do with the reuse of the singleton resource object |
| 14:25:33 | <rfriedman> java code isn't normally re-entrant, is it? |
| 14:26:00 | <bwolfe> how is it crashing? |
| 14:26:35 | <rfriedman> it just throws a conversion error, can't convert conceptmaptype |
| 14:27:04 | <bwolfe> hmm, whats underlying that though? you'll have to check the logs |
| 14:27:20 | <rfriedman> excuse me, concept map |
| 14:27:37 | <rfriedman> yes |
| 14:27:51 | <rfriedman> that's all it's saying |
| 14:27:58 | <bwolfe> does conceptmap have a resource? or one updated to 1.9? |
| 14:28:22 | <rfriedman> it's in conversionutil.converttorepresentation |
| 14:28:31 | <rfriedman> it's one i've written |
| 14:29:08 | <rfriedman> but the one i'm testing is conceptreferenceterm |
| 14:29:11 | *** downey_ has joined #openmrs |
| 14:29:11 | *** ChanServ sets mode: +o downey_ |
| 14:29:17 | <rfriedman> it contains a conceptmap collection |
| 14:29:37 | <rfriedman> conceptmap contains a conceptreferenceterm field |
| 14:30:35 | <rfriedman> i had traced it through crt trying to represent cm trying to represent crt |
| 14:30:53 | <rfriedman> which is how i thought i had an infinite recursion |
| 14:31:22 | *** downey has quit IRC |
| 14:31:22 | *** downey_ is now known as downey |
| 14:32:35 | <rfriedman> bwolfe, the first crt resource is created by the controller, then conversion util uses the singleton array for cm, crt and i think it is the next invocation of cm that kills things |
| 14:32:46 | *** suranga has quit IRC |
| 14:32:54 | <dkayiwa> hi goutham_ |
| 14:33:58 | *** goutham_ is now known as goutham |
| 14:34:20 | <goutham> dkayiwa: hi , im just reading james mail |
| 14:34:33 | <rfriedman> bwolfe, guess the next step is to test cm directly? |
| 14:34:36 | <dkayiwa> goutham: yes i wanted to point you to it :) |
| 14:35:02 | <dkayiwa> goutham: response to him is first priority. :) |
| 14:35:35 | <goutham> dkayiwa: ok :) |
| 14:36:04 | <dkayiwa> goutham: it will ensure that we atleast have a fully working module from 1.8 and above :) |
| 14:36:08 | *** sunbiz has quit IRC |
| 14:36:42 | <goutham> dkayiwa: Yes :) |
| 14:40:00 | <rfriedman> bwolfe, but my real question is, what is the justification for the singleton array? |
| 14:46:27 | *** cpower has quit IRC |
| 14:55:14 | *** cpower has joined #openmrs |
| 14:56:22 | *** lh is now known as lh_afk |
| 14:57:55 | *** harshadura has joined #openmrs |
| 15:01:24 | *** shortend has quit IRC |
| 15:04:34 | <goutham> dkayiwa: i will be back in 2 and half hour |
| 15:04:42 | <dkayiwa> goutham: ok |
| 15:07:13 | *** dkayiwa has quit IRC |
| 15:08:19 | *** dkayiwa has joined #openmrs |
| 15:11:46 | *** cpower has quit IRC |
| 15:12:00 | *** lh_afk is now known as lh |
| 15:12:55 | *** goutham has quit IRC |
| 15:15:29 | <djazayeri> bwolfe: can you please send a short email to the dev list, and probably implementers list too, in its own thread, with capital letters and high importance, telling people they need to be aware of github migration tomorrow. |
| 15:15:54 | <djazayeri> bwolfe: something like "If you have the OpenMRS codebase checked out, you need to read this message!" |
| 15:16:17 | <djazayeri> bwolfe: and ask to forward/pass it along to anyone they know who doesn't follow the dev/impl mailing lists, but should know this? |
| 15:16:32 | <djazayeri> time runs short |
| 15:24:09 | *** lh has quit IRC |
| 15:26:44 | *** robbyoconnor has quit IRC |
| 15:29:30 | *** nadee has joined #openmrs |
| 15:33:07 | <rfriedman> djazayeri, time runneth short |
| 15:34:22 | <bwolfe> djazayeri, sure |
| 15:34:50 | <bwolfe> djazayeri, I've operated under the assumption that if you care you read the dev list every once in a while...and we've had 1000 emails about this in the last 3 months |
| 15:35:18 | <djazayeri> bwolfe: per downey, a blog post is better |
| 15:40:36 | <bwolfe> djazayeri, a blog post is nice. and a good idea. but its not blanketing |
| 15:40:45 | <djazayeri> bwolfe: an email pointing to the blog post |
| 15:42:34 | <bwolfe> yes, that is necessary |
| 15:42:53 | <bwolfe> perhaps then another tweet pointing at the email pointing at the blog post. ;-) |
| 15:44:29 | *** sgithens has joined #openmrs |
| 15:46:27 | <djazayeri> bwolfe: no, that would be silly, the tweet can point at an rss feed which has the blog post. :-P |
| 15:55:15 | <djazayeri> bwolfe: I operate under the assumption that for really important things, we need to send multiple emails, and particularly start a NEW email thread in case of any muting/filtering/foldering/etc |
| 15:55:54 | *** cpower has joined #openmrs |
| 15:59:32 | *** rram_ has joined #openmrs |
| 16:00:45 | *** mvorobey has joined #openmrs |
| 16:00:50 | <mvorobey> hi all |
| 16:09:40 | *** rram_ has quit IRC |
| 16:14:10 | *** nadee has quit IRC |
| 16:14:26 | *** rram_ has joined #openmrs |
| 16:21:44 | *** rram_ has quit IRC |
| 16:41:48 | *** maurya has quit IRC |
| 16:44:08 | *** maurya has joined #openmrs |
| 16:45:12 | *** Maurya_ has joined #openmrs |
| 16:47:45 | *** mccallumg has joined #openmrs |
| 16:47:45 | *** ChanServ sets mode: +v mccallumg |
| 16:49:05 | *** maurya has quit IRC |
| 16:55:22 | *** diptanuc has joined #openmrs |
| 16:55:36 | <diptanuc> bwolfe: Around? |
| 16:57:47 | <bwolfe> hi diptanuc |
| 16:57:48 | <bwolfe> yes |
| 16:58:12 | *** cpower has quit IRC |
| 17:05:02 | *** Maurya_ is now known as maurya |
| 17:05:07 | *** ChanServ sets mode: +v maurya |
| 17:05:50 | <diptanuc> We are starting in a couple of minutes |
| 17:08:37 | <bwolfe> diptanuc, ok |
| 17:08:38 | *** suranga has joined #openmrs |
| 17:08:38 | *** ChanServ sets mode: +v suranga |
| 17:08:44 | <bwolfe> diptanuc, those other two tickets you listed looked fine too |
| 17:08:52 | <bwolfe> diptanuc, so any of the 6 you are thinking of should be fine |
| 17:08:58 | *** pulasthi7 has joined #openmrs |
| 17:09:05 | <bwolfe> diptanuc, how many devs do you have for this round? and how many repeats? |
| 17:10:21 | *** rob_m has joined #openmrs |
| 17:10:26 | <downey> Hi rob_m and welcome to the #openmrs IRC channel. |
| 17:10:53 | <diptanuc> bwolfe: We have 7 devs |
| 17:11:14 | <diptanuc> bwolfe: One two people are repeats from the first codejam! |
| 17:11:33 | <diptanuc> rob_m is my colleague and participating the codejam! |
| 17:11:44 | <diptanuc> bwolfe: This is rob_m's first OpenMRS codejam! |
| 17:11:54 | <bwolfe> welcome rob_m |
| 17:12:03 | <bwolfe> :-) |
| 17:12:11 | <downey> fantastic. :) |
| 17:14:53 | <rob_m> hi bwolfe :) |
| 17:15:15 | <suranga> hi pulasthi7 |
| 17:15:20 | *** kavuri has joined #openmrs |
| 17:15:26 | <pulasthi7> hi suranga |
| 17:15:34 | *** rfilippi has joined #openmrs |
| 17:15:52 | <suranga> pulasthi7, I saw you had merged into trunk today. Im sure you must have enjoyed that :-) |
| 17:16:13 | <dkayiwa> bwolfe: do we have a licence key for YourKit profiler? |
| 17:16:19 | <kavuri> bwolfe: in the REST GET command, is it possible to provide both a query and a representation together? With the ?q= and ?v= |
| 17:16:35 | <djazayeri> kavuri: yes, but the second should be a & |
| 17:16:46 | <djazayeri> e.g. GET patient?q=darius&v=FULL |
| 17:17:02 | <djazayeri> kavuri: just two different HTTP request parameters |
| 17:17:13 | <kavuri> djazayeri: thanks for the tip |
| 17:17:20 | <djazayeri> dkayiwa: ask downey about the license key. he'll tell you to create an ITSM ticket I think |
| 17:17:29 | <dkayiwa> djazayeri: ok |
| 17:17:31 | <pulasthi7> suranga, yes, i fixed those issues and meged the branch today. |
| 17:17:59 | <suranga> pulasthi7, did you try running the trunk after you had merged ? just to check if everything was ok ? |
| 17:18:13 | <bwolfe> dkayiwa, I think there is a wiki page about it saying that too |
| 17:18:31 | <dkayiwa> bwolfe: let me check |
| 17:19:21 | <pulasthi7> suranga, i didn't check it for a fresh copy. I'll check it out and have a check. |
| 17:20:06 | <suranga> pulasthi7, you could try preparing the vedio using the trunk. that way you could kill two birds with one stone |
| 17:20:41 | <suranga> pulasthi7, hows that progressing, by the way ? when will you plan to record the video ? |
| 17:20:52 | <downey> dkayiwa: what bwolfe said is true :) |
| 17:21:00 | <dkayiwa> bwolfe: a wiki page telling me to ask downey ? :) |
| 17:21:23 | <bwolfe> if ITSM == downey, yes. :-) |
| 17:21:34 | <dkayiwa> bwolfe: ok :) |
| 17:22:01 | *** lh has joined #openmrs |
| 17:22:01 | *** lh has joined #openmrs |
| 17:22:04 | <diptanuc> bwolfe: rfilippi is a codejammer too! |
| 17:22:33 | *** rafa_ has joined #openmrs |
| 17:22:36 | <pulasthi7> suranga, i had a rough go on timing today. I'll get it done today and tomorrow |
| 17:22:38 | <downey> welcome all code jammers! |
| 17:23:40 | <suranga> pulasthi7, cool. and after that, we'll have a final round of testing, and then a grand release party ! :) |
| 17:24:22 | <pulasthi7> :) |
| 17:29:25 | <kavuri> djazayeri: currently, a GET returns even null values in json message. Is it possible to not return null values? |
| 17:32:41 | <bwolfe> kavuri, the null/empty ones shoudl be left out |
| 17:34:03 | <kavuri> bwolfe: some are left out for some resources, but for resources like address, person, attributes with null values are returned |
| 17:34:19 | <bwolfe> kavuri, can you give an example? |
| 17:34:24 | <kavuri> bwolfe: e.g: {"lockoutTimestamp":"","loginAttempts":"0"},"person":{"uuid":"4aa97864-18ba-4fc5-967b-436363be9dca","display":"Annie Mark","gender":"F","age":18,"birthdate":"1994-08-04T00:00:00.000+0530","birthdateEstimated":false,"dead":false,"deathDate":null,"causeOfDeath":nul |
| 17:34:38 | <bwolfe> hmm |
| 17:34:42 | *** jordank has quit IRC |
| 17:34:52 | <kavuri> bwolfe: in address, I see even more null values being returned |
| 17:34:53 | <bwolfe> yes, those should be left out |
| 17:36:22 | <kavuri> bwolfe: maybe I can raise a ticket to track this? |
| 17:37:01 | <bwolfe> yeah, probably should |
| 17:42:03 | *** rafa_ has quit IRC |
| 17:44:20 | <kavuri> bwolfe: created issue RESTWS-287 |
| 17:55:32 | *** mvorobey has quit IRC |
| 17:55:41 | <bwolfe> thanks kavuri |
| 17:58:32 | <downey> djazayeri: fyi, bwolfe was writing something earlier |
| 18:00:22 | *** bwolfe has quit IRC |
| 18:03:21 | <djazayeri> downey: did you end the Design forum connect session recently on purpose? |
| 18:03:33 | <downey> djazayeri: no, nor at all |
| 18:03:41 | <djazayeri> Okay, nm |
| 18:03:53 | <downey> djazayeri: but you should be able to log in with your account and re-start it. |
| 18:04:08 | <djazayeri> downey: I did that, just wanted to make sure you weren't actively changing something |
| 18:04:08 | <djazayeri> thx |
| 18:04:14 | <downey> nope |
| 18:08:46 | *** bwolfe has joined #openmrs |
| 18:08:46 | *** ChanServ sets mode: +o bwolfe |
| 18:09:02 | *** torsten has joined #openmrs |
| 18:09:14 | <downey> Hi torsten and welcome to the #openmrs IRC channel. |
| 18:09:56 | <torsten> bwolfe: I am a codejammer, and working on 3628 |
| 18:10:04 | <bwolfe> welcome torsten |
| 18:10:10 | <bwolfe> !ticket TRUNK-3628 |
| 18:10:12 | <OpenMRSBot> bwolfe: [#TRUNK-3628] Hide the Preferred radio button on concept form - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3628 |
| 18:12:44 | <rfilippi> @bwolfe attempting to reproduce TRUNK-3608 - how do users become voided ? |
| 18:13:53 | <bwolfe> !ticket TRUNK-3608 |
| 18:13:55 | <OpenMRSBot> bwolfe: [#TRUNK-3608] Cannot edit user if name is null - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3608 |
| 18:14:32 | <bwolfe> rfilippi, its the name that is voided |
| 18:15:03 | *** diptanuc has quit IRC |
| 18:15:05 | <rfilippi> @bwolfe under the manage persons screen just seen that |
| 18:15:51 | <bwolfe> yes, that is where you can void them |
| 18:15:55 | <bwolfe> a user has an associated person |
| 18:15:59 | <bwolfe> and the person contains the names |
| 18:16:19 | <bwolfe> rfilippi, you might need to just edit the database person_name table to void all the names. (a validator might prevent it) |
| 18:16:38 | <rfilippi> @bwolfe ok will try that |
| 18:18:08 | *** dkayiwa has quit IRC |
| 18:19:07 | *** kavuri has quit IRC |
| 18:19:22 | *** dkayiwa has joined #openmrs |
| 18:20:16 | <torsten> bwolfe: We are trying to solve 3628 |
| 18:20:47 | <torsten> bwolfe: We are creating a new concept, and adding a synonym after the preferred name. |
| 18:21:19 | <torsten> bwolfe: Do we need to hide the radio buttons which is by the Preferred field? |
| 18:21:38 | <bwolfe> dkayiwa, want to chime in about TRUNK-3628? |
| 18:21:41 | <bwolfe> !ticket TRUNK-3628 |
| 18:21:43 | <OpenMRSBot> bwolfe: [#TRUNK-3628] Hide the Preferred radio button on concept form - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3628 |
| 18:22:07 | <dkayiwa> bwolfe: ok |
| 18:23:02 | <torsten> dkayiwa: If you could reproduce it for us on the demo server, it will be a good starting point for us |
| 18:23:15 | <bwolfe> torsten, I THINK you have it right. the radio button is the one int he "preferred" column. but if there is only one concept, no reason to mark it as "preferred" |
| 18:23:27 | <dkayiwa> torsten: ok |
| 18:23:54 | <dkayiwa> torsten: did you fail to reproduce it using the instructions Wyclif gave? |
| 18:24:17 | <torsten> dkayiwa: Yeah, on the view concept page i dont see any checked radio button |
| 18:24:59 | <rfilippi> @bwolfe we reproduced 3608 by voiding the only existing name in the db and then attempting to add/edit |
| 18:25:22 | <torsten> dkayiwa: http://demo.openmrs.org/openmrs/dictionary/concept.htm?conceptId=6099 |
| 18:25:38 | <torsten> dkayiwa: Take a look at this concept, we created it on the demo server |
| 18:26:57 | <dkayiwa> torsten: set only the fully specified name |
| 18:27:19 | *** pulasthi7 has quit IRC |
| 18:27:54 | <torsten> dkayiwa: Now we can see it, but only on the edit page |
| 18:28:05 | <torsten> dkayiwa: http://demo.openmrs.org/openmrs/dictionary/concept.form?conceptId=6099 |
| 18:28:32 | *** jkeiper_ has joined #openmrs |
| 18:29:12 | <torsten> dkayiwa: The radio button is not present in the view concept page http://demo.openmrs.org/openmrs/dictionary/concept.htm?conceptId=6099 |
| 18:29:55 | *** goutham has joined #openmrs |
| 18:30:11 | <torsten> dkayiwa: So i think the bug report says that the view page shows the radio button. So we got a little confused :) |
| 18:31:38 | <dkayiwa> torsten: yes it is on the edit |
| 18:31:50 | <dkayiwa> torsten: you can change the ticket description :) |
| 18:32:22 | <torsten> dkayiwa: Thanks mate! I think we know what to do now :) |
| 18:33:30 | <rfilippi> @bwolfe TRUNK-3608 so we're a bit more familiar with the problem, but not sure what the best fix is since it stems from a database inconsistency |
| 18:33:52 | <rfilippi> if all names are voided then you don't see any name in the list users view, |
| 18:34:00 | <rfilippi> but you see the preferred name in the add/edit users form |
| 18:34:09 | *** dkayiwa_ has joined #openmrs |
| 18:36:07 | *** dkayiwa has quit IRC |
| 18:36:07 | *** dkayiwa_ is now known as dkayiwa |
| 18:37:19 | <rfilippi> @bwolfe - ok, we've read the manual and we understand the fix that you'd like now |
| 18:39:31 | *** mvorobey has joined #openmrs |
| 18:42:55 | <bwolfe> rfilippi, :-) |
| 18:43:12 | <bwolfe> rfilippi, the fix is to make it not fail even if the db has bad data |
| 18:43:29 | <bwolfe> rfilippi, ...because bad data happens sometimes. no idea how it gets there, but it happens. :-) |
| 18:44:51 | *** lh is now known as lh_afk |
| 18:45:48 | *** rfriedman has quit IRC |
| 18:46:36 | <torsten> dkayiwa: We were able to reproduce the problem on the demo version but it seems to be working fine on our local trunk. Could you verify this with latest changes in trunk? |
| 18:47:20 | <dkayiwa> torsten: can you try creating a new concept once again on trunk? |
| 18:47:52 | <torsten> dkayiwa: on demo or on our local trunk? |
| 18:48:01 | <dkayiwa> torsten: trunk |
| 18:48:04 | *** jordank has joined #openmrs |
| 18:48:19 | <torsten> dkayiwa: ok ... |
| 18:49:26 | *** diptanuc has joined #openmrs |
| 18:49:41 | <diptanuc> bwolfe: We submitted the first patch of the evening! |
| 18:49:52 | <diptanuc> bwolfe: Could you please review it for us? |
| 18:50:01 | <bwolfe> which ticket? |
| 18:50:03 | <torsten> dkayiwa: we see it still working fine on our trunk. |
| 18:51:02 | *** tcowling has joined #openmrs |
| 18:51:08 | <downey> Hi tcowling and welcome to the #openmrs IRC channel. |
| 18:51:28 | *** mvorobey has quit IRC |
| 18:51:31 | <rob_m> hi bwolfe we're looking at this ticket https://tickets.openmrs.org/browse/TRUNK-3501 |
| 18:51:37 | <dkayiwa> torsten: maybe it was fixed but not back ported |
| 18:51:57 | <bwolfe> diptanuc, which ticket needs review? |
| 18:52:04 | <bwolfe> rob_m, ok, whats your question for it? |
| 18:52:15 | <rob_m> we've replicated and fixed the problem, but we're unsure about what is meant by moving to an annotated controller |
| 18:52:19 | *** mvorobey has joined #openmrs |
| 18:52:36 | *** rfriedman has joined #openmrs |
| 18:52:37 | <tcowling> bwolfe: hey Ben, we are having a codejam in Manchester, we've just finished with ticket number 3615, whats the next step? |
| 18:52:46 | <torsten> dkayiwa: we'll close the ticket then to keep it nice and clean. |
| 18:52:58 | <dkayiwa> torsten: no |
| 18:53:14 | <dkayiwa> it needs to be fixed on 1.9.0 |
| 18:53:18 | <torsten> dkayiwa: ok I'll hold. |
| 18:53:36 | <bwolfe> dkayiwa, torsten: can you confirm it doesn't work on 1.9.x branch? |
| 18:54:00 | <bwolfe> tcowling, https://tickets.openmrs.org/browse/TRUNK-3615 looks right |
| 18:54:11 | <bwolfe> you clicked the "request review" button and added a patch. |
| 18:54:13 | <bwolfe> :-) |
| 18:55:19 | <torsten> bwolfe: will check. |
| 18:55:38 | <tcowling> bwolfe: cool, hope its alright :) |
| 18:57:06 | <bwolfe> tcowling, I reviewed. you missed one point in the desc about the slash |
| 18:59:07 | <tcowling> bwolfe: ah ok, wasn't sure whether that was part of it, will fix it right now.. |
| 18:59:26 | *** maryam has joined #openmrs |
| 18:59:38 | <downey> Hi maryam and welcome to the #openmrs IRC channel. |
| 18:59:46 | <maryam> Hi bwolfe, I am codejammer and solving 3638 |
| 19:00:13 | <maryam> bwolfe: I understand what needs to be done, but i am not sure which changesets belongs to which OpenMRS release |
| 19:00:18 | <bwolfe> welcome maryam |
| 19:00:46 | *** diptanuc has quit IRC |
| 19:00:58 | <maryam> bwolfe: So i think we need to separate the huge changeset file. |
| 19:01:04 | <bwolfe> maryam, you'd have to look at the 1.9.x branch in svn. look at its liquibase file to see where it ends. anything after that in trunk (1.10) is for the sep file |
| 19:02:25 | <maryam> bwolfe: I see |
| 19:02:32 | <torsten> dkayiwa: which svn version equals to 1.9.x? |
| 19:02:37 | <maryam> bwolfe: Do I need to do it for the other releases as well? |
| 19:03:16 | <bwolfe> maryam, no, we'll just start doing this in trunk (for 1.10) |
| 19:03:23 | <dkayiwa> torsten: http://svn.openmrs.org/openmrs/branches/1.9.x/ |
| 19:03:52 | <bwolfe> maryam, there were a few things to test out in the ticket comments, iirc. so which changesets move over aren't strictly important yet. a feasibility test would be nice |
| 19:03:53 | <torsten> dkayiwa: ah ok, thank you! :) |
| 19:05:04 | <maryam> bwolfe: Ok. I was actually asking you if we should separate out the changesets for 1.5, 1.6 , 1.7, 1.8 as well? Or is it fine two have one file for 1.9 and below and another for anything above it? |
| 19:05:24 | <bwolfe> maryam, just 1.9 and below in one file |
| 19:05:45 | <maryam> bwolfe: Sure, makes it easy for us! |
| 19:08:59 | <rob_m> bwolfe: we're considering checking in the fix for the bug without doing the refactoring to annotated controller.. |
| 19:09:01 | *** scsibug has joined #openmrs |
| 19:09:28 | <bwolfe> rob_m, for which ticket? sorry, too many related tickets going on right now... |
| 19:09:34 | <rob_m> sorry - https://tickets.openmrs.org/browse/TRUNK-3501 |
| 19:09:59 | <torsten> dkayiwa, bwolfe : bug report 3628 is fixed on trunk 1.9.x |
| 19:10:05 | <bwolfe> rob_m, ok, thats allowed |
| 19:10:34 | <rob_m> bwolfe, thanks |
| 19:11:13 | <tcowling> bwolfe: code resubmitted to include / |
| 19:12:40 | <downey> codejammers++ |
| 19:14:24 | <torsten> bwolfe: bug report 3628 is fixed on trunk 1.9.x , should we check something else before closing the ticket? |
| 19:16:44 | *** james_regen has left #openmrs |
| 19:22:52 | *** jkeiper_ has quit IRC |
| 19:24:44 | *** mvorobey has quit IRC |
| 19:27:11 | *** pushkar has joined #openmrs |
| 19:27:28 | <pushkar> bwolfe, Hi |
| 19:28:13 | <pushkar> downey, hi |
| 19:29:08 | <downey> hi pushkar |
| 19:29:36 | <pushkar> downey, can the demo video be around 10 min ? |
| 19:29:45 | <downey> pushkar: 3 :) |
| 19:30:10 | <downey> pushkar: if you want to make a second one that's longer, that's ok. :) |
| 19:30:24 | *** rob_m has quit IRC |
| 19:30:34 | <pushkar> downey, okay :-) |
| 19:32:38 | <bwolfe> pushkar, we will only have enough time for each student to have 3 mins. so you will have to either take a 9 min video and speed it up 3x, or you make a short video for the call and a longer one for documentation |
| 19:34:47 | <bwolfe> torsten, dkayiwa, I don't think TRUNK-3628 is fixed in 1.9.x |
| 19:35:19 | <bwolfe> I updated the demo server to 1.9.1 (which is 1.9.x as of 2 days ago) |
| 19:35:32 | <bwolfe> this link still has the stray radio box |
| 19:35:33 | <bwolfe> http://demo.openmrs.org/openmrs/dictionary/concept.form?conceptId=6101 |
| 19:35:50 | *** maryam has quit IRC |
| 19:36:15 | *** torsten has quit IRC |
| 19:36:29 | <bwolfe> dkayiwa, do you see the radio box on that link? |
| 19:37:29 | <dkayiwa> bwolfe: yes i do |
| 19:38:45 | *** rfilippi has quit IRC |
| 19:40:50 | *** tcowling has quit IRC |
| 19:43:00 | *** lh_afk is now known as lh |
| 19:56:56 | *** jordank has quit IRC |
| 20:08:01 | *** scsibug has quit IRC |
| 20:08:56 | *** bwolfe has quit IRC |
| 20:10:29 | *** suranga has quit IRC |
| 20:24:24 | *** scsibug has joined #openmrs |
| 20:29:59 | *** jordank has joined #openmrs |
| 20:32:31 | *** mvorobey has joined #openmrs |
| 20:36:18 | *** sunbiz has joined #openmrs |
| 20:36:18 | *** ChanServ sets mode: +v sunbiz |
| 20:41:03 | <jordank> hi mccallumg, is it better to write unit tests for each of the private helper methods, or only the method calling them? |
| 20:41:52 | <mccallumg> hi jordank. private methods are lower priority |
| 20:44:19 | *** pushkar has quit IRC |
| 20:46:25 | <jordank> mccallumg: ok. so for all of my datatype checks, it would be fair to only test that preview method should redirect with the error message if the concepts are wrong.. even though it's using private helper methods to do it? |
| 20:47:16 | *** scsibug_ has joined #openmrs |
| 20:47:25 | <downey> Hi scsibug_ and welcome to the #openmrs IRC channel. |
| 20:50:54 | *** scsibug has quit IRC |
| 20:50:55 | *** scsibug_ is now known as scsibug |
| 20:56:38 | <mccallumg> jordank: fair or not. More like good and better. Depends on the time available. |
| 20:57:46 | <jordank> mccallumg: okay, thanks |
| 21:01:25 | <dkayiwa> hi goutham |
| 21:01:35 | <goutham> dkayiwa: Hi |
| 21:01:45 | <dkayiwa> goutham: just seen your email. please keep up the good work :) |
| 21:02:17 | <goutham> Sure dkayiwa :) |
| 21:02:44 | <goutham> dkayiwa: with your support i will always do |
| 21:02:46 | <goutham> :) |
| 21:02:56 | *** sunbiz has quit IRC |
| 21:03:05 | <dkayiwa> goutham: :D |
| 21:07:50 | <goutham> dkayiwa: i made the tests to skip compilation and uploaded to openmrs 1.7 . Still its giving me error |
| 21:08:12 | <dkayiwa> goutham: same error? |
| 21:09:18 | <goutham> dkayiwa: Almost similar :) http://pastebin.com/xqmZ7SsE |
| 21:10:06 | *** robbyoconnor has joined #openmrs |
| 21:10:06 | *** ChanServ sets mode: +v robbyoconnor |
| 21:10:19 | <dkayiwa> goutham: can you commit and i have a look at it? |
| 21:10:41 | <goutham> dkayiwa: ok 1min |
| 21:15:15 | <goutham> dkayiwa: made the commit |
| 21:15:21 | <dkayiwa> goutham: ok |
| 21:29:04 | *** snoppy has left #openmrs |
| 21:43:00 | *** mvorobey has quit IRC |
| 22:01:45 | *** rfriedman has quit IRC |
| 22:04:35 | *** dkayiwa_ has joined #openmrs |
| 22:05:38 | *** dkayiwa has quit IRC |
| 22:05:39 | *** dkayiwa_ is now known as dkayiwa |
| 22:10:37 | *** lh has quit IRC |
| 22:22:53 | *** scsibug has quit IRC |
| 22:23:47 | *** maurya has quit IRC |
| 22:31:18 | *** dkayiwa_ has joined #openmrs |
| 22:33:26 | *** dkayiwa has quit IRC |
| 22:33:26 | *** dkayiwa_ is now known as dkayiwa |
| 22:53:07 | *** mccallumg has quit IRC |
| 22:57:25 | <goutham> dkayiwa: der? |
| 22:57:50 | *** lh has joined #openmrs |
| 23:01:40 | *** goutham has quit IRC |
| 23:03:58 | *** lh has joined #openmrs |
| 23:03:58 | *** lh has joined #openmrs |
| 23:05:29 | *** dkayiwa has quit IRC |
| 23:34:48 | *** downey has quit IRC |
| 23:43:01 | *** bwolfe has joined #openmrs |
| 23:43:01 | *** ChanServ sets mode: +o bwolfe |
| 23:46:22 | *** jordank has quit IRC |
| 23:50:07 | *** lh has quit IRC |
| 23:52:03 | *** lh has joined #openmrs |