00:12:20
|
*** jordank has quit IRC
|
00:40:40
|
*** robbyoconnor has joined #openmrs
|
00:40:40
|
*** ChanServ sets mode: +v robbyoconnor
|
00:44:43
|
*** robbyoconnor has quit IRC
|
00:46:20
|
*** robbyoconnor has joined #openmrs
|
00:46:20
|
*** ChanServ sets mode: +v robbyoconnor
|
00:59:01
|
*** lh has joined #openmrs
|
00:59:01
|
*** lh has joined #openmrs
|
01:20:51
|
*** jordank has joined #openmrs
|
01:22:10
|
*** jordank has quit IRC
|
01:54:28
|
*** deepaganu has joined #openmrs
|
01:54:38
|
<deepaganu> hi robbyoconnor
|
01:55:05
|
<deepaganu> i am getting not ableto create a table while deploying a project
|
02:04:56
|
*** mseaton has joined #openmrs
|
02:04:56
|
*** ChanServ sets mode: +v mseaton
|
02:05:09
|
*** mseaton has left #openmrs
|
02:12:05
|
*** deepaganu has quit IRC
|
02:12:28
|
*** wyclif has joined #openmrs
|
02:14:23
|
*** bwolfe has joined #openmrs
|
02:14:23
|
*** ChanServ sets mode: +o bwolfe
|
02:23:57
|
*** harshadura has joined #openmrs
|
03:08:49
|
*** upul` has joined #openmrs
|
03:08:49
|
*** ChanServ sets mode: +v upul`
|
03:10:24
|
*** suranga has joined #openmrs
|
03:10:24
|
*** ChanServ sets mode: +v suranga
|
03:11:03
|
<suranga> hi bwolfe :)
|
03:11:18
|
<suranga> bwolfe, got a minute for a quick update ?
|
03:11:42
|
<bwolfe> sure
|
03:12:54
|
*** harshadura has quit IRC
|
03:15:14
|
<suranga> bwolfe, sorry, ddididnt see your reply...
|
03:15:59
|
<suranga> bwolfe, besically, now the controller is working, so wee need to work on getting a basic GET request to return a fully formatted hl7 message
|
03:16:20
|
<suranga> bwolfe, i was testing it yesterday, so far I got a partial message (PID + PVI) retrieved
|
03:17:07
|
<suranga> bwolfe, um... since theres only daniel and myself (partially) working this, I want tore-so my priorities for the last day of the sprint
|
03:17:39
|
<suranga> bwolfe, I want to ignore the UI (web pages) side of things, and focus on returning correctly parsed hl7 messages
|
03:17:48
|
<bwolfe> sounds good
|
03:17:48
|
<suranga> in both pipe delimited and xml format
|
03:17:55
|
<bwolfe> better to get it working than working pretty :-)
|
03:18:26
|
<suranga> bwolfe, umm.. how do you think our progrress has been ?
|
03:18:39
|
<bwolfe> good
|
03:18:44
|
<bwolfe> just one last step
|
03:45:04
|
*** lh has quit IRC
|
04:12:31
|
*** bwolfe has quit IRC
|
04:28:27
|
*** suranga_ has joined #openmrs
|
04:32:06
|
*** suranga has quit IRC
|
04:51:17
|
*** suranga_ has quit IRC
|
05:24:03
|
*** rram_ has joined #openmrs
|
06:13:01
|
*** shortend has joined #openmrs
|
06:15:17
|
*** shortend has quit IRC
|
06:15:53
|
*** shortend has joined #openmrs
|
06:18:44
|
*** shortend has quit IRC
|
06:42:33
|
*** dawn_ has joined #openmrs
|
06:42:33
|
*** ChanServ sets mode: +v dawn_
|
06:53:08
|
*** rram__ has joined #openmrs
|
06:53:09
|
*** rram_ has quit IRC
|
06:55:51
|
*** mgielow has joined #openmrs
|
07:06:02
|
*** suranga has joined #openmrs
|
07:06:14
|
*** ChanServ sets mode: +v suranga
|
07:07:11
|
*** shortend has joined #openmrs
|
07:09:39
|
*** harshadura has joined #openmrs
|
07:15:48
|
*** dkayiwa has joined #openmrs
|
07:32:30
|
*** dkayiwa has quit IRC
|
07:50:27
|
*** magoo_ has joined #openmrs
|
07:52:37
|
*** magoo_ has quit IRC
|
07:53:30
|
*** rafa has joined #openmrs
|
07:53:30
|
*** ChanServ sets mode: +v rafa
|
08:37:01
|
*** dawn__ has joined #openmrs
|
08:37:01
|
*** ChanServ sets mode: +v dawn__
|
08:39:24
|
*** dawn_ has quit IRC
|
08:39:24
|
*** dawn__ is now known as dawn_
|
09:02:19
|
<mgielow> hello
|
09:09:17
|
*** dkayiwa has joined #openmrs
|
09:09:21
|
<dkayiwa> hi suranga
|
09:12:42
|
<suranga> dkayiwa, helooooooo
|
09:12:46
|
<suranga> dkayiwa, good morning !
|
09:12:59
|
<suranga> dkayiwa, I saw you had commited that change, thanks !
|
09:13:13
|
<suranga> dkayiwa, what had you in mind for today ? I ask because I think I have a blocker...
|
09:18:39
|
<dkayiwa> suranga: was waiting for you to give me what next :)
|
09:18:49
|
<suranga> dkayiwa, https://tickets.openmrs.org/browse/HLQRY-47
|
09:19:20
|
<suranga> dkayiwa, i was tied up with my other projrct, so could not research this thoruoghtly
|
09:19:33
|
<dkayiwa> suranga: ok
|
09:19:38
|
<suranga> dkayiwa, i was hoping u could take a look at it
|
09:19:44
|
<dkayiwa> suranga: ok
|
09:20:18
|
<suranga> dkayiwa, this is a blocker. if it was solved, we have as output to show 4 the end of the sprint...
|
09:20:30
|
<dkayiwa> suranga: ok
|
09:20:47
|
<dkayiwa> suranga: i like blockers :)
|
09:31:59
|
<dkayiwa> hi suranga
|
09:32:11
|
<suranga> howdy dkayiwa
|
09:32:17
|
<dkayiwa> suranga: what should i put for the ORUR 01 Template global property?
|
09:32:26
|
<dkayiwa> suranga: it is empty on my system
|
09:32:39
|
<dkayiwa> suranga: shouldn't we provide a default?
|
09:32:55
|
<suranga> dkayiwa, the name of the ORUR01 parent template
|
09:33:01
|
<suranga> dkayiwa, i think its Generic ORUR01
|
09:33:17
|
<suranga> dkayiwa, yes, there should be a default, u are right :)
|
09:33:44
|
<dkayiwa> suranga: so will you create a ticket for that? or it does not require it? :)
|
09:34:02
|
<suranga> dkayiwa, it should be there, I wil create a ticket
|
09:34:09
|
<suranga> dkayiwa, in about 15 mins ? )
|
09:34:14
|
<dkayiwa> suranga: ok
|
09:36:21
|
<dkayiwa> suranga: why do we require idTypeUuid?
|
09:37:04
|
<suranga> dkayiwa, thats the UUID type of the identifier we use
|
09:37:08
|
*** dawn_ has quit IRC
|
09:37:14
|
<dkayiwa> suranga: is patientId the identifier or internal database id?
|
09:37:31
|
<dkayiwa> suranga: i had supplied an internal database id
|
09:37:35
|
<suranga> dkayiwa, aha.... its a patient identifier value
|
09:37:48
|
<suranga> dkayiwa, sorry, should have mentioned that :(
|
09:37:56
|
<dkayiwa> suranga: why don't we support the database id too?
|
09:38:47
|
*** dawn_ has joined #openmrs
|
09:38:47
|
*** ChanServ sets mode: +v dawn_
|
09:39:02
|
<suranga> dkayiwa, we could do that too, eventually. I always assumed that it was better to have patient identifiers instead :(
|
09:39:22
|
<suranga> dkayiwa, maybe we should talk to Ben, and consider putting that in too :)
|
09:39:50
|
*** dkayiwa has quit IRC
|
09:39:56
|
*** dkayiwa_ has joined #openmrs
|
09:49:14
|
<dkayiwa_> hi suranga
|
09:49:39
|
<dkayiwa_> suranga: am getting: org.openmrs.module.hl7query.HL7TemplateException: org.openmrs.module.hl7query.HL7TemplateException: groovy.lang.MissingPropertyException: No such property: implementationId for class: SimpleTemplateScript11
|
09:50:09
|
<dkayiwa_> suranga: is the unit test for the complete template working?
|
09:59:57
|
<suranga> dkayiwa_, ooos. it was working last night :(
|
10:00:04
|
<suranga> lets see...
|
10:31:08
|
*** dawn_ has quit IRC
|
10:35:20
|
*** upul` has quit IRC
|
10:47:20
|
*** Maurya_ has joined #openmrs
|
10:53:12
|
<suranga> howdy dkayiwa_ , i see u picked up 48..
|
10:53:20
|
<suranga> dkayiwa_, is this a blocker for 47 ?
|
10:53:49
|
<dkayiwa_> suranga: i just do not feel confident testing even when the unit test is failing :)
|
10:54:19
|
<suranga> dkayiwa_, you're the experianced guy, i'll take your word for it :)
|
10:54:32
|
<dkayiwa_> suranga: hahaha. we are all learning :)
|
10:55:04
|
*** snoppy has joined #openmrs
|
11:00:58
|
*** sunbiz has joined #openmrs
|
11:00:58
|
*** ChanServ sets mode: +v sunbiz
|
11:11:50
|
<dkayiwa_> suranga: are you testing on 1.9?
|
11:13:28
|
<dkayiwa_> hi rafa
|
11:13:34
|
<rafa> dkayiwa_: hi
|
11:13:43
|
<dkayiwa_> rafa: could you be knowing why there is no Concept.getUnits() in 1.9
|
11:13:53
|
<dkayiwa_> rafa: i see you used it in your hl7 template
|
11:14:03
|
<rafa> dkayiwa_: it's on ConceptNumeric
|
11:14:29
|
<dkayiwa_> rafa: am getting: org.openmrs.module.hl7query.HL7TemplateException: org.openmrs.module.hl7query.HL7TemplateException: groovy.lang.MissingMethodException: No signature of method: org.openmrs.Concept_$$_javassist_16.getUnits() is applicable for argument types: () values: []
|
11:14:29
|
<dkayiwa_> Possible solutions: getUuid(), getUuid(), getClass(), getNames(), getSet(), getNames()
|
11:14:57
|
<rafa> dkayiwa_: have you set the datatype to numeric on your concept?
|
11:15:14
|
<suranga> dkayiwa_, are you guys testing on 1.9 or 1.8.2 ?
|
11:15:24
|
<suranga> rafa, u tested on 1.8.2, isnt it ?
|
11:15:25
|
<dkayiwa_> rafa: am not running a unit test. am trying to send the module a GET request :)
|
11:15:32
|
<rafa> dkayiwa_: if yes, then you must pass ConceptNumeric not Concept
|
11:16:02
|
<dkayiwa_> rafa: am not the one passing it. its coming from the patient observations :)
|
11:16:18
|
<rafa> dkayiwa_: so check if the concept is correct
|
11:16:34
|
<dkayiwa_> rafa: do i even know which concept? :)
|
11:16:58
|
<rafa> dkayiwa_: hmmm you need to add some log info to figure out the id
|
11:17:06
|
<dkayiwa_> rafa: ok
|
11:17:37
|
<dkayiwa_> rafa: you have this test: if (conceptDatatype.isNumeric()) {
|
11:17:50
|
<dkayiwa_> rafa: so looks like it should be numeric. not so?
|
11:17:53
|
*** ibewes has quit IRC
|
11:18:08
|
<rafa> dkayiwa_: yes, but then I expect ConceptNumeric and not Concept
|
11:18:16
|
<rafa> dkayiwa_: the object of type ConceptNumberic
|
11:18:27
|
<rafa> dkayiwa_: apparently Concept is passed
|
11:18:37
|
<dkayiwa_> rafa: ok
|
11:19:07
|
*** james_regen has joined #openmrs
|
11:19:07
|
*** ChanServ sets mode: +v james_regen
|
11:27:06
|
*** applecool has joined #openmrs
|
11:27:06
|
*** ChanServ sets mode: +v applecool
|
11:27:13
|
<applecool> hi rafa
|
11:27:18
|
<rafa> applecool: hi
|
11:28:38
|
<applecool> how do i start with the METAREPO-8
|
11:28:55
|
<applecool> any tips rafa
|
11:29:00
|
<dkayiwa_> rafa: could this be a bug in OpenMRS?
|
11:29:02
|
<dkayiwa_> org.openmrs.module.hl7query.HL7TemplateException: org.openmrs.module.hl7query.HL7TemplateException: org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast object '5242' with class 'org.openmrs.Concept_$$_javassist_16' to class 'org.openmrs.ConceptNumeric'
|
11:29:22
|
<dkayiwa_> rafa: i checked and as per the interface, its datatype is numeric
|
11:29:37
|
<dkayiwa_> rafa: concept name is RESPIRATORY RATE
|
11:29:44
|
<rafa> dkayiwa_: is it stored as numeric in the database?
|
11:30:11
|
<rafa> dkayiwa_: when you open it in a concept dictionary does it have units specified?
|
11:30:13
|
<dkayiwa_> rafa: the database just stores conceptId of 5242
|
11:30:32
|
<dkayiwa_> rafa: no units
|
11:31:02
|
<rafa> dkayiwa_: so I would say it's wrong data in your concept dictionary
|
11:31:21
|
<rafa> dkayiwa_: if it's numeric it needs to have numeric values specified
|
11:31:37
|
<dkayiwa_> rafa: here it is: http://demo.openmrs.org/openmrs/dictionary/concept.htm?conceptId=5242
|
11:33:03
|
<rafa> dkayiwa_: what if you specify units there?
|
11:33:17
|
<dkayiwa_> rafa: let me try that
|
11:33:25
|
<rafa> dkayiwa_: or any other numeric value
|
11:33:37
|
<dkayiwa_> rafa: let me try that
|
11:35:26
|
<dkayiwa_> rafa: does the question mark test for if not null? obs.getConcept()?
|
11:35:35
|
<dkayiwa_> rafa: obx6ce1 = obs.getConcept()?.getUnits()
|
11:35:38
|
<rafa> dkayiwa_: yes
|
11:35:57
|
<dkayiwa_> rafa: so why would it still fail even when it has not units?
|
11:36:20
|
<rafa> dkayiwa_: because it tests only if concept is not null and
|
11:36:33
|
<rafa> dkayiwa_: if it's not then it call the getUnits method
|
11:36:41
|
<dkayiwa_> rafa: ok
|
11:37:01
|
<dkayiwa_> rafa: i tried cast the concept to ConceptNumeric and it did throw a cannot cast exception
|
11:37:19
|
<rafa> dkayiwa_: we could test if(concept instanceof ConceptNumeric)
|
11:37:20
|
<dkayiwa_> rafa: doesn't that look like openmrs is not instantiating a ConceptNumeric
|
11:37:35
|
<rafa> applecool: sorry busy right now
|
11:37:38
|
<dkayiwa_> rafa: would a cast fail and that passes?
|
11:37:54
|
<applecool> rafa: okay
|
11:37:59
|
<rafa> dkayiwa_: yes, it's not instantiating ConceptNumeric
|
11:38:04
|
<rafa> dkayiwa_: for some reason
|
11:38:13
|
<dkayiwa_> rafa: yes thats what i suspect too
|
11:38:16
|
<rafa> dkayiwa_: maybe because none of ConceptNumeric fields are set
|
11:38:29
|
<dkayiwa_> rafa: let me try fill them all
|
11:38:33
|
<rafa> dkayiwa_: and it's still stored as Concept and not ConceptNumeric
|
11:39:17
|
<dkayiwa_> rafa: i thought if the ui displays concept data type as numeric, it means it is stored as numeric. not so?
|
11:39:29
|
<rafa> applecool: not today
|
11:39:40
|
<applecool> rafa: oh
|
11:39:40
|
<rafa> dkayiwa_: it would make sense, but I'm not sure if that's true ;)
|
11:39:50
|
<dkayiwa_> rafa: hahaha :0
|
11:39:52
|
<dkayiwa_> :)
|
11:41:26
|
*** mvorobey has joined #openmrs
|
11:41:32
|
<mvorobey> hi all
|
11:41:43
|
<dkayiwa_> rafa: just checked the database and datatypeid = 1 (which is numeric)
|
11:42:03
|
<rafa> dkayiwa_: but is it stored in concept_numeric table?
|
11:42:44
|
<dkayiwa_> rafa: yes
|
11:42:51
|
<dkayiwa_> rafa: select * from concept_numeric where concept_id=5242
|
11:43:17
|
<rafa> dkayiwa_: then it looks like a bug that it's instantiated as Concept instead of ConceptNumeric
|
11:43:27
|
<rafa> dkayiwa_: where does that happen?
|
11:43:29
|
<dkayiwa_> rafa: makes sense
|
11:43:43
|
<dkayiwa_> rafa: let me debug to find out that :)
|
11:43:58
|
<rafa> dkayiwa_: we could work around it in a template
|
11:44:06
|
<dkayiwa_> rafa: aha
|
11:44:10
|
<dkayiwa_> rafa: how?
|
11:44:18
|
<rafa> dkayiwa_: if concept is numeric then Context.getConceptService().getConcept(id)
|
11:44:26
|
<rafa> dkayiwa_: it should return ConceptNumeric object
|
11:44:38
|
<dkayiwa_> rafa: ok thanks let me try that right away :)
|
11:45:24
|
<rafa> dkayiwa_: but we still need to find out why it's not instantiated as ConceptNumeric at the first place :)
|
11:45:33
|
<dkayiwa_> rafa: ok :)
|
11:47:27
|
*** maurya has joined #openmrs
|
11:47:54
|
*** ChanServ sets mode: +v maurya
|
11:59:47
|
<dkayiwa_> rafa: tried that and am getting: java.lang.ClassCastException: org.openmrs.Concept_$$_javassist_16 cannot be cast to org.openmrs.ConceptNumeric
|
12:00:19
|
<dkayiwa_> rafa: so return value from Context.getConceptService().getConcept cannot be cast to conceptnumeric
|
12:00:26
|
*** suranga has quit IRC
|
12:00:48
|
<rafa> dkayiwa_: that's interesting
|
12:01:24
|
*** rfriedman has joined #openmrs
|
12:01:54
|
<rfriedman> hi rafa, you there? got a few minutes?
|
12:02:18
|
<rafa> rfriedman: hi
|
12:02:29
|
<rafa> rfriedman: little busy
|
12:02:43
|
<rfriedman> ok, you want to set a time? I need to chat about concept map
|
12:03:20
|
<rfriedman> rafa ^
|
12:03:42
|
<rafa> rfriedman: let's try now
|
12:04:00
|
<rafa> rfriedman: I'll be switching contexts :D
|
12:04:27
|
*** jkeiper_ has joined #openmrs
|
12:04:31
|
<rfriedman> ok, so first, it's neither a data nor a metadata object, you can only add or purge it
|
12:05:19
|
<rfriedman> rafa, second, in 1.9, I didn't find any typical methods or privileges -- save, getall, get, get by uuid, purge
|
12:06:37
|
<rfriedman> rafa, did you create any of these? did they get lost in the branching to 1.9?
|
12:07:11
|
<rfriedman> rafa, or was it intentional, that there was some plan to redo this in 1.9?
|
12:08:08
|
<rafa> rfriedman: wyclif worked on these changes to concept mappings
|
12:08:47
|
<rafa> rfriedman: I don't know why they got lost
|
12:09:30
|
<rfriedman> ok, rafa, but you're last on the conceptmap pojo
|
12:09:51
|
<rafa> rfriedman: last?
|
12:10:14
|
<rfriedman> rafa, your name is on the active version
|
12:10:31
|
<rafa> rfriedman: you mean in svn history? :)
|
12:11:06
|
<rfriedman> rafa, think so, shows in the workspace list of Eclipse
|
12:11:24
|
<rfriedman> rafa, project explorer
|
12:12:11
|
<rafa> rfriedman: I did some small changes yes :)
|
12:12:39
|
<rafa> rfriedman: but I haven't redone the whole thing :)
|
12:12:51
|
<rfriedman> rafa, so you don't know why conceptmap has no retire/void?
|
12:13:22
|
<rfriedman> rafa, also wanted to coordinate this because you will have to deal with this in metadata sharing
|
12:13:33
|
<rfriedman> rafa, unless you don't use the API :)
|
12:13:38
|
*** bwolfe has joined #openmrs
|
12:13:38
|
*** ChanServ sets mode: +o bwolfe
|
12:14:17
|
<rafa> rfriedman: I don't know why it doesn't have void, and yes will want to add it for MDS purpose
|
12:14:40
|
<rfriedman> rafa, ok, i will work with wyclif and keep you informed
|
12:15:02
|
<rafa> rfriedman: good
|
12:15:34
|
*** applecool has quit IRC
|
12:15:48
|
<rfriedman> wyclif, hi, you really there? got a couple of minutes?
|
12:17:28
|
<dkayiwa_> hi bwolfe
|
12:18:05
|
<dkayiwa_> bwolfe: do you have any idea why the return value for: Context.getConceptService().getConcept(numericConceptId) cannot be cast to ConceptNumeric?
|
12:20:03
|
<rfriedman> dkayiwa_, hi, you an Eclipse user?
|
12:21:10
|
*** pushkar has joined #openmrs
|
12:23:35
|
<bwolfe> dkayiwa_, what kind of object is it then?
|
12:23:50
|
*** jkeiper_ has quit IRC
|
12:23:57
|
<sunbiz> rfriedman: hi, Im a Netbeans user!! :P
|
12:24:16
|
<rfriedman> sunbiz, no help to me :)
|
12:24:35
|
<rfriedman> bwolfe, you an eclipse user?
|
12:25:39
|
<bwolfe> rfriedman, yes
|
12:26:06
|
<rfriedman> bwolfe, how do I change working sets? Project>Build Working Sets>Select Working Set is greyed out
|
12:27:27
|
<mvorobey> rafa, hey
|
12:27:42
|
<mvorobey> rafa, how it's going with maintenance release ?
|
12:27:43
|
<rafa> mvorobey: hi
|
12:27:43
|
<rfriedman> hey gospodar, how's it going?
|
12:27:55
|
<rafa> mvorobey: testing
|
12:27:59
|
<rafa> mvorobey: not yet tagged
|
12:28:48
|
<mvorobey> rfriedman, hi, not bad, being on bug fixing swim lane is not so difficult as I thought :)
|
12:28:49
|
<sunbiz> rfriedman: Im just selling stuff u dont need :)
|
12:29:14
|
<rfriedman> sunbiz, you can sell me some pickled herring, i love it
|
12:29:27
|
<mvorobey> rafa, cool, that's great! go for it and release them :)
|
12:31:20
|
<dkayiwa_> bwolfe: it is Concept
|
12:31:40
|
<dkayiwa_> bwolfe: i tried casting to conceptnumeric and i get: am getting: java.lang.ClassCastException: org.openmrs.Concept_$$_javassist_16 cannot be cast to org.openmrs.ConceptNumeric
|
12:31:56
|
<sunbiz> rfriedman: too much charges on international shipping
|
12:33:40
|
<mvorobey> dkayiwa_, hey, what is new ?
|
12:34:04
|
<rfriedman> sunbiz, bring me a case to manila
|
12:35:34
|
*** shortend has quit IRC
|
12:43:52
|
<dkayiwa_> mvorobey: nothing much
|
12:43:57
|
<dkayiwa_> mvorobey: wazup
|
12:45:27
|
<mvorobey> dkayiwa_, just wanted to ask if you'll be able to help me with post-commit review on XFRM-90 ?
|
12:45:58
|
<dkayiwa_> mvorobey: i reviewed the patch before you applied it :0
|
12:45:59
|
<dkayiwa_> :)
|
12:46:11
|
<dkayiwa_> mvorobey: so you are good to go
|
12:46:19
|
<mvorobey> dkayiwa_, so we can close it :)
|
12:46:24
|
<mvorobey> dkayiwa_, thanks!
|
12:46:27
|
<dkayiwa_> mvorobey: yes
|
12:47:16
|
<bwolfe> dkayiwa_, hmm. what is the context here? where/why are you doing this?
|
12:47:33
|
<mvorobey> dkayiwa_, looks like that am restricted to close that ticket, can you do it for me ?
|
12:48:29
|
<bwolfe> dkayiwa_, is the concept also something else? Can you debug that and look at what the underlying type really is?
|
12:48:45
|
<dkayiwa_> bwolfe: we have a template which doe this: if (conceptDatatype.isNumeric()) { obx6ce1 = obs.getConcept()?.getUnits()
|
12:48:46
|
<bwolfe> dkayiwa_, is there a reason you don't want to do service.getConceptNumeric(id) ?
|
12:49:05
|
<bwolfe> dkayiwa_, ok
|
12:49:16
|
<dkayiwa_> bwolfe: service.getConceptNumeric(id) is enough for me
|
12:50:08
|
<mvorobey> bwolfe, hey, can you answer to my next question ?
|
12:50:53
|
<mvorobey> bwolfe, we've ticket TRUNK-3574, it's pretty simple, can we go with it without review ?
|
12:51:04
|
<mvorobey> !ticket TRUNK-3574
|
12:51:05
|
<OpenMRSBot> mvorobey: [#TRUNK-3574] Automated Error Report: MySQLIntegrityConstraintViolationException: Duplicate entry 117543-160167 for key PRIMARY - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3574
|
12:51:26
|
* bwolfe looks
|
12:52:06
|
<mvorobey> rafa, what do you think, we need this ticket available with maintenance releases, don't we ?
|
12:52:15
|
<bwolfe> mvorobey, did you run it? does that leave a blank row? or does it hide it and the row below it slide up?
|
12:52:43
|
<mvorobey> bwolfe, not yet, but will definitely do it very soon :)
|
12:52:57
|
<mvorobey> bwolfe, so review is unnecessary ...
|
12:53:59
|
<bwolfe> mvorobey, right. I prefer "display: none", because I think it treats it like its not there and html objects slide into where it was
|
12:54:24
|
<bwolfe> I think "visibility: hidden" will just make it invisibile, but the object still takes up space
|
12:55:50
|
*** mseaton has joined #openmrs
|
12:55:50
|
*** ChanServ sets mode: +v mseaton
|
12:56:06
|
<rafa> mvorobey: if you can back port it in the next hour it's fine. make sure to add fixVersions
|
12:56:16
|
*** mseaton has left #openmrs
|
12:56:22
|
<mvorobey> bwolfe, you're right, display none is much better
|
12:56:25
|
*** mgielow has quit IRC
|
12:56:36
|
<mvorobey> rafa, can I go for it right now ?
|
12:56:41
|
<rafa> mvorobey: sure
|
13:00:27
|
*** suranga has joined #openmrs
|
13:00:27
|
*** ChanServ sets mode: +v suranga
|
13:00:46
|
<mvorobey> rafa, started
|
13:01:49
|
<bwolfe> mvorobey, did you confirm? I might be wrong (that happens sometimes you know)
|
13:02:32
|
<mvorobey> bwolfe, launching webapp right now, got to switch to 1.10 version so it took some extra time :)
|
13:02:40
|
<bwolfe> mvorobey, ah yes
|
13:02:57
|
<bwolfe> mvorobey, you could also have just applied those 10 characters to your existing install
|
13:03:08
|
<bwolfe> or even directly to the jsp of one that was already running, then no reload is necessary
|
13:03:23
|
<mvorobey> bwolfe, just forgot it :)
|
13:03:39
|
<mvorobey> bwolfe, would not hurt if I rebuild app once more time :)
|
13:03:54
|
*** rram__ has quit IRC
|
13:04:21
|
<bwolfe> mvorobey, heh, only hurts your time :-)
|
13:04:29
|
*** rram_ has joined #openmrs
|
13:04:43
|
<mvorobey> bwolfe, yeah, but rafa gave me an hour :)
|
13:06:23
|
<suranga> hi dkayiwa_
|
13:06:30
|
<dkayiwa_> si suranga
|
13:06:33
|
<suranga> dkayiwa_, sorry im not being much of a help
|
13:06:42
|
<dkayiwa_> suranga: :)
|
13:06:45
|
*** jkeiper_ has joined #openmrs
|
13:06:48
|
<suranga> dkayiwa_, any luck with your buggie ? i see your updates..
|
13:07:11
|
<bwolfe> mvorobey, rafa is too generous ;-)
|
13:07:12
|
<dkayiwa_> suranga: now getting: ca.uhn.hl7v2.HL7Exception: java.lang.NullPointerException trying to set data type of OBX-5
|
13:07:41
|
<mvorobey> bwolfe, works as we expected, can I commit and backport it right now ?
|
13:07:53
|
<suranga> dkayiwa_, whats the data type u are trying to set ?
|
13:08:29
|
<bwolfe> mvorobey, go for it
|
13:08:35
|
<dkayiwa_> suranga: do i even know? :)
|
13:08:47
|
<mvorobey> bwolfe, will be done@
|
13:08:48
|
<rfriedman> dkayiwa_, what you don't know can't hurt you
|
13:08:49
|
<dkayiwa_> suranga: all am doing is the GET request through the controller
|
13:09:06
|
<dkayiwa_> rfriedman: hahahaha i love that :D
|
13:09:24
|
<suranga> dkayiwa_, you rare making a get on a patient, with no encounters, right ?
|
13:09:43
|
<rfriedman> wyclif, you still not there?
|
13:09:52
|
<suranga> dkayiwa_, umm.. there should have been validations on the templates to face such a scenario....i think...
|
13:09:54
|
<dkayiwa_> suranga: the patient has encounters
|
13:10:20
|
<dkayiwa_> suranga: for demo data, this is the patient with identifier 5858NT-7
|
13:10:48
|
<suranga> dkayiwa_, you should test using a patient with a single encounter, with Obs that you create yourself. I guess that will make bug fixing easier...
|
13:11:05
|
<bwolfe> mvorobey++
|
13:11:10
|
<dkayiwa_> suranga: ok let me do that
|
13:11:26
|
<dkayiwa_> suranga: and by the way the line where is occurs is this: hl7Output = hL7QueryService.renderPipeDelimitedHl7(hl7Output);
|
13:11:41
|
<suranga> dkayiwa_, start off with a patient with no encounters, then with an encounter but no obs,
|
13:11:53
|
<dkayiwa_> suranga: ok
|
13:11:53
|
<suranga> dkayiwa_, and finally, and encounter with obs..
|
13:12:01
|
<dkayiwa_> suranga: 8)
|
13:15:08
|
<dkayiwa_> suranga: patient without encounters returns: MSH|^~\&||OPENMRS|||20120810165719||ORU^R01^ORU_R01|689b11d1-a594-4cf8-aadb-2925f6f88b82|D^C|2.5^RWA|||||||||CLSM_V0.83
|
13:15:51
|
<suranga> umm... dkayiwa_ thats only the MSH segment, right ?
|
13:16:01
|
<suranga> the PID and PV1 are also missing ?
|
13:16:08
|
<dkayiwa_> suranga: ok
|
13:16:32
|
<suranga> dkayiwa_, ah, I get it, were extracting the patient object from the encounter, so no encounter == no PID + Pvi
|
13:16:37
|
<suranga> dkayiwa_, thats right, isnt it ?
|
13:16:42
|
<dkayiwa_> suranga: yes
|
13:16:45
|
<dkayiwa_> suranga: for (encounter in encounters) {
|
13:16:55
|
<dkayiwa_> suranga: thats after the MSH segment
|
13:16:58
|
<suranga> dkayiwa_, this is a problem, but lets fix this later
|
13:17:13
|
<dkayiwa_> suranga: ok now let me add an obs and see
|
13:17:14
|
<suranga> dkayiwa_, i'll add a ticket for that, to be worked on later..
|
13:17:20
|
<dkayiwa_> suranga: ok
|
13:19:09
|
<dkayiwa_> suranga: i added an obs which is not in an encounter and got the same
|
13:19:47
|
<suranga> dkayiwa_, thats cool, lets try a blanck encounter with no obs...
|
13:19:56
|
<dkayiwa_> suranga: ok
|
13:20:12
|
<rafa> bwolfe: do you recall why: // quick check to make sure we're only being called by ourselves
|
13:20:12
|
<rafa> //Class<?> callerClass = Reflection.getCallerClass(0);
|
13:20:12
|
<rafa> Class<?> callerClass = new OpenmrsSecurityManager().getCallerClass(0);
|
13:20:12
|
<rafa> if (!TimerSchedulerTask.class.isAssignableFrom(callerClass))
|
13:20:12
|
<rafa> throw new APIException("This method can only be called from the TimerSchedulerTask class, not "
|
13:20:12
|
<rafa> + callerClass.getName());
|
13:20:24
|
<rafa> in Deamon.executeScheduledTask
|
13:21:14
|
*** downey has joined #openmrs
|
13:21:14
|
*** ChanServ sets mode: +o downey
|
13:21:14
|
*** OpenMRSBot sets mode: +o downey
|
13:21:48
|
<rafa> bwolfe: it seems to cause schedule tasks to fail on 1.9
|
13:22:17
|
<dkayiwa_> suranga: encounter with no obs returns this:
|
13:22:18
|
<dkayiwa_> MSH|^~\&||OPENMRS|||20120810170425||ORU^R01^ORU_R01|fd62d26b-2de2-48a8-be79-63121c2b7b18|D^C|2.5^RWA|||||||||CLSM_V0.83 PID|1||111^^^^Old Identification Number||Martin^Testing^null PV1||0|c0937b97-1691-11df-97a5-7038c432aabf^^^Wishard Hospital|ADULTINITIAL|||dd552fc1-1691-11df-97a5-7038c432aabf^User^Super^^^^^^^^^^NID|||||||||||||||||||||||||||||||||||||20120810000000 OBR|0|||1238^MEDICAL RECORD
|
13:22:18
|
<dkayiwa_> OBSERVATIONS^TEST-IMPLEMENTATION||||||||||||||0|||||||||||^&&da15481d-c52d-4fcd-8328-eb3c29e4b4cd
|
13:22:57
|
<suranga> dkayiwa_, thats not baaad at allll :0
|
13:23:01
|
<rafa> bwolfe: event though the method is called from TimerScheduledTask
|
13:23:05
|
<suranga> I ment :)*
|
13:23:29
|
<suranga> dkayiwa_, BUT, if there are no obs, we dont need the OBSGROP tag (OBR) right ?
|
13:23:47
|
<dkayiwa_> suranga: you know that better than me :)
|
13:24:15
|
<suranga> dkayiwa_, if the encounter has no obs, i think its unnessesary to have that OBR segment...
|
13:24:23
|
<dkayiwa_> suranga: ok
|
13:24:28
|
<suranga> dkayiwa_, would that be a big change ? :(
|
13:24:45
|
<dkayiwa_> suranga: as long as you create a ticket for it :)
|
13:24:46
|
<rafa> bwolfe: I think it should be Class<?> callerClass = new OpenmrsSecurityManager().getCallerClass(1);
|
13:25:20
|
<suranga> dkayiwa_, cool, i'll do that (this time I really mean it :P)
|
13:25:21
|
<dkayiwa_> suranga: i can do it right away :)
|
13:25:34
|
<bwolfe> rafa, I don't know offhand if the list of classes starts at the current class or the previous one
|
13:25:53
|
<bwolfe> rafa, but if you are seeing it act a certain way, then feel free to fix it. :-)
|
13:26:03
|
<rafa> bwolfe: with 0 it's Deamon.class
|
13:26:14
|
<rafa> bwolfe: with 1 it's TimerSchedulerTask.class
|
13:26:32
|
<bwolfe> rafa, I trust you on that one
|
13:26:43
|
<rafa> bwolfe: I can fix it this way, but I don't understand why is that even being tested :P
|
13:26:47
|
<bwolfe> rafa, don't we have a unit test for htat? why is that not being caught?
|
13:27:01
|
<bwolfe> rafa, its a pseudo security check
|
13:27:10
|
<mvorobey> rafa, which fix versions should I use? 1.9.1 or 1.9.2 ?
|
13:27:15
|
<bwolfe> we don't want just anybody calling the Daemon methods to get full privileges
|
13:27:20
|
<rafa> mvorobey: 1.9.1
|
13:28:37
|
<rafa> bwolfe: we may have some tests proving that it doesn't work if you call it from some other class, but none proving it works form the TimerSchedulerTask :D
|
13:29:01
|
<suranga> dkayiwa_, i even assigned it to you https://tickets.openmrs.org/browse/HLQRY-50
|
13:29:09
|
<bwolfe> rafa, ha, fair point
|
13:29:09
|
<dkayiwa_> suranga: ok :)
|
13:29:23
|
<mvorobey> bwolfe, would not you mind do a quick post-commit review for https://tickets.openmrs.org/browse/TRUNK-3574 ?
|
13:31:13
|
<bwolfe> mvorobey, I see you changed to using "display". was I right in my guess earlier? what did using "visibility" look like?
|
13:31:17
|
<rafa> bwolfe: actually we do test both cases, need to look into that :(
|
13:33:07
|
<mvorobey> bwolfe, CSS rule visibility only deals with the visibility of the element, nothing more
|
13:34:06
|
<bwolfe> mvorobey, ok, good, so I was right. :-)
|
13:36:50
|
<mvorobey> bwolfe, thanks for closing!
|
13:37:05
|
<bwolfe> np
|
13:37:09
|
<bwolfe> thanks for committing!
|
13:37:10
|
<bwolfe> :-)
|
13:37:14
|
<bwolfe> mvorobey++
|
13:37:18
|
<mvorobey> dkayiwa_, can you close XFRM-90 because I do not have rights for this!
|
13:37:32
|
<bwolfe> if I could give one karma point to mvorobey for each ticket closed this week...
|
13:37:34
|
<bwolfe> !karma mvorobey
|
13:37:34
|
<OpenMRSBot> bwolfe: Karma for "mvorobey" has been increased 4 times and decreased 0 times for a total karma of 4.
|
13:37:47
|
<dkayiwa_> !ticket XFRM-90
|
13:37:48
|
<OpenMRSBot> dkayiwa_: [#XFRM-90] Timeouts on download of large cohorts - OpenMRS JIRA - https://tickets.openmrs.org/browse/XFRM-90
|
13:37:53
|
<dkayiwa_> mvorobey:++
|
13:38:08
|
<mvorobey> bwolfe, :)
|
13:39:43
|
<bwolfe> !karma mvorobey:
|
13:39:43
|
<OpenMRSBot> bwolfe: Karma for "mvorobey:" has been increased 1 time and decreased 0 times for a total karma of 1.
|
13:39:49
|
<bwolfe> dkayiwa_ ^^
|
13:40:01
|
<dkayiwa_> :)
|
13:40:09
|
<bwolfe> mvorobey++
|
13:40:11
|
<bwolfe> !=
|
13:40:12
|
<OpenMRSBot> bwolfe: Error: "=" is not a valid command.
|
13:40:14
|
<bwolfe> mvorobey:++
|
13:40:36
|
<mvorobey> bwolfe, hey, I think that it's enough for me :)
|
13:40:42
|
<mvorobey> bwolfe:++
|
13:41:04
|
<bwolfe> no colon!
|
13:41:13
|
<bwolfe> dkayiwa_, see the bad example you're setting? :-p
|
13:41:19
|
<bwolfe> mvorobey--
|
13:41:25
|
<bwolfe> dkayiwa_--
|
13:41:27
|
<bwolfe> err,
|
13:41:30
|
<bwolfe> dkayiwa--
|
13:41:30
|
<dkayiwa_> bwolfe: hahaha :D
|
13:42:03
|
<dkayiwa_> mvorobey: be a good boy d:)
|
13:42:29
|
<mvorobey> bwolfe++
|
13:42:33
|
<mvorobey> bwolfe++
|
13:42:40
|
<mvorobey> !karma bwolfe
|
13:42:40
|
<OpenMRSBot> mvorobey: Karma for "bwolfe" has been increased 133 times and decreased 29 times for a total karma of 104.
|
13:43:07
|
<mvorobey> !karma dkayiwa_
|
13:43:07
|
<OpenMRSBot> mvorobey: Karma for "dkayiwa_" has been increased 0 times and decreased 1 time for a total karma of -1.
|
13:43:26
|
<mvorobey> dkayiwa_, we need to fix it asap :D
|
13:43:31
|
<mvorobey> dkayiwa_++
|
13:43:32
|
<mvorobey> dkayiwa_++
|
13:43:33
|
<mvorobey> dkayiwa_++
|
13:43:34
|
<mvorobey> dkayiwa_++
|
13:43:34
|
<mvorobey> dkayiwa_++
|
13:43:38
|
<mvorobey> !karma dkayiwa_
|
13:43:38
|
<OpenMRSBot> mvorobey: Karma for "dkayiwa_" has been increased 5 times and decreased 1 time for a total karma of 4.
|
13:43:40
|
<dkayiwa_> mvorobey: thats not me :)
|
13:43:55
|
<pushkar> hi bwolfe
|
13:44:11
|
<dkayiwa_> mvorobey: didnt you see when bwolfe fixed it above without the _ :)
|
13:44:24
|
<dkayiwa_> mvorobey: after the err :D
|
13:44:29
|
<mvorobey> dkayiwa_, really ? :)
|
13:44:36
|
<dkayiwa_> oh ya :)
|
13:44:51
|
<mvorobey> dkayiwa_, btw, thanks for closing XFRM-90
|
13:45:23
|
<dkayiwa_> mvorobey: thanks too for applying the patch, and also increasing karma for a GHOST dkayiwa_ :)
|
13:46:00
|
<mvorobey> dkayiwa_, hahahaha :D
|
13:49:36
|
<mvorobey> bwolfe, hey, I gotta run, may I go with my scrum update now ?
|
13:50:01
|
<suranga> mvorobey, please do increase my karma scores too :)
|
13:50:07
|
<suranga> !karma suranga
|
13:50:07
|
<OpenMRSBot> suranga: Karma for "suranga" has been increased 6 times and decreased 2 times for a total karma of 4.
|
13:50:19
|
<bwolfe> suranga++
|
13:50:20
|
<bwolfe> suranga++
|
13:50:20
|
<bwolfe> suranga++
|
13:50:20
|
<bwolfe> suranga++
|
13:50:25
|
<bwolfe> mvorobey, sure, go ahead
|
13:51:34
|
<mvorobey> so, my scrum begins
|
13:51:38
|
<mvorobey> * Backported and prepared for closing - TRUNK-3668
|
13:51:38
|
<mvorobey> * Recreated the patch, committed, backported and completed - TRUNK-3574
|
13:51:38
|
<mvorobey> * Applied patch for XFRM-90, prepared ticket for closing
|
13:51:38
|
<mvorobey> No blockers
|
13:51:45
|
<mvorobey> my scrum ends
|
13:54:57
|
<mvorobey> bwolfe, dkayiwa_, rafa, djazayeri: gotta run, thanks for helping me with bug fixing swim lane!
|
13:55:15
|
<rafa> mvorobey++
|
13:55:32
|
<rafa> mvorobey: good job!
|
13:56:02
|
<dkayiwa_> mvorobey: sure :D
|
13:56:26
|
<mvorobey> thanks, bye!
|
13:56:46
|
*** mvorobey has quit IRC
|
13:57:05
|
<rfriedman> wyclif, you there yet?
|
13:58:01
|
<rafa> bwolfe: seems like for some reason OpenmrsSecurityManager appears twice when running in a webapp on the stacktrace, thus the wrong class is picked
|
13:58:08
|
<rafa> bwolfe: works fine in unit tests
|
13:58:51
|
<rafa> bwolfe: will it be good enough to see if instanceof TimerSchedulerTask is somewhere on the stacktrace?
|
13:58:52
|
<bwolfe> rafa, very weird
|
13:59:16
|
<rafa> bwolfe: I think SecurityManager may do some additional call
|
13:59:27
|
<bwolfe> rafa, instead of going that broad, I'd rather we say that "TimerSchedulerTask" is the first one or the first one after "securitymanager"
|
13:59:44
|
<rafa> bwolfe: ok
|
14:00:34
|
*** shortend has joined #openmrs
|
14:00:46
|
<shortend> Also, Tomcat is running with openjdk
|
14:01:00
|
<shortend> Maybe we should try with the official one.
|
14:01:08
|
<rfriedman> bwolfe, what modality would you like to use for code review? is skype with each looking at their own crucible page OK?
|
14:01:25
|
<bwolfe> shortend?
|
14:01:26
|
<shortend> Oops.
|
14:01:29
|
<shortend> Haha
|
14:01:32
|
<shortend> Sorry...
|
14:02:03
|
*** lh has joined #openmrs
|
14:02:09
|
<suranga> dkayiwa_, youureee faaast !
|
14:02:11
|
<bwolfe> rfriedman, sure. I don't know what I'm looking at yet. can you send me a link to the review I should look at?
|
14:02:21
|
<bwolfe> !seen cpower
|
14:02:21
|
<OpenMRSBot> bwolfe: cpower was last seen in #openmrs 18 hours, 37 minutes, and 28 seconds ago: <cpower> !scrumoff
|
14:03:10
|
<dkayiwa_> suranga: yes for very very small and tiny tickets :)
|
14:03:27
|
*** lakkarau has joined #openmrs
|
14:03:41
|
<suranga> dkayiwa_, aha ! but what happens when we make a GET on an encounter WITH obs ? :):)
|
14:04:05
|
<dkayiwa_> suranga: let me do that now
|
14:04:15
|
<rfriedman> bwolfe, CR-MOD-497, sandeep sent us an e-mail
|
14:04:34
|
<rfriedman> bwolfe, do you not get notified about reviews you are on?
|
14:04:38
|
<bwolfe> rfriedman, looks like he only added me ot the review. no direct email
|
14:04:56
|
<bwolfe> rfriedman, I do, but I get so many I ignore them until I have time to go through them all :-)
|
14:05:14
|
<rfriedman> bwolfe, ignorance is bliss
|
14:05:43
|
<bwolfe> true
|
14:06:40
|
<dkayiwa_> suranga: with one obs for WEIGHT (KG) i get this:
|
14:06:41
|
<dkayiwa_> MSH|^~\&||OPENMRS|||20120810174857||ORU^R01^ORU_R01|24299084-b8db-449e-a297-c816c1fe6e95|D^C|2.5^RWA|||||||||CLSM_V0.83 PID|1||222^^^^Old Identification Number||Catherine^Suranga^null PV1||0|c0937b97-1691-11df-97a5-7038c432aabf^^^Wishard Hospital|ADULTINITIAL|||dd552fc1-1691-11df-97a5-7038c432aabf^User^Super^^^^^^^^^^NID|||||||||||||||||||||||||||||||||||||20120810000000 OBR|0|||1238^MEDICAL RECORD
|
14:06:41
|
<dkayiwa_> OBSERVATIONS^TEST-IMPLEMENTATION||||||||||||||0|||||||||||^&&c9152f16-ac12-4823-90ee-750f2846554e OBX|1|NM|5089^WEIGHT (KG)^TEST-IMPLEMENTATION||67.3|kg^^UCUM||||||||20120810174843
|
14:06:55
|
<rfriedman> bwolfe, i am roxanne.feline on skype
|
14:07:11
|
<bwolfe> should I ask why?
|
14:07:27
|
<rfriedman> you want to hear about that night in Singapore?
|
14:07:34
|
<bwolfe> request sent
|
14:07:45
|
<suranga> dkayiwa_, hm.. I can see anything wrong with it (to the naked eye)
|
14:07:50
|
<bwolfe> rfriedman, I don't believe that is the true reason behind it...
|
14:08:03
|
<dkayiwa_> suranga: anything or something :)
|
14:08:12
|
<suranga> dkayiwa_, does adding a obs add another line to the Hl7 message ?
|
14:08:32
|
<dkayiwa_> suranga: do you mean i should make it two obs?
|
14:08:32
|
<rfriedman> bwolfe, it is another story there will probably never be enough time for
|
14:08:43
|
<suranga> dkayiwa_, shall we try that ?
|
14:08:52
|
<dkayiwa_> suranga: ok doing that right now
|
14:09:01
|
<suranga> dkayiwa_, and after that, an eocunter with two OBS groupings :)
|
14:09:10
|
<dkayiwa_> suranga: ok :)
|
14:09:41
|
<bwolfe> rfriedman, I'll wait for your memoirs to come out
|
14:10:17
|
*** wyclif has quit IRC
|
14:10:38
|
*** sandeep_ has joined #openmrs
|
14:10:49
|
<rfriedman> bwolfe, i no longer remember anything from before i got married
|
14:11:56
|
<djazayeri> hey, are we scrumming?
|
14:12:11
|
<dkayiwa_> suranga: with two obs, here wego:
|
14:12:12
|
<dkayiwa_> MSH|^~\&||OPENMRS|||20120810175407||ORU^R01^ORU_R01|3c54f78a-1796-40de-a70f-d5ad64c26b2a|D^C|2.5^RWA|||||||||CLSM_V0.83 PID|1||333^^^^Old Identification Number||TwoObs^Suranga^Catherine PV1||0|c0937f0c-1691-11df-97a5-7038c432aabf^^^Chulaimbo|ADULTINITIAL|||dd552fc1-1691-11df-97a5-7038c432aabf^User^Super^^^^^^^^^^NID|||||||||||||||||||||||||||||||||||||20120810000000 OBR|0|||1238^MEDICAL RECORD
|
14:12:12
|
<dkayiwa_> OBSERVATIONS^TEST-IMPLEMENTATION||||||||||||||0|||||||||||^&&ff7986e8-b647-421f-92de-ce36aea5b2d5 OBX|1|NM|5090^HEIGHT (CM)^TEST-IMPLEMENTATION||24.2|cm^^UCUM||||||||20120810175355 OBX|2|NM|5089^WEIGHT (KG)^TEST-IMPLEMENTATION||23.1|kg^^UCUM||||||||20120810175355
|
14:13:07
|
<suranga> dkayiwa_, are u getting these from GET requests, or unit tests ?
|
14:13:24
|
<dkayiwa_> suranga: using this url: http://localhost:8081/openmrs-standalone/module/hl7query/ORUR01.htm?patientId=333&idTypeUuid=8d79403a-c2cc-11de-8d13-0010c6dffd0f
|
14:13:49
|
<suranga> dkayiwa_, cool. shall I list out the other scenarios we need working ?
|
14:13:57
|
*** harshadura has quit IRC
|
14:13:58
|
<dkayiwa_> suranga: ok
|
14:13:59
|
<suranga> dkayiwa_, 1) an encounter with grouped obs only
|
14:14:16
|
<suranga> dkayiwa_, 2) encounter with both grouped and ungrouped obs
|
14:14:26
|
<suranga> dkayiwa_, multiple obs in single request
|
14:14:33
|
*** sandeep_ has quit IRC
|
14:15:04
|
<suranga> dkayiwa_, and assuming that all these work, can you please take a look at wether the parsing to XML also works :):)
|
14:15:28
|
<dkayiwa_> suranga: what do you mean by parsing to xml?
|
14:16:25
|
*** lakkarau has quit IRC
|
14:16:30
|
*** lakkarau_ has joined #openmrs
|
14:17:51
|
<bwolfe> djazayeri, was waiting for chris, then got distracted. lets scrum here quickly
|
14:17:55
|
<bwolfe> !scrumon bwolfe
|
14:17:55
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster bwolfe- you may begin when ready.
|
14:18:27
|
<bwolfe> today's order: djazayeri, lakkarau_, bwolfe, rafa, dkayiwa_, (and mvoroby already left)
|
14:19:01
|
<djazayeri> Same report as all week for me
|
14:19:02
|
<djazayeri> All week
|
14:19:02
|
<djazayeri> * OpenMRS Calls
|
14:19:02
|
<djazayeri> * I-TECH work
|
14:19:02
|
<djazayeri> * sporadic code reviews and ticket comments
|
14:19:03
|
<djazayeri> No blockers
|
14:19:14
|
<lakkarau_> bwolfe:nothing much working on HLQRY-26 and TRUNK-3589.No Blockers
|
14:19:45
|
*** judygichoya has joined #openmrs
|
14:20:21
|
<bwolfe> lakkarau_, you've been working on those for 3 days. there must be blockers... :-/
|
14:21:01
|
<bwolfe> Thursday
|
14:21:01
|
<bwolfe> dev call
|
14:21:01
|
<bwolfe> ldrship call
|
14:21:01
|
<bwolfe> review sprint tickets
|
14:21:01
|
<bwolfe> reviewed tickets for mykola
|
14:21:02
|
<bwolfe> week in review with paul/burke
|
14:21:04
|
<bwolfe> emails, omg, the emails
|
14:21:06
|
<bwolfe> Friday
|
14:21:10
|
<bwolfe> emails
|
14:21:12
|
<bwolfe> review with Sandeep/Roger
|
14:21:14
|
<bwolfe> dev call planning with Burke/Darius
|
14:21:16
|
<bwolfe> reviewed commits by Mvoroby/Rafal
|
14:21:18
|
<bwolfe> (half day again)
|
14:21:20
|
<bwolfe> no blockers
|
14:21:22
|
<bwolfe> rafa?
|
14:21:25
|
<rafa> Today:
|
14:21:25
|
<rafa> * Finished back porting tickets for maintenance releases.
|
14:21:26
|
<rafa> * Currently testing 1.9.1.
|
14:21:26
|
<rafa> * Tag 1.9.1 and 1.8.4.
|
14:21:26
|
<rafa> Tomorrow:
|
14:21:26
|
<rafa> * Tag 1.7.4 and 1.6.6
|
14:21:26
|
<rafa> * Should I delete 1.6.x branch after tagging 1.6.6 EOL?
|
14:21:27
|
<rafa> No blockers.
|
14:21:40
|
<dkayiwa_> Committed a fix for: Create a 'Manage Templates' admin page for the hl7query table - HLQRY-11
|
14:21:40
|
<dkayiwa_> Committed: If the Encounter being retrieved has no obs, then do not include an OBR segment in the hl7 message - HLQRY-50
|
14:21:41
|
<dkayiwa_> Committed: Fix No such property: implementationId for class: SimpleTemplateScript11 when doing a GET request - HLQRY-49
|
14:21:41
|
<dkayiwa_> Now looking into: Making a GET request on the hl7query module results in an out of memory error - HLQRY-47
|
14:21:41
|
<dkayiwa_> No Blockers
|
14:21:45
|
<rafa> It should be * Will tag
|
14:22:05
|
<djazayeri> rafa: no, you should not delete the 1.6.x branch
|
14:22:31
|
<lakkarau_> bwolfe:some times yes ,but now i dont have a blocker.regarding the Location Service I need to discuss with you and proceed coding i think it should be finished today.
|
14:22:40
|
<rafa> djazayeri: ok
|
14:23:04
|
<djazayeri> rafa: it's just no longer supported by the core team, but other community members are still allowed to push bugfixes into on their own time.
|
14:23:33
|
<bwolfe> djazayeri, please discuss blockers at the end. ;-)
|
14:23:44
|
<djazayeri> okay
|
14:23:46
|
<djazayeri> apologies
|
14:23:47
|
<bwolfe> dkayiwa_?
|
14:24:24
|
<dkayiwa_> bwolfe: ???
|
14:24:29
|
<rafa> djazayeri: right just saw we still have 1.5.x and 1.4.x :)
|
14:25:04
|
<dkayiwa_> bwolfe: does your irc window scroll? :D
|
14:25:44
|
<dkayiwa_> i think you forgot suranga :)
|
14:25:56
|
<suranga> dkayiwa_, bwolfe :):)
|
14:26:22
|
<suranga> yesterday : basic fixes, testing
|
14:26:29
|
<bwolfe> dkayiwa_, oh, missed yours above! :-)
|
14:26:45
|
<dkayiwa_> bwolfe: am used to that :)
|
14:26:46
|
<suranga> today: working on getting the final (working version out) this involves annoying Daniel a lot
|
14:26:50
|
<bwolfe> dkayiwa_, haha, yes, it does scroll. its just I haven't figured out how to use that feature. ;-)
|
14:26:58
|
<suranga> blockers : none, other than outstanding tickets...
|
14:26:58
|
*** rram_ has quit IRC
|
14:27:04
|
<dkayiwa_> bwolfe: :D
|
14:27:32
|
*** rram_ has joined #openmrs
|
14:27:45
|
<bwolfe> dkayiwa_, suranga, thanks ahead of time for putting in the effort to get a releasable version!
|
14:27:58
|
<bwolfe> !scrumoff
|
14:27:58
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:28:06
|
<bwolfe> discussion points:
|
14:28:19
|
<dkayiwa_> bwolfe: thats unfair. a number of other people, you inclusive, have worked towards that :)
|
14:28:40
|
<bwolfe> rafa, about 1.6.x: what djazayeri said. we aren't deleting the EOL branches
|
14:28:57
|
<suranga> dkayiwa_, i will pass on my share of the praise to you :P
|
14:29:02
|
<bwolfe> dkayiwa_, yes, but now you have the hard part of finding all the little bugs and getting it going
|
14:29:04
|
<judygichoya> quick question â¦
|
14:29:13
|
<bwolfe> dkayiwa_, suranga, I fear it might take some of the weekend. :-(
|
14:29:13
|
<dkayiwa_> bwolfe: oh i see :)
|
14:29:27
|
<dkayiwa_> bwolfe: no shortcut for that
|
14:29:32
|
<judygichoya> can the hl7query module be used for orders?
|
14:29:58
|
<suranga> judygichoya, for orders ? umm.. does that involve and ORUR01 message ?
|
14:30:03
|
<judygichoya> in my understanding now it looks like it is mainly for converting encounters/obs to hl7 messages for sending
|
14:30:28
|
*** lakkarau_ has quit IRC
|
14:30:33
|
<suranga> judygichoya, yes, currently only ORUR01 is supported, but can be expanded for any message type..
|
14:30:48
|
<suranga> dkayiwa_, hi,
|
14:30:49
|
<suranga> I found out that you have already claimed this ticket.
|
14:30:49
|
<suranga> https://tickets.openmrs.org/browse/HLQRY-8
|
14:30:49
|
<suranga> if you look at the description, you will see the part about using the location header to parse the xml string into either XML or pipe delimited (what you're doing now)
|
14:30:49
|
<suranga> if the users want xml, we need to take the string, and encode it to xml, and output.
|
14:30:50
|
<bwolfe> judygichoya, suranga, there is one ticket for making a generic controller. that generic controller would allow the user to call any template. that way any template you could design would be possible
|
14:30:51
|
<suranga> The code to do this looks is attached as a comment to ticket 8
|
14:31:32
|
<suranga> judygichoya, there is an alternative to that :0
|
14:31:38
|
<bwolfe> the "encode to xml" basically just means "don't call the 'convertToPipes' method", right ?
|
14:31:51
|
<judygichoya> ahhh
|
14:32:06
|
<judygichoya> the ORU is observation result only...
|
14:32:20
|
<suranga> judygichoya, if you write, say an ADT parent template, and store it in the DB, you can specify it as your default parent template cia a global property
|
14:32:24
|
<judygichoya> will the generic encoder be part of the release...
|
14:32:27
|
<dkayiwa_> suranga: i though xml is what hL7QueryService.evaluateTemplate(template, bindings); returns????
|
14:32:32
|
<suranga> that way, you can call it, and it will work as normal
|
14:32:57
|
<dkayiwa_> suranga: and we only call hL7QueryService.renderPipeDelimitedHl7(hl7Output when we want convert it into pipe delimted???
|
14:33:35
|
<suranga> dkayiwa_, bwolfe we're writing xml using groovy. so theartically, it would be valid hl7. what I ment was, before sending that out to the user, we should parse it to xml formatted HAPI, so that its 'validated'
|
14:34:13
|
<bwolfe> suranga, nah
|
14:34:17
|
<dkayiwa_> suranga: would the output xml be different?
|
14:34:27
|
<dkayiwa_> suranga: from the input?
|
14:35:01
|
<suranga> dkayiwa_, bwolfe it depends on what groovy templates people may write.. if they write dangerous templates, then they may end up in trouble without validation...
|
14:35:53
|
<suranga> ooops. guys, got to disapear for a while, sorry about this... :-\
|
14:35:57
|
<dkayiwa_> suranga: but should that be part of that ticket?
|
14:35:57
|
<bwolfe> suranga, who cares? thats their problem!
|
14:36:11
|
<bwolfe> if we don't validate, then the tool is more powerful! can be used for things other than hl7!
|
14:36:18
|
<bwolfe> if you really want validation, do it at template save time
|
14:36:45
|
<dkayiwa_> suranga: and how different would that be from HLQRY-2?
|
14:36:50
|
<dkayiwa_> !ticket HLQRY-2
|
14:36:51
|
<OpenMRSBot> dkayiwa_: [#HLQRY-2] Validate the template xml on-save via pseudo parsing through HAPI - OpenMRS JIRA - https://tickets.openmrs.org/browse/HLQRY-2
|
14:37:59
|
<rafa> bwolfe: https://tickets.openmrs.org/browse/TRUNK-3676 see commits, is it what you meant?
|
14:40:50
|
<dkayiwa_> hi suranga
|
14:41:08
|
<dkayiwa_> suranga: here is the output with one grouped obs:
|
14:41:09
|
<dkayiwa_> MSH|^~\&||OPENMRS|||20120810182315||ORU^R01^ORU_R01|5cdd271b-7402-47d6-a08a-333b1155042e|D^C|2.5^RWA|||||||||CLSM_V0.83 PID|1||444^^^^Old Identification Number||ObsGroup^Suranga^Catherine PV1||0|c0937d4f-1691-11df-97a5-7038c432aabf^^^Mosoriot Hospital|ADULTINITIAL|||dd552fc1-1691-11df-97a5-7038c432aabf^User^Super^^^^^^^^^^NID|||||||||||||||||||||||||||||||||||||20120810000000 OBR|0|||1238^MEDICAL RECORD
|
14:41:09
|
<dkayiwa_> OBSERVATIONS^TEST-IMPLEMENTATION||||||||||||||0|||||||||||^&&732ecb92-5acb-4e48-bb01-50594d13d859 OBR|1|||6105^GROUPED OBS^TEST-IMPLEMENTATION||||||||||||||0|||||||||||^&&732ecb92-5acb-4e48-bb01-50594d13d859 OBX|1|NM|5089^WEIGHT (KG)^TEST-IMPLEMENTATION||41.6|kg^^UCUM||||||||20120810182251
|
14:42:37
|
*** suranga has quit IRC
|
14:44:47
|
*** jordank has joined #openmrs
|
14:46:34
|
*** rram_ has quit IRC
|
14:55:21
|
<rafa> bwolfe: should I update bundled modules in all maintenance releases?
|
14:57:24
|
<rafa> djazayeri: ^
|
14:59:43
|
<rafa> djazayeri: I mean 1.8.4 and 1.9.1
|
15:00:04
|
<rafa> djazayeri: 1.6.6 and 1.7.4 don't come with anything more than logic, right?
|
15:04:42
|
<djazayeri> rafa: I thought we hand bundled stuff
|
15:05:35
|
<djazayeri> rafa: I though we did have bundled stuff in 1.6 and 1.7
|
15:05:54
|
<djazayeri> rafa: I think you should look at the released notes pages, rather than the code
|
15:06:02
|
<rafa> djazayeri: there's nothing in tags
|
15:06:08
|
<rafa> djazayeri: I see
|
15:06:53
|
<djazayeri> rafa: you actually need to ask the module owners about stable versions
|
15:07:51
|
<rafa> djazayeri: ok so I see some modules are bundled with 1.7.3
|
15:07:53
|
<rafa> djazayeri: https://wiki.openmrs.org/display/RES/Release+Notes+1.7.3
|
15:08:08
|
<rafa> djazayeri: are they intentionally not committed to svn?
|
15:08:15
|
<djazayeri> rafa: I think so
|
15:08:31
|
<djazayeri> rafa: I think it was intentinoal
|
15:08:57
|
<djazayeri> rafa: see https://tickets.openmrs.org/browse/TRUNK-3671 and https://tickets.openmrs.org/browse/TRUNK-36712
|
15:08:57
|
<rafa> djazayeri: https://wiki.openmrs.org/display/docs/Release+Process says to put them in snv
|
15:09:18
|
<djazayeri> rafa: we're about to change that process, but I guess for now you can use the old process still.
|
15:10:00
|
<djazayeri> rafa: so I guess you can put them in svn for now.
|
15:10:07
|
<djazayeri> bwolfe: waiting for you on phone call
|
15:10:26
|
<rafa> djazayeri: ok
|
15:12:55
|
<djazayeri> rafa: I'm on the phone with burke, slight change of plans:
|
15:12:55
|
<judygichoya> dkayiwa_ can you make table in the forms module?
|
15:13:24
|
<rafa> djazayeri: yes?
|
15:14:45
|
<djazayeri> rafa: for all of these versions (1.9.1, 1.8.whatever, 1.7.4, 1.6.6) do _not_ include any bundled modules in the WAR.
|
15:14:51
|
<djazayeri> rafa: but do include them in the standalone
|
15:14:56
|
<dkayiwa_> judygichoya: like what kind of table?
|
15:14:58
|
<djazayeri> rafa: (but do include logic)
|
15:15:21
|
<judygichoya> table format for data entryâ¦.on a form...
|
15:15:31
|
<djazayeri> rafa: i.e. the WAR distribution should be "clean", but the standalone distribution has extra features.
|
15:15:55
|
<rafa> djazayeri: ok, so the way to go is to claim that TRUNK-3671 and back port remove omods except for logic from svn
|
15:16:41
|
<rafa> djazayeri: then just add an ability to bundle them with standalone
|
15:16:47
|
<rafa> djazayeri: for now I'll do it manually
|
15:16:56
|
<djazayeri> rafa: do it the easiest way for now.
|
15:17:46
|
<rafa> djazayeri: cool
|
15:23:29
|
<dkayiwa_> judygichoya: i did not know that you had responded because you did not include my name :)
|
15:23:45
|
<dkayiwa_> judygichoya: yes you can do tables in the htmlformentry module
|
15:24:15
|
<judygichoya> not in xforms dkayiwa
|
15:24:26
|
<dkayiwa_> judygichoya: not at the moment
|
15:24:28
|
<judygichoya> i just need to confirm this for soemone
|
15:25:01
|
<dkayiwa_> judygichoya: so you now have the answer :)
|
15:25:11
|
<judygichoya> ndio
|
15:25:52
|
*** dkayiwa_ has left #openmrs
|
15:30:06
|
*** harshadura has joined #openmrs
|
15:34:52
|
*** harshadura has quit IRC
|
15:38:06
|
*** sunbiz has left #openmrs
|
15:40:04
|
*** sunbiz has joined #openmrs
|
15:40:04
|
*** ChanServ sets mode: +v sunbiz
|
16:06:39
|
*** rram_ has joined #openmrs
|
16:15:35
|
*** judygichoya has quit IRC
|
16:26:48
|
* rfriedman is wasting time
|
16:27:20
|
<djazayeri> rfriedman: want to read an hl7 integration manual, and summarize it for me?
|
16:27:22
|
<djazayeri> That would continue to waste your time, but would be good for me. :-)
|
16:27:53
|
<djazayeri> j/k, gotta run
|
16:39:23
|
*** goutham has joined #openmrs
|
16:54:27
|
*** suranga has joined #openmrs
|
16:54:27
|
*** ChanServ sets mode: +v suranga
|
16:58:08
|
<suranga> bwolfe, hi, im back....
|
17:00:00
|
<bwolfe> hi suranga
|
17:00:33
|
<suranga> bwolfe, sorr, I had to go offf earlier.. it was something really importaint :-(
|
17:01:06
|
<suranga> bwolfe, we have a basic working version of our module up and running now...
|
17:01:08
|
<bwolfe> np
|
17:01:10
|
<bwolfe> nice
|
17:01:12
|
<bwolfe> !
|
17:02:05
|
<suranga> bwolfe, i think now we need to start thinking about wrapping up the sprint ?
|
17:02:21
|
<bwolfe> suranga, yes.
|
17:02:25
|
<suranga> bwolfe, making a release, mailing people, etc ?
|
17:02:25
|
<bwolfe> look for open pull requests
|
17:02:28
|
<bwolfe> look fro open tickets
|
17:02:31
|
<bwolfe> make sure changes are done
|
17:02:42
|
<bwolfe> if not, document them, make sure they are not overly important, etc
|
17:03:06
|
<bwolfe> suranga, I just reviewed daniel's latest pull request. some major bugs tehre
|
17:03:10
|
<bwolfe> (easy to fix, but major)
|
17:03:23
|
<suranga> bwolfe, so if a change is pending, I mark it, and the ticket is not closed.. the assumption is someone will pick up on it later ?
|
17:03:35
|
<suranga> bwolfe, ooopps... have you noted them down ?
|
17:03:59
|
<bwolfe> you should review everything committed (all pull requests) and all post-commit review tickets to make sure you have seen/reviewed it all
|
17:04:09
|
<bwolfe> if you can close pull requests and tickets, great, do that
|
17:04:14
|
<bwolfe> but I know there are fixes that are needed
|
17:04:30
|
<bwolfe> if there are just cosmetic fixes, you can leave the ticket open (perhaps unassign the dev)
|
17:04:44
|
<bwolfe> FYI: daniel is now offline for 24 hours due to religious reasons
|
17:05:01
|
*** rram_ has quit IRC
|
17:05:55
|
*** pushkar has quit IRC
|
17:08:27
|
<suranga> ah, I see bwolfe , will do that :):)
|
17:11:33
|
<bwolfe> ok, off for a while. send me an email if you have questions suranga
|
17:11:50
|
<suranga> bwolfe, ah, I see. will do that :):)
|
17:13:11
|
*** bwolfe has quit IRC
|
17:21:45
|
*** kavuri has joined #openmrs
|
17:22:59
|
*** harshadura has joined #openmrs
|
17:24:33
|
*** goutham has quit IRC
|
17:25:21
|
*** goutham has joined #openmrs
|
17:26:22
|
*** jordank has quit IRC
|
17:32:16
|
*** lakkarau has joined #openmrs
|
17:51:08
|
<rfriedman> djazayeri, sure, e-mail it to r dot friedman at mindspring dot com
|
17:51:31
|
*** rfriedman has quit IRC
|
17:54:08
|
*** kreddy has joined #openmrs
|
17:59:12
|
*** bwolfe has joined #openmrs
|
17:59:12
|
*** ChanServ sets mode: +o bwolfe
|
18:00:13
|
*** djazayeri1 has joined #openmrs
|
18:02:07
|
*** djazayeri has quit IRC
|
18:04:07
|
*** lh has quit IRC
|
18:16:10
|
<lakkarau> bwolfe:hi
|
18:16:25
|
<bwolfe> hi lakkarau
|
18:16:51
|
<lakkarau> bwolfe: i have coded the hl7settingcontroller but not able to view the page
|
18:17:34
|
<bwolfe> what do you see instead?
|
18:19:48
|
<lakkarau> bwolfe:i dont even see the link to my page
|
18:20:47
|
<lakkarau> i added it in the Adminlist.java
|
18:21:49
|
<bwolfe> ok
|
18:21:56
|
<bwolfe> pastebin your adminlist
|
18:22:04
|
<bwolfe> and did you recompile your omod and reload it into the app?>
|
18:22:09
|
<bwolfe> which page are you not seeing it on?>
|
18:22:22
|
<bwolfe> I need a lot more details to help you debug! :-)
|
18:24:06
|
<lakkarau> sorry ben pastebin does not work on my system i tryed it a lot of times
|
18:24:34
|
<lakkarau> bwolfe :can i push the code so that you can have a look at it
|
18:24:35
|
<bwolfe> pastebin.com ?
|
18:24:53
|
<bwolfe> lakkarau, thats fine to. push to github and then link me to the file.
|
18:25:01
|
<bwolfe> lakkarau, how does pastebin.com not work on your system?
|
18:25:27
|
<lakkarau> bwolfe :i did not reload in to the app,think that is the problem
|
18:29:45
|
<lakkarau> bwolfe:paste bin is working now it does not work on ie recently started working on firefox .i will past it
|
18:31:06
|
<bwolfe> if its working for you now there is no reason to paste it
|
18:35:05
|
<lakkarau> bwolfe: ok
|
18:43:34
|
*** james_regen has left #openmrs
|
18:47:07
|
*** harshadura has quit IRC
|
18:51:36
|
*** djazayeri1 is now known as djazayeri
|
18:51:37
|
*** ChanServ sets mode: +o djazayeri
|
18:59:07
|
*** sunbiz has quit IRC
|
19:05:14
|
<lakkarau> bwolfe:There was an error starting the module: HL7 Query ('Reading' this alert 'reads' it for all recipients)
|
19:07:14
|
*** bwolfe has quit IRC
|
19:39:36
|
*** kavuri has quit IRC
|
19:46:17
|
*** sunbiz has joined #openmrs
|
19:46:17
|
*** ChanServ sets mode: +v sunbiz
|
19:52:13
|
*** sunbiz has quit IRC
|
19:52:45
|
*** maurya has quit IRC
|
19:55:05
|
*** shortend has left #openmrs
|
20:00:52
|
*** djazayeri1 has joined #openmrs
|
20:03:32
|
*** djazayeri has quit IRC
|
20:05:07
|
*** djazayeri1 has quit IRC
|
20:13:59
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting 0.7.2 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=reporting&version=&0.7.2> || OpenMRS Modules: Serialization Xstream 0.2.7 uploaded to OpenMRS Module Repository <https://dev.openmrs.org/modules/view.jsp?module=serialization.xstream&version=&0.2.7>
|
20:15:10
|
*** suranga has quit IRC
|
20:37:51
|
*** jkeiper_ has quit IRC
|
20:57:53
|
*** jordank has joined #openmrs
|
20:59:56
|
*** goutham has quit IRC
|
21:13:12
|
*** rfriedman has joined #openmrs
|
21:13:47
|
*** rfriedman is now known as rfriedman_away
|
21:15:19
|
*** rafa has quit IRC
|
21:25:03
|
*** snoppy has left #openmrs
|
22:26:08
|
*** downey has quit IRC
|
23:02:18
|
*** mseaton has joined #openmrs
|
23:02:18
|
*** ChanServ sets mode: +v mseaton
|
23:02:21
|
*** mseaton has left #openmrs
|
23:04:44
|
*** jkeiper_ has joined #openmrs
|
23:06:10
|
*** kreddy has quit IRC
|
23:08:52
|
*** jkeiper_ has quit IRC
|
23:09:18
|
*** lakkarau has quit IRC
|
23:09:21
|
*** jkeiper_ has joined #openmrs
|
23:19:52
|
*** jkeiper__ has joined #openmrs
|
23:23:19
|
*** jkeiper_ has quit IRC
|
23:43:04
|
*** jkeiper__ has quit IRC
|
23:43:30
|
*** jkeiper__ has joined #openmrs
|